id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
210,958,130 | go | x/crypto/ssh: add support for alive interval | When the underlying TCP connection for a long-standing SSH connection abruptly dies, operations on an `ssh.Client` can hang forever. This is because the client remains [stuck in an `io.ReadFull` call](https://github.com/golang/crypto/blob/84bacda6ede319f5074d43b5d096b7ee7f3f5d77/ssh/cipher.go#L150) with no preceding or concurrent calls to `net.Conn.SetDeadline`. Without any deadline set, there is no guarantee that `Read` will ever return.
Even though the user has access the underlying `net.Conn` and can set the deadline themselves, they have no way of determining if the underlying connection is actually dead or just idle. Thus, the `ssh` package should support this functionality that allows sending of empty messages to intentionally invoke a response from the remote endpoint, in order to determine if it is still alive.
This is a feature request for the [equivalent options for OpenSSH](http://man.openbsd.org/ssh_config.5):
* `AliveInterval time.Duration`: Sets a timeout interval after which, if no data has been received, sends an alive message through the encrypted channel to invoke a response from the remote end. The default is 0, indicating that such messages will not be sent.
* `AliveCountMax int`: Sets the number of alive messages which may be sent without receiving a response from the remote end. If this threshold is reached while alive messages are being sent, the SSH session will be terminated.
If this is reasonable, I can implement this. | NeedsInvestigation,FeatureRequest | medium | Major |
211,015,561 | vscode | Add option to always show word based suggestions | - VSCode Version: 1.9.1
Steps to Reproduce:
1. Go to an empty TypeScript file
2. Enter `fooBarBaz`
3. Enter a new line and then type `fooBa`
Expected result: word based quick suggestions should show.
Actual result: no quick suggestions. Ctrl+space shows a popup with content 'No suggestions'.
Try the same in a JavaScript file and it works.
I would like IntelliSense and word based suggestions for my TypeScript.
| feature-request,suggest | high | Critical |
211,064,273 | opencv | Uniform empty image handling | **Vote**: Please use GitHub emoji/reaction for next two comments below to provide your opinion.
As suggested by @sovrasov in PR #8288 we definitely need to unify the way that empty images are handled inside the imgproc module.
- :one: OPTION 1: generate an assertion (exception) from the moment an empty input is given
- :two: OPTION 2: do not fail, just silently copy with empty data and make output also empty
The second option will require the user to do all the checking on data validity himself.
---
**Update 2020-03-01**: option 1 - 15, option 2 - 5
**Update 2020-04-30**: option 1 - 16, option 2 - 6 | future,vote | low | Major |
211,161,812 | rust | Tracking issue for the `x86-interrupt` calling convention | ## Overview
Tracking issue for the `x86-interrupt` calling convention, which was added in PR #39832. The feature gate name is `abi_x86_interrupt`. This feature will not be considered for stabilization without an RFC.
The `x86-interrupt` calling convention can be used for defining interrupt handlers on 32-bit and 64-bit x86 targets. The compiler then uses `iret` instead of `ret` for returning and ensures that all registers are restored to their original values.
### Usage
```rust
extern "x86-interrupt" fn handler(stack_frame: ExceptionStackFrame) {…}
```
for interrupts and exceptions without error code and
```rust
extern "x86-interrupt" fn handler_with_err_code(stack_frame: ExceptionStackFrame,
error_code: u64) {…}
```
for exceptions that push an error code (e.g., page faults or general protection faults). The programmer must ensure that the correct version is used for each interrupt.
For more details see the [LLVM PR][1], and the corresponding [proposal][2].
[1]: https://reviews.llvm.org/D15567
[2]: http://lists.llvm.org/pipermail/cfe-dev/2015-September/045171.html
## Known issues
- [x] An earlier version of this description stated that the `ExceptionStackFrame` is passed by reference (instead of by value). This used to work on older LLVM version, but no longer works on LLVM 12. See https://github.com/rust-lang/rust/issues/40180#issuecomment-814270159 for more details.
- [ ] LLVM **doesn't preserve MMX and x87 floating point registers** across interrupts. This issue was reported in https://github.com/llvm/llvm-project/issues/26785.
- [x] _(fixed)_ x86-interrupt calling convention leads to **wrong error code** in debug mode (#57270)
- https://github.com/rust-lang/rust/labels/F-abi_x86_interrupt currently shows:
- [ ] https://github.com/rust-lang/rust/issues/63018
- [ ] https://github.com/rust-lang/rust/issues/124806
- [ ] https://github.com/rust-lang/rust/issues/126418
- [ ] https://github.com/rust-lang/rust/issues/132834
- [ ] https://github.com/rust-lang/rust/issues/132835
- [ ] https://github.com/rust-lang/rust/issues/132841
### 64-bit
- [x] The x86_64 automatically aligns the stack on a 16-byte boundary when an interrupts occurs in 64-bit mode. However, the CPU pushes an 8-byte error code for some exceptions, which destroys the 16-byte alignment. At the moment, LLVM doesn't handle this case correctly and always assumes a 16-byte alignment. This leads to **alignment issues on targets with SSE support**, since LLVM uses misaligned [`movaps`](http://x86.renejeschke.de/html/file_module_x86_id_180.html) instructions for saving the `xmm` registers. This issue is tracked as [bug 26413](https://bugs.llvm.org//show_bug.cgi?id=26413).
_A fix for this problem was submitted in [D30049](https://reviews.llvm.org/D30049) and merged in [rL299383](https://reviews.llvm.org/rL299383)._
- [x] LLVM always tries to backup the `xmm` registers on 64-bit platforms even if the target doesn't support SSE. This leads to invalid opcode exceptions whenever an interrupt handler is invoked.
_The fix was merged to LLVM trunk in [rL295347](https://reviews.llvm.org/rL295347). Backported in rust-lang/llvm#63._
- [ ] https://github.com/llvm/llvm-project/issues/41189
### 32-bit
- [ ] In 32-bit mode, the CPU performs no stack alignment on interrupts. Thus, the interrupt handler should perform a dynamic stack alignment (i.e. `and esp, 16`). However, LLVM doesn't do that at the moment, which might lead to **alignment errors**, especially for targets with SSE support. This issue is tracked in https://github.com/llvm/llvm-project/issues/26851. | T-lang,B-unstable,C-tracking-issue,S-tracking-needs-summary,F-abi_x86_interrupt,A-hardware-interrupts | medium | Critical |
211,173,189 | neovim | API/UI: externalize dialogs | https://github.com/onivim/oni/issues/264#issuecomment-283428670
Add a new "dialog" event so that its UI can be externalized. | enhancement,api,ui,channels-rpc,ui-extensibility | low | Major |
211,194,920 | angular | ContentChildren doesn't get children created with NgTemplateOutlet | Original title: *ViewChildren doesn't get children created with NgTemplateOutlet*
**Please see comments below...**
**I'm submitting a ...**
```
[x] bug report
```
**Current behavior**
When you use ngTemplateOutlet to render a template passing by input property ViewChildren don't get or don't find in the redered elements.
**Expected behavior**
I think ViewChildren should get the elements rendered by ngTemplateOutlet.
**Minimal reproduction of the problem with instructions**
In this [plunkr](https://plnkr.co/edit/BHZHcVKuhoP8OzQHIxAR?p=info), on app.ts file, you can see a `Child` component and a `Parent` component, Parent component has an input property called `template1`, this accept a TemplateRef that is rendered using ngTemplateOutlet. `Parent` component has a `ViewChildren` collection to get the `Child` components and shows the length of this collection in the end of template.
Well, using this component this way:
```` html
<ng-template #template1>
<child></child>
<child></child>
</ng-template>
<parent [template1]="template1"></parent>
````
The `Parent` component render the two `Child` components but the length of ViewChildren collection is 0. You can uncomment the line 16 of app.ts file to include a static `<child/>` component in the `Parent` template. Then the collection length is 1.
**What is the motivation / use case for changing the behavior?**
It's would be very useful to pass template to components, rows of grids, lines of lists, ...
In the other hand I have this [plunkr](https://plnkr.co/edit/wFvjrJjNYBLx5sYnJRhm?p=preview) in this case I am rendering `Child` components using a `ngFor`, ViewChildren works fine.
Since both, ngTemplateOutlet and ngForOf, using `viewContainerRef.createEmbeddedView` to render the templates ... why works with ngFor and not with ngTemplateOutlet?
I think that the only reason is that `Child` components come from different component context, but I would like to know it.
**Please tell us about your environment:**
Windows 10, VisualStudioCode, npm, lite-server
* **Angular version:** 4.0.0-rc2
* **Browser:** [all]
* **Language:** [TypeScript 2.2.1]
| area: core,core: queries,type: use-case,P3 | high | Critical |
211,196,392 | flutter | VM service should accept URIs instead of file paths for hot reload | Do be truly portable, the following calls should accept real platform-independent URIs (instead of platform-specific file paths) on the remote (VM) side:
* https://github.com/flutter/flutter/blob/17057bb44b7c10b2b4603cd09b266d9379f65ba2/packages/flutter_tools/lib/src/devfs.dart#L203
* https://github.com/flutter/flutter/blob/17057bb44b7c10b2b4603cd09b266d9379f65ba2/packages/flutter_tools/lib/src/devfs.dart#L273
* https://github.com/flutter/flutter/blob/17057bb44b7c10b2b4603cd09b266d9379f65ba2/packages/flutter_tools/lib/src/vmservice.dart#L850
* https://github.com/flutter/flutter/blob/17057bb44b7c10b2b4603cd09b266d9379f65ba2/packages/flutter_tools/lib/src/vmservice.dart#L853
* https://github.com/goderbauer/flutter/blob/b8a53749c1bd542e4c5588c332e01e2a8790f852/packages/flutter_tools/lib/src/vmservice.dart#L717 | team,tool,P3,team-tool,triaged-tool | low | Major |
211,243,578 | rust | consolidate recursion limit errors | They should all have an error code and maybe a helper function to create the suggestion message.
cc @nikomatsakis #39655 | C-cleanup,A-diagnostics,T-compiler | low | Critical |
211,251,675 | TypeScript | Optional Generic Type Inference | #13487 added default generic types, but it's still not possible to infer a generic type:
```ts
type Return<T extends () => S, S = any> = S
```
Here `S` takes its default type `any`, but `T` could permit inference of a subset type of `any` for `S`:
```ts
const Hello = () => 'World'
type HelloReturn = Return<typeof Hello> // any
```
Here `HelloReturn` still has `any` type, and TypeScript could infer `S` as the literal type `'World'`, which is a subset of `any`.
## Use Case
Here's an example of a fully declarative workaround for #6606, using generic type inference:
```ts
type Return<T extends () => S, S = any> = S
```
```ts
const Hello = () => 'World'
type HelloReturn = Return<typeof Hello> // 'World'
```
## Default Type
If return of `T` is not a subset of `S`, it should throw an error:
```ts
type ReturnString<T extends () => S, S = string> = S
```
```ts
const Hello = () => 'World'
type HelloReturn = ReturnString<typeof Hello> // 'World'
```
```ts
const calculateMeaningOfLife = () => 42
type MeaningOfLife = ReturnString<typeof calculateMeaningOfLife> // ERROR: T should return a subset of String
```
## Multiple Possible Type Inferences
The current implementation always returns the superset (which is just the default generic type), solving this issue would require to return the subset (the most precise type of all the inferred possibilities).
If a type has multiple possible type inferences, TypeScript should check that all these types **are not disjoint**, and that they all are subsets of the Default Generic Type.
The inferred type is the most precise subset. | Suggestion,In Discussion | high | Critical |
211,294,502 | youtube-dl | Unable to download from http://oscar.go.com/video/... | Example:
$ youtube-dl -v http://oscar.go.com/video/oscar-highlights-2017/seth-rogen-and-michael-j-fox-go-back-to-the-future
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://oscar.go.com/video/oscar-highlights-2017/seth-rogen-and-michael-j-fox-go-back-to-the-future']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.02.28
[debug] Python version 3.4.2 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.7
[debug] exe versions: ffmpeg 3.2.4-1, ffprobe 3.2.4-1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] seth-rogen-and-michael-j-fox-go-back-to-the-future: Requesting header
WARNING: Falling back on generic information extractor.
[generic] seth-rogen-and-michael-j-fox-go-back-to-the-future: Downloading webpage
[generic] seth-rogen-and-michael-j-fox-go-back-to-the-future: Extracting information
ERROR: Unsupported URL: http://oscar.go.com/video/oscar-highlights-2017/seth-rogen-and-michael-j-fox-go-back-to-the-future
Traceback (most recent call last):
File "/home/ant/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 761, in extract_info
ie_result = ie.extract(url)
File "/home/ant/bin/youtube-dl/youtube_dl/extractor/common.py", line 427, in extract
ie_result = self._real_extract(url)
File "/home/ant/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2604, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: http://oscar.go.com/video/oscar-highlights-2017/seth-rogen-and-michael-j-fox-go-back-to-the-future
Thank you in advance. :) | geo-restricted | low | Critical |
211,384,679 | rust | Lifetime inference falls over with identical lifetimes across trait and implementing struct | I tried to write this code:
```
fn main() {
let a = XImpl {};
foo(&a);
}
fn foo(x: &X) {
x.bar();
}
pub trait X<'a> {
fn bar(&'a self);
}
pub struct XImpl {}
impl<'a> X<'a> for XImpl {
fn bar(&'a self) {}
}
```
I think this should compile, but it fails with: [https://gist.github.com/buntpfotenkatze/073cc5d65bdbd0e87b202cfe6013d39c](https://gist.github.com/buntpfotenkatze/073cc5d65bdbd0e87b202cfe6013d39c)
Replacing `fn foo(x: &X)` with `fn foo<'a>(x: &'a X<'a>)` fixes it, but I think the compiler should be able to deduce that the two lifetimes of x are identical.
Edit:
[code updated to 2021 ed](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=335c08261b255849fe730f66be260416)
current error:
```
error: lifetime may not live long enough
--> src/main.rs:6:5
|
5 | fn foo(x: &dyn X) {
| - - let's call the lifetime of this reference `'1`
| |
| has type `&dyn X<'2>`
6 | x.bar();
| ^^^^^^^ argument requires that `'1` must outlive `'2`
error: could not compile `playground` (bin "playground") due to previous error
``` | A-lifetimes,A-inference,C-bug | low | Critical |
211,402,219 | flutter | Android Studio Layout Editor has problems with FlutterView | An exception is displayed in the Layout Editor in Android Studio when choosing the design tab and a FlutterView is used in a layout file for example like this:
```xml
<?xml version="1.0" encoding="utf-8"?>
<LinearLayout xmlns:android="http://schemas.android.com/apk/res/android"
android:orientation="vertical"
android:layout_width="match_parent"
android:layout_height="match_parent">
<io.flutter.view.FlutterView
android:id="@+id/flutter_view"
android:layout_width="match_parent"
android:layout_height="match_parent"
/>
</LinearLayout>
```
It says:
```
Rendering Problems
The following classes could not be instantiated:
- io.flutter.view.FlutterView (Open Class, Show Exception, Clear Cache)
Tip: Use View.isInEditMode() in your custom views to skip code or show sample data when shown in the IDE. If this is an unexpected error you can also try to build the project, then manually refresh the layout. Exception Details java.lang.ClassNotFoundException: org.json.JSONException Copy stack to clipboard
Clicking on 'show Exception' it shows this stacktrace:
java.lang.ClassNotFoundException: org.json.JSONException
at org.jetbrains.android.uipreview.ModuleClassLoader.load(ModuleClassLoader.java:160)
at com.android.tools.idea.rendering.RenderClassLoader.findClass(RenderClassLoader.java:54)
at org.jetbrains.android.uipreview.ModuleClassLoader.findClass(ModuleClassLoader.java:90)
at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
at org.jetbrains.android.uipreview.ModuleClassLoader.loadClass(ModuleClassLoader.java:193)
at java.lang.Class.getDeclaredConstructors0(Native Method)
at java.lang.Class.privateGetDeclaredConstructors(Class.java:2673)
at java.lang.Class.getConstructor0(Class.java:3077)
at java.lang.Class.getConstructor(Class.java:1827)
at org.jetbrains.android.uipreview.ViewLoader.createNewInstance(ViewLoader.java:396)
at org.jetbrains.android.uipreview.ViewLoader.loadClass(ViewLoader.java:172)
at org.jetbrains.android.uipreview.ViewLoader.loadView(ViewLoader.java:105)
at com.android.tools.idea.rendering.LayoutlibCallbackImpl.loadView(LayoutlibCallbackImpl.java:186)
at android.view.BridgeInflater.loadCustomView(BridgeInflater.java:334)
at android.view.BridgeInflater.loadCustomView(BridgeInflater.java:345)
at android.view.BridgeInflater.createViewFromTag(BridgeInflater.java:245)
at android.view.LayoutInflater.createViewFromTag(LayoutInflater.java:727)
at android.view.LayoutInflater.rInflate_Original(LayoutInflater.java:858)
at android.view.LayoutInflater_Delegate.rInflate(LayoutInflater_Delegate.java:70)
at android.view.LayoutInflater.rInflate(LayoutInflater.java:834)
at android.view.LayoutInflater.rInflateChildren(LayoutInflater.java:821)
at android.view.LayoutInflater.inflate(LayoutInflater.java:518)
at android.view.LayoutInflater.inflate(LayoutInflater.java:397)
at com.android.layoutlib.bridge.impl.RenderSessionImpl.inflate(RenderSessionImpl.java:324)
at com.android.layoutlib.bridge.Bridge.createSession(Bridge.java:429)
at com.android.ide.common.rendering.LayoutLibrary.createSession(LayoutLibrary.java:389)
at com.android.tools.idea.rendering.RenderTask$2.compute(RenderTask.java:548)
at com.android.tools.idea.rendering.RenderTask$2.compute(RenderTask.java:533)
at com.intellij.openapi.application.impl.ApplicationImpl.runReadAction(ApplicationImpl.java:966)
at com.android.tools.idea.rendering.RenderTask.createRenderSession(RenderTask.java:533)
at com.android.tools.idea.rendering.RenderTask.lambda$inflate$72(RenderTask.java:659)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)
``` | platform-android,P3,team-android,triaged-android | low | Critical |
211,424,615 | angular | State transition animations are canceled when the state changes, even though no transition is defined (e.g. with '*' transitions) or the state is identical. | **I'm submitting a ...**
```
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see
```
**Current behavior**
State transition animations are canceled when the state changes to one with an identical style.
This could perhaps be as designed/intended behavior and should be a feature request?
**Expected behavior**
If the state has an identical style, the existing animation should continue.
**Minimal reproduction of the problem with instructions**
https://plnkr.co/edit/eP1lax?p=preview
**What is the motivation / use case for changing the behavior?**
This allows more complex state change animations driven from a single state variable. For example if an application has the following states:
initialized, loading, loaded, updating, failed
You can animate your component to appear after initialized, say the state changes to "loading":
state('initialized', style({transform: 'scale(0)'})),
state('loading, loaded, updating, failed', style({transform: 'scale(1)'})),
transition('* => initialized', animate('2000ms')),
transition('initialized=> *', animate('2000ms'))
but if you're server is quicker than the animation, and the loading is complete, your state changes to "loaded", and even though there should be no transition or new animation (due to the '*' notation) the current animation is canceled abruptly.
**Please tell us about your environment:**
* **Angular version:** 2.4.8 and 4.0.0-rc.1
* **Browser:** all (Assumption, only tested on chrome)
* **Language:** all (Assumption. Only tested with typescript)
* **Node (for AoT issues):** n/a
| type: bug/fix,area: animations,freq1: low,P4 | low | Critical |
211,446,498 | TypeScript | Cannot Optionalize Class Getters | **TypeScript Version:** 2.2.1
**Code**
```ts
class Person {
firstName: string;
lastName: string;
get fullName?() {
return this.firstName + ' ' + this.lastName;
}
}
```
**Expected behavior:**
Since `fullName` is optional the following should work:
```
const Me: Person = {
firstName: 'Foo',
lastName: 'Bar'
}
```
**Actual behavior:**
A syntax error occurs on this line `get fullName?() {`
I'm not sure if omitting the ability to optionalize getters was by design or not. If it was by design, I'd love to know the reasoning behind it. | Suggestion,In Discussion | high | Critical |
211,460,832 | TypeScript | Plugin Support for Custom Transformers | Since #13764 has landed, it's easy to write custom transformers. However, if I understand the API correctly, it is needed to duplicate the whole tsc command line just to add a single transformer. This leads to incompatibilities since these, on typescript depending, applications do not support the same features as the tsc command line tool.
It, therefore, would be favored to have a plugin system that allows loading Custom Transformers from third party node modules as this is the case for the language service proxies #12231. These transformers then easily integrate into existing build tools / build workflows.
If someone experienced has inputs on how to implement the changes, I'm willing to create a PR as it would simplify my project tremendously. | Docs | high | Critical |
211,541,702 | vscode | Feature Request: Support for private marketplace/gallery | We have created several VSIX extension that have no use to anybody else except our company. We would like to host our own private extension gallery and have an ability to specify alternative extension gallery paths (like "Additional Extension Galleries" in Visual Studio 2015).
- VSCode Version: 1.10.1
- OS Version: Windows 10
| feature-request,upstream,marketplace,upstream-issue-linked | high | Critical |
211,665,186 | go | cmd/compile: an FSM with ~40k states takes a lot of memory to build | ### What version of Go are you using (`go version`)?
go version go1.8 linux/amd64
### What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/opennota/gocode"
GORACE=""
GOROOT="/home/opennota/go"
GOTOOLDIR="/home/opennota/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build723393668=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
### What did you do?
I tried to build `x.go` from here: https://github.com/opennota/x . It is a 3.3 MB / 230 kLOC file containing an autogenerated finite state machine with about 40k states.
### What did you expect to see?
The build is completed in a matter of seconds (there's no cgo, after all).
### What did you see instead?
The build takes a goodish while and slowly consumes all the available memory. Actually, despite having 8 GB of memory I wasn't able to build the package.
With Go 1.7.3 the memory usage is stable (not increasing), but again, the build is a way too slow. | ToolSpeed,compiler/runtime | low | Critical |
211,705,128 | vscode | Outline matching selections instead of highlight | <!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode -->
- VSCode Version: 1.10.1
- OS Version: macOS 10.12.2
Steps to Reproduce:
1. Highlight a selection with multiple instances.
2. Look how hard it is to distinguish which instance is selected.
There are three fundamental issues that this request entails:
1. When you make a selection and there are multiple instances, it's extremely hard to distinguish which one is actually selected. This image shows VSCode's standard Monokai theme. This is not a "theme" issue, users should be able to use any theme that is available in the marketplace.
2. When you make a selection, matching instances shouldn't be highlighted at all. Being highlighted indicates that they are also selected, which is not the case. So when I double click on a single word to select it, all the matching instances get highlighted too, creating the appearance that they are all selected.
3. The check that looks for matching instances should be _case sensitive_, so that when I select `contract`, a camel-case instance of `newContract` should not have that instance of contract highlighted. | feature-request,ux,editor-theming,editor-highlight | medium | Critical |
211,743,673 | rust | 1.15.1 (and earlier) armhf nondeterministically uses locking to implement atomic instructions when cross-compiling to x64 but not x86 | This was originally reported over at #33809 with the full build log [here](https://gist.github.com/mmatyas/b775b83908cbdfc6551ff79d8bf0b0ef) but back then I dismissed it as "just install binutils-multiarch". However, we just saw the exact same issue crop up when trying to bring rustc to Debian armhf.
Build machine: [hasse.debian.org](https://db.debian.org/machines.cgi?host=hasse)
Raw build log: https://buildd.debian.org/status/fetch.php?pkg=rustc&arch=armhf&ver=1.15.1%2Bdfsg1-1%7Eexp2&stamp=1488549003&raw=1
The relevant part is here, visible in both build logs:
~~~~
error: make failed
status: exit code: 2
command: "make"
stdout:
------------------------------------------
make[3]: Entering directory '/«BUILDDIR»/rustc-1.15.1+dfsg1/src/test/run-make/atomic-lock-free'
LD_LIBRARY_PATH="[..]" '[..]/rustc' [..] -C link-args=-Wl,-z,relro --target=i686-unknown-linux-gnu atomic_lock_free.rs
nm "[..]/libatomic_lock_free.rlib" | grep -vq __atomic_fetch_add
LD_LIBRARY_PATH="[..]" '[..]/rustc' [..] -C link-args=-Wl,-z,relro --target=x86_64-unknown-linux-gnu atomic_lock_free.rs
nm "[..]/libatomic_lock_free.rlib" | grep -vq __atomic_fetch_add
Makefile:9: recipe for target 'all' failed
make[3]: Leaving directory '/«BUILDDIR»/rustc-1.15.1+dfsg1/src/test/run-make/atomic-lock-free'
------------------------------------------
stderr:
------------------------------------------
nm: rust.metadata.bin: File format not recognized
nm: atomic_lock_free.0.bytecode.deflate: File format not recognized
nm: atomic_lock_free.0.o: File format not recognized
nm: rust.metadata.bin: File format not recognized
nm: atomic_lock_free.0.bytecode.deflate: File format not recognized
make[3]: *** [all] Error 1
~~~~
Note how, for `atomic_lock_free.0.o` for i686, `nm` complains "File format not recognized" but we get no such complaint for x86_64. This suggests that it did in fact read the file correctly, and `grep -v` is what caused `make` to fail.
However, I cannot reproduce this issue on another armhf machine, [abel.debian.org](https://db.debian.org/machines.cgi?host=abel) where this test passes.
This test also passes on all other architectures on Debian. It is very likely that all of the target architectures mentioned in `src/test/run-make/atomic-lock-free/Makefile` are being tested (on each host architecture that is running the tests), since `llvm-config --components` on Debian outputs all of the target architectures mentioned.
Arguably there is another bug here - if `nm` gives "File format not recognized" then this should fail the test, rather than causing it to pass (because `grep -v` finds nothing). | O-Arm,C-bug | low | Critical |
211,748,236 | angular | bypassSecurityTrustStyle gives error on Safari | <!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING
-->
**I'm submitting a ...** (check one with "x")
```
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
```
**Current behavior**
<!-- Describe how the bug manifests. -->
Gives an error:
```
inline template:1:28 caused by: Attempted to assign to readonly property.
```
**Expected behavior**
<!-- Describe what the behavior would be without the bug. -->
**Minimal reproduction of the problem with instructions**
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
Check out this Plunkr on **Chrome**, then check it out on **Safari**. Chrome has no error. **Safari has a bunch of errors**:
https://plnkr.co/edit/YETcOvKxhZsIbjpd3FLh?p=preview
Here is a plunkr with no error on both (I removed bypassSecurityTrustStyle in the template):
https://plnkr.co/edit/BCpyitIqIGCc44k1w9Q9?p=preview
**What is the motivation / use case for changing the behavior?**
<!-- Describe the motivation or the concrete use case -->
Because its good to have it working on both browsers
**Please tell us about your environment:**
<!-- Operating system, IDE, package manager, HTTP server, ... -->
Mac OS Latest, fully updated.
* **Angular version:** 2.4.9
<!-- Check whether this is still an issue in the most recent Angular version -->
Angular v2.4.9
* **Browser:** Safari 10.0.3
<!-- All browsers where this could be reproduced -->
* **Language:** TypeScript 2 | type: bug/fix,freq2: medium,area: core,core: sanitization,P3 | low | Critical |
211,788,970 | youtube-dl | Vimeo On Demand download not working (I get the trailer) | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.03.02**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
I'm trying to download a rented On Demand video from Vimeo, but I get the trailer, not the full movie.
In the logs I see ``WARNING: Unable to download JSON metadata: HTTP Error 403: Forbidden``, but if I try with a bad password then I get ``ERROR: Wrong login info: HTTP Error 418`` so the password is valid.
I will have access to the movie for 24h, email me at [email protected] and I can provide account credentials.
```
$ youtube-dl https://vimeo.com/ondemand/distract -u FOO -p BAR -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'https://vimeo.com/ondemand/distract', u'-u', u'PRIVATE', u'-p', u'PRIVATE', u'-v']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.03.02
[debug] Python version 2.7.13 - Darwin-16.4.0-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[vimeo:ondemand] distract: Downloading webpage
[vimeo] Logging in
[vimeo] 204148215: Downloading webpage
[vimeo] 204148215: Extracting information
[vimeo] 204148215: Downloading JSON metadata
WARNING: Unable to download JSON metadata: HTTP Error 403: Forbidden
[vimeo] 204148215: Downloading akfire_interconnect m3u8 information
[vimeo] 204148215: Downloading fastly_skyfire m3u8 information
[vimeo] 204148215: Downloading akfire_interconnect_quic MPD information
[vimeo] 204148215: Downloading akfire_interconnect_quic MPD information
[vimeo] 204148215: Downloading fastly_skyfire MPD information
[vimeo] 204148215: Downloading fastly_skyfire MPD information
[debug] Invoking downloader on u'https://skyfire.vimeocdn.com/1488575127-0xa49db4470ebb2e3dae60f04429d9095b0641fc94/204148215/video/693502553,693502569,693502568,693502562/../'
[download] Dis.Traction-204148215.mp4 has already been downloaded
[download] 100% of 17.94MiB
``` | account-needed | medium | Critical |
211,875,331 | youtube-dl | Youtube OPML subscription list support | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.03.02**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### Description of your *issue*, suggested solution and other information
Is it possible to support an OPML file downloaded manually from Youtube ?
https://www.youtube.com/subscription_manager?action_takeout=1
I would like to download the subscription list manually, and use the OPML as an input in youtube-dl, to avoid the use of argument --netrc and having to save/update my credentials in a netrc file.
Thanks | request | low | Critical |
211,897,891 | go | testing: output hard to read when a test case is stalling | When the package contains a stalling case, the verbose is hard to read to figure out what has run and not finished finished yet. I often have to pipe the output to another program to match RUNs and PASSes (or FAILs) to filter what has not finished.
We might just consider printing the currently running test cases upon SIGINT.
```
go test -v
=== RUN TestTrace
=== RUN TestTraceWithWait
--- PASS: TestTraceWithWait (0.01s)
=== RUN TestTraceFromHeader
=== RUN TestTraceFromHeaderWithWait
--- PASS: TestTraceFromHeaderWithWait (2.00s)
=== RUN TestNewSpan
--- PASS: TestNewSpan (0.01s)
=== RUN TestNoTrace
--- PASS: TestNoTrace (0.04s)
=== RUN TestNoTraceWithWait
--- PASS: TestNoTraceWithWait (0.14s)
=== RUN TestNoTraceFromHeader
--- PASS: TestNoTraceFromHeader (0.04s)
=== RUN TestNoTraceFromHeaderWithWait
--- PASS: TestNoTraceFromHeaderWithWait (0.04s)
=== RUN TestSample
--- PASS: TestSample (0.00s)
=== RUN TestSampling
=== RUN TestBundling
=== RUN TestWeights
--- PASS: TestWeights (0.02s)
=== RUN TestPropagation
--- PASS: TestPropagation (0.00s)
=== RUN TestNoTraceIncoming
--- PASS: TestNoTraceIncoming (0.00s)
--- PASS: TestSampling (1.98s)
--- PASS: TestTrace (2.00s)
--- PASS: TestTraceFromHeader (2.00s)
^Csignal: interrupt
FAIL cloud.google.com/go/trace 189.182s
``` | help wanted,NeedsInvestigation | low | Major |
211,919,550 | vue | Allow Component Tag in Transition Group | Allow this kind of feature for transition-group or transition
```html
<transition-group tag="todo-layout-container">
<!-- Which will render a component rather a tag -->
</transition-group>
```
and will compile to
```html
<todo-layout-container>
</todo-layout-container>
```
and compiles to what is inside of the todo-layout-container
```js
let Todo = Vue.extend({
name: 'todo-layout-container',
methods: {
//Per todo methods
}
});
``` | feature request,transition | low | Major |
211,925,597 | TypeScript | Can't find definition of a property on an object with an index signature. | Finding the definition for `foo.x` here works:
```
const foo = {
x: () => {
}
}
foo.x // here
```
This fails to find a definition:
```
const foo: { [key: string]: any } = {
x: () => {
}
}
foo.x // here
```
I understand in principle why this is the case, but in the second case, can't we just optimistically try the algorithm we used for the first case - and if it fails, _then_ fail to find the definition? | Bug,Help Wanted,Domain: Symbol Navigation | low | Major |
211,933,887 | youtube-dl | Tests should use a modern hash (SHA-256 instead of MD5) | `youtube-dl`'s download tests all use MD5 as a hash. While it's probably not cryptographically critical that download testing use a secure hash, the world has moved past MD5, and past SHA-1. `youtube-dl` should at least support SHA-256 in the `info_dict`, and use whichever hash has been supplied in the `_TEST`'s `info_dict`. | request | low | Minor |
211,954,024 | TypeScript | Existential type? | Here's a case where I need a few existentials. It's for a definition file, where I need to have parameters for `Binding` and `Scheduler`, but it doesn't matter to me what they are. All I care about is that they're internally correct (and `any` doesn't cover this), and I'd rather not simulate it by making the constructor unnecessarily generic.
The alternative for me is to be able to declare additional constructor-specific type parameters that don't carry to other methods, but existentials would make it easier.
```ts
export interface Scheduler<Frame, Idle> {
nextFrame(func: () => any): Frame;
cancelFrame(frame: Frame): void;
nextIdle(func: () => any): Idle;
cancelIdle(frame: Idle): void;
nextTick(func: () => any): void;
}
export interface Binding<E> extends Component {
binding: E;
patchEnd?(): void;
patchAdd?(
prev: string | E | void,
next: string | E | void,
pos: number,
): void;
patchRemove?(
prev: string | E | void,
next: string | E | void,
pos: number
): void;
patchChange?(
oldPrev: string | E | void,
newPrev: string | E | void,
oldNext: string | E | void,
newNext: string | E | void,
oldPos: number,
newPos: number
): void;
}
export class Subtree {
constructor(
onError?: (err: Error) => any,
scheduler?: type<F, I> Scheduler<F, I>
);
// ...
}
export class Root extends Subtree {
constructor(
component: type<E> Binding<E>,
onError?: (err: Error) => any,
scheduler?: type<F, I> Scheduler<F, I>
);
// ...
}
```
| Suggestion,In Discussion | high | Critical |
211,972,120 | TypeScript | Using `undefined` as a discriminator within a mapped type yields erroneous types when primitive intersections are involved | **TypeScript Version:** 2.2.0
[**Code**](http://www.typescriptlang.org/play/#src=%2F%2F%20A%20*self-contained*%20demonstration%20of%20the%20problem%20follows...%0D%0Atype%20DeepReadonly%3CT%3E%20%3D%20%7B%0D%0A%20%20%20%20readonly%20%5BK%20in%20keyof%20T%5D%3A%20DeepReadonly%3CT%5BK%5D%3E%3B%0D%0A%7D%0D%0A%0D%0Ainterface%20FieldBrand%20%7B%0D%0A%20%20%20%20%22%20do%20not%20use%20%22%3A%20void%3B%0D%0A%7D%0D%0A%0D%0Atype%20FieldId%20%3D%20number%20%26%20FieldBrand%3B%0D%0A%0D%0Ainterface%20DefOne%20%7B%0D%0A%20%20%20%20field%3A%20string%20%7C%20FieldId%3B%0D%0A%20%20%20%20kind%3A%20string%3B%0D%0A%7D%0D%0A%0D%0Ainterface%20DefTwo%20%7B%0D%0A%20%20%20%20field%3F%3A%20undefined%3B%20%2F%2F%20Allow%20discriminant%20checks%20on%20'field'%0D%0A%20%20%20%20value%3A%20string%3B%0D%0A%7D%0D%0A%0D%0Atype%20Def%20%3D%20DefOne%20%7C%20DefTwo%3B%0D%0A%0D%0Ainterface%20State%20%7B%0D%0A%20%20%20%20a%3F%3A%20Def%3B%0D%0A%20%20%20%20b%3F%3A%20Def%3B%0D%0A%7D%0D%0A%0D%0Atype%20ROState%20%3D%20DeepReadonly%3CState%3E%3B%0D%0A%0D%0Afunction%20lookupName(f%3A%20FieldId)%3A%20string%20%7B%0D%0A%20%20%20%20return%20%22%22%3B%0D%0A%7D%0D%0A%0D%0Afunction%20remapFieldsToNames(channels%3A%20ROState)%3A%20ROState%20%7B%0D%0A%20%20%20%20const%20newState%3A%20State%20%3D%20%7B%7D%3B%0D%0A%20%20%20%20for%20(const%20k%20of%20Object.keys(channels))%20%7B%0D%0A%20%20%20%20%20%20%20%20const%20key%20%3D%20k%20as%20keyof%20ROState%3B%0D%0A%20%20%20%20%20%20%20%20const%20ch%20%3D%20channels%5Bkey%5D%3B%0D%0A%20%20%20%20%20%20%20%20let%20replacement%3A%20ROState%5Btypeof%20key%5D%20%7C%20undefined%20%3D%20undefined%3B%0D%0A%20%20%20%20%20%20%20%20if%20(ch)%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20if%20(ch.field)%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20const%20f%20%3D%20ch.field%3B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20if%20(typeof%20f%20%3D%3D%3D%20%22number%22)%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20f%3B%20%2F%2F%20Should%20be%20FieldId%20or%20number%2C%20not%20never!%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20replacement%20%3D%20%7B%20...ch%2C%20field%3A%20lookupName(f)%20%7D%3B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20else%20if%20(typeof%20f%20%3D%3D%3D%20%22string%22)%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20f%3B%20%2F%2F%20correct%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%20%20%20%20newState%5Bk%5D%20%3D%20replacement%20%7C%7C%20channels%5Bk%5D%3B%0D%0A%20%20%20%20%7D%0D%0A%20%20%20%20return%20newState%3B%0D%0A%7D%0D%0A)
```ts
// A *self-contained* demonstration of the problem follows...
type DeepReadonly<T> = {
readonly [K in keyof T]: DeepReadonly<T[K]>;
}
interface FieldBrand {
" do not use ": void;
}
type FieldId = number & FieldBrand;
interface DefOne {
field: string | FieldId;
kind: string;
}
interface DefTwo {
field?: undefined; // Allow discriminant checks on 'field'
value: string;
}
type Def = DefOne | DefTwo;
interface State {
a?: Def;
b?: Def;
}
type ROState = DeepReadonly<State>;
function lookupName(f: FieldId): string {
return "";
}
function remapFieldsToNames(channels: ROState): ROState {
const newState: State = {};
for (const k of Object.keys(channels)) {
const key = k as keyof ROState;
const ch = channels[key];
let replacement: ROState[typeof key] | undefined = undefined;
if (ch) {
if (ch.field) {
const f = ch.field;
if (typeof f === "number") {
f; // Should be FieldId or number, not never!
replacement = { ...ch, field: lookupName(f) };
}
else if (typeof f === "string") {
f; // correct
}
}
}
newState[k] = replacement || channels[k];
}
return newState;
}
```
**Expected behavior:**
There are no type errors in the above, and `f` after the `typeof f === "number"` check is either a number or `FieldId`.
**Actual behavior:**
`replacement = { ...ch, field: lookupName(f) };` has a type error and `f` is of type `never`. | Needs Investigation | low | Critical |
211,973,111 | go | html/template: improve ErrBadHTML error report | Please answer these questions before submitting your issue. Thanks!
#### What did you do?
Recently I got the `ErrBadHTML` error 2-3 times, and and each time it took longer than expected to fix the typo, since there was no line reported in the error message.
Here is an example:
https://play.golang.org/p/syrtLCXWeE
#### What did you expect to see?
The error message should report the line were the error was found.
#### What did you see instead?
The error message only reports
```
"<" in attribute name: " selected<"
```
but this does not help when searching for the error in a big template.
Looking at the source code, it is possible that this issue does not only affect ErrBadHTML but also other errors.
#### System details
```
go version go1.8 linux/amd64
GOARCH="amd64"
GOBIN="/home/manlio/.local/bin"
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/manlio/.local/lib/go:/home/manlio/code/src/go"
GORACE=""
GOROOT="/usr/lib/go"
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build656653276=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
GOROOT/bin/go version: go version go1.8 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.8 X:framepointer
uname -sr: Linux 4.9.11-1-ARCH
/usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.24, by Roland McGrath et al.
gdb --version: GNU gdb (GDB) 7.12.1
```
| NeedsFix | low | Critical |
211,975,188 | create-react-app | Refuse to build if user is importing something that isn't declared in package.json | I think Brunch does this, if I recall correctly.
This is an important feature because people often misunderstand that transitive dependencies aren’t supposed to be importable.
See https://github.com/facebookincubator/create-react-app/issues/1714 and https://github.com/facebookincubator/create-react-app/issues/1622 for examples. | contributions: up for grabs!,difficulty: complex | medium | Critical |
211,975,410 | go | runtime: osyield is expensive on darwin? | This is a naive question about an unexpected and striking benchmarking result.
At tip, on my amd64 OS X laptop, I get:
```bash
$ go test -bench=BenchmarkSplitSingleByteSeparator -run=NONE bytes
BenchmarkSplitSingleByteSeparator-8 500 2722171 ns/op
```
If I apply [CL 37795](https://golang.org/cl/37795), the execution time increases 65%:
```bash
$ go test -bench=BenchmarkSplitSingleByteSeparator -run=NONE bytes
BenchmarkSplitSingleByteSeparator-8 300 4518575 ns/op
```
Note that in that CL, all that really happens is that a single function is removed from the call stack. Index checks the length of its argument, and if it is 1, then Index calls IndexByte.
CPU profiling indicates that basically all of the extra time is spent in runtime.usleep (called from runtime.osyield) and runtime.mach_semaphore_signal (called from runtime.notewakeup).
I'm left wondering:
(1) Is there a cheaper way to do an osyield on darwin that doesn't cost a full microsecond? (Linux appears to make an arch_prctl syscall instead of calling select.)
(2) Why does removing a function call from the stack create additional calls to osyield? Can this be avoided?
cc @ianlancetaylor @aclements
| Performance,OS-Darwin,early-in-cycle | low | Major |
211,995,124 | go | proposal: spec: add sum types / discriminated unions | This is a proposal for sum types, also known as discriminated unions. Sum types in Go should essentially act like interfaces, except that:
- they are value types, like structs
- the types contained in them are fixed at compile-time
Sum types can be matched with a switch statement. The compiler checks that all variants are matched. Inside the arms of the switch statement, the value can be used as if it is of the variant that was matched. | LanguageChange,Proposal,LanguageChangeReview | high | Critical |
211,995,682 | go | crypto: constant time AES and GCM | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
1.7.4
### What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH=""
GORACE=""
GOROOT="/home/dobenour/archives/go"
GOTOOLDIR="/home/dobenour/archives/go/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build902131924=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
### What did you do?
Looked at the Go docs for `crypto/aes`
### What did you expect to see?
That the AES implementation uses bitslicing to make it constant time.
### What did you see instead?
That the AES-GCM implementation is not constatn time and is vulnerable to timing attacks. | NeedsInvestigation | low | Critical |
212,007,115 | vscode | Trigger save even if file is not dirty through API | https://code.visualstudio.com/updates/v1_10#_manually-trigger-save-actions
I read this so I assumed the save() command from the API does the same thing.
https://github.com/Microsoft/vscode/blob/master/src/vs/vscode.d.ts#L124
The comment here makes it seem like it doesn't. Does this call trigger a save even if the document is not dirty? | feature-request,api,file-io | medium | Major |
212,033,602 | pytorch | dataloader parallels over elements vs over batches | With current design of `dataloader`, if we set `num_workers=8`, 8 batches of data will be prepared in advance, each worker works on one batch. This is not very efficient especially when one batch is large/expensive to process; and normally we only need 1-2 batches ahead of time . Why didn't we go with the design where all workers work on one batch at a time?
cc @SsnL @VitalyFedyunin @ejguan @NivekT | todo,feature,module: dataloader,triaged | low | Minor |
212,102,621 | vscode | Investigate better UX for previewing things | ~~People use `previewHtml` for building UI which does't work well. We should investigate different options~~~
We will tackle the problem from the other side: https://github.com/Microsoft/vscode/issues/22068#issuecomment-293903020 | feature-request,webview,workbench-editors,custom-editors | medium | Critical |
212,137,490 | go | tour: explain how to read a stacktrace | Hello,
I'd like to propose adding to the Tour of Go a page where the user is presented with a stack trace that occurs from a panic and guided into how to read / debug it.
I think this would be valuable for people just learning the language and would help them when they'll run for the first time into a such an issue.
If approved, I'd be happy to send a CL to do this (guidance welcomed).
What do you think? | Proposal-Accepted | medium | Critical |
212,265,547 | TypeScript | Reformat ternary operator | _From @lijunray on March 6, 2017 22:4_
<!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode -->
- VSCode Version: 1.9.1
- OS Version: MacOS 10.12.3
Steps to Reproduce:
The default reformatting for ternary operator is working unexpectedly.
What I want:
[![enter image description here][1]][1]
After Reformatting:
[![enter image description here][2]][2]
How can I config the reformatting so that it works as I expect?
[1]: https://i.stack.imgur.com/vnwGM.png
[2]: https://i.stack.imgur.com/yhZei.png
_Copied from original issue: Microsoft/vscode#22110_ | Bug,Help Wanted,Domain: Formatter,VS Code Tracked | medium | Major |
212,272,077 | rust | Same for loop up to 38% slower depending on iterator used | An issue making what would be the same code in C++ running at significantly different speed with Rust stable/beta/nightly depending on:
- The type of for loop used: `for y in buf` or `for i in 0..buf.len()`
- Whether the input data is contained in a Vec, Array or Array Slice
- Whether the test algorithm is inside a function used only with Vec or Array, Array Slice inputs but not several of them.
Previously reported as #40044 with imprecision.
Current stable is 1.15.1. The issue exists pre-MIR albeit with slightly different figures.
#### Real world examples measured on an audio DSP algorithm
##### arm
- Raspberry Pi, Rustc 1.15.1: up to 34% slower
##### armv7
- Raspberry Pi 3, Rustc 1.15.1: up to 34% slower, Array 4% slower than Vec
- Nexus 5, Rustc 1.15: up to 38% slower, Array 1% slower than Vec
- Nexus 5X, Rustc 1.15: up to 18% slower
##### aarch64
- Nexus 5X, Rustc 1.15: up to 27% slower
##### x86-64
- Core i5-750, Rustc 1.15: up to 18% slower
Test and demo project:
https://github.com/supercurio/rust-issue-vec-array-iterators-perf
Bench results:
https://github.com/supercurio/rust-issue-vec-array-iterators-perf/tree/master/benchs | I-slow,C-enhancement | low | Major |
212,282,070 | opencv | opencv_traincascade may get in infinite loop on MacOSX | - OpenCV => master, probably others.
- Operating System / Platform => MacOSX
- Compiler => Apple LLVM version 8.0.0 (clang-800.0.42.1)
##### Detailed description
opencv_traincascade may get in infinite loop in `CvCascadeBoostTrainData::precalculate()`
```
parallel_for_( Range(numPrecalcVal, numPrecalcIdx),
FeatureIdxOnlyPrecalc(featureEvaluator, buf, sample_count, is_buf_16u!=0) );
```
`numPrecalcVal` and `numPrecalcIdx` are set in `CvCascadeBoostTrainData::setData()` and `numPrecalcIdx` can be zero if `featureEvaluator->getMaxCatCount() > 0`.
So, `numPrecalcVal` can be bigger then `numPrecalcIdx`.
On MacOSX `parallel_for_` is expanded to
```
dispatch_apply_f(stripeRange.end - stripeRange.start, concurrent_queue, &pbody, block_function);
```
First parameter is unsigned, so we get some really big value here.
Possible fixes:
1. Don't allow ranges with `start > end`.
2. Check `stripeRange.end >= stripeRange.start` on MacOSX. | bug,category: core,category: apps | low | Minor |
212,321,577 | react | Switch to using createFactory in compiler steps | ```js
var Foo = require('Foo');
function Bar() {
return <Foo x={1}>Hi</Foo>;
}
```
Originally we intended to compile JSX to this format:
```js
var Foo = require('Foo');
var Foo_ = React.createFactory(Foo);
function Bar() {
return Foo_({ x: 1, children: "Hi" });
}
```
That allows us to generate a factory that can be more optimized and resolves `defaultProps`.
There are some problems with generating an optimized factory in many cases because it can slow down start up. However, if you have an optimizing compiler that can resolve that, we can turn that on in those cases.
Another thing we can do is that if the function is a simple functional component then we can just return the functional component itself. So that it becomes just a straight through function call. At least if the element doesn't have a key. (Slight change in semantics but mostly not.)
An optimizing compiler or VM (that is aware of the type of "Foo" which not known to the Babel transform) can then infer that this function is just a function call and can then proceed to actually inline it.
For heavy functions it would be bad to do this though since it can expand the time a render is executed and work against the time slicing mechanism of Fiber.
Therefore, we might want to use a heuristic to determine if a functional component gets to be "inlined" or not. E.g. function length or something.
A good data point to use in a heuristic is whether the component is part of a loop or a closure (such as being part of a map);
```js
var Foo = require('Foo');
function Bar({ data }) {
var children = [];
for (var i = 0; i < data.length; i++) {
children.push(<Baz>{data[i]}</Baz>);
}
return <Foo x={1}>{children}</Foo>;
}
```
or
```js
var Foo = require('Foo');
function Bar({ data }) {
return <Foo x={1}>{data.map(d => <Baz>{d}</Baz>)}</Foo>;
}
```
We could change the transform to treat these special and flag them as part of a hot path by calling a special createFactory:
```js
var Foo = require('Foo');
var Baz = require('Baz');
var Foo_ = React.createFactory(Foo);
var Baz_ = React.createFactoryHot(Baz);
function Bar({ data }) {
return Foo_({ x: 1, children: data.map(d => Baz_({ children: d })) });
}
```
The neat part of this model is that the transform can be pretty simple and readable.
The optimization itself is in createFactory and createFactoryHot.
It also doesn't have to reason about cross-module transforms. That's all taken care of by the optimizing compiler or VM. | Component: Optimizing Compiler,React Core Team | low | Major |
212,352,915 | rust | vtable accesses optimization in a tight loop. | This is a followup of #39992 .
This [playrust]( https://is.gd/foJgye):
```
#![crate_type="lib"]
use std::sync::Arc;
pub struct Wrapper {
x: usize,
y: usize,
t: Arc<Foo>,
}
pub trait Foo {
fn foo(&self);
}
pub fn test(foo: Wrapper) {
for _ in 0..200 {
foo.t.foo();
}
}
```
Generates the tight loop:
```
.LBB1_1:
incl %ebp
cmpl $200, %ebp
jge .LBB1_2
movq 16(%rbx), %rdi
movq 24(%rbx), %rax
leaq 15(%rdi), %rcx
negq %rdi
andq %rcx, %rdi
addq %r12, %rdi
.Ltmp12:
callq *%rax
.Ltmp13:
jmp .LBB1_1
```
while it seems to me the vtable access should be out of the loop, and it shouldn't be hard. | I-slow,C-enhancement,C-optimization | low | Minor |
212,405,859 | opencv | Move enums from cvflann to cv::flann | Now python bindings can't be generated for these enums. This causes usage of magic numbers like in #8245. | category: python bindings,category: flann,future | low | Minor |
212,478,801 | rust | std::io functions should document which ErrorKinds they can return | See [this reddit post](https://www.reddit.com/r/rust/comments/5xrlys/hey_rustaceans_got_an_easy_question_ask_here/dekujpe/) where the question was "How can `File::open` fail?" and the information is sort of there in the docs, but I was reduced to guessing `io::ErrorKind` variants from the text description of errors. Similar to how Unix man pages list _exactly_ which `errno` values are possible, the `std::io` functions should list the exact variants they might return. | C-enhancement,P-medium,T-libs-api,E-medium,A-docs | medium | Critical |
212,505,179 | angular | ValueAccessor.writeValue is being called twice, first time with a phantom null value | <!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING
-->
**I'm submitting a ...** (check one with "x")
```
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
```
**Current behavior**
The ValueAccessor.writeValue method is called twice on a custom value accessor during component initialization, when a control is bound using [(ngModel)], first time with a phantom null value.
Note that this is not an issue in form builder scenarios when control is bound using [formControlName].
**Expected behavior**
ValueAccessor.writeValue should be called only once, with an actual value of the property bound to [(ngModel)].
**Minimal reproduction of the problem with instructions**
Run the following plunker:
[http://plnkr.co/edit/g5kjqQ9bQ9DF2cs4DbEH?p=preview](http://plnkr.co/edit/g5kjqQ9bQ9DF2cs4DbEH?p=preview)
MyValueAccessor is applied to the MyCmp component, the latter is bound using [(ngModel)] to the property initialized to 'Hello'. MyValueAccessor.writeValue writes the passed value to the console, the output looks as follows:
```
MyValueAccessor.writeValue: null
MyValueAccessor.writeValue: Hello
```
**What is the motivation / use case for changing the behavior?**
<!-- Describe the motivation or the concrete use case -->
**Please tell us about your environment:**
<!-- Operating system, IDE, package manager, HTTP server, ... -->
* **Angular version:** RC.4 - 2.4.9
<!-- Check whether this is still an issue in the most recent Angular version -->
* **Browser:** Chrome, IE11
<!-- All browsers where this could be reproduced -->
* **Language:** TypeScript
* **Node (for AoT issues):** `node --version` =
| type: bug/fix,freq2: medium,area: forms,state: confirmed,forms: ControlValueAccessor,P3 | high | Critical |
212,515,768 | TypeScript | Unicode Character Causing all Lines to Be shifted by one | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
From: https://github.com/Microsoft/vscode/issues/22144
**TypeScript Version:** 2.1.1 / nightly (2.2.0-dev.201xxxxx)
**Code**
```ts
/**
* 清除字节数组的内容，并将 length 和 position 属性重置为 0。
*/
class Bla {
foo(){}
bar(){}
}
```
Note that there's an end byte sequence of `\xe2\x80\xa8` on the line of the comment (line separator perhaps)
**Bug**
This causes all lines returned by the TSServer to be off by one. It seems like the line is not being treated as a newline.
This in turn causes a number of issues, such incorrect symbol locations and incorrect formatting such as:
<img width="496" alt="screen shot 2017-03-07 at 10 17 09 am" src="https://cloud.githubusercontent.com/assets/12821956/23671223/4d660708-031f-11e7-81a4-e3f85f1a54ce.png">
| Bug,VS Code Tracked | low | Critical |
212,528,591 | TypeScript | Parameter type narrowing should consider function overload signatures | **TypeScript Version:** 2.2.1
**Code**
```ts
interface A { x: number; }
interface B { y: number; }
function foo(b: B): void;
function foo(a: A, b: B): void;
function foo(a: A|B, b?: B): void {
if(b !== void 0) {
console.log(a.y); // Error: Property 'y' does not exist on type 'A | B'
}
}
```
The third (unified) function signature is hidden from the call site, and therefore any arguments should be able to be narrowed based on inspection of the provided arguments. In the case above, the second argument is only defined if the first argument is of type `A`, and so I would expect narrowing of the argument type to occur accordingly. One could make the argument that in the compiled output, it's possible for JavaScript to still pass subsequent arguments, but then why narrow types at all, seeing as JavaScript can always violate every type constraint that TypeScript makes inferences from? | Suggestion,Needs Proposal | low | Critical |
212,545,224 | TypeScript | Enable type parameter lower-bound syntax | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
**TypeScript Version:** 2.1.1
**Code**
```ts
class Animal {}
class Cat extends Animal {}
class Kitten extends Cat{}
function foo<A super Kitten>(a: A) { /* */ }
```
**Expected behavior:**
The type parameter `A` has the type `Kitten` as lower-bound.
**Actual behavior:**
Compilation failure. The syntax is unsupported.
**Discussion:**
The upper-bound counterpart of the failed code works fine:
```ts
class Animal {}
class Cat extends Animal {}
class Kitten extends Cat{}
function foo<A extends Animal>(a: A) { /* */ }
```
People in issue [#13337](https://github.com/Microsoft/TypeScript/issues/13337) have suggested to use
```ts
function foo <X extends Y, Y>(y: Y) { /* */ }
```
to lower-bound `Y` with `X`. But this does not cover the case where `X` is an actual type (instead of a type parameter). | Suggestion,In Discussion | high | Critical |
212,568,257 | neovim | :terminal range - ":%term foo" should read the output of `foo` | - `nvim --version`: NVIM 0.2.0-dev
- Vim (version: 7.4.712-2ubuntu4) behaves differently? yes
- Operating system/version: Ubuntu 15.10
- Terminal name/version: GNOME Terminal 3.18.2
- `$TERM`: screen-256color
### Actual behaviour
I know `:%!cmd` runs in a non-interactive shell and I'm supposed to use `:te` but I can't find any way to pass lines from the current buffer to an interactive command for processing and read the output back to the buffer.
### Expected behaviour
Way to send some or all lines to `:te` in a similar way `%!cmd` works in Vim.
### Steps to reproduce using `nvim -u NORC`
Very practical usecase is to edit encrypted files - saving to hard drive (as well as swap) is undesired for security reasons. Creating such file would be:
```
nvim -u NORC
i foobar escape
:%!gpg -c
(normally here you type in and repeat the passphrase and then can save encrypted buffer)
(in NVIM the buffer doesn't get encrypted and process freezes)
```
For the time being I use Vim to do it but it would be nice to fully switch to NVIM. | enhancement,terminal | low | Minor |
212,615,821 | TypeScript | Incorrect Formatting For Class With Decorator | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
From https://github.com/Microsoft/vscode/issues/21723
**TypeScript Version:** 2.2.1
**Code**
```ts
function Component(x) {
return x
}
@Component
export class Foo {bar(): void {
return 2
}
}
```
Set formatting options to two spaces and run document format
**Expected behavior:**
Class is formatted with two spaces as
```ts
@Component
export class Foo {
bar(): void {
return 2
}
}
```
**Actual behavior:**
Class is formatted with four spaces:
```ts
@Component
export class Foo {
bar(): void {
return 2
}
}
```
Running format again returns to the correct two space formatting
```
[Trace - 5:55:14 PM] Sending request: configure (12). Response expected: yes. Current queue length: 0
Arguments: {
"file": "/Users/matb/projects/sand/x.ts",
"formatOptions": {
"tabSize": 2,
"indentSize": 2,
"convertTabsToSpaces": true,
"newLineCharacter": "\n",
"insertSpaceAfterCommaDelimiter": true,
"insertSpaceAfterSemicolonInForStatements": true,
"insertSpaceBeforeAndAfterBinaryOperators": true,
"insertSpaceAfterKeywordsInControlFlowStatements": true,
"insertSpaceAfterFunctionKeywordForAnonymousFunctions": true,
"insertSpaceBeforeFunctionParenthesis": false,
"insertSpaceAfterOpeningAndBeforeClosingNonemptyParenthesis": true,
"insertSpaceAfterOpeningAndBeforeClosingNonemptyBrackets": false,
"insertSpaceAfterOpeningAndBeforeClosingTemplateStringBraces": false,
"insertSpaceAfterOpeningAndBeforeClosingJsxExpressionBraces": false,
"placeOpenBraceOnNewLineForFunctions": false,
"placeOpenBraceOnNewLineForControlBlocks": false
}
}
[Trace - 5:55:14 PM] Response received: configure (12). Request took 4 ms. Success: true
[Trace - 5:55:14 PM] Sending request: format (13). Response expected: yes. Current queue length: 0
Arguments: {
"file": "/Users/matb/projects/sand/x.ts",
"line": 1,
"offset": 1,
"endLine": 10,
"endOffset": 2
}
[Trace - 5:55:14 PM] Response received: format (13). Request took 36 ms. Success: true
Result: [
{
"start": {
"line": 1,
"offset": 20
},
"end": {
"line": 1,
"offset": 20
},
"newText": " "
},
{
"start": {
"line": 1,
"offset": 21
},
"end": {
"line": 1,
"offset": 21
},
"newText": " "
},
{
"start": {
"line": 6,
"offset": 19
},
"end": {
"line": 6,
"offset": 19
},
"newText": "\n"
},
{
"start": {
"line": 6,
"offset": 19
},
"end": {
"line": 6,
"offset": 19
},
"newText": " "
},
{
"start": {
"line": 7,
"offset": 1
},
"end": {
"line": 7,
"offset": 1
},
"newText": " "
},
{
"start": {
"line": 8,
"offset": 1
},
"end": {
"line": 8,
"offset": 1
},
"newText": " "
}
]
| Bug,Help Wanted,Domain: Formatter,VS Code Tracked | low | Critical |
212,654,326 | rust | type checker takes O(~1.5^recursion_limit) time to reject simple-ish code | Found when trying to port my old type system Brainfuck interpreter to use associated types. Reduced case:
```rust
#![recursion_limit="10"]
use std::marker::PhantomData;
struct Nil;
struct Cons<A, B>(PhantomData<A>, PhantomData<B>);
struct BFPlus;
trait BF {
type NewState: ?Sized;
}
// +
impl<U, OtherInsns, NewState>
BF for (U, Cons<BFPlus, OtherInsns>)
where (U, OtherInsns): BF<NewState=NewState> {
type NewState = ();
}
fn main() {
let insns = Nil;
let state = Nil;
fn print_bf<State, Insns, NewState>(state: State, insns: Insns)
where (State, Insns): BF<NewState=NewState> {
}
print_bf(state, insns);
}
```
I don't really understand what's going on, but as written, rustc outputs:
```
error[E0275]: overflow evaluating the requirement `<(_, _) as BF>::NewState`
--> xx-iloop.rs:27:5
|
27 | print_bf(state, insns);
| ^^^^^^^^
|
= help: consider adding a `#![recursion_limit="20"]` attribute to your crate
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, _>)`
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, Cons<BFPlus, _>>)`
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, _>>>)`
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, _>>>>)`
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, _>>>>>)`
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, _>>>>>>)`
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, _>>>>>>>)`
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, _>>>>>>>>)`
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, _>>>>>>>>>)`
= note: required because of the requirements on the impl of `BF` for `(_, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, Cons<BFPlus, _>>>>>>>>>>)`
= note: required by `main::print_bf`
```
However, increasing the recursion_limit dramatically increases the time it takes to report the error.
Note that writing the impl more normally as
```rust
impl<U, OtherInsns>
BF for (U, Cons<BFPlus, OtherInsns>)
where (U, OtherInsns): BF {
type NewState = <(U, OtherInsns) as BF>::NewState;
}
```
fails instantly even with a high recursion limit. But I don't see why it should fail at all: the impl is sane enough, implementing `BF` for a larger type based on its implementation for a smaller type. | C-enhancement,A-trait-system,I-compiletime,T-compiler | low | Critical |
212,771,371 | go | context: TestLayersCancel flake | From trybot run https://storage.googleapis.com/go-build-log/dbcdd62f/openbsd-amd64-60_97787251.log
```
--- FAIL: TestLayersCancel (0.46s)
context_test.go:520: seed=1488986705610226342: ctx should not be canceled yet
context_test.go:565: context.Background.WithCancel.WithDeadline(2017-03-08 07:25:05.810276628 -0800 PST m=+1.147363981 [-255.077111ms]).WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithValue((*context.value)(0xc4200155b0), (*context.value)(0xc4200155b0)).WithCancel.WithCancel.WithCancel.WithValue((*context.value)(0xc4200155b8), (*context.value)(0xc4200155b8)).WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithValue((*context.value)(0xc420015660), (*context.value)(0xc420015660)).WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithCancel.WithValue((*context.value)(0xc420015668), (*context.value)(0xc420015668)).WithValue((*context.value)(0xc4200156d0), (*context.value)(0xc4200156d0)).WithCancel.WithCancel.WithCancel
FAIL
FAIL context 1.745s
``` | Testing,help wanted,NeedsFix | low | Major |
212,787,577 | rust | Common well-known traits make "Trait Implementations" too verbose | I find the "Trait Implementations" section of Rustdoc very hard to follow. It has low signal to noise ratio:
* Very common traits are displayed in full detail. For traits like `Copy`, `Clone`, `Default`, `Display`, `Debug`, `Hash`, etc. I don't need to see all the methods *inline* with their description. Just links to these traits would be enough. Generally I only need to know whether the type implements them or not.
* Similarly, traits used via operators are also displayed in full detail. `Eq`, `PartialEq`, `Add`, `Sub`, `Ord`, `PartialOrd`, etc. flood the documentation page with documentation *of* the traits, and the specific methods are even less relevant. The long verbose list makes it hard to see *which* traits are supported.
* If the type implements the same trait multiple times for slightly different types, the whole trait documentation is repeated multiple times. It is useful to know which type combinations are supported, but repeated function descriptions only lower signal to noise ratio. It's worst for [primitive types](https://doc.rust-lang.org/std/primitive.i32.html) where the list appears to be dominated by countless the variants of `Shr` and `Shl`, drowning out all other information.
The current layout does work well for less common/more specific traits, e.g. having entire trait documentation inlined is perfect for `*Ext` traits and makes sense in some cases like `impl Read for File`.
So I'm suggesting:
* Implement collapsing widget for trait implementations, which collapses documentation of methods, leaving only `[+] impl Trait for Foo` line.
* Collapse basic traits by default (`Copy`, `Clone`, `Debug`, `std::ops::*`, etc.). Not all traits in `std` are obvious, so the list of traits to display in a terse form would probably be manually curated.
* Group implementations of the same trait together, and collapse all implementations except one. For example [`File`](https://doc.rust-lang.org/std/fs/struct.File.html) displays all of `Read` docs twice, in two separate places. It makes the list longer and makes it harder to notice that there are two implementations. It would be clearer to display it as:
> `[+] impl Read for File`
> `[-] impl<'a> Read for &'a File`
> ` fn read(&mut self) …`
| T-rustdoc,P-low,C-feature-request | low | Critical |
212,792,807 | nvm | I have lost all node packages after installing nvm ? | After installing nvm on **PRODCUTION SERVER** everything is down since it have changed the default node folder I can no more have any installed packages. How to undo this effect and get the default node folder with all packages before installing nvm ? | installing node,needs followup | low | Minor |
212,813,355 | rust | duplicate definition error depends on macro declaration order | Consider this code:
```rust
macro_rules! m { () => { mod Foo {} } }
struct Foo {}
m!();
```
The error is, "a module named `Foo` has already been defined in this module", pointing at line 2, the struct definition. Note that from, I would say, a user's perspective, the module is actually declared _after_ the struct (by calling the macro).
Furthermore, switching lines 1 and 2 (_not_ lines 2 and 3) switches the blame to the mod as being a duplicate. | C-enhancement,A-diagnostics,A-resolve,A-macros,T-compiler | low | Critical |
212,830,125 | godot | Sub-inherited scene is not updated properly in the editor | **Operating system or device - Godot version:**
Godot 2.1 and 3.0 probably too, after applying #7978 or #7979, respectively (without them the issues are much more serious)
**Issue description:**
If a scene indirectly inherits another, it doesn't get properly updated in the editor. The editor won't trigger the reload of the most derived scene, but will apply partially the changes made to the base scene.
**Steps to reproduce:**
1. Create a scene hierarchy (inheritance) like this: __C__ inherits __B__ which inherits __A__.
2. Open __A__ and __C__ in the editor.
3. Add some node to __A__.
4. Switch to __C__. Notice it isn't reloaded.
5. Reload manually with _Revert Scene_.
6. Switch back to __A__.
7. Remove the node you created.
8. Switch again to __C__. Notice how the node you created now appears as owned.
9.a. If you reload __C__ again, everything will be in place (with the phantom node gone).
9.b. If instead you save __C__, the node will be commited to the scene as if it had been created there initially.
**Link to minimal example project:**
Maybe one day.
| bug,topic:editor,confirmed | low | Major |
212,850,602 | rust | Misleading suggestion for missing trait bounds | This is a simplified version of https://users.rust-lang.org/t/solved-iterator-filter-and-zip-in-place/9809/4
```rust
trait Foo {
fn foo(self) -> Self;
}
impl<I, T, U> Foo for I
where I: Iterator<Item = (T, U)>
{
fn foo(self) -> Self {
self
}
}
fn main() {
let v = vec![(1, 'a'), (2, 'b'), (3, 'c')];
for x in v.iter().foo() {
println!("{:?}", x);
}
}
```
[The error is](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=6d156770fb7bf83601c77a3d71592a02):
```
error: no method named `foo` found for type `std::slice::Iter<'_, ({integer}, char)>` in the current scope
--> <anon>:15:23
|
15 | for x in v.iter().foo() {
| ^^^
|
= note: the method `foo` exists but the following trait bounds were not satisfied: `&std::slice::Iter<'_, ({integer}, char)> : std::iter::Iterator`
= help: items from traits can only be used if the trait is implemented and in scope; the following trait defines an item `foo`, perhaps you need to implement it:
= help: candidate #1: `Foo`
```
The `note:` chose to report missing `&Iter: Iterator`, which is true, but it's not best thing it could have noted. I guess it's looking at `&Iter` because of some auto-ref in the method call. But if you force it to use `Iter` directly with UFCS, like `Foo::foo(v.iter())`, the note is more useful.
```
error[E0271]: type mismatch resolving `<std::slice::Iter<'_, ({integer}, char)> as std::iter::Iterator>::Item == (_, _)`
--> <anon>:15:14
|
15 | for x in Foo::foo(v.iter()) {
| ^^^^^^^^ expected reference, found tuple
|
= note: expected type `&({integer}, char)`
found type `(_, _)`
= note: required because of the requirements on the impl of `Foo` for `std::slice::Iter<'_, ({integer}, char)>`
= note: required by `Foo::foo`
```
So we *do* have an `Iterator`, just the wrong `Item`. | C-enhancement,A-diagnostics,T-compiler,D-confusing,D-papercut | low | Critical |
212,880,604 | go | runtime: signal handling: async signals should forward to existing C handlers by default | `runtime.sigfwdgo` currently includes this snippet, intended to ignore signals per the [documented behavior of os/signal](https://golang.org/pkg/os/signal/#hdr-Changing_the_behavior_of_signals_in_Go_programs):
```go
// If we aren't handling the signal, forward it.
// […]
if atomic.Load(&handlingSig[sig]) == 0 {
sigfwd(fwdFn, sig, info, ctx)
return true
}
flags := sigtable[sig].flags
// Only forward synchronous signals and SIGPIPE.
// […]
if (c.sigcode() == _SI_USER || flags&_SigPanic == 0) && sig != _SIGPIPE {
return false
}
// Determine if the signal occurred inside Go code. We test that:
// (1) we were in a goroutine (i.e., m.curg != nil), and
// (2) we weren't in CGO.
g := getg()
if g != nil && g.m != nil && g.m.curg != nil && !g.m.incgo {
return false
}
```
`handlingSig[sig]` is set for *all* of the signals that the `os/signal` package cares about any time `signal.Notify` is called for *any* signal.
That results in signals intended for C handlers (such as `SIGABRT`) being dropped, which is arguably incorrect for programs which may include C handlers for those signals.
----
For example, in the program below we register an early C handler for `SIGUSR1` and a Go handler for `SIGUSR2`, then signal the program with `SIGUSR1` (in a way that happens to ensure the signal is delivered to a thread in a Go stack frame, to make the program more deterministic).
Since there is a C handler for the signal and no corresponding `signal.Notify` call for that signal, `sigfwdgo` arguably ought to forward `SIGUSR1` to the C handler.
Instead, it returns without forwarding, the handler drops through to `runtime.sighandler`, and the signal is ignored.
```
bcmills:~/go$ go version
go version devel +228438e097 Wed Mar 8 21:34:32 2017 +0000 linux/amd64
```
src/asyncsig/asyncsig.go:
```go
package main
/*
#include <signal.h>
#include <stdbool.h>
#include <stdlib.h>
static volatile sig_atomic_t signaled = 0;
static void record_signal(int sig) {
signaled = 1;
}
static void register_handler() __attribute__ ((constructor (200)));
static void register_handler() {
signal(SIGUSR1, record_signal);
}
static bool was_signaled() {
return signaled != 0;
}
*/
import "C"
import (
"os"
"os/signal"
"runtime"
"syscall"
)
func main() {
ch := make(chan os.Signal)
signal.Notify(ch, syscall.SIGUSR2)
tidc := make(chan int, 1)
go func() {
runtime.LockOSThread()
tid := syscall.Gettid()
for { // Loop forever sending the current TID.
select {
case tidc <- tid:
default:
}
}
}()
syscall.Tgkill(syscall.Getpid(), <-tidc, syscall.SIGUSR1)
// Wait for the thread to finish handling the signal.
<-tidc
<-tidc
if !C.was_signaled() {
panic("expected SIGUSR1 to have been signaled")
}
}
```
```
bcmills:~$ go build asyncsig && ./asyncsig
panic: expected SIGUSR1 to have been signaled
goroutine 1 [running]:
main.main()
/usr/local/google/home/bcmills/src/asyncsig/asyncsig.go:56 +0x1a3
```
| compiler/runtime | low | Major |
212,885,047 | go | cmd/compile,runtime: avoid multiple returns from deferproc | We currently compile a defer to this:
```
x := deferproc(...)
if x != 0 { goto deferreturn }
...
deferreturn:
deferreturn()
```
Normally deferproc returns 0. However, when a subsequent panic is caught and the defer is run by the panic, and that defer recovers, then the runtime arranges the defer to return 1 at the same deferproc callsite. The generated code then immediately jumps to deferreturn().
We should just make a recover'd panic return to the deferreturn callsite. That may involve passing the pc of the deferreturn call to deferproc.
It would mean stack traces during panic point to the end of the function instead of to the site of the defer call. That's arguably more correct (and matches the behavior on non-panic running of defers).
Part of the reason for this fix is that the code past deferproc() but before the branch gets executed twice in a defer/panic/recover scenario. The SSA backend has been known to insert non-idempotent code in spots like that (See #19201. That was for selectrecv not deferproc, but the same issue applies.)
The generated code may have originally been written this way because there was a push/pop sequence around the deferproc call, and the pops were required on the second return as well. Those push/pop sequences were removed a long time ago.
@rsc @mdempsky
See #19331 | compiler/runtime | low | Minor |
212,916,481 | TypeScript | Changing baseUrl causes compiler not to look at @types subdirectory | When `baseUrl` is set in tsconfig.json, the compiler will not look into `baseUrl/@types` to try and find type definitions
**TypeScript Version:** 2.2.1
**Code**
Example is available at:
https://github.com/spion/ts-base-url-issue
If the "paths" entry is removed from tsconfig.json, the compiler is unable to find `react-dom`
**Expected behavior:**
Compiles fine even without a "paths" entry.
**Actual behavior:**
Compiler doesn't find the definition file if the paths config option is removed. `--trace-resolution` shows that it never tries baseUrl/@types/react-dom
```
======== Resolving module 'react-dom' from '/Users/spion/Documents/tests/ts-modules-broken/app/index.ts'. ========
Explicitly specified module resolution kind: 'NodeJs'.
'baseUrl' option is set to '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules', using this value to resolve non-relative module name 'react-dom'
Resolving module name 'react-dom' relative to base url '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules' - '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom'.
Loading module as file / folder, candidate module location '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom', target file type 'TypeScript'.
File '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom.ts' does not exist.
File '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom.tsx' does not exist.
File '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom.d.ts' does not exist.
Found 'package.json' at '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom/package.json'.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
File '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom/index.ts' does not exist.
File '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom/index.tsx' does not exist.
File '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom/index.d.ts' does not exist.
Loading module 'react-dom' from 'node_modules' folder, target file type 'TypeScript'.
Directory '/Users/spion/Documents/tests/ts-modules-broken/app/node_modules' does not exist, skipping all lookups in it.
Directory '/Users/spion/Documents/tests/ts-modules-broken/node_modules' does not exist, skipping all lookups in it.
Directory '/Users/spion/Documents/tests/node_modules' does not exist, skipping all lookups in it.
Directory '/Users/spion/Documents/node_modules' does not exist, skipping all lookups in it.
Directory '/Users/spion/node_modules' does not exist, skipping all lookups in it.
Directory '/Users/node_modules' does not exist, skipping all lookups in it.
Directory '/node_modules' does not exist, skipping all lookups in it.
'baseUrl' option is set to '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules', using this value to resolve non-relative module name 'react-dom'
Resolving module name 'react-dom' relative to base url '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules' - '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom'.
Loading module as file / folder, candidate module location '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom', target file type 'JavaScript'.
File '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom.js' does not exist.
File '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom.jsx' does not exist.
Found 'package.json' at '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom/package.json'.
'package.json' has 'main' field 'index.js' that references '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom/index.js'.
File '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom/index.js' exist - use it as a name resolution result.
======== Module name 'react-dom' was successfully resolved to '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom/index.js'. ========
app/index.ts(1,22): error TS7016: Could not find a declaration file for module 'react-dom'. '/Users/spion/Documents/tests/ts-modules-broken/vendor/node_modules/react-dom/index.js' implicitly has an 'any' type.
```
**Workaround**
Adding a paths entry gets the `@types` directory into the lookup list again:
```json
"baseUrl": "./vendor/node_modules",
"paths": {
"*": ["@types/*", "*"]
}
```
| Docs | low | Critical |
212,963,408 | youtube-dl | [szenik.eu] Download wrong video | Attempted to download a live opera video from
http://www.szenik.eu/de/Szenik-live/Klassik/arminio
A video is in fact downloaded, but not the opera I wanted: just a short "trailer" movie with monthly news. A "WARNING: Falling back on generic information extractor" makes me suppose that this site is not supported yet. I'd be grateful if you could help.
Here's a full transcript:
```
youtube-dl --verbose "http://www.szenik.eu/de/Szenik-live/Klassik/arminio"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'http://www.szenik.eu/de/Szenik-live/Klassik/arminio']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.03.07
[debug] Python version 2.7.2 - Darwin-15.6.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 2.2.4, rtmpdump 2.4
[debug] Proxy map: {}
[generic] arminio: Requesting header
WARNING: Falling back on generic information extractor.
[generic] arminio: Downloading webpage
[generic] arminio: Extracting information
[download] Downloading playlist: Arminio I Georg Friedrich Händel I Oper in voller Länge
[generic] playlist Arminio I Georg Friedrich Händel I Oper in voller Länge: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[youtube] BRqLX699hCE: Downloading webpage
[youtube] BRqLX699hCE: Downloading video info webpage
[youtube] BRqLX699hCE: Extracting video information
[youtube] {22} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {43} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {18} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {36} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] {17} signature length 40.40, html5 player en_US-vflOnuOF-
[youtube] BRqLX699hCE: Downloading MPD manifest
[debug] Invoking downloader on u'https://r8---sn-fpoq-4jvz.googlevideo.com/videoplayback/id/051a8b5faf7d8421/itag/136/source/youtube/requiressl/yes/pl/16/mn/sn-fpoq-4jvz/mm/31/ms/au/mv/m/ei/9QvBWKf7OcKUWsaWouAL/initcwndbps/847500/pcm2cms/yes/ratebypass/yes/mime/video%2Fmp4/otfp/1/gir/yes/clen/8696486/lmt/1488383796379055/dur/61.694/mt/1489046486/upn/5ZKcv1rZmDg/signature/44897AC8A0C3894102222403E182DECCDAAB6981.912B120D2468AC295B31103CCE43831AEFE3656A/key/dg_yt0/ip/151.15.88.167/ipbits/0/expire/1489068118/sparams/ip,ipbits,expire,id,itag,source,requiressl,pl,mn,mm,ms,mv,ei,initcwndbps,pcm2cms,ratebypass,mime,otfp,gir,clen,lmt,dur/'
[dashsegments] Total fragments: 13
[download] Destination: Mars _ März 17-BRqLX699hCE.f136.mp4
[download] 100% of 8.29MiB in 00:06
[debug] Invoking downloader on u'https://r8---sn-fpoq-4jvz.googlevideo.com/videoplayback/id/051a8b5faf7d8421/itag/140/source/youtube/requiressl/yes/pl/16/mn/sn-fpoq-4jvz/mm/31/ms/au/mv/m/ei/9QvBWKf7OcKUWsaWouAL/initcwndbps/847500/pcm2cms/yes/ratebypass/yes/mime/audio%2Fmp4/otfp/1/gir/yes/clen/982024/lmt/1488383777748891/dur/61.741/mt/1489046486/upn/5ZKcv1rZmDg/signature/521EF913BC95368CDDCF3879513D664C3088AECD.1CB94F7D6303BC679C5AA4D7CD13BC11F0ADF049/key/dg_yt0/ip/151.15.88.167/ipbits/0/expire/1489068118/sparams/ip,ipbits,expire,id,itag,source,requiressl,pl,mn,mm,ms,mv,ei,initcwndbps,pcm2cms,ratebypass,mime,otfp,gir,clen,lmt,dur/'
[dashsegments] Total fragments: 14
[download] Destination: Mars _ März 17-BRqLX699hCE.f140.m4a
[download] 100% of 958.82KiB in 00:01
[ffmpeg] Merging formats into "Mars _ März 17-BRqLX699hCE.mp4"
[debug] ffmpeg command line: ffmpeg -y -i 'file:Mars _ März 17-BRqLX699hCE.f136.mp4' -i 'file:Mars _ März 17-BRqLX699hCE.f140.m4a' -c copy -map 0:v:0 -map 1:a:0 'file:Mars _ März 17-BRqLX699hCE.temp.mp4'
Deleting original file Mars _ März 17-BRqLX699hCE.f136.mp4 (pass -k to keep)
Deleting original file Mars _ März 17-BRqLX699hCE.f140.m4a (pass -k to keep)
[download] Finished downloading playlist: Arminio I Georg Friedrich Händel I Oper in voller Länge
``` | site-support-request | low | Critical |
212,988,499 | rust | std::process::Command no way to handle command-line length limits | The arg method doesn't track the total resulting command-line length and has no way of indicating to clients that the resulting command-line length would exceed the OS's underlying maximum length. This is fine for launching subprocesses with dozens of arguments, but renders it impossible to implement xargs or similar functionality.
Can I suggest a new method
`fn try_add_arg<S: AsRef<OsStr>>(&mut self, arg: S) -> Option<S>`
with documentation saying that it's only preferable to `arg` when you're wanting multi-kilobyte command-lines?
`try_add_arg` would keep track of the number of args already added, and if the number of args or the resulting length would exceed the OS limits, then it ignores the argument and returns it back to the client. Otherwise it acts like the normal `arg` method and returns None. | T-libs-api,C-feature-accepted,A-process | low | Major |
213,120,772 | react | No blur event fired when button is disabled/removed | **Do you want to request a *feature* or report a *bug*?**
Bug
**What is the current behavior?**
When a focussed button becomes disabled, React does not dispatch a blur event.
**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem via https://jsfiddle.net or similar (template: https://jsfiddle.net/reactjs/69z2wepo/).**
1. Attach a blur event to a button
2. Focus the button
3. Make the button disabled or remove it from the DOM
**What is the expected behavior?**
A blur event will be dispatched.
**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**
15.1.0, not sure if it worked in previous versions.
Isolated test case: http://jsbin.com/fuvite/1/edit?html,css,js,output | Type: Bug,Component: DOM | medium | Critical |
213,143,978 | TypeScript | type information from referenced file not available. | <!-- BUGS: Please use this template. -->
Excuse me if this is an issue in Visual Studio Code, please. I can move it.
But it seems I can't get type information from referenced files.... I can't seem to tell what I'm doing wrong.
**TypeScript Version:** 2.1.1 / nightly (2.2.0-dev.201xxxxx)
**rowdata.js**
```js
function RowData() {
this.alpha = "";
this.numeric = 0;
}
module.exports = RowData();
```
**data.js**
```js
/// <reference path="./rowdata.js" />
let RowData = require("./rowdata.js");
/** @type {RowData[]} */
let someArray = [];
someArray.push(new RowData());
/** @type {RowData} */
let someVal = new RowData(); // also not available
```
**Expected behavior:**
Or something along these lines. This was just faked with a typedef higher in the file.
**Actual behavior:**
| Bug,Domain: JavaScript | low | Critical |
213,189,051 | neovim | execute() cannot be used with customlist command completion | `execute()` appears to fail when being used in a completion function.
With the following Vim file, `MycommandRedir` will have completion, but `Mycommand` won't.
``` vim
function! MyComplete(ArgLead, ...)
return [execute('echon 123')]
endfunction
function! MyCompleteRedir(ArgLead, ...)
redir => r
silent echon 123
redir END
return [r]
endfunction
command! -nargs=* -bar -complete=customlist,MyComplete Mycommand call Foo()
command! -nargs=* -bar -complete=customlist,MyCompleteRedir MycommandRedir call Foo()
```
I've reported this for Vim in https://github.com/vim/vim/issues/1141 a while ago, and then it worked in Neovim.
git-bisect shows that https://github.com/neovim/neovim/commit/7e7f01a3be90a4024d779a4032e5a914f850abdc broke it, which was meant to fix https://github.com/neovim/neovim/issues/5422. | bug-vim,has:repro | low | Minor |
213,189,253 | opencv | error: calling a __host__ function("__builtin_clzl") from a __device__ function("std::__lg") is not allowed | This happens when compiling with cuda in debug mode
```
INFO: From Compiling external/opencv_repo3/modules/nonfree/src/surf.cpp:
external/gcc_4_8/usr/include/c++/4.8/bits/stl_algobase.h(989): error: calling a __host__ function("__builtin_clzl") from a __device__ function("std::__lg") is not allowed
```
##### System information (version)
- OpenCV => 2.4.13.2
- Operating System / Platform => ubuntu 16.04
- Compiler => bazel
##### Detailed description
```
third_party/gpus/crosstool/clang/bin/crosstool_wrapper_driver_is_not_gcc -nostdinc -isystem external/gcc_4_8/usr/include -isystem external/gcc_4_8/usr/include/x86_64-linux-gnu -isystem external/gcc_4_8/usr/lib/gcc/x86_64-linux-gnu/4.8/include -isystem external/gcc_4_8/usr/lib/gcc/x86_64-linux-gnu/4.8/include-fixed -U_FORTIFY_SOURCE '-D_FORTIFY_SOURCE=1' -fstack-protector -Wall -Wunused-but-set-parameter -Wno-free-nonheap-object -fno-omit-frame-pointer -DROS_ASSERT_ENABLED -Werror -Wextra -Wno-unused-parameter -g '-std=c++11' -isystem external/gcc_4_8/usr/include/c++/4.8 -isystem external/gcc_4_8/usr/include/c++/4.8/backward -isystem external/gcc_4_8/usr/include/x86_64-linux-gnu/c++/4.8 -Wnon-virtual-dtor -MD -MF bazel-out/local_linux-dbgcuda/bin/external/opencv_repo3/_objs/nonfree/external/opencv_repo3/modules/nonfree/src/surf.pic.d '-frandom-seed=bazel-out/local_linux-dbgcuda/bin/external/opencv_repo3/_objs/nonfree/external/opencv_repo3/modules/nonfree/src/surf.pic.o' -fPIC -DHAVE_AV_CONFIG_H -DZLIB_CONST '-D_FILE_OFFSET_BITS=64' -D_ISOC99_SOURCE -D_LARGEFILE_SOURCE '-D_POSIX_C_SOURCE=200112' '-D_XOPEN_SOURCE=600' -DPIC -iquote external/opencv_repo3 -iquote bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3 -iquote external/zlib_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/zlib_repo -iquote external/bazel_tools -iquote bazel-out/local_linux-dbgcuda/genfiles/external/bazel_tools -iquote external/tbb_repo2 -iquote bazel-out/local_linux-dbgcuda/genfiles/external/tbb_repo2 -iquote . -iquote bazel-out/local_linux-dbgcuda/genfiles -iquote external/cuda_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/cuda_repo -iquote external/libv4l_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libv4l_repo -iquote external/png_repo2 -iquote bazel-out/local_linux-dbgcuda/genfiles/external/png_repo2 -iquote external/jpeg_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/jpeg_repo -iquote external/bz2_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/bz2_repo -iquote external/liblzma_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/liblzma_repo -iquote external/libsctp_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libsctp_repo -iquote external/valgrind_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/valgrind_repo -iquote external/x264_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/x264_repo -iquote external/dc1394_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/dc1394_repo -iquote external/libtiff_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libtiff_repo -iquote external/libjbig_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libjbig_repo -iquote external/libgtk_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libgtk_repo -iquote external/libglib_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libglib_repo -iquote external/x11_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/x11_repo -iquote external/libcairo_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libcairo_repo -iquote external/libfontconfig_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libfontconfig_repo -iquote external/libexpat1_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libexpat1_repo -iquote external/libfreetype_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libfreetype_repo -iquote external/libpango_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libpango_repo -iquote external/libharfbuzz_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libharfbuzz_repo -iquote external/libxml_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libxml_repo -iquote external/libatk_repo -iquote bazel-out/local_linux-dbgcuda/genfiles/external/libatk_repo -isystem external/opencv_repo3 -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3 -isystem external/opencv_repo3/modules/nonfree/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/nonfree/include -isystem external/opencv_repo3/modules/imgproc/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/imgproc/include -isystem external/opencv_repo3/modules/core/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/core/include -isystem external/opencv_repo3/modules/dynamicuda/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/dynamicuda/include -isystem external/opencv_repo3/modules/gpu/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/gpu/include -isystem external/zlib_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/zlib_repo/usr/include -isystem external/zlib_repo/usr/include/x86_64-linux-gnu -isystem bazel-out/local_linux-dbgcuda/genfiles/external/zlib_repo/usr/include/x86_64-linux-gnu -isystem external/bazel_tools/tools/cpp/gcc3 -isystem external/tbb_repo2/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/tbb_repo2/usr/include -isystem external/opencv_repo3/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/include -isystem external/cuda_repo -isystem bazel-out/local_linux-dbgcuda/genfiles/external/cuda_repo -isystem external/cuda_repo/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/cuda_repo/include -isystem external/opencv_repo3/modules/features2d/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/features2d/include -isystem external/opencv_repo3/modules/flann/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/flann/include -isystem external/opencv_repo3/modules/calib3d/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/calib3d/include -isystem external/opencv_repo3/modules/objdetect/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/objdetect/include -isystem external/opencv_repo3/modules/highgui/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/highgui/include -isystem external/libv4l_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libv4l_repo/usr/include -isystem external/png_repo2/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/png_repo2/usr/include -isystem external/jpeg_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/jpeg_repo/usr/include -isystem external/jpeg_repo/usr/include/x86_64-linux-gnu -isystem bazel-out/local_linux-dbgcuda/genfiles/external/jpeg_repo/usr/include/x86_64-linux-gnu -isystem third_party/ffmpeg -isystem bazel-out/local_linux-dbgcuda/genfiles/third_party/ffmpeg -isystem third_party/ffmpeg/third_party/ffmpeg -isystem bazel-out/local_linux-dbgcuda/genfiles/third_party/ffmpeg/third_party/ffmpeg -isystem external/bz2_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/bz2_repo/usr/include -isystem external/liblzma_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/liblzma_repo/usr/include -isystem external/libsctp_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libsctp_repo/usr/include -isystem external/valgrind_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/valgrind_repo/usr/include -isystem external/x264_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/x264_repo/usr/include -isystem external/dc1394_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/dc1394_repo/usr/include -isystem external/libtiff_repo/usr/include/x86_64-linux-gnu -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libtiff_repo/usr/include/x86_64-linux-gnu -isystem external/libjbig_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libjbig_repo/usr/include -isystem external/libgtk_repo/usr/include/gtk-2.0 -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libgtk_repo/usr/include/gtk-2.0 -isystem external/libgtk_repo/usr/lib/x86_64-linux-gnu/gtk-2.0/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libgtk_repo/usr/lib/x86_64-linux-gnu/gtk-2.0/include -isystem external/libgtk_repo/usr/include/gdk-pixbuf-2.0 -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libgtk_repo/usr/include/gdk-pixbuf-2.0 -isystem external/libglib_repo/usr/include/glib-2.0 -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libglib_repo/usr/include/glib-2.0 -isystem external/libglib_repo/usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libglib_repo/usr/lib/x86_64-linux-gnu/glib-2.0/include -isystem external/x11_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/x11_repo/usr/include -isystem external/libcairo_repo/usr/include/cairo -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libcairo_repo/usr/include/cairo -isystem external/libfontconfig_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libfontconfig_repo/usr/include -isystem external/libexpat1_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libexpat1_repo/usr/include -isystem external/libfreetype_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libfreetype_repo/usr/include -isystem external/libpango_repo/usr/include/pango-1.0 -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libpango_repo/usr/include/pango-1.0 -isystem external/libharfbuzz_repo/usr/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libharfbuzz_repo/usr/include -isystem external/libxml_repo/usr/include/libxml2 -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libxml_repo/usr/include/libxml2 -isystem external/libatk_repo/usr/include/atk-1.0 -isystem bazel-out/local_linux-dbgcuda/genfiles/external/libatk_repo/usr/include/atk-1.0 -isystem external/opencv_repo3/modules/video/include -isystem bazel-out/local_linux-dbgcuda/genfiles/external/opencv_repo3/modules/video/include -x cuda '-DGOOGLE_CUDA=1' -DCUDA_FOUND -DUSE_CUDA '-nvcc_options=expt-relaxed-constexpr' -no-canonical-prefixes -fno-canonical-system-headers -Wno-builtin-macro-redefined '-D__DATE__="redacted"' '-D__TIMESTAMP__="redacted"' '-D__TIME__="redacted"' -c external/opencv_repo3/modules/nonfree/src/surf.cpp -o bazel-out/local_linux-dbgcuda/bin/external/opencv_repo3/_objs/nonfree/external/opencv_repo3/modules/nonfree/src/surf.pic.o)
INFO: From Compiling external/opencv_repo3/modules/nonfree/src/surf.cpp:
external/gcc_4_8/usr/include/c++/4.8/bits/stl_algobase.h(989): error: calling a __host__ function("__builtin_clzl") from a __device__ function("std::__lg") is not allowed
``` | bug,priority: low,category: build/install | low | Critical |
213,223,368 | go | cmd/cgo: permits reference to non-existent struct | This code compiles and runs:
package main
import "C"
import "fmt"
var V C.struct_X
func main() {
fmt.Println(V)
}
It prints `{}`. That makes no sense. There is no type `X` here. It should give an error somewhere. | NeedsFix,compiler/runtime | low | Critical |
213,226,600 | vscode | Feature request: highlight problem indicator with color when problems exist | <!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode -->
- VSCode Version: 1.10.2
- OS Version: Windows 7 SP 1 & Windows 10
For a better callout (those icons aren't very noticeable normally), it would be nice if when there are errors or warnings detected, it highlighted the respective icon (yellow for warning, red for error).
| feature-request,ux,themes,error-list | medium | Critical |
213,233,268 | opencv | Feature Request: Set normal and up vector for WText3D | ##### System information (version)
- OpenCV => latest
- Operating System / Platform => Ubuntu 16.04
- Compiler => GCC 5.4
##### Detailed description
Currently when using [WText3D](http://docs.opencv.org/3.1.0/d6/d3d/classcv_1_1viz_1_1WText3D.html) only the position and text_scale can be set, I want to control the normal and upvector just like [WPlane](http://docs.opencv.org/3.1.0/d8/d01/classcv_1_1viz_1_1WPlane.html), but I can't do it so I am unable to orient the text in the right direction I like. Can we have this function added? Isn't WText3D just kinda like WPlane with a built in alpha channel?
| feature,category: viz | low | Minor |
213,240,452 | go | x/net/xsrftoken: move away from SHA-1 | SHA-1 is not considered secure any more. | NeedsFix | low | Minor |
213,242,192 | go | cmd/vet: -shadow false positive | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
```
go version go1.7.1 darwin/amd64
```
A sample code:
```go
package main
import (
"fmt"
"github.com/pkg/errors"
)
func main() {
var err error
defer func() {
// Rear the mistake here is just a local error in processing logic, does not belong to the end to unified handling errors
if err := errors.New(""); err != nil {
fmt.Println(err)
}
// Business logic mistakes need to deal with here
fmt.Println(err)
}()
if err = errors.New(""); err != nil {
return
}
if err = errors.New(""); err != nil {
return
}
}
```
Run the command `go tool vet -shadow *.go` to get :
```
sample.go:14: declaration of "err" shadows declaration at sample.go:10
```
I think there is no question of such code, in the main function in the defer if caused by using the local err statement.
| NeedsFix,Analysis | low | Critical |
213,281,410 | vscode | Alt + Numpad keybindings insert characters into editor | - VSCode Version: Code 1.10.2 (8076a19fdcab7e1fc1707952d652f0bb6c6db331, 2017-03-08T14:02:52.799Z)
- OS Version: Windows_NT ia32 10.0.14393
- Extensions:
|Extension|Author|Version|
|---|---|---|
|plantuml|jebbs|1.2.5|
|cpptools|ms-vscode|0.10.2|
|debugger-for-chrome|msjsdiag|2.6.0|
|language-vscode-javascript-angular2|nwallace|0.0.11|
|language-plantuml|qhoekman|0.0.3|
|nativescript|Telerik|0.6.1|;
---
Old schoold people like me, still want the numlock key disabled. This means that "ALT + arrows" (and using the arrows on the numpad of a desktop keyboard) results in inserting an ascii code instead in addition to the keyboard shortcut defined in VSCode.
Steps to Reproduce:
1. Open the editor with some text separated by newlines
2. ALT + Up arrow and ALT + Down arrow move the lines up and down
3. Now turn off the numlock on the keyboard
4. repeat the step at point (2):
ALT + Up Arrow (on the numpad) lead to inserting the character ◘
ALT + Down Arrow (on the numpad) lead to inserting the character ☻
I expect the behavior is consistent with Visual Studio where ascii characted are never injected on these keyboard combinations.
Thanks
| feature-request,keybindings,windows | low | Critical |
213,287,853 | opencv | CvVideoCamera : repeatedly stop cause app crash | **System information (version)**
OpenCV => 3.2.0
Operating System / Platform => macOS 10.12.12
Compiler => Xcode Version 8.2.1 (8C1002)
**Detailed description**
iOS 10 using CvVideoCamera, when repeatedly start/stop it crashes
**Steps to reproduce**
```objc
- (void) initializeCamera {
self->videoCamera = [[CvVideoCamera alloc] initWithParentView:cameraView];
self->videoCamera.delegate = self;
self->videoCamera.defaultAVCaptureDevicePosition = AVCaptureDevicePositionBack;
self->videoCamera.defaultAVCaptureSessionPreset = AVCaptureSessionPresetHigh;
videoCamera.useAVCaptureVideoPreviewLayer = true;
videoCamera.defaultAVCaptureVideoOrientation = AVCaptureVideoOrientationPortrait;
videoCamera.videoCaptureConnection.videoOrientation = AVCaptureVideoOrientationPortrait;
videoCamera.captureVideoPreviewLayer.connection.videoOrientation = AVCaptureVideoOrientationPortrait;
self->videoCamera.defaultFPS = 24;
}
- (void)startCamera {
[self initializeCamera];
[self->videoCamera start];
self->stillImageOutput = [AVCaptureStillImageOutput new];
[self->videoCamera.captureSession addOutput:stillImageOutput];
}
- (void)stopCamera {
[self->videoCamera stop];
videoCamera = nil;
stillImageOutput = nil;
}
```
**Logs**
```
*** -[AVCaptureSession addInput:] Can't add a nil AVCaptureInput{
0 CoreFoundation __exceptionPreprocess + 124
1 libobjc.A.dylib objc_exception_throw + 56
2 AVFoundation -[AVCaptureSession addInput:] + 964
3 Tessa α (null)
4 Tessa α (null)
5 Tessa α (null)
6 Tessa α (null)
7 Tessa α (null)
8 Tessa α (null)
9 Tessa α (null)
10 Tessa α (null)
11 UIKit -[UIViewController _setViewAppearState:isAnimating:] + 624
12 UIKit -[UIViewController __viewWillAppear:] + 156
13 UIKit __56-[UIPresentationController runTransitionForCurrentState]_block_invoke + 1096
14 UIKit _runAfterCACommitDeferredBlocks + 292
15 UIKit _cleanUpAfterCAFlushAndRunDeferredBlocks + 560
16 UIKit _afterCACommitHandler + 168
17 CoreFoundation __CFRUNLOOP_IS_CALLING_OUT_TO_AN_OBSERVER_CALLBACK_FUNCTION__ + 32
18 CoreFoundation __CFRunLoopDoObservers + 372
19 CoreFoundation __CFRunLoopRun + 1024
20 CoreFoundation CFRunLoopRunSpecific + 444
21 GraphicsServices GSEventRunModal + 180
22 UIKit -[UIApplication _run] + 684
23 UIKit UIApplicationMain + 208
24 Tessa α (null)
25 libdyld.dylib start + 4
}
``` | bug,priority: low,category: videoio(camera),platform: ios/osx | low | Critical |
213,294,149 | TypeScript | JSDoc comment nodes are not traversed and their parents are sent even if they should not | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
**TypeScript Version:** 2.2.1
**Code**
```ts
const ts = require('typescript');
const source = `
/**
* Some fancy comment
*
* @function sum
* @param {number} a
* @param {number} b
* @returns {number}
*/
function sum(a: number, b: number): number {
return a + b;
}
`;
let sourceFile = ts.createSourceFile(
'input.ts',
source,
ts.ScriptTarget.ESNext,
false // <-- don't set parents
);
ts.forEachChild(sourceFile, function (node) {
if (node.kind === ts.SyntaxKind.FunctionDeclaration) {
console.assert(!!node.jsDoc);
console.assert(node.jsDoc.length === 1);
console.assert(node.jsDoc[0].parent === undefined);
} else if (node.kind === ts.SyntaxKind.JSDocComment) {
console.assert(false);
}
});
```
**Expected behavior:**
* Expected `JSDocComment` nodes parents not to be set.
* Expected `JSDocComment` nodes to be traversed using `forEachChild`.
**Actual behavior:**
When explicitly passing `false` to `createSourceFile` for not setting parents in nodes, they are set anyway in all `JSDocComment` nodes. Also, `JSDocComments` (and therefore all their children) are not traversed when calling `forEachChild`. I don't know if that last part is expected behavior, but it is definitely weird that they are not traversed. | Bug,Help Wanted,API | low | Critical |
213,386,590 | electron | Subclass of native classes (re-consider or update docs) | I've just discovered that `BrowserWindow` and other native classes of Electron shouldn't be sub-classed, @zcbenz has provided an explanation for this choice in 2013 here: https://github.com/electron/electron/issues/23.
I am wondering if this can be reconsidered since it has been decided when ES2015 wasn't around, and that V8 has changed a lot since (I don't know if it's now possible). Today, it's very natural to write:
```javascript
class MyBrowserWindow extends BrowserWindow {
constructor (options){
super(options)
// Do stuff
}
}
const myBrowserWindowInstance = new MyBrowserWindow({ height:600; width: 800 })
```
In my case, I am currently sub-classing `BrowserWindow` with no found caveats since Electron 1.4.x, except when using methods that check the equality of `myBrowserWindowInstance.constructor` with `BrowserWindow` (for example in `Menu` and `dialog` methods, see here https://github.com/electron/electron/issues/8895).
**If this is definitely a won't fix, the documentation should specify that native classes of Electron shouldn't be sub-classed.** | discussion,component/BrowserWindow | low | Major |
213,388,608 | go | runtime: working with small maps is 4x-10x slower than in nodejs | Please answer these questions before submitting your issue. Thanks!
#### What did you do?
Hello up there. Map performance was already discussed some time ago in #3885 and improved a bit. It was also said there that the map algorithm is choosen to work very well with very very large maps. However maps are not always very very large and imho in many practical cases they are small and medium.
So please consider the following 3 programs:
```go
package main
//import "fmt"
func main() {
a := make(map[int]int)
for i := 0; i < 100000000; i++ {
a[i & 0xffff] = i
//a[i & 0x7f] = i
//a[i] = i
}
//fmt.Println(a)
}
```
(https://play.golang.org/p/rPH1pSM1Xk)
```javascript
#!/usr/bin/env nodejs
function main() {
var a = {};
for (var i = 0; i < 100000000; i++) {
a[i & 0xffff] = i;
//a[i & 0x7f] = i;
//a[i] = i;
}
//console.log(a)
}
main()
```
```python
#!/usr/bin/env pypy
def main():
a = {}
for i in range(100000000):
a[i & 0xffff] = i
#a[i & 0x7f] = i
#a[i] = i
#print(a)
if __name__ == '__main__':
main()
```
The time it takes to run them on i7-6600U is as follows:
Program | Time (seconds, best of 5)
------------ | -------------
map.go | 3.668
map.js | 0.385
map.py | 1.988
The go version is 9.5x slower than javascript one, and ~ 1.8x slower than pypy one.
If we reduce the actual map size from 64K elements to 128 elements, activating the `a[i & 0x7f] = i` case via e.g. the following patch:
```diff
--- a/map.go.kirr
+++ b/map.go
@@ -5,8 +5,8 @@ func main() {
a := make(map[int]int)
for i := 0; i < 100000000; i++ {
- a[i & 0xffff] = i
- //a[i & 0x7f] = i
+ //a[i & 0xffff] = i
+ a[i & 0x7f] = i
//a[i] = i
}
```
timings become:
Program | Time (seconds, best of 5)
------------ | -------------
map.go | 1.571
map.js | 0.377
map.py | 0.896
javascript becomes only a bit faster here while go & pypy improved ~ 2.3x / 2.2x respectively. Still go is 4x slower than javascript and 1.7x slower than pypy.
We can also test how it works if we do not limit the map size and let it grow on every operation. Yes, javascript and pypy are more memory hungry and for original niter=1E8 I'm getting out-of-memory in their cases on my small laptop, but let's test with e.g. niter=1E7 (diff to original program):
```diff
--- a/map.go.kirr
+++ b/map.go
@@ -4,10 +4,10 @@ package main
func main() {
a := make(map[int]int)
- for i := 0; i < 100000000; i++ {
- a[i & 0xffff] = i
+ for i := 0; i < 100000000 / 10; i++ {
+ //a[i & 0xffff] = i
//a[i & 0x7f] = i
- //a[i] = i
+ a[i] = i
}
//fmt.Println(a)
```
timings become:
Program | Time (seconds, best of 5)
------------ | -------------
map.go | 2.877
map.js | 0.438
map.py | 1.277
So it is go/js ~6.5x slower and go/pypy is ~2.2x slower.
The profile for original program (`a[i & 0xffff] = i`) is:
```
File: map
Type: cpu
Time: Mar 10, 2017 at 7:18pm (MSK)
Duration: 3.70s, Total samples = 36ms ( 0.97%)
Entering interactive mode (type "help" for commands, "o" for options)
(pprof) top10
Showing nodes accounting for 36000us, 100% of 36000us total
flat flat% sum% cum cum%
27800us 77.22% 77.22% 33900us 94.17% runtime.mapassign /home/kirr/src/tools/go/go/src/runtime/hashmap.go
3100us 8.61% 85.83% 3100us 8.61% runtime.aeshash64 /home/kirr/src/tools/go/go/src/runtime/asm_amd64.s
3000us 8.33% 94.17% 3000us 8.33% runtime.memequal64 /home/kirr/src/tools/go/go/src/runtime/alg.go
1700us 4.72% 98.89% 36000us 100% main.main /home/kirr/tmp/trashme/map/map.go
400us 1.11% 100% 400us 1.11% runtime.mapassign /home/kirr/src/tools/go/go/src/runtime/stubs.go
0 0% 100% 36000us 100% runtime.main /home/kirr/src/tools/go/go/src/runtime/proc.go
```
#### What did you expect to see?
Map operations for small / medium maps are as fast or better than in nodejs.
#### What did you see instead?
Map operations are 4x-10x slower than in javascript for maps sizes that are commonly present in many programs.
#### Does this issue reproduce with the latest release (go1.8)?
Yes.
#### System details
```
go version devel +d11a2184fb Fri Mar 10 01:39:09 2017 +0000 linux/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/kirr/go"
GORACE=""
GOROOT="/home/kirr/src/tools/go/go"
GOTOOLDIR="/home/kirr/src/tools/go/go/pkg/tool/linux_amd64"
GCCGO="/usr/bin/gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build714926978=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOROOT/bin/go version: go version devel +d11a2184fb Fri Mar 10 01:39:09 2017 +0000 linux/amd64
GOROOT/bin/go tool compile -V: compile version devel +d11a2184fb Fri Mar 10 01:39:09 2017 +0000 X:framepointer
uname -sr: Linux 4.9.0-2-amd64
Distributor ID: Debian
Description: Debian GNU/Linux 9.0 (stretch)
Release: 9.0
Codename: stretch
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Debian GLIBC 2.24-9) stable release version 2.24, by Roland McGrath et al.
gdb --version: GNU gdb (Debian 7.12-6) 7.12.0.20161007-git
```
Thanks beforehand,
Kirill
/cc @rsc, @randall77 | Performance,NeedsInvestigation,compiler/runtime | high | Critical |
213,400,347 | go | misc/trace: events disappear at high zoom | ### What version of Go are you using (`go version`)?
go version go1.8 linux/amd64
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/austin/r/go"
GORACE=""
GOROOT="/home/austin/.cache/gover/1.8"
GOTOOLDIR="/home/austin/.cache/gover/1.8/pkg/tool/linux_amd64"
GCCGO="/usr/bin/gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build085760083=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
```
### What did you do?
Use `go tool trace` on the trace from https://github.com/golang/go/issues/19378#issuecomment-284020538. Zoom in around timestamp 208,125 ms.
### What did you expect to see?
All of the events in the visible time window, regardless of zoom.
### What did you see instead?
When the zoom gets close enough to show a few milliseconds on the screen (it happens around 8 ms for me), the sweep events on proc 0 start to flicker, shift around, and disappear. If you keep zooming in, several of them will disappear entirely. You can tell that they should be there by clicking on one of the events that's still visible, pressing left or right a few times to navigate to a neighboring event, and then pressing 'm' to mark the duration of the selected event. If you're on one of the invisible events, it will highlight a range that appears to have nothing in it.
Zoomed close but not too close:
Zoomed very slightly closer:
/cc @dvyukov
| help wanted,NeedsFix | low | Critical |
213,402,535 | go | runtime: measure actual CPU time of GC | Currently, the CPU time we report for GC in the gctrace is based on the assumption that each GC worker actually gets the CPU for the full wall-clock duration it runs for. This is a bad assumption on over-subscribed systems. We've seen this internally when users set GOMAXPROCS too high or have other processes in the same cgroup that consume too much CPU and the cgroup throttles execution. This may also be relevant to #19378.
We should consider asking the OS for actual CPU consumed by GC and reporting that. Comparing this with wall-clock time in the gctrace will give both us and users a better sense of any environmental problems causing long GC phases.
We should also consider how GC pacing would be affected by measuring actual CPU time versus wall-clock CPU time.
/cc @RLH | compiler/runtime | low | Major |
213,419,713 | kubernetes | Pod cgroup sandbox should be cleaned up in the pod worker | Cleaning up the pod cgroup in the pod worker is more efficient than relying on the periodic cleanup routine (`HandlePodCleanup`).
This would also allow removing the extra condition (see https://github.com/kubernetes/kubernetes/pull/42585/files#r105076567) that may cause even more races .
Ref: #42893
/cc @derekwaynecarr @dashpole @Random-Liu @dchen1107 | priority/important-soon,kind/cleanup,sig/node,lifecycle/frozen | low | Major |
213,453,686 | three.js | Memory pool for RenderTargets to help with complex EffectComposer pipelines | ##### Description of the problem
I have a lot of effects on my ThreeJS scenes. Right now with the way ThreeJS's effects are designed, they each allocate their own render targets, even their intermediate/temporary render targets. This leads to somewhere around 50 render targets allocated for my specific use case. But really only a couple are ever used at the same time, the rest are just setting there wasting memory and causing out of memory errors are various devices, especially high resolution (QHD/4K) + low memory mobile devices.
I am thinking that if we create a memory pool ( https://en.wikipedia.org/wiki/Memory_pool ) for RenderTargets we could decrease the maximum amount of memory required for complex EffectComposer pipelines without sacrificing speed or quality.
The design would be something like:
RenderTargetPool:
allocate( width, height, options ) -> renderTarget;
free( renderTarget )
nextFrame() - increase current frame.
disposeOld( oldness ) - to dispose all targets not recently used (could be all)
disposeAll() -- to be called once done or in the case of a resize (see below.)
This memory pool would track which render targets are currently in use (which haven't been returned) and allocate new ones if needed. But it would try to recycle as much as possible. I'd keep it simple and track the current frame and allow explicit disposal of those render targets that haven't been used in a recent frame (specified by the user - but I think a value of 10 is pretty reasonable for most use cases) or all current render targets (if ending the rendering.)
This will automatically minimally allocate render targets.
I guess the only issue is how to handle resizes. Right now ThreeJS will resize render targets when the render region changes shape. I wonder if we adopt the RenderTargetPool we could just dispose all in that case and recreate render targets of the new size -- I think that is how it works underneath anyhow.
Only intermediate render targets can be used via the pool. Those that persist such those that back up textures attached to objects need to have explicitly controlled lifetimes.
Thoughts welcome.... this is just an idea on how to solve our issue while making Three.JS easier and more efficient.
##### Three.js version
- [x] Dev
- [x] r84
##### Browser
- [x] All of them
##### OS
- [x] All of them | Enhancement,Post-processing | low | Critical |
213,464,023 | kubernetes | Proposal: versioned DaemonSet | Pod running as a Daemon Set is usually responsible for some operations on the node. With new releases of node components the environment for those operations can happen. Since usually DS is updated together with the master node and we are committed to support a few past versions of nodes due to backward compatibility it would be great to have a support to run different versions of the agent for different versions of the node.
For example I'd like to run fluentd in the following way:
- version 1.25 on nodes in version 1.4.x
- version 1.28 on nodes in version 1.5.x
- version 2.0 on nodes in version 1.6.x
Currently this can be done by creating 3 Daemon Sets separately which targets different node versions (though it's not obvious how do it, see #42840). This also generates additional maintenance overhead and general confusion (why do I need a DS for version 1.5.x while I don't have any nodes in this version).
The issue could be addressed by introducing an abstraction on top of DaemonSet which will manage daemon sets underneath in a similar manner that currently Deployment manages a set of ReplicaSets.
@bgrant0607 @erictune @janetkuo @kubernetes/sig-apps-feature-requests
cc @fgrzadkowski @crassirostris | kind/feature,sig/apps,area/workload-api/daemonset,lifecycle/frozen | low | Major |
213,467,774 | TypeScript | Way to Go From Method Implementation to Interface Method Declaration | <!-- BUGS: Please use this template. -->
<!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript -->
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md -->
From https://github.com/Microsoft/vscode/issues/22385
**TypeScript Version:** 2.2.1
**Code**
```ts
interface ITest {
test(): void;
}
class Test implements ITest {
test() {
return null;
}
}
```
**Request**
Running `go to definition` on `test` in class `Test` currently does not return `ITest::test`. Neither does `go to type definition`.
In VSCode, we would like some way to jump from a class's interface method implementation or abstract method implementation to the interface method declaration or abstract method declaration itself. I'm not sure which command makes sense to do this, either `go to definition` or `go to type definition`, but we are open to any suggestions
| Suggestion,Awaiting More Feedback,VS Code Tracked,Domain: Symbol Navigation | low | Critical |
213,469,778 | go | x/term: cross-platform key codes | Add cross-platform key identifiers that can be used to detect keypresses for user shortcuts regardless of keyboard layouts.
More info:
- https://stackoverflow.com/questions/8737566/rolling-ones-own-keyboard-input-system-in-c-c
- https://hg.libsdl.org/SDL/file/default/include/SDL_scancode.h
- http://www.usb.org/developers/hidpage/Hut1_12v2.pdf
About names - let's keep them consistent with SDL:
- KeyUp
- KeyPageUp
| NeedsInvestigation | low | Minor |
213,470,489 | go | x/net/proxy: add HTTP CONNECT support | This is a proposal to add HTTP CONNECT support to x/net/proxy package.
### Implement HTTP CONNECT dialer
As what’s done for socks5, we can add an implementation for HTTP CONNECT dialer, it dials to the proxy, and then does a HTTP CONNECT handshake.
Also, we can register this dialer to proxySchemes with key “http” and key “https” as default dialers. This should be done in an init() function, so that users can overwrite those with their custom dialers if they want.
### Add function `FromEnvironmentForScheme(scheme)`
Like `FromEnvironment()`, this function returns a dialer.
The existing function `FromEnvironment()` checks the environment variable “all_proxy”, while in the case of HTTP CONNECT, we would want to use “http_proxy” and “https_proxy”.
The new function `FromEnvironmentForScheme()` checks https_proxy, http_proxy and all_proxy based on the scheme.
- If scheme is "https", it checks https_proxy, http_proxy and all_proxy.
- If scheme is "http", it checks http_proxy and all_proxy.
- In other cases, it checks all_proxy.
### Add `DialContext()` function
As requested in https://github.com/golang/go/issues/17759.
Adding `DialContext()` to `Dialer` interface will be a breaking change though. What's proposed in #17759 seems like a good solution. | NeedsInvestigation,FeatureRequest | low | Major |
213,493,076 | opencv | VideoCapture::read() returns "true" erroneously | I am using opencv 3.2 with VS2017 on Windows 10 and noticed that there is a problem with VideoCapture and webcams. If I open my USB webcam from some other application so that it is displaying video and then do something this:
```
m_webCam = cv::VideoCapture(0);
bool ok = false;
ok = m_webCam.read(m_frame);
```
`ok` is true after this. I was using opencv 3.1 and Visual Studio 2015 and I can confirm it returned false. Either moving to opencv 3.2 or Visual Studio 2017 broke the functionality. Because this returns true, m_frame ends up having uninitialized data and causes my program to hang somewhere within the system code. If I break my application during the hang it is off in never never land. Regardless, the read() function should definitely be returning false in this situation.
I also checked and `m_webCam.isOpen` also returns true.
| bug,priority: low,category: videoio(camera),platform: win32 | low | Major |
213,517,530 | rust | Undetected unconditional recursion in Clone impl using to_owned() | ```rust
fn main() {
struct Foo;
impl Clone for Foo {
fn clone(&self) -> Self {
self.to_owned()
}
}
Foo.clone();
}
```
Rustc gives no warning, but this overflows the stack.
Slightly more realistic example:
```rust
fn main() {
use std::borrow::{Borrow, ToOwned};
use std::ops::Deref;
struct Foo;
struct Borrowed;
impl Deref for Foo {
type Target = Borrowed;
fn deref(&self) -> &Borrowed {
unimplemented!()
}
}
impl Borrow<Borrowed> for Foo {
fn borrow(&self) -> &Borrowed {
&*self
}
}
impl ToOwned for Borrowed {
type Owned = Foo;
fn to_owned(&self) -> Foo {
unimplemented!()
}
}
impl Clone for Foo {
fn clone(&self) -> Self {
(*self).to_owned() // Oops, should have dereferenced twice
}
}
Foo.clone();
}
```
([Real life use case for implementing `Clone` through `deref -> to_owned`](https://github.com/jeremyletang/rust-sfml/blob/941a53008d3385ec4e578deabc398a8851eecd69/src/audio/sound_buffer.rs#L219-L236))
Is it feasible for rustc to detect this kind of cross-trait unconditional recursion? | C-enhancement,A-lints,T-compiler | low | Minor |
213,520,560 | go | runtime: better support for 64bit div/mod operations on 32bit platforms | encountered in https://go-review.googlesource.com/c/38071/:
assuming x and y are uint64:
```
q = x/y
r = x%y
```
only uses a single DIV instruction on amd64 however on 386 this makes a runtime call to
uint64div and one to uint64mod.
1) Both could be handled calculated together in a combined uint64divmod runtime call
2) In case y is constant the compiler could optimize the calculation to not require a div and not need a runtime call
| Performance,compiler/runtime | low | Major |
213,527,825 | kubernetes | End-2-end encrypted kubectl exec using SSH as protocol | The current kubectl-exec implementation is using the transport encryption from the kubectl to the apiserver and the transport encryption from the apiserver to the kubelet to tunnel the terminal data. The terminal data itself is not protected otherwise, i.e. the apiserver can read everything in plain text.
This is a potential attack surface as taking over the apiserver allows to watch execs and/or to even initiate them to attack any pod and compromise it.
**In other words, this issue is part of the investigation of how containers on the node can be protected if the apiserver cannot be fully trusted.**
The basic idea is:
- use end-2-end encrypted connections from kubectl to the pods for kubectl-exec (and -run and -port-forward)
- using SSH as the binary protocol
- by letting the kubelet spawn ad-hoc SSH servers on each connection
- add an ssh subcommand to kubectl like `kubectl ssh -i ~/.ssh/kube-rsa pod-name /bin/bash`.
The SSH public key will be provided somehow to the kubelet. One approach would be to pass them as an annotation of a pod. But as the apiserver by assumption cannot be trusted, also the annotation cannot be trusted. This means that measures are necessary to protect against the apiserver playing man-in-the-middle by faking the public keys in the pod's annotation. So probably the kubectl needs some kind of identity check that it is talking to the kubelet and no man-in-the-middle.
| area/security,sig/node,sig/api-machinery,kind/feature,sig/architecture,lifecycle/frozen,triage/needs-information,sig/security | medium | Major |
213,564,024 | youtube-dl | [kaltura] Support playlists | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.03.10**
```
~$ youtube-dl --version
2017.03.10
```
### I have
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- #5081 and #6137 were fixes in past versions, I think
- #12041 indicates a non-url format for single Kaltura videos; I tried this with the playlist ID and got an extractor error (also below)
### purpose of issue
- [x] Bug report (encountered problems with youtube-dl)
---
### verbose output
```
~$ youtube-dl -v "https://cdnapisec.kaltura.com/html5/html5lib/v2.41/mwEmbedFrame.php/p/1770401/uiconf_id/34290512?wid=_1770401&iframeembed=true&playerId=kaltura_player_1484154962&flashvars%5BstreamerType%5D=auto&flashvars%5BplaylistAPI.kpl0Id%5D=0_pmra4snw"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'https://cdnapisec.kaltura.com/html5/html5lib/v2.41/mwEmbedFrame.php/p/1770401/uiconf_id/34290512?wid=_1770401&iframeembed=true&playerId=kaltura_player_1484154962&flashvars%5BstreamerType%5D=auto&flashvars%5BplaylistAPI.kpl0Id%5D=0_pmra4snw']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.03.10
[debug] Python version 2.7.13 - Darwin-14.5.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.2, ffprobe 3.2, rtmpdump 2.4
[debug] Proxy map: {}
ERROR: Invalid URL
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 761, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 427, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/kaltura.py", line 248, in _real_extract
raise ExtractorError('Invalid URL', expected=True)
ExtractorError: Invalid URL
```
Trying the format from #12041 (see above) with parameters taken from URL:
```
~$ youtube-dl -v kaltura:1770401:0_pmra4snw
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'kaltura:1770401:0_pmra4snw']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.03.10
[debug] Python version 2.7.13 - Darwin-14.5.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.2, ffprobe 3.2, rtmpdump 2.4
[debug] Proxy map: {}
[Kaltura] 0_pmra4snw: Downloading video info JSON
ERROR: An extractor error has occurred. (caused by KeyError(u'dataUrl',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 427, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/kaltura.py", line 266, in _real_extract
data_url = info['dataUrl']
KeyError: u'dataUrl'
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 761, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 440, in extract
raise ExtractorError('An extractor error has occurred.', cause=e)
ExtractorError: An extractor error has occurred. (caused by KeyError(u'dataUrl',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
```
---
I tried archiving a playlist from kaltura but it's not working... also tried the non-URL `kaltura:` format with with the IDs in the URL, but it gave me an extractor error and said to report.
Thanks for any help | request | low | Critical |
213,613,612 | youtube-dl | [DirecTV.com] TV on Demand | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.03.10**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
```
C:\Users\Desktop\youtube-dl>youtube-dl.exe -f best --all-subs --username PRIVATE --password PRIVATE --ap-username PRIVATE --ap-password PRIVATE --ap-mso DTV https://www.directv.com/tv/Nickelodeon-s-2017-Kids-Choice-Awards-aEtWZkNzcjZlSWJybGQydnpFVzZCdz09 -v
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-f', 'best', '--all-subs', '--username', 'PRIVATE', '--password', 'PRIVATE', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--ap-mso', 'DTV', 'https://www.directv.com/tv/Nickelodeon-s-2017-Kids-Choice-Awards-aEtWZkNzcjZlSWJybGQydnpFVzZCdz09', '-v']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.03.10
[debug] Python version 3.4.4 - Windows-10-10.0.14393
[debug] exe versions: ffmpeg N-83034-gf48b6b8, ffprobe N-83096-g6596b34
[debug] Proxy map: {}
[generic] Nickelodeon-s-2017-Kids-Choice-Awards-aEtWZkNzcjZlSWJybGQydnpFVzZCdz09: Requesting header
WARNING: Could not send HEAD request to https://www.directv.com/tv/Nickelodeon-s-2017-Kids-Choice-Awards-aEtWZkNzcjZlSWJybGQydnpFVzZCdz09: HTTP Error 503: Service Unavailable
[generic] Nickelodeon-s-2017-Kids-Choice-Awards-aEtWZkNzcjZlSWJybGQydnpFVzZCdz09: Downloading webpage
WARNING: Falling back on generic information extractor.
[generic] Nickelodeon-s-2017-Kids-Choice-Awards-aEtWZkNzcjZlSWJybGQydnpFVzZCdz09: Extracting information
ERROR: Unsupported URL: https://www.directv.com/tv/Nickelodeon-s-2017-Kids-Choice-Awards-aEtWZkNzcjZlSWJybGQydnpFVzZCdz09
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpj3l3ckzu\build\youtube_dl\YoutubeDL.py", line 761, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpj3l3ckzu\build\youtube_dl\extractor\common.py", line 427, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpj3l3ckzu\build\youtube_dl\extractor\generic.py", line 2648, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.directv.com/tv/Nickelodeon-s-2017-Kids-Choice-Awards-aEtWZkNzcjZlSWJybGQydnpFVzZCdz09
...
<end of log>
```
---
- Single video: https://www.directv.com/tv/Nickelodeon-s-2017-Kids-Choice-Awards-aEtWZkNzcjZlSWJybGQydnpFVzZCdz09
- Single video: https://www.directv.com/movies/Tangled-Before-Ever-After-Wm5nMTFuNzlyK3k4blJLK3dQMDJ5dz09
---
I don't know if you can add, but would be cool though :)
| tv-provider-account-needed | low | Critical |
213,659,340 | go | encoding/gob: slow map decoding | ### What version of Go are you using (`go version`)?
go version go1.8 linux/amd64
### What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/opennota/gocode"
GORACE=""
GOROOT="/home/opennota/go"
GOTOOLDIR="/home/opennota/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build966707479=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
PKG_CONFIG="pkg-config"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
### What did you do?
I tried to encode a big map to gob
1. as a map.
2. as slices of keys and values
and decode the encoded data back. In the first case the data decodes almost 3x slower.
https://play.golang.org/p/ZpHC-4I9p1
Output:
```
533.188157ms
180.698776ms
``` | Performance | low | Critical |
213,670,862 | TypeScript | Preserve JSDocs in *.d.ts files when stripping comments | # Suggestion/Feature
When using the switch ```removeComments``` it will strip out all comments including the ones you may consider useful to the end consumer such as JSDocs. I'd like to strip out any internal comments but preserve any JSDocs comments. It seems that an option to preserve comments in types would be sufficient.
## Existing functionality
```json
"removeComments": true,
"declaration": true,
```
removes all comments including those in *.d.ts files.
## Suggested functionality
```json
"removeComments": true,
"declaration": true,
```
I would think by default you'd want to include the JSDocs in your type defs, so this would remove all comments from the code, but retain any comments associated with the types ie JSDocs.
If however, there is a need to remove all comments then an additional switch may be required to serve that purpose:
```json
"removeCommentsIncludingDeclarations": true,
"declaration": true,
```
Would produce the same result we have today.
| Suggestion,In Discussion | high | Critical |
213,677,652 | TypeScript | Can not set static properties on arrow-function-initialized variables | ```ts
// @ts-check
const F1 = () => { };
F1.prop = 0; // Error prop does not exist on F
const F2 = function() { };
F2.prop = 0; // OK
``` | Bug,Domain: JavaScript | low | Critical |
213,711,484 | flutter | Custom URL scheme handling | Basically this is a feature request for handling custom URI scheme for inter-app communication within the framework.
The feature itself is pretty straightforward. Would like to provide additional description if necessary.
ref:
- https://developer.android.com/training/basics/intents/filters.html
- https://developer.android.com/training/app-links/index.html
- https://developer.apple.com/library/content/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/Inter-AppCommunication/Inter-AppCommunication.html
- https://developer.apple.com/library/content/featuredarticles/iPhoneURLScheme_Reference/Introduction/Introduction.html
| c: new feature,framework,f: routes,P3,team-framework,triaged-framework | low | Minor |
213,814,124 | rust | Tracking issue for spurious network failures on bots | I'm hoping to catalog network failures on the bots here just to keep an eye on the rate that they're happening as well as common failure modes. If they're common enough we should investigate solutions.
#### github errors
* https://travis-ci.org/rust-lang/rust/jobs/217835684 - failed to clone repo
* https://travis-ci.org/rust-lang/rust/jobs/217834828 - failed to clone repo
#### Submodule clone timeout
https://travis-ci.org/rust-lang/rust/jobs/210363616
```
Cloning into '/home/travis/build/rust-lang/rust/src/llvm'...
No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated
```
## Fixed faiulres
#### Failure to fetch OpenSSL tarball
Fixed by https://github.com/rust-lang/rust/pull/40545
https://travis-ci.org/rust-lang/rust/jobs/211285568
```
curl: (7) Failed to connect to www.openssl.org port 443: Connection refused
command did not execute successfully: "curl" "-o" "/checkout/obj/build/mipsel-unknown-linux-gnu/openssl/openssl-1.0.2k.tar.tmp" "https://www.openssl.org/source/openssl-1.0.2k.tar.gz"
expected success, got: exit code: 7
```
#### CentOS 5 urls changed
https://travis-ci.org/rust-lang/rust/jobs/218179477
hopefully fixed by https://github.com/rust-lang/rust/pull/41045
CentOS 5.11 become EOL, apparently the base image failed to keep succeeding at `yum update`
#### Crates.io errors
Presumed [bug in Cargo](https://github.com/rust-lang/cargo/pull/3890)
* https://travis-ci.org/rust-lang/rust/jobs/214573195 - during cargotest
* https://travis-ci.org/rust-lang/rust/jobs/214511796 - during cargotest
* https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2517/job/78c29lc858e7a0nh - corrupt download?
| A-spurious,T-infra,C-tracking-issue,A-CI | medium | Critical |
213,825,349 | rust | Consider specific warning for trying to use an existing variable in a pattern | According to the book, this is a common mistake (common enough to call out specifically, anyway):
fn compare(x: i32, y: i32) {
match x {
y => println!("match"), // wrong
_ => println!("no match")
}
}
fn main() { compare(3, 4); }
Rust currently emits 3 warnings:
* `y` argument is unused
* `y` match-binding is unused
* `_` pattern is unreachable
All are correct. But if this really is a common pitfall, it'd better for Rust to have a specific diagnostic for this problem.
The last two warnings, in combination with the other binding `y` already in scope, strongly suggest that the programmer has made this exact mental mistake. The third warning in particular shows that the programmer expected the pattern `y` to be refutable.
The new warning could be something like: "the identifier `y` in this pattern introduces a new variable (it does not refer to the variable `y` declared *here*)"
(Of course shadowing an existing binding is normal in other circumstances; I'm only proposing a different warning for certain situations where Rust already emits warnings.) | C-enhancement,A-diagnostics,T-compiler | low | Major |
213,837,339 | go | cmd/link: linker should be able to remove init functions with no side-effects | In this example:
`testlinker/a/a.go`
```go
package a
type DieDieType struct {
Test map[string]int
}
var DieDieVar = &DieDieType{
Test: make(map[string]int),
}
var Constant = 5
```
`testlinker/main.go`
```go
package main
import (
"fmt"
"testlinker/a"
)
func main() {
fmt.Println(a.Constant)
}
```
the linker is unable to remove references to `DieDieType` because it is referenced by `a.init`. But this init function, generated by the compiler to initialize `DieDieValue`, is actually useless, because it has no side-effects and only initializes a global variable that is then unreferenced. So the init function could be dropped, and this in turn would remove references to the types.
This is distilled from the analysis in #19523, where just referencing a constant in a package causes a very large growth of binary size because of a deep chain of dependencies which are not used by the program. I haven't fully tracked everything so I can't swear that all init functions are side-effects-free in that case, but I think there's a reasonable chance that it would fix that instance.
| binary-size,compiler/runtime | low | Major |
213,854,031 | rust | Derived traits in the standard library are missing stability information | `impl Default for Duration` was [added in 1.15](https://github.com/rust-lang/rust/pull/37699) but the [current documentation](https://doc.rust-lang.org/std/time/struct.Duration.html) doesn't indicate it wasn't available before that. | T-rustdoc,A-stability,T-compiler,C-bug | low | Major |
213,865,278 | rust | rustc does not understand linker scripts with `GROUP` statements | I'm statically linking dpdk (`libdpdk.a`) to a rust rlib via Cargo. The compiler fails with `failed to add native library /Volumes/Source/GitHub/lemonrock/dpdk/components/dpdk-sys/compile-dpdk.conf.d/temporary/destdir/usr/local/lib/libdpdk.a: failed to open archive`. This archive is actually a linker script which contains a `GROUP` statement\*. Such linker scripts occur when dealing with native C libraries from time-to-time, particularly on libraries only targeting Linux systems (which have historically used the GNU tools which supported them). I also recall them being used in the past for some ?glibc? .so files.
I'm surprised rustc fails on this - I'd incorrectly assumed it would have just passed the linked argument (`-l static=dpdk`) down to the linker (`cc` in this case). I think rustc should gain some knowledge of these scripts; technically a `GROUP` is supposed to be interpreted as `-Wl,-(` malarky IIRC.
I have a workaround I can implement via a `build.rs` for now, so this isn't critical to me - just open the linker script and spit out the contents to rustc as a bunch of links - but this probably isn't technically correct as I note above. Note, personally, I'm not a fan of linker scripts, but they have their place, I suppose; for those not authoring exotic alternatives to ELF or writing bare metal, they're handy for listing dependencies of dependencies when static linking. I just wish the original authors had used a different file extension for them...
\* FYI, contents of `libdpdk.a`: `GROUP ( librte_acl.a librte_cfgfile.a librte_cmdline.a librte_cryptodev.a librte_distributor.a librte_eal.a librte_efd.a librte_ethdev.a librte_hash.a librte_ip_frag.a librte_jobstats.a librte_kni.a librte_kvargs.a librte_lpm.a librte_mbuf.a librte_mempool.a librte_meter.a librte_net.a librte_pdump.a librte_pipeline.a librte_pmd_af_packet.a librte_pmd_bnxt.a librte_pmd_bond.a librte_pmd_cxgbe.a librte_pmd_e1000.a librte_pmd_ena.a librte_pmd_enic.a librte_pmd_fm10k.a librte_pmd_i40e.a librte_pmd_ixgbe.a librte_pmd_nfp.a librte_pmd_null.a librte_pmd_null_crypto.a librte_pmd_qede.a librte_pmd_ring.a librte_pmd_sfc_efx.a librte_pmd_tap.a librte_pmd_vhost.a librte_pmd_virtio.a librte_pmd_vmxnet3_uio.a librte_port.a librte_power.a librte_reorder.a librte_ring.a librte_sched.a librte_table.a librte_timer.a librte_vhost.a )` | A-linkage,T-compiler,C-bug | low | Critical |
213,914,550 | go | x/build: make linux-amd64-noopt builder also a pre-submit TryBot | CL 37751 would have benefitted from this. | Builders,NeedsDecision,FeatureRequest | low | Major |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.