id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
---|---|---|---|---|---|---|
203,829,854 | youtube-dl | Add support for Adobe Pass Auth TV provider Frontier Communications | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.01.28*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2017.01.28**
### Before submitting an *issue* make sure you have:
- [X] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [X] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### Description of your *issue*, suggested solution and other information
Would like to request support for Frontier Communications as an Adobe Pass MSO option. I believe the MSO ID is FRONTIER. | tv-provider-account-needed | low | Critical |
203,830,190 | rust | Non-upper case constant warning misapplied in patterns | A constant with `#[allow(non_upper_case_globals)]` applied still generates a warning when used in a pattern, unless the `match` also has the allow attribute. For example:
```rust
#[allow(non_upper_case_globals)]
mod keywords {
pub const If: u32 = 0;
pub const While: u32 = 1;
}
fn main() {
use keywords::*;
// the warning goes away with this attribute:
// #[allow(non_upper_case_globals)]
match 0 {
keywords::If => println!("if"),
While => println!("while"),
_ => println!("<unknown>"),
}
}
```
[Playground](https://is.gd/jzNZQB) | A-lints,I-needs-decision,T-compiler,C-bug | low | Major |
203,853,311 | pytorch | Add Peephole connections for LSTMs? | From this [paper](http://www.jmlr.org/papers/volume3/gers02a/gers02a.pdf). Peephole connections seem to help in learning precise timings of events. | feature,triaged,Stale | medium | Major |
203,865,042 | youtube-dl | Lynda.com: Add support for extraction of "release-date" & "update-date" html elements | [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.01.28**
[x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Feature request (request for a new functionality)
Hi there,
at the moment, youtube-dl is not supporting the output template "release_date" for Lynda.com courses.
It would be very nice if someone could add a support for extraction of a Lynda.com's course release/update date. The html element ids are "update-date" and "release-date".
The output template should then add the newest of those two dates to the folder/path name in descending order.
E.g. for https://www.lynda.com/Java-tutorials/Up-Running-Java-Applications/435790-2.html with above ids (Updated: 8/1/2016, Released: 2/22/2016)
and the usage of the following commands: youtube-dl --output "E:\Downloads\\%%(playlist)s (%%(release_date)s)\\
=> E:\Downloads\Up and Running with Java Applications (2016-8-1)\
Best regards
| request | low | Critical |
203,882,473 | go | x/net/webdav: PROPFIND fails on OpenBSD if the directory has a unix domain socket in it | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
1.7.4
### What operating system and processor architecture are you using (`go env`)?
openbsd/amd64
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="openbsd"
GOOS="openbsd"
GOPATH="/home/stuart/go"
GORACE=""
GOROOT="/home/stuart/.goroot"
GOTOOLDIR="/home/stuart/.goroot/pkg/tool/openbsd_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -fmessage-length=0"
CXX="g++"
CGO_ENABLED="0"
### What did you do?
If possible, provide a recipe for reproducing the error.
1. Make a unix domain socket in a temporary directory
2. Serve the directory with x/net/webdav
3. Try to list the directory with the socket
Code used to serve directory.
http://play.golang.org/p/ClPtJ4beK4
For the socket, `socat unix-listen:testpipe - & pkill -9 socat` works.
### What did you expect to see?
A listing of the directory contents.
### What did you see instead?
```
dav:/> ls
Listing collection `/': failed:
XML parse error at line 1: junk after document element
```
The problem seems to be in the function `props` in `/x/net/webdav/prop.go`. It opens every file to get its dead properties. Unfortunately, on OpenBSD, opening a unix socket (as opposed to connecting to it), returns EOPNOTSUPP. | OS-OpenBSD | low | Critical |
203,886,342 | pytorch | Feature Request: NegativeSampling and HierarchicalSoftmax loss functions | It's a bit difficult to write a SkipGram word2vec model without these functions.
Not entirely sure, but the Chainer implementations for [NegativeSampling](https://github.com/pfnet/chainer/blob/master/chainer/links/loss/negative_sampling.py) and [HierarchicalSoftmax](https://github.com/pfnet/chainer/blob/master/chainer/links/loss/hierarchical_softmax.py) could be easily ported to pytorch.
I think this could be a useful addition to pytorch. Also, if you need some help in this, I might be able to find some time and submit a PR.
cc @albanD @mruberry @jbschlosser @walterddr @kshitij12345 @saketh-are @ezyang @ngimel | feature,module: nn,module: loss,triaged,Stale,module: primTorch | low | Major |
203,909,573 | youtube-dl | Please add support for Playstation Vue logins | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.01.29*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2017.01.29**
### Before submitting an *issue* make sure you have:
- [X] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [X] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### Description of your *issue*, suggested solution and other information
If you go to https://www.playstation.com/en-us/network/vue/ you can sign up for a free trial of Playstation Vue if you have a PlayStation Network account, and you just have to remember to cancel it within a week to not get billed for it if you don't want it. I have read in several places that a Playstation Vue login can be used in place of a cable or satellite provider login on several of the streaming sites, therefore if you could add Playstation Vue to the list of supported MSO's then perhaps youtube-dl would be able to download files from those services without the need for a separate cable or satellite subscription. | tv-provider-account-needed | low | Critical |
203,915,519 | rust | resolve: improve diagnostics for a single `super` at the crate root | For example,
```rust
fn main() {
let super = 0;
// ^^^^^ Ideally, the error here would be something like:
// - "the root module has not parent"
// - "`super` is not allowed in the crate root"
}
``` | C-enhancement,A-diagnostics,A-resolve,T-compiler | low | Critical |
204,071,120 | angular | Ngclass value not updating if form input field has errors. It seems to be one tick behind. | <!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING
-->
**I'm submitting a ...** (check one with "x")
```
[x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
```
**Current behavior**
<!-- Describe how the bug manifests. -->
The ngClass on a surrounding div is not updating correctly if I have an input field with a dynamic min length. The input field itself sets ng-valid or ng-invalid correctly.
**Expected behavior**
<!-- Describe what the behavior would be without the bug. -->
Both the input field and the surrounding div / ngClass should have the same valid / invalid status.
**Minimal reproduction of the problem with instructions**
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
https://plnkr.co/edit/amWsyRTLaHOIQv0x7qYi?p=preview for a preview.
Enter 1 for minimum length.
Enter test for actual input
Without erasing the 1, enter 2 for minimum input so that the min input becomes 12. You'll notice that it'll say Ngclass valid, input ng-invalid. Erase the 2, and then it'll say Ngclass invalid, input ng-valid. Alternate between 1 and 12 for min length, and the input and ngClass valid / invalid will alternate
* **Angular version:** 2.X latest
<!-- Check whether this is still an issue in the most recent Angular version --> | type: bug/fix,freq3: high,area: forms,state: confirmed,core: change detection,P3 | low | Critical |
204,109,326 | go | go/doc: enable grouping of functions with common names and suffix N | Suggested by @griesemer in another proposal: https://github.com/golang/go/issues/18616#issuecomment-275761203.
An example of the proposed before and after output, for a series of functions called `TrailingZeros` with integer sizes "N" as a suffix:
Before:
```
// TrailingZeros16 returns the number of trailing zero bits in x.
// The result is 16 if x == 0.
func TrailingZeros16(x uint16) uint
// TrailingZeros32 returns the number of trailing zero bits in x.
// The result is 32 if x == 0.
func TrailingZeros32(x uint32) uint
// TrailingZeros64 returns the number of trailing zero bits in x.
// The result is 64 if x == 0.
func TrailingZeros64(x uint64) uint
```
After:
```
// TrailingZerosN returns the number of trailing zero bits in a uintN value x for N = 16, 32, 64.
// The result is N if x == 0.
func TrailingZeros16(x uint16) uint
func TrailingZeros32(x uint32) uint
func TrailingZeros64(x uint64) uint
```
Seems like a big usability improvement, and would be useful in at least `sync/atomic` as it exists now in the stdlib: https://golang.org/pkg/sync/atomic/. Would also be useful for some of the proposed APIs for a `math/bits` as discussed here: https://github.com/golang/go/issues/18616 | NeedsInvestigation | low | Major |
204,121,745 | rust | Tracking issue: declarative macros 2.0 | Tracking issue for declarative macros 2.0 (aka `macro` aka decl_macro aka macros-by-example).
RFC: https://github.com/rust-lang/rfcs/blob/master/text/1584-macros.md
RFC PR: https://github.com/rust-lang/rfcs/pull/1584
cc @rust-lang/compiler
---
### About tracking issues
Tracking issues are used to record the overall progress of implementation.
They are also used as hubs connecting to other relevant issues, e.g., bugs or open design questions.
A tracking issue is however *not* meant for large scale discussion, questions, or bug reports about a feature.
Instead, open a dedicated issue for the specific matter and add the relevant feature gate label.
Discussion comments will get marked as off-topic or deleted.
Repeated discussions on the tracking issue may lead to the tracking issue getting locked.
## Tasks
- [ ] Complete the draft hygiene [prototype](https://github.com/jseyfried/rust/tree/hygiene) and [RFC](https://github.com/jseyfried/rfcs/blob/hygiene/text/0000-hygiene.md).
- [x] Hygiene for items, explicit imports, lexical scopes, and module scopes.
- [x] Hygiene for globs and trait methods (w.r.t. extension trait candidates in scope for a method call).
- [x] Hygiene for type directed name resolutions (i.e. methods, associated types, and fields).
- [x] Support `macro` in blocks as well as modules.
- [x] Implement inter-crate hygiene, except for nested `macro`s.
- [ ] Implement "hygiene bending" for when users want a name from macro def to "escape".
- Examples: https://github.com/rust-lang/rust/issues/91249, https://github.com/rust-lang/rust/issues/46342
- [ ] Implement inter-crate hygiene for nested `macro`s (pending macro def encoding).
- [ ] Make `private_in_public` hygienic?
- [ ] Make `unsafe` and lints hygienic (if appropriate)?
- [x] Add variant `ast::ItemKind::MacroDef` for `macro_rules!` items and `macro` items (PR #40220).
- [x] Encode `macro`s in the crate metadata using `TokenStream`, not `String`.
- [x] Fix #30476 (`private_in_public` details).
- [x] Fix span issues #30506 and #39450 (PR #40597).
- [x] Land `macro` behind a feature gate (PR #40847).
- [ ] Future-proof matchers (e.g. `$e:expr`) by employing a simpler, more general grammar.
- [ ] Allow fragments (e.g. `$e` where `$e:expr`) to be parsed in more contexts (c.f. #26361).
- [ ] Decide whether we want macro invocations in identifier positions and/or eager expansion.
- [x] ~Remove $:meta matcher (#49629)~
Potentially blocking issues:
- https://github.com/rust-lang/rust/issues/71614 | B-RFC-approved,A-macros,T-lang,B-unstable,C-tracking-issue,F-decl_macro,S-tracking-design-concerns | high | Critical |
204,128,640 | youtube-dl | Help adding DISH adobe support | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.01.29*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [ x] I've **verified** and **I assure** that I'm running youtube-dl **2017.01.29**
### Before submitting an *issue* make sure you have:
- [ x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [x ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### Description of your *issue*, suggested solution and other information
Ive been trying to add dish support for past few days on and off. I cant give login creditials out as
there my sisters. So im forced to try to get it working on my own :(
Anyway here is as much info as I have.
ive added to adobepadd.py
'Dish': {
'name': 'DISH',
'username_field': 'username',
'password_field': 'password',
},
url of redirect is similar to xfinity as its a redirect not a popup like most of rest
https://sp.auth.adobe.com/adobe-services/authenticate?requestor_id=syfy&no_iframe=false&mso_id=Dish&domain_name=syfy%2Ecom&redirect_url=http%3A%2F%2Fwww%2Esyfy%2Ecom%2Fkilljoys%2Fvideos%2F1%2F2616
which redirect too:
https://identity1.dishnetwork.com/saml/module.php/sociallogin/login.php?AuthState=_e1a33b890e60fbe4ae431ca47b642708b1f18a02c7%3Ahttps%3A%2F%2Fidentity1.dishnetwork.com%2Fsaml%2Fsaml2%2Fidp%2FSSOService.php%3Fspentityid%3Dhttps%253A%252F%252Fsaml.sp.auth.adobe.com%26cookieTime%3D1485809534%26RequesterID%3D%255B%2522syfy%2522%255D%26NameIDFormat%3Durn%253Aoasis%253Anames%253Atc%253ASAML%253A2.0%253Anameid-format%253Atransient
on this page there are 3 form elements.....1 of which is remember me button.
Online ID:
`<input placeholder="Online ID" class="input" id="username" type="text" name="username" value="" tabindex="1" autocapitalize="off" autocorrect="off" `required="">`
Password:
`<input` placeholder="Password" class="input" id="password" type="password" name="password" value="" tabindex="2" autocapitalize="off" autocorrect="off" `required="">`
Remember me check box:
`<input` type="checkbox" name="remember_me" value="yes" tabindex="4" `checked="checked">`
and login button:
`<button` id="login" type="submit" name="source_button" value="authsynacor_identity1.dishnetwork.com" class="login" tabindex="3">
Log In
`</button>`
after that I ran make......
issued command
./youtube-dl -v --ap-mso Dish --ap-username PRIVATE --ap-password PRIVATE --list-formats http://www.syfy.com/killjoys/videos/110-escape-velocity
and it hangs at:
[Syfy] 2877726: Downloading Provider Login Page
If I let it sit for like 5 minutes......it eventually gives ssl error time......
Now im running this on a remote vps so dont think its an internet issue but just to be sure.....I tried my login credentials on Direct tv and it errors out invalid credentials.
So Im thinking it just geting to page and timing out......but I cant figure out why.
Any help or steps I can do to resolve this would be greatly appreciated.
here is output up till hang:
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'--ap-mso', u'Dish', u'--ap-username', u'PRIVATE', u'--ap-password', u'PRIVATE', u'--list-formats', u'http://www.syfy.com/killjoys/videos/110-escape-velocity']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.01.28
[debug] Python version 2.7.12 - Linux-4.4.0-59-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: avconv 2.8.10-0ubuntu0.16.04.1, avprobe 2.8.10-0ubuntu0.16.04.1, ffmpeg 2.8.10-0ubuntu0.16.04.1, ffprobe 2.8.10-0ubuntu0.16.04.1, rtmpdump 2.4
[debug] Proxy map: {}
[Syfy] 110-escape-velocity: Downloading webpage
[Syfy] 2877726: Downloading Provider Redirect Page
[Syfy] 2877726: Downloading Provider Login Page
^C
ERROR: Interrupted by user
Thanks for your time
| tv-provider-account-needed | medium | Critical |
204,250,273 | vscode | Copy line does not work properly with multi-cursor | <!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode -->
- VSCode Version: 1.8.1
- OS Version: OSX El Capitan 10.11.6
Steps to Reproduce:
1 .Invoke the "Insert cursor below" or "Inser cursor above" command.
2. Invoke the "Copy line (empty selection)" command.
3. Paste from the clipboard at some arbitrary place in the document.
Results:
One empty line is appended below the cursor.
Expected behaviour:
The copied lines are appended below the cursor.
| feature-request,editor-multicursor | low | Minor |
204,414,915 | neovim | Mixed languages in intro-screen: type (engl.) vs Tippe (german) | 
- `nvim --version`:
NVIM 0.1.7
Build type: Release
Compilation: /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -Wconversion -O2 -DNDEBUG -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -D_GNU_SOURCE -I/build/neovim/src/build/config -I/build/neovim/src/neovim-0.1.7/src -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/build/neovim/src/build/src/nvim/auto -I/build/neovim/src/build/include
Übersetzt von builduser
Optional features included (+) or not (-): +acl +iconv +jemalloc +tui
For differences from Vim, see :help vim-differences
System-vimrc-Datei: "$VIM/sysinit.vim"
Voreinstellung für $VIM: "/usr/share/nvim"
- Vim (version: ) behaves differently?
- Operating system/version: archlinux
- Terminal name/version: Konsole 16.12.1
- `$TERM`: xterm-256color = Konsole (Plasma)
### Actual behaviour
### Expected behaviour
### Steps to reproduce using `nvim -u NORC`
```
nvim -u NORC
```
| localization | low | Critical |
204,416,638 | TypeScript | Expose ts.matchFiles as public API to make implementing readDirectory easier. | Problem:
When implementing a custom host that virtualizes the file system, the `readDirectory` method is cumbersome to implement in a way that matches tsc behavior.
If you look at the hosts within typescript, the `matchFiles` method was added to unify behavior with `readDirectory` between hosts.
While `matchFiles` is exported, it isn't in the type definition files so I'm assuming it is "private" API.
Either the host should be able to provide a `getFileSystemEntries(path: string) => { files: string[], directories: string[] }` to get a `readDirectory` implementation or expose `matchFiles`.
I'm working on improving the `broccoli-typescript-compiler` broccoli plugin to have more parity with tsc and VS Code, but I need to virtualize the FS, since broccoli builds from tmp directory and I want the node_modules/@types discovery, tsconfig extends, etc all to work, I need to pretend the tmp dir is inside the project.
Thanks | Suggestion,Help Wanted,API,Experience Enhancement | low | Major |
204,419,412 | go | proposal: reflect/v2: make Value uncomparable | Comparing two `Value` type does not do what the user expects. The type is documented as such:
> Using == on two Values does not compare the underlying values they represent, but rather the contents of the Value structs. To compare two Values, compare the results of the Interface method.
However, it is still common to see users accidentally make this mistake. What's worse is that it "seems to work", giving a false sense of security.
```go
s1, s2 := "hello", "goodbye"
v1a := reflect.ValueOf(&s1)
v1b := reflect.ValueOf(&s1)
v2 := reflect.ValueOf(&s2)
fmt.Println(v1a == v1a) // Prints true
fmt.Println(v1a == v1b) // Prints true
fmt.Println(v1a == v2) // Prints false
```
This is because the `Value` struct contains a `flag` field whose value may be different for each `Value` and is entirely an implementation detail of the reflect package.
Perhaps we should add a uncomparable type to prevent this misuse:
```go
type Value struct {
_ [0]func() // Prevents Value from being comparable and occupies 0 bytes
typ *rtype
ptr unsafe.Pointer
flag
}
```
\cc @ianlancetaylor | v2,Proposal | low | Major |
204,458,667 | TypeScript | JSDoc syntax highlight. Not supported type '...*' | _From @IgorNovozhilov on November 9, 2016 11:2_
- VSCode Version:

- OS Version: win7 pro
Steps to Reproduce:
I'm used a Google Closure-Type notation:
https://github.com/google/closure-compiler/wiki/Types-in-the-Closure-Type-System#template-types

Make JSDoc comments:
Not highlighted type and the argument name:

And how it works:

And so:

In the example from Google:

I think `{function(this:T, ...)}` a wrong. Must be `{function(this:T, ...*)}`, but so, too, does not work

And so, too, does not work

_Copied from original issue: Microsoft/vscode#15239_ | Bug,VS Code Tracked,Domain: JSDoc | low | Minor |
204,478,930 | rust | rustdoc: types used in exported type definitions are not documented. | When I generate docs via `cargo doc`, types used in type definitions are not documented. This is a problem when a module exports a type definition but not the types on which it is based, because even though the type definition is documented, it is entirely opaque.
For example:
```
pub mod foo {
mod bar {
pub struct Foo<T> { ... }
impl<T> Foo<T> { ... }
}
pub type Foo = bar::Foo<i32>;
}
```
None of the methods on `foo::bar::Foo<T>` will be documented, and the documentation for `foo::Foo` will be nothing more than its type definition (and any documentation on the type definition itself).
I've tried removing the `skip-private` pass using the following command, and that still does not document the types used in the type definitions:
```
cargo rustdoc -- --passes=strip-hidden --passes=collapse-docs --passes=unindent-comments
```
Is this the expected behavior? Is there some way to document these types without exporting them? | T-rustdoc,C-bug,A-reachable-priv | low | Minor |
204,498,837 | TypeScript | Can't extend mixin constructor that constructs a generic type | This applies regardless of whether or not I intersect it with some bogus type, or have a reasonable constraint. So none of the following works.
**Returning a plain `T`**
```ts
export type Constructor<T> = new (...args: any[]) => T
export interface Timestamp {
timestamp: Date;
}
// plain old T
export function Timestamp<T, CT extends Constructor<T>>(Base: CT): Constructor<Timestamp> & Constructor<T> {
return class extends Base {
timestamp = new Date();
}
}
```
**Constructor of `T` with a bogus object type (`{}`)**
```ts
export type Constructor<T> = new (...args: any[]) => T
export interface Timestamp {
timestamp: Date;
}
// Constructor of T with a bogus object type
export function Timestamp<T, CT extends Constructor<T & {}>>(Base: CT): Constructor<Timestamp> & Constructor<T> {
return class extends Base {
timestamp = new Date();
}
}
```
**Constructor of `T` where `T` is constrained to `{}`**
```ts
export type Constructor<T> = new (...args: any[]) => T
export interface Timestamp {
timestamp: Date;
}
export function Timestamp<T extends {}, CT extends Constructor<T>>(Base: CT): Constructor<Timestamp> & Constructor<T> {
return class extends Base {
timestamp = new Date();
}
}
```
**Constructor of `T` where `T` is constrained to `object`** (see also #13805)
```ts
export type Constructor<T> = new (...args: any[]) => T
export interface Timestamp {
timestamp: Date;
}
export function Timestamp<T extends object, CT extends Constructor<T>>(Base: CT): Constructor<Timestamp> & Constructor<T> {
return class extends Base {
timestamp = new Date();
}
}
```
| Suggestion,In Discussion | low | Major |
204,608,573 | go | os: `Process` finalizer should wait for process on Unix systems | The os package sets a finalizer on all `Process` values. Currently, on Unix, that finalizer does nothing useful. It should probably call `wait` on the process if that has not already been done, to remove the otherwise zombie process. | NeedsDecision | low | Minor |
204,676,210 | TypeScript | Compiler should complain about implicit return value of child class constructor, if it does not satisfy child class type | **TypeScript Version:** 2.1.5
Since TypeScript 2.1 (due to #7574) the return value of a constructor call is the return value of the super constructor. So that
```typescript
class Child extends Base {}
```
is compiled to
```javascript
function Child() {
return _super !== null && _super.apply(this, arguments) || this;
}
```
**Actual behavior:**
The actual problem is, that the implementation of `Child`(see example below) will be compiled without errors, despite of the fact that the instance (`child`) does not satisfy its type `Child`, because `someMethod` does not exist on `child`.
```typescript
class Base {
hello = 'base';
constructor() {
return {
hello: 'world'
};
}
}
class Child extends Base { // <-- compiler does not complain
someMethod() {}
}
const child = new Child();
child.someMethod(); // <-- compiler does NOT complain, despite of "someMethod" does not exist on {hello: 'world'}
```
**Expected behavior:**
The compiler should complain about the implicit return value of the child class constructor, if this value is not a type of the child class. So that either an explicitly defined return value for the child class constructor should be forced like...
```typescript
class Child extends Base {
constructor() {
super();
return {
someMethod() {},
/* ... inherited members */
}
}
someMethod() {}
}
```
or the return value has to be extended (`const base = super()`) to fulfill the type `Child` or all members of the child class have to be optional. | Suggestion,Awaiting More Feedback | low | Critical |
204,704,169 | TypeScript | [typings installer] ensure that installed @types packages are supported by the current version of the TypeScript | If user have installed `@types` package using i.e. TypeScript 2.2 and then moved back to TypeScript 2.1 (via `tsdk` setting) it is possible that installed packages has some syntactic features that are now supported in the older versions of the compiler. Typings installer should detect such cases and updated installed packages to the latest supported version. | Bug | low | Minor |
204,709,183 | vscode | [folding] show folding lines | I would like to see more options with code folding and with bracket matching.
It seems the user base is quite split on how they want the collapsed region to display, so I think this should be a user configuration setting along with the other features listed.
### Feature Requests
1. Collapse fold to a single line [Related#2 Alternative Designs#1](https://github.com/Microsoft/vscode/issues/2948#issuecomment-183540068)
1. Bracket anchors/leads/lines seen in `pictures #2 and #3` + [Related#2 Alternative Designs#2](https://github.com/Microsoft/vscode/issues/2948#issuecomment-183540068)
1. Peek at top bracket when hovering the bottom bracket `pictures #3` This should only happen when the top matching bracket isn't visible on the current viewport.
1. Highlight current region. In `pictures #1 and #2` it highlights the current block you're on
1. Collapse block from bottom bracket. In `pictures #1 and #3` you can collapse a block region from the lower bracket which can be really nice, it can be a quick way to see what the bracket belongs to w/o feature `request #3`
### Picture examples
1. Single line collapse

1. Anchor / leads / lines

1. Peek at top bracket

### Related
1. Collapse to same line #3352
1. Icons for folding #2948
#### Labels
- editor
- editor-folding
- feature-request | feature-request,editor-folding | medium | Major |
204,748,518 | flutter | Proposal: find.widgetWithText should return one widget instead of two if the widget has two children with the text given | I'm describing the situation like this,
```dart
new Row(children: [new Text('foo'), new Text('foo')]);
```
If I call `find.widgetWithText('foo')`, I expect `findsOneWidget`. But currently it finds two. Because two text widgets are found first and then trace the ancestors of they two. For both text widgets, the same Row is found twice. | a: tests,framework,c: proposal,P2,team-framework,triaged-framework | low | Minor |
204,757,567 | go | x/net/http2: make Transport check whether a GET Request.Body has any bytes before sending stream? | ### What version of Go are you using (`go version`)?
go version go1.7.5 darwin/amd64 (also tested on linux)
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/kalbasit/code"
GORACE=""
GOROOT="/usr/local/Cellar/go/1.7.5/libexec"
GOTOOLDIR="/usr/local/Cellar/go/1.7.5/libexec/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/ty/mr64q0m92n98g9lkdrthg2qc0000gn/T/go-build293044907=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
```
### What did you do?
https://play.golang.org/p/uwnSRGt27v
```
package main
import (
"bytes"
"crypto/tls"
"io"
"io/ioutil"
"log"
"net/http"
)
func main() {
c := http.Client{}
// According to the CloudFront documentation for a request behavior, if the
// request is GET and includes a body, it returns a 403 Forbidden. See the
// documentation here:
// https://docs.aws.amazon.com/AmazonCloudFront/latest/DeveloperGuide/RequestAndResponseBehaviorCustomOrigin.html#RequestCustom-get-body
var body bytes.Buffer
r, err := http.NewRequest("GET", "https://d1ytf8d9p4nfnz.cloudfront.net/optivpaid/optivpaid.js?cb=847742584", ioutil.NopCloser(&body))
if err != nil {
log.Fatalf("error creating the request: %s", err)
}
res, err := c.Do(r)
if err != nil {
log.Fatalf("error doing the request: %s", err)
}
io.Copy(ioutil.Discard, res.Body)
res.Body.Close()
log.Printf("response status for an HTTP/2 request: %s", res.Status)
// doing the same request without HTTP/2 does work
c.Transport = &http.Transport{
TLSNextProto: map[string]func(string, *tls.Conn) http.RoundTripper{},
}
r, err = http.NewRequest("GET", "https://d1ytf8d9p4nfnz.cloudfront.net/optivpaid/optivpaid.js?cb=847742584", ioutil.NopCloser(&body))
if err != nil {
log.Fatalf("error creating the request: %s", err)
}
res, err = c.Do(r)
if err != nil {
log.Fatalf("error doing the request: %s", err)
}
io.Copy(ioutil.Discard, res.Body)
res.Body.Close()
log.Printf("response status for an HTTP/1 request: %s", res.Status)
}
```
### What did you expect to see?
```
% go run main.go
2017/02/01 17:27:31 response status for an HTTP/2 request: 200 OK
2017/02/01 17:27:32 response status for an HTTP/1 request: 200 OK
```
### What did you see instead?
```
% go run main.go
2017/02/01 17:27:31 response status for an HTTP/2 request: 403 Forbidden
2017/02/01 17:27:32 response status for an HTTP/1 request: 200 OK
```
| NeedsInvestigation | low | Critical |
204,944,224 | three.js | AudioLoader and LoadingManager onLoad Race | ##### Description of the problem
`AudioLoader` calls `scope.manager.itemEnd` (through the file loader) after loading the buffer, but its own `onLoad` after decoding it. Since decoding the buffer is asynchronous (or at least, has a callback) you can get into a race condition if the audio loader is the last loader in the loading manager's queue, where the manager thinks all of it's items are finished but the individual loaders haven't finished parsing. We noticed this in our preloading situation and had to implement our own loading queue that used the per-item `onLoad` to tick off complete items.
Unfortunately, looking at FileLoader/AudioLoader source, I'm not sure how to fix this or if it's even a concern; maybe the easiest solution to just clarify in the docs that `LoadingManager#onLoad` only indicates the network request is finished, and doesn't indicate that the data has been parsed.
##### Three.js version
- [x] r84
##### Browser
- [x] All of them
##### OS
- [x] All of them
| Bug,Loaders | low | Minor |
204,998,706 | vscode | Add action to show inline all diagnostics in file. | `F8` and `Shift + F8` navigation between diagnostic is really nice but sometimes it would be useful to have nice view of all diagnostics in current file.
Looks like it would be fairly simple to implement, just one additional editor action in https://github.com/Microsoft/vscode/blob/2a40036dbb34aac4f5aefbe999c21f2eaf76c59b/src/vs/editor/contrib/gotoError/browser/gotoError.ts, I could try implementing it if this feature idea is accepted. | feature-request,editor-contrib,languages-diagnostics | medium | Critical |
205,028,116 | TypeScript | Doc comment applied to all components of dotted namespace declaration | **TypeScript Version:** 2.1.5, 2.2-rc
**Code**
```ts
/** Performance measurements for the compiler. */
namespace ts.performance {}
```
**Expected behavior:**
The doc comment should show up in quickinfo/completion for references to the innermost declared namespace `performance`, but not for `ts`.
**Actual behavior:**
The doc comment appears in quickinfo/completion for references to both `performance` and `ts`, even though for the outer namespace `ts` it's most likely irrelevant:
 | Bug,Help Wanted | low | Major |
205,078,216 | kubernetes | Disable restart of containers in multi-container pods | <!-- Thanks for filing an issue! Before hitting the button, please answer these questions.-->
**Is this a request for help?** (If yes, you should use our troubleshooting guide and community support channels, see http://kubernetes.io/docs/troubleshooting/.): No
**What keywords did you search in Kubernetes issues before filing this one?** (If you have found any duplicates, you should instead reply there.): multi, restart, liveness, restart
---
**Is this a BUG REPORT or FEATURE REQUEST?** (choose one): Feature request
<!--
If this is a BUG REPORT, please:
- Fill in as much of the template below as you can. If you leave out
information, we can't help you as well.
If this is a FEATURE REQUEST, please:
- Describe *in detail* the feature/behavior/change you'd like to see.
Pods managed by a ReplicationController only allows a restart policy of "Always".
When a container in a multi-container pod managed by a ReplicationController crashes, the crashed container is restarted in the existing pod without notifying or restarting the other pods. I'd like to have a way to specify that *any* container crash in the pod should take down and replace the entire pod or at least restart all the other containers.
Our use case is as follows:
Pods consists of a worker container exposing gRPC APIs (let's call it container A) and a utility container (container B). Container B is connected to a Kubernetes HTTP liveness probe. When that probe is called, A makes a series of gRPC calls to B to determine it's health. If B returns an unhealthy result from the probe, Kubernetes restarts B in the existing container leaving A untouched and in an unhealthy state. Kubernetes should not just restart B, but delete the entire pod and have the ReplicationController bring up a new pod.
As a note, the worker containers are provided by other teams and source code, docker base image, etc are not available to the team operating the Kubernetes cluster so we cannot change the worker containers. We would also like the dynamic pairing of containers pods allows for to change out the utility containers depending on environment (dev, stg,prod) as the criteria for e.g. being healthy can change depending on environment.
In both cases, be ready for followup questions, and please respond in a timely
manner. If we can't reproduce a bug or think a feature already exists, we
might close your issue. If we're wrong, PLEASE feel free to reopen it and
explain why.
-->
**Kubernetes version** (use `kubectl version`): 1.3.6
**Environment**:
- **Cloud provider or hardware configuration**: AWS EC2
- **OS** (e.g. from /etc/os-release): CentOS Linux 7 (Core)
- **Kernel** (e.g. `uname -a`): Linux ip-10-44-68-102 3.10.0-327.10.1.el7.x86_64 #1 SMP Tue Feb 16 17:03:50 UTC 2016 x86_64 x86_64 x86_64 GNU/Linux
- **Install tools**: custom
- **Others**:
**What happened**: A container in a multi-container pod returned 500 from an HTTP liveness probe. Only that container in the pod was restarted
**What you expected to happen**: When a container in a multi-container pod indicates that the pod is unhealthy, the entire pod should be restarted.
**How to reproduce it** (as minimally and precisely as possible):
Create a replication controller with a template of a pod containing two containers.
Attach an HTTP liveness probe to a REST endpoint returning 500 from one of the containers.
Observe that only the connected container is restarted.
Observe that the pod is not recreated and that the non-probe-connected container has not been restarted
**Anything else we need to know**:
| sig/node,kind/feature,lifecycle/frozen,needs-triage | high | Critical |
205,098,813 | youtube-dl | iqiyi not downloading properly | Log is as follows(including 2 examples):
```
$ ./youtube-dl http://www.iqiyi.com/a_19rrhanifd.html#vfrm=2-4-0-1 --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'http://www.iqiyi.com/a_19rrhanifd.html#vfrm=2-4-0-1', u'--verbose']
[debug] Encodings: locale ISO-8859-1, fs ISO-8859-1, out ISO-8859-1, pref ISO-8859-1
[debug] youtube-dl version 2017.02.01
[debug] Python version 2.7.3 - Linux-2.6.32_1-18-0-0-x86_64-with-redhat-4.3-Final
[debug] exe versions: none
[debug] Proxy map: {}
[iqiyi] temp_id: download video page
ERROR: Unable to extract tvid; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "./youtube-dl/youtube_dl/YoutubeDL.py", line 694, in extract_info
ie_result = ie.extract(url)
File "./youtube-dl/youtube_dl/extractor/common.py", line 369, in extract
return self._real_extract(url)
File "./youtube-dl/youtube_dl/extractor/iqiyi.py", line 345, in _real_extract
r'data-player-tvid\s*=\s*[\'"](\d+)', webpage, 'tvid')
File "./youtube-dl/youtube_dl/extractor/common.py", line 672, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract tvid; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
```
```
$ ./youtube-dl http://www.iqiyi.com/v_19rramot48.html --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'http://www.iqiyi.com/v_19rramot48.html', u'--verbose']
[debug] Encodings: locale ISO-8859-1, fs ISO-8859-1, out ISO-8859-1, pref ISO-8859-1
[debug] youtube-dl version 2017.02.01
[debug] Python version 2.7.3 - Linux-2.6.32_1-18-0-0-x86_64-with-redhat-4.3-Final
[debug] exe versions: none
[debug] Proxy map: {}
[iqiyi] temp_id: download video page
WARNING: unable to extract album title; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
[iqiyi] 606416900: Download playlist page 2
ERROR: An extractor error has occurred. (caused by KeyError(u'data',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "./youtube-dl/youtube_dl/extractor/common.py", line 369, in extract
return self._real_extract(url)
File "./youtube-dl/youtube_dl/extractor/iqiyi.py", line 340, in _real_extract
playlist_result = self._extract_playlist(webpage)
File "./youtube-dl/youtube_dl/extractor/iqiyi.py", line 326, in _extract_playlist
vlist = pagelist['data']['vlist']
KeyError: u'data'
Traceback (most recent call last):
File "./youtube-dl/youtube_dl/YoutubeDL.py", line 694, in extract_info
ie_result = ie.extract(url)
File "./youtube-dl/youtube_dl/extractor/common.py", line 375, in extract
raise ExtractorError('An extractor error has occurred.', cause=e)
ExtractorError: An extractor error has occurred. (caused by KeyError(u'data',)); please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
``` | bug | medium | Critical |
205,099,122 | three.js | Inconsistent return value type from FileLoader.load() | ##### Description of the problem
`FileLoader.load()` returns three types of return value.
1. `XMLHttpRequest` instance when cache doesn't hit and url is not data: URI
2. cached data when cache hits
3. `undefined` when url is data: URI
As for me it'd be kinda confusing to users because the return value type
depends on the cache state and url type.
Another confusing thing is it returns cached(loaded) data synchronously
before it calls `manager.itemEnd()` when cache hits.
I like consistent design,
I want loaded/cached data only to be asynchronously passed to user via `onLoad` callback.
So how about returning `null` when 2. and 3.?
Or any other ideas?
##### Three.js version
- [x] Dev
##### Browser
- [x] All of them
- [ ] Chrome
- [ ] Firefox
- [ ] Internet Explorer
##### OS
- [x] All of them
- [ ] Windows
- [ ] Linux
- [ ] Android
- [ ] IOS
##### Hardware Requirements (graphics card, VR Device, ...)
| Suggestion,Loaders | low | Major |
205,172,092 | vscode | Explore using formatters for indentation adjustment when formatters are available | VSCode 1.9 introduced initial support for line indenting as [per the release notes](https://code.visualstudio.com/updates/v1_9#_indentation-rules-improvements), I think it's this commit: https://github.com/Microsoft/vscode/commit/be1b5f75161a30dd63316b832067b41d2caec0b3. I'm very interested in this feature, big 👍 for bringing it into VSCode.
Here is some initial feedback:
- I tried for a couple of file formats, it only worked for TypeScript and not e.g., for JSON or PHP.
- Formatting (`Alt+Shift+F`) can already do indentation better than the new implementation, maybe it could be used as a fallback if the language doesn't have proper indentation rules.
- If I read the code correctly, it re-indents the whole file. It should respect my selection. For example, if I have only 10 lines selected, it should re-indent those. If I don't have any selection, it should do the whole file.
- The command is currently `editor.action.reindentlines`, proper casing would be `editor.action.reindentLines`. | editor-autoindent,under-discussion | low | Major |
205,209,447 | neovim | syntax: "indent" grouping | There are several popular languages (Haskell, Python) and file formats (YAML, cabal) out there that are indentation sensitive and as far as I know `Vim` is not very good in supporting that when it comes to things like syntax highlighting.
The only approach that I'm aware of is doing backtracking with Vimscript which is tedious and error prone.
I'm the main author of `haskell-vim` and I get quite a lot of feature requests that would need a way to figure out in which kind of block I am.
A very handy thing would be something like `syn indent` that works like so:
Let's say we want to define how `do` blocks in Haskell are being highlighted. They start with the keyword `do`.
```viml
syn indent {group-name} start="\<do\>" contains=…
```
If that rule finds a match all the following lines indented relative to the match belong to that group.
Example:
```haskell
fun x = do -- match
foo -- indented by 2 relative to the matched line, therefore part of the group
bar -- ditto
-- not indented anymore, therefore not part of the group.
bar x d = …
```
A way to tell that the group should ignore empty lines would also be handy so something like this could work:
```haskell
fun x = do --match
foo -- part of the group
bar -- also part of the group
```
Maybe there already is a way to do this with Neovim but if there isn't this would make writing plugins for languages with significant whitespace a lot easier. | enhancement,api,syntax | medium | Critical |
205,214,646 | rust | Escaping `char` in libcore adds 2k of static data for no_std cases | The PR to [improve char escaping](https://github.com/rust-lang/rust/pull/34485) unfortunately added 2k of static data to libcore, which impacts the `no_std` use case on small devices. Even if in some cases this data could be eliminated automatically, if you ever format a character, you'll definitely bring these tables in.
We should see whether there's a way to get this functionality while moving the bloat to `libstd`, perhaps using specialization. | A-Unicode,T-libs-api,E-help-wanted,C-feature-accepted,WG-embedded,I-heavy | low | Major |
205,263,726 | rust | Incorrect type mismatch resolving when using return in closure | The following code is failing to compile in stable and nightly
```rust
fn main() {
let a = |hello| { return hello + 1; };
let _ = a(2);
}
```
with the following message:
```
rustc 1.15.0 (10893a9a3 2017-01-19)
error[E0271]: type mismatch resolving `<i32 as std::ops::Add>::Output == ()`
--> <anon>:2:30
|
2 | let a = |hello| { return hello + 1; };
| ^^^^^^^^^ expected i32, found ()
|
= note: expected type `i32`
= note: found type `()`
error: aborting due to previous error
```
If I remove the return and the semicolon, it works as expected.
Adding the type `i32` to `_` or adding a type to the parameter (e.g.: `2u32`) fixes the problem. | A-inference,C-bug | low | Critical |
205,278,094 | opencv | iOS: Build only device archs, without simulator | It seems like there is no way currently to build opencv framework only for devices archs, without the ones for simulator.
Is there any specific reasons for that? I think it may help to reduce framework size. | feature,priority: low,category: build/install,platform: ios/osx | low | Minor |
205,333,055 | rust | Suggestion: make string/slice more efficient with match | The `match` clause is already flexible to generate a `switch` IR for enum and integers.
It would be good to see a good implementation for str, [T] too. https://github.com/sfackler/rust-phf is a good candiate, since it's translated to a switch+equality comparison, and the code generation doesn't take much time (.4s for 100000 entries). | I-slow,C-enhancement,T-compiler | low | Major |
205,340,808 | rust | dead_code warnings for functions/types used in a unused function | Hi everybody.
[Playground](https://is.gd/jMqXK2)
Code:
```rust
fn foo() {}
fn bar() {
foo();
}
fn main() {}
```
Output:
```
warning: function is never used: `foo`, #[warn(dead_code)] on by default
--> <anon>:1:1
|
1 | fn foo() {
| _^ starting here...
2 | |
3 | | }
| |_^ ...ending here
warning: function is never used: `bar`, #[warn(dead_code)] on by default
--> <anon>:5:1
|
5 | fn bar() {
| _^ starting here...
6 | | foo();
7 | | }
| |_^ ...ending here
```
I don't like it because it confuses what exactly isn't used. | A-lints,I-needs-decision,C-bug | medium | Major |
205,349,658 | youtube-dl | A model, well-commented extractor | Since I'm not intimately familiar with the youtube-dl codebase, when I make a change to an extractor I often want to review other extractors to see how things have been handled previously. But oftentimes, it's really not clear which of several choices is better, what is favored, and what is more elegant.
If I had time to read through every single extractor I could make those determinations, but with 600+ of them, that's kind of daunting. Oftentimes I'll grep for a function and start looking at how abc.py and abcnews.py do it, since they are first alphabetically. But that's perhaps not a great plan.
It would be nice if there were a few well-written sample or "model" extractors that were highlighted as Best Practices that we could look at and review. And if those were clearly identified somehow, so I know where to look (maybe such model extractors exist already, I'm just not sure what to be looking at?). All things being equal, it'd be great if they were at the head of the alphabet, too :)
Thanks.
Also, the youtube-dl coding style seems to discourage comments. Maybe when you're very familiar with the code and the functions in common.py they don't seem so important, but for someone new to the codebase, they can help a lot. So it would be nice if any such model extractors could also be well-commented, or at least more verbosely commented than is typical in the codebase. | request | low | Major |
205,368,737 | youtube-dl | site request | please add support for http://www.infowars.com/watch-alex-jones-show/
thanks | site-support-request | low | Minor |
205,369,256 | youtube-dl | [telebasel] Add site support for telebasel.ch | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.02.04.1*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.04.1**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://telebasel.ch/telebasel-news/
- Single video: https://telebasel.ch/telebasel-news/?aid=4063&pid=77015&channel=15881
- Playlist: https://telebasel.ch/2017/02/01/bruno-manser-als-abenteuerfilmheld/?channel=105100
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description
Telebasel is a Swiss regional TV station. It is currently not supported by youtube-dl:
```
$ youtube-dl -v "https://telebasel.ch/telebasel-news/?aid=4063&pid=77015&channel=15881"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://telebasel.ch/telebasel-news/?aid=4063&pid=77015&channel=15881']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.02.04.1
[debug] Python version 3.6.0 - Linux-4.9.6-1-ARCH-x86_64-with-arch
[debug] exe versions: ffmpeg 3.2.2, ffprobe 3.2.2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] ?aid=4063&pid=77015&channel=15881: Requesting header
WARNING: Falling back on generic information extractor.
[generic] ?aid=4063&pid=77015&channel=15881: Downloading webpage
[generic] ?aid=4063&pid=77015&channel=15881: Extracting information
ERROR: Unsupported URL: https://telebasel.ch/telebasel-news/?aid=4063&pid=77015&channel=15881
Traceback (most recent call last):
File "/usr/lib/python3.6/site-packages/youtube_dl/YoutubeDL.py", line 696, in extract_info
ie_result = ie.extract(url)
File "/usr/lib/python3.6/site-packages/youtube_dl/extractor/common.py", line 369, in extract
return self._real_extract(url)
File "/usr/lib/python3.6/site-packages/youtube_dl/extractor/generic.py", line 2551, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: https://telebasel.ch/telebasel-news/?aid=4063&pid=77015&channel=15881
```
It would be really nice to have support for telebasel.ch.
I will work on this.
| site-support-request | low | Critical |
205,444,732 | go | x/net/html/charset: htmlEncoding incompatibility with x/text/encoding/htmlindex.Name | ### What version of Go are you using (`go version`)?
```
$ go version
go version go1.7.3 darwin/amd64
```
### What operating system and processor architecture are you using (`go env`)?
```go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/gautiertanguy/work"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/w3/f2rhtgc56jv010vxvkdpvk4m0000gn/T/go-build762276495=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
```
### What did you do?
Run :
```
package main
import (
"fmt"
"golang.org/x/net/html/charset"
"golang.org/x/text/encoding/htmlindex"
)
func main() {
enc, _ := charset.Lookup("UTF-8")
name, err := htmlindex.Name(enc)
if err != nil {
fmt.Println(err)
return
}
fmt.Println(name)
}
```
### What did you expect to see?
```
utf-8
```
### What did you see instead?
```
htmlindex: unknown Encoding
```
The type assertion in `htmlindex.Name(enc)` to check if `enc` is a `golang.org/x/text/encoding/internal/identifier.Interface`will always fail in the above code because here `enc` is a `golang.org/x/net/html/charset.htmlEncoding` which wraps the actual encoding (except its eventual internal part). | NeedsInvestigation | low | Critical |
205,451,088 | TypeScript | Proposal: JSX.ElementType | Hello,
There are many GUI frameworks (ExtJs, SmartClient, OpenUI5) which do not works in React way and they could be easily be integrated with JSX/TSX if their JSX expressions would return correct "element type" e.g.
`const listGrid = <ListGrid/> ; // should be type of ListGrid or isc.IListgrid, not JSX.Element`
My proposal would be to add new special type into global `JSX` namespace - `ElementTypeProperty`.
JSX.ElementTypeProperty
-------------------------------
Given an element instance type, we need to produce a type that will be return type of that JSX element. We call this the element type.
The interface JSX.ElementTypeProperty defines this process.
It may have 0 properties, in which case element instance type will be element type.
Or 1 property, in which case the element type will be the type of that property type of element instance type.
Note: Intrinsic lookup is not affected by ElementTypeProperty.
----------------------
Related: https://github.com/Microsoft/TypeScript/issues/13746
| Suggestion,In Discussion,Domain: JSX/TSX | medium | Major |
205,455,474 | react-native | Memory leak when programmatically changing 'source' prop of Image | ### Description
If you use an Image component in render and use the parent component's state to manage the source prop, each time the source is changed the previous source is not deallocated. Even when the parent component is unmounted, the previous images still use memory.
<img width="800" alt="imagetest_memory_leak" src="https://cloud.githubusercontent.com/assets/4549380/22629970/dd31d43c-ebe8-11e6-8637-3f563a6fafd3.png">
### Reproduction
I've made a simple [ImageTest project](https://github.com/tomchambers2/ImageTest) that demonstrates the bug. **(IMPORTANT: run app in release mode to experience the issue)**
Code:
```
/**
* Sample React Native App
* https://github.com/facebook/react-native
* @flow
*/
import React, { Component } from 'react';
import {
AppRegistry,
StyleSheet,
Text,
View,
Image,
TouchableHighlight,
Dimensions,
} from 'react-native';
import image0 from './images/0.png'
import image1 from './images/1.png'
import image2 from './images/2.png'
import image3 from './images/3.png'
import image4 from './images/4.png'
const images = [
image0,
image1,
image2,
image3,
image4,
]
export default class ImageTest extends Component {
constructor() {
super()
this.state = ({
counter: 0,
})
}
increment = () => {
this.setState({
counter: this.state.counter + 1
})
}
render() {
const imageSource = images[this.state.counter]
return (
<View>
<Image
source={imageSource}
style={styles.image}
/>
<TouchableHighlight onPress={this.increment} style={styles.highlight}>
<Text style={styles.text}>NEXT IMAGE</Text>
</TouchableHighlight>
</View>
);
}
}
const window = Dimensions.get('window')
const styles = StyleSheet.create({
highlight: {
backgroundColor: 'yellow',
position: 'absolute',
bottom: 0,
left: 0,
},
text: {
fontSize: 50,
},
image: {
width: window.width,
height: window.height,
},
});
AppRegistry.registerComponent('ImageTest', () => ImageTest);
```
### Solution
Presumably when the source is changed the underlying UIImage/UIImageView needs to be destroyed.
### Additional Information
* React Native version: 0.41.0
* Platform: iOS
* Operating System: MacOS 10.12.3 / xcode 8.2
| Good first issue,Platform: iOS,Component: Image,Bug | medium | Critical |
205,495,677 | vscode | Suggestion - Add a line-spacing or line-margin option | i create a new post because i didn't see anything that exactly correspond to my demand in already existing tickets.
What i suggest is to add a line-spacing flag in the editor category, that should add a space, who is 0px by default BETWEEN lines.
It is different from lineHeight flag because line height also modify the size of the carret, line hightlight, etc...
it seems to be very capricious suggestion, and i don't know if it is possible in the actual software architecture, but i let it here, in case of. I used to use this in sublime text before, and it greatly helped me to read the code easier.
An alternative could be to change carret and line-highlight to always scales to the font size instead of line-height size.
Due to my frenshyness, please, excuse me for my approximative english.
I hope this is understandable. Do not hesitate to question me otherwise.
thanks
Guema | feature-request,editor-core | medium | Major |
205,647,427 | youtube-dl | Export fragments list with ism and f4m protocols | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.04.1**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
Like it's possible now with mpd/dash manifests right now, would it be possible to export ism/f4m fragments list with JSON output? FFmpeg/mpv doesn't demuxing the manifests directly. | request | low | Critical |
205,675,694 | youtube-dl | [condenast] please support wired.com | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.02.04.1*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.04.1**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Site support request (request for adding support for a new site)
```
[$] youtube-dl -vF "https://www.wired.com/2017/02/airbus-kinda-serious-swappable-plane-interiors-cafes-spas/"
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-vF', u'https://www.wired.com/2017/02/airbus-kinda-serious-swappable-plane-interiors-cafes-spas/']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.02.04.1
[debug] Python version 2.7.13 - Linux-4.9.0-1-amd64-x86_64-with-debian-9.0
[debug] exe versions: ffmpeg 3.2.2-2, ffprobe 3.2.2-2, rtmpdump 2.4
[debug] Proxy map: {}
[generic] airbus-kinda-serious-swappable-plane-interiors-cafes-spas: Requesting header
WARNING: Falling back on generic information extractor.
[generic] airbus-kinda-serious-swappable-plane-interiors-cafes-spas: Downloading webpage
[generic] airbus-kinda-serious-swappable-plane-interiors-cafes-spas: Extracting information
ERROR: Unsupported URL: https://www.wired.com/2017/02/airbus-kinda-serious-swappable-plane-interiors-cafes-spas/
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 1711, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2526, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2515, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1653, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1517, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 6, column 16
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 696, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 369, in extract
return self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2551, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://www.wired.com/2017/02/airbus-kinda-serious-swappable-plane-interiors-cafes-spas/
```
Hopefully this can be fixed. | request,broken-IE | low | Critical |
205,752,027 | opencv | Video file playback fail to open with Microsoft Media Foundation (CV_CAP_MSMF) | - OpenCV => 3.0
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2013
##### Detailed description
VideoCapture Video "file" playback using Media Foundation (CV_CAP_MSMF) is failed to open given various video format I had tested, mostly in mp4, wmv, and avi format.
I used `VideoCapture cap(fileName, CV_CAP_MSMF);`
By rebuilding from source of OpenCV 3.0, 3.1, 3.2 (-with_msmf), I always get `cap.isOpened()` to return false.
When digging into the cap_msmf.cpp source, in line 3864, my multiple video(s) can not match this particular MFVideoFormat_RGB24. It makes me wonder if there is a limitation of OpenCV's media foundation implementation. If there is, it should be stated in the document, like what particular video format it can support, or does it only work with video device (instead of file)
In cap_msmf.cpp of line 3864
```
MediaType MT = FormatReader::Read(pType.Get());
// We can capture only RGB video.
if( MT.MF_MT_SUBTYPE == MFVideoFormat_RGB24 )
```
I had spent couple days on confirming this bug, and hope to get some confirmation. Thanks a lot!
##### Steps to reproduce
1. First build opencv from source with_msmf, and remove ffmpeg dependency
2. Try out this code:
```
VideoCapture cap(fileName, CV_CAP_MSMF);
if(cap.isOpened()){
//Will always return, no matter what file
return;
}
```
3. It will return without success in opening this file
| bug,priority: low,category: videoio,category: documentation | low | Critical |
205,759,424 | react | Clear button on iOS date input does not return correct event value | **Bug**
For iOS only.
When pressing `clear` on a date input, the `onChange` event is fired but` event.target.value` is showing the original value rather than an empty string.
**What is the current behavior?**
On Chrome and Android, when the clear button is pressed the onChange event has a value of `''`.
On iOS when the clear button is pressed the onChange event has a value of `previousValue`.
**Demo**
https://output.jsbin.com/zojuteloto/5/
Try on Chrome/Android. Then on iOS.
**What is the expected behavior?**
Value should be returned an an empty string.
**Versions**
Affects React 15+ & iOS 10. Unsure of previous versions.
| Type: Bug,Component: DOM | medium | Critical |
205,829,735 | vscode | Code snippet control indentation | <!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode -->
How can I control unindentation in code snippets?
```json
{
"Create migration helper execute statement": {
"prefix": "mhe",
"body": [
"\\$helper->execute(<<<SQL",
"\t$0",
"\rSQL",
");"
]
}
}
```
When invoking it in indented context:
```php
class Migration {
→ public function up(Helper $helper) {
→ → mhe<tab complete snippet>
→ }
}
```
Expected behavior:
```php
class Migration {
→ public function up(Helper $helper) {
→ → $helper->execute(<<<SQL
→ → → |<cursor>
SQL
→ → );
→ }
}
```
Actual behavior:
```php
class Migration {
→ public function up(Helper $helper) {
→ → $helper->execute(<<<SQL
→ → → |<cursor>
→ →
→ → SQL
→ → );
→ }
}
```
This is invalid behavior when using heredoc.
I tried to insert `\r` <carriage return> to try removing all indentation,
but it is just translated to a newline and indented according to snippet context.
- VSCode Version: 1.9.0
- OS Version: macOS Sierra | feature-request,snippets | medium | Major |
205,837,616 | TypeScript | Suggestion: DeepReadonly<T> type | **TypeScript Version:** 2.1.1 / nightly (2.2.0-dev.201xxxxx)
**Code**
It would be nice to have a shard, standard library type that allows to express deep readonly-ness (not really const, since methods are out of scope, but still...):
```ts
interface Y { a: number; }
interface X { y: Y; }
let x: Readonly<X> = {y: {a: 1}};
x.y.a = 2; // Succeeds, which is expected, but it'd be nice to have a common way to express deep readonly
type DeepReadonly<T> = {
readonly [P in keyof T]: DeepReadonly<T[P]>;
}
let deepX: DeepReadonly<X> = {y: {a: 1}};
deepX.y.a = 2; // Fails as expected!
``` | Suggestion,Needs More Info | high | Critical |
205,913,581 | go | cmd/compile: Fannkuch11 on AMD64 slow down 6% after removing assembler backend instruction reordering | CL https://go-review.googlesource.com/c/36205/ deletes assembler backend instruction reordering. This makes Fannkuch-11 on AMD64 slow down 6%. Figure out why and improve the compiler. | Performance,compiler/runtime | medium | Major |
205,914,034 | neovim | UI: externalize 'cursorline'/'cursorcolumn' | ```
$ nvim --version
NVIM 0.2.0-dev
Build type: RelWithDebInfo
Compilation: /usr/bin/x86_64-linux-gnu-gcc -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -Wconversion -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1 -O2 -g -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -D_GNU_SOURCE -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/build/config -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/src -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/.deps/usr/include -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/.deps/usr/include -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/.deps/usr/include -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/.deps/usr/include -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/.deps/usr/include -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/.deps/usr/include -I/usr/include -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/build/src/nvim/auto -I/build/neovim-TT51tV/neovim-0.1.7ubuntu1+git201702021745+3100+23~ubuntu16.04.1/build/include
Compiled by root@lgw01-18
Optional features included (+) or not (-): +acl +iconv +jemalloc +tui
For differences from Vim, see :help vim-differences
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/usr/share/nvim"
```
- Vim (version: ) behaves differently?
vim 8 is just as slow. maybe even - if possible - slower.
- Operating system/version:
Ubuntu 16.04 LTS 64-bit.
- Terminal name/version:
gnome-terminal running `tmux 2.1-3build1` or plain xterm without tmux. same results.
- `$TERM`:
```
xterm-256color
```
### Steps to reproduce using `nvim -u NORC`
```
wget https://gist.githubusercontent.com/hholst80/2531dad506f45812ef036c762d55e5b3/raw/75fe1d4dd19349863d96e3ff147032bba903c8cc/test.yml
nvim -u NORC test.yml
```
| performance,api,ui,ui-extensibility | low | Critical |
205,949,376 | angular | patchValue of Select with value not in options keeps the form valid | **I'm submitting a ...** (check one with "x")
```
[x] bug report => search github for a similar issue or PR before submitting
```
**Current behavior**
Using patchValue to set a value to a Select box (a value that *doesn't* exist in the Select options), sets the model to that value (and makes the field valid).
(The select box *doesn't* show the "invalid" value, which is OK, since its not one of the options).
**Expected behavior**
For Select boxes, using patchValue or setValue may/can/should/need not set the value (or set an empty one) if the value doesn't exist in the options.
**Minimal reproduction of the problem with instructions**
1. Have a reactive form with a select box, with `Validators.required`.
2. The select box has several options ("a", "b", and "c")
3. Using `patchValue`, set the value of the select to "d".
Plunkr: http://plnkr.co/mo9aCu?p=preview
--> I do understand that creating a `FormGroup` has nothing to do with the HTML template, and that a `FormControl` isn't related to either `input type="text"` or `select` for example. I'm not sure if this should be a bug or a feature request.
**What is the motivation / use case for changing the behavior?**
I let the user import previously saved form data, and need to patch the current form with the user's supplied data. If possible values have changed over time in a Select box, and user has old data, the field (and the form) will remain valid after import, but no data will be displayed in the Select.
**Please tell us about your environment:**
Plunkr, CentOS 6.8
* **Angular version:**
4.0.0-beta.6
* **Browser:**
Chrome 56
Thanks. | type: bug/fix,area: forms,forms: validators,forms: Controls API,P4 | low | Critical |
205,978,532 | youtube-dl | Support toukoucity.to | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.07**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Site support request (request for adding support for a new site)
---
Support toukoucity.to
Support for http://toukoucity.to should be pretty easy, as the video is always called "video.mp4" in the page's source. Example below.
$ youtube-dl --version
2017.02.07
$ youtube-dl http://toukoucity.to/video/VpvpP3ghin/
[debug] System config: []
[debug] User config: [u'--no-overwrites', u'--continue', u'--verbose', u'-f', u'best']
[debug] Custom config: []
[debug] Command-line args: [u'http://toukoucity.to/video/VpvpP3ghin/']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.02.07
[debug] Python version 2.7.9 - Linux-3.16.0-4-686-pae-i686-with-debian-8.7
[debug] exe versions: avconv 11.8-6, avprobe 11.8-6
[debug] Proxy map: {}
[generic] VpvpP3ghin: Requesting header
[redirect] Following redirect to http://toukoucity.to/
[generic] toukoucity: Requesting header
WARNING: Falling back on generic information extractor.
[generic] toukoucity: Downloading webpage
[generic] toukoucity: Extracting information
ERROR: Unsupported URL: http://toukoucity.to/
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 1741, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2526, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2515, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 4, column 451
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 696, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 369, in extract
return self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2589, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: http://toukoucity.to/
<end of log>
additional info:
Source of page and the video.mp4 link. Which is easy to download, but youtube-dl would make it even easier.
-From URL: "view-source:http://toukoucity.to/video/VpvpP3ghin/"
so.addVariable('file','http://107.182.234.250/p1/VpvpP3ghin/video.mp4');
-
So
wget http://107.182.234.250/p1/VpvpP3ghin/video.mp4 -O toukoucity-VpvpP3ghin.mp4
works now.
Note that the IP number and sub-dir "P1" are subject to change depending on the URL.
I don't think the site has alternative formats, so http://toukoucity.to/video/FFFFFFFFFF/ seems to be the only URL format. | site-support-request,nsfw | low | Critical |
205,981,967 | TypeScript | Ignore __proto__ | **TypeScript Version:** 2.2.0
**Code:**
```ts
{ __proto__: {} } as { [key: string]: string }
```
**Expected behavior:**
Ok
**Actual behavior:**
`Type '{ __proto__: {}; }' cannot be converted to type '{ [key: string]: string; }'.` | Suggestion,Awaiting More Feedback | low | Major |
206,029,693 | go | proposal: how to specify mechanical code updates after API changes? | Go should adopt conventions for packages to explain to potential clients how to update their code in response to API changes in a mechanical way. That is, a package developer should have a way to write down the significant changes of API and compiler and/or tools can *apply* or *fix* them.
See also #18130 and https://github.com/golang/go/issues/18130#issuecomment-278136380 | Proposal,Proposal-Hold | low | Major |
206,064,901 | TypeScript | Accept Input Source Maps | The typescript compiler produces sources maps mapping from the javascript it produces to the typescript sources it compiled. This is great, but doesn't go far enough if there are tools which generate the sources that are consumed by the typescript compiler.
For example, [Tsickle](https://github.com/angular/tsickle) preprocesses typescript sources before passing them to the typescript compiler. As things stand we've had to implement a hack to get our source maps to work. We use a compiler host which performs the tsickle transforms as the typescript compiler reads files, saves the resulting source maps and then compose them with the source maps produced by the typescript compiler as they're emitted.
Instead the typescript compiler could accept source maps as input alongside sources, and compose the input source maps with the source maps produced by the compiler.
The ideal api would be that the typescript compiler would look for either a. an inline source map as a comment in the source file or b. a file in the same directory with the name {source file name}.ts.map, which shouldn't require any crazy file resolution. | Suggestion,In Discussion | medium | Critical |
206,122,816 | TypeScript | Computed property key names should not be widened | **TypeScript Version:** 2.1.5
**Code**
The latest `@types/react` (`v15.0.6`) use `Pick<S,K>` to correctly type the `setState` method of `React.Component`s. While this makes it now possible to merge the `state` of a component instead of replacing it, it also makes it harder to write a dynamic update function that uses computed properties.
```ts
import * as React from 'react';
interface Person {
name: string;
age: number|undefined;
}
export default class PersonComponent extends React.Component<void, Person> {
constructor(props:any) {
super(props);
this.state = {
name: '',
age: undefined
};
this.handleUpdate = this.handleUpdate.bind(this);
}
handleUpdate (e:React.SyntheticEvent<HTMLInputElement>) {
const key = e.currentTarget.name as keyof Person;
const value = e.currentTarget.value;
this.setState({ [key]: value }); // <-- Error
}
render() {
return (
<form>
<input type="text" name="name" value={this.state.name} onChange={this.handleUpdate} />
<input type="text" name="age" value={this.state.age} onChange={this.handleUpdate} />
</form>
);
}
}
```
The above should show an actual use case of the issue, but it can be reduced to:
```ts
const key = 'name';
const value = 'Bob';
const o:Pick<Person, 'name'|'age'> = { [key]: value };
```
which will result in the same error. [Link to the TS playground](http://www.typescriptlang.org/play/index.html#src=interface%20Person%20%7B%0D%0A%20%20name%3A%20string%3B%0D%0A%20%20age%3A%20number%7Cundefined%3B%0D%0A%7D%0D%0A%0D%0Aconst%20key%20%3D%20'name'%3B%0D%0Aconst%20value%20%3D%20'Bob'%3B%0D%0Aconst%20o%3APick%3CPerson%2C%20'name'%7C'age'%3E%20%3D%20%7B%20%5Bkey%5D%3A%20value%20%7D%3B)
**Expected behavior:**
No error, because `key` is a `keyof Person`, which will result in the literal type `"name" | "age"`. Both values that are valid keys for`state`.
**Actual behavior:**
The compiler will throw the following error:
```
[ts] Argument of type '{ [x: string]: string; }' is not assignable
to parameter of type 'Pick<Person, "name" | "age">'.
Property 'name' is missing in type '{ [x: string]: string; }'.
```
My uninformed guess is that the constant `key` is (incorrectly) widened to `string`.
| Bug | high | Critical |
206,129,048 | rust | Document unwind-safety without referencing an RFC | https://doc.rust-lang.org/std/panic/trait.UnwindSafe.html currently says:
> for more information about unwind safety and how it applies to Rust, see an [associated RFC](https://github.com/rust-lang/rfcs/blob/master/text/1236-stabilize-catch-panic.md).
While this RFC is very informative, much of it is dedicated to Rust as it was before the RFC was implemented, possible alternatives, and trade-offs. This can be a distraction for someone not involved in programming language design and who just wants to learn how to safely use FFI in today’s Rust. (Which is admittedly intrinsically hard.)
Perhaps the Nomicon would be an appropriate alternative?
https://doc.rust-lang.org/nomicon/unwinding.html
https://doc.rust-lang.org/nomicon/exception-safety.html
https://doc.rust-lang.org/nomicon/poisoning.html | C-enhancement,P-medium,T-lang,A-docs | low | Major |
206,305,296 | kubernetes | Stricter checking/validation of statefulset pvcs | Currently theren's no enforcement around statefulset volume templates, which means the burden is on the user to make sure there's no collision. A user can create:
Petset 1: petset Claim: alpha-beta
Petset 2: beta-petset Claim: alpha
and end up with a collision. The controller should be smarter, maybe we need something like parent-ref?
@kubernetes/sig-apps-bugs @jingxu97 | kind/bug,area/stateful-apps,sig/apps,lifecycle/frozen | low | Critical |
206,306,331 | opencv | cv::VideoCapture leaks memory on ethernet cams | ##### System information (version)
- OpenCV => 3.2
- Operating System / Platform => Linux 64 Bit
- Compiler => GCC
##### Detailed description
I have been noticing my software memory usage grows (slowly) over time.
I used to believe it was some kind of buffer. But after I let it running overnight, and it crashed because it was out of memory, I had to debug.
My software uses 8 VideoCapture instances in RTSP Ethernet Cameras, each one in it's thread, at around 5FPS.
I found out if disable grab() and replace retrieve() for a still image, memory usage doesn't grow. A still image runs my algorithm normally.
After I re-enabled grab(), but not retrieve, the process memory grown 80MB in 1h23m.
After I re-enabled grab and retrieve, the process memory grown 120MB in 16min.
##### Steps to reproduce
I could reproduce the problem with the following code. More cameras make the memory usage grows faster.
cv::VideoCapture fb;
fb[0].open("rtsp://admin:admin@CAM_IP:554/ucast/11");
cv::Mat test;
while(true){
fb.grab();
fb.retrieve(test);
std::cout << "size: " << test.size() << std::endl;
}
It gave some warnings while running.:
[Output.txt](https://github.com/opencv/opencv/files/761908/Output.txt)
(I believe this is the source of the growing memory.)
##### More Info
- I sometimes get an error : " [rtsp @ 0xXXXXXXXXXXXX] Too short data for FU-A H.264 RTP packet"
- I have to do 5 grabs for 1 retrieve, so my image don't get delays.
- grab() and retrieve() happen in different threads.
##### Build details
[OpenCV_Build.txt](https://github.com/opencv/opencv/files/761794/OpenCV_Build.txt)
| incomplete | low | Critical |
206,322,684 | go | net/http/httptrace: add ServerTrace hooks | ## Problem
A very common pattern in Go HTTP servers is to implement an `http.ResponseWriter` that wraps another `http.ResponseWriter` and captures the status code. This is often used for logging and metrics collection.
For example,
```
type statusCaptureWriter struct {
http.ResponseWriter
status int
}
func (scw *statusCaptureWriter) WriteHeader(status int) {
scw.status = status
scw.ResponseWriter.WriteHeader(status)
}
type loggedHandler struct {
handler http.Handler
logger SomeLogger
}
func (h *loggedHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
scw := &statusCaptureWriter{ResponseWriter: w}
h.handler.ServeHTTP(scw, r)
h.logger.Logf("status=%d ...", scw.status)
}
```
I've written something like this a bunch of times. You can find examples in nearly every Go web framework out there. One example is https://github.com/urfave/negroni/blob/master/response_writer.go#L13-L26.
There are some issues with this approach. For instance, my `statusCaptureWriter` doesn't implement other interfaces like `http.Flusher`, `http.CloseNotifier` or `http.Pusher`. I can't determine at compile time whether the underlying `http.ResponseWriter` implementation implements any of these interfaces, so if I choose to implement them I might lie to callers at higher levels of the stack and inadvertently break things. (This particularly a problem with CloseNotifier.)
## Proposal (rejected, see below)
I'd like to propose an additional interface, `http.Statuser` (better name welcome) that exposes the status code within a `http.ResponseWriter` implementation. The internal `http.(*response)` implementation already tracks the status code written, so this can just be exposed and it will automatically implement this interface.
Software could avoid wrapping the `http.ResponseWriter` by instead type asserting it to `http.Statuser` and getting the status as needed there. (And it could optionally continue to wrap the ResponseWriter as needed until this is widely deployed.)
```
type loggedHandler struct {
handler http.Handler
logger SomeLogger
}
func (h *loggedHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
// Could check for http.Statuser implementation here and wrap http.ResponseWriter
// if necessary, but omitting for brevity
h.handler.ServeHTTP(w, r)
status := 0
if s, ok := w.(http.Statuser); ok {
status = s.Status()
}
h.logger.Logf("status=%d ...", status)
}
```
## Alternative proposal
Implement an `httptrace.ServerTrace` struct that is analogous to the `ClientTrace` already there. See https://github.com/golang/go/issues/18997#issuecomment-279611928 for more info. | FeatureRequest,early-in-cycle | high | Critical |
206,346,064 | rust | Add option to define environment vars | Right now, code can use `env!()` and `option_env!()` to query arbitrary environment variables set at the time rustc is invoked. This is a subtle leak of the compilation environment into the generated code, which can cause issues with build reproducibility, and could conceivably be considered a security problem.
I'd like to have the option to completely define the "environment" that's available to `env!()` on the compiler command line to an explicitly delimited set of names and values
For example:
`--override-env` - disable querying of real environment
`--set-env name=val` - define an environment variable (added to existing env if `--override-env` not set)
`--unset-env name` - make a name unset
cc @luser - this seems pertinent to caching https://github.com/rust-lang/cargo/issues/3066 | C-feature-request | low | Major |
206,346,150 | rust | Assertion failed in llvm/include/llvm/Support/Casting.h | Source:
```rust
pub extern "C" fn alt_main() {
extern {
fn main() -> i32;
}
unsafe { main(); }
}
pub fn main() {
println!("Hello");
}
```
Result:
```
$ rustc alt_main.rs -C link-args="-e_alt_main"
Assertion failed: (isa<X>(Val) && "cast<Ty>() argument of incompatible type!"), function cast, file /Users/rustbuild/src/rust-buildbot/slave/nightly-dist-rustc-mac/build/src/llvm/include/llvm/Support/Casting.h, line 237.
```
Rustc:
rustc 1.17.0-nightly (c49d10207 2017-02-07) on OS X
Edit: I'm aware that there are issues w/ the actual code, but even if I fix them, the assertion still fails | I-crash,A-LLVM,T-compiler,C-bug | low | Critical |
206,447,640 | vscode | Offline spell checker for VSCode | Hello (first time contributing here)
There are few offline spell checkers among VSCode extensions, but they are based on seriously faulty JavaScript implementations of [Hunspell](http://hunspell.github.io/) spell checker.
[Hunspell](http://hunspell.github.io/) is nowadays probably the most widespread standard for spell check layer. It is used on MacOS, Linux and in some software (e.g. LibreOffice) on Windows. It is also used by both Atom and Sublime Text. There is an enormous collection of polished dictionaries for Hunspell.
There exists some JavaScript implementations that refer to Hunspell's name but in fact they do not implement critical functionality - lexical parser. I have verified these three:
[hunspell-spellchecker](https://github.com/GitbookIO/hunspell-spellchecker)
[Typo.js](https://github.com/cfinke/Typo.js)
[nspell](https://github.com/wooorm/nspell)
All three work more or less following a simple idea of loading the dictionary into memory (into a associative table, a.k.a. dictionary, object to be precise). They use the Hunspell's affixes (.aff file) to create ALL variants of the words found in the dictionary (.dic file) and then store them in the memory. When checking spelling dictionary is simply asked whether the word exist or not. Simple, but it has these implications:
1. Loading takes a lot of time;
2. It takes a lot of memory too;
3. Memory consumption causes them to crash under dictionaries with more expanded affix system (two out of three mentioned, third does not consume all of the affixes).
For example when running [hunspell-spellchecker](https://github.com/GitbookIO/hunspell-spellchecker) (there is a [SpellChecker](https://marketplace.visualstudio.com/items?itemName=swyphcosmo.spellchecker) extension based on it) with English dictionary ("en_US", 62K+ words in dictionary) memory consumption is in peaks 500 MB and constantly above 250 MB. It crashes under Polish language dictionary ("pl_PL", 300K+ words in dictionary) after reaching about 1.5 GB memory consumed (there are reports about other dictionaries doing the same) with "JavaScript heap out of memory" message hidden well under the hood. Hunspell has a lexical parser which allows it to use these two sets (dictionary and affixes) "on the fly" without the need to merge them thus exploding memory consumption and load time.
There is a good spell checker component for node.js, which is actually a bindings for native spell checkers for MacOS (NSSpellChecker), Linux (Hunspell) and Windows (Spell Check API in windows 8+, Hunspell in earlier versions):
https://github.com/atom/node-spellchecker
It is alas a native module.
I have built a spell checker using this module. I will rather not publish it because it is quite pointless:
- The extension will (silently) stop working every time the electron or node get a version bump and I cannot guarantee I will always be around to rebuild binary dependencies quickly;
- Rebuilding binary dependencies is quite a hassle;
- I am unable to reasonably maintain binary dependencies for all three platforms (MacOS, Linux & Windows) - there already is an [extension](https://marketplace.visualstudio.com/items?itemName=adrienjoly.vscode-spellchecker-fr) which uses this module, but it provides binary dependencies for MacOS only;
- Even If I would produce node-spellchecker module using [node-pre-gyp](https://github.com/mapbox/node-pre-gyp) with binaries for various platforms if I understand things correctly extension cannot (easily?) install dependent modules using npm (which could also imply having a proper C++ toolchain around in case node-pre-gyp packaged binaries are not sufficient). Binaries are packaged and simply get downloaded along with the extension.
So I would like you to consider doing something about it.
There are few paths I can imagine among them two are most obvious:
1. Build the node-spellchecker module along with the VSCode and make it available among "standard" modules that extension developers can count upon (this could result in more than one spell checker extension e.g. for spelling text or latex documents, comments in code etc.);
2. Provide a way to use native modules among extensions' dependencies.
I am most probably no one to discuss pros or cons of these alternatives, there are maybe other alternatives that I cannot see, but I think that with the evidence provided it is clear that unless something changes the answer to the question in the title is MOST PROBABLY NOT! | feature-request,languages-basic | high | Critical |
206,486,035 | youtube-dl | Site Request: NowTV.com | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.07**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Site support request (request for adding support for a new site)
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://watch.nowtv.com/watch-entertainment/mo
rph/1950055733548510VgnVCM1000000b43150a____/seasons/1/episodes/1']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.02.07
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[generic] 1: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 1: Downloading webpage
[generic] 1: Extracting information
ERROR: Unsupported URL: http://watch.nowtv.com/watch-entertainment/morph/1950055
733548510VgnVCM1000000b43150a____/seasons/1/episodes/1
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\YoutubeDL.py", line 696, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\extractor\common.py", line 369, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\extractor\generic.py", line 2589, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: http://watch.nowtv.com/watch
-entertainment/morph/1950055733548510VgnVCM1000000b43150a____/seasons/1/episodes
/1
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: http://watch.nowtv.com/watch-entertainment/morph/1950055733548510VgnVCM1000000b43150a____/seasons/1/episodes/1
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
I'd like to make a request for nowtv.com please, thank you. | site-support-request,account-needed | low | Critical |
206,499,852 | youtube-dl | Site Request: anywhere.virginmedia.com | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.07**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Site support request (request for adding support for a new site)
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
youtube-dl.exe -v http://anywhere.virginmedia.com/sh
ow/wild-24
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://anywhere.virginmedia.com/show/wild-24'
]
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.02.07
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-83410-gb1e2192, ffprobe N-83410-gb1e2192
[debug] Proxy map: {}
[generic] wild-24: Requesting header
[redirect] Following redirect to http://anywhere.virginmedia.com/unsupportedBrow
ser/unsupported//show/wild-24
[generic] wild-24: Requesting header
WARNING: Falling back on generic information extractor.
[generic] wild-24: Downloading webpage
[generic] wild-24: Extracting information
ERROR: Unsupported URL: http://anywhere.virginmedia.com/unsupportedBrowser/unsup
ported//show/wild-24
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\YoutubeDL.py", line 696, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\extractor\common.py", line 369, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\extractor\generic.py", line 2589, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: http://anywhere.virginmedia.
com/unsupportedBrowser/unsupported//show/wild-24
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Playlist: http://anywhere.virginmedia.com/show/wild-24
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
I'd like to make a request for anywhere.virginmedia.com please, thank you.
| site-support-request,account-needed | low | Critical |
206,560,094 | angular | Update DOM when changing template in reactive form fails | **I'm submitting a ...** (check one with "x")
```
[ x ] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
```
**Current behavior**
<!-- Describe how the bug manifests. -->
Changing a reactive form template fails. When replacing the form, it throws an error: `Error in ./App class App - inline template:0:6 caused by: control.registerOnChange is not a function`
**Expected behavior**
<!-- Describe what the behavior would be without the bug. -->
It should not throw any error... and should change the template
**Minimal reproduction of the problem with instructions**
<!--
If the current behavior is a bug or you can illustrate your feature request better with an example,
please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via
https://plnkr.co or similar (you can use this template as a starting point: http://plnkr.co/edit/tpl:AvJOMERrnz94ekVua0u5).
-->
https://plnkr.co/edit/dJ1KyDLFDOOa1FUfWu5d?p=preview
Click on new template and check the console
**What is the motivation / use case for changing the behavior?**
<!-- Describe the motivation or the concrete use case -->
**Please tell us about your environment:**
<!-- Operating system, IDE, package manager, HTTP server, ... -->
NodeJS 7.4.0 running on Windows 10
* **Angular version:** 2.4.7
* **Browser:** Chrome 55 64bit
* **Language:** Typescript | type: bug/fix,freq3: high,area: forms,state: confirmed,P3 | medium | Critical |
206,561,332 | vscode | Git - Support GitHub 2FA | - VSCode Version: 1.9.1
- OS Version: Ubuntu 14.04, 16.04
Steps to Reproduce:
1. Make changes to a GitHub repo with two-factor authentication enabled
2. Push/Sync changes.
> Error: Authentication failed on the git remote.
A dialog box appears to enter your git username/password, but there is no subsequent dialog for the two-factor authentication code, and so the process just fails.
The `https` protocol was used for the `git clone` on this repo. | help wanted,feature-request,git | low | Critical |
206,575,665 | flutter | `flutter doctor` should warn if `flutter` is not in your path. | `brew doctor` and other tools do this. Our current flutter.io/setup instructions don't instruct you how to permenently add `flutter` to your path so it's easy to get into this state (if you restart).
It's possible we separately will want a `flutter install-in-path` or `flutter fix-path` or whatever to help folks with this over time. | c: new feature,tool,t: flutter doctor,P2,team-tool,triaged-tool | low | Major |
206,587,100 | go | cmd/compile: add tool for understanding/debugging SSA rules | As discussed in [CL 36329](https://golang.org/cl/36329), debugging SSA rules can be tedious and time-consuming. [CL 36646](https://golang.org/cl/36646) adds some rudimentary tools to help. This issue describes a pie-in-the-sky tool. Maybe we'll settle on something in between. :)
ssa.html appropriately treats rule-based passes (opt, dec, lower) as a single phase, but they actually perform a very long series of transformations, and it can be hard to see how the input relates to the output. In a typical rule pass, many many rules get applied, so putting them all side-by-side is not feasible.
But imagine some html dedicated to a single rule-based pass. Two columns, before and after, similar to existing ssa.html columns. A header at the top shows a single rule being applied, and if it does not apply, why it does not apply. Before column shows input to that rule, after shows output. Use arrow keys to step forward/back to watch rules get applied (or not) one at a time.
This would be unusable without a way to filter--there are too many rules to view them all one at a time. Filtering should consist of marking either rules and/or values of interest. Any rule marked as interesting always gets shown, whether it applies or not. Any rule that alters a value of interest gets shown. All other rules get compressed into a single "n rules applied" rule.
So a typical debugging experience might be:
* Mark rules as interesting in the rules file somehow.
* Provide a list of interesting values, from observing previous compilations of the same code. (Where/how? envvar? file? Specifying values of interest dynamically in UI might be too hard, for data volume and sanity reasons.)
* Compile, generating html artifact.
* Poke around at the rules/values you care about.
* Glorious comprehension / profit.
cc @rasky @randall77 @minux
| compiler/runtime | low | Critical |
206,594,148 | rust | Tracking issue for sanitizer support | Currently we have:
- A rustc flag, `-Z sanitizer`, to sanitize rlibs (it adds an extra LLVM pass/attribute) and executables (it links to the sanitizer runtime). Added in #38699.
- An attribute `#[no_sanitize]` to disable sanitization on specific functions. Also lints if those functions are marked as requesting inlining. Added in https://github.com/rust-lang/rust/pull/68164.
- `#[no_sanitize]` suppresses `#[inline]` hints. A lint is issued if combined with `#[inline(always)]`.
- A few violations (false positives?) in the test runner
- [x] ThreadSanitizer detects a data race in the test runner (`rustc --test`) #39608
- [x] MemorySanitizer detects an use of unitialized value in the test runner (`rustc --test`) #39610
- Known issues
- [x] Incremental compilation breaks sanitizers #39611
- Unresolved questions:
- [ ] Should we call the attribute `#[no_sanitize]` or perhaps something like `#[sanitize(never)]` or some other variation? In particular, might we at some point want "positive options" like `#[sanitize(miri(aggressive))]`? There is much back and forth in #68164.
- [ ] What should the user experience be to enable sanitizers, particularly when using cargo? Should cargo have first-class support? Is that blocked on build-std stabilizing? | B-unstable,T-dev-tools,A-sanitizers,C-tracking-issue,S-tracking-needs-summary,A-CLI | high | Critical |
206,600,235 | tensorflow | `tf.dynamic_stitch` gradient is incorrect | ### If possible, provide a minimal reproducible example (We usually don't have time to read hundreds of lines of your code)
Original reproduction code (TensorFlow 1.0)
``` python
import tensorflow as tf
x = tf.zeros((1, 3))
y = tf.dynamic_stitch([[0], [0]], [x, tf.ones((1, 3))])
with tf.Session() as sess:
print("y")
print(sess.run(y))
analytic, numeric = tf.test.compute_gradient(x, (1, 3), y, (1, 3))
print("analytic")
print(analytic)
print("numeric")
print(numeric)
```
Updated reproduction code (TensorFlow 2.16)
``` python
import tensorflow as tf
x = tf.zeros((1, 3))
analytic, numeric = tf.test.compute_gradient(
lambda x: tf.dynamic_stitch([[0], [0]], [x, tf.ones((1, 3))]), [x]
)
print("analytic")
print(analytic)
print("numeric")
print(numeric)
```
gives output
```
y
[[ 1. 1. 1.]]
analytic
[[ 1. 0. 0.]
[ 0. 1. 0.]
[ 0. 0. 1.]]
numeric
[[ 0. 0. 0.]
[ 0. 0. 0.]
[ 0. 0. 0.]]
```
The numeric gradient correctly shows that `x` has no impact on `y` (since the value of `x` is completely overwritten by a constant in the `dynamic_stitch`). The analytic gradient is incorrect; it seems like the gradient calculation in `dynamic_stitch` does not handle the case where there are duplicate indices being merged.
| stat:awaiting tensorflower,type:bug,comp:ops,TF 2.9 | medium | Major |
206,652,810 | pytorch | Feature Request: Easier to extend base RNN implementation | Currently base RNN class/functions are hard to extend. If someone would like to extend LSTM with new features to pytorch they would have to modify:
AutogradRNN ([nn/_functions/rnn.py](https://github.com/pytorch/pytorch/blob/master/torch/nn/_functions/rnn.py#L192-L234))
StackedRNN ([nn/_functions/rnn.py](https://github.com/pytorch/pytorch/blob/master/torch/nn/_functions/rnn.py#L50-L88))
RNNBase ([nn/modules/rnn.py](https://github.com/pytorch/pytorch/blob/master/torch/nn/modules/rnn.py#L9-L54))
Furthermore, the default RNN implementation is restrictive, enforcing every stacked RNN layer to be exactly the same.
I was thinking it may be worthwhile to instead have an RNN driver abstract RNN base class.
RNN Driver would be similar in function to recurrent, stackedRNN, and AutogradRNN functions but would be dependent on abstract RNN class but independent of specific RNN definitions.
The code would look something like...
```py
class RNNDriver(nn.Module):
#constructor could either take an RNN or list of RNN layers
def __init__(self, inputRNN, num_layers=1):
if not isinstance(inputRNN, list):
self.rnns = [inputRNN]
for i in range(num_layers-1):
self.rnns.append(inputRNN.clone())
else:
assert len(inputRNN) == num_layers, "RNN list length must be equal to num_layers"
self.rnns=inputRNN
#Parameters call to group parameters of all layers
def parameters(self):
memo = set()
for rnn in self.rnns:
for p in rnn.parameters(memo):
yield p
def forward(self, input, train=True, batch_first=False, dropout=0, bidirectional=False):
...
def initHidden(self, bsz):
for rnn in self.rnns:
rnn.initHidden(bsz)
def resetHidden(self, bsz):
for rnn in self.rnns:
rnn.resetHidden(bsz)
def initInference(self, bsz):
for rnn in self.rnns:
rnn.initInference(bsz)
class RNNBase(nn.Module):
#Base initialization could be for a simple RNN layer or could be empty
def __init__(self, input_size, hidden_size):
super(RNNBase, self).__init__()
self.hidden_size = hidden_size
self.input_size = input_size
self.w_ih = nn.Parameter(torch.Tensor(hidden_size, input_size))
self.b_ih = nn.Parameter(torch.Tensor(hidden_size))
self.w_hh = nn.Parameter(torch.Tensor(hidden_size, hidden_size))
self.hidden = None
self.reset_parameters()
def reset_parameters(self, feature_size):
stdv = 1.0 / math.sqrt(feature_size)
for weight in self.parameters():
weight.data.uniform_(-stdv, stdv)
def initHidden(self, bsz):
#Create hidden variable(s)
raise NotImplementedError
def resetHidden(self, bsz):
#Re-wrap hidden variables
raise NotImplementedError
def initInference(self, bsz):
#Re-wrap hidden in a variable with volatile=True
raise NotImplementedError
def forward(self, input):
#Implement RNN layer and return output
raise NotImplementedError
``` | feature,triaged,Stale | medium | Critical |
206,731,266 | go | cmd/pprof: invokeVisualizer is racy | In `invokeVisualizer`, we [defer deleting the temporary file](https://github.com/golang/go/blob/c439a5d8b77a3b87d94bc49714faeeb2a04112f4/src/cmd/pprof/internal/commands/commands.go#L205) when invoking the visualizer until the end of the `pprof` program. However, the `invokeVisualizer` [does not wait for the viewer to finish](https://github.com/golang/go/blob/c439a5d8b77a3b87d94bc49714faeeb2a04112f4/src/cmd/pprof/internal/commands/commands.go#L225-L229) when not running in interactive mode.
Thus, the following race occurs in non-interactive mode:
* `pprof` generates some report
* `pprof` invokes the browser to show report; Chrome starts running
* Without waiting for browser to end, we return from `invokeVisualizer` and the `pprof` program begins terminations.
* The `DeferDelete` is run, deleting the report file
* Chrome has finished starting up, but cannot find the file. Oops.
The fix is probably to wait for the visualizer to end regardless of "interactivity". | compiler/runtime | low | Minor |
206,752,777 | neovim | "dd if=/dev/zero | nvim -s -" hangs | - `nvim --version: NVIM 0.1.7 // Compilation: /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -Wconversion -O2 -DNDEBUG -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -DHAVE_CONFIG_H -D_GNU_SOURCE -I/build/neovim/src/build/config -I/build/neovim/src/neovim-0.1.7/src -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/build/neovim/src/build/src/nvim/auto -I/build/neovim/src/build/include
Compiled by builduser`
- Vim (version: ) behaves differently and accepts interrupts
- Operating system/version: arch linux, latest packages as of 11.02.2017.
- Terminal name/version: any or urxvt
- `$TERM`: rxvt-unicode-256color
### Actual behaviour
«dd if=/dev/zero | nvim» doesn't accept interrupts and the terminal is effectively *locked*
### Expected behaviour
Embrace the interrupt and die or stop reading from stdin.
### Steps to reproduce using `nvim -u NORC`
«dd if=/dev/zero | nvim -u NORC» | bug,io,input,system | low | Critical |
206,771,462 | opencv | CMake cannot find PythonLibs | ##### System information (version)
- OpenCV => 3.2.0
- Operating System / Platform => Windows 10
- Compiler => GNU 4.8.1
- Python => 3.5.0
- CMake => 3.7.2
- Generator => MinGW Makefiles
##### Detailed description
When I _configure_ using CMake-gui, I get
```
Found PythonInterp: D:/Python35/python.exe (found suitable version "3.5", minimum required is "2.7")
Found PythonInterp: D:/Python35/python.exe (found suitable version "3.5", minimum required is "3.4")
Could NOT find PythonLibs (missing: PYTHON_INCLUDE_DIRS) (Required is exact version "3.5.0")
```
On setting `PYTHON_INCLUDE_DIRS` to `D:/Python35/include` and configuring again, I no longer get the "could not find ..." message, but libraries are still not found:
```
Python 3:
Interpreter: D:/Python35/python.exe (ver 3.5)
Libraries: NO
numpy: D:/Python35/lib/site-packages/numpy/core/include (ver 1.11.2)
packages path: D:/Python35/Lib/site-packages
```
CMake screenshot:

| wontfix,category: build/install | low | Major |
206,790,578 | youtube-dl | Site Request: wuaki.tv | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.10**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Site support request (request for adding support for a new site)
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
youtube-dl.exe -v https://uk.wuaki.tv/movies/sintel
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'https://uk.wuaki.tv/movies/sintel']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.02.07
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-83410-gb1e2192, ffprobe N-83410-gb1e2192
[debug] Proxy map: {}
[generic] sintel: Requesting header
[redirect] Following redirect to https://uk.wuaki.tv/pages/update_browser
[generic] update_browser: Requesting header
WARNING: Falling back on generic information extractor.
[generic] update_browser: Downloading webpage
[generic] update_browser: Extracting information
ERROR: Unsupported URL: https://uk.wuaki.tv/pages/update_browser
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\YoutubeDL.py", line 696, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\extractor\common.py", line 369, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpfjt892j_\bu
ild\youtube_dl\extractor\generic.py", line 2589, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://uk.wuaki.tv/pages/up
date_browser
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://uk.wuaki.tv/movies/sintel (This is a free video)
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
I'd like to make a request for wuaki.tv please, thank you. | site-support-request,geo-restricted,account-needed | low | Critical |
206,830,780 | opencv | Clustering wiki page missing description of bestLabels function argument | - OpenCV => 2.4.3
- Operating System / Platform => Ubuntu 14.04
- Compiler => gcc
The wiki page on clustering (http://docs.opencv.org/2.4.3/modules/core/doc/clustering.html) doesn't have a description of what the function argument "bestLabels" does?
| feature,priority: low,category: documentation,affected: 2.4 | low | Minor |
206,845,091 | youtube-dl | Allow using ffmpeg -vf ( video filters ) in --external-downloader-args | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.02.10*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x ] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.10**
### Before submitting an *issue* make sure you have:
- [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output:
```
Option vf (set video filters) cannot be applied to input url http://livestream-f.akamaihd.net/i/23093026_6897778_lsiswg499e87c8vkhxz_1@407805/index_2320_av-b.m3u8?sd=10&dw=100&rebase=on&hdntl=exp=1486831046~acl=%2fi%2f23093026_6897778_lsiswg499e87c8vkhxz_1%40407805%2f*~data=hdntl~hmac=480a5086e32f3ffea64b61645ab7db0738f7e7e1c8000aeccd91de259aa8f63a -- you are trying to apply an input option to an output file or vice versa. Move this option before the file it belongs to.
Error parsing options for input file http://livestream-f.akamaihd.net/i/23093026_6897778_lsiswg499e87c8vkhxz_1@407805/index_2320_av-b.m3u8?sd=10&dw=100&rebase=on&hdntl=exp=1486831046~acl=%2fi%2f23093026_6897778_lsiswg499e87c8vkhxz_1%40407805%2f*~data=hdntl~hmac=480a5086e32f3ffea64b61645ab7db0738f7e7e1c8000aeccd91de259aa8f63a.
Error opening input files: Invalid argument
ERROR: ffmpeg exited with code 1
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 162, in _run_module_as_main
"__main__", fname, loader, pkg_name)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/local/bin/youtube-dl/__main__.py", line 19, in <module>
youtube_dl.main()
File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 451, in main
_real_main(argv)
File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 441, in _real_main
retcode = ydl.download(all_urls)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1791, in download
url, force_generic_extractor=self.params.get('force_generic_extractor', False))
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 705, in extract_info
return self.process_ie_result(ie_result, download, extra_info)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 751, in process_ie_result
return self.process_video_result(ie_result, download=download)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1435, in process_video_result
self.process_info(new_info)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1699, in process_info
success = dl(filename, info_dict)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1641, in dl
return fd.download(name, info)
File "/usr/local/bin/youtube-dl/youtube_dl/downloader/common.py", line 353, in download
return self.real_download(filename, info_dict)
File "/usr/local/bin/youtube-dl/youtube_dl/downloader/hls.py", line 77, in real_download
return fd.real_download(filename, info_dict)
File "/usr/local/bin/youtube-dl/youtube_dl/downloader/external.py", line 43, in real_download
self.get_basename(), retval))
File "/usr/local/bin/youtube-dl/youtube_dl/downloader/common.py", line 162, in report_error
self.ydl.report_error(*args, **kargs)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 568, in report_error
self.trouble(error_message, tb)
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 530, in trouble
tb_data = traceback.format_list(traceback.extract_stack())
```
---
### Description of your *issue*, suggested solution and other information
I would like to add a timestamp to a live video stream that I'm downloading. The command I'm running is as follows:
```
youtube-dl --hls-use-mpegts --external-downloader-args "-vf \"drawtext=fontfile=/Library/Fonts/Arial Black.ttf: \
text='%{localtime\:%c}': [email protected]: fontsize=24: box=1: [email protected]: \
boxborderw=5: x=(w-text_w)-10: y=10\"" "https://livestream.com/accounts/23093026/events/6897778/\
player?enableInfoAndActivity=true&autoPlay=true&mute=false&startswith=true"
```
I have tested the ffmpeg **-vf drawtext** arguments without youtube-dl and the timestamp is video filter is correctly added. example:
```
ffmpeg -i test.mp4 -s 640x480 -r 30 \
-vf "drawtext=fontfile=/Library/Fonts/Arial Black.ttf: \
text='%{localtime\:%c}': [email protected]: fontsize=24: box=1: [email protected]: \
boxborderw=5: x=(w-text_w)-10: y=10" -vcodec libx264 -vb 2000k \
-preset ultrafast -f mp4 output.mp4
```
But the error above ( Option vf (set video filters) cannot be applied to input url ... ) shows up when i run the youtube-dl command above. Please can you tell me if you know of a way I can get a time stamp appended to my livestream download? Thank you very much. | request | low | Critical |
206,946,627 | go | net, net/http: unpredictable slowness of TestSendfile and TestOnlyWriteTimeout w/ squeezed TCP windows | This is probably not an issue for the standard library; for the runtime package which retrieves data readable/writable notifications from the kernel, for the net package which invokes read/write system calls, and for the net/http package which adds, drops and manages in-flight connections and IO calls for customer traffic. This happens, as fa as I can observe, on any combination of FreeBSD 10 through 12 and go1.7 through tip.
When we run a script like the following:
```
#!/usr/bin/env bash
function die() {
rc=$?
sudo sysctl -w net.inet.tcp.recvspace=65536
sudo sysctl -w net.inet.tcp.sendspace=32768
exit $rc
}
for (( wnd=65536; wnd >= 1024; wnd /= 2 )); do
sudo sysctl -w net.inet.tcp.recvspace=$wnd
sudo sysctl -w net.inet.tcp.sendspace=$wnd
go test -v -run TestSendfile net || die
# go test -v -run TestOnlyWriteTimeout net/http || die
done
die
```
TestSendfile takes a bit long time with some window size.
```
net.inet.tcp.recvspace: 65536 -> 65536
net.inet.tcp.sendspace: 32768 -> 65536
=== RUN TestSendfile
--- PASS: TestSendfile (0.11s)
net.inet.tcp.recvspace: 65536 -> 32768
net.inet.tcp.sendspace: 65536 -> 32768
=== RUN TestSendfile
--- PASS: TestSendfile (15.24s)
net.inet.tcp.recvspace: 32768 -> 16384
net.inet.tcp.sendspace: 32768 -> 16384
=== RUN TestSendfile
--- PASS: TestSendfile (0.21s)
net.inet.tcp.recvspace: 16384 -> 8192
net.inet.tcp.sendspace: 16384 -> 8192
=== RUN TestSendfile
--- PASS: TestSendfile (83.76s)
net.inet.tcp.recvspace: 8192 -> 4096
net.inet.tcp.sendspace: 8192 -> 4096
=== RUN TestSendfile
--- PASS: TestSendfile (14.93s)
net.inet.tcp.recvspace: 4096 -> 2048
net.inet.tcp.sendspace: 4096 -> 2048
=== RUN TestSendfile
--- PASS: TestSendfile (25.12s)
net.inet.tcp.recvspace: 2048 -> 1024
net.inet.tcp.sendspace: 2048 -> 1024
=== RUN TestSendfile
--- PASS: TestSendfile (45.75s)
```
With a quick glance at system call trace, it looks like the kevent system call sometimes takes a long breath.
Not sure the reason; sb{r,w}wakeup miss some important condition? tcp_input miscalculates some threshold for sb{r,w}wakeup? tcp over ip over loopback interface does some special short-circuit/fuse stuff? or runtime-integrated network poller is not invoked appropriately? (the last one is unlikely)
Note that I ran the above test under some VM stuff on my '09 laptop and I guess that test results may vary on circumstances. | Performance | low | Major |
206,951,010 | opencv | cvtColor on OpenCL (AMD) doesn't compile | ##### System information (version)
- OpenCV => 3.2
- Operating System / Platform => Linux Ubuntu 16.04 64 Bit
- Compiler => gcc 5.4.0
- GPU => AMD FirePro S9300 x2
##### Detailed description
OpenCL kernel for cvtColor cannot be compiled using ROCm 1.4 driver. When the function compiles (when it is used) the compiler returns:
> OpenCL program build log: -D depth=0 -D scn=3 -D PIX_PER_WI_Y=1 -D dcn=1 -D bidx=0 -D STRIPE_SIZE=1 -D AMD_DEVICE
> error: <unknown>:0:0: in function Lab2BGR void (i8 addrspace(1)*, i32, i32, i8 addrspace(1)*, i32, i32, i32, i32, float addrspace(2)*, float, float): unsupported call to function Lab2BGR_f
> Error: Creating the executable failed: Compiling LLVM IRs to exe.
When looking at Lab2BGR in cvtcolor.cl we see it really does use a function named Lab2BGR_f. There seems nothing out of the ordinary about that function, except that it is inline. And while it normally wouldn't cause any problems it seems that with the current AMD CL driver this crashes. When I remove the inline everything works fine.
It doesn't return any stack trace or clang dump.
Cannot be replicated on Nvidia GPU's with Nvidia driver.
##### Steps to reproduce
```.cpp
// Just call cvtColor (any conversion) with OpenCL active
cv::cvtColor(in_device, out_device, cv::COLOR_BGR2GRAY);
``` | invalid,priority: low,category: ocl | low | Critical |
206,964,144 | vscode | search in files focus resets when line changed | - VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-08T23:44:55.542Z)
- OS Version: Linux x64 4.4.0-62-generic
- Extensions:
|Extension|Author|Version|
|---|---|---|
|glslx-vscode|evanw|0.0.8|
|cpptools|ms-vscode|0.10.1|
|csharp|ms-vscode|1.7.0|
|mono-debug|ms-vscode|0.13.0|
|debugger-for-chrome|msjsdiag|2.5.3|
|arduino-vscode|steveyin|0.2.0|
---
Steps to Reproduce:
1. ctrl-shift-f search for a string that appears at least 3 times
2. hit F4 a TWO times to go to the 2nd result.
- notice how in the search window the focused result is hilighted
3. now, edit the file (that contains the 2nd search result) so the line in that file no longer matches the search criteria.
- notice how the 2nd search result disappears from the search results pane, and NO results are hilighted.
4. hit F4 again.
- BUG: the first search result is hilighted.
expected: F4 should progress to the new 2nd search result (which was previously the 3rd result).
this bug breaks the process of using F4 to skip through results selectively editing, since every time you make an edit you have to start back at the beginning of the result. for hundreds of results, and many to skip repeatedly, this is extremely annoying.
| bug,search,confirmed | high | Critical |
207,016,536 | go | cmd/internal/obj: optimize wrapper method prologue for branch prediction | Wrapper functions (such as those found in CL 36809) have an extra prologue inserted during preprocessing. Quoting cmd/internal/obj/xk86/obj6.go (after CL 36833), what this does is:
```
// if g._panic != nil && g._panic.argp == FP {
// g._panic.argp = bottom-of-frame
// }
//
// MOVQ g_panic(CX), BX
// TESTQ BX, BX
// JEQ end
// LEAQ (autoffset+8)(SP), DI
// CMPQ panic_argp(BX), DI
// JNE end
// MOVQ SP, panic_argp(BX)
// end:
// NOP
```
These jumps are the wrong direction. Static branch prediction says forward jumps are not taken, but the first forward jump is almost always taken. Rearrange the code to fix that.
I have a CL, to be mailed momentarily, that does this. However, I am having a hard time writing a test for this, because I cannot find a way to trigger the rare (in-a-panic) cases. From reading the panic sources, this only happens when panicking inside a deferred statement (?), but even then I see the wrapper function in the traceback.
What exactly _is_ this prologue for? How do I test that it is doing its job correctly?
cc @randall77 @minux
| Performance,compiler/runtime | low | Minor |
207,018,351 | vscode | [html] prevent that embedded grammars can corrupt syntax highlighting of rest of document | Currently, when writing embedded language, a lot of the times the embedded grammar can cause disruption to the rest of DOCUMENT:
This is html grammar.

Imagine editing css in a `<style>` at the `<head>` of a long html file. The rest of document will be constantly re-tokenized and (wrongly) syntax highlighted. This doesn't look good UX-wise and will probably have some perf impact.
For the following grammar and setting:
```yaml
- name: source.css.embedded.html
begin: <style>
end: </style>
patterns:
- include: source.css
```
```json
"embeddedLanguages": {
"source.css": "css"
}
```
I hope VSCode can only apply CSS grammar to the section between `<style>` and `</style>`, so when I'm typing out my incomplete CSS VSCode would just re-tokenize and highlight until `</style>`, but not rest of the document.
/cc @alexandrudima
Also would like to hear @aeschli's opinion, as you are writing the html grammar.
| bug,upstream,languages-basic,debt | medium | Critical |
207,075,342 | youtube-dl | [site-support-request] Inform player | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.11**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Site support request (request for adding support for a new site)
---
thehill.com (news site for Washington, DC -- i.e. "Capitol Hill") seems to use a lot of different embedded players on different article pages, and youtube-dl is hit-or-miss with them.
The one I got stuck on today is
http://thehill.com/homenews/senate/319143-franken-says-he-would-have-told-trump-calling-warren-pocahontas-was-racist
which seems to use Akamai AMP via something called inform-news, although I'm not really sure.
I wasn't able to find any similar extractors, though obviously there is some support for Akamai AMP, so maybe I am just looking in the wrong place.
---
```
$ youtube-dl -v 'http://thehill.com/homenews/senate/319143-franken-says-he-would-have-told-trump-calling-warren-pocahontas-was-racist'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'-v', u'http://thehill.com/homenews/senate/319143-franken-says-he-would-have-told-trump-calling-warren-pocahontas-was-racist']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2017.02.11
[debug] Python version 2.7.10 - Darwin-14.5.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 3.1.5, ffprobe 3.1.5, rtmpdump 2.4
[debug] Proxy map: {}
[generic] 319143-franken-says-he-would-have-told-trump-calling-warren-pocahontas-was-racist: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 319143-franken-says-he-would-have-told-trump-calling-warren-pocahontas-was-racist: Downloading webpage
[generic] 319143-franken-says-he-would-have-told-trump-calling-warren-pocahontas-was-racist: Extracting information
ERROR: Unsupported URL: http://thehill.com/homenews/senate/319143-franken-says-he-would-have-told-trump-calling-warren-pocahontas-was-racist
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 1741, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2526, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2515, in _XML
parser.feed(text)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
self._raiseerror(v)
File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 342, column 21
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 696, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 369, in extract
return self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2589, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: http://thehill.com/homenews/senate/319143-franken-says-he-would-have-told-trump-calling-warren-pocahontas-was-racist
```
---
The HTML seems to have this form for the video:
```
<div class="inform-embed"
data-config-id="1"
data-type="VideoPlayer/Single"
data-tracking-group="91690"
data-playlist-id="13434"
data-video-id="31974114"
data-site-section="thehill2300_nws_pol_sec">
</div>
```
although after JS runs on the page the DOM has:
```
<div id="inform-player-container-1" style="width:100%;height:100%;" data-amp.version="AMP Premier - NDN v1.53.x.0004" class="akamai-flash akamai-player akamai-desktop akamai-vod akamai-medium-video akamai-ad-mode akamai-paused">
<div class="akamai-video akamai-layer">
<object type="application/x-shockwave-flash" id="flashObject1486927047763" name="flashObject1486927047763" data="http://launch.newsinc.com/167/js/lib/amp.premier/AkamaiPremierPlayer.swf" style="visibility: visible;" class="akamai-media-element" height="100%" width="100%">
...
``` | site-support-request | low | Critical |
207,093,160 | rust | Performance regression in nightly-2017-01-15 | I've recently run into a performance regression in the Rust compiler in a project I'm working on. I've used nightlies to narrow it down to somewhere in 778988174..bf6d7b665. Specifically, the 2017-01-14 nightly is good, and 2017-01-15 is bad. The regression is independent of `CARGO_INCREMENTAL=1`.
If you have a machine with a few cores, you can test it on a clone of https://github.com/mit-pdos/distributary/. Run with
```console
$ cargo run -v --release --bin vote -- --avg --articles=100000 --runtime=10 --migrate=3 soup:// | grep 'PUT+'
```
On `-14`, the "migration" mentioned in the middle finishes quite quickly. On `-15`, it takes a long time, and so `PUT` never transitions to `PUT+`.
I wanted to try a `git bisect` to narrow the problem down further, but compiling it takes *forever*. A cursory glance over the commit range doesn't reveal anything particularly suspect, and `#rust-internals` told me to post here to get some more eyes on the problem. | I-slow,C-enhancement,T-compiler,A-incr-comp | medium | Major |
207,117,260 | opencv | Minor C++11 type narrowing issues with IplImage->depth? | ##### System information (version)
- OpenCV => any
- Operating System / Platform => Mac OSX
- Compiler => Xcode 7.1.1
##### Detailed description
Building OpenCV itself with C++11 on Mac OS X used to fail
( http://code.opencv.org/issues/2263 ); the problem was probably suppressed by
https://github.com/opencv/opencv/commit/c5aba337 which added
add_extra_compiler_option(-Wno-narrowing) to CMakeLists.txt.
But apps that use opencv and happen to write functions that do
```
switch (my_iplImage->depth) {
case IPL_DEPTH_32S: ...
```
will fail to compile with errors like
error: case value evaluates to 2147483680, which cannot be narrowed to type 'int' [-Wc++11-narrowing]
because IPL_DEPTH_32S is built up using #define IPL_DEPTH_SIGN 0x80000000,
which is not a legal int.
##### Steps to reproduce
Given x.cc:
```
#include <opencv2/core/core_c.h>
int foo(IplImage &foobar) {
switch (foobar.depth) {
case IPL_DEPTH_32S: return 1;
}
return 0;
}
```
the following command fails:
```
g++ -I /path/to/opencv/include -c -std=c++11 -Wall x.cc
x.cc:5:9: error: case value evaluates to 2147483680, which cannot be narrowed to type 'int' [-Wc++11-narrowing]
case IPL_DEPTH_32S: return 1;
^
/path/to/opencv//include/opencv2/core/types_c.h:444:23: note: expanded from macro 'IPL_DEPTH_32S'
#define IPL_DEPTH_32S (IPL_DEPTH_SIGN|32)
^
1 error generated
```
The app can work around this by casting foobar.depth to unsigned int,
but shouldn't have to. If opencv were to clean up its act and enable
the narrowing warning, this minor user annoyance would go away.
| bug,category: build/install | low | Critical |
207,132,707 | opencv | OpenCL Implementation for cv::StereoSGBM is missing | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 3.2
- Operating System / Platform => macOS Sierra (10.12.3)
- Compiler => gcc
##### Detailed description
OpenCV 3 has supported T-APIs (Transparent APIs) which enables code to be ran with OpenCL or without OpenCL support based on the availability of the Hardware Support.
Though I found that StereoSGBM algorithm lacks on OpenCL Kernel Implementation. Yet similar algorithm StereoBM is implemented OpenCL Kernel (One may want to take reference from)
This Issue submit requests new feature/implementation of StereoSGBM under OpenCL.
There has been 2 Separate Implementation for OpenCV implementation for StereoSGBM (Normal and 3Way) both uses some of the common computation methods.
Mark this as new Implementation Issue.
| feature,category: calib3d,category: ocl | low | Critical |
207,141,570 | vscode | Search: target particular set of files | - VSCode Version: Code 1.9.1 (f9d0c687ff2ea7aabd85fb9a43129117c0ecf519, 2017-02-08T23:31:51.320Z)
- OS Version: Darwin x64 15.6.0
- Extensions:
|Extension|Author|Version|
|---|---|---|
|cpptools|ms-vscode|0.10.1|
---
Steps to Reproduce:
1.when i use global search, it's not easy to type whole file path and name in input box,
hope that there is a convenient way to use highlight in search current file by typing "<current file>"
---
Note from @roblourens This includes searching in any particular subset of files such as
- All open files
- Files staged in git
- Recently modified files
etc | feature-request,search | high | Critical |
207,221,694 | vue | Аn unexpected behaviour when using <transition> with a Vue component. | ### Vue.js version
2.1.10
### Reproduction Link
https://jsfiddle.net/bhrztdjn/4/
### Steps to reproduce
Click on "Toggle" button.
### What is Expected?
Transitions for a component should have the same behavior as transitions applied to HTML element.
### What is actually happening?
A CSS transition works fine with an HTML element with both directive - `v-if` and `v-show` (as [declared in docs](https://vuejs.org/v2/guide/transitions.html#Transitioning-Single-Elements-Components)).
But for the component, which has a directive v-show on its root element the transition isn't applied on entering and leaving states.
And for the component, which has a directive v-if on its root element the transition isn't applied on leaving state. | improvement,transition | low | Major |
207,243,242 | go | database/sql: sql.Result has problems that should be fixed / replaced | I'm not proposing anything at this point. I'm just documenting various things I've come things I've come across that relate to sql.Result.
@mjibson has said:
> the current problem i'm having with the database/sql API is that it's not possible to get intermediate non-rows returning results when sending multiple statements in a single string
for example given create table t (i int); drop table a; i'd like to get back 2 results instead of 1. the next result sets stuff assumes that a full rows object instead of optionally returning a sql.Result instead. i am modifying lib/pq to support this, but only if you don't use database/sql.
The other @mattn has [said](https://github.com/mattn/go-oci8/issues/55#issuecomment-271909189):
> One of the motivation is rowid in oracle. rowid is not number, so go-oci8 doesn't work correctly for the go's LastInsertId. The second, we have to allocate/free the buffer to get result specific value for the pl/sql.
@tgulacsi do you have anything to add?
| NeedsInvestigation | medium | Major |
207,268,072 | go | proposal: runtime: add AlignedN types that can be used to increase alignment | The sync/atomic packages have this in the docs in the "Bugs" section: "On both ARM and x86-32, it is the caller's responsibility to arrange for 64-bit alignment of 64-bit words accessed atomically. The first word in a global variable or in an allocated struct or slice can be relied upon to be 64-bit aligned." This makes it difficult to use atomic operations in types that may not necessarily be at the beginning of an allocated struct or slice. For example, `sync.WaitGroup` does this:
// 64-bit value: high 32 bits are counter, low 32 bits are waiter count.
// 64-bit atomic operations require 64-bit alignment, but 32-bit
// compilers do not ensure it. So we allocate 12 bytes and then use
// the aligned 8 bytes in them as state.
state1 [12]byte
and this:
func (wg *WaitGroup) state() *uint64 {
if uintptr(unsafe.Pointer(&wg.state1))%8 == 0 {
return (*uint64)(unsafe.Pointer(&wg.state1))
} else {
return (*uint64)(unsafe.Pointer(&wg.state1[4]))
}
}
Further, on x86 there are vector instructions that require alignment to 16 bytes, and there are even some instructions (e.g., `vmovaps` with VEC.256), that require 32 byte alignment. While those instructions are not currently generated by the gc compiler, one can easily imagine using them in assembler code, which will require the values to be appropriately aligned.
To permit programmers to force the desired alignment, I propose that we add new types to the runtime package: `runtime.Aligned2`, `runtime.Aligned4`, `runtime.Aligned8`, `runtime.Aligned16`, `runtime.Aligned32`, `runtime.Aligned64`, `runtime.Aligned128`. (We could also use bit values, giving us `runtime.Aligned16` through `runtime.Aligned1024`, if that seems clearer.)
These types will be identical to the type `struct{}` except that they will have a the alignment implied by the name. This will make it possible to write a struct as
type vector struct {
vals [16]byte
_ runtime.Aligned16
}
and ensure that instances of this struct will always be aligned to a 16 byte boundary.
It will be possible to change `sync.Waitgroup` to be
type WaitGroup struct {
noCopy noCopy
_ runtime.Aligned8
state uint64
sema uint32
}
simplifying the code.
Although this functionality will not be used widely, it does provide a facility that we need today without requiring awkward workarounds. The drawback is the addition of a new concept to the runtime, though I think it is fairly clear to those people who need to use it.
Another complexity is that we will have to decide whether the size of a value is always a multiple of the alignment of the value. Currently that is the case. It would not be the case for the `runtime.AlignedN` values. Should it be the case for any struct that contains a field with one of those types? If the size of a value is not always a multiple of the alignment, we will have to modify the memory allocator to support that concept. I don't think that will be particularly difficult, but I haven't really looked. | Proposal,Proposal-Hold | high | Critical |
207,286,621 | rust | rustdoc splits test-args wrongly | rustdoc is [splitting](https://github.com/rust-lang/rust/blob/717ac960b51a5a2bbedf0e4da899aec7ab2ab7ee/src/librustdoc/lib.rs#L238-L241) test-args using split_whitespace, it should use something like [shlex](https://crates.io/crates/shlex/).
After the output of rusdoc testing changes, it is not possible to run a specific test anymore. For example, consider a x.rs file:
```rust
/// ```
/// assert!(true);
/// ```
fn f() { }
```
With stable compiler (1.15.1), this run the test
```
rustdoc +stable x.rs --test --test-args --exact --test-args "f_0"
```
With nightly compiler (1.17.0-nightly (ba7cf7cc5 2017-02-11)), this does not run the test
```
rustdoc +nightly x.rs --test --test-args --exact --test-args "x.rs - line 1"
```
Note that I'm taking the test name using `rustdoc +stable x.rs --test --test-args --list`
It would be great if something like `rustdoc +nightly x.rs --test --test-args '--exact "x.rs - line 1"'` worked.
| T-rustdoc,C-feature-request | low | Major |
207,303,794 | flutter | Would like `flutter devices` to show gpu information | I have a lot of phones on my desk. Sometimes I want to know what GPU one has. Would be nice if `flutter devices` told me.
Might also be nice for bug reports, to save us one step in looking up a phone model.
For example, right now I have a phone which on the back says "Galaxy S III mini", and flutter devices says:
```
%flutter devices [/tmp/gradel]
1 connected device:
SAMSUNG SM G730A • 6a5d62e9 • android-arm • Android 4.2.2 (API 17)
```
Would be nice to know a bit more, including at least the GPU. | c: new feature,team,tool,P3,team-tool,triaged-tool | low | Critical |
207,311,845 | youtube-dl | Site Request: Blaze.TV | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.02.14**
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Site support request (request for adding support for a new site)
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
youtube-dl.exe -v http://www.blaze.tv/series/seasons
/episode?series=American%20Restoration&season=0&episode=9
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', 'http://www.blaze.tv/series/seasons/episode?se
ries=American%20Restoration']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2017.02.10
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: ffmpeg N-83410-gb1e2192, ffprobe N-83410-gb1e2192
[debug] Proxy map: {}
[generic] episode?series=American Restoration: Requesting header
WARNING: Falling back on generic information extractor.
[generic] episode?series=American Restoration: Downloading webpage
[generic] episode?series=American Restoration: Extracting information
ERROR: Unsupported URL: http://www.blaze.tv/series/seasons/episode?series=Americ
an%20Restoration
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpdk0ryty4\bu
ild\youtube_dl\YoutubeDL.py", line 696, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpdk0ryty4\bu
ild\youtube_dl\extractor\common.py", line 369, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpdk0ryty4\bu
ild\youtube_dl\extractor\generic.py", line 2589, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: http://www.blaze.tv/series/s
easons/episode?series=American%20Restoration
'season' is not recognized as an internal or external command,
operable program or batch file.
'episode' is not recognized as an internal or external command,
operable program or batch file.
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: http://www.blaze.tv/series/seasons/episode?series=American%20Restoration&season=0&episode=9
---
### Description of your *issue*, suggested solution and other information
Please add support for www.Blaze.TV | site-support-request,geo-restricted | low | Critical |
207,314,547 | flutter | Add support for parallax effect in scrolling Widgets | I'd like to have a parallax scrolling effect in `ListView` items - namely, the actual image content be offset with regards to the `Image` displaying it in such a way as to create the impression that image is "behind" the main plane and thus moving slower.
I made a short video of the original Android version of the app I am trying to port to Flutter: https://www.youtube.com/watch?v=5FTf1irqhDM
In #1234 @abarth mentioned the sliver protocol as part of a possible solution. | c: new feature,framework,f: scrolling,d: examples,P3,team-framework,triaged-framework | low | Major |
207,363,099 | go | doc: Effective Go's "safelyDo" does not demonstrate safe use of recover | Effective Go gives an [example](https://golang.org/doc/effective_go.html#recover) of a server that captures and logs panics so that a single panicking goroutine does not take down the entire server. Copying the example below:
```go
func server(workChan <-chan *Work) {
for work := range workChan {
go safelyDo(work)
}
}
func safelyDo(work *Work) {
defer func() {
if err := recover(); err != nil {
log.Println("work failed:", err)
}
}()
do(work)
}
```
This design is controversial and I recommend that the example be either removed or updated with caveats. In general, there is no guarantee that shared data structures are in a usable and safe state after a panic occurs. It is arguably better to let panics crash the program. Empirically, the above design has led to real bugs in production systems. Specific examples of how bugs can arise:
1. A held mutex is not unlocked after the panic because the caller did not use `defer m.Unlock()`. This is a specific example of how `do(work)` may not be _panic safe_. Note that `do(work)` is especially vulnerable if it calls library code that is not panic safe.
2. The panic is the result of an invariant violation in a shared data structure. Program execution should not continue because the shared data structure is in an invalid state.
3. The panic is the result of a data race. Technically, program behavior is undefined from this point (especially if the data race involved an interface or slice).
Given these potential problems, I would argue that `safelyDo` is actually not safe. That said, the general design is not entirely invalid. It is possible to write a safe version of `safelyDo`, but to do so, one of the following properties must be guaranteed:
1. `safelyDo` must only recover from explicitly-thrown panics that it knows about. An example of this is shown in the `Compile` regexp function just below the `safelyDo` example.
2. The goroutines must not use any mutable shared state, i.e., `safelyDo(a)` touches completely disjoint state than `safelyDo(b)` for all `a != b`. This implies that `safelyDo` cannot invoke any libraries that use mutable shared state.
3. The implementation of `do(work)` must be completely panic safe, including all library code used by the implementation. | Documentation,NeedsFix | low | Critical |
207,363,717 | TypeScript | Re-export module namespace as global | We're attempting to migrate users within Google to new @types typings, which move most typings into modules, and having a ton of trouble. The basic problem is that a module (e.g. CodeMirror) used to declare a global complex interface:
```
declare function CodeMirror(...);
declare namespace CodeMirror { ... }
```
and now they are modules:
```
export = CodeMirror;
```
and other typings refer to them as modules (so we can't just undo that export statement) but we also have tons of older user code that *doesn't* refer to them as modules. Ideally we'd be able to make it work both ways while we migrate users incrementally.
I appreciate that you don't want the language to make this convenient, but I'm having difficulty finding any way to make it work temporarily while we migrate.
Some things I tried:
1) Aliasing the module into the global namespace
```
declare global {
import CodeMirror = require('codemirror');
}
```
(and other variants) fails with "Imports are not permitted in module augmentations.".
2) Making the module global first, then aliasing it into a module namespace.
If you wrap the file contents with a "declare global {", then I couldn't figure out a way to repackage that global as a module again. The `export = CodeMirror;` fails with "Cannot find name 'CodeMirror'." despite the global CodeMirror being declared in the same file.
Do you have any advice? Note that "export as namespace" doesn't help because our user code is already modules, not scripts. | Suggestion,In Discussion | medium | Critical |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.