id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
639,659,684 |
flutter
|
Documentation is not clear if ActivityAware is supported with v1 embedding.
|
## Steps to Reproduce
1. Go to https://flutter.dev/docs/development/packages-and-plugins/plugin-api-migration or https://api.flutter.dev/javadoc/io/flutter/embedding/engine/plugins/activity/ActivityAware.html to learn about the Android Plugin API Migration and ActivityAware.
2. Observe `(Optional) If your plugin needs an Activity reference, also implement the ActivityAware interface.` in the first link.
3. Read documentation that states if `ActivityAware` will function on pre Flutter 1.12 Android projects.
**Expected results:** Documentation exists.
**Actual results:** Not clear if ActivityAware is supposed to work on pre Flutter 1.12 Android projects.
I am unable to get it to work but I'm not sure if its a bug or an unsupported scenario.
```
[✓] Flutter (Channel stable, v1.17.3, on Mac OS X 10.15.5 19F101, locale en-CA)
• Flutter version 1.17.3 at /Users/jrai/dev/flutter
• Framework revision b041144f83 (12 days ago), 2020-06-04 09:26:11 -0700
• Engine revision ee76268252
• Dart version 2.8.4
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at /Users/jrai/Library/Android/sdk
• Platform android-29, build-tools 29.0.3
• Java binary at: /Users/jrai/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.5)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.5, Build version 11E608c
• CocoaPods version 1.9.3
[✓] Android Studio (version 4.0)
• Android Studio at /Users/jrai/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android Studio.app/Contents
• Flutter plugin version 46.0.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] VS Code (version 1.46.0)
• VS Code at /Applications/Visual Studio Code.app/Contents
• Flutter extension version 3.11.0
[✓] Connected device (1 available)
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator)
• No issues found!
```
|
platform-android,engine,d: api docs,e: embedder,P2,team-android,triaged-android
|
low
|
Critical
|
639,750,690 |
pytorch
|
Bump up NCCL to 2.7.3
|
NCCL 2.7 has been release with p2p communication. Let's upgrade our NCCL submodule to 2.7.
https://docs.nvidia.com/deeplearning/nccl/user-guide/docs/usage/p2p.html#sendrecv
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
|
oncall: distributed,triaged,module: nccl
|
low
|
Major
|
639,784,120 |
flutter
|
Proxy `flutter run -d web-device` output
|
## Use case
When developing web apps, you typically serve the generated frontend assets from the backend server to avoid CORS, use real certificates, etc. This doesn't seem possible today with flutter unless you reverse proxy the web-server device, which lacks in browser refresh and makes the development process quite painful.
## Proposal
Ideally, it would be great to have a flag/option for flutter to save the output files on disk and expose some kind of SSE port to receive refresh notifications on (like webpack). In lieu of this, have the web-server device pass the same SSE refresh events as the chrome device.
|
c: new feature,tool,framework,platform-web,c: proposal,P3,team-web,triaged-web
|
low
|
Minor
|
639,784,388 |
pytorch
|
Updating learning rate with Libtorch 1.5 and optimiser options
|
This is my first question ever on Github, so please accept my apologies if I have not posted this in the right place. With the release of the 1.5 stable version of the C++ API for PyTorch, there are some changes in some of the object interfaces. For instance, now
`optimizer.options.learning_rate();`
won't work (here the optimiser being used is Adam) since `learning_rate` has changed to `lr` (see https://github.com/pytorch/pytorch/releases) but moreover the optimiser no longer has options (`no member named 'options' in 'torch::optim::Adam'`). So my question is: how would one run
`optimizer.options.learning_rate();`
or update the learning rate
`optimizer.options.learning_rate(updatedlearningrate);`
with the new release? Any help will be appreciated! Thank you
cc @yf225 @glaringlee @vincentqb
|
module: cpp,module: optimizer,triaged
|
low
|
Minor
|
639,791,335 |
deno
|
ECDSA Certificate Support
|
Can we get ECDSA certificate support? Currently, deno doesn't recognize them as certificates when given to serveTLS or listenAndServeTLS (in the http standard module).
|
feat,cli,tls
|
low
|
Minor
|
639,813,021 |
godot
|
Mono Build fails with "Missing required property 'OutputPath' for project type 'PackageReference'."
|
<!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
v3.2.2.rc1.mono.official
**OS/device including version:**
Windows 10
**Issue description:**
Cannot build any Mono Project with MSBuild (Mono). Projects build without a problem using MSBuild (VS Build Tools).
**Steps to reproduce:**
- Try to build a Mono project with Godot_v3.2.1-stable_mono_win64.exe using MSBuild (Mono)
**Minimal reproduction project:**
[Test Mono RC1.zip](https://github.com/godotengine/godot/files/4787739/Test.Mono.RC1.zip)
Console Output:
```
Godot Engine v3.2.2.rc1.mono.official - https://godotengine.org
OpenGL ES 3.0 Renderer: Intel(R) HD Graphics 4600
Mono: Logfile is: C:\Users\Marcel\AppData\Roaming/Godot/mono/mono_logs/2020_06_16 17.16.11 (15180).txt
Editing project: C:/Users/Marcel/Downloads/Godot/Test Mono RC1 (C:::Users::Marcel::Downloads::Godot::Test Mono RC1)
Godot Engine v3.2.2.rc1.mono.official - https://godotengine.org
OpenGL ES 3.0 Renderer: Intel(R) HD Graphics 4600
Mono: Logfile is: C:\Users\Marcel\AppData\Roaming/Godot/mono/mono_logs/2020_06_16 17.16.14 (8508).txt
Running: "C:\Program Files\Mono\bin\msbuild.bat" "C:/Users/Marcel/Downloads/Godot/Test Mono RC1/Test Mono RC1.sln" /v:normal /t:Restore,Build "/p:Configuration=Debug" "/l:GodotTools.BuildLogger.GodotBuildLogger,C:\Users\Marcel\Downloads\Godot\Godot_v3.2.2-rc1_mono_win64\GodotSharp\Tools\GodotTools.BuildLogger.dll;C:\Users\Marcel\AppData\Roaming/Godot/mono/build_logs\adeb49de002905ec5b4f1c77aaf06cf7_Debug" /p:GodotDefineConstants=\"GODOT_WINDOWS;GODOT_64;\"
Microsoft (R) Build Engine version 16.5.0-ci for Mono
Copyright (C) Microsoft Corporation. All rights reserved.
Build started 16/06/2020 17:16:20.
Project "C:\Users\Marcel\Downloads\Godot\Test Mono RC1\Test Mono RC1.sln" on node 1 (Restore;Build target(s)).
ValidateSolutionConfiguration:
Building solution configuration "Debug|Any CPU".
ERROR: call_build: An EditorPlugin build callback failed.
At: editor/editor_node.cpp:5276
```
Build Log:
```
Project "Test Mono RC1.sln" (Restore;Build target(s)):
Message: Building solution configuration "Debug|Any CPU".
Project "Test Mono RC1.csproj" (Restore target(s)):
Project "Test Mono RC1.csproj" (_IsProjectRestoreSupported target(s)):
Done building project "Test Mono RC1.csproj".
Project "Test Mono RC1.csproj" (_GenerateRestoreProjectPathWalk target(s)):
Done building project "Test Mono RC1.csproj".
Project "Test Mono RC1.csproj" (_IsProjectRestoreSupported target(s)):
Done building project "Test Mono RC1.csproj".
Project "Test Mono RC1.csproj" (_GenerateRestoreGraphProjectEntry target(s)):
Done building project "Test Mono RC1.csproj".
Project "Test Mono RC1.csproj" (_GenerateProjectRestoreGraph target(s)):
Done building project "Test Mono RC1.csproj".
C:\Program Files\Mono\lib\mono\msbuild\15.0\bin\NuGet.targets(124,5): error : Invalid restore input. Missing required property 'OutputPath' for project type 'PackageReference'. Input files: C:\Users\Marcel\Downloads\Godot\Test Mono RC1\Test Mono RC1.csproj. [C:\Users\Marcel\Downloads\Godot\Test Mono RC1\Test Mono RC1.csproj]
```
Possibly related to #36361.
|
bug,platform:windows,confirmed,topic:dotnet
|
low
|
Critical
|
639,821,749 |
flutter
|
MaterialStateMouseCursor.clickable should only show "hand" pointer in Web apps
|
The "hand" pointer used on websites has no precedent of being used outside Web apps. The default behavior of `MaterialStateMouseCursor.clickable` should be to only return `SystemMouseCursors.click` is the application is running in a web browser.
## Use case
All non-web apps built with Flutter.
## Proposal
In `MaterialStateMouseCursor.clickable`, only return the `SystemMouseCursors.click` cursor if `kIsWeb == true`.
|
c: new feature,framework,platform-mac,platform-windows,platform-linux,c: proposal,a: desktop,a: mouse,P2,team-framework,triaged-framework
|
low
|
Major
|
639,827,553 |
flutter
|
API to get the screen resolution
|
`ui.window.physicalSize` and `MediaQuery.size` (at least for the root one provided by the framework) provide the _current size_ of the Window object. On mobile platforms, this is typically the same as the screen resolution.
On web and desktop, the window can be trivially resized. If a user wishes to, e.g., size an image based on the maximum resolution of the screen, they don't have a good way to do that right now.
/cc @yjbanov @stuartmorgan for thoughts on severity of this issue.
|
c: new feature,framework,engine,platform-web,a: desktop,P3,team-engine,triaged-engine
|
low
|
Minor
|
639,839,711 |
rust
|
Extend `#[must_use]` to more types
|
In particular, we should add `#[must_use]` to these "wrapper" types in the standard library:
- #67387 `Pin`
- #71368 `Option`
Both would be conditioned on whether `T` was `#[must_use]`.
|
T-lang,T-libs-api,A-async-await,AsyncAwait-Triaged
|
low
|
Minor
|
639,891,562 |
terminal
|
[VT Mouse Mode] No mouse tracking when window is unfocused
|
**NOTES** (@DHowett): gnome-terminal and xterm both emit mouse events when the window is unfocused, even on Windows. Perhaps we need to decide whether to do the same?
---
# Steps to reproduce
Use WSL profile, enable the mouse tracking mode `SGR (1006)`:
```cmd
echo -e '\e[?1003;1006h'
```
Unfocus the terminal window.
Mouse movement on the window is no longer tracked when the terminal window loses focus.
# Expected behavior
The terminal tracks mouse movement regardless of focus.
# Actual behavior
The terminal does not track the mouse when the window is unfocused.
|
Product-Conhost,Area-Input,Area-VT,Issue-Task
|
low
|
Minor
|
639,895,952 |
pytorch
|
[RFC] Add a RPC context manager that collects/waits for all RPC futures created in scope
|
Inspired by this forum post: https://discuss.pytorch.org/t/distributed-pagerank-with-pytorch/78529/17
Currently, applications need to manually collect all futures created by RPC and wait for them if necessary. This is a bit cumbersome and might even be hard if some imported libraries uses RPC.
To make it easier to use, we could create a context manager to automatically collects all futures created in scope by `RpcAgent::send` and wait for all of them on exit. It might be sufficient to just collect futures created by the current threads and ignore nested RPCs in requests handled in the RPC thread pool.
## Update
As we will be using this as a bootcamp task, let me add more details to this issue.
### Pitch
#### API
Suppose the context manager is called `wait_all()`. Open to better names. It creates a thread local list to hold all `Future` objects returned by `RpcAgent::sendWithRetries` and wait for all of them on exit.
```python
with rpc.wait_all():
rpc.rpc_async(...)
rref = rpc.remote(...)
some_imported_func_with_rpc(...)
# block here until all created futures (including the ones for RRefs) are done
```
Note that this can be used in conjunction with #40166. Applications can perform per-iteration sync using:
```python
with rpc.wait_all():
run_one_iteration()
rpc.barrier()
```
#### Implementation Phase 1 (Python-Only)
**Goal**: only wait for `Future` objects created by `rpc_async`.
1. Add the context manager, which collects the future returned by the following function
https://github.com/pytorch/pytorch/blob/591fffc5245e1ce8b00cf2a778d5874e43655d53/torch/distributed/rpc/api.py#L593-L674
2. Add tests to cover `rpc_async` to [`rpc_test.py`](https://github.com/pytorch/pytorch/blob/591fffc5245e1ce8b00cf2a778d5874e43655d53/torch/testing/_internal/distributed/rpc/rpc_test.py). Note that this might change if [this stack](https://github.com/pytorch/pytorch/pull/40860) lands first.
#### Implementation Phase 2 (Touches C++ Code)
1. Create a C++ thread local variable to collect Futures returned by the following function:
https://github.com/pytorch/pytorch/blob/591fffc5245e1ce8b00cf2a778d5874e43655d53/torch/csrc/distributed/rpc/rpc_agent.cpp#L48-L83
2. Expose that variable (setter/getter) through pybind11. Similar to the code below:
https://github.com/pytorch/pytorch/blob/591fffc5245e1ce8b00cf2a778d5874e43655d53/torch/csrc/distributed/rpc/init.cpp#L718-L723
3. Remove the Python thread local variable added in phase 1, and port the context manager to use the pybind exported APIs.
4. Add tests to cover `remote` to [`rpc_test.py`](https://github.com/pytorch/pytorch/blob/591fffc5245e1ce8b00cf2a778d5874e43655d53/torch/testing/_internal/distributed/rpc/rpc_test.py).
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar
|
module: bootcamp,feature,triaged,module: rpc
|
low
|
Major
|
639,916,050 |
flutter
|
Material bottom sheets do not account for keyboard visibility
|
Material bottom sheets require manual intervention to co-exist with visible software keyboards.
I think that this is either a bug that should be addressed, or an issue of mismatched expectations that should be clearly documented.
There have been other issues filed related to this. One such issue is here:
https://github.com/flutter/flutter/issues/18564
That issue was closed because it appeared to be over-specified in the original post in relation to the broad set of frustrations that are logged by other commenters in that thread. Based on that thread, it doesn't appear that Flutter provided a solution to the general problem, but only a workaround for a specific problem.
This ticket is about the general issue of keyboard input within the context of a modal bottom sheet.
It is stated in the documentation for `showModalBottomSheet` that "A modal bottom sheet is an alternative to a menu or a dialog...".
Dialogs are often used to collect text input, e.g., signing into an account via a dialog. Therefore, a modal bottom sheet should be equally capable of including text fields without further modification.
The 2 prevalent workarounds from what I've seen in the linked thread are:
* Wrap the content of the bottom sheet in a `Scaffold` so that the bottom insets are automatically adjusted
* Use a `Padding` that looks up the `MediaQuery` insets
In my case, I couldn't even get the `Scaffold` approach to work. It correctly moved the bottom insets up, but the top of my bottom sheet was kept the same, resulting in a scrunched bottom sheet that was only about 50 pixels tall.
The `Padding` option requires that developers understand the connection between the keyboard's visibility, its impact on the concept of view insets, and the fact that such insets can be obtained from a `MediaQuery`. I don't believe it's in Flutter's interest to expect this level of knowledge to allow for the inclusion of a single `TextField` within a bottom sheet.
I'd like to see adjustments to bottom sheets that allow them to play nicely with keyboard interactions out of the box so that developers can quickly setup a small user input form in a bottom sheet just like what they might try to do with an alert dialog.
|
framework,f: material design,a: annoyance,team-design,triaged-design
|
low
|
Critical
|
639,922,816 |
next.js
|
ISG with GIP in _app overrides cache-control of ISG page
|
# Bug report
When using the `unstable_revalidate` param with ISG, a header set by _app should never win.
## Additional context
From @lfades:
> Update: this is currently not the case, SSG finishes the request before it gets to _app.
>
> the custom _app in the Next.js site was setting a header, but that causes an error because the request was sent, this happens in production and with next start, but in dev you don't get any error.
|
good first issue,type: next,Pages Router
|
low
|
Critical
|
639,928,027 |
pytorch
|
ppc64le: test cpp_extensions/rng_extension.cpp failure (without altivec override)
|
## 🐛 Bug
When building the cpp_extensions tests from the master branch, on ppc64le platform, the compilation fails on the (somewhat) recent addition of rng_extension.cpp.
Note that this is in the test subdirectory, `test/cpp_extensions/rng_extension.cpp`. The
build of pytorch itself has lately been completing fine.
This file itself seems to have been added in late March under PR #34774.
The error itself is hundreds of lines long so I won't post it here, but an example can be seen at
the end of the output of one of the recent nightly CI runs, such as:
https://powerci.osuosl.org/job/pytorch-master-nightly-py3-linux-ppc64le-gpu/838/console
However, to simplify with what I have found, I have isolated the failing underlying command to this:
`gcc -pthread -B /home/jenkins/miniconda/compiler_compat -Wl,--sysroot=/ -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/home/jenkins/miniconda/lib/python3.7/site-packages/torch/include -I/home/jenkins/miniconda/lib/python3.7/site-packages/torch/include/torch/csrc/api/include -I/home/jenkins/miniconda/lib/python3.7/site-packages/torch/include/TH -I/home/jenkins/miniconda/lib/python3.7/site-packages/torch/include/THC -I/home/jenkins/miniconda/include/python3.7m -c rng_extension.cpp -o rng_extension.o -g -DTORCH_API_INCLUDE_EXTENSION_H -DTORCH_EXTENSION_NAME=rng -D_GLIBCXX_USE_CXX11_ABI=1 -std=c++14`
Now, to see the above compilation succeed, one can just add `-mno-altivec` to the command above. (In my trial, I added it as arg1 immediately after gcc). I believe this tracks to a lack of altivec support within pytorch for ppc64le, related to the Feature Request numbered 27678. So in a way this would be expected to fail -- except that if the support isn't there, this part of the testing shouldn't be run on the platform; since the function isn't universal, the test element should ideally have a guard check such that it be run contingent on whether it is applicable. (e.g. "if platform is not ppc64le, then...").
I admit I don't personally understand the full implication of building this cpp_extension without altivec versus skipping the test altogether (if it is actually not applicable), but I welcome suggestions on what would be appropriate.
## To Reproduce
Described above: attempt compilation on the PPC64LE platform using the command above.
## Expected behavior
In this case, I'd expect the test to be conditionally excluded as inapplicable, where appropriate. (ppc64le at least; I don't know if there are other scenarios).
## Environment
Key element here I think is only that the system be on ppc64le. I'm running in a RHEL container
with cuda 10.2, python 3.7, building in a conda environment. The ENTIRE build output can be seen in the nightly ppc64le CI runs, such as the one in the first link above.
NOTE: I would welcome any suggestions on build script updates to skip over this in the interim, while this issue exists, to allow the nightly pytorch CI to go through the rest of the pytorch tests. ( I can directly access and edit the build parameters for the ppc64le CI runs.)
cc @pbelevich
|
triaged,module: random,module: POWER
|
low
|
Critical
|
639,946,275 |
three.js
|
Add support for compressed versions of DataTexture2DArray and DataTexture3D.
|
Would be nice to have a way for compressed 3D Textures and TextureArray for custom shaders.
Request is done after:
https://discourse.threejs.org/t/is-it-possible-to-have-a-texture-array-of-compressed-textures/16213
##### Browser
- [x] All of them
- [ ] Chrome
- [ ] Firefox
- [ ] Internet Explorer
##### OS
- [x] All of them
- [ ] Windows
- [ ] macOS
- [ ] Linux
- [ ] Android
- [ ] iOS
##### Hardware Requirements (graphics card, VR Device, ...)
|
Enhancement
|
medium
|
Major
|
639,976,282 |
flutter
|
webview_flutter add ability to turn off automatic image download
|
in Android webview you can use the setLoadsImagesAutomatically api (https://developer.android.com/reference/android/webkit/WebSettings#setLoadsImagesAutomatically(boolean)) to turn on/off automatic image download. We have some cases where we wish to turn this off (due to bandwidth constraints) but are not able to do so since only a subset of the webview settings are exposed.
|
c: new feature,p: webview,package,c: proposal,team-ecosystem,P3,triaged-ecosystem
|
low
|
Minor
|
639,983,965 |
three.js
|
displacementMap does not update normals
|
##### Description of the problem
Adding a displacementMap to a MeshPhongMaterial without flatShading will offset the vertices correctly but will not correctly change the normals. The result is an object that has the right shape, but the wrong lighting.
[Fiddle demonstrating the problem](https://jsfiddle.net/mhebes/9soeLcxj/55/) (be sure to minimize that getimage() base64 method, I couldn't get images to work on fiddle).
##### Three.js version
r117
##### Browser
Chrome and Edge at least
##### OS
Windows at least
|
Enhancement
|
low
|
Major
|
639,996,731 |
go
|
misc/wasm: long tasks with Go WebAssembly
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
go v1.14.3
<pre>
$ go version
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
`GOOS=js and GOARCH=wasm`
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
Compiled [0x-mesh](https://github.com/0xProject/0x-mesh) to WebAssembly and ran in the browser. I put a hot function inside of a `goroutine` and used a channel for synchronization to try to get the go runtime to release the main thread enough to prevent the UI from stuttering.
### What did you expect to see?
I expected the go runtime to not block the event loop for long periods of time when a goroutine was invoked.
### What did you see instead?
These are two flame graphs of different functions that block for a long period of time (up to 1 second). As you'll notice, the sub-calls within these graphs run in significantly less time, so I would think that it would be possible to pick execution back up after clearing the event loop.
<img width="785" alt="Screen Shot 2020-06-16 at 4 50 44 PM" src="https://user-images.githubusercontent.com/34827329/84831951-ea3bfb00-aff1-11ea-9256-2c4435d758ad.png">
<img width="385" alt="Screen Shot 2020-06-16 at 4 56 03 PM" src="https://user-images.githubusercontent.com/34827329/84832138-51f24600-aff2-11ea-814a-39433946c6f7.png">
### Notes
If there is an easy way to break these tasks up (like putting something inside of a go-routine), that would fix my problem.
The tasks in the pictures provided correspond to two different scenarios involving the same function, `HandleOrderSyncResponse`. This can be found in our codebase here: https://github.com/0xProject/0x-mesh/blob/master/core/ordersync/ordersync.go#L471.
We do a few things that are somewhat non-standard for optimization purposes within this callstack including calling out to functions registered on the Javascript `window` object. This code can be found here: https://github.com/0xProject/0x-mesh/blob/master/orderfilter/validate_js.go#L36. I recently created a new PR that makes the Javascript function that is being called asynchronous, which significantly reduced the time that the individual calls would hold onto the event loop; however, the underlying task held onto the event loop for a much longer period of time. The second image is the flame graph contains calls to the updated `MatchOrder` function. This PR can be found [here](https://github.com/0xProject/0x-mesh/pull/841).
|
NeedsInvestigation,arch-wasm
|
low
|
Critical
|
640,002,142 |
flutter
|
Improve Images in Flutter to allow for more control over GIFs such as playback status and speed.
|
## Use case
For optimization reasons I need more control over GIF images. I would like to be able to control the speed as well as control the status of the playback. In my case, I am facing performance issues on web and would like to disable the playback of the GIF when a certain number are in view on the user's screen.
## Proposal
Images should have an API that provides a controller when an image contains multiple frames, or other apis to more easily access the status and/or playback speed.
|
c: new feature,framework,a: images,c: proposal,P2,team-framework,triaged-framework
|
low
|
Major
|
640,002,314 |
vscode
|
Implement Google Chrome-like grouped tabs
|
Google Chrome Beta recently announced [grouped tabs](https://blog.google/products/chrome/manage-tabs-with-google-chrome/), which is pretty awesome.
Here's the gist:
Having such a thing within VSCode will be very useful IMO.
Having it integrated with the search, where a group is automatically created once you open more than one search result, should help with the tab clutter it ensues. Same for Peek references, automatic grouping of files within the same folders... I see many possibilities for it.
|
feature-request,workbench-tabs,keep
|
high
|
Critical
|
640,070,555 |
pytorch
|
Why does Libtorch use more memory than Pytorch does in Python？
| ERROR: type should be string, got "\r\nhttps://github.com/pytorch/pytorch/issues/39927#issue-637501953" |
needs reproduction,module: memory usage,triaged
|
low
|
Minor
|
640,084,669 |
pytorch
|
About torch.backends.cudnn.deterministic issue
|
In order to reproduce the training process, I set torch.backends.cudnn.deterministic to FALSE, but this slowed down for almost an hour. Is there any way to reproduce the training process under the condition of torch.backends.cudnn.deterministic for TRUE. Do you have any suggestions？
cc @csarofeen @ptrblck
|
module: cudnn,triaged
|
low
|
Major
|
640,084,896 |
godot
|
Godot Editor Drag and Drop Lag on MacOS
|
**Godot version:**
3.2.1
**OS/device including version:**
macOS Catalina v10.15.5
3GHz 6-Core Intel Core i5
32gb DDR4
Intel UHD Graphics 630 1536 MB
**Issue description:**
Recently converted my work station over to mac from windows. Setup my Godot project and noticed that dragging and dropping assets from the file system to the inspector panel lags.
I've noticed no other performance hits while using the editor, and this was not a problem on my windows machine. Seems to happen specifically with dragging and dropping images into texture slots in the inspector.
**Steps to reproduce:**
Drag and drop an image from the file system panel to an appropriate outlet in the inspector tab.
Not sure if it's visible in this gif -- but you can at least notice the icon alongside the cursor dragging along.
<!-- A small Godot project which reproduces the issue. Drag and drop a zip archive to upload it. -->
|
bug,platform:macos,topic:editor,confirmed,topic:gui,performance
|
medium
|
Major
|
640,089,007 |
go
|
x/pkgsite: support launchpad.net in source.ModuleInfo
|
Add support for getting source from launchpad.net.
https://github.com/golang/pkgsite/blob/4ea5ad9/internal/source/source.go#L273
Related: #39621
|
help wanted,NeedsFix,pkgsite
|
low
|
Minor
|
640,097,981 |
pytorch
|
Improve RPC test debugability
|
## 🚀 Enhancement
Noticed a few issues when debugging flaky RPC tests that make it harder to debug, listed them below with some ideas on how we can address these issues
1) As part of RPC shutdown, we delete all UserRRefs and OwnerRRefs that have never been forked. This method includes a couple of condvar waits to ensure there are no pending users and all delete User RRef messages have been processed. Thus this method has a timeout of 100s, but this is unfortunately equal to our RPC test timeout. Therefore, sometimes we may see a test timed out error, when in reality we were stuck in this function. If the timeout for this method was smaller during tests, it would help surface these RRef related issues
2) ProcessGroupAgent has a sync() method that blocks until all nodes agree on the # of messages sent and processed. This worked well when processing on the server side and sending the result was synchronous, which is no longer the case. Now, we may have work scheduled in callbacks that is never executed in some error cases, and a later callback (which never runs) may call into `ProcessGroupAgent::send()`. The result is that we time out waiting in this function with no debug information. For this, in unittests, we can probably add some logging or throw an exception once we have gone longer than a certain timeout and still don't have message synchronization.
## Motivation
Sometimes RPC tests fail with a timeout error and no useful stacktrace indicating possible errors, the above would be a good start to addressing that issue.
cc @ezyang @gchanan @zou3519 @bdhirsh @jbschlosser @anjali411 @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @jjlilley @osalpekar @jiayisuse @mrzzd @xush6528
|
high priority,triaged,better-engineering,module: rpc
|
low
|
Critical
|
640,106,882 |
rust
|
rustc panicked when link.exe ran out of memory
|
I saw "we would appreciate a bug report" in the trace, so here it is! The full terminal output after I ran `cargo test`: https://gist.github.com/rtfeldman/027a3550c21381bb7d36daa0613a453a
I don't have a small project that reproduces this, and the project where I encountered it is not public, so I can't link to it directly from here. (That said, I can absolutely invite anyone to the project who is interested in reproducing this bug - just let me know!)
## Meta
`rustc --version --verbose`:
```
rustc 1.44.0 (49cae5576 2020-06-01)
binary: rustc
commit-hash: 49cae55760da0a43428eba73abcb659bb70cf2e4
commit-date: 2020-06-01
host: x86_64-pc-windows-msvc
release: 1.44.0
LLVM version: 9.0
```
|
A-linkage,I-ICE,T-compiler,S-needs-repro
|
low
|
Critical
|
640,114,013 |
TypeScript
|
Literal Comparison for Conditional Types
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
`compare type to value literal`, `conditional type literals`, `type is literal`, `complex schemas`
## Suggestion
The ability to compare a type against an example of that type, for use in complex type aliases and interfaces.
<!-- A summary of what you'd like to see added or changed -->
## Use Cases
When designing a complex schema for an object, the actual fields contained by the object can branch in many different ways.
Of course, it's possible to approach the problem by using nullable types for fields that are not present in all cases. This results in a readable type in the error inspection window, but lots of unnecessarily defensive code that would have been solved by a fully typed schema.
It's also possible to create a discriminated union consisting of every branch--but what if you have a lot of branches? It becomes undesirably repetitive and the error inspection window is a wall of text.
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
Take for example, the type of a Pipeline:
```TypeScript
type Action = 'Data Selection' | 'Data Cleanup' | 'Train' | 'Store' | 'Deploy'
type Status = 'running' | 'finished' | 'error'
type PipelineStep = {
name: Action
status: Status
tags: Array<string>
// `never` actually always results in a type check error right now
message: PipelineStep['status'] is 'Error' ? string : never
path: PipelineStep['name'] is 'Data Selection' | 'Store' ? string : never
trainingID: PipelineStep['name'] is 'Train' ? string : never
endpoint: PipelineStep['name'] is 'Deploy' ? string : never
}
```
Contrasted with the current syntax and discriminated unions:
```TypeScript
type PipelineStep = {
name: Action
status: Exclude<Status, 'Error'>
tags: Array<String>
} | {
name: Action
status: 'Error'
tags: Array<string>
message: string
} | // I give up
```
The number of branches is multiplicative in nature. In this case, the most complex schema could have a maximum of 6 (Actions) x 3 (Status) possible branches.
After optimization, it becomes:
```TypeScript
type StepStatus = {
status: Exclude<Status, 'Error'>
} | {
status: 'Error'
message: string
}
type DataSelectionStep = {
name: 'Data Selection'
path: string
}
type TrainingStep = {
name: 'Training'
trainingID: string
}
type StoreStep = {
name: 'Store'
path: string
}
type DeployStep = {
name: 'Deploy'
endpoint: string
}
type PipelineStep = (DataSelectionStep | TrainingStep | StoreStep | DeployStep | {
name: Exclude<Action, 'Training' | 'Data Selection' | 'Store' | 'Deploy'>
}) & StepStatus & {
tags: Array<String>
}
```
which isn't really much better...
<!-- Show how this would be used and what the behavior would be -->
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
640,119,533 |
flutter
|
The Route stack unexpectedly cleared when changing MaterialApp home
|
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
I'm not sure if I don't understand the usage of the Widget correctly but I think the following shouldn't have different behavior.
## Steps to Reproduce
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
A minimum example is https://github.com/CareF/drawer_rebuild
**Expected results:** <!-- what did you want to see? -->
In https://github.com/CareF/drawer_rebuild/blob/master/lib/main.dart#L38
If I use `_foo` and `_bar` function to generate `home` of `MaterialApp` instead of `Foo` and `Bar` class (the commented line), it behaves as expected: the drawer stays where it is, and the app UI behind the drawer changes.
<img src="https://user-images.githubusercontent.com/11715538/84853111-6f440600-b02c-11ea-90c3-9fc6181314fc.gif" width="200">
And if I add `Navigator.pop`, I should see the animation of the drawer going back.
<img src="https://user-images.githubusercontent.com/11715538/84853108-6c491580-b02c-11ea-974c-1e464b320977.gif" width="200">
**Actual results:** <!-- what did you see? -->
When changing the `MyAppState` from the `SettingDrawer`, it looks like the Route is destroyed in that the drawer disappear without animation.
<img src="https://user-images.githubusercontent.com/11715538/84852770-a534ba80-b02b-11ea-884a-cbc752d1a197.gif" width="200">
|
framework,f: material design,f: routes,has reproducible steps,found in release: 3.0,found in release: 3.1,team-design,triaged-design
|
low
|
Critical
|
640,125,598 |
next.js
|
Incremental Static Regeneration replaces `.amp` with `?amp=1`
|
# Bug report
## Describe the bug
- When the page is built with Amp and SSG config, the output url of amp page becomes `/foo.amp` (routing is `pages/[slug]`)
- In the build phase, the non-amp page `/foo` refers to `/foo.amp` in `<link rel="amphtml">` correctly.
- However when Incremental Static Regeneration is turned on, the `/foo.amp` is replaced with `/foo?amp=1`
## To Reproduce
set
- amp: "hybrid"
- add `unstable_revalidate: 30` to getStaticProps return value.
reproduce:
https://github.com/wawoon/next-amp-ssg-reproduce
yarn build
yarn start
go to `http://localhost:3000/foo`
## Expected behavior
The non amp page should always refer to`/foo.amp` in `<link rel="amphtml">` tag even if Incremental Static Regeneration is turned on.
## Screenshots
initial access:
<img width="1042" alt="スクリーンショット 2020-06-17 12 59 06" src="https://user-images.githubusercontent.com/36811303/84853875-27a89300-b09b-11ea-85b7-5b9cba21fab2.png">
after 30sec
<img width="1017" alt="スクリーンショット 2020-06-17 12 59 35" src="https://user-images.githubusercontent.com/36811303/84853964-59b9f500-b09b-11ea-8945-93c680da978a.png">
## System information
- macOS
- Chrome
- Next: 9.4.5-canary.12
- Node: v12.14.1
## Additional context
https://github.com/vercel/next.js/issues/13038
https://github.com/vercel/next.js/pull/13046
|
good first issue,Pages Router
|
low
|
Critical
|
640,128,066 |
storybook
|
Opt-in to *not* re-mount in React on HMR
|
**Is your feature request related to a problem? Please describe.**
Long discussion on this here: https://github.com/storybookjs/storybook/issues/10616
The idea is that if you are willing to forgo React Hooks in your stories + decorators (instead you can just render components that use hooks), you can alter your stories (specifically the *args*) and not have the component remount, just like if you "edit" args via the controls addon.
**Describe the solution you'd like**
1. Add a parameter `parameters.react.remountOnHMR` that changes this line not to use JSX/`React.createElement`:
https://github.com/storybookjs/storybook/blob/a2e2ac8fab073ebf58e92a720400ba5c4b801746/app/react/src/client/preview/render.tsx#L61
2. Pass `implementationChanged` in `RenderContext` so we can not force a remount here: https://github.com/storybookjs/storybook/blob/a2e2ac8fab073ebf58e92a720400ba5c4b801746/app/react/src/client/preview/render.tsx#L70-L72
Note doing 2 alone will have no effect without doing 1 as react will see `<StoryFn>` as a new component and remount it (as `StoryFn` is different). However `StoryFn()` may return something that has not changed in the two implementations.
3. Document the above.
4. Investigate if 2. should/could be applied to other frameworks.
|
feature request,react,core
|
low
|
Minor
|
640,133,815 |
pytorch
|
SyncBatchNorm doesn't work when I set track_running_stats False
|
Hi,
I try to apply a DDP to a model. However, when I set track_running_stats False, it output a error
And when I turn it to True, it works well. Then I read the source
and try to print it, it says
running mean and running var is none. I konw it beacause I set track_running_stas False.
And the actual bug is in here
It seems that the "None" of running mean and the running var caused it. But I did need it set to False. I would be grateful if someone else could tell me how to fix it.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
|
oncall: distributed,triaged
|
low
|
Critical
|
640,157,615 |
go
|
x/crypto/acme/autocert: new certificate rejected by Chrome client for 1h if client's clock is behind.
|
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.4 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="off"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/h8liu/Library/Caches/go-build"
GOENV="/Users/h8liu/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/h8liu/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/4l/dcqzjhqn65gggmw9qrlnksx00000gn/T/go-build462787337=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
1. use autocert to host a new site
2. change client's system clock to 3 second behind UTC. (1 second would also work).
3. visit the site with Google Chrome, the site will be rejected due to SCT timestamp was in the past.
4. in fact, even 5 seconds later, when the certificate is valid again, the site will still get rejected.
Chrome version: 83.0.4103.97
### What did you expect to see?
Certificate won't get rejected, at least not for one hour.
I think the rejection can also happen when the visit is on a new renewal, but renewals often happen in the background, so it is slightly harder to hit the particular time window in a debug session.
### What did you see instead?
Certificate got rejected for 1 hour.
----
to be fair, I think the root cause is on chrome browser side. I also filed the issue to chrome, and chrome marked it as won't fix:
https://bugs.chromium.org/p/chromium/issues/detail?id=1093183
so one mitigation `autocert` can have, is to have an config to optionally insert a sleeping delay after a certificate is issued and before the certificate can be returned to a `GetCertificate()` call.
|
NeedsInvestigation
|
low
|
Critical
|
640,165,482 |
next.js
|
SSG with fallback doesn't generate AMP page dynamically
|
# Bug report
## Describe the bug
- When SSG with `fallback: true` and `amp: "hybrid"` are used together, the paths not specified in `getStaticPaths` have an invalid href in `<link rel="amphtml">` tag.
- For example, when there is a `pages/[slug].jsx` and the user visits `/bar`, the `<link rel="amphtml">` tag will refer to `/[slug].amp`.
## To Reproduce
https://github.com/wawoon/next-amp-ssg-fallback-reproduce
pages/[slug]/index.jsx
```jsx
export default (props) => {
return <div>slug: {props.slug}</div>;
};
export const config = {
amp: "hybrid",
};
export const getStaticProps = async (ctx) => {
return {
props: {
slug: ctx.params.slug,
},
};
};
export const getStaticPaths = async () => {
return { paths: [{ params: { slug: "foo" } }], fallback: true };
};
```
※ caution: When you add `unstable_revalidate` to getStaticProps, the href of `<link rel="amphtml">` is overwritten while regeneration by #14251
When the user visits `http://localhost:3000/bar`, `bar` is not specified in `getStaticPaths`, the href of `<link rel="amphtml">` refers to `/[slug].amp`. And this `/[slug].amp` is invalid url.
<img width="1022" alt="スクリーンショット 2020-06-17 14 21 57" src="https://user-images.githubusercontent.com/36811303/84858863-f2a23d80-b0a6-11ea-9f42-9c66e2ced23a.png">
## Expected behavior
- The `/bar` should have correct amp page path, even when the path is not included in `getStaticPaths`.
- The amp version of `/bar` should be generated using `getStaticProps` dynamically.
## Screenshots
## System information
- macOS
- Chrome
- Next: 9.4.5-canary.12
- Node: v12.14.1
## Additional context
- I have recently created #14251 which is related with amp page with SSG.
|
Pages Router
|
low
|
Critical
|
640,214,285 |
flutter
|
Listener or rule for flutter_driver tests, to make automatically screenshot, if any one test failed
|
**Hello!**
There is huge trouble with taking automatically screenshot, if any test failed in test suite. In general I mean the same solution as it working in JUnit or TestNG.
Also I'm tried to wrap all test cases in try/catch, but it didn't work properly...
Please help if have any idea how to solve it.
Thanks in advance)
**For example**
_In JUnit it's:_
import com.codeborne.selenide.junit.ScreenShooter;
public class MyTest {
@Rule
public ScreenShooter makeScreenshotOnFailure = ScreenShooter.failedTests();
// ...
}
_In TestNG it's:_
import com.codeborne.selenide.testng.ScreenShooter;
@Listeners({ ScreenShooter.class})
public class MyTest {
// ...
}
|
c: new feature,tool,t: flutter driver,a: debugging,c: proposal,P3,team-tool,triaged-tool
|
low
|
Critical
|
640,216,686 |
flutter
|
[flutter driver] Run a single test or group test by command
|
In unit/widget test I can do something like this to run only one test:
```
flutter test --plain-name="simple test name"
```
But "--plain-name" seems do not exist inside dirve, and I do not find any alternative. I try this:
```
flutter drive --target=test_driver/app.dart --release --plain-name="simple test name"
```
but oviously do not work.
How can I run only one test or only a group of test with flutter drive?
|
c: new feature,tool,t: flutter driver,c: proposal,P3,team-tool,triaged-tool
|
low
|
Major
|
640,227,394 |
godot
|
Godot overwrites the Project Manager list on close
|
**Godot version:**
3.2.2.rc.custom_build.2e8480d56
**OS/device including version:**
Debian Buster amd64, Radeon RX550
**Issue description:**
Apparently, closing Godot forces it to overwrite the Project Manager list with whatever it was when the project was opened.
**Steps to reproduce:**
- Open a project in Godot
- Open another Godot window, "star" or "unstar" some project, close it
- Open Godot again - the project list is how you left it
- Close the first window
- Open another Godot window - the list is back to what it was before opening the first project
This happens with "starring", "unstarring", creating or deleting projects - the list will be overwritten with an old list when you close Godot.
I would understand this if it happened when closing the Project Manager, but it does not make sense when closing Godot. I often have multiple projects opened, and to modify the list, I have to close them all first.
|
discussion,topic:editor,usability
|
low
|
Minor
|
640,233,383 |
flutter
|
[animations] Name conflict for DualTransitionBuilder
|
Since DualTransitionBuilder was introduced to `flutter/flutter`: https://github.com/flutter/flutter/pull/58686, this can result in a naming conflict for the `animations` package, since the `animations` package also contains an identical `DualTransitionBuilder`.
We should have the `animations` package use its own copy of the widget until DualTransitionBuilder reaches the `stable` branch. Then, we can safely remove the copy of DualTransitionBuilder in the animations package.
|
package,p: animations,team-ecosystem,P3,triaged-ecosystem
|
low
|
Minor
|
640,258,596 |
flutter
|
How to disable text anti-aliasing
|
Trying to disable text anti-aliasing I've build my own local engine with `font.setEdging(SkFont::Edging::kAlias);` instead of `kAntiAlias` in /engine/src/flutter/third_party/txt/src/txt/paragraph_txt.cc.
Running application with local engine leads to result where text is not rendered at all, although it is seems the layout and decoration (wavy underline) are correctly drawn.
Is there any way to disable text anti-aliasing?
|
framework,engine,dependency: skia,d: api docs,a: typography,c: rendering,P2,team-engine,triaged-engine
|
low
|
Major
|
640,286,430 |
angular
|
strictTemplates and strictNullChecks doesn't work well with optional chaining in templates
|
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🐞 bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- ✍️edit: --> The issue is caused by package @angular/compiler?
### Is this a regression?
?
### Description
* enable Ivy
* enable `strictTemplates`
* enable `strictNullChecks`
* use an expression like `foo?.bar.baz` in a template
* `foo` is nullable, `bar` is not
* template compiler shows error on `baz`: `Object is possibly 'undefined'.`
* note that the whole chain ends if `foo` is nullish (long short circuiting), therefore accessing `baz` is always safe
* disabling `strictNullChecks` makes the compile error go away and everything functions as expected without runtime error (i.e. Angular's optional chaining also does long short circuiting)
## 🔬 Minimal Reproduction
https://stackblitz.com/edit/angular-ivy-pu8dk5
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## 🔥 Exception or Error
<pre><code>
`Object is possibly 'undefined'.`
</code></pre>
## 🌍 Your Environment
**Angular Version:**
<pre><code>
@angular/animations 9.1.11
@angular/common 9.1.11
@angular/compiler 9.1.11
@angular/core 9.1.11
@angular/forms 9.1.11
@angular/platform-browser 9.1.11
@angular/platform-browser-dynamic 9.1.11
@angular/router 9.1.11
</code></pre>
**Anything else relevant?**
<!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->
<!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
|
type: bug/fix,freq1: low,workaround2: non-obvious,area: compiler,state: confirmed,P3,compiler: template type-checking
|
medium
|
Critical
|
640,320,145 |
rust
|
Not desugaring to HRTB for closure argument
|
My understanding was that `FnMut(&T)` desugars to `for<'a> FnMut(&'a T)`. In this instance, it is seemingly not doing so. If you comment out line 44 then this compiles. Why is the `map` function triggering the incorrect (?) desugaring, and how can I fix it?
```rust
trait Pipe<In> {
type Out;
}
struct Identity;
impl<In> Pipe<In> for Identity {
type Out = In;
}
struct Map<P, F> {
p: P,
f: F,
}
impl<P, In, F, R> Pipe<In> for Map<P, F>
where
P: Pipe<In>,
F: FnMut(P::Out) -> R,
{
type Out = R;
}
fn map<P, In, F, R>(p: P, f: F) -> Map<P, F>
where
P: Pipe<In>,
F: FnMut(P::Out) -> R,
{
Map { p, f }
}
fn pipe<T, Sink>(_: Sink)
where
Sink: for<'a> Pipe<&'a T>,
T: 'static,
{
}
fn main() {
fn abc<'a>(_: &'a String) {}
pipe(Map {
p: Identity,
f: |_: &String| {},
});
pipe(map(Identity, abc));
pipe(map(Identity, |_: &String| {}));
}
```
([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=e96ca22d8ef90e5d72062cd4a4f95398))
Errors:
```
Compiling playground v0.0.1 (/playground)
error[E0308]: mismatched types
--> src/main.rs:44:5
|
44 | pipe(map(Identity, |_: &String| {}));
| ^^^^ one type is more general than the other
|
= note: expected type `std::ops::FnOnce<(&'a std::string::String,)>`
found type `std::ops::FnOnce<(&std::string::String,)>`
error: aborting due to previous error
For more information about this error, try `rustc --explain E0308`.
error: could not compile `playground`.
To learn more, run the command again with --verbose.
```
---
Possibly related: https://github.com/rust-lang/rust/issues/70263
|
A-lifetimes,A-closures,T-compiler
|
low
|
Critical
|
640,333,497 |
rust
|
Warn on assert!(always_false)
|
It would be useful if rustc emitted a warning on assertions when the condition can be statically proven to always be false.
Example:
```rust
pub fn meh() {
let always_false = 2 > 3;
assert!(always_false);
println!("foo");
}
```
Currently compiles cleanly without any warnings ([playground](https://play.rust-lang.org/?version=stable&mode=release&edition=2018&gist=74a4e2c9abeda1dd2d52887e8b44f71a)) — neither about the always false assertion, nor about the unreachable statement.
The LLVM IR emitted:
```
; playground::meh
; Function Attrs: noreturn nonlazybind uwtable
define void @_ZN10playground3meh17h3a7dd68d372b246aE() unnamed_addr #3 {
start:
; call std::panicking::begin_panic
tail call fastcc void @_ZN3std9panicking11begin_panic17h982033eda4eb16e4E()
unreachable
}
```
suggests rustc is able to statically prove the assertion to be always false even before LLVM optimization is run.
I would expect to get something similar to this:
```
warning: assertion is always false: `always_false`
--> meh.rs:3:15
|
3 | assert!(always_false);
| ^^^^^^^^^^^^ the assertion is always false
|
= help: to unconditionally panic, use `panic!()` or `unreachable!()`
= note: `#[warn(assert_is_always_false)]` on by default
warning: unreachable statement
--> meh.rs:4:5
|
3 | assert!(always_false);
| ---------------------- any code following this expression is unreachable
4 | println!("foo");
| ^^^^^^^^^^^^^^^^ unreachable statement
|
= note: `#[warn(unreachable_code)]` on by default
```
## Meta
This is not about any particular version or platform, but here it goes anyway:
`rustc --version --verbose`:
```
rustc 1.44.0 (49cae5576 2020-06-01)
binary: rustc
commit-hash: 49cae55760da0a43428eba73abcb659bb70cf2e4
commit-date: 2020-06-01
host: x86_64-unknown-linux-gnu
release: 1.44.0
LLVM version: 9.0
```
|
A-lints,T-compiler,C-feature-request
|
low
|
Minor
|
640,353,069 |
go
|
encoding/xml: Decoder does not decode innerxml when using a TokenReader
|
### What version of Go are you using (`go version`)?
1.14.4
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/hgoes/.cache/go-build"
GOENV="/home/hgoes/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY="git.engelvoelkers.com"
GONOSUMDB="git.engelvoelkers.com"
GOOS="linux"
GOPATH="/home/hgoes/go"
GOPRIVATE="git.engelvoelkers.com"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build309819268=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
When using `encoding/xml.NewTokenDecoder`, the decoder fails to fill fields marked `",innerxml"`.
Here's an example: https://play.golang.org/p/57xVMNiafsB
Removing the second assignment to the decoder gives the desired output.
### What did you expect to see?
The inner XML of the test element
### What did you see instead?
empty string
### Diagnosis
I've debugged this a bit and I'm fairly certain that the problem is that the "innerxml" feature relies on the internal `saved` state of the `Decoder` which is not updated when using a `TokenReader`. The solution would be to serialize the resulting token into the `saved` field in the `Decoder.rawToken` function.
|
NeedsInvestigation
|
low
|
Critical
|
640,377,882 |
angular
|
optional chaining in template uses 'null', but strictTemplates treats it as 'undefined'
|
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🐞 bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- ✍️edit: --> The issue is caused by package @angular/compiler or @angular/language-service?
### Is this a regression?
no
### Description
Using optional chaining (or safe navigation operator) in templates uses `null`, but the language-service and compiler (with strictTemplates) treat it as `undefined`.
This is not a request to change `null` to `undefined` (that's proposed by #34385). Instead I want the static types to be correct so I'm not surprised by the different semantics of Angular's safe navigation operator compared to TypeScript/ECMAScript.
## 🔬 Minimal Reproduction
https://stackblitz.com/edit/angular-ivy-hh5mwz?file=src%2Fapp%2Fapp.component.ts
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## 🔥 Exception or Error
<pre><code>
<!-- If the issue is accompanied by an exception or an error, please share it below: -->
<!-- ✍️-->
</code></pre>
## 🌍 Your Environment
**Angular Version:**
<pre><code>
9.1.11
<!-- ✍️-->
</code></pre>
**Anything else relevant?**
<!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->
<!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
|
type: bug/fix,workaround4: none,freq2: medium,area: compiler,state: confirmed,P3,compiler: template type-checking
|
low
|
Critical
|
640,402,398 |
godot
|
Viewport's Control derived nodes bug when in-editor
|
**Godot version:**
3.2.2 RC1
**OS/device including version:**
Ubuntu 20.04
**Issue description:**
I'm making a plugin using viewports in-editor (tool keyword) and UI doesnt work, I'm using as basis the demo 3d-in-2d.
It works when you press F6 to run game, but in-editor doesnt work.
**Steps to reproduce:**
* Download MRP below
* Install inside addons/ of an existing project
* Open Node.tscn
* Press F6
* See the button working
* Now activate the plugin
* press F8 to open the dialog
* See that button is not working
**Minimal reproduction project:**
[file.zip](https://github.com/godotengine/godot/files/4792441/file.zip)
|
bug,topic:plugin
|
low
|
Critical
|
640,440,528 |
PowerToys
|
HTML <details> tab breaks markdown preview
|
Adding collapsible section in markdown using html details tag is not supported and all of the embedded markdown in the details tag is shows as is:
Use HTML tag details
\<details>
< summary >Click to expand!< /summary >
## Add collapsible section
1. All of this is shown
2. with
* no line breaks
* or rendering
</ details>
|
Product-File Explorer
|
medium
|
Major
|
640,443,826 |
youtube-dl
|
AT&T Tech Channel
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.06.16.1**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://techchannel.att.com/play-video.cfm/2011/3/7/AT&T-Archives-Similarities-of-Wave-Behavior
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
Please consider including support for this AT&T tech video repository.
There was a previous issue on this, issue #3938, closed as "fixed in youtube-dl 2015.01.10.1 and newer".
I note that some of their videos are also on YT itself, including this one, so this may not be necessary; I don't know if all of their videos are mirrored on YT.
thanks very much indeed.
$ youtube-dl --verbose 'https://techchannel.att.com/playvideo/2011/03/07/AT&T-Archives-Similarities-of-Wave-Behavior'
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://techchannel.att.com/playvideo/2011/03/07/AT&T-Archives-Similarities-of-Wave-Behavior']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2020.06.16.1
[debug] Python version 2.7.15+ (CPython) - Linux-4.17.0-1-amd64-x86_64-with-debian-bullseye-sid
[debug] exe versions: avconv 4.2.2-1, avprobe 4.2.2-1, ffmpeg 4.2.2-1, ffprobe 4.2.2-1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] AT&T-Archives-Similarities-of-Wave-Behavior: Requesting header
WARNING: Falling back on generic information extractor.
[generic] AT&T-Archives-Similarities-of-Wave-Behavior: Downloading webpage
[generic] AT&T-Archives-Similarities-of-Wave-Behavior: Extracting information
ERROR: Unsupported URL: https://techchannel.att.com/playvideo/2011/03/07/AT&T-Archives-Similarities-of-Wave-Behavior
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2387, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2562, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/bin/youtube-dl/youtube_dl/compat.py", line 2551, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1659, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1523, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 14, column 11
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 797, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 530, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/generic.py", line 3382, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://techchannel.att.com/playvideo/2011/03/07/AT&T-Archives-Similarities-of-Wave-Behavior
|
site-support-request
|
low
|
Critical
|
640,455,898 |
bitcoin
|
Replace all of the RecursiveMutex instances with the Mutex ones
|
**UPD 2023-04-18**. See a shortlist [here](https://github.com/bitcoin/bitcoin/issues/19303#issuecomment-1513337566).
---
This is a tracking issue for the long-term goal to replace all of the `RecursiveMutex` instances with the `Mutex` ones throughout the code base.
Anthony Williams (_C++ Concurrency in Action_, 2019, 3.3.3 Recursive locking):
> Most of the time, if you think you want a recursive mutex, you probably need to change your design instead.
Anthony Towns, https://github.com/bitcoin/bitcoin/issues/19303#issuecomment-646956780:
> ... the actual goal is "make locking logic easier to follow" rather than "remove RecurviseMutex"
Should be noted, to insure that mutex locking policy has not been changed by accident in non-trivial cases, all of the related code branches must be covered by appropriate lock assertions: `AssertLockHeld()` or `AssertLockNotHeld()`.
Also Clang Thread Safety Analysis annotations with [Negative Capabilities](https://clang.llvm.org/docs/ThreadSafetyAnalysis.html#negative) are very useful (see #19249) but are not a panacea, of course :)
---
- [x] `RecursiveMutex cs_Shutdown` (#19180)
- [x] `RecursiveMutex cs_nTimeOffset` (#19189)
- [x] `RecursiveMutex cs_proxyInfos` (#19190)
- ~`RecursiveMutex csPathCached` (#19213)~
- [x] `RecursiveMutex cs_warnings` (#19220)
- [x] `RecursiveMutex CAddrMan::cs` (#19238)
- [x] `RecursiveMutex BanMan::m_cs_banned` (#24092, #24097)
- [x] `RecursiveMutex cs_mapLocalHost` (#24099)
- [x] `RecursiveMutex CConnman::cs_totalBytesRecv` (#22829)
- [x] `RecursiveMutex CConnman::cs_totalBytesSent` (#24157)
- [x] `RecursiveMutex CConnman::m_addr_fetches_mutex` (#22829)
- [x] `RecursiveMutex CConnman::cs_vAddedNodes` (#22829)
- [ ] `RecursiveMutex CConnman::m_nodes_mutex`
- [x] `RecursiveMutex CNode::cs_vSend` (#19915)
- [x] `RecursiveMutex CNode::cs_hSocket` (#19915)
- [x] `RecursiveMutex CNode::cs_vRecv` (#19915)
- ~`RecursiveMutex CNode::cs_vProcessMsg` (#24122)~
- ~`RecursiveMutex CNode::cs_sendProcessing` (#25597)~
- [x] `RecursiveMutex CNode::cs_SubVer` (#24079)
- [x] `RecursiveMutex CNode::cs_inventory` (#19347)
- [x] `RecursiveMutex CNode::cs_addrName` (removed in #22782)
- [x] `RecursiveMutex CNode::cs_addrLocal` #24108
- [ ] `RecursiveMutex Peer::TxRelay::m_bloom_filter_mutex`
- [ ] `RecursiveMutex Peer::TxRelay::m_tx_inventory_mutex` (#24125)
- [x] `RecursiveMutex CNode::TxRelay::cs_feeFilter` (#18819)
- ~`RecursiveMutex g_cs_orphans`~
- [x] `RecursiveMutex g_cs_recent_confirmed_transactions` (#19378)
- [x] `RecursiveMutex cs_most_recent_block` (#24062)
- [x] `RecursiveMutex CBlockPolicyEstimator::m_cs_fee_estimator` (#22014)
- [x] `RecursiveMutex cs_rpcWarmup` (#19399)
- [x] `RecursiveMutex SingleThreadedSchedulerClient::m_cs_callbacks_pending` (#24069)
- [ ] `RecursiveMutex BlockManager::cs_LastBlockFile`
- [ ] `RecursiveMutex FillableSigningProvider::cs_KeyStore`
- [ ] `RecursiveMutex ArgsManager::cs_args`
- [x] `RecursiveMutex CChainState::cs_nBlockSequenceId` (#22824)
- [x] `RecursiveMutex CChainState::m_cs_chainstate` (#24103)
- [ ] `RecursiveMutex cs_db`
- [ ] `RecursiveMutex DescriptorScriptPubKeyMan::cs_desc_man`
- [x] `RecursiveMutex cs_wallets` (#19101)
- [ ] `RecursiveMutex CWallet::cs_wallet` (#19773, #19833)
and
- `RecursiveMutex CTxMemPool::cs` (#19306, ~#19647~, #19652, #19854, #19872, #19901, #19909, #19917)
- `RecursiveMutex cs_main`
|
Brainstorming,Refactoring
|
medium
|
Major
|
640,497,834 |
create-react-app
|
Failed 'create-react-app .' deletes current directory
|
<!--
Please note that your issue will be fixed much faster if you spend about
half an hour preparing it, including the exact reproduction steps and a demo.
If you're in a hurry or don't feel confident, it's fine to report bugs with
less details, but this makes it less likely they'll get fixed soon.
In either case, please use this template and fill in as many fields below as you can.
Note that we don't provide help for webpack questions after ejecting.
You can find webpack docs at https://webpack.js.org/.
-->
### Describe the bug
When CRA fails, it deletes the created directory. However, when calling `create-react-app .`, that directory is the _current_ directory.
I see this is done intentionally, and CRA purposefully [moves the node process out of the directory](https://github.com/facebook/create-react-app/blob/master/packages/create-react-app/createReactApp.js#L514-L520) in order to delete it, but the shell process is still left in that directory.
#### Why is this a problem?
My user base works on a custom `npm` registry - which can cause failures with module/template/etc resolution when misconfigured - and `npm` chokes when run from a directory which does not exist. **While `npm`'s failure is not an issue in CRA,** `npm` is just an example in this case. _Many_ tools break when trying to run from a directory which does not exist, and users may attempt to use those tools to troubleshoot why CRA failed.
#### Duplicating
```bash
# create a temp space for easy cleanup
mkdir tmp-cra
cd tmp-cra
# make an incomplete template that will fail
mkdir cra-template-broken
cd cra-template-broken
echo '{"name": "cra-template-broken"}' > package.json
cd ..
# run CRA against that template
mkdir cra-working-directory
cd cra-working-directory
npx create-react-app@latest . --template file:../cra-template-broken
# assert on the current directory existing
pwd
ls $PWD
# npm will break when running inside of a directory which does not exist.
# When CRA fails due to registry or other npm configuration issues,
# you may not realize you're in a non-existent directory before attempting to troubleshoot the registry issue.
npm config get registry
# clean up
cd ../..
rm -r tmp-cra
```
<details>
<summary>Sample Output (click to expand)</summary>
</details>
Going back to that [defensive code](https://github.com/facebook/create-react-app/blob/master/packages/create-react-app/createReactApp.js#L514-L520) I mentioned earlier, it seems that `process.chdir(...)` is designed to [change the working directory of the current process, but does not change the directory of the overarching shell process](https://stackoverflow.com/a/32871358), meaning that CRA is successfully navigating up and out of this directory, but the shell is left behind. Apparently that's tough to do (I have no evidence to back that up), so my suggestion is to dodge it entirely by only removing the directory when the process is not in that directory.
My suggestion is to [detect if `root === process.cwd()` and avoid `fs.removeSync`ing the directory](https://github.com/facebook/create-react-app/blob/master/packages/create-react-app/createReactApp.js#L512) (see below), however I also see that this code is in `createReactApp.js`, and as such is the [untouchable stuff of legends](https://github.com/facebook/create-react-app/blob/master/packages/create-react-app/createReactApp.js#L9).
```diff
- if (!remainingFiles.length) {
+ if (!remainingFiles.length && root !== process.cwd()) {
```
> ⬆️ May require additional `path.resolve(root)`?
The node interaction can be further validated with this script:
```bash
echo "shell pwd before: $PWD"
node -e "
const path = require('path')
console.log('script cwd before', process.cwd())
process.chdir(path.resolve(process.cwd(), '..'))
console.log('script cwd after', process.cwd())
"
echo "shell pwd after: $PWD"
```
<details>
<summary>Sample Output (click to expand)</summary>
</details>
### Did you try recovering your dependencies?
N/A
### Which terms did you search for in User Guide?
```
dir(ectory)
remove
clean
fail
error
```
### Environment
```
Environment Info:
current version of create-react-app: 3.4.1
running from /Users/z001gk0/.nvm/versions/node/v12.14.1/lib/node_modules/create-react-app
System:
OS: macOS Mojave 10.14.6
CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
Binaries:
Node: 12.14.1 - ~/.nvm/versions/node/v12.14.1/bin/node
Yarn: 1.22.4 - ~/.nvm/versions/node/v12.14.1/bin/yarn
npm: 6.13.7 - ~/.nvm/versions/node/v12.14.1/bin/npm
Browsers:
Chrome: 83.0.4103.106
Firefox: Not Found
Safari: 13.1.1
npmPackages:
react: Not Found
react-dom: Not Found
react-scripts: Not Found
npmGlobalPackages:
create-react-app: 3.4.1
```
### Steps to reproduce
```bash
# create a temp space for easy cleanup
mkdir tmp-cra
cd tmp-cra
# make an incomplete template that will fail
mkdir cra-template-broken
cd cra-template-broken
echo '{"name": "cra-template-broken"}' > package.json
cd ..
# run CRA against that template
mkdir cra-working-directory
cd cra-working-directory
npx create-react-app@latest . --template file:../cra-template-broken
# assert on the current directory existing
pwd
ls $PWD
# npm will break when running inside of a directory which does not exist.
# When CRA fails due to registry or other npm configuration issues,
# you may not realize you're in a non-existent directory before attempting to troubleshoot the registry issue.
npm config get registry
# clean up
cd ../..
rm -r tmp-cra
```
To re-iterate, the `npm` issue is beside the point and is only placed there as an example of one of many tools which will break when the current directory does not exist.
### Expected behavior
Either:
* CRA should move the shell process out of the working directory when deleting it
* CRA should not delete the working directory when it is the same as the current directory
### Actual behavior
CRA deletes the working directory (when it is the same as the current directory).
### Reproducible demo
It's not really a runtime issue as much as an issue on generation, so `Steps to reproduce` may have to suffice.
|
tag: enhancement
|
low
|
Critical
|
640,542,261 |
flutter
|
datetime keyboard input type for Samsung keyboards doesn't allow for separators
|
With the new date picker, the manual input entry requires a / separator which is not present in the Samsung keyboard that is invoked with the TextInputType.datetime for the InputDatePickerFormField widget.
Flutter version: 1.17.0
Device: Samsung Galaxy S6 - Android 7.0
|
platform-android,framework,f: material design,f: date/time picker,a: fidelity,e: OS-version specific,has reproducible steps,P2,e: samsung,found in release: 3.3,found in release: 3.7,team-android,triaged-android
|
low
|
Major
|
640,544,233 |
rust
|
intra-rustdoc-link: Cannot use core in core crate
|
I tried to document this code in libcore (`./x.py doc src/libcore`):
```rust
impl<T: Deref, E> Result<T, E> {
/// Converts from `Result<T, E>` (or `&Result<T, E>`) to `Result<&<T as Deref>::Target, &E>`.
///
/// [`core::ops::Deref`]
pub fn as_deref(&self) -> Result<&T::Target, &E>;
}
```
I expected to see the above code build pass.
Instead, this happened: Build failed the following errors:
```rust
Documenting core v0.0.0 (/home/lzutao/fork/rust/compiler/src/libcore)
error: `[core::ops::Deref]` cannot be resolved, ignoring it.
--> src/libcore/result.rs:1151:68
|
1151 | /// Coerces the [`Ok`] variant of the original [`Result`] via [`core::ops::Deref`]
| ^^^^^^^^^^^^^^^^^^ cannot be resolved, ignoring
|
note: the lint level is defined here
--> src/libcore/lib.rs:64:9
|
64 | #![deny(intra_doc_link_resolution_failure)] // rustdoc is run without -D warnings
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
error: Could not document `core`.
```
cc #43466
cc @Manishearth @GuillaumeGomez @jyn514
|
T-rustdoc,S-blocked,A-intra-doc-links,D-confusing
|
medium
|
Critical
|
640,561,949 |
react-native
|
Redesign Native RedBox
|
## Overview
LogBox handles most errors users see but we still display native RedBoxes in cases where:
- JavaScript has not loaded (e.g. Metro is unavailable)
- JavaScript is unavailable (e.g. a syntax error in the bundle)
- LogBox fails to render (e.g. an error in LogBox JavaScript)
- Native log errors (e.g. RCTLogFatal)
This issue is to improve the fallback RedBox in these cases for a better experience.
## Tasks
- Update design to be in line with LogBox (see below)
- Cleanup code by removing the symbolication logic (as this is handled by LogBox)
- Remove stack trace since for all errors that this can occur the stack trace is not relevant
## Designs
### JavaScript has not loaded (Metro is unavailable)
### JavaScript is not available (syntax error)
### LogBox fails to render
### Native log errors
|
Type: Discussion,Type: Enhancement,Never gets stale
|
medium
|
Critical
|
640,608,667 |
flutter
|
Refresh indicator and VoiceOver
|
There does not appear to be a way to trigger a `RefreshIndicator` on iOS when using VoiceOver.
|
platform-ios,framework,f: material design,a: accessibility,f: cupertino,d: examples,team-design,triaged-design
|
low
|
Minor
|
640,620,845 |
TypeScript
|
improper declared type cause narrow type not work when its computed type is not union.
|
<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 4.0
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts repro
interface A {
type:'A'
}
interface B {
type:'B'
}
function assert(x:any) :asserts x is A|B{
}
function foo(x: any): any {
x; // any
assert(x);
x; // A | B
if (x.type === 'A') {
return x;
}
x; // B
if (x.type === 'B') {
return x;
}
x; // B, but should be never.
// ^?
}
```
**Expected behavior:**
the last x should be never.
**Actual behavior:**
still B.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/play/index.html?ts=4.0.0-dev.20200615&ssl=1&ssc=1&pln=25&pc=2#code/JYOwLgpgTgZghgYwgAgIIG8BQyfLATwAcIAuAclTMwF9NNRJZEUAhLXPI0slq2zGAFcQCMMAD2IZHADOM6GAAUADxJwQ+AJTI1chTOTLkwA6gA+bOvyEixk5DHHiVJaRs2v1+ZO1zKA3DgA9EFu+Ni4svJQSsqa-hE4AcGhqMhmyCyJxjDIKgB0BMTIALxlyBRk2r4cOFAQYIJQUgHZtBzJyCGZ2cC5BUUoZSUVvNXZHPWNzYYJHO1+gV2hWdRAA
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
|
Bug,Has Repro
|
low
|
Critical
|
640,622,910 |
flutter
|
Make a logging macro for Window embedding
|
Currently we're just using `stderr`; it would be good to have a logging macro that lets us adjust how we do logging over time, have debug-only vs debug-or-release logging, etc.
|
engine,platform-windows,a: desktop,P3,c: tech-debt,team-windows,triaged-windows
|
low
|
Critical
|
640,691,235 |
flutter
|
Document how AA works in Flutter API docs and what "conflation" artifacts are expected
|
As Flutter uses Skia, it's limited by Skia's AA algorithm. We have to clearly document such limitations.
See https://groups.google.com/g/skia-discuss/c/2ULlxsL8Aek/m/phyycURxAAAJ and https://github.com/flutter/flutter/issues/58547#issuecomment-639917241 for some more details.
|
engine,dependency: skia,d: api docs,c: rendering,P3,team-engine,triaged-engine
|
low
|
Minor
|
640,694,988 |
terminal
|
Prompt before closing pane with multiple client apps
|
<!--
🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
Some console apps, like vim, neovim, far, etc, are ignored when you accidentally hit Ctrl+W and your unsaved work is gone forever.
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
# Proposed technical implementation details (optional)
I'm not sure how to do that, but it would be nice to offer an API or something to block closing if some return code is not met.
<!--
A clear and concise description of what you want to happen.
-->
|
Issue-Feature,Area-Settings,Product-Terminal
|
medium
|
Critical
|
640,719,145 |
flutter
|
[SelectableText] Edit menu position is incorrect when Selected text exceeds the Screen size
|
## Steps to Reproduce
1. Use `SelectableText(LONG_TEXT, showCursor: true)` **Edit:** Text needs to be longer than fits on screen
2. Highlight text -> Select All
3. Text is selected but `Copy` is not an option. Tap/LongTap will remove the selection.
<details>
<summary>flutter doctor -v</summary>
[✓] Flutter (Channel stable, v1.17.3, on Linux, locale en_US.UTF-8)
• Flutter version 1.17.3 at /home/jacob/tools/flutter
• Framework revision b041144f83 (13 days ago), 2020-06-04 09:26:11 -0700
• Engine revision ee76268252
• Dart version 2.8.4
[✓] Android toolchain - develop for Android devices (Android SDK version 30.0.0)
• Android SDK at /home/jacob/Android/Sdk
• Platform android-30, build-tools 30.0.0
• Java binary at: /snap/android-studio/90/android-studio/jre/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
• All Android licenses accepted.
[✓] Android Studio (version 4.0)
• Android Studio at /snap/android-studio/90/android-studio
• Flutter plugin version 46.0.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[✓] Connected device (1 available)
• sdk gphone x86 • emulator-5554 • android-x86 • Android 11 (API 30) (emulator)
• No issues found!
</details>
|
platform-android,platform-ios,framework,f: material design,a: typography,has reproducible steps,found in release: 3.3,found in release: 3.6,team-design,triaged-design
|
low
|
Major
|
640,738,843 |
go
|
cmd/compile: inaccurate DWARF location information -> misleading profile
|
During a recent profiling session, I noticed spurious non-zero samples against lines I knew to be unreachable in the test scenario. It appears that the compiler's DWARF information is incorrect. I don't know to what extent the rest of the profiler's information is reliable.
I'm using today's tip:
```
$ go version
go version devel +8b98498a58 Wed Jun 17 19:48:45 2020 +0000 linux/amd64
```
It's easy to reproduce deterministically, though the test case is far from minimal. The profiled application is go.starlark.net/cmd/starlark. The executable file is here called 'x'.
```
$ cd $GOROOT/src/go.starlark.net
$ git log | head -n 1
commit c6daab680f283fdf16a79c99d8e86a1562400761
$ go build -o x ./cmd/starlark
```
There are 49 program counter locations that purport to belong to interp.go:333. One of them is address 0x593311.
```
$ objdump --dwarf=decodedline x | grep 'starlark/interp.go .* 333 ' | wc -l
49
adonovan2:go.starlark.net% objdump --dwarf=decodedline x | grep 'starlark/interp.go .* 333 ' | grep 0x593311
/go.starlark.net/starlark/interp.go 333 0x593311
```
The actual code at interp.go:333 (https://github.com/google/starlark-go/blob/c6daab680f283fdf16a79c99d8e86a1562400761/starlark/interp.go#L333) is a case in a byte code interpreter that handles the ITERPUSH bytecode, which is not reached in the profiled scenario. (I confirmed this by replacing it with a panic statement; it did not panic.)
```
$ nl -ba starlark/interp.go | grep -A1 -B8 333
325 case compile.ITERPUSH:
326 x := stack[sp-1]
327 sp--
328 iter := Iterate(x)
329 if iter == nil {
330 err = fmt.Errorf("%s value is not iterable", x.Type())
331 break loop
332 }
333 iterstack = append(iterstack, iter) # <-- spuriously associated with 0x593311
334
```
But disassembling the program shows that address 0x593311 is in fact in code for the body of the loop at lines 96-104 (https://github.com/google/starlark-go/blob/c6daab680f283fdf16a79c99d8e86a1562400761/starlark/interp.go#L96). (The add 7 instruction is the giveaway.) I've shown the whole basic block.
```
$ objdump -S x
...
593305: 48 83 c1 07 add $0x7,%rcx # <-- a clue
593309: 4c 8b 84 24 d0 02 00 mov 0x2d0(%rsp),%r8
593310: 00
593311: 4c 8b bc 24 30 01 00 mov 0x130(%rsp),%r15 # <-- our instruction
593318: 00
593319: 48 89 8c 24 d0 00 00 mov %rcx,0xd0(%rsp)
593320: 00
593321: 89 74 24 70 mov %esi,0x70(%rsp)
593325: 48 8b 8c 24 78 03 00 mov 0x378(%rsp),%rcx
59332c: 00
59332d: 48 8b b4 24 a0 01 00 mov 0x1a0(%rsp),%rsi
593334: 00
593335: 4d 39 cb cmp %r9,%r11
593338: 0f 86 1d 4b 00 00 jbe 597e5b <go.starlark.net/starlark.(*Function).CallInternal+0x4fdb>
```
Here's the corresponding source:
```
$ nl -ba starlark/interp.go | grep -A7 ' 96'
96 for s := uint(0); ; s += 7 {
97 b := code[pc]
98 pc++
99 arg |= uint32(b&0x7f) << s
100 if b < 0x80 {
101 break
102 }
103 }
```
Running the program in gdb and breakpointing that instruction appears to confirm this inference. Picking some of the other instructions associated with interp.go:333, several appear to be logic for the binary tree in the control flow graph for 'switch op'.
All the affected PC addresses appear to be loads of 0x130(SP). Perhaps the liveness analysis is using that stack slot as a temporary as well as for 'iterstack', and somehow location information is leaking between the two variables assigned to the same slot?
I realize a perfect debug view is basically impossible to achieve, but I wonder if there is an easy fix in this case.
|
NeedsInvestigation,compiler/runtime
|
low
|
Critical
|
640,753,178 |
PowerToys
|
[FancyZones Options] Add a button to exclude a window name with a drag and drop widget
|
# Summary of the new feature/enhancement
I would find it faster to drag and drop a targeting crosshair over a window to add it to the list of excluded window names in the FancyZones options.
I imagine a button that looks like a crosshair that you can click to pickup, drag over a window, and drop-- then the window's name will be added to the list of excluded items.
# Proposed technical implementation details (optional)
This could probably be done by creating a drag-and-droppable widget that is not bounded by the options window, and capture the window handle upon `DragEnter()`, and add the window's name to the list upon `DragDrop()`.
> You can enable user drag-and-drop operations within a Windows-based application by handling a series of events, most notably the DragEnter, DragLeave, and DragDrop events.
from https://docs.microsoft.com/en-us/dotnet/framework/winforms/advanced/drag-and-drop-operations-and-clipboard-support
|
Idea-Enhancement,Help Wanted,FancyZones-Settings,Product-FancyZones,Needs-Spec
|
low
|
Minor
|
640,771,496 |
flutter
|
[video_player] StreamBuilder A VideoPlayerController was used after being disposed
|
When using multiple VideoPlayerControllers (with StreamBuilders) disposing the controller throws an error when the widget is built despite being disposed correctly and only once.
I have linked a demo with an complete example.
## Steps to Reproduce
1. Clone demo repo: [crtl/flutter-bugs](https://github.com/crtl/flutter-bugs/)
2. Checkout branch `video_player/usedAfterDisposed`
3. Run app
4. Press the button
5. Despite calling dispose before initializing next controller an error is thrown.
**Expected results:**
Should work.
**Actual results:**
```
══╡ EXCEPTION CAUGHT BY WIDGETS LIBRARY ╞═══════════════════════════════════════════════════════════
The following assertion was thrown building StreamBuilder<VideoPlayerController>(state:
_StreamBuilderBaseState<VideoPlayerController, AsyncSnapshot<VideoPlayerController>>#f93e0):
A VideoPlayerController was used after being disposed.
Once you have called dispose() on a VideoPlayerController, it can no longer be used.
The relevant error-causing widget was:
StreamBuilder<VideoPlayerController>
file:///D:/dev/projects/flutter/flutter-bugs/lib/main.dart:105:16
When the exception was thrown, this was the stack:
#0 ChangeNotifier._debugAssertNotDisposed.<anonymous closure> (package:flutter/src/foundation/change_notifier.dart:108:9)
#1 ChangeNotifier._debugAssertNotDisposed (package:flutter/src/foundation/change_notifier.dart:114:6)
#2 ChangeNotifier.removeListener (package:flutter/src/foundation/change_notifier.dart:169:12)
#3 _VideoPlayerState.didUpdateWidget (package:video_player/video_player.dart:537:26)
#4 StatefulElement.update (package:flutter/src/widgets/framework.dart:4734:58)
#5 Element.updateChild (package:flutter/src/widgets/framework.dart:3245:15)
#6 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:5881:14)
#7 Element.updateChild (package:flutter/src/widgets/framework.dart:3245:15)
#8 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:4571:16)
#9 StatefulElement.performRebuild (package:flutter/src/widgets/framework.dart:4719:11)
#10 Element.rebuild (package:flutter/src/widgets/framework.dart:4262:5)
#11 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2667:33)
#12 WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:866:20)
#13 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:286:5)
#14 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1115:15)
#15 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1054:9)
#16 SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:970:5)
#20 _invoke (dart:ui/hooks.dart:267:10)
#21 _drawFrame (dart:ui/hooks.dart:225:3)
(elided 3 frames from dart:async)
```
<details>
<summary>Logs</summary>
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
```
[√] Flutter (Channel master, 1.20.0-1.0.pre.30, on Microsoft Windows [Version 10.0.18362.900], locale de-DE)
• Flutter version 1.20.0-1.0.pre.30 at D:\dev\flutter
• Framework revision e96b13c72f (5 days ago), 2020-06-12 09:02:19 -0700
• Engine revision 965fbbed17
• Dart version 2.9.0 (build 2.9.0-14.0.dev 2b917f5b6a)
[√] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at D:\dev\android\sdk
• Platform android-29, build-tools 29.0.2
• ANDROID_HOME = D:\dev\android\sdk
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
• All Android licenses accepted.
[√] Android Studio (version 4.0)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 46.0.2
• Dart plugin version 193.7361
• Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b01)
```
</details>
|
p: video_player,package,team-ecosystem,has reproducible steps,P3,found in release: 2.2,found in release: 2.3,triaged-ecosystem
|
low
|
Critical
|
640,774,349 |
go
|
runtime: unnecessary heap allocations when `range`ing over an empty array
|
<!--
Please answer these questions before submitting your issue. Thanks!
For questions please use one of our forums: https://github.com/golang/go/wiki/Questions
-->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.14.2 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes (1.15beta1)
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/nickgregory/.cache/go-build"
GOENV="/home/nickgregory/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/nickgregory/dev/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go-1.14"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go-1.14/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build389543628=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
In an example like the following, `thing` is created on the heap even if the passed `arr` has length 0 and the loop body is never run:
```go
package main
type foo struct {
a uint64
b uint64
}
var glob *foo
//go:noinline
func f(arr []foo) {
for _, thing := range arr {
glob = &thing
}
}
func main() {
f([]foo{})
}
```
This is contrived/minimalistic example (inlining is just to make the asm easier to read), but shows the point. This originally came up in a case where `arr` was generated in an event processing critical path, and this iteration over a (usually empty array) was creating millions of objects that escaped to heap (due to storage in another object, not assignment to a global), eating ~10% of run time.
### What did you expect to see?
I would expect that the `runtime.newobject` call would only happen after the array is checked for length > 0.
### What did you see instead?
```
...
45d528: e8 d3 e1 fa ff call 40b700 <runtime.newobject>
45d52d: 48 8b 44 24 08 mov rax,QWORD PTR [rsp+0x8]
45d532: 48 8b 4c 24 28 mov rcx,QWORD PTR [rsp+0x28]
45d537: 48 85 c9 test rcx,rcx
45d53a: 7e 35 jle 45d571 <main.f+0x71>
45d53c: 48 8b 54 24 20 mov rdx,QWORD PTR [rsp+0x20]
45d541: 31 db xor ebx,ebx
45d543: eb 04 jmp 45d549 <main.f+0x49>
45d545: 48 83 c2 10 add rdx,0x10
...
{loop body}
...
45d569: 48 ff c3 inc rbx
45d56c: 48 39 d9 cmp rcx,rbx
45d56f: 7f d4 jg 45d545 <main.f+0x45>
45d571: 48 8b 6c 24 10 mov rbp,QWORD PTR [rsp+0x10]
45d576: 48 83 c4 18 add rsp,0x18
45d57a: c3 ret
...
```
|
Performance,NeedsInvestigation,compiler/runtime
|
low
|
Critical
|
640,788,593 |
rust
|
Confusing 'type mismatch' error when using function pointer as fn trait
|
The following code:
```rust
struct MyType;
fn parse_header<T, F: FnOnce(&MyType) -> T>(parse: F) -> T {
panic!()
}
fn make_it(val: &MyType) -> &MyType { panic!() }
pub fn from_url<'a>() -> &'a MyType {
parse_header(make_it)
}
fn main() {}
```
gives this error:
```
error[E0271]: type mismatch resolving `for<'r> <for<'s> fn(&'s MyType) -> &'s MyType {make_it} as std::ops::FnOnce<(&'r MyType,)>>::Output == _`
--> src/main.rs:10:5
|
3 | fn parse_header<T, F: FnOnce(&MyType) -> T>(parse: F) -> T {
| - required by this bound in `parse_header`
...
10 | parse_header(make_it)
| ^^^^^^^^^^^^ expected bound lifetime parameter, found concrete lifetime
```
There are several issues with this error:
* The 'type mismatch' message contains several pieces of 'internal' rust syntax (multiple consecutive `for<>` binders, the weird `{make_it}` syntax for function pointers, and an inference variable).
* We call the return type `T` a 'bound', even though it's clearly not a bound.
* We give an confusing 'expected bound lifetime parameter, found concrete lifetime' message, which doesn't really explain what's going on
* We don't point at `make_it`, even though it's part of the issue.
This was minimized from code posted by @rvolosatovs.
|
A-diagnostics,A-lifetimes,T-compiler,D-confusing
|
low
|
Critical
|
640,819,641 |
TypeScript
|
Incorrectly inferred object property as string literal value
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
**TypeScript Version:** 3.9.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
incorrectly inferred string index type
inferred object property in function return type
**Expected behavior:**
The key values in each `Variation` should be inferred as string not the literal string value
**Actual behavior:**
The key values in each `Variation` are inferred as the literal string value of the first object
<!-- Did you find other bugs that looked similar? -->
**Related Issues:**
Possibly related: https://github.com/microsoft/TypeScript/issues/38759,
**Code**
```ts
type Variation = {
[testDescription: string]: () => void;
}
export type VariationProvider = {
variations: Variation[];
};
export type VariationProviderFactory = (extras: object) => VariationProvider;
export function createVariationProvider(factory: VariationProviderFactory) {
return factory;
}
createVariationProvider(() => {
return {
variations: [
{
foo: () => {}
},
{
broken: () => {}
},
]
}
})
```
<details><summary><b>Output</b></summary>
```ts
export function createVariationProvider(factory) {
return factory;
}
createVariationProvider(() => {
return {
variations: [
{
foo: () => { }
},
{
broken: () => { }
},
]
};
});
```
</details>
<details><summary><b>Compiler Options</b></summary>
```json
{
"compilerOptions": {
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"strictBindCallApply": true,
"noImplicitThis": true,
"noImplicitReturns": true,
"useDefineForClassFields": false,
"alwaysStrict": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"downlevelIteration": false,
"noEmitHelpers": false,
"noLib": false,
"noStrictGenericChecks": false,
"noUnusedLocals": false,
"noUnusedParameters": false,
"esModuleInterop": true,
"preserveConstEnums": false,
"removeComments": false,
"skipLibCheck": false,
"checkJs": false,
"allowJs": false,
"declaration": true,
"experimentalDecorators": false,
"emitDecoratorMetadata": false,
"target": "ES2017",
"module": "ESNext"
}
}
```
</details>
**Playground Link:** [Provided](https://www.typescriptlang.org/play/?ssl=14&ssc=1&pln=15&pc=1#code/C4TwDgpgBAaghgJwJZ2Eg9gOygXigbwCgoSoBtYCAZ2ABFqBjZMNLALihuUwHMBdDgAoAlLgB8UAG7okAEwDchAL6EIADzDoEwKKEixEKVpgAKCdJLkQEuAsSmHUGTFQ7xkTrGT6Kli1RpaOnrQ7kbOZhZWCABicAzAWiC2gurACHCuUOgARgBWEAmiOBJhnqbmlrLW-uqa2lAAZgCumAnOUEwQqBBlxpFV1oKN8YkIIG6O-ZXRcQlJokQkCBDAzQjYI-PjvoR7XT19ETPVCIIi4nbLq+vYS6SSU85ZZPakV++kjejoQsUS+BUnygSgANG9SPdgTlzABrCCYP6XQEQkhgiF8ewqJTCQhAA)
|
Needs Investigation
|
low
|
Critical
|
640,824,436 |
TypeScript
|
Check JS doesn't narrow types properly
|
<!-- 🚨 STOP 🚨 STOP 🚨 STOP 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.x-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
import { useReducer } from 'react';
/**
* @template {{ type: string; payload?: any; }} Action
* @template {object} State
* @template {{ past: State[]; present: State; future: State[]; }} UndoState
* @template {{ type: 'UNDO'; } | { type: 'REDO'; }} UndoAction
* @param {{ (state: State, action: Action): State; }} reducer
* @param {State} initialState
*/
export function useUndoReducer(reducer, initialState) {
/**
* @param {UndoState} state
* @param {UndoAction | Action} action
*/
const undoReducer = (state, action) => {
switch (action.type) {
case 'UNDO': {
const [newPresent, ...newPast] = state.past;
return {
past: newPast,
present: newPresent,
future: [state.present, ...state.future],
};
}
case 'REDO': {
const [newPresent, ...newFuture] = state.future;
return {
past: [state.present, ...state.past],
present: newPresent,
future: newFuture,
};
}
default:
return {
past: [state.present, ...state.past],
// @ts-ignore
present: reducer(state.present, action),
future: [],
};
}
};
return useReducer(undoReducer, {
past: [],
present: initialState,
future: [],
});
}
```
**Expected behavior:**
not having to use a `@ts-ignore`
**Actual behavior:**
had to use `@ts-ignore`
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=51&pc=1&useJavaScript=true#code/JYWwDg9gTgLgBAbzgVwM4FMBK6AmyDG6UcAvnAGZQQhwDkU6AhvjLQNwBQHA9AFS8c4vOAAEY6cABtG4xEhgBPMOgBccVDCjAAdgHM2cMIwWSIjHAH41jbQoMkyAQRbAI2wcLESw02QggARgBW6CxkAMowMugeouJS0XKGjBpqkdEA2gC6BmAMGNowaVHiBuTIMMgMxZk5pGQAqto4EOnisV4JfvJKqnQNAHIAIgDy7KRwAD6IcIrKarSYAKKj4w5wTS3OMK7uQqJGUIw0CEgAFBrRNeIANHDMO25q27sAlNfo9mQMeIRQHYdjog2ugyDpgDtGJIQR5uBx0AAPSCwCjIbQuNwoDCbCDYX5EM4-AhEO7gyHQkroV6IQRwPgCOCMzyAk44kFkS7tRn7EQsxA4l6Y6aC7RkB67WlCOGM-BuDQoZq43DE4gAXjgF0pd3FbmpqoAfDTueoAO4Q-AACw1Ou0ADo5lSjca4PgUuh+sMxmoEJLnbLtPKMtp0CaAAr5dCFO62mPBsMpGBZODqznoW1GDScX3GhiVKDaJ3O7kZopwOOhhM3bPOvLoAql8sRqPV43lPN9DKp9NNmDRmNdttVdBZKtFxkkThFkjV10YOjLVbelsuuXwIMh8N1yO9uAx21xgBiFSHSZTlNtg4YWbHcFzVQLPpvjJLak759r9b7tq7JZHy+fPZqI2W7Nk+qLtkBIZHu2o5jhO1bTkWODoOQjDIJIRTLne+aFmOL5wG+0TdiBO57j+CZ-mBH7bmoRJ-JqRHUVG9wYtorywTel4dpRcGTtyiGkNet7oHmBZoFgyr0WiLR4iqdyPsWCavjxAEkWoZLAFCIIceBQ7KbBJCvJw05AA
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
|
Needs Investigation
|
low
|
Critical
|
640,831,820 |
TypeScript
|
Fails type check for type unions as keys to the Map constructor
|
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
**TypeScript Version:** 3.9.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Expected behavior:**
The example code should not fail type checking.
In general a map with a type union as keys `Map<A | B, V>` should accept either type (`A` or `B`) as keys in the `Map()` constructor.
**Actual behavior:**
In general the map will fail type checking if both subtypes `A` *and* `B` appear as keys in the `Map()` constructor.
```ts
let a: A;
let b: B;
// ...
const map: Map<A | B, V> = new Map([
[a, aValue],
[b, bValue],
]);
```
The example code fails type checking with the error message:
```
const ANSWER: typeof ANSWER
No overload matches this call.
Overload 1 of 4, '(iterable: Iterable<readonly [string, number]>): Map<string, number>', gave the following error.
Argument of type '([string, number] | [symbol, number])[]' is not assignable to parameter of type 'Iterable<readonly [string, number]>'.
The types returned by '[Symbol.iterator]().next(...)' are incompatible between these types.
Type 'IteratorResult<[string, number] | [symbol, number], any>' is not assignable to type 'IteratorResult<readonly [string, number], any>'.
Type 'IteratorYieldResult<[string, number] | [symbol, number]>' is not assignable to type 'IteratorResult<readonly [string, number], any>'.
Type 'IteratorYieldResult<[string, number] | [symbol, number]>' is not assignable to type 'IteratorYieldResult<readonly [string, number]>'.
Type '[string, number] | [symbol, number]' is not assignable to type 'readonly [string, number]'.
Type '[symbol, number]' is not assignable to type 'readonly [string, number]'.
Types of property '0' are incompatible.
Type 'symbol' is not assignable to type 'string'.
Overload 2 of 4, '(iterable: Iterable<readonly [string, number]>): Map<string, number>', gave the following error.
Argument of type '([string, number] | [symbol, number])[]' is not assignable to parameter of type 'Iterable<readonly [string, number]>'.
Overload 3 of 4, '(entries?: readonly (readonly [string, number])[] | null | undefined): Map<string, number>', gave the following error.
Type 'symbol' is not assignable to type 'string'.
```
<!-- Did you find other bugs that looked similar? -->
**Related Issues:**
**Code**
```ts
const ANSWER = Symbol("The ultimate question");
const map: Map<string | symbol, number> = new Map([
["foo", 1],
["bar", 2],
[ANSWER, 42],
]);
// This is OK
map.set(ANSWER, 4_000_000_000);
```
<details><summary><b>Output</b></summary>
```ts
"use strict";
const ANSWER = Symbol("The ultimate question");
const map = new Map([
["foo", 1],
["bar", 2],
[ANSWER, 42],
]);
// This is OK
map.set(ANSWER, 4000000000);
```
</details>
<details><summary><b>Compiler Options</b></summary>
```json
{
"compilerOptions": {
"noImplicitAny": true,
"strictNullChecks": true,
"strictFunctionTypes": true,
"strictPropertyInitialization": true,
"strictBindCallApply": true,
"noImplicitThis": true,
"noImplicitReturns": true,
"useDefineForClassFields": false,
"alwaysStrict": true,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"downlevelIteration": false,
"noEmitHelpers": false,
"noLib": false,
"noStrictGenericChecks": false,
"noUnusedLocals": false,
"noUnusedParameters": false,
"esModuleInterop": true,
"preserveConstEnums": false,
"removeComments": false,
"skipLibCheck": false,
"checkJs": false,
"allowJs": false,
"declaration": true,
"experimentalDecorators": false,
"emitDecoratorMetadata": false,
"target": "ES2017",
"module": "ESNext"
}
}
```
</details>
**Playground Link:** [Provided](https://www.typescriptlang.org/play/index.html#code/MYewdgzgLgBAggOQMoHUCiAlGBeGSCeAtgEYgA2AFAEQAqAFgKYwCuZUAloQIZRMCOzBtHbgqASgDcAKFCRY3AA4AuGAFkuCgDzQATuzABzGAB8YEIqTIAaGGGYkGOgHw5bDAO5qNFANpSYATA+VABmICBUNgCMALpW-oHBxFw6kTAATHEJAT6IqJg2ACyZ8TGSUlIA9JUw9OwQMPUwAPIA0lKKAHQQDFAUeegYRQD6AAzjYxPjo5JAA)
|
Bug
|
low
|
Critical
|
640,832,844 |
PowerToys
|
[Shortcut Guide] Improve Desktop Preview when using multiple displays
|
When using the Shortcut-Guide only the active window will be shown in preview. But all displays will be available in the preview area.
# Environment
```
Windows build number: Microsoft Windows [Version 10.0.18363.900]
PowerToys version: Release v0.18.2
PowerToy module for which you are reporting the bug (if applicable): Shortcut Guide
```
# Steps to reproduce
Open the Shortcut Guide
# Expected behavior
Not sure. There are 2 possible behaviors in my opinion.
a) Show the desktop in the preview area just like it is
b) Only show the active window but hide the display previews
The current behavior
c) Display all available displays as black squares in the preview area but only show the active window
# Actual behavior
When bringing up the Shortcut Guide it displays all avilable displays as "black boxes" but only shows the active window - if one is selected.
# Screenshots
|
Idea-Enhancement,Product-Shortcut Guide
|
low
|
Critical
|
640,849,334 |
pytorch
|
C++ API for torch.autograd.functional.jacobian
|
## 🚀 Feature
<!-- A clear and concise description of the feature proposal -->
Add C++ API for [`torch.autograd.functional.jacobian`](https://pytorch.org/docs/stable/_modules/torch/autograd/functional.html#jacobian)
## Motivation
<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
I would like to calculate the jacobian of my model output wrt to the input and the feature is available in the python api but was dismayed to find out that it was not in the C++ API.
## Pitch
<!-- A clear and concise description of what you want to happen. -->
Include `torch::autograd::functional::jacobian` functionality in C++ API
## Alternatives
<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->
N/A
## Additional context
<!-- Add any other context or screenshots about the feature request here. -->
Just some links for easy browsing:
https://github.com/pytorch/pytorch/tree/master/torch/csrc/autograd
https://pytorch.org/cppdocs/api/namespace_torch__autograd.html
https://pytorch.org/docs/stable/_modules/torch/autograd/functional.html#jacobian
cc @ezyang @SsnL @albanD @zou3519 @gqchen @yf225 @glaringlee
|
module: cpp,module: autograd,triaged
|
medium
|
Major
|
640,849,446 |
flutter
|
TabBar shadows are clipped and indicator height cannot be reduced
|
Hello!
To understand what am I trying to achieve, have a look at the attached image.
<img width="426" alt="Screenshot 2020-06-18 at 3 36 51" src="https://user-images.githubusercontent.com/29690177/84968863-b955e600-b117-11ea-9f6c-37d9bb3c2fb7.png">
But as you can see, the tab's shadow can not fit inside the Tab. So how do I make space for the shadow?
Also, how do I change the indicators size? For example, I want to make my tabs indicator height smaller.
I can't find any way to configure that.
Here is how I build a Tab:
```
Tab buildTab(CategoryModel category) {
return Tab(child: ConstrainedBox(
constraints: BoxConstraints(
minWidth: 48,
),
child: Text(category.name, textAlign: TextAlign.center,),
),);
}
```
And this is how I builde the TabBar:
```
return TabBar(
indicator: BoxDecoration(
color: Colors.blue,
borderRadius: const BorderRadius.all(
const Radius.circular(999.0),
),
boxShadow: const [BoxShadow(color: Colors.blueAccent, blurRadius: 6.0)]
),
unselectedLabelColor: Colors.blue,
labelColor: Colors.white,
isScrollable: true,
tabs: tabs,
);
```
|
framework,f: material design,has reproducible steps,found in release: 3.3,found in release: 3.7,team-design,triaged-design
|
low
|
Major
|
640,878,448 |
flutter
|
Support building Windows applications from macOS
|
|
c: new feature,platform-mac,platform-windows,a: desktop,a: build,P3,team-windows,triaged-windows
|
low
|
Major
|
640,886,511 |
godot
|
Abnormal Android audio recording
|
Gdodt Editor Version : 3.2.1 Stable
Windows Version : Win10
Android Version : 10
Phone Model : Huawei ELE-AL00
Project settings--Audio--Mix Rate : (8000、16000、or other)
default_bus_layout--Record--Format : 8-Bit
Recording parameters are normal in Windows
But the parameters are abnormal after recording on Android
Mix_Rate : always 44100
**When using Android recording！
Project settings--Audio--Mix Rate : (8000、16000、or other)
This parameter does not take effect on Android when setting！
It is recommended to add "Mix Rate" property setting in "Audioeffectrecord"**
|
bug,platform:android,topic:porting,topic:audio
|
low
|
Minor
|
640,887,947 |
rust
|
Duplicating mut Copy variables doesn't warn or error
|
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6dee1348129e0c1938c67eb66a8f62b0
```rust
fn main() {
let mut x = 0;
let closure = move || {
let mut closure2 = move || {
x += 1;
};
closure2();
println!("{}", x);
};
closure();
}
```
The inner closure essentially forks the mutable variable `x` into *two* variables. I would expect rustc to give a warning or error, but there is no warning or error. I understand the logic behind allowing this but I think it can lead to surprising results. rust-analyzer warns that assignment to `x` in `closure2` is never read. This led me to a real bug in our code.
Seems to me that duplicating a `mut` `Copy` variable like this deserves some kind of warning at least.
|
A-lints,A-closures,T-compiler,C-bug
|
low
|
Critical
|
640,894,697 |
react
|
Proposition about onInput/onChange
|
Hi :)
In ReactDom we can find:
``` javascript
function getTargetInstForInputOrChangeEvent(topLevelType, targetInst) {
if (topLevelType === TOP_INPUT || topLevelType === TOP_CHANGE) {
return getInstIfValueChanged(targetInst);
}
}
```
Why not adding an extra condition here like:
``` javascript
function getTargetInstForInputOrChangeEvent(topLevelType, targetInst) {
if ((!React.$$useRealOnChange && topLevelType === TOP_INPUT) || topLevelType === TOP_CHANGE) {
return getInstIfValueChanged(targetInst);
}
}
```
By checking `React.$$useRealOnChange` in this function, a user could add this line:
``` javascript
React.$$useRealOnChange = true;
```
anywhere in their code (before or after including ReactDom) to find back the more native behavior.
I'm sorry in advance if this proposition has already been proposed
|
Status: Unconfirmed
|
medium
|
Critical
|
640,904,622 |
flutter
|
[Linux][GTK] Flutter apps will not display properly (Release mode)
|
Sometimes, Flutter app is not displayed properly. In debug mode, It seems no problem.
## Steps to Reproduce
1. $ mkdir flutter_sample
2. $ cd flutter_sample
3. $ flutter create .
4. $ flutter build linux
5. $ ./build/linux/release/bundle/flutter_sample
6. Exit the app
7. go to No. 5 step. (Repeat several times)
```
[ERROR:flutter/shell/platform/embedder/embedder_surface_gl.cc(108)] Could not create a resource context for async texture uploads. Expect degraded performance. Set a valid make_resource_current callback on FlutterOpenGLRendererConfig.
[ERROR:flutter/shell/platform/embedder/embedder_surface_gl.cc(108)] Could not create a resource context for async texture uploads. Expect degraded performance. Set a valid make_resource_current callback on FlutterOpenGLRendererConfig.
```
<details>
<summary>flutter doctor -v</summary>
```
$ flutter doctor -v
[✓] Flutter (Channel master, 1.20.0-1.0.pre.91, on Linux, locale ja_JP.UTF-8)
• Flutter version 1.20.0-1.0.pre.91 at /opt/flutter
• Framework revision 9c3f0faa6d (6 hours ago), 2020-06-17 18:47:54 -0400
• Engine revision 965fbbed17
• Dart version 2.9.0 (build 2.9.0-14.0.dev 2b917f5b6a)
[!] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /home/matsu/Android/Sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: /usr/local/android-studio/jre/bin/java
• Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
✗ Android licenses not accepted. To resolve this, run: flutter doctor
--android-licenses
[✓] Chrome - develop for the web
• Chrome at google-chrome
[✓] Linux toolchain - develop for Linux desktop
• clang version 6.0.0-1ubuntu2 (tags/RELEASE_600/final)
• cmake version 3.10.2
• ninja version 1.8.2
• pkg-config version 0.29.1
[!] Android Studio (version 3.5)
• Android Studio at /usr/local/android-studio
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
• Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
[✓] VS Code (version 1.46.0)
• VS Code at /usr/share/code
• Flutter extension version 3.11.0
[✓] Connected device (3 available)
• Linux • Linux • linux-x64 • Linux
• Web Server • web-server • web-javascript • Flutter Tools
• Chrome • chrome • web-javascript • Google Chrome 83.0.4103.106
! Doctor found issues in 2 categories.
```
</details>
Thank you.
|
engine,platform-linux,c: rendering,a: desktop,a: build,a: release,P2,team-linux,triaged-linux
|
low
|
Critical
|
640,905,824 |
godot
|
Script editor loses focus (the cursor) when running the project
|
**Godot version:**
3.2.2.rc
**OS/device including version:**
Debian Buster amd64, Radeon RX550
**Steps to reproduce:**
- Open any script in a script editor
- Launch a project and close it
- Your blinking cursor disappeared from the script editor - I don't even know where is it. (Not only do you have to reach for your mouse, but you don't even remember where you left your cursor.)
- (Workaround found) Press F2, then F3 - now your cursor is back.
- (More info found) Instead of pressing F2 then F3, just press F3 two or more times to get an error message in the console.
|
bug,topic:editor,confirmed,usability
|
low
|
Critical
|
640,948,462 |
go
|
sync: clarify WaitGroup.Done() behaviour when the counter is zero
|
I think it's worth noting that `WaitGroup.Done()` panics if the counter is already zero. It's currently inferrable from the docs, but not super obvious.
|
Documentation,NeedsInvestigation,compiler/runtime
|
low
|
Major
|
640,952,413 |
rust
|
Doctest panic line numbers are incorrect
|
<!--
Thank you for filing a bug report! 🐛 Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
I tried this code:
```rust
/// ```
/// panic!()
/// ```
fn f() {}
```
I expected to see this happen: either
- `thread 'main' panicked at 'explicit panic', src/lib.rs:2:1`, the actual line of the panic
- `thread 'main' panicked at 'explicit panic', src/lib.rs:1:1`, the line of the panic inside the doctest
Instead, this happened: `thread 'main' panicked at 'explicit panic', src/lib.rs:3:1`. Why line 3? (I suspect it's the implicit code insertion, but it would sure be nice if the line numbers were corrected.)
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.44.0 (49cae5576 2020-06-01)
binary: rustc
commit-hash: 49cae55760da0a43428eba73abcb659bb70cf2e4
commit-date: 2020-06-01
host: x86_64-unknown-linux-gnu
release: 1.44.0
LLVM version: 9.0
```
<!--
Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your
environment. E.g. `RUST_BACKTRACE=1 cargo build`.
-->
<details><summary>Backtrace</summary>
<p>
```
thread 'main' panicked at 'explicit panic', src/lib.rs:3:1
stack backtrace:
0: backtrace::backtrace::libunwind::trace
at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/libunwind.rs:86
1: backtrace::backtrace::trace_unsynchronized
at /cargo/registry/src/github.com-1ecc6299db9ec823/backtrace-0.3.46/src/backtrace/mod.rs:66
2: std::sys_common::backtrace::_print_fmt
at src/libstd/sys_common/backtrace.rs:78
3: <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt
at src/libstd/sys_common/backtrace.rs:59
4: core::fmt::write
at src/libcore/fmt/mod.rs:1069
5: std::io::Write::write_fmt
at src/libstd/io/mod.rs:1504
6: std::sys_common::backtrace::_print
at src/libstd/sys_common/backtrace.rs:62
7: std::sys_common::backtrace::print
at src/libstd/sys_common/backtrace.rs:49
8: std::panicking::default_hook::{{closure}}
at src/libstd/panicking.rs:198
9: std::panicking::default_hook
at src/libstd/panicking.rs:218
10: std::panicking::rust_panic_with_hook
at src/libstd/panicking.rs:511
11: std::panicking::begin_panic
12: rust_out::main
13: std::rt::lang_start::{{closure}}
14: std::rt::lang_start_internal::{{closure}}
at src/libstd/rt.rs:52
15: std::panicking::try::do_call
at src/libstd/panicking.rs:331
16: std::panicking::try
at src/libstd/panicking.rs:274
17: std::panic::catch_unwind
at src/libstd/panic.rs:394
18: std::rt::lang_start_internal
at src/libstd/rt.rs:51
19: std::rt::lang_start
20: main
21: __libc_start_main
22: _start
```
</p>
</details>
|
T-rustdoc,C-bug,A-doctests
|
low
|
Critical
|
640,953,774 |
flutter
|
UI bug: Pointer hover events pass through DraggableScrollableSheet
|
DraggableScrollableSheet does not prevent pointer hover events from passing through.
## Steps to Reproduce
**main.dart**
A UI that stacks a DraggableScrollableSheet on top of the page content.
*also includes an example of a workaround*
```dart
import 'package:flutter/material.dart';
void main() {
runApp(MyApp());
}
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(title: 'Flutter dss-hover-pass-through bug', home: MyHomePage());
}
}
class MyHomePage extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Stack(
children: <Widget>[
Scaffold(
appBar: AppBar(
title: Text('DraggableScrollableSheet hover-pass-through bug'),
actions: <Widget>[
IconButton(
icon: Icon(Icons.info), tooltip: "Action tooltip", onPressed: () {}),
],
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Padding(
padding: const EdgeInsets.all(16.0),
child: Text(
'The button below and the appbar action above should not receive hover events when covered by the DraggableScrollableSheet.'
' To demonstrate, drag the red sheet over the buttons and mouse over them. The tooltips will display when they should not.'
' The blue sheet implements a workaround by wrapping its content with a MouseRegion widget.',
),
),
Tooltip(
message: 'Button tooltip',
child: RaisedButton(child: Text('Button'), onPressed: () {}),
),
],
),
),
),
// A sheet through which the hover events will pass-through.
DraggableScrollableSheet(
initialChildSize: .2,
maxChildSize: 1,
minChildSize: .2,
builder: (BuildContext _, ScrollController sc) {
return Card(
color: Colors.red[100],
child: SingleChildScrollView(
controller: sc,
child: Center(child: Text("DraggableScrollableSheet")),
),
);
},
),
// A sheet with a workaround for the bug.
DraggableScrollableSheet(
initialChildSize: .1,
maxChildSize: 1,
minChildSize: .1,
builder: (BuildContext _, ScrollController sc) {
return MouseRegion(
child: Card(
color: Colors.lightBlue[100],
child: SingleChildScrollView(
controller: sc,
child: Center(child: Text("DraggableScrollableSheet with workaround")),
),
),
);
},
),
],
);
}
}
```
**Expected results:** <!-- what did you want to see? -->
The content hidden by the DraggableScrollableSheet to not react to mouse hover events.
**Actual results:** <!-- what did you see? -->
Tooltips triggered by mouse hover events are shown for content hidden by the DraggableScrollableSheet.
|
framework,f: scrolling,a: desktop,a: mouse,has reproducible steps,P2,found in release: 3.7,found in release: 3.11,team-framework,triaged-framework
|
low
|
Critical
|
640,955,964 |
flutter
|
Hardware Acceleration status on flutter_wayland
|
I was trying to run a flutter application using https://github.com/chinmaygarde/flutter_wayland on ARM platform with the engine buit using the configuration given below
```
--clang \
--target-triple arm-linux-gnueabihf \
--linux-cpu arm \
--runtime-mode debug \
--embedder-for-target \
--no-lto \
--target-os linux \
--arm-float-abi hard
```
Would this support hardware acceleration by default? I tried loading the Flutter Gallery application from the flutter team and the app seemed to have a delay in loading the icons and pages. Could this be related to hardware acceleration? If yes, do I need to make any changes in any part of the code of flutter_wayland or the engine conf to enable the same?
|
c: new feature,engine,P3,team-engine,triaged-engine
|
low
|
Critical
|
641,035,101 |
angular
|
Whitespaces are not trimmed in Text Node with `preserveWhitespaces: false`
|
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🐞 bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- ✍️edit: -->
The issue is caused by package `@angular/compiler`
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
<!-- ✍️--> Yes, the previous version in which this bug was not present was: ....
No idea
### Description
<!-- ✍️--> A clear and concise description of the problem...
https://github.com/angular/angular/blob/d1ea1f4c7f3358b730b0d94e65b00bc28cae279c/packages/compiler/src/ml_parser/html_whitespaces.ts#L78
```html
<!-- input -->
<span>
{{ 'text' }}
</span>
<!-- output -->
<span> {{ 'text' }} </span>
<!-- expected -->
<span>{{ 'text' }}</span>
```
There is no way to `trim` the text.
## 🔬 Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-ivy
-->
<!-- ✍️--> https://stackblitz.com/edit/angular-ivy-pkkssb
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## 🌍 Your Environment
**Angular Version:**
<pre><code>
<!-- run `ng version` and paste output below -->
<!-- ✍️-->
Angular CLI: 9.1.1
Node: 12.18.0
OS: darwin x64
Angular: 9.1.2
... animations, common, compiler, compiler-cli, core, forms
... platform-browser, platform-browser-dynamic, router
Ivy Workspace: Yes
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.901.1
@angular-devkit/build-angular 0.901.1
@angular-devkit/build-optimizer 0.901.1
@angular-devkit/build-webpack 0.901.1
@angular-devkit/core 9.1.1
@angular-devkit/schematics 9.1.1
@angular/cdk 9.2.1
@angular/cli 9.1.1
@angular/flex-layout 9.0.0-beta.29
@ngtools/webpack 9.1.1
@schematics/angular 9.1.1
@schematics/update 0.901.1
rxjs 6.5.5
typescript 3.8.3
webpack 4.42.0
</code></pre>
**Anything else relevant?**
<!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->
<!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
|
area: core,area: compiler,core: basic template syntax,type: use-case,P3
|
low
|
Critical
|
641,049,422 |
pytorch
|
Move all torch.Tensor methods to codegen
|
## 🚀 Feature
The proposal is to move all (or as many as possible) of `torch.Tensor` methods as possible into codegen.
cc: @ezyang who proposed this and @kurtamohler and @Baranowski who expressed interest.
Checklist:
### `torch/tensor.py`
#### Normal methods/properties
- [ ] `register_hook`
- [ ] `retain_grad`
- [ ] `is_shared`
- [ ] `share_memory_`
- [ ] `norm`
- [ ] `lu`
- [ ] `istft`
- [ ] `resize`
- [ ] `resize_as`
- [ ] `split`
- [ ] `unique`
- [ ] `unique_consecutive`
- [ ] `refine_names`
- [ ] `align_to`
- [ ] `unflatten`
- [ ] `rename_`
- [ ] `rename`
- [ ] `_update_names`
- [ ] `grad`
#### Dunder methods
(Determine if possible/feasible)
- [ ] `__deepcopy__`
- [ ] `__reduce_ex__`
- [ ] `__setstate__`
- [ ] `__repr__`
- [ ] `__repr__`
- [ ] `__format__`
- [ ] `__len__`
- [ ] `__hash__`
- [ ] `__dir__`
- [ ] `__array_wrap__`
- [ ] `__cuda_array_interface__`
- [ ] Operators, e.g. `__add__`.
### `tools/autograd/templates/python_variable_methods.cpp`
(In my call with @ezyang it was mentioned that C++ methods were probably hard to port, I found this to be not necessarily true. See the section "Pitch" below.)
- [ ] `THPVariable__is_view`
- [ ] `THPVariable_apply_`
- [ ] `THPVariable_stride`
- [ ] `THPVariable_get_device`
- [ ] `THPVariable_has_names`
- [ ] `THPVariable_data_ptr`
- [ ] `THPVariable_storage_offset`
- [ ] `THPVariable_dim`
- [ ] `THPVariable_numel`
- [ ] `THPVariable_contiguous`
- [ ] `THPVariable_copy_`
- [ ] `THPVariable_*_scalar`
- [ ] `THPVariable_invert`
- [ ] `THPVariable_cpu`
- [ ] `THPVariable_nonzero`
- [ ] `THPVariable_cuda`
- [ ] `THPVariable_{datatype}`
- [ ] `THPVariable_element_size`
- [ ] `THPVariable_numpy`
- [ ] `THPVariable_requires_grad_`
- [ ] `THPVariable_is_contiguous`
- [ ] `THPVariable_map_`
- [ ] `THPVariable_map2_`
- [ ] `THPVariable_new_*`
- [ ] `THPVariable_storage`
- [ ] `THPVariable_storage_type`
- [ ] `THPVariable_to`
- [ ] `THPVariable_type`
## Motivation
Resulting from a verbal discussion with @ezyang regarding #37091, it was proposed that we move all `torch.Tensor` methods and, if possible, properties to codegen. This was motivated by the large diffs in the files `torch/tensor.py` and `tools/autograd/templates/python_variable_methods.cpp` in that same PR. If all of these methods are moved to codegen, future changes could be more easily handled, as well as reducing the diff in that PR.
## Pitch
In my mind, all of these methods can be divided into (broadly) three categories:
1. Those that can be moved.
2. Those that require changes to codegen to move a large amount (e.g. if properties are added to codegen, it'll move a large amount of properties already)
3. Those that cannot be moved without significant effort, e.g. each requiring their own changes to codegen.
My proposal is we determine which methods/properties fall under which category, and then tackle moving things in categories 1 and 2.
cc @ezyang @bhosmer @smessmer @ljk53
|
module: internals,triaged,module: pybind
|
low
|
Major
|
641,137,132 |
flutter
|
[tool_crash] StateError: Bad state: Cannot add event after closing
|
## Command
```
flutter run -d chrome
```
## Steps to Reproduce
1. ... flutter clean
2. ... flutter run -d chrome
3. ...
## Logs
StateError: Bad state: Cannot add event after closing
```
#0 _StreamController.add (dart:async/stream_controller.dart:596:24)
#1 _StreamSinkWrapper.add (dart:async/stream_controller.dart:876:13)
#2 AppConnection.runMain (package:dwds/src/connections/app_connection.dart:32:22)
#3 _ResidentWebRunner.attach (package:flutter_tools/src/build_runner/resident_web_runner.dart:707:41)
<asynchronous suspension>
#4 _ResidentWebRunner.run.<anonymous closure> (package:flutter_tools/src/build_runner/resident_web_runner.dart:455:16)
<asynchronous suspension>
#5 _ResidentWebRunner.run.<anonymous closure> (package:flutter_tools/src/build_runner/resident_web_runner.dart)
#6 asyncGuard.<anonymous closure> (package:flutter_tools/src/base/async_guard.dart:111:32)
#7 _rootRun (dart:async/zone.dart:1190:13)
#8 _CustomZone.run (dart:async/zone.dart:1093:19)
#9 _runZoned (dart:async/zone.dart:1630:10)
#10 runZonedGuarded (dart:async/zone.dart:1618:12)
#11 runZoned (dart:async/zone.dart:1547:12)
#12 asyncGuard (package:flutter_tools/src/base/async_guard.dart:109:3)
#13 _ResidentWebRunner.run (package:flutter_tools/src/build_runner/resident_web_runner.dart:403:20)
<asynchronous suspension>
#14 RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:564:37)
<asynchronous suspension>
#15 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:797:18)
#16 _rootRunUnary (dart:async/zone.dart:1198:47)
#17 _CustomZone.runUnary (dart:async/zone.dart:1100:19)
#18 _FutureListener.handleValue (dart:async/future_impl.dart:143:18)
#19 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:696:45)
#20 Future._propagateToListeners (dart:async/future_impl.dart:725:32)
```
```
[✓] Flutter (Channel beta, 1.19.0-4.1.pre, on Linux, locale en_GB.UTF-8)
• Flutter version 1.19.0-4.1.pre at /home/azzam/Desktop/flutter
• Framework revision f994b76974 (9 days ago), 2020-06-09 15:53:13 -0700
• Engine revision 9a28c3bcf4
• Dart version 2.9.0 (build 2.9.0-14.1.beta)
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /home/azzam/Android/Sdk
• Platform android-29, build-tools 29.0.2
• Java binary at: /usr/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_242-8u242-b08-0ubuntu3~18.04-b08)
• All Android licenses accepted.
[✓] Chrome - develop for the web
• Chrome at google-chrome
[!] Android Studio
• Android Studio at /home/azzam/Downloads/android-studio/bin/studio.sh
✗ Flutter plugin not installed; this adds Flutter specific functionality.
✗ Dart plugin not installed; this adds Dart specific functionality.
✗ android-studio-dir = /home/azzam/Downloads/android-studio/bin/studio.sh
✗ Android Studio not found at /home/azzam/Downloads/android-studio/bin/studio.sh
• Try updating or re-installing Android Studio.
• Consider removing your android-studio-dir setting by running:
flutter config --android-studio-dir=
[✓] VS Code (version 1.45.1)
• VS Code at /usr/share/code
• Flutter extension version 3.11.0
[✓] Connected device (2 available)
• Web Server • web-server • web-javascript • Flutter Tools
• Chrome • chrome • web-javascript • Google Chrome 83.0.4103.106
! Doctor found issues in 1 category.
```
## Flutter Application Metadata
**Type**: app
**Version**: 1.0.0+1
**Material**: true
**Android X**: false
**Module**: false
**Plugin**: false
**Android package**: null
**iOS bundle identifier**: null
**Creation channel**: beta
**Creation framework version**: f994b769743368b36b9c03fb359f62230b60ab92
### Plugins
cloud_firestore-0.13.6
cloud_firestore_web-0.1.1+2
file_picker-1.12.0
firebase_core-0.4.5
firebase_core_web-0.1.1+2
firebase_storage-3.1.6
flutter_plugin_android_lifecycle-1.0.8
|
c: crash,tool,platform-web,P2,team-web,triaged-web
|
low
|
Critical
|
641,177,228 |
PowerToys
|
FancyZones: Alow editing of Zone Numbers
|
Zone numbers should be editable.
FancyZones allows automatically moving of windows to the new position when changing the zone layout. For movement, the zone numbers are used. If I want to keep my layouts, but want to change the zone a window would move too, when changing the layout, changing the layout number is required (at least that is why I understood). So it would be great if the user can change the zone numbers in the layout editor. Otherwise you have to recreate (maybe complex) layout just to change the zone number for moving the windows to the desired zone
.
Further it could be helpful to allow non-continuous numbering.
For example you have stack layout of two windows and a grid layout with 4 zones:
```
--------------- --------------------------
| 1 | | 1 | 2 |
--------------- --------------------------
| 2 | | 3 | 4 |
--------------- --------------------------
```
Today, you could only move windows to and from zones with zone number 1 or 2. So automatic window movement between the layout only work for zone numbers 1 and 2. For comfort it would be great to allow non-continuous numbering like:
```
--------------- --------------------------
| 1 | | 1 | 2 |
--------------- --------------------------
| 4 | | 3 | 4 |
--------------- --------------------------
```
So by changing the zone number in the stack layout, I can allow automatic window movements to any zone of a 2x2 grid layout. Today way of handling this situation is, to create a new 2x2 grid layout.
Allowing non-continuous zone numbering offers lot of possibilities when you frequently use multiple layouts during your daily work. Example:
```
--------------- --------------- --------------------------
| 1 | | | | | 1 | 2 |
--------------- | 2 | 3 | --------------------------
| 4 | | | | | 3 | 4 |
--------------- --------------- --------------------------
--------------------------
| 4 |
--------------------------
| 2 | 1 |
--------------------------
```
|
Idea-Enhancement,Product-FancyZones
|
low
|
Major
|
641,195,363 |
flutter
|
Support for downloading videos and offline playback
|
## Use case
This would be useful for video streaming applications to allow users to be able to download and play videos offline. Downloading them externally would not provide as smooth experience as downloading directly with, for example, ExoPlayer.
## Proposal
I propose that `video_player` should have an API for managing downloads and the ability to play downloaded videos.
|
c: new feature,p: video_player,package,c: proposal,team-ecosystem,P3,triaged-ecosystem
|
low
|
Major
|
641,211,078 |
flutter
|
flutter web: too many copies of dart_sdk.js
|
It appears that we have 3 identical copies of each version of `dart_sdk.js`:
```
> find . -name dart_sdk.js | xargs ls -ltu
-rw-r--r-- 1 vsm staff 9257504 Jun 13 12:30 ./bin/cache/kernel/amd-canvaskit/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257534 Jun 13 12:30 ./bin/cache/kernel/amd/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257842 Jun 13 12:30 ./bin/cache/kernel/legacy/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257812 Jun 13 12:30 ./bin/cache/kernel/legacy-canvaskit/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257504 Jun 13 12:30 ./bin/cache/flutter_web_sdk/kernel/amd-canvaskit/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257534 Jun 13 12:30 ./bin/cache/flutter_web_sdk/kernel/amd/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257842 Jun 13 12:30 ./bin/cache/flutter_web_sdk/kernel/legacy/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257812 Jun 13 12:30 ./bin/cache/flutter_web_sdk/kernel/legacy-canvaskit/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257504 Jun 13 12:30 ./bin/cache/flutter_web_sdk/flutter_web_sdk/kernel/amd-canvaskit/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257534 Jun 13 12:30 ./bin/cache/flutter_web_sdk/flutter_web_sdk/kernel/amd/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257842 Jun 13 12:30 ./bin/cache/flutter_web_sdk/flutter_web_sdk/kernel/legacy/dart_sdk.js
-rw-r--r-- 1 vsm staff 9257812 Jun 13 12:30 ./bin/cache/flutter_web_sdk/flutter_web_sdk/kernel/legacy-canvaskit/dart_sdk.js
-rw-r--r-- 1 vsm staff 5362616 Jun 13 12:26 ./bin/cache/dart-sdk/lib/dev_compiler/kernel/es6/dart_sdk.js
-rw-r--r-- 1 vsm staff 5363178 Jun 13 12:26 ./bin/cache/dart-sdk/lib/dev_compiler/kernel/common/dart_sdk.js
-rw-r--r-- 1 vsm staff 5634476 Jun 13 12:26 ./bin/cache/dart-sdk/lib/dev_compiler/kernel/amd/dart_sdk.js
```
|
tool,platform-web,P3,team-web,triaged-web
|
low
|
Minor
|
641,257,948 |
TypeScript
|
Composite (-b) projects don't report duplicate compilations
|
**TypeScript Version:** 4.0.0-dev.20200615
**Search Terms:** type narrowing composite build project references duplicate compilations
**Code**
* [`tsconfig.base.json`](https://github.com/JoshuaKGoldberg/ts-repro-project-narrowing/blob/5b71a26b336e6b5267d919832e076923dbb38296/tsconfig.base.json)
* [`tsconfig.json`](https://github.com/JoshuaKGoldberg/ts-repro-project-narrowing/blob/5b71a26b336e6b5267d919832e076923dbb38296/tsconfig.json)
* [`src/a/tsconfig.json`](https://github.com/JoshuaKGoldberg/ts-repro-project-narrowing/blob/5b71a26b336e6b5267d919832e076923dbb38296/src/a/tsconfig.json)
* [`src/a/Wat.tsx`](https://github.com/JoshuaKGoldberg/ts-repro-project-narrowing/blob/5b71a26b336e6b5267d919832e076923dbb38296/src/a/Wat.tsx)
**Expected behavior:**
As determined in #38406, the above projects are misconfigured so that `Wat.tsx` is included twice in compilation (https://github.com/microsoft/TypeScript/issues/38406#issuecomment-625546420). There should be some indication that the projects are misconfigured.
**Actual behavior:**
Mysterious, difficult-to-debug inconsistencies in type narrowing during compile checking coupled with unusually slow builds.
**Repository Link:**
https://github.com/JoshuaKGoldberg/ts-repro-project-narrowing/tree/5b71a26b336e6b5267d919832e076923dbb38296
**Related Issues:** #38406
|
Suggestion,Needs Proposal
|
low
|
Critical
|
641,308,837 |
godot
|
Multiple nodes selected, Inspector shows only one object after closing the running project
|
**Godot version:**
3.2.2.rc
**OS/device including version:**
Windows 10 , Build 18362
**Steps to reproduce:**
- Select multiple objects -> _(inspector edits multiple objects)_
- Press F5/F6 to run the game
- Close the game and return to the engine
- Check inspector -> _(inspector edits only one object, although multiple objects selected)_
|
bug,topic:editor
|
low
|
Minor
|
641,347,678 |
flutter
|
[tool_crash] FileSystemException: Cannot resolve symbolic links, path = 'D:\development\flutter' (OS Error: The system cannot find the file specified., errno = 2)
|
## Command
```
flutter --no-color run --machine --track-widget-creation --device-id=emulator-5554 lib\main.dart
```
## Steps to Reproduce
1. ...
2. ...
3. ...
## Logs
FileSystemException: FileSystemException: Cannot resolve symbolic links, path = 'D:\development\flutter' (OS Error: The system cannot find the file specified.
, errno = 2)
```
#0 FileSystemEntity._throwIfError (dart:io/file_system_entity.dart:828:7)
#1 FileSystemEntity.resolveSymbolicLinksSync (dart:io/file_system_entity.dart:391:5)
#2 ForwardingFileSystemEntity.resolveSymbolicLinksSync (package:file/src/forwarding/forwarding_file_system_entity.dart:58:49)
#3 _compareResolvedPaths (package:flutter_tools/src/runner/flutter_command_runner.dart:529:65)
#4 FlutterCommandRunner._checkFlutterCopy (package:flutter_tools/src/runner/flutter_command_runner.dart:513:21)
#5 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart:303:9)
<asynchronous suspension>
#6 FlutterCommandRunner.runCommand.<anonymous closure> (package:flutter_tools/src/runner/flutter_command_runner.dart)
#7 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:150:29)
#8 _rootRun (dart:async/zone.dart:1184:13)
#9 _CustomZone.run (dart:async/zone.dart:1077:19)
#10 _runZoned (dart:async/zone.dart:1619:10)
#11 runZoned (dart:async/zone.dart:1539:10)
#12 AppContext.run (package:flutter_tools/src/base/context.dart:149:18)
#13 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:288:19)
#14 CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#15 new Future.sync (dart:async/future.dart:224:31)
#16 CommandRunner.run (package:args/command_runner.dart:112:14)
#17 FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:231:18)
#18 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:63:22)
```
```
[✓] Flutter (Channel stable, v1.17.3, on Microsoft Windows [Version 10.0.18362.900], locale en-ID)
• Flutter version 1.17.3 at D:\development\flutter
• Framework revision b041144f83 (2 weeks ago), 2020-06-04 09:26:11 -0700
• Engine revision ee76268252
• Dart version 2.8.4
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
• Android SDK at D:\AndroidStudio\Sdk
• Platform android-29, build-tools 29.0.3
• ANDROID_HOME = D:/AndroidStudio/Sdk
• Java binary at: D:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
• All Android licenses accepted.
[✓] Android Studio (version 3.5)
• Android Studio at D:\Program Files\Android\Android Studio
• Flutter plugin version 44.0.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03)
[✓] VS Code (version 1.46.0)
• VS Code at C:\Users\Hp\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 3.11.0
[✓] Connected device (2 available)
• HK1 Max • 192.168.0.2:5555 • android-arm64 • Android 9 (API 28)
• Android SDK built for x86 • emulator-5554 • android-x86 • Android 8.0.0 (API 26) (emulator)
• No issues found!
```
## Flutter Application Metadata
**Type**: app
**Version**: 1.0.0+1
**Material**: true
**Android X**: false
**Module**: false
**Plugin**: false
**Android package**: null
**iOS bundle identifier**: null
**Creation channel**: stable
**Creation framework version**: b041144f833e05cf463b8887fa12efdec9493488
|
c: crash,tool,platform-windows,P2,team-tool,triaged-tool
|
low
|
Critical
|
641,453,981 |
youtube-dl
|
Add support for Iltalehti
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.06.16.1. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.06.16.1**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
https://en.wikipedia.org/wiki/Iltalehti
youtube-dl --verbose https://www.iltalehti.fi/kotimaa/a/22a7cc8e-7458-49e2-ba5a-1bc5ed651240
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.iltalehti.fi/kotimaa/a/22a7cc8e-7458-49e2-ba5a-1bc5ed651240']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2020.06.16.1
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg 4.2.3, ffprobe 4.2.3
[debug] Proxy map: {}
[generic] 22a7cc8e-7458-49e2-ba5a-1bc5ed651240: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 22a7cc8e-7458-49e2-ba5a-1bc5ed651240: Downloading webpage
[generic] 22a7cc8e-7458-49e2-ba5a-1bc5ed651240: Extracting information
ERROR: Unsupported URL: https://www.iltalehti.fi/kotimaa/a/22a7cc8e-7458-49e2-ba5a-1bc5ed651240
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\YoutubeDL.py", line 797, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpspbsbtmq\build\youtube_dl\extractor\generic.py", line 3382, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.iltalehti.fi/kotimaa/a/22a7cc8e-7458-49e2-ba5a-1bc5ed651240
|
site-support-request
|
low
|
Critical
|
641,463,839 |
godot
|
Ray slows down before the collision
|
Godot version: 3.2.1
OS/device including version: Windows10, gtx1050, GLES3
If Continuous Cd is set to Ray, there will be an unintended slowdown before the high speed collision.
By the way, if you set Static's Rotation to If you set it to 45 degrees. No slowdown occurs.
[Ray_Test.zip](https://github.com/godotengine/godot/files/4800479/Ray_Test.zip)
|
bug,topic:physics
|
low
|
Major
|
641,481,011 |
vscode
|
Silence the startup command printout in Integrated Terminal
|
<!-- ⚠️⚠️ Do Not Delete This! feature_request_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
When I run a Dart app in the Integrated Terminal, it prints out a very verbose startup command, e.g.:
`cd /Users/mikem/myproject; /usr/local/Cellar/dart/2.8.2/libexec/bin/dart --enable-vm-service=0 --pause_isolates_on_start=true --write-service-info=file:///var/folders/2n/vn59_vz152vg107rrs53ympc0000gn/T/dart-vm-service-ee74.json -DSILENT_OBSERVATORY=true --enable-asserts bin/main.dart`
This happens for Javascript too:
`mikem@MBP node_sample % /usr/local/bin/node --inspect-brk=6018 scripts/simple.js
Debugger listening on ws://127.0.0.1:6018/453abe68-1da3-4862-8ba4-71d8e3dfd8d6
For help, see: https://nodejs.org/en/docs/inspector
Debugger attached.`
These printouts pollute the scrollback and aren't very useful imho. Could we get an option to silence this output, so the first thing I see in the Integrated Terminal is one of the print statements actually in my code?
Note that this doesn't happen when using the Debug Console. There, I only see this printout (which also would be nice to silence, but at least it's less verbose):
`Connecting to VM Service at ws://127.0.0.1:58210/4yciVJ1NsWE=/w`
|
feature-request
|
medium
|
Critical
|
641,504,732 |
rust
|
Iterator Indexing
|
Itertools is considering [a PR introducing iterator indexing](https://github.com/rust-itertools/itertools/pull/447), implemented in the same manner as the core library's [slice indexing mechanism](https://doc.rust-lang.org/std/slice/trait.SliceIndex.html). This [playground link](https://play.rust-lang.org/?edition=2018&gist=2d908fb28c16fb69070ea857c5aa1143) demonstrates the gist of it:
```rust
// `Itertools::get` indexes an iterator:
assert_eq!(
(0..5).get(2).collect::<Vec<_>>(),
vec![2]
);
assert_eq!(
(0..5).get(..3).collect::<Vec<_>>(),
vec![0, 1, 2]
);
assert_eq!(
(0..5).get(2..).collect::<Vec<_>>(),
vec![2, 3, 4]
);
```
I'm excited to merge this—it feels like something that ought to be in the standard library—but I want to avoid another [`{Itertools,Iterator}::flatten`](https://github.com/rust-lang/rfcs/pull/2845#issuecomment-596231853) debacle; i.e., if the core library later adopts this same method, then itertools users calling this method will have builds break.
Would this addition be a good fit for the core library?
|
T-libs-api,C-feature-request,A-iterators
|
low
|
Minor
|
641,526,472 |
pytorch
|
Move torch cpp Errors to c10::Error
|
The torch's python-like exception types defined in `csrc/Exceptions.h` [here](https://github.com/pytorch/pytorch/blob/master/torch/csrc/Exceptions.h) are based on printf string formating that can cause problems with the lifetime of the cstring.
We should move them to use the c10 version of these errors (that are already properly converted to the corresponding python error) from `c10/util/Exception.h` [here](https://github.com/pytorch/pytorch/blob/master/c10/util/Exception.h).
cc @ezyang @bhosmer @smessmer @ljk53
|
module: internals,module: error checking,triaged,enhancement,better-engineering
|
low
|
Critical
|
641,542,136 |
flutter
|
Hairline stroke painting can be antialiased across fractional pixel boundaries
|
## Steps to reproduce
Run the following app:
```dart
import 'package:flutter/material.dart';
void main() {
runApp(HairlineNotSoMuch());
}
class HairlineNotSoMuch extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Padding(
padding: EdgeInsets.all(50),
child: Column(
textDirection: TextDirection.ltr,
crossAxisAlignment: CrossAxisAlignment.start,
children: [
CustomPaint(
size: Size(99, 99),
painter: BoxPainter(),
),
],
),
);
}
}
class BoxPainter extends CustomPainter {
@override
void paint(Canvas canvas, Size size) {
final Paint paint = Paint()
..style = PaintingStyle.stroke
..strokeWidth = 0
..color = Colors.white;
final Rect rect = Rect.fromCenter(
center: Offset(size.width / 2, size.height / 2),
width: size.width,
height: size.height,
);
canvas.drawRect(rect, paint);
}
@override
bool shouldRepaint(CustomPainter oldDelegate) => true;
}
```
## Expected behavior
The [documentation on `Paint.strokeWidth`](https://api.flutter.dev/flutter/dart-ui/Paint/strokeWidth.html) says that a zero width "corresponds to a hairline width", and a further [discussion of hairline widths in `BorderSide.width`](https://api.flutter.dev/flutter/painting/BorderSide/width.html) says "Setting width to 0.0 will result in a hairline border. This means that the border will have the width of one physical pixel."
Given that (and no discussion of antialiasing), you expect such the code above to produce a 1-physical-pixel border.
## Actual behavior
The above code yields the following result (on my mac-os embedding; saw similar results on iOS and Android emulator):
This shows a 2-physical-pixel border.
Note: setting `isAntiAlias = false` on the paint causes it to render to one physical pixel. If the behavior outlined so far is indeed working as intended, then we should fix `BorderSide.toPaint()` to turn off anti-aliasing for the hairline border case. The current code is:
https://github.com/flutter/flutter/blob/6db22118ad7192d2719816688b65cef325db528b/packages/flutter/lib/src/painting/borders.dart#L179-L182
|
framework,a: quality,c: rendering,P3,team-framework,triaged-framework
|
medium
|
Critical
|
641,546,394 |
TypeScript
|
"export = { }" vs "let a = { }; export = a", causes discrepancy in import behavior
|
**TypeScript Version:** 3.9.5
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** I searched import related bug labels
**Code**
```ts
//module a
export = {
name: 'zzxoto'
};
//module b
const EX = { name: 'zzxoto' };
export = EX;
//////////////////////////////////////////////////////////////////
//when importing a
//this gives error:
//This module can only be referenced with ECMAScript imports/exports by turning on the 'esModuleInterop' flag and referencing its default export.ts(2497)
import { name } from './a';
//this works
import A from './a';
A.name;
//////////////////////////////////////////////////////////////////
//////////////////////////////////////////////////////////////////
//when importing b
//this works
import { name } from './b';
//this works too
import B from './b';
B.name
//////////////////////////////////////////////////////////////////
//tsconfig.json
{
"compilerOptions": {
"target": "ES2019",
"module": "commonjs",
"strict": false,
"strictNullChecks": true,
"allowJs": false,
"esModuleInterop": true
},
"include": ["**/*.ts"]
}
```
**Expected behavior:**
There should be no descrepancy while import `module a` vs `module b`.
**Actual behavior:**
Described above.
|
Needs Investigation
|
low
|
Critical
|
641,547,317 |
vscode
|
Symbol occurrence highlighting overlaps occurrences of the selected text
|
<!-- ⚠️⚠️ Do Not Delete This! bug_report_template ⚠️⚠️ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
When selecting text or placing the cursor on a symbol with the C/C++ extension **disabled**, the other occurrences of the **symbol** are highlighted, **or** if there is a selection, the occurrences of the **selection** are highlighted. The selection is highlighted with the regular selection highlight color (`editor.selectionBackground`), and the occurrences are highlighted using the occurrences highlight color (`editor.selectionHighlightBackground`).
With the C/C++ extension **enabled**, if the global setting `Editor: Occurrences Highlight` is enabled, VS Code will always do **both**, with the symbolic occurrence highlighting rendered **_after_** the selection highlight, and **all** occurrences of **both** the selected text, **and** the symbol are highlighted in the _same style_, with no way to differentiate between them. This causes the **selected text**, which is more specific, and a direct result of a user action, and therefore arguably higher precedence, to be _completely obscured_ by the **symbol** occurrence provided by the extension, which is arguably lower precedence.
Here, in an **unsaved buffer**, with the language set to `C`, the behavior is predictable and correct. When placing the cursor on an occurrence of a **symbol** with **no selection**, the other occurrences of the **symbol** are highlighted:
Here, in the same **unsaved** buffer, **part** of the symbol `foo` is selected. The behavior is still predictable and correct. The other occurrences of the **selection** are highlighted in the highlight color (`editor.selectionHighlightBackground`), and the selection itself is highlighted in the selection color (`editor.selectionBackground`):
Likewise, if the entire symbol `foo` is **selected**, the behavior is still as expected, with the **selection** itself highlighted with the **selection color**, and the **other occurrences** of the **selection** highlighted in the **highlight color**:
If the file is **saved**, and the C/C++ extension becomes enabled for the file, the behavior becomes problematic. Here, as in the first example, the cursor is placed within a symbol, but **no selection** is made. The behavior is as expected, with the **symbol** and **all other occurrences** highlighted in the **highlight** color:
Here, when **part** of the symbol is selected in the **saved** file, the **symbol** occurrences _overlap_ the **selection** occurrences. The first two characters of the symbol `foo` are selected, but due to the overlapping, both the selection is obscured, and additionally, there are now **two different occurrences** being highlighted throughout the file at the same time, in the same color and style (both the selection, `fo`, and the symbol, `foo`), making them impossible to differentiate:
Here, when the entire symbol is selected, the selection color is lost, so it is impossible to identify which text is selected:
If both colors are made to be transparent, or a highlight border is added, it becomes obvious that both highlight actions are taking place, first the selection occurrences, then the symbolic occurrences (there is also a noticeable delay for the second highlight, so the selection highlighting can be seen briefly before being obscured). Setting these colors to be transparent would seem to resolve the problem, but the occurrence highlighting feature becomes almost useless when the highlight transparency is adjusted to the point where the original selection is visible **through** it. I also firmly believe that transparency is not a solution to this issue, because most color combinations either result in the underlying selection not being visible enough to distinguish through the occurrence highlight, or the occurrence highlighting not being visible against the background. The other core problem is that both the selection and the symbol are highlighted using the same `editor.selectionHighlightBackground` color, so even if there was no visible problem overlapping at the location of the selection itself, all of the instances of both the **selection** and the **symbol occurrences** are highlighted the same, which is confusing.
This can be seen here, where `editor.selectionBackground` is set to a bright, opaque color `#ff0000`, and `editor.selectionHighlightBackground` is set to a bright, but also transparent color `#00ff0050`, in order to keep the main highlight color visible underneath:
This makes the selection highlighting visible, but unfortunately also causes whitespace decorations to be obscured, which is another problem with relying on transparency for symbol visibility. This is one of the best case scenarios (a bright, opaque selection color with a bright, transparent highlight color), but still suffers from **all** highlighted occurrences being styled the **same** (both `foo` and `fo` are highlighted green). Most normal combinations of transparent highlight colors are hardly visible, especially if using a sane `editor.selectionBackground`.
Setting both colors to transparent values allows whitespace decorations to be shown, but results in hardly usable or visible highlighting in either case. Here, both are set to transparent values, and the selection itself can hardly be seen, and still, all occurrences of both the selection and the symbol are the same color:
As far as I can tell, there is no way to disable the 'overlapping' occurrence highlighting feature without losing other important functionality, like single-clicking on a symbol and the other instances being automatically highlighted, or without completely disabling the C/C++ extension and losing Intellisense features.
It appears the most straightforward solution would be to do one, or ideally both of the following:
- Render the **selection** highlight, and the **occurrences** of the **selection**, **after** the symbol occurrences, causing their highlighted backgrounds to be rendered on **top** of the symbolic highlighting background.
- Add a setting to allow the user to select the desired behavior. **Always** highlight symbolic occurrences, or only highlight symbolic occurrences when **no selection is present**.
It would also make sense to render whitespace and other related decorations **after** the highlighting as well, so they would be visible regardless of the selection and/or occurrence highlighting, and regardless of the transparency of the selected colors.
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.46.0
- OS Version: macOS 10.14.6 and Windows 10 Enterprise (1909)
Steps to Reproduce:
**Prepare the environment:**
1. Enable the setting `Editor: Occurrences Highlight`
2. Set both `editor.selectionBackground` and `editor.selectionHighlightBackground` in `settings.json` -> `workbench.colorCustomizations` to two different, opaque colors. For example, `#ff0000` and `#0000ff`.
3. Ensure the C/C++ extension is installed and enabled. This example uses C/C++, but this problem likely occurs with any extension that provides highlight ranges.
**Test the behavior:**
1. Create a new folder.
2. Create a new `.c` file in the folder.
3. Open the new folder in VS Code.
4. Within the newly created `.c` file, add the code in the screenshots above, or any other valid `C` code with several occurrences of a given symbol, ideally one that shares likeness with another symbol or keyword in order to demonstrate the problem (`testvar1` and `temp2` for example, sharing the prefix `te`).
5. Save the `.c.` file.
6. Copy the entire text to the clipboard.
7. Create a new empty buffer, set the language of the new buffer to `C`, and paste the copied text into the buffer. Do not save the buffer.
8. Observe the behaviors described above. The unsaved buffer will behave predictably, presumably because the C/C++ extension is not active (so Intellisense is also not active, and the extension is not providing any highlight ranges). The saved buffer will have C/C++ Intellisense enabled, and symbolic occurrences highlighting will obscure the active selection highlighting.
**Expected behavior**
Highlighted occurrences of selected text take precedence over symbolic highlighting occurrences, only occurrences of the **selected text** are highlighted if a selection is present, or both are visible and differentiated.
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: No. However, I initially filed this issue in the C/C++ extension repository and was instructed to file it here based on extensions not having any control over the highlight rendering, only the ranges to be highlighted as per [https://microsoft.github.io/language-server-protocol/specification#textDocument_documentHighlight](https://microsoft.github.io/language-server-protocol/specification#textDocument_documentHighlight).
|
bug,editor-rendering
|
medium
|
Critical
|
641,548,084 |
flutter
|
[flutter_tools] Have doctor validate all system requirements
|
It is easy for users to overlook the system requirements on the website (e.g. https://flutter.dev/docs/get-started/install/windows). We should validate them all (or as best as we can) in the doctor.
|
tool,P3,team-tool,triaged-tool
|
low
|
Minor
|
641,574,157 |
PowerToys
|
[PowerRename] invoke via command prompt
|
another use-case (that interests me) is to rename downloaded file names using regEx with PowerRenamer,
i have files with the pattern: S1E12 or S1E4 inside the name,
i have to run the tool twice in order to replace all files,
once for the single digit names (and pad them with leading zero),
and a second time for double digits names,
so a command-line interface to be able to run a rename command with the parameter twice from a single batch would do the trick
_Originally posted by @shaybc in https://github.com/microsoft/PowerToys/issues/3301#issuecomment-636284182_
|
Idea-Enhancement,Help Wanted,Product-PowerRename
|
low
|
Minor
|
641,587,442 |
pytorch
|
Include expanded TensorOptions version of op in at:: namespace
|
Currently this version is only in at::native and we only have the packed `TensorOptions` version available in `at::`. This requires backends to have a hacky codegen to construct TensorOptions before calling `at::` functions.
https://github.com/pytorch/pytorch/pull/39492
|
triaged,module: codegen
|
low
|
Minor
|
641,620,075 |
flutter
|
[engine][fuchsia] Need RasterThreadMerger working on Fuchsia
|
Currently, fuchsia does not use RasterThreadMerger. Code and test utilizing this need to be excluded using \#define(OS_FUCHSIA) flags.
|
engine,dependency: fuchsia,platform-fuchsia,P2,team-engine,triaged-engine
|
low
|
Minor
|
641,647,456 |
flutter
|
flutter run doesn't show notice message when removing identical print lines.
|
A minimum example:
```
import 'package:flutter/material.dart';
void main() => runApp(MyApp());
/// This Widget is the main application widget.
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
for(int i=0; i<10; i++) {
print('here!');
}
return MaterialApp();
}
}
```
There will be random number of "here!" printed by `flutter run` command line. Replacing `print('here!');` to `print('here! $i');` will promise 10-line output.
If it's running from Android studio, there will be a line like
```
I/chatty (25285): uid=10281(com.example.sample) 1.ui identical 8 lines
```
to inform users that there are omitted outputs, but there isn't such warning if running from `flutter run` command line.
This can be confusing when debugging and developing.
|
c: new feature,tool,a: annoyance,P3,team-tool,triaged-tool
|
low
|
Critical
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.