id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
611,782,175 |
PowerToys
|
[FancyZones] Allow linking of windows in a layout together to bring them all to the front when one is pressed.
|
# Summary of the new feature/enhancement
I think it would be incredibly useful if windows in a Zone were able to be linked together such that if you brought one to the front it would bring all of them to the front at the same time. I understand that you could have multiple windows in the same section on a zone so there'd need to be some way to say which windows are linked together. This could perhaps be a separate toy all together.
The use case for this is that if a monitor is used for multiple things, some windows may cover part or all of a set of other windows. If two or more windows have been snapped to a zone it's likely they should all be visible at the same time so needing to click each window one by one to bring them all forward again can be tedious.
I currently don't have any suggestions for how this would look from a UI/UX perspective.
|
Idea-Enhancement,Product-FancyZones
|
medium
|
Major
|
611,794,749 |
flutter
|
Material Component widget request: multi-select search field with auto-suggestion
|
## Use case
[RecipeRadar](https://www.reciperadar.com/) currently provides the user with the ability to enter multiple ingredients and/or kitchen equipment items that they would like to include or exclude when searching for recipes.
This functionality is built using a server-side auto-suggestion API that responds to the user's query text with suggested valid ingredient and equipment identifiers (and their corresponding human-readable names).
While the user-facing application does not use `flutter`, we are evaluating it as a possible next-generation application framework, particularly as [support for Progressive Web Apps](https://flutter.dev/web) as a target platform continues to develop.
One detractor that we have encountered is that `flutter` does not yet support a multi-selection auto-suggest search input.
We are currently using [select2's multi-select functionality](https://select2.org/getting-started/basic-usage#multi-select-boxes-pillbox) and have discovered existing native client-side functionality in [Android's MultiAutoCompleteTextView](https://developer.android.com/reference/android/widget/MultiAutoCompleteTextView).
## Proposal
A [Material Component widget](https://flutter.dev/docs/development/ui/widgets/material) that [implements](https://github.com/flutter/flutter/tree/0549ab239009e6f76f95881364e935cd345a4da7/packages/flutter/test/material) support for multi-valued text input, with support for auto-suggestion.
- [Android's MultiAutoCompleteTextView](https://developer.android.com/reference/android/widget/MultiAutoCompleteTextView) may provide a useful reference for design, accessibility and implementation concerns
- Support for population of values from a server-side API endpoint is required; we and likely other customers would be greatly aided during system migration if the component would support client-side transformation of the data returned by the endpoint
- User-selectde items will require both a user-accessible text description, and also a service-defined ID value (similar to the distinction between an HTML [option](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/option) field's innerHTML and its `value` attribute)
- Support for purely client-side autosuggestion and tokenization may be valuable for other customers (although it is not currently a requirement that we have)
## Relates to
- https://github.com/flutter/flutter/issues/17119
- https://github.com/flutter/flutter/issues/23827
|
c: new feature,framework,f: material design,c: proposal,P3,team-text-input,triaged-text-input
|
low
|
Minor
|
611,799,737 |
deno
|
deno install should bundle before installation
|
`deno install` is a utility that allows to install any module as an executable by creating shell script that invokes actual module.
Currently it works by caching all dependencies of the module in `$DENO_DIR` and adding entry point local URL to the shell script.
Huge caveat in this approach is that if user reloads dependencies installed script might break (especially for untagged imports...).
To mitigate this problem the script should be bundled into a single file during installation.
This way installed script can be made into standalone utilities that do not share cache with other development projects and are completely standalone.
CC @ry
|
feat,cli
|
low
|
Major
|
611,957,037 |
pytorch
|
CMake Documentation Issue
|
It isn't mentioned in PyTorch docs about the Set()
Also, the Cmake file isn't quite complete and needs to be updated. Maybe new users don't know about it.
```
set(CMAKE_PREFIX_PATH "libtorch/share/cmake/Torch")
```
[here](https://pytorch.org/tutorials/advanced/cpp_frontend.html) as well as [here](https://pytorch.org/tutorials/advanced/cpp_export.html)
The CMake file needs to be clear in the documentation. It is causing trouble for many people.
#12449 #21976 #806 #12449
It's not a bug. But a doc improvement issue.
|
module: docs,triaged
|
low
|
Critical
|
611,967,909 |
PowerToys
|
Fine-tune multi-monitor positioning tool
|
# Summary of the new feature/enhancement
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
The current way to position monitors is via Display Settings, but this does really bad snapping as one can see in the following example for a Dell XPS 4k laptop monitor and 2 Dell 1080p external monitors:
(for the record, I've actually raised a Feedback Hub issue on this problem: https://aka.ms/AA6rwp7)
# Proposed technical implementation details (optional)
<!--
A clear and concise description of what you want to happen.
-->
Ideally, I would like this screen with a more powerful interface, that would allow me to even specify coordinates on the monitors positioning.
DisplayFusion does provide a tool to do this, but it is a paid utility to fix a Windows problem, and I believe this should be natively provided (or via PowerToys)
|
Help Wanted,Idea-New PowerToy,Product-Display management
|
low
|
Major
|
611,976,818 |
flutter
|
Flutter project - All files duplicated when created
|
Whenever I create a Flutter project either by using the Flutter CLI or Android Studio, a strange problems seem to occur. All files are duplicated and a ' 2' (space two) is put in the end of the file's name.
1. Run `flutter create bug`.
2. Look at the project structure
**Expected results:**
A project without all of theses duplicated files.
**Actual results:**
A project with all of theses duplicated files.
<details>
<summary>Logs</summary>
```
[ ] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-mdpi/ic_launcher 2.png: Resource and asset merger: ' ' is not a
valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ +1 ms] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-hdpi/ic_launcher 2.png: Resource and asset merger: ' ' is not a
valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ +1 ms] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/drawable/launch_background 2.xml: Resource and asset merger: ' ' is not a
valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ ] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher 2.png: Resource and asset merger: ' ' is not a
valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ +1 ms] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-xxhdpi/ic_launcher 2.png: Resource and asset merger: ' ' is not a
valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ ] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-xhdpi/ic_launcher 2.png: Resource and asset merger: ' ' is not a
valid file-based resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ +90 ms] FAILURE: Build failed with an exception.
[ ] * What went wrong:
[ ] Execution failed for task ':app:mergeDebugResources'.
[ ] > /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-mdpi/ic_launcher 2.png: Error: ' ' is not a valid file-based
resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ ] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-hdpi/ic_launcher 2.png: Error: ' ' is not a valid file-based
resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ +1 ms] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/drawable/launch_background 2.xml: Error: ' ' is not a valid file-based
resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ +1 ms] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-xxxhdpi/ic_launcher 2.png: Error: ' ' is not a valid file-based
resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ +1 ms] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-xxhdpi/ic_launcher 2.png: Error: ' ' is not a valid file-based
resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
[ +1 ms] /Users/matheuscirillo/Documents/Alura/flutter/flutter_app/android/app/src/main/res/mipmap-xhdpi/ic_launcher 2.png: Error: ' ' is not a valid file-based
resource name character: File-based resource names must contain only lowercase a-z, 0-9, or underscore
```
</details>
The error `' ' is not a valid file-based` led me to believe that this is related to the ' 2' that goes in the end of the file's name. (see the Logs section)
## EDIT
`flutter doctor -v` command result:
```
[β] Flutter (Channel stable, v1.12.13+hotfix.9, on Mac OS X 10.14.5 18F132, locale pt-BR)
β’ Flutter version 1.12.13+hotfix.9 at /Users/matheuscirillo/Documents/flutter
β’ Framework revision f139b11009 (5 weeks ago), 2020-03-30 13:57:30 -0700
β’ Engine revision af51afceb8
β’ Dart version 2.7.2
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
β’ Android SDK at /Users/matheuscirillo/Library/Android/sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-29, build-tools 29.0.3
β’ ANDROID_HOME = /Users/matheuscirillo/Library/Android/sdk
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS
β Xcode installation is incomplete; a full installation is necessary for iOS development.
Download at: https://developer.apple.com/xcode/download/
Or install Xcode via the App Store.
Once installed, run:
sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
sudo xcodebuild -runFirstLaunch
β CocoaPods not installed.
CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To install:
sudo gem install cocoapods
[β] Android Studio (version 3.6)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 45.1.1
β’ Dart plugin version 192.7761
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[!] VS Code (version 1.44.2)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[!] Connected device
! No devices available
! Doctor found issues in 3 categories.
```
|
tool,platform-mac,P2,team-tool,triaged-tool
|
low
|
Critical
|
611,978,557 |
rust
|
Incorrect recommended import for renamed dependencies
|
This requires two crates: `a` and `b`.
`a/src/lib.rs`:
```rust
pub struct A;
pub trait Foo {
fn foo(&self);
}
impl Foo for A {
fn foo(&self) {}
}
```
`b/Cargo.toml`:
```
[package]
name = "b"
version = "0.1.0"
[dependencies]
c = { path = "../a", package = "a" }
```
`b/src/lib.rs`
```rust
fn b() {
c::A.foo();
}
```
When compiling `b` we get the following error:
```
error[E0599]: no method named `foo` found for struct `a::A` in the current scope
--> src/lib.rs:2:10
|
2 | c::A.foo();
| ^^^ method not found in `a::A`
|
::: /home/programming/f/a/src/lib.rs:3:8
|
3 | fn foo(&self);
| ---
| |
| the method is available for `std::boxed::Box<a::A>` here
| the method is available for `std::sync::Arc<a::A>` here
| the method is available for `std::rc::Rc<a::A>` here
|
= help: items from traits can only be used if the trait is in scope
help: the following trait is implemented but not in scope; perhaps add a `use` for it:
|
1 | use a::Foo;
|
```
Adding `use a::Foo` is not correct, as we have to use `c::Foo`.
|
A-diagnostics,T-compiler,C-bug,D-papercut,D-invalid-suggestion
|
low
|
Critical
|
612,013,110 |
TypeScript
|
Automatic multi-file namespace references in AMD/System modules are buggy in complicated situations
|
**TypeScript Version:** 3.8.3
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** AMD, System, Reference, Circular reference, Automatic Reference, Auto Reference, Multi-file Namespace, Splitting Across Files
**Problem**
While most people use TypeScript with a `commonjs` way of modeling. There are a fraction of this community that uses the AMD / System setup—just like the TypeScript compiler itself—and a common practice is to have `outFile` enabled. In this situation the compiler automatically detects which file is the dependency of what other file and arranges the namespaces in such way that it can be put into a single file.
This however is not when it comes to rather complicated structures in which one has namespaces separated in multiple files and have circular referencing in them. For that TypeScript does have these `/// <reference path="..." />` comments that act like the `require` / `import` features.
Using the reference comments always solves any kind of dependency resolution. But the problem is while the compiler halts on using an identifier without importing on other modules (`import` / `require`), there is no compiler error or even warning on not using the reference comments.
I do not know what is the bug in here:
- Is it that the compiler gives no error on absence of the reference comment?
- Or is the file dependency graph resolver that is buggy?
I have demonstrated a situation in which a simple project with a complicated enough graph of dependencies show how the problem can be replicated. This is the graph describing the structure of this project and a git repository containing both a working version and a buggy version is provided respectively: <br><br>
**Code**
- Buggy version: http://codes.kary.us/playgrounds/typescript-amd-automatic-reference-bug/tree/buggy-version
- Working version: http://codes.kary.us/playgrounds/typescript-amd-automatic-reference-bug/tree/fixed-version
**Expected behavior:**
- I think either the compiler should have the right dependency resolver and insert reference tags for all the calls to other files in each file.
- Or the reference comments should be forced on all files and the compiler gives errors that one identifier cannot be found because it is not resolved with the reference comment.
**Actual behavior:**
If you use the reference comments for all the imported identifiers in every file the code will run successfully but if you remove them it will compile but the code will not work because it has type checking problems on undefined modules. This screenshot shows the working and buggy versions for good:
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
|
Needs Investigation
|
low
|
Critical
|
612,034,927 |
flutter
|
Adding span with Url throws assertion in RichText
|
In RichText when we add span with `Url` it throws this assertion.
## Steps to Reproduce
```
getParsedMessage() {
if (message.body == null || message.body.isEmpty) return Container();
List<TextSpan> spans = [];
var urlPattern =
r"(https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9][a-zA-Z0-9-]+[a-zA-Z0-9]\.[^\s]{2,}|https?:\/\/(?:www\.|(?!www))[a-zA-Z0-9]\.[^\s]{2,}|www\.[a-zA-Z0-9]\.[^\s]{2,})";
String tmp = message.body;
Iterable<Match> matches = RegExp(urlPattern).allMatches(message.body);
matches.forEach((m) {
String match = m.group(0);
int index = tmp.indexOf(match);
if (index > 0) {
spans.add(
TextSpan(text: tmp.substring(0, index), style: normal14blackish));
}
spans.add(TextSpan(
text: match,
style: normal14blackish.copyWith(color: Colors.blue),
recognizer: MultiTapGestureRecognizer()
..onTap = (int) async {
if (await canLaunch(match)) launch(match);
}));
tmp = tmp.substring(index).replaceFirst(match, '');
});
spans.add(TextSpan(text: tmp, style: normal14blackish));
return RichText(text: TextSpan(children: spans));
}
```
## Logs
Found in 1.17.0-3.4.pre.
|
framework,a: typography,found in release: 1.17,P2,team-framework,triaged-framework
|
low
|
Major
|
612,046,446 |
go
|
image/gif: GIF files with extraneous 0x00 bytes cause "gif: unknown block type: 0x00"
|
### What version of Go are you using (`go version`)?
```
$ go version
go version go1.14.1 linux/amd64
```
### Does this issue reproduce with the latest release?
Yes (and it has probably existed for a very long time, possibly forever)
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/steve/.cache/go-build"
GOENV="/home/steve/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOOS="linux"
GOPATH="/home/steve/go"
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build601247294=/tmp/go-build -gno-record-gcc-switches"
GOROOT/bin/go version: go version go1.14.1 linux/amd64
GOROOT/bin/go tool compile -V: compile version go1.14.1
uname -sr: Linux 5.3.0-46-generic
Distributor ID: Ubuntu
Description: Ubuntu 19.10
Release: 19.10
Codename: eoan
/lib/x86_64-linux-gnu/libc.so.6: GNU C Library (Ubuntu GLIBC 2.30-0ubuntu2.1) stable release version 2.30.
gdb --version: GNU gdb (Ubuntu 8.3-0ubuntu1) 8.3
</pre></details>
### What did you do?
Tried to use `image/gif` `DecodeAll()` on a GIF with extra `0x00` byte(s) before the trailer byte `0x3b`.
Example:
https://play.golang.org/p/vzVJUj4TRgm
### What did you expect to see?
The image loads properly (as it does in browsers, ImageMagick, gifsicle and Eye Of GNOME).
### What did you see instead?
`gif: unknown block type: 0x00`
### Comments ###
This is caused by a more strict implementation of the GIF file format than most other programs. We already address this issue for extraneous trailing bytes in the LZW decoder (#16146), but I am also seeing them elsewhere between blocks in real files, generally before the closing trailer byte.
Here are the hex dumps of some example files that I have found:
```
./test/gifs/PIL-V_AN.GIF
00000130 a8 e7 5c 3e 1f 8d d7 f1 9d e7 3b d8 c3 05 00 c4 |..\>......;.....|
00000140 60 2f 56 34 d2 2a 49 a5 e9 d1 74 c2 86 51 65 aa |`/V4.*I...t..Qe.|
00000150 4a cc 6a 27 d9 a7 68 d4 fc 5e 21 53 31 35 50 36 |J.j'..h..^!S15P6|
00000160 03 be 05 00 00 3b |.....;|
00000166
./test/gifs/CDROM.GIF
00004190 2e 00 f0 8f a2 b9 10 5c 65 5b 06 e0 55 1b c0 7c |.......\e[..U..||
000041a0 5f 85 02 2e e7 6a b3 89 8a cc c6 4a bf 39 9c c4 |_....j.....J.9..|
000041b0 59 9c 0c c6 79 9c c8 99 9c ca b9 9c c6 19 10 00 |Y...y...........|
000041c0 00 3b |.;|
000041c2
./test/gifs/LYSSKILT.GIF
00001c20 b1 a8 8f ac ac ca 69 b0 cc 79 c7 74 d3 ad 8f da |......i..y.t....|
00001c30 d1 96 b6 cd dd 9d d7 f0 f1 f2 f3 f4 f5 f6 f7 f8 |................|
00001c40 f9 fa fb fc fd fe ff 00 03 0a 1c 48 b0 47 04 00 |...........H.G..|
00001c50 00 3b |.;|
00001c52
./test/gifs/PIL-N_AN.GIF
00000140 12 dd 50 31 2a 1e 2b 38 e5 92 e7 14 f2 0c d1 1b |..P1*.+8........|
00000150 a9 64 14 01 73 ba 29 97 b3 bd 46 af b1 09 99 04 |.d..s.)...F.....|
00000160 38 ab d7 ec b6 fb 0d 8f cb e7 f4 ba fd 8e cf eb |8...............|
00000170 c9 05 00 00 3b |....;|
00000175
./test/gifs/PIL-O_AN.GIF
00000130 c4 f2 3c d9 b7 08 f4 be 2e f1 35 7a 37 1a 0a 98 |..<.......5z7...|
00000140 19 22 35 44 99 51 59 4c c2 96 15 ea 31 ca b4 42 |."5D.QYL....1..B|
00000150 77 d9 9f f7 03 0e 8b c7 e4 b2 f9 8c 4e ab d7 ec |w...........N...|
00000160 b6 fb 0d 67 17 00 00 00 3b |...g....;|
00000169
./test/gifs/LYS.GIF
000026b0 e8 c5 d0 5e 05 15 24 80 60 05 fe b9 77 1c 72 04 |...^..$.`...w.r.|
000026c0 2e a0 c2 09 09 d2 04 d7 85 0c 76 f0 20 6f 01 44 |..........v. o.D|
000026d0 b0 c0 03 09 0e 90 d8 00 02 50 55 80 03 28 3e 88 |.........PU..(>.|
000026e0 5c 40 00 00 3b |\@..;|
000026e5
./test/gifs/MOOSE.GIF
000048d0 20 63 72 65 61 74 65 64 20 77 69 74 68 20 61 20 | created with a |
000048e0 72 65 67 69 73 74 65 72 65 64 20 76 65 72 73 69 |registered versi|
000048f0 6f 6e 20 6f 66 20 47 49 46 20 43 6f 6e 73 74 72 |on of GIF Constr|
00004900 75 63 74 69 6f 6e 20 53 65 74 00 00 |uction Set..|
0000490c
./test/gifs/SOUNDER2.GIF
00000210 9b c5 57 57 3e 31 16 63 90 a5 b8 95 5e 98 36 2b |..WW>1.c....^.6+|
00000220 fa a9 d1 db b9 18 fd 50 09 9c 9d b9 df a3 01 67 |.......P.......g|
00000230 43 56 0c 37 32 25 8f 8a a6 c2 e4 74 16 00 00 00 |CV.72%.....t....|
00000240 3b |;|
00000241
./test/gifs/PIL-H_AN.GIF
00000140 f1 68 a9 60 70 78 2a 1a 81 c8 90 72 19 6b 66 9e |.h.`px*....r.kf.|
00000150 50 18 f1 57 8d f5 a8 d9 5e 0d 9b b5 78 bf 61 d7 |P..W....^...x.a.|
00000160 f8 bb 49 ab 9f 67 89 b2 ed c6 c2 e3 e2 79 64 64 |..I..g.......ydd|
00000170 77 4b 0a 00 00 3b |wK...;|
00000176
./test/gifs/COFFEEMA.GIF
00004a30 ea 05 4e b5 44 b6 71 06 67 f2 10 31 da ae e3 4a |..N.D.q.g..1...J|
00004a40 21 c3 73 61 fc 85 15 7b 21 a5 f6 3a 0c 6e 18 a5 |!.sa...{!..:.n..|
00004a50 40 79 a8 ff 4a 0b 44 27 a5 46 70 05 f5 5a b0 0c |@y..J.D'.Fp..Z..|
00004a60 db b0 b2 12 02 00 00 3b |.......;|
00004a68
```
Here are the images referenced above, they are all very small:
https://drive.google.com/drive/folders/13hKuVy_Kf2MeyWacXLPanwhH2uoIxLUe?usp=sharing
I have a simple solution so I'll put in a PR, but I'm not sure how strict you want to be in handling this (is one extraneous byte OK, but two not OK, for example?).
|
NeedsInvestigation
|
low
|
Critical
|
612,056,780 |
flutter
|
[Web] _CaretMetrics are incorrect for TextSpans
|
Following up on three skipped tests in `text_painter_test.dart`. The offset and height of the **_CaretMetrics** are incorrect for these tests on Web.
Test name: _TextPainter caret emoji test_
https://github.com/flutter/flutter/blob/c32d1387ab9a6cba7a4f9849dce1d6df63f5a173/packages/flutter/test/painting/text_painter_test.dart#L124
```md
02:01 +245 ~14 -1: /tmp/flutter sdk/packages/flutter/test/painting/text_painter_test.dart: TextPainter caret emoji test [E]
Expected: <42>
Actual: <14>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 216:49 throw_
package:test_api expect$
package:flutter_test/src/widget_tester.dart 364:3 expect$
text_painter_test.dart 80:5
```
---
Test name: _TextPainter caret center space test_
https://github.com/flutter/flutter/blob/c32d1387ab9a6cba7a4f9849dce1d6df63f5a173/packages/flutter/test/painting/text_painter_test.dart#L146
```md
02:01 +245 ~14 -2: /tmp/flutter sdk/packages/flutter/test/painting/text_painter_test.dart: TextPainter caret center space test [E]
Expected: <21>
Actual: <0>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 216:49 throw_
package:test_api expect$
package:flutter_test/src/widget_tester.dart 364:3 expect$
text_painter_test.dart 135:5 <fn>
```
---
Text name: _TextPainter caret height and line height_
https://github.com/flutter/flutter/blob/c32d1387ab9a6cba7a4f9849dce1d6df63f5a173/packages/flutter/test/painting/text_painter_test.dart#L835
```md
02:02 +253 ~16 -4: /tmp/flutter sdk/packages/flutter/test/painting/text_painter_test.dart: TextPainter caret height and line height [E]
Expected: <50>
Actual: <14>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/errors.dart 216:49 throw_
package:test_api expect$
package:flutter_test/src/widget_tester.dart 364:3 expect$
text_painter_test.dart 833:5 <fn>
```
|
a: tests,team,framework,a: typography,platform-web,e: web_html,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-web,triaged-web
|
low
|
Critical
|
612,059,866 |
react
|
Bug: devtools "rendered at" for child components uses value of top component
|
React version: 17.0.2
devtools version: 4.18.0-f58bbcf9a
## Steps To Reproduce
1. Record profiling session
2. Goto flamegraph
3. Click on a "bar" that's not the top-most
Link to code example: https://codesandbox.io/s/vibrant-thunder-bm3so
## The current behavior
"rendered at" uses the value from the root component
## The expected behavior
it should use the same value that is displayed in the tooltip. Otherwise I don't see much value in displaying it since I could just read the value directly from the root. I thought it was intended for very dense flamegraphs e.g.
|
Status: Unconfirmed,Component: Developer Tools,React Core Team
|
low
|
Critical
|
612,081,194 |
flutter
|
[Web] AssetImageProvider hangs on failure to load
|
Following up on skipped test, which times out when enabled. On null load passes (the test that comes after this one), but a failed load hangs.
Test name: _ImageProvider Image cache AssetImageProvider - evicts on failure to load _
https://github.com/flutter/flutter/blob/c32d1387ab9a6cba7a4f9849dce1d6df63f5a173/packages/flutter/test/painting/image_provider_test.dart#L68
```md
03:12 +325 ~4 -1: /tmp/flutter sdk/packages/flutter/test/painting/image_provider_test.dart: ImageProvider Image cache AssetImageProvider - evicts on failure to load [E]
TimeoutException after 0:00:30.000000: Test timed out after 30 seconds. See https://pub.dev/packages/test#timeouts
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1180:38 _rootRun
package:dart-sdk/lib/async/zone.dart 1077:19 run
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1184:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1077:19 run
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1184:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1077:19 run
package:dart-sdk/lib/async/zone.dart 1003:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 50:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1101:19 registerCallback
package:dart-sdk/lib/async/zone.dart 1002:22 bindCallback
package:dart-sdk/lib/async/zone.dart 1251:20 _rootCreateTimer
package:dart-sdk/lib/async/zone.dart 1145:19 createTimer
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1184:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1077:19 run
package:dart-sdk/lib/async/zone.dart 1618:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1539:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12 _async
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/future.dart 176:37 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1180:38 _rootRun
package:dart-sdk/lib/async/zone.dart 1077:19 run
package:dart-sdk/lib/async/zone.dart 979:7 runGuarded
package:dart-sdk/lib/async/zone.dart 1019:23 <fn>
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1184:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1077:19 run
package:dart-sdk/lib/async/zone.dart 1003:23 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/isolate_helper.dart 50:19 internalCallback
===== asynchronous gap ===========================
package:dart-sdk/lib/async/zone.dart 1101:19 registerCallback
package:dart-sdk/lib/async/zone.dart 1018:22 bindCallbackGuarded
package:dart-sdk/lib/async/timer.dart 54:45 new
package:dart-sdk/lib/async/timer.dart 91:9 run
package:dart-sdk/lib/async/future.dart 174:11 new
package:test_api <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 86:54 runBody
package:dart-sdk/lib/_internal/js_dev_runtime/patch/async_patch.dart 125:12 _async
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1184:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1077:19 run
package:dart-sdk/lib/async/zone.dart 1618:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1539:10 runZoned
package:stack_trace <fn>
package:dart-sdk/lib/async/zone.dart 1184:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1077:19 run
package:dart-sdk/lib/async/zone.dart 1618:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1539:10 runZoned
package:test_api [_onRun]
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 326:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 390:10 callMethod
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 394:5 dsend
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1184:13 _rootRun
package:dart-sdk/lib/async/zone.dart 1077:19 run
package:dart-sdk/lib/async/zone.dart 1618:67 _runZoned
package:dart-sdk/lib/async/zone.dart 1539:10 runZoned
package:test_api <fn>
package:dart-sdk/lib/async/zone.dart 1192:38 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1085:19 runUnary
package:dart-sdk/lib/async/zone.dart 987:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 339:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 266:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 779:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 655:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 597:5 add
package:dart-sdk/lib/async/zone.dart 1196:13 _rootRunUnary
package:dart-sdk/lib/async/zone.dart 1085:19 runUnary
package:dart-sdk/lib/async/zone.dart 987:7 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 339:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 266:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 779:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 655:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 597:5 add
package:dart-sdk/lib/async/stream_controller.dart 873:13 add
package:stream_channel <fn>
package:dart-sdk/lib/async/zone.dart 1374:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 339:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 266:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 779:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 655:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 597:5 add
package:dart-sdk/lib/async/zone.dart 1374:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 339:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 266:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 779:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 655:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 597:5 add
package:dart-sdk/lib/async/stream_controller.dart 873:13 add
package:dart-sdk/lib/async/zone.dart 1374:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 339:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 266:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 779:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 655:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 597:5 add
package:dart-sdk/lib/async/zone.dart 1374:10 runUnaryGuarded
package:dart-sdk/lib/async/stream_impl.dart 339:11 [_sendData]
package:dart-sdk/lib/async/stream_impl.dart 266:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 779:19 [_sendData]
package:dart-sdk/lib/async/stream_controller.dart 655:7 [_add]
package:dart-sdk/lib/async/stream_controller.dart 597:5 add
package:dart-sdk/lib/async/stream_controller.dart 873:13 add
package:stream_channel add
image_provider_test.dart.browser_test.dart 52:17 <fn>
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 326:14 _checkAndCall
package:dart-sdk/lib/_internal/js_dev_runtime/private/ddc_runtime/operations.dart 331:39 dcall
package:dart-sdk/lib/html/dart2js/html_dart2js.dart 37108:58 <fn>
```
|
a: tests,team,framework,platform-web,a: images,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-web,triaged-web
|
low
|
Critical
|
612,088,553 |
pytorch
|
Guard Gloo and TensorPipe related code in RPC with #ifdef
|
As we have compile flags like `USE_GLOO` and `USE_TENSORPIPE` that can disable Gloo and TensorPipe independently when `USE_DISTRIBUTED=1`, RPC code (e.g., in `rpc/init.cpp`) should not expect `process_group_agent` and `tensor_pipe_agent` are always available. They should be guarded by `#ifdef`.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley @osalpekar @jiayisuse @lw @beauby
|
module: bootcamp,triaged,module: rpc,module: tensorpipe
|
low
|
Minor
|
612,109,661 |
go
|
runtime: nmspinning's position in struct schedt
|
i think the nmspinning's position in struct schedt in runtime should be writen in the "m" part instead of "p" part
current is
```
midle muintptr // idle m's waiting for work
nmidle int32 // number of idle m's waiting for work
nmidlelocked int32 // number of locked m's waiting for work
mnext int64 // number of m's that have been created and next M ID
maxmcount int32 // maximum number of m's allowed (or die)
nmsys int32 // number of system m's not counted for deadlock
nmfreed int64 // cumulative number of freed m's
ngsys uint32 // number of system goroutines; updated atomically
pidle puintptr // idle p's
npidle uint32
nmspinning uint32 // See "Worker thread parking/unparking" comment in proc.go.
```
i think it should like this:
```
midle muintptr // idle m's waiting for work
nmidle int32 // number of idle m's waiting for work
nmidlelocked int32 // number of locked m's waiting for work
mnext int64 // number of m's that have been created and next M ID
maxmcount int32 // maximum number of m's allowed (or die)
nmsys int32 // number of system m's not counted for deadlock
nmfreed int64 // cumulative number of freed m's
nmspinning uint32 // See "Worker thread parking/unparking" comment in proc.go.
ngsys uint32 // number of system goroutines; updated atomically
pidle puintptr // idle p's
npidle uint32
```
|
NeedsInvestigation,compiler/runtime
|
low
|
Minor
|
612,119,054 |
opencv
|
Create Non-Transparent OpenCL API for better GPU / Accelerators utilization
|
I am sorry in advance if this isn't the right place for feature-requests / suggestions. This is an important issue though.
OpenCV contains the most extensive OpenCL implementations for computer vision algorithms. Many of them contain very well written kernels.
Yet, every time I take a look inside the OpenCV 'Transparent API' implementation I am horrified by the lack of basic efficiency with regard to properly utilizing the GPU.
For instance, OpenCV Canny performs at least 3 large and synchronous clBuffer allocations which totally stall the GPU pipeline and cannot be avoided by simply passing pre-allocated buffers for intermediate results.
Another example are algorithms which download results From GPU back to RAM even when it is not necessarily needed, thus stalling the GPU.
These kind of redundant memory allocations and memory transfers really goes against the whole **asynchronous** GPU programming paradigm. Which strives for saturating the GPU with the maximum amount of computation work.
On many occasions, the OpenCV CPU implementation easily outperform the GPU implementation simply because of the stated reasons.
I understand the rational behind the transparent API, but it seems like all the wonderful OpenCL kernels written are simply wasted.
What is needed is a **non-transparent API**, one that allows the client to pass his/her own buffers, invokes OpenCL kernels and let the user decide if and when to perform memory transfers.
This paradigm is implemented by libraries such as CLFFT and CLBlast.
|
category: ocl,RFC
|
low
|
Minor
|
612,152,633 |
vscode
|
Support /mnt WSL links in windows not using Remote WSL
|
<!-- β οΈβ οΈ Do Not Delete This! bug_report_template β οΈβ οΈ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.44.2
- OS Version: Windows 10 1909
Using a Windows terminal for the integrated terminal system such as Powershell lets you jump to places in code logged by errors by holding ctrl and clicking on the directory. However, using WSL, you can't do this because your Windows filesystem is mounted so it shows `/mnt/` before the directory. I think this can be fixed with some Regex and I would appreciate if it were fixed because I find the code jumping convenient.
|
help wanted,feature-request,windows,WSL,terminal-links
|
low
|
Critical
|
612,165,437 |
tensorflow
|
tf.io.gfile.listdir is inconsistent between GCS dir and local dir - adds trailing slashes
|
**System information**
- TensorFlow version (use command below): v2.0.0-rc2-26-g64c3d38 2.0.0
- Python version: 3.6
**Describe the current behavior**
When listing the directory items for a GCS dir, listdir returns names with trailing slashes.
When listing the directory items for a local dir, listdir returns names without trailing slashes.
**Describe the expected behavior**
The behavior needs to be consistent.
**Standalone code to reproduce the issue**
```
tensorflow.io.gfile.listdir('gs://bucket/dir')
>>> ['eval/', 'train/']
tensorflow.io.gfile.listdir('..')
>>> ['eval', 'train']
```
|
stat:awaiting tensorflower,type:bug,comp:ops,TF 2.7
|
medium
|
Major
|
612,180,921 |
youtube-dl
|
gigtv.com.au
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.05.03. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.05.03**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://webcast.gigtv.com.au/Mediasite/Showcase/vala2020/Presentation/46f03de9b50442788fc5fcc370534bee1d
## Description
Plays OK in Firefox, Safari, and Chrome on a Mac
|
site-support-request
|
low
|
Critical
|
612,190,178 |
rust
|
Better diagnostics when user forgets to wrap code in `main` function
|
```rust
// some_third_party_crate/lib.rs
mod some_third_party_crate {
pub fn show() {}
}
//////////////////////////////////////////
//////////////////////////////////////////
//////////////////////////////////////////
// main.rs
some_third_party_crate::show();
```
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=8fca04bfa35f22c6776578d6c9fd8fbc
<img width="608" alt="Screen Shot 2020-05-04 at 5 46 43 PM" src="https://user-images.githubusercontent.com/416575/81016859-3dd1fb00-8e2f-11ea-9abd-f84ba387d3d7.png">
We should suggest the user wrap their code in `fn main() { ... }`
|
C-enhancement,A-diagnostics,A-parser,T-compiler
|
low
|
Critical
|
612,207,254 |
kubernetes
|
DELETECOLLECTION doesn't always
|
**What happened**:
Deleting a large collection times out (504) and leaks a goroutine that's busy deleting the collection. Calling multiple times in a row makes it worse. There's no indication that apiserver is currently deleting the collection.
**What you expected to happen**:
a) Change delete collection so that it deletes just the first page of items in the collection, rather than loading the whole collection into memory. Callers must call repeatedly to delete the whole collection.
b) Change delete collection to use a single-flight approach, so that if you call delete collection while one is in progress, you join it rather than start a new one. (This actually doesn't work because there's multiple apiservers.)
**Environment**:
- Kubernetes version (use `kubectl version`): 1.14.x (but I don't think it matters)
/sig api-machinery
|
kind/bug,sig/api-machinery,lifecycle/frozen
|
medium
|
Critical
|
612,218,315 |
react
|
Add devtools "Inspect React component" to right-click menu
|
Noticed today that Vue's devtools have an awesome "Inspect Vue component" option when right-clicking on a webpage (added in https://github.com/vuejs/vue-devtools/pull/479).
The React devtools should have the same feature! It would be useful when debugging for sure.
|
Type: Feature Request,Component: Developer Tools
|
medium
|
Critical
|
612,254,273 |
opencv
|
Suggestion for creation of OpenCV technical notes
|
In my opinion, there should be some kind of OpenCV technical notes for certain important algorithms. The idea is to summarize in a document different things like implementation details, implementation choices, deviation from the original algorithm, performance or accuracy benchmarks.
Cons:
- can almost double the development time in order to develop proper benchmark, proper method to analyze the results
- can become obsolete quickly
- more work to do, time consuming, tedious
Pros:
- implementation details can be useful for some users
- better for the research community since it should avoid confusion between OpenCV implementation and original implementation, can be citable maybe?
---
Here some examples I have in mind:
### SIFT features
- 20 years later, it is the "revival" of SIFT features, it would be great to be able to summarize the performance and the accuracy of the OpenCV SIFT implementation with the newest future developments
- references could be the Lowe's SIFT binary and the [`vl_sift`](https://www.vlfeat.org/overview/sift.html) implementation
- from this recent paper ([Image Matching across Wide Baselines: From Paper to Practice](https://arxiv.org/abs/2003.01587)), it looks like the OpenCV SIFT implementation performs correctly
- probably the dataset and the methodology for a proper accuracy benchmark will be time consuming
### SURF features
- possible alternative to SIFT is SURF
- there is an [old benchmark page](https://boofcv.org/index.php?title=Performance:SURF) (2012) comparing the OpenCV SURF implementations with other libraries
- it performs badly, this is an old benchmark but a quick look to the [history](https://github.com/opencv/opencv_contrib/commits/master/modules/xfeatures2d/src/surf.cpp) shows not so much new
changes
- this means that benchmarks using the OpenCV SURF implementation could potentially overperform (since the OpenCV implementation has worse performance in term of accuracy compared to the SURF original implementation)
- lots of efforts are needed to check the implementation, improve it, so this is probably not soon this would happen
- there are also CUDA and OpenCL SURF implementations in OpenCV, ideally the three implementations should give the same results, so more work needed
### Harris corners detection
- in theory the Harris corners method should be rotation invariant
- an user stumbled about [this issue](https://stackoverflow.com/questions/59473193/harris-corner-detector-at-different-rotations) where the OpenCV implementation of the Harris corners is not rotation invariance
- here the reported issue
- the thing is that the OpenCV implementation deviates from the original method since it uses for instance box blur instead of Gaussian blur for performance reason, here a paper with some info about the OpenCV implementation: [An Analysis and Implementation of the Harris CornerDetector](https://www.ipol.im/pub/art/2018/229/)
- by tweaking the parameters in `goodFeaturesToTrack()` instead of retrieving manually the corners from the output of `cornerHarris()`, better results can be achieved. Here [the link](https://i.imgur.com/PNzow4P.mp4), left is result from [DIPlib](https://github.com/DIPlib/diplib), right is OpenCV
- for this kind of issue, it would have been great to have the implementation details of the OpenCV / IPP Harris corners detector summarizes somewhere
### AprilTag
- I like the AprilTag fiducial marker detector
- there is a [GSoC subject](https://github.com/opencv/opencv/wiki/GSoC_2020#idea-create-robust-visual-fiducial-tags) tackling this topic
- ideally, the OpenCV AprilTag implementation should give the exact same results than the original implementation
- here the [official repo](https://github.com/AprilRobotics/apriltag) for AprilTag 3 version described in this paper: [Flexible Layouts for Fiducial Tags](https://april.eecs.umich.edu/papers/details.php?name=krogius2019iros)
- in my opinion, if the OpenCV implementation deviates and gives poorer results than the original code, warning should be put in the documentation to warn the user that the results are inferior to the original code
- and ideally global performance and accuracy results should be documented somewhere
- I would also advice to avoid mixing ArUco and AprilTag methods in the code:
- there are already some differences between the OpenCV ArUco and the [author ArUco](https://www.uco.es/investiga/grupos/ava/node/26) latest development (Aruco 3)
- but I think most of the time the ArUco is mentioned, this is for the OpenCV implementation
- to avoid confusion, it would be better in my opinion to have something like a parent class for fiducial markers and implementation classes for ArUco and AprilTag methods
- from my experience, AprilTag 3 is better for detecting tags and gives more accurate tag corners locations than OpenCV ArUco
- for instance a quick test:
- this is AprilTag 3
- this is OpenCV ArUco with `DICT_6x6` and `refine=None`:
- this is OpenCV ArUco with `DICT_6x6` and `refine=Subpixel`:
- this is OpenCV ArUco with `DICT_6x6` and `refine=contour`:
- this is OpenCV ArUco with `DICT_6x6` and `refine=AprilTag 2`:
- this is a quick test, I did not try to tweak the ArUco parameters
- detection rate of AprilTag 3 should be a little bit better than OpenCV ArUco but accuracy in corners extraction should be definitively better with AprilTag 3
- no idea why changing the ArUco refine method gives different detection results, I am using `example_aruco_detect_markers` sample
### Pixel coordinates system
- for image resizing, warping and maybe some other operations, OpenCV treats coordinates using top-left pixel coordinates
- there are some info in the doc, but probably more details would be better in the doc since other libraries can use a different convention
- also using top-left coordinates should introduce shift, so for image analysis this is not desirable
- related issues: [9096](https://github.com/opencv/opencv/issues/9096#issuecomment-333673380), [10146](https://github.com/opencv/opencv/issues/10146), and maybe also [12680](https://github.com/opencv/opencv/issues/12680)
- with Deep Learning, I think I have read that different image resizing method can give notable difference?
---
For important new algorithms, new developments, these kind of implementation details or performance/accuracy benchmarks should be made available from the OpenCV doc. This can be simply in a Doxygen form or maybe even in pdf form for easy citation?
|
category: documentation,pr: Discussion Required
|
low
|
Major
|
612,299,734 |
go
|
net/http: drop support for any other TransferEncoding value than "chunked"
|
As of RFC 7230, "identity" is not a thing anymore, and we are probably off-spec for any other value. nginx only supports "chunked" anyway. There is a lot of code that can be removed or simplified in the sending path. (The parsing path is already being made strict as security hardening.)
However, we document setting TransferEncoding to "identity" as the way to affect some automatic chunking behavior, so we should probably still catch it at a shallow level, and behave accordingly, even if we don't send it on the wire.
|
NeedsFix
|
low
|
Minor
|
612,316,416 |
pytorch
|
Add Numpy-like "order" argument to reshape
|
## π Feature
<!-- A clear and concise description of the feature proposal -->
the reshape method should support Fortran-like order except for C-like order. e.g. wo could use a vecotr to fill a matrix in column order first, not just rows.
thx~~
## Motivation
<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
## Pitch
<!-- A clear and concise description of what you want to happen. -->
## Alternatives
<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->
## Additional context
<!-- Add any other context or screenshots about the feature request here. -->
cc @mruberry @rgommers @heitorschueroff
|
feature,triaged,module: numpy,has workaround
|
low
|
Minor
|
612,334,710 |
go
|
crypto/x509: stop looking at first root store
|
For some reason, when looking for a CA root store on UNIX we stop at the first good file, still look at directories, and not stop at the first good directory. On most systems the file, if it exists, is a bundling of the roots in the directory, and the directories are for different systems, not for combining.
We should probably make the function exit sooner.
|
NeedsFix
|
low
|
Minor
|
612,344,698 |
youtube-dl
|
Site support request for knowledge.ca
|
## Checklist
- [X] I'm reporting a new site support request
- [X] I've verified that I'm running youtube-dl version **2020.05.03**
- [X] I've checked that all provided URLs are alive and playable in a browser
- [X] I've checked that none of provided URLs violate any copyrights
- [X] I've searched the bugtracker for similar site support requests including closed ones
- Single video: https://www.knowledge.ca/program/canada-over-edge/s1/e1/best-nova-scotia
knowledge.ca has a bunch of exclusive content. The most awesome of which is the Canada Over The Edge series. HD video of Canada and all its beauty. The content is behind an account login.
Enjoy! And thanks! Love youtube-dl! :)
|
site-support-request
|
low
|
Critical
|
612,359,394 |
pytorch
|
DistributedDataParallel does not support Modules that take no inputs.
|
## π Bug
If you wrap a module that takes no input in DDP and try to call the forward pass, it fails with an IndexError. These kind of modules are useful to store re-parameterizations (ex: 2D -> SO(3)) that you want to update consistently across DDP workers without having to manually synchronize gradients.
## To Reproduce
```python
import os
import torch as th
from torch.nn.parallel import DistributedDataParallel
class Holder(th.nn.Module):
def __init__(self):
super().__init__()
self.x = th.nn.Parameter(th.zeros(3))
def forward(self):
return self.x
os.environ["MASTER_ADDR"] = "127.0.0.1"
os.environ["MASTER_PORT"] = "12345"
os.environ["WORLD_SIZE"] = "1"
th.distributed.init_process_group(
backend="nccl",
init_method="env://",
world_size=1,
rank=0,
)
holder = Holder().cuda()
holder = DistributedDataParallel(holder, device_ids=[0])
x = holder()
```
Result:
```
Traceback (most recent call last):
File "test.py", line 25, in <module>
x = holder()
File ".../torch/nn/modules/module.py", line 550, in __call__
result = self.forward(*input, **kwargs)
File ".../torch/nn/parallel/distributed.py", line 445, in forward
output = self.module(*inputs[0], **kwargs[0])
IndexError: tuple index out of range
```
## Expected behavior
No exception is raised.
## Environment
- PyTorch Version (e.g., 1.0): 1.5.0
- OS (e.g., Linux): Linux
- How you installed PyTorch (`conda`, `pip`, source): conda
- Python version: 3.7
- CUDA/cuDNN version: 10.1/7.6.5
- GPU models and configuration: v100
|
triaged,module: data parallel
|
low
|
Critical
|
612,372,148 |
kubernetes
|
CSI ephemeral volumes: idempotent NodeUnpublishVolume
|
<!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
During testing with PMEM-CSI, `NodeUnpublishVolume` was called twice by kubelet, presumably because the first call took too long (deleting volumes does take time). The second call blocked, waiting for the first to complete its work, and then returned `NOT_FOUND` because the first call had removed all information about the volume. That caused kubelet to keep calling `NodeUnpublishVolume` forever and the pod never got deleted.
**What you expected to happen**:
Returning `NOT_FOUND` is required by the CSI spec. The driver cannot know that the volume was ephemeral because it now longer has any information about it. The csi-driver-host-path does the same: https://github.com/kubernetes-csi/csi-driver-host-path/blob/941f7a8aa7b991c11293e806de80e6b6483d3d01/pkg/hostpath/nodeserver.go#L203-L206
Perhaps kubelet then needs to be changed and accept that `NOT_FOUND` indicates success? But doing that for persistent volumes would be a spec violation, too, so it has to be limited to ephemeral volumes.
/cc @jsafrane for suggestions...
**How to reproduce it (as minimally and precisely as possible)**:
We would have to artificially slow down `NodeUnpublishVolume` in a driver to trigger the error condition in kubelet.
/sig storage
|
kind/bug,sig/storage,lifecycle/frozen
|
low
|
Critical
|
612,383,341 |
go
|
crypto/tls: conflicting lock order in Handshake() and Read()
|
### What version of Go are you using (`go version`)?
1.14.2
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/boqin/.cache/go-build"
GOENV="/home/boqin/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/boqin/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/data/suz305/go-workspace/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/data/suz305/go-workspace/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build519488021=/tmp/go-build -gno-record-gcc-switches"
### What did you do?
I analyzed the source code crypto/tls/conn.go and found a possible conflicting lock order which may lead to deadlock.
If `Conn.Handshake()` and `Conn.Read()` are executed concurrently in two threads, then a deadlock may occur.
In crypto/tls/conn.go
```
type Conn struct {
...
handshakeMutex sync.Mutex
...
// input/output
in, out halfConn
}
```
```
type halfConn struct {
sync.Mutex
...
}
```
1. `Conn.handshakeMutex.Lock()` -> `Conn.in.Lock()`
In `Handshake()`: `Conn.handshakeMutex.Lock()` is on L1344. `Conn.in.Lock()` is on L1354
https://github.com/golang/go/blob/9b189686a53d7fec7deb93d7521531157aa023cb/src/crypto/tls/conn.go#L1343-L1355
2. `Conn.in.Lock()` -> `Conn.handshakeMutex.Lock()`
In `Read()`: `c.in.Lock() ` is on L1243. `handlePostHandshakeMessage()` is on L1251.
https://github.com/golang/go/blob/9b189686a53d7fec7deb93d7521531157aa023cb/src/crypto/tls/conn.go#L1233-L1251
Then `handleRenegotiation()` is on L1178.
https://github.com/golang/go/blob/9b189686a53d7fec7deb93d7521531157aa023cb/src/crypto/tls/conn.go#L1176-L1179
`Conn.handshakeMutex.Lock()` is on L1164
https://github.com/golang/go/blob/9b189686a53d7fec7deb93d7521531157aa023cb/src/crypto/tls/conn.go#L1164-L1172
### What did you expect to see?
--
### What did you see instead?
--
|
NeedsInvestigation
|
low
|
Critical
|
612,407,462 |
terminal
|
Display graphical images in terminal
|
<!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
It would be nice to have the ability to display graphical images in the terminal by using the API provided by the Windows Terminal. Maybe something similar to https://sw.kovidgoyal.net/kitty/kittens/icat.html or https://www.iterm2.com/documentation-images.html
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
|
Issue-Feature,Help Wanted,Area-TerminalControl,Product-Terminal
|
high
|
Critical
|
612,409,160 |
rust
|
Anchor names for some impls are not predictable
|
I have [a struct with a generic type](https://gitlab.com/sequoia-pgp/sequoia/-/blob/master/openpgp/src/cert/bundle.rs#L112):
```
struct ComponentBundle<C> {
component: C,
...
}
```
Then I have [implementations for different concrete types](https://gitlab.com/sequoia-pgp/sequoia/-/blob/master/openpgp/src/cert/bundle.rs#L628), e.g.,:
```
impl ComponentBundle<UserID> {
...
}
```
I want to link to the documentation for one of those implementations. But their anchors are called ["#method.revocation_status-1"](https://docs.sequoia-pgp.org/sequoia_openpgp/cert/amalgamation/struct.ComponentAmalgamation.html#method.revocation_status-1), ["#method.revocation_status-2"](https://docs.sequoia-pgp.org/sequoia_openpgp/cert/amalgamation/struct.ComponentAmalgamation.html#method.revocation_status-2), etc., which is brittle. It would be nice if the anchor names were more predictable.
|
T-rustdoc,C-bug
|
low
|
Major
|
612,485,367 |
godot
|
Creating a node and attaching a built-in script to it resets the names of built-in scripts with higher ID's (lower on the scene tree) than the newly created script/node.
|
**Godot version:**
3.2.1
**OS/device including version:**
Windows 10 Education Version 1909 Build 10.0.18363
**Issue description:**
When a built-in script gets created and saved above other nodes (on the scene tree) that have built-in scripts (on a freshly opened project?) their built-in script names get reset and their ID's get bumped up by one.
**Steps to reproduce:**
1. Create a new scene.
2. Add a root node.
3. Add three nodes as children to the root node.
4. Attach a built-in script to the third child of the root node. Name the script in the resource panel on the right and save.
5. Attach a built-in script to the second child of the root node. Name the script in the resource panel on the right and save.
6. Save and exit the editor.
7. Reopen the editor and reopen the scene and reopen the scripts in the editor.
9. Attach a built-in script to the first child of the root node.
10. Hit save and observe the scripts you named earlier get reset to no names and their ID's get bumped by one.
**Minimal reproduction project:**
[script-bug.zip](https://github.com/godotengine/godot/files/4580056/script-bug.zip)
|
bug,topic:editor
|
low
|
Critical
|
612,491,416 |
go
|
x/playground: exit code 2 is cached and returned for a valid program
|
### What version of Go are you using (`go version`)?
<pre>
$ go version
go1.14.2
</pre>
### Does this issue reproduce with the latest release?
Probably yes
### What operating system and processor architecture are you using (`go env`)?
`playground configurations`
### What did you do?
I changed the syntax of two programs(that are logically the same), by switching the order of the functions
- https://play.golang.org/p/ftthvh6ifYd
- https://play.golang.org/p/mn1PAI19xI6
### What did you expect to see?
I was expecting to see the same outputs
### What did you see instead?
The second program(from the above list) crashed
|
NeedsInvestigation
|
low
|
Critical
|
612,541,704 |
angular
|
Cannot parse slashes in unquoted attribute values
|
<!--π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
Oh hi there! π
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
-->
# π bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- βοΈedit: --> The issue is caused by package @angular/compiler.
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
<!-- βοΈ--> No.
### Description
Context: ikatyang/angular-html-parser#14, prettier/prettier#8210
According to the [HTML spec](https://html.spec.whatwg.org/#unquoted):
> The attribute name, followed by zero or more ASCII whitespace, followed by a single U+003D EQUALS SIGN character, followed by zero or more ASCII whitespace, followed by the attribute value, which, in addition to the requirements given above for attribute values, **must not contain any literal ASCII whitespace, any U+0022 QUOTATION MARK characters ("), U+0027 APOSTROPHE characters ('), U+003D EQUALS SIGN characters (=), U+003C LESS-THAN SIGN characters (<), U+003E GREATER-THAN SIGN characters (>), or U+0060 GRAVE ACCENT characters (`), and must not be the empty string.**
U+002F SLASH characters (/) are valid unquoted attribute values, but the parser treat them as end signals:
https://github.com/angular/angular/blob/42c58d9fe8e51931c465f779b3da64fe8551b8c4/packages/compiler/src/ml_parser/lexer.ts#L595-L599
https://github.com/angular/angular/blob/42c58d9fe8e51931c465f779b3da64fe8551b8c4/packages/compiler/src/ml_parser/lexer.ts#L761-L764
## π¬ Minimal Reproduction
```js
const {parseTemplate} = require("@angular/compiler");
const ast = parseTemplate("<a href=https://angular.io/>Link</a>");
console.log(ast.errors); //=> Unexpected closing tag "a".
```
## π₯ Exception or Error
_Unexpected closing tag "a". It may happen when the tag has already been closed by another tag. For more info see https://www.w3.org/TR/html5/syntax.html#closing-elements-that-have-implied-end-tags_
## π Your Environment
**Angular Version:**
```
@angular/[email protected]
```
**Anything else relevant?**
<!-- βοΈIs this a browser specific issue? If so, please specify the browser and version. -->
No.
<!-- βοΈDo any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
|
type: bug/fix,area: compiler,state: confirmed,P5,compiler: parser
|
low
|
Critical
|
612,644,116 |
godot
|
File.open() returns ERR_FILE_NOT_FOUND for png/wav/resource files in exported games
|
**Godot version:**
Godot Engine v3.2.1.stable.official
**OS/device including version:**
Windows 10
**Issue description:**
Opening files in windows returns `OK`, however in HTML5 it returns `ERR_FILE_NOT_FOUND`
**Steps to reproduce:**
Add this code to your scene
```
extends Node
func _ready() -> void:
var file: = File.new()
var ERROR = file.open("res://test.wav", File.READ)
file.close()
var file2: = File.new()
var ERROR2 = file2.open("res://test.png", File.READ)
file2.close()
var new_label = Label.new()
add_child(new_label)
new_label.text = "res://test.wav: " + str(ERROR) + "\nres://test.png: " + str(ERROR2)
```
make sure `res://test.wav` & `res://test.png` exists
Windows: `Error.OK = 0`
HTML5: `Error.ERR_FILE_NOT_FOUND = 7`
**Minimal reproduction project:**
[File Open .wav.zip](https://github.com/godotengine/godot/files/4581267/File.Open.wav.zip)
|
topic:editor,documentation,topic:import
|
low
|
Critical
|
612,652,500 |
PowerToys
|
[Image Resizer] Offer option to encode images to another format (image converter)
|
Hello,
I took a look at the image resizer feature and found it really interesting, but I was wondering if it could also encode to another format. There are times when you have a bunch of png images that you want to convert to png, to have a lighter file, with or without a resize of the image. I think it could be interesting to add this option. It could simply be a drop list added when you create a new format size, with encode to : [Keep format, png, jpg ...]
|
Idea-Enhancement,Help Wanted,Product-Image Resizer
|
high
|
Critical
|
612,677,058 |
svelte
|
Nested Transitions NOT Honored
|
I believe I have discovered an issue where Nested Transitions are not operating correctly.
**Component**:
I have a simple TreeView component ([see code here](https://svelte.dev/repl/82b00644720a4ca2bdb89c6a653ec987?version=3.22.2)).
- Each node in the tree is powered through a recursion on itself (via the `<svelte:self>` element).
- The expansion state of each node is retained _(through a simple ModuleScoped state)_, so collapsing a parent does not loose the expansion of it's children _(when the parent is re-expanded)_.
- The expansion/contraction of each node is animated through the standard `slide` svelte transition
**Issue**:
The **issue** I am seeing is when you expand a node that has pre-expanded children, the animated transition only occurs at the top-level. Once the top-level transition has completed, the expanded children pop out instantly. In other words, **the nested element transition is NOT honored**.
_To see this **issue**_:
1. expand all nodes in the sample (i.e. all children and grandchildren)
2. collapse the top-level `USA` node
3. re-expand the top-level `USA` node
**NOTICE** the direct `USA` children correctly animate, **however** the grandchildren pop out instantly, once their parent transition is complete.
_In contrast_, if you expand/collapse the tree one level at a time, the transition animation is correct.
Am I missing something obvious in my code, or is this in fact an issue?
**More Research**:
I have found references to this topic in older V2 Issues/PRs, however they are all closed/merged. **Is this issue thought to be fixed?**
- [MERGED PR 1451](https://github.com/sveltejs/svelte/pull/1451): Nested transitions #1451
- [MERGED PR 1448](https://github.com/sveltejs/svelte/pull/1448): add skipIntroByDefault compiler option #1448
- [CLOSED ISSUE 117](https://github.com/sveltejs/svelte-loader/issues/117): Support for svelte compiler 'cascade' option #117
- [CLOSED ISSUE 547](https://github.com/sveltejs/svelte/issues/547): Skip transitions on initial render #547
- [CLOSED ISSUE 1495](https://github.com/sveltejs/svelte/issues/1495): Nested components cause transitionManager to always be added if nestedTransitions: true #1495
- [CLOSED ISSUE 1492](https://github.com/sveltejs/svelte/issues/1492): outroing is not defined with nestedTransitions: true #1492
I realize that when dealing with multiple transitions, it can be difficult to generically determine the "right thing to do". This may be a case for driving some compiler directives from the component code itself ... thoughts?
Your help is greatly appreciated!
Thanks so much for such an awesome product, providing reactivity in an extremely simple form!!!
`</Kevin>`
|
bug,temp-stale
|
low
|
Major
|
612,696,996 |
TypeScript
|
Allow usage of `Reflect.get()` by returning `unknown` instead of `any`
|
## Search Terms
Reflect get unknown
## Suggestion
Change the type definition of `Reflect.get()` to return `unknown` instead of `any`.
## Use Cases
Allow type safe dynamic access of fields on an `object` or `{ [k: string}: unknown }`
Using `Reflect.get(o, 'some key')` and have it return `unknown`.
This allows usage of `Reflect.get()` in code bases where we do not want implicit any and where we have `@typescript-eslint` rules to ban unsafe usage of `any`.
## Examples
```js
/**
* @param {CustomError} cause
* @returns {{ [k: string]: unknown }}
*/
function getInfoForPlainError (cause) {
/** @type {{ [k: string]: unknown }} */
const info = {}
for (const field of PLAIN_ERROR_FIELDS) {
const v = reflectGet(cause, field)
if (typeof v !== 'undefined') {
info[field] = v
}
}
return info
}
```
## Checklist
My suggestion meets these guidelines:
* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Unfortunately changing a signature from `any` to `unknown` is a breaking change.
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
612,747,517 |
flutter
|
Web text layout benchmarks do too little work per measurement
|
Turns out the reason why the text benchmarks are severely affected (e.g. the color grid benchmark regresses by 20%) by enabling chrome://tracing is because they do too little amount of work per measurement. The solution might be to bundle text measurements (e.g. 1000 measurements per bundle) and report them all at once.
Details: https://bugs.chromium.org/p/chromium/issues/detail?id=1068259#c12
|
framework,c: performance,a: typography,platform-web,team: benchmark,P2,team-web,triaged-web
|
low
|
Critical
|
612,755,213 |
pytorch
|
[DRAFT] Channels Last + AMP support plan for 1.6 release
|
- [ ] Fix DDP
- [ ] Verify it works with TorchVIsion models
- [ ] Update/Verify pytorch/examples code
.
- [ ] AMP
- [ ] Update pytorch/examples code to support AMP and Channels Last
.
- [ ] Operators Coverage
- [ ] Automate operators coverage tests
- [ ] Publish operators conversion issue to tracker, extend documentation if necessary
.
- [ ] Add support fo permutations #32078
- [ ] Write in details behaviour of `contiguous()`, IPC, Serialization
- [ ] Hide code behind `#ifdef` guards
cc @VitalyFedyunin @jamesr66a
|
triaged,module: memory format
|
low
|
Minor
|
612,788,404 |
go
|
runtime/race: should 32-bit atomic ops be flagged as racing with 64-bit atomic ops?
|
(Broken out from https://github.com/golang/go/issues/5045#issuecomment-624210372.)
My instinct is that mixing 32-bit and 64-bit `atomic` ops on the same memory must not be allowed, because their implementations may differ on some 32-bit hardware. However, the race detector does not currently flag them.
For example, [this program](https://play.golang.org/p/sYUi-eo2_2e) exits without error when run with `go test -race` using `go version devel +9b189686 Tue May 5 05:13:26 2020 +0000 linux/amd64`:
```go
package main
import (
"fmt"
"runtime"
"sync/atomic"
"unsafe"
)
func main() {
var x uint64
xa := (*[2]uint32)(unsafe.Pointer(&x))
xl := &xa[0]
xh := &xa[1]
done := make(chan struct{})
go func() {
atomic.StoreUint64(&x, 0xbadc0ffee)
close(done)
}()
runtime.Gosched()
x0 := atomic.LoadUint32(xl)
x1 := atomic.LoadUint32(xh)
<-done
fmt.Printf("Stored %x; loaded %x.", *xa, [2]uint32{x0, x1})
}
```
CC @dvyukov @aclements @cherrymui
|
RaceDetector,NeedsInvestigation,compiler/runtime
|
low
|
Critical
|
612,792,962 |
flutter
|
[Test]: Golden Test Fails on CI(Same Platform)
|
## Steps to Reproduce
<!-- You must include full steps to reproduce so that we can reproduce the problem. -->
1. Run ``` flutter test --update-goldens``` on local machine
2. Run ```flutter test``` on CI machine
**Expected results:** <!-- what did you want to see? -->
Test should pass
**Actual results:** <!-- what did you see? -->
Test fails
IsolatedDiff
<details>
<summary>Logs</summary>
```
The following TestFailure object was thrown running a test:
Expected: one widget whose rasterized image matches golden image "goldens/welcome.png"
Actual: _WidgetTypeFinder:<exactly one widget with type "LocalizedLytApp" (ignoring offstage
widgets): LocalizedLytApp>
Which: Golden "goldens/welcome.png": Pixel test failed, 0.32% diff detected.
Failure feedback can be found at /Users/jenkins/vstsagent/_work/3/s/test/failures
When the exception was thrown, this was the stack:
#0 fail (package:test_api/src/frontend/expect.dart:154:30)
#1 _expect.<anonymous closure> (package:test_api/src/frontend/expect.dart:128:9)
#13 MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart)
<asynchronous suspension>
#14 MatchesGoldenFile.matchAsync.<anonymous closure> (package:flutter_test/src/_matchers_io.dart)
#15 AutomatedTestWidgetsFlutterBinding.runAsync.<anonymous closure> (package:flutter_test/src/binding.dart:921:22)
#18 AutomatedTestWidgetsFlutterBinding.runAsync (package:flutter_test/src/binding.dart:919:26)
#19 MatchesGoldenFile.matchAsync (package:flutter_test/src/_matchers_io.dart:72:20)
#20 _expect (package:test_api/src/frontend/expect.dart:117:26)
#21 expectLater (package:test_api/src/frontend/expect.dart:76:5)
#22 expectLater (package:flutter_test/src/widget_tester.dart:406:10)
#23 main.<anonymous closure>.<anonymous closure>.<anonymous closure> (file:///Users/jenkins/vstsagent/_work/3/s/test/widget_test.dart:43:15)
#34 FakeAsync.flushMicrotasks (package:fake_async/fake_async.dart:192:32)
#35 AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1102:19)
(elided 35 frames from dart:async, dart:async-patch, and package:stack_trace)
```
flutter doctor -v on CI machine
```
[β] Flutter (Channel master, 1.18.0-9.0.pre.123, on Mac OS X 10.15.4 19E287, locale en-DK)
β’ Flutter version 1.18.0-9.0.pre.123 at /Users/jenkins/vstsagent/_work/3/flutter
β’ Framework revision a48a51b0ff (56 minutes ago), 2020-05-05 09:54:21 -0700
β’ Engine revision 494a63c411
β’ Dart version 2.9.0 (build 2.9.0-3.0.dev cab69e7706)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /Users/jenkins/Library/Android/sdk
β’ Platform android-29, build-tools 28.0.3
β’ ANDROID_HOME = /Users/jenkins/Library/Android/sdk
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.4.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.4.1, Build version 11E503a
β’ CocoaPods version 1.9.1
[!] Android Studio (version 3.5)
β’ Android Studio at /Applications/Android Studio.app/Contents
β Flutter plugin not installed; this adds Flutter specific functionality.
β Dart plugin not installed; this adds Dart specific functionality.
β’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[β] VS Code (version 1.41.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.8.1
[!] Connected device
! No devices available
! Doctor found issues in 2 categories.
```
flutter doctor -v on local machine
```
[β] Flutter (Channel master, 1.18.0-9.0.pre.122, on Mac OS X 10.15.4 19E287,
locale en-DK)
β’ Flutter version 1.18.0-9.0.pre.122 at /Users/b044560/Development/flutter
β’ Framework revision 9a99403ad2 (15 hours ago), 2020-05-04 22:29:02 -0400
β’ Engine revision 95ecd9a405
β’ Dart version 2.9.0 (build 2.9.0-5.0.dev e7bebea059)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
β’ Android SDK at /Users/b044560/Library/Android/sdk
β’ Platform android-29, build-tools 29.0.2
β’ ANDROID_HOME = /Users/b044560/Library/Android/sdk
β’ Java binary at: /Applications/Android
Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.4.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.4.1, Build version 11E503a
β’ CocoaPods version 1.9.1
[β] Chrome - develop for the web
β’ Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[β] Android Studio (version 3.5)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 44.0.1
β’ Dart plugin version 191.8593
β’ Java version OpenJDK Runtime Environment (build
1.8.0_202-release-1483-b49-5587405)
[β] VS Code (version 1.44.2)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.10.1
[β] Connected device (3 available)
β’ Notaβs iPhone β’ 00008030-001470DE010A802E β’ ios β’ iOS 13.3.1
β’ Web Server β’ web-server β’ web-javascript β’ Flutter
Tools
β’ Chrome β’ chrome β’ web-javascript β’ Google
Chrome 81.0.4044.129
β’ No issues found!
```
</details>
|
a: tests,framework,platform-mac,P3,a: gamedev,customer: chilli,team-framework,triaged-framework
|
medium
|
Critical
|
612,797,840 |
godot
|
Camera2D seems to make tooltips appear far away from cursor.
|
**Godot version:** 3.2.1 Mono
**OS/device including version:** Windows 10 Home 64-bit
**Issue description:** Tooltips appear far away from cursor.
The Camera2D in the scene is a child of a Sprite node, and moves wherever it goes. Changing it's position and rebooting the game causes the tooltip to appear in a different position relative to the cursor. Tooltip may not appear if it's position is outside of the Camera2D's view.
**Steps to reproduce:**
Make a Camera2D a child of a Sprite.
Randomly generate TextureButtons (any type of graphical node would probably work) around the Sprite, and set their `HintTooltip` property to something.
Start the Game.
**Minimal reproduction project:**
[https://github.com/JDoe543/Tooltip_Bug_MCVE](https://github.com/JDoe543/Tooltip_Bug_MCVE)
|
bug,topic:gui,topic:2d
|
low
|
Critical
|
612,810,183 |
pytorch
|
llvmlite version issue when upgrading CI docker image to python 3.8
|
## Issue description
Found an issue when trying to upgrade all CI docker images to python 3.8.
1. Pytorch docker image install llvmlite 0.30.0 which does not support llvm9 under python 3.8, it needs llvm-config which is not available in llvm9.
2. Switching to llvmlite 0.31.0 (or 32) makes the docker image built, but the gcc-5 version is upgraded to 5.5 instead of 5.4. All CI tests that using gcc-5 currently assumes the version is 5.4, need to confirm 5.5 is fine with those tests if switching llvmlite version.
cc @ezyang @seemethere
|
module: ci,triaged
|
low
|
Minor
|
612,836,489 |
TypeScript
|
Add missing `toString` declarations for base types that have them
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
toString, RegExp, Regular Expression, Boolean, Error
## Suggestion
In @typescript-eslint, we have a rule `no-base-to-string`. This rule ensures that any value that's being coerced to a string has a `toString` method defined on it.
This is to help catch cases where you accidentally coerce something to a string, and end up with an `[object Object]` in your strings.
This rule has a pretty simple implementation - it just gets the declarations of the `toString` method on the type, and ensures that none of the declarations belong to the `Object` type.
The logic relies upon the fact that every type that actually has a `toString` method explicitly declares a `toString` method.
A few of our users ran into cases that were reporting errors for them, even though they shouldn't (https://github.com/typescript-eslint/typescript-eslint/issues/1655).
There's one that specifically has caused people some issues: `Boolean`/`boolean`.
I eyeballed the docs and the types, and I am pretty certain there are only 3 types that are missing a `toString` declaration:
- RegExp: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/toString
- Boolean: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Boolean/toString
- Error: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/toString
## Related
PR: #37839
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
medium
|
Critical
|
612,838,944 |
PowerToys
|
[FEATURE REQUEST] Ability to tile windows automatically
|
### The "Window-Tiling" PowerToy
Here's an idea, add the ability to tile windows automatically. What I mean by that is when a window would open, it'll cover the whole screen but when another window would open, it'll cover the half of the screen automatically and the first app would also resize to the half of the screen. If the third window opens it'll open below the second window, resizing the second window to half vertically. And the new window would take place under the second window.
It has been done before in some Linux window managers like "i3". And a lot of people really appreciate the ability to do that.
### Concept Shots
I've prepared some concept shots to show that:
In the image above, a single window is opened. When the user wants open another window, they would need to click the start button or hit the start key on the keyboard. The Start Menu would be replaced with Power Run. The user would be able to select the desired app by typing it's name and selecting one of the results by using the arrow keys. Or just type the name and hit enter
And when more than two apps are opened:
And when more than three apps are opened, the third app would be resized to half of it's size and the fourth window would appear in the empty space created by the third app.
There are better explanations of tiling window managers (than what I've done here) online
### Conclusion
The window tiling feature is inspired by some window managers in Linux (like i3). I think it'll help with productivity stuff. I've posted these concept shots on Twitter and many people wanted this feature to be in PowerToys. Maybe integrate it in FancyZones by adding a toggle for this feature. What do you think? :)
|
Idea-Enhancement,Product-Window Manager,Product-FancyZones
|
high
|
Critical
|
612,838,970 |
pytorch
|
autograd engine callbacks don't respect non-default cuda streams
|
## π Bug
Not sure if this is actually a bug, but discovered this when debugging https://github.com/pytorch/pytorch/issues/37790. It seems that callbacks added to the autograd engine with `queue_callback` (from C++) or `Variable._execution_engine.queue_callback` (Python) don't respect the current cuda stream and instead execute on the default stream. As a result any cuda kernels executed in the callback would not be placed on the non-default stream.
I don't have too much context, but it looks like support for non-default streams was added in https://github.com/pytorch/pytorch/pull/8354, although it doesn't appear that this support was added for the callbacks.
## To Reproduce
Patch the test in `test_cuda` in this PR: https://github.com/pytorch/pytorch/pull/37858. This test essentially enqueues a callback into the autograd engine that checks if the current stream is equal to the default stream. In `backward()` in that test, the current stream is NOT the default stream, as expected, however, in the callback, this does not hold true.
## Expected behavior
The non-default stream should be respected. Not sure if the autograd callbacks should support this natively or if it the user's responsibility to ensure the callbacks are executed on the non-default cuda stream.
## Environment
Latest master
cc @ezyang @SsnL @albanD @zou3519 @gqchen @ngimel
|
module: autograd,module: cuda,triaged
|
low
|
Critical
|
612,841,977 |
pytorch
|
Deprecate type() and type_as() call
|
- Move it to an internal API
- Replace it with either `dtype/device` or the internal API
|
triaged,module: deprecation,module: ux
|
low
|
Minor
|
612,877,956 |
go
|
cmd/go: optimize CGO caching and dead code removal
|
I'm writing this with the assumption that each CGO-generated wrapper for each C function is stored in its own C file.
Editing and compiling a CGO package can take a minute or 2, even for one little change.
It should be possible to cache the generated .o files and only recompile them if the code for that function changes.
When linking the CGO wrappers, Go should avoid linking unused wrappers to reduce size.
|
NeedsInvestigation,GoCommand
|
low
|
Major
|
612,880,811 |
flutter
|
It is difficult to properly style a DropdownButton for both Dark and Light modes
|
Dartpad: https://dartpad.dev/a7b8353fb0ba259741aab0bd4c34dffd
See, e.g. the Cocoon dashboard page.
When the drop down overlay is not up, the text is rendered on a transparent dropdown that shows the background color. It would ideally look white in that situation.
When the popup shows, in dark mode black text is illegible, and in light mode white text is illegible.
I'm not 100% sure if these are separate issues or not, but what I'm seeing is:
- There's no way to set the text color differently when the popup is showing or not currently
- The logic that draws the text does not seem to differentiate between light and dark modes when drawing the popup.
- If you let the theme completely handle the styling, the text is hard to read in light mode when the menu is not dropped down.
|
framework,f: material design,a: typography,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-design,triaged-design
|
low
|
Major
|
612,898,847 |
flutter
|
Support discovery of arbitrary Flutter instances
|
### Background
Flutter is easily embeddable in a variety of platforms and environments. While the tool will still build out first class support for several platforms, there are a growing number of alternatives being developed as well. Ideally a developer that targets an alternative embedding would be able to benefit from as much of the existing flutter tooling as possible. This would both improve the usability of Flutter in different environments, and make it easier to stand-up new environment's tooling.
Originally this was proposed via a Dart API in the flutter tool. I investigated this approach in 2019 and found that problem had a much larger scope than we had resources to work on. It required defining and stabilizing APIs for building, installation, and doctor checks, which would be both difficult the design given the lack of current usage and difficult to change in the future if usage increased. Without ruling out this approach in the future, there are some incremental steps we could take to improve usability.
### Arbitrary embedder discovery
`flutter attach` _almost_ supports discovery of arbitrary embedders, and with a few adjustments could become generally usable for this.
Using mDNS, the tool can discover Dart VMs running on iOS devices, but there is no reason we could not generalize this to more platforms. The requirement for the embedder side would be to either advertise via the Dart VM automatically, or otherwise manually implement some variety of debug-only broadcast.
caveat: There were issues getting mDNS to work on Android devices, so this may be limited in other ways we're not aware of. FYI @dnfield
The tool could then easily attach to these instances and support feature discovery to determine build mode and dart platform (dart v fuchsia)
### IDE integration
Currently Intellij and vscode have a drop-down selector for devices that can be targeted for flutter run. We could similarly implement an "instance dropdown" for Android, iOS, and other instances that could be attached to.
|
c: new feature,tool,P3,team-tool,triaged-tool
|
low
|
Critical
|
612,902,025 |
pytorch
|
[RFC] Don't install CI dependencies in build scripts, install them in underlying docker images
|
## Motivation
<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
Our build scripts do a lot to install multiple dependencies which makes debugging incredibly difficult and makes our docker images harder to manage and update since you have to circle through multiple shell scripts to find the place where dependencies are actually installed and managed.
## Pitch
<!-- A clear and concise description of what you want to happen. -->
I'd like to remove all dependency installation from our CI build scripts and instead move them to their respective Dockerfiles.
For example:
* https://github.com/pytorch/pytorch/blob/master/.jenkins/pytorch/build.sh#L17-L33
* https://github.com/pytorch/pytorch/blob/master/.jenkins/pytorch/build.sh#L68-L79
* https://github.com/pytorch/pytorch/blob/master/.jenkins/pytorch/build.sh#L253-L271
cc @ezyang @seemethere @malfet
|
module: ci,triaged
|
low
|
Critical
|
612,905,834 |
pytorch
|
Support @property decorator in TorchScript
|
## π Feature
Currently, trying to use a `@property`-decorated method in TorchScript results in the following error:
```
(This attribute exists on the Python module, but it's an @property method. @property methods are not yet supported in TorchScript. Please file a feature request on Github):
```
It would be useful to support `@property` decorated methods in TorchScript rather than throwing the error.
## Motivation
<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
When implementing a `nn.Module`, it is useful to be able to distinguish between publicly-accessible instance variables and internal instance variables. Using the `@property` decorator is a useful way to distinguish between the two.
## Pitch
<!-- A clear and concise description of what you want to happen. -->
Support the `@property` decorator for methods called within TorchScript. For example:
```
import torch
from torch import nn
class Foo(nn.Module):
def __init__(self, bar: int):
super().__init__()
self._bar = bar
@property
def bar(self) -> int:
return self._bar
def forward(self, input: torch.Tensor) -> torch.Tensor:
return input + self.bar
foo = Foo(3)
torch.jit.script(foo)
```
Currently, running the above returns the following error:
```
RuntimeError:
Module 'Foo' has no attribute 'bar'
(This attribute exists on the Python module, but it's an @property method. @property methods are not yet supported in TorchScript. Please file a feature request on Github):
File "<ipython-input-7-5327862aa311>", line 14
def forward(self, input: torch.Tensor) -> torch.Tensor:
return input + self.bar
~~~~~~~~ <--- HERE
```
Adding support for `@property` methods would fix this error when calling `torch.jit.script`.
## Alternatives
<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->
Several alternatives are:
1. Avoid using the `@decorator` methods in any scripted methods, and use the internal variables (e.g. `self._bar` here) instead. However, this is poor practice when other classes / modules want to access the `@decorator` instance variable, since we are bypassing the `@decorator` public API.
2. Use instance variables instead of `@decorator` methods (e.g. `self.bar = bar` in the `__init__()` function above).
I am currently using alternative 1, but am running into issues where I need to access the internal instance variables, where I would like to use the `@decorator` public method.
## Additional context
<!-- Add any other context or screenshots about the feature request here. -->
N/A
cc @suo
|
triage review,oncall: jit
|
low
|
Critical
|
612,935,678 |
three.js
|
VolumeShader is said to "not work very well with perspective yet"
|
https://github.com/mrdoob/three.js/blob/dev/examples/webgl2_materials_texture3d.html#L53 has a cautionary comment `// Create camera (The volume renderer does not work very well with perspective yet)`.
This seemed worth an issue. Perhaps VolumeShader can be improved? Perhaps we need a second shader, which works well with perspective? Perhaps the caution is no longer true, can be removed to avoid confusion, and the example reverted to using perspective (to turn up any remaining problems)?
The example switched from PerspectiveCamera to OrthographicCamera in https://github.com/mrdoob/three.js/commit/5ab8129d92e249119f542a362657a1103c55f9df . VolumeShader is https://github.com/mrdoob/three.js/blob/dev/examples/jsm/shaders/VolumeShader.js .
Thank you for your work.
@Mugen87 @takahirox @almarklein
|
Addons
|
low
|
Minor
|
612,973,606 |
pytorch
|
torch.addmv can't take as input tensors with different dtypes
|
Is this expected?
```
>>> vec = torch.randn(3, dtype=torch.half)
>>> M = torch.randn(2, dtype=torch.float)
>>> mat = torch.randn(2, 3, dtype=torch.float)
>>> torch.addmv(M, mat, vec)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
RuntimeError: expected scalar type Float but found Half
```
Note: jax supports this behavior
>>> import jax.numpy as np
>>> a = np.array([[1, 0], [2j,3j]])
/data/users/chourdiaanjali/miniconda3/envs/myenv2/lib/python3.6/site-packages/jax/lib/xla_bridge.py:116: UserWarning: No GPU/TPU found, falling back to CPU.
warnings.warn('No GPU/TPU found, falling back to CPU.')
>>> b = np.array([1, 2])
>>> np.matmul(a, b)
DeviceArray([1.+0.j, 0.+8.j], dtype=complex64)
cc. @nairbv
|
triaged,module: type promotion
|
low
|
Critical
|
612,984,317 |
flutter
|
Cross-Compiling Engine for Linux doesn't build Unit Test Cases
|
When cross-compiling Engine for Linux (86c0c54bef50b4e02e8f98bcd913e0293f82f7bf), relavent Unit Test Cases are not being generated.
|
a: tests,engine,platform-linux,P2,team-engine,triaged-engine
|
low
|
Minor
|
612,988,933 |
svelte
|
Mutating spring store values sets the values instantly
|
https://svelte.dev/repl/888343d074354aff99bde5bbee55b68d?version=3.22.2
Using the `$store.key = value` syntax with springs sets the values instantly when two keys are changed in the same frame
Should be fixed with #4742
|
stale-bot,temp-stale
|
low
|
Minor
|
613,009,406 |
TypeScript
|
Incremental type checking failure (regression)
|
**TypeScript Version:** 3.7.x-dev.20200505
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
1. clone https://github.com/falsandtru/typed-dom
2. npm i
3. open src/builder.ts (no error)
4. remove the closing parenthesis of `API(html, shadow)`
5. redo
6. error
```
Argument of type 'Factory<HTMLElementTagNameMap>' is not assignable to parameter of type 'Factory<ShadowHostElementTagNameMap>'.
Property ''custom-tag'' is missing in type 'HTMLElementTagNameMap' but required in type 'ShadowHostElementTagNameMap'.ts(2345)
```
**Expected behavior:**
no error
**Actual behavior:**
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
|
Needs Investigation
|
low
|
Critical
|
613,016,686 |
neovim
|
many char support for listchars's space.
|
<!-- Before reporting: search existing issues and check the FAQ. -->
- `nvim --version`:0.4.3
- `vim -u DEFAULTS` (version: ) behaves differently? no
- Operating system/version: Winodow10
- Terminal name/version:
- `$TERM`:
### Steps to reproduce using `nvim -u NORC`
```
nvim -u NORC
```
### Actual behaviour
- I want to use some char to show listchars's space
- this i try the char
- `β` <span style="color:green">ok</span>
- `βΏ°` <span style="color:red">no</span>
- `β` <span style="color:green">ok</span>
- `Β¦` <span style="color:green">ok</span>
- `κ` <span style="color:green;">ok</span>
- `ΙΈ` <span style="color:green">ok</span>
- `β` <span style="color:green">ok</span>
- `|` <span style="color:red">no</span>
- `\` <span style="color:green">ok</span>
...
### Expected behaviour
- i want to see to many char support for listchars's space.
|
enhancement,display
|
low
|
Minor
|
613,027,991 |
go
|
cmd/compile: package-scope and function-scope types get the same name
|
This programs shows that we can get two different types with the same name. This is permitted by the reflect package, but it seems unnecessarily confusing. Should the compiler generate different names for these types?
```Go
package main
import (
"fmt"
"reflect"
)
type myint64 int64
func main() {
var i1 myint64 = 100
fmt.Printf("%T: %v\n", i1, i1)
t1 := reflect.TypeOf(i1)
type myint64 int32
var i3 myint64 = 100
fmt.Printf("%T: %v\n", i3, i3)
t2 := reflect.TypeOf(i3)
fmt.Printf("t1: %v %v\n", t1.Kind(), t1.String())
fmt.Printf("t2: %v %v\n", t2.Kind(), t2.String())
fmt.Println(t1 == t2)
}
```
Output:
```
main.myint64: 100
main.myint64: 100
t1: int64 main.myint64
t2: int32 main.myint64
false
```
|
NeedsInvestigation,compiler/runtime
|
low
|
Major
|
613,054,104 |
youtube-dl
|
Request support for altcensored.com (same format as YT, it hosts deleted channels)
|
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.05.03. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.05.03**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.altcensored.com/watch?v=YP0-ibk2MBQ
- Single https://www.altcensored.com/watch?v=6pt8nriWCIQ
- Playlist: https://www.altcensored.com/channel/UCAhmDfQ1LfOYECmNNWgXJ7Q
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
AltCensored hosts mirrors of controversial/deleted youtube channels. They mimic YT url formats.
|
site-support-request
|
low
|
Critical
|
613,072,249 |
create-react-app
|
Question: should we use `allowSyntheticDefaultImports:true` or `skipLibCheck:true` in every React project?
|
There are currently two ways of writing in the community:
In [TypeScript Documentation](https://www.typescriptlang.org/v2/docs/handbook/react-&-webpack.html#write-some-code) it write:
```ts
import * as React from "react";
```
and in CRA:
https://github.com/facebook/create-react-app/blob/9123aae7a3beaba8b245f73eb0180baa7b2f8411/packages/cra-template-typescript/template/src/index.tsx#L1
---
For users of a library, both usages are allowed. Because CRA has enabled `allowSyntheticDefaultImports` and `skipLibCheck`.
https://github.com/facebook/create-react-app/blob/30fc0bf5ed566d9b42194d56541d278013d7928c/packages/react-scripts/scripts/utils/verifyTypeScriptSetup.js#L104-L106
---
But for users of the library, the problem arises:
If I write a library using`import React from 'react';`.
Then downstream users must enable `allowSyntheticDefaultImports` or `skipLibCheck`, otherwise they will not be able to use this library in Typescript.
For users who configure webpack and tsconfig themselves, it is common to turn off `allowSyntheticDefaultImports` and `skipLibCheck`(default behavior).
---
Question: Which of the following two methods is more recommended?
* Force each project to force skipLibCheck.
* Force each project to force enableSyntheticDefaultImports.
* We should recommend the author of the library to use `import * as React from 'react';`, but not restrict library users to use `import * as React from 'react';` or `import React from 'react';`
Whichever method we choose, we should specify this behavior in the react / create-react-app / TypeScript documentation website, and we should have some more detailed suggestions for the react library authors and react library users.
---
related issues:
* https://github.com/facebook/create-react-app/issues/7586
* https://github.com/facebook/react/issues/11503
@ianschmitz @gaearon @RyanCavanaugh @DanielRosenwasser @orta
|
issue: proposal,needs triage
|
low
|
Major
|
613,126,977 |
godot
|
Mouse Key is ignored when used as Shortcut in Button
|
**Godot version:**
Godot 3.2.1
**OS/device including version:**
WIndows 10
**Issue description:**
Mouse Key that registered on input map is ignored when used as Button's Shortcut.
**Steps to reproduce:**
1. Add Mouse Button to Input Map, in this reproduction project I added it to ui_cancel
2. Create a Button and Add an InputEventAction as its Shortcut and type the action that have the Mouse Button in step 1 (in this repro I used ui_cancel)
3. Play the scene.
4. The Button will respond to all Keys in the ui_cancel Input Map except the mouse button.
**Minimal reproduction project:**
[Bug-MouseKeyIgnoredOnShortcut.zip](https://github.com/godotengine/godot/files/4585475/Bug-MouseKeyIgnoredOnShortcut.zip)
|
bug,confirmed,topic:input,topic:gui
|
low
|
Critical
|
613,197,671 |
vscode
|
[semantic] proposals for new standard semantic token types
|
The new semantic token provider API comes with a list of standard token types and modifiers.
https://code.visualstudio.com/api/language-extensions/semantic-highlight-guide#semantic-token-classification
These type serve as a base across languages and by having all/most providers using theme will make easier to write theming rules across languages.
That said, semantic token providers are not forced to stick to the standard, but can add new types/modifiers, or extend existing types as seen in the doc.
This issue is to collect proposals for new types and modifiers. When making a suggestion, please add a description and a small code sample. If it exists, name the corresponding TextMate scope.
The standard token types should be be applicable across multiple languages and be useful for theming. We want to keep the set of standard tokens consistent and coherent.
Proposed types:
| Identifier (extends) | Description | Ref | Sample | TextMate scope |
| ------------- |:-------------:| -----:| -----:| -----:|
| importKeyword (keyword) | keywords related to imports/includes | (1) | __import__ * from x | |
| modifierKeyword (keyword) | keywords describing a modifier | (1) | __private__ void foo(); | |
| docComment (comment) | documentation comments | #96712 | /** */ | |
Proposed modifiers:
| Identifier | Description | Ref | Sample |
| ------------- |:-------------:| -----:| -----:|
| unused | annotated all unused symbols | (2) | let __unusedVariable__; |
References:
(1) https://github.com/microsoft/language-server-protocol/issues/968
(2) https://github.com/microsoft/vscode-languageserver-node/issues/604
|
feature-request,semantic-tokens
|
medium
|
Critical
|
613,199,848 |
flutter
|
[google_maps_flutter] controller.getLatLng() returns randomly "LatLng(-90.0, -180.0)" inside onMapCreated
|
<!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
1. Run a flutter app with `google_maps_flutter:` as a dependency
2. Render a GoogleMap widget:
`GoogleMap(
mapType: MapType.normal,
initialCameraPosition: _deviceLocation,
onMapCreated: _mapCreatedHandler,
),`
3. Try to get latitude and longitude based on the screen coordinates
`void _mapCreatedHandler(GoogleMapController controller) {
controller.getLatLng(
ScreenCoordinate(
x: 0,
y: 0,
).then((coordinates) => print(coordinates));
}`
**Expected results:** Should always return the map coordinates needed
**Actual results:** Returns sometimes `LatLng(-90.0, -180.0)`, some other times the actual coordinates and completely random, I don't know is it's related to the fact that getLatLng() is an asynchronous function.
<details>
<summary>Logs</summary>
`No issues found! (ran in 5.0s)`
```
`[β] Flutter (Channel dev, v1.18.0-8.0.pre, on Mac OS X 10.15.4 19E287, locale en-AR)
β’ Flutter version 1.18.0-8.0.pre at /Users/magax/Documents/dev/Flutter/tools/flutter
β’ Framework revision e0c63cd35e (12 days ago), 2020-04-23 22:29:01 -0400
β’ Engine revision d2ec21221e
β’ Dart version 2.9.0 (build 2.9.0-3.0.dev b0d35855d8)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.3)
β’ Android SDK at /Users/magax/Library/Android/sdk
β’ Platform android-29, build-tools 29.0.3
β’ ANDROID_HOME = /Users/magax/Library/Android/sdk
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
β’ All Android licenses accepted.
[β] Xcode - develop for iOS and macOS (Xcode 11.4.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 11.4.1, Build version 11E503a
β’ CocoaPods version 1.9.1
[β] Android Studio (version 3.6)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 44.0.2
β’ Dart plugin version 192.7761
β’ Java version OpenJDK Runtime Environment (build 1.8.0_212-release-1586-b4-5784211)
[β] VS Code (version 1.44.2)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 3.9.1
[β] Connected device (1 available)
β’ Magaxβs iPhone β’ cd482d10f1eef699e7dxea7d962a7126c19aa24c β’ ios β’ iOS 13.4`
```
```
```
</details>
|
platform-ios,p: maps,package,has reproducible steps,P2,found in release: 1.21,found in release: 2.0,found in release: 2.3,team-ios,triaged-ios
|
low
|
Critical
|
613,286,990 |
TypeScript
|
TS2345 when calling a superclass' method with a conditional type parameter from a parameterized subclass
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.3 & 4.0.0-dev.20200506
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** TS2345 generic constructor super superclass method type parameter inheritance conditional type constraint
**Code**
```ts
type FilterKeysOf<T, Condition> = { [K in keyof T]: T[K] extends Condition ? K : never }[keyof T];
type ArrayKeysOf<T> = FilterKeysOf<T, readonly unknown[]>;
interface I {
foo: string;
bar: string[];
baz: number;
}
interface J extends I {
qux: boolean[];
}
class A<T extends I> {
protected treasure: T
constructor(treasure: T) {
this.treasure = treasure;
}
getArrayTreasure<K extends ArrayKeysOf<T>>(fieldName: K): T[K] {
return this.treasure[fieldName];
}
}
class B<T extends J> extends A<T> {
getQuxArrayTreasure(): boolean[] {
return super.getArrayTreasure('qux');
}
}
class C extends B<J> {
anyQux(): boolean {
return super.getArrayTreasure('qux').some(Boolean);
}
}
```
**Expected behavior:**
Compiles without errors.
**Actual behavior:**
TS v3.8.3:
```
foo.ts:25:35 - error TS2345: Argument of type '"qux"' is not assignable to parameter of type 'T[keyof T] extends readonly unknown[] ? keyof T : never'.
25 return super.getArrayTreasure('qux');
~~~~~
Found 1 error.
```
TS v4.0.0-dev.20200506:
```
foo.ts:25:5 - error TS2322: Type 'T[{ [K in keyof T]: T[K] extends readonly unknown[] ? K : never; }[keyof T]]' is not assignable to type 'boolean[]'.
Type 'T[T[keyof T] extends readonly unknown[] ? keyof T : never]' is not assignable to type 'boolean[]'.
Type 'T[keyof T]' is not assignable to type 'boolean[]'.
Type 'T[string] | T[number] | T[symbol]' is not assignable to type 'boolean[]'.
Type 'T[string]' is not assignable to type 'boolean[]'.
25 return super.getArrayTreasure('qux');
foo.ts:25:35 - error TS2345: Argument of type '"qux"' is not assignable to parameter of type 'T[keyof T] extends readonly unknown[] ? keyof T : never'.
25 return super.getArrayTreasure('qux');
~~~~~
Found 2 errors.
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
[Link](https://www.typescriptlang.org/play/?module=1&ssl=1&ssc=1&pln=38&pc=1#code/C4TwDgpgBAYglgG2BATgaQiAzgeQGYA8AKgDRQDCA9gHYAmcwcNAfFALxQDeUA2mlHGpQA1pkp4oRALoAuSXylQIAD2R0sFGvUY0oAfij851CADdUUAL49RIcZKkBuAFDPQkKAEEUKAIYgMbHxiVg54JFRA3EJSKBQIX1oaBBAoAFdqYWpKAHdqHilmF2dBZBQ8XwBjaABJLmcoKDxKSjksYBRBAHMXRoAjXxQ2ju6C3qgBgC9jNIBbPtQXS1dS1ArqqAApJVUIdSg6zgaoAEc05Tk+loQE-KdnZedKhF8sDU9iHbVaDRrWI8aYBQlGQlWQtCgHQSWDS8TkRFcjUqNHaKDSYMoKAAFFDXrCIPCAJT1RqNYAACzgWAAdLiYfF2JD4nj4uNHo0uhBgN4-CAiMz6RACPwVN93j5-FFgkRmMwsXg4BAELQAHK+WYEwyE+EKEmk+LAWFCClU2kC-E8BVK1XqiD3RrLR7PV4aABCn1Fex+W1Ynv2Hxles5wAAiucef5+dD8VjtRNrrcCnrGgajVAYZAUNTgxG+eb4liAORnZSFwlsh6uZ1vChfL1ugibf7HXzUEBh5Sxy4J1vJuJctMZ1DZrm5qMsiBFktl6lYSgarGunvUcvHR3OIA)
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
|
Bug
|
low
|
Critical
|
613,300,177 |
godot
|
If you modify an exported script variable it shows it as modified even if you return the variable to its original value.
|
**Godot version:**
3.2.stable.official
**OS/device including version:**
Windows 10 - 1909
**Issue description:**
The exported variable will appear as if it is modified even if you manually set it to the original value it was exported as.
**Steps to reproduce:**
Export a variable, modify it, and put it back to the original value.
**Minimal reproduction project:**
N/A
This is incredibly low priority but hopefully I'm still posting it in the correct location.
|
bug,topic:editor,usability
|
low
|
Minor
|
613,306,324 |
godot
|
Popupmenu 'items' property is an array that stores a weirdly complex pattern of objects.
|
**Godot version:**
3.2.stable.official
**OS/device including version:**
Windows 10 - 1909
**Issue description:**
If you want to reorder a PopupMenu's elements you need to modify an oddly complex array of objects manually. It seems strange that rather than being stored in a dictionary, these elements are just appended to the end of the array.
e.g.
[Open, [Object:null], 0, False, False, 0, 0, Null, , False,
Save, [Object:null], 0, False, False, 0, 0, Null, , False,
Save As, [Object:null], 0, False, False, 0, 0, Null, , False]
**Steps to reproduce:**
Access the .items property of a PopupMenu and you will see what I mean by the ordering being weirdly complex.
**Minimal reproduction project:**
N/A
**Suggestion:**
Perhaps document the items property and turn items into dictionaries that are stored in an array instead of appending each new item's properties onto the end of a single array.
|
discussion,topic:gui
|
low
|
Minor
|
613,428,667 |
terminal
|
Session text is invisible when Windows is set to "HDR mode".
|
<!--
π¨π¨π¨π¨π¨π¨π¨π¨π¨π¨
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
<!--
This bug tracker is monitored by Windows Terminal development team and other technical folks.
**Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**.
Instead, send dumps/traces to [email protected], referencing this GitHub issue.
If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link.
Please use this form and describe your issue, concisely but precisely, with as much detail as possible.
-->
# Environment
```none
Windows build number: 10.0.18363.0
Windows Terminal version (if applicable): 0.11.1191.0
Any other software?
```
# Steps to reproduce
Start Menu
Settings
System
Display
Play HDR games and apps - Set this to ON.
# Expected behavior
That text in the Windows Terminal would be visible as it is in "SDR mode".
# Actual behavior
All text regardless of session type (pwsh, Powershell, cmd, etc.) or ANSI codes is invisible (it has the same color as the terminal session background).
|
Help Wanted,Area-Rendering,Issue-Bug,Product-Terminal,Priority-2
|
low
|
Critical
|
613,449,424 |
electron
|
Specify the resources path
|
### Preflight Checklist
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
The `resources` directory is hard coded to be next the exec-path.
In some cases, we would like to locate it in a different dir.
For example, the main code could be in Program Files, but the resources in UserData,
so it would be easy to update the resources app.asar file without patching files in Program Files.
### Proposed Solution
Changing the code https://github.com/electron/electron/blob/979c291847f7aff333249dbe773b63f2b2059621/shell/common/node_bindings.cc#L257-L267 to be able to configure the resources dir during compilation-time or through flags/environment-variables that are passed to the executable.
### Alternatives Considered
Replacing the resources dir with a symlink.
|
enhancement :sparkles:
|
low
|
Minor
|
613,465,403 |
flutter
|
WipError: WipError 4: {code: -32000, message: Cannot find context with specified id}
|
From `run -d chrome` from crash logging. No back trace =(
@jonahwilliams
|
c: crash,tool,platform-web,P2,team-web,triaged-web
|
low
|
Critical
|
613,466,522 |
PowerToys
|
[KBM] UI needs to respond to PT Settings Theme
|
Currently UI only changes from light to dark mode in accordance with a users Windows settings.
|
Product-Keyboard Shortcut Manager,Area-User Interface,Priority-3
|
low
|
Major
|
613,467,211 |
flutter
|
plutil FormatException during `flutter create .`
|
Seen in `master/1.18.0-9.0.pre.98`
We're possibly passing a flag the user's version of plutil doesn't like and not checking the exit code.
```
FormatException: Unexpected character (at character 1)
Usage: plutil -i|--infile FILE [-o|--outfile FILE] [-d|--debug]
^
Β | atΒ _ChunkedJsonParser.fail | (convert_patch.dart:1394 )
Β | atΒ _ChunkedJsonParser.parseNumber | (convert_patch.dart:1261 )
Β | atΒ _ChunkedJsonParser.parse | (convert_patch.dart:926 )
Β | atΒ _parseJson | (convert_patch.dart:31 )
Β | atΒ JsonDecoder.convert | (json.dart:505 )
Β | atΒ JsonCodec.decode | (json.dart:153 )
Β | atΒ PlistParser.parseFile | (plist_parser.dart:59 )
Β | atΒ PlistParser.getValueFromFile | (plist_parser.dart:77 )
Β | atΒ IosProject.productBundleIdentifier | (project.dart:424 )
Β | atΒ FlutterProject.organizationNames | (project.dart:105 )
Β | atΒ CreateCommand.runCommand | (create.dart:326 )
Β | atΒ FlutterCommand.verifyThenRunCommand | (flutter_command.dart:796 )
Β | atΒ _rootRunUnary | (zone.dart:1192 )
Β | atΒ _CustomZone.runUnary | (zone.dart:1085 )
Β | atΒ _FutureListener.handleValue | (future_impl.dart:141 )
Β | atΒ Future._propagateToListeners.handleValueCallback | (future_impl.dart:686 )
Β | atΒ Future._propagateToListeners | (future_impl.dart:715 )
Β | atΒ Future._completeWithValue | (future_impl.dart:526 )
Β | atΒ Future._asyncCompleteWithValue.<anonymous closure> | (future_impl.dart:560 )
Β | atΒ _rootRun | (zone.dart:1184 )
Β | atΒ _CustomZone.run | (zone.dart:1077 )
Β | atΒ _CustomZone.runGuarded | (zone.dart:979 )
Β | atΒ _CustomZone.bindCallbackGuarded.<anonymous closure> | (zone.dart:1019 )
Β | atΒ _microtaskLoop | (schedule_microtask.dart:43 )
Β | atΒ _startMicrotaskLoop | (schedule_microtask.dart:52 )
Β | atΒ _runPendingImmediateCallback | (isolate_patch.dart:118 )
Β | atΒ _RawReceivePortImpl._handleMessage | (isolate_patch.dart:169 )
```
@jmagman
|
c: crash,tool,P2,team-tool,triaged-tool
|
low
|
Critical
|
613,500,159 |
flutter
|
[pigeon] print warning when `configurePigeon` overrides a commandline flag
|
cc @gaaclarke
|
c: new feature,package,team-ecosystem,p: pigeon,P3,triaged-ecosystem
|
low
|
Minor
|
613,507,042 |
go
|
x/build/cmd/gopherbot: instances of no reviewers being assigned to CLs
|
There are owners for this directory, so I'm surprised no one got auto-assigned until @hyangah added reviewers. Are there logs that I can take a look at? Happy to investigate myself, but I don't know how (or if I can) access gopherbot logs.
|
Builders,NeedsInvestigation
|
low
|
Major
|
613,511,556 |
rust
|
extern crate in function body results in incorrect path suggestions.
|
```rust
fn main() {
extern crate num; // 0.2.1
struct F<T: num::Integer>(T);
fn foo<T>(_: F<T>) {}
}
```
[playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=d1641035710d382c99e29dca6e17fca3)
has the following error:
```
error[E0277]: the trait bound `T: main::num::Integer` is not satisfied
--> src/main.rs:6:18
|
4 | struct F<T: num::Integer>(T);
| ----------------------------- required by `main::F`
5 |
6 | fn foo<T>(_: F<T>) {}
| ^^^^ the trait `main::num::Integer` is not implemented for `T`
|
help: consider restricting this type parameter with `T: main::num::Integer`
--> src/main.rs:6:12
|
6 | fn foo<T>(_: F<T>) {}
| ^
```
`main::num::Integer` is not a valid path. We probably want to use just `num::Integer` here instead
|
T-compiler,C-bug,A-suggestion-diagnostics,D-invalid-suggestion
|
low
|
Critical
|
613,515,156 |
go
|
proposal: spec: disallow impossible interface-interface type assertions
|
Now that we have introduced a vet check for this (see #4483), once we use modules to select the language version, we should disallow impossible interface-interface type assertions.
A quick refresher: Given a variable `x` of type interface `I1` with a method `m()`, and an interface `I2` with a method of the same name but different signature `m(int)`, the type assertion `x.(I2)` can never succeed because no value satisfying `I1` can also satisfy `I2`. The compiler can statically detect that this type assertion makes no sense (it will always panic or return false).
|
LanguageChange,Proposal,Analysis,LanguageChangeReview
|
medium
|
Major
|
613,529,031 |
flutter
|
asset manifest rebuilt logic does not include additions to wildcard directories
|
Currently the asset manifest rebuild logic consists of a depfile produced from all known copied assets + the manifest itself. Unfortunately this is incorrect in the presence of wildcard directories, since the addition of a file should be picked up, but does not change the hash of any known dependencies.
To solve this without removing support for wildcards, we could create a psuedo-hash for directory inputs, which consists of a stable combination of a shallow file listing. This would also unblock unifying the debug asset manifest rebuild logic from the production build. Unfortunately we won't be able to communicate this information accurately to build systems we are embedded in (Gradle/Xcode), since these require a list of files for inputs/outputs. For Gradle, we could build special logic into the task to compute wildcard directories, but this will likely be cumbersome.
During flutter run, this is solved by calling stat on all wildcard directories. This is not feasible at build time.
|
tool,a: build,P3,team-tool,triaged-tool
|
low
|
Critical
|
613,557,084 |
TypeScript
|
Allow JSX element tags to be symbols
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
es6 symbols JSX createElement element tag type intrinsic host
## Suggestion
Allow JSX element tags to be ES6 symbols instead of just strings, functions or classes.
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
JSX-based libraries like React have adopted the convention of using special upper-cased symbols as the tag of the JSX expression (`<Fragment />`, `<Suspense />`) as a way to provide intrinsic elements which arenβt callable and whose behavior are defined by the library rather than the tag.
Currently, TypeScript only allows JSX tags to be strings, functions or classes as defined by the JSX interface, and will throw errors like the following if Symbols are used:
```
error TS2604: JSX element type 'Fragment' does not have any construct or call signatures.
```
Libraries are therefore forced to lie about the actual typings of Symbol tags as something other than a `unique symbol`. For instance, React defines Symbol tags as `ExoticComponent` and pretends that the symbols are callable (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/react/index.d.ts#L358-L364). The framework I work on (Crank.js) just defines symbols meant to be used as tags as `any` but this then has further repercussions when I attempt to, for instance, use these symbol types in interfaces.
Symbols are useful because they:
1. Allow intrinsic elements to be upper-cased. This allows people to provide renderer-provided element APIs which mirror XML languages which are case-sensitive.
2. Not globally scoped, so there is no possibility of namespace clashes, and can be imported/exported.
3. Can still work with the global `IntrinsicElements` interfaces to be strongly typed.
## Examples
```tsx
const Fragment = Symbol.for("crank.Fragment");
type Fragment = typeof Fragment;
const Portal = Symbol.for("crank.Portal");
type Portal = typeof Portal;
// should not error
const el = (
<Fragment>{children}</Fragment>
);
declare namespace JSX {
interface IntrinsicElements {
foo: any;
[Portal]: {root: any};
}
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
low
|
Critical
|
613,578,981 |
go
|
x/website: link to signatures on Go releases and document how to validate
|
On https://golang.org/dl/, there are links to each Go release, along with SHA256 checksums. However, the security of those checksums is only ensured by HTTPS. I learned recently that there are also PGP signatures for each release. So to go along with:
https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz
There is also:
https://dl.google.com/go/go1.14.2.linux-amd64.tar.gz.asc
It would be great to document that fact on https://golang.org/dl/, along with instructions on how to validate the signature.
|
Documentation,Builders,NeedsInvestigation,FeatureRequest,website
|
low
|
Major
|
613,599,506 |
flutter
|
Un-merge threads when there are no mutations in the platform views and overlays.
|
Our first launch of dynamic thread merging will only un-merge the thread when there are no platform views at the current frame and next frame. No platform views also guarantees there are no overlay views.
In the future, we want to optimize this so that the threads can be un-merged while there are platform views and overlays on the scene and only keep the thread merged when there are changes in the platform views and overlays.
The current limitation is that during preroll, we don't know if there are changes in the overlays. We should find a way to know if a platform view overlay is "added", "removed" or "changed" during preroll so we can optimize it.
@amirh @blasten
|
platform-ios,engine,c: performance,a: platform-views,perf: speed,P2,team-ios,triaged-ios
|
low
|
Minor
|
613,600,451 |
TypeScript
|
Allow trailing lines in multiline comment directives
|
**TypeScript Version:** 4.0.0-dev.20200507
**Search Terms:** multiline comment directive ts-expect-error ts-ignore
**Code**
```ts
const x = 0;
/* @ts-ignore
continuing comment
that could be multiline*/
x();
```
**Expected behavior:**
The comment looks like a directive to ignore the `x();`'s type checking complaint.
**Actual behavior:**
Comment directive parsing only looks at the _last_ line of the comment. It should also allow the _first_ line of the comment.
I'm in favor of _not_ allowing any other lines (i.e. "middle" lines) to count as directives. Extending to allow characters after the `@ts-` has precedent from what's already allowed _(we're really just adding newlines)_. But putting characters before the `@ts-` has a precedent of not working even in single-line comments.
```tsx
/* Here we use a
@ts-ignore
that is multiline*/
```
**Playground Link:** https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=28&pc=2#code/MYewdgzgLgBAHjAvDADAbgFAYPQCoYACUEAtAJYDmYIATgKYahhRlgCurFMoAtj3cxgYYUABYBDWKDYAbACYwARnRg9ZLGazq5sWOAAoAlGiA
**Related Issues:** Following discussion in https://github.com/microsoft/TypeScript/pull/38228#discussion_r420940329, as suggested by @sheetalkamat.
|
Bug,Rescheduled
|
low
|
Critical
|
613,633,823 |
terminal
|
Support using the Accent Color for `cursorColor`, `selectionBackground`, etc.
|
>
>
> Can there be support for the Accent Color brushes, so if I were to set my cursor or selction to my Accent Color, as it changes, that change will be reflected in Windows Terminal?
So that might need to be it's own separate feature request. The cursor and the selection are drawn in DirectX down in `TermControl`, so they work differently than a lot of the things in this spec (which are all XAML elements).
For those, we'd need to accept something like `"cursorColor": "accent"`. When we did that, `CascadiaSettings` would know that the string isn't a "#rrggbb" color, so it could look up the color when we're building the `TerminalSettings` to pass to the `TermControl`. However, after that point, if the user changes their accent color, that wouldn't be reflected dynamically in the Terminal, until the user manually refreshes their settings.
It's not a horrible idea, but probably something we should move to it's own thread for discussion, since I don't think it really fits in with a lot of the other things in this spec.
_Originally posted by @zadjii-msft in https://github.com/microsoft/terminal/pull/5772#issuecomment-624908257_
#6338 is related.
|
Help Wanted,Area-TerminalControl,Area-Settings,Product-Terminal,Issue-Task
|
low
|
Minor
|
613,635,487 |
TypeScript
|
Introduce new flag for minifier optimization hints
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
Optimization
Minifier
Bundler
IIFE
Wrapper
Terser
## Suggestion
TypeScript 3.9 pulled in PR #32011, which tailors TypeScript's output for optimization with minifiers such as Terser. This PR definitely goes in the right direction for optimizing TypeScript's emit for most users, but doesn't necessarily work for all toolchains out there. At Google we have optimization processes after TypeScript compilation that use static analysis to look for classes, do some rough type-checking, and for example rename class properties and drop methods. The wrapper introduced in TypeScript 3.9 hinders our ability to analyze these classes.
We'd like to propose a new flag to toggle this behavior, which I'll call `--add-optimization-hints` for now. This flag would control if TypeScript decides to emit these hints for optimizers and bundlers, which is not necessarily limited to the `/** @class */` form introduced in TypeScript 3.9. For users such as Google, we can disable this flag and instead rely on our own optimizers to handle this, but users piping directly through Webpack and Terser can still receive the benefits from #32011.
## Use Cases
### Removing IIFE Wrapper for ES2015 Classes
Expanding on our toolchain a bit from above, at Google we use a combination of [tsickle](https://github.com/angular/tsickle), [closure-compiler](https://github.com/google/closure-compiler), and other tools to optimize our TypeScript code. Tsickle is used to add type annotations and use the `goog.module` module system to TypeScript's emit such that Closure Compiler can optimize the code. Using the TypeScript 3.9 RC which emits IIFE wrappers around ES2015 classes Closure Compiler is unable to understand that this is an alias for the inner class. By setting `--add-optimization-hints=false` we would be able to statically analyze TypeScript's output without doing additional special processing.
### Adding Further Optimization Hints
PR #32011 isn't the first to request optimization hints from the TypeScript output, for example #13721 requested a `/** #pure */` annotation as well, and there could be more in the future that TypeScript would like to hint at. Adding this flag allows TypeScript to produce messier code that is less similar to the input, but more compatible with bundlers and minifiers.
## Examples
This would be a new flag for the TypeScript compiler. Assuming TypeScript 3.9 is being used, given the input:
```ts
// input.ts
class C {
static prop = 10;
getProp() {
return C.prop;
}
}
```
**Compiling with `tsc --add-optimization-hints=true`**:
```js
// output.js
"use strict";
let C = /** @class */ (() => {
class C {
getProp() {
return C.prop;
}
}
C.prop = 10;
return C;
})();
```
**Compiling with `tsc --add-optimization-hints=false`**:
```js
// output.js
"use strict";
class C {
getProp() {
return C.prop;
}
}
C.prop = 10;
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,Awaiting More Feedback
|
medium
|
Critical
|
613,679,845 |
flutter
|
pigeon: add constructor arguments to generated dart classes
|
right now the constructors are empty
|
package,team-ecosystem,p: pigeon,P3,triaged-ecosystem
|
low
|
Minor
|
613,680,636 |
flutter
|
pigeon: add nice error message if someone sends a message to an API that hasn't been setup
|
package,team-ecosystem,p: pigeon,P3,triaged-ecosystem
|
low
|
Critical
|
|
613,689,874 |
node
|
constants: stop exporting UV_ constants
|
...and possibly other internal constants as well.
Context: #33246
Example: `os.constants` exports `UV_UDP_REUSEADDR`, which makes no sense for that module and isn't usable outside of core.
Introduced in dcccbfdc799 which turned the mostly-internal, undocumented `constants` module into something that's public and documented but apparently without reviewing whether it makes sense to export/document everything.
|
discuss,lib / src
|
low
|
Minor
|
613,690,579 |
pytorch
|
torch.save incompatible with lzma file
|
## π Bug
Using the `lzma` module when opening a file for use with `torch.save` or `torch.load` does not work, when it should, since it provides file-like objects.
## To Reproduce
Steps to reproduce the behavior:
t = torch.tensor(range(5))
f = lzma.open('tmp.xz', 'wb')
torch.save(t, f)
f.close()
f = lzma.open('tmp.xz', 'rb')
torch.load(f)
Yields `LZMAError: Input format not supported by decoder`.
## Expected behavior
No error.
## Environment
- PyTorch version: 1.5.0
- Is debug build: No
- CUDA used to build PyTorch: 10.2
- OS: Arch Linux
- GCC version: (Arch Linux 9.3.0-1) 9.3.0
- CMake version: Could not collect
- Python version: 3.8
- Is CUDA available: Yes
- CUDA runtime version: 10.0.130
- GPU models and configuration: GPU 0: GeForce GTX 1070
- Nvidia driver version: 440.82
- cuDNN version: /usr/lib/libcudnn.so.7.6.5
Versions of relevant libraries:
- [pip3] numpy==1.18.4
- [pip3] torch==1.5.0
- [pip3] torchvision==0.6.0
- [pip3] torchviz==0.0.1
- [conda] Could not collect
## Additional context
I think `torch.save` is not using the `lzma` wrapper and writing directly to the underlying file or something, since the file does not have the lzma format at all. I don't know enough about the inner workings though.
cc @SsnL
|
module: serialization,triaged
|
low
|
Critical
|
613,690,750 |
TypeScript
|
Array literal of union type should be convertible to union of arrays
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** v4.0.0-dev.20200505, v3.8.3
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** array union literal
**Code**
```ts
declare let x: Date | Error;
const y: Date[] | Error[] = [x];
```
**Expected behavior:**
No errors.
Array literals of unions should be contextually typed by unions of array literals.
I would also expect `[Date | Error]` to be convertible to `Date[] | Error[]`, which [also fails](https://www.typescriptlang.org/play/index.html?ssl=3&ssc=10&pln=3&pc=26#code/CYUwxgNghgTiAEEQBd4A8Bc8AiVkIB94BRGGAexgG4AoMcgOwGdV8BbABywG1d94ipCjAC68ALzxuaEbXrNUATyx8Q3MYLKV1E+Ow60gA)
**Actual behavior:**
```
Type '(Date | Error)[]' is not assignable to type 'Date[] | Error[]'.
Type '(Date | Error)[]' is not assignable to type 'Date[]'.
Type 'Date | Error' is not assignable to type 'Date'.
...
```
**Playground Link:** [Link](https://www.typescriptlang.org/play/index.html#code/CYUwxgNghgTiAEEQBd4A8Bc8AiVkIB94BRGGAexgG4AoMcgOwGdUBPLXfAbQF14jSFGL3gBeeFzQ9aQA)
**Motivating real-life(-ish) example**: [Link](https://www.typescriptlang.org/play/index.html?ts=4.0.0-dev.20200505#code/CYUwxgNghgTiAEAzArgOzAFwJYHtXy1VRBgBUALQgcwAoAPALngBEoMQBtAXXgB94AojBg4Y3AJQBuAFDSU6bHng5k7MpVS1GLNgn5CRMcfADe0+BfgB6K-AB0D85cLF11GhzpcpTizfuOAL5AA)
|
Bug
|
low
|
Critical
|
613,705,659 |
svelte
|
Observer still called when unsubscribed during store update
|
https://svelte.dev/repl/703dd3e1045543388fd5583c489bac55?version=3.22.2
```js
const store = writable(0);
let is2cancelled = false;
const cancel_sub1 = store.subscribe((v) => {
if(v === 1){
cancel_sub2()
is2cancelled = true
}
});
const cancel_sub2 = store.subscribe((v) => {
if(v === 1 && is2cancelled){
console.log('I have been cancelled already');
}
});
store.set(1); // logs 'I have been cancelled already'
cancel_sub1();
```
will fix with #4742 unless someone thinks this behavior is expected ?
|
awaiting submitter,stale-bot
|
low
|
Minor
|
613,708,576 |
pytorch
|
Special methods on torchscript custom class
|
## π Feature
Allow torchscript custom extension class to define Python special methods such as `__len__` and `__getitem__`.
## Motivation
We are implementing torchscript-able Sentence Piece in torchtext. https://github.com/pytorch/text/pull/755
`__len__` and `__getitem__` are useful when building NLP pipeline.
The official Sentence Piece Python binding uses Swig to define `__len__` and `__getitem__`.
## Pitch
It would be nice if we can do `len` and indexing when encoding the input text.
## Alternatives
I tried
```
static auto sentencepiece =
torch::class_<SentencePiece>("torchtext", "SentencePiece")
.def(torch::init())
.def("__len__", [](const c10::intrusive_ptr<SentencePiece>& self) {
return (int64_t)self->processor_.GetPieceSize();})
```
but got error
```
E TypeError: object of type 'torch._C.ScriptObject' has no len()
```
cc @suo
|
oncall: jit,triaged
|
low
|
Critical
|
613,709,270 |
pytorch
|
JIT compilation of NamedTuple Containing a NamedTuple fails
|
## π Bug
When creating a Class inherited from NamedTuple which contains a member which is a type of a different class inherited from NamedTuple, jit compiler fails at resolving the type.
## To Reproduce
<img width="815" alt="Screen Shot 2020-05-06 at 5 58 42 PM" src="https://user-images.githubusercontent.com/20385914/81243189-fc268900-8fc3-11ea-8412-f9d282e7260e.png">
## Expected behavior
Recursively resolve the datatype for all the members in named_tuple. Functions compiled with jit can take input that are type of class inherited from NamedTuple which contains a member that as a NamedTuple.
## Environment
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).
You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
Collecting environment information...
PyTorch version: 1.4.0a0+7f73f1d.atg.3
Is debug build: No
CUDA used to build PyTorch: 10.1
OS: Ubuntu 18.04.4 LTS
GCC version: (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0
CMake version: Could not collect
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: GeForce GTX 1080
Nvidia driver version: 430.64
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] Could not collect
[conda] Could not collect
## Additional context
<!-- Add any other context about the problem here. -->
cc @suo
|
oncall: jit,triaged
|
low
|
Critical
|
613,717,015 |
TypeScript
|
Better type printing for JSX IntrinsicElements
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
JSX IntrinsicElements print
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
When printing JSX IntrinsicElements related types, prefer the tag name
<!-- A summary of what you'd like to see added or changed -->
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
```ts
const z1 = <a class="" />;
```
Now:
```
Type '{ class: string; }' is not assignable to type 'DetailedHTMLProps<AnchorHTMLAttributes<HTMLAnchorElement>, HTMLAnchorElement>'.
```
Suggest:
```
Type '{ class: string; }' is not assignable to type '<a />'.
```
This will make the error message easier to understand
<!-- Show how this would be used and what the behavior would be -->
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
|
Suggestion,In Discussion
|
low
|
Critical
|
613,754,864 |
flutter
|
Support `flutter attach` on iOS devices on non-macOS devices
|
It would be nice to be able to `flutter attach` to iOS devices on non-macOS devices.
This is related to #22771, but specifically for attaching.
I used to have [a patch (older, shorter)](https://gist.github.com/gabrc52/eb03009970d3baa30b0bb546e15aaa9f/bdb8acc4eaeacb61d2db1c5a87ea0e469fc84b9b) [(newer version, but longer)](https://gist.github.com/gabrc52/eb03009970d3baa30b0bb546e15aaa9f) to be able to do this, but #50252 has made listing devices Mac-only by using an XCode-specific tool.
Even if it's not possible to build iOS apps on Linux or Windows, it would still be very useful to people who don't have a Mac, since we can use tools like Codemagic to build the app.
So, with this new feature:
* `flutter devices` would detect iOS devices on any platform, maybe with a disclaimer that `flutter run` is not supported
* `flutter run` would warn the user that it's not possible without a Mac, and would suggest using a build service like Codemagic
* `flutter attach` would work the same as with a Mac or with Android devices
* IDE/Daemon would work the same way
If a pull request to add this feature was made, considering the code adheres to the quality standards of the project, would it be merged?
|
c: new feature,platform-ios,tool,P3,team-ios,triaged-ios
|
low
|
Major
|
613,768,265 |
TypeScript
|
RFC: Support __proto__ literal in object initializers
|
This is a new issue to specifically propose and elaborate on a feature I raised [in this comment](https://github.com/microsoft/TypeScript/issues/30587#issuecomment-614855795) on #30587.
## Search Terms
- \_\_proto__
- prototype
- object literal
- object spread
- object initializer
## Suggestion
While accessing or mutating an _existing_ object via the `Object.protptype.__proto__` getter/setter is deprecated, to the best of my knowledge defining the prototype of a _new_ object via the object initializer `__proto__` literal is very much encouraged.
The rules for specifying the prototype of a new object via these semantics are very well-specified and safe. [See the relevant section of the spec here.](https://www.ecma-international.org/ecma-262/6.0/index.html#sec-__proto__-property-names-in-object-initializers)
### Basic support
Given the following:
```ts
const foo = {
__proto__: { a: "a" },
b: "b"
};
```
Typescript currently thinks that `foo` is the following shape:
```ts
type foo = {
["__proto__"]: { a: string };
b: string;
};
```
when in reality, it is:
```ts
type foo = {
a: string;
b: string;
};
```
TypeScript should be able to correctly detect the type of this object initialization.
### Strict validity checks
Additionally, TypeScript should prevent invalid `__proto__` assignments that are "ignored" by the spec, and require all values to be `null` or an object. This should fail validation:
```ts
const invalid = { __proto__: "hello" }
```
### Correct handling of computed properties
It's important to note that per the spec, `__proto__` literals are _not_ the same as regular property assignments.
This object initialization, for example:
```ts
const foo = {
__proto__: { a: "a" },
b: "b",
["__proto__"]: { c: "c"},
};
```
creates an object of the following shape:
```ts
type foo = {
a: string;
b: string;
["__proto__"]: { c: string};
};
```
Given this, I would recommend that a `__proto__` literal be forbidden in _type/interface definitions_, such that this is considered a syntax error:
```ts
type foo = {
__proto__: { a: string }
}
```
while this is an allowable way to specify a **property** named `__proto__` on the type `foo`.
```ts
type foo = {
["__proto__"]: string
}
```
## Use-Cases & Examples
This feature allows TypeScript to correctly understand the shape of objects defined with standard JS semantics. While this pattern isn't especially prevalent, it is an important feature of the language, and should be much more common in one particular use-case where TypeScript currently has a rather severe blind spot:
TypeScript currently _PREVENTS_ the creation of safe indexed objects derived from existing indexed objects. For example:
Given this object, and the goal of "spreading" it into a new map:
```ts
// All safe map objects MUST have a `null` prototype.
const someMapObject: { [key: string]: boolean } = Object.create(null);
```
The following is UNSAFE, and probably the most common approach I see people using. TypeScript _should_ catch this, and _should_ issue a compile-time error. See bug #37963.
```ts
const unsafeSpreadMapObject: { [key: string]: boolean | undefined } = {
...someMapObject,
foo: false
};
console.log(typeof unsafeSpreadMapObject["constructor"]);
// => function
console.log(typeof safeSpreadMapObject["foo"]);
// => boolean
```
The following is also UNSAFE. While using `Object.assign` and `Object.create` is a perfectly valid alternative, the `any` returned by `Object.create` propagates through the statement and breaks type safety. (Perhaps the result of `Object.create` should be `unknown` instead of `any`?)
```ts
const unsafeAssignMapObject: { [key: string]: boolean | undefined } = Object.assign(
Object.create(null),
{ foo: "this is not boolean" }
);
console.log(typeof safeSpreadMapObject["constructor"]);
// => undefined
console.log(typeof safeSpreadMapObject["foo"]);
// => string
```
This is the SAFE way to accomplish this while using object spreads, but TypeScript currently forbids it, since it lacks support for the `__proto__` literal, and incorrectly believes a _property_ of type `null` is being defined:
```ts
const safeSpreadMapObject: { [key: string]: boolean | undefined } = {
__proto__: null,
...someMapObject,
foo: false
};
console.log(typeof safeSpreadMapObject["constructor"]);
// => undefined
console.log(typeof safeSpreadMapObject["foo"]);
// => boolean
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
## References
- [Object initialization: Prototype mutation (MDN)](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Object_initializer#Prototype_mutation)
- [\_\_proto__ Property Names in Object Initializers (ECMAScript Spec)](https://tc39.es/ecma262/#sec-__proto__-property-names-in-object-initializers)
|
Suggestion,Awaiting More Feedback
|
medium
|
Critical
|
613,769,659 |
pytorch
|
unsqueeze support for named tensors
|
## π Feature
I would love to be able to use unsqueeze on named tensors.
## Motivation
In my code using named tensors I end up with a lot of code that looks like: `
my_named_tensor.rename(None).unsqueeze(1).refine_names("x","y","z")
`
where the "x" and "z" are the existing names, and "y" would be the newly created dimension.
## Pitch
There seems to be an obvious extension to the API which would allow this functionality. What I propose is as follows: If you use the current unsqueeze API, you'll get:
`assert(my_named_tensor.unsqueeze(1).names == ("x", None, "z"))`
The new dimension will be created in the position requested, with a None name.
I'd like to go one step further, though, and add an optional name argument to unsqueeze.
`assert(my_named_tensor.unsqueeze(1,"y") == ("x","y","z"))
`
The only thing that's unclear to me is what should happen if `unsqueeze` is called with `name` on unnamed tensor.
## Alternatives
The current workaround is to rename to None and then back to a named tensor. It's awkward.
## Additional context
I'd love to to implement this if my proposal is agreed to!
cc @zou3519
|
triaged,enhancement,module: named tensor
|
low
|
Minor
|
613,794,114 |
pytorch
|
New padding size format for F.pad, allowing named tensors and more clear syntax overall
|
## π Feature
This feature request is within regards to the padding size argument of `F.pad`. From my perspective there are two deficiencies with the current format:
1. For normal tensors (not named), the current format can be very awkward. If you're adding padding to the last dimension it's elegant. But sometimes you're adding padding to the first or second dimension, and things can get awkward. For instance I have code that adds padding to the second dimension of a tensor. The unfortunate thing is that the tensor is sometimes 3d and sometimes 4d. When you combine these situations with the awkward dimension counting from the end, you sometimes end up code like:
```
pad_size = [0 for i in range(2 * len(x.shape))]
pad_size[2*len(x.shape) - 1 - 2 * pad_dim] = padding
F.pad(x, pad_size, ...)
```
2. The more pressing issue, from my perspective, is that `F.pad`'s formatting is fundamentally incompatible with named tensors.
## Motivation
I'd like to see a more elegant way of padding both named tensors and regular tensors.
## Pitch
My proposal is to increase the expressiveness of the the padding_size argument of `F.pad`. I propose padding_size can be one of two types:
- (tuple) in which case the current behavior is maintained. This ensures total backward compatibility.
- (dict) in which case the padding format is `{dim: [padding_left, padding_right]}`. `dim` could take multiple values
-- If dim is a positive int, it specifies the index of the dimension to be padded.
-- If dim is a negative int, it specifies the index from the back to be padded. `-1` would be the last dimension.
-- If dim is a string, it specifies the name of the dimension to be padded.
## Alternatives
The alternative is to continue to use `F.pad` as it's written, convert all named tensors to non-named tensors before padding, and then convert them back to named tensors afterward.
## Additional context
I'd be happy to implement this if a proposal is agreed upon.
cc @albanD @mruberry
|
feature,module: nn,triaged
|
low
|
Minor
|
613,965,564 |
TypeScript
|
Implicit Symbol.iterator call in for..of loops / spread destructuring doesn't infer `this` generic type parameter
|
<!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 4.0.0-dev.20200507
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** Symbol.iterator type parameter implicit calling for..of loops object spread destructuring this generic
**Code**
What follows is 3 different ways of iterating over an object using a custom-made iterator. However, using `Symbol.iterator` implicitly via the for..of loop fails to produce the same behavior:
```ts
const obj = {
x: 1,
y: 2,
z: 3,
*[Symbol.iterator]<T extends object>(
this: T,
): Generator<NonNullable<{ [K in keyof T]: [K, NonNullable<T[K]>] }[keyof T]>, void, unknown> {
for (const entry of Object.entries(this)) yield entry as never;
},
};
{
const iter = obj[Symbol.iterator]();
for (let result = iter.next(); !result.done; result = iter.next()) {
const { value } = result;
value; // ["x", number] | ["y", number] | ["z", number]
}
}
for (const value of obj[Symbol.iterator]()) {
value; // ["x", number] | ["y", number] | ["z", number]
}
for (const value of obj) {
value; // NonNullable<{ [K in keyof T]: [K, NonNullable<T[K]>]; }[keyof T]>
// bad! This should be ["x", number] | ["y", number] | ["z", number]
}
// also, spread destructuring suffers from the same problem!
const values = [...obj]; // Array<NonNullable<{ [K in keyof T]: [K, NonNullable<T[K]>]; }[keyof T]>>
// bad! This should be Array<["x", number] | ["y", number] | ["z", number]>
```
**Expected behavior:** `for (const value of obj)` should implicitly do the type equivalent of calling our iterator symbol, i.e. `for (const value of obj[Symbol.iterator]())`. That means our type parameter should be correctly inferred like so: `obj[Symbol.iterator]<T>(this: T)`.
**Actual behavior:** `T` cannot be inferred as the local `this` type, so all derivative types cannot be evaluated and the type stays as its generic version.
[**Playground Link**](https://www.typescriptlang.org/play/index.html?ts=4.0.0-dev.20200506#code/MYewdgzgLgBCBGArGBeGBvAsAKAJAA8AuGARgBodcBPYgJgrwC9iBmB3AKgG0BlKgW3ggANgDoAllACmAJwCGUEDIC6AHgAqMKfmlgAJhDhIpwKAD4AFJVxQAFuIjF17AJTEA4lLCyFS1QDlwfwBXYWE5eGEpVXQYLgBpGHEwGABrKSoQADMYdWViBLIYQLAQsIiojQTlM2UYAF8udMycvLMigDcQcT0i4LBUsBAAdzAzDGsspRgLUEhYLygZKjgcgHljU1FFmXEpCAs7BxcXGCo94T0tMCWVuUNvDtkAbkp6hnrX7BwsPDnoJLSGSoIyIXgCIRiSQ+RQqCwuL6UKbAixRWAyfahWBoaEyUTeHTw54wACEGIgWNEenAUmJ5KxINx+O0UHhp1+uFw-1gsQ6cmEwSkDRB9OEUC+nL5AtpMAA9LK4gAifCKopgYKCWR1AA+Sqoqpg6s1Khguq4isYBqN8C1bxw9RwOGRM25MClgtWoPBghEEiBvjhJwmeHdMvlSpVao1NpNZsV+qjxp1SstiZjyntjuwztm4ABoc9CEQ7MooeJ4ZKZXCkWisQSSRSzWyuXycXiRUroWrlXU1VqxMaTdaNUo4fgcj0JNy9kMEFsIFCVxtEat0a1pr1q6TG-NqcNa5Ume+2FdocMaC4oivReU5YVAEEZPIqAEgl2KrW2w20hlm3kCu2xRvuUNZVPENS3g0TS-sOZhmDgY4TlO6gzjAc4LpcMDLo+z6qOakb7tucYJoR6Y7haW7pmYQA) <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? --> n/a
|
Suggestion,Experience Enhancement,Has Repro
|
low
|
Critical
|
613,977,662 |
ant-design
|
Remove inline styling from ant components (props)
|
- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### What problem does this feature solve?
Right now some components like **aside** navigation etc. have some of the styles by default in html structure, and some of them in css files. It makes the whole styling process way more complicated then it should be, and forces a front-end developer to split their work in two (by using css and props).
### What does the proposed API look like?
Everything that relates to styling should be moved to CSS for easier and more consistent work. Elements like **aside** should not contain any inline styles when rendered and should get all styling from .css file/s.
<!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
|
Inactive,improvement
|
low
|
Major
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.