id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
420,625,225 | godot | Viewport display modes not working in GLES 2 | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
<!-- Specify commit hash if non-official. -->
3.1
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Pop OS 18.10/ NVIDIA GeForce 920MX
**Issue description:**
<!-- What happened, and what was expected. -->
when you try to change the viewport render mode to something like wireframe with the gles 2 renderer nothing happens
when i tried it in gles 3 it worked fine
**Steps to reproduce:**
create a new project
switch to gles 2
add a mesh instance
change the viewport display mode to wireframe, overdraw, unshaded. | bug,topic:rendering,topic:editor,confirmed | low | Major |
420,629,804 | pytorch | "unknown builtin op" error with static library | Getting error while running libtorch example from https://pytorch.org/tutorials/advanced/cpp_export.html . Getting error only with static library. Shared library works fine.
```
./libtorch_test model.pt
terminate called after throwing an instance of 'torch::jit::script::ErrorReport'
what():
unknown builtin op:
def mul(a : float, b : Tensor) -> Tensor:
return b * a
~~~~~ <--- HERE
def add(a : float, b : Tensor) -> Tensor:
return b + a
def ne(a : float, b : Tensor) -> Tensor:
return b != a
def eq(a : float, b : Tensor) -> Tensor:
return b == a
def lt(a : float, b : Tensor) -> Tensor:
return b > a
def le(a : float, b : Tensor) -> Tensor:
Aborted (core dumped)
```
Command used to compile libtorch_test
```
LIBTORCH = /pytorch/torch/lib/tmp_install
g++ -I"$LIBTORCH/include" -I"$LIBTORCH/include/torch/csrc/api/include" -D_GLIBCXX_USE_CXX11_ABI=0 -std=gnu++11 libtorch_test.cpp -o libtorch_test -L"$LIBTORCH/lib" -ltorch -lcaffe2 -lc10 -lc10d -lTHD -fopenmp -lpthread -lrt -lm -lsleef -llapack -lblas -lcpuinfo -lclog -lprotobuf -lonnx -lonnx_proto -lcaffe2_protos
```
## Environment
- PyTorch Version: 1.0.1:
- OS: Redhat Linux:
- Build command:
`EXTRA_CAFFE2_CMAKE_FLAGS="-DTORCH_STATIC=1 -DBUILD_SHARED_LIBS=OFF -DUSE_CUDA=0" python ../tools/build_libtorch.py`
cc @yf225 | module: cpp,triaged | low | Critical |
420,653,825 | TypeScript | QuickInfo misleading with signatures from higher order function type inference | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.20190313
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
interface T1 {}
declare function pipe2<A, B, C, D>(ab: (a: A) => B, cd: (c: C) => D): (a: [A, C]) => [B, D];
declare function list<T extends T1>(a: T): T[];
declare function box<T extends T1>(x: T): { value: T };
const listBox = pipe2(list, box);
```
**Expected behavior:**
Propagated type parameters should be renamed if a different type with the same name is used in the constraint or initializer of any other propagated type parameter.
For example: `<T extends T1, T2 extends T1>`.
**Actual behavior:**
Hovering over `listBox` displays `const listBox: <T extends T1, T1 extends T1>(a: [T, T1]) => [T[], {value: T1;}]`
Note the `T1 extends T1` and `T extends T1` where `T1` refers to something completely different.
This is not limited to renamed type parameters. Hovering over `listBox` in the following code displays circular type parameter constraints (`<T extends V, V extends T>`) without any renaming going on:
```ts
interface T {}
interface V {}
declare function pipe2<A, B, C, D>(ab: (a: A) => B, cd: (c: C) => D): (a: [A, C]) => [B, D];
declare function list<T extends V>(a: T): T[];
declare function box<V extends T>(x: V): { value: V };
const listBox = pipe2(list, box);
```
| Bug,Domain: Type Display,Domain: Quick Info | low | Critical |
420,668,186 | kubernetes | Vsphere Cloud Provider: failed to detach volume from shutdown node | **What happened**:
I have a pod with a pv attached to it running on node1.
When I shutdown node1 to simulate node-failure, Kubernetes detects the unhealthy node in the configured timeframe and tries to re-schedule the pod on node2 following the --pod-eviction timeout.
When trying to start the pod on node2, the pv can not be attached as it is still attached to the shutdown node1:
```
Warning FailedAttachVolume 6m attachdetach-controller Multi-Attach error for volume "pvc-db44144b-457f-11e9-a7b0-005056af6878" Volume is already exclusively attached to one node and can't be attached to another
```
Also, the pod on the shutdown node does not get deleted.
**What you expected to happen**:
As documented [here](https://vmware.github.io/vsphere-storage-for-kubernetes/documentation/high-availability.html):
The disk should be detached from the shutdown node and attached to the new node where the pod is scheduled on
**How to reproduce it (as minimally and precisely as possible)**:
1. Schedule single pod using pvc on node1
1. Shutdown node1
1. Watch FailedAttachVolume event on the new pod on node2
**Anything else we need to know?**:
Also, kube-controller-manager does not log anything about this failure.
Detachment and attachment to another nodes works fine, as long as all nodes are healthy.
Force-deletion of the pod on the shutdown node also does nothing.
**Environment**:
- Kubernetes version (use `kubectl version`): 1.12.5
- Cloud provider or hardware configuration: vsphere
- OS (e.g: `cat /etc/os-release`): Ubuntu 16.04
- Kernel (e.g. `uname -a`): Linux k8s-dev-master3 4.4.0-139-generic #165-Ubuntu SMP Wed Oct 24 10:58:50 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
- Install tools: Kubespray 2.8.3 using kubeadm
- Others: VSphere 6.5
Thanks in advance! :) | kind/bug,priority/important-soon,lifecycle/frozen,area/provider/vmware,sig/cloud-provider,needs-triage | medium | Critical |
420,671,831 | flutter | Provide a way to print the Navigator inner stack | It would be nice to have a way to print the `Navigator` current stack, so we can check if it's being built in the way we imagine, or if there are some stray screens there, that shouldn't, or if we are replacing the wrong screen in a `pushAndRemoveUntil`.
something like:
```
Navigator.of(context).printStack();
``` | c: new feature,framework,f: routes,customer: crowd,c: proposal,P3,team-framework,triaged-framework | medium | Critical |
420,675,356 | material-ui | Equivalent to Blueprint's RunningText | A `<RunningText>` component would apply typography styles to basic html elements in it, so something like this:
```
<RunningText>
<h2>Foo</h2>
</RunningText>
```
Would behave like this:
```
<Typography variant="h2">Foo</Typography>
```
- [x] This is not a v0.x issue. <!-- (v0.x is no longer maintained) -->
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Expected Behavior π€
Within a `<RunningText>` all of the styles normally applied by `<Typography>` would be applied to the corresponding plain html elements.
## Current Behavior π―
If you want to render markdown in Material-UI, you have to use something like https://github.com/remarkjs/remark-react and its `remarkReactComponents` to make transformations like `<h2>` => `<Typography variant="h2">`. If you want to render arbitrary rich text from something like ProseMirror, you have to use something like https://github.com/remarkablemark/html-react-parser/ and its `replace` functionality to do the same. If you want to render rich text from a contenteditable with WYSIWYG, you're out of luck because there's no way to use `<Typography>` in the editing control of things like ProseMirror.
## Examples π
Blueprint.js is React component library unrelated to Material Design. It has a feature like this, documented here as "RUNNING_TEXT": https://blueprintjs.com/docs/#core/components/html
## Context π¦
I listed some specific use cases in Current Behavior, but basically any situation where you want to render basic document content that might be dynamically generated and where using lots of `<Typography>` elements would be difficult.
## Benchmark
- https://elastic.github.io/eui/#/display/text
- https://bulma.io/documentation/elements/content/ | new feature,waiting for π,component: Typography | low | Minor |
420,675,838 | rust | C runtime library is not linked on macOS | **Problem**
rustc is not default to link C runtime library on macOS. I'm trying to write rust binding for a C library. That C library is shipped with my crate by a git submodule. The C library uses functionality provide by C runtime library. When I run `cargo test` without any special cargo configuration, it failed at linking stage because it cannot find the symbol `__emutls_get_address` which is provided in C runtime library.
The bug doesn't happen on Linux. On Ubuntu 18.04.2 LTS (GNU/Linux 4.15.0-46-generic x86_64). With the help of nightly `rustc -Z print-link-args`, I found out that rustc on linux has a link arg `-lgcc_s` which resolve to `/usr/lib/gcc/x86_64-linux-gnu/7/libgcc_s.so`.
**Steps**
<!-- The steps to reproduce the bug. -->
1. Get my repo
```
$ git clone [email protected]:lwshang/q-capi.git --single-branch --branch rustc-link
$ cd q-capi
$ git submodule update --init
```
2. disable my workaround in` .cargo/config`
```
$ mv .cargo .cargo.bk
```
3. Try to build the test executable
```
$ cargo test
...
= note: Undefined symbols for architecture x86_64:
"___emutls_get_address", referenced from:
l004 in e.o
...
```
**Possible Solution(s)**
<!-- Not obligatory, but suggest a fix/reason for the bug, -->
<!-- or ideas how to implement the addition or change -->
Currently, I have a workaround to separately add link-args in `.cargo/config` which specify the path to a C runtime library. But this is just a temporary solution, since the path is version sensitive, it will be different on different version of macOS with different version of Xcode.
If we compile a C program, the final link process always links a C runtime library. Depends on the compiler, different lib will be linked.
1. If using macOS 10.14.3 system clang, it links `/Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/10.0.0/lib/darwin/libclang_rt.osx.a`. (This is what I have in `.cargo/config`)
2. If using brew gcc-8, there is a link arg
`-lgcc_ext.10.5` which resolve to `/usr/local/Cellar/gcc/8.3.0/lib/gcc/8/libgcc_ext.10.5.dylib`.
If rustc default to link the first one (`libclang_rt.osx.a`), the special setting in `.cargo/config` will be non-necessary.
**meta**
```
rustc 1.33.0 (2aa4c46cf 2019-02-28)
binary: rustc
commit-hash: 2aa4c46cfdd726e97360c2734835aa3515e8c858
commit-date: 2019-02-28
host: x86_64-apple-darwin
release: 1.33.0
LLVM version: 8.0
``` | A-linkage,O-macos | low | Critical |
420,750,511 | pytorch | Unsupported type of tensor c10::half when running resnet50_trainer.py in Caffe2 | ## π Bug
Unsupported type of tensor c10::half error in SpatialBN operator when running resnet50_trainer with float16 type on V100, cuda10, cudnn7
## To Reproduce
Steps to reproduce the behavior:
1. docker pull pytorch/pytorch:nightly-runtime-cuda10.0-cudnn7
2. nvidia-docker run --entrypoint="/bin/bash" -it --ipc=host --privileged --shm-size 8G --device=/dev/kfd --device=/dev/dri --runtime=nvidia pytorch/pytorch:nightly-runtime-cuda10.0-cudnn7
3. pip install future networkx protobuf
4. python /opt/conda/lib/python3.6/site-packages/caffe2/python/examples/resnet50_trainer.py --train_data null --batch_size 64 --epoch_size 6400 --num_epochs 1 --num_gpus 1 --float16_compute --dtype float16
Console output:
Ignoring @/caffe2/caffe2/contrib/nccl:nccl_ops as it is not a valid file.
Ignoring @/caffe2/caffe2/contrib/gloo:gloo_ops as it is not a valid file.
Ignoring @/caffe2/caffe2/contrib/gloo:gloo_ops_gpu as it is not a valid file.
Ignoring @/caffe2/caffe2/distributed:file_store_handler_ops as it is not a valid file.
Ignoring @/caffe2/caffe2/distributed:redis_store_handler_ops as it is not a valid file.
[E init_intrinsics_check.cc:43] CPU feature avx is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature avx2 is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature fma is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
INFO:ResNe(X)t_trainer:Running on GPUs: [0]
INFO:ResNe(X)t_trainer:Using epoch size: 6400
INFO:data_parallel_model:Parallelizing model for devices: [0]
INFO:data_parallel_model:Create input and model training operators
INFO:data_parallel_model:Model for GPU : 0
INFO:data_parallel_model:Adding gradient operators
INFO:data_parallel_model:Add gradient all-reduces for SyncSGD
INFO:data_parallel_model:Post-iteration operators for updating params
INFO:data_parallel_model:Calling optimizer builder function
INFO:data_parallel_model:Add initial parameter sync
WARNING:memonger:NOTE: Executing memonger to optimize gradient memory
INFO:memonger:Memonger memory optimization took 0.01833963394165039 secs
INFO:ResNe(X)t_trainer:Starting epoch 0/1
[E net_async_base.cc:377] [enforce fail at operator.h:1116] . Unsupported type of tensor: c10::Half
Error from operator:
input: "gpu_0/conv1" input: "gpu_0/conv1_spatbn_relu_s" input: "gpu_0/conv1_spatbn_relu_b" input: "gpu_0/conv1_spatbn_relu_rm" input: "gpu_0/conv1_spatbn_relu_riv" output: "gpu_0/conv1_spatbn_relu" output: "gpu_0/conv1_spatbn_relu_rm" output: "gpu_0/conv1_spatbn_relu_riv" output: "gpu_0/conv1_spatbn_relu_sm" output: "gpu_0/conv1_spatbn_relu_siv" name: "" type: "SpatialBN" arg { name: "order" s: "NCHW" } arg { name: "use_cudnn" i: 1 } arg { name: "cudnn_exhaustive_search" i: 1 } arg { name: "ws_nbytes_limit" i: 67108864 } arg { name: "epsilon" f: 1e-05 } arg { name: "momentum" f: 0.9 } arg { name: "is_test" i: 0 } device_option { device_type: 1 device_id: 0 }frame #0: std::function<std::string ()>::operator()() const + 0x11 (0x7fa5eabf72b1 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libc10.so)
frame #1: c10::ThrowEnforceNotMet(char const*, int, char const*, std::string const&, void const*) + 0x49 (0x7fa5eabf70c9 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libc10.so)
frame #2: <unknown function> + 0x2b7a325 (0x7fa5edbad325 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2_gpu.so)
frame #3: <unknown function> + 0x16032b5 (0x7fa5ec6362b5 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2_gpu.so)
frame #4: caffe2::AsyncNetBase::run(int, int) + 0x144 (0x7fa625ccac74 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2.so)
frame #5: <unknown function> + 0x192e7b9 (0x7fa625cd17b9 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2.so)
frame #6: c10::ThreadPool::main_loop(unsigned long) + 0x263 (0x7fa5eabf0d53 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libc10.so)
frame #7: <unknown function> + 0xb8678 (0x7fa62f22f678 in /opt/conda/bin/../lib/libstdc++.so.6)
frame #8: <unknown function> + 0x76ba (0x7fa63df3f6ba in /lib/x86_64-linux-gnu/libpthread.so.0)
frame #9: clone + 0x6d (0x7fa63dc7541d in /lib/x86_64-linux-gnu/libc.so.6)
, op SpatialBN
[E net_async_base.cc:129] Rethrowing exception from the run of 'resnext50'
WARNING:caffe2.python.workspace:Original python traceback for operator `1` in network `resnext50` in exception above (most recent call last):
WARNING:caffe2.python.workspace: File "/opt/conda/lib/python3.6/site-packages/caffe2/python/examples/resnet50_trainer.py", line 690, in <module>
WARNING:caffe2.python.workspace: File "/opt/conda/lib/python3.6/site-packages/caffe2/python/examples/resnet50_trainer.py", line 685, in main
WARNING:caffe2.python.workspace: File "/opt/conda/lib/python3.6/site-packages/caffe2/python/examples/resnet50_trainer.py", line 488, in Train
WARNING:caffe2.python.workspace: File "/opt/conda/lib/python3.6/site-packages/caffe2/python/data_parallel_model.py", line 232, in Parallelize
WARNING:caffe2.python.workspace: File "/opt/conda/lib/python3.6/site-packages/caffe2/python/examples/resnet50_trainer.py", line 392, in create_resnext_model_ops
WARNING:caffe2.python.workspace: File "/opt/conda/lib/python3.6/site-packages/caffe2/python/models/resnet.py", line 344, in create_resnext
WARNING:caffe2.python.workspace: File "/opt/conda/lib/python3.6/site-packages/caffe2/python/brew.py", line 107, in scope_wrapper
WARNING:caffe2.python.workspace: File "/opt/conda/lib/python3.6/site-packages/caffe2/python/helpers/normalization.py", line 151, in spatial_bn
Traceback (most recent call last):
File "/opt/conda/lib/python3.6/site-packages/caffe2/python/examples/resnet50_trainer.py", line 690, in <module>
main()
File "/opt/conda/lib/python3.6/site-packages/caffe2/python/examples/resnet50_trainer.py", line 685, in main
Train(args)
File "/opt/conda/lib/python3.6/site-packages/caffe2/python/examples/resnet50_trainer.py", line 584, in Train
explog
File "/opt/conda/lib/python3.6/site-packages/caffe2/python/examples/resnet50_trainer.py", line 197, in RunEpoch
workspace.RunNet(train_model.net.Proto().name)
File "/opt/conda/lib/python3.6/site-packages/caffe2/python/workspace.py", line 237, in RunNet
StringifyNetName(name), num_iter, allow_fail,
File "/opt/conda/lib/python3.6/site-packages/caffe2/python/workspace.py", line 198, in CallWithExceptionIntercept
return func(*args, **kwargs)
RuntimeError: [enforce fail at operator.h:1116] . Unsupported type of tensor: c10::Half
Error from operator:
input: "gpu_0/conv1" input: "gpu_0/conv1_spatbn_relu_s" input: "gpu_0/conv1_spatbn_relu_b" input: "gpu_0/conv1_spatbn_relu_rm" input: "gpu_0/conv1_spatbn_relu_riv" output: "gpu_0/conv1_spatbn_relu" output: "gpu_0/conv1_spatbn_relu_rm" output: "gpu_0/conv1_spatbn_relu_riv" output: "gpu_0/conv1_spatbn_relu_sm" output: "gpu_0/conv1_spatbn_relu_siv" name: "" type: "SpatialBN" arg { name: "order" s: "NCHW" } arg { name: "use_cudnn" i: 1 } arg { name: "cudnn_exhaustive_search" i: 1 } arg { name: "ws_nbytes_limit" i: 67108864 } arg { name: "epsilon" f: 1e-05 } arg { name: "momentum" f: 0.9 } arg { name: "is_test" i: 0 } device_option { device_type: 1 device_id: 0 }frame #0: std::function<std::string ()>::operator()() const + 0x11 (0x7fa5eabf72b1 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libc10.so)
frame #1: c10::ThrowEnforceNotMet(char const*, int, char const*, std::string const&, void const*) + 0x49 (0x7fa5eabf70c9 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libc10.so)
frame #2: <unknown function> + 0x2b7a325 (0x7fa5edbad325 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2_gpu.so)
frame #3: <unknown function> + 0x16032b5 (0x7fa5ec6362b5 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2_gpu.so)
frame #4: caffe2::AsyncNetBase::run(int, int) + 0x144 (0x7fa625ccac74 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2.so)
frame #5: <unknown function> + 0x192e7b9 (0x7fa625cd17b9 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2.so)
frame #6: c10::ThreadPool::main_loop(unsigned long) + 0x263 (0x7fa5eabf0d53 in /opt/conda/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libc10.so)
frame #7: <unknown function> + 0xb8678 (0x7fa62f22f678 in /opt/conda/bin/../lib/libstdc++.so.6)
frame #8: <unknown function> + 0x76ba (0x7fa63df3f6ba in /lib/x86_64-linux-gnu/libpthread.so.0)
frame #9: clone + 0x6d (0x7fa63dc7541d in /lib/x86_64-linux-gnu/libc.so.6)
## Expected behavior
The script should run and output images/sec data for each iteration.
## Environment
- PyTorch Version : 1.0.0.dev20190311
- OS: Ubuntu 16.04.5 LTS
- How you installed PyTorch: docker from pytorch dockerhub repo - pytorch/pytorch:nightly-runtime-cuda10.0-cudnn7
- Python version: 3.6
- CUDA/cuDNN version: 10/7
- GPU models and configuration: Tesla V100-SXM2
| caffe2 | low | Critical |
420,757,855 | go | cmd/compile: allow ; on the RHS of rewrite rules for side-effects | Consider this rewrite rule:
```
(ADDQ x l:(MOVQload [off] {sym} ptr mem)) && canMergeLoadClobber(v, l, x) && clobber(l) -> (ADDQload x [off] {sym} ptr mem)
```
The `canMergeLoadClobber` condition is pure (free from side-effects). The `clobber` condition is not really a condition at all, but pretends to be one and is there for side-effects instead.
It'd be nice, for both clarity and reusability, to be able to put side-effects on the RHS of the rule. Something like:
```
(ADDQ x l:(MOVQload [off] {sym} ptr mem)) && canMergeLoadClobber(v, l, x) -> clobber(l); (ADDQload x [off] {sym} ptr mem)
```
`noteRule`, `warnRule`, and `clobberIfDead` all belong on the RHS.
[@mundaym's hypothetical `mergeSuccessor` function](https://github.com/golang/go/issues/30645#issuecomment-470612424) could also be naturally split into pure conditional LHS and impure RHS.
Thoughts?
cc @randall77 @cherrymui @mvdan @mundaym
| NeedsFix | low | Minor |
420,789,025 | ant-design | Avoid to remove tag when pressing backspace on select | - [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
Hi, I have been trying to intercept on keydown and preventDefault / stopPropagation / return false but nothing works, I think it will be a great feature.
### What problem does this feature solve?
Avoid tag remove when pressing backspace on select, some users will not wish it
### What does the proposed API look like?
removeOnBackspace={false|true}
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive,βFAQ | medium | Major |
420,794,007 | pytorch | Support 'bytes' type in torchscript | ## π Feature
Need support for 'bytes' type in torchscript
## Motivation
While dealing with image data, we have use cases where we download a blob from a blobstore and need to pass it to a torchscript module for further processing (ex: torchvision.transforms).
Currently, there is no clean way to do this since pybind enforces that python strings be utf-8 encoded and as a result we can't pass in arbitrary bytes to a torchscript module.
Supporting the python 'bytes' type in torchscript would be a clean way to support use cases like this.
cc @suo | oncall: jit,triaged,jit-backlog | low | Major |
420,805,826 | vscode | TerminalOptions.waitOnExit API | ```ts
enum WaitOnExitType {
Never = 0,
NonZeroExitCode = 1,
Always = 2
}
export interface TerminalOptions {
/**
* Whether the terminal panel should wait before closing when a terminal's process exits.
*/
waitOnExit?: WaitOnExitType;
}
```
waitOnExit was originally proposed as a boolean in https://github.com/Microsoft/vscode/issues/15583 | feature-request,api,api-proposal,terminal-process | medium | Major |
420,817,011 | godot | Textboxes trap the input using keyboard only | **Godot version:**
3.1 stable
**OS/device including version:**
Windows 10
**Issue description:**
When the user moves with only the keyboard or a joystick pad, if the current focused object is a lineedit or textedit, the user can't leave the textbox using left and right arrows in lineedit and left, right, up, down in case of textedit multiline
The user never should be locked in an input, this default behavior breaks the joystick only games by default, with textedit the only way to leave the textbox is using mouse o keyboard prev/next focus key.
**Steps to reproduce:**
Create a lineedit or textedit.
Add some other nodes at left, right, up, down from textbox.
In line edit case focus the lineedit and try to leave using only left, right.
In textedit case focus the textedit and try to leave using only arrows.
How I expect to be in all textboxes for consistency:
When the caret is after the last character if the user press right again, change focus to right object.
When the caret is before first character if the user press left again, change focus to left object.
When the caret is in the first line and before the first character, if the user press up again, change focus to top object.
When the caret is in the last line and after the last character, if the user press down again, change focus to bot object.
**Minimal reproduction project:**
I applied my idea as a script using the neighbour attributes for lineedit, but it should be the default behavior without using neighbour attributes.
And there are examples without the script with the default godot behavior.
[next_textbox_3.1.zip](https://github.com/godotengine/godot/files/2964602/next_textbox_3.1.zip)
| bug,topic:gui | low | Major |
420,824,657 | go | x/image/tiff: unexpected EOF | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/wh/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/wh/jobs/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/opt/go/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/opt/go/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/d7/9qx1qd7s6wb8hlmw9xtt9h_h0000gn/T/go-build488513078=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
```go
package main
import (
"image"
"os"
"log"
_ "golang.org/x/image/tiff"
)
func main() {
f, err := os.OpenFile("1.tif", os.O_RDONLY, 0644)
if err != nil {
log.Fatal(err)
}
img, format, err := image.Decode(f)
if err != nil {
log.Fatal(err)
}
log.Printf("%v %s", img, format)
}
```
The image is here
[1.tif.zip](https://github.com/golang/go/files/2964703/1.tif.zip)
### What did you expect to see?
### What did you see instead?
unexpected EOF | ExpertNeeded,NeedsInvestigation | low | Critical |
420,829,064 | go | x/build: speed up large container start-up times without pre-pulling containers into VMs (CRFS) | Tracking bug for improving how we maintain & deploy our larger builder environment containers easily and quickly while also having them start up quickly.
Our current situation (building a container, pushing to gcr.io, then automating the creation of a COS-like VM images that has the image pre-pulled) is pretty gross and tedious.
I propose CRFS: a Container-Registry Filesystem. See design doc at https://github.com/golang/build/tree/master/crfs#crfs-container-registry-filesystem
The gist of it is that we can read bytes from gcr.io directly with a FUSE filesystem, rather than doing huge docker pulls. It's not very hard once you tweak the tarballs into a more amenable format. | Performance,Builders,NeedsInvestigation | high | Critical |
420,832,563 | go | cmd/go: more graceful upgrades when a module changes its name | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/cbro/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/cbro/"
GOPROXY=""
GORACE=""
GOROOT="/Users/cbro/sdk/go1.12"
GOTMPDIR=""
GOTOOLDIR="/Users/cbro/sdk/go1.12/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/var/folders/h0/kdykkxh94y1fdv1_yz98yr_w003lw8/T/tmp.ULmCh1W7/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/h0/kdykkxh94y1fdv1_yz98yr_w003lw8/T/go-build671297704=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
While investigating https://github.com/googleapis/google-cloud-go/issues/1359, https://github.com/golang/lint/issues/436, and opening https://github.com/census-instrumentation/opencensus-go/issues/1064, I've found it impossible to figure out how to get almost any of these packages to build and successfully run `go get -u`.
It seems to be a never-ending loop of things depending on slightly older things, which ultimately end up depending on the invalid github.com/golang/lint.
For a lot, but not all (see below) of these packages, I was able to track the chain from github.com/golang/lint up to its depender using `go mod graph`.
Of course, because of MVS, the old version of grpc (and therefore github.com/golang/lint) is never used in the actual build, but for some reason still blocks a successful run of `go get -u`.
```
$ cd $(mktemp -d)
T/tmp.ULmCh1W7 $ ls
T/tmp.ULmCh1W7 $ go mod init m
go: creating new go.mod: module m
T/tmp.ULmCh1W7 $ go get google.golang.org/grpc
go: downloading golang.org/x/net v0.0.0-20180826012351-8a410e7b638d
go: downloading google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8
go: extracting golang.org/x/net v0.0.0-20180826012351-8a410e7b638d
go: downloading golang.org/x/text v0.3.0
go: extracting google.golang.org/genproto v0.0.0-20180817151627-c66870c02cf8
go: extracting golang.org/x/text v0.3.0
T/tmp.ULmCh1W7 $ cat go.mod
module m
go 1.12
require google.golang.org/grpc v1.19.0 // indirect
T/tmp.ULmCh1W7 $ go get -u
go: finding github.com/golang/glog latest
go: finding google.golang.org/genproto latest
go: finding golang.org/x/sync latest
go: finding honnef.co/go/tools latest
go: finding golang.org/x/lint latest
go: finding golang.org/x/oauth2 latest
go: finding golang.org/x/net latest
go: finding golang.org/x/sys latest
go: finding github.com/shurcooL/issuesapp latest
go: finding github.com/google/pprof latest
go: finding golang.org/x/time latest
go: finding golang.org/x/exp latest
go: finding github.com/anmitsu/go-shlex latest
go: finding golang.org/x/tools latest
go: finding github.com/shurcooL/issues latest
go: finding github.com/tarm/serial latest
go: finding golang.org/x/build latest
go: finding github.com/neelance/astrewrite latest
go: finding dmitri.shuralyov.com/state latest
go: finding github.com/shurcooL/httpgzip latest
go: finding github.com/shurcooL/gopherjslib latest
go: finding github.com/shurcooL/htmlg latest
go: finding github.com/shurcooL/component latest
go: finding github.com/google/btree latest
go: finding github.com/shurcooL/reactions latest
go: finding github.com/shurcooL/github_flavored_markdown latest
go: finding github.com/jellevandenhooff/dkim latest
go: finding grpc.go4.org latest
go: finding github.com/shurcooL/highlight_go latest
go: finding dmitri.shuralyov.com/html/belt latest
go: finding go4.org latest
go: finding github.com/shurcooL/notifications latest
go: finding github.com/shurcooL/users latest
go: finding github.com/coreos/go-systemd latest
go: finding golang.org/x/mobile latest
go: finding github.com/BurntSushi/xgb latest
go: finding github.com/shurcooL/webdavfs latest
go: finding github.com/neelance/sourcemap latest
go: finding github.com/shurcooL/go latest
go: finding golang.org/x/crypto latest
go: finding github.com/prometheus/client_model latest
go: finding github.com/flynn/go-shlex latest
go: finding golang.org/x/perf latest
go: finding github.com/prometheus/procfs latest
go: finding dmitri.shuralyov.com/service/change latest
go: finding github.com/jstemmer/go-junit-report latest
go: finding github.com/shurcooL/httpfs latest
go: finding github.com/shurcooL/httperror latest
go: finding github.com/sourcegraph/syntaxhighlight latest
go: finding github.com/beorn7/perks latest
go: finding gopkg.in/check.v1 latest
go: finding github.com/gopherjs/gopherjs latest
go: finding dmitri.shuralyov.com/app/changes latest
go: finding github.com/shurcooL/highlight_diff latest
go: finding github.com/shurcooL/home latest
go: finding github.com/shurcooL/octicon latest
go: finding github.com/sourcegraph/annotate latest
go: finding github.com/gonum/blas latest
go: finding github.com/gonum/internal latest
go: finding github.com/gonum/lapack latest
go: finding github.com/GoogleCloudPlatform/cloudsql-proxy latest
go: finding github.com/gregjones/httpcache latest
go: finding golang.org/x/image latest
go: finding github.com/shurcooL/events latest
go: finding github.com/bradfitz/go-smtpd latest
go: finding github.com/shurcooL/go-goon latest
go: finding github.com/shurcooL/gofontwoff latest
go: finding github.com/golang/lint latest
go: finding github.com/alecthomas/units latest
go: finding github.com/gonum/matrix latest
go: github.com/golang/[email protected]: parsing go.mod: unexpected module path "golang.org/x/lint"
go: finding github.com/eapache/go-xerial-snappy latest
go: finding github.com/mwitkow/go-conntrack latest
go: finding github.com/rcrowley/go-metrics latest
go: finding github.com/aclements/go-moremath latest
go: finding github.com/gonum/floats latest
go get: error loading module requirements
Exit code 1
T/tmp.ULmCh1W7 $ go mod graph | grep golang/lint
Exit code 1
T/tmp.ULmCh1W7 $ go mod graph
m google.golang.org/[email protected]
google.golang.org/[email protected] cloud.google.com/[email protected]
google.golang.org/[email protected] github.com/BurntSushi/[email protected]
google.golang.org/[email protected] github.com/client9/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] github.com/golang/[email protected]
google.golang.org/[email protected] golang.org/x/[email protected]
google.golang.org/[email protected] golang.org/x/[email protected]
google.golang.org/[email protected] golang.org/x/[email protected]
google.golang.org/[email protected] golang.org/x/[email protected]
google.golang.org/[email protected] golang.org/x/[email protected]
google.golang.org/[email protected] golang.org/x/[email protected]
google.golang.org/[email protected] golang.org/x/[email protected]
google.golang.org/[email protected] google.golang.org/[email protected]
google.golang.org/[email protected] google.golang.org/[email protected]
google.golang.org/[email protected] honnef.co/go/[email protected]
```
### What did you expect to see?
`go get -u` succeeds, no mention of github.com/golang/lint because it shouldn't be included due to MVS rules.
### What did you see instead?
| NeedsFix,GoCommand,modules | medium | Critical |
420,854,865 | godot | Soft bodies do not collide with each other | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
<!-- Specify commit hash if non-official. -->
3.1 Stable
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Windows 10 1809 64bit, ver 17763.316
GTX 1080, driver 418.81
**Issue description:**
<!-- What happened, and what was expected. -->
Soft bodies do not collide with other soft bodies. Expected them to collide.
**Steps to reproduce:**
1. Create a soft body and add a plane mesh (Godot internal).
2. Create a soft body sphere (mesh from Blender).
3. Pin the edges of the plane so it acts as a "net".
4. Move the ball on top of the plane and press play. Ball falls through without colliding/getting caught.
Spheres do not collide with each other either (minimal project has 2 spheres and 1 plane).
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
[softbodytest.zip](https://github.com/godotengine/godot/files/2964990/softbodytest.zip)
(Performance is also fairly slow but I'm not sure if it's expected with soft bodies like these. Once both balls are on the ground in the example project I get a lot of lag with an r5 2400g and GTX 1080. Would it be fixed by #22448 ?)
| bug,confirmed,topic:physics | low | Critical |
420,877,133 | go | cmd/go: 'build -o' overwrite behavior differs between Linux and Windows | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12 windows/amd64
go version go1.12 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
yes
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
When exec "build -o dst_file" on windows casually, i got an errorοΌ
`go build go-test: build output "dst_file" already exists and is not an object file.`
I found dst_file allready exists and is an empty fileοΌbut it works on linux in the same case.
After reviewed code related build, I found the code snippet:
`b.moveOrCopyFile(a.Target, a1.built, perm, false)`
force is false, and moveOrCopyFile rename src to dst on linux, and not check the param force.
### What did you expect to see?
It should be the same on different os, I think param force should be retain semantically, eg:
<pre>
if err := os.Chmod(src, mode); err == nil {
+ // Be careful about removing/overwriting dst.
+ // Do not remove/overwrite if dst exists and is a directory
+ // or a non-object file.
+ if fi, err := os.Stat(dst); err == nil {
+ if fi.IsDir() {
+ return fmt.Errorf("build output %q already exists and is a directory", dst)
+ }
+ if !force && fi.Mode().IsRegular() && !isObject(dst) {
+ return fmt.Errorf("build output %q already exists and is not an object file", dst)
+ }
+ }
if err := os.Rename(src, dst); err == nil {
if cfg.BuildX {
b.Showcmd("", "mv %s %s", src, dst)
}
return nil
}
}
</pre>
Can someone give me some advice?
:) thanks.
| OS-Windows,NeedsInvestigation | low | Critical |
420,905,054 | pytorch | caffe2 Segmentation fault (core dumped) | I compile caffe2 from source(pytorch) by anaconda3.
operations:
In the pytorch directory,I
mkdir build && cd build
cmake -DCMAKE_PREFIX_PATH=/home/zhengr/.conda/envs/caffe2-source -DCMAKE_INSTALL_PREFIX=/home/zhengr/.conda/envs/caffe2-source ..
sudo make install -j8
there is no error by then.
[100%] Built target caffe2_detectron_ops_gpu
Install the project...
-- Install configuration: "Release"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/bin/protoc" to "$ORIGIN"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libonnxifi_dummy.so" to "$ORIGIN"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libonnxifi.so" to "$ORIGIN"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libfoxi_dummy.so" to "$ORIGIN"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libfoxi.so" to "$ORIGIN"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libc10.so" to "$ORIGIN"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libc10_cuda.so" to "$ORIGIN:/usr/local/cuda/lib64"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libcaffe2.so" to "$ORIGIN:/usr/lib/openmpi/lib:/home/zhengr/.conda/envs/caffe2-source/lib:/usr/local/cuda/lib64"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libcaffe2_gpu.so" to "$ORIGIN:/usr/local/cuda/lib64:/home/zhengr/.conda/envs/caffe2-source/lib:/usr/lib/openmpi/lib"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/python2.7/site-packages/caffe2/python/caffe2_pybind11_state.so" to "$ORIGIN:/home/zhengr/.conda/envs/caffe2-source/lib"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/python2.7/site-packages/caffe2/python/caffe2_pybind11_state_gpu.so" to "$ORIGIN:/usr/local/cuda/lib64:/home/zhengr/.conda/envs/caffe2-source/lib"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libcaffe2_detectron_ops_gpu.so" to "$ORIGIN:/usr/local/cuda/lib64:/home/zhengr/.conda/envs/caffe2-source/lib"
-- Set runtime path of "/home/zhengr/.conda/envs/caffe2-source/lib/libcaffe2_observers.so" to "$ORIGIN:/home/zhengr/.conda/envs/caffe2-source/lib"
when i test "from caffe2.python import core" in python, when in different dictories, I got
(caffe2-source) zhengr@zhengr-ThinkStation-P318:~/data/projects/caffe2-source$ python
Python 2.7.15 | packaged by conda-forge | (default, Feb 28 2019, 04:00:11)
[GCC 7.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from caffe2.python import core
WARNING:root:This caffe2 python run does not have GPU support. Will run in CPU only mode.
Segmentation fault (core dumped)
(caffe2-source) zhengr@zhengr-ThinkStation-P318:~/data/projects/caffe2-source/pytorch$ python
Python 2.7.15 | packaged by conda-forge | (default, Feb 28 2019, 04:00:11)
[GCC 7.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from caffe2.python import core
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
File "caffe2/python/__init__.py", line 2, in <module>
from caffe2.proto import caffe2_pb2
ImportError: cannot import name caffe2_pb2
"Segmentation fault (core dumped)" is the problem I think.
more information:
/usr/local/lib/libboost_random.so.1.62.0
gcc (Ubuntu 4.9.3-13ubuntu2) 4.9.3
what shoud I do? can anyone help me?
| caffe2 | low | Critical |
420,939,222 | godot | FileDialog and EditorFileDialog signals are not fired from EditorScript | **Godot version: 3.1 stable**
<!-- Specify commit hash if non-official. -->
**OS/device including version: macOS 10.14.3 (Mojave)**
<!-- Specify GPU model and drivers if graphics-related. -->
**Issue description:**
If created from `EditorScript`, none of the `FileDialog` or `EditorFileDialog` signals seem to ever fire, except for `about_to_show`.
List of signals that are never fired:
- `modal_closed`
- `hide`
- `popup_hide`
- `confirmed`
- `file_selected`
- `dir_selected`
- `files_selected`
Neither do `pressed` signals of **ok** and **cancel** buttons, obtained from `FileDialog#get_ok()` and `FileDialog#get_cancel()` respectively
**Steps to reproduce:**
Example code to open `FileDialog` from the `EditorScript`:
```
tool
extends EditorScript
#var save_dialog:EditorFileDialog
var save_dialog:FileDialog
func _run():
_open_save_res_dialog()
func _open_save_res_dialog():
var ei:EditorInterface = get_editor_interface()
var vp = ei.get_editor_viewport()
"""
save_dialog = EditorFileDialog.new()
save_dialog.mode = EditorFileDialog.MODE_SAVE_FILE
save_dialog.access = EditorFileDialog.ACCESS_RESOURCES
save_dialog.display_mode = EditorFileDialog.DISPLAY_LIST
"""
save_dialog = FileDialog.new()
save_dialog.mode = FileDialog.MODE_OPEN_FILE
save_dialog.access = FileDialog.ACCESS_RESOURCES
vp.add_child(save_dialog)
save_dialog.get_ok().connect("pressed", self, "_on_ok")
save_dialog.get_cancel().connect("pressed", self, "_on_cancel")
# the only one that actually fires
save_dialog.connect("about_to_show", self, "_on_about_to_show")
save_dialog.connect("modal_closed", self, "_on_modal_closed")
save_dialog.connect("hide", self, "_on_hide")
save_dialog.connect("popup_hide", self, "_on_popup_hidden")
save_dialog.connect("confirmed", self, "_on_confirmed")
save_dialog.connect("file_selected", self, "_on_file_selected")
save_dialog.connect("dir_selected", self, "_on_dir_selected")
save_dialog.connect("files_selected", self, "_on_files_selected")
save_dialog.popup_centered_ratio(0.75)
print(save_dialog.current_dir)
func _on_ok():
print("_on_ok")
func _on_cancel():
print("_on_cancel")
func _on_modal_closed():
print("_on_modal_closed")
func _on_hide():
print("_on_hide")
func _on_about_to_show():
print("_on_about_to_show")
func _on_popup_hidden():
print("_on_popup_hidden")
func _on_confirmed():
print("_on_confirmed")
func _on_file_selected(path):
print("_on_file_selected ", path)
func _on_files_selected(paths):
print("_on_files_selected ", paths)
func _on_dir_selected(dir):
print("_on_dir_selected ", dir)
```
None of the interactions with the file dialog created this way fire any signals mentioned above.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
[FileDialog_Test1.zip](https://github.com/godotengine/godot/files/2965883/FileDialog_Test1.zip)
| discussion,topic:editor | low | Critical |
421,002,780 | neovim | create one-line window / remove local statusline | Some times, I need one line window, such like WinBar of vim8.1 or notebook tabs like gui.
But I found, I can not make one line window, the minimize window has 2 lines, 1 line content and 1 line statusline.
Can nvim provide an option to hide the statusline of the window? | enhancement,ui,ui-extensibility,statusline | low | Major |
421,014,657 | create-react-app | replace dotenv with dotenv-webpack? | ### Is this a bug report?
No
### Description
We are using a .env file to make configuration changes easy between our different environments and it works great.
However, the way that `dotenv` works it not particularly interesting as it:
1. bloats the code (even minified)
2. exposes all environment variables right next to each other (the values will become public anyway, but you don't need them to be right next to each other)
In our codebase, we have a couple of variables and this block is inserted six times into our code:
In a project without create-react-app I've been using dotenv-webpack with great success. It effectively replaces your call to an environment variable with the value itself, minimizing code bloat.
I believe this would be a small change in the code, but I was wondering if there are reasons not to do this? If there is no reason not to switch it, I would like to work on a PR. | issue: proposal | low | Critical |
421,045,558 | TypeScript | Request (probably long-term) type compilation debugger | ## Search Terms
`debug type`, `debug types`, `debug compilation`
## Related
- #3318 about debugging the compiler; with enough knowledge of tsc it probably could be used for this but thatβs quite a barrier
- #29937 about logging types and other strings during compilation
## Suggestion
This is probably a huge amount of work, but as Typescriptβs type system becomes more and more expressive and complex, it also becomes harder to reason about and know why things are not doing what you want (or, sometimes, why they are doing what you want). For more complex type expressions, there is a lot of trial and error, and even when you get it working it can be a complete mystery _why_ itβs now working.
For runtime issues, we have a solution to that: the debugger. For compile-time issues, weβre stuck instead with trying to break up our code into separate types to see the result at each stepβand even that isnβt completely effective, because being a separate alias rather than just in-lined code can actually change behavior!
Obviously, this would be a huge effort. I certainly donβt expect anything like it any time soon. But as a long-term goal, I think itβs only going to become more and more necessary. Already we have cases where Typescript doesnβt reason about types as completely as it could _explicitly because_ we lack a debugger to track it downβsee [Ryanβs comment here](https://github.com/Microsoft/TypeScript/issues/14094#issuecomment-373492422) where `{ type: "foo"; } & { type: "bar"; }` is not narrowed to `never` because of concerns about some conflict deep in the object tree causing the entire type to resolve to an opaque `never` with no way of figuring out why.
So this is kind of a question/suggestion: is this something the TS team is interested in/would like to do βsomeday,β and if not, Iβm suggesting it should be.
## Use Cases
Any complex type.
## Examples
I donβt have specific suggestions for what the debugging would look like. Stepping through a type evaluation in VS Code would be awesome (it has a debugger already for running the code, obviously), but really anything that exposes more of whatβs going on so we can make more informed choices about our types would be good.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Needs Proposal | medium | Critical |
421,060,619 | storybook | Change theme to dark if user has dark mode enabled using prefers-color-scheme media query | Chrome and Safari will soon support the [prefers-color-scheme](https://caniuse.com/#search=prefers-color-scheme%3A) media query. Let's respect that since Storybook has a dark theme already
**Are you able to assist bring the feature to reality?**
yes
| feature request,documentation,theming | medium | Major |
421,147,665 | flutter | After some number of failures, retry pub get with the --offline flag | When I run an app from IntelliJ and my computer is offline, it tries to do a pub get, and fails (this is usually when it has needed to rebuild the flutter tool because I committed a change). It doesn't actually need to fetch anything, however, the data is already in the pub cache. (For that matter, it doesn't need to rebuild flutter either, but...).
Is it possible to just try pub get once, and if the connection isn't there, try and run without fetching anything? Sure, if you don't have your dependencies it'll fail, but it's going to do that anyhow if there is no network. This way, at least if you really did already have the packages you needed, working offline would be a possibility.
So, the repro environment is:
1. Turn off network
1. Make a change to the flutter repo.
2. Commit the change locally.
3. Try to run an app.
4. Flutter command rebuilds, tries to do pub get, and fails after 8 retries (a couple of minutes).
5. Developer cries out in anguish.
What I'd like to see is:
3. Try to run an app
4. Flutter tries `pub get`, fails once, then tries `pub --offline get` and succeeds.
5. App runs. | c: new feature,team,tool,a: annoyance,P3,team-tool,triaged-tool | low | Critical |
421,155,058 | rust | Cannot pass small struct by value across FFI on linux-gnu | I am creating an FFI function that takes a tagged union as a parameter. It corresponds to a Rust enum with variant. The tagged union definition for the C++ code was generated with `cbindgen`. The problem is that the calling convention between Rust's `extern "C"` and the actual C calling convention aren't matching up, so it gets faulty values for the argument.
This looks like it's similar to #5744.
I tried this code:
Rust:
```rust
#[repr(C)]
#[no_mangle]
pub enum SLCArgs {
Add(*const c_char), // borrowed
Count,
Print,
}
#[no_mangle]
// works if changed to extern "Rust"
pub unsafe extern "C" fn StringListContainer_do(slc_p : *mut StringListContainer, m : SLCArgs) {
let slc = &mut *(slc_p);
match m {
SLCArgs::Count => println!("{}", slc.Count()),
SLCArgs::Add(cstr) => StringListContainer_Add(slc_p, cstr),
SLCArgs::Print => slc.print(),
}
}
```
bindings.h:
```cpp
struct StringListContainer;
struct SLCArgs {
enum class Tag {
Add,
Count,
Print,
};
struct Add_Body {
const char *_0;
};
Tag tag;
union {
Add_Body add;
};
};
extern "C" {
void StringListContainer_do(StringListContainer *slc_p, SLCArgs m);
//...
} // extern "C"
```
C++:
```cpp
int main() {
StringListContainer* slc = new_StringListContainer();
StringListContainer_do(slc, {SLCArgs::Tag::Add, {"top text"}});
StringListContainer_do(slc, {SLCArgs::Tag::Add, {"middle text"}});
StringListContainer_do(slc, {SLCArgs::Tag::Add, {"bottom text"}});
StringListContainer_do(slc, {SLCArgs::Tag::Count, {}});
StringListContainer_do(slc, {SLCArgs::Tag::Print, {}});
}
```
I expected to see this happen:
```
3
top text
middle text
bottom text
```
Instead, this happened:
It prints nothing out because Rust believes that the struct was placed in the argument build area of the stack, just above the return address. In reality, since this is a small struct, it was placed in the second and third registers `%rsi` `%rdx`.
[According to this interpretation](https://cs61.seas.harvard.edu/site/2018/Asm2/) of the System V AMD64 ABI, structs between 2-4 words are passed sequentially through registers. Although, according to [some experimentation](https://www.godbolt.org/z/GSRD1g), it looks like any struct over 2 words is also passed on the stack.
Looking at the assembly, the first SLCArgs was initialized on the stack in the argument build area just by chance, so the values that Rust reads when it looks for the struct is `Add("top text")`. However, this happens every time we call `StringListContainer_do`, so we never print anything out, just keep adding the first string.
However, this does work on Windows-MSVC and on Linux-GNU *but only* if you mark StringListContainer_do as `extern "Rust"`. Just `extern` and `extern "C"` will not work.
The repo for this code is [here](https://github.com/andrewhu-uw/rust_rr_test), if that helps
## Meta
`rustc --version --verbose`:
```
rustc 1.33.0 (2aa4c46cf 2019-02-28)
binary: rustc
commit-hash: 2aa4c46cfdd726e97360c2734835aa3515e8c858
commit-date: 2019-02-28
host: x86_64-unknown-linux-gnu
release: 1.33.0
LLVM version: 8.0
``` | O-linux,A-FFI,O-x86_64,T-compiler,C-bug | low | Major |
421,161,011 | rust | Document and clean up ty::print some more. | In order to get #58140 merged before it bitrots again, and needs an eleventh rebase, I've left some of the review comments (by @nikomatsakis) unresolved.
There's also a few things, such as const generics, `$(...)?` in macros, etc. that weren't possible when the PR was originally authored, but can be taken into account now. | C-cleanup,A-pretty,T-compiler | low | Minor |
421,164,857 | flutter | findsOneWidget erroneously passes for DropdownMenuItem that is off screen under DropdownButton. | ## Steps to Reproduce
* Create a Mobile app project for Flutter in Android Studio
* Create a unit test in a new my_test.dart file:
```
import 'package:flutter/material.dart';
import 'package:flutter_test/flutter_test.dart';
Future void main() async {
testWidgets('drop down value', (tester) async {
final Widget myWidget = DropdownButtonHideUnderline(
child: DropdownButton<String>(
isExpanded: true,
value: '123', // ********* Actual selected value visible on screen, '123'
onChanged: (_) => print(_),
items: ['123', '456', '789'].map( // ********* Creating list of values in drop down: 123, 456, 789
(value) {
return DropdownMenuItem(
value: value,
child: Text(value?.toString() ?? 'hint'),
);
},
).toList(),
),
);
await pumpMaterial(tester, myWidget);
expect(find.text('123'), findsOneWidget); // ********* Passes
expect(find.text('456'), findsOneWidget); // ********* Passes
expect(find.text('789'), findsOneWidget); // ********* Passes
});
}
Future<void> pumpMaterial(WidgetTester tester, Widget widget) async {
final app = MaterialApp(
home: Material(
child: Center(
child: widget,
),
),
);
await tester.pumpWidget(app);
}
```
* Run the test.
* **Actual result:**
All 3 "expect" checks pass, the test passes and shows up green.
* **Expected result:**
Only the check for string '123' should pass, others should fail, as their text is not visible on the screen.
## Logs
Log:
```
Testing started at 8:49 AM ...
/Users/acherkashyn/Flutter/flutter/bin/flutter --no-color test --machine --plain-name "drop down value" test/my_test.dart
```
flutter analyze:
```
Analyzing app...
No issues found! (ran in 5.0s)
```
flutter doctor -v:
```
[β] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.3 18D42, locale en-US)
β’ Flutter version 1.2.1 at /Users/acherkashyn/Flutter/flutter
β’ Framework revision 8661d8aecd (4 weeks ago), 2019-02-14 19:19:53 -0800
β’ Engine revision 3757390fa4
β’ Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /Users/acherkashyn/Library/Android/sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-28, build-tools 28.0.3
β’ ANDROID_HOME = /Users/acherkashyn/Library/Android/sdk
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
β’ All Android licenses accepted.
[β] iOS toolchain - develop for iOS devices (Xcode 10.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 10.1, Build version 10B61
β’ ios-deploy 1.9.4
β’ CocoaPods version 1.6.1
[β] Android Studio (version 3.3)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 33.3.1
β’ Dart plugin version 182.5215
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
[β] IntelliJ IDEA Community Edition (version 2018.3.4)
β’ IntelliJ at /Applications/IntelliJ IDEA CE.app
β’ Flutter plugin version 32.0.3
β’ Dart plugin version 183.5901
[β] VS Code (version 1.31.1)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β’ Flutter extension version 2.23.0
[β] Connected device (1 available)
β’ iPhone XR β’ F6F6EA6E-9B25-44D7-AA86-0221686AE960 β’ ios β’ iOS 12.1 (simulator)
β’ No issues found!
```
| a: tests,framework,f: material design,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-design,triaged-design | low | Minor |
421,171,314 | flutter | The engine should be tested with AddressSanitizer | engine,P2,team-engine,triaged-engine | low | Minor |
|
421,186,618 | kubernetes | emptyDir persistent volumes | **What would you like to be added**:
I need a volume accessible from different pods on each node, serving as a **shared file cache**. In my case it should be a `tmpfs` volume to provide maximum speed, so I'd use `emptyDir` with `medium: Memory`.
Therefore I'd like `emptyDir` to be available in `PersistentVolumeSpec` just like all other volume sources.
**Why is this needed**:
Currently (AFAIK) the only way to achieve this is to:
- `mkdir` on each node's host filesystem at some predefined path
- optionally mount a `tmpfs` volume there
- create a `PersistentVolume` of type `hostPath` or `local` to mount that path
This method seems very "un-kubernetic" to me and could be easily automated.
Even pure Docker can do this:
```
docker volume create --driver local --opt type=tmpfs --opt device=tmpfs \
--opt o=size=100m,uid=1000 foo
```
There is an old similar issue #27732 but I don't think it has to be limited to `tmpfs` only. | sig/storage,kind/feature,lifecycle/frozen | medium | Critical |
421,221,336 | TypeScript | Confusing error message for labels used before definition | The following gives me an unexpected "TS1007: Jump target cannot cross function boundary error" in TS 3.3.33333
```
function foo() {
for (let i = 0; i < 10; i++) {
console.log(`${i}`);
continue loopend;
}
loopend:
console.log('end of loop');
}
```
Further investigation... you can jump to the start of the loop, so the error I would argue is that the error message is confusing.
[shareable link](https://www.typescriptlang.org/play/#src=%0D%0Afunction%20foo()%20%7B%0D%0A%20%20%20%20for%20(let%20i%20%3D%200%3B%20i%20%3C%2010%3B%20i%2B%2B)%20%7B%0D%0A%20%20%20%20%20%20%20%20console.log(%60%24%7Bi%7D%60)%3B%0D%0A%20%20%20%20%20%20%20%20continue%20loopend%3B%0D%0A%20%20%20%20%7D%0D%0A%0D%0A%20%20%20%20loopend%3A%0D%0A%20%20%20%20console.log('end%20of%20loop')%3B%0D%0A%7D%0D%0A) | Suggestion,Help Wanted,Good First Issue,Effort: Moderate,Domain: Error Messages,Domain: Related Error Spans,Experience Enhancement,PursuitFellowship | low | Critical |
421,226,079 | scrcpy | View X Y coordinates | On occasion it is nice to automate a few things using ADB/monkeyrunner, but the process to get the X/Y coordinates to simulate touches can be a pain. It would really cool to integrate this somehow. Previous implementations have done this (e.g. droid@screen, Monkeyrunner Recorder). Great tool, thanks! | feature request | low | Minor |
421,238,879 | flutter | CustomPaint instances are really hard to test. | Our finders assume they will take a list of elements and evaluate to a list of elements.
CustomPaint is fine with this if you're looking for a `child` of it, but not if you want to find (for example) semantic information it baked into the `foreground` or `background`. In that case, the semantics no longer correspond to elements, and our finders all work with elements, and most of our test actions take finders. | a: tests,framework,a: quality,P2,team-framework,triaged-framework | low | Minor |
421,243,788 | flutter | Path.combine() is Not Precise when intersecting Paths with another Path. | I am using the `Path.combine()` operation to find all the intersecting `Paths` with another `Path`.
The necessary code:
```
Rect intersectPathBounds = intersectPath.getBounds();
_paths.forEach((Path path, PenInfo penInfo) {
if (path.getBounds().overlaps(intersectPathBounds )) {
Path intersection = Path.combine(
PathOperation.intersect, intersectPath, path);
if (!intersection.getBounds().isEmpty) {
if (intersection.computeMetrics().any((ui.PathMetric metric) => metric.length > 0)) {
penInfo.penColor = Colors.red;
}
}
}
}
});
```
Sometimes on small `Paths` even if they are clearly overlapping the `Path.combine()` does not return the expected result.
I drew some `Paths`.
Now I am drawing the `Path` that should change the color of each intersected `Path` to red.
As you can see some of the intersected Paths stay black (In the blue squares. Instead they should be colored red.
Also there are `Paths` that return intersections even if the `Paths` are not actually intersecting (they are not even close).
```
My flutter doctor:
[β] Flutter (Channel stable, v1.2.1, on Microsoft Windows [Version 10.0.17134.648],
locale de-DE)
β’ Flutter version 1.2.1 at G:\Flutter\flutter
β’ Framework revision 8661d8aecd (4 weeks ago), 2019-02-14 19:19:53 -0800
β’ Engine revision 3757390fa4
β’ Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at G:\AndroidSDK
β’ Android NDK location not configured (optional; useful for native profiling
support)
β’ Platform android-28, build-tools 28.0.3
β’ ANDROID_SDK_ROOT = G:\AndroidSDK
β’ Java binary at: G:\Android\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
β’ All Android licenses accepted.
```
I also checked with flutter version 1.1.8, this issue already existed. | engine,dependency: skia,a: quality,P3,team-engine,triaged-engine | medium | Critical |
421,249,886 | opencv | imgcodecs: avoid vulnerabilities in Jasper codec (JPEG-2000) | Jasper project has many opened vulnerabilities which are not get fixed for a long time.
Especially in version 1.900 which is used by OpenCV.
It is not safe to open external/untrusted JPEG-2000 images via `imread()`/`imdecode()`.
Perhaps it is not save to use encoder too via `imwrite()`/`imencode()`.
Possible alternative to Jasper codec is [OpenJPEG](https://github.com/uclouvain/openjpeg), which should replace Jasper in OpenCV in the future.
Changes:
- Add runtime option `OPENCV_IO_ENABLE_JASPER`.
Turned **OFF** by default (for current outdated code of Jasper 1.900).
Prevents calling of Jasper code from OpenCV, prints warning message with the link on this issue.
Users are still able to turn ON this option during runtime. **Use it at your own risk!**
**PR**: https://github.com/opencv/opencv/pull/14059
OpenCV versions: 3.4.6+ / 4.1.0+
- Change CMake defaults: BUILD_JASPER=OFF.
TBD
- Change CMake defaults: WITH_JASPER=OFF
TBD
---
- Jasper has been excluded from Ubuntu 18.04 distribution ([Ubuntu 16.04 package](https://packages.ubuntu.com/xenial/libjasper1))
- relates #5849 | bug,category: imgcodecs | low | Major |
421,274,633 | puppeteer | Modified request headers don't appear in response.request().headers() | I'm doing something relatively simple in the request interception:
```javascript
const headers = request.headers();
const modifiedHeaders = { ...headers, "x-new-header": "true" };
request.continue({ headers: modifiedHeaders });
```
However, later, when I receive the callback for the response, this header is missing from the associated request:
```javascript
response.request().headers()["x-new-header"] !== "true";
```
I am trying to mark the request as modified so that later in the response I know this was one of my intercepted requests. | feature | low | Minor |
421,313,983 | flutter | Deeper integration for package:test running on device | Relates to #26080
Right now you can run package:test tests on a device using Flutter driver but there's no easy way to get reports of failed tests and notify the host about them. In the meantime we can check the logs output for "Some tests failed."
Support for getting more fine-grained test reports could probably be added with some effort, either with Flutter driver or native testing frameworks (Espresso/XCUITest).
Creating as a tracking issue for pull requests relating to notifying the test runner about on-device test results. | c: new feature,tool,t: flutter driver,P3,team-tool,triaged-tool | low | Critical |
421,394,472 | godot | Errors when Godot try to import files which contains in name unallowed characters | **Godot version:**
Godot 3.1
**OS/device including version:**
Ubuntu 18.04
**Issue description:**
When I put into godot project, folders with names like :::\\::: (kopia) or ::::\\::Zdj?>, then Godot show a lot of errors:
```
ERROR: _scan_filesystem: Condition ' split.size() != 3 ' is true. Continuing..:
At: editor/editor_file_system.cpp:237.
ERROR: _get_modified_time: Failed to get modified time for: res://::::\\::Zdj (kopia)
At: drivers/unix/file_access_unix.cpp:292.
ERROR: _scan_new_dir: Cannot go into subdir: new folder
At: editor/editor_file_system.cpp:736.
```
I think that godot should change name all of names which contains unallowed characters to corrent, like "::::??Zdjecia" -> "Zdjecia"
**Minimal reproduction project:**
[FFFFFFFFFFFFFFFFFFFF.zip](https://github.com/godotengine/godot/files/2969941/FFFFFFFFFFFFFFFFFFFF.zip)
| enhancement,topic:editor,usability | low | Critical |
421,394,991 | rust | ARM needs a "thumb-state" target-feature to fix a recent breakage that `stdsimd` caused. | So recently [stdsimd added an intrinsic](https://github.com/rust-lang-nursery/stdsimd/issues/702) that was too liberal. The intrinsic needs to only be allowed in in [specific circumstances](https://github.com/rust-lang-nursery/stdsimd/issues/702#issuecomment-471179422), like so:
```rust
#[cfg(any(not(target_feature = "thumb-state"), target_feature = "v6t2"))]
```
Unfortunately we [don't currently](https://github.com/rust-lang-nursery/stdsimd/pull/704#discussion_r264111187) have a "thumb-mode" feature.
@gnzlbg said that before a PR for this change we should first have an issue with a ping to @parched, @Amanieu, and @japaric , so that everyone can be on the same page about how to proceed.
**EDIT:** Within official ARM docs, using ARM or Thumb code is called the "state", not "mode", so we should stick with that naming system. The CPU's "mode" is reserved for a different concept. | O-Arm,T-compiler | low | Minor |
421,405,528 | godot | Conversion of Sprite using region to MeshInstance2D broken | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
3.1-stable
**OS/device including version:**
Windows 10
**Issue description:**
When converting a Sprite that uses region to MeshInstance2D, the resulting mesh is broken:
**Steps to reproduce:**
* Add a sprite with region to scene
* Click "convert to 2d mesh"
**Minimal reproduction project:**
Get [Minimal reproduction project](https://github.com/lekoder/godot-issue-broken-sprite-to-mesh-convert) and try to convert the sprite.
| bug,topic:editor,confirmed | low | Critical |
421,414,192 | pytorch | cuDNN error when using 3d convolutions | ## π Bug
The following simple script: https://gist.github.com/vlasenkov/b3aa7c12570fe0056fca3421453470ca crashes with the following traceback:
```
Traceback (most recent call last):
File "models/unet/test.py", line 126, in <module>
loss.backward()
File "/opt/conda/lib/python3.6/site-packages/torch/tensor.py", line 102, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph)
File "/opt/conda/lib/python3.6/site-packages/torch/autograd/__init__.py", line 90, in backward
allow_unreachable=True) # allow_unreachable flag
RuntimeError: cuDNN error: CUDNN_STATUS_EXECUTION_FAILED
```
## To Reproduce
Run the code above on single GPU.
## Expected behavior
The script just successfully finishes.
## Environment
```
Collecting environment information...
PyTorch version: 1.0.1.post2
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Ubuntu 16.04.5 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
CMake version: version 3.5.1
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.0.130
GPU models and configuration:
GPU 0: Tesla V100-DGXS-32GB
GPU 1: Tesla V100-DGXS-32GB
GPU 2: Tesla V100-DGXS-32GB
GPU 3: Tesla V100-DGXS-32GB
Nvidia driver version: 410.79
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.7.4.1
Versions of relevant libraries:
[pip] Could not collect
[conda] blas 1.0 mkl
[conda] magma-cuda100 2.1.0 5 local
[conda] mkl 2019.0 118
[conda] mkl-include 2019.0 118
[conda] mkl_fft 1.0.6 py36h7dd41cf_0
[conda] mkl_random 1.0.1 py36h4414c95_1
[conda] pytorch 1.0.1 py3.6_cuda10.0.130_cudnn7.4.2_2 pytorch
[conda] torch 1.0.0a0 pypi_0 pypi
[conda] torchtext 0.3.0 pypi_0 pypi
[conda] torchvision 0.2.1 pypi_0 pypi
```
| module: dependency bug,module: cudnn,triaged | low | Critical |
421,537,582 | godot | Creating and Saving Mono Nodes Fails | **Godot version:**
3.1
**Issue description:**
Given a C# class "NodeScript" which inherits from Node, I expected the following to work:
```
var node = new NodeScript();
var packedScene = new PackedScene();
packedScene.Pack(node);
var restoredNode = (NodeScript) packedScene.Instance();
```
But the restoredNode loses the association with NodeScript upon being loaded. When I save the PackedScene to a file (my actual intent), I also see that the Node is saved with a CSharpScript association, but no actual association to the subclass.
I think the saved scene exhibits #17689, but the underlying issue is that the Ctor of NodeScript doesn't actually associate the right script with the node.
Minimal project:
[ScriptChange.zip](https://github.com/godotengine/godot/files/2971435/ScriptChange.zip)
| bug,topic:dotnet | low | Minor |
421,544,855 | bitcoin | Feature request: bitcoin-wallet tool: don't modify files unless requested | When only getting info for a wallet with the bitcoin-wallet tool, I was surprised to find it changing the file modification time (but happy that it didn't also seem to modify the file contents):
```bash
$ stat --format=%Y /tmp/test.dat ; sha256sum /tmp/test.dat
1552658778
8d932caabee0dc8d42c7ea362fb685325bd23f217557135282279f5b14233eec /tmp/test.dat
$ bitcoin/src/bitcoin-wallet -wallet=/tmp/test.dat info
Wallet info
[...]
$ stat --format=%Y /tmp/test.dat ; sha256sum /tmp/test.dat
1552658867
8d932caabee0dc8d42c7ea362fb685325bd23f217557135282279f5b14233eec /tmp/test.dat
```
Setting the file permissions to read-only also surprisingly causes the tool to fail:
```bash
$ chmod 400 /tmp/test.dat
$ bitcoin/src/bitcoin-wallet -wallet=/tmp/test.dat info
Error loading /tmp/test.dat. Is wallet being used by another process?
```
It also fails on a read-only filesystem even if the permission bits are set to writable:
```bash
$ chmod 600 /tmp/test.dat
$ sudo mount -t tmpfs -o size=10000000 tmpfs /mnt
$ sudo cp -a /tmp/test.dat /mnt
$ sudo mount -o remount,ro /mnt
$ bitcoin/src/bitcoin-wallet -wallet=/mnt/test.dat info
Error loading /mnt/test.dat. Is wallet being used by other process?
$ ls -lh /mnt/test.dat
-rw------- 1 user user 1.4M Mar 15 10:07 /mnt/test.dat
```
I'd expect the tool to open files read-only when it doesn't need to make any modifications in order to *ensure* it doesn't make any modifications. Additionally, I'd expect the tool to be able to examine backup files that have been safeguarded by making them read-only in some way.
See also [IRC discussion](http://www.erisian.com.au/bitcoin-core-dev/log-2019-03-15.html#l-356), including @laanwj mentioning a `DB_RDONLY` flag. | Utils/log/libs | low | Critical |
421,611,545 | storybook | Addons panel position resets on story change | **Describe the bug**
Panel position is being reset to what is specified in the global options.
**To Reproduce**
Steps to reproduce the behavior:
1. Run CRA example (note: `panelPosition: 'right'` is set in the options)
2. Open `/?path=/story/button--with-text`
3. Switch addons panel to the `bottom` mode
4. Open `/?path=/story/button--with-some-emoji`
5. Addons panel position is reset to the `right` mode
**Expected behavior**
Addons panel should be still displayed in the bottom.
**Code snippets**
Looks like the problem is here:
```
// lib/ui/src/core/context.js
api.on(STORY_CHANGED, id => {
const options = api.getParameters(id, 'options');
api.setOptions(options);
});
```
```
// lib/ui/src/core/layout.js
const updatedLayout = {
...layout,
...pick(options, Object.keys(layout)),
...checkDeprecatedLayoutOptions(options),
};
```
`setOptions` is being called after every story change, and `panelPosition` is being reset to what is specified in the options, as `...pick(options, Object.keys(layout)),` overrides whatever is in `layout`.
**System:**
- OS: MacOS
- Device: Macbook Pro 2015
- Browser: chrome
- Framework: react
- Version: 5.1.0-alpha.6
| bug,good first issue,ui | low | Critical |
421,619,693 | TypeScript | source.organizeImports organizes imports to a sort order that tslint complains about | Issue Type: <b>Bug</b>
settings:
"editor.codeActionsOnSave": {
"source.fixAll": true,
"source.organizeImports": true
}
tslint.json:
{
"extends": "tslint-microsoft-contrib",
...
Code:
```ts
import * as cp from 'child_process';
import * as fse from 'fs-extra';
import { IActionContext, parseError } from 'vscode-azureextensionui';
import { ImageNode } from '../explorer/models/imageNode';
import { ext } from '../extensionVariables';
import { docker, DockerEngineType } from './utils/docker-endpoint';
import { ImageItem, quickPickImage } from './utils/quick-pick-image';
import os = require('os');
import vscode = require('vscode');
```
That gives this error:
Auto-fixing the lint issue reorders to this code:
```ts
import * as cp from 'child_process';
import * as fse from 'fs-extra';
import os = require('os');
import vscode = require('vscode');
import { IActionContext, parseError } from 'vscode-azureextensionui';
import { ImageNode } from '../explorer/models/imageNode';
import { ext } from '../extensionVariables';
import { docker, DockerEngineType } from './utils/docker-endpoint';
import { ImageItem, quickPickImage } from './utils/quick-pick-image';
```
Then pressing CTRL+S to save puts it back to the first form, which causes the lint error again.
VS Code version: Code - Insiders 1.33.0-insider (d77d8d561143cc021a82664efc056755c075d070, 2019-03-11T08:47:23.627Z)
OS version: Windows_NT x64 10.0.17763
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Xeon(R) W-2133 CPU @ 3.60GHz (12 x 3600)|
|GPU Status|2d_canvas: enabled<br>checker_imaging: disabled_off<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>rasterization: enabled<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>webgl: enabled<br>webgl2: enabled|
|Memory (System)|31.73GB (16.54GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (13)</summary>
Extension|Author (truncated)|Version
---|---|---
vscode-antlr4|mik|2.1.1
vscode-cosmosdb|ms-|0.10.0
extension-manifest-editor|ms-|0.1.5
azure-account|ms-|0.8.0
csharp|ms-|1.17.1
vscode-typescript-tslint-plugin|ms-|1.0.0
azurerm-vscode-tools|msa|0.5.0
vscode-docker|Pet|0.5.2
vscode-sort-json|ric|1.13.0
scope-info|sie|0.2.0
tmcolor|sle|0.0.1
sort-lines|Tyr|1.8.0
win-ca|uko|2.4.0
</details>
<!-- generated by issue reporter --> | Suggestion,Experience Enhancement | low | Critical |
421,630,412 | go | proposal: database/sql: define a Decimal decompose interface for decimal packages | ## Background
Databases store many types of values. One type of very common value databases store, especially SQL databases, are decimal values. Some databases limit the size of the decimal, while others support arbitrary precision. But common to all is a base10 representation of the decimal number.
Historically handling decimals for `database/sql` and database drivers has been a pain. What types should a driver look for? If a driver looks for a given type and handles it, then it has to import it and depend on it. Or possibly go to the trouble of injecting the various types it handles with some type of type registry. The solution space at present for "library" packages that need to deal with decimals, but may be used by many other applications, is sub-optimal.
There is a history of proposals for including a decimal type into the standard library:
#19787 #12127 #12332 .
Lastly, there are a number of decimal packages. Each implementation has a similar type implementation:
* https://github.com/shopspring/decimal/blob/master/decimal.go#L71
* https://github.com/cockroachdb/apd/blob/master/decimal.go#L33
* https://github.com/ericlagergren/decimal/blob/master/big.go#L35
* https://github.com/hydrogen18/sillyquill/blob/master/dec/dec.go#L51
* https://github.com/processout/decimal/blob/master/decimal.go#L64
* https://github.com/luno/luno-go/blob/master/decimal/decimal.go#L12
* https://pkg.go.dev/github.com/amazon-ion/ion-go/ion#Decimal
Generally each decimal type has a `big.Int` coefficient and an `int32` exponent. All of these types of decimals are arbitrary precision, not fixed size like `decimal128`.
## Proposal
I propose that a common interface is defined for a decimal type that dumps the `big.Int` and int32 exponent. This interface could be defined in the standard library, or agreed upon by each package. This way a SQL driver would need to do a type assertion for the well known interface, dump the value and exponent, and marshal the value to the driver. When scanning a decimal value, it would try to load the value and exponent into the decimal type presented to it.
It may be necessary to also provide some test vectors along with the implementation so the value and exponent are interpreted the same.
The proposed interface:
```Go
// Decimal composes or decomposes a decimal value to and from individual parts.
// There are four separate parts: a boolean negative flag, a form byte with three possible states
// (finite=0, infinite=1, NaN=2), a base-2 little-endian integer
// coefficient (also known as a significand) as a []byte, and an int32 exponent.
// These are composed into a final value as "decimal = (neg) (form=finite) coefficient * 10 ^ exponent".
// A zero length coefficient is a zero value.
// If the form is not finite the coefficient and scale should be ignored.
// The negative parameter may be set to true for any form, although implementations are not required
// to respect the negative parameter in the non-finite form.
//
// Implementations may choose to signal a negative zero or negative NaN, but implementations
// that do not support these may also ignore the negative zero or negative NaN without error.
// If an implementation does not support Infinity it may be converted into a NaN without error.
// If a value is set that is larger then what is supported by an implementation is attempted to
// be set, an error must be returned.
// Implementations must return an error if a NaN or Infinity is attempted to be set while neither
// are supported.
type Decimal interface {
// Decompose returns the internal decimal state into parts.
// If the provided buf has sufficient capacity, buf may be returned as the coefficient with
// the value set and length set as appropriate.
Decompose(buf []byte) (form byte, negative bool, coefficient []byte, exponent int32)
// Compose sets the internal decimal value from parts. If the value cannot be
// represented then an error should be returned.
Compose(form byte, negative bool, coefficient []byte, exponent int32) error
}
```
---
This is the original proposed interface: [out-dated, see this comment or see above](https://github.com/golang/go/issues/30870#issuecomment-477258214).
```
// Form of the number. If this lived in "math/big" it could be typed as "type Form byte".
const (
Finite byte = iota // Normal numbers
NaN
InfiniteNegative
InfinitePositive
)
// DecimalValue is an interface decimal implementations may implement to
// allow easy conversion between various decimal packages. These interfaces
// may also used by packages that need to marshal or unmarshal a decimal value,
// but don't care about the rest of the decimal type.
//
// The decimal value in the finite form is defined as "decimal = coefficient * 10^exponent".
type DecimalValue interface {
// ValueExponent returns the coefficient, exponent, and form of the decimal value.
ValueExponent() (coefficient big.Int, exponent int32, form byte)
// SetValueExponent sets the decimal number's value, exponent, and form.
// If the decimal number does not support the value form (such as Infinite),
// or if the value is larger then a fixed size representation can handle, an error should be returned.
// However, if a decimal supports NaN but not Infinite forms, the Infinite forms
// may be coerced into a NaN.
SetValueExponent(coefficient big.Int, exponent int32, form byte) error
}
```
/cc @mjibson @victorquinn @ericlagergren
If this, or a similar, interface is acceptable to cockroachdb, shopspring, and Eric, I'd be willing to open up PRs to add the methods and some test vectors.
---
Edited proposed interface to include a "form".
| Proposal,Proposal-Hold | high | Critical |
421,638,108 | TypeScript | Including full error range in TSC output | From https://github.com/Microsoft/vscode/issues/70465
**Repo**
1. For the TS code with `strict` enabled:
```ts
const obj = {
prop: Date.now() ? 'str' : undefined
}
obj.prop.toLowerCase();
```
1. Run a tsc task in VS Code to see reported errors (make sure to close the ts file as well)
**Problem**
We currently only report the potential undefined access error on `obj` in the line `obj.prop.toLowerCase();`. The correct range should span `obj.prop`.
The root cause of this is that VS Code's problem matcher does not have the full range of the error from tsc, only the start line and column. Here's the tsc output:
```
src/index.ts:7:1 - error TS2532: Object is possibly 'undefined'.
7 obj.prop.toLowerCase();
~~~~~~~~
```
With the current tsc output, there is also no way to extract the full range of the error.
**Request**
Somewhere in the line `src/index.ts:7:1 - error TS2532: Object is possibly 'undefined'.
`, add the end position as well so that tooling can properly highlight it. We would want to do this in a way that doesn't detract from the error's human readability. This needs some thought | Suggestion,Awaiting More Feedback | low | Critical |
421,672,285 | svelte | Some way of binding bidirectionally to all props in an object, capturing all custom events. | There seems to be no way of bidirectionally binding to all of a component's arbitrary props.
```html
<!-- pass arbitrary props, already there -->
<svelte:component this={someComponent} {...itsProps} />
<!-- get changes to arbitrary props, missing, various potential syntaxes follow -->
<svelte:component this={someComponent} bind:{...itsProps} />
<svelte:component this={someComponent} bind:$$props />
<svelte:component this={someComponent} {...itsProps} on:propsChanged={propHandler} />
```
I would say it could/should also be available outside of `<component/>` to enable generic handling of children.
This would be useful for updating a property tree of components, which could be useful for serializing and deserializing component trees. Also for the particular situation of svelte-subdivide, which would benefit from persisting a prop configuration.
For example, at present [svelte/svelte-subdivide](https://github.com/svelte/svelte-subdivide) can receive a layout property specifying a layout geometry that will instantiate the same component in each Pane, but you can't specify the properties of this object, much less for each indivdual instance.
I'm adding this capability to [it](https://github.com/saabi/svelte-subdivide/tree/child-props). In that version, you can pass arbitrary component props individually to each pane.
_However_, I can't capture those arbitrary props later on if they change.
It could also be useful to capture all custom events in a similar fashion, I have no need for it at present and so far can only think of its usefulness for debugging perhaps.
## Considerations
Should properties from grandchild components be available for serialization as well? How would one choose child props, or props from all descendants?
## Example
The closest I can achieve so far:
https://v3.svelte.technology/repl?version=3.0.0-beta.15&gist=52549b8577ff8f3f47cd25139877d371
But in the example, I'm forced to add logic to Component3.svelte, which ideally would be a generic component with no special custom logic. | feature request,temp-stale | low | Critical |
421,677,187 | flutter | WebView crash: IllegalArgumentException: reasonPhrase can't be empty. | Pretty much any webpage I try to goto craps out with wanting glUtilsParamSize?? maybe thats unrelated but its preventing me from releasing this update to the android play store.
or its
java.lang.IllegalArgumentException: reasonPhrase can't be empty.
I am using pretty much the built in Example from the /example folder
Android 26 Emulator and Android 28 emulators, If the page is simple enough it won't crash but still spam the logs but if its more complex (think images + jquery) it craps out.
`D/ (20167): HostConnection::get() New Host Connection established 0xc3d7dd40, tid 20181
I/flutter (20167): 209.82857142857142
I/flutter (20167): -86.39999999999999
I/flutter (20167): 0.0
I/flutter (20167): 0.0
D/EGL_emulation(20167): eglMakeCurrent: 0xeb9c6a60: ver 2 0 (tinfo 0xd00ff010)
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
I/chromium(20167): [INFO:CONSOLE(2)] "JQMIGRATE: Migrate is installed, version 1.4.1", source: https://example.com/wp-includes/js/jquery/jquery-migrate.min.js?ver=1.4.1 (2)
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
E/eglCodecCommon(20167): glUtilsParamSize: unknow param 0x000085b5
D/AndroidRuntime(20167): Shutting down VM
E/AndroidRuntime(20167): FATAL EXCEPTION: main
E/AndroidRuntime(20167): Process: org.mycompany.myflutterapp, PID: 20167
E/AndroidRuntime(20167): java.lang.IllegalArgumentException: reasonPhrase can't be empty.
E/AndroidRuntime(20167): at android.webkit.WebResourceResponse.setStatusCodeAndReasonPhrase(WebResourceResponse.java:139)
E/AndroidRuntime(20167): at android.webkit.WebResourceResponse.<init>(WebResourceResponse.java:77)
E/AndroidRuntime(20167): at xl.a(PG:292)
E/AndroidRuntime(20167): at afG.handleMessage(PG:67)
E/AndroidRuntime(20167): at android.os.Handler.dispatchMessage(Handler.java:106)
E/AndroidRuntime(20167): at android.os.Looper.loop(Looper.java:193)
E/AndroidRuntime(20167): at android.app.ActivityThread.main(ActivityThread.java:6669)
E/AndroidRuntime(20167): at java.lang.reflect.Method.invoke(Native Method)
E/AndroidRuntime(20167): at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
E/AndroidRuntime(20167): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858)
I/Process (20167): Sending signal. PID: 20167 SIG: 9
Lost connection to device.` | c: crash,platform-android,p: webview,package,P3,team-android,triaged-android | medium | Critical |
421,681,289 | vscode | Settings UI is overwhelming for extensions with lots of settings | Specifically for GitLens, I find the settings ui practically unusable -- mainly because GitLens has LOTS of settings, but also because there is no extension controlled order (alphabetic imo doesn't work well), no extension controlled grouping (other than alphabetic proximity), and more. And since the new settings ui became the default, I've seen an uptick in users running into many issues trying to find settings.
To combat this (and really this was long before there was even a settings ui), GitLens provides its own built-in settings editor which is highly tailored and interactive to help guide users. But users have a very hard time discovering it. And again since the settings ui became the default users think that the vscode settings ui is the same as GitLens' settings editor, even when I explicitly provide the command to be run from the palette.
Given the above, I would *really* love a way from the vscode settings ui, extension page, etc, to at least advertise (or better yet replace/block the built-in ui) and direct people to GitLens' settings editor. Maybe something like a mini-banner with a link or something to guide a user to a much better experience.
/cc @roblourens
| feature-request,settings-editor | medium | Major |
421,685,848 | neovim | filter :bufdo with regex pattern | I'd like to request a new feature where ex commands like `:bufdo` `:tabdo` `:windo` would accept optional regex parameter to filter the scope.
| enhancement,core | low | Minor |
421,693,283 | create-react-app | Feature request: importing json from sass | It would be great to have out of the box support for import JSON files in SASS/CSS Modules. One source of truth for configurations. Perhaps something like this:
https://github.com/Updater/node-sass-json-importer
| issue: proposal | low | Minor |
421,697,565 | flutter | [Flutter Driver] How to submit a TextField? | ## Steps to Reproduce
1. Create a TextField inside the app with an onSubmitted handler.
2. Write a driver test case that inputs text into it
(so far, this works flawlessly)
But now what, how can I submit the TextField to trigger onSubmitted without creating a separate UI element that does that when tapped?
```
[β] Flutter (Channel stable, v1.2.1, on Microsoft Windows [Version 10.0.17134.648], locale en-DE)
β’ Flutter version 1.2.1 at G:\FlutterSDK
β’ Framework revision 8661d8aecd (4 weeks ago), 2019-02-14 19:19:53 -0800
β’ Engine revision 3757390fa4
β’ Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at G:\AndroidSDK
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-28, build-tools 28.0.3
β’ ANDROID_HOME = G:\AndroidSDK
β’ Java binary at: G:\Program Files\Android Studio\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
β’ All Android licenses accepted.
[β] Android Studio (version 3.3)
β’ Android Studio at G:\Program Files\Android Studio
β’ Flutter plugin version 33.3.1
β’ Dart plugin version 182.5215
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
[β] Connected device (1 available)
β’ Android SDK built for x86 β’ emulator-5554 β’ android-x86 β’ Android 9 (API 28) (emulator)
β’ No issues found!
```
| a: tests,framework,t: flutter driver,c: proposal,P2,team-framework,triaged-framework | low | Major |
421,703,413 | rust | Consider appending to CLI list arguments rather than overwriting | Right now with (at least) `-C` and `-Z` command line arguments that are lists, specifying the argument multiple times _overwrites_ the earlier options. It probably would be more logical to _append_ to that list, but this may be a breaking change for stable flags. | C-enhancement,T-compiler | low | Minor |
421,712,380 | create-react-app | [internal] e2e:docker tests fails on lerna publish (works running each test suite separately) | First of all, thanks to all of you for the incredible job you've done with this project!
I tried to run `yarn e2e:docker`, both with and without the `--test-suite=all` flag and the second test suite (`./tasks/e2e-kitchensink.sh`) always fails. However, when running the tests separately, they all pass, including `e2e-kitchensink`. Also, when changing the order of the test suites in `tasks/local-test.sh` it is always the second the one that fails.
I believe it's because after `e2e-simple.sh` has run, the packages are published to the local npm registry (verdaccio), and this is not cleared after the test has finished running. So when the second test suite runs, it tries to publish packages with the same version numbers as the ones published by the first test suite.
```
+ git clean -df
Removing yarn.lock
+ ./tasks/publish.sh --yes '--force-publish=*' --skip-git --cd-version=prerelease --exact --npm-tag=latest
+ cd ..
+ root_path=/home/node/create-react-app
+ '[' -z true ']'
++ git status --porcelain
+ '[' -n '' ']'
+ cd packages/react-error-overlay/
+ npm run build:prod
> [email protected] build:prod /home/node/create-react-app/packages/react-error-overlay
> cross-env NODE_ENV=production node build.js
Cleaned up the lib folder.
Compiling iframeScript.js
Hash: 72a9fa7b4fa42cd3b99e
Time: 5118ms
Built at: 2019-03-15 21:14:31
Asset Size Chunks Chunk Names
iframe-bundle.js 274 KiB 0 [emitted] main
Entrypoint main = iframe-bundle.js
Compiling index.js
Hash: 0af3a2eb73eabe4e1fae
Time: 359ms
Built at: 2019-03-15 21:14:32
Asset Size Chunks Chunk Names
index.js 326 KiB 0 [emitted] [big] main
Entrypoint main [big] = index.js
Compiled successfully!
+ cd ../..
+ otp=
+ '[' -z true ']'
+ NPM_CONFIG_OTP=
+ ./node_modules/.bin/lerna publish --independent --npm-client=npm --yes '--force-publish=*' --skip-git --cd-version=prerelease --exact --npm-tag=latest
lerna info version 2.9.1
lerna info versioning independent
lerna info Checking for updated packages...
lerna info Comparing with [email protected].
lerna info Checking for prereleased packages...
Changes:
- babel-plugin-named-asset-import: 0.3.1 => 0.3.2-0
- babel-preset-react-app: 7.0.2 => 7.0.3-0
- confusing-browser-globals: 1.0.6 => 1.0.7-0
- create-react-app: 2.1.8 => 2.1.9-0
- eslint-config-react-app: 3.0.8 => 3.0.9-0
- react-app-polyfill: 0.2.2 => 0.2.3-0
- react-dev-utils: 8.0.0 => 8.0.1-0
- react-error-overlay: 5.1.4 => 5.1.5-0
- react-scripts: 2.1.8 => 2.1.9-0
lerna info auto-confirmed
lerna info publish Publishing packages to npm...
lerna ERR! publish Retrying failed publish: confusing-browser-globals
lerna ERR! publish Retrying failed publish: babel-plugin-named-asset-import
lerna ERR! publish Retrying failed publish: babel-preset-react-app
lerna ERR! publish Retrying failed publish: create-react-app
lerna ERR! publish Retrying failed publish: confusing-browser-globals
lerna ERR! publish Retrying failed publish: babel-plugin-named-asset-import
lerna ERR! publish Retrying failed publish: babel-preset-react-app
lerna ERR! publish Retrying failed publish: create-react-app
lerna ERR! publish Retrying failed publish: babel-preset-react-app
lerna ERR! publish Retrying failed publish: confusing-browser-globals
lerna ERR! publish Retrying failed publish: babel-plugin-named-asset-import
lerna ERR! publish Retrying failed publish: create-react-app
lerna ERR! publish Retrying failed publish: babel-plugin-named-asset-import
lerna ERR! publish Retrying failed publish: confusing-browser-globals
lerna ERR! publish Retrying failed publish: babel-preset-react-app
lerna ERR! publish Retrying failed publish: create-react-app
lerna ERR! publish Ran out of retries while publishing confusing-browser-globals Error: Command failed: npm publish --tag latest
lerna ERR! publish npm notice
lerna ERR! publish npm notice package: [email protected]
lerna ERR! publish npm notice === Tarball Contents ===
lerna ERR! publish npm notice 427B package.json
lerna ERR! publish npm notice 1.0kB index.js
lerna ERR! publish npm notice 1.1kB LICENSE
lerna ERR! publish npm notice 1.2kB README.md
lerna ERR! publish npm notice === Tarball Details ===
lerna ERR! publish npm notice name: confusing-browser-globals
lerna ERR! publish npm notice version: 1.0.7-0
lerna ERR! publish npm notice package size: 2.0 kB
lerna ERR! publish npm notice unpacked size: 3.7 kB
lerna ERR! publish npm notice shasum: 179cbb21ab06f646a1904443d998aeb218127e34
lerna ERR! publish npm notice integrity: sha512-W63Df7oGlVMxA[...]djV0m03FFwJgQ==
lerna ERR! publish npm notice total files: 4
lerna ERR! publish npm notice
lerna ERR! publish npm ERR! code EPUBLISHCONFLICT
lerna ERR! publish npm ERR! publish fail Cannot publish over existing version.
lerna ERR! publish npm ERR! publish fail Update the 'version' field in package.json and try again.
lerna ERR! publish npm ERR! publish fail
lerna ERR! publish npm ERR! publish fail To automatically increment version numbers, see:
lerna ERR! publish npm ERR! publish fail npm help version
lerna ERR! publish
lerna ERR! publish npm ERR! A complete log of this run can be found in:
lerna ERR! publish npm ERR! /home/node/.npm/_logs/2019-03-15T21_14_36_841Z-debug.log
lerna ERR! publish
lerna ERR! publish at Promise.all.then.arr (/home/node/create-react-app/node_modules/lerna/node_modules/execa/index.js:236:11)
lerna ERR! publish at <anonymous>
lerna ERR! publish at process._tickCallback (internal/process/next_tick.js:189:7)
lerna ERR! execute callback with error
lerna ERR! Error: Command failed: npm publish --tag latest
lerna ERR! npm notice
lerna ERR! npm notice package: [email protected]
lerna ERR! npm notice === Tarball Contents ===
lerna ERR! npm notice 427B package.json
lerna ERR! npm notice 1.0kB index.js
lerna ERR! npm notice 1.1kB LICENSE
lerna ERR! npm notice 1.2kB README.md
lerna ERR! npm notice === Tarball Details ===
lerna ERR! npm notice name: confusing-browser-globals
lerna ERR! npm notice version: 1.0.7-0
lerna ERR! npm notice package size: 2.0 kB
lerna ERR! npm notice unpacked size: 3.7 kB
lerna ERR! npm notice shasum: 179cbb21ab06f646a1904443d998aeb218127e34
lerna ERR! npm notice integrity: sha512-W63Df7oGlVMxA[...]djV0m03FFwJgQ==
lerna ERR! npm notice total files: 4
lerna ERR! npm notice
lerna ERR! npm ERR! code EPUBLISHCONFLICT
lerna ERR! npm ERR! publish fail Cannot publish over existing version.
lerna ERR! npm ERR! publish fail Update the 'version' field in package.json and try again.
lerna ERR! npm ERR! publish fail
lerna ERR! npm ERR! publish fail To automatically increment version numbers, see:
lerna ERR! npm ERR! publish fail npm help version
lerna ERR!
``` | tag: internal | low | Critical |
421,718,015 | puppeteer | SOCKS proxy authentication | According to [this comment](https://github.com/GoogleChrome/puppeteer/issues/426#issuecomment-345830027), `page.authenticate` doesn't work for SOCKS proxy.
We should make `page.authenticate` more capable to drive auth for proxies and servers. | feature | medium | Critical |
421,719,658 | rust | #[panic_handler] does not work with std. | The `#[panic_handler]` attribute does not work when using the std library. Thus, there's no way for libraries to register custom panic handlers without resorting to a lazy_static or similar global initializer.
This seems like quite an oversight. | T-lang | low | Major |
421,749,239 | pytorch | [JIT Script] Need support on distributions.Categorical. | ## π Feature
Need jit script module to support `torch.distributions.Categorical`.
## Motivation
Our generative model need a sample layer during inference. Currently we are missing sampling support for script model.
## Alternatives
Categorical is a simple method to implement, we can implement a less performant workaround as below:
E.g:
We wish to have:
sample = torch.distributions.Categorical(posterior).sample().float()
This is equivalent to:
sample = 0
sum = posterior[0]
rand = torch.rand(1).squeeze()
while bool(torch.lt(sum, rand)):
sample += 1
sum += posterior[sample]
sample = torch.tensor(sample).cpu().float()
Just found a functional call that I didn't noticed before, this can solve my current problem perfectly:
sample = torch.multinomial(posterior, 1).squeeze().cpu()
We can live with the second solution for now. But it's slow and eventually can be an issue.
## Additional context
The main issue is `torch.distributions.Categorical` is a class, we need to initialize it with different posterior (and get only one sample) in each inference step. And jit script does not support class object initialization. Can we make a function to take a posterior as parameter and sample directly from it?
cc @suo | oncall: jit,triaged | low | Major |
421,759,286 | pytorch | torch.flip is inconsistent with np.flip and also uses `dims` arg instead of `dim` | Functions like `torch.sum` and `torch.mean` support multi-dim through argument `dim` accepting a tuple or a list.
`torch.flip` instead asks for an argument named `dims`. Yes, it doesn't do reduction, but still it processes multiple dimensions, for the sake of consistency, I propose it supports `dim` as well (and maybe `dims` may be deprecated).
https://pytorch.org/docs/master/torch.html#torch.flip says that `dims (a list or tuple) β axis to flip on` is a list or tuple, but in fact a scalar works as well, so explicit `x.flip(dim = 1)` does make sense.
Same for `torch.rot90`, `torch.roll` and `torch.tensordot` (along with `torch.flip` they are the only 4 functions to use argument name `dims`)
cc @mruberry @rgommers | triaged,module: numpy,function request | low | Major |
421,762,688 | go | net/http: document that context cancellation does not apply to writable bodies | https://github.com/golang/go/issues/26937
To enable http.ReverseProxy to cleanly support websocket connections, http.Transport began returning writable response bodies.
This is documented. But what's undocumented is how this response body deals with the request context's cancellation.
See https://github.com/golang/go/issues/26101
Right now, the documentation says the cancellation of the request context will cause the response body to close, even if it is writable. However, this is not the case. If a writable response body is returned, cancellation of the request context does not affect it. This is certainly the right behaviour but should be documented. | Documentation,NeedsInvestigation | low | Major |
421,773,595 | vue | v-on listeners array | ### What problem does this feature solve?
Two components with scoped slots that provide events to a child component. If they are used together some listeners may be overwritten if not normalised first.
```html
<v-menu>
<template #activator="{ on: menu }">
<v-tooltip bottom>
<template #activator="{ on: tooltip }">
<v-btn v-on="{ ...tooltip, ...menu }"> <!-- If both have a click event, only the menu will work -->
Dropdown w/ Tooltip
</v-btn>
</template>
<span>Im A ToolTip</span>
</v-tooltip>
</template>
<v-list>[...]</v-list>
</v-menu>
```
### What does the proposed API look like?
```html
<component v-on="[{ click: foo }, { click: bar }]">
```
Equivalent to:
```html
<component v-on="{ click: [foo, bar] }">
```
In the first example:
```html
<v-menu>
<template #activator="{ on: menu }">
<v-tooltip bottom>
<template #activator="{ on: tooltip }">
<v-btn v-on="[tooltip, menu]">
Dropdown w/ Tooltip
</v-btn>
</template>
<span>Im A ToolTip</span>
</v-tooltip>
</template>
<v-list>[...]</v-list>
</v-menu>
```
Currently this throws `[Vue warn]: v-on without argument expects an Object value`
<!-- generated by vue-issues. DO NOT REMOVE --> | feature request,has workaround | medium | Minor |
421,773,610 | rust | Improve the help message for the error on using fully qualified syntax for nested associated types | Here is a small example to reproduce the error and its help message:
```
trait A {
type Item;
}
trait B {
type Item: A;
fn trait_fn(x: Self::Item::Item);
}
```
Then I get the following error:
```
error[E0223]: ambiguous associated type
--> src/main.rs:8:20
|
8 | fn trait_fn(x: Self::Item::Item);
| ^^^^^^^^^^^^^^^^ help: use fully-qualified syntax: `<<Self as B>::Item as Trait>::Item`
```
It looks like the word "`Trait`" in `<<Self as B>::Item as Trait>::Item` should be replaced with the trait name `A` so that the suggested expression compiles:
**help: use fully-qualified syntax: `<<Self as B>::Item as A>::Item`**.
| C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics | low | Critical |
421,792,067 | pytorch | Android NNAPI support of Caffe2 | ## β Questions and Help
I want to run my nerual network model on Android mobile phone with Snapdragon DSP or Huawei NPU.
As I know, Android NNAPI supports vendor-specific drivers, including drivers for Snapdragon DSP or Huwaei NPU.
I saw some code supporting NNAPI for Android phone in Caffe2.
* [nnapi.h](https://github.com/pytorch/pytorch/blob/master/caffe2/mobile/contrib/nnapi/nnapi.h)
However, Caffe2 seems to use NNAPI on only its own test or benchmark code.
NNAPI support code seems not to be integrated into Caffe2.
* [nnapi_benchmark.cc](https://github.com/pytorch/pytorch/blob/master/caffe2/mobile/contrib/nnapi/nnapi_benchmark.cc)
* [nnapi_test.cc](https://github.com/pytorch/pytorch/blob/master/caffe2/mobile/contrib/nnapi/nnapi_test.cc)
Is there any plan to support Android NNAPI on Caffe2 main code? | caffe2 | low | Minor |
421,797,029 | flutter | Cupertino blurs should boost saturation | Apple makes extensive use of blur on iOS/MacOS to guide the users focus and attention. As announced in the 2019 roadmap, Flutter wants to expand to platforms beyond mobile (such as Mac/Web) but still wants to provide the most native experience possible. This could be easily improved by providing a more open ImageFilter API to give developers the power to customize blur effects.
In order to add a iOS like blur effect in CSS, apple is using the `backdrop-filter: blur(20px) saturation(180%)` property. ItΒ΄s particulary important to have control over the saturation to achive a high similarity to the iOS/MacOS translucency.
No saturation:
With saturation:
Most of the effects defined in `UIBlurEffect.Style` could be recreated when providing a saturation filter.
Similar issues like [this](https://github.com/flutter/flutter/issues/16296) by @matthew-carroll
or [this](https://stackoverflow.com/questions/55190136/flutter-equivalent-off-css-backdrop-filter-blur20px-saturation180) question on stackoverflow show that these APIs are requested for a long time. I am curious if the Flutter team is currently working on improving blur and how those APIs would look like since Hummingbird needs support for this as well.
| c: new feature,framework,engine,f: cupertino,customer: crowd,P3,team-design,triaged-design | medium | Critical |
421,798,156 | scrcpy | Customable Phone Skin for scrcpy Window | Hi, Developers.
Thank you very much for this very useful opensource software.
I have a feature request for adding generic phone skin for scrcpy including menu, home, and back button skin. It will be very nice to have it, especially for people like me who want to make tutorial for Android.
Thanks. | feature request | low | Major |
421,798,433 | go | x/tools/go/ssa/interp: panic: no code for function: time.runtimeNano on darwin | #### What did you do?
main.go
```go
package main
import (
"go/types"
"log"
"golang.org/x/tools/go/packages"
"golang.org/x/tools/go/ssa"
"golang.org/x/tools/go/ssa/interp"
"golang.org/x/tools/go/ssa/ssautil"
)
func main() {
target := "./testdata"
cfg := &packages.Config{
Mode: packages.LoadAllSyntax,
Tests: false,
}
pkgs, err := packages.Load(cfg, target)
if err != nil {
log.Fatalf("failed to load package: %v", err)
return
}
ssaProg, ssaPkgs := ssautil.AllPackages(pkgs, 0)
ssaProg.Build()
var mainPkg *ssa.Package
for _, ssaPkg := range ssaPkgs {
if ssaPkg.Pkg.Name() == "main" {
mainPkg = ssaPkg
}
}
mode := interp.EnableTracing
interp.Interpret(mainPkg, mode, &types.StdSizes{WordSize: 8, MaxAlign: 8}, "main", []string{})
}
```
testdata/t.go
```go
package main
import "fmt"
func main() {
fmt.Println("hello")
}
```
go.mod
```
module github.com/ajalab/ssainterp
go 1.12
require golang.org/x/tools v0.0.0-20190315214010-f0bfdbff1f9c
```
#### What did you expect to see?
The program prints "hello" to stdout.
#### What did you see instead?
The program panics.
```
Entering time.runtimeNano at /usr/local/go/src/time/time.go:1076:6.
Leaving time.runtimeNano, resuming time.init at /usr/local/go/src/time/time.go:1084:34.
Panicking: string no code for function: time.runtimeNano.
Leaving time.init, resuming internal/poll.init.
Panicking: string no code for function: time.runtimeNano.
Leaving internal/poll.init, resuming os.init.
Panicking: string no code for function: time.runtimeNano.
Leaving os.init, resuming fmt.init.
Panicking: string no code for function: time.runtimeNano.
Leaving fmt.init, resuming github.com/ajalab/ssainterp/testdata.init.
Panicking: string no code for function: time.runtimeNano.
Leaving github.com/ajalab/ssainterp/testdata.init.
panic: no code for function: time.runtimeNano
```
#### Does this issue reproduce with the latest release (go1.12.1)?
yes
#### System details
```
go version go1.12.1 darwin/amd64
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/koki/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/koki/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/koki/prj/ssainterp/go.mod"
GOROOT/bin/go version: go version go1.12.1 darwin/amd64
GOROOT/bin/go tool compile -V: compile version go1.12.1
uname -v: Darwin Kernel Version 18.2.0: Thu Dec 20 20:46:53 PST 2018; root:xnu-4903.241.1~1/RELEASE_X86_64
ProductName: Mac OS X
ProductVersion: 10.14.3
BuildVersion: 18D42
lldb --version: lldb-1000.0.38.2
Swift-4.2
```
| NeedsInvestigation,Tools | low | Critical |
421,804,333 | vscode | [html] embedded java script grammar doesn't end because of missing semicolon | <!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: latest
- OS Version: windows 10
Steps to Reproduce:
1.forget a semi-colon in a script tag in head (not required in JS for every line)
2.press ctrl + /
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
| bug,html | low | Major |
421,817,788 | godot | tree_exited signal callbacks are run in the editor even when the script is not "tool", can cause editor crash | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:** 3.1-stable_X11.64
<!-- Specify commit hash if non-official. -->
**OS/device including version:** Solus 3.9999 Gnome Nvidia GTX 1050TI
<!-- Specify GPU model and drivers if graphics-related. -->
**Issue description:**
<!-- What happened, and what was expected. -->
Randomly when I switch between scenes Godot crashes, the only thing on the terminal when this happens is:
```
ERROR: _load: Condition ' !f ' is true. returned: ERR_CANT_OPEN
At: scene/resources/dynamic_font.cpp:149.
ERROR: _get_modified_time: Failed to get modified time for:
At: drivers/unix/file_access_unix.cpp:292.
ERROR: _load: No loader found for resource: res://
At: core/io/resource_loader.cpp:285.
malloc(): smallbin double linked list corrupted
```
I am using GLES2
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
It's not minimal but can give enough context
[mooncheeser source.zip](https://github.com/godotengine/godot/files/2974024/source.zip)
| bug,topic:core,topic:editor,confirmed | medium | Critical |
421,825,593 | TypeScript | preserveSymlinks: Changes to target module are not propagated to symlink modules | **TypeScript Version:** 3.4.0-dev.20190316
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- preserveSymlinks, symlink, watch, change
**Description:**
I'm not familiar with how `preserveSymlinks` works internally, but it appears that symlink modules are not notified of changes to their target path.
My scenario is the following: I'm linking from `node_modules/foo` to a package that exists outside my project's root directory. When I update `foo/src/index.ts`, my project is not aware until I restart the TS server.
**Related Issues:** None.
| Suggestion,Awaiting More Feedback | low | Major |
421,833,517 | opencv | python cv2: suppress stream decoders output messages (f.e. `[h264 @ 0x2f6d280] Invalid NAL unit size (0 > 2133).`) | Hello,
i'm processing some videos retrieved from the web using the `cv2` python module, and some of those videos generate warning during decoding with 3rd-party codecs, for example:
```
[h264 @ 0x2f6d280] Error splitting the input into NAL units.
[h264 @ 0x2dbbb00] Invalid NAL unit size (0 > 41960).
[h264 @ 0x2dbbb00] Error splitting the input into NAL units.
[h264 @ 0x2c132c0] Invalid NAL unit size (0 > 5375).
[h264 @ 0x2c132c0] Error splitting the input into NAL units.
[h264 @ 0x2c890c0] Invalid NAL unit size (0 > 1582).
[h264 @ 0x2c890c0] Error splitting the input into NAL units.
[h264 @ 0x2b5a7c0] Invalid NAL unit size (0 > 2140).
[h264 @ 0x2b5a7c0] Error splitting the input into NAL units.
[h264 @ 0x2b77040] Invalid NAL unit size (0 > 1752).
[h264 @ 0x2b77040] Error splitting the input into NAL units.
[h264 @ 0x2b93900] Invalid NAL unit size (0 > 14127).
[h264 @ 0x2b93900] Error splitting the input into NAL units.
[h264 @ 0x3046b40] co located POCs unavailable
[h264 @ 0x2f6d280] co located POCs unavailable
[h264 @ 0x2dbbb00] co located POCs unavailable
[h264 @ 0x2c890c0] co located POCs unavailable
[h264 @ 0x2b5a7c0] co located POCs unavailable
[h264 @ 0x2b77040] co located POCs unavailable
```
while they may be interesting to some people, it would be great if there could be a way to silence them, like a `warning=off` when calling `cv2.VideoCapture()` or something
thanks for considering! | feature,category: video,priority: low | low | Critical |
421,843,500 | pytorch | copy.copy not working for ScriptModule | The following code does not work
```python
import torch
import copy
class M(torch.jit.ScriptModule):
@torch.jit.script_method
def forward(self, x):
return x
m = M()
copy.copy(m)
```
Error message:
```
Traceback (most recent call last):
File "test.py", line 13, in <module>
copy.copy(m)
File "/usr/lib/python3.7/copy.py", line 96, in copy
rv = reductor(4)
File "/home/gaoxiang/.virtualenvs/pt/lib/python3.7/site-packages/torch/jit/__init__.py", line 1226, in __getstate__
"Mixed serialization of script and non-script modules is not supported. " +
_pickle.PickleError: ScriptModules cannot be saved using torch.save. Mixed serialization of script and non-script modules is not supported. For purely script modules use my_script_module.save(<filename>) instead.
```
Related: https://github.com/pytorch/pytorch/issues/17422
cc @suo | oncall: jit,triaged,jit-backlog | medium | Critical |
421,845,605 | react | Hooks - unmount and didUpdate | I'm opening this up at Dan's request from a twitter discussion:
https://twitter.com/lichstam/status/1106995545938247682
From Twitter:
I can fill in on this. The first example I would like to point to is a debouncing hook I've created that looks something like this:
```javascript
useEffect(() => {
const debounced = setTimeout(() => setDebounced(steps), 500);
return () => clearTimeout(debounced);
}, [steps])
```
and then I have another one, that actually performs the request:
```javascript
useEffect(request, [debounced])
```
And it all works fine, apart from when the component is mounted and unmounted.
In the class model I was able to make sure it never runs the first time and on unmounting I could clear the timeout and, if the state value differs from prop (yes I know, you shouldn't mirror your props but I have to debounce somewhere), I could just perform a last request before I unmount.
Furthermore, `componentDidUpdate` really made it easy preventing this from running the first time. I'm not quite sure how to approach this with hooks.
Perhaps I'm doing it all wrong but to Patrick's point, the class way was more straight forward.
Another example: I code in RN and use the Animated API a lot. I have cases that translates into something like this:
```javascript
useEffect(() => {
if (inAddStage) moveAndShowStep(); // Animate with Animated API
}, [inAddStage]);
```
This works well but it does perform an unnecessary initial run which makes me wonder if I've missed the point with hooks (again, to Patrick's point, it seems a bit more complex sometimes). Why isn't there a hook that **doesn't** run the first time btw? Again, with the old lifecycles it was much clearer how to prevent this from happening (using `componentDidUpdate`).
On a last note, I just want to say that I'm very fond of the idea and wholeheartedly support the functional approach and I really like the concept of hooks being "state observers", that react only when the specified attributes change - which basically makes the whole code more declarative.
I've just started using them so I'll probably figure things out along the way but I thought I could give you something since you didn't get any answer :) | Type: Discussion | low | Minor |
421,848,829 | youtube-dl | Formula1.com | - [X] I've **verified** and **I assure** that I'm running youtube-dl **2019.03.09**
- [X] At least skimmed through the [README](https://github.com/ytdl-org/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/ytdl-org/youtube-dl#faq) and [BUGS](https://github.com/ytdl-org/youtube-dl#bugs) sections
- [X] [Searched](https://github.com/ytdl-org/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [X] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser
- [X] Bug report (encountered problems with youtube-dl)
---
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-u', 'PRIVATE', '-p', 'PRIVATE', '--verbose', 'http
s://f1tv.formula1.com/en/current-season/australian-grand-prix/2019-australian-gr
and-prix-qualifying']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2019.03.09
[debug] Python version 3.4.4 (CPython) - Windows-7-6.1.7601-SP1
[debug] exe versions: none
[debug] Proxy map: {}
[generic] 2019-australian-grand-prix-qualifying: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 2019-australian-grand-prix-qualifying: Downloading webpage
[generic] 2019-australian-grand-prix-qualifying: Extracting information
ERROR: Unsupported URL: https://f1tv.formula1.com/en/current-season/australian-g
rand-prix/2019-australian-grand-prix-qualifying
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpy110f8qy\bu
ild\youtube_dl\YoutubeDL.py", line 794, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpy110f8qy\bu
ild\youtube_dl\extractor\common.py", line 522, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpy110f8qy\bu
ild\youtube_dl\extractor\generic.py", line 3320, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://f1tv.formula1.com/en
/current-season/australian-grand-prix/2019-australian-grand-prix-qualifying
```
---
The site formula1.com is in your Supported sites list, but I receive "Unsupported URL" error | geo-restricted | low | Critical |
421,874,972 | godot | No button release triggered after drag using "gui_input" signal | **Godot version:**
godot 3.1 master
**OS/device including version:**
N/A
**Issue description:**
When connecting to a control "gui_input" signal, to detect click+drag+release, the left mouse button released (event) at the end of the drag is not triggered.
if I print event as_text()
```
if p_event is InputEventMouseButton:
print(p_event.as_text())
```
if I click and release I get:
```
InputEventMouseButton : button_index=BUTTON_LEFT, pressed=true, position=(110, 37), button_mask=1, doubleclick=false
InputEventMouseButton : button_index=BUTTON_LEFT, pressed=false, position=(110, 37), button_mask=0, doubleclick=false
```
if I click drag and release I get:
```
InputEventMouseButton : button_index=BUTTON_LEFT, pressed=true, position=(54, 24), button_mask=1, doubleclick=false
```
as you can see there is no release event being trigger.
| bug,topic:input | low | Major |
421,888,999 | youtube-dl | Please add support for Google Fiber as an MSO | - [x] I've **verified** and **I assure** that I'm running youtube-dl **2019.03.09**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/ytdl-org/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/ytdl-org/youtube-dl#faq) and [BUGS](https://github.com/ytdl-org/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### Description of your *issue*, suggested solution and other information
Please provide Google Fiber as an MSO; alternately, if someone who has written MSO's before can document the process they've used, I could try my hand at writing the support for it. I've looked at the code and it seems pretty straight-forward, but I'm not sure where one finds the values for `username_field` and `password_field`, given that Google Fiber uses SAML. | tv-provider-account-needed | low | Critical |
421,893,612 | create-react-app | Question: Source mapping componentStack from error boundary in production | Lately, I am trying to use error boundaries to tackle unexpected errors more properly. I am also logging most of the errors to the Sentry service. I am sending the `componentStack` from `componentDidMount` there as well, but since it's minified, it feels fairly useless.
I am wondering what are my options if any. Since that output is pretty much just a string, the source mapping does not seem possible at any level. | issue: proposal | medium | Critical |
421,908,181 | flutter | Popup menu shown at wrong position | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.io/
* https://docs.flutter.io/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.io/bug-reports/
-->
## Steps to Reproduce
<!--
Please tell us exactly how to reproduce the problem you are running into.
Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.
If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.
-->
Please use this [code](https://gist.github.com/HubertZhang/7b2d20a062a80fc172ba2dc7200e91be) as main.dart
1. Run
2. The origin flutter SDK would give
where popup menu is expanded at a low position
3. Change <FLUTTER_SDK_ROOT>/packages/flutter/lib/src/material/popup_menu.dart:538
```
double y;
if (selectedItemOffset == null) {
y = position.top;
} else {
--- y = position.top + (size.height - position.top - position.bottom) / 2.0 - selectedItemOffset;
+++ y = position.top - selectedItemOffset;
}
```
would give right result
## Logs
No log needed
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
flutter analyze result
```
Analyzing demo...
No issues found! (ran in 1.3s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
flutter doctor result
```
[β] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.3 18D109, locale zh-Hans-CN)
β’ Flutter version 1.2.1 at /Users/Hubert/Development/flutter
β’ Framework revision 8661d8aecd (4 weeks ago), 2019-02-14 19:19:53 -0800
β’ Engine revision 3757390fa4
β’ Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at /usr/local/share/android-sdk/
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-28, build-tools 28.0.3
β’ ANDROID_HOME = /usr/local/share/android-sdk/
β’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
β’ All Android licenses accepted.
[!] iOS toolchain - develop for iOS devices (Xcode 10.1)
β’ Xcode at /Applications/Xcode.app/Contents/Developer
β’ Xcode 10.1, Build version 10B61
β Verify that all connected devices have been paired with this computer in Xcode.
If all devices have been paired, libimobiledevice and ideviceinstaller may require updating.
To update with Brew, run:
brew update
brew uninstall --ignore-dependencies libimobiledevice
brew uninstall --ignore-dependencies usbmuxd
brew install --HEAD usbmuxd
brew unlink usbmuxd
brew link usbmuxd
brew install --HEAD libimobiledevice
brew install ideviceinstaller
β ios-deploy not installed. To install:
brew install ios-deploy
β’ CocoaPods version 1.5.0
[β] Android Studio (version 3.3)
β’ Android Studio at /Applications/Android Studio.app/Contents
β’ Flutter plugin version 33.3.1
β’ Dart plugin version 182.5215
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
[!] IntelliJ IDEA Ultimate Edition (version 2017.3.3)
β’ IntelliJ at /Applications/IntelliJ IDEA.app
β Flutter plugin not installed; this adds Flutter specific functionality.
β Dart plugin not installed; this adds Dart specific functionality.
β’ For information about installing plugins, see
https://flutter.io/intellij-setup/#installing-the-plugins
[!] VS Code (version 1.32.2)
β’ VS Code at /Applications/Visual Studio Code.app/Contents
β Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[β] Connected device (1 available)
β’ iPhone XR β’ 17B921C2-F5F5-4BD9-84E1-094CC9696E38 β’ ios β’ iOS 12.1 (simulator)
! Doctor found issues in 3 categories.
```
| framework,f: material design,a: quality,has reproducible steps,P2,found in release: 2.5,found in release: 2.6,team-design,triaged-design | low | Critical |
421,918,204 | go | cmd/link: "relocation target * not defined" for .syso symbol with LinkMode=external | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel +14c3692502 Sat Mar 16 14:16:39 2019 +0000 linux/amd64
</pre>
(Also tested with go1.12 and go1.12.1).
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN="/home/pwaller/.local/bin"
GOCACHE="/home/pwaller/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/pwaller/go"
GOPROXY=""
GORACE=""
GOROOT="/home/pwaller/sdk/go1.12"
GOTMPDIR=""
GOTOOLDIR="/home/pwaller/sdk/go1.12/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/pwaller/.local/src/github.com/pwaller/bench-syso-broken/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build380714510=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
Tried to use the toolchain trick described in ["Use syso file to embed arbitrary self-contained C code"](https://github.com/golang/go/wiki/GcToolchainTricks#use-syso-file-to-embed-arbitrary-self-contained-c-code).
1. Put `code.go`, `code.s` and `code.syso` in a package with the following described below.
2. Run `go build`.
#### `code.syso`
I generated a .syso file in the same directory as the package with the following command: `gcc -x c -c -o code.syso - <<<'void nop1() {}'`. Note, I'm aware of the limitations of syso files with respect to calling convention, I'm just using this as an easy way to get an object file for purposes of demonstrating that linking is not working as I'd expect.
#### `code.go`
```go
package main
// Comment out this line, and the main binary compiles successfully(!?).
import _ "golang.org/x/sys/unix"
func main() {
nop()
}
func nop()
```
#### `code.s`
```asm
TEXT Β·nop(SB),$0-0
JMP nop1(SB)
```
Then I ran `go build`.
### What did you expect to see?
A successfully compiled binary.
### What did you see instead?
```
# github.com/pwaller/syso-broken
main.nop: relocation target nop1 not defined
```
### Additional notes
* If I remove the otherwise unused import of `golang.org/x/sys/unix`, then the binary compiles.
* I can reproduce with both old-style `GOPATH` or modules.
/cc @ianlancetaylor for the linker.
@gopherbot label needsinvestigation | NeedsInvestigation,compiler/runtime | low | Critical |
421,925,982 | rust | Reevaluate removing `ty::Error` | I just found
https://github.com/rust-lang/rust/blob/7cf074a1e655ac07d04d045667278fa1a9970b93/src/librustc/ty/flags.rs#L70-L76
which seems to suggest that it's not the "infects everything" problem of using `Result` in more places, but actually some ages old situation where either the compiler ended up segfaulting during compilation or the compiled crate segfaulted during execution.
cc @nikomatsakis your name is mentioned in the comment
Cleaning this up seems to fit into the "technical debt" part of this year's roadmap.
I envision that changing this would result in more uses of `Result<T, ErrorReported>` across the code base and hopefully a reduction of `delay_span_bug`s and `bug!`s that are never reached. | C-cleanup,T-compiler | low | Critical |
421,949,465 | vscode | WebView doesn't close on extension (but not window) reload | ### Summary
Some actions can cause extensions to be reloaded without the whole window being reloaded. This results in WebViews opened by extensions to remain open. On its own not a problem, except should these use the message API to "talk" to their extension, since it got reloaded/terminated. Expected behavior is to close all WebViews, similar to what happens when the window is reloaded, e.g. using the `Developer: Reload Window` command.
### Steps to reproduce on your own
1. Have an extension launch a WebView
2. Change the "main workspace folder" without triggering a window reload
I discovered this by my extension using `updateWorkspaceFolders` to go from 0 to 1 folders.
Having a multi-folder workspace, rightclicking the first folder, and using `Remove Folder from Workspace` also triggers this effect. So does pressing `Reload` after installing a (new) .vsix for an already installed extension, but that results in an empty WebView?
3. The WebView remains, working, but the extensions reloaded, "breaking" `onDidReceiveMessage`
### With [example extension](https://drive.google.com/file/d/19O86YV-_IWptsLu-894k6fEfvWf-fHmK/view) to easily replicate
*(source code available by opening the file as an archive, or doing step 4 below)*
1. Open a new window (and install the extension if you haven't yet)
2. Run the `ISSUE: Open a test WebView` command
3. Click `Send message` and notice how you get a response from the extension
4. Run the `ISSUE: Add/remove the first workspace folder to trigger the semi-reload` command
If you had folders in your workspace, the first one gets removed. If your workspace is empty, it'll add the extension's folder (with source code) as workspace folder.
5. Click `Send message` and notice how you don't get a response anymore
_____
- VSCode versions tested:
- 1.32.3 (user setup) (a3db5be9)
- 1.33.0-insider (user setup) (5a88160c)
- OS Version: Windows 10 Version 1803 (OS Build 17134.407)
> If the first workspace folder is added, removed or changed, the currently executing extensions (including the one that called this method) will be terminated and restarted so that the (deprecated) rootPath property is updated to point to the first workspace folder.
***From the documentation of vscode.workspace.updateWorkspaceFolders***
| feature-request,webview | low | Major |
421,949,874 | TypeScript | Inconsistent error reporting for duplicate JSDoc tags | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
JSDoc error
**Code**
```ts
// @ts-check
/** @type {number} */
/** @type {string} */
var v; // no error, type is 'number'
/** @type {number} @type {string} */
var v2; // error on the second '@type' tag
```
**Expected behavior:**
An error on the redundant `@type` tag of `v`.
**Actual behavior:**
No error if the redundant tag is in a different JSDoc comment. The same applies to `@return`.
**Related Issues:** #24996
| Bug | low | Critical |
421,958,257 | TypeScript | Alternate syntax for function overloads | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
class method signature
method signature
function overload syntax
function overload
proxy function
proxy function signature
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
A new syntax for function overloads:
```js
function Func as FunctionSignature
class A {
static Func as FunctionSignature
Func as FunctionSignature
}
```
This would allow types to be less static, and often more accurate to the purpose of the overloaded function
Right now, we can do something similar using `const` -
```js
const: FunctionSignature = function() {}
```
however, the differences in detailed in #25761 and the lack of any equivalent in classes make this a separate issue.
I'm not dead set on the `as` syntax, but I think it fits with what we already have quite well. The checking done on overloads is similar to that of `({ prop: "HI" } as { prop: number })`, and it fits well in and out of classes
It's also worth noting that every use case of this would benefit greatly from #28172
## Use Cases
### Generic Types
```js
type Pipe<V> = (val: V) => V
function MyFunc as Pipe<string>
// function MyFunc(val: string): string
function MyFunc(...args: any[]): any {
}
```
### Inheritance
```js
function tryInt as typeof parseInt
// function tryInt(s: string, radix?: number): number
function tryInt(...args: [string, number?]) {
const n = parseInt(...args)
if (isNaN(n)) throw "Failed to parse"
return n
}
```
### Combining function implementations
A solution to the problems brought up in #12041 -
```js
function overload as typeof implementation
function overload as typeof otherImplementation
// function overload(num: number): string
// function overload(str: string, num: number): string
function overload(...args: [string, number] | [number]) {
return args.length === 1 ? implementation(...args) : otherImplementation(...args)
}
```
Which would work particularly well combined with #28172,
```js
function overload as typeof implementation
function overload as typeof otherImplementation
function overload() {
return arguments.length === 1 ? implementation(...arguments) : otherImplementation(...arguments)
}
```
fully checking the types against the current signature of both implementations, and emitting useful errors
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
<!-- Show how this would be used and what the behavior would be -->
This came up in the context of an argument parser, where I attempt to parse the values using a direct proxy to another method -
```js
class ArgumentIssue {
confidence: number
}
class Arguments {
async parse(args: string, cb: (val: string) => any = v => v): Promise<{ [key: string]: any }> {
// Follows the return value ^
}
}
class Signature extends Array<Arguments> {
parse as ArgumentBuilder["parse"]
// parse(args: string, cb: (val: string) => any): Promise<{ [key: string]: any }>
parse(a: any, ...args: any[]) {
let Nearest: [Arguments, ArgumentIssue];
for (const overload of this) {
try {
return overload.parse(a, ...args)
} catch (issue) {
if (!(issue instanceof ArgumentIssue)) throw issue;
if (!Nearest || issue.confidence > Nearest[1].confidence)
Nearest = [overload, issue];
}
}
throw Nearest;
}
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
422,009,168 | three.js | Editor: better controls for default camera | Most modelling programs have quick settings for the default camera, such as:
* jump to specific views such as top, left, bottom, right,
* reset the view
* switch between perspective and orthographic projection
* fit camera to scene (in clara.io this is called "frame scene")
* fit camera to selection
* create new perspective camera from current view and add it to the scene
It would be useful to add these to the editor as well. Most of these options can go in the same menu that was added in #15998.
See Clara.io for an example of how these can be set up.
| Enhancement,Editor | medium | Major |
422,033,094 | go | cmd/trace: generate trace graph for custom region selection | I propose that cmd/trace should have an option in the web UI to generate a trace graph for an arbitrary list of user defined regions.
I want/need to see the timing between certain user defined regions and having such an option in the web ui would be very useful. I could just dump them all into the same task but this means recompiling the program and changing code just to change what regions get shown together. Also if the program failed to call `task.End()` for any reason, then the trace graph doesn't get generated at all. | Proposal,Proposal-Accepted,FeatureRequest | medium | Critical |
422,038,271 | TypeScript | Organize imports: add an option to put all absolute paths after node_modules ones | **Feature Request**
Add a configuration option that to sort all the absolute paths (i.e. with `baseUrl = /src` in `jsconfig.json`) after all the node_modules paths.
**Reason**
More and more people use alias to avoid long relative paths. It's a common practice to have first the third-party imports, then the absolute paths, and finally the relative ones. | Suggestion,Awaiting More Feedback | medium | Major |
422,044,924 | godot | Unable to make CollisionPolygon2D from specific array | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:3.1
<!-- Specify commit hash if non-official. -->
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
**Issue description:**
<!-- What happened, and what was expected. -->
the follow array can not make a valid CollisionPolygon2D. However, it's a valid array to make a Polygon2D.
[(0, 805), (60, 773.250732), (120, 688.083008), (180, 576.537048), (240, 474.027863), (300, 413.10141), (360, 413.10141), (420, 474.027863), (480, 576.537048), (540, 688.083008), (600, 773.250732), (660, 805), (660, 805), (720, 773.250732), (780, 688.083008), (840, 576.537048), (900, 474.027863), (960, 413.10141), (1020, 413.10141), (1080, 474.027863), (1140, 576.537048), (1200, 688.083008), (1260, 773.250732), (1320, 805), (1320, 805), (1380, 773.250732), (1440, 688.083008), (1500, 576.537048), (1560, 474.027863), (1620, 413.10141), (1680, 413.10141), (1740, 474.027863), (1800, 576.537048), (1860, 688.083008), (1920, 773.250732), (1980, 805), (1980, 1080), (0, 1080)]
**Steps to reproduce:**
1.add a new StaticBody2D
2.add a CollisionPolygon2D to the StaticBody2D
3.set the polygon to the value as above values.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. --> | bug,topic:core,confirmed | low | Critical |
422,063,561 | flutter | [documentatio] rename Overlay class or provide updated documentation | Documentation of [`Overlay`](https://docs.flutter.io/flutter/widgets/Overlay-class.html):
> A Stack of entries that can be managed independently.
>
> Overlays let independent child widgets "float" visual elements on top of other widgets by inserting them into the overlay's Stack. The overlay lets each of these widgets manage their participation in the overlay using OverlayEntry objects.
>
> Although you can create an Overlay directly, it's most common to use the overlay created by the Navigator in a WidgetsApp or a MaterialApp. The navigator uses its overlay to manage the visual appearance of its routes.
Definition of the word overlay:
> Something laid as a covering over something else.
I don't see the relationship between these 2 things. If an `Overlay` is basically a `Stack`, where the entries can be managed, it should perhaps be called something like `ManagedStack`.
Perhaps this name was given because of
> Overlays let independent child widgets "float" visual elements on top of other widgets by inserting them into the overlay's Stack
?
But this doesn't affect the `Overlay` widget itself. It's just an internal property of how its children are arranged. At least from the documentation it's not understandable how this widget is supposed to be an overlay (what does it overlay?). If it's just a managed stack, it can be used anywhere, in front or behind of other widgets. | framework,d: api docs,c: proposal,P2,team-framework,triaged-framework | low | Minor |
422,075,845 | flutter | When there is a RouteObserver set inside the child of a Hero widget, Flutter crashes | If you take out only the Hero widget from the below code, everything works as expected.
## Code
``` Dart
import 'package:flutter/material.dart';
import 'test_page.dart';
import 'test_widget.dart';
final RouteObserver<PageRoute> routeObserver = RouteObserver<PageRoute>();
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: MyHomePage(title: 'HERO and RouteObserver'),
routes: <String, WidgetBuilder> {
'test': (BuildContext context) => TestPage(
routeObserver: routeObserver
)
},
navigatorObservers: [routeObserver],
);
}
}
class MyHomePage extends StatefulWidget {
MyHomePage({Key key, this.title}) : super(key: key);
final String title;
@override
_MyHomePageState createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
@override
Widget build(BuildContext context) {
return Scaffold(
backgroundColor: Colors.blue,
appBar: AppBar(
title: Text(widget.title),
),
body: Hero(
tag: "HeroTag",
child: TestWidget(
routeObserver: routeObserver
),
),
floatingActionButton: FloatingActionButton(
onPressed: _toTestPage,
child: Icon(Icons.add),
),
);
}
void _toTestPage() {
Navigator.of(context).pushNamed("test");
}
}
```
``` Dart
import 'package:flutter/material.dart';
import 'test_widget.dart';
class TestPage extends StatefulWidget {
const TestPage({
this.routeObserver
});
final RouteObserver<PageRoute> routeObserver;
@override
State<StatefulWidget> createState() => TestPageState();
}
class TestPageState extends State<TestPage> with RouteAware {
@override
void initState() {
super.initState();
}
@override
void dispose() {
super.dispose();
}
@override
void didChangeDependencies() {
super.didChangeDependencies();
widget.routeObserver.subscribe(this, ModalRoute.of(context));
}
@override
void didPush() {
print("did push: test_page");
}
@override
void didPushNext() {
print("did push next: test_page");
}
@override
void didPop() {
print("did pop: test_page");
}
@override
void didPopNext() {
print("did pop next: test_page");
}
@override
Widget build(BuildContext context) {
return Scaffold(
backgroundColor: Colors.blue,
appBar: AppBar(
title: Text("Test Page"),
),
body: Center(
child: Container(
width: 200,
height: 200,
child: Hero(
tag: "HeroTag",
child: TestWidget(
routeObserver: widget.routeObserver
),
),
),
),
);
}
}
```
``` Dart
import 'package:flutter/material.dart';
class TestWidget extends StatefulWidget {
const TestWidget({
this.routeObserver
});
final RouteObserver<PageRoute> routeObserver;
@override
State<StatefulWidget> createState() => TestWidgetState();
}
class TestWidgetState extends State<TestWidget> with RouteAware {
@override
void initState() {
super.initState();
}
@override
void dispose() {
super.dispose();
}
@override
void didChangeDependencies() {
super.didChangeDependencies();
widget.routeObserver.subscribe(this, ModalRoute.of(context));
}
@override
void didPush() {
print("did push: test_widget");
}
@override
void didPushNext() {
print("did push next: test_widget");
}
@override
void didPop() {
print("did pop: test_widget");
}
@override
void didPopNext() {
print("did pop next: test_widget");
}
@override
Widget build(BuildContext context) {
return Container(
color: Colors.red,
child : Center(
child: Text("Hero"),
)
);
}
}
```
## Logs
```
[+1116 ms] I/flutter (18702): did push next: test_widget
[ +26 ms] I/flutter (18702): did push: test_page
[ +3 ms] I/flutter (18702): did push: test_widget
[ +96 ms] I/flutter (18702): βββ‘ EXCEPTION CAUGHT BY WIDGETS LIBRARY ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
[ +2 ms] I/flutter (18702): The following assertion was thrown building Positioned(left: 65.2, top: 171.0, right: 65.2, bottom:
[ +1 ms] I/flutter (18702): 91.0):
[ +1 ms] I/flutter (18702): 'package:flutter/src/widgets/routes.dart': Failed assertion: line 1369 pos 12: 'route != null': is
[ +1 ms] I/flutter (18702): not true.
[ ] I/flutter (18702):
[ ] I/flutter (18702): Either the assertion indicates an error in the framework itself, or we should provide substantially
[ ] I/flutter (18702): more information in this error message to help you determine and fix the underlying cause.
[ ] I/flutter (18702): In either case, please report this assertion by filing a bug on GitHub:
[ ] I/flutter (18702): https://github.com/flutter/flutter/issues/new?template=BUG.md
[ ] I/flutter (18702):
[ ] I/flutter (18702): When the exception was thrown, this was the stack:
[ ] I/flutter (18702): #2 RouteObserver.subscribe (package:flutter/src/widgets/routes.dart:1369:12)
[ ] I/flutter (18702): #3 TestWidgetState.didChangeDependencies (package:hero_error/test_widget.dart:28:26)
[ ] I/flutter (18702): #4 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3862:12)
[ ] I/flutter (18702): #5 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3711:5)
[ ] I/flutter (18702): #6 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2956:14)
[ ] I/flutter (18702): #7 Element.updateChild (package:flutter/src/widgets/framework.dart:2759:12)
[ ] I/flutter (18702): #8 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4876:14)
[ ] I/flutter (18702): #9 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2956:14)
[ ] I/flutter (18702): #10 Element.updateChild (package:flutter/src/widgets/framework.dart:2759:12)
[ ] I/flutter (18702): #11 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4876:14)
[ ] I/flutter (18702): #12 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2956:14)
[ ] I/flutter (18702): #13 Element.updateChild (package:flutter/src/widgets/framework.dart:2759:12)
[ ] I/flutter (18702): #14 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:4876:14)
[ ] I/flutter (18702): #15 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2956:14)
[ ] I/flutter (18702): #16 Element.updateChild (package:flutter/src/widgets/framework.dart:2759:12)
[ ] I/flutter (18702): #17 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3747:16)
[ ] I/flutter (18702): #18 Element.rebuild (package:flutter/src/widgets/framework.dart:3559:5)
[ ] I/flutter (18702): #19 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3716:5)
[ ] I/flutter (18702): #20 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3711:5)
[ ] I/flutter (18702): #21 ParentDataElement.mount (package:flutter/src/widgets/framework.dart:4063:11)
[ ] I/flutter (18702): #22 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2956:14)
[ ] I/flutter (18702): #23 Element.updateChild (package:flutter/src/widgets/framework.dart:2759:12)
[ ] I/flutter (18702): #24 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3747:16)
[ ] I/flutter (18702): #25 Element.rebuild (package:flutter/src/widgets/framework.dart:3559:5)
[ ] I/flutter (18702): #26 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3716:5)
[ ] I/flutter (18702): #27 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3864:11)
[ ] I/flutter (18702): #28 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3711:5)
[ ] I/flutter (18702): #29 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2956:14)
[ ] I/flutter (18702): #30 Element.updateChild (package:flutter/src/widgets/framework.dart:2759:12)
[ ] I/flutter (18702): #31 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3747:16)
[ ] I/flutter (18702): #32 Element.rebuild (package:flutter/src/widgets/framework.dart:3559:5)
[ ] I/flutter (18702): #33 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3716:5)
[ ] I/flutter (18702): #34 StatefulElement._firstBuild (package:flutter/src/widgets/framework.dart:3864:11)
[ ] I/flutter (18702): #35 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3711:5)
[ ] I/flutter (18702): #36 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2956:14)
[ ] I/flutter (18702): #37 Element.updateChild (package:flutter/src/widgets/framework.dart:2759:12)
[ ] I/flutter (18702): #38 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:4659:32)
[ ] I/flutter (18702): #39 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4992:17)
[ ] I/flutter (18702): #40 Element.updateChild (package:flutter/src/widgets/framework.dart:2748:15)
[ ] I/flutter (18702): #41 _TheatreElement.update (package:flutter/src/widgets/overlay.dart:508:16)
[ ] I/flutter (18702): #42 Element.updateChild (package:flutter/src/widgets/framework.dart:2748:15)
[ ] I/flutter (18702): #43 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3747:16)
[ ] I/flutter (18702): #44 Element.rebuild (package:flutter/src/widgets/framework.dart:3559:5)
[ ] I/flutter (18702): #45 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2273:33)
[ ] I/flutter (18702): #46 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:700:20)
[ ] I/flutter (18702): #47 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:268:5)
[ ] I/flutter (18702): #48 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:988:15)
[ ] I/flutter (18702): #49 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:928:9)
[ ] I/flutter (18702): #50 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:840:5)
[ ] I/flutter (18702): #54 _invoke (dart:ui/hooks.dart:209:10)
[ ] I/flutter (18702): #55 _drawFrame (dart:ui/hooks.dart:168:3)
[ ] I/flutter (18702): (elided 5 frames from class _AssertionError and package dart:async)
[ ] I/flutter (18702): ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
[ +50 ms] I/flutter (18702): Another exception was thrown: 'package:flutter/src/widgets/routes.dart': Failed assertion: line 1369 pos 12: 'route != null': is not true.
[ +171 ms] I/flutter (18702): did push: test_widget
[+2099 ms] I/flutter (18702): did push: test_widget
```
```
Analyzing hero_error...
No issues found! (ran in 1.6s)
```
```
[β] Flutter (Channel stable, v1.2.1, on Microsoft Windows [Version 10.0.17134.590], locale ja-JP)
β’ Flutter version 1.2.1 at C:\Users\z.shota.yuki\Documents\flutter
β’ Framework revision 8661d8aecd (4 weeks ago), 2019-02-14 19:19:53 -0800
β’ Engine revision 3757390fa4
β’ Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
β’ Android SDK at C:\Users\z.shota.yuki\AppData\Local\Android\sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-28, build-tools 28.0.3
β’ ANDROID_HOME = C:\Users\z.shota.yuki\AppData\Local\Android\sdk
β’ Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)
β’ All Android licenses accepted.
[β] Android Studio (version 3.1)
β’ Android Studio at C:\Program Files\Android\Android Studio
β’ Flutter plugin version 29.0.1
β’ Dart plugin version 173.4700
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02)
[β] VS Code, 64-bit edition (version 1.29.1)
β’ VS Code at C:\Program Files\Microsoft VS Code
β’ Flutter extension version 2.21.1
[β] Connected device (1 available)
β’ Pixel 3 β’ 8ADX0R099 β’ android-arm64 β’ Android 9 (API 28)
β’ No issues found!
``` | c: crash,framework,f: routes,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-framework,triaged-framework | low | Critical |
422,077,988 | create-react-app | npm start does not work on Node.js 11.3.0 and above. | <!--
PLEASE READ THE FIRST SECTION :-)
-->
### Is this a bug report?
Yes
<!--
If you answered "Yes":
Please note that your issue will be fixed much faster if you spend about
half an hour preparing it, including the exact reproduction steps and a demo.
If you're in a hurry or don't feel confident, it's fine to report bugs with
less details, but this makes it less likely they'll get fixed soon.
In either case, please fill as many fields below as you can.
If you answered "No":
If this is a question or a discussion, you may delete this template and write in a free form.
Note that we don't provide help for webpack questions after ejecting.
You can find webpack docs at https://webpack.js.org/.
-->
### Did you try recovering your dependencies?
<!--
Your module tree might be corrupted, and that might be causing the issues.
Let's try to recover it. First, delete these files and folders in your project:
* node_modules
* package-lock.json
* yarn.lock
Then you need to decide which package manager you prefer to use.
We support both npm (https://npmjs.com) and yarn (http://yarnpkg.com/).
However, **they can't be used together in one project** so you need to pick one.
If you decided to use npm, run this in your project directory:
npm install -g npm@latest
npm install
This should fix your project.
If you decided to use yarn, update it first (https://yarnpkg.com/en/docs/install).
Then run in your project directory:
yarn
This should fix your project.
Importantly, **if you decided to use yarn, you should never run `npm install` in the project**.
For example, yarn users should run `yarn add <library>` instead of `npm install <library>`.
Otherwise your project will break again.
Have you done all these steps and still see the issue?
Please paste the output of `npm --version` and/or `yarn --version` to confirm.
-->
Yes
### Which terms did you search for in User Guide?
<!--
There are a few common documented problems, such as watcher not detecting changes, or build failing.
They are described in the Troubleshooting section of the User Guide:
https://facebook.github.io/create-react-app/docs/troubleshooting
Please scan these few sections for common problems.
Additionally, you can search the User Guide itself for something you're having issues with:
https://facebook.github.io/create-react-app/
If you didn't find the solution, please share which words you searched for.
This helps us improve documentation for future readers who might encounter the same problem.
-->
Node compatibility, http error 400
### Environment
<!--
To help identify if a problem is specific to a platform, browser, or module version, information about your environment is required.
This enables the maintainers quickly reproduce the issue and give feedback.
Run the following command in your React app's folder in terminal.
Note: The result is copied to your clipboard directly.
`npx create-react-app --info`
Paste the output of the command in the section below.
-->
```
System:
OS: Windows 10
CPU: x64 Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz
Binaries:
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: 44.17763.1.0
Internet Explorer: 11.0.17763.1
Chrome: 73.0.3683.75
npmPackages:
react: ^16.8.4 => 16.8.4
react-dom: ^16.8.4 => 16.8.4
react-scripts: 2.1.8 => 2.1.8
npmGlobalPackages:
create-react-app: Not Found
```
### Steps to Reproduce
<!--
How would you describe your issue to someone who doesnβt know you or your project?
Try to write a sequence of steps that anybody can repeat to see the issue.
-->
(Write your steps here:)
1. Download an install node-v11.3.0-x64.msi
2. Open PowerShell
3. Set environment variable $env:DEBUG="*" for debugging
4. Run npx create-react-app new-app.
5. Run npm start
### Expected Behavior
<!--
How did you expect the tool to behave?
Itβs fine if youβre not sure your understanding is correct.
Just write down what you thought would happen.
-->
The default template should be shown in browser.
<img width="1288" alt="explorer_2019-03-18_15-37-49" src="https://user-images.githubusercontent.com/2337380/54514047-0470ce80-4994-11e9-92b6-42f1c725afc8.png">
### Actual Behavior
<!--
Did something go wrong?
Is something broken, or not behaving as you expected?
Please attach screenshots if possible! They are extremely helpful for diagnosing issues.
-->
The browser will show http error 400.
<img width="1039" alt="chrome_2019-03-18_15-33-57" src="https://user-images.githubusercontent.com/2337380/54513846-8ca2a400-4993-11e9-8dd2-1b10a42a8428.png">
| issue: needs investigation | low | Critical |
422,110,431 | flutter | Add run once after first build layout | Every time you need to use the context but run once the code you need to use some bool flag or ??= to instantiate only once. Something like didChangeDependencies() running once like initState() does. For example using .of(context) to get the BloC and subscribe to it.
Also for first after layout there is this package https://pub.dartlang.org/packages/after_layout.
This should be added by default in flutter. | c: new feature,framework,P3,team-framework,triaged-framework | medium | Critical |
422,110,805 | create-react-app | dynamic import are unrecognized in 3.0.0-next.b0cbf2ca, compile fails | <!--
PLEASE READ THE FIRST SECTION :-)
-->
### Is this a bug report?
Yes
<!--
If you answered "Yes":
Please note that your issue will be fixed much faster if you spend about
half an hour preparing it, including the exact reproduction steps and a demo.
If you're in a hurry or don't feel confident, it's fine to report bugs with
less details, but this makes it less likely they'll get fixed soon.
In either case, please fill as many fields below as you can.
If you answered "No":
If this is a question or a discussion, you may delete this template and write in a free form.
Note that we don't provide help for webpack questions after ejecting.
You can find webpack docs at https://webpack.js.org/.
-->
### Did you try recovering your dependencies?
<!--
Your module tree might be corrupted, and that might be causing the issues.
Let's try to recover it. First, delete these files and folders in your project:
* node_modules
* package-lock.json
* yarn.lock
Then you need to decide which package manager you prefer to use.
We support both npm (https://npmjs.com) and yarn (http://yarnpkg.com/).
However, **they can't be used together in one project** so you need to pick one.
If you decided to use npm, run this in your project directory:
npm install -g npm@latest
npm install
This should fix your project.
If you decided to use yarn, update it first (https://yarnpkg.com/en/docs/install).
Then run in your project directory:
yarn
This should fix your project.
Importantly, **if you decided to use yarn, you should never run `npm install` in the project**.
For example, yarn users should run `yarn add <library>` instead of `npm install <library>`.
Otherwise your project will break again.
Have you done all these steps and still see the issue?
Please paste the output of `npm --version` and/or `yarn --version` to confirm.
-->
`npm version` 6.8.0
### Which terms did you search for in User Guide?
<!--
There are a few common documented problems, such as watcher not detecting changes, or build failing.
They are described in the Troubleshooting section of the User Guide:
https://facebook.github.io/create-react-app/docs/troubleshooting
Please scan these few sections for common problems.
Additionally, you can search the User Guide itself for something you're having issues with:
https://facebook.github.io/create-react-app/
If you didn't find the solution, please share which words you searched for.
This helps us improve documentation for future readers who might encounter the same problem.
-->
### Environment
<!--
To help identify if a problem is specific to a platform, browser, or module version, information about your environment is required.
This enables the maintainers quickly reproduce the issue and give feedback.
Run the following command in your React app's folder in terminal.
Note: The result is copied to your clipboard directly.
`npx create-react-app --info`
Paste the output of the command in the section below.
-->
I used the command, but I got an error instead.
(node:16088) UnhandledPromiseRejectionWarning: Error: The system cannot find the path specified.
at Function.e.exports.sync (C:\Users\jonas\AppData\Roaming\npm\node_modules\create-react-app\node_modules\envinfo\dist\envinfo.js:1:7778)
at Object.copySync (C:\Users\jonas\AppData\Roaming\npm\node_modules\create-react-app\node_modules\envinfo\dist\envinfo.js:1:104976)
at Object.t.writeSync.e [as writeSync] (C:\Users\jonas\AppData\Roaming\npm\node_modules\create-react-app\node_modules\envinfo\dist\envinfo.js:1:123499)
at C:\Users\jonas\AppData\Roaming\npm\node_modules\create-react-app\node_modules\envinfo\dist\envinfo.js:1:124274 at Promise.all.then.e (C:\Users\jonas\AppData\Roaming\npm\node_modules\create-react-app\node_modules\envinfo\dist\envinfo.js:1:124289)
(node:16088) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwinginside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:16088) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.
I'm on Windows 10
- node v11.8.0
- npm v6.8.0
- react-scripts v3.0.0-next.b0cbf2ca
- react & react-dom v16.8.1
### Steps to Reproduce
<!--
How would you describe your issue to someone who doesnβt know you or your project?
Try to write a sequence of steps that anybody can repeat to see the issue.
-->
(Write your steps here:)
1. Create a new project with the latest prerelease (3.0.0-next.b0cbf2ca)
2. Import a module dynamically (eg. const AsyncApp = lazy(() => import('./App')))
3. npm start -> Failed to compile
### Expected Behavior
<!--
How did you expect the tool to behave?
Itβs fine if youβre not sure your understanding is correct.
Just write down what you thought would happen.
-->
(Write what you thought would happen.)
The build would pass, as it does in previous versions.
### Actual Behavior
<!--
Did something go wrong?
Is something broken, or not behaving as you expected?
Please attach screenshots if possible! They are extremely helpful for diagnosing issues.
-->
### Reproducible Demo
<!--
If you can, please share a project that reproduces the issue.
This is the single most effective way to get an issue fixed soon.
There are two ways to do it:
* Create a new app and try to reproduce the issue in it.
This is useful if you roughly know where the problem is, or canβt share the real code.
* Or, copy your app and remove things until youβre left with the minimal reproducible demo.
This is useful for finding the root cause. You may then optionally create a new project.
This is a good guide to creating bug demos: https://stackoverflow.com/help/mcve
Once youβre done, push the project to GitHub and paste the link to it below:
-->
(Paste the link to an example project and exact instructions to reproduce the issue.)
<!--
What happens if you skip this step?
We will try to help you, but in many cases it is impossible because crucial
information is missing. In that case we'll tag an issue as having a low priority,
and eventually close it if there is no clear direction.
We still appreciate the report though, as eventually somebody else might
create a reproducible example for it.
Thanks for helping us help you!
-->
| tag: underlying tools,issue: needs investigation | medium | Critical |
422,176,478 | TypeScript | This narrowing typeguard effect bleeds into subsequent statments on a type with bivariant type-parameter | **TypeScript Version:** 3.4.0-dev.201xxxxx (although 3.3 is also impacted)
**Search Terms:** this type guards
If we create a type-guard that narrows `this` on a type that has a type-parameter that is present only in a bivariant position, the effect of the type guard persists outside of the guarded block.
**Code**
```ts
type GetKnownKeys<G> = G extends GuardedMap<infer KnownKeys> ? KnownKeys: never;
interface GuardedMap<KnownKeys extends string> {
get(k: KnownKeys): number;
has<S extends string>(k: S): this is GuardedMap<S | GetKnownKeys<this>>;
}
declare let map: GuardedMap<never>;
map.get('bar') // err, as expected
if (map.has('foo')) {
map.get('foo').toExponential(); // ok as expected
if(map.has('bar'))
{
map.get('foo').toExponential(); // ok as expected
map.get('bar').toExponential(); // ok as expected
}
map.get('bar').toExponential(); /// OK!?!?! WHY ?!
}
map.get('bar') // OK ?!
```
**Expected behavior:**
Type guard only impacts the guarded block.
**Actual behavior:**
The effect of the type guard bleads into all subsequent statements. (marked with `OK!?!?!` and `OK?!`)
**Note:** With `strictFunctionTypes` on, declaring `get` as `get: (k: KnownKeys) => number;` makes the code work as expected.
**Playground Link:** [link](https://www.typescriptlang.org/play/#src=type%20GetKnownKeys%3CG%3E%20%3D%20G%20extends%20GuardedMap%3Cinfer%20KnownKeys%3E%20%20%3F%20KnownKeys%3A%20never%3B%0D%0Ainterface%20GuardedMap%3CKnownKeys%20extends%20string%3E%20%7B%0D%0A%20%20%20%20get(k%3A%20KnownKeys)%3A%20number%3B%0D%0A%20%20%20%20has%3CS%20extends%20string%3E(k%3A%20S)%3A%20this%20is%20GuardedMap%3CS%20%7C%20GetKnownKeys%3Cthis%3E%3E%3B%0D%0A%7D%0D%0A%0D%0Adeclare%20let%20map%3A%20GuardedMap%3Cnever%3E%3B%0D%0A%0D%0Amap.get('bar')%20%2F%2F%20err%0D%0A%2F%2F%20Works%20for%20string%20literals!%0D%0Aif%20(map.has('foo'))%20%7B%0D%0A%20%20%20%20map.get('foo').toExponential()%3B%0D%0A%20%20%20%20if(map.has('bar'))%20%0D%0A%20%20%20%20%7B%0D%0A%20%20%20%20%20%20%20%20map.get('foo').toExponential()%3B%0D%0A%20%20%20%20%20%20%20%20map.get('bar').toExponential()%3B%0D%0A%20%20%20%20%7D%0D%0A%20%20%20%20%20%20%20%20%0D%0A%20%20%20%20map.get('bar').toExponential()%3B%20%2F%2F%2F%20OK!%3F!%3F!%20WHY%20%3F!%0D%0A%20%20%20%20%0D%0A%7D%0D%0Amap.get('bar')%20%2F%2F%20OK%20%3F)
**Related Issues:** Similar to #14817
Found this while playing with a solution for #9619
| Suggestion,Needs Proposal | low | Major |
422,182,049 | go | x/image/riff: Implement write functionality | Presently, `x/image/riff` has no functionality for writing in the RIFF format; it only has read functionality. | NeedsDecision,FeatureRequest | low | Minor |
422,203,494 | TypeScript | Proposal: Follow program flow in constructor when strictPropertyInitialization = true | ## Search Terms
constructor strictPropertyInitialization flow
## Suggestion
TypeScript should follow unconditional function calls in constructor when checking for strict property initialization.
## Use Cases
It is a common pattern to be able to reset objects after construction and, thus, to transfer object initialization to a separate routine:
```ts
class C
{
private p: number;
public constructor() { Initialize() }
public Initialize() { p = 0; }
}
```
Currently, TypeScript doesn't consider functions being unconditionally called from within a constructor function when checking for strict property initialization. The above code yields a compiler error.
I propose TypeScript to be able to analyse code flow and recognize property initialization that's performed in functions unconditionally called by the constructor function.
## Checklist
My suggestion meets these guidelines:
* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals). | Suggestion,In Discussion | medium | Critical |
422,210,219 | flutter | Drag&Drop reorder between two lists | Hello!
I am trying to create some sort of task manager exactly like in trello and your library solving my problem of drag&droping perfectly, but now fully. Can you please make possivle to drag&drop item of list between two and more lists.
| c: new feature,framework,f: material design,d: examples,P3,team-design,triaged-design | low | Minor |
422,312,366 | flutter | [Material] Tooltip on FAB interrupts Ink response. | In the starter app created by `flutter create`, the FAB has a Tooltip that appears on a long press.
When the tooltip appears, it cancels out the Ink response on the FAB, even though the user is continuing the press.
| framework,a: animation,f: material design,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-design,triaged-design | low | Major |
422,322,499 | rust | Tracking issue for `BinaryHeap` sorted iterator methods | This tracks the stabilization of `BinaryHeap::into_iter_sorted` (`binary_heap_into_iter_sorted`) and `BinaryHeap::drain_sorted` (`binary_heap_drain_sorted`) implemented in https://github.com/rust-lang/rust/pull/65091.
EDIT much later:
- [ ] https://github.com/rust-lang/rust/pull/76234 looked at stabilizing part of this, but didn't come to a conclusion that it was ready-to-go as-is. The questions from there (such as consistency in order with `into_sorted_vec`) need to be addressed before a future attempt to stabilize.
Original feature request:
-----
Currently, both `BinaryHeap::into_iter` and `BinaryHeap::drain` yield the heap elements in an arbitrary order. This seems counter-intuitive given the nature of a heap. Sadly, we can't simply change their behavior behind the scenes, as we would have to remove the implementation of `DoubleEndedIterator`. Should we perhaps add `into_ordered_iter` and `drain_ordered`? The implementation is pretty straightforward so I'd be happy to submit a PR. | A-collections,T-libs-api,B-unstable,C-tracking-issue,A-iterators,Libs-Tracked | medium | Critical |
422,350,633 | material-ui | [Select] Remove the React.cloneElement usage | <!--- Provide a general summary of the issue in the Title above -->
I have a form with two text fields. The first text field works as expected in selecting and closing on click, but the second does and not have have gone in to very hacky territory in order to try to get it to work but it does not.
<!--
Thank you very much for contributing to Material-UI by creating an issue! β€οΈ
To avoid duplicate issues we ask you to check off the following list.
-->
<!-- Checked checkbox should look like this: [x] -->
- [X ] This is not a v0.x issue. <!-- (v0.x is no longer maintained) -->
- [X ] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Expected Behavior π€
The menu option should blur on click
## Current Behavior π―
It stays open and does not trigger a handleChange or handleBlur event in the parent. In the code sandbox it doesn't even open.
## Steps to Reproduce πΉ
<!---
Provide a link to a live example (you can use codesandbox.io) and an unambiguous set of steps to reproduce this bug.
Include code to reproduce, if relevant (which it most likely is).
This codesandbox.io template _may_ be a good starting point:
https://codesandbox.io/s/github/mui-org/material-ui/tree/next/examples/create-react-app
If you're using typescript a better starting point would be
https://codesandbox.io/s/github/mui-org/material-ui/tree/next/examples/create-react-app-with-typescript
If YOU DO NOT take time to provide a codesandbox.io reproduction, should the COMMUNITY take time to help you?
-->
Link: https://codesandbox.io/s/create-react-app-forked-s5ouz?file=/src/pages/index.js
## Context π¦
I need wrap the menu in an EnhancedComponent in order to Observe certain fields on the model (async)
## Your Environment π
<!---
Include as many relevant details about the environment with which you experienced the bug.
If you encounter issues with typescript please include version and tsconfig.
-->
| Tech | Version |
|--------------|---------|
| Material-UI | v3.6.0 |
| React | v16.8.0 |
| Browser | chrome 72.0.3626.121 |
| TypeScript | no |
| etc. | |
| new feature,component: select | medium | Critical |
422,386,771 | TypeScript | Convert to async/await doesn't support .finally() method | ```ts
declare function delay(n: number): Promise<void>;
async function foo() {
delay().then(x => delay(400)).then(x => delay(400)).finally(x => console.log(x));
}
``` | Suggestion,Experience Enhancement | low | Major |
422,399,488 | opencv | imread Should Raise If Path Doesn't Exist | ##### System information (version)
- OpenCV => 4.0.1
- Operating System / Platform => MacOS 10.14 Mojave
- Compiler => Xcode 10.1
##### Detailed description
`cv2.imread` doesn't check file existence and reads nonexistent files into a NoneType object. In comparison, `matplotlib.pyplot.imread` and `PIL` both throw.
##### Steps to reproduce
```python
import cv2
nonetype_thingy = cv2.imread('nonexistent_path.jpg') # this is somehow legal
cv2.imshow('lel', nonetype_thingy) # this will throw a "cv2.error: OpenCV(4.0.1) /Users/username/opencv/modules/highgui/src/window.cpp:352: error: (-215:Assertion failed) size.width>0 && size.height>0 in function 'imshow'"
```
| category: imgcodecs,RFC | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.