id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
409,070,589 | go | x/crypto/acme: send req with external context to RetryBackoff function | ### What did you do?
```golfing
client = &acme.Client{
Key: config.PrivateKey,
DirectoryURL: *ServerApiURL,
RetryBackoff: func(n int, r *http.Request, res *http.Response) time.Duration {
ctx := r.Context()
retryLogger := zc.L(ctx) // get logger from context https://github.com/rekby/zapcontext
if retryLogger == nil {
retryLogger = logger.With(zap.String("request_context", "no-logger"))
}
retryLogger.Info("Test")
}
}
```
Send request to Lets encrypt with retrieval error.
_, err = client.Accept(ctx, httpchallenge)
### What did you expect to see?
logs with my logger from ctx, and without request_context" = "no-logger"
### What did you see instead?
logs with "request_context" = "no-logger" and without my logger from context ctx.
I suggest to send req with external context to function. Now it receive clear context (but http call do with external context).
My patch for self: https://github.com/rekby/crypto/commit/9874cac870c3253304772cee7f13a87c56040e88
| NeedsInvestigation | low | Critical |
409,076,574 | go | x/build/maintner: GitHub issue becoming 404 (e.g., due to being deleted) is not reflected in model | GitHub issue golang/go#23772 is currently 404.
If it's possible to do so in the scope of the work that `maintner` already does (i.e., it doesn't require going out of its way), then it should detect that and set its [`NotExist`](https://godoc.org/golang.org/x/build/maintner#GitHubIssue.NotExist) field gets to true.
```Go
c, err := godata.Get(context.Background())
if err != nil {
panic(err)
}
i := c.GitHub().Repo("golang", "go").Issue(23772)
fmt.Println(i.NotExist)
// Output: false (but should be true)
```
/cc @bradfitz @jmdobry
(This came up from #30182.) | Builders,NeedsInvestigation | low | Major |
409,088,348 | rust | Redundant bounds check is not elided | [Nightly Playground link](https://play.rust-lang.org/?version=nightly&mode=release&edition=2018&gist=aed66d73af0bece065fb47940cefe14a)
Splitting a slice in two such that `left.len() <= right.len()`, then looping `left.len()` times over the elements of `left` and `right` cannot overflow, but a bounds check is emitted for `right[i]` regardless:
```rust
pub fn foo(bytes: &[u8]) -> u8 {
let (left, right) = bytes.split_at(bytes.len() >> 1);
let mut total: u8 = 0;
for i in 0..left.len() {
let a = left[i];
let b = right[i];
let n = a.wrapping_add(b);
total = total.wrapping_add(n);
}
total
}
```
```asm
playground::foo: # @playground::foo
# %bb.0:
pushq %rax
movq %rsi, %rcx
shrq %rcx
je .LBB0_1
# %bb.3:
movq %rsi, %r8
subq %rcx, %r8
leaq (%rdi,%rcx), %r9
xorl %eax, %eax
xorl %esi, %esi
.LBB0_4: # =>This Inner Loop Header: Depth=1
cmpq %r8, %rsi
jae .LBB0_6
# %bb.5: # in Loop: Header=BB0_4 Depth=1
addb (%rdi,%rsi), %al
addb (%r9,%rsi), %al
leaq 1(%rsi), %rdx
movq %rdx, %rsi
cmpq %rcx, %rdx
jb .LBB0_4
# %bb.2:
# kill: def $al killed $al killed $rax
popq %rcx
retq
.LBB0_1:
xorl %eax, %eax
# kill: def $al killed $al killed $rax
popq %rcx
retq
.LBB0_6:
leaq .Lanon.f6dd5f9df35562231dce3b61698e08b8.0(%rip), %rdi
movq %r8, %rdx
callq *core::panicking::panic_bounds_check@GOTPCREL(%rip)
ud2
# -- End function
str.0:
.ascii "src/lib.rs"
.Lanon.f6dd5f9df35562231dce3b61698e08b8.0:
.quad str.0
.quad 10 # 0xa
.long 6 # 0x6
.long 17 # 0x11
``` | A-LLVM,I-slow,C-enhancement,T-compiler,C-optimization | low | Minor |
409,106,154 | flutter | Consider Deprecating & Removing `BitField` and `kMaxUnsignedSMI` | The `kMaxUnsignedSMI` is based on and refers to smi and mints concepts from Dart 1. In Dart 2 all ints are 64 bits, making the current name and size inaccurate. It also cannot be accurately represented in JavaScript which only supports 32 bit ints. This poses issues for compilation, requiring either unsupported replacements or different behavior.
The BitField depends on this constant, but is also unused in the framework.
There were several new usages of the `kMaxUnsignedSMI` value which we should audit before introducing more.
cc @goderbauer @gspencergoog @Hixie | framework,c: API break,c: proposal,P2,team-framework,triaged-framework | low | Minor |
409,113,034 | rust | Unknown feature names are not reported if there are other errors | I just added an impl that I thought should be valid now with https://github.com/rust-lang/rfcs/pull/2451, but I got a compiler error. So I found the RFC and copied the feature name `re_rebalancing_coherence` from it. However, I still got the compile error, so I spent a while trying to figure out if the impl was really valid. Eventually, I tried commenting out the impl, and then (thanks to #52644), the compiler told me the feature was unknown (it has been renamed to `re_rebalance_coherence`). The impl was valid using the correct feature name. I didn't get the error saying the feature name was invalid because of the error caused by the feature name being invalid.
I think the compiler should report unknown feature names even if there are other errors. For example: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=e46fde7bf4076220df3005d702df9cbb doesn't report the feature name is invalid. With box syntax, it suggests "help: add #![feature(box_syntax)] to the crate attributes to enable" but the coherence error didn't.
Feel free to close this issue if you don't think it is worth fixing.
| C-enhancement,A-diagnostics,T-compiler | low | Critical |
409,151,881 | flutter | centerSlice throws exception when scaling down | This seems closely related to https://github.com/flutter/flutter/issues/20013, but I'm not sure whether it is the same issue.
I have two images that are being used as resolution-aware assets: the "main" asset is 68x46, and the 3.0x pixel ratio version is 208x142. If I use the asset in an `Image` widget with no `centerSlice` it works fine -- the 3.0x version is rendered at the same size as the lower-res main image as expected. I can set the `width` and `height` properties and they work as well.
Next, if I include *only* the main asset and give it a `centerSlice` and set the size of the `Image` to 100x46 everything still works okay, the `centerSlice` is applied properly, and everything looks good.
However, as soon as I add the 3.0x version, Flutter fails an assertion and throws an error about the `BoxFit` being wrong (even though it isn't) and says to create an issue here.
It seems the problem is something to do with the `centerSlice` processing not handling the scaling correctly. The only way I can make the error go away is to set the `height` and `width` of the `Image` to something that is equal to or greater than the actual size of the 3.0x image. Of course, that is not an actual solution because then the image renders at that larger size instead of what it should be.
## Logs
```
I/flutter (10662): ══╡ EXCEPTION CAUGHT BY RENDERING LIBRARY ╞═════════════════════════════════════════════════════════
I/flutter (10662): The following assertion was thrown during paint():
I/flutter (10662): centerSlice was used with a BoxFit that does not guarantee that the image is fully
visible.
I/flutter (10662): 'package:flutter/src/painting/decoration_image.dart': Failed assertion: line 406 pos 12: 'sourceSize
I/flutter (10662): == inputSize'
I/flutter (10662):
I/flutter (10662): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter (10662): more information in this error message to help you determine and fix the underlying cause.
I/flutter (10662): In either case, please report this assertion by filing a bug on GitHub:
I/flutter (10662): https://github.com/flutter/flutter/issues/new?template=BUG.md
I/flutter (10662):
I/flutter (10662): When the exception was thrown, this was the stack:
I/flutter (10662): #2 paintImage (package:flutter/src/painting/decoration_image.dart:406:12)
I/flutter (10662): #3 RenderImage.paint (package:flutter/src/rendering/image.dart:357:5)
I/flutter (10662): #4 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #5 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #6 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter (10662): #7 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #8 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #9 _RenderFlex&RenderBox&ContainerRenderObjectMixin&RenderBoxContainerDefaultsMixin.defaultPaint (package:flutter/src/rendering/box.dart:2273:15)
I/flutter (10662): #10 RenderFlex.paint (package:flutter/src/rendering/flex.dart:931:7)
I/flutter (10662): #11 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #12 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #13 RenderShiftedBox.paint (package:flutter/src/rendering/shifted_box.dart:70:15)
I/flutter (10662): #14 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #15 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #16 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter (10662): #17 RenderDecoratedBox.paint (package:flutter/src/rendering/proxy_box.dart:1974:11)
I/flutter (10662): #18 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #19 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #20 RenderShiftedBox.paint (package:flutter/src/rendering/shifted_box.dart:70:15)
I/flutter (10662): #21 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #22 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #23 _RenderCustomMultiChildLayoutBox&RenderBox&ContainerRenderObjectMixin&RenderBoxContainerDefaultsMixin.defaultPaint (package:flutter/src/rendering/box.dart:2273:15)
I/flutter (10662): #24 RenderCustomMultiChildLayoutBox.paint (package:flutter/src/rendering/custom_layout.dart:361:5)
I/flutter (10662): #25 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #26 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #27 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter (10662): #28 _RenderInkFeatures.paint (package:flutter/src/material/material.dart:491:11)
I/flutter (10662): #29 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #30 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #31 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter (10662): #32 RenderPhysicalModel.paint.<anonymous closure> (package:flutter/src/rendering/proxy_box.dart:1724:88)
I/flutter (10662): #33 ClipContext._clipAndPaint (package:flutter/src/painting/clip.dart:29:12)
I/flutter (10662): #34 ClipContext.clipRRectAndPaint (package:flutter/src/painting/clip.dart:49:5)I/flutter (10662): #35 RenderPhysicalModel.paint (package:flutter/src/rendering/proxy_box.dart:1724:17)
I/flutter (10662): #36 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #37 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #38 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter (10662): #39 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #40 PaintingContext.paintChild (package:flutter/src/rendering/object.dart:173:13)
I/flutter (10662): #41 _RenderProxyBox&RenderBox&RenderObjectWithChildMixin&RenderProxyBoxMixin.paint (package:flutter/src/rendering/proxy_box.dart:122:15)
I/flutter (10662): #42 RenderObject._paintWithContext (package:flutter/src/rendering/object.dart:2094:7)
I/flutter (10662): #43 PaintingContext._repaintCompositedChild (package:flutter/src/rendering/object.dart:128:11)
I/flutter (10662): #44 PaintingContext.repaintCompositedChild (package:flutter/src/rendering/object.dart:96:5)
I/flutter (10662): #45 PipelineOwner.flushPaint (package:flutter/src/rendering/object.dart:855:29)I/flutter (10662): #46 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding.drawFrame (package:flutter/src/rendering/binding.dart:283:19)
I/flutter (10662): #47 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:686:13)
I/flutter (10662): #48 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:219:5)
I/flutter (10662): #49 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
I/flutter (10662): #50 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:930:9)
I/flutter (10662): #51 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._handleDrawFrame (package:flutter/src/scheduler/binding.dart:842:5)
I/flutter (10662): #52 _invoke (dart:ui/hooks.dart:159:13)
I/flutter (10662): #53 _drawFrame (dart:ui/hooks.dart:148:3)
I/flutter (10662): (elided 2 frames from class _AssertionError)
I/flutter (10662):
I/flutter (10662): The following RenderObject was being processed when the exception was fired:
I/flutter (10662): RenderImage#77fd3 relayoutBoundary=up6
I/flutter (10662): creator: RawImage ← Semantics ← Image ← GoogleSignInButton ← BlocBuilder<AccountEvent,
I/flutter (10662): AccountState> ← Column ← Padding ← DecoratedBox ← Container ← MediaQuery ← Padding ← SafeArea ← ⋯
I/flutter (10662): parentData: <none> (can use size)
I/flutter (10662): constraints: BoxConstraints(0.0<=w<=395.4, 0.0<=h<=Infinity)
I/flutter (10662): size: Size(69.3, 47.3)
I/flutter (10662): image: [208×142]
I/flutter (10662): scale: 3.0
I/flutter (10662): alignment: center
I/flutter (10662): centerSlice: Rect.fromLTRB(53.0, 7.0, 55.0, 9.0)
I/flutter (10662): invertColors: false
I/flutter (10662): filterQuality: low
I/flutter (10662): This RenderObject has no descendants.
I/flutter (10662): ════════════════════════════════════════════════════════════════════════════════════════════════════
```
```
No issues found! (ran in 21.0s)
```
```
[√] Flutter (Channel beta, v1.1.8, on Microsoft Windows [Version 10.0.17763.55], locale en-US)
• Flutter version 1.1.8 at C:\Users\Caleb\flutter
• Framework revision 985ccb6d14 (5 weeks ago), 2019-01-08 13:45:55 -0800
• Engine revision 7112b72cc2
• Dart version 2.1.1 (build 2.1.1-dev.0.1 ec86471ccc)
[!] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at C:\Users\Caleb\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
X Android license status unknown.
[√] Android Studio (version 3.3)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 32.0.1
• Dart plugin version 182.5124
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
[√] VS Code (version 1.31.0)
• VS Code at C:\Users\Caleb\AppData\Local\Programs\Microsoft VS Code
• Flutter extension version 2.22.3
[√] Connected device (1 available)
• Pixel 2 XL • 709KPNY0046767 • android-arm64 • Android 9 (API 28)
! Doctor found issues in 1 category.
```
| c: crash,framework,a: images,has reproducible steps,P2,found in release: 3.3,found in release: 3.5,team-framework,triaged-framework | low | Critical |
409,184,290 | TypeScript | Recursive definitions in mixins | Its currently possible to create a circular references in classes just fine:
```ts
export class Class1 {
another : Class2 // compiles fine
}
export class Class2 {
another : Class1 // compiles fine
}
```
However, the same thing fails when using mixin-based classes:
```ts
export const SampleMixin1 = <T extends AnyConstructor<object>>(base : T) =>
class SampleMixin1 extends base {
another : SampleMixin2 // TS2502: 'another' is referenced directly or indirectly in its own type annotation
}
export type SampleMixin1 = Mixin<typeof SampleMixin1>
export const SampleMixin2 = <T extends AnyConstructor<object>>(base : T) =>
class SampleMixin2 extends base {
another : SampleMixin1 // TS2502: 'another' is referenced directly or indirectly in its own type annotation
}
export type SampleMixin2 = Mixin<typeof SampleMixin2>
// supporting declarations for mixin pattern
export type AnyFunction<A = any> = (...input: any[]) => A
export type AnyConstructor<A = any> = new (...input: any[]) => A
export type Mixin<T extends AnyFunction> = InstanceType<ReturnType<T>>
```
This makes things much more complicated, you need to introduce some dummy interfaces, etc, etc.
The workaround exists - to use different form of creating the type for the standalone mixin class - with interfaces:
```ts
export const SampleMixin3 = <T extends AnyConstructor<object>>(base : T) =>
class SampleMixin3 extends base {
another : SampleMixin4
}
export interface SampleMixin3 extends Mixin<typeof SampleMixin3> {}
export const SampleMixin4 = <T extends AnyConstructor<object>>(base : T) =>
class SampleMixin4 extends base {
another : SampleMixin3
}
export interface SampleMixin4 extends Mixin<typeof SampleMixin4> {}
```
But this notation seems to drive crazy the IDE (the language server under the hood?). It stop finding usages of properties, show many false type errors etc. Basically in such approach you are limited to old-good console `npx tsc` launch (which works well at least), but all the development aid facilities don't work.
I think mixin pattern should be supported first class. I'd even create some language construct for it.
| Suggestion,Awaiting More Feedback | medium | Critical |
409,197,515 | go | net/rpc/jsonrpc: client implementation is not compatible with JSON-RPC 1.0 spec | According to [JSON-RPC 1.0 specification](https://www.jsonrpc.org/specification_v1) the params property should be an array of object. The canonical example of calling remote methods with JSON-RPC 1.0 is to send the parameters as one dimensional JSON array:
`{"method": "concat", "params": ["foo", "bar"], "id": 123}`
The GO's client implementation will always wrap the params property in an additional array:
`{"method": "concat", "params": [["foo", "bar"]], "id": 123}`
This works fine as long as both ends use the GO's implementation and expect the actual params to be the first element of the params array. It becomes a problem if you have another server implementation of JSON-RPC 1.0 but want to use GO's client to call remote methods.
I have worked around this issue locally by fixing it in my [go fork](https://github.com/stefangluszek/go/commit/80d3eb1e1fd3c5f55dc0776bde7218c2e10650f6). | help wanted,NeedsInvestigation | low | Major |
409,307,979 | react-native | SectionList ListHeaderComponent gets rerendered when sections data changes | ## 🐛 Bug Report
This is a duplicate of:
https://github.com/facebook/react-native/issues/16824
https://github.com/facebook/react-native/issues/16823
https://github.com/facebook/react-native/issues/14249
But since those 3 were closed and they are missing a reproducible example of the bug I'm reopening.
## Description
If one uses a TextInput as a ListHeaderComponent when searching and when the returned sections are empty the TextInput loses focus.
If when searching the sections still have data - then the TextInput in the ListHeaderComponent doesn't lose focus.
## To Reproduce
https://snack.expo.io/H12h3BgHV
## Expected Behavior
I would expect for the TextInput not to lose focus
## Code Example
https://snack.expo.io/H12h3BgHV
## Environment
[skip envinfo]
RN 0.58
I've been trying to debug this with @pawelczerepak and what we noticed is that VirtualizedCellWrapper
https://github.com/facebook/react-native/blob/master/Libraries/Lists/VirtualizedList.js#L1759
gets unmounted and mounted when sections is an empty array. And when this happens everything inside of it gets unmounted and mounted again.
@sahrens - any ideas on what might be going on here? | Ran Commands,Component: SectionList,Bug | low | Critical |
409,354,950 | flutter | Getting AnimationController from ExpansionTile | <!-- Thank you for using Flutter!
Please check out our documentation first:
* https://flutter.io/
* https://docs.flutter.io/
If you can't find the answer there, please consider asking a question on
the Stack Overflow Web site:
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
Please don't file a GitHub issue for support requests. GitHub issues are
for tracking defects in the product. If you file a bug asking for help, we
will consider this a request for a documentation update.
-->
Im trying to make an ExpansionTile with a custom trailing AnimatedIcon:
```dart
ExpansionTile(title: Text("Test"), trailing: AnimatedIcon(icon: AnimatedIcons.home_menu, progress: ???))
```
However I can't get the progress value from the ExpansionTile, because it's stored in a private variable https://github.com/flutter/flutter/blob/af3cdb33dab6092c47453b6cdcb790514caf8e6b/packages/flutter/lib/src/material/expansion_tile.dart#L91. Am I missing something or is it impossible for now to subscribe to that value? | c: new feature,framework,f: material design,P2,team-design,triaged-design | low | Critical |
409,376,975 | electron | Unwanted Prevent Sleep behavior when using media in BrowserWindow | **Is your feature request related to a problem? Please describe.**
When having media like a video in a `BrowserWindow`, the app prevents the system from going to sleep (on MacOS, have not tested Windows), much like chrome does. If that is not the desired behavior, there would be nice to have an API control wether that should happen or not
**Describe the solution you'd like**
An API that can enable/disable the "prevent from going to sleep" behavior
**Describe alternatives you've considered**
A workaround we have found for now is pausing the media when the `BrowserWindow` is blurred
| enhancement :sparkles: | low | Minor |
409,412,073 | flutter | Test output is hard to read | The `compact` reporter isn't really compact if you have errors, info messages, or skips in your test run. It's particularly difficult if there are multiple failures, or if you're using CI and the failures don't happen to be the very last tests that are run.
I have started work on addressing this: https://github.com/flutter/flutter/compare/master...dnfield:test_reporter but want to solicit feedback. Some things I can think of that we want to acheive:
1. Any invocation of the test package use the new reporter (whether for packags/flutter, packages/flutter_tools, or wherever else in our repo). My WIP change is only handling `flutter test` at the moment.
2. Right now I'm just wrapping the `json` reporter. We could write our own reporter, but ultimately I'd like to see us able to use the data from our test runs in a more structured manner for analytics, which will probably require wrapping the JSON reporter anyway.
/cc @jonahwilliams | a: tests,c: new feature,team,tool,P2,team-tool,triaged-tool | low | Critical |
409,439,425 | vscode | [html] [custom data] allow to give custom HTML tags/attributes a higher completion rank | From https://github.com/Microsoft/vscode/issues/62976#issuecomment-462002568
Maybe similar to https://marketplace.visualstudio.com/items?itemName=VisualStudioExptTeam.VSIntelliCode#review-details, we should show custom tags/attributes on top of others (with a `*`). | feature-request,html | low | Minor |
409,461,463 | opencv | Error on build for 3.4 with Visual Studio 2017 | I am trying to build OpenCV 3.4 to use with UWP but I get errors saying method GetModuleHandleEx is not part of global namespace on file datafile.cpp
Error on build with Visual Studio 2017.
core/src/utils/datafile.cpp doesn't build for UWP (Windows Store 10.0 x64)
Error C2039 'GetModuleHandleEx': no es un miembro de '`global namespace'' opencv_world
Error C2065 'GET_MODULE_HANDLE_EX_FLAG_FROM_ADDRESS': identificador no declarado opencv_world
_Originally posted by @pablolq in https://github.com/opencv/opencv/issues/7143#issuecomment-462896650_ | priority: low,category: build/install,platform: winrt/uwp | low | Critical |
409,463,355 | vscode | Warning for trailing spaces in folder names | Issue Type: <b>Feature Request</b>
My colleague and I had an insanely embarassing and unforgetable experience today at work due to the lack of a feature involving trailing spaces in folder names.
I was teaching my colleague how to use Redux with React Native when we got an error in the console. Something along the lines: "Could not resolve module reducers. Path ./reducers not found."
I had encountered this issue many times before with previous versions of Expo in which the Metro Bundler cache would not update correctly and it would not recognize the creation of a new folder. I believed the problem to be related to the cache and my colleague and I spent half a day researching the issue on Google and StackOverflow.
Eventually, we realized that my colleague had accidentally included a space at the end of the folder name as follows: "reducers ". Not in the import statement, however.
There should undoubtedly be a feature in VSCode that enables a warning message by default for trailing spaces in both folder and file names.
Though I will admit, the laugh we got out of this was well worth the loss of time.
VS Code version: Code - OSS 1.30.2 (61122f88f0bf01e2ac16bdb9e1bc4571755f5bd8, 2019-01-08T23:10:56.746Z)
OS version: Linux x64 4.20.6-arch1-1-ARCH
<!-- generated by issue reporter --> | feature-request,languages-diagnostics | low | Critical |
409,466,466 | TypeScript | Make automatic adding missing imports smarter | ### Scenario 1: Fuzzy Logic
I have a several files containing `import {connect} from "react-redux";`. If I use the add missing imports context menu to add the missing import for `connect`, the system should realize "react-redux" is far more probable module than "net", "tls", and "http2", which are all recommended higher than "react-redux", but none of which are used anywhere in my project.
### Scenario 2: Respect node conventions
If I have a file `./myfolder/index.ts`, I can import the file with `import "./myfolder"`. The system currently resolves missing imports from `./myfolder` as `./myfolder/index.ts`, when it should actually use `./myfolder`. | Suggestion,Awaiting More Feedback | low | Major |
409,486,233 | pytorch | Download speed issues with the pytorch conda channel | Download speed of pytorch/torch is too slow. I'm downloading the file around 80KB/s at 24MBit/s connection. I've searched the same file I've been downloading and found at a mirror which lets 1MB/s download speed, what is going on with pytorch? not enough bandwidth for science?
original link for pip install torchvision was "https://files.pythonhosted.org/packages/93/b3/672813e65ac7605bac14a2a8e40e1a18e03bf0ac588c6a799508ee66c289/torch-1.0.1.post2-cp27-cp27mu-manylinux1_x86_64.whl"
the link I'm downloading it now; https://pypi.lcsb.uni.lu/packages/93/b3/672813e65ac7605bac14a2a8e40e1a18e03bf0ac588c6a799508ee66c289/torch-1.0.1.post2-cp27-cp27mu-manylinux1_x86_64.whl
this is seriously weird. | module: dependency bug,triaged | high | Major |
409,507,440 | rust | rustdoc should skip unresolvable private members | When using the `doc_cfg` feature it's useful to run rustdoc on structures that aren't defined for the running platform. However, compilation will fail if those structures have private members that also aren't defined on the running platform. The only solution is to laboriously `#[cfg]` gate each private member, even if the struct itself is already gated. This issue severely restricts the usefulness of `doc_cfg`. Here's an example:
```rust
#[cfg(any(target_os = "freebsd", rustdoc))]
struct NewType {
x: libc::something_freebsd_specific
}
```
rustdoc will fail unless you add another `#[cfg(target_os = "freebsd")]` attribute directly on `x`. It should be possible for rustdoc to simply ignore `x`, since private members aren't normally documented anyway.
For a real-world example, see https://github.com/nix-rust/nix/pull/1019/files#diff-78f451c970a63ad3a93cab0d2670b05dR12 . That PR only builds because of the extra `#[cfg()]` gate on the `libc::ucontext` variable, even though the entire module is already restricted to Linux.
doc_cfg tracking issue: https://github.com/rust-lang/rust/issues/43781
| T-rustdoc,A-visibility | low | Minor |
409,513,709 | TypeScript | Disallow excess properties to React components (for performance) | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
react excess props properties component function parameters
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
``` ts
import * as React from 'react';
import { ComponentType } from 'react';
type Props = { foo: 1 };
declare const MyComponent: ComponentType<Props>;
declare const propsWithExtras: Props & { bar: 1 };
// Expected error, but got none
<MyComponent {...propsWithExtras} />;
```
I understand this matches TypeScript's behaviour with functions:
``` ts
type Props = { foo: 1 };
declare const MyFunction: (props: Props) => void;
declare const propsWithExtras: Props & { bar: 1 };
// No error
MyFunction(propsWithExtras);
MyFunction({ ...propsWithExtras });
```
However, with React, passing excess props to a component is a performance concern, since those excess props may break component memoization, causing the component to update more frequently than it should.
In my experience, this error most often occurs when wrapping components, where the wrapper components need to "pass through" types to a child:
``` ts
type MyComponentProps = { foo: 1 };
declare const MyComponent: ComponentType<MyComponentProps>;
type MyWrapperComponent = MyComponentProps & { myWrapperProp: 1 };
const MyWrapperComponent: ComponentType<MyWrapperComponent> = props => (
<MyComponent
// We're passing too many props here, but no error!
{...props}
/>
);
```
Workarounds I'm aware of: (1) avoid spreading, but this quickly becomes a non-option when a component has many props you have to manually pick and pass through.
``` ts
const MyWrapperComponent: ComponentType<MyWrapperComponent> = ({ foo, myWrapperProp }) => (
// Error as expected due to excess prop `myWrapperProp`
<MyComponent foo={foo} myWrapperProp={myWrapperProp} />
);
```
(2) Pass through props via an object.
``` ts
type MyWrapperComponent = { myComponentProps: MyComponentProps } & { myWrapperProp: 1 };
const MyWrapperComponent: ComponentType<MyWrapperComponent> = ({ myComponentProps, myWrapperProp }) => (
// Error as expected due to excess prop `myWrapperProp`
<MyComponent {...myComponentProps} myWrapperProp={myWrapperProp} />
);
```
However then [we lose special JSX behaviour such as the ability to pass data attributes as props](https://github.com/Microsoft/TypeScript/issues/28960).
IIUC, this could be a use case for https://github.com/Microsoft/TypeScript/issues/12936.
## Checklist
My suggestion meets these guidelines:
* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [ ] This wouldn't change the runtime behavior of existing JavaScript code
* [ ] This could be implemented without emitting different JS based on the types of the expressions
* [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Needs Proposal | medium | Critical |
409,580,579 | pytorch | Errors running distributed example | I am new to pytorch and distributed learning in general and I’m trying to go through this tutorial here: https://pytorch.org/tutorials/beginner/aws_distributed_training_tutorial.html. After setting everything up, when I run the 4 different python processes (2 on each machine) I always get the following error:
```
File “/home/ec2-user/anaconda3/envs/pytorch_p36/lib/python3.6/site-packages/torch/distributed/rendezvous.py”, line 95, in _tcp_rendezvous_handler
store = TCPStore(result.hostname, result.port, start_daemon)
RuntimeError: Address already in use
```
I feel like this is somehow related to the init_method being specified. I’m using the rank 0 machine ip and port for that value as specified in the tutorial. Nothing else is running on that port. Am I missing something about how to configure this properly?
I got around this by setting up EFS in AWS to avoid using the TCP init method, but then I ran into a second issue.
```
RuntimeError:
An attempt has been made to start a new process before the
current process has finished its bootstrapping phase.
This probably means that you are not using fork to start your
child processes and you have forgotten to use the proper idiom
in the main module:
if __name__ == '__main__':
freeze_support()
...
The "freeze_support()" line can be omitted if the program
is not going to be frozen to produce an executable.
```
From what I found on this error it seems to be an issue that happens on Windows, but I'm running linux. I tried adding the suggested line anyways, but still get the same error.
Not sure what else to try at this point. | oncall: distributed,triaged | low | Critical |
409,590,547 | vue | 升级2.6以上版本后在部分安卓机上input使用v-model的同时有对数据格式化时光标异常 | ### Version
2.6.6
### Reproduction link
https://codepen.io/matf5/project/editor/ARGnKV
```
computed: {
cardNoFormat: {
get() {
return this.cardNo.replace(/(\d{4})(?=\d)/g, '$1 ');
},
set(value) {
this.cardNo = value;
}
}
}
```
### Steps to reproduce
例如输入输入62148时，数据会变为6214 8
### What is expected?
光标位于8后面
### What is actually happening?
有问题的安卓机如vivo，华为荣耀在部分浏览器内核下（如uc）光标会卡在8前面
<!-- generated by vue-issues. DO NOT REMOVE --> | need repro,browser quirks | low | Minor |
409,598,901 | kubernetes | Distribute debugging symbols for every binary in a Kubernetes release | **What would you like to be added**:
Distribute the debugging symbols generated when building every binary (e.g. kube-apiserver, kube-scheduler, kube-controller-manager, etc) in a Kubernetes release.
**Why is this needed**:
To allow debugging of official Kubernetes binaries "in situ," i.e., in a cluster that is already deployed. Currently, end users who want to debug "in situ" have to [build and distribute their own binaries](https://github.com/kubernetes/kubernetes/pull/70276#issuecomment-436831592). End users who choose to use (or are forced to use) official Kubernetes binaries are unable to debug "in situ."
Delve, the de facto go debugger, [added support in November 2018](https://github.com/go-delve/delve/commit/51c342c6b70ac8f75298ffc534e220da751c19d6) for reading debug symbols from external files. And GDB [has had support](https://sourceware.org/gdb/onlinedocs/gdb/Separate-Debug-Files.html) for longer. | kind/feature,help wanted,sig/release,lifecycle/frozen,needs-triage | medium | Critical |
409,608,201 | terminal | AllocConsole failing with ERROR_GEN_FAILURE as a service in rare cases | We have a software package running on thousands of Windows machines from XP onward. In 2 cases we have received a bug report that the users application fails to call AllocConsole with error code ERROR_GEN_FAILURE. This has been seen once on a Windows Server 2008 system and the second on a Windows Server 2012 system. In both cases the error was encountered while running as a Service.
The error message is "A device attached to the system is not functioning. (0x1f)"
Unfortunately we have not been able to reproduce this on any other systems. It happens 100% of the time of the failing system however.
I was able to find any documentation that shows this as a possible error.
Any thoughts on this would be appreciated.
| Product-Conhost,Area-Server,Issue-Bug | low | Critical |
409,719,105 | rust | Getter functions and indexing don't seem to follow the same lifetime rules | This is my first issue for the Rust project. Apologies up front if it is somehow unclear. I'd be happy to provide any additional information you need.
DESCRIPTION
The issue I'm running into is this. Consider the following code:
`collection.get_mut(collection.get(0).unwrap().index).unwrap().index = 1;`
The inner call to `get` causes an immutable borrow on `collection`. We then obtain a index from the return value, and use that for the outer call to `get_mut`. This causes a mutable borrow on `collection`.
The above code compiles just fine. My assumption is that because `index` implements `Copy`, NLL allow the immutable borrow on `collection` to be dropped as soon as we have a copy of `index`, so we can borrow it mutably again after that.
So far, so good. However, now consider the following code:
`collection[collection[0].index].index = 1`;
EXPECTED BEHAVIOR
This should be equivalent to the earlier code. In fact, I've implemented the `Index` trait to forward to `get(index).unwrap()`.
ACTUAL BEHAVIOR
This time, however, the compiler complains:
`error[E0502]: cannot borrow `collection` as immutable because it is also borrowed as mutable`
For more context, here is a playground link that illustrates the problem:
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=21d19fde2c8c58d4859bfdefa3b7720a | P-medium,T-compiler,A-NLL,NLL-complete | low | Critical |
409,763,485 | flutter | TextFormField doesn't support input shortcuts | Some input software have some shortcut to help us quickly edit the input fields (like the screenshot below), but it seems the `TextFormField` (and maybe `TextField` and so on) doesn't support those behavour?
***
> flutter analyze
> flutter doctor -v
| a: text input,c: new feature,framework,P2,team-framework,triaged-framework | low | Major |
409,817,216 | opencv | OpenCL related test failures on MacOS 10.14 (AppleClang 10.0) | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 4.0.1
- Operating System / Platform => macOS 10.14.2 (18C54)
- Compiler => Apple LLVM version 10.0.0 (clang-1000.10.44.4)
Hardware (as reported by opencv tests)
```
OpenCL Platforms:
Apple
CPU: Intel(R) Core(TM) i7-8700B CPU @ 3.20GHz (OpenCL 1.2 )
iGPU: Intel(R) UHD Graphics 630 (OpenCL 1.2 )
Current OpenCL device:
Type = iGPU
Name = Intel(R) UHD Graphics 630
Version = OpenCL 1.2
Driver version = 1.2(Nov 26 2018 20:27:30)
```
##### Detailed description
* **opencv_test_gapi** produces the following errors:
```
[ FAILED ] 32 tests, listed below:
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/5, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 3, 125, 5, false, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/4, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 3, 125, 5, false, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/6, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 3, 125, 5, true, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/7, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 3, 125, 5, true, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/12, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 3, 240, 5, false, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/13, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 3, 240, 5, false, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/14, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 3, 240, 5, true, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/15, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 3, 240, 5, true, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/20, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 120, 125, 5, false, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/21, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 120, 125, 5, false, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/22, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 120, 125, 5, true, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/23, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 120, 125, 5, true, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/28, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 120, 240, 5, false, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/29, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 120, 240, 5, false, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/30, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 120, 240, 5, true, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/31, where GetParam() = (48-byte object ..., 8UC1, 1280x720, 120, 240, 5, true, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/36, where GetParam() = (48-byte object ..., 8UC1, 640x480, 3, 125, 5, false, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/37, where GetParam() = (48-byte object ..., 8UC1, 640x480, 3, 125, 5, false, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/38, where GetParam() = (48-byte object ..., 8UC1, 640x480, 3, 125, 5, true, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/39, where GetParam() = (48-byte object ..., 8UC1, 640x480, 3, 125, 5, true, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/44, where GetParam() = (48-byte object ..., 8UC1, 640x480, 3, 240, 5, false, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/45, where GetParam() = (48-byte object ..., 8UC1, 640x480, 3, 240, 5, false, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/46, where GetParam() = (48-byte object ..., 8UC1, 640x480, 3, 240, 5, true, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/47, where GetParam() = (48-byte object ..., 8UC1, 640x480, 3, 240, 5, true, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/52, where GetParam() = (48-byte object ..., 8UC1, 640x480, 120, 125, 5, false, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/53, where GetParam() = (48-byte object ..., 8UC1, 640x480, 120, 125, 5, false, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/54, where GetParam() = (48-byte object ..., 8UC1, 640x480, 120, 125, 5, true, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/55, where GetParam() = (48-byte object ..., 8UC1, 640x480, 120, 125, 5, true, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/60, where GetParam() = (48-byte object ..., 8UC1, 640x480, 120, 240, 5, false, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/61, where GetParam() = (48-byte object ..., 8UC1, 640x480, 120, 240, 5, false, true, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/62, where GetParam() = (48-byte object ..., 8UC1, 640x480, 120, 240, 5, true, false, { 32-byte object ... })
[ FAILED ] CannyTestGPU/CannyTest.AccuracyTest/63, where GetParam() = (48-byte object ..., 8UC1, 640x480, 120, 240, 5, true, true, { 32-byte object ... })
```
In all the cases above the error is similar to this below:
```
2-7F 00-00 70-C8 A8-A4 A2-7F 00-00>, 8UC1, 640x480, 3, 240, 5, false, true, { 32-byte object <26-67 61-70 69-2E 6B-65 72-6E 65-6C 5F-70 61-63 6B-61 67-65 00-00 00-00 90-8E 47-A4 A2-7F 00-00> })
AbsSimilarPoints error: err_points=116124 max_err_points=15360 (total=307200) diff_tolerance=0
opencv/modules/gapi/test/common/gapi_imgproc_tests_inl.hpp:407: Failure
Value of: cmpF(out_mat_gapi, out_mat_ocv)
Actual: false
Expected: true
```
* **opencv_test_imgproc** produces the following errors:
```
[ FAILED ] OCL_ImgProc/Canny.Accuracy/4, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(false), UseRoi(false))
[ FAILED ] OCL_ImgProc/Canny.Accuracy/5, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(false), UseRoi(true))
[ FAILED ] OCL_ImgProc/Canny.Accuracy/6, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(true), UseRoi(false))
[ FAILED ] OCL_ImgProc/Canny.Accuracy/7, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(true), UseRoi(true))
[ FAILED ] OCL_ImgProc/Canny.AccuracyCustomGradient/4, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(false), UseRoi(false))
[ FAILED ] OCL_ImgProc/Canny.AccuracyCustomGradient/5, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(false), UseRoi(true))
[ FAILED ] OCL_ImgProc/Canny.AccuracyCustomGradient/6, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(true), UseRoi(false))
[ FAILED ] OCL_ImgProc/Canny.AccuracyCustomGradient/7, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(true), UseRoi(true))
[ FAILED ] OCL_ImageProc/SepFilter2D.Mat/0, where GetParam() = (CV_8U, Channels(1), BORDER_CONSTANT, false, false)
[ FAILED ] OCL_ImageProc/SepFilter2D.Mat/2, where GetParam() = (CV_8U, Channels(1), BORDER_CONSTANT, true, false)
[ FAILED ] OCL_ImageProc/SepFilter2D.Mat/4, where GetParam() = (CV_8U, Channels(1), BORDER_REPLICATE, false, false)
[ FAILED ] OCL_ImageProc/SepFilter2D.Mat/6, where GetParam() = (CV_8U, Channels(1), BORDER_REPLICATE, true, false)
[ FAILED ] OCL_ImageProc/SepFilter2D.Mat/8, where GetParam() = (CV_8U, Channels(1), BORDER_REFLECT, false, false)
[ FAILED ] OCL_ImageProc/SepFilter2D.Mat/10, where GetParam() = (CV_8U, Channels(1), BORDER_REFLECT, true, false)
[ FAILED ] OCL_ImageProc/SepFilter2D.Mat/12, where GetParam() = (CV_8U, Channels(1), BORDER_REFLECT_101, false, false)
[ FAILED ] OCL_ImageProc/SepFilter2D.Mat/14, where GetParam() = (CV_8U, Channels(1), BORDER_REFLECT_101, true, false)
```
The errors are as below:
```
[ RUN ] OCL_ImgProc/Canny.AccuracyCustomGradient/5, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(false), UseRoi(true))
opencv/modules/imgproc/test/ocl/test_canny.cpp:126: Failure
Expected: (checkSimilarity(dst_roi, udst_roi)) <= (eps), actual: 0.428767 vs 0.03
Size: [512 x 480]
opencv/modules/imgproc/test/ocl/test_canny.cpp:127: Failure
Expected: (checkSimilarity(dst, udst)) <= (eps), actual: 0.428351 vs 0.03
Size: [514 x 556]
[ FAILED ] OCL_ImgProc/Canny.AccuracyCustomGradient/5, where GetParam() = (Channels(1), ApertureSize(5), L2gradient(false), UseRoi(true)) (14 ms)
```
```
[ RUN ] OCL_ImageProc/SepFilter2D.Mat/6, where GetParam() = (CV_8U, Channels(1), BORDER_REPLICATE, true, false)
opencv/modules/imgproc/test/ocl/test_sepfilter2d.cpp:105: Failure
Expected: (TestUtils::checkNorm2(dst_roi, udst_roi)) <= (threshold), actual: 78 vs 1
Size: [60 x 51]
[ FAILED ] OCL_ImageProc/SepFilter2D.Mat/6, where GetParam() = (CV_8U, Channels(1), BORDER_REPLICATE, true, false) (4 ms)
```
In both cases the errors go away if I run the tests with environment variable: `OPENCV_OPENCL_DEVICE=disabled`
##### Steps to reproduce
Just let it build with the defaults
```
OpenCL: YES (no extra features)
Include path: NO
Link libraries: -framework OpenCL
``` | bug,priority: low,platform: ios/osx,category: ocl | low | Critical |
409,831,766 | opencv | Some Suggestions to OpenCV Team | ##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => 4.0.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2017
**Suggestions to OpenCV Team:**
I want to suggest for some operation which is needed to be added in the feature releases.
1. Mat multiplication operation needs to support an optional mask parameter.
2. Mat division operation needs to support an optional mask parameter.
3. The normalize operation needs to support inverse of the current Min-Max operation, it means for example if we have an array like [0.1, 0.2, 0.3] then if we want to normalize the array in the range 0~255 it can give as [255, 128, 0], but now only gives [0, 128, 255]
These operations were what we needed, but was not implemented in OpenCV. And also when I searched, other people also ask these questions.
Thanks! Long live with OpenCV!
| RFC | low | Minor |
409,859,935 | opencv | Updating installation instructions, adding package manager installation and macOS | ERROR: type should be string, got "https://docs.opencv.org/3.4.5/df/d65/tutorial_table_of_content_introduction.html\r\n\r\nThis link contains links to installation instructions for Linux, Windows and iOS, but not macOS.\r\n\r\nA lot of macOS users will know that they can probably use the instructions for Linux (they can right? I'm not 100% sure) - but it's not safe to assume that they all will. Also, the Linux instructions do not mention that they can work on macOS, too (they only say`The following steps have been tested for Ubuntu 10.04 but should work with other distros as well.`). \r\n\r\nI don't have too much knowledge about OpenCV, but I feel like those instructions (for Linux, for example) should be updated. The fact that they mention testing on Ubuntu 10.04 is a hint towards that. They are also 100 lines long (if counting a few whitespace-only lines) and yet never mention installing via something like `apt-get opencv`. Is there a reason there isn't a package manager installation? I found instructions to install with `brew` on macOS, could that just be added there?" | category: documentation | low | Minor |
409,875,533 | go | proposal: cmd/go/internal/lockedfile: add Append function | This is a proposal of adding `Append` function to [cmd/go/internal/lockedfile](https://tip.golang.org/pkg/cmd/go/internal/lockedfile/).
`Append` will act as [Write](https://tip.golang.org/pkg/cmd/go/internal/lockedfile/#Write), except that it will not truncate a file if it already exists. | Proposal,Proposal-Hold | low | Minor |
409,901,596 | material-ui | App Layout component | ## Expected Behavior 🤔
It should provide a configurable layout out of the box without so much additional coding required.
This is a really basic feature and e.g. Ant Design does it great and so simple.
## Current Behavior 😯
Any layout has to be done with a lot of coding to handle RWD, different drawer variants etc.
## Examples 🌈
<img width="783" alt="Screenshot 2022-12-31 at 00 35 59" src="https://user-images.githubusercontent.com/3165635/210118120-e0f78a22-6ba9-4055-9cbd-3fe342ec5880.png">
Origen Studio Layout component which is using Material UI!: https://github.com/OrigenStudio/material-ui-layout.
Quasar Framework Layout (VueJS). Such a great implementation for VueJS. Easy, flexible, and reliable.
https://v1.quasar-framework.org/layout/layout
and also to show how simple it can/should be Ant Design Layout: https://ant.design/components/layout/
## Context 🔦
It is time-consuming to set up the layout with Material UI and everyone has to do it on his/her own instead of the job being done once in the MUI repo and being reused across all projects.
## Benchmark
- https://www.tremor.so/blocks/page-shells
- https://quasar.dev/layout/layout
- https://vuetifyjs.com/en/getting-started/wireframes/
- https://ant.design/components/layout/
- https://tailwindui.com/components/application-ui/application-shells/stacked
- https://ui.shadcn.com/blocks
- Jun Layout https://github.com/siriwatknp/mui-treasury/tree/8238811dad4eb6d0ff5275c76b6957d9bae43c6d/packages/mui-layout
- https://panjiachen.github.io/vue-element-admin/#/nested/menu1/menu1-1 (nested routes)
Advanced layout components: https://github.com/mui/mui-toolpad/issues/3280 | new feature,waiting for 👍 | medium | Major |
409,959,389 | flutter | UserAccountsDrawerHeader lacks access to Details Pressed state | The `UserAccountsDrawerHeader` provides a void callback (`onDetailsPressed`) to indicate that the details state has changed. However there is no method to determine if the current state is "arrow up" or
"arrow down" and there is no method to change that state.
| c: new feature,framework,f: material design,P2,team-design,triaged-design | low | Minor |
409,961,235 | vscode | Allow dynamic location of textmate grammar | Ref: https://github.com/vuejs/vetur/issues/210
In Vue files you can have `<template>`, `<style>` and `<script>` tag.
However, certain libraries can add top-level custom blocks that uses another language. For example:
```vue
<template></template>
<script></script>
<style></style>
<docs>
# This might be markdown or json, depending on user's build configuration
</docs>
```
Our approach was:
- Give a setting `vetur.grammar.customBlocks`
- Register a command to recompile the TextMate grammar with the custom blocks
- Write the file to extension directory, the same path as the one specified in `package.json`
This has been working, but I'm worried extension integrity check might kick in and ask for reinstall. Also @sandy081 mentioned updates remove the old folder, so it's bad to keep states in extension directory.
What I need is a path that I can:
- Statically determine in write-time (as the path is specified in `package.json`)
- Have write permission
So the paths in `ExtensionContext` wouldn't work for me.
After checking with @sandy081, we think offering an API like `languages.setGrammar` would be best. We considered allowing path interpolations like `${globalStoragePath}/grammars/vue.json` in `package.json`, but that means the best Vetur can do is to write to that path on first activation, so no coloring before first activation/reload.
However, I'm not sure we should provide an API tied to TextMate grammar. Also the API means the dynamically generated TextMate grammar wouldn't be loaded until extension activation.
@alexandrudima What do you think? | feature-request,api | medium | Major |
409,977,841 | flutter | [webview] Allow overriding responses to webview requests with local resources | customer: dream are managing their own resource cache.
They need to be able to have the webview respond to specific requests with resources that are available locally and are provided by the application.
On Android this can be done with [WebViewClient#shouldInterceptRequest](https://developer.android.com/reference/android/webkit/WebViewClient#shouldInterceptRequest(android.webkit.WebView,%20android.webkit.WebResourceRequest)), one challenge there is that shouldInterceptRequest needs to synchronously return a WebResourceResponse, so the decision of whether to intercept the request, and what is the mime type encoding(and potentially some other metadata) has to be synchronous. The documentation does mention that the "method is called on a thread other than the UI thread", need to check if it's ok to block that thread briefly.
On iOS as far as I can tell there isn't a mechanism for doing this per-webview, though it is possible to override URL loading for the entire app by registering a custom [NSURLProtocol](https://developer.apple.com/documentation/foundation/nsurlprotocol) implementation.
It looks like we might end up with different APIs for Android and iOS, where the iOS API isn't part of the webview (I'm not even sure if it belongs in the webview plugin) | c: new feature,customer: dream (g3),p: webview,package,team-ecosystem,P3,triaged-ecosystem | medium | Major |
409,991,223 | electron | TouchBarScrubber does not expose layout options | In https://github.com/electron/electron/pull/11038 dynamic width calculation was added to the scrubber touch bar item layout, however there is no way to specify the itemSpacing and itemSize (https://developer.apple.com/documentation/appkit/nsscrubberflowlayout?language=objc) for entries in the scrubber list, which are necessary to emulate the appearance of the TouchBarSegmentedControl class.
Desired: (TouchBarSegmentedControl)
Current appearance: (Scrubber)
Request: Likely the simplest solution would be to add optional `itemSpacing` and `itemSize` properties to the TouchBarScrubber constructor options and use those in `sizeForItemAtIndex` if given (https://github.com/dashersw/electron/blob/master/atom/browser/ui/cocoa/atom_touch_bar.mm#L670). | enhancement :sparkles: | low | Minor |
409,995,059 | create-react-app | Dependencies that use require.ensure for backward compatibility cause warnings | Importing dependencies into an app created with `create-react-app` that [use `require.ensure` as a fallback option](https://github.com/mozilla/pdf.js/blob/960213cb6963f9bf46d6224805de2dc73fef0af4/src/display/api.js#L42-L98) causes the following warning in the console;
```
./node_modules/pdfjs-dist/build/pdf.js
Critical dependency: require function is used in a way in which dependencies cannot be statically extracted
```
This seems to be because the webpack settings in `create-react-app` do not allow dependencies to use `require.ensure`, but [it seems that some libraries need to include this as a conditional fallback](https://github.com/mozilla/pdf.js/issues/10253).
One possible solution might be to remove [`{ parser: { requireEnsure: false } }`](https://github.com/facebook/create-react-app/blame/49e258b4a6d04fb7e3542d7a060c6dcad4093564/packages/react-scripts/config/webpack.config.js#L302) from the webpack configuration. I don't see much context or discussion about why that rule is important other than that it's not a standard language feature.
I can see the argument from both sides, both why `create-react-app` would want to warn about this, and why another package might want to include it as a fallback. I don't know the correct solution, but this causes noisy warnings in the console when starting an app that make it more difficult to focus on actionable warnings.
Maybe the correct solution is to [allow the suppression of unwanted warnings in `create-react-app`](https://github.com/facebook/create-react-app/issues/1947), but that seems to be a settled issue.
I'm open to any other workarounds or solutions. | issue: needs investigation | medium | Major |
410,000,050 | opencv | Frame offset points outside movi section error | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => :grey_question: 3.3.1
- Operating System / Platform => :grey_question: Windows 10 64 Bit
- Compiler => :grey_question: Visual Studio 2015
##### Detailed description
<!-- your description -->
I recorded a video with 'MJPG' codec. When read it, the system promoted 4 times of "offset points outside movi section" like this:
> Frame offset points outside movi section.
> Frame offset points outside movi section.
> Frame offset points outside movi section.
> Frame offset points outside movi section.
Total frame number is also not correct
##### Steps to reproduce
```
import cv2
cap1 = cv2.VideoCapture(pth_vid1) # pth_vid1, video file name whose length is about 1 hour coded with 'MJPG'.
print('IR has frame numbers', cap1.get(cv2.CAP_PROP_FRAME_COUNT))
```
result:
> IR has frame numbers 6312.0
This file absolutely has more frames than this.
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
-->
| category: videoio,incomplete | low | Critical |
410,013,309 | create-react-app | Default linter and/or linting configuration cannot parse various TypeScript features (e.g. modifiers like readonly) | <!--
PLEASE READ THE FIRST SECTION :-)
-->
### Is this a bug report?
Yes
<!--
If you answered "Yes":
Please note that your issue will be fixed much faster if you spend about
half an hour preparing it, including the exact reproduction steps and a demo.
If you're in a hurry or don't feel confident, it's fine to report bugs with
less details, but this makes it less likely they'll get fixed soon.
In either case, please fill as many fields below as you can.
If you answered "No":
If this is a question or a discussion, you may delete this template and write in a free form.
Note that we don't provide help for webpack questions after ejecting.
You can find webpack docs at https://webpack.js.org/.
-->
### Did you try recovering your dependencies?
<!--
Your module tree might be corrupted, and that might be causing the issues.
Let's try to recover it. First, delete these files and folders in your project:
* node_modules
* package-lock.json
* yarn.lock
Then you need to decide which package manager you prefer to use.
We support both npm (https://npmjs.com) and yarn (http://yarnpkg.com/).
However, **they can't be used together in one project** so you need to pick one.
If you decided to use npm, run this in your project directory:
npm install -g npm@latest
npm install
This should fix your project.
If you decided to use yarn, update it first (https://yarnpkg.com/en/docs/install).
Then run in your project directory:
yarn
This should fix your project.
Importantly, **if you decided to use yarn, you should never run `npm install` in the project**.
For example, yarn users should run `yarn add <library>` instead of `npm install <library>`.
Otherwise your project will break again.
Have you done all these steps and still see the issue?
Please paste the output of `npm --version` and/or `yarn --version` to confirm.
-->
The issue occurs on a freshly created application.
### Which terms did you search for in User Guide?
<!--
There are a few common documented problems, such as watcher not detecting changes, or build failing.
They are described in the Troubleshooting section of the User Guide:
https://facebook.github.io/create-react-app/docs/troubleshooting
Please scan these few sections for common problems.
Additionally, you can search the User Guide itself for something you're having issues with:
https://facebook.github.io/create-react-app/
If you didn't find the solution, please share which words you searched for.
This helps us improve documentation for future readers who might encounter the same problem.
-->
Linting, Readonly, TypeScript
### Environment
<!--
To help identify if a problem is specific to a platform, browser, or module version, information about your environment is required.
This enables the maintainers quickly reproduce the issue and give feedback.
Run the following command in your React app's folder in terminal.
Note: The result is copied to your clipboard directly.
`npx create-react-app --info`
Paste the output of the command in the section below.
-->
```
Environment Info:
System:
OS: macOS Sierra 10.12.6
CPU: x64 Intel(R) Core(TM) i7-3740QM CPU @ 2.70GHz
Binaries:
Node: 10.15.1 - ~/.nodenv/versions/10.15.1/bin/node
npm: 6.7.0 - ~/.nodenv/versions/10.15.1/bin/npm
Browsers:
Chrome: 72.0.3626.96
Firefox: 64.0.2
Safari: 12.0.3
npmPackages:
react: ^16.8.1 => 16.8.1
react-dom: ^16.8.1 => 16.8.1
react-scripts: 2.1.5 => 2.1.5
npmGlobalPackages:
create-react-app: 2.1.5
```
### Steps to Reproduce
<!--
How would you describe your issue to someone who doesn’t know you or your project?
Try to write a sequence of steps that anybody can repeat to see the issue.
-->
1. Generate an app with the typescript option:
```
create-react-app my-app --typescript
```
2. Add TypeScript code with the `readonly` modifier, for example in `src/App.tsx`:
```
interface Test {
readonly foo: string
}
```
3. Observe that eslint cannot parse the code, as indicated by the editor if integrated with eslint, or by running the following command:
```
$> ./node_modules/eslint/bin/eslint.js src/App.tsx
/path/to/my-app/src/App.tsx
6:12 error Parsing error: Unexpected token, expected ":"
4 |
5 | interface Test {
> 6 | readonly foo: string;
| ^
7 | }
8 |
9 | class App extends Component {
✖ 1 problem (1 error, 0 warnings)
```
### Expected Behavior
<!--
How did you expect the tool to behave?
It’s fine if you’re not sure your understanding is correct.
Just write down what you thought would happen.
-->
The linter with its default configuration should be able to parse this interface.
### Actual Behavior
<!--
Did something go wrong?
Is something broken, or not behaving as you expected?
Please attach screenshots if possible! They are extremely helpful for diagnosing issues.
-->
The linter fails to parse the interface with the error:
```
error Parsing error: Unexpected token, expected ":"
```
Removing the readonly modified removes the parsing error.
### Reproducible Demo
<!--
If you can, please share a project that reproduces the issue.
This is the single most effective way to get an issue fixed soon.
There are two ways to do it:
* Create a new app and try to reproduce the issue in it.
This is useful if you roughly know where the problem is, or can’t share the real code.
* Or, copy your app and remove things until you’re left with the minimal reproducible demo.
This is useful for finding the root cause. You may then optionally create a new project.
This is a good guide to creating bug demos: https://stackoverflow.com/help/mcve
Once you’re done, push the project to GitHub and paste the link to it below:
-->
[This repository](https://github.com/AlphaHydrae/create-react-app-typescript-readonly-bug) demonstrates the issue with [a simple commit](https://github.com/AlphaHydrae/create-react-app-typescript-readonly-bug/commit/441c68de0bab44ad79c75c08b568482a0c7718fb).
Run the following command to reproduce:
```
git clone https://github.com/AlphaHydrae/create-react-app-typescript-readonly-bug.git && \
cd create-react-app-typescript-readonly-bug && \
npm ci && \
./node_modules/eslint/bin/eslint.js src/App.tsx
```
<!--
What happens if you skip this step?
We will try to help you, but in many cases it is impossible because crucial
information is missing. In that case we'll tag an issue as having a low priority,
and eventually close it if there is no clear direction.
We still appreciate the report though, as eventually somebody else might
create a reproducible example for it.
Thanks for helping us help you!
-->
| issue: needs investigation,issue: typescript | low | Critical |
410,037,260 | react-native | <View /> doesn't recalculate it's size when a descendant <Text /> changes height due to wrapping following a device rotation | ## 🐛 Bug Report
<!--
A clear and concise description of what the bug is.
Include screenshots if needed.
-->
I believe I've found a bug in the `View` size calculation logic in React Native. In certain cases, the ancestor `View` fails to recalculate its size if a descendant `<Text />` component changes in size due to a rotation and subsequent text (re)wrapping.
The following shows three states: initial, rotated, and back to original orientation. Notice that the fuschia view "grows" after returning to the original orientation.
### Initial orientation
<img width="300" alt="image" src="https://user-images.githubusercontent.com/77138/52748619-d7e42400-2f9b-11e9-8033-c79f865db18a.png">
### Portrait
<img height="300" alt="image" src="https://user-images.githubusercontent.com/77138/52748684-0104b480-2f9c-11e9-8cdc-a4bbb5d3a7f1.png">
### Back to initial orientation
<img width="300" alt="image" src="https://user-images.githubusercontent.com/77138/52748729-21347380-2f9c-11e9-95d1-4724222eddd3.png">
## Speculative Analysis and Workaround
This appears to be an issue where an ancestor view caches a layout calculation and doesn't trigger a re-calculation when a nested Text component changes in size due to orientation changes.
After some playing around, we've figured out that if you "poke" any of the style properties that affect the view's style layout, the view will recalculate and be correct. We did this by toggling a state var upon rotation and then adding/removing a style object to the view's `styles` array that contained an extra `paddingBottom` that mirrored the existing `padding` on the view (basically we changed the style but the effect had no changes to the layout).
You can see a demo of the workaround by uncommenting the line of code below the `FIXME` comment in the code sample.
## To Reproduce
See the code, but basically if you have a `<ScrollView>` that contains a container `<View>` which contains another `<View>` and then have a `<Text>` element inside that view... this layout bug will happen. I haven't been able to reduce this example further than that.
## Expected Behavior
After rotating and going back to the initial orientation, the View should be exactly the same size.
## Code Example
Github repo: https://github.com/jeremywiebe/react-native-text-orientation-bug
## Environment
```
React Native Environment Info:
System:
OS: macOS 10.14.2
CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
Memory: 34.97 MB / 16.00 GB
Shell: 3.0.0 - /usr/local/bin/fish
Binaries:
Node: 8.15.0 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.1, macOS 10.14, tvOS 12.1, watchOS 5.1
Android SDK:
API Levels: 23, 25, 27
Build Tools: 23.0.1, 25.0.0, 25.0.2, 25.0.3, 27.0.3, 28.0.1, 28.0.2, 28.0.3
System Images: android-16 | Intel x86 Atom, android-16 | Google APIs Intel x86 Atom, android-19 | Intel x86 Atom, android-19 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-24 | Google APIs Intel x86 Atom, android-24 | Google Play Intel x86 Atom, android-25 | Google APIs Intel x86 Atom, android-28 | Google Play Intel x86 Atom
IDEs:
Android Studio: 3.1 AI-173.4907809
Xcode: 10.1/10B61 - /usr/bin/xcodebuild
npmPackages:
react: 16.6.3 => 16.6.3
react-native: 0.58.4 => 0.58.4
``` | Issue: Author Provided Repro,Component: View,Bug | medium | Critical |
410,084,023 | godot | Project Settings window's Input map does not update when the InputMap is changed in code. | **Godot version:**
3.1 Beta 3
**Issue description:**
<!-- What happened, and what was expected. -->
When creating a plugin, I would like that plugin to check the currently existing keybinds in the Input Map and add a new one if there is no binding with a specific name. I am able to add the binding to the ProjectSettings singleton via ProjectSettings.set_setting, but the action does not appear in the "Input Map" tab unless you restart the entire engine.
I've already tried using InputMap.load_from_globals() but that appears to be for use during runtime and has no effect on the editor gui as far as I can tell.
I've noticed that when setting any other type of project setting, the setting appears normally under the "General" tab without any need for reloading.
**Steps to reproduce:**
* Make a script that runs in the editor.
* In that script, call ProjectSettings.set_setting("input/your_keybind_name_here", {"deadzone": 0.5, "events": []})
* Then call ProjectSettings.save()
* Check the Input Map tab in the Project Settings window and notice your keybind is not there.
* Open the project.godot file and notice your keybind is there alongside your others.
* Restart your engine and the keybind should now be in the list of actions in the Input Map.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
[Project Settings Example.zip](https://github.com/godotengine/godot/files/2862920/Project.Settings.Example.zip)
Inside the example project, there is a single plugin. On activation of the plugin, a new input map is created but will not be visible until the project is closed and reopened. On deactivation of the plugin, the input map is destroyed and that change is not visible until the project is reopened as well. | bug,topic:editor,confirmed,topic:plugin,topic:input | low | Critical |
410,085,658 | go | encoding/csv: Read returns strings which has reference of string of whole line | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.11.5 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/user/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/user/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/Cellar/go/1.11.5/libexec"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.11.5/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/lx/fcsz9swj2ysdrvthsnxnxjzr0000gn/T/go-build061484716=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
"encoding/csv" `Reader.Read()` returns `record []string`, which has reference to the string of ***whole*** line.
I wrote my code hold only one field in `record`, and found the usage of memory is huger than expects me.
To confirm it, I wrote some sample code:
https://play.golang.org/p/OpsuPDjMRfJ
This line says that each field of record has reference of line string.
https://github.com/golang/go/blob/go1.11.5/src/encoding/csv/reader.go#L386
### What did you expect to see?
Has only reference of the field of record which I use it.
In sample code of playground, first field ( = "0" ) is held, but second field "0 ... 0" is not held.
### What did you see instead?
It held over 100002*10000 bytes in memory. | Performance,NeedsInvestigation | low | Critical |
410,161,623 | flutter | LastPass doesn't support text fields in Flutter apps | Might be just another symptom of https://github.com/flutter/flutter/issues/14047 | a: text input,framework,engine,P2,team-engine,triaged-engine | low | Major |
410,286,485 | angular | Define generic of ng-template | <!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🚀 feature request
### Relevant Package
<!-- Can you pin-point one or more @angular/* packages the are relevant for this feature request? -->
<!-- ✍️edit: --> This feature request is for @angular/language-service
### Description
I quite often use ng-templates in my application to later include them in the *ngTemplateOutlet and pass them the context. However when I define the template itself, it doesn't know the interface the context will have, so say this:
```
<ng-template #willUseLater
let-item
let-index="index">
{{index}} — {{item}}
</ng-template>
```
Gives me an error `ng: The template context does not defined a member called 'index'.` (note also a typo here)
Under ng-template there's `TemplateRef<T>`, but there is no way to define that T.
### Describe the solution you'd like
Provide a way to define the generic in place without extra overhead
### Describe alternatives you've considered
At least disable this error as it has no purpose if you have any complex template usage
| feature,area: core,area: compiler,core: ng-template and *microsyntax,compiler: template type-checking,feature: under consideration | high | Critical |
410,296,185 | pytorch | Distributed training jobs do not terminate properly if there is a crash | ## 🐛 Bug
If I use distributed training, sometimes one of the processes dies for a variety of reasons (maybe out of memory, a cuda runtime error, etc). In a single GPU job, the experiment would crash. In the distributed setting, the remaining processes often freeze and wait endlessly, so the job remains alive continues to consume GPU resources, even though it is actually dead.
## Expected behavior
If one process in a distributed job crashes, all of the nodes in the distributed job should crash.
## Environment
PyTorch 1.0
| oncall: distributed,triaged | medium | Critical |
410,373,063 | TypeScript | Refactor: Introduce object destruction | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
refactor, object destruction
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
A refactor that extract all property access expression to a object destruction or convert back
<!-- A summary of what you'd like to see added or changed -->
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
```ts
const item = {
a: 1, b: 2
}
call(item.a, item.b)
```
to
```ts
const item = {
a: 1, b: 2
}
const { a, b } = item
call(a, b)
```
<!-- Show how this would be used and what the behavior would be -->
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
410,391,040 | godot | Saving base script does not update exported properties in the inspector | **Godot version:**
3.1 beta 4
Tested on: `3.1 beta 4` and `3.0 stable`. I cannot reproduce the issue in `3.0 stable`.
**OS/device including version:**
Windows 10 64-bits
**Issue description:**
As commented in: https://github.com/godotengine/godot/pull/25866#issuecomment-463451182
Saving the base script does not seem to update exported properties in the inspector.
**Steps to reproduce:**
Example project: [TestGDScript.zip](https://github.com/godotengine/godot/files/2865929/TestGDScript.zip)
You can see the exported properties in the root node.
Follow these steps:
- In `res://Node.gd` (the base script) uncomment the line `#a`. This will make it fail to parse.
- Restart the editor (maybe re-opening the scene is enough, I don't know).
At this point the properties should not be visible in the inspector. This is expected.
- Fix the build/parse error in the base script (comment the line again).
The properties are still not showing in the inspector. In order for them to be shown again, the derived script (`res://new_script.gd`) needs to be saved again. Nothing is lost though, so at least it's not critical.
Not sure if this is caused by the properties fallback or not. It doesn't happen in 3.0.0.
| bug,topic:gdscript,topic:editor,confirmed | low | Critical |
410,394,109 | TypeScript | Allow mapped tuples to have behaviour based on index | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
mapped tuples index
## Suggestion
I want to be able to create a tuple from function parameters and have all elements in the tuple optional other than the firstK
## Use Cases
I am trying to create a curry implementation that allows you to curry any number of parameters. The first parameter must be specified but all other params are optional.
Would be good to be able to remove the last param as well.
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
something along the lines of
```
type OptionalExceptFirst<T> = {
[K in keyof T]:isFirst ? ? T[K] : T[K];
};
type AllExceptLast<T> = {
[K in keyof T]:isLast ? never : T[K];
};
```
The syntax will need some work hopefully the intended functionality is clear.
## Checklist
My suggestion meets these guidelines:
* [x ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [ x] This wouldn't change the runtime behavior of existing JavaScript code
* [ x] This could be implemented without emitting different JS based on the types of the expressions
* [ x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [ x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
410,421,675 | kubernetes | PodStartupLatency logs are misleading | Something is terribly broken in ClusterLoader tests, for at least last week.
I'm seeing logs like this:
I0131 18:08:17.805407 12168 pod_startup_latency.go:305] PodStartupLatency: perc50: 6.479659787s, perc90: 1m14.604992502s, perc99: 1m38.973342003s
And the test is passing.
For example this run:
https://gubernator.k8s.io/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce-scalability/22431
@krzysied @mm4tt @mborsz @kubernetes/sig-scalability-bugs | kind/bug,sig/scalability,priority/important-longterm,lifecycle/frozen | low | Critical |
410,435,806 | angular | ngOnDestroy not called for injectables created via factory providers provided at component level | # 🐞 bug report
### Affected Package
@angular/core
### Is this a regression?
Don't know
### Description
**ngOnDestroy** is not called for Services provided via **factory function** into component level.
## 🔬 Minimal Reproduction
I forked the Angular repo and created a Merge Request including 2 tests that both should pass. Of course, one test don't pass, that is the ones that we provide the service using the factory function.
**EDIT**: I also have added the code to make the tests pass, although I am not in context at all, an maybe I am missing something in the path
Here is the MR: https://github.com/angular/angular/pull/28737
## 🌍 Your Environment
**Angular Version:** 8.0.0-beta.3
| hotlist: error messages,freq3: high,area: core,core: di,design complexity: major,P4 | medium | Critical |
410,436,228 | go | cmd/link: TestDWARF failing under all.bash on OSX 10.13.6 | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.11.5 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/tham/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/tham/go"
GOPROXY=""
GORACE=""
GOROOT="/Users/tham/opt/go"
GOTMPDIR=""
GOTOOLDIR="/Users/tham/opt/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/jw/jl09r8zn7yxcg04glntytrl07k6c17/T/go-build179495697=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Try to build go from source.
1. Clone from github mirror
2. checkout 52d020260
3. run all.bash from src directory
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
### What did you expect to see?
successful build
### What did you see instead?
--- FAIL: TestDWARF (3.88s)
--- FAIL: TestDWARF/testprogcgo (1.95s)
dwarf_test.go:98: decoding dwarf section info at offset 0x0: too short
FAIL
FAIL cmd/link 5.179s
--- FAIL: TestRuntimeTypeAttrExternal (1.02s)
dwarf_test.go:945: error reading DWARF: decoding dwarf section info at offset 0x0: too short
FAIL
FAIL cmd/link/internal/ld 2.336s
| OS-Darwin,NeedsInvestigation,compiler/runtime | low | Critical |
410,451,245 | flutter | video_player Image Thumbnail | The video_player plugin does not document how you can use it with image thumbnails to implement an image thumbnail from a video frame within the video to display as an image cover like YouTube and Instagram does for videos | c: new feature,a: video,p: video_player,package,c: proposal,team-ecosystem,P2,triaged-ecosystem | low | Critical |
410,457,389 | TypeScript | Upgrading from 3.0.3 to 3.1.1 breaks underscore type definition | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.1.1 up to the latest 3.3.3
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
underscore TS2339 property does not exist
**Code**
```ts
// have @types/underscore installed
_.each([1,2,3,4], x => console.log(x));
```
**Expected behavior:**
Compile successfully
**Actual behavior:**
In TS 3.0.3, compile successfully
In TS 3.1.1, compile failed with error
error TS2339: Property 'each' does not exist on type 'typeof _'. | Bug | low | Critical |
410,472,497 | javascript | Documentation conflicts with object-property-newline setting? | It seems like the documentation consistently promotes having a new line for each item in multiline lists, whether it be in a [function invocation](https://github.com/airbnb/javascript#functions--signature-invocation-indentation) or in [an array](https://github.com/airbnb/javascript#arrays--bracket-newline) (both of which mention bad examples of not having each item on a new line).
And even the [object examples](https://github.com/airbnb/javascript#objects--quoted-props) (although not referring to this specific rule) seem to favor this approach.
With that said, what is the reasoning behind [allowing object properties to all appear on the same line](https://github.com/airbnb/javascript/blob/17e0454672f784772c5f5ab052523a93229d9adf/packages/eslint-config-airbnb-base/rules/style.js#L406)?
It would seem more consistent to remove that option for `object-property-newline`. But at the very least, the reasoning and/or use case should probably be documented. | pull request wanted | low | Major |
410,481,705 | pytorch | Support callables in scripted functions | ## 🚀 Feature
Allow for callables (notably other scripted functions or ScriptModules) to be passed to scripted functions (Currently fails with `cannot call a value`).
## Motivation
Attempting to tease out fusions from larger codebases (in my case maskrcnn_benchmark) where some blocks of code may not be scriptable, but subsets of those blocks may be. In a concrete example, I have a module which contains loop over sets of inputs & modules, where `z = module(x) + y` is seen. `module` is itself a ScriptModule, and I'd like to be able to add the `+` to a fused group that's already being generated within that ScriptModule. However, there are several things that prevent the outermost module from being scripted. Pulling out the relevant code to a separate function like:
```
@torch.jit.script
def impl(m, x. y):
return m(x) + y
```
Should allow the desired fusion, but is currently not supported.
## Pitch
Allow callables (at least ScriptModules) to be passed as arguments to scripted functions and called.
## Alternatives
My specific use-case disappears as the scripting supports a certain level of python, but I would expect there to be other use-cases.
## Additional context
This is a proxy code I wrote to make sure that the error I was seeing wasn't from the larger application. This fails with `cannot call a value`.
```
import torch
class Bias(torch.jit.ScriptModule):
def __init__(self, num_channels):
super(Bias, self).__init__()
self.bias = torch.nn.Parameter(torch.zeros(num_channels))
@torch.jit.script_method
def forward(self, x):
return x + self.bias.reshape(1, -1, 1, 1)
@torch.jit.script
def fwd_impl(b, x, y):
return b(x) + y
# Note: Not-scriptable in real app
class OuterModule(torch.nn.Module):
def __init__(self, n):
super(OuterModule, self).__init__()
self.bias = Bias(n)
def forward(self, x, y):
return fwd_impl(self.bias, x, y)
n, c, h, w = 32, 4, 16, 16
x = torch.randn(n, c, h, w).cuda()
y = torch.randn(n, c, h, w).cuda()
m = OuterModule(c).cuda()
with torch.no_grad():
z = m(x, y)
```
cc @suo | oncall: jit,jit-backlog | low | Critical |
410,508,856 | go | x/sys/cpu: report core information and speed | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.11.4 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
N/A. all of them?
### What did you do?
Tried to use existing packages to get information about CPU core count, clock speed, and so on. Among them, `gopsutil`, `intel-go/cpuid`, and `klauspost/cpuid`. They all do some of what would be desireable.
### What did you expect to see?
A way to get CPU model name (if available), core counts, and ideally some kind of clock speed information.
### What did you see instead?
A tangled mishmash of possibilities. I can't find *anything at all* on Linux that can give the CPU's officially-rated clock speed that isn't "get the brand string and parse it manually". On darwin/freebsd, gopsutil gets reasonable numbers by parsing sysctl output. On Linux, it uses something from /sys, but it gets the "max" CPU speed -- thus, for a 3.00GHz Xeon with a "max" speed of 4.00GHz, it reports 4000MHz. cpuid can accurately report on cores/threads (aka logical cores) for a single chip, but can't tell you how many chips the machine has. gopsutil can report the number of physical cores on a Mac (you would see a single CPU entry with 2 cores for a typical 2-core i5), but can't tell you about threads or logical cores. on Linux, the same machine would show 4 1-core CPUs, but if you used a map to check for unique core ID strings, you could infer that there were two distinct cores available.
This is the sort of thing where the go runtime probably already has decent insight into core count, for instance, and I think the proliferation of not-quite-working methods for getting this information is a problem. I briefly considered writing my own, but I think that would be a very bad idea. I guess I'm sort of half volunteering to implement a simple starting point for this for at least some targets, but I don't have access to a broad enough pool of targets to implement it competently for everything.
For benchmarking-type purposes, I think both logical and physical core counts (or threads/cores, depending on terminology) would be extremely valuable to developers. Clock speed(s) less so, but they can still be a handy reference point for looking at what hardware a given test was run against. | NeedsDecision,FeatureRequest | low | Minor |
410,515,762 | go | cmd/go: standard-library vendoring in module mode | This proposal is both a fix for #26924, and a means for users to explicitly upgrade the `golang.org/x` dependencies of the standard library (such as `x/crypto` and `x/net`).
### Proposal
The standard library will ship with three go.mod files: `src/go.mod` (with module path `std`), `src/cmd/go.mod` (with module path `cmd`), and `misc/go.mod` (with module path `misc`).
The `std` and `cmd` modules will have `vendor` directories, containing `modules.txt` files in the usual format and managed using the standard Go 1.13 vendoring semantics (hopefully #30240).
The `std` and `cmd` modules differ somewhat from ordinary modules, in that they do not appear in the build list.
* No module outside `GOROOT/src` may declare its own module path to begin with `std` or `cmd`.
* No module may explicitly `require`, `replace`, or `exclude` any module whose path begins with `std` or `cmd`. (Their versions are fixed to the Go release in use.)
For files within `GOROOT/src` only, when we resolve an import of a package provided by an external module, we will first check the build list for that module.
* If the build list does not contain that module, or if the version in the build list is strictly older than the one required by the standard-library module containing the file, then we will resolve the import to a directory in the standard library, and the effective import path will include the explicit prefix `vendor` or `cmd/vendor`.
* The explicit prefix ensures that no two packages in the build will have the same import path but different source code.
* It also ensures that any code loaded from a valid module path has a corresponding module in the build list.
* If the version in the build list is equal to than the one required by `std` or `cmd`, that version is not `replace`d in the main module, and the package exists in the corresponding `vendor` directory, then we will load the package from `vendor` or `cmd/vendor` with its original import path.
* This eliminates network lookups if the main module is `std` or `cmd` itself (that is, if the user is working within `GOROOT/src`).
* We assume that the code in `GOROOT/src/vendor` and `GOROOT/src/cmd/vendor` will remain pristine and unmodified.
* If the version in the build list is greater than the version required by `std` or `cmd`, or if the version is equal and the module is `replace`d, then we will load the package from the module cache in the usual way.
* This may cause substantial portions of the library to be rebuilt, but will also reduce code duplication — which should result in smaller binaries. | Proposal,Proposal-Accepted,early-in-cycle,modules | high | Critical |
410,548,493 | kubernetes | HPA controller reorders the spec.metrics list | <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!-->
**What happened**:
I have an HPA spec as follows.
```yaml
apiVersion: autoscaling/v2beta1
kind: HorizontalPodAutoscaler
metadata:
name: argocd-server
spec:
minReplicas: 1
maxReplicas: 2
metrics:
- resource:
name: cpu
targetAverageUtilization: 76
type: Resource
- resource:
name: memory
targetAverageValue: 3096Mi
type: Resource
scaleTargetRef:
apiVersion: extensions/v1beta1
kind: Deployment
name: argocd-server
```
After applying it results in the following object. Notice that the `spec.metrics` list is re-ordered:
```yaml
apiVersion: autoscaling/v2beta1
kind: HorizontalPodAutoscaler
metadata:
annotations:
kubectl.kubernetes.io/last-applied-configuration: |
{"apiVersion":"autoscaling/v2beta1","kind":"HorizontalPodAutoscaler","metadata":{"annotations":{},"name":"argocd-server","namespace":"argocd"},"spec":{"maxReplicas":2,"metrics":[{"resource":{"name":"cpu","targetAverageUtilization":75},"type":"Resource"},{"resource":{"name":"memory","targetAverageValue":"3096Mi"},"type":"Resource"}],"minReplicas":1,"scaleTargetRef":{"apiVersion":"extensions/v1beta1","kind":"Deployment","name":"argocd-server"}}}
creationTimestamp: "2019-02-13T06:32:00Z"
name: argocd-server
namespace: argocd
resourceVersion: "1244555"
selfLink: /apis/autoscaling/v2beta1/namespaces/argocd/horizontalpodautoscalers/argocd-server
uid: 11d7a94b-2f59-11e9-99d6-a6a55e696d25
spec:
maxReplicas: 2
metrics:
- resource:
name: memory
targetAverageValue: 3096Mi
type: Resource
- resource:
name: cpu
targetAverageUtilization: 75
type: Resource
minReplicas: 1
scaleTargetRef:
apiVersion: extensions/v1beta1
kind: Deployment
name: argocd-server
status:
conditions:
- lastTransitionTime: "2019-02-13T06:32:08Z"
message: the HPA controller was able to get the target's current scale
reason: SucceededGetScale
status: "True"
type: AbleToScale
- lastTransitionTime: "2019-02-13T06:32:08Z"
message: 'the HPA was unable to compute the replica count: unable to get metrics
for resource memory: unable to fetch metrics from resource metrics API: the
server could not find the requested resource (get pods.metrics.k8s.io)'
reason: FailedGetResourceMetric
status: "False"
type: ScalingActive
currentMetrics: null
currentReplicas: 1
desiredReplicas: 0
```
**What you expected to happen**:
The fact that the list get's re-ordered is problematic for things like GitOps and diffing tools, because in most other cases, the order of lists are significant. In our case, we are correctly identifying that the live object spec is different than the desired object.
My expectation is for HPA to preserve the order of the list.
**How to reproduce it (as minimally and precisely as possible)**:
```
kubectl apply -f hpa.yaml # example in description
kubectl get hpa.v2beta1.autoscaling argocd-server -o yaml
```
**Anything else we need to know?**:
It's unclear to me if HPA controller will order the list in a deterministic way. I hope that it is, because it will at least allow us to provide some guidance to our users about how to store their HPA manifests in git.
**Environment**:
- Kubernetes version (use `kubectl version`):
```
$ kubectl version
Client Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.2", GitCommit:"cff46ab41ff0bb44d8584413b598ad8360ec1def", GitTreeState:"clean", BuildDate:"2019-01-13T23:15:13Z", GoVersion:"go1.11.4", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.1", GitCommit:"eec55b9ba98609a46fee712359c7b5b365bdd920", GitTreeState:"clean", BuildDate:"2018-12-13T10:31:33Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"}
```
- Cloud provider or hardware configuration: minikube on darwin
- OS (e.g. from /etc/os-release):
- Kernel (e.g. `uname -a`):
- Install tools:
- Others:
| kind/bug,sig/autoscaling,needs-triage | high | Critical |
410,563,769 | godot | TextureAtlas doesn't work in shader when passed as sampler2D | Godot version: 3.0.6
Window 7 Home 64 bit
passed a texture atlas to a shader for palette swapping it seems like the shader ignores the texture atlas crop.
- make a shader material
- copy the shader code below and paste it as your shader code
- copy the palette image to your project
- create two texture atlases 1 with a rect of 0,0,4,1 and 1 with a rect of 0,1,4,1
- pass these texture atlases as parameters to the shader.
- see that the shader does not update the color.
if you use separate images it works.
shader_type canvas_item;
uniform sampler2D palette_old; //the color to test against
uniform sampler2D palette_new; //the target color
uniform float threshold;
//get the texture color
void fragment()
{
vec4 texture_col = texture (TEXTURE, UV);
int palette_size = textureSize(palette_old, 0).x;
for (int i = 0; i < 4; i ++)
{
vec4 palette_col_old = texelFetch(palette_old, ivec2(i, 0), 0);
vec4 palette_col_new = texelFetch(palette_new, ivec2(i, 0), 0);
if (distance(texture_col.rgb, palette_col_old.rgb) < threshold)
{
texture_col.rgb = palette_col_new.rgb; break;
}
}
COLOR = texture_col;
}
 <-- palette
| bug,topic:rendering,confirmed | low | Major |
410,591,145 | pytorch | Conv2d layers should accept 4-tuple for padding argument | ## 🚀 Feature
Currently Conv2d layers supports int or tuple however tuple is only allowed to be 2-tuple. So this only supports symmetrical padding case. This should be 4-tuple to allow for asymmetrical padding. This will be required anytime we are trying to mix and match odd and even sized inputs and kernels.
## Pitch and Motivation
One of the first issue users coming from TensorFlow encounter is lack of feature `padding='SAME'`. This feature has allowed users to quickly prototype without having to dive into convolutional arithmetic for network design. There have been [some reservations](https://github.com/pytorch/pytorch/issues/3867) for adding this feature despite of strong demand from users. I think the least we can probably do is above simple change that hopefully won't cause any other issues.
## Alternatives
Current alternative for users is to spend time in learning and extracting formulas for convolutional arithmetic, computing neccessory padding and use either `F.pad` or padding layers (which are unfortunately not easily discoverable).
Another alternative is to discover various threads like [1](https://discuss.pytorch.org/t/padding-for-convolutions/5881/5), [2](https://discuss.pytorch.org/t/utility-function-for-calculating-the-shape-of-a-conv-output/11173/2), [3](https://github.com/pytorch/pytorch/issues/3867) and piece togather some workaround proposed from various answers.
cc @albanD @mruberry @jbschlosser | module: nn,module: convolution,triaged,enhancement | low | Major |
410,628,997 | go | wiki: CodeReviewComments should more thoroughly describe test helper functions | The document already covers testing helper functions, and how to use them. I propose to add instructions how to write testing helper functions. Two things that I thought of are:
1. The first argument should always be `t *testing.T`.
2. The first line of the function should be `t.Helper()`.
The reason for this issue is that currently context is instructed to be the first argument of a function. A testing helper function that I wrote `testCtx(t *testing.T, ctx context.Context)` result in a lint warning - context should always be the first argument. I opened golang/lint#422 and created a fix golang/lint#423, but it was declined for the reason that lint enforces only what's in EffectiveGo and CodeReviewComments.
The current state is that if I want to have this function I should declare it as `testCtx(ctx context.Context, t *testing.T)` which fills wrong to me. | NeedsDecision | low | Minor |
410,702,291 | vscode | Restart task fails if task already completed | We have writ
Issue Type: <b>Bug</b>
Build tasks are often quite long (especially when building for embedded systems) and it's common for them to throw up intermediate errors before completion.
In this case a typical pattern is ...
- start build task
- spot error report in early build output
- edit offending file
- run build task again
At this stage if the original build task is still running a dialog is presented giving the option to terminate/restart.
If 'restart' is chosen but the task completed while the dialog was being presented, you get another error saying the task couldn't be terminated. (Although this may be technically correct, failing to terminate because the task has already closed doesn't really seem like something worth reporting.)
Really the behaviour I want is for CTRL-B to just terminate any current build tasks and start a new one unconditionally. Perhaps there is a way to customise preferences to get this behaviour? (Goes off to explore options...)
VS Code version: Code 1.31.1 (1b8e8302e405050205e69b59abb3559592bb9e60, 2019-02-12T02:20:54.427Z)
OS version: Windows_NT x64 10.0.16299
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7 CPU 930 @ 2.80GHz (8 x 2806)|
|GPU Status|2d_canvas: enabled<br>checker_imaging: disabled_off<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>rasterization: unavailable_off<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>webgl: enabled<br>webgl2: enabled|
|Memory (System)|5.99GB (1.01GB free)|
|Process Argv|--folder-uri file:///j%3A/esp|
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (17)</summary>
Extension|Author (truncated)|Version
---|---|---
Bookmarks|ale|10.2.2
numbered-bookmarks|ale|6.1.0
comments|Ale|1.0.4
vscode-markdownlint|Dav|0.24.0
vscode-instant-markdown|dba|1.4.3
gitlens|eam|9.5.1
json-tools|eri|1.0.2
gc-excelviewer|Gra|2.1.29
mdhelper|jos|0.0.11
python|ms-|2019.1.0
cpptools|ms-|0.21.0
csharp|ms-|1.17.1
PowerShell|ms-|1.11.0
team|ms-|1.144.1
platformio-ide|pla|1.6.0
powerquerymlanguage|sea|1.0.0
vscodeintellicode|Vis|1.1.3
</details>
<!-- generated by issue reporter -->ten the needed data into your clipboard because it was too large to send. Please paste. | feature-request,tasks | low | Critical |
410,722,816 | flutter | Flutter test coverage will not report untested files | I run the `flutter test --coverage` as follows
and here are my project's files;
the generated `Icov.info` looks like this:
```
SF:lib/components/button.component.dart
DA:12,1
DA:29,1
DA:45,1
DA:47,1
DA:48,1
DA:49,1
DA:50,1
DA:51,2
DA:52,1
DA:53,1
DA:56,2
DA:57,1
DA:59,2
DA:60,1
DA:61,1
DA:62,1
DA:63,3
DA:64,2
DA:65,1
DA:66,1
DA:67,1
DA:70,1
DA:71,2
DA:72,1
LF:24
LH:24
end_of_record
SF:lib/components/button.css.dart
DA:4,1
DA:6,2
DA:7,2
DA:8,1
DA:10,1
DA:16,3
DA:53,1
DA:73,0
LF:8
LH:7
end_of_record
SF:lib/environment.dart
DA:6,1
DA:8,2
DA:9,1
DA:11,1
DA:13,2
DA:14,2
DA:15,2
DA:16,1
LF:8
LH:8
end_of_record
```
why coverage didn't include the untested files?
i know how to show coverage by tools like `genHtml` `locv-sumary`
I just want to know how to generate the Locv.info that includes untested files in my projects | a: tests,c: new feature,tool,dependency: dart,P2,team-tool,triaged-tool | low | Critical |
410,742,066 | go | cmd/vet: "possible malformed +build comment" check too strict | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel +ffd096db2b Wed Feb 13 05:35:45 2019 +0000 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What did you do?
I have a go generate line that prepends a +build comment to a C file:
<pre>
//go:generate sed -i "1s;^;// +build linux,!android\\n\\n;" wayland_xdg_shell.c
</pre>
### What did you expect to see?
No warning from `go vet` or `go test`.
### What did you see instead?
Running `go vet` or `go test` on the package results in:
<pre>
os/os_wayland.go:14:1: possible malformed +build comment
</pre>
I admit this is a special case. | NeedsInvestigation,Analysis | low | Major |
410,761,314 | rust | aarch64 ABI: revisit which ZST fields should be filtered from repr(C) | Spawned off of https://github.com/rust-lang/rust/issues/56877#issuecomment-457490611 and https://github.com/rust-lang/rust/pull/57645#issuecomment-456962622
The issues raised by #56877 were partially addressed by PR #57645 but there may be some followup work to do here.
Based on my current understanding, PR #57645 ended up settling on filtering out *all* ZST's when determining if a type is an instance of a so-called "homogeneous aggregate", and the remaining question is whether we have to deal with architecture/target dependencies when resolving the semantic question of whether the Rust type `[T; 0]` should map to the C type`T[0]` or to `T[]`.
Namely, it sounds like AArch64 may require us to restrict the filtering we do (for determining whether a type is a homogenous aggregate) to just the Rust ZST's like `PhantomData`.
Anyway, this issue is to tracking that leftover work to resolve that question. | A-FFI,T-compiler,A-ABI,A-repr | low | Minor |
410,790,559 | rust | lldb doesn't print enums | ```Rust
enum E1 { A, B }
enum E2 { A1 { x: i32, y: i32 }, B1(u8), C1 }
fn main() {
let a = E1::A;
let aa = E2::A1 { x: 42, y: 123 };
let bb = E2::B1(10);
let cc = E2::C1;
}
```
Run lldb (without pretty-printers, lldb-1000.0.38.2)
```
(lldb) p a
(main::E1) $0 = A
(lldb) p aa
(main::E2) $1 = {}
(lldb) p bb
(main::E2) $2 = {}
(lldb) p cc
(main::E2) $3 = {}
```
It affects both stable (1.32.0) and nightly (1.34.0) Rust toolchains. | A-debuginfo,T-compiler | low | Major |
410,803,788 | rust | support for implementing "extern" functions required by C code when it's declared in a C header/rust-binding | Some C libraries require the user of the lib to implement (platform/sys) functions which are then used by the lib.
The library header usually declares the function so you can implement it wherever you want and get a compiler error if the signature has changed and your implementation is thus wrong now.
If I use bindgen to generate rust bindings for such a library I'm unable to implement such functions using rust, because they already are declared as extern to rust and the compiler treats this as duplicate/mismatching implementations.
If I would just blacklist these functions in bindgen so they'd not be part of the generated bindings there'd be no check if my rust function's signature actually matches the one declared in the C header which is installed on the system.
I think the solution to this would be adding a new function-attribute which lets you explicitly implement an extern function in rust. | A-FFI,C-feature-request | low | Critical |
410,805,283 | youtube-dl | Full support for BFI free content | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2019.02.08*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2019.02.08**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://player.bfi.org.uk/free/film/watch-ian-dury-1983-online
- Single video: https://player.bfi.org.uk/free/film/watch-computer-doctor-1974-online
- Playlist: https://player.bfi.org.uk/free/collection/disabled-britain-on-film
- Homepage of free content: https://player.bfi.org.uk/free
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
| site-update-request | low | Critical |
410,806,577 | go | meta: request output of `go list -m all` in the issue template | As @FiloSottile notes in https://github.com/golang/go/issues/30241#issuecomment-463829083:
> I actually don't want to have to figure out if a `crypto/tls` internal failure is due to a `replace`d `chacha20poly1305`.
But of course the same is true for `x`-repo interdependencies in general: if someone is reporting an issue against, say, `x/tools` or `x/net`, it would be really helpful to know the exact version in which they found the issue, and whether any of the dependencies involved have been locally modified.
I propose that we request `go list -m all` alongside `go env` in the issue template.
(CC @thepudds @myitcv @bradfitz) | NeedsFix,Community | low | Critical |
410,885,779 | create-react-app | Source License notice strip | I have a project, for example:
<details>
<summary>Example</summary>
<br/>
package.json
```json
{
"...": "",
"main": "index.js",
"scripts": {
"...": "",
"build": "react-scripts build"
},
"dependencies": {
"...": "",
"react-scripts": "2.1.5"
}
}
```
index.js
```js
/*!
* project
* Copyright 2019 Igor Vuchastyi
* Licensed under MIT
*/
// Some other code
```
</details>
<br/>
When i run <code>npm run build</code> it executes <code>react-scripts build</code>, then it creates build directory like this build/static/{css,js}/*.{css,js}.<br/>
JS files doesn't contain any license i have specified at the index.js. If i do it with webpack - webpack collect my license and put at the top of bundle.
<br/><br/>
I think <b>react-scripts</b> strips my license from bundle and from other packages.
<br/><br/>
<b>My problem</b>: i don't want use <code>react-scripts eject</code>, i don't want use any other which is forks of react-scripts or etc.<br/>
<b>My question</b>: is there a way to leave my License notice at top of each chunk produced by react-scripts?<br/>
I was searching for around 2 hours. Was googling, was searching in this repository. Found nothing about this thread. | issue: bug | medium | Major |
410,891,139 | flutter | Make FixedExtentScrollPhysics & FixedExtentScrollController usable with ordinary ListViews | `FixedExtentScrollPhysics` and `FixedExtentScrollController` are very handy classes for creating snapping scroll views but unfortunately these can only be used with the `ListWheelScrollView`, which enforces a carousel-like 3D-effect.
`FixedExtentScrollPhysics` and `FixedExtentScrollController` would be more useful, if you could use these with ordinary scrolling views. | c: new feature,framework,P2,team-framework,triaged-framework | low | Critical |
410,905,514 | pytorch | Global Second Order Pooling | Global Second Order Pooling is claimed to be better than Global Average Pooling, which is used in many networks. Producing covariance matrices as image representations, it has achieved state-of-the-art results in a variety of vision tasks. Few examples are as follows:
http://openaccess.thecvf.com/content_cvpr_2018/papers/Li_Towards_Faster_Training_CVPR_2018_paper.pdf
http://openaccess.thecvf.com/content_ICCV_2017/papers/Li_Is_Second-Order_Information_ICCV_2017_paper.pdf
https://vision.cornell.edu/se3/wp-content/uploads/2017/04/cui2017cvpr.pdf
https://arxiv.org/pdf/1804.00428.pdf
https://arxiv.org/abs/1611.02155
More importantly, in this (https://arxiv.org/pdf/1811.12006.pdf) paper, they also claim it to be better than several state-of-the-art spatial and channel attention modules (Squeeze-Excite, Gather-Excite, CBAM, etc). Some implementations are here. I believe that it would be great to have Global Second Order Pooling in the PyTorch framework with a reliable and fast implementation of the functionality required.
https://github.com/jiangtaoxie/fast-MPN-COV/blob/master/src/representation/MPNCOV.py | todo,feature,triaged,module: pooling | low | Major |
410,923,988 | opencv | Issues with installing OpenCV JS on Windows 10 | - OpenCV => 4.0.1 and previous versions
- Operating System / Platform => Windows 10 64 Bit
- Compiler => Visual Studio 2017
I am on the process of installing OpenCV JS and I've encountered simple errors here and there that can be found by searching via Google.
However, I'm currently on an error that is irresolvable at the moment and is something out of my limit. I'm about to build opencv.js with this:
`python build_js.py build_js --emscripten_dir=C:\Users\schma\Documents\DulChunCinn\opencv-js\emsdk`
And this is the error I get:
```
CMake Error at cmake/OpenCVDetectCXXCompiler.cmake:186 (message):
OpenCV 4.x requires C++11
Call Stack (most recent call first):
CMakeLists.txt:156 (include)
-- Configuring incomplete, errors occurred!
See also "C:/Users/schma/Documents/DulChunCinn/opencv-js/opencv/platforms/js/build_js/CMakeFiles/CMakeOutput.log".
See also "C:/Users/schma/Documents/DulChunCinn/opencv-js/opencv/platforms/js/build_js/CMakeFiles/CMakeError.log".
Traceback (most recent call last):
File "build_js.py", line 227, in <module>
builder.config()
File "build_js.py", line 167, in config
execute(cmd)
File "build_js.py", line 23, in execute
raise Fail("Child returned: %s" % retcode)
__main__.Fail: Child returned: 1
```
I tried running with the latest versions of OpenCV (i.e. 4.0.1), of Emscripten SDK and also of CMake. Moreover, I tried it with their previous versions as well.
Any kind of help would be highly appreciated. Thanks in advance.
P.S. For all it's worth, here's the CMakeError.log:
```
Compilation failed:
source file: 'C:/Users/schma/Documents/DulChunCinn/opencv-js/opencv/cmake/checks/cxx11.cpp'
check option: ''
===== BUILD LOG =====
Change Dir: C:/Users/schma/Documents/DulChunCinn/opencv-js/opencv/platforms/js/build_js/CMakeFiles/CMakeTmp
Run Build Command:"C:/Program Files (x86)/Microsoft Visual Studio/2017/BuildTools/MSBuild/15.0/Bin/MSBuild.exe" "cmTC_36d58.vcxproj" "/p:Configuration=Debug" "/p:Platform=Win32" "/p:VisualStudioVersion=15.0"
Microsoft (R) Build Engine version 15.9.21+g9802d43bc3 for .NET Framework
Copyright (C) Microsoft Corporation. All rights reserved.
Build started 15-Feb-19 7:16:47 PM.
Project "C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj" on node 1 (default targets).
PrepareForBuild:
Creating directory "cmTC_36d58.dir\Debug\".
Creating directory "C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\Debug\".
Creating directory "cmTC_36d58.dir\Debug\cmTC_36d58.tlog\".
InitializeBuildStatus:
Creating "cmTC_36d58.dir\Debug\cmTC_36d58.tlog\unsuccessfulbuild" because "AlwaysCreate" was specified.
ClCompile:
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX86\x86\CL.exe /c /W1 /WX- /diagnostics:classic /O2 /Oy- /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /MD /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_36d58.dir\Debug\\" /Fd"cmTC_36d58.dir\Debug\vc141.pdb" /Gd /TP /analyze- /errorReport:queue -g "C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\cmake\checks\cxx11.cpp"
Microsoft (R) C/C++ Optimizing Compiler Version 19.16.27027.1 for x86
Copyright (C) Microsoft Corporation. All rights reserved.
cxx11.cpp
cl /c /W1 /WX- /diagnostics:classic /O2 /Oy- /D "CMAKE_INTDIR=\"Debug\"" /D _MBCS /Gm- /MD /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /Fo"cmTC_36d58.dir\Debug\\" /Fd"cmTC_36d58.dir\Debug\vc141.pdb" /Gd /TP /analyze- /errorReport:queue -g "C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\cmake\checks\cxx11.cpp"
cl : Command line warning D9002: ignoring unknown option '-g' [C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj]
Link:
C:\Program Files (x86)\Microsoft Visual Studio\2017\BuildTools\VC\Tools\MSVC\14.16.27023\bin\HostX86\x86\link.exe /ERRORREPORT:QUEUE /OUT:"C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\Debug\cmTC_36d58.js" /INCREMENTAL /NOLOGO /MANIFEST:NO /PDB:"C:/Users/schma/Documents/DulChunCinn/opencv-js/opencv/platforms/js/build_js/CMakeFiles/CMakeTmp/Debug/cmTC_36d58.pdb" /SUBSYSTEM:CONSOLE /TLBID:1 /DYNAMICBASE /NXCOMPAT /IMPLIB:"C:/Users/schma/Documents/DulChunCinn/opencv-js/opencv/platforms/js/build_js/CMakeFiles/CMakeTmp/Debug/" /MACHINE:X86 /SAFESEH --default-obj-ext .obj cmTC_36d58.dir\Debug\cxx11.obj
LINK : warning LNK4044: unrecognized option '/-default-obj-ext'; ignored [C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj]
LINK : fatal error LNK1104: cannot open file '.obj' [C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj]
Done Building Project "C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj" (default targets) -- FAILED.
Build FAILED.
"C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj" (default target) (1) ->
(ClCompile target) ->
cl : Command line warning D9002: ignoring unknown option '-g' [C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj]
"C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj" (default target) (1) ->
(Link target) ->
LINK : warning LNK4044: unrecognized option '/-default-obj-ext'; ignored [C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj]
"C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj" (default target) (1) ->
(Link target) ->
LINK : fatal error LNK1104: cannot open file '.obj' [C:\Users\schma\Documents\DulChunCinn\opencv-js\opencv\platforms\js\build_js\CMakeFiles\CMakeTmp\cmTC_36d58.vcxproj]
2 Warning(s)
1 Error(s)
Time Elapsed 00:00:01.24
===== END =====
```
| priority: low,category: build/install,category: javascript (js) | low | Critical |
410,947,606 | flutter | Autoselect real device when running in release mode | If you have both a real device and a simulator connected, and you do `flutter run --release`, flutter asks you which device to run on, but it can only run on a real device in release mode, so could it not just autoselect the real device ( if it's possible to differentiate this ) ? | c: new feature,tool,a: quality,P2,team-tool,triaged-tool | low | Minor |
410,951,154 | go | x/build/cmd/gerritbot: Gerrit asks PR author to review their own change | In https://go-review.googlesource.com/c/oauth2/+/162937 I wrote:
> I'm going to delete your code review vote because it's misleading. Reviewing your own code doesn't really count in terms of our code review requirements.
PR author @nwidger then replied:
> My bad! I wasn't sure if doing that was appropriate. The email from Gerrit Bot said 'Gerrit Bot would like Niels Widger to review this change' so I thought maybe that's what it wanted me to do.
This is a tracking bug to understand why that happened and ideally prevent that message.
/cc @andybons @dmitshur | Builders,NeedsInvestigation | low | Critical |
410,968,248 | TypeScript | Add '--bail' option when running '--build' mode | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
project references, bail, cascade, errors
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
When building multiple Typescript projects using the `--build` flag, and the projects had dependencies on each other, an error in an upstream project can cause a cascade of errors from downstream projects that obscure the original error.
A possible solution would be a `--bail` option (or however you'd like to name it). When provided in `--build` mode, it would prevent all projects downstream from a project with an error from building. While this may hide downstream errors that are only found when re-running, it will prevent "false-positive" errors from being shown.
<!-- A summary of what you'd like to see added or changed -->
## Use Cases
Using `--build` mode on a large web of project references, without the possibility of being flooded with spurious errors due to one upstream typo.
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
410,983,813 | kubernetes | Kubelet sysctl settings cannot be overridden | <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
The kubelet overrides user defined sysctl parameters silently.
**What you expected to happen**:
Values defined by the administrator in `/etc/sysctl.d/*.conf` files should take priority or at least not be silently overridden.
**How to reproduce it (as minimally and precisely as possible)**:
1. Create a file in `/etc/sysctl.d` that conflicts with one that kubelet sets on startup. - `echo "vm.panic_on_oom = 1" > /etc/sysctl.d/30-panic-on-oom.conf` is a good example.
2. Reboot
3. After boot the value specified through sysctl is overridden by kubelet.
**Anything else we need to know?**:
This behavior is particularly tricky to debug because the kubelet is almost always going to start after the systemd-sysctl service. The end result here is that the system boots and claims to have successfully applied all user defined kernel configuration, but then inspecting manually with the `sysctl` utility doesn't show the expected values.
I can understand why the kubelet would want to discover the state of the oom panic toggle on startup, but the changes made for #15091 appear to have completely hard-coded this behavior and actively fight against configuration managed through traditional Linux management options (these parameters would all be valid on the GRUB command line or through systemd setting sysctl parameters on startup).
I can see a few options that would be a reasonable way to handle this:
1. Offer a configuration option on the kubelet to override the behavior.
2. Stop managing sysctl parameters that are not fatal to the kubelet running and ship recommended parameters as sysctl.d config files through post-install tooling for the kubelet package in a package manager (deb/rpm) or by letting provisioning tools create those files. Parameters that are considered best-practice but are not required for the kubelet to start can throw a warning.
**Environment**:
- Kubernetes version (use `kubectl version`): 1.12.4
- Cloud provider or hardware configuration: Azure
- OS (e.g. from /etc/os-release): Ubuntu 16.04
- Kernel (e.g. `uname -a`): `4.15.0-1037-azure`
- Install tools: AKS Engine
| area/kubelet,sig/node,kind/feature,lifecycle/frozen | medium | Critical |
411,047,981 | go | cmd/go: explicitly reject packages whose source files contain leading dots | ### What version of Go are you using (`go version`)?
<pre>
go1.11.1 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes, tested with:
<pre>
go1.12rc1 darwin/amd64
</pre>
But at least the latest version shows the `._` filename being processed, and generates 'unexpected NUL in input'
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOBIN="/Users/peter/go/bin"
GOCACHE="/Users/peter/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
```
### What did you do?
`go build`
### What did you expect to see?
module to build without errors, which it does after deleting the spurious `._<filename>.go` file.
Probably the go command line tools should be ignoring these system files.
### What did you see instead?
fails with "cannot find package"
I initially thought this was related to #27238 but I think it is a different problem specific to macos. However it might be worth adding a link from there in case anyone else has this problem.
| OS-Darwin,NeedsInvestigation | low | Critical |
411,060,513 | pytorch | Deadlock with multiprocessing (using fork) and OpenMP / PyTorch should warn after OMP and fork that multithreading may be broken | ## 🐛 Bug
The following program never terminates.
```
import torch
import torch.multiprocessing as mp
def foo():
x = torch.ones((2, 50, 10))
return torch.einsum('ijl,ikl->ijk', x, x)
if __name__ == '__main__':
foo()
p = mp.Process(target=foo)
p.start()
p.join()
```
The behavior persists if one changes the `einsum` inside `foo` with an equivalent operation (e.g., `bmm(y, y.transpose(1,2))`, or `(y.unsqueeze(2) * y.unsqueeze(1)).sum(3)`.
It doesn't reproduce, however, if one doesn't call `foo` inside the main block.
## Environment
PyTorch version: 1.0.1.post2
Is debug build: No
CUDA used to build PyTorch: 9.0.176
OS: Arch Linux
GCC version: (GCC) 8.2.1 20181127
CMake version: version 3.13.4
Python version: 3.7
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
## Additional context
Perhaps related to #2245. | high priority,module: docs,module: multiprocessing,triaged | medium | Critical |
411,077,923 | go | runtime: simplify right shift and zero test | ### What version of Go are you using (`go version`)?
1.11
### What did you do?
Please consider the following dummy code:
func Dummy(x uint64) int {
i := 0
for {
x >>= 1
if x == 0 {
break
}
i -= 1
}
return i
}
### What did you expect to see?
Main part of the loop could compile down to (i.e. without the test for zero):
SHRQ $1, AX
JNE label
or even:
SHRQ AX
JNE label
### What did you see instead?
It compiles down to (on x86):
SHRQ $1, AX
TESTQ AX, AX
JNE label
PS: I've just noticed similar situation occurs with `- 1`, instead of `>> 1`:
func DummySub(x int64) int {
if x == 0 {
x = 10
}
i := 0
for {
x -= 1
if x == 0 {
break
}
i += 1
}
return i
}
There the:
DECQ AX
CMPQ AX, $1
JNE label
could also be replaced by:
SUBQ AX, $1 // or DECQ AX
JE label | Performance,NeedsFix,compiler/runtime | low | Major |
411,099,410 | rust | LLVM ERROR: Undefined temporary symbol when compiling wasm-bindgen-macro-support on powerpc64+powerpc64le linux | See log here https://buildd.debian.org/status/fetch.php?pkg=rust-wasm-bindgen-macro-support&arch=ppc64el&ver=0.2.33-1&stamp=1549258418&raw=0
The same issue is reproducible with the rustc binary from [here](https://static.rust-lang.org/dist/rust-1.32.0-powerpc64le-unknown-linux-gnu.tar.gz), but one needs to first work around #58334/#57345 by building your cargo, e.g. the Debian `cargo` package works.
Stack traces, but locals are optimised out:
Debian rustc
~~~~
$ cargo build --verbose --verbose
[..]
$ rust-gdb -q rustc
[..]
(gdb) break llvm::report_fatal_error
[..]
(gdb) run --crate-name wasm_bindgen_macro_support crates/macro-support/src/lib.rs --color always --crate-type lib --emit=dep-info,link -C debuginfo=2 --cfg 'feature="spans"' --cfg 'feature="wasm-bindgen-backend"' -C metadata=267ded4c6ac04022 -C extra-filename=-267ded4c6ac04022 --out-dir $HOME/wasm-bindgen/target/debug/deps -C incremental=$HOME/wasm-bindgen/target/debug/incremental -L dependency=$HOME/wasm-bindgen/target/debug/deps --extern proc_macro2=$HOME/wasm-bindgen/target/debug/deps/libproc_macro2-ddf6fe723d049424.rlib --extern quote=$HOME/wasm-bindgen/target/debug/deps/libquote-bd5442aa4aee0f1c.rlib --extern syn=$HOME/wasm-bindgen/target/debug/deps/libsyn-a5d8e6188798fcb2.rlib --extern wasm_bindgen_backend=$HOME/wasm-bindgen/target/debug/deps/libwasm_bindgen_backend-c8bf27854c4fe469.rlib --extern wasm_bindgen_shared=$HOME/wasm-bindgen/target/debug/deps/libwasm_bindgen_shared-216cd9cb4202c473.rlib
[..]
(gdb) bt
#0 __gthread_mutex_lock () at /usr/lib/gcc/powerpc64le-linux-gnu/8/../../../../include/powerpc64le-linux-gnu/c++/8/bits/gthr-default.h:747
#1 lock () at /usr/lib/gcc/powerpc64le-linux-gnu/8/../../../../include/c++/8/bits/std_mutex.h:103
#2 lock_guard () at /usr/lib/gcc/powerpc64le-linux-gnu/8/../../../../include/c++/8/bits/std_mutex.h:162
#3 report_fatal_error () at /build/llvm-toolchain-7-4s73DP/llvm-toolchain-7-7.0.1/lib/Support/ErrorHandling.cpp:101
#4 0x00003fffb202973c in llvm::MCContext::reportError(llvm::SMLoc, llvm::Twine const&) () at /build/llvm-toolchain-7-4s73DP/llvm-toolchain-7-7.0.1/lib/MC/MCContext.cpp:628
#5 0x00003fffb20056a8 in computeSymbolTable () at /build/llvm-toolchain-7-4s73DP/llvm-toolchain-7-7.0.1/lib/MC/ELFObjectWriter.cpp:645
#6 writeObject () at /build/llvm-toolchain-7-4s73DP/llvm-toolchain-7-7.0.1/lib/MC/ELFObjectWriter.cpp:1151
#7 0x00003fffb171ed30 in ?? () from /usr/lib/powerpc64le-linux-gnu/libLLVM-7.so.1
#8 0x00003fffb201b9b4 in Finish () at /build/llvm-toolchain-7-4s73DP/llvm-toolchain-7-7.0.1/lib/MC/MCAssembler.cpp:849
#9 0x00003fffb204aef0 in FinishImpl () at /build/llvm-toolchain-7-4s73DP/llvm-toolchain-7-7.0.1/lib/MC/MCObjectStreamer.cpp:683
#10 0x00003fffb2039474 in FinishImpl () at /build/llvm-toolchain-7-4s73DP/llvm-toolchain-7-7.0.1/lib/MC/MCELFStreamer.cpp:674
#11 0x00003fffb20561c4 in Finish () at /build/llvm-toolchain-7-4s73DP/llvm-toolchain-7-7.0.1/lib/MC/MCStreamer.cpp:863
#12 0x00003fffb1718324 in doFinalization () at /build/llvm-toolchain-7-4s73DP/llvm-toolchain-7-7.0.1/lib/CodeGen/AsmPrinter/AsmPrinter.cpp:1548
#13 0x0000000000000000 in ?? ()
~~~~
Upstream rustc
~~~~
$ export PATH=$HOME/vroot/usr/bin:$HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/bin:/usr/local/bin:/usr/bin:/bin
$ export LD_LIBRARY_PATH=$HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rust-std-powerpc64le-unknown-linux-gnu/lib/rustlib/powerpc64le-unknown-linux-gnu/lib
$ export RUSTFLAGS="-L $LD_LIBRARY_PATH"
$ export RUSTDOCFLAGS="-L $LD_LIBRARY_PATH"
$ which cargo
$HOME/vroot/usr/bin/cargo
$ which rustc
$HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/bin/rustc
$ cargo build --verbose --verbose
[..]
$ rust-gdb -q rustc
[..]
(gdb) break llvm::report_fatal_error
[..]
(gdb) run --crate-name wasm_bindgen_macro_support crates/macro-support/src/lib.rs --color always --crate-type lib --emit=dep-info,link -C debuginfo=2 --cfg 'feature="spans"' --cfg 'feature="wasm-bindgen-backend"' -C metadata=56e98bc84653fd36 -C extra-filename=-56e98bc84653fd36 --out-dir $HOME/wasm-bindgen/target/debug/deps -C incremental=$HOME/wasm-bindgen/target/debug/incremental -L dependency=$HOME/wasm-bindgen/target/debug/deps --extern proc_macro2=$HOME/wasm-bindgen/target/debug/deps/libproc_macro2-a9b42ce46045ad3d.rlib --extern quote=$HOME/wasm-bindgen/target/debug/deps/libquote-b533d9dc523383f1.rlib --extern syn=$HOME/wasm-bindgen/target/debug/deps/libsyn-73f28adcf440f43e.rlib --extern wasm_bindgen_backend=$HOME/wasm-bindgen/target/debug/deps/libwasm_bindgen_backend-0d6dbe292e1636ee.rlib --extern wasm_bindgen_shared=$HOME/wasm-bindgen/target/debug/deps/libwasm_bindgen_shared-7b78e47489df9616.rlib -L $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rust-std-powerpc64le-unknown-linux-gnu/lib/rustlib/powerpc64le-unknown-linux-gnu/lib
[..]
(gdb) bt
#0 0x00003fffb3ab339c in llvm::report_fatal_error(llvm::Twine const&, bool) ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#1 0x00003fffb395f540 in llvm::MCContext::reportError(llvm::SMLoc, llvm::Twine const&) ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#2 0x00003fffb393488c in (anonymous namespace)::ELFWriter::computeSymbolTable(llvm::MCAssembler&, llvm::MCAsmLayout const&, llvm::DenseMap<llvm::MCSectionELF const*, unsigned int, llvm::DenseMapInfo<llvm::MCSectionELF const*>, llvm::detail::DenseMapPair<llvm::MCSectionELF const*, unsigned int> > const&, llvm::DenseMap<llvm::MCSymbol const*, unsigned int, llvm::DenseMapInfo<llvm::MCSymbol const*>, llvm::detail::DenseMapPair<llvm::MCSymbol const*, unsigned int> > const&, std::map<llvm::MCSectionELF const*, std::pair<unsigned long, unsigned long>, std::less<llvm::MCSectionELF const*>, std::allocator<std::pair<llvm::MCSectionELF const* const, std::pair<unsigned long, unsigned long> > > >&) () from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#3 0x00003fffb393695c in (anonymous namespace)::ELFWriter::writeObject(llvm::MCAssembler&, llvm::MCAsmLayout const&) [clone .constprop.391] ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#4 0x00003fffb3938e30 in (anonymous namespace)::ELFSingleObjectWriter::writeObject(llvm::MCAssembler&, llvm::MCAsmLayout const&) ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#5 0x00003fffb3950fa8 in llvm::MCAssembler::Finish() () from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#6 0x00003fffb39852d0 in llvm::MCObjectStreamer::FinishImpl() ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#7 0x00003fffb3972e60 in llvm::MCELFStreamer::FinishImpl() () from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#8 0x00003fffb3993468 in llvm::MCStreamer::Finish() () from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#9 0x00003fffb29e4810 in llvm::AsmPrinter::doFinalization(llvm::Module&) ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#10 0x00003fffb1b5d774 in (anonymous namespace)::PPCLinuxAsmPrinter::doFinalization(llvm::Module&) ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#11 0x00003fffb379b188 in llvm::FPPassManager::doFinalization(llvm::Module&) ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#12 0x00003fffb37aa888 in llvm::legacy::PassManagerImpl::run(llvm::Module&) ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#13 0x00003fffb37aab3c in llvm::legacy::PassManager::run(llvm::Module&) ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#14 0x00003fffb1710244 in LLVMRustWriteOutputFile () from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#15 0x00003fffb162baac in rustc_codegen_llvm::back::write::write_output_file ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#16 0x00003fffb162f638 in rustc_codegen_llvm::back::write::codegen::{{closure}} ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#17 0x00003fffb162e92c in rustc_codegen_llvm::back::write::codegen ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#18 0x00003fffb15e43a0 in rustc_codegen_ssa::back::write::execute_work_item ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#19 0x00003fffb16d0d9c in std::sys_common::backtrace::__rust_begin_short_backtrace ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#20 0x00003fffb15a2fd8 in std::panicking::try::do_call () from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#21 0x00003fffb7c62e84 in __rust_maybe_catch_panic () at src/libpanic_unwind/lib.rs:102
#22 0x00003fffb15ac188 in <F as alloc::boxed::FnBox<A>>::call_box ()
from $HOME/rust-1.32.0-powerpc64le-unknown-linux-gnu/rustc/lib/rustlib/powerpc64le-unknown-linux-gnu/codegen-backends/librustc_codegen_llvm-llvm.so
#23 0x00003fffb7c5787c in _$LT$alloc..boxed..Box$LT$$LP$dyn$u20$alloc..boxed..FnBox$LT$A$C$$u20$Output$u3d$R$GT$$u20$$u2b$$u20$$u27$a$RP$$GT$$u20$as$u20$core..ops..function..FnOnce$LT$A$GT$$GT$::call_once::hcb2877104e64de51 () at /rustc/9fda7c2237db910e41d6a712e9a2139b352e558b/src/liballoc/boxed.rs:683
#24 std::sys_common::thread::start_thread () at src/libstd/sys_common/thread.rs:24
#25 std::sys::unix::thread::Thread::new::thread_start () at src/libstd/sys/unix/thread.rs:90
#26 0x00003fffb4f28e04 in start_thread (arg=0x0) at pthread_create.c:486
#27 0x00003fffb7ad3cd8 in clone () at ../sysdeps/unix/sysv/linux/powerpc/powerpc64/clone.S:82
~~~~
| A-LLVM,T-compiler,O-PowerPC,C-bug | low | Critical |
411,099,907 | rust | Type inference fails even though all types are known | The following code fails to compile, even though all types are known
https://play.rust-lang.org/?version=stable&mode=debug&edition=2015&gist=8de9e57e8de5cd8f2896f422d693f453
```rust
pub fn f(s: &str) {
let mut it = s.split(|c: char| c == ',').fuse();
let t = it.next().unwrap().parse::<usize>().unwrap();
}
```
```
Compiling playground v0.0.1 (/playground)
error[E0282]: type annotations needed
--> src/main.rs:3:13
|
3 | let t = it.next().unwrap().parse::<usize>().unwrap();
| ^^^^^^^^^^^^^^^^^^ cannot infer type for `T`
|
= note: type must be known at this point
error: aborting due to previous error
For more information about this error, try `rustc --explain E0282`.
error: Could not compile `playground`.
To learn more, run the command again with --verbose.
```
| P-medium,T-compiler,regression-from-stable-to-stable,A-inference,C-bug | low | Critical |
411,108,841 | rust | Tracking issue for error source iterators | This covers the `<dyn Error>::iter_chain` and `<dyn Error>::iter_sources` methods added in #58289. | T-libs-api,B-unstable,C-tracking-issue,A-error-handling,Libs-Tracked,PG-error-handling | high | Critical |
411,129,382 | rust | Poor suggestions wrt closure type/lifetime inference | Given the following code:
```
fn main() {
let cl = |x| { x.split_at(0) };
let (_x, _y) = cl("42");
}
```
rustc suggests:
```
3 | let cl = |x| { x.split_at(0) };
| ^ consider giving this closure parameter a type
```
Unfortunately, specifying a closure parameter type casts the user from the frying pan into the fire:
```
error[E0495]: cannot infer an appropriate lifetime for autoref due to conflicting requirements
--> src/main.rs:3:27
|
3 | let cl = |x:&str| { x.split_at(0) };
| ^^^^^^^^
|
note: first, the lifetime cannot outlive the anonymous lifetime #1 defined on the body at 3:14...
--> src/main.rs:3:14
|
3 | let cl = |x:&str| { x.split_at(0) };
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
note: ...so that reference does not outlive borrowed content
--> src/main.rs:3:25
|
3 | let cl = |x:&str| { x.split_at(0) };
| ^
note: but, the lifetime must be valid for the call at 4:20...
--> src/main.rs:4:20
|
4 | let (_x, _y) = cl("42");
| ^^^^^^^^
note: ...so type `(&str, &str)` of expression is valid during the expression
--> src/main.rs:4:20
|
4 | let (_x, _y) = cl("42");
| ^^^^^^^^
```
Helpful contributors on #rust-beginners found https://github.com/rust-lang/rust/issues/55526 https://github.com/rust-lang/rust/issues/56537 and the following simple workaround:
```
fn main() {
let cl = |x| { let x : &str = x; x.split_at(0) };
let (_x, _y) = cl("42");
}
```
The underlying problem with lifetime inference in closures seems quite tricky and I guess it will remain like this for a while.
Under the circumstances, it would be nice if the compiler could make more helpful suggestions, including the trick with the let binding to nail the type.
Something like this maybe:
> Consider removing the type specification for this closure parameter to allow lifetime inference. If the type specification is needed within the closure, a binding let VAR : TYPE = VAR at the start of the closure may help.
(for outputting, in addition to the other messages, in the more complicated lifetime problem case) | C-enhancement,A-diagnostics,A-closures,T-compiler,A-inference,A-suggestion-diagnostics,D-newcomer-roadblock | low | Critical |
411,135,900 | youtube-dl | mxplayer.in - Site Request | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see what your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2019.02.08*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2019.02.08**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
- [x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2019.02.08
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.mxplayer.in/show/watch-super-dancer-chapter-3/chapter-3/ep15-dance-and-dhamaal-16-february-2019-online-0c2dfe47dd05151ad04819b32a899a51
Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
| site-support-request,geo-restricted | low | Critical |
411,149,227 | pytorch | Group Norm Error When using FP16 | ## 🐛 Bug
## To Reproduce
```
import torch
x = torch.randn(1, 10, 20, 20).cuda().half()
M1 = torch.nn.BatchNorm2d(10).cuda()
M2 = torch.nn.GroupNorm(10, 10).cuda()
M1(x) (tensor)
M2(x) (error)
```
```
RuntimeError: Expected object of scalar type Float but got scalar type Half for argument #3 'tensor1'
```
## Expected behavior
Group norm seems to reshape the input tensor and then use batch norm internally based on [these lines]:(https://github.com/pytorch/pytorch/blob/7157be86226b79e3a698cbb0c524fc3ae59e28de/aten/src/ATen/native/Normalization.cpp#L465)
```
# ATen/native/Normalization.cpp
auto input_reshaped = input.contiguous().view({1, b * num_groups, -1});
auto out = at::batch_norm(input_reshaped, {}, {}, {}, {}, true, 0, eps,
cudnn_enabled);
out = out.view(input_shape);
```
I am able to train models that have batch norms in mix precision with Nvidia's [apex](https://github.com/NVIDIA/apex), so I guess it should work for group morns.
## Environment
PyTorch version: 1.0.1
Is debug build: No
CUDA used to build PyTorch: 10.0
OS: Microsoft Windows 10 Home
GCC version: (GCC) 7.3.0
CMake version: version 3.12.18081601-MSVC_2
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: 10.0.130
cc @nairbv @mruberry | needs reproduction,triaged,module: type promotion,module: half,module: norms and normalization | low | Critical |
411,149,841 | rust | Impossible to specify link-args for lld in json target specification | Rustc target spec json files can specify `link-args` and `pre-link-args`. For instance, here is part of the output of `rustc -Z unstable-options --print target-spec-json --target i686-unknown-linux-gnu`:
```json
"pre-link-args": {
"gcc": [
"-Wl,--as-needed",
"-Wl,-z,noexecstack",
"-m32"
]
},
```
As far as I can tell, for annoying reasons about how it's implemented, it isn't possible to set this with `lld` instead of `gcc`.
In [`librustc_target/spec/mod.rs`](https://github.com/rust-lang/rust/blob/master/src/librustc_target/spec/mod.rs):
```rust
#[derive(Clone, Copy, Debug, Eq, Ord, PartialEq, PartialOrd, Hash,
RustcEncodable, RustcDecodable)]
pub enum LinkerFlavor {
Em,
Gcc,
Ld,
Msvc,
Lld(LldFlavor),
PtxLinker,
}
```
This is serialized and de-serialized with `rustc-serialize`. Unlike the other variants, `Lld` contains a field. Looking at how the json serialization/de-serialization is [implemented](https://github.com/rust-lang-deprecated/rustc-serialize/blob/master/src/json.rs), it looks like this is would be represented as `{"variant": "lld", "fields": [...]"}`.
The issue is that this can't appear in the target spec in place of `"gcc"` from the example above, since json doesn't allow an object to be the key of an object.
Is my analysis right, and this is currently impossible to do in a json target spec, or am I missing something?
### Solution
I think the best solution in the short term is to implement `Decodable` and `Encodable` manually for the enum. I presume changing the representation of this wouldn't break anything in practice, and even if it did it's an implementation detail that doesn't provide stability guarantees?
In the long term, I'm not sure what the plans for `rustc-serialize` are. It describes itself as "deprecated". Is it ideally intended to be replaced with `serde` at some point, which just hasn't been done since it's a lot of work? | C-enhancement,T-compiler,A-target-specs | low | Critical |
411,156,911 | godot | Mono build thrashes stacktrace (backtrace) from GDNative | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:** v3.1.beta4.mono.official
<!-- Specify commit hash if non-official. -->
**OS/device including version:** Linux 64b
<!-- Specify GPU model and drivers if graphics-related. -->
**Issue description:**
<!-- What happened, and what was expected. -->
Without mono:
```
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x354b0) [0x7f144a1f04b0] (??:0)
[2] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x956179] (??:?)
[3] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x20e0973] (??:?)
[4] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x957ea3] (??:?)
[5] godot::___godot_icall_void_String(godot_method_bind*, godot::Object const*, godot::String const&) (??:0)
[6] godot::Resource::set_name(godot::String) (??:0)
[7] godot::CPP::createMesh(Chunk*) (??:0)
[8] godot::CPP::generateChunkNodes(std::map<Vector3Int, Chunk*, std::less<Vector3Int>, std::allocator<std::pair<Vector3Int const, Chunk*> > >*) (??:0)
[9] godot::CPP::benchGenerateChunkNodes(std::map<Vector3Int, Chunk*, std::less<Vector3Int>, std::allocator<std::pair<Vector3Int const, Chunk*> > >*) (??:0)
[10] godot::CPP::_process(float) (??:0)
[11] godot_variant godot::__wrapped_method<godot::CPP, void, float>(void*, void*, void*, int, godot_variant**) (??:0)
[12] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0xa7b338] (<artificial>:?)
[13] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x169444f] (??:?)
[14] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x9078e6] (??:?)
[15] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x20dd3c4] (??:?)
[16] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x1620dbe] (<artificial>:?)
[17] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x166a021] (??:?)
[18] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x9aef90] (??:?)
[19] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x7ac22d] (??:?)
[20] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0) [0x7f144a1db830] (??:0)
[21] /xxx/Godot_v3.1-beta4_x11_64/Godot_v3.1-beta4_x11.64() [0x7b9c8e] (??:?)
-- END OF BACKTRACE --
```
With mono:
```
Stacktrace:
/proc/self/maps:
00400000-04197000 r-xp 00000000 fc:04 696 /xxx/Godot_v3.1-beta4_mono_x11.64
04397000-04463000 r--p 03d97000 fc:04 696 /xxx/Godot_v3.1-beta4_mono_x11.64
04463000-0447d000 rw-p 03e63000 fc:04 696 /xxx/Godot_v3.1-beta4_mono_x11.64
0447d000-044ae000 rw-p 00000000 00:00 0
04628000-0e7d9000 rw-p 00000000 00:00 0 [heap]
40035000-40045000 rwxp 00000000 00:00 0
40777000-40797000 rwxp 00000000 00:00 0
4113b000-411ed000 rw-p 00000000 00:00 0
412b4000-412b6000 r-xs 00000000 fc:01 2359682 /tmp/.glkuIqcW (deleted)
413c9000-413d9000 rwxp 00000000 00:00 0
41432000-41442000 rwxp 00000000 00:00 0
7fd5ab7ff000-7fd5abbff000 rw-s 00000000 00:06 622 /dev/nvidiactl
7fd5abbff000-7fd5abfff000 rw-s 00000000 00:06 622 /dev/nvidiactl
7fd5abfff000-7fd5b0000000 rw-p 00000000 00:00 0
7fd5b0000000-7fd5b0021000 rw-p 00000000 00:00 0
7fd5b0021000-7fd5b4000000 ---p 00000000 00:00 0
7fd5b43fe000-7fd5b47fe000 rw-s 00000000 00:06 622 /dev/nvidiactl
7fd5b47fe000-7fd5b8000000 rw-p 00000000 00:00 0
7fd5b8000000-7fd5b8021000 rw-p 00000000 00:00 0
7fd5b8021000-7fd5bc000000 ---p 00000000 00:00 0
7fd5bc000000-7fd5bc021000 rw-p 00000000 00:00 0
7fd5bc021000-7fd5c0000000 ---p 00000000 00:00 0
7fd5c0000000-7fd5c0021000 rw-p 00000000 00:00 0
7fd5c0021000-7fd5c4000000 ---p 00000000 00:00 0
7fd5c41fd000-7fd5c45fd000 rw-s 00000000 00:06 622 /dev/nvidiactl
Unhandled Exception:
System.NullReferenceException: Object reference not set to an instance of an object
```
**Steps to reproduce:**
Run crashing C++ code using GDNative in Godot mono build.
<!--**Minimal reproduction project:**-->
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
| enhancement,topic:dotnet | low | Critical |
411,162,115 | rust | Diagnostic for `dyn Self` could be more specific | Code ([play]):
```rust
trait S {
fn f() -> dyn Self;
}
```
[play]: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=6f2a1b502460a961d6e5f33abace4dcd
Current diagnostic (1.34.0-nightly 2019-02-15 eac09088e1a8fc8a2930):
```
error[E0411]: expected trait, found self type `Self`
--> src/lib.rs:2:19
|
2 | fn f() -> dyn Self;
| ^^^^ `Self` is only available in impls, traits, and type definitions
```
@Moongoodboy-K on IRC points out that it might be more helpful for the
diagnostic to say something like,
> expected trait, found concrete type `Self`
>
> (help: `Self` refers to the concrete type implementing this trait)
(For context: while I’ve since learned that this code is pretty far from
valid, the intent was to find a way to use `Self`-types while preserving
object-safety. My intuition was that it should suffice to return the
receiver’s vtable from the function, which suggested to me the syntax
`dyn Self`. Using simply `fn f() -> dyn S` is object-safe but loses the
self-typing, which might matter if given something like `dyn S + Send`.)
| C-enhancement,A-diagnostics,A-trait-system,T-compiler,D-papercut | low | Critical |
411,169,508 | rust | Tracking issue for LinkedList cursors | This is a tracking issue for the RFC "Linked list cursors" (rust-lang/rfcs#2570).
**Steps:**
- [x] Implement the RFC (#68123)
- [ ] Update documentation, add examples
- [ ] Stabilization PR ([see instructions on forge][stabilization-guide])
[stabilization-guide]: https://forge.rust-lang.org/stabilization-guide.html
[doc-guide]: https://forge.rust-lang.org/stabilization-guide.html#updating-documentation
**Unresolved questions:**
- [ ] Only for linked lists? | A-collections,T-libs-api,B-RFC-implemented,C-tracking-issue,Libs-Tracked | high | Critical |
411,190,305 | flutter | pub get failed (1) | I'm trying to run Flutter app but I can't. I can't neither get packages.
## Logs
```
D:\Programmazione\Flutter\flutter_app>flutter run -v
[ +31 ms] executing: [D:\Programmazione\Flutter\flutter\] git rev-parse --abbrev-ref --symbolic @{u}
[ +98 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[ ] origin/master
[ ] executing: [D:\Programmazione\Flutter\flutter\] git rev-parse --abbrev-ref HEAD
[ +66 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[ ] master
[ ] executing: [D:\Programmazione\Flutter\flutter\] git ls-remote --get-url origin
[ +62 ms] Exit code 0 from: git ls-remote --get-url origin
[ ] https://github.com/flutter/flutter.git
[ ] executing: [D:\Programmazione\Flutter\flutter\] git log -n 1 --pretty=format:%H
[ +63 ms] Exit code 0 from: git log -n 1 --pretty=format:%H
[ ] e99c881f8d0e63042af6e2a3f6182c3ca6967442
[ ] executing: [D:\Programmazione\Flutter\flutter\] git log -n 1 --pretty=format:%ar
[ +64 ms] Exit code 0 from: git log -n 1 --pretty=format:%ar
[ +1 ms] 3 days ago
[ +1 ms] executing: [D:\Programmazione\Flutter\flutter\] git describe --match v*.*.* --first-parent --long --tags
[ +84 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[ ] v1.2.0-197-ge99c881
[ +193 ms] executing: D:\Local\Android\Sdk\platform-tools\adb devices -l
[ +37 ms] Exit code 0 from: D:\Local\Android\Sdk\platform-tools\adb devices -l
[ ] List of devices attached
ce12160cdb9eac0f05 device product:hero2ltexx model:SM_G935F device:hero2lte transport_id:1
[ +255 ms] D:\Local\Android\Sdk\platform-tools\adb -s ce12160cdb9eac0f05 shell getprop
[ +128 ms] ro.hardware = samsungexynos8890
[ +839 ms] Launching lib/main.dart on SM G935F in debug mode...
[ +27 ms] Initializing gradle...
[ +2 ms] Using gradle from D:\Programmazione\Flutter\flutter_app\android\gradlew.bat.
[ +164 ms] executing: D:\Programmazione\Flutter\flutter_app\android\gradlew.bat -v
[ +968 ms]
------------------------------------------------------------
Gradle 4.10.2
------------------------------------------------------------
Build time: 2018-09-19 18:10:15 UTC
Revision: b4d8d5d170bb4ba516e88d7fe5647e2323d791dd
Kotlin DSL: 1.0-rc-6
Kotlin: 1.2.61
Groovy: 2.4.15
Ant: Apache Ant(TM) version 1.9.11 compiled on March 23 2018
JVM: 1.8.0_152-release (JetBrains s.r.o 25.152-b01)
OS: Windows 10 10.0 amd64
[ +12 ms] "flutter run" took 2.489ms.
[ ] "flutter run" took 2.489ms.
Oops; flutter has exited unexpectedly.
Sending crash report to Google.
Crash report sent (report ID: d6ac79dde905bda6)
Crash report written to D:\Programmazione\Flutter\flutter_app\flutter_07.log;
please let us know at https://github.com/flutter/flutter/issues.
```
```
D:\Programmazione\Flutter\flutter_app>flutter doctor -v
[√] Flutter (Channel master, v1.2.1-pre.197, on Windows, locale it-IT)
• Flutter version 1.2.1-pre.197 at D:\Programmazione\Flutter\flutter
• Framework revision e99c881f8d (3 days ago), 2019-02-14 16:08:26 +0800
• Engine revision 3757390fa4
• Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb)
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at D:\Local\Android\Sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• ANDROID_HOME = D:\Local\Android\Sdk
• Java binary at: D:\Programmi\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
• All Android licenses accepted.
[√] Android Studio (version 3.3)
• Android Studio at D:\Programmi\Android\Android Studio
• Flutter plugin version 33.0.1
• Dart plugin version 182.5215
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
[√] Connected device (1 available)
• SM G935F • ce12160cdb9eac0f05 • android-arm64 • Android 8.0.0 (API 26)
• No issues found!
```
```
D:\Programmazione\Flutter\flutter_app>flutter packages get -v
[ +21 ms] executing: [D:\Programmazione\Flutter\flutter\] git rev-parse --abbrev-ref --symbolic @{u}
[ +66 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u}
[ ] origin/master
[ ] executing: [D:\Programmazione\Flutter\flutter\] git rev-parse --abbrev-ref HEAD
[ +47 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD
[ +1 ms] master
[ ] executing: [D:\Programmazione\Flutter\flutter\] git ls-remote --get-url origin
[ +42 ms] Exit code 0 from: git ls-remote --get-url origin
[ ] https://github.com/flutter/flutter.git
[ ] executing: [D:\Programmazione\Flutter\flutter\] git log -n 1 --pretty=format:%H
[ +44 ms] Exit code 0 from: git log -n 1 --pretty=format:%H
[ ] e99c881f8d0e63042af6e2a3f6182c3ca6967442
[ ] executing: [D:\Programmazione\Flutter\flutter\] git log -n 1 --pretty=format:%ar
[ +45 ms] Exit code 0 from: git log -n 1 --pretty=format:%ar
[ ] 3 days ago
[ ] executing: [D:\Programmazione\Flutter\flutter\] git describe --match v*.*.* --first-parent --long --tags
[ +54 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags
[ ] v1.2.0-197-ge99c881
[ +126 ms] Running "flutter packages get" in flutter_app...
[ +4 ms] Using D:\Programmazione\Flutter\flutter\.pub-cache for the pub cache.
[ +1 ms] executing: [D:\Programmazione\Flutter\flutter_app\] D:\Programmazione\Flutter\flutter\bin\cache\dart-sdk\bin\pub.bat --verbosity=warning --verbose get --no-precompile
[ +389 ms] Running "flutter packages get" in flutter_app... (completed in 0,4s)
[ +1 ms] "flutter get" took 493ms.
[ ] "flutter get" took 493ms.
pub get failed (1)
#0 throwToolExit (package:flutter_tools/src/base/common.dart:24:3)
#1 pub (package:flutter_tools/src/dart/pub.dart:170:5)
<asynchronous suspension>
#2 pubGet (package:flutter_tools/src/dart/pub.dart:104:13)
<asynchronous suspension>
#3 PackagesGetCommand._runPubGet (package:flutter_tools/src/commands/packages.dart:59:11)
<asynchronous suspension>
#4 PackagesGetCommand.runCommand (package:flutter_tools/src/commands/packages.dart:82:11)
<asynchronous suspension>
#5 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:545:18)
#6 _asyncThenWrapperHelper.<anonymous closure> (dart:async/runtime/libasync_patch.dart:77:64)
#7 _rootRunUnary (dart:async/zone.dart:1132:38)
#8 _CustomZone.runUnary (dart:async/zone.dart:1029:19)
#9 _FutureListener.handleValue (dart:async/future_impl.dart:126:18)
#10 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:639:45)
#11 Future._propagateToListeners (dart:async/future_impl.dart:668:32)
#12 Future._complete (dart:async/future_impl.dart:473:7)
#13 _SyncCompleter.complete (dart:async/future_impl.dart:51:12)
#14 _AsyncAwaitCompleter.complete.<anonymous closure> (dart:async/runtime/libasync_patch.dart:33:20)
#15 _rootRun (dart:async/zone.dart:1124:13)
#16 _CustomZone.run (dart:async/zone.dart:1021:19)
#17 _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23)
#18 _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#19 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#20 _runPendingImmediateCallback (dart:isolate/runtime/libisolate_patch.dart:115:13)
#21 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:172:5)
```
| tool,dependency: dart,P2,team-tool,triaged-tool | low | Critical |
411,206,124 | node | http server.headersTimeout keeps the socket open after timeout | * **Version**: v11.6.0
* **Platform**: Darwin Mariuss-MBP-2.lan 18.2.0 Darwin Kernel Version 18.2.0: Mon Nov 12 20:24:46 PST 2018; root:xnu-4903.231.4~2/RELEASE_X86_64 x86_64
* **Subsystem**: http
In case timeout is reached for `server.headersTimeout`, node keeps the socket open until it receives data or `server.timeout` is reached.
I believe this issue causes dropped connections / 502 errors on AWS ALB (load balancer), because it tries to send data and socket closes immediately after data is received.
I have set `server.headersTimeout = 10 * 1000` and ran tcpdump to confirm.
As you can see in the dump, 24 seconds has passed, data was received, acknowledged and socket closed after data was received.
I expected socket to be closed after 10 seconds has passed without data.
| http | low | Critical |
411,209,365 | node | http socket might get reset instead of normal close while handling timeout | * **Version**: v10.15.1
* **Platform**: Linux 0fe3a1d57e94 4.9.125-linuxkit #1 SMP Fri Sep 7 08:20:28 UTC 2018 x86_64 GNU/Linux
* **Subsystem**: http,net
We were experiencing unexpected dropped connections between AWS ALB and nodejs application resulting in 502 errors from load balancer.
Managed to replicate a condition when nodejs abnormally closes socket with RST packet instead of normal FIN packets.
Here's exact conditions:
```
server.timeout = 10 * 1000;
server.keepAliveTimeout = 0;
```
We kept doing requests to the same connection every 10 seconds to trigger the condition.
Note that data was received and acknowledged, but instead of handling data or closing socket in a normal way nodejs reset the tcp connection.
| help wanted,http | low | Critical |
411,273,037 | TypeScript | tsconfig - Ignore errors by ids | I know that all errors in TypeScript are optional, it'd be nice if we could declare which error ids we want to ignore.
I.E. In the `tsconfig.json`:
```json
{
"compilerOptions":{
"ignoreErrors":[2403,2686,...]
}
}
```
The reason I say this is because a lot of these errors are just irratating... Like the error:
```
'L' refers to a UMD global, but the current file is a module. Consider adding an import instead.
```
This isn't an actual type error. It's a code style suggestion, and is entirely subjective unlike invalid type errors. I find many little 'errors' like this and they are deeply frustrating, as they just fill the error log with rubbish... Allow us to define which error ids we want to ignore, and this won't happen. | Suggestion,Awaiting More Feedback | high | Critical |
411,293,427 | godot | KinematicBody2D: test_move breaks when parent is offset from (0, 0) | **Godot version:**
3.1 beta 4
**OS/device including version:**
Windows 10
**Issue description:**
When a kinematic body 2d's parent does not have the position (0, 0), test_move behaves incorrectly.
**Steps to reproduce:**
Open attached project. Play the LevelBase scene by itself. Notice that it works normally. Now change LevelBase's position and test again. Notice that the platformer character will no longer behave correctly, such as refusing to jump, fast falling off ledges, etc. These have to do with the test_move checks in Player.gd, which is basic platforming logic.
you can also test
in TestRoom.tscn, and see how it impacts the game in Main.tscn.
**Minimal reproduction project:**
[Spectrum.zip](https://github.com/godotengine/godot/files/2874021/Spectrum.zip) | documentation,topic:physics | low | Minor |
411,339,700 | go | runtime: adopt mesh allocation technique? | I recently came across [Mesh: Compacting Memory Management for C/C++ Applications](https://arxiv.org/abs/1902.04738). From the paper:
> It introduces Mesh, a novel memory allocator that acts as a plug-in replacement for malloc. Mesh combines remapping of virtual to physical pages (meshing) with randomized allocation and search algorithms to enable safe and effective compaction without relocation for C/C++.
The results look quite promising:
> […] it reduces the memory of consumption of Firefox by 16% and Redis by 39%.
I’m not familiar enough with Go’s allocator to say precisely whether we could adopt mesh (or parts of it), but I figured I’d bring it up, just in case the paper doesn’t already find its way to people working on Go’s allocator :) | ExpertNeeded,NeedsInvestigation,FeatureRequest,compiler/runtime | low | Minor |
411,356,780 | flutter | [video_player] Add network cache functionality | ## Steps to Reproduce
I built this sample:
https://github.com/flutter/plugins/tree/master/packages/video_player/example
(v0.10.0+2)
and switched tab from side to side. Downloaded videos are disappear and started redownloading every time.
## Flutter Doctor
```
[√] Flutter (Channel beta, v0.11.10, on Microsoft Windows [Version 10.0.17763.316], locale ja-JP)
• Flutter version 0.11.10 at C:\flutter
• Framework revision c27c4a265e (3 months ago), 2018-11-26 17:07:24 -0500
• Engine revision eebc6a5895
• Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297)
[√] Android toolchain - develop for Android devices (Android SDK 28.0.3)
• Android SDK at C:\Users\XXXXXXXX\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
• All Android licenses accepted.
[√] Android Studio (version 3.3)
• Android Studio at C:\Program Files\Android\Android Studio
• Flutter plugin version 33.0.1
• Dart plugin version 182.5215
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1248-b01)
[√] Connected device (1 available)
• Pixel 3 • XXXXXXXXX • android-arm64 • Android 9 (API 28)
• No issues found!
```
| c: new feature,p: video_player,package,team-ecosystem,P2,triaged-ecosystem | low | Critical |
411,427,017 | vue | Chrome overrides value if superior to max value of input[type=range] because Vue sets attributes in the same order as they are provided | ### Version
2.6.6
### Reproduction link
https://codepen.io/posva/pen/LqMMNV
### Steps to reproduce
- set value attribute before max with a value > 100 on Chrome
### What is expected?
Vue should respect the value attr regardless of whether it is outside of the bounds of the default min/max threshold
### What is actually happening?
Vue sets the value to 100 if it is >100
<!-- generated by vue-issues. DO NOT REMOVE --> | browser quirks,has workaround | low | Major |
411,465,527 | create-react-app | Generate .gitignore at the same time README.md and package.json are created (before npm install) | I would like to propose that `.gitignore` gets created at the same time `README.md` and `package.json` do. Right now from experimentation it seems like the two do get created first, then `npm install` is run and then a bunch of other files including `.gitignore` gets dropped into the directory.
There's probably a reason for that, maybe the `.gitignore` gets copied from the scripts package, I don't know, but still, maybe an interim `.gitignore` could be created which ignores `node_modules`?
The reason I ask for this is because when I run `create-react-app .` (create in the current directory) in the VS Code Terminal, VS Code tries to calculate changes at npm-install-time and often runs into the too may changes state, which is a wasted effort ultimately, because at the end of the CRA creation, the Git ignore file gets dropped and the resulting set of changes is correct.
Providing the Git ignore file upfront (before `npm install`) or providing an interim one to be replaced by the filed one would solve this issue and make the experience a bit nicer. | issue: proposal | low | Minor |
411,597,901 | go | cmd/gofmt: remove plus operator before variable | In the following program:
```go
package main
import "fmt"
func main() {
a := 3
b := 7
a = +b
a += +b
fmt.Println("a", a, "b", b)
}
```
I believe the `+b` is extraneous and does not modify command operation, in both cases. Could `go fmt` simplify this by removing the plus operator? Similarly we remove things like braces and semicolons when they are unnecessary and do not affect program operation.
Running `go` tip. | NeedsDecision,FeatureRequest | low | Minor |
411,614,854 | rust | Compiler crashes when trying to compile core with static relocation model | I'm trying to compile Rust code for MS-DOS, and have written a custom target. In this target I have the relocation model set to `static`, since including that kind of information is impossible in a COM executable (which I'm using because it's trivial to generate them with linker scripts, unlike MZ executables). However, when compiling `core`, the compiler simply crashes with a segmentation fault. It seems to get most of the way through compiling `core`, as it actually crashes during or after LTO (I can't really tell). Here is the last part of the output of running the build with `RUST_LOG=debug`.
```
INFO 2019-02-18T19:19:11Z: rustc_codegen_ssa::base: codegen_instance(<alloc::AllocErr as fmt::Debug>::fmt)
INFO 2019-02-18T19:19:11Z: rustc_codegen_ssa::base: codegen_instance(<alloc::CannotReallocInPlace as fmt::Debug>::fmt)
INFO 2019-02-18T19:19:11Z: rustc_codegen_ssa::base: codegen_instance(mem::size_of::<u8>)
INFO 2019-02-18T19:19:11Z: rustc_codegen_ssa::base: codegen_instance(mem::size_of::<fmt::ArgumentV1>)
INFO 2019-02-18T19:19:11Z: rustc_codegen_ssa::base: codegen_instance(mem::size_of::<fmt::rt::v1::Argument>)
INFO 2019-02-18T19:19:11Z: rustc_codegen_ssa::base: codegen_instance(mem::size_of::<&str>)
INFO 2019-02-18T19:19:11Z: rustc_codegen_ssa::base: codegen_instance(mem::size_of::<u32>)
Post-codegen
Ty interner total ty region both
Adt : 7819 8.6%, 0.2% 0.0% 0.0%
Array : 1969 2.2%, 0.0% 0.0% 0.0%
Slice : 222 0.2%, 0.0% 0.0% 0.0%
RawPtr : 222 0.2%, 0.0% 0.0% 0.0%
Ref : 42210 46.3%, 0.1% 0.0% 0.0%
FnDef : 21176 23.2%, 0.0% 0.0% 0.0%
FnPtr : 8613 9.4%, 0.0% 0.0% 0.0%
Placeholder : 0 0.0%, 0.0% 0.0% 0.0%
Generator : 0 0.0%, 0.0% 0.0% 0.0%
GeneratorWitness : 0 0.0%, 0.0% 0.0% 0.0%
Dynamic : 253 0.3%, 0.0% 0.0% 0.0%
Closure : 1799 2.0%, 0.2% 0.0% 0.0%
Tuple : 2164 2.4%, 0.2% 0.0% 0.0%
Bound : 17 0.0%, 0.0% 0.0% 0.0%
Param : 240 0.3%, 0.0% 0.0% 0.0%
Infer : 16 0.0%, 0.0% 0.0% 0.0%
UnnormalizedProjection: 0 0.0%, 0.0% 0.0% 0.0%
Projection : 4429 4.9%, 0.0% 0.0% 0.0%
Opaque : 0 0.0%, 0.0% 0.0% 0.0%
Foreign : 1 0.0%, 0.0% 0.0% 0.0%
total 91150 0.8% 0.0% 0.0%
Substs interner: #65877
Region interner: #30211
Stability interner: #322
Allocation interner: #1060
Layout interner: #411
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: 641 symbols to preserve in this crate
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: going for that thin, thin LTO
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 0 - core.1v8m1ai7-cgu.15
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 1 - core.1v8m1ai7-cgu.0
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 2 - core.1v8m1ai7-cgu.2
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 3 - core.1v8m1ai7-cgu.5
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 4 - core.1v8m1ai7-cgu.1
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 5 - core.1v8m1ai7-cgu.6
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 6 - core.1v8m1ai7-cgu.7
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 7 - core.1v8m1ai7-cgu.14
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 8 - core.1v8m1ai7-cgu.3
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 9 - core.1v8m1ai7-cgu.9
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 10 - core.1v8m1ai7-cgu.8
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 11 - core.1v8m1ai7-cgu.11
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 12 - core.1v8m1ai7-cgu.12
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 13 - core.1v8m1ai7-cgu.4
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 14 - core.1v8m1ai7-cgu.13
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: local module: 15 - core.1v8m1ai7-cgu.10
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: thin LTO data created
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: thin LTO import map loaded
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: checking which modules can be-reused and which have to be re-optimized.
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.15: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.0: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.2: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.5: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.1: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.6: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.7: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.14: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.3: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.9: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.8: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.11: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.12: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.4: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.13: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: - core.1v8m1ai7-cgu.10: re-compiled
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: running thin lto passes over core.1v8m1ai7-cgu.11
INFO 2019-02-18T19:19:11Z: rustc_codegen_llvm::back::lto: running thin lto passes over core.1v8m1ai7-cgu.15
[2019-02-18T19:19:20Z INFO cargo::core::compiler::job_queue] end: core v0.0.0 (/home/seren/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libcore) => Target(lib)/Profile(release) => Target
[2019-02-18T19:19:20Z INFO cargo::util::rustc] updated rustc info cache
[2019-02-18T19:19:20Z DEBUG cargo] exit_with_error; err=CliError { error: Some(ProcessError { desc: "process didn\'t exit successfully: `rustc --crate-name core /home/seren/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libcore/lib.rs --color always --crate-type lib --emit=dep-info,link -C opt-level=3 -C panic=abort -C metadata=83dd25ed9bb01753 -C extra-filename=-83dd25ed9bb01753 --out-dir /tmp/xargo.Ts6CcVcYOJgB/target/dos/release/deps --target /home/seren/Code/Rust/dos/dos.json -L dependency=/tmp/xargo.Ts6CcVcYOJgB/target/dos/release/deps -L dependency=/tmp/xargo.Ts6CcVcYOJgB/target/release/deps` (signal: 11, SIGSEGV: invalid memory reference)", exit: Some(ExitStatus(ExitStatus(139))), output: None }
Could not compile `core`.), unknown: false, exit_code: 101 }
error: Could not compile `core`.
Caused by:
process didn't exit successfully: `rustc --crate-name core /home/seren/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/src/libcore/lib.rs --color always --crate-type lib --emit=dep-info,link -C opt-level=3 -C panic=abort -C metadata=83dd25ed9bb01753 -C extra-filename=-83dd25ed9bb01753 --out-dir /tmp/xargo.Ts6CcVcYOJgB/target/dos/release/deps --target /home/seren/Code/Rust/dos/dos.json -L dependency=/tmp/xargo.Ts6CcVcYOJgB/target/dos/release/deps -L dependency=/tmp/xargo.Ts6CcVcYOJgB/target/release/deps` (signal: 11, SIGSEGV: invalid memory reference)
error: `"cargo" "rustc" "-p" "alloc" "--release" "--manifest-path" "/tmp/xargo.Ts6CcVcYOJgB/Cargo.toml" "--target" "dos.json" "--" "-Z" "force-unstable-if-unmarked"` failed with exit code: Some(101)
note: run with `RUST_BACKTRACE=1` for a backtrace
``` | I-crash,A-LLVM,T-compiler,C-bug | low | Critical |
411,621,920 | flutter | Why is StreamSubscription( _subscription) not exposed in StreamBuilder | Reading the code for StreamBuilder:
https://github.com/flutter/flutter/blob/ef276ffea501a9f9ea4d627f9d069e52a31b75be/packages/flutter/lib/src/widgets/async.dart
Is there any reason for not exposing StreamSubscription(_subscription)?
It would be nice to use pause etc.
| c: new feature,framework,P2,team-framework,triaged-framework | low | Major |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.