id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
404,384,033 | godot | Unstable RigidBody when adding/applying forces/torque | **Godot version:**
3.0/3.1 Bullet physics engine (Godot internal doesn't even work)
**Issue description:**
Applying torque on a RigidBody leads into strange behavior, tested using Cylinder and Sphere collision shapes. The wheel (rigidbody) that I want to simulate rolls normally at first while trying to go threw the flat surface ground (big cube) which is strange enough, then it starts to jump and sometimes just snap in place and start to dance and never stops.
Here are two videos I recorded for the problem:
[Wheel alone](https://youtu.be/Y7Aq0qi46I4)
[A Vehicle with 4 wheels and Joints](https://youtu.be/K6MBtzQZ4gg)
**Steps to reproduce:**
Add a RigidBody with cylinder collision shape to the world with a flat static ground, then apply torque.
**Minimal reproduction project:**
[rigidbody_physics_bug.zip](https://github.com/godotengine/godot/files/2808588/rigidbody_physics_bug.zip)
| bug,confirmed,topic:physics | low | Critical |
404,418,489 | go | net: better documentation of UNIX sockets | The documentation on how to use the various net.Unix* features is rather thin. I don't mind reading man pages for the underlying system calls, but it's often unclear what the abstractions actually do in terms of those system calls. Some substantial examples would help, including ones that show how to pass a file descriptor from one process to another, and which combinations of read/write functions are appopriate for stream, datagram, and packet-oriented sockets. | ExpertNeeded,Documentation,NeedsFix | low | Minor |
404,481,828 | pytorch | The word "ints" is not rendered correclty in docs. | ## π Documentation
See attached image. "Tuple of ints" is rendered as "Tuple of python:ints" instead of "int" being converted into a cross-reference.
<img width="536" alt="image" src="https://user-images.githubusercontent.com/1893159/51939676-10053780-23de-11e9-80e2-7fa091ea4396.png">
<!-- A clear and concise description of what content in https://pytorch.org/docs is an issue. If this has to do with the general https://pytorch.org website, please file an issue at https://github.com/pytorch/pytorch.github.io/issues/new/choose instead. If this has to do with https://pytorch.org/tutorials, please file an issue at https://github.com/pytorch/tutorials/issues/new -->
cc @brianjo @mruberry | todo,module: docs,triaged | low | Minor |
404,489,042 | kubernetes | StatefulSetStatus CurrentRevision doesn't update with OnDelete update strategy | Note: This may be an enhancement request, but I'm writing it up as a bug since it took me by surprise given how Status was being updated for certain fields and not for others.
**What happened**: I have a statefulset with the `OnDelete` strategy and I deleted the pods, which successfully restarted with the correct, updated controller-revision-hash. However, the StatefulSetStatus was left with the old CurrentRevision, rather than be updated with the UpdatedRevision.
**What you expected to happen**: A `RollingUpdate` will complete with a call to the `completeRollingUpdate` func, which updates the Status:
https://github.com/kubernetes/kubernetes/blob/7f23a743e8c23ac6489340bbb34fa6f1d392db9d/pkg/controller/statefulset/stateful_set_utils.go#L375-L382
The StatefulSetStatus keeps track of the currentReplicas and updatedReplicas even when using the `OnDelete` update strategy, so wouldn't it make sense to call a status updater to update the CurrentRevision?
**How to reproduce it (as minimally and precisely as possible)**:
a) Create a statefulset with the `OnDelete` strategy
b) Delete the pods and wait for them to restart -- notice that the controller-revision-hash label is updated and note that the StatefulSetStatus keeps track of the updatedReplicas count
c) Notice that the StatefulSetStatus CurrentRevision does not get updated
**Environment**:
- Kubernetes version (use `kubectl version`):
Client Version: version.Info{Major:"1", Minor:"9", GitVersion:"v1.9.0", GitCommit:"925c127ec6b946659ad0fd596fa959be43f0cc05", GitTreeState:"clean", BuildDate:"2017-12-15T21:07:38Z", GoVersion:"go1.9.2", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"13", GitVersion:"v1.13.1", GitCommit:"eec55b9ba98609a46fee712359c7b5b365bdd920", GitTreeState:"clean", BuildDate:"2018-12-13T10:31:33Z", GoVersion:"go1.11.2", Compiler:"gc", Platform:"linux/amd64"} | kind/bug,sig/apps,needs-triage | medium | Critical |
404,521,747 | go | sizeof: new package with constants for Int, Uint, Uintptr, Int8, Float64, etc | See the tail of the (closed) proposal #5602. There I suggested that instead of making unsafe.Sizeof a safe thing, which it still kinda isn't in general, we solve 90% of the problem by add easy-to-use constants to a safe package, such as:
```
package reflect
const (
SizeofInt = <size on this machine>
SizeofUint = SizeofInt
SizeofBool = 1
SizeofFloat64 = 8
//...
)
```
These would be defined for primitive types only, not slices, maps, etc. You'd still need the unsafe package to handle them. | help wanted,Proposal,Proposal-Accepted,Proposal-Hold | high | Critical |
404,522,278 | kubernetes | predictable memory usage by reflector | **What would you like to be added**:
Predictable memory usage by reflector. I mean, the memory used by reflector does not have to be linear to the total number of objects in apiserver, since the list call can be paged, so I would expect the memory used should just be enough to handle a single page ideally.
**Why is this needed**:
Considering when a controller starts up, the reflector tries to list from apiserver, now if the initial data size is pretty huge(300+MB?), the memory used to decode objects could be huge, I can see that CoreDNS implements something that converts the object to a trimmed version with important fields only, but in my opinion, it does not help much during initialization phase, as the initial memory still has to be allocated, as a result, the application can consume more than 1G memory initially while it only needs 300MB(or less as what is done in CoreDNS) once the list is done. More generally, the question is: is there a possibility that we make sure the memory is bounded even during `list`phase? Maybe something like a shared memory for decoding(a single page at most?), and then trimmed it down for event handlers to consume? | sig/scalability,sig/api-machinery,kind/feature,priority/important-longterm,lifecycle/frozen | medium | Major |
404,525,878 | create-react-app | Discussing Advanced Configuration Options | I believe there's a great need for CRA to support advanced configuration. [React-app-rewired](https://github.com/timarney/react-app-rewired) was the first to let users patch their CRA configs. Then CRA changed (2.0+ and the merging of dev & prod builds). So... I made [Rescripts](https://github.com/harrysolovay/rescripts), which similarly patches react-scripts. These tools work... but they're subject to break whenever CRA changes. Not to mention, they operate via node's require cache and can lag (big time).
**I agree with everything that's been said about prioritizing simplicity for beginners.** Nevertheless, **there's a missed opportunity to provide better DX for experienced devs** (who should also be a priority). No experienced devs want to miss out on updates to react-scripts... but they also don't want to miss out on a lot of the beautiful tooling that hasn't made its way into CRA.
CRA isββfor manyββthe go-to starter (~1.75 million downloads this week alone according to react-scripts npm stats). I feel a little guilty as I ask this question (for what is surely the trillionth time maintainers have heard it), but why can't there be a built-in mechanismββthat isn't ejectionββfor overriding the config?
I'd be more than happy to build this into CRA as an optional back door for manipulating the Webpack config. Something simple, where users can define a function which takes in, operates on, and returns the config object. This way, there's no need to use a 3rd party patching tool, nor would there be a need to eject in most cases.
Beginner devs stay happy. Other devs become overjoyed. Thoughts? | issue: proposal | high | Critical |
404,589,478 | pytorch | Error with setting tensors to use cpu in packed_padded_sequence when CUDA tensor is set as default | ## π Bug
@ptrblck helped me diagnose the issue
<!-- A clear and concise description of what the bug is. -->
if Default tensors are set to gpu, setting length to cpu for pack_padded_sequence doesn't work
## To Reproduce
Steps to reproduce the behavior:
`import torch`
`torch.set_default_tensor_type(torch.cuda.FloatTensor)`
`lengths, _ = torch.sort(torch.randint(1, 100, (10,)), descending=True)`
`lengths = torch.as_tensor(lengths.cpu(), dtype=torch.int64)`
`lengths.type()`
this results in a torch.cuda.LongTensor instead of a torch.Longtensor
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
This is due to the following line in RNN.py"
[line](https://github.com/pytorch/pytorch/blob/21193bf12314f9d1be5ea36cbce3162c54b35225/torch/nn/utils/rnn.py#L195)
## Expected behavior
Expected behaviour will be to accept the move to cpu.
## Environment
PyTorch version: 1.0.0
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Ubuntu 18.04.1 LTS
GCC version: (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
CMake version: version 3.13.3
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: 9.1.85
GPU models and configuration: GPU 0: GeForce RTX 2080 Ti
Nvidia driver version: 410.79
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] Could not collect
[conda] blas 1.0 mkl
[conda] cuda100 1.0 0 pytorch
[conda] mkl 2019.1 144
[conda] mkl-service 1.1.2 py37he904b0f_5
[conda] mkl_fft 1.0.6 py37hd81dba3_0
[conda] mkl_random 1.0.2 py37hd81dba3_0
[conda] pytorch 1.0.0 py3.7_cuda10.0.130_cudnn7.4.1_1 [cuda100] pytorch
[conda] torchvision 0.2.1 py_2 pytorch
| module: rnn,module: cuda,triaged | medium | Critical |
404,598,280 | rust | error: undefined symbol: __chkstk in compiling UEFI application on ARM64 | Hi,
I'm creating a UEFI application on ARM64. My target .json file is as follows and it works well for a simple hello_world application.
```
{
"llvm-target": "aarch64-pc-windows-msvc",
"target-endian": "little",
"target-pointer-width": "64",
"target-c-int-width": "32",
"os": "uefi",
"arch": "aarch64",
"data-layout": "e-m:e-i64:64-f80:128-n8:16:32:64-S128",
"linker": "rust-lld",
"linker-flavor": "lld-link",
"pre-link-args": {
"lld-link": [
"/Subsystem:EFI_Application",
"/Entry:wenqiu_entry",
"/Machine:arm64"
]
},
"panic-strategy": "abort",
"default-hidden-visibility": true,
"executables": true,
"exe-suffix": ".efi",
"is-like-windows": true,
"emit-debug-gdb-scripts": false,
}
```
However, when I create a static Once object
`pub static MY_OBJECT: Once<MutexIrqSafe<MyStruct>> = Once::new();`
and initialize it with
`MY_OBJECT.call_once(|| {MutexIrqSafe::new( myobj ) });`,
an error occurs
` note: rust-lld: error: undefined symbol: __chkstk`
I found this link [https://github.com/rust-lang/rust/pull/56913](https://github.com/rust-lang/rust/pull/56913) and it says this error is caused by a large local variable. According to the corresponding commitment [0b00db](https://github.com/rust-lang/rust/commit/0b00dbedce3100b3c6504630896725035c12b1a7), I add
` "stack_probes": true,`
in the target.json file, but the problem is still there. The toolchain I use is nightly-2019-01-02.
Does anyone know how to solve the problem?
| A-linkage,O-AArch64 | low | Critical |
404,691,635 | pytorch | KeyError: 'No translator registered for layer: name: "res3b_relu_norm"\ntype: "Normalize"\nbottom: "res3b"\ntop: "res3b_relu_norm"\nnorm_param | It looks like "Normalize" op is not supported in 'caffe_translator.py' when i convert my model from caffe to caffe2.right? I just call the script directly from command line:
`python -m caffe2.python.caffe_translator deploy.prototxt pretrained.caffemodel`
Will you guys add this op to 'caffe_translator.py' in near future?
My environment:
- PyTorch Version : 1.0.0
- OS : Linux
- How you installed PyTorch (`conda`, `pip`, source): conda
- Python version: python3.7.1
- CUDA/cuDNN version: cuda-9.2 / cuDNN-7.2
- GPU models and configuration:Titan | caffe2 | low | Critical |
404,731,830 | flutter | Additional TextOverflow variants: middle, start | need an equivalent like an android: middle, start
https://developer.android.com/reference/android/widget/TextView#attr_android:ellipsize | c: new feature,framework,engine,a: typography,P2,team-engine,triaged-engine | low | Minor |
404,749,040 | go | x/tools/go/analysis: golang-x-tools doesn't build with gccgo (testsuite failures) | Trying to build golang-x-tools with gccgo from gcc-8 fails due to multiple testsuite failures:
<details>
<summary>build log</summary>
```
cd build && go test -vet=off -v -p 64 -test.short golang.org/x/tools/benchmark/parse golang.org/x/tools/blog golang.org/x/tools/blog/atom golang.org/x/tools/cmd/benchcmp golang.org/x/tools/cmd/bundle golang.org/x/tools/cmd/callgraph golang.org/x/tools/cmd/compilebench golang.org/x/tools/cmd/digraph golang.org/x/tools/cmd/eg golang.org/x/tools/cmd/fiximports golang.org/x/tools/cmd/getgo golang.org/x/tools/cmd/getgo/server golang.org/x/tools/cmd/go-contrib-init golang.org/x/tools/cmd/godex golang.org/x/tools/cmd/godoc golang.org/x/tools/cmd/goimports golang.org/x/tools/cmd/golsp golang.org/x/tools/cmd/gomvpkg golang.org/x/tools/cmd/gopls golang.org/x/tools/cmd/gopls/forward golang.org/x/tools/cmd/gorename golang.org/x/tools/cmd/gotype golang.org/x/tools/cmd/goyacc golang.org/x/tools/cmd/guru golang.org/x/tools/cmd/guru/serial golang.org/x/tools/cmd/html2article golang.org/x/tools/cmd/present golang.org/x/tools/cmd/splitdwarf golang.org/x/tools/cmd/splitdwarf/internal/macho golang.org/x/tools/cmd/ssadump golang.org/x/tools/cmd/stress golang.org/x/tools/cmd/stringer golang.org/x/tools/cmd/tip golang.org/x/tools/cmd/toolstash golang.org/x/tools/container/intsets golang.org/x/tools/cover golang.org/x/tools/go/analysis golang.org/x/tools/go/analysis/analysistest golang.org/x/tools/go/analysis/cmd/vet golang.org/x/tools/go/analysis/internal/analysisflags golang.org/x/tools/go/analysis/internal/checker golang.org/x/tools/go/analysis/internal/facts golang.org/x/tools/go/analysis/multichecker golang.org/x/tools/go/analysis/passes/asmdecl golang.org/x/tools/go/analysis/passes/assign golang.org/x/tools/go/analysis/passes/atomic golang.org/x/tools/go/analysis/passes/atomicalign golang.org/x/tools/go/analysis/passes/bools golang.org/x/tools/go/analysis/passes/buildssa golang.org/x/tools/go/analysis/passes/buildtag golang.org/x/tools/go/analysis/passes/cgocall golang.org/x/tools/go/analysis/passes/composite golang.org/x/tools/go/analysis/passes/copylock golang.org/x/tools/go/analysis/passes/ctrlflow golang.org/x/tools/go/analysis/passes/findcall golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall golang.org/x/tools/go/analysis/passes/httpresponse golang.org/x/tools/go/analysis/passes/inspect golang.org/x/tools/go/analysis/passes/internal/analysisutil golang.org/x/tools/go/analysis/passes/loopclosure golang.org/x/tools/go/analysis/passes/lostcancel golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel golang.org/x/tools/go/analysis/passes/nilfunc golang.org/x/tools/go/analysis/passes/nilness golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness golang.org/x/tools/go/analysis/passes/pkgfact golang.org/x/tools/go/analysis/passes/printf golang.org/x/tools/go/analysis/passes/shadow golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow golang.org/x/tools/go/analysis/passes/shift golang.org/x/tools/go/analysis/passes/stdmethods golang.org/x/tools/go/analysis/passes/structtag golang.org/x/tools/go/analysis/passes/tests golang.org/x/tools/go/analysis/passes/unmarshal golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal golang.org/x/tools/go/analysis/passes/unreachable golang.org/x/tools/go/analysis/passes/unsafeptr golang.org/x/tools/go/analysis/passes/unusedresult golang.org/x/tools/go/analysis/singlechecker golang.org/x/tools/go/analysis/unitchecker golang.org/x/tools/go/ast/astutil golang.org/x/tools/go/ast/inspector golang.org/x/tools/go/buildutil golang.org/x/tools/go/callgraph golang.org/x/tools/go/callgraph/cha golang.org/x/tools/go/callgraph/rta golang.org/x/tools/go/callgraph/static golang.org/x/tools/go/cfg golang.org/x/tools/go/expect golang.org/x/tools/go/gccgoexportdata golang.org/x/tools/go/gcexportdata golang.org/x/tools/go/internal/cgo golang.org/x/tools/go/internal/gccgoimporter golang.org/x/tools/go/internal/gcimporter golang.org/x/tools/go/internal/packagesdriver golang.org/x/tools/go/loader golang.org/x/tools/go/packages golang.org/x/tools/go/packages/gopackages golang.org/x/tools/go/packages/packagestest golang.org/x/tools/go/pointer golang.org/x/tools/go/ssa golang.org/x/tools/go/ssa/interp golang.org/x/tools/go/ssa/ssautil golang.org/x/tools/go/types/objectpath golang.org/x/tools/go/types/typeutil golang.org/x/tools/go/vcs golang.org/x/tools/godoc golang.org/x/tools/godoc/analysis golang.org/x/tools/godoc/dl golang.org/x/tools/godoc/env golang.org/x/tools/godoc/proxy golang.org/x/tools/godoc/redirect golang.org/x/tools/godoc/short golang.org/x/tools/godoc/util golang.org/x/tools/godoc/vfs golang.org/x/tools/godoc/vfs/gatefs golang.org/x/tools/godoc/vfs/httpfs golang.org/x/tools/godoc/vfs/mapfs golang.org/x/tools/godoc/vfs/zipfs golang.org/x/tools/imports golang.org/x/tools/internal/fastwalk golang.org/x/tools/internal/gopathwalk golang.org/x/tools/internal/jsonrpc2 golang.org/x/tools/internal/lsp golang.org/x/tools/internal/lsp/cache golang.org/x/tools/internal/lsp/cmd golang.org/x/tools/internal/lsp/protocol golang.org/x/tools/internal/lsp/source golang.org/x/tools/internal/module golang.org/x/tools/internal/semver golang.org/x/tools/internal/tool golang.org/x/tools/internal/txtar golang.org/x/tools/playground golang.org/x/tools/playground/socket golang.org/x/tools/present golang.org/x/tools/refactor/eg golang.org/x/tools/refactor/importgraph golang.org/x/tools/refactor/rename golang.org/x/tools/refactor/satisfy
=== RUN TestParseLine
--- PASS: TestParseLine (0.00s)
=== RUN TestParseSet
--- PASS: TestParseSet (0.00s)
PASS
ok golang.org/x/tools/benchmark/parse 0.292s
=== RUN TestLinkRewrite
--- PASS: TestLinkRewrite (0.00s)
PASS
ok golang.org/x/tools/blog 0.338s
? golang.org/x/tools/blog/atom [no test files]
=== RUN TestSelectBest
--- PASS: TestSelectBest (0.00s)
=== RUN TestDelta
--- PASS: TestDelta (0.00s)
=== RUN TestCorrelate
--- PASS: TestCorrelate (0.00s)
=== RUN TestBenchCmpSorting
--- PASS: TestBenchCmpSorting (0.00s)
PASS
ok golang.org/x/tools/cmd/benchcmp 0.285s
=== RUN TestBundle
--- PASS: TestBundle (0.00s)
PASS
ok golang.org/x/tools/cmd/bundle 0.408s
? golang.org/x/tools/cmd/callgraph [no test files]
? golang.org/x/tools/cmd/compilebench [no test files]
=== RUN TestDigraph
--- PASS: TestDigraph (0.00s)
=== RUN TestSplit
--- PASS: TestSplit (0.00s)
=== RUN TestQuotedLength
--- PASS: TestQuotedLength (0.00s)
PASS
ok golang.org/x/tools/cmd/digraph 0.309s
? golang.org/x/tools/cmd/eg [no test files]
=== RUN TestFixImports
--- PASS: TestFixImports (2.27s)
=== RUN TestDryRun
--- PASS: TestDryRun (0.47s)
PASS
ok golang.org/x/tools/cmd/fiximports 3.053s
main_test: Skipping integration tests with GOGET_INTEGRATION unset
ok golang.org/x/tools/cmd/getgo 0.087s
? golang.org/x/tools/cmd/getgo/server [no test files]
=== RUN TestExpandUser
--- PASS: TestExpandUser (0.00s)
PASS
ok golang.org/x/tools/cmd/go-contrib-init 0.291s
? golang.org/x/tools/cmd/godex [no test files]
=== RUN TestLiveServer
--- SKIP: TestLiveServer (0.00s)
regtest_test.go:30: regtest.host flag missing.
PASS
ok golang.org/x/tools/cmd/godoc 0.265s
? golang.org/x/tools/cmd/goimports [no test files]
? golang.org/x/tools/cmd/golsp [no test files]
? golang.org/x/tools/cmd/gomvpkg [no test files]
? golang.org/x/tools/cmd/gopls [no test files]
? golang.org/x/tools/cmd/gopls/forward [no test files]
? golang.org/x/tools/cmd/gorename [no test files]
? golang.org/x/tools/cmd/gotype [no test files]
? golang.org/x/tools/cmd/goyacc [no test files]
=== RUN TestIssue17515
--- PASS: TestIssue17515 (0.00s)
=== RUN TestGuru
--- SKIP: TestGuru (0.00s)
guru_test.go:234: skipping in short mode
=== RUN TestIssue14684
--- PASS: TestIssue14684 (0.00s)
PASS
ok golang.org/x/tools/cmd/guru 0.253s
? golang.org/x/tools/cmd/guru/serial [no test files]
? golang.org/x/tools/cmd/html2article [no test files]
? golang.org/x/tools/cmd/present [no test files]
? golang.org/x/tools/cmd/splitdwarf [no test files]
=== RUN TestOpen
--- PASS: TestOpen (0.00s)
=== RUN TestOpenFailure
--- PASS: TestOpenFailure (0.00s)
=== RUN TestOpenFat
--- PASS: TestOpenFat (0.00s)
=== RUN TestOpenFatFailure
--- PASS: TestOpenFatFailure (0.00s)
=== RUN TestRelocTypeString
--- PASS: TestRelocTypeString (0.00s)
=== RUN TestTypeString
--- PASS: TestTypeString (0.00s)
PASS
ok golang.org/x/tools/cmd/splitdwarf/internal/macho 0.520s
? golang.org/x/tools/cmd/ssadump [no test files]
? golang.org/x/tools/cmd/stress [no test files]
=== RUN TestGolden
--- PASS: TestGolden (0.00s)
=== RUN TestSplitIntoRuns
--- PASS: TestSplitIntoRuns (0.00s)
PASS
ok golang.org/x/tools/cmd/stringer 0.312s
=== RUN TestTipRedirects
--- PASS: TestTipRedirects (0.00s)
PASS
ok golang.org/x/tools/cmd/tip 0.313s
? golang.org/x/tools/cmd/toolstash [no test files]
=== RUN TestNLZ
--- PASS: TestNLZ (0.00s)
=== RUN TestPopcount
--- PASS: TestPopcount (0.06s)
=== RUN TestBasics
--- PASS: TestBasics (0.00s)
=== RUN TestMoreBasics
--- PASS: TestMoreBasics (0.00s)
=== RUN TestTakeMin
--- PASS: TestTakeMin (0.00s)
=== RUN TestMinAndMax
--- PASS: TestMinAndMax (0.00s)
=== RUN TestEquals
--- PASS: TestEquals (0.00s)
=== RUN TestRandomMutations
--- PASS: TestRandomMutations (0.00s)
=== RUN TestLowerBound
--- PASS: TestLowerBound (0.64s)
=== RUN TestSetOperations
--- PASS: TestSetOperations (0.09s)
=== RUN TestIntersectionWith
--- PASS: TestIntersectionWith (0.00s)
=== RUN TestIntersects
--- PASS: TestIntersects (0.01s)
=== RUN TestSubsetOf
--- PASS: TestSubsetOf (0.00s)
=== RUN TestBitString
--- PASS: TestBitString (0.00s)
=== RUN TestFailFastOnShallowCopy
--- SKIP: TestFailFastOnShallowCopy (0.00s)
sparse_test.go:581: Test disabled on gccgo.
PASS
ok golang.org/x/tools/container/intsets 1.153s
? golang.org/x/tools/cover [no test files]
? golang.org/x/tools/go/analysis [no test files]
=== RUN TestTheTest
--- PASS: TestTheTest (0.15s)
PASS
ok golang.org/x/tools/go/analysis/analysistest 0.492s
? golang.org/x/tools/go/analysis/cmd/vet [no test files]
=== RUN TestExec
--- PASS: TestExec (1.61s)
PASS
ok golang.org/x/tools/go/analysis/internal/analysisflags 2.006s
? golang.org/x/tools/go/analysis/internal/checker [no test files]
=== RUN TestEncodeDecode
--- PASS: TestEncodeDecode (1.53s)
facts_test.go:101: decode a facts = {}
facts_test.go:101: decode b facts = {type a.A int: myFact(a.A), type a.T int: myFact(a.T)}
facts_test.go:101: decode c facts = {type b.B chan a2.A2: myFact(b.B), type b.F func() a.T: myFact(b.F)}
PASS
ok golang.org/x/tools/go/analysis/internal/facts 1.946s
? golang.org/x/tools/go/analysis/multichecker [no test files]
2019/01/30 13:25:54 unknown architecture wasm
=== RUN Test
--- PASS: Test (0.43s)
PASS
ok golang.org/x/tools/go/analysis/passes/asmdecl 0.836s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/assign/testdata/src/a/a.go:9:8: could not import math/rand (invalid package name: "")
--- FAIL: Test (0.16s)
analysistest.go:110: error analyzing assign@a: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/assign 0.495s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/atomic/testdata/src/a/a.go:10:2: could not import sync/atomic (invalid package name: "")
--- PASS: Test (0.42s)
PASS
ok golang.org/x/tools/go/analysis/passes/atomic 0.780s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/atomicalign/testdata/src/b/b.go:10:2: could not import sync/atomic (invalid package name: "")
--- FAIL: Test (0.62s)
analysistest.go:110: error analyzing atomicalign@b: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/atomicalign 1.060s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/bools/testdata/src/a/a.go:9:8: could not import io (invalid package name: "")
--- FAIL: Test (0.38s)
analysistest.go:110: error analyzing bools@a: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/bools 0.750s
=== RUN Test
--- PASS: Test (0.53s)
PASS
ok golang.org/x/tools/go/analysis/passes/buildssa 0.959s
=== RUN Test
--- PASS: Test (0.31s)
PASS
ok golang.org/x/tools/go/analysis/passes/buildtag 0.657s
=== RUN Test
/tmp/gopackages227435845/a/_cgo_gotypes.go:7:10: could not import runtime/cgo (missing package: "runtime/cgo")
/tmp/gopackages227435845/a/_cgo_gotypes.go:9:8: could not import syscall (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/cgocall/testdata/src/b/b.go:10:10: could not import fmt (invalid package name: "")
--- PASS: Test (0.93s)
PASS
ok golang.org/x/tools/go/analysis/passes/cgocall 1.277s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/composite/testdata/src/a/a.go:10:2: could not import flag (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/composite/testdata/src/a/a.go:11:2: could not import go/scanner (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/composite/testdata/src/a/a.go:12:2: could not import go/token (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/composite/testdata/src/a/a.go:13:2: could not import image (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/composite/testdata/src/a/a.go:14:2: could not import unicode (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/composite/testdata/src/a/a.go:87:2: missing type in composite literal
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/composite/testdata/src/a/a.go:91:2: missing type in composite literal
--- FAIL: Test (0.67s)
analysistest.go:311: a/a.go:100: no diagnostic was reported matching "unkeyed fields"
analysistest.go:311: a/a.go:119: no diagnostic was reported matching "unkeyed fields"
analysistest.go:311: a/a.go:120: no diagnostic was reported matching "unkeyed fields"
analysistest.go:311: a/a.go:76: no diagnostic was reported matching "unkeyed fields"
analysistest.go:311: a/a.go:91: no diagnostic was reported matching "unkeyed fields"
analysistest.go:311: a/a.go:92: no diagnostic was reported matching "unkeyed fields"
FAIL
FAIL golang.org/x/tools/go/analysis/passes/composite 1.102s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:4:2: could not import sync (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:5:2: could not import sync/atomic (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:12:6: OkFunc redeclared in this block
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:11:6: other declaration of OkFunc
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:13:6: BadFunc redeclared in this block
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:43:6: other declaration of BadFunc
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:30:6: OkFunc redeclared in this block
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:11:6: other declaration of OkFunc
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:31:6: BadFunc redeclared in this block
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:43:6: other declaration of BadFunc
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:32:6: OkRet redeclared in this block
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:15:6: other declaration of OkRet
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:33:6: BadRet redeclared in this block
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:16:6: other declaration of BadRet
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:41:6: OkFunc redeclared in this block
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:11:6: other declaration of OkFunc
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:42:6: BadFunc redeclared in this block
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:43:6: other declaration of BadFunc
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:13:2: p declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:17:6: z declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:18:2: w declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:21:2: q declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:25:2: yy declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:32:2: nl declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:33:2: mx declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:34:2: xx declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:56:4: no new variables on left side of :=
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:45:2: p declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:57:6: z declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:59:2: w declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:62:6: q declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:66:2: yy declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:79:2: muSlice declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:85:2: mmuSlice declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:91:2: fmuSlice declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:96:2: aLen declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:97:2: aCap declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:110:2: unsafe.Sizeof(mu) (invalid operand) is not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:111:2: unsafe1.Sizeof(mu) (invalid operand) is not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:112:2: Sizeof(mu) (invalid operand) is not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:123:6: rwmuXX declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:124:2: rwmuX1 declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:125:2: rwmuY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:127:6: rwmuYY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:128:2: rwmuP declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:129:2: rwmuZ declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:133:6: condXX declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:134:2: condX1 declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:135:2: condY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:137:6: condYY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:138:2: condP declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:139:2: condZ declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:146:6: wgXX declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:147:2: wgX1 declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:148:2: wgY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:150:6: wgYY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:151:2: wgP declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:152:2: wgZ declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:156:6: poolXX declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:157:2: poolX1 declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:158:2: poolY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:160:6: poolYY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:161:2: poolP declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:162:2: poolZ declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:166:6: onceXX declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:167:2: onceX1 declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:168:2: onceY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:170:6: onceYY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:171:2: onceP declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:172:2: onceZ declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:179:6: vXX declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:180:2: vX1 declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:183:2: vY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:185:6: vYY declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:186:2: vP declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock.go:187:2: vZ declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:15:27: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:16:27: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:32:35: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:33:35: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:66:41: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:93:19: t (variable of type struct{lock invalid type}) is not a type
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:117:7: undeclared name: EmbeddedRwMutex
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:119:7: undeclared name: OKRet
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_func.go:117:2: x declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:13:6: mu declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:14:6: i declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:21:6: i declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:25:6: i declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:29:9: m declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:33:6: i declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:33:9: m declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:37:9: m declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:41:6: k declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:45:6: k declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:49:9: v declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/copylock/testdata/src/a/copylock_range.go:57:6: v declared but not used
--- FAIL: Test (0.45s)
analysistest.go:311: a/copylock.go:102: no diagnostic was reported matching "call of len copies lock value: sync.Mutex"
analysistest.go:311: a/copylock.go:105: no diagnostic was reported matching "call of cap copies lock value: sync.Mutex"
analysistest.go:311: a/copylock.go:114: no diagnostic was reported matching "call of unsafe.Sizeof copies lock value: sync.Mutex"
analysistest.go:311: a/copylock.go:116: no diagnostic was reported matching "call of Sizeof copies lock value: sync.Mutex"
analysistest.go:311: a/copylock.go:125: no diagnostic was reported matching "assignment copies lock value to rwmuY: sync.RWMutex"
analysistest.go:311: a/copylock.go:126: no diagnostic was reported matching "assignment copies lock value to rwmuY: sync.RWMutex"
analysistest.go:311: a/copylock.go:127: no diagnostic was reported matching "variable declaration copies lock value to rwmuYY: sync.RWMutex"
analysistest.go:311: a/copylock.go:135: no diagnostic was reported matching "assignment copies lock value to condY: sync.Cond contains sync.noCopy"
analysistest.go:311: a/copylock.go:136: no diagnostic was reported matching "assignment copies lock value to condY: sync.Cond contains sync.noCopy"
analysistest.go:311: a/copylock.go:137: no diagnostic was reported matching "variable declaration copies lock value to condYY: sync.Cond contains sync.noCopy"
analysistest.go:311: a/copylock.go:148: no diagnostic was reported matching "assignment copies lock value to wgY: sync.WaitGroup contains sync.noCopy"
analysistest.go:311: a/copylock.go:149: no diagnostic was reported matching "assignment copies lock value to wgY: sync.WaitGroup contains sync.noCopy"
analysistest.go:311: a/copylock.go:150: no diagnostic was reported matching "variable declaration copies lock value to wgYY: sync.WaitGroup contains sync.noCopy"
analysistest.go:311: a/copylock.go:158: no diagnostic was reported matching "assignment copies lock value to poolY: sync.Pool contains sync.noCopy"
analysistest.go:311: a/copylock.go:159: no diagnostic was reported matching "assignment copies lock value to poolY: sync.Pool contains sync.noCopy"
analysistest.go:311: a/copylock.go:160: no diagnostic was reported matching "variable declaration copies lock value to poolYY: sync.Pool contains sync.noCopy"
analysistest.go:311: a/copylock.go:168: no diagnostic was reported matching "assignment copies lock value to onceY: sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:169: no diagnostic was reported matching "assignment copies lock value to onceY: sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:170: no diagnostic was reported matching "variable declaration copies lock value to onceYY: sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:48: no diagnostic was reported matching "assignment copies lock value to \\*p: sync.Mutex"
analysistest.go:311: a/copylock.go:53: no diagnostic was reported matching "assignment copies lock value to \\*tp: a.Tlock contains sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:54: no diagnostic was reported matching "assignment copies lock value to t: a.Tlock contains sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:56: no diagnostic was reported matching "assignment copies lock value to y: sync.Mutex"
analysistest.go:311: a/copylock.go:57: no diagnostic was reported matching "variable declaration copies lock value to z: a.Tlock contains sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:60: no diagnostic was reported matching "literal copies lock value from \\*x: sync.Mutex"
analysistest.go:311: a/copylock.go:63: no diagnostic was reported matching "literal copies lock value from t: a.Tlock contains sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:64: no diagnostic was reported matching "literal copies lock value from \\*tp: a.Tlock contains sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:67: no diagnostic was reported matching "literal copies lock value from t: a.Tlock contains sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:68: no diagnostic was reported matching "literal copies lock value from \\*tp: a.Tlock contains sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:73: no diagnostic was reported matching "call of new copies lock value: a.Tlock contains sync.Once contains sync.Mutex"
analysistest.go:311: a/copylock.go:77: no diagnostic was reported matching "assignment copies lock value to muB: sync.Mutex"
analysistest.go:311: a/copylock.go:78: no diagnostic was reported matching "assignment copies lock value to muA: sync.Mutex"
analysistest.go:311: a/copylock.go:83: no diagnostic was reported matching "assignment copies lock value to mmuB: sync.Mutex"
analysistest.go:311: a/copylock.go:84: no diagnostic was reported matching "assignment copies lock value to mmuA: sync.Mutex"
analysistest.go:311: a/copylock_func.go:108: no diagnostic was reported matching "return copies lock value: sync.Mutex"
analysistest.go:311: a/copylock_func.go:110: no diagnostic was reported matching "return copies lock value: struct.lock sync.Mutex. contains sync.Mutex"
analysistest.go:311: a/copylock_func.go:129: no diagnostic was reported matching "Bad passes lock by value: a.LocalOnce contains sync.Mutex"
analysistest.go:311: a/copylock_func.go:13: no diagnostic was reported matching "BadFunc passes lock by value: sync.Mutex"
analysistest.go:311: a/copylock_func.go:14: no diagnostic was reported matching "BadFunc2 passes lock by value: sync.Map contains sync.Mutex"
analysistest.go:311: a/copylock_func.go:20: no diagnostic was reported matching "func passes lock by value: sync.Mutex"
analysistest.go:311: a/copylock_func.go:21: no diagnostic was reported matching "func passes lock by value: sync.Map contains sync.Mutex"
analysistest.go:311: a/copylock_func.go:29: no diagnostic was reported matching "BadMeth passes lock by value: a.EmbeddedRWMutex"
analysistest.go:311: a/copylock_func.go:31: no diagnostic was reported matching "BadFunc passes lock by value: a.EmbeddedRWMutex"
analysistest.go:311: a/copylock_func.go:40: no diagnostic was reported matching "BadMeth passes lock by value: a.FieldMutex contains sync.Mutex"
analysistest.go:311: a/copylock_func.go:42: no diagnostic was reported matching "BadFunc passes lock by value: a.FieldMutex contains sync.Mutex"
analysistest.go:311: a/copylock_func.go:57: no diagnostic was reported matching "Bad passes lock by value: a.L0 contains a.L1 contains a.L2"
analysistest.go:311: a/copylock_func.go:91: no diagnostic was reported matching "call of f copies lock value: sync.Mutex"
analysistest.go:311: a/copylock_func.go:92: no diagnostic was reported matching "call of f copies lock value: struct.lock sync.Mutex. contains sync.Mutex"
analysistest.go:311: a/copylock_func.go:94: no diagnostic was reported matching "call of fntab.0. copies lock value: struct.lock sync.Mutex. contains sync.Mutex"
analysistest.go:311: a/copylock_range.go:27: no diagnostic was reported matching "range var mu copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:29: no diagnostic was reported matching "range var m copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:31: no diagnostic was reported matching "range var mu copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:33: no diagnostic was reported matching "range var m copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:37: no diagnostic was reported matching "range var m copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:41: no diagnostic was reported matching "range var k copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:43: no diagnostic was reported matching "range var mu copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:45: no diagnostic was reported matching "range var k copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:47: no diagnostic was reported matching "range var mu copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:49: no diagnostic was reported matching "range var v copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:55: no diagnostic was reported matching "range var mu copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:57: no diagnostic was reported matching "range var v copies lock: sync.Mutex"
analysistest.go:311: a/copylock_range.go:65: no diagnostic was reported matching "range var t.mu copies lock: sync.Mutex"
FAIL
FAIL golang.org/x/tools/go/analysis/passes/copylock 0.780s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/ctrlflow/testdata/src/a/a.go:6:2: could not import log (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/ctrlflow/testdata/src/a/a.go:7:2: could not import os (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/ctrlflow/testdata/src/a/a.go:8:2: could not import runtime (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/ctrlflow/testdata/src/a/a.go:9:2: could not import syscall (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/ctrlflow/testdata/src/a/a.go:10:2: could not import testing (invalid package name: "")
--- FAIL: Test (0.40s)
analysistest.go:110: error analyzing ctrlflow@a: analysis skipped due to errors in package
panic: interface conversion: interface is nil, not * golang_org_x_tools_go_analysis_passes_ctrlflow ctrlflow.CFGs [recovered]
panic: interface conversion: interface is nil, not * golang_org_x_tools_go_analysis_passes_ctrlflow ctrlflow.CFGs
goroutine 20 [running]:
panic
../../../src/libgo/go/runtime/panic.go:554
testing.tRunner..func1
../../../src/libgo/go/testing/testing.go:728
panic
../../../src/libgo/go/runtime/panic.go:495
golang_org_x_tools_go_analysis_passes_ctrlflow_test.Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/ctrlflow/ctrlflow_test.go:24
testing.tRunner
../../../src/libgo/go/testing/testing.go:777
created by testing.T.Run
../../../src/libgo/go/testing/testing.go:824 +989
FAIL golang.org/x/tools/go/analysis/passes/ctrlflow 0.714s
=== RUN TestFromStringLiterals
=== RUN TestFromStringLiterals/SimpleTest
--- PASS: TestFromStringLiterals (0.72s)
--- PASS: TestFromStringLiterals/SimpleTest (0.72s)
=== RUN TestFromFileSystem
--- PASS: TestFromFileSystem (0.36s)
PASS
ok golang.org/x/tools/go/analysis/passes/findcall 1.511s
? golang.org/x/tools/go/analysis/passes/findcall/cmd/findcall [no test files]
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/httpresponse/testdata/src/a/a.go:4:2: could not import log (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/httpresponse/testdata/src/a/a.go:5:2: could not import net/http (invalid package name: "")
--- FAIL: Test (0.73s)
analysistest.go:110: error analyzing httpresponse@a: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/httpresponse 1.230s
? golang.org/x/tools/go/analysis/passes/inspect [no test files]
? golang.org/x/tools/go/analysis/passes/internal/analysisutil [no test files]
=== RUN Test
--- PASS: Test (0.09s)
PASS
ok golang.org/x/tools/go/analysis/passes/loopclosure 0.504s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/lostcancel/testdata/src/a/a.go:8:2: could not import context (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/lostcancel/testdata/src/a/a.go:9:2: could not import log (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/lostcancel/testdata/src/a/a.go:10:2: could not import os (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/lostcancel/testdata/src/a/a.go:11:2: could not import testing (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/lostcancel/testdata/src/a/a.go:12:2: could not import time (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/lostcancel/testdata/src/b/b.go:7:8: could not import context (invalid package name: "")
--- FAIL: Test (0.90s)
analysistest.go:110: error analyzing <nil>: failed prerequisites: ctrlflow@a
analysistest.go:110: error analyzing <nil>: failed prerequisites: ctrlflow@b
FAIL
FAIL golang.org/x/tools/go/analysis/passes/lostcancel 1.202s
? golang.org/x/tools/go/analysis/passes/lostcancel/cmd/lostcancel [no test files]
=== RUN Test
--- PASS: Test (0.36s)
PASS
ok golang.org/x/tools/go/analysis/passes/nilfunc 0.786s
=== RUN Test
--- PASS: Test (0.31s)
PASS
ok golang.org/x/tools/go/analysis/passes/nilness 0.696s
? golang.org/x/tools/go/analysis/passes/nilness/cmd/nilness [no test files]
=== RUN Test
--- PASS: Test (0.34s)
PASS
ok golang.org/x/tools/go/analysis/passes/pkgfact 0.732s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/b/b.go:3:8: could not import fmt (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:10:2: could not import fmt (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:11:9: could not import log (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:12:2: could not import math (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:13:2: could not import os (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:14:2: could not import testing (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:217:2: invalid operation: et1 (variable of type *invalid type) has no field or method Error
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:218:2: invalid operation: et1 (variable of type *invalid type) has no field or method Error
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:219:2: invalid operation: et1 (variable of type *invalid type) has no field or method Error
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:220:2: invalid operation: et1 (variable of type *invalid type) has no field or method Errorf
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:246:2: invalid operation: t (variable of type *invalid type) has no field or method Log
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:247:2: invalid operation: t (variable of type *invalid type) has no field or method Logf
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:248:2: invalid operation: t (variable of type *invalid type) has no field or method Logf
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:312:2: invalid operation: l (variable of type *invalid type) has no field or method Fatal
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:313:2: invalid operation: l (variable of type *invalid type) has no field or method Fatalf
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:314:2: invalid operation: l (variable of type *invalid type) has no field or method Fatalln
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:315:2: invalid operation: l (variable of type *invalid type) has no field or method Panic
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:316:2: invalid operation: l (variable of type *invalid type) has no field or method Panicf
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:317:2: invalid operation: l (variable of type *invalid type) has no field or method Panicln
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:318:2: invalid operation: l (variable of type *invalid type) has no field or method Print
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:319:2: invalid operation: l (variable of type *invalid type) has no field or method Printf
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/printf/testdata/src/a/a.go:320:2: invalid operation: l (variable of type *invalid type) has no field or method Println
--- FAIL: Test (0.18s)
analysistest.go:110: error analyzing <nil>: failed prerequisites: printf@b
analysistest.go:110: error analyzing printf@b: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/printf 0.613s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/shadow/testdata/src/a/a.go:11:8: could not import os (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/shadow/testdata/src/a/a.go:20:13: invalid operation: f (variable of type *invalid type) has no field or method Read
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/shadow/testdata/src/a/a.go:29:16: invalid operation: f (variable of type *invalid type) has no field or method Read
--- FAIL: Test (0.43s)
analysistest.go:110: error analyzing shadow@a: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/shadow 0.775s
? golang.org/x/tools/go/analysis/passes/shadow/cmd/shadow [no test files]
=== RUN Test
--- PASS: Test (0.29s)
PASS
ok golang.org/x/tools/go/analysis/passes/shift 0.658s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/stdmethods/testdata/src/a/a.go:8:2: could not import encoding/xml (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/stdmethods/testdata/src/a/a.go:9:2: could not import fmt (invalid package name: "")
--- FAIL: Test (0.42s)
analysistest.go:110: error analyzing stdmethods@a: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/stdmethods 0.816s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/structtag/testdata/src/a/a.go:11:2: could not import encoding/xml (invalid package name: "")
--- PASS: Test (0.33s)
PASS
ok golang.org/x/tools/go/analysis/passes/structtag 0.719s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/tests/testdata/src/a/a_test.go:4:2: could not import testing (invalid package name: "")
/tmp/gopackages655062445/a/testmain-go:6:2: could not import os (invalid package name: "")
/tmp/gopackages655062445/a/testmain-go:8:2: could not import testing (invalid package name: "")
/tmp/gopackages655062445/a/testmain-go:9:2: could not import testing/internal/testdeps (invalid package name: "")
/tmp/gopackages655062445/divergent/testmain-go:6:2: could not import os (invalid package name: "")
/tmp/gopackages655062445/divergent/testmain-go:8:2: could not import testing (invalid package name: "")
/tmp/gopackages655062445/divergent/testmain-go:9:2: could not import testing/internal/testdeps (invalid package name: "")
--- FAIL: Test (0.29s)
analysistest.go:110: error analyzing tests@a: analysis skipped due to errors in package
analysistest.go:110: error analyzing tests@a_test: analysis skipped due to errors in package
analysistest.go:110: error analyzing [email protected]: analysis skipped due to errors in package
analysistest.go:110: error analyzing [email protected]: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/tests 0.701s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unmarshal/testdata/src/a/a.go:10:2: could not import encoding/gob (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unmarshal/testdata/src/a/a.go:11:2: could not import encoding/json (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unmarshal/testdata/src/a/a.go:12:2: could not import encoding/xml (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unmarshal/testdata/src/a/a.go:13:2: could not import io (invalid package name: "")
--- FAIL: Test (0.65s)
analysistest.go:110: error analyzing unmarshal@a: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/unmarshal 1.089s
? golang.org/x/tools/go/analysis/passes/unmarshal/cmd/unmarshal [no test files]
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1071:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1075:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1081:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1088:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1094:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1102:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1111:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1119:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1129:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1138:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1153:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1161:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1168:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1176:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1183:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1192:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1202:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1211:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1220:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1230:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1239:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1249:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1260:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1275:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1288:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1296:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1299:1: label L declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1309:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1316:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1325:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1353:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1361:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1370:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1380:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1387:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1396:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1406:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1413:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1422:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1432:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1438:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1448:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1458:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1469:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1480:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1495:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1509:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1522:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1534:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1543:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1557:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1569:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1578:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1589:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1602:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1616:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1629:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1642:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1654:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1667:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1679:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1691:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1703:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1710:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1722:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1734:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1746:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1756:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1770:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1783:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1798:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1811:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1823:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1836:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1848:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1855:3: fallthrough statement out of place
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1860:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1867:3: fallthrough statement out of place
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1872:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1879:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1891:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1903:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1910:3: fallthrough statement out of place
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1915:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1925:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1939:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1952:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1967:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1974:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1979:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1985:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1990:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1997:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2004:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2011:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2019:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2027:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2034:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2041:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2048:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2056:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2063:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2072:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2082:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2091:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2100:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2110:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2119:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2123:2: invalid AST: branch statement: goto
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:18:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:22:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:28:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:35:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:41:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:49:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:58:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:66:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:76:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:85:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:100:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:108:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:115:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:123:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:130:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:139:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:149:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:158:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:167:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:177:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:186:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:196:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:207:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:222:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:235:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:243:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:246:1: label L declared but not used
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:256:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:263:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:272:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:300:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:308:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:317:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:327:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:334:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:343:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:353:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:360:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:369:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:379:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:385:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:395:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:405:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:416:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:427:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:442:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:456:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:469:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:481:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:490:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:504:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:516:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:525:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:536:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:549:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:563:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:576:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:589:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:601:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:614:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:626:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:638:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:650:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:657:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:669:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:681:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:693:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:703:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:717:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:730:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:745:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:758:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:770:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:783:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:795:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:802:3: fallthrough statement out of place
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:807:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:814:3: fallthrough statement out of place
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:819:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:826:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:838:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:850:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:857:3: fallthrough statement out of place
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:862:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:872:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:886:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:899:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:914:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:921:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:926:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:932:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:937:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:944:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:951:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:958:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:966:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:974:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:981:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:988:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:995:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1003:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1010:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1019:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1029:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1038:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1047:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1057:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:1066:1: missing return
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2129:7: cannot convert 1 (untyped int constant) to bool
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unreachable/testdata/src/a/a.go:2133:1: missing return
--- PASS: Test (0.43s)
PASS
ok golang.org/x/tools/go/analysis/passes/unreachable 0.867s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unsafeptr/testdata/src/a/a.go:8:2: could not import reflect (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unsafeptr/testdata/src/a/a.go:33:21: invalid operation: s1 (variable of type *invalid type) has no field or method Data
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unsafeptr/testdata/src/a/a.go:35:21: invalid operation: s2 (variable of type *invalid type) has no field or method Data
--- FAIL: Test (0.36s)
analysistest.go:110: error analyzing unsafeptr@a: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/unsafeptr 0.951s
=== RUN Test
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unusedresult/testdata/src/a/a.go:8:2: could not import bytes (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unusedresult/testdata/src/a/a.go:9:2: could not import errors (invalid package name: "")
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/analysis/passes/unusedresult/testdata/src/a/a.go:10:2: could not import fmt (invalid package name: "")
--- FAIL: Test (0.14s)
analysistest.go:110: error analyzing unusedresult@a: analysis skipped due to errors in package
FAIL
FAIL golang.org/x/tools/go/analysis/passes/unusedresult 0.582s
? golang.org/x/tools/go/analysis/singlechecker [no test files]
? golang.org/x/tools/go/analysis/unitchecker [no test files]
=== RUN TestAddImport
--- PASS: TestAddImport (0.02s)
=== RUN TestDoubleAddImport
--- PASS: TestDoubleAddImport (0.00s)
=== RUN TestDoubleAddNamedImport
--- PASS: TestDoubleAddNamedImport (0.00s)
=== RUN TestDoubleAddImportWithDeclComment
--- PASS: TestDoubleAddImportWithDeclComment (0.00s)
=== RUN TestDeleteImport
--- PASS: TestDeleteImport (0.02s)
=== RUN TestRewriteImport
--- PASS: TestRewriteImport (0.00s)
=== RUN TestImports
--- PASS: TestImports (0.00s)
=== RUN TestUsesImport
--- PASS: TestUsesImport (0.00s)
=== RUN TestPathEnclosingInterval_Exact
--- PASS: TestPathEnclosingInterval_Exact (0.00s)
=== RUN TestPathEnclosingInterval_Paths
--- PASS: TestPathEnclosingInterval_Paths (0.00s)
=== RUN TestRewrite
=== RUN TestRewrite/*
=== RUN TestRewrite/*/nop
=== PAUSE TestRewrite/*/nop
=== RUN TestRewrite/*/replace
=== PAUSE TestRewrite/*/replace
=== RUN TestRewrite/*/set_doc_strings
=== PAUSE TestRewrite/*/set_doc_strings
=== RUN TestRewrite/*/insert_names
=== PAUSE TestRewrite/*/insert_names
=== RUN TestRewrite/*/insert
=== PAUSE TestRewrite/*/insert
=== RUN TestRewrite/*/delete
=== PAUSE TestRewrite/*/delete
=== RUN TestRewrite/*/insertafter-delete
=== PAUSE TestRewrite/*/insertafter-delete
=== RUN TestRewrite/*/delete-insertafter
=== PAUSE TestRewrite/*/delete-insertafter
=== CONT TestRewrite/*/nop
=== CONT TestRewrite/*/insert
=== CONT TestRewrite/*/replace
=== CONT TestRewrite/*/set_doc_strings
=== CONT TestRewrite/*/insert_names
=== CONT TestRewrite/*/insertafter-delete
=== CONT TestRewrite/*/delete-insertafter
=== CONT TestRewrite/*/delete
--- PASS: TestRewrite (0.00s)
--- PASS: TestRewrite/* (0.00s)
--- PASS: TestRewrite/*/nop (0.00s)
--- PASS: TestRewrite/*/replace (0.00s)
--- PASS: TestRewrite/*/insert (0.00s)
--- PASS: TestRewrite/*/set_doc_strings (0.00s)
--- PASS: TestRewrite/*/insert_names (0.00s)
--- PASS: TestRewrite/*/insertafter-delete (0.00s)
--- PASS: TestRewrite/*/delete-insertafter (0.00s)
--- PASS: TestRewrite/*/delete (0.00s)
PASS
ok golang.org/x/tools/go/ast/astutil 0.490s
=== RUN TestInspectAllNodes
--- PASS: TestInspectAllNodes (0.00s)
=== RUN TestInspectPruning
--- PASS: TestInspectPruning (0.00s)
=== RUN TestTypeFiltering
--- PASS: TestTypeFiltering (0.00s)
PASS
ok golang.org/x/tools/go/ast/inspector 0.263s
=== RUN TestAllPackages
--- SKIP: TestAllPackages (0.00s)
allpackages_test.go:23: gccgo has no standard packages
=== RUN TestExpandPatterns
--- PASS: TestExpandPatterns (0.00s)
=== RUN TestParseOverlayArchive
--- PASS: TestParseOverlayArchive (0.00s)
=== RUN TestOverlay
--- PASS: TestOverlay (0.00s)
=== RUN TestTags
--- PASS: TestTags (0.00s)
PASS
ok golang.org/x/tools/go/buildutil 0.396s
? golang.org/x/tools/go/callgraph [no test files]
=== RUN TestCHA
--- PASS: TestCHA (0.00s)
PASS
ok golang.org/x/tools/go/callgraph/cha 0.413s
=== RUN TestRTA
--- PASS: TestRTA (0.00s)
PASS
ok golang.org/x/tools/go/callgraph/rta 0.398s
=== RUN TestStatic
--- PASS: TestStatic (0.00s)
PASS
ok golang.org/x/tools/go/callgraph/static 0.404s
=== RUN TestDeadCode
--- PASS: TestDeadCode (0.00s)
PASS
ok golang.org/x/tools/go/cfg 0.361s
=== RUN TestMarker
--- PASS: TestMarker (0.00s)
PASS
ok golang.org/x/tools/go/expect 0.281s
=== RUN Test
--- PASS: Test (0.00s)
gccgoexportdata_test.go:36: filename = testdata/errors.gox
gccgoexportdata_test.go:36: filename = testdata/short.a
gccgoexportdata_test.go:36: filename = testdata/long.a
PASS
ok golang.org/x/tools/go/gccgoexportdata 0.446s
=== RUN TestAppEngine16
--- PASS: TestAppEngine16 (0.00s)
PASS
ok golang.org/x/tools/go/gcexportdata 0.436s
? golang.org/x/tools/go/internal/cgo [no test files]
=== RUN TestInstallationImporter
--- SKIP: TestInstallationImporter (0.00s)
gccgoinstallation_test.go:157: This test needs gccgo
=== RUN TestGoxImporter
--- PASS: TestGoxImporter (0.01s)
=== RUN TestObjImporter
--- SKIP: TestObjImporter (0.00s)
importer_test.go:130: This test needs gccgo
=== RUN TestTypeParser
--- PASS: TestTypeParser (0.00s)
PASS
ok golang.org/x/tools/go/internal/gccgoimporter 0.453s
=== RUN TestImportTestdata
--- SKIP: TestImportTestdata (0.00s)
gcimporter_test.go:155: gc-built packages not available (compiler = gccgo)
=== RUN TestVersionHandling
--- SKIP: TestVersionHandling (0.00s)
gcimporter_test.go:189: gc-built packages not available (compiler = gccgo)
=== RUN TestImportStdLib
--- SKIP: TestImportStdLib (0.00s)
gcimporter_test.go:270: gc-built packages not available (compiler = gccgo)
=== RUN TestIssue5815
--- SKIP: TestIssue5815 (0.00s)
gcimporter_test.go:286: gc-built packages not available (compiler = gccgo)
=== RUN TestCorrectMethodPackage
--- SKIP: TestCorrectMethodPackage (0.00s)
gcimporter_test.go:315: gc-built packages not available (compiler = gccgo)
=== RUN TestIssue13566
--- SKIP: TestIssue13566 (0.00s)
gcimporter_test.go:338: gc-built packages not available (compiler = gccgo)
=== RUN TestIssue13898
--- SKIP: TestIssue13898 (0.00s)
gcimporter_test.go:377: gc-built packages not available (compiler = gccgo)
=== RUN TestIssue15517
--- SKIP: TestIssue15517 (0.00s)
gcimporter_test.go:423: gc-built packages not available (compiler = gccgo)
=== RUN TestIssue15920
--- SKIP: TestIssue15920 (0.00s)
gcimporter_test.go:462: gc-built packages not available (compiler = gccgo)
=== RUN TestIssue20046
--- SKIP: TestIssue20046 (0.00s)
gcimporter_test.go:479: gc-built packages not available (compiler = gccgo)
=== RUN TestBExportData_stdlib
--- SKIP: TestBExportData_stdlib (0.00s)
bexport_test.go:27: gccgo standard library is inaccessible
=== RUN TestVeryLongFile
--- PASS: TestVeryLongFile (0.05s)
=== RUN TestTypeAliases
--- PASS: TestTypeAliases (0.01s)
PASS
ok golang.org/x/tools/go/internal/gcimporter 0.327s
? golang.org/x/tools/go/internal/packagesdriver [no test files]
=== RUN TestFromArgs
--- PASS: TestFromArgs (0.00s)
=== RUN TestLoad_NoInitialPackages
--- PASS: TestLoad_NoInitialPackages (0.00s)
=== RUN TestLoad_MissingInitialPackage
--- SKIP: TestLoad_MissingInitialPackage (0.00s)
loader_test.go:114: Test disabled on gccgo.
=== RUN TestLoad_MissingInitialPackage_AllowErrors
--- SKIP: TestLoad_MissingInitialPackage_AllowErrors (0.00s)
loader_test.go:136: gccgo has no standard library test files
=== RUN TestCreateUnnamedPackage
--- PASS: TestCreateUnnamedPackage (0.00s)
=== RUN TestLoad_MissingFileInCreatedPackage
open /local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/loader/missing.go: no such file or directory
--- PASS: TestLoad_MissingFileInCreatedPackage (0.00s)
=== RUN TestLoad_MissingFileInCreatedPackage_AllowErrors
open /local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/loader/missing.go: no such file or directory
--- PASS: TestLoad_MissingFileInCreatedPackage_AllowErrors (0.00s)
=== RUN TestLoad_ParseError
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/loader/testdata/badpkgdecl.go:1:34: expected 'package', found 'EOF'
--- PASS: TestLoad_ParseError (0.00s)
=== RUN TestLoad_ParseError_AllowErrors
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/loader/testdata/badpkgdecl.go:1:34: expected 'package', found 'EOF'
--- PASS: TestLoad_ParseError_AllowErrors (0.00s)
=== RUN TestLoad_FromSource_Success
--- PASS: TestLoad_FromSource_Success (0.00s)
=== RUN TestLoad_FromImports_Success
--- SKIP: TestLoad_FromImports_Success (0.00s)
loader_test.go:264: gccgo has no standard library test files
=== RUN TestLoad_MissingIndirectImport
/go/src/b/x.go:1:21: could not import c (cannot find package "c" in any of:
/go/src/c (from $GOROOT)
($GOPATH not set. For more details see: 'go help gopath'))
--- PASS: TestLoad_MissingIndirectImport (0.00s)
=== RUN TestLoad_BadDependency_AllowErrors
/go/src/b/x.go:1:21: could not import c (cannot find package "c" in any of:
/go/src/c (from $GOROOT)
($GOPATH not set. For more details see: 'go help gopath'))
/go/src/b/x.go:1:21: could not import c (/go/src/c/x.go:1:8: expected 'IDENT', found 'EOF')
/go/src/c/x.go:1:20: expected operand, found 'EOF'
--- PASS: TestLoad_BadDependency_AllowErrors (0.00s)
=== RUN TestCwd
cannot find package "two/three" in any of:
/go/src/two/three (from $GOROOT)
($GOPATH not set. For more details see: 'go help gopath')
--- PASS: TestCwd (0.02s)
=== RUN TestLoad_vendor
--- PASS: TestLoad_vendor (0.00s)
=== RUN TestVendorCwd
cannot find package "http" in any of:
/go/src/vendor/http (vendor tree)
/go/src/http (from $GOROOT)
($GOPATH not set. For more details see: 'go help gopath')
--- PASS: TestVendorCwd (0.00s)
=== RUN TestVendorCwdIssue16580
--- PASS: TestVendorCwdIssue16580 (0.00s)
=== RUN TestTransitivelyErrorFreeFlag
/go/src/c/x.go:1:31: cannot convert false (untyped bool constant) to int
--- PASS: TestTransitivelyErrorFreeFlag (0.00s)
=== RUN TestErrorReporting
--- PASS: TestErrorReporting (0.00s)
=== RUN TestCycles
--- PASS: TestCycles (0.00s)
=== RUN TestLoad1
--- SKIP: TestLoad1 (0.00s)
loader_test.go:822: Test disabled on gccgo.
=== RUN TestLoad2
--- SKIP: TestLoad2 (0.00s)
loader_test.go:828: Test disabled on gccgo.
=== RUN TestStdlib
--- SKIP: TestStdlib (0.00s)
stdlib_test.go:34: Test disabled on gccgo.
=== RUN TestCgoOption
--- SKIP: TestCgoOption (0.00s)
stdlib_test.go:126: skipping in short mode; uses tons of memory (https://golang.org/issue/14113)
PASS
ok golang.org/x/tools/go/loader 0.437s
=== RUN TestLoadZeroConfig
--- FAIL: TestLoadZeroConfig (0.35s)
packages_test.go:65: got name= srcs=[] imports=map[], want name=hash srcs=[hash.go] imports=map[]
=== RUN TestLoadImportsGraph
=== RUN TestLoadImportsGraph/GOPATH
--- FAIL: TestLoadImportsGraph (3.15s)
--- FAIL: TestLoadImportsGraph/GOPATH (3.15s)
packages_test.go:176: errors.Name = "", want "errors"
packages_test.go:191: errors.Srcs = [], want [errors.go]
packages_test.go:176: unsafe.Name = "", want "unsafe"
=== RUN TestLoadImportsTestVariants
=== RUN TestLoadImportsTestVariants/GOPATH
--- PASS: TestLoadImportsTestVariants (1.01s)
--- PASS: TestLoadImportsTestVariants/GOPATH (1.01s)
=== RUN TestLoadAbsolutePath
--- PASS: TestLoadAbsolutePath (0.33s)
=== RUN TestVendorImports
--- PASS: TestVendorImports (0.56s)
=== RUN TestConfigDir
=== RUN TestConfigDir/GOPATH
--- PASS: TestConfigDir (3.05s)
--- PASS: TestConfigDir/GOPATH (3.05s)
=== RUN TestConfigFlags
=== RUN TestConfigFlags/GOPATH
--- PASS: TestConfigFlags (2.23s)
--- PASS: TestConfigFlags/GOPATH (2.23s)
=== RUN TestLoadTypes
=== RUN TestLoadTypes/GOPATH
--- PASS: TestLoadTypes (0.77s)
--- PASS: TestLoadTypes/GOPATH (0.77s)
=== RUN TestLoadSyntaxOK
=== RUN TestLoadSyntaxOK/GOPATH
--- PASS: TestLoadSyntaxOK (0.61s)
--- PASS: TestLoadSyntaxOK/GOPATH (0.61s)
=== RUN TestLoadDiamondTypes
=== RUN TestLoadDiamondTypes/GOPATH
--- PASS: TestLoadDiamondTypes (0.37s)
--- PASS: TestLoadDiamondTypes/GOPATH (0.37s)
=== RUN TestLoadSyntaxError
=== RUN TestLoadSyntaxError/GOPATH
--- PASS: TestLoadSyntaxError (0.83s)
--- PASS: TestLoadSyntaxError/GOPATH (0.83s)
=== RUN TestParseFileModifyAST
=== RUN TestParseFileModifyAST/GOPATH
--- PASS: TestParseFileModifyAST (0.09s)
--- PASS: TestParseFileModifyAST/GOPATH (0.09s)
=== RUN TestOverlay
=== RUN TestOverlay/GOPATH
--- PASS: TestOverlay (3.90s)
--- PASS: TestOverlay/GOPATH (3.90s)
=== RUN TestLoadAllSyntaxImportErrors
=== RUN TestLoadAllSyntaxImportErrors/GOPATH
--- PASS: TestLoadAllSyntaxImportErrors (0.00s)
--- SKIP: TestLoadAllSyntaxImportErrors/GOPATH (0.00s)
packages_test.go:877: go list -compiled -e fails with non-zero exit status for empty packages
=== RUN TestAbsoluteFilenames
=== RUN TestAbsoluteFilenames/GOPATH
--- PASS: TestAbsoluteFilenames (5.08s)
--- PASS: TestAbsoluteFilenames/GOPATH (5.08s)
=== RUN TestContains
=== RUN TestContains/GOPATH
--- PASS: TestContains (0.40s)
--- PASS: TestContains/GOPATH (0.40s)
=== RUN TestContainsOverlay
=== RUN TestContainsOverlay/GOPATH
--- PASS: TestContainsOverlay (0.59s)
--- PASS: TestContainsOverlay/GOPATH (0.59s)
=== RUN TestSizes
=== RUN TestSizes/GOPATH
--- PASS: TestSizes (0.67s)
--- PASS: TestSizes/GOPATH (0.67s)
=== RUN TestContains_FallbackSticks
=== RUN TestContains_FallbackSticks/GOPATH
--- PASS: TestContains_FallbackSticks (0.69s)
--- PASS: TestContains_FallbackSticks/GOPATH (0.69s)
=== RUN TestName
=== RUN TestName/GOPATH
--- PASS: TestName (1.48s)
--- PASS: TestName/GOPATH (1.48s)
=== RUN TestName_Modules
--- SKIP: TestName_Modules (0.00s)
packages_test.go:1186: pre-modules version of Go
=== RUN TestName_ModulesDedup
--- SKIP: TestName_ModulesDedup (0.00s)
packages_test.go:1226: pre-modules version of Go
=== RUN TestRedundantQueries
=== RUN TestRedundantQueries/GOPATH
--- FAIL: TestRedundantQueries (1.31s)
--- FAIL: TestRedundantQueries/GOPATH (1.31s)
packages_test.go:1276: Load("errors", "name=errors") = [errors], wanted just the errors package
=== RUN TestNoPatterns
=== RUN TestNoPatterns/GOPATH
--- PASS: TestNoPatterns (0.31s)
--- PASS: TestNoPatterns/GOPATH (0.31s)
=== RUN TestJSON
=== RUN TestJSON/GOPATH
--- PASS: TestJSON (0.57s)
--- PASS: TestJSON/GOPATH (0.57s)
=== RUN TestRejectInvalidQueries
--- PASS: TestRejectInvalidQueries (0.00s)
=== RUN TestPatternPassthrough
=== RUN TestPatternPassthrough/GOPATH
--- PASS: TestPatternPassthrough (0.30s)
--- PASS: TestPatternPassthrough/GOPATH (0.30s)
=== RUN TestConfigDefaultEnv
=== RUN TestConfigDefaultEnv/GOPATH
=== RUN TestConfigDefaultEnv/GOPATH/driver_off
=== RUN TestConfigDefaultEnv/GOPATH/driver_unset
=== RUN TestConfigDefaultEnv/GOPATH/driver_set
--- PASS: TestConfigDefaultEnv (0.34s)
--- PASS: TestConfigDefaultEnv/GOPATH (0.34s)
--- PASS: TestConfigDefaultEnv/GOPATH/driver_off (0.31s)
--- PASS: TestConfigDefaultEnv/GOPATH/driver_unset (0.01s)
--- PASS: TestConfigDefaultEnv/GOPATH/driver_set (0.02s)
=== RUN TestBasicXTest
=== RUN TestBasicXTest/GOPATH
--- PASS: TestBasicXTest (0.30s)
--- PASS: TestBasicXTest/GOPATH (0.30s)
=== RUN TestErrorMissingFile
=== RUN TestErrorMissingFile/GOPATH
--- PASS: TestErrorMissingFile (0.30s)
--- PASS: TestErrorMissingFile/GOPATH (0.30s)
packages_test.go:1630: []
=== RUN TestLoadImportsC
--- FAIL: TestLoadImportsC (0.09s)
packagescgo_test.go:58: package "net": got
,
want to have syscall:syscall
packagescgo_test.go:54: package "net [syscall.test]" not loaded
packagescgo_test.go:54: package "syscall_test [syscall.test]" not loaded
=== RUN TestStdlibMetadata
--- FAIL: TestStdlibMetadata (0.11s)
stdlib_test.go:47: Loaded 0 packages
stdlib_test.go:52: Loaded only 0 packages, want at least 150
stdlib_test.go:55: GOMAXPROCS: 64
stdlib_test.go:56: Metadata: 92.853236ms
stdlib_test.go:57: #MB: 0
=== RUN TestCgoOption
--- SKIP: TestCgoOption (0.00s)
stdlib_test.go:62: skipping in short mode; uses tons of memory (https://golang.org/issue/14113)
FAIL
FAIL golang.org/x/tools/go/packages 30.202s
? golang.org/x/tools/go/packages/gopackages [no test files]
=== RUN TestExpect
--- PASS: TestExpect (0.14s)
=== RUN TestGOPATHExport
--- PASS: TestGOPATHExport (0.00s)
PASS
ok golang.org/x/tools/go/packages/packagestest 0.534s
=== RUN TestParseExtendedQuery
file.go:4:8: could not import reflect (invalid package name: "")
--- FAIL: TestParseExtendedQuery (0.00s)
query_test.go:58: couldn't load packages due to errors: main
=== RUN TestStdlib
--- SKIP: TestStdlib (0.00s)
stdlib_test.go:36: skipping (slow) stdlib test (use --stdlib)
FAIL
FAIL golang.org/x/tools/go/pointer 0.252s
=== RUN TestBuildPackage
--- SKIP: TestBuildPackage (0.00s)
builder_test.go:32: Test disabled on gccgo.
=== RUN TestRuntimeTypes
--- SKIP: TestRuntimeTypes (0.00s)
builder_test.go:167: Test disabled on gccgo.
=== RUN TestInit
--- SKIP: TestInit (0.00s)
builder_test.go:268: Test disabled on gccgo.
=== RUN TestSyntheticFuncs
--- PASS: TestSyntheticFuncs (0.00s)
=== RUN TestPhiElimination
--- PASS: TestPhiElimination (0.01s)
=== RUN TestValueForExprStructConv
--- PASS: TestValueForExprStructConv (0.00s)
=== RUN TestObjValueLookup
--- SKIP: TestObjValueLookup (0.00s)
source_test.go:34: Test disabled on gccgo.
=== RUN TestValueForExpr
--- PASS: TestValueForExpr (0.01s)
=== RUN TestEnclosingFunction
--- PASS: TestEnclosingFunction (0.00s)
=== RUN TestFindTests
--- SKIP: TestFindTests (0.00s)
testmain_test.go:41: Test disabled on gccgo.
=== RUN TestFindTestsTesting
--- PASS: TestFindTestsTesting (0.00s)
PASS
ok golang.org/x/tools/go/ssa 0.426s
? golang.org/x/tools/go/ssa/interp [no test files]
=== RUN TestBuildPackage
--- SKIP: TestBuildPackage (0.00s)
load_test.go:37: Test disabled on gccgo.
=== RUN TestPackages
--- FAIL: TestPackages (0.29s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=1 addr=96 pc=94668996224122]
goroutine 21 [running]:
panic
../../../src/libgo/go/runtime/panic.go:554
testing.tRunner..func1
../../../src/libgo/go/testing/testing.go:728
panic
../../../src/libgo/go/runtime/panic.go:495
golang_org_x_tools_go_ssa_ssautil_test.TestPackages
/local_scratch/glaubitz/gotests/golang-go.tools/build/src/golang.org/x/tools/go/ssa/ssautil/load_test.go:72
testing.tRunner
../../../src/libgo/go/testing/testing.go:777
created by testing.T.Run
../../../src/libgo/go/testing/testing.go:824 +989
FAIL golang.org/x/tools/go/ssa/ssautil 0.617s
=== RUN TestPaths
--- PASS: TestPaths (0.00s)
=== RUN TestSourceAndExportData
--- PASS: TestSourceAndExportData (0.00s)
PASS
ok golang.org/x/tools/go/types/objectpath 0.452s
=== RUN TestStaticCallee
--- FAIL: TestStaticCallee (0.01s)
callee_test.go:68: p.go:3:8: could not import fmt (invalid package name: "")
=== RUN TestDependencies
--- PASS: TestDependencies (0.00s)
=== RUN TestAxioms
--- PASS: TestAxioms (0.00s)
=== RUN TestMap
--- PASS: TestMap (0.00s)
=== RUN TestIntuitiveMethodSet
--- PASS: TestIntuitiveMethodSet (0.00s)
=== RUN ExampleMap
--- PASS: ExampleMap (0.00s)
FAIL
FAIL golang.org/x/tools/go/types/typeutil 0.390s
=== RUN TestRepoRootForImportPath
--- SKIP: TestRepoRootForImportPath (0.00s)
vcs_test.go:49: Skipping test in offline build environment
=== RUN TestFromDir
--- PASS: TestFromDir (0.00s)
=== RUN TestParseMetaGoImports
--- PASS: TestParseMetaGoImports (0.00s)
=== RUN TestValidateRepoRoot
--- PASS: TestValidateRepoRoot (0.00s)
=== RUN TestMatchGoImport
--- PASS: TestMatchGoImport (0.00s)
PASS
ok golang.org/x/tools/go/vcs 0.397s
=== RUN TestNewDirTree
--- PASS: TestNewDirTree (0.43s)
=== RUN TestStructField
=== RUN TestStructField/10
=== RUN TestStructField/100
=== RUN TestStructField/1000
=== RUN TestStructField/10000
--- PASS: TestStructField (0.37s)
--- PASS: TestStructField/10 (0.00s)
--- PASS: TestStructField/100 (0.00s)
--- PASS: TestStructField/1000 (0.03s)
--- PASS: TestStructField/10000 (0.33s)
=== RUN TestPkgLinkFunc
--- PASS: TestPkgLinkFunc (0.00s)
=== RUN TestSrcPosLinkFunc
--- PASS: TestSrcPosLinkFunc (0.00s)
=== RUN TestSrcLinkFunc
--- PASS: TestSrcLinkFunc (0.00s)
=== RUN TestQueryLinkFunc
--- PASS: TestQueryLinkFunc (0.00s)
=== RUN TestDocLinkFunc
--- PASS: TestDocLinkFunc (0.00s)
=== RUN TestSanitizeFunc
--- PASS: TestSanitizeFunc (0.00s)
=== RUN TestStructFieldsIDAttributes
--- PASS: TestStructFieldsIDAttributes (0.00s)
=== RUN TestValueSpecIDAttributes
--- PASS: TestValueSpecIDAttributes (0.00s)
=== RUN TestCompositeLitLinkFields
--- PASS: TestCompositeLitLinkFields (0.00s)
=== RUN TestFuncDeclNotLink
--- PASS: TestFuncDeclNotLink (0.00s)
=== RUN TestScanIdentifier
--- PASS: TestScanIdentifier (0.00s)
=== RUN TestReplaceLeadingIndentation
--- PASS: TestReplaceLeadingIndentation (0.00s)
=== RUN TestSrcBreadcrumbFunc
--- PASS: TestSrcBreadcrumbFunc (0.00s)
=== RUN TestSrcToPkgLinkFunc
--- PASS: TestSrcToPkgLinkFunc (0.00s)
=== RUN TestFilterOutBuildAnnotations
--- PASS: TestFilterOutBuildAnnotations (0.00s)
=== RUN TestIndex
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
--- PASS: TestIndex (0.09s)
index_test.go:75: docs, goCode, fullText = true,true,true
index_test.go:75: docs, goCode, fullText = true,true,false
index_test.go:75: docs, goCode, fullText = true,false,true
index_test.go:75: docs, goCode, fullText = true,false,false
index_test.go:75: docs, goCode, fullText = false,true,true
index_test.go:75: docs, goCode, fullText = false,true,false
index_test.go:75: docs, goCode, fullText = false,false,true
index_test.go:75: docs, goCode, fullText = false,false,false
=== RUN TestIndexWriteRead
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
2019/01/30 13:25:58 updateMetadata: file does not exist
--- PASS: TestIndexWriteRead (0.11s)
=== RUN TestIdentResultSort
--- PASS: TestIdentResultSort (0.00s)
=== RUN TestIdentFilter
--- PASS: TestIdentFilter (0.00s)
=== RUN TestIgnoredGoFiles
--- PASS: TestIgnoredGoFiles (0.00s)
=== RUN TestParseEBNFString
--- PASS: TestParseEBNFString (0.00s)
=== RUN TestParseVersionRow
--- PASS: TestParseVersionRow (0.00s)
=== RUN TestAPIVersion
--- PASS: TestAPIVersion (0.05s)
PASS
ok golang.org/x/tools/godoc 1.330s
? golang.org/x/tools/godoc/analysis [no test files]
=== RUN TestParseVersion
--- PASS: TestParseVersion (0.00s)
=== RUN TestFileOrder
--- PASS: TestFileOrder (0.00s)
=== RUN TestFilesToReleases
--- PASS: TestFilesToReleases (0.00s)
=== RUN TestOldUnstableNotShown
--- PASS: TestOldUnstableNotShown (0.00s)
=== RUN TestNewUnstableShownOnce
--- PASS: TestNewUnstableShownOnce (0.00s)
=== RUN TestUnstableShown
--- PASS: TestUnstableShown (0.00s)
PASS
ok golang.org/x/tools/godoc/dl 0.435s
? golang.org/x/tools/godoc/env [no test files]
? golang.org/x/tools/godoc/proxy [no test files]
=== RUN TestRedirects
--- PASS: TestRedirects (0.50s)
PASS
ok golang.org/x/tools/godoc/redirect 0.902s
? golang.org/x/tools/godoc/short [no test files]
? golang.org/x/tools/godoc/util [no test files]
=== RUN TestNewNameSpace
--- PASS: TestNewNameSpace (0.00s)
=== RUN TestRootType
--- PASS: TestRootType (0.00s)
PASS
ok golang.org/x/tools/godoc/vfs 0.410s
=== RUN TestRootType
--- PASS: TestRootType (0.00s)
PASS
ok golang.org/x/tools/godoc/vfs/gatefs 0.354s
? golang.org/x/tools/godoc/vfs/httpfs [no test files]
=== RUN TestOpenRoot
--- PASS: TestOpenRoot (0.00s)
=== RUN TestReaddir
--- PASS: TestReaddir (0.00s)
PASS
ok golang.org/x/tools/godoc/vfs/mapfs 0.397s
=== RUN TestZipFSReadDir
--- PASS: TestZipFSReadDir (0.00s)
=== RUN TestZipFSStatFuncs
--- PASS: TestZipFSStatFuncs (0.00s)
=== RUN TestZipFSNotExist
--- PASS: TestZipFSNotExist (0.00s)
=== RUN TestZipFSOpenSeek
--- PASS: TestZipFSOpenSeek (0.00s)
=== RUN TestRootType
--- FAIL: TestRootType (0.00s)
zipfs_test.go:203: unexpected fsType. Expected- GOROOT, Got-
FAIL
FAIL golang.org/x/tools/godoc/vfs/zipfs 0.384s
=== RUN TestSimpleCases
=== RUN TestSimpleCases/factored_imports_add
=== RUN TestSimpleCases/factored_imports_add/GOPATH
=== RUN TestSimpleCases/factored_imports_add/GOPATH_GoPackages
=== RUN TestSimpleCases/factored_imports_add_first_sec
=== RUN TestSimpleCases/factored_imports_add_first_sec/GOPATH
=== RUN TestSimpleCases/factored_imports_add_first_sec/GOPATH_GoPackages
=== RUN TestSimpleCases/factored_imports_add_first_sec_2
=== RUN TestSimpleCases/factored_imports_add_first_sec_2/GOPATH
=== RUN TestSimpleCases/factored_imports_add_first_sec_2/GOPATH_GoPackages
=== RUN TestSimpleCases/add_import_section
=== RUN TestSimpleCases/add_import_section/GOPATH
=== RUN TestSimpleCases/add_import_section/GOPATH_GoPackages
=== RUN TestSimpleCases/add_import_paren_section
=== RUN TestSimpleCases/add_import_paren_section/GOPATH
=== RUN TestSimpleCases/add_import_paren_section/GOPATH_GoPackages
=== RUN TestSimpleCases/no_double_add
=== RUN TestSimpleCases/no_double_add/GOPATH
=== RUN TestSimpleCases/no_double_add/GOPATH_GoPackages
=== RUN TestSimpleCases/no_mismatched_add
=== RUN TestSimpleCases/no_mismatched_add/GOPATH
=== RUN TestSimpleCases/no_mismatched_add/GOPATH_GoPackages
=== RUN TestSimpleCases/remove_unused_1_of_2
=== RUN TestSimpleCases/remove_unused_1_of_2/GOPATH
=== RUN TestSimpleCases/remove_unused_1_of_2/GOPATH_GoPackages
=== RUN TestSimpleCases/remove_unused_2_of_2
=== RUN TestSimpleCases/remove_unused_2_of_2/GOPATH
=== RUN TestSimpleCases/remove_unused_2_of_2/GOPATH_GoPackages
=== RUN TestSimpleCases/remove_unused_1_of_1
=== RUN TestSimpleCases/remove_unused_1_of_1/GOPATH
=== RUN TestSimpleCases/remove_unused_1_of_1/GOPATH_GoPackages
=== RUN TestSimpleCases/dont_remove_empty_imports
=== RUN TestSimpleCases/dont_remove_empty_imports/GOPATH
=== RUN TestSimpleCases/dont_remove_empty_imports/GOPATH_GoPackages
=== RUN TestSimpleCases/dont_remove_dot_imports
=== RUN TestSimpleCases/dont_remove_dot_imports/GOPATH
=== RUN TestSimpleCases/dont_remove_dot_imports/GOPATH_GoPackages
=== RUN TestSimpleCases/skip_resolved_refs
=== RUN TestSimpleCases/skip_resolved_refs/GOPATH
=== RUN TestSimpleCases/skip_resolved_refs/GOPATH_GoPackages
=== RUN TestSimpleCases/skip_template
=== RUN TestSimpleCases/skip_template/GOPATH
=== RUN TestSimpleCases/skip_template/GOPATH_GoPackages
=== RUN TestSimpleCases/cgo
=== RUN TestSimpleCases/cgo/GOPATH
=== RUN TestSimpleCases/cgo/GOPATH_GoPackages
=== RUN TestSimpleCases/make_sections
=== RUN TestSimpleCases/make_sections/GOPATH
=== RUN TestSimpleCases/make_sections/GOPATH_GoPackages
=== RUN TestSimpleCases/delete_empty_import_block
=== RUN TestSimpleCases/delete_empty_import_block/GOPATH
=== RUN TestSimpleCases/delete_empty_import_block/GOPATH_GoPackages
=== RUN TestSimpleCases/use_empty_import_block
=== RUN TestSimpleCases/use_empty_import_block/GOPATH
=== RUN TestSimpleCases/use_empty_import_block/GOPATH_GoPackages
=== RUN TestSimpleCases/blank_line_before_new_group
=== RUN TestSimpleCases/blank_line_before_new_group/GOPATH
=== RUN TestSimpleCases/blank_line_before_new_group/GOPATH_GoPackages
=== RUN TestSimpleCases/blank_line_separating_std_and_third_party
=== RUN TestSimpleCases/blank_line_separating_std_and_third_party/GOPATH
=== RUN TestSimpleCases/blank_line_separating_std_and_third_party/GOPATH_GoPackages
=== RUN TestSimpleCases/new_imports_before_comment
=== RUN TestSimpleCases/new_imports_before_comment/GOPATH
=== RUN TestSimpleCases/new_imports_before_comment/GOPATH_GoPackages
=== RUN TestSimpleCases/new_section_for_dotless_import
=== RUN TestSimpleCases/new_section_for_dotless_import/GOPATH
=== RUN TestSimpleCases/new_section_for_dotless_import/GOPATH_GoPackages
=== RUN TestSimpleCases/fragment_with_main
=== RUN TestSimpleCases/fragment_with_main/GOPATH
=== RUN TestSimpleCases/fragment_with_main/GOPATH_GoPackages
=== RUN TestSimpleCases/fragment_without_main
=== RUN TestSimpleCases/fragment_without_main/GOPATH
=== RUN TestSimpleCases/fragment_without_main/GOPATH_GoPackages
=== RUN TestSimpleCases/remove_first_import_in_section
=== RUN TestSimpleCases/remove_first_import_in_section/GOPATH
=== RUN TestSimpleCases/remove_first_import_in_section/GOPATH_GoPackages
=== RUN TestSimpleCases/new_section_for_all_kinds_of_imports
=== RUN TestSimpleCases/new_section_for_all_kinds_of_imports/GOPATH
=== RUN TestSimpleCases/new_section_for_all_kinds_of_imports/GOPATH_GoPackages
=== RUN TestSimpleCases/comments_formatted
=== RUN TestSimpleCases/comments_formatted/GOPATH
=== RUN TestSimpleCases/comments_formatted/GOPATH_GoPackages
=== RUN TestSimpleCases/remove_duplicates
=== RUN TestSimpleCases/remove_duplicates/GOPATH
=== RUN TestSimpleCases/remove_duplicates/GOPATH_GoPackages
=== RUN TestSimpleCases/no_extra_groups
=== RUN TestSimpleCases/no_extra_groups/GOPATH
=== RUN TestSimpleCases/no_extra_groups/GOPATH_GoPackages
=== RUN TestSimpleCases/named_import_doesnt_provide_package_name
=== RUN TestSimpleCases/named_import_doesnt_provide_package_name/GOPATH
=== RUN TestSimpleCases/named_import_doesnt_provide_package_name/GOPATH_GoPackages
=== RUN TestSimpleCases/unused_named_import_removed
=== RUN TestSimpleCases/unused_named_import_removed/GOPATH
=== RUN TestSimpleCases/unused_named_import_removed/GOPATH_GoPackages
=== RUN TestSimpleCases/ignore_unexported_identifier
=== RUN TestSimpleCases/ignore_unexported_identifier/GOPATH
=== RUN TestSimpleCases/ignore_unexported_identifier/GOPATH_GoPackages
=== RUN TestSimpleCases/formatonly_works
=== RUN TestSimpleCases/formatonly_works/GOPATH
=== RUN TestSimpleCases/formatonly_works/GOPATH_GoPackages
=== RUN TestSimpleCases/preserve_import_group
=== RUN TestSimpleCases/preserve_import_group/GOPATH
=== RUN TestSimpleCases/preserve_import_group/GOPATH_GoPackages
=== RUN TestSimpleCases/import_grouping_not_path_dependent_no_groups
=== RUN TestSimpleCases/import_grouping_not_path_dependent_no_groups/GOPATH
=== RUN TestSimpleCases/import_grouping_not_path_dependent_no_groups/GOPATH_GoPackages
=== RUN TestSimpleCases/import_grouping_not_path_dependent_existing_group
=== RUN TestSimpleCases/import_grouping_not_path_dependent_existing_group/GOPATH
=== RUN TestSimpleCases/import_grouping_not_path_dependent_existing_group/GOPATH_GoPackages
=== RUN TestSimpleCases/package_statement_insertion_preserves_comments
=== RUN TestSimpleCases/package_statement_insertion_preserves_comments/GOPATH
=== RUN TestSimpleCases/package_statement_insertion_preserves_comments/GOPATH_GoPackages
=== RUN TestSimpleCases/import_comment_stays_on_import
=== RUN TestSimpleCases/import_comment_stays_on_import/GOPATH
=== RUN TestSimpleCases/import_comment_stays_on_import/GOPATH_GoPackages
=== RUN TestSimpleCases/no_blank_after_comment
=== RUN TestSimpleCases/no_blank_after_comment/GOPATH
=== RUN TestSimpleCases/no_blank_after_comment/GOPATH_GoPackages
=== RUN TestSimpleCases/no_blank_after_comment_reordered
=== RUN TestSimpleCases/no_blank_after_comment_reordered/GOPATH
=== RUN TestSimpleCases/no_blank_after_comment_reordered/GOPATH_GoPackages
=== RUN TestSimpleCases/no_blank_after_comment_unnamed
=== RUN TestSimpleCases/no_blank_after_comment_unnamed/GOPATH
=== RUN TestSimpleCases/no_blank_after_comment_unnamed/GOPATH_GoPackages
=== RUN TestSimpleCases/blank_after_package_statement_with_comment
=== RUN TestSimpleCases/blank_after_package_statement_with_comment/GOPATH
=== RUN TestSimpleCases/blank_after_package_statement_with_comment/GOPATH_GoPackages
=== RUN TestSimpleCases/blank_after_package_statement_no_comment
=== RUN TestSimpleCases/blank_after_package_statement_no_comment/GOPATH
=== RUN TestSimpleCases/blank_after_package_statement_no_comment/GOPATH_GoPackages
=== RUN TestSimpleCases/cryptorand_preferred_easy_possible
=== RUN TestSimpleCases/cryptorand_preferred_easy_possible/GOPATH
=== RUN TestSimpleCases/cryptorand_preferred_easy_possible/GOPATH_GoPackages
=== RUN TestSimpleCases/cryptorand_preferred_easy_impossible
=== RUN TestSimpleCases/cryptorand_preferred_easy_impossible/GOPATH
=== RUN TestSimpleCases/cryptorand_preferred_easy_impossible/GOPATH_GoPackages
=== RUN TestSimpleCases/cryptorand_preferred_complex_possible
=== RUN TestSimpleCases/cryptorand_preferred_complex_possible/GOPATH
=== RUN TestSimpleCases/cryptorand_preferred_complex_possible/GOPATH_GoPackages
=== RUN TestSimpleCases/cryptorand_preferred_complex_impossible
=== RUN TestSimpleCases/cryptorand_preferred_complex_impossible/GOPATH
=== RUN TestSimpleCases/cryptorand_preferred_complex_impossible/GOPATH_GoPackages
--- PASS: TestSimpleCases (7.45s)
--- PASS: TestSimpleCases/factored_imports_add (0.01s)
--- PASS: TestSimpleCases/factored_imports_add/GOPATH (0.00s)
--- PASS: TestSimpleCases/factored_imports_add/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/factored_imports_add_first_sec (0.01s)
--- PASS: TestSimpleCases/factored_imports_add_first_sec/GOPATH (0.00s)
--- PASS: TestSimpleCases/factored_imports_add_first_sec/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/factored_imports_add_first_sec_2 (0.01s)
--- PASS: TestSimpleCases/factored_imports_add_first_sec_2/GOPATH (0.00s)
--- PASS: TestSimpleCases/factored_imports_add_first_sec_2/GOPATH_GoPackages (0.01s)
--- PASS: TestSimpleCases/add_import_section (0.01s)
--- PASS: TestSimpleCases/add_import_section/GOPATH (0.00s)
--- PASS: TestSimpleCases/add_import_section/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/add_import_paren_section (0.01s)
--- PASS: TestSimpleCases/add_import_paren_section/GOPATH (0.00s)
--- PASS: TestSimpleCases/add_import_paren_section/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/no_double_add (0.01s)
--- PASS: TestSimpleCases/no_double_add/GOPATH (0.00s)
--- PASS: TestSimpleCases/no_double_add/GOPATH_GoPackages (0.01s)
--- PASS: TestSimpleCases/no_mismatched_add (1.68s)
--- PASS: TestSimpleCases/no_mismatched_add/GOPATH (0.10s)
--- PASS: TestSimpleCases/no_mismatched_add/GOPATH_GoPackages (1.59s)
--- PASS: TestSimpleCases/remove_unused_1_of_2 (0.01s)
--- PASS: TestSimpleCases/remove_unused_1_of_2/GOPATH (0.01s)
--- PASS: TestSimpleCases/remove_unused_1_of_2/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/remove_unused_2_of_2 (0.01s)
--- PASS: TestSimpleCases/remove_unused_2_of_2/GOPATH (0.00s)
--- PASS: TestSimpleCases/remove_unused_2_of_2/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/remove_unused_1_of_1 (0.01s)
--- PASS: TestSimpleCases/remove_unused_1_of_1/GOPATH (0.00s)
--- PASS: TestSimpleCases/remove_unused_1_of_1/GOPATH_GoPackages (0.01s)
--- PASS: TestSimpleCases/dont_remove_empty_imports (0.01s)
--- PASS: TestSimpleCases/dont_remove_empty_imports/GOPATH (0.01s)
--- PASS: TestSimpleCases/dont_remove_empty_imports/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/dont_remove_dot_imports (0.01s)
--- PASS: TestSimpleCases/dont_remove_dot_imports/GOPATH (0.00s)
--- PASS: TestSimpleCases/dont_remove_dot_imports/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/skip_resolved_refs (0.01s)
--- PASS: TestSimpleCases/skip_resolved_refs/GOPATH (0.00s)
--- PASS: TestSimpleCases/skip_resolved_refs/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/skip_template (0.01s)
--- PASS: TestSimpleCases/skip_template/GOPATH (0.00s)
--- PASS: TestSimpleCases/skip_template/GOPATH_GoPackages (0.01s)
--- PASS: TestSimpleCases/cgo (0.01s)
--- PASS: TestSimpleCases/cgo/GOPATH (0.01s)
--- PASS: TestSimpleCases/cgo/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/make_sections (1.93s)
--- PASS: TestSimpleCases/make_sections/GOPATH (0.33s)
--- PASS: TestSimpleCases/make_sections/GOPATH_GoPackages (1.60s)
--- PASS: TestSimpleCases/delete_empty_import_block (0.02s)
--- PASS: TestSimpleCases/delete_empty_import_block/GOPATH (0.01s)
--- PASS: TestSimpleCases/delete_empty_import_block/GOPATH_GoPackages (0.01s)
--- PASS: TestSimpleCases/use_empty_import_block (0.01s)
--- PASS: TestSimpleCases/use_empty_import_block/GOPATH (0.00s)
--- PASS: TestSimpleCases/use_empty_import_block/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/blank_line_before_new_group (1.35s)
--- PASS: TestSimpleCases/blank_line_before_new_group/GOPATH (0.31s)
--- PASS: TestSimpleCases/blank_line_before_new_group/GOPATH_GoPackages (1.04s)
--- PASS: TestSimpleCases/blank_line_separating_std_and_third_party (0.01s)
--- PASS: TestSimpleCases/blank_line_separating_std_and_third_party/GOPATH (0.01s)
--- PASS: TestSimpleCases/blank_line_separating_std_and_third_party/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/new_imports_before_comment (0.01s)
--- PASS: TestSimpleCases/new_imports_before_comment/GOPATH (0.00s)
--- PASS: TestSimpleCases/new_imports_before_comment/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/new_section_for_dotless_import (0.01s)
--- PASS: TestSimpleCases/new_section_for_dotless_import/GOPATH (0.00s)
--- PASS: TestSimpleCases/new_section_for_dotless_import/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/fragment_with_main (0.01s)
--- PASS: TestSimpleCases/fragment_with_main/GOPATH (0.00s)
--- PASS: TestSimpleCases/fragment_with_main/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/fragment_without_main (0.01s)
--- PASS: TestSimpleCases/fragment_without_main/GOPATH (0.00s)
--- PASS: TestSimpleCases/fragment_without_main/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/remove_first_import_in_section (0.01s)
--- PASS: TestSimpleCases/remove_first_import_in_section/GOPATH (0.00s)
--- PASS: TestSimpleCases/remove_first_import_in_section/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/new_section_for_all_kinds_of_imports (0.02s)
--- PASS: TestSimpleCases/new_section_for_all_kinds_of_imports/GOPATH (0.01s)
--- PASS: TestSimpleCases/new_section_for_all_kinds_of_imports/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/comments_formatted (0.01s)
--- PASS: TestSimpleCases/comments_formatted/GOPATH (0.00s)
--- PASS: TestSimpleCases/comments_formatted/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/remove_duplicates (0.01s)
--- PASS: TestSimpleCases/remove_duplicates/GOPATH (0.00s)
--- PASS: TestSimpleCases/remove_duplicates/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/no_extra_groups (0.01s)
--- PASS: TestSimpleCases/no_extra_groups/GOPATH (0.00s)
--- PASS: TestSimpleCases/no_extra_groups/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/named_import_doesnt_provide_package_name (0.01s)
--- PASS: TestSimpleCases/named_import_doesnt_provide_package_name/GOPATH (0.00s)
--- PASS: TestSimpleCases/named_import_doesnt_provide_package_name/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/unused_named_import_removed (0.01s)
--- PASS: TestSimpleCases/unused_named_import_removed/GOPATH (0.00s)
--- PASS: TestSimpleCases/unused_named_import_removed/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/ignore_unexported_identifier (0.01s)
--- PASS: TestSimpleCases/ignore_unexported_identifier/GOPATH (0.01s)
--- PASS: TestSimpleCases/ignore_unexported_identifier/GOPATH_GoPackages (0.01s)
--- PASS: TestSimpleCases/formatonly_works (0.01s)
--- PASS: TestSimpleCases/formatonly_works/GOPATH (0.00s)
--- PASS: TestSimpleCases/formatonly_works/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/preserve_import_group (0.01s)
--- PASS: TestSimpleCases/preserve_import_group/GOPATH (0.00s)
--- PASS: TestSimpleCases/preserve_import_group/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/import_grouping_not_path_dependent_no_groups (0.96s)
--- PASS: TestSimpleCases/import_grouping_not_path_dependent_no_groups/GOPATH (0.10s)
--- PASS: TestSimpleCases/import_grouping_not_path_dependent_no_groups/GOPATH_GoPackages (0.85s)
--- PASS: TestSimpleCases/import_grouping_not_path_dependent_existing_group (1.17s)
--- PASS: TestSimpleCases/import_grouping_not_path_dependent_existing_group/GOPATH (0.33s)
--- PASS: TestSimpleCases/import_grouping_not_path_dependent_existing_group/GOPATH_GoPackages (0.84s)
--- PASS: TestSimpleCases/package_statement_insertion_preserves_comments (0.02s)
--- PASS: TestSimpleCases/package_statement_insertion_preserves_comments/GOPATH (0.01s)
--- PASS: TestSimpleCases/package_statement_insertion_preserves_comments/GOPATH_GoPackages (0.01s)
--- PASS: TestSimpleCases/import_comment_stays_on_import (0.01s)
--- PASS: TestSimpleCases/import_comment_stays_on_import/GOPATH (0.00s)
--- PASS: TestSimpleCases/import_comment_stays_on_import/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/no_blank_after_comment (0.01s)
--- PASS: TestSimpleCases/no_blank_after_comment/GOPATH (0.00s)
--- PASS: TestSimpleCases/no_blank_after_comment/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/no_blank_after_comment_reordered (0.01s)
--- PASS: TestSimpleCases/no_blank_after_comment_reordered/GOPATH (0.00s)
--- PASS: TestSimpleCases/no_blank_after_comment_reordered/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/no_blank_after_comment_unnamed (0.01s)
--- PASS: TestSimpleCases/no_blank_after_comment_unnamed/GOPATH (0.00s)
--- PASS: TestSimpleCases/no_blank_after_comment_unnamed/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/blank_after_package_statement_with_comment (0.01s)
--- PASS: TestSimpleCases/blank_after_package_statement_with_comment/GOPATH (0.00s)
--- PASS: TestSimpleCases/blank_after_package_statement_with_comment/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/blank_after_package_statement_no_comment (0.01s)
--- PASS: TestSimpleCases/blank_after_package_statement_no_comment/GOPATH (0.00s)
--- PASS: TestSimpleCases/blank_after_package_statement_no_comment/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/cryptorand_preferred_easy_possible (0.01s)
--- PASS: TestSimpleCases/cryptorand_preferred_easy_possible/GOPATH (0.00s)
--- PASS: TestSimpleCases/cryptorand_preferred_easy_possible/GOPATH_GoPackages (0.01s)
--- PASS: TestSimpleCases/cryptorand_preferred_easy_impossible (0.01s)
--- PASS: TestSimpleCases/cryptorand_preferred_easy_impossible/GOPATH (0.00s)
--- PASS: TestSimpleCases/cryptorand_preferred_easy_impossible/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/cryptorand_preferred_complex_possible (0.01s)
--- PASS: TestSimpleCases/cryptorand_preferred_complex_possible/GOPATH (0.00s)
--- PASS: TestSimpleCases/cryptorand_preferred_complex_possible/GOPATH_GoPackages (0.00s)
--- PASS: TestSimpleCases/cryptorand_preferred_complex_impossible (0.01s)
--- PASS: TestSimpleCases/cryptorand_preferred_complex_impossible/GOPATH (0.00s)
--- PASS: TestSimpleCases/cryptorand_preferred_complex_impossible/GOPATH_GoPackages (0.00s)
=== RUN TestAppengine
=== RUN TestAppengine/GOPATH
=== RUN TestAppengine/GOPATH_GoPackages
--- PASS: TestAppengine (2.05s)
--- PASS: TestAppengine/GOPATH (0.31s)
--- PASS: TestAppengine/GOPATH_GoPackages (1.74s)
=== RUN TestReadFromFilesystem
=== RUN TestReadFromFilesystem/works
=== RUN TestReadFromFilesystem/works/GOPATH
=== RUN TestReadFromFilesystem/works/GOPATH_GoPackages
=== RUN TestReadFromFilesystem/missing_package
=== RUN TestReadFromFilesystem/missing_package/GOPATH
=== RUN TestReadFromFilesystem/missing_package/GOPATH_GoPackages
--- PASS: TestReadFromFilesystem (0.00s)
--- PASS: TestReadFromFilesystem/works (0.00s)
--- PASS: TestReadFromFilesystem/works/GOPATH (0.00s)
--- PASS: TestReadFromFilesystem/works/GOPATH_GoPackages (0.00s)
--- PASS: TestReadFromFilesystem/missing_package (0.00s)
--- PASS: TestReadFromFilesystem/missing_package/GOPATH (0.00s)
--- PASS: TestReadFromFilesystem/missing_package/GOPATH_GoPackages (0.00s)
=== RUN TestImportSymlinks
=== RUN TestImportSymlinks/GOPATH
=== RUN TestImportSymlinks/GOPATH_GoPackages
--- PASS: TestImportSymlinks (1.86s)
--- PASS: TestImportSymlinks/GOPATH (0.31s)
--- PASS: TestImportSymlinks/GOPATH_GoPackages (1.55s)
=== RUN TestImportSymlinksWithIgnore
=== RUN TestImportSymlinksWithIgnore/GOPATH
=== RUN TestImportSymlinksWithIgnore/GOPATH_GoPackages
--- PASS: TestImportSymlinksWithIgnore (0.77s)
--- PASS: TestImportSymlinksWithIgnore/GOPATH (0.11s)
--- PASS: TestImportSymlinksWithIgnore/GOPATH_GoPackages (0.66s)
=== RUN TestModuleVersion
=== RUN TestModuleVersion/GOPATH
=== RUN TestModuleVersion/GOPATH_GoPackages
--- PASS: TestModuleVersion (0.01s)
--- PASS: TestModuleVersion/GOPATH (0.00s)
--- PASS: TestModuleVersion/GOPATH_GoPackages (0.00s)
=== RUN TestVendorPackage
=== RUN TestVendorPackage/GOPATH
=== RUN TestVendorPackage/GOPATH_GoPackages
--- PASS: TestVendorPackage (0.82s)
--- PASS: TestVendorPackage/GOPATH (0.06s)
--- PASS: TestVendorPackage/GOPATH_GoPackages (0.76s)
=== RUN TestInternal
=== RUN TestInternal/GOPATH
=== RUN TestInternal/GOPATH_GoPackages
=== RUN TestInternal/GOPATH#01
=== RUN TestInternal/GOPATH_GoPackages#01
--- PASS: TestInternal (2.30s)
--- PASS: TestInternal/GOPATH (0.32s)
--- PASS: TestInternal/GOPATH_GoPackages (1.11s)
--- PASS: TestInternal/GOPATH#01 (0.32s)
--- PASS: TestInternal/GOPATH_GoPackages#01 (0.55s)
=== RUN TestProcessVendor
=== RUN TestProcessVendor/GOPATH
=== RUN TestProcessVendor/GOPATH_GoPackages
--- PASS: TestProcessVendor (1.47s)
--- PASS: TestProcessVendor/GOPATH (0.31s)
--- PASS: TestProcessVendor/GOPATH_GoPackages (1.17s)
=== RUN TestFindStdlib
--- PASS: TestFindStdlib (0.88s)
=== RUN TestRenameWhenPackageNameMismatch
=== RUN TestRenameWhenPackageNameMismatch/GOPATH
=== RUN TestRenameWhenPackageNameMismatch/GOPATH_GoPackages
--- PASS: TestRenameWhenPackageNameMismatch (0.70s)
--- PASS: TestRenameWhenPackageNameMismatch/GOPATH (0.10s)
--- PASS: TestRenameWhenPackageNameMismatch/GOPATH_GoPackages (0.61s)
=== RUN TestAddNameToMismatchedImport
=== RUN TestAddNameToMismatchedImport/GOPATH
=== RUN TestAddNameToMismatchedImport/GOPATH_GoPackages
--- PASS: TestAddNameToMismatchedImport (0.58s)
--- PASS: TestAddNameToMismatchedImport/GOPATH (0.05s)
--- PASS: TestAddNameToMismatchedImport/GOPATH_GoPackages (0.53s)
=== RUN TestLocalPrefix
=== RUN TestLocalPrefix/one_local
=== RUN TestLocalPrefix/one_local/GOPATH
=== RUN TestLocalPrefix/one_local/GOPATH_GoPackages
=== RUN TestLocalPrefix/two_local
=== RUN TestLocalPrefix/two_local/GOPATH
=== RUN TestLocalPrefix/two_local/GOPATH_GoPackages
=== RUN TestLocalPrefix/three_prefixes
=== RUN TestLocalPrefix/three_prefixes/GOPATH
=== RUN TestLocalPrefix/three_prefixes/GOPATH_GoPackages
--- PASS: TestLocalPrefix (5.73s)
--- PASS: TestLocalPrefix/one_local (1.55s)
--- PASS: TestLocalPrefix/one_local/GOPATH (0.32s)
--- PASS: TestLocalPrefix/one_local/GOPATH_GoPackages (1.23s)
--- PASS: TestLocalPrefix/two_local (2.62s)
--- PASS: TestLocalPrefix/two_local/GOPATH (0.33s)
--- PASS: TestLocalPrefix/two_local/GOPATH_GoPackages (2.29s)
--- PASS: TestLocalPrefix/three_prefixes (1.56s)
--- PASS: TestLocalPrefix/three_prefixes/GOPATH (0.33s)
--- PASS: TestLocalPrefix/three_prefixes/GOPATH_GoPackages (1.23s)
=== RUN TestIgnoreDocumentationPackage
=== RUN TestIgnoreDocumentationPackage/GOPATH
=== RUN TestIgnoreDocumentationPackage/GOPATH_GoPackages
--- PASS: TestIgnoreDocumentationPackage (0.84s)
--- PASS: TestIgnoreDocumentationPackage/GOPATH (0.11s)
--- PASS: TestIgnoreDocumentationPackage/GOPATH_GoPackages (0.74s)
=== RUN TestImportPathToNameGoPathParse
=== RUN TestImportPathToNameGoPathParse/GOPATH
=== RUN TestImportPathToNameGoPathParse/GOPATH_GoPackages
--- PASS: TestImportPathToNameGoPathParse (0.27s)
--- PASS: TestImportPathToNameGoPathParse/GOPATH (0.26s)
--- SKIP: TestImportPathToNameGoPathParse/GOPATH_GoPackages (0.00s)
fix_test.go:1813: go/packages does not ignore package main
=== RUN TestIgnoreConfiguration
=== RUN TestIgnoreConfiguration/GOPATH
=== RUN TestIgnoreConfiguration/GOPATH_GoPackages
--- PASS: TestIgnoreConfiguration (1.25s)
--- PASS: TestIgnoreConfiguration/GOPATH (0.31s)
--- PASS: TestIgnoreConfiguration/GOPATH_GoPackages (0.94s)
=== RUN TestSkipNodeModules
=== RUN TestSkipNodeModules/GOPATH
=== RUN TestSkipNodeModules/GOPATH_GoPackages
--- PASS: TestSkipNodeModules (0.97s)
--- PASS: TestSkipNodeModules/GOPATH (0.11s)
--- PASS: TestSkipNodeModules/GOPATH_GoPackages (0.85s)
=== RUN TestGlobalImports
=== RUN TestGlobalImports/GOPATH
=== RUN TestGlobalImports/GOPATH_GoPackages
--- PASS: TestGlobalImports (0.00s)
--- PASS: TestGlobalImports/GOPATH (0.00s)
--- PASS: TestGlobalImports/GOPATH_GoPackages (0.00s)
=== RUN TestGlobalImports_DifferentPackage
=== RUN TestGlobalImports_DifferentPackage/GOPATH
=== RUN TestGlobalImports_DifferentPackage/GOPATH_GoPackages
--- PASS: TestGlobalImports_DifferentPackage (0.00s)
--- PASS: TestGlobalImports_DifferentPackage/GOPATH (0.00s)
--- PASS: TestGlobalImports_DifferentPackage/GOPATH_GoPackages (0.00s)
=== RUN TestGlobalImports_MultipleMains
=== RUN TestGlobalImports_MultipleMains/GOPATH
=== RUN TestGlobalImports_MultipleMains/GOPATH_GoPackages
--- PASS: TestGlobalImports_MultipleMains (0.00s)
--- PASS: TestGlobalImports_MultipleMains/GOPATH (0.00s)
--- PASS: TestGlobalImports_MultipleMains/GOPATH_GoPackages (0.00s)
=== RUN TestSiblingImports
=== RUN TestSiblingImports/GOPATH
=== RUN TestSiblingImports/GOPATH_GoPackages
--- PASS: TestSiblingImports (0.00s)
--- PASS: TestSiblingImports/GOPATH (0.00s)
--- PASS: TestSiblingImports/GOPATH_GoPackages (0.00s)
=== RUN TestSiblingImport_Misnamed
=== RUN TestSiblingImport_Misnamed/GOPATH
=== RUN TestSiblingImport_Misnamed/GOPATH_GoPackages
--- PASS: TestSiblingImport_Misnamed (0.00s)
--- PASS: TestSiblingImport_Misnamed/GOPATH (0.00s)
--- PASS: TestSiblingImport_Misnamed/GOPATH_GoPackages (0.00s)
=== RUN TestPkgIsCandidate
=== RUN TestPkgIsCandidate/normal_match
=== RUN TestPkgIsCandidate/no_match
=== RUN TestPkgIsCandidate/match_too_early
=== RUN TestPkgIsCandidate/substring_match
=== RUN TestPkgIsCandidate/hidden_internal
=== RUN TestPkgIsCandidate/visible_internal
=== RUN TestPkgIsCandidate/invisible_vendor
=== RUN TestPkgIsCandidate/visible_vendor
=== RUN TestPkgIsCandidate/match_with_hyphens
=== RUN TestPkgIsCandidate/match_with_mixed_case
=== RUN TestPkgIsCandidate/matches_with_hyphen_and_caps
--- PASS: TestPkgIsCandidate (0.00s)
--- PASS: TestPkgIsCandidate/normal_match (0.00s)
--- PASS: TestPkgIsCandidate/no_match (0.00s)
--- PASS: TestPkgIsCandidate/match_too_early (0.00s)
--- PASS: TestPkgIsCandidate/substring_match (0.00s)
--- PASS: TestPkgIsCandidate/hidden_internal (0.00s)
--- PASS: TestPkgIsCandidate/visible_internal (0.00s)
--- PASS: TestPkgIsCandidate/invisible_vendor (0.00s)
--- PASS: TestPkgIsCandidate/visible_vendor (0.00s)
--- PASS: TestPkgIsCandidate/match_with_hyphens (0.00s)
--- PASS: TestPkgIsCandidate/match_with_mixed_case (0.00s)
--- PASS: TestPkgIsCandidate/matches_with_hyphen_and_caps (0.00s)
=== RUN TestProcessStdin
--- PASS: TestProcessStdin (0.07s)
=== RUN TestLocalPackagePromotion
=== RUN TestLocalPackagePromotion/GOPATH
=== RUN TestLocalPackagePromotion/GOPATH_GoPackages
--- PASS: TestLocalPackagePromotion (1.09s)
--- PASS: TestLocalPackagePromotion/GOPATH (0.11s)
--- PASS: TestLocalPackagePromotion/GOPATH_GoPackages (0.98s)
=== RUN TestFindImportInLocalGoFiles
=== RUN TestFindImportInLocalGoFiles/GOPATH
=== RUN TestFindImportInLocalGoFiles/GOPATH_GoPackages
--- PASS: TestFindImportInLocalGoFiles (0.00s)
--- PASS: TestFindImportInLocalGoFiles/GOPATH (0.00s)
--- PASS: TestFindImportInLocalGoFiles/GOPATH_GoPackages (0.00s)
=== RUN TestInMemoryFile
=== RUN TestInMemoryFile/GOPATH
=== RUN TestInMemoryFile/GOPATH_GoPackages
--- PASS: TestInMemoryFile (0.00s)
--- PASS: TestInMemoryFile/GOPATH (0.00s)
--- PASS: TestInMemoryFile/GOPATH_GoPackages (0.00s)
=== RUN TestImportNoGoFiles
--- PASS: TestImportNoGoFiles (0.00s)
=== RUN TestProcessLargeToken
=== RUN TestProcessLargeToken/GOPATH
=== RUN TestProcessLargeToken/GOPATH_GoPackages
--- PASS: TestProcessLargeToken (0.05s)
--- PASS: TestProcessLargeToken/GOPATH (0.03s)
--- PASS: TestProcessLargeToken/GOPATH_GoPackages (0.02s)
PASS
ok golang.org/x/tools/imports 29.486s
=== RUN TestFastWalk_Basic
--- PASS: TestFastWalk_Basic (0.00s)
=== RUN TestFastWalk_LongFileName
--- PASS: TestFastWalk_LongFileName (0.00s)
=== RUN TestFastWalk_Symlink
--- PASS: TestFastWalk_Symlink (0.00s)
=== RUN TestFastWalk_SkipDir
--- PASS: TestFastWalk_SkipDir (0.00s)
=== RUN TestFastWalk_SkipFiles
--- PASS: TestFastWalk_SkipFiles (0.00s)
=== RUN TestFastWalk_TraverseSymlink
--- PASS: TestFastWalk_TraverseSymlink (0.00s)
PASS
ok golang.org/x/tools/internal/fastwalk 0.416s
=== RUN TestShouldTraverse
--- PASS: TestShouldTraverse (0.00s)
=== RUN TestSkip
2019/01/30 13:25:55 scanning /tmp/goimports-501566396/src
2019/01/30 13:25:55 Read /tmp/goimports-501566396/src/.goimportsignore
2019/01/30 13:25:55 Directory added to ignore list: /tmp/goimports-501566396/src/ignoreme
2019/01/30 13:25:55 Directory added to ignore list: /tmp/goimports-501566396/src/v
2019/01/30 13:25:55 Directory added to ignore list: /tmp/goimports-501566396/src/mod
2019/01/30 13:25:55 scanned /tmp/goimports-501566396/src
--- PASS: TestSkip (0.01s)
PASS
ok golang.org/x/tools/internal/gopathwalk 0.372s
=== RUN TestPlainCall
--- PASS: TestPlainCall (0.00s)
=== RUN TestHeaderCall
--- PASS: TestHeaderCall (0.00s)
PASS
ok golang.org/x/tools/internal/jsonrpc2 0.268s
=== RUN TestLSP
=== RUN TestLSP/GOPATH
=== RUN TestLSP/GOPATH/Completion
=== RUN TestLSP/GOPATH/Diagnostics
=== RUN TestLSP/GOPATH/Format
=== RUN TestLSP/GOPATH/Definitions
=== RUN TestLSP/GOPATH/TypeDefinitions
--- FAIL: TestLSP (8.19s)
--- FAIL: TestLSP/GOPATH (8.19s)
--- PASS: TestLSP/GOPATH/Completion (4.44s)
--- FAIL: TestLSP/GOPATH/Diagnostics (1.63s)
lsp_test.go:163: diagnostics failed for /tmp/TestLSP_GOPATH887962622/lsp/src/golang.org/x/tools/internal/lsp/format/bad_format.go:
expected:
Error: from LSP at 12:6Β¦7: x declared but not used
got:
Error: from LSP at 4:2Β¦1: could not import fmt (invalid package name: "")
Error: from LSP at 5:2Β¦1: could not import runtime (invalid package name: "")
Error: from LSP at 7:2Β¦1: could not import log (invalid package name: "")
Error: from LSP at 12:6Β¦7: x declared but not used
--- PASS: TestLSP/GOPATH/Format (0.00s)
--- PASS: TestLSP/GOPATH/Definitions (1.60s)
--- PASS: TestLSP/GOPATH/TypeDefinitions (0.00s)
FAIL
FAIL golang.org/x/tools/internal/lsp 8.436s
? golang.org/x/tools/internal/lsp/cache [no test files]
? golang.org/x/tools/internal/lsp/cmd [no test files]
? golang.org/x/tools/internal/lsp/protocol [no test files]
=== RUN TestURI
--- PASS: TestURI (0.00s)
PASS
ok golang.org/x/tools/internal/lsp/source 0.306s
=== RUN TestCheck
--- PASS: TestCheck (0.00s)
=== RUN TestCheckPath
--- PASS: TestCheckPath (0.00s)
=== RUN TestSplitPathVersion
--- PASS: TestSplitPathVersion (0.00s)
=== RUN TestEncodePath
--- PASS: TestEncodePath (0.00s)
=== RUN TestDecodePath
--- PASS: TestDecodePath (0.00s)
PASS
ok golang.org/x/tools/internal/module 0.445s
=== RUN TestIsValid
--- PASS: TestIsValid (0.00s)
=== RUN TestCanonical
--- PASS: TestCanonical (0.00s)
=== RUN TestMajor
--- PASS: TestMajor (0.00s)
=== RUN TestMajorMinor
--- PASS: TestMajorMinor (0.00s)
=== RUN TestPrerelease
--- PASS: TestPrerelease (0.00s)
=== RUN TestBuild
--- PASS: TestBuild (0.00s)
=== RUN TestCompare
--- PASS: TestCompare (0.00s)
=== RUN TestMax
--- PASS: TestMax (0.00s)
PASS
ok golang.org/x/tools/internal/semver 0.364s
? golang.org/x/tools/internal/tool [no test files]
=== RUN Test
=== RUN Test/basic
--- PASS: Test (0.00s)
--- PASS: Test/basic (0.00s)
PASS
ok golang.org/x/tools/internal/txtar 0.302s
? golang.org/x/tools/playground [no test files]
=== RUN TestBuffer
--- PASS: TestBuffer (0.00s)
=== RUN TestLimiter
--- PASS: TestLimiter (0.01s)
PASS
ok golang.org/x/tools/playground/socket 0.274s
=== RUN TestParseCode
--- PASS: TestParseCode (0.00s)
=== RUN TestInlineParsing
--- PASS: TestInlineParsing (0.00s)
=== RUN TestSplit
--- PASS: TestSplit (0.00s)
=== RUN TestFont
--- PASS: TestFont (0.00s)
=== RUN TestStyle
--- PASS: TestStyle (0.00s)
=== RUN ExampleStyle
--- PASS: ExampleStyle (0.00s)
PASS
ok golang.org/x/tools/present 0.249s
? golang.org/x/tools/refactor/eg [no test files]
? golang.org/x/tools/refactor/importgraph [no test files]
=== RUN TestErrors
While scanning Go workspace:
Package "foo": /go/src/foo/0.go:1:1: expected 'package', found 'EOF'.
/go/src/foo/0.go:1:1: expected 'package', found 'EOF'
--- PASS: TestErrors (0.01s)
=== RUN TestMoves
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
--- PASS: TestMoves (0.04s)
=== RUN TestConflicts
Renamed 1 occurrence in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 3 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
--- PASS: TestConflicts (0.05s)
=== RUN TestInvalidIdentifiers
--- PASS: TestInvalidIdentifiers (0.00s)
=== RUN TestRewrites
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 2 files in 2 packages.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 4 occurrences in 1 file in 1 package.
Renamed 4 occurrences in 1 file in 1 package.
Renamed 4 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 3 occurrences in 2 files in 2 packages.
Renamed 3 occurrences in 2 files in 2 packages.
Renamed 3 occurrences in 2 files in 2 packages.
Renamed 5 occurrences in 1 file in 1 package.
Renamed 5 occurrences in 1 file in 1 package.
Renamed 3 occurrences in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
Renamed 1 occurrence in 1 file in 1 package.
Renamed 2 occurrences in 1 file in 1 package.
/go/src/main/0.go:4:6: unused declared but not used
Renamed 2 occurrences in 1 file in 1 package.
--- PASS: TestRewrites (0.05s)
=== RUN TestDiff
--- SKIP: TestDiff (0.00s)
rename_test.go:1287: Test disabled on gccgo.
PASS
ok golang.org/x/tools/refactor/rename 0.417s
? golang.org/x/tools/refactor/satisfy [no test files]
```
To reproduce on Debian unstable:
```
$ git clone https://salsa.debian.org/go-team/packages/golang-go.tools.git
$ sudo apt-get build-dep golang-golang-x-tools
$ sudo apt-get install gccgo-go
$ cd golang-golang-x-tools
$ dpkg-buildpackage -B
```
<\details>
Installing ```golang-go``` instead of ```gccgo-go``` fixes the testsuite, so it's an issue related to gccgo.
CC @jrtc27 @ianlancetaylor | NeedsInvestigation,Analysis | low | Critical |
404,807,095 | flutter | Wrapped Text has unexpected intrinsic size | I'd expect wrapped Text to have an intrinsic size that fits the text. However, if I wrap such a text with an `IntrinsicHeight` widget, the height includes the first line, only. If wrapped with an `IntrinsicWidth` widget, on the other hand, the width does not only fit the text, but stretches to the available width.
Here is an example for "intrinsic height only includes the first line" (the yellow box should include all three lines):
```dart
class TestPage extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: IntrinsicHeight(
child: Container(
color: Colors.black12,
width: 105,
alignment: Alignment.centerLeft,
child: IntrinsicWidth(
child: Container(
color: Colors.yellow,
child: Text("Hallo! dies sollte umbrechen"),
),
),
),
),
),
);
}
}
```
Here is an example for "intrinsic width stretches to available width" (the yellow box should be left-aligned and stop at the "n" in the third line):
```dart
class TestPage extends StatelessWidget {
@override
Widget build(BuildContext context) {
return Scaffold(
body: Center(
child: Container(
color: Colors.back12,
width: 105,
height: 105,
alignment: Alignment.centerLeft,
child: IntrinsicWidth(
child: Container(
color: Colors.yellow,
child: Text("Hallo! dies sollte umbrechen"),
),
),
),
),
);
}
}
```
My Flutter version:
```sh
$ flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[β] Flutter (Channel master, v1.1.10-pre.220, on Mac OS X 10.14.2 18C54, locale de-DE)
[β] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
[β] iOS toolchain - develop for iOS devices (Xcode 10.1)
[β] Android Studio (version 3.3)
[β] VS Code (version 1.30.2)
[β] Connected device (1 available)
``` | framework,a: typography,has reproducible steps,P2,found in release: 3.7,found in release: 3.8,team-framework,triaged-framework | low | Critical |
404,849,630 | go | go/parser: keep parsing after error limit is reached? | This issue and repro case was raised by @rogpeppe:
This file fails to parse:
```go
package m
func _() {
_(_
}
func _() {
if _ {
_
}
if _ {
}
_ = _
if _ {
_
}
}
```
However, commenting out one line (unrelated to the error) causes the file to parse correctly.
```go
package m
func _() {
_(_
}
func _() {
if _ {
_
}
if _ {
}
// _ = _
if _ {
_
}
}
```
| NeedsInvestigation | low | Critical |
404,899,054 | vscode | Revealing in the editor should be aware of how much space the command palette is using | Was trying to navigate symbols but I couldn't see the active symbol:
This was with editor.zoomLevel: 0 and and terminal with 13 rows active. | feature-request,quick-pick | low | Minor |
404,911,538 | opencv | UBSan runtime errors in imgproc/src/drawing.cpp | ##### System information (version)
- OpenCV => 3.1.0
- Operating System / Platform => Fedora 28
- Compiler => Clang 7.0 @2018/10/09
##### Detailed description
The imgproc drawing.cpp code relies upon undefined behavior in the C++ compiler to handle its translation between integral and fixed point position representations, which cause failures in UndefinedBehaviorSanitizer and indicate that the code could break in other compiler versions.
From examining and trying to patch up the code, there are some systemic issues with this code. It converts integral points to an internal fixed-point representation by left-shifting the incoming coordinates by 16 bits, or less if the incoming position data from the API call is specified to already be in a fixed point format. It then shifts them back right to the integral format as appropriate during and after execution.
This happens to work when those values are negative because C++ compilers historically treat such operations on negative values as if they were casted to unsigned first and then casted back. However, that is undefined behavior in the C++ standard and could theoretically break, which is why the sanitizer complains.
This breaks OpenCV in codebases that are compiling it from source with these sanitizers enabled.
A possible fix would be to add helper functions for doing the conversions to/from these representations that does the casting to unsigned before the shifts and then back to the signed representation explicitly. Even better would be to create internal type wrappers for these representations that do these conversions automatically to make it harder to forget to do them in the proper way at each conversion point.
Also, line 1118 should change from:
`ptr += img.step*y;`
...to:
`ptr += static_cast<int>(img.step)*y;`
...as the undefined behavior sanitizer is detecting the result of this operation as an underflow when y is negative because of the lack of explicit casting as img.step is unsigned.
##### Steps to reproduce
1. Build OpenCV with [UndefinedBehaviorSanitizer](http://clang.llvm.org/docs/UndefinedBehaviorSanitizer.html).
2. Run code that uses the imgproc drawing module to draw shapes near borders of an image.
Result:
Errors like:
```
opencv/src/modules/imgproc/src/drawing.cpp:701:37: runtime error: left shift of negative value -158218
#0 0x000000000d22f160 in __ubsan::ScopedReport::~ScopedReport() ()
#1 0x000000000d23116e in handleShiftOutOfBoundsImpl(__ubsan::ShiftOutOfBoundsData*, unsigned long, unsigned long, __ubsan::ReportOptions) ()
#2 0x000000000d2337c0 in __ubsan_handle_shift_out_of_bounds_abort ()
#3 0x000000000903c40f in cv::Line2 (img=..., pt1=..., pt2=..., color=0x7fffc1e7a680) at .../opencv/src/modules/imgproc/src/drawing.cpp:701
#4 0x000000000900f9fd in cv::FillConvexPoly (img=..., v=0x7fffc1e79da0, npts=4, color=0x7fffc1e7a680, line_type=8, shift=16) at .../opencv/src/modules/imgproc/src/drawing.cpp:1105
#5 0x000000000900bbd2 in cv::ThickLine (img=..., p0=..., p1=..., color=0x7fffc1e7a680, thickness=98304, line_type=8, flags=3, shift=0) at .../opencv/src/modules/imgproc/src/drawing.cpp:1615
#6 0x00000000090097a3 in cv::line (_img=..., pt1=..., pt2=..., color=..., thickness=3, line_type=8, shift=0) at .../opencv/src/modules/imgproc/src/drawing.cpp:1746
#7 0x000000000900c9f8 in cv::arrowedLine (img=..., pt1=..., pt2=..., color=..., thickness=3, line_type=8, shift=0, tipLength=0.10000000000000001) at .../opencv/src/modules/imgproc/src/drawing.cpp:1760
...
``` | priority: low | low | Critical |
404,970,074 | opencv | Compilation (master with contrib) fails at debayer.cu compilation | Compilation fails with : i:\opencv-master\opencv\modules\core\include\opencv2\core\cuda\detail/color_detail.hpp(535): error : dynamic initializa
tion is not supported for a __constant__ variable [I:\opencv-master\build\modules\cudaimgproc\opencv_cudaimgproc.vcxpro
j]
i:\opencv-master\opencv\modules\core\include\opencv2\core\cuda\detail/color_detail.hpp(584): error : dynamic initializa
tion is not supported for a __constant__ variable [I:\opencv-master\build\modules\cudaimgproc\opencv_cudaimgproc.vcxpro
j]
i:\opencv-master\opencv\modules\core\include\opencv2\core\cuda\detail/color_detail.hpp(674): error : dynamic initializa
tion is not supported for a __constant__ variable [I:\opencv-master\build\modules\cudaimgproc\opencv_cudaimgproc.vcxpro
j]
i:\opencv-master\opencv\modules\core\include\opencv2\core\cuda\detail/color_detail.hpp(751): error : dynamic initializa
tion is not supported for a __constant__ variable [I:\opencv-master\build\modules\cudaimgproc\opencv_cudaimgproc.vcxpro
j]
##### System information (version)
- OpenCV => master (from git, from now)
- Operating System / Platform => Windows 10 64bits
- Compiler => Visual Studio 2017
- cmake 3.13.3 64bits
- cuda 10
##### Detailed description
Building NVCC (Device) object modules/cudaimgproc/CMakeFiles/cuda_compile_1.dir/src/cuda/Release/cuda_compile_1_gener
ated_debayer.cu.obj
debayer.cu
i:\opencv-master\opencv\modules\core\include\opencv2\core\cuda\detail/color_detail.hpp(535): error : dynamic initializa
tion is not supported for a __constant__ variable [I:\opencv-master\build\modules\cudaimgproc\opencv_cudaimgproc.vcxpro
j]
i:\opencv-master\opencv\modules\core\include\opencv2\core\cuda\detail/color_detail.hpp(584): error : dynamic initializa
tion is not supported for a __constant__ variable [I:\opencv-master\build\modules\cudaimgproc\opencv_cudaimgproc.vcxpro
j]
i:\opencv-master\opencv\modules\core\include\opencv2\core\cuda\detail/color_detail.hpp(674): error : dynamic initializa
tion is not supported for a __constant__ variable [I:\opencv-master\build\modules\cudaimgproc\opencv_cudaimgproc.vcxpro
j]
i:\opencv-master\opencv\modules\core\include\opencv2\core\cuda\detail/color_detail.hpp(751): error : dynamic initializa
tion is not supported for a __constant__ variable [I:\opencv-master\build\modules\cudaimgproc\opencv_cudaimgproc.vcxpro
j]
4 errors detected in the compilation of "C:/Users/soleil/AppData/Local/Temp/tmpxft_000018b0_00000000-10_debayer.cpp1.
ii".
##### Steps to reproduce
cmake -G $target -T v141, host=x64 -j8 `
-DBUILD_JAVA=0 -DWITH_MATLAB=0 -DBUILD_DOC=0 -DBUILD_PERF_TESTS=0 -DBUILD_TESTS=0 -DBUILD_opencv_world=0 `
-DOPENCV_ENABLE_NONFREE=1 -DBUILD_opencv-apps=0 -DENABLE_PYLINT=0 -DENABLE_CXX11=1 -DWITH_VTK=1 `
-DCUDA_SDK_ROOT_DIR="$env:CUDA_PATH" -DCUDA_ARCH_BIN="5.2" -DCUDA_VERBOSE_BUILD=0 -DBUILD_CUDA_STUBS=0 `
-DWITH_OPENCL=1 -DWITH_CUDA=1 -DMKL_WITH_OPENMP=1 -DMKL_WITH_TBB=1 `
-DOPENCV_EXTRA_MODULES_PATH="../opencv_contrib/modules" `
-DINSTALL_CREATE_DISTRIB=1 -DCPACK_BINARY_ZIP=1 -DCPACK_SOURCE_ZIP=1 -DCMAKE_VERBOSE_MAKEFILE=0 `
../opencv | Tee-Object -Variable RESULT | category: build/install,category: gpu/cuda (contrib) | low | Critical |
405,030,612 | flutter | Embedder proc resolver API requires questionable cast | Following on from discussion [here](https://github.com/google/flutter-desktop-embedding/pull/184#pullrequestreview-188183991).
Unless I'm confused, the current API requires clients to cast between a function pointer and an object pointer (void*). The standard does *not* require that this is a safe/valid cast, which means that on some platforms this might explode. Even where it does work, it requires a reinterpret_cast, which is not ideal.
It seems like the type should be using a generic function pointer (`void*(*)()`), not a generic object pointer (`void*`).
| engine,a: quality,e: embedder,P2,team-engine,triaged-engine | low | Minor |
405,049,299 | TypeScript | Readonly type breaks Set and Map | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
// A *self-contained* demonstration of the problem follows...
// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
```
**Expected behavior:**
However, Set and Map can't use with es3 and es5. We need any workaround.
```ts
export type Readonly<T> =
T extends ReadonlySet<infer V> ? ReadonlySet<V> :
T extends ReadonlyMap<infer K, infer V> ? ReadonlyMap<K, V> :
{ readonly [P in keyof T]: T[P]; };
```
**Actual behavior:**
```ts
type Readonly<T> = {
readonly [P in keyof T]: T[P];
};
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Suggestion,In Discussion | low | Critical |
405,054,406 | pytorch | Make sure `data_ptr` for non-zero-size input tensors stays the same after the VariableType dispatch | In VariableType.cpp, https://github.com/pytorch/pytorch/pull/16305 adds checks to make sure we are still using the same input `TensorImpl` and `Storage` after we call the non-autograd in-place function. However, it is still possible that the in-place function changes the `data_ptr` of the input tensors without changing `TensorImpl` or `Storage` (e.g. by calling `tensor.resize_({bigger_than_original})`. If the input tensors have 0-size, then we expect this behavior to happen and all is good; if the input tensors have non-zero-size and is smaller than needed, we want to tell the user to resize their input tensors to the correct size before passing them into the VariableType function, to prevent `tensor.resize_({size_needed})` from allocating a new `data_ptr` and to make sure the buffer they pass in would be the buffer that contains the returned data.
cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer @Lezcano @Varal7 | module: autograd,module: molly-guard,triaged,module: assert failure | low | Minor |
405,057,497 | pytorch | Benchmarking pre-trained model in Caffe2 | If you have a question or would like help and support, please ask at our
[forums](https://discuss.pytorch.org/).
If you are submitting a feature request, please preface the title with [feature request].
If you are submitting a bug report, please fill in the following details.
## Issue description
I am trying to benchmark Caffe2 framework. In the pytorch I see the convnet python script
to do benchmarking. We have to defined the ML network in this python script.
But this python script does not accept any pre-trained caffe2 model.
How can I run a pre-trained model and do benchmarking in Caffe2?
Provide a short description.
## Code example
Please try to provide a minimal example to repro the bug.
Error messages and stack traces are also helpful.
## System Info
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).
You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```
- PyTorch or Caffe2:
- How you installed PyTorch (conda, pip, source):
- Build command you used (if compiling from source):
- OS:
- PyTorch version:
- Python version:
- CUDA/cuDNN version:
- GPU models and configuration:
- GCC version (if compiling from source):
- CMake version:
- Versions of any other relevant libraries:
| caffe2 | low | Critical |
405,060,481 | pytorch | [JIT] NVRTC unknown error | ## π Bug
I have consistently run into NVRTC unknown error.
```RuntimeError: /pytorch-atg/torch/csrc/jit/fuser/cuda/fused_kernel.cpp:138: NVRTC_ERROR unknown```
I ran with `export PYTORCH_FUSION_DEBUG=1`
and I got this:
```
fusion code:
typedef unsigned char uint8_t;
typedef signed char int8_t;
typedef short int int16_t;
typedef long long int int64_t;
#define NAN __int_as_float(0x7fffffff)
#define POS_INFINITY __int_as_float(0x7f800000)
#define NEG_INFINITY __int_as_float(0xff800000)
typedef unsigned int IndexType;
template<typename T, size_t N>
struct TensorInfo {
T* data;
IndexType sizes[N];
IndexType strides[N];
};
template<typename T>
struct TensorInfo<T, 0> {
T * data;
};
extern "C" __global__
void kernel_0(IndexType totalElements, TensorInfo<float,1> t0, TensorInfo<float,1> t1, TensorInfo<float,1> t2 ) {
for (IndexType linearIndex = blockIdx.x * blockDim.x + threadIdx.x;
linearIndex < totalElements;
linearIndex += gridDim.x * blockDim.x) {
// Convert `linearIndex` into an offset of tensor:
IndexType t0_offset = 0;
IndexType t0_linearIndex = linearIndex;
//printf("tensor t0 sizes[0] = %d, strides[0] = %d\n", t0.sizes[0],t0.strides[0]);
size_t t0_dimIndex0 = t0_linearIndex ;
t0_offset += t0_dimIndex0 * t0.strides[0];
IndexType t1_offset = 0;
IndexType t1_linearIndex = linearIndex;
//printf("tensor t1 sizes[0] = %d, strides[0] = %d\n", t1.sizes[0],t1.strides[0]);
size_t t1_dimIndex0 = t1_linearIndex ;
t1_offset += t1_dimIndex0 ;
IndexType t2_offset = 0;
IndexType t2_linearIndex = linearIndex;
//printf("tensor t2 sizes[0] = %d, strides[0] = %d\n", t2.sizes[0],t2.strides[0]);
size_t t2_dimIndex0 = t2_linearIndex ;
t2_offset += t2_dimIndex0 ;
// calculate the results
float n0 = t0.data[t0_offset];
int n1 = -72;
int n2 = 1;
float n3 = (n0 - ((float) n2)*((float) n1));
float n4 = 5.000000e+00f;
float n5 = n3 * n4;
float n6 = ceilf(n5);
int n7 = 0;
int n8 = 721;
float n9 = (n6<n7?n7:(n6>n8?n8:n6));
t1.data[t1_offset] = n9;
t2.data[t2_offset] = n6;
}
}
Traceback (most recent call last):
File "/av/python/av/experimental/toronto/experiments/intentnet/train.py", line 436, in <module>
sys.exit(main())
File "/av/python/av/experimental/toronto/experiments/intentnet/train.py", line 428, in main
trainer.train_model()
File "/av/python/av/experimental/toronto/experiments/intentnet/train.py", line 258, in train_model
should_run_eval = self.train()
File "/av/python/av/experimental/toronto/experiments/intentnet/train.py", line 181, in train
voxel_img = self.preprocessor(batched_frames)
File "/av/lib/python/torch/nn/modules/module.py", line 489, in __call__
result = self.forward(*input, **kwargs)
RuntimeError: /pytorch-atg/torch/csrc/jit/fuser/cuda/fused_kernel.cpp:138: NVRTC_ERROR unknown
```
## To Reproduce
I am unable to repro yet. I am working on a minimum repro at the moment
cc @ezyang @gchanan @zou3519 @suo | needs reproduction,oncall: jit,has workaround | medium | Critical |
405,081,769 | pytorch | Feature Request: Earth Mover's Distance Loss | ## π Feature
(Approximate) Earth Mover's Distance Loss Function
## Motivation
This is a common function used in deep learning papers for point cloud generation and distribution matching.
## Pitch
This ought to be added to the loss function library as it is only increasing in usage in deep learning literature.
## Additional context
There are a few open source implementations out there already. I have updated [this older one](https://github.com/fxia22/pointGAN/tree/74b6c432c5eaa1e0a833e755f450df2ee2c5488e/emd) for PyTorch 1.0 according to the CUDA extension tutorial. While it generally works, there are some bugs though that go beyond my expertise (or understanding) when it comes to larger point sets. These bugs were extant before I started toying with it. My version [can be found here](https://github.com/meder411/PyTorch-EMDLoss). | module: loss,triaged,function request | low | Critical |
405,099,184 | pytorch | Error while installing pytorch | I am trying to install pytorch with caffe2 support. After cloning the library, I ran this command:
> FULL_CAFFE2=1 python setup.py install
Error
```
make: *** No rule to make target 'install'. Stop.
Traceback (most recent call last):
File "setup.py", line 720, in <module>
build_deps()
File "setup.py", line 279, in build_deps
build_dir='build')
File "/home/afzal/mmdnn_test/pytorch/tools/build_pytorch_libs.py", line 227, in build_caffe2
check_call(['make', '-j', str(max_jobs), 'install'], cwd=build_dir)
File "/usr/lib/python3.5/subprocess.py", line 581, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['make', '-j', '12', 'install']' returned non-zero exit status 2
```
Any help? | module: build,caffe2 | medium | Critical |
405,183,069 | flutter | Debug console spew from WebView plugin on Android | When running WebView widget on Android Simulator I see constant stream of messages in the console like the following:
```
I/zygote ( 5185): NativeAlloc concurrent copying GC freed 14(32KB) AllocSpace objects, 0(0B) LOS objects, 49% free, 1597KB/3MB, paused 271us total 241.543ms
W/zygote ( 5185): Attempt to remove non-JNI local reference, dumping thread
W/zygote ( 5185): Attempt to remove non-JNI local reference, dumping thread
W/zygote ( 5185): Attempt to remove non-JNI local reference, dumping thread
W/zygote ( 5185): Attempt to remove non-JNI local reference, dumping thread
I/zygote ( 5185): NativeAlloc concurrent copying GC freed 18(63KB) AllocSpace objects, 0(0B) LOS objects, 49% free, 1598KB/3MB, paused 37us total 409.673ms
W/zygote ( 5185): Attempt to remove non-JNI local reference, dumping thread
W/zygote ( 5185): Attempt to remove non-JNI local reference, dumping thread
W/zygote ( 5185): Attempt to remove non-JNI local reference, dumping thread
I/zygote ( 5185): NativeAlloc concurrent copying GC freed 16(47KB) AllocSpace objects, 0(0B) LOS objects, 49% free, 1598KB/3MB, paused 7.778ms total 253.467ms
W/zygote ( 5185): Attempt to remove non-JNI local reference, dumping thread
I/zygote ( 5185): NativeAlloc concurrent copying GC freed 21(64KB) AllocSpace objects, 0(0B) LOS objects, 49% free, 1550KB/3MB, paused 25us total 159.171ms
```
Is it OK or is there some kind of issue? | platform-android,a: quality,p: webview,package,has reproducible steps,P2,found in release: 3.10,found in release: 3.11,team-android,triaged-android | low | Critical |
405,227,835 | godot | Materials are rendering black if there are no lights in the scene (Intel driver bug) | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:3.1**
<!-- Specify commit hash if non-official. -->
**OS/device including version:Windows 7 64 bit**
Intel g41 express chipset
Open Gl 2.1
<!-- Specify GPU model and drivers if graphics-related. -->
**Issue description:** I used GLES2 renderer. Adding a mesh instance gives a completely black cube. Adding materials has no effect. The sky is rendering as it should. Using mesa3d as a open GL 3.1 fixes this problem. Otherwise it occurs on every project
<!-- What happened, and what was expected. -->
**Steps to reproduce:** Add a cube in Godot 3.1 on intel g41 express on GLES2 project
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
| bug,platform:windows,topic:rendering,confirmed,topic:thirdparty,topic:3d | medium | Critical |
405,313,862 | rust | Unnecessary implicit reborrow cause confusing compiler error | When calling a function with mutable reference itself, it will cause unnecessary implicit reborrow, which may produces "cannot borrow ... because it is also borrowed as mutable", though there is "no borrow" in the error line.
[Example](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=5276b24d3ddd33dcd50b62f26dac17dd)
I think there should be no reborrowing in all 3 calls, and the expected error message should be "borrow of moved value" here.
```rust
pub fn id<'a, T>(x: T) -> T { x }
pub fn id_ref<'a, T: 'a>(x: &'a mut T) -> &'a mut T { x }
fn main() {
let p = &mut 0i32;
let q = id_ref(p); // error[E0502]: cannot borrow `p` as immutable because it is also borrowed as mutable
// let q = id(&mut *p); // error[E0502]: cannot borrow `p` as immutable because it is also borrowed as mutable
// let q = id(p); // error[E0382]: borrow of moved value: `p`
println!("{}", p);
q; // Keep `q` lives here
}
```
Noting that the call to `id_ref` causes reborrowing, but the call to `id` doesn't.
I'm not sure whether it is the expected behavior.
| C-enhancement,A-diagnostics,T-compiler,D-papercut | low | Critical |
405,366,338 | go | x/build/cmd/gerritbot: not possible to make cherry-pick CLs via PRs | I investigated whether it's possible to create cherry-pick CLs by making a Pull Request, a question that was brought up on the golang-dev mailing list [here](https://groups.google.com/d/msg/golang-dev/Tc8OlLRsju0/AysH6zdeAwAJ) and in issue #25020.
In order to learn whether it's supported, I made an attempt and learned from the experience:
- Backport issue - https://github.com/golang/go/issues/29922#issuecomment-457381644
- Cherry-pick PR I created - PR #29926
- Cherry-pick CL that gerritbot imported - [CL 159478](https://golang.org/cl/159478)
It was possible to create the cherry-pick CL against the correct release branch by having the appropriate base branch in the PR.
However, gerritbot does not recognize it when the PR description contains Change-Id and other lines from the commit being backported. In the PR, the description ended with:
```
<body>
Change-Id: I09a2212eb74c63db575223277aec363c55421ed8
Reviewed-on: https://go-review.googlesource.com/c/159157
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Filippo Valsorda <[email protected]>
```
In the imported CL, the commit message ended up having:
```
<body>
Change-Id: I09a2212eb74c63db575223277aec363c55421ed8
Reviewed-on: https://go-review.googlesource.com/c/159157
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Filippo Valsorda <[email protected]>
Change-Id: I09a2212eb74c63db575223277aec363c55421ed8
GitHub-Last-Rev: 396cc6b3a61292ccbe3ccad4e55c3a9842145cab
GitHub-Pull-Request: golang/go#29926
```
In order for it to be possible to make cherry-pick CLs via gerritbot, it would need to gain support for recognizing when the PR description contains `Change-Id` lines from the original commit, and reuse it. So the final commit message imported by gerritbot would need to look something like:
```
<body>
Change-Id: I09a2212eb74c63db575223277aec363c55421ed8
Reviewed-on: https://go-review.googlesource.com/c/159157
Run-TryBot: Brad Fitzpatrick <[email protected]>
TryBot-Result: Gobot Gobot <[email protected]>
Reviewed-by: Filippo Valsorda <[email protected]>
GitHub-Last-Rev: 396cc6b3a61292ccbe3ccad4e55c3a9842145cab
GitHub-Pull-Request: golang/go#29926
```
Until this is resolved, it's not possible to send cherry-pick CLs via Pull Requests. /cc @andybons | Builders,NeedsInvestigation,FeatureRequest | low | Minor |
405,372,476 | go | xerrors: allow accessing the frame for each error directly | When using structured logging with errors, we don't want a string representation of the error + the frame, we want to access the error string, function name and file:line separately to make them separate fields in the UI and to make it easier to analyze logs. For now, I've written an `xerrors.printer` that just stores all lines that are printed to it and then returns those and based on `xerrors` atm, the first line is the error message, second is the function and third is the file name. But this is janky and fragile.
An easy way to do this is to add an interface to the package that errors can implement to return their frames. | NeedsDecision | low | Critical |
405,436,533 | vscode | Auto-indent on closing brace | VSCode Version: Code 1.30.2
OS Version: Windows_NT x64 10.0.17763
Extensions: Extensions are enabled
on typing the closing brace. Meaning VSCode should take the current tab indentation size in account and auto-indent the code-block when typing the closing brace. | feature-request,typescript,javascript,editor-autoindent,on-unit-test | medium | Critical |
405,502,220 | flutter | Add lints to catch common DiagnosticsProperty related bugs | The goal of these lints is to catch cases where a developer added properties to a class implementing Diagnosticable class but forgot to update the debugFillProperties method to include the properties.
Additionally we can add lints for trivial to spot cases where the right DiagnosticsProperty subclass wasn't used for a particular value type.
## Candidate lints to add:
* Lint that warns about properties that exist in a class but are not referenced by debugFillProperties. Key for this lint being useful is to keep false positives to a minimum by counting any reference to a property in the debugFillProperties or describeChildren calls and providing an escape hatch.
* Lint that warns when a DiagnosticsProperty is used instead of EnumProperty for values of type enum.
* Lint that warns when DiagnosticsProperty is used instead of StringProperty, IntProperty, or DoubleProperty for a value of type String, int, or Double.
* Lint that returns an error if EnumProperty is used with a type that isn't an enum (if Dart's type system had an enum base class we wouldn't have to do it).
* Lint that warns when DiagnosticsProperty is used instead of TransformProperty for Matrix objects.
Example bug that would have been caught earlier if we had a lint for EnumProperty: https://github.com/flutter/flutter/pull/27224/files
There are cases where a class has properties that are never mentioned anywhere inside the contents of debugFillProperties and that is a good thing as the property value is not useful to show for debugging. Much of the value of debugFillProperties vs simply showing all properties is the curation of what properties are relevant to show.
Provide an escape hatch annotation in `package:meta` perhaps called `@debuggerHidden` that when applied to a properties or fields indicates that it is intentional that they are excluded from debugFillProperties. The lint warning for missing properties will specify exactly the change you need to make to add the annotation to properly mark the properties as intentionally omitted.
The annotation is a generally useful feature for debuggers with prior art of similar work in many platforms. For example [.net ](https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.debuggerhiddenattribute?view=netframework-4.7.2)provides a debuggerHiddenAttribute annotation indicating fields to hide by default in debuggers.
With this annotations Dart debugging tools such as VSCode can do a better job of displaying objects as they know which properties are useful to users and which should be hidden by default.
Example of how this would apply to the Element class:
```dart
class Element {
bool _dirty = true;
// Whether this is in owner._dirtyElements. This is used to know whether we
// should be adding the element back into the list when it's reactivated.
@hideForDebugging bool _inDirtyList = false;
@override
void debugFillProperties(DiagnosticPropertiesBuilder properties) {
super.debugFillProperties(properties);
properties.defaultDiagnosticsTreeStyle= DiagnosticsTreeStyle.dense;
properties.add(ObjectFlagProperty<int>('depth', depth, ifNull: 'no depth'));
properties.add(ObjectFlagProperty<Widget>('widget', widget, ifNull: 'no widget'));
if (widget != null) {
properties.add(DiagnosticsProperty<Key>('key', widget?.key, showName: false, defaultValue: null, level: DiagnosticLevel.hidden));
widget.debugFillProperties(properties);
}
properties.add(FlagProperty('dirty', value: dirty, ifTrue: 'dirty'));
}
}
````
Additional example:
There was a bug in the debugFillProperty method for UnconstrainedBox where the value of 'constrainedAxis' was always set to null and a property that was an EnumProperty was not listed as an EnumProperty which misses the nice EnumProperty syntax.
```dart
class UnconstrainedBox extends SingleChildRenderObjectWidget {
/// Creates a widget that imposes no constraints on its child, allowing it to
/// render at its "natural" size. If the child overflows the parents
/// constraints, a warning will be given in debug mode.
const UnconstrainedBox({
Key key,
Widget child,
this.textDirection,
this.alignment = Alignment.center,
this.constrainedAxis,
}) : assert(alignment != null),
super(key: key, child: child);
/// The text direction to use when interpreting the [alignment] if it is an
/// [AlignmentDirectional].
final TextDirection textDirection;
/// The alignment to use when laying out the child.
///
/// If this is an [AlignmentDirectional], then [textDirection] must not be
/// null.
///
/// See also:
///
/// * [Alignment] for non-[Directionality]-aware alignments.
/// * [AlignmentDirectional] for [Directionality]-aware alignments.
final AlignmentGeometry alignment;
/// The axis to retain constraints on, if any.
///
/// If not set, or set to null (the default), neither axis will retain its
/// constraints. If set to [Axis.vertical], then vertical constraints will
/// be retained, and if set to [Axis.horizontal], then horizontal constraints
/// will be retained.
final Axis constrainedAxis; // <-- This is an enum type.
@override
void debugFillProperties(DiagnosticPropertiesBuilder properties) {
super.debugFillProperties(properties);
properties.add(DiagnosticsProperty<AlignmentGeometry>('alignment', alignment));
properties.add(DiagnosticsProperty<Axis>('constrainedAxis', null));
properties.add(DiagnosticsProperty<TextDirection>('textDirection', textDirection, defaultValue: null));
}
}
``` | team,framework,dependency: dart,P2,team-framework,triaged-framework | low | Critical |
405,503,053 | rust | Inconsistencies when exporting dynamic symbols from executables | I'm working on a project that uses dynamic loading with callbacks back into the Rust executable. Now that the project is big enough to require some of these callbacks to be defined in separate crates, I'm finding the behavior of when a symbol is exported or not to be very inconsistent.
I've tried to shrink the issue by creating a repo that contains several variants that do and don't work. The README describes the variations in more detail: https://github.com/acfoltzer/exported-symbol-example
The upshot is that based on #54451, I would expect that any `#[no_mangle]` definitions in both the executable crate and any dependencies to be exported from the final executable, assuming `--export-dynamic` is used for the final link step.
Instead, the exported `#[no_mangle]` callbacks are eliminated from the final executable in many situations. It's not as simple as whether the callbacks are used/reachable directly from `main`, but also seems to be influenced by the use of trait objects that happen to share a module with the callbacks. This doesn't seem like the intended behavior.
## Meta
Reproducible on nightly and stable:
```
% rustc --version --verbose
rustc 1.32.0 (9fda7c223 2019-01-16)
binary: rustc
commit-hash: 9fda7c2237db910e41d6a712e9a2139b352e558b
commit-date: 2019-01-16
host: x86_64-unknown-linux-gnu
release: 1.32.0
LLVM version: 8.0
```
```
%rustc --version --verbose
rustc 1.34.0-nightly (c1c3c4e95 2019-01-29)
binary: rustc
commit-hash: c1c3c4e95b69dfeaca5c5db6c622d7f90ad30a54
commit-date: 2019-01-29
host: x86_64-unknown-linux-gnu
release: 1.34.0-nightly
LLVM version: 8.0
```
| A-FFI | low | Major |
405,548,767 | rust | self-less method missing return type lifetime should suggest adding &self | I frequently find myself forgetting to write the `&self` on methods. In the scenario where I write a method whose return type has a lifetime that I've elided, it would be nice if the compiler could include a note suggesting that I might have meant to add `&self` on the method, instead of (or in addition to) suggesting that I should add `'static`.
Example:
```rust
struct Foo<'a>;
struct Bar;
impl Bar {
fn foos() -> Vec<Foo> {
unimplemented!()
}
}
```
This produces the error
```
error[E0106]: missing lifetime specifier
--> unnamed.rs:6:22
|
6 | fn foos() -> Vec<Foo> {
| ^^^ help: consider giving it a 'static lifetime: `Foo + 'static`
|
= help: this function's return type contains a borrowed value, but there is no value for it to be borrowed from
```
In fact, looking at that error, even the current help is incorrect, I'd want to write `Foo<'static>`, not `Foo + 'static`. | C-enhancement,A-diagnostics,T-compiler | low | Critical |
405,553,077 | godot | 2D Inverse Kinematics: Add a bool property to control the IK's bend orientation | The 2D IKs orient based on how you move bones in the chain. Often the limbs bend the wrong way and there's no control to fix that:
You generally want 2d IKs to bend only one way. in Spine2D, you have a bool property to define and toggle the bend's direction: http://esotericsoftware.com/spine-ik-constraints | enhancement,topic:core | low | Minor |
405,554,057 | godot | 2D Inverse Kinematics only work with the "Make Custom Bones" tool, not Bone2D nodes | "Make IK Chain" doesn't work with Bone2D nodes. Even if you have a chain of Bone2Ds, you must first select them, go to the bones menu in the toolbar and click "Make Custom Bones From Nodes".
Instead, I would expect to:
1. Select a chain of Bone2D nodes
2. Open the bones menu in the toolbar, click "Make IK chain"
And get an IK chain. | enhancement,topic:editor,usability,topic:2d | low | Major |
405,586,551 | rust | Expose core::intrinsics::volatile_copy_nonoverlapping_memory as core::ptr::volatile_copy_nonoverlapping | I propose that we expose [`core::intrinsics::volatile_copy_nonoverlapping_memory`](https://doc.rust-lang.org/core/intrinsics/fn.volatile_copy_nonoverlapping_memory.html) as the stable `core::ptr::volatile_copy_nonoverlapping`. It might make sense to stabilize other intrinsics while we're at it; I only mention this one in particular because I have a use case for it.
Is a discussion here sufficient, or should I submit an RFC? | T-lang,T-libs-api,C-feature-request | medium | Major |
405,602,439 | vscode | Reveal in sidebar by double-click breadcrumb | I've set the `explorer.autoReveal: false` in my settings.
It would be great, if i am double-click the file or folder in the breadcrumbs it would be reveal in sidebar/explorer. | feature-request,breadcrumbs | medium | Major |
405,651,482 | pytorch | pytorch was blocked at loss.backward | The pytorch version is 0.4.0
The call stack in python as follow:
```
File "/home/admin/code/PROPAGATE/tools/0_train_base.py", line 290, in <module>
process(sys.argv[1], sys.argv[2], int(sys.argv[3]), sys.argv[4])
File "/home/admin/code/PROPAGATE/tools/0_train_base.py", line 212, in process
solver.solve()
File "/home/admin/code/PROPAGATE/tools/0_train_base.py", line 162, in solve
loss, accB, accN, lossC = self.iterate(XB, YB, XN, YN, True)
File "/home/admin/code/PROPAGATE/tools/0_train_base.py", line 120, in iterate
loss.backward()
File "/home/admin/code/PROPAGATE/rpm/anaconda/lib/python2.7/site-packages/torch/tensor.py", line 93, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph)
File "/home/admin/code/PROPAGATE/rpm/anaconda/lib/python2.7/site-packages/torch/autograd/__init__.py", line 90, in backward
allow_unreachable=True) # allow_unreachable flag
File "/home/admin/code/PROPAGATE/rpm/anaconda/lib/python2.7/site-packages/torch/nn/parallel/distributed.py", line 341, in reduction_fn_nccl
group=self.nccl_reduction_group_id)
File "/home/admin/code/PROPAGATE/rpm/anaconda/lib/python2.7/site-packages/torch/distributed/__init__.py", line 306, in all_reduce_multigpu
return torch._C._dist_all_reduce_multigpu(tensor_list, op, group)
File "<string>", line 1, in <module>
```
The call stack in c++ as follow:
```
Thread 1 (Thread 0x7ff1f47c4740 (LWP 1386)):
#0 0x00007ff1f45c3a8b in _dl_update_slotinfo () from /lib64/ld-linux-x86-64.so.2
#1 0x00007ff1f45b1f7f in update_get_addr () from /lib64/ld-linux-x86-64.so.2
#2 0x00007ff1f45c8b38 in __tls_get_addr () from /lib64/ld-linux-x86-64.so.2
#3 0x00007ff1e6882538 in ncclGroupEnd () at misc/group.cu:165
#4 0x00007ff1e681f27f in thd::DataChannelNccl::_getNcclResourcePair(std::vector<at::Tensor, std::allocator<at::Tensor> >&, int) () from /home/admin/code/PROPAGATE/rpm/anaconda/lib/python2.7/site-packages/torch/_C.so
#5 0x00007ff1e68209dd in thd::DataChannelNccl::allReduce(std::vector<at::Tensor, std::allocator<at::Tensor> >&, THDReduceOp, int) () from /home/admin/code/PROPAGATE/rpm/anaconda/lib/python2.7/site-packages/torch/_C.so
#6 0x00007ff1e67f7a57 in THDAllReduceMultiGPU () from /home/admin/code/PROPAGATE/rpm/anaconda/lib/python2.7/site-packages/torch/_C.so
#7 0x00007ff1e667f36a in THDPModule_allReduceMultiGPU (_unused=<optimized out>, args=<optimized out>) at torch/csrc/distributed/Module.cpp:389
#8 0x00007ff1f42b6615 in PyEval_EvalFrameEx () from /home/admin/code/PROPAGATE/rpm/anaconda/bin/../lib/libpython2.7.so.1.0
#9 0x00007ff1f42b84e9 in PyEval_EvalCodeEx () from /home/admin/code/PROPAGATE/rpm/anaconda/bin/../lib/libpython2.7.so.1.0
#10 0x00007ff1f42b5482 in PyEval_EvalFrameEx () from /home/admin/code/PROPAGATE/rpm/anaconda/bin/../lib/libpython2.7.so.1.0
#11 0x00007ff1f42b84e9 in PyEval_EvalCodeEx () from /home/admin/code/PROPAGATE/rpm/anaconda/bin/../lib/libpython2.7.so.1.0
#12 0x00007ff1f4240fda in function_call () from /home/admin/code/PROPAGATE/rpm/anaconda/bin/../lib/libpython2.7.so.1.0
#13 0x00007ff1f421c773 in PyObject_Call () from /home/admin/code/PROPAGATE/rpm/anaconda/bin/../lib/libpython2.7.so.1.0
#14 0x00007ff1f421d053 in PyObject_CallFunctionObjArgs () from /home/admin/code/PROPAGATE/rpm/anaconda/bin/../lib/libpython2.7.so.1.0
#15 0x00007ff1e622f40d in operator() (__closure=0x7ff0c8c00660) at torch/csrc/autograd/python_engine.cpp:197
#16 std::_Function_handler<void(), THPEngine_queue_callback(PyObject*, PyObject*)::<lambda()> >::_M_invoke(const std::_Any_data &) (__functor=...) at /opt/rh/devtoolset-3/root/usr/include/c++/4.9.2/functional:2039
#17 0x00007ff1e6202cdb in operator() (this=<optimized out>) at /opt/rh/devtoolset-3/root/usr/include/c++/4.9.2/functional:2439
#18 torch::autograd::Engine::execute (this=this@entry=0x7ff1e9df7880 <engine>, input_roots=..., inputs=..., keep_graph=<optimized out>, create_graph=<optimized out>, outputs=...) at torch/csrc/autograd/engine.cpp:552
#19 0x00007ff1e623013c in torch::autograd::python::PythonEngine::execute (this=this@entry=0x7ff1e9df7880 <engine>, roots=..., inputs=..., keep_graph=<optimized out>, create_graph=<optimized out>, outputs=...) at torch/csrc/autograd/python_engine.cpp:61
#20 0x00007ff1e6230dc5 in THPEngine_run_backward (self=<optimized out>, args=<optimized out>, kwargs=<optimized out>) at torch/csrc/autograd/python_engine.cpp:169
```
any body can solve this problem? | needs reproduction,oncall: distributed,triaged | low | Major |
405,652,372 | angular | compareWith for RadioControlValueAccessor | <!--π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
Oh hi there! π
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
-->
# π feature request
### Relevant Package
This feature request is for @angular/forms
### Description
I want to bind objects to radio button values and need an own function for comparing the ngModel with the value.
### Describe the solution you'd like
I suggest the `RadioControlValueAccessor` should have `compareWith` like the `SelectControlValueAccessor`.
### Describe alternatives you've considered | feature,freq1: low,area: forms,feature: under consideration | low | Major |
405,654,178 | opencv | Loss of type of fixed-type matrix `cv::Mat_<T>` when initialized with empty matrix | ##### System information
- OpenCV = 4.0.1
- Compiler = MSVC
##### Description
I have a fixed-type matrix that is initialized by some other matrix:
cv::Mat_<double> A = B.clone();
So, when matrix `B` is empty, type of `A` becomes `UINT_8` | RFC | low | Minor |
405,656,651 | pytorch | CUDA cache doubles on the second batch and causes OOM, `empty_cache` doesn't empty it | I am trying to train an FCN8s net on full-sized VOC2012 data with batch size 1. I use Pytorch 1.0.0a0 and 32Gb GPU. Note, that the original model was trained on a 12Gb card.
Here is this question on the forum: https://discuss.pytorch.org/t/fcn-training-on-full-size-voc-data-cuda-oom/36074
## Issue description
CUDA cache doubles on the second batch and causes OOM
## Code example
For example the following (reproducible code: https://gist.github.com/vlasenkov/5338ccc7e2afcf9baa38326dc21fe403)
```
import os
os.environ["CUDA_VISIBLE_DEVICES"] = "0"
import torch
import torch.nn as nn
import ssms
model = ssms.arch.FCN8s(21)
model.cuda()
model.train()
optimizer = torch.optim.SGD(model.parameters(), lr=1e-3)
loss_fn = nn.CrossEntropyLoss(ignore_index=255)
for i in range(4):
img = torch.randn(1, 3, 128, 128).cuda()
lbl = torch.randint(0, 5, (1, 128, 128)).cuda()
optimizer.zero_grad()
out = model(img)
loss = loss_fn(input=out, target=lbl)
loss.backward()
optimizer.step()
print(ssms.util.memuse())
```
produces:
```
ALLOCATED: 1.005 ( 5.531) CACHED: 5.571 ( 5.571)
ALLOCATED: 1.005 ( 6.035) CACHED: 10.456 (10.456)
ALLOCATED: 1.005 ( 6.035) CACHED: 10.456 (10.456)
ALLOCATED: 1.005 ( 6.035) CACHED: 10.456 (10.456)
```
So for larger inputs this results in OOM error.
Also `empty_cache` doesn't help, however if only 1 Gb is allocated than more than 9 Gb could be released..
Adding this:
```
del loss, out, img, lbl
gc.collect()
torch.cuda.empty_cache()
```
doesn't help too.
The same with 0.4.1 and 1.0.0.
## System Info
```
PyTorch version: 1.0.0a0
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Ubuntu 16.04.5 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
CMake version: version 3.5.1
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.0.130
GPU models and configuration:
GPU 0: Tesla V100-DGXS-32GB
GPU 1: Tesla V100-DGXS-32GB
GPU 2: Tesla V100-DGXS-32GB
GPU 3: Tesla V100-DGXS-32GB
Nvidia driver version: 410.79
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.7.4.1
Versions of relevant libraries:
[pip] Could not collect
[conda] blas 1.0 mkl
[conda] magma-cuda100 2.1.0 5 local
[conda] mkl 2019.0 118
[conda] mkl-include 2019.0 118
[conda] mkl_fft 1.0.6 py36h7dd41cf_0
[conda] mkl_random 1.0.1 py36h4414c95_1
[conda] torch 1.0.0a0 <pip>
[conda] torchfcn 1.9.0 <pip>
[conda] torchtext 0.3.0 <pip>
[conda] torchvision 0.2.1 <pip>
```
| module: dependency bug,module: cudnn,triaged | medium | Critical |
405,707,078 | kubernetes | Scalability tests: Apiserver latency metrics have 0s as latency values | <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!-->
**What happened**:
Some of calls latencies have 0 values in scalability performance test APIResponsiveness summary.
https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-scale-performance-cl/12/artifacts/APIResponsiveness_load_2019-01-31T20:01:15Z.txt
**What you expected to happen**:
There should be values != 0.
**How to reproduce it (as minimally and precisely as possible)**:
Run 5000 nodes scalability performance test.
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`): All
- Cloud provider or hardware configuration:
- OS (e.g. from /etc/os-release): All
- Kernel (e.g. `uname -a`):
- Install tools:
- Others:
| kind/bug,sig/scalability,lifecycle/frozen | low | Critical |
405,711,646 | rust | Annotating higher-ranked lifetimes on closures is arduous | Executive summary: If you want to make a closure returning a higher-ranked lifetime, you need to use a helper like `fn annotate<T,F>(f: F) -> F where F: Fn(&T) -> &T { f }`. We could probably do better.
----
Spawned off of https://github.com/rust-lang/rust/issues/22557#issuecomment-77467069 (and possibly a duplicate of #22340 )
Consider this code ([play](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=550d63c90360f959d74c512aad75bd95)):
```rust
fn main() {
let f = |x: &i32| x;
let i = &3;
let j = f(i);
}
```
It doesn't compile. And its diagnostic is pretty hard to understand.
You can see an explanation from @nikomatsakis about why it doesn't compile here: https://github.com/rust-lang/rust/issues/22557#issuecomment-77467069
With `#![feature(nll)]`, it still doesn't compile; the diagnostic is slightly better:
```
error: lifetime may not live long enough
--> src/main.rs:4:23
|
4 | let f = |x: &i32| x;
| - - ^ returning this value requires that `'1` must outlive `'2`
| | |
| | return type of closure is &'2 i32
| let's call the lifetime of this reference `'1`
```
----
The aforementioned [explanation](https://github.com/rust-lang/rust/issues/22557#issuecomment-77467069) claims that adding a return type will get it to compile. But when I tried that, *it did not work*, both with and without `#![feature(nll)]` ([play](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=4c1949c24979c12ed83bdd58dd032a05), which includes NLL since I like its diagnostic here better):
```rust
fn main() {
let f = |x: &i32| -> &i32 { x };
let i = &3;
let j = f(i);
}
```
yields (and we'll leave #58053 in its own bug):
```
error: lifetime may not live long enough
--> src/main.rs:4:33
|
4 | let f = |x: &i32| -> &i32 { x };
| - - ^ returning this value requires that `'1` must outlive `'2`
| | |
| | return type of closure is &'2 i32
| let's call the lifetime of this reference `'1`
```
So what gives? Well, I think when @nikomatsakis claimed that an explicit return type would work, they were assuming that an explicit return type would cause lifetime elision rules to apply such that the same lifetime would be provided for the input and output reference-types on `f`. But as we saw in #56537, lifetime elision rules do not apply to closure return type annotations.
----
So what we want is to say that we have a lifetime parametric closure, with a type something like `for<'a> Fn(&'a i32) -> &'a i32`. But no, that's not a type, its a trait bound, so this does not work either ([play](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=84058cafa8766434fbb5a92456a6cd3b)):
```rust
fn main() {
let f: for<'a> Fn(&'a i32) -> &'a i32 = |x| x;
let i = &3;
let j = f(i);
}
```
yields:
```
error[E0308]: mismatched types
--> src/main.rs:4:45
|
4 | let f: for<'a> Fn(&'a i32) -> &'a i32 = |x| x;
| ^^^^^ expected trait std::ops::Fn, found closure
|
= note: expected type `dyn for<'a> std::ops::Fn(&'a i32) -> &'a i32`
found type `[closure@src/main.rs:4:45: 4:50]`
error[E0277]: the size for values of type `dyn for<'a> std::ops::Fn(&'a i32) -> &'a i32` cannot be known at compilation time
--> src/main.rs:4:9
|
4 | let f: for<'a> Fn(&'a i32) -> &'a i32 = |x| x;
| ^ doesn't have a size known at compile-time
|
= help: the trait `std::marker::Sized` is not implemented for `dyn for<'a> std::ops::Fn(&'a i32) -> &'a i32`
= note: to learn more, visit <https://doc.rust-lang.org/book/ch19-04-advanced-types.html#dynamically-sized-types-and-the-sized-trait>
= note: all local variables must have a statically known size
= help: unsized locals are gated as an unstable feature
```
----
An approach that *does* work is to feed in the trait bound explicitly via a helper function, like this ([play](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2015&gist=bd1f8c14fab2930979e892b6e5b6e1c8)):
```rust
fn annotate<T,F>(f: F) -> F where F: Fn(&T) -> &T { f }
fn main() {
let f = annotate(|x| x);
let i = &3;
let j = f(i);
assert_eq!(*j, 3);
}
```
But that seems like a pretty arduous way to encode a relatively simple pattern. If you look at https://github.com/rust-lang/rust/issues/22340#issuecomment-219794032, you can see others have suggested syntaxes like `for <'a> |x: &'a i32| -> &'a i32 { x }`, (where the `for <'a> CLOSURE_EXPR` is the new interesting expression form), which would be more convenient for addressing cases like ths. | A-lifetimes,A-closures,T-lang | medium | Critical |
405,724,273 | create-react-app | Creation of production build is compiling files in __mocks__ folders | <!--
PLEASE READ THE FIRST SECTION :-)
-->
### Is this a bug report?
Yes
### Did you try recovering your dependencies?
Yes
### Environment
Environment Info:
System:
OS: Windows 10
CPU: x64 Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz
Binaries:
npm: 6.4.1 - C:\Program Files\nodejs\npm.CMD
Browsers:
Edge: 42.17134.1.0
Internet Explorer: 11.0.17134.1
npmPackages:
react: ^16.7.0 => 16.7.0
react-dom: ^16.7.0 => 16.7.0
react-scripts: 2.1.3 => 2.1.3
npmGlobalPackages:
create-react-app: Not Found
### Steps to Reproduce
I noticed that `react-scripts build` command is compiling files from `__mocks__` folder (where manual mocks are stored to be used by jest). I have imported "devDepencency" to one .ts file in such folder and building process has failed.
(Write your steps here:)
1. Create project with `__mocks__` folder.
2. Add "devDependency" to file in `__mocks__` folder.
3. Try to build the solution.
### Expected Behavior
Solution has compiled successfully.
### Actual Behavior
Compilation has failed, because cannot find dependency in mock file.
| issue: needs investigation | low | Critical |
405,732,522 | go | cmd/go: validate GOBIN early as possible | <pre>
GO111MODULE=on GOPATH=`mktemp -d` GOBIN=. tipgo get golang.org/x/tools/cmd/godoc
go: finding golang.org/x/tools/cmd/godoc latest
go: finding golang.org/x/tools/cmd latest
go: finding golang.org/x/tools latest
go: downloading golang.org/x/tools v0.0.0-20190131163942-067a2f313b69
go: extracting golang.org/x/tools v0.0.0-20190131163942-067a2f313b69
go: finding golang.org/x/net/context/ctxhttp latest
go: finding golang.org/x/net/context latest
go: finding golang.org/x/net latest
go: downloading golang.org/x/net v0.0.0-20190125091013-d26f9f9a57f3
go: extracting golang.org/x/net v0.0.0-20190125091013-d26f9f9a57f3
cannot install, GOBIN must be an absolute path
</pre>
In most cases, the module, build caches will kick in and the work will not be completely wasted.
But it would be nice if Go detects such an obvious user error early before starting all the work.
<pre>
go version devel +faf187fb8e Thu Jan 31 16:55:43 2019 +0000 linux/amd64
</pre>
| ToolSpeed,NeedsDecision,GoCommand | low | Critical |
405,779,505 | go | testing: move gomaxprocs to key-value pair in benchmark output | It's been a few releases since we introduced the new `key: value` syntax in benchmark output. When we first introduced it, we left the `-P` suffix to signal the GOMAXPROCS setting, to avoid disruption for tools that didn't know about the new syntax. At this point I think we can safely move that into the key-value sections, cleaning up the main output lines.
That is, this output from `go test -bench=Parallel64 -benchtime=0.1s -count=5 -cpu=1,2,4 -run=XXX net/http`:
```
goos: darwin
goarch: amd64
pkg: net/http
BenchmarkClientServerParallel64 2000 76182 ns/op 5503 B/op 63 allocs/op
BenchmarkClientServerParallel64 2000 86365 ns/op 5610 B/op 64 allocs/op
BenchmarkClientServerParallel64 2000 81944 ns/op 5485 B/op 63 allocs/op
BenchmarkClientServerParallel64 2000 79690 ns/op 5488 B/op 63 allocs/op
BenchmarkClientServerParallel64 2000 98858 ns/op 5481 B/op 64 allocs/op
BenchmarkClientServerParallel64-2 1000 150096 ns/op 9203 B/op 81 allocs/op
BenchmarkClientServerParallel64-2 1000 147771 ns/op 8820 B/op 78 allocs/op
BenchmarkClientServerParallel64-2 1000 251588 ns/op 9759 B/op 81 allocs/op
BenchmarkClientServerParallel64-2 500 241765 ns/op 11516 B/op 87 allocs/op
BenchmarkClientServerParallel64-2 500 262960 ns/op 11397 B/op 86 allocs/op
BenchmarkClientServerParallel64-4 200 634660 ns/op 16159 B/op 116 allocs/op
BenchmarkClientServerParallel64-4 100 1377371 ns/op 17915 B/op 126 allocs/op
BenchmarkClientServerParallel64-4 200 576365 ns/op 15874 B/op 114 allocs/op
BenchmarkClientServerParallel64-4 200 516387 ns/op 14173 B/op 112 allocs/op
BenchmarkClientServerParallel64-4 200 515807 ns/op 14572 B/op 113 allocs/op
```
would become this output:
```
goos: darwin
goarch: amd64
pkg: net/http
gomaxprocs: 1
BenchmarkClientServerParallel64 2000 76182 ns/op 5503 B/op 63 allocs/op
BenchmarkClientServerParallel64 2000 86365 ns/op 5610 B/op 64 allocs/op
BenchmarkClientServerParallel64 2000 81944 ns/op 5485 B/op 63 allocs/op
BenchmarkClientServerParallel64 2000 79690 ns/op 5488 B/op 63 allocs/op
BenchmarkClientServerParallel64 2000 98858 ns/op 5481 B/op 64 allocs/op
gomaxprocs: 2
BenchmarkClientServerParallel64 1000 150096 ns/op 9203 B/op 81 allocs/op
BenchmarkClientServerParallel64 1000 147771 ns/op 8820 B/op 78 allocs/op
BenchmarkClientServerParallel64 1000 251588 ns/op 9759 B/op 81 allocs/op
BenchmarkClientServerParallel64 500 241765 ns/op 11516 B/op 87 allocs/op
BenchmarkClientServerParallel64 500 262960 ns/op 11397 B/op 86 allocs/op
gomaxprocs: 4
BenchmarkClientServerParallel64 200 634660 ns/op 16159 B/op 116 allocs/op
BenchmarkClientServerParallel64 100 1377371 ns/op 17915 B/op 126 allocs/op
BenchmarkClientServerParallel64 200 576365 ns/op 15874 B/op 114 allocs/op
BenchmarkClientServerParallel64 200 516387 ns/op 14173 B/op 112 allocs/op
BenchmarkClientServerParallel64 200 515807 ns/op 14572 B/op 113 allocs/op
```
/cc @aclements | NeedsFix,early-in-cycle | low | Minor |
405,813,319 | flutter | Video player: add the absolute position property for the live stream | The idea is to add the absolute position date time property for the currently playing stream. It's a necessary feature for the app with highly usage of live streams(HLS or DASH).
The aspects where it can be useful:
- Correct progress indicator positioning on the timeline
- Easy selection of the currently playing program in program table
- Seeking in the TV time-shifting archives and more
The good formed HLS stream usually has this information inside. | c: new feature,p: video_player,package,team-ecosystem,P3,triaged-ecosystem | low | Minor |
405,816,825 | angular | [Bug]: Namespaced Custom Events | <!--π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
Oh hi there! π
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
-->
# π bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- βοΈedit: -->
platform-browser
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
<!-- βοΈ--> No.
### Description
<!-- βοΈ-->
Custom events that are namespaced using the syntax `namespace:event` will fail. For example, binding to the `MDCTabBar:activated` event will fail ([source](https://github.com/material-components/material-components-web/blob/master/packages/mdc-tab-bar/constants.js#L26)).
```html
<mwc-tab-bar (MDCTabBar:activated)="onTabActivated($event)"></mwc-tab-bar>
```
The problem is Angular will think you are listening to an `activated` event on a global `MDCTabBar` event target ([source](https://github.com/angular/angular/blob/b61dafaeacbe80572b76884aa7acf1ba1c6ac45a/packages/platform-browser/src/browser/browser_adapter.ts#L350)).
**Possible Solution**
If Angular doesn't know about the event target then assume it is part of the event name, or add syntax to tell Angular to listen to the event name verbatim. I think I saw the `^` syntax in another issue.
e.g.
```html
<!-- hey Angular, don't mess with the event name -->
<mwc-tab-bar (^MDCTabBar:activated)="onTabActivated($event)"></mwc-tab-bar>
```
## π¬ Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2
-->
<!-- βοΈ-->
Not needed.
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue. Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## π₯ Exception or Error
<pre><code>
Unsupported event target null for event activated
</code></pre>
## π Your Environment
**Angular Version:**
<pre><code>
platform-browser: 7.0.3
</code></pre>
**Anything else relevant?**
<!-- βοΈIs this a browser specific issue? If so, please specify the browser and version. -->
<!-- βοΈDo any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
| type: bug/fix,breaking changes,freq1: low,area: core,state: confirmed,core: event listeners,design complexity: major,P3 | low | Critical |
405,825,518 | pytorch | new_zeros is not traced correctly | ## π Bug
If the model contains tensor.new_zeros, the tracer only generates a constant tensor. However, we expect it generates the right zero operator/function.
## To Reproduce
```
import torch
from torch import nn
from torch import jit
from torch.nn.utils.rnn import pack_padded_sequence, pad_packed_sequence
EMBEDDING_SIZE = 3
VOCAB_SIZE = 20
LSTM_SIZE = 5
class Model(nn.Module):
def __init__(self):
super().__init__()
self.embedding = nn.Embedding(VOCAB_SIZE, EMBEDDING_SIZE)
self.lstm = nn.LSTM(EMBEDDING_SIZE, LSTM_SIZE, num_layers=1, bidirectional=True)
def forward(self, tokens, seq_lengths):
embedded = self.embedding(tokens)
rnn_input = pack_padded_sequence(
embedded, seq_lengths.int(), batch_first=True,
)
rep, unused_state = self.lstm(rnn_input)
unpacked, _ = pad_packed_sequence(
rep,
padding_value=0.0,
batch_first=True,
total_length=embedded.size(1),
)
return unpacked
trace_input = (
torch.LongTensor([[1], [1]]),
torch.LongTensor([1, 1]),
)
test_input = (
torch.LongTensor([[1, 2, 3, 4]]),
torch.LongTensor([4]),
)
model = Model()
model(*trace_input)
model(*test_input)
traced = jit.trace(model, trace_input)
traced(*trace_input)
traced(*test_input) # trigger the problem, since the hidden state is constant, doesn't match the batch size.
```
## Expected behavior
The above code should work, however, the hx in the RNN module is traced as constant, so it won't work on different batch size.
cc: @jamesr66a @pritamdamania
cc @suo | oncall: jit,good first issue,triaged | low | Critical |
405,843,942 | pytorch | numa_test.py fails with AssertionError | ## π Bug
caffe2/python/numa_test.py fails intermittently. It seems as if Caffe2 ignores whatever numa_node_id is set in the numa_device_option when running ConstantFill for output_blob_0 and output_blob_1. This test case will also print out some warnings about `1` not being a valid NUMA node when run on POWER. Just doing a `numactl --hardware` on my POWER machine, it looks like POWER's NUMA nodes are not numbered consecutively. Instead of nodes 0, 1, 2, 3, etc. I have nodes 0, 8, 254, etc. The test case doesn't take this into account, and assumes that node 1 exists.
## To Reproduce
Steps to reproduce the behavior:
1. Build and install PyTorch, and make sure that CMake includes NUMA in the build
2. Run caffe2/python/numa_test.py
On x86:
```
(pytorch-env) [builder@b81f4478d132 python]$ python numa_test.py
[E init_intrinsics_check.cc:43] CPU feature avx is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature avx2 is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature fma is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[I net_dag_utils.cc:102] Operator graph pruning prior to chain compute took: 7.728e-06 secs
[I net_async_base.h:206] Using estimated CPU pool size: 40; device id: 1
[I net_async_base.h:224] Created shared CPU pool, size: 40; device id: 1
[I net_async_base.h:206] Using estimated CPU pool size: 40; device id: 0
[I net_async_base.h:224] Created shared CPU pool, size: 40; device id: 0
[I net_async_base.h:206] Using estimated CUDA pool size: 40; device id: 0
[I net_async_base.h:224] Created shared CUDA pool, size: 40; device id: 0
.
----------------------------------------------------------------------
Ran 1 test in 1.613s
OK
(pytorch-env) [builder@b81f4478d132 python]$ python numa_test.py
[E init_intrinsics_check.cc:43] CPU feature avx is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature avx2 is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature fma is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[I net_dag_utils.cc:102] Operator graph pruning prior to chain compute took: 9.282e-06 secs
[I net_async_base.h:206] Using estimated CPU pool size: 40; device id: 1
[I net_async_base.h:224] Created shared CPU pool, size: 40; device id: 1
[I net_async_base.h:206] Using estimated CPU pool size: 40; device id: 0
[I net_async_base.h:224] Created shared CPU pool, size: 40; device id: 0
[I net_async_base.h:206] Using estimated CUDA pool size: 40; device id: 0
[I net_async_base.h:224] Created shared CUDA pool, size: 40; device id: 0
F
======================================================================
FAIL: test_numa (__main__.NUMATest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "numa_test.py", line 49, in test_numa
self.assertEqual(workspace.GetBlobNUMANode("output_blob_0"), 0)
AssertionError: 1 != 0
----------------------------------------------------------------------
Ran 1 test in 1.451s
FAILED (failures=1)
```
On POWER:
```
(pytorch-env) [builder@34def4d0c457 python]$ python numa_test.py
[I net_dag_utils.cc:102] Operator graph pruning prior to chain compute took: 7.333e-06 secs
[I net_async_base.h:206] Using estimated CPU pool size: 176; device id: 1
[I net_async_base.h:224] Created shared CPU pool, size: 176; device id: 1
[I net_async_base.h:206] Using estimated CPU pool size: 176; device id: 0
[I net_async_base.h:224] Created shared CPU pool, size: 176; device id: 0
libnuma: Warning: node 1 not allowed
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
numa_sched_setaffinity_v2_int() failed: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
set_mempolicy: Invalid argument
[I net_async_base.h:206] Using estimated CUDA pool size: 176; device id: 0
[I net_async_base.h:224] Created shared CUDA pool, size: 176; device id: 0
F
======================================================================
FAIL: test_numa (__main__.NUMATest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "numa_test.py", line 50, in test_numa
self.assertEqual(workspace.GetBlobNUMANode("output_blob_1"), 1)
AssertionError: 0 != 1
----------------------------------------------------------------------
Ran 1 test in 6.899s
FAILED (failures=1)
```
## Expected behavior
The test case should pass on both x86 and POWER
<!-- A clear and concise description of what you expected to happen. -->
## Environment
x86:
```
PyTorch version: 1.0.0a0+bda268a (with some local modifications)
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Red Hat Enterprise Linux Server 7.5 (Maipo)
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
CMake version: Could not collect
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.0.130
GPU models and configuration:
GPU 0: Tesla P100-PCIE-16GB
GPU 1: Tesla P100-PCIE-16GB
Nvidia driver version: 410.79
```
POWER:
```
PyTorch version: 1.0.0a0+bda268a (with some local modifications)
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Red Hat Enterprise Linux Server 7.5 (Maipo)
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
CMake version: Could not collect
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.0.130
GPU models and configuration:
GPU 0: Tesla V100-SXM2-16GB
GPU 1: Tesla V100-SXM2-16GB
GPU 2: Tesla V100-SXM2-16GB
GPU 3: Tesla V100-SXM2-16GB
Nvidia driver version: 410.72
cuDNN version: Probably one of the following:
/usr/local/cuda-10.0/targets/ppc64le-linux/lib/libcudnn.so.7.3.1
/usr/local/cuda-10.0/targets/ppc64le-linux/lib/libcudnn_static.a
```
| caffe2 | low | Critical |
405,861,475 | pytorch | Reduce fragmentation with CUDA caching allocator when using many streams | At the moment, once we retrieve a block from `cudaMalloc` for the CUDA caching allocator, it is permanently associated with whatever stream was current at the time it was allocated. Even if it is subsequently split, all splits of the block live on the same stream. This means that if you have a program which uses many streams, you will have a much greater amount of fragmentation, scaled with the number of streams you use. On some internal Caffe2 video processing workflows, we have noticed that this fragmentation is the difference between OOM and a successful run.
It would be good if we could reduce fragmentation in these cases. The reason we permanently associate blocks with streams is because we try not to record an event (to tell when stream computation has finished) in the common case that someone frees a block. Without an event, we have no way of knowing when computation on the stream has finished; thus, it is only safe to reuse the block if we are returning it on the same stream (which will cause us to setup the correct ordering).
Related: #1529
CC @zheng-xq
cc @ngimel | module: cuda,module: memory usage,triaged | low | Minor |
405,872,584 | angular | Add documentation for zone.js in Angular | <!--π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
Oh hi there! π
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
-->
# π Docs or angular.io bug report
### Description
I'm new to angular but familiar with rxjs. I was caught by surprise when I sent a value through an observable (subject) via the console, but the change was not reflected on the screen. At the end of a lot of searching and learning, I ran across this link that fixed the issue for me whereby I could enable zone patches in the angular polyfill.ts file: [https://stackoverflow.com/questions/50784775/purpose-of-zone-js-dist-zone-patch-rxjs](https://stackoverflow.com/questions/50784775/purpose-of-zone-js-dist-zone-patch-rxjs).
It would be nice if the docs mentioned something to the effect of `vanilla rxjs is being used, the UI change detection is being managed by zones.js, and if you'd like your rxjs pipelines to be zone-aware, enable this patch in the polyfill.ts`. Or if there are any side-effects of doing so, document what those are.
Or maybe include them in the polyfill.ts project template:
```typescript
/***************************************************************************************************
* Zone JS is required by Angular itself.
*/
import 'zone.js/dist/zone'; // Included with Angular CLI.
// uncomment below to make sure that rx streams are zone-aware and change detection gets properly triggered
//import 'zone.js/dist/zone-patch-rxjs';
//import 'zone.js/dist/zone-patch-rxjs-fake-async';
```
## π¬ Minimal Reproduction
### What's the affected URL?
https://stackblitz.com/edit/angular-jasonkenneth-iybrkf?file=src%2Fapp%2Fasync-pipe%2Fasync-pipe.component.ts
| effort2: days,freq2: medium,state: community,P3,area: docs | low | Critical |
405,931,534 | rust | Add lints for all common traits | The [interoperability API guidelines](https://rust-lang-nursery.github.io/api-guidelines/interoperability.html#c-common-traits) suggest that all of the following traits should be eagerly implemented for types where it's appropriate:
* `Copy`
* `Clone`
* `Eq`
* `PartialEq`
* `Ord`
* `PartialOrd`
* `Hash`
* `Debug`
* `Display`
* `Default`
Both `Debug` and `Copy` have corresponding `missing_${TRAIT}_implementations` lints in `rustc` for checking that they exist. These lints have recently become of interest for `libc` because of [RFC2235](https://github.com/rust-lang/rfcs/blob/master/text/2235-libc-struct-traits.md). However, since some of these traits rely on manual implementations, it'd be useful to have lints to fail CI should any desired lints be missed in a PR.
Given that two of these lints already exist and the API guidelines lay out a clear standard practice, I'm not certain if an RFC is required to add the rest of these lints, so I'm raising this issue. My plan is to work through adding the lints for `Clone`, `Eq`, `Hash`, and `PartialEq`, as they're required for rust-lang/libc#1217. | A-lints,T-compiler,C-feature-request | low | Critical |
405,938,180 | rust | Recursive Drop causes stack overflow even for object trees | The issue seems to be that the way Drop is currently compiled is fatally flawed for recursive data structures.
The following code doesn't seem to have an fundamental issues that would cause it to fail, but it ends up causing a stack overflow, even for the version which uses Box instead of CustomBox.
```rust
use std::alloc::{alloc, dealloc, Layout, handle_alloc_error};
use std::ptr::{NonNull, drop_in_place, write};
use std::mem::drop;
use std::borrow::Borrow;
struct CustomBox<T> {
wrapped: NonNull<T>
}
impl<T> CustomBox<T> {
fn new(data: T) -> CustomBox<T> {
let wrapped = unsafe {
let layout = Layout::new::<T>();
let memory = alloc(layout);
if memory.is_null() {
handle_alloc_error(layout);
}
let result = NonNull::new_unchecked(memory as *mut T);
write(result.as_ptr(), data);
result
};
CustomBox {
wrapped
}
}
fn borrow(&self) -> &T {
unsafe {
self.wrapped.as_ref()
}
}
}
impl<T> Drop for CustomBox<T> {
fn drop(&mut self) {
let layout = Layout::new::<T>();
unsafe {
drop_in_place(self.wrapped.as_ptr());
dealloc(self.wrapped.as_ptr() as *mut u8, layout);
}
}
}
macro_rules! create_linked_list {
($name:ident, $box_type:ident) => {
struct $name {
data: u32,
next: Option<$box_type<$name>>
}
impl $name {
fn new(size: usize) -> Option<$box_type<$name>> {
let mut result: Option<$box_type<$name>> = None;
for i in 0..size {
let new_node = $box_type::new($name {
data: i as u32,
next: result.take()
});
result = Some(new_node);
}
result
}
fn sum(mut list: &Option<$box_type<$name>>) -> u64 {
let mut result = 0;
while let Some(node) = list.as_ref() {
let node_ref: &$name = node.borrow();
result += node_ref.data as u64;
list = &node_ref.next;
}
result
}
}
};
}
create_linked_list!(LinkedList, CustomBox);
create_linked_list!(BoxLinkedList, Box);
fn main() {
let list = BoxLinkedList::new(10_000_000);
println!("{}", BoxLinkedList::sum(&list));
println!("Trying to drop normal Box");
drop(list);
println!("Dropped successfully.");
let list = LinkedList::new(10_000_000);
println!("{}", LinkedList::sum(&list));
println!("Trying to drop CustomBox");
drop(list);
println!("Dropped successfully.");
}
```
I expected to see this happen: It should have run this code sample and printed each println.
Instead, this happened: It crashes when drop(list) is called the first time.
Currently, the LinkedList implementation in `std::collections` seems to explicitly deal with deallocating nodes without recursion so it is not affected.
I'm not sure if this was an intentional design decision or not, but if it it was intentional, it should be better documented, there isn't much indication in the [official docs](https://doc.rust-lang.org/std/ops/trait.Drop.html) that dropping is actually done as non-tail call recursive functions.
One way to potentially fix this could be to make a `lazy_drop_in_place ` macro which has the same signature as `drop_in_place`, except that instead of immediately dropping that item, it instead saves these pointers at the top of the stack (which is why this should be a macro instead of a function) in a static sized buffer.
This API would not allow variable size deallocations, but it would solve the problem since then then the compiler could avoid recursion for things like linked lists.
## Meta
`rustc --version --verbose`:
```
rustc 1.33.0-nightly (e2f221c75 2019-01-15)
binary: rustc
commit-hash: e2f221c75932de7a29845c8d6f1f73536ad00c41
commit-date: 2019-01-15
host: x86_64-pc-windows-msvc
release: 1.33.0-nightly
LLVM version: 8.0
```
Backtrace:
```
Compiling large-stack-drop v0.1.0 (C:\codedump\alloc-serialize\large-stack-drop)
Finished release [optimized] target(s) in 0.43s
Running `target\release\large-stack-drop.exe`
49999995000000
Trying to drop normal Box
thread 'main' has overflowed its stack
error: process didn't exit successfully: `target\release\large-stack-drop.exe` (exit code: 0xc00000fd, STATUS_STACK_OVERFLOW)
``` | C-enhancement,A-destructors,T-lang,A-docs | low | Critical |
405,939,491 | TypeScript | Relations based on variance markers do not take into account parameters used as key types. | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.3
**Code**
```ts
type Record2<K extends keyof any, T> = {
[P in K]: T;
};
function defaultRecord(x: Record<'a', string>, y: Record<string, string>) {
x = y; // no error, but error expected.
}
function customRecord(x: Record2<'a', string>, y: Record2<string, string>) {
x = y; // no error, but error expected.
}
function mixed1(x: Record2<'a', string>, y: Record<string, string>) {
x = y; // error
}
function mixed2(x: Record<'a', string>, y: Record2<string, string>) {
x = y; // error
}
```
**Playground Link:** [link](https://www.typescriptlang.org/play/#src=type%20Record2%3CK%20extends%20keyof%20any%2C%20T%3E%20%3D%20%7B%0A%20%20%20%20%5BP%20in%20K%5D%3A%20T%3B%0A%7D%3B%0A%0Afunction%20defaultRecord(x%3A%20Record%3C'a'%2C%20string%3E%2C%20y%3A%20Record%3Cstring%2C%20string%3E)%20%7B%0A%20%20%20%20x%20%3D%20y%3B%20%2F%2F%20no%20error%2C%20but%20error%20expected.%0A%7D%0A%0Afunction%20customRecord(x%3A%20Record2%3C'a'%2C%20string%3E%2C%20y%3A%20Record2%3Cstring%2C%20string%3E)%20%7B%0A%20%20%20%20x%20%3D%20y%3B%20%2F%2F%20no%20error%2C%20but%20error%20expected.%0A%7D%0A%0Afunction%20mixed1(x%3A%20Record2%3C'a'%2C%20string%3E%2C%20y%3A%20Record%3Cstring%2C%20string%3E)%20%7B%0A%20%20%20%20x%20%3D%20y%3B%20%2F%2F%20error%0A%7D%0A%0Afunction%20mixed2(x%3A%20Record%3C'a'%2C%20string%3E%2C%20y%3A%20Record2%3Cstring%2C%20string%3E)%20%7B%0A%20%20%20%20x%20%3D%20y%3B%20%2F%2F%20error%0A%7D)
**Related Issues:** #28798 <!-- Did you find other bugs that looked similar? --> | Bug | low | Critical |
405,960,038 | kubernetes | RawExtension yaml/json doesn't roundtrip to equal objects - causes ControllerRevisions that can break update validation | /sig api-machinery
/kind bug
@kubernetes/sig-api-machinery-bugs
One controller revision can be un-updatable if its content's order isn't forced by k/k codec stack
**What happened**:
Initially I found some error logs in garbage-collector/kube-controller-manager which was trying to orphaning a ControllerRevision to perform a cascading deletion:
> {"kind":"Status","apiVersion":"v1","metadata":{},"status":"Failure","message":"ControllerRevision.apps \"holiday-78b7ffcd54\" is invalid: data: Invalid value: runtime.Unknown{TypeMeta:runtime.TypeMeta{APIVersion:\"\", Kind:\"\"}, Raw:[]uint8{0x7b, 0x22, 0x61, 0x66, 0x66, 0x69, 0x6e, 0x69, 0x74, 0x79, 0x22.....<omitted>... ContentEncoding:\"\", ContentType:\"application/json\"}: field is immutable","field":"data"}]},"code":422}
but actually it wasn't trying to update any content but `ownerReferences` in that controller revision, and the patch request body was:
> {"metadata":{"ownerReferences":[{"$patch":"delete","uid":"e620de7e-26aa-11e9-9276-00163e000b8d"}],"uid":"e628e563-26aa-11e9-9e54-00163e000652"}}
After digging into the error and i find that the update validation is failing b/c the data content in controller revision is re-ordered when it's deserialized from storage. here i caught their dumps by adding some logs:
the old controllerRevision.Data in the failing update validation:
> "{"containers":[{"name":"holiday","image":":20190130003346413-master.01fc4fb8","resources"
:{"limits":{"cpu":"1","memory":"1Gi"},"requests":{"cpu":"500m","memory":"512Mi"}},"terminationMessagePolicy":"File","imagePullPolicy":"Always"}],"restartPolicy":"Always","
terminationGracePeriodSeconds":30,"dnsPolicy":"Default","securityContext":{},"affinity":{"nodeAffinity":{"requiredDuringSchedulingIgnoredDuringExecution":{"nodeSelectorTerms":[{"matchExpre
ssions":[{"key":"failure-domain.beta.kubernetes.io/cell","operator":"In","values":["",""]}]}]}}},"schedulerName":"default-scheduler"}"
the new controllerRevision.Data in the failing update validation:
> {"affinity":{"nodeAffinity":{"requiredDuringSchedulingIgnoredDuringExecution":{"nodeSelectorTerms":[{"matchExpressions":[{"key":"failure
-domain.beta.kubernetes.io/cell","operator":"In","values":["",""]}]}]}}},"containers":[{"image":":2019013000
3346413-master.01fc4fb8","imagePullPolicy":"Always","name":"holiday","resources":{"limits":{"cpu":"1","memory":"1Gi"},"requests":{"cpu":"500m","memory":"512Mi"}},"terminati
onMessagePolicy":"File"}],"dnsPolicy":"Default","restartPolicy":"Always","schedulerName":"default-scheduler","securityContext":{},"terminationGracePeriodSeconds":30}"
The content of that controller revision wasn't decoded by k/k's codec stack, and it's just roughly decoded by calling `json.Unmarshal`. so the `containers` field is placed before the `affinity` but when it is deserialized again by apiserver in memory, the order changed as is shown above.
**How to reproduce it (as minimally and precisely as possible)**:
Just create a controller revision w/ direct HTTP call (instead of creating via `kubectl`) and w/ a json body:
```json
{
"apiVersion": "apps/v1",
"kind": "ControllerRevision",
"metadata": {
"name": "test2-holiday-78b7ffcd54",
"namespace": "default"
},
"data": {
"containers": "foo",
"affinity": "bar"
},
"revision": 1
}
```
πΏthen any update on this object will fail due to the order forced by k/k codec stack | kind/bug,priority/important-soon,sig/api-machinery,lifecycle/frozen | low | Critical |
405,983,980 | rust | Expand implicit conversion of functions to function pointers | (I'm not sure if this requires a RFC, if so please let me know.)
Allow implicit conversion of functions to function pointers when trait is implemented on a function pointer. The code below shows the problem I'm having.
Calling `accepts_fn` works fine today, however calling `accepts_my_fn` doesn't work, even though the `MyFn` trait is implementation for function pointers. To make it work a explicit conversion (`as fn(_) -> _`) is required. This seems a bit surprising that in one instance a function in implicitly converted and another instance it is not.
```rust
β¨β¨β¨fn add1(n: usize) -> usize {
n + 1
}
fn accepts_fn(f: fn(usize) -> usize) -> usize {
f(1)
}
trait MyFn {
fn call(&mut self, n: usize) -> usize;
}
impl MyFn for fn(usize) -> usize {
fn call(&mut self, n: usize) -> usize {
(self)(n)
}
}
fn accepts_my_fn<F: MyFn>(mut f: F) -> usize {
f.call(2)
}
fn main() {
let n = accepts_fn(add1);
println!("n: {}", n);
// This doesn't work.
//let n = accepts_my_fn(add1);
// We need explicit conversion.
let n = accepts_my_fn(add1 as fn(_) -> _);
println!("n: {}", n);
}
```
([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=04a590eb70e99a78b14f2368c2bb7a41)) | A-trait-system,T-lang,C-feature-request,A-coercions | low | Critical |
406,000,308 | kubernetes | TTL support for ConfigMaps tied to job completion | /sig api-machinery
<!-- Please only use this template for submitting enhancement requests -->
**What would you like to be added**:
Ability to set ConfigMap lifecycle to delete after the completion of a Job resource object.
**Why is this needed**:
Job objects are inherently ephemeral. And support for this is included by the TTL controller. Otherwise given enough time the API would become littered with the corpses of long-dead jobs.
But Jobs frequently need ConfigMap objects built specifically for that single job instance. For example if we want to run the job with a given file as input. Without any support for pruning these job-unique ConfigMaps the same problem occurs. Even if the dead jobs are culled, their corresponding ConfigMaps aren't. | sig/api-machinery,kind/feature,sig/apps,lifecycle/frozen | medium | Critical |
406,016,032 | rust | Field ordering still causes extra memcpy | This is similar to #56356 except this time with more fields:
```rust
use std::mem;
struct SV {
capacity: usize,
disc: usize,
data: [usize; 40],
}
impl SV {
fn new() -> SV {
SV { data: unsafe { mem::uninitialized() },
disc: 0,
capacity: 0 }
}
}
pub struct L {
a: SV,
b: SV
}
pub struct Allocation<T> {
f: *mut T,
}
impl<T> Allocation<T> {
pub fn init(self, value: T) {
use std::ptr;
unsafe {
ptr::write(self.f, value);
}
}
}
#[inline(never)]
pub fn foo(a: Allocation<L>) {
a.init(L {
a: SV::new(),
b: SV::new()
});
}
```
gives:
```asm
example::foo:
sub rsp, 680
xorps xmm0, xmm0
movaps xmmword ptr [rsp], xmm0
movaps xmmword ptr [rsp + 336], xmm0
mov rsi, rsp
mov edx, 672
call qword ptr [rip + memcpy@GOTPCREL]
add rsp, 680
ret
```
vs moving capacity to the end of the struct:
```asm
example::foo:
mov qword ptr [rdi], 0
xorps xmm0, xmm0
movups xmmword ptr [rdi + 328], xmm0
mov qword ptr [rdi + 664], 0
ret
```
The problem is reproducible with C++ so I'll file a new llvm bug too. | A-LLVM,I-slow,C-enhancement,E-needs-test,T-compiler,A-mir-opt,A-mir-opt-nrvo | low | Critical |
406,016,961 | pytorch | Check whether _cudnn_rnn_flatten_weight can avoid changing the TensorImpl or Storage pointer of tensors in `weight_arr` | https://github.com/pytorch/pytorch/pull/16305 adds checks for TensorImpl and Storage pointer equality when a function modifies its input tensors (via inplace or out-variants) in VariableType functions. However, `_cudnn_rnn_flatten_weight` doesn't currently pass this check because it does in-place update into `weight_arr` that changes its internal tensors' TensorImpl or Storage pointer. We should investigate whether it's possible to fix this and make it also pass the pointer equality check.
cc @csarofeen @ptrblck @xwang233 | module: cudnn,triaged,module: assert failure | low | Minor |
406,023,626 | godot | Improve nonexistent input action message when using a Shortcut resource in a Button's Shortcut property | x11
https://github.com/godotengine/godot/commit/869887641f3d31f19837a34da116039a26618cb0
Is there a way to make the error more specific? (point to the Button/ShortCut)
Steps:
1. Create a Button
2. Add "ShortCut"
3. Add "InputEventAction"
3. Run and press any key
| enhancement,usability,topic:input,topic:gui | low | Critical |
406,030,269 | opencv | Regression: TiffDecoder fails to read 32F tiled tiffs | ##### System information (version)
- OpenCV => 3.4.1 or greater
##### Detailed description
As of the 3.4.1 release the TiffDecoder no longer reads single channel tiled 32 bit floating point tiffs. It fails with the error message `Can not read scanlines from a tiled image` this looks to be the result of #10493 where all 32 bit float tiffs are forced to be read with the scanline interface where before they were read using either the strip or tile interface.
| priority: low,category: imgcodecs | low | Critical |
406,031,416 | TypeScript | Feature Request: LanguageServiceHost plugin | ## Search Terms
language service host compiler plugin
Refs #16607
## Suggestion
Currently, TypeScript only supports proxying the [language service](https://github.com/Microsoft/TypeScript/wiki/Writing-a-Language-Service-Plugin). It would be good to have an officially supported way of being able to proxy the `LanguageServiceHost` as well.
## Use Cases
Being able to provide a plugin that changes how the language service host behaves is often a requirement for use cases where the default behaviour of TypeScript in Visual Studio Code does not mirror the compile time behaviour when using tools that implement a language service host with TypeScript.
For example in [Deno](https://denoland.github.io/deno), we utilise full path names for modules, including TypeScript ones. The standard language service host disallows this (because it assumes that the module name won't end in `.ts` at runtime).
There are likely to be other use cases where the behaviour of the language service host differs when using other forms of TypeScript other than `tsc` and Visual Studio Code, where it would be useful to allow plugins to mimic that behaviour, in particular in Visual Studio Code, so that the editing experience can be more rich.
## Examples
I currently have a [plugin](https://github.com/kitsonk/deno_ls_plugin/blob/c5ed4d532a7154e1c40d991b0aef3f03f89add06/index.ts#L7-L12) which just monkey patches the LanguageServiceHost to inject similar logic for module resolution to what is done in Deno. This is because I cannot return a proxy, like I could with the `LanaguageService`.
## Checklist
My suggestion meets these guidelines:
* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,In Discussion | low | Major |
406,042,358 | flutter | Some problem caused by the Android multitasking window | 1.When you return to the app from the multitasking window interface, the screen will blink
screen captureοΌhttps://drive.google.com/open?id=1cNeIJFWwFLDMY7QDli8REf1myiHb2nRo
2.When you open the multitasking window interface, if you accidentally touch the bottom navigation bar, after returning, the effect will not disappear.
screen captureοΌhttps://drive.google.com/open?id=1kPNqtLjMHEmXjWCsdfJpll1-fvIWIaOQ
| team,platform-android,engine,customer: alibaba,P2,found in release: 1.22,team-android,triaged-android | low | Major |
406,053,293 | TypeScript | TS is overly picky when declaring a class constructor type | **TypeScript Version:** 3.4.0-dev.20190202
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** class, extend, constructor, any[]
**Code**
```ts
type ClassConstructor = new(...args: any[]) => {}
function mixin<C extends ClassConstructor>(Class: C) {
return class extends Class {}
}
```
**Expected behavior:**
I should be able to replace `...args: any[]` with `...args: unknown[]`, or any other signature.
**Actual behavior:**
```
Error: Type 'C' is not a constructor function type. [2507]
```
**Playground Link:** https://www.typescriptlang.org/play/index.html#src=type%20ClassConstructor%20%3D%20new(...args%3A%20unknown%5B%5D)%20%3D%3E%20%7B%7D%0D%0A%0D%0Afunction%20mixin%3CC%20extends%20ClassConstructor%3E(Class%3A%20C)%20%7B%0D%0A%20%20return%20class%20extends%20Class%20%7B%7D%0D%0A%7D
| Bug,Help Wanted,Good First Issue | low | Critical |
406,058,411 | pytorch | [feature request] Store accumulated gradients in separate GPU or on CPU memory | When using the DataParallel, accumulated gradients seem to be gathered and stored on the primary GPU. Since the primary GPU is also used to compute forward passes and store optimizer states, it uses disproportionately more memory than other GPUs. Due to the large size of my model, I am unable to store accumulated gradients in a single GPU while using the same GPU to compute future losses and gradients.
I am wondering if it is possible to gather gradients computed in a DataParallel model to a separate, dedicated GPU, or to even store them in CPU memory along with the optimizer.
More details can be found on this [pytorch topic](https://discuss.pytorch.org/t/uneven-gpu-utilization-during-training-backpropagation/36117). | triaged,module: data parallel | low | Major |
406,073,631 | pytorch | split_with_sizes should accept a LongTensor as the split_sizes parameter | ## π Feature
The function `torch.split` partitions a tensor into chunks of equal size (except last) if called with an `int` parameter:
```python
torch.split(torch.arange(10), split_size_or_sections=3)
(
tensor([0, 1, 2]),
tensor([3, 4, 5]),
tensor([6, 7, 8]),
tensor([9])
)
```
or chucks of specific sizes if called with a list of ints:
```python
torch.split(torch.arange(10), split_size_or_sections=[7, 3])
(
tensor([0, 1, 2, 3, 4, 5, 6]),
tensor([7, 8, 9])
)
```
This second behavior is delegated to the (undocumented) function `torch.split_with_sizes` which only accepts a list of integers as parameter. I would like to be able to call `torch.split` and `torch.split_with_sizes` using a `LongTensor` instead of a list of ints.
## Motivation
In the project I am working on, the sizes of the split are part of the data itself, and it makes sense to me to store them as tensors rather than simple lists. With the current behavior I find myself writing this quite often:
```python
features: torch.Tensor
splits: torch.LongTensor
torch.split(features, splits.tolist())
```
I am afraid that the conversion to a native list might be inefficient and, in general, error-prone.
## Changes
- The signature of `torch.split` should become:
`torch.split(tensor: torch.Tensor, split_size_or_sections: Union[int, Sequence[int], torch.LongTensor], dim: int=0)`
- The signature of `torch.split_with_sizes` should become:
`torch.split(tensor: torch.Tensor, split_sizes: Union[Sequence[int], torch.LongTensor], dim: int=0)`
- (Optionally) I think `split_with_sizes` should have a docstring so that one can easily call it instead of calling `torch.split` which in turn delegates to `torch.split_with_sizes`
cc @mruberry @rgommers @heitorschueroff | feature,triaged,module: numpy | low | Critical |
406,090,743 | rust | "--emit mir" does not emit drop shim | When compiling code that generates drop shims, such as
```rust
struct Bar(u16); // ZSTs are tested separately
static mut DROP_COUNT: usize = 0;
impl Drop for Bar {
fn drop(&mut self) {
assert_eq!(self.0 as usize, unsafe { DROP_COUNT }); // tests whether we are called at a valid address
unsafe { DROP_COUNT += 1; }
}
}
fn main() {
let b = [Bar(0), Bar(1), Bar(2), Bar(3)];
assert_eq!(unsafe { DROP_COUNT }, 0);
drop(b);
assert_eq!(unsafe { DROP_COUNT }, 4);
// check empty case
let b : [Bar; 0] = [];
drop(b);
assert_eq!(unsafe { DROP_COUNT }, 4);
}
```
I would expect the file created by `rustc --emit mir` to also contain the drop shim. However, that is not the case.
This is related to https://github.com/rust-lang/rust/issues/53532 but not identical: the code for selecting what gets dumped with `-Zdump-mir` and `--emit=mir` is, from all I can see, entirely independent. Just the actual printing is shared. | C-enhancement,A-destructors,T-compiler,A-MIR | low | Minor |
406,097,735 | godot | Light2d shadows do not seem to affect polygons | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
3.1 beta 3
**OS/device including version:**
windows 10, nvidia gtx 1070
**Issue description:**
light2d does not affect polygons
**Steps to reproduce:**
create light and place polygon near it
| bug,topic:rendering,confirmed,topic:2d | low | Minor |
406,105,242 | godot | The theme editor preview is tiny on hiDPI displays |
**Godot version:**
<!-- Specify commit hash if non-official. -->
v3.1.beta3.official
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Model Name: MacBook Pro
Model Identifier: MacBookPro14,3
Processor Name: Intel Core i7
Processor Speed: 3.1 GHz
10.14.3
**Issue description:**
<!-- What happened, and what was expected. -->
Was going to create a new theme.
Went to the control node, chose theme, created new theme, clicked "open editor"
The edit theme editor opened in the middle bottom.
Expected:
Editor should open with fonts the same size as the rest of the UI of the Godot engine.
Actual:
The UI fonts are tiny. See screenshot.
<img width="1416" alt="screen shot 2019-02-03 at 8 24 33 am" src="https://user-images.githubusercontent.com/8691/52179338-10ab1e80-278e-11e9-9487-842ef4b9b0af.png">
| enhancement,topic:editor,confirmed,usability | medium | Critical |
406,121,060 | godot | Path2D and RayCast2D line width doesnΒ΄t adapt to canvas editor zoom | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
<!-- Specify commit hash if non-official. -->
869887641f3d31f19837a34da116039a26618cb0
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Win7
**Issue description:**
<!-- What happened, and what was expected. -->
Path2D and RayCast2D line doesnΒ΄t follow editor zoom like particles2d rect does... lines 98 to 102 in path2d.cpp are:
```
#if TOOLS_ENABLED
const float line_width = 2 * EDSCALE;
#else
const float line_width = 2;
#endif
```
I think that editor_scale is not the property that should be used in that code, but iΒ΄m unable to find what property and file should be used to maintain the size no mathers the zoom.
The problem:
| enhancement,discussion,topic:editor,usability | low | Minor |
406,139,660 | TypeScript | `symbol` does not match interface | **TypeScript Version:** playground and 3.3
**Search Terms:** symbol interface
**Code**
```ts
const sym: symbol = Symbol();
function f(arg: { constructor?: unknown }): void {
}
f(sym);
```
**Expected behavior:**
`symbol` is a non-nullish primitive, as such, it should be able to potentially match any interface.
**Actual behavior:**
Type error.
**Playground Link:** https://www.typescriptlang.org/play/#src=const%20sym%3A%20symbol%20%3D%20Symbol()%3B%0D%0A%0D%0Afunction%20f(arg%3A%20%7B%20constructor%3F%3A%20unknown%20%7D)%3A%20void%20%7B%0D%0A%7D%0D%0A%0D%0Af(sym)%3B
**Related Issues:** #29536 (discovered in relation to #28900), #1863, #24587 | Bug,Domain: lib.d.ts | low | Critical |
406,145,772 | pytorch | Very poor Uniform() sampling near floating 0.0 | ## π Bug
When using uniformly-distributed random number generation, especially using `float32`, over a range including 0, the sampling code ignores the extra precision of floating-point around 0, leading to very bad sampling.
The generated floats also have at most 24 (`float32`) or 53 (`float64`) bits of entropy.
**Consequence 1:** Multiplying any PyTorch float32 `uniform_(0,1)` by a large integer like `2**33` is guaranteed to give an integer.
**Consequence 2:** It is actually possible to generate an exact `0.0` using the `float32` **`uniform_(0,1)`,** with probability 2**-24, whereas that should actually have been 2**-149.
**Consequence 3:** It is not possible to generate a `float32` strictly between `0.0` and `2**-24` with `uniform_(0,1)`, whereas it should have been possible with probability 2**-24.
## To Reproduce
*Test 1:* If the following is `!= 0`, the RNG sucks: `torch.FloatTensor(int(1e8)).uniform_().eq(0).sum()`
*Test 2:* If the following is `== -inf`, the RNG sucks: `torch.FloatTensor(int(1e8)).uniform_().log().sum()`
## Expected behavior
*Test 1:* A return of `0`.
*Test 2:* A finite, negative value.
## Environment
_Not relevant._
- PyTorch Version 1.1.0a0+c865d46, but the same problem dates back to the beginning of the history of this code, which is over a year.
## Additional context
This has serious knock-on effects on many other distributions that use `uniform_()` as a basis. In particular, `log(uniform_())` has a 2**-24 chance of producing `-inf`, and `log2(uniform_())` cannot produce a number `< -24` (except `-inf`).
cc @pbelevich | triaged,module: random | medium | Critical |
406,164,110 | pytorch | Better include path when compiling mkldnn | Today I got hit by a similar issue as https://github.com/pytorch/pytorch/issues/14995, due to that I have `conda` `mkldnn` installed. Since we only compile mkldnn from source now, we should be able to do some cmake stuff to make sure it includes the correct headers.
cc @malfet @seemethere @walterddr | module: build,triaged | low | Minor |
406,171,324 | pytorch | culibos linker errors on binary_linux_conda_3.6_cu90_build | binary_linux_conda_3.6_cu90_build is failing on master
```
/opt/conda/conda-bld/pytorch-nightly_1549230224750/work/build/lib/libcaffe2_gpu.so: undefined reference to `culibosInitializeCriticalSection'
/opt/conda/conda-bld/pytorch-nightly_1549230224750/work/build/lib/libcaffe2_gpu.so: undefined reference to `culibosOnce'
/opt/conda/conda-bld/pytorch-nightly_1549230224750/work/build/lib/libcaffe2_gpu.so: undefined reference to `culibosLoadLibrary'
/opt/conda/conda-bld/pytorch-nightly_1549230224750/work/build/lib/libcaffe2_gpu.so: undefined reference to `culibosInit'
/opt/conda/conda-bld/pytorch-nightly_1549230224750/work/build/lib/libcaffe2_gpu.so: undefined reference to `culibosFreeLibrary'
/opt/conda/conda-bld/pytorch-nightly_1549230224750/work/build/lib/libcaffe2_gpu.so: undefined reference to `culibosEnterCriticalSection'
/opt/conda/conda-bld/pytorch-nightly_1549230224750/work/build/lib/libcaffe2_gpu.so: undefined reference to `culibosLeaveCriticalSection'
/opt/conda/conda-bld/pytorch-nightly_1549230224750/work/build/lib/libcaffe2_gpu.so: undefined reference to `culibosProcessId'
/opt/conda/conda-bld/pytorch-nightly_15492302247\]
```
sample log https://circleci.com/gh/pytorch/pytorch/707045?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link/console
cc @pjh5 | module: build,triaged | low | Critical |
406,264,763 | TypeScript | Object non-literal keys breaks parameter type guard in callback value | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.20190202
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
object dynamic keys callback implicit any
duplicate dynamic object key typing
**Code**
```ts
// PLEASE ENABLE => noImplicitAny
type Keys = 'a' | 'b' | 'c';
type Shape = { [K in Keys]?: K extends string ? (key: K) => K : never };
const getC = () => 'c' as 'c';
export const obj: Shape = {
['a']: key => key, // OK => inferred correctly
['b' as 'b']: key => key, // Error => inference broken "any" type
[getC()]: key => key, // Error => inference broken "any" type
[getC()]: key => key, // Error => inference broken "any" type instead of Duplicate identifier
['a']: key => key, // OK => Duplicate identifier as expected
};
```
**Expected behavior:**
* No implicit any error, but correct type assignation
* Detect duplicate identifier in case of non-explicit literal string key
**Actual behavior:**
* When not using an explicit literal string as an object-key, TypeScript cannot infer correctly the value.
* In a same way, TypeScript cannot detect duplicate identifier
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
(http://www.typescriptlang.org/play/#src=%2F%2F%20PLEASE%20ENABLE%20%3D%3E%20noImplicitAny%20%0D%0A%0D%0Atype%20Keys%20%3D%20'a'%20%7C%20'b'%20%7C%20'c'%3B%0D%0Atype%20Shape%20%3D%20%7B%20%5BK%20in%20Keys%5D%3F%3A%20K%20extends%20string%20%3F%20(key%3A%20K)%20%3D%3E%20K%20%3A%20never%20%7D%3B%0D%0A%0D%0Aconst%20getC%20%3D%20()%20%3D%3E%20'c'%20as%20'c'%3B%0D%0A%0D%0Aexport%20const%20obj%3A%20Shape%20%3D%20%7B%0D%0A%20%20%5B'a'%5D%3A%20key%20%3D%3E%20key%2C%20%2F%2F%20OK%20%3D%3E%20inferred%20correctly%0D%0A%20%20%5B'b'%20as%20'b'%5D%3A%20key%20%3D%3E%20key%2C%20%2F%2F%20Error%20%3D%3E%20inference%20broken%20%22any%22%20type%0D%0A%20%20%5BgetC()%5D%3A%20key%20%3D%3E%20key%2C%20%2F%2F%20Error%20%3D%3E%20inference%20broken%20%22any%22%20type%0D%0A%20%20%5BgetC()%5D%3A%20key%20%3D%3E%20key%2C%20%2F%2F%20Error%20%3D%3E%20inference%20broken%20%22any%22%20type%20instead%20of%20Duplicate%20identifier%0D%0A%20%20%5B'a'%5D%3A%20key%20%3D%3E%20key%2C%20%2F%2F%20OK%20%3D%3E%20Duplicate%20identifier%20as%20expected%0D%0A%7D%3B%0D%0A)
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug | medium | Critical |
406,290,569 | go | cmd/compile: add a README section on developing the compiler | For example, such a section could mention:
* https://godoc.org/golang.org/x/tools/cmd/toolstash, to make backups of a working/previous Go compiler
* General recommendations like `toolstash restore && go install cmd/compile` to rebuild the compiler in a fast and stable way
* Tips to ensure that the compiler hasn't been obviously broken, such as `go build -toolexec "toolstash -cmp" -a -v std cmd`
* Tips on how to use https://godoc.org/golang.org/x/tools/cmd/compilebench along with `toolstash` and `benchstat` to measure performance optimizations
Anything else that comes to mind, please add it to this issue. I plan on sending a CL to add a markdown section sometime during the 1.13 cycle.
I realise the SSA package has lots of extra checks and debugging flags one can enable, but I think those should be covered by `cmd/compile/internal/ssa/README`. I am also not nearly as familiar with those as I'm with this list here, so I'm leaving ssa's tips for another issue/CL.
/cc @josharian @mdempsky @aclements @randall77 | Documentation,NeedsInvestigation,compiler/runtime | medium | Critical |
406,313,471 | flutter | Improve error messages for indirectly caused type-errors | So, I already found the solution and it was definitely my problem. However, I think the error message can be improved. Basically, I wanted to write a `StreamToListWidget` with dynamic typing. The following code (1) can compile, but when used like this (2) it gives the error message (3). I could fix it by changing this line (4).
1
```dart
import 'package:flutter/material.dart';
class StreamToListWidget<T> extends StatefulWidget {
final Widget Function(T) mapper;
final Stream<T> stream;
StreamToListWidget(this.stream,
this.mapper,) : super();
@override
_StreamToListWidgetState createState() =>
_StreamToListWidgetState(stream, mapper);
}
class _StreamToListWidgetState<T> extends State<StreamToListWidget> {
Stream<T> stream;
List<T> content;
final Widget Function(T) mapper;
_StreamToListWidgetState(this.stream, this.mapper) {
// content = List();
// print("_StreamToListWidgetState created");
// stream.listen((entry) {
// print("Received Widget: ${widget}");
// setState(() {
// content.add(entry);
// });
// });
}
@override
Widget build(BuildContext context) {
return Row(
children: <Widget>[Text("Hallo")],
);
}
}
```
2
```
StreamToListWidget(
Stream.fromIterable(["123", "foo"]),
(String text) =>
Text("$text"),
)
```
3
```
I/flutter ( 2223): βββ‘ EXCEPTION CAUGHT BY WIDGETS LIBRARY ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
I/flutter ( 2223): The following assertion was thrown building FutureBuilder<Reddit>(state:
I/flutter ( 2223): _FutureBuilderState<Reddit>#75b87):
I/flutter ( 2223): type '(String) => Text' is not a subtype of type '(dynamic) => Widget'
I/flutter ( 2223):
I/flutter ( 2223): Either the assertion indicates an error in the framework itself, or we should provide substantially
I/flutter ( 2223): more information in this error message to help you determine and fix the underlying cause.
I/flutter ( 2223): In either case, please report this assertion by filing a bug on GitHub:
I/flutter ( 2223): https://github.com/flutter/flutter/issues/new?template=BUG.md
I/flutter ( 2223):
I/flutter ( 2223): When the exception was thrown, this was the stack:
I/flutter ( 2223): #0 StreamToListWidget.createState (package:offline_reddit/wrappedFuture.dart:30:40)
I/flutter ( 2223): #1 new StatefulElement (package:flutter/src/widgets/framework.dart:3789:23)
I/flutter ( 2223): #2 StatefulWidget.createElement (package:flutter/src/widgets/framework.dart:795:38)
I/flutter ( 2223): #3 Element.inflateWidget (package:flutter/src/widgets/framework.dart:2948:40)
I/flutter ( 2223): #4 Element.updateChild (package:flutter/src/widgets/framework.dart:2753:12)
I/flutter ( 2223): #5 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #6 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #7 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #8 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #9 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #10 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #11 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #12 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #13 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #14 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #15 StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
I/flutter ( 2223): #16 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #17 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #18 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #19 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #20 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #21 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #22 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #23 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #24 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #25 SliverMultiBoxAdaptorElement.updateChild (package:flutter/src/widgets/sliver.dart:1028:36)
I/flutter ( 2223): #26 SliverMultiBoxAdaptorElement.performRebuild.processElement (package:flutter/src/widgets/sliver.dart:978:34)
I/flutter ( 2223): #27 List.forEach (dart:core/runtime/libgrowable_array.dart:278:8)
I/flutter ( 2223): #28 SliverMultiBoxAdaptorElement.performRebuild (package:flutter/src/widgets/sliver.dart:989:36)
I/flutter ( 2223): #29 SliverMultiBoxAdaptorElement.update (package:flutter/src/widgets/sliver.dart:955:7)
I/flutter ( 2223): #30 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #31 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #32 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #33 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:4585:32)
I/flutter ( 2223): #34 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4975:17)
I/flutter ( 2223): #35 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #36 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #37 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #38 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #39 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #40 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #41 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #42 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #43 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #44 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #45 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #46 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #47 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #48 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #49 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #50 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #51 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #52 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #53 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #54 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #55 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #56 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #57 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #58 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #59 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #60 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #61 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #62 StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
I/flutter ( 2223): #63 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #64 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #65 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #66 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #67 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #68 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #69 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #70 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #71 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #72 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #73 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #74 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #75 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #76 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #77 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #78 StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
I/flutter ( 2223): #79 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #80 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #81 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #82 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #83 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #84 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #85 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #86 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #87 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #88 RenderObjectElement.updateChildren (package:flutter/src/widgets/framework.dart:4585:32)
I/flutter ( 2223): #89 MultiChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4975:17)
I/flutter ( 2223): #90 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #91 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #92 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #93 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #94 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #95 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #96 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #97 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #98 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #99 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #100 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #101 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #102 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #103 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #104 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #105 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #106 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #107 StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
I/flutter ( 2223): #108 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #109 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #110 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #111 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #112 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #113 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #114 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #115 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #116 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #117 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #118 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #119 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #120 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #121 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #122 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #123 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #124 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #125 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #126 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #127 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #128 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #129 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #130 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #131 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #132 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #133 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #134 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #135 StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
I/flutter ( 2223): #136 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #137 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
Reloaded 1 of 588 libraries in 1,020ms.
I/flutter ( 2223): #138 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #139 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #140 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #141 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #142 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #143 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #144 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #145 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #146 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #147 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #148 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #149 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #150 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #151 StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
I/flutter ( 2223): #152 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #153 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #154 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #155 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #156 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #157 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #158 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #159 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #160 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #161 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #162 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #163 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #164 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #165 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #166 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #167 StatefulElement.update (package:flutter/src/widgets/framework.dart:3878:5)
I/flutter ( 2223): #168 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #169 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #170 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #171 StatelessElement.update (package:flutter/src/widgets/framework.dart:3781:5)
I/flutter ( 2223): #172 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #173 SingleChildRenderObjectElement.update (package:flutter/src/widgets/framework.dart:4867:14)
I/flutter ( 2223): #174 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #175 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #176 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #177 ProxyElement.update (package:flutter/src/widgets/framework.dart:3990:5)
I/flutter ( 2223): #178 Element.updateChild (package:flutter/src/widgets/framework.dart:2742:15)
I/flutter ( 2223): #179 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3732:16)
I/flutter ( 2223): #180 Element.rebuild (package:flutter/src/widgets/framework.dart:3547:5)
I/flutter ( 2223): #181 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2286:33)
I/flutter ( 2223): #182 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding&WidgetsBinding.drawFrame (package:flutter/src/widgets/binding.dart:676:20)
I/flutter ( 2223): #183 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding&PaintingBinding&SemanticsBinding&RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:219:5)
I/flutter ( 2223): #184 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:990:15)
I/flutter ( 2223): #185 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:930:9)
I/flutter ( 2223): #186 _WidgetsFlutterBinding&BindingBase&GestureBinding&ServicesBinding&SchedulerBinding.scheduleWarmUpFrame.<anonymous closure> (package:flutter/src/scheduler/binding.dart:751:7)
I/flutter ( 2223): #188 _Timer._runTimers (dart:isolate/runtime/libtimer_impl.dart:382:19)
I/flutter ( 2223): #189 _Timer._handleMessage (dart:isolate/runtime/libtimer_impl.dart:416:5)
I/flutter ( 2223): #190 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:171:12)
I/flutter ( 2223): (elided one frame from package dart:async)
I/flutter ( 2223): ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
```
4
```dart
class StreamToListWidget<T> extends StatefulWidget {
final Widget Function(T) mapper;
final Stream<T> stream;
StreamToListWidget(this.stream,
this.mapper,) : super();
@override
_StreamToListWidgetState createState() =>
_StreamToListWidgetState<T>(stream, mapper); // added <T> here
}
```
| team,framework,a: error message,P2,team-framework,triaged-framework | low | Critical |
406,332,949 | TypeScript | tsc counts errors twice | <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.2.4
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** error double, error twice
**Expected behavior:**
tsc reports 4 errors.
**Actual behavior:**
it reports 8 errors.
| Bug | low | Critical |
406,369,153 | pytorch | Performance regression on CPU from 0.4.1 to 1.0.0 on ResNet inference | ## π Bug
ResNet50 inference is 20 - 65% slower on pytorch 1.0.0 and 1.0.1 vs 0.4.1 on CPU with `OMP_NUM_THREADS=1`, and ~~2800% slower without `OMP_NUM_THREADS=1` (8 core CPU), although these are probably two separate issues and I'm personally more interested in `OMP_NUM_THREADS=1` behaviour because it gets maximal use of available cores regardless of the version used~~ (edited: updated for 1.0.1, all timings below are very similar between 1.0.0 and 1.0.1).
## To Reproduce
Steps to reproduce the behavior:
- install pytorch from PyPI on Linux with Python 3.6, specifically these wheels were installed: `https://files.pythonhosted.org/packages/7e/60/66415660aa46b23b5e1b72bc762e816736ce8d7260213e22365af51e8f9c/torch-1.0.0-cp36-cp36m-manylinux1_x86_64.whl` and `https://files.pythonhosted.org/packages/49/0e/e382bcf1a6ae8225f50b99cc26effa2d4cc6d66975ccf3fa9590efcbedce/torch-0.4.1-cp36-cp36m-manylinux1_x86_64.whl`
- run `CUDA_VISIBLE_DEVICES= OMP_NUM_THREADS=1 ipython`
- in ipython, run:
```
import torch, torchvision
model = torchvision.models.resnet50(num_classes=10)
with torch.no_grad(): model(torch.zeros(1, 3, 224, 224))`
```
- still in ipython, run:
`%timeit with torch.no_grad(): model(torch.zeros(1, 3, 224, 224))`
## Expected behavior
I expected pytorch 1.0.0 to be in the same ballpark as pytorch 0.4.1, or faster. Instead it is from 20% to 65% slower. I tested on two different servers, one old `Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz` and another newer `Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz`.
Results of `%timeit` on `Intel(R) Xeon(R) CPU E5-2670 0 @ 2.60GHz`:
pytorch 0.4.1:
```
In [4]: %timeit with torch.no_grad(): model(torch.zeros(1, 3, 224, 224))
362 ms Β± 40.3 ms per loop (mean Β± std. dev. of 7 runs, 1 loop each)
```
pytorch 1.0.0:
```
In [4]: %timeit with torch.no_grad(): model(torch.zeros(1, 3, 224, 224))
596 ms Β± 57.1 ms per loop (mean Β± std. dev. of 7 runs, 1 loop each)
```
Results on `Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz`:
pytorch 0.4.1:
```
In [6]: %timeit with torch.no_grad(): model(torch.zeros(1, 3, 224, 224))
174 ms Β± 786 Β΅s per loop (mean Β± std. dev. of 7 runs, 10 loops each)
```
pytorch 1.0.0:
```
In [5]: %timeit with torch.no_grad(): model(torch.zeros(1, 3, 224, 224))
210 ms Β± 593 Β΅s per loop (mean Β± std. dev. of 7 runs, 1 loop each)
```
~~Also on the same server (8 virtual cores), without ``OMP_NUM_THREADS=1`` I get ``143 ms Β± 4.14 ms per loop (mean Β± std. dev. of 7 runs, 10 loops each)`` for 0.4.1, and ``4.05 s Β± 126 ms per loop (mean Β± std. dev. of 7 runs, 1 loop each)`` for 1.0.0 (so 28 times slower).~~ (edited: this bit is resolved in 1.0.1)
## Environment
For pytorch 0.4.1:
```
# python3 collect_env.py
Collecting environment information...
PyTorch version: 0.4.1
Is debug build: No
CUDA used to build PyTorch: 9.0.176
OS: Ubuntu 18.04.1 LTS
GCC version: (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
CMake version: Could not collect
Python version: 3.6
Is CUDA available: No
CUDA runtime version: 9.2.148
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.7.4.1
/usr/lib/x86_64-linux-gnu/libcudnn_static_v7.a
Versions of relevant libraries:
[pip] Could not collect
[conda] Could not collect
```
Same for 1.0.0:
```
# python3 collect_env.py
Collecting environment information...
PyTorch version: 1.0.0
Is debug build: No
CUDA used to build PyTorch: 9.0.176
OS: Ubuntu 18.04.1 LTS
GCC version: (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0
CMake version: Could not collect
Python version: 3.6
Is CUDA available: No
CUDA runtime version: 9.2.148
GPU models and configuration: Could not collect
Nvidia driver version: Could not collect
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.7.4.1
/usr/lib/x86_64-linux-gnu/libcudnn_static_v7.a
Versions of relevant libraries:
[pip] Could not collect
[conda] Could not collect
``` | module: performance,module: cpu,triaged,module: single threaded | low | Critical |
406,393,283 | rust | [rustdoc] Tracking issue for `--show-coverage` | cc @QuietMisdreavus | T-rustdoc,B-unstable,C-tracking-issue,A-doc-coverage | low | Major |
406,452,175 | go | cmd/compile: compileSSA takes a long time on very large (generated) functions | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12beta2 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/esmarques/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/esmarques/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build549978624=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
`$ go build a.go`
a.go is machine-genrated Go code:
[a.zip](https://github.com/golang/go/files/2829244/a.zip)
<pre>
$ wc a.go
44611 190970 1405515 a.go
</pre>
### What did you expect to see?
go build should finish eventually.
### What did you see instead?
go build consuming all the CPU and never finishes.
| ToolSpeed,NeedsInvestigation | low | Critical |
406,461,456 | rust | Linker error for no_std binary using musl | I tried to build a simple `no_std` "Hello World!" program using the `x86_64-unknown-linux-musl` target. The source code (in `src/main.rs`) is here:
```rust
#![no_std]
#![no_main]
use libc::{c_char, c_int, exit, puts};
#[no_mangle]
pub extern "C" fn main(_: c_int, _: *const *const c_char) -> c_int {
unsafe {
puts(b"Hello World!\0" as *const u8 as *const i8);
}
0
}
#[panic_handler]
fn panic_handler(_: &core::panic::PanicInfo) -> ! {
unsafe {
exit(1)
}
}
```
When using my default `x86_64-unknown-linux-gnu` target, the program compiles and runs like it should, but with `x86_64-unknown-linux-musl`, I get this linking error:
```
error: linking with `cc` failed: exit code: 1
|
= note: "cc" "-Wl,--as-needed" "-Wl,-z,noexecstack" "-Wl,--eh-frame-hdr" "-m64" "-nostdlib" "/home/johannes/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib/crt1.o" "/home/johannes/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib/crti.o" "-L" "/home/johannes/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib" "/home/johannes/hello/target/x86_64-unknown-linux-musl/release/deps/hello-8e567d3b97d6bd11.hello.c72za6mx-cgu.0.rcgu.o" "-o" "/home/johannes/hello/target/x86_64-unknown-linux-musl/release/deps/hello-8e567d3b97d6bd11" "-Wl,--gc-sections" "-no-pie" "-Wl,-zrelro" "-Wl,-znow" "-Wl,-O1" "-nodefaultlibs" "-L" "/home/johannes/hello/target/x86_64-unknown-linux-musl/release/deps" "-L" "/home/johannes/hello/target/release/deps" "-L" "/home/johannes/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib" "-Wl,-Bstatic" "/home/johannes/hello/target/x86_64-unknown-linux-musl/release/deps/liblibc-8c2b3cf08263e000.rlib" "/home/johannes/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib/libcore-879310dc3b96af61.rlib" "/home/johannes/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib/libcompiler_builtins-d0572f7a936161bf.rlib" "-static" "-Wl,-Bdynamic" "/home/johannes/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib/crtn.o"
= note: /usr/bin/ld: /home/johannes/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/x86_64-unknown-linux-musl/lib/crt1.o: in function `_start_c':
/build/musl-1.1.20/crt/crt1.c:17: undefined reference to `__libc_start_main'
/usr/bin/ld: /home/johannes/hello/target/x86_64-unknown-linux-musl/release/deps/hello-8e567d3b97d6bd11.hello.c72za6mx-cgu.0.rcgu.o: in function `main':
hello.c72za6mx-cgu.0:(.text.main+0xa): undefined reference to `puts'
collect2: error: ld returned 1 exit status
```
I can build a normal (`std`-using) "Hello World!" program for musl without problems, only this `no_std` version doesn't work.
I am also able to work around this problem by instead moving the source code to `src/lib.rs` and compiling it as a library with `crate-type = ["staticlib"]`, then linking manually with `musl-gcc`. The error only occurs when trying to build a binary directly.
<details>
<summary>My Cargo.toml. Uncomment the two lines and move main.rs to lib.rs for the workaround.</summary>
```toml
[package]
name = "hello"
version = "0.1.0"
authors = ["me"]
edition = "2018"
#[lib]
#crate-type = ["staticlib"]
[dependencies]
libc = { version = "0.2", default-features = false }
[profile.dev]
panic = "abort"
[profile.release]
panic = "abort"
```
</details> | A-linkage,T-libs-api,T-compiler,O-musl | low | Critical |
406,478,917 | godot | Circle gizmo losing its looking transform in Overdraw mode | **Godot version:**
3.1 beta 3
**Issue description:**
I dont know whether its bug or is it intended : in overdraw mode that gizmo looking incorrect(cuz it start to use transformation instead face it to user) compared to other draw modes
Take for example an OmniLight node -
also note that its not correctly draw a lamp bulb sprite in that mode | bug,topic:rendering,topic:editor,confirmed | low | Critical |
406,479,176 | TypeScript | typescript/idea auto create method bug | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
video here
https://www.youtube.com/watch?v=3WaM6SvJk-c&feature=youtu.be
```ts
import novelInfo, { IMdconfMeta, _handleDataForStringify } from 'node-novel-info';
class A
{
protected _handleDataForStringify(...argv)
{
// @ts-ignore
return _handleDataForStringify(...argv)
}
}
class B extends A
{
// create _handleDataForStringify here
}
```
**Expected behavior:**
```ts
protected _handleDataForStringify(...argv): IMdconfMeta
{
return super._handleDataForStringify(...argv);
}
```
**Actual behavior:**
```ts
protected _handleDataForStringify(...argv): IMdconfMeta
{
return super._handleDataForStringify(argv);
}
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug | low | Critical |
406,484,224 | node | Frequent console.log() calls prevent error output on stack overflow | This seems familiar, but I cannot recall if this was considered wontfix.
See report on SO: https://stackoverflow.com/questions/54508290/maximum-calls-does-not-exceed-on-certain-code-inside-function-in-nodejs
This is not reproducible in Node.js 6 and 8, but is reproducible in Node.js 10 and 11, at least in Windows 7 x64. | windows,tty,stdio | low | Critical |
406,522,073 | TypeScript | Overload gets lost in mapped type with conditional type | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** mapped type overload
**Code**
```ts
interface Overloads {
foo(a: string): void;
foo(a: number, b: string): void;
}
/** Converts all properties of an object to Promises and all methods to return Promises */
type ProxiedObject<T> = {
[P in keyof T]: T[P] extends (...args: infer Arguments) => infer R
? (...args: Arguments) => Promise<R>
: Promise<T[P]>
};
declare let x: ProxiedObject<Overloads>;
x.foo("abc"); // Error: [ts] Expected 2 arguments, but got 1. [2554]
x.foo(123, "abc");
```
**Expected behavior:**
No error, overload should be maintained.
This makes it impossible to use this pattern with popular types that contain overloads, like Rx `Observable` `pipe()`/`subscribe()`.
The `ProxiedObject` type is used in https://github.com/GoogleChromeLabs/comlink.
**Actual behavior:**
Overload gets lost, compile error when trying to call the first overload.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> [link](https://www.typescriptlang.org/play/index.html#src=interface%20Overloads%20%7B%0D%0A%20%20foo(a%3A%20string)%3A%20void%3B%0D%0A%20%20foo(a%3A%20number%2C%20b%3A%20string)%3A%20void%3B%0D%0A%7D%0D%0A%0D%0A%2F**%20Converts%20all%20properties%20of%20an%20object%20to%20Promises%20and%20all%20methods%20to%20return%20Promises%20*%2F%0D%0Atype%20ProxiedObject%3CT%3E%20%3D%20%7B%0D%0A%20%20%5BP%20in%20keyof%20T%5D%3A%20T%5BP%5D%20extends%20(...args%3A%20infer%20Arguments)%20%3D%3E%20infer%20R%0D%0A%20%20%20%20%3F%20(...args%3A%20Arguments)%20%3D%3E%20Promise%3CR%3E%0D%0A%20%20%20%20%3A%20Promise%3CT%5BP%5D%3E%0D%0A%7D%3B%0D%0A%0D%0Adeclare%20let%20x%3A%20ProxiedObject%3COverloads%3E%3B%0D%0Ax.foo(%22abc%22)%3B%20%2F%2F%20Error%3A%20%5Bts%5D%20Expected%202%20arguments%2C%20but%20got%201.%20%5B2554%5D%0D%0Ax.foo(123%2C%20%22abc%22)%3B)
| Suggestion,In Discussion | medium | Critical |
406,544,749 | three.js | ObjectLoader: Add support for helpers | ##### Description of the problem
If you serialize a Box3Helper object it drops the reference to `box`, which means that parsing it always returns the default Box3Helper. In the snippet below, it should appear as if there is only one box, but instead two boxes of different sizes show up.
Relevant snippet:
```javascript
var box = new THREE.Box3(
new THREE.Vector3( -5, -5, -5 ),
new THREE.Vector3( 5, 5, 5 ),
);
var helper = new THREE.Box3Helper( box, 0xffff00 );
scene.add(helper);
var string = JSON.stringify(helper);
var loader = new THREE.ObjectLoader();
var parsed = loader.parse(JSON.parse(string));
scene.add(parsed);
```
https://codepen.io/anon/pen/rPzLPO
##### Three.js version
- [ ] Dev
- [x] r101
- [ ] ...
##### Browser
- [ ] All of them
- [x] Chrome
- [ ] Firefox
- [ ] Internet Explorer
##### OS
- [ ] All of them
- [ ] Windows
- [x] macOS
- [ ] Linux
- [ ] Android
- [ ] iOS
##### Hardware Requirements (graphics card, VR Device, ...)
| Enhancement | low | Major |
406,550,447 | node | Workers affected by V8 aborting on virtual allocation failure | * **Version**: 4b6e4c1eb110
* **Platform**: Linux 4.19.15 x86_64
* **Subsystem**: `worker_threads`
A process aborts when V8 fails to allocate virtual memory. This is detremental to using `Workers` because:
1. If a `Worker` fails to allocate virtual memory during initialization the process aborts.
2. V8's virtual memory allocator doesn't play nicely with `ulimit`.
To demonstrate this issue:
1. Set `ulimit -v` to some value smaller than actual physically available memory (I've allocated 8GB out of 16GB).
2. Run the following script that spawns a set number of `Worker`s (the number to spawn may need adjusting depending on the system):
```js
const WORKER_COUNT = 60; // Value may need adjustment
const { Worker, parentPort, workerData, threadId } = require('worker_threads');
const worker_array = [];
if (workerData) {
process._rawDebug(workerData, threadId, process.pid, process.ppid);
parentPort.postMessage(42);
setTimeout(() => {}, 1000000);
return;
}
(function runner(n) {
if (++n > WORKER_COUNT) return setTimeout(killAll, 10);
const w = new Worker(__filename, { workerData: n });
w.on('message', () => {
process._rawDebug(JSON.stringify(getMemUsage()));
runner(n);
});
w.on('exit', c => process._rawDebug(`${n} exited with ${c}`));
worker_array.push(w);
})(0);
function killAll() {
for (let w of worker_array)
w.terminate();
}
function getMemUsage() {
const o = process.memoryUsage();
for (let i in o) o[i] = o[i] / 1024;
return o;
}
```
Which results in a `Fatal process OOM in CodeRange setup: allocate virtual memory` error. With the stack trace of:
```
* thread #1: tid = 4094, 0x0000000003eab702 node_g`v8::base::OS::Abort() at platform-posix.cc:399, name = 'node_g', stop reason = signal SIGILL: illegal instruction operand
* frame #0: 0x0000000003eab702 node_g`v8::base::OS::Abort() at platform-posix.cc:399
frame #1: 0x0000000002954ac2 node_g`v8::Utils::ReportOOMFailure(isolate=0x0000000005c13170, location="CodeRange setup: allocate virtual memory", is_heap_oom=false) at api.cc:460
frame #2: 0x000000000295492d node_g`v8::internal::V8::FatalProcessOutOfMemory(isolate=0x0000000005c13170, location="CodeRange setup: allocate virtual memory", is_heap_oom=false) at api.cc:428
frame #3: 0x000000000322e4a6 node_g`v8::internal::MemoryAllocator::InitializeCodePageAllocator(this=0x0000000005c076d0, page_allocator=0x00000000045aa030, requested=134217728) a t spaces.cc:168
frame #4: 0x000000000322e083 node_g`v8::internal::MemoryAllocator::MemoryAllocator(this=0x0000000005c076d0, isolate=0x0000000005c13170, capacity=1526909922, code_range_size=0) at spaces.cc:132
frame #5: 0x000000000318d6da node_g`v8::internal::Heap::SetUp(this=0x0000000005c13190) at heap.cc:4349
frame #6: 0x000000000331aa77 node_g`v8::internal::Isolate::Init(this=0x0000000005c13170, des=0x00007fffffff6db8) at isolate.cc:3176
frame #7: 0x00000000036e558c node_g`v8::internal::Snapshot::Initialize(isolate=0x0000000005c13170) at snapshot-common.cc:55
frame #8: 0x0000000002994b0d node_g`v8::Isolate::Initialize(isolate=0x0000000005c13170, params=0x00007fffffff7170) at api.cc:8224
frame #9: 0x00000000025db63b node_g`node::NewIsolate(allocator=0x00007fff34002c80, event_loop=0x0000000005bf2530) at node.cc:1420
frame #10: 0x000000000270d9a6 node_g`node::worker::Worker::Worker(this=0x0000000005bf2500, env=0x00007fffffffcd08, wrap=(val_ = 0x00007fffffff84a0), url="\xb0?"..., per_isolate_ opts=nullptr) at node_worker.cc:106
```
Examination of the `strace` log shows:
```
31103 mmap(0x129b53343000, 134217728, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_NORESERVE, -1, 0) = -1 ENOMEM (Cannot allocate memory)
31103 mmap(0x129b53343000, 134217728, PROT_NONE, MAP_PRIVATE|MAP_ANONYMOUS|MAP_NORESERVE, -1, 0) = -1 ENOMEM (Cannot allocate memory)
31103 write(2, "\n#\n# Fatal process OOM in CodeRa"..., 70) = 70
```
Though if I run the same script on a machine with 8GB physical memory and `ulimit -v unlimited` the script doesn't have a problem.
In the end, this is probably something that'd need to be resolved by V8. Both to allocate virtual memory more intelligently and allow the `Isolate` to notify when no more memory could be allocated. Then have that hooked into the `Worker`'s `'error'` event.
| confirmed-bug,v8 engine,worker | low | Critical |
406,561,673 | rust | Error duplicate definitions for impls on distinct associated types | As a minimal example of the error I'm running into (using the [`typenum`](https://crates.io/crates/typenum) crate although I don't think it's specific to that):
```rust
use core::{marker::PhantomData, ops::Add};
use typenum::*;
struct Wrapper<T>(PhantomData<T>);
type X = <U2 as Add<U3>>::Output;
type Y = <U7 as Add<U9>>::Output;
impl Wrapper<X> {
fn foo() {}
}
impl Wrapper<Y> {
fn foo() {}
}
```
gives
```
error[E0592]: duplicate definitions with name `foo`
--> .../lib.rs:30:9
|
30 | fn foo() {}
| ^^^^^^^^^^^ duplicate definitions for `foo`
...
34 | fn foo() {}
| ----------- other definition for `foo`
```
I think this might be related to #20400, but I'm not sure. I tried making a simpler reproduction on the [playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=33581ec271cc2ee6ff28affdbb74757d) without using `typenum`, but I wasn't able to.
Clearly, `X` and `Y` are distinct types, as they are not assignable to each other, so why can't I define the same function in `impl`s for them?
[Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2021&gist=0380ca8bffb2e2d6b097f1d53bbfc1eb) | A-type-system,A-associated-items,T-compiler,C-bug,T-types | low | Critical |
406,562,500 | pytorch | torch.save overwrite | ## π Feature
<!-- A clear and concise description of the feature proposal -->
Add an overwrite feature to torch.save (default: True) or throw a warning that a file will not overwrite an already existing file.
## Motivation
The current [workaround](https://discuss.pytorch.org/t/how-to-save-a-model-from-a-previous-epoch/20252/4) is to save a new model at each epoch. This is helpful in many applications, but saving a single model file when you know overfitting will not be an issue (e.g. when reimplementing a paper) would save a lot of memory when training large models as well as remove the need for a workaround using os / shutil functions. The default in all other applications I have seen is to overwrite the file.
cc @brianjo @mruberry @ezyang @gchanan @zou3519 | module: docs,triaged,enhancement | low | Major |
406,565,998 | flutter | Cupertino Time picker hour plural label should fade in and out | Right now on the plural 's' pops in and out when you scroll past 1 when selecting hours with the Cupertino time picker. It should instead fade to 'hour' or to 'hours' after drag up when scrolling the hour dial. | framework,f: date/time picker,a: fidelity,f: cupertino,c: proposal,good first issue,P2,team-design,triaged-design | low | Minor |
406,568,183 | go | proposal: add x/tools/cmd/mapper | I can offer the tool `mapper` as a sort of sibling to `stringer`. It is part of my [`maps`](https://github.com/drgrib/maps) repo and can be installed using
``` bash
go get -u github.com/drgrib/maps/cmd/mapper
```
And used with
``` bash
mapper -types string:CustomType
```
To generate the file `map_string_customtype.go` that infers its `package` from surrounding `.go` files or the current folder name if no other files are found:
``` go
package maps
func ContainsKeyStringCustomType(m map[string]CustomType, k string) bool {
_, ok := m[k]
return ok
}
func ContainsValueStringCustomType(m map[string]CustomType, v CustomType) bool {
for _, mValue := range m {
if mValue == v {
return true
}
}
return false
}
func GetKeysStringCustomType(m map[string]CustomType) []string {
keys := []string{}
for k, _ := range m {
keys = append(keys, k)
}
return keys
}
func GetValuesStringCustomType(m map[string]CustomType) []CustomType {
values := []CustomType{}
for _, v := range m {
values = append(values, v)
}
return values
}
func CopyStringCustomType(m map[string]CustomType) map[string]CustomType {
copyMap := map[string]CustomType{}
for k, v := range m {
copyMap[k] = v
}
return copyMap
}
```
I've never contributed to the `go` code base so I'm not sure how this all works but am happy to make this code part of the core project, which may be useful until we get generics in Go 2.0. | Proposal,Proposal-Hold | low | Minor |
406,568,569 | flutter | Add mechanism in RenderSliver to check pointer status. | I'm trying to create a custom refresh indicator similar to `CupertinoRefreshControl` but that doesn't trigger the refresh action until the user has released the drag. To do this I need to know when the user has released the drag and then determine if they dragged enough to trigger it.
It'd be a lot nicer to be able to implement this with a custom `RenderSliver` rather than have to make a custom `CustomScrollView`. | c: new feature,framework,f: scrolling,P2,team-framework,triaged-framework | low | Minor |
406,622,821 | TypeScript | 3.3.1 regression in type inference | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.3.1 & 3.4.0-dev.20190202
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
class Foo {
foo: number = 0;
}
class FooBar extends Foo {
bar: number = 10;
}
async function foo(f: Foo | number) {
if (f instanceof FooBar) {
try {
f = await (async (): Promise<Foo | number> => {
throw new Error();
})();
}
catch (ex) {
console.log(f.bar); // 3.3.1 has an error on this line -- "Property 'bar' does not exist on type 'number | Foo'. Property 'bar' does not exist on type 'number'"
}
}
}
foo(new FooBar());
```
**Expected behavior:**
No error as was in TypeScript 3.2.4
**Actual behavior:**
Error `Property 'bar' does not exist on type 'number | Foo'. Property 'bar' does not exist on type 'number'`
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
http://www.typescriptlang.org/play/index.html#src=class%20Foo%20%7B%0D%0A%20%20%20%20foo%3A%20number%20%3D%200%3B%0D%0A%7D%0D%0A%0D%0Aclass%20FooBar%20extends%20Foo%20%7B%0D%0A%20%20%20%20bar%3A%20number%20%3D%2010%3B%0D%0A%7D%0D%0A%0D%0Aasync%20function%20foo(f%3A%20Foo%20%7C%20number)%20%7B%0D%0A%20%20%20%20if%20(f%20instanceof%20FooBar)%20%7B%0D%0A%20%20%20%20%20%20%20%20try%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20f%20%3D%20await%20(async%20()%3A%20Promise%3CFoo%20%7C%20number%3E%20%3D%3E%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20%20throw%20new%20Error()%3B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20%7D)()%3B%0D%0A%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%20%20%20%20catch%20(ex)%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20console.log(f.bar)%3B%0D%0A%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A%0D%0Afoo(new%20FooBar())%3B
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug | low | Critical |
406,637,641 | godot | DynamicFontData can't store antialias or hinting property value unless it's saved to a `.tres`/`.res` file (fixed in `master`) |
Godot v3.1 Beta 3
Windows 10.
GeForce GTX 550
Can't switch off Anti-Aliasing of some Dynamic Fonts (.ttf) in game, only Editor.
I would expect to be able to turn off the Anti-Aliasing for low res retro games. I would expect the game to mimic the Editor settings. Some fonts work, some don't. Size of font doesn't seem to make a difference. I've included an example project.
Set Anti-Aliasing to 'off' in the editor after adding a Dynamic Font.
[Anti-Aliasing Dynamic Font Bug.zip](https://github.com/godotengine/godot/files/2830863/Anti-Aliasing.Dynamic.Font.Bug.zip)
| enhancement,confirmed,documentation,topic:gui | medium | Critical |
406,656,607 | flutter | Cursor should snap back into another inside the viewport when scrolling a text field | Take a TextField and put the cursor somewhere.
Scroll the whole textfield putting the cursor outside the viewport. The cursor should change its position to another place in the text that's currently in the viewport to match native Android behavior. | a: text input,platform-android,framework,f: material design,f: scrolling,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-framework,triaged-framework,fyi-text-input | low | Minor |
406,659,597 | go | cmd/go: warn when `go get` removes a module that provides a package in the import graph? | ### What version of Go are you using (`go version`)?
<pre>
go version go1.11.4 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
yes it does
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/U/Library/Caches/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/U/Work/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/U/Work/TestProj/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rm/sngdtnn11x3b_zp_zzyw6jl40000gn/T/go-build528112071=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
```
$go get github.com/miekg/dns/idn@cdb76b64a347436f019bf96ab5eb2d74e73e964b
go: finding github.com/miekg/dns/idn cdb76b64a347436f019bf96ab5eb2d74e73e964b
$grep dns go.mod
github.com/miekg/dns v0.0.0-20171124081448-cdb76b64a347
$go mod vendor
go: finding github.com/miekg/dns/idn latest
$grep dns go.mod
github.com/miekg/dns v1.1.1
```
### What did you expect to see?
github.com/miekg/dns v0.0.0-20171124081448-cdb76b64a347 vendored
### What did you see instead?
github.com/miekg/dns v1.1.1 vendored | NeedsInvestigation,modules | low | Critical |
406,847,420 | flutter | Feature request: Add a widget to relatively position a child to its parent | In some cases it can be useful to relatively position a child to its parent.
For example let's say we want a container positioned at 10% from the left edge of its parent, 20% from the top, 30% from the right and 40% from the bottom:
<img width="108" alt="capture d ecran 2019-02-05 a 16 23 19" src="https://user-images.githubusercontent.com/9378033/52283515-e2326c80-2962-11e9-880a-8f3ea49d297a.png">
As discussed in #24475, we can use a combination of `Align` and `FractionallySizedBox` for this, but this is not straightforward:
```dart
import 'package:flutter/material.dart';
void main() => runApp(MyDemoWidget());
class MyDemoWidget extends StatelessWidget {
@override
Widget build(BuildContext context) {
// The child's left edge should be indented at 10% of the parent's width.
const double leftFactor = 0.10;
// The child's top edge should be indented at 20% of the parent's height.
const double topFactor = 0.20;
// The child should have a width of 60% (100 - 10 - 30) of the parent's width.
const double widthFactor = 0.60;
// The child should have a height of 40% (100 - 20 - 40) of the parent's height.
const double heightFactor = 0.40;
return MaterialApp(
home: Scaffold(
appBar: AppBar(
title: Text('DEMO'),
),
body: Center(
child: Container(
height: 100.0,
width: 100.0,
color: Colors.orange,
child: Align(
alignment: FractionalOffset(
leftFactor / (1.0 - widthFactor),
topFactor / (1.0 - heightFactor),
),
child: FractionallySizedBox(
widthFactor: widthFactor,
heightFactor: heightFactor,
child: Container(
color: Colors.yellow,
),
),
),
),
),
),
);
}
}
```
As @goderbauer suggested, we could encapsulate this into a widget.
I ended up with this base of work (in order to have the same kind of API than the `Positioned` widget):
```dart
import 'package:flutter/widgets.dart';
class FractionallyAlignedSizedBox extends StatelessWidget {
FractionallyAlignedSizedBox({
Key key,
@required this.child,
this.leftFactor,
this.topFactor,
this.rightFactor,
this.bottomFactor,
this.widthFactor,
this.heightFactor,
}) : assert(
leftFactor == null || rightFactor == null || widthFactor == null),
assert(
topFactor == null || bottomFactor == null || heightFactor == null),
assert(widthFactor == null || widthFactor >= 0.0),
assert(heightFactor == null || heightFactor >= 0.0),
super(key: key);
final double leftFactor;
final double topFactor;
final double rightFactor;
final double bottomFactor;
final double widthFactor;
final double heightFactor;
final Widget child;
@override
Widget build(BuildContext context) {
double dx = 0;
double dy = 0;
double width = widthFactor;
double height = heightFactor;
if (widthFactor == null) {
final left = leftFactor ?? 0;
final right = rightFactor ?? 0;
width = 1 - left - right;
if (width != 1) {
dx = left / (1.0 - width);
}
}
if (heightFactor == null) {
final top = topFactor ?? 0;
final bottom = bottomFactor ?? 0;
height = 1 - top - bottom;
if (height != 1) {
dy = top / (1.0 - height);
}
}
if (widthFactor != null && widthFactor != 1) {
if (leftFactor != null) {
dx = leftFactor / (1 - widthFactor);
} else if (leftFactor == null && rightFactor != null) {
dx = (1 - widthFactor - rightFactor) / (1 - widthFactor);
}
}
if (heightFactor != null && heightFactor != 1) {
if (topFactor != null) {
dy = topFactor / (1 - heightFactor);
} else if (topFactor == null && bottomFactor != null) {
dy = (1 - heightFactor - bottomFactor) / (1 - heightFactor);
}
}
return Align(
alignment: FractionalOffset(
dx,
dy,
),
child: FractionallySizedBox(
widthFactor: width,
heightFactor: height,
child: child,
),
);
}
}
```
So that the previous example could be written like this:
```dart
import 'package:flutter/material.dart';
void main() => runApp(MyDemoWidget());
class MyDemoWidget extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
appBar: AppBar(
title: Text('DEMO'),
),
body: Center(
child: Container(
height: 100.0,
width: 100.0,
color: Colors.orange,
child: FractionallyAlignedSizedBox(
leftFactor: 0.10,
topFactor: 0.20,
rightFactor: 0.30,
bottomFactor: 0.40,
child: Container(
color: Colors.yellow,
),
),
),
),
),
);
}
}
```
Concerning the name `FractionallyAlignedSizedBox` I'm not sure if people who look for positioning a widget relative to the size of its parent would find it easily π.
What do you think about this? | c: new feature,framework,P3,team-framework,triaged-framework | low | Major |
406,896,979 | flutter | Google Map's camera is not positioned correctly at initialization. | This is a follow-up ticket for https://github.com/flutter/flutter/issues/24806.
The original issue is fixed by a temporary workaround https://github.com/flutter/plugins/pull/1157.
We suspect the bug is in the iOS Google Maps SDK. We will use this ticket to track the status of the Goole Maps SDK fix; and once it is fixed, we can remove the temporary workaround. | customer: crowd,p: maps,package,team-ecosystem,P2,triaged-ecosystem | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.