id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
391,578,039
flutter
Stuck at waiting for observatory port to be available if platform code Intent is used.
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.io/ * https://docs.flutter.io/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.io/bug-reports/ --> ## Steps to Reproduce 1. Start new flutter project. 2. Create new file HelloService.java , paste the following: ```java package com.example.hello; import android.content.Intent; import android.app.IntentService; import android.content.IntentFilter; import android.app.Service; public class HelloService extends IntentService { public HelloService() { super("HelloService"); } @Override protected void onHandleIntent(Intent Intent) { } } ``` 3. Modify the Main Activity by adding `Intent i = new Intent(this, HelloService.class);` 4. Modify the manifest by adding a `<service android:name=".HelloService">` 5. Run `flutter run -v`. ## Logs ``` ... compileReleaseUnitTestJavaWithJavac: task ':app:compileReleaseUnitTestJavaWithJavac' compileReleaseUnitTestSources: task ':app:compileReleaseUnitTestSources' components: SoftwareComponentInternal set configurationActions: org.gradle.configuration.project.DefaultProjectConfigurationActionContainer@48fe032d configurationTargetIdentifier: org.gradle.configuration.ConfigurationTargetIdentifier$1@56e7fc36 configurations: configuration container connectedAndroidTest: task ':app:connectedAndroidTest' connectedCheck: task ':app:connectedCheck' connectedDebugAndroidTest: task ':app:connectedDebugAndroidTest' consumeConfigAttr: task ':app:consumeConfigAttr' convention: org.gradle.api.internal.plugins.DefaultConvention@26327249 copyFlutterAssetsDebug: task ':app:copyFlutterAssetsDebug' copyFlutterAssetsDynamicProfile: task ':app:copyFlutterAssetsDynamicProfile' copyFlutterAssetsDynamicRelease: task ':app:copyFlutterAssetsDynamicRelease' copyFlutterAssetsProfile: task ':app:copyFlutterAssetsProfile' copyFlutterAssetsRelease: task ':app:copyFlutterAssetsRelease' createDebugCompatibleScreenManifests: task ':app:createDebugCompatibleScreenManifests' createDynamicProfileCompatibleScreenManifests: task ':app:createDynamicProfileCompatibleScreenManifests' createDynamicReleaseCompatibleScreenManifests: task ':app:createDynamicReleaseCompatibleScreenManifests' createMockableJar: task ':app:createMockableJar' createProfileCompatibleScreenManifests: task ':app:createProfileCompatibleScreenManifests' createReleaseCompatibleScreenManifests: task ':app:createReleaseCompatibleScreenManifests' defaultArtifacts: org.gradle.api.internal.plugins.DefaultArtifactPublicationSet_Decorated@79d78b67 defaultTasks: [] deferredProjectConfiguration: org.gradle.api.internal.project.DeferredProjectConfiguration@4108181b dependencies: org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler_Decorated@28674a40 dependencyLocking: org.gradle.internal.locking.DefaultDependencyLockingHandler_Decorated@1d72c53f depth: 1 description: null deviceAndroidTest: task ':app:deviceAndroidTest' deviceCheck: task ':app:deviceCheck' displayName: project ':app' distsDir: C:\Users\addis\OneDrive\temp\hello\build\app\distributions distsDirName: distributions docsDir: C:\Users\addis\OneDrive\temp\hello\build\app\docs docsDirName: docs ext: org.gradle.api.internal.plugins.DefaultExtraPropertiesExtension@58bbf945 extensions: org.gradle.api.internal.plugins.DefaultConvention@26327249 extractApksForDebug: task ':app:extractApksForDebug' extractApksForDynamicProfile: task ':app:extractApksForDynamicProfile' extractApksForDynamicRelease: task ':app:extractApksForDynamicRelease' extractApksForProfile: task ':app:extractApksForProfile' extractApksForRelease: task ':app:extractApksForRelease' extractProguardFiles: task ':app:extractProguardFiles' fileOperations: org.gradle.api.internal.file.DefaultFileOperations@59f2fa89 fileResolver: org.gradle.api.internal.file.BaseDirFileResolver@4b559ebd flutter: FlutterExtension_Decorated@4085f1d5 flutterBuildDebug: task ':app:flutterBuildDebug' flutterBuildDynamicProfile: task ':app:flutterBuildDynamicProfile' flutterBuildDynamicRelease: task ':app:flutterBuildDynamicRelease' flutterBuildProfile: task ':app:flutterBuildProfile' flutterBuildRelease: task ':app:flutterBuildRelease' flutterBuildX86Jar: task ':app:flutterBuildX86Jar' generateDebugAndroidTestAssets: task ':app:generateDebugAndroidTestAssets' generateDebugAndroidTestBuildConfig: task ':app:generateDebugAndroidTestBuildConfig' generateDebugAndroidTestResValues: task ':app:generateDebugAndroidTestResValues' generateDebugAndroidTestResources: task ':app:generateDebugAndroidTestResources' generateDebugAndroidTestSources: task ':app:generateDebugAndroidTestSources' generateDebugAssets: task ':app:generateDebugAssets' generateDebugBuildConfig: task ':app:generateDebugBuildConfig' generateDebugFeatureMetadata: task ':app:generateDebugFeatureMetadata' generateDebugFeatureTransitiveDeps: task ':app:generateDebugFeatureTransitiveDeps' generateDebugResValues: task ':app:generateDebugResValues' generateDebugResources: task ':app:generateDebugResources' generateDebugSources: task ':app:generateDebugSources' generateDebugUnitTestAssets: task ':app:generateDebugUnitTestAssets' generateDebugUnitTestResources: task ':app:generateDebugUnitTestResources' generateDebugUnitTestSources: task ':app:generateDebugUnitTestSources' generateDynamicProfileAssets: task ':app:generateDynamicProfileAssets' generateDynamicProfileBuildConfig: task ':app:generateDynamicProfileBuildConfig' generateDynamicProfileFeatureMetadata: task ':app:generateDynamicProfileFeatureMetadata' generateDynamicProfileFeatureTransitiveDeps: task ':app:generateDynamicProfileFeatureTransitiveDeps' generateDynamicProfileResValues: task ':app:generateDynamicProfileResValues' generateDynamicProfileResources: task ':app:generateDynamicProfileResources' generateDynamicProfileSources: task ':app:generateDynamicProfileSources' generateDynamicProfileUnitTestAssets: task ':app:generateDynamicProfileUnitTestAssets' generateDynamicProfileUnitTestResources: task ':app:generateDynamicProfileUnitTestResources' generateDynamicProfileUnitTestSources: task ':app:generateDynamicProfileUnitTestSources' generateDynamicReleaseAssets: task ':app:generateDynamicReleaseAssets' generateDynamicReleaseBuildConfig: task ':app:generateDynamicReleaseBuildConfig' generateDynamicReleaseFeatureMetadata: task ':app:generateDynamicReleaseFeatureMetadata' generateDynamicReleaseFeatureTransitiveDeps: task ':app:generateDynamicReleaseFeatureTransitiveDeps' generateDynamicReleaseResValues: task ':app:generateDynamicReleaseResValues' generateDynamicReleaseResources: task ':app:generateDynamicReleaseResources' generateDynamicReleaseSources: task ':app:generateDynamicReleaseSources' generateDynamicReleaseUnitTestAssets: task ':app:generateDynamicReleaseUnitTestAssets' generateDynamicReleaseUnitTestResources: task ':app:generateDynamicReleaseUnitTestResources' generateDynamicReleaseUnitTestSources: task ':app:generateDynamicReleaseUnitTestSources' generateProfileAssets: task ':app:generateProfileAssets' generateProfileBuildConfig: task ':app:generateProfileBuildConfig' generateProfileFeatureMetadata: task ':app:generateProfileFeatureMetadata' generateProfileFeatureTransitiveDeps: task ':app:generateProfileFeatureTransitiveDeps' generateProfileResValues: task ':app:generateProfileResValues' generateProfileResources: task ':app:generateProfileResources' generateProfileSources: task ':app:generateProfileSources' generateProfileUnitTestAssets: task ':app:generateProfileUnitTestAssets' generateProfileUnitTestResources: task ':app:generateProfileUnitTestResources' generateProfileUnitTestSources: task ':app:generateProfileUnitTestSources' generateReleaseAssets: task ':app:generateReleaseAssets' generateReleaseBuildConfig: task ':app:generateReleaseBuildConfig' generateReleaseFeatureMetadata: task ':app:generateReleaseFeatureMetadata' generateReleaseFeatureTransitiveDeps: task ':app:generateReleaseFeatureTransitiveDeps' generateReleaseResValues: task ':app:generateReleaseResValues' generateReleaseResources: task ':app:generateReleaseResources' generateReleaseSources: task ':app:generateReleaseSources' generateReleaseUnitTestAssets: task ':app:generateReleaseUnitTestAssets' generateReleaseUnitTestResources: task ':app:generateReleaseUnitTestResources' generateReleaseUnitTestSources: task ':app:generateReleaseUnitTestSources' gradle: build 'android' group: android identityPath: :app inheritedScope: org.gradle.api.internal.ExtensibleDynamicObject$InheritedDynamicObject@47734951 installDebug: task ':app:installDebug' installDebugAndroidTest: task ':app:installDebugAndroidTest' installDynamicProfile: task ':app:installDynamicProfile' installDynamicRelease: task ':app:installDynamicRelease' installProfile: task ':app:installProfile' installRelease: task ':app:installRelease' java: org.gradle.api.plugins.internal.DefaultJavaPluginExtension_Decorated@91bd584 javaPreCompileDebug: task ':app:javaPreCompileDebug' javaPreCompileDebugAndroidTest: task ':app:javaPreCompileDebugAndroidTest' javaPreCompileDebugUnitTest: task ':app:javaPreCompileDebugUnitTest' javaPreCompileDynamicProfile: task ':app:javaPreCompileDynamicProfile' javaPreCompileDynamicProfileUnitTest: task ':app:javaPreCompileDynamicProfileUnitTest' javaPreCompileDynamicRelease: task ':app:javaPreCompileDynamicRelease' javaPreCompileDynamicReleaseUnitTest: task ':app:javaPreCompileDynamicReleaseUnitTest' javaPreCompileProfile: task ':app:javaPreCompileProfile' javaPreCompileProfileUnitTest: task ':app:javaPreCompileProfileUnitTest' javaPreCompileRelease: task ':app:javaPreCompileRelease' javaPreCompileReleaseUnitTest: task ':app:javaPreCompileReleaseUnitTest' layout: org.gradle.api.internal.file.DefaultProjectLayout@6e5c026c libsDir: C:\Users\addis\OneDrive\temp\hello\build\app\libs libsDirName: libs lint: task ':app:lint' lintDebug: task ':app:lintDebug' lintDynamicProfile: task ':app:lintDynamicProfile' lintDynamicRelease: task ':app:lintDynamicRelease' lintFix: task ':app:lintFix' lintProfile: task ':app:lintProfile' lintRelease: task ':app:lintRelease' lintVitalRelease: task ':app:lintVitalRelease' listenerBuildOperationDecorator: org.gradle.configuration.internal.DefaultListenerBuildOperationDecorator@1b84d2b logger: org.gradle.internal.logging.slf4j.OutputEventListenerBackedLogger@9258db6 logging: org.gradle.internal.logging.services.DefaultLoggingManager@5c5cb58c mainApkListPersistenceDebug: task ':app:mainApkListPersistenceDebug' mainApkListPersistenceDebugAndroidTest: task ':app:mainApkListPersistenceDebugAndroidTest' mainApkListPersistenceDynamicProfile: task ':app:mainApkListPersistenceDynamicProfile' mainApkListPersistenceDynamicRelease: task ':app:mainApkListPersistenceDynamicRelease' mainApkListPersistenceProfile: task ':app:mainApkListPersistenceProfile' mainApkListPersistenceRelease: task ':app:mainApkListPersistenceRelease' makeApkFromBundleForDebug: task ':app:makeApkFromBundleForDebug' makeApkFromBundleForDynamicProfile: task ':app:makeApkFromBundleForDynamicProfile' makeApkFromBundleForDynamicRelease: task ':app:makeApkFromBundleForDynamicRelease' makeApkFromBundleForProfile: task ':app:makeApkFromBundleForProfile' makeApkFromBundleForRelease: task ':app:makeApkFromBundleForRelease' mergeDebugAndroidTestAssets: task ':app:mergeDebugAndroidTestAssets' mergeDebugAndroidTestJniLibFolders: task ':app:mergeDebugAndroidTestJniLibFolders' mergeDebugAndroidTestResources: task ':app:mergeDebugAndroidTestResources' mergeDebugAndroidTestShaders: task ':app:mergeDebugAndroidTestShaders' mergeDebugAssets: task ':app:mergeDebugAssets' mergeDebugJniLibFolders: task ':app:mergeDebugJniLibFolders' mergeDebugResources: task ':app:mergeDebugResources' mergeDebugShaders: task ':app:mergeDebugShaders' mergeDynamicProfileAssets: task ':app:mergeDynamicProfileAssets' mergeDynamicProfileJniLibFolders: task ':app:mergeDynamicProfileJniLibFolders' mergeDynamicProfileResources: task ':app:mergeDynamicProfileResources' mergeDynamicProfileShaders: task ':app:mergeDynamicProfileShaders' mergeDynamicReleaseAssets: task ':app:mergeDynamicReleaseAssets' mergeDynamicReleaseJniLibFolders: task ':app:mergeDynamicReleaseJniLibFolders' mergeDynamicReleaseResources: task ':app:mergeDynamicReleaseResources' mergeDynamicReleaseShaders: task ':app:mergeDynamicReleaseShaders' mergeProfileAssets: task ':app:mergeProfileAssets' mergeProfileJniLibFolders: task ':app:mergeProfileJniLibFolders' mergeProfileResources: task ':app:mergeProfileResources' mergeProfileShaders: task ':app:mergeProfileShaders' mergeReleaseAssets: task ':app:mergeReleaseAssets' mergeReleaseJniLibFolders: task ':app:mergeReleaseJniLibFolders' mergeReleaseResources: task ':app:mergeReleaseResources' mergeReleaseShaders: task ':app:mergeReleaseShaders' modelRegistry: org.gradle.model.internal.registry.DefaultModelRegistry@b3cec76 modelSchemaStore: org.gradle.model.internal.manage.schema.extract.DefaultModelSchemaStore@73c30ce2 module: org.gradle.api.internal.artifacts.ProjectBackedModule@62552397 name: app normalization: org.gradle.normalization.internal.DefaultInputNormalizationHandler_Decorated@57dc01f objects: org.gradle.api.internal.model.DefaultObjectFactory@466f048e org.gradle.jvmargs: -Xmx1536M packageAppClassesDebug: task ':app:packageAppClassesDebug' packageAppClassesDebugAndroidTest: task ':app:packageAppClassesDebugAndroidTest' packageAppClassesDebugUnitTest: task ':app:packageAppClassesDebugUnitTest' packageAppClassesDynamicProfile: task ':app:packageAppClassesDynamicProfile' packageAppClassesDynamicProfileUnitTest: task ':app:packageAppClassesDynamicProfileUnitTest' packageAppClassesDynamicRelease: task ':app:packageAppClassesDynamicRelease' packageAppClassesDynamicReleaseUnitTest: task ':app:packageAppClassesDynamicReleaseUnitTest' packageAppClassesProfile: task ':app:packageAppClassesProfile' packageAppClassesProfileUnitTest: task ':app:packageAppClassesProfileUnitTest' packageAppClassesRelease: task ':app:packageAppClassesRelease' packageAppClassesReleaseUnitTest: task ':app:packageAppClassesReleaseUnitTest' packageDebug: task ':app:packageDebug' packageDebugAndroidTest: task ':app:packageDebugAndroidTest' packageDebugBundle: task ':app:packageDebugBundle' packageDebugUniversalApk: task ':app:packageDebugUniversalApk' packageDynamicProfile: task ':app:packageDynamicProfile' packageDynamicProfileBundle: task ':app:packageDynamicProfileBundle' packageDynamicProfileUniversalApk: task ':app:packageDynamicProfileUniversalApk' packageDynamicRelease: task ':app:packageDynamicRelease' packageDynamicReleaseBundle: task ':app:packageDynamicReleaseBundle' packageDynamicReleaseUniversalApk: task ':app:packageDynamicReleaseUniversalApk' packageProfile: task ':app:packageProfile' packageProfileBundle: task ':app:packageProfileBundle' packageProfileUniversalApk: task ':app:packageProfileUniversalApk' packageRelease: task ':app:packageRelease' packageReleaseBundle: task ':app:packageReleaseBundle' packageReleaseUniversalApk: task ':app:packageReleaseUniversalApk' parent: root project 'android' parentIdentifier: root project 'android' path: :app pluginManager: org.gradle.api.internal.plugins.DefaultPluginManager_Decorated@7fa6391a plugins: [org.gradle.api.plugins.HelpTasksPlugin@131525c4, com.android.build.gradle.api.AndroidBasePlugin@78836281, org.gradle.language.base.plugins.LifecycleBasePlugin@4676426b, org.gradle.api.plugins.BasePlugin@8d6cd56, org.gradle.api.plugins.ReportingBasePlugin@3257e28d, org.gradle.api.plugins.JavaBasePlugin@5123192c, com.android.build.gradle.AppPlugin@25b27c79, FlutterPlugin@1b30b9e4] preBuild: task ':app:preBuild' preDebugAndroidTestBuild: task ':app:preDebugAndroidTestBuild' preDebugBuild: task ':app:preDebugBuild' preDebugUnitTestBuild: task ':app:preDebugUnitTestBuild' preDynamicProfileBuild: task ':app:preDynamicProfileBuild' preDynamicProfileUnitTestBuild: task ':app:preDynamicProfileUnitTestBuild' preDynamicReleaseBuild: task ':app:preDynamicReleaseBuild' preDynamicReleaseUnitTestBuild: task ':app:preDynamicReleaseUnitTestBuild' preProfileBuild: task ':app:preProfileBuild' preProfileUnitTestBuild: task ':app:preProfileUnitTestBuild' preReleaseBuild: task ':app:preReleaseBuild' preReleaseUnitTestBuild: task ':app:preReleaseUnitTestBuild' prepareLintJar: task ':app:prepareLintJar' processDebugAndroidTestJavaRes: task ':app:processDebugAndroidTestJavaRes' processDebugAndroidTestManifest: task ':app:processDebugAndroidTestManifest' processDebugAndroidTestResources: task ':app:processDebugAndroidTestResources' processDebugJavaRes: task ':app:processDebugJavaRes' processDebugManifest: task ':app:processDebugManifest' processDebugResources: task ':app:processDebugResources' processDebugUnitTestJavaRes: task ':app:processDebugUnitTestJavaRes' processDynamicProfileJavaRes: task ':app:processDynamicProfileJavaRes' processDynamicProfileManifest: task ':app:processDynamicProfileManifest' processDynamicProfileResources: task ':app:processDynamicProfileResources' processDynamicProfileUnitTestJavaRes: task ':app:processDynamicProfileUnitTestJavaRes' processDynamicReleaseJavaRes: task ':app:processDynamicReleaseJavaRes' processDynamicReleaseManifest: task ':app:processDynamicReleaseManifest' processDynamicReleaseResources: task ':app:processDynamicReleaseResources' processDynamicReleaseUnitTestJavaRes: task ':app:processDynamicReleaseUnitTestJavaRes' processOperations: org.gradle.api.internal.file.DefaultFileOperations@59f2fa89 processProfileJavaRes: task ':app:processProfileJavaRes' processProfileManifest: task ':app:processProfileManifest' processProfileResources: task ':app:processProfileResources' processProfileUnitTestJavaRes: task ':app:processProfileUnitTestJavaRes' processReleaseJavaRes: task ':app:processReleaseJavaRes' processReleaseManifest: task ':app:processReleaseManifest' processReleaseResources: task ':app:processReleaseResources' processReleaseUnitTestJavaRes: task ':app:processReleaseUnitTestJavaRes' project: project ':app' projectConfigurator: org.gradle.api.internal.project.BuildOperationCrossProjectConfigurator@16fe7385 projectDir: C:\Users\addis\OneDrive\temp\hello\android\app projectEvaluationBroadcaster: ProjectEvaluationListener broadcast projectEvaluator: org.gradle.configuration.project.LifecycleProjectEvaluator@5fddf20f projectPath: :app projectRegistry: org.gradle.api.internal.project.DefaultProjectRegistry@693a1c39 properties: {...} providers: org.gradle.api.internal.provider.DefaultProviderFactory@b56bf95 reportBuildArtifactsDebug: task ':app:reportBuildArtifactsDebug' reportBuildArtifactsDynamicProfile: task ':app:reportBuildArtifactsDynamicProfile' reportBuildArtifactsDynamicRelease: task ':app:reportBuildArtifactsDynamicRelease' reportBuildArtifactsProfile: task ':app:reportBuildArtifactsProfile' reportBuildArtifactsRelease: task ':app:reportBuildArtifactsRelease' reportSourceSetTransformAndroidTest: task ':app:reportSourceSetTransformAndroidTest' reportSourceSetTransformAndroidTestDebug: task ':app:reportSourceSetTransformAndroidTestDebug' reportSourceSetTransformDebug: task ':app:reportSourceSetTransformDebug' reportSourceSetTransformDynamicProfile: task ':app:reportSourceSetTransformDynamicProfile' reportSourceSetTransformDynamicRelease: task ':app:reportSourceSetTransformDynamicRelease' reportSourceSetTransformMain: task ':app:reportSourceSetTransformMain' reportSourceSetTransformProfile: task ':app:reportSourceSetTransformProfile' reportSourceSetTransformRelease: task ':app:reportSourceSetTransformRelease' reportSourceSetTransformTest: task ':app:reportSourceSetTransformTest' reportSourceSetTransformTestDebug: task ':app:reportSourceSetTransformTestDebug' reportSourceSetTransformTestDynamicProfile: task ':app:reportSourceSetTransformTestDynamicProfile' reportSourceSetTransformTestDynamicRelease: task ':app:reportSourceSetTransformTestDynamicRelease' reportSourceSetTransformTestProfile: task ':app:reportSourceSetTransformTestProfile' reportSourceSetTransformTestRelease: task ':app:reportSourceSetTransformTestRelease' reporting: org.gradle.api.reporting.ReportingExtension_Decorated@775b6763 reportsDir: C:\Users\addis\OneDrive\temp\hello\build\app\reports repositories: repository container resolveConfigAttr: task ':app:resolveConfigAttr' resourceLoader: org.gradle.internal.resource.transfer.DefaultUriTextResourceLoader@125c5056 resources: org.gradle.api.internal.resources.DefaultResourceHandler@22a19598 rootDir: C:\Users\addis\OneDrive\temp\hello\android rootProject: root project 'android' script: false scriptHandlerFactory: org.gradle.api.internal.initialization.DefaultScriptHandlerFactory@1b438e21 scriptPluginFactory: org.gradle.configuration.ScriptPluginFactorySelector@378f8255 serviceRegistryFactory: org.gradle.internal.service.scopes.ProjectScopeServices$4@47a1ba12 services: ProjectScopeServices signingReport: task ':app:signingReport' sourceCompatibility: 1.8 sourceSets: SourceSet container splitsDiscoveryTaskDebug: task ':app:splitsDiscoveryTaskDebug' splitsDiscoveryTaskDynamicProfile: task ':app:splitsDiscoveryTaskDynamicProfile' splitsDiscoveryTaskDynamicRelease: task ':app:splitsDiscoveryTaskDynamicRelease' splitsDiscoveryTaskProfile: task ':app:splitsDiscoveryTaskProfile' splitsDiscoveryTaskRelease: task ':app:splitsDiscoveryTaskRelease' standardOutputCapture: org.gradle.internal.logging.services.DefaultLoggingManager@5c5cb58c state: project state 'EXECUTED' status: integration subprojects: [] targetCompatibility: 1.8 tasks: task set test: task ':app:test' testDebugUnitTest: task ':app:testDebugUnitTest' testDynamicProfileUnitTest: task ':app:testDynamicProfileUnitTest' testDynamicReleaseUnitTest: task ':app:testDynamicReleaseUnitTest' testProfileUnitTest: task ':app:testProfileUnitTest' testReleaseUnitTest: task ':app:testReleaseUnitTest' testReportDir: C:\Users\addis\OneDrive\temp\hello\build\app\reports\tests testReportDirName: tests testResultsDir: C:\Users\addis\OneDrive\temp\hello\build\app\test-results testResultsDirName: test-results transformClassesWithDexBuilderForDebug: task ':app:transformClassesWithDexBuilderForDebug' transformClassesWithDexBuilderForDebugAndroidTest: task ':app:transformClassesWithDexBuilderForDebugAndroidTest' transformClassesWithDexBuilderForDynamicProfile: task ':app:transformClassesWithDexBuilderForDynamicProfile' transformClassesWithDexBuilderForDynamicRelease: task ':app:transformClassesWithDexBuilderForDynamicRelease' transformClassesWithDexBuilderForProfile: task ':app:transformClassesWithDexBuilderForProfile' transformClassesWithDexBuilderForRelease: task ':app:transformClassesWithDexBuilderForRelease' transformDexArchiveWithDexMergerForDebug: task ':app:transformDexArchiveWithDexMergerForDebug' transformDexArchiveWithDexMergerForDebugAndroidTest: task ':app:transformDexArchiveWithDexMergerForDebugAndroidTest' transformDexArchiveWithDexMergerForDynamicProfile: task ':app:transformDexArchiveWithDexMergerForDynamicProfile' transformDexArchiveWithDexMergerForDynamicRelease: task ':app:transformDexArchiveWithDexMergerForDynamicRelease' transformDexArchiveWithDexMergerForProfile: task ':app:transformDexArchiveWithDexMergerForProfile' transformDexArchiveWithDexMergerForRelease: task ':app:transformDexArchiveWithDexMergerForRelease' transformDexArchiveWithExternalLibsDexMergerForDebug: task ':app:transformDexArchiveWithExternalLibsDexMergerForDebug' transformDexArchiveWithExternalLibsDexMergerForDebugAndroidTest: task ':app:transformDexArchiveWithExternalLibsDexMergerForDebugAndroidTest' transformDexArchiveWithExternalLibsDexMergerForDynamicProfile: task ':app:transformDexArchiveWithExternalLibsDexMergerForDynamicProfile' transformDexArchiveWithExternalLibsDexMergerForDynamicRelease: task ':app:transformDexArchiveWithExternalLibsDexMergerForDynamicRelease' transformDexArchiveWithExternalLibsDexMergerForProfile: task ':app:transformDexArchiveWithExternalLibsDexMergerForProfile' transformDexArchiveWithExternalLibsDexMergerForRelease: task ':app:transformDexArchiveWithExternalLibsDexMergerForRelease' transformNativeLibsWithMergeJniLibsForDebug: task ':app:transformNativeLibsWithMergeJniLibsForDebug' transformNativeLibsWithMergeJniLibsForDebugAndroidTest: task ':app:transformNativeLibsWithMergeJniLibsForDebugAndroidTest' transformNativeLibsWithMergeJniLibsForDynamicProfile: task ':app:transformNativeLibsWithMergeJniLibsForDynamicProfile' transformNativeLibsWithMergeJniLibsForDynamicRelease: task ':app:transformNativeLibsWithMergeJniLibsForDynamicRelease' transformNativeLibsWithMergeJniLibsForProfile: task ':app:transformNativeLibsWithMergeJniLibsForProfile' transformNativeLibsWithMergeJniLibsForRelease: task ':app:transformNativeLibsWithMergeJniLibsForRelease' transformResourcesWithMergeJavaResForDebug: task ':app:transformResourcesWithMergeJavaResForDebug' transformResourcesWithMergeJavaResForDebugAndroidTest: task ':app:transformResourcesWithMergeJavaResForDebugAndroidTest' transformResourcesWithMergeJavaResForDebugUnitTest: task ':app:transformResourcesWithMergeJavaResForDebugUnitTest' transformResourcesWithMergeJavaResForDynamicProfile: task ':app:transformResourcesWithMergeJavaResForDynamicProfile' transformResourcesWithMergeJavaResForDynamicProfileUnitTest: task ':app:transformResourcesWithMergeJavaResForDynamicProfileUnitTest' transformResourcesWithMergeJavaResForDynamicRelease: task ':app:transformResourcesWithMergeJavaResForDynamicRelease' transformResourcesWithMergeJavaResForDynamicReleaseUnitTest: task ':app:transformResourcesWithMergeJavaResForDynamicReleaseUnitTest' transformResourcesWithMergeJavaResForProfile: task ':app:transformResourcesWithMergeJavaResForProfile' transformResourcesWithMergeJavaResForProfileUnitTest: task ':app:transformResourcesWithMergeJavaResForProfileUnitTest' transformResourcesWithMergeJavaResForRelease: task ':app:transformResourcesWithMergeJavaResForRelease' transformResourcesWithMergeJavaResForReleaseUnitTest: task ':app:transformResourcesWithMergeJavaResForReleaseUnitTest' uninstallAll: task ':app:uninstallAll' uninstallDebug: task ':app:uninstallDebug' uninstallDebugAndroidTest: task ':app:uninstallDebugAndroidTest' uninstallDynamicProfile: task ':app:uninstallDynamicProfile' uninstallDynamicRelease: task ':app:uninstallDynamicRelease' uninstallProfile: task ':app:uninstallProfile' uninstallRelease: task ':app:uninstallRelease' validateSigningDebug: task ':app:validateSigningDebug' validateSigningDebugAndroidTest: task ':app:validateSigningDebugAndroidTest' validateSigningDynamicProfile: task ':app:validateSigningDynamicProfile' validateSigningDynamicRelease: task ':app:validateSigningDynamicRelease' validateSigningProfile: task ':app:validateSigningProfile' validateSigningRelease: task ':app:validateSigningRelease' version: unspecified writeDebugApplicationId: task ':app:writeDebugApplicationId' writeDynamicProfileApplicationId: task ':app:writeDynamicProfileApplicationId' writeDynamicReleaseApplicationId: task ':app:writeDynamicReleaseApplicationId' writeProfileApplicationId: task ':app:writeProfileApplicationId' writeReleaseApplicationId: task ':app:writeReleaseApplicationId' 1 actionable task: 1 executed [ +25 ms] executing: [C:\Users\addis\OneDrive\temp\hello\android\] C:\Users\addis\OneDrive\temp\hello\android\gradlew.bat app:tasks --all [+1856 ms] > Task :app:tasks ------------------------------------------------------------ All tasks runnable from project :app ------------------------------------------------------------ Android tasks ------------- androidDependencies - Displays the Android dependencies of the project. signingReport - Displays the signing info for each variant. sourceSets - Prints out all the source sets defined in this project. Build tasks ----------- assemble - Assembles all variants of all applications and secondary packages. assembleAndroidTest - Assembles all the Test applications. assembleDebug - Assembles all Debug builds. assembleDynamicProfile - Assembles all DynamicProfile builds. assembleDynamicRelease - Assembles all DynamicRelease builds. assembleProfile - Assembles all Profile builds. assembleRelease - Assembles all Release builds. build - Assembles and tests this project. buildDependents - Assembles and tests this project and all projects that depend on it. buildNeeded - Assembles and tests this project and all projects it depends on. bundleDebug - Creates all Debug bundles. bundleDynamicProfile - Creates all DynamicProfile bundles. bundleDynamicRelease - Creates all DynamicRelease bundles. bundleProfile - Creates all Profile bundles. bundleRelease - Creates all Release bundles. clean - Deletes the build directory. cleanBuildCache - Deletes the build cache directory. compileDebugAndroidTestSources compileDebugSources compileDebugUnitTestSources compileDynamicProfileSources compileDynamicProfileUnitTestSources compileDynamicReleaseSources compileDynamicReleaseUnitTestSources compileProfileSources compileProfileUnitTestSources compileReleaseSources compileReleaseUnitTestSources Cleanup tasks ------------- lintFix - Runs lint on all variants and applies any safe suggestions to the source code. Help tasks ---------- buildEnvironment - Displays all buildscript dependencies declared in project ':app'. components - Displays the components produced by project ':app'. [incubating] dependencies - Displays all dependencies declared in project ':app'. dependencyInsight - Displays the insight into a specific dependency in project ':app'. dependentComponents - Displays the dependent components of components in project ':app'. [incubating] help - Displays a help message. model - Displays the configuration model of project ':app'. [incubating] projects - Displays the sub-projects of project ':app'. properties - Displays the properties of project ':app'. tasks - Displays the tasks runnable from project ':app'. Install tasks ------------- installDebug - Installs the Debug build. installDebugAndroidTest - Installs the android (on device) tests for the Debug build. installDynamicProfile - Installs the DynamicProfile build. installDynamicRelease - Installs the DynamicRelease build. installProfile - Installs the Profile build. installRelease - Installs the Release build. uninstallAll - Uninstall all applications. uninstallDebug - Uninstalls the Debug build. uninstallDebugAndroidTest - Uninstalls the android (on device) tests for the Debug build. uninstallDynamicProfile - Uninstalls the DynamicProfile build. uninstallDynamicRelease - Uninstalls the DynamicRelease build. uninstallProfile - Uninstalls the Profile build. uninstallRelease - Uninstalls the Release build. Verification tasks ------------------ check - Runs all checks. connectedAndroidTest - Installs and runs instrumentation tests for all flavors on connected devices. connectedCheck - Runs all device checks on currently connected devices. connectedDebugAndroidTest - Installs and runs the tests for debug on connected devices. deviceAndroidTest - Installs and runs instrumentation tests using all Device Providers. deviceCheck - Runs all device checks using Device Providers and Test Servers. lint - Runs lint on all variants. lintDebug - Runs lint on the Debug build. lintDynamicProfile - Runs lint on the DynamicProfile build. lintDynamicRelease - Runs lint on the DynamicRelease build. lintProfile - Runs lint on the Profile build. lintRelease - Runs lint on the Release build. lintVitalRelease - Runs lint on just the fatal issues in the release build. test - Run unit tests for all variants. testDebugUnitTest - Run unit tests for the debug build. testDynamicProfileUnitTest - Run unit tests for the dynamicProfile build. testDynamicReleaseUnitTest - Run unit tests for the dynamicRelease build. testProfileUnitTest - Run unit tests for the profile build. testReleaseUnitTest - Run unit tests for the release build. Other tasks ----------- assembleDebugAndroidTest assembleDebugUnitTest assembleDynamicProfileUnitTest assembleDynamicReleaseUnitTest assembleProfileUnitTest assembleReleaseUnitTest buildDebugPreBundle buildDynamicProfilePreBundle buildDynamicReleasePreBundle buildProfilePreBundle buildReleasePreBundle bundle bundleDebugAndroidTestResources bundleDebugResources bundleDynamicProfileResources bundleDynamicReleaseResources bundleProfileResources bundleReleaseResources checkDebugAndroidTestClasspath checkDebugClasspath checkDebugLibraries checkDebugManifest checkDynamicProfileClasspath checkDynamicProfileLibraries checkDynamicProfileManifest checkDynamicReleaseClasspath checkDynamicReleaseLibraries checkDynamicReleaseManifest checkProfileClasspath checkProfileLibraries checkProfileManifest checkReleaseClasspath checkReleaseLibraries checkReleaseManifest compileDebugAidl compileDebugAndroidTestAidl compileDebugAndroidTestJavaWithJavac compileDebugAndroidTestNdk compileDebugAndroidTestRenderscript compileDebugAndroidTestShaders compileDebugJavaWithJavac compileDebugNdk compileDebugRenderscript compileDebugShaders compileDebugUnitTestJavaWithJavac compileDynamicProfileAidl compileDynamicProfileJavaWithJavac compileDynamicProfileNdk compileDynamicProfileRenderscript compileDynamicProfileShaders compileDynamicProfileUnitTestJavaWithJavac compileDynamicReleaseAidl compileDynamicReleaseJavaWithJavac compileDynamicReleaseNdk compileDynamicReleaseRenderscript compileDynamicReleaseShaders compileDynamicReleaseUnitTestJavaWithJavac compileLint compileProfileAidl compileProfileJavaWithJavac compileProfileNdk compileProfileRenderscript compileProfileShaders compileProfileUnitTestJavaWithJavac compileReleaseAidl compileReleaseJavaWithJavac compileReleaseNdk compileReleaseRenderscript compileReleaseShaders compileReleaseUnitTestJavaWithJavac consumeConfigAttr copyFlutterAssetsDebug copyFlutterAssetsDynamicProfile copyFlutterAssetsDynamicRelease copyFlutterAssetsProfile copyFlutterAssetsRelease createDebugCompatibleScreenManifests createDynamicProfileCompatibleScreenManifests createDynamicReleaseCompatibleScreenManifests createMockableJar createProfileCompatibleScreenManifests createReleaseCompatibleScreenManifests extractApksForDebug extractApksForDynamicProfile extractApksForDynamicRelease extractApksForProfile extractApksForRelease extractProguardFiles flutterBuildDebug flutterBuildDynamicProfile flutterBuildDynamicRelease flutterBuildProfile flutterBuildRelease flutterBuildX86Jar generateDebugAndroidTestAssets generateDebugAndroidTestBuildConfig generateDebugAndroidTestResources generateDebugAndroidTestResValues generateDebugAndroidTestSources generateDebugAssets generateDebugBuildConfig generateDebugFeatureMetadata generateDebugFeatureTransitiveDeps generateDebugResources generateDebugResValues generateDebugSources generateDebugUnitTestAssets generateDebugUnitTestResources generateDebugUnitTestSources generateDynamicProfileAssets generateDynamicProfileBuildConfig generateDynamicProfileFeatureMetadata generateDynamicProfileFeatureTransitiveDeps generateDynamicProfileResources generateDynamicProfileResValues generateDynamicProfileSources generateDynamicProfileUnitTestAssets generateDynamicProfileUnitTestResources generateDynamicProfileUnitTestSources generateDynamicReleaseAssets generateDynamicReleaseBuildConfig generateDynamicReleaseFeatureMetadata generateDynamicReleaseFeatureTransitiveDeps generateDynamicReleaseResources generateDynamicReleaseResValues generateDynamicReleaseSources generateDynamicReleaseUnitTestAssets generateDynamicReleaseUnitTestResources generateDynamicReleaseUnitTestSources generateProfileAssets generateProfileBuildConfig generateProfileFeatureMetadata generateProfileFeatureTransitiveDeps generateProfileResources generateProfileResValues generateProfileSources generateProfileUnitTestAssets generateProfileUnitTestResources generateProfileUnitTestSources generateReleaseAssets generateReleaseBuildConfig generateReleaseFeatureMetadata generateReleaseFeatureTransitiveDeps generateReleaseResources generateReleaseResValues generateReleaseSources generateReleaseUnitTestAssets generateReleaseUnitTestResources generateReleaseUnitTestSources javaPreCompileDebug javaPreCompileDebugAndroidTest javaPreCompileDebugUnitTest javaPreCompileDynamicProfile javaPreCompileDynamicProfileUnitTest javaPreCompileDynamicRelease javaPreCompileDynamicReleaseUnitTest javaPreCompileProfile javaPreCompileProfileUnitTest javaPreCompileRelease javaPreCompileReleaseUnitTest mainApkListPersistenceDebug mainApkListPersistenceDebugAndroidTest mainApkListPersistenceDynamicProfile mainApkListPersistenceDynamicRelease mainApkListPersistenceProfile mainApkListPersistenceRelease makeApkFromBundleForDebug makeApkFromBundleForDynamicProfile makeApkFromBundleForDynamicRelease makeApkFromBundleForProfile makeApkFromBundleForRelease mergeDebugAndroidTestAssets mergeDebugAndroidTestJniLibFolders mergeDebugAndroidTestResources mergeDebugAndroidTestShaders mergeDebugAssets mergeDebugJniLibFolders mergeDebugResources mergeDebugShaders mergeDynamicProfileAssets mergeDynamicProfileJniLibFolders mergeDynamicProfileResources mergeDynamicProfileShaders mergeDynamicReleaseAssets mergeDynamicReleaseJniLibFolders mergeDynamicReleaseResources mergeDynamicReleaseShaders mergeProfileAssets mergeProfileJniLibFolders mergeProfileResources mergeProfileShaders mergeReleaseAssets mergeReleaseJniLibFolders mergeReleaseResources mergeReleaseShaders packageAppClassesDebug packageAppClassesDebugAndroidTest packageAppClassesDebugUnitTest packageAppClassesDynamicProfile packageAppClassesDynamicProfileUnitTest packageAppClassesDynamicRelease packageAppClassesDynamicReleaseUnitTest packageAppClassesProfile packageAppClassesProfileUnitTest packageAppClassesRelease packageAppClassesReleaseUnitTest packageDebug packageDebugAndroidTest packageDebugBundle packageDebugUniversalApk packageDynamicProfile packageDynamicProfileBundle packageDynamicProfileUniversalApk packageDynamicRelease packageDynamicReleaseBundle packageDynamicReleaseUniversalApk packageProfile packageProfileBundle packageProfileUniversalApk packageRelease packageReleaseBundle packageReleaseUniversalApk preBuild preDebugAndroidTestBuild preDebugBuild preDebugUnitTestBuild preDynamicProfileBuild preDynamicProfileUnitTestBuild preDynamicReleaseBuild preDynamicReleaseUnitTestBuild prepareLintJar preProfileBuild preProfileUnitTestBuild preReleaseBuild preReleaseUnitTestBuild processDebugAndroidTestJavaRes processDebugAndroidTestManifest processDebugAndroidTestResources processDebugJavaRes processDebugManifest processDebugResources processDebugUnitTestJavaRes processDynamicProfileJavaRes processDynamicProfileManifest processDynamicProfileResources processDynamicProfileUnitTestJavaRes processDynamicReleaseJavaRes processDynamicReleaseManifest processDynamicReleaseResources processDynamicReleaseUnitTestJavaRes processProfileJavaRes processProfileManifest processProfileResources processProfileUnitTestJavaRes processReleaseJavaRes processReleaseManifest processReleaseResources processReleaseUnitTestJavaRes reportBuildArtifactsDebug reportBuildArtifactsDynamicProfile reportBuildArtifactsDynamicRelease reportBuildArtifactsProfile reportBuildArtifactsRelease reportSourceSetTransformAndroidTest reportSourceSetTransformAndroidTestDebug reportSourceSetTransformDebug reportSourceSetTransformDynamicProfile reportSourceSetTransformDynamicRelease reportSourceSetTransformMain reportSourceSetTransformProfile reportSourceSetTransformRelease reportSourceSetTransformTest reportSourceSetTransformTestDebug reportSourceSetTransformTestDynamicProfile reportSourceSetTransformTestDynamicRelease reportSourceSetTransformTestProfile reportSourceSetTransformTestRelease resolveConfigAttr splitsDiscoveryTaskDebug splitsDiscoveryTaskDynamicProfile splitsDiscoveryTaskDynamicRelease splitsDiscoveryTaskProfile splitsDiscoveryTaskRelease transformClassesWithDexBuilderForDebug transformClassesWithDexBuilderForDebugAndroidTest transformClassesWithDexBuilderForDynamicProfile transformClassesWithDexBuilderForDynamicRelease transformClassesWithDexBuilderForProfile transformClassesWithDexBuilderForRelease transformDexArchiveWithDexMergerForDebug transformDexArchiveWithDexMergerForDebugAndroidTest transformDexArchiveWithDexMergerForDynamicProfile transformDexArchiveWithDexMergerForDynamicRelease transformDexArchiveWithDexMergerForProfile transformDexArchiveWithDexMergerForRelease transformDexArchiveWithExternalLibsDexMergerForDebug transformDexArchiveWithExternalLibsDexMergerForDebugAndroidTest transformDexArchiveWithExternalLibsDexMergerForDynamicProfile transformDexArchiveWithExternalLibsDexMergerForDynamicRelease transformDexArchiveWithExternalLibsDexMergerForProfile transformDexArchiveWithExternalLibsDexMergerForRelease transformNativeLibsWithMergeJniLibsForDebug transformNativeLibsWithMergeJniLibsForDebugAndroidTest transformNativeLibsWithMergeJniLibsForDynamicProfile transformNativeLibsWithMergeJniLibsForDynamicRelease transformNativeLibsWithMergeJniLibsForProfile transformNativeLibsWithMergeJniLibsForRelease transformResourcesWithMergeJavaResForDebug transformResourcesWithMergeJavaResForDebugAndroidTest transformResourcesWithMergeJavaResForDebugUnitTest transformResourcesWithMergeJavaResForDynamicProfile transformResourcesWithMergeJavaResForDynamicProfileUnitTest transformResourcesWithMergeJavaResForDynamicRelease transformResourcesWithMergeJavaResForDynamicReleaseUnitTest transformResourcesWithMergeJavaResForProfile transformResourcesWithMergeJavaResForProfileUnitTest transformResourcesWithMergeJavaResForRelease transformResourcesWithMergeJavaResForReleaseUnitTest validateSigningDebug validateSigningDebugAndroidTest validateSigningDynamicProfile validateSigningDynamicRelease validateSigningProfile validateSigningRelease writeDebugApplicationId writeDynamicProfileApplicationId writeDynamicReleaseApplicationId writeProfileApplicationId writeReleaseApplicationId Rules ----- Pattern: clean<TaskName>: Cleans the output files of a task. Pattern: build<ConfigurationName>: Assembles the artifacts of a configuration. Pattern: upload<ConfigurationName>: Assembles and uploads the artifacts belonging to a configuration. 1 actionable task: 1 executed [ +13 ms] Resolving dependencies... (completed) [ +2 ms] executing: C:\Users\addis\AppData\Local\Android\sdk\build-tools\28.0.3\aapt dump xmltree C:\Users\addis\OneDrive\temp\hello\build\app\outputs\apk\app.apk AndroidManifest.xml [ +27 ms] Exit code 0 from: C:\Users\addis\AppData\Local\Android\sdk\build-tools\28.0.3\aapt dump xmltree C:\Users\addis\OneDrive\temp\hello\build\app\outputs\apk\app.apk AndroidManifest.xml [ ] N: android=http://schemas.android.com/apk/res/android E: manifest (line=2) A: android:versionCode(0x0101021b)=(type 0x10)0x1 A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0") A: package="com.example.hello" (Raw: "com.example.hello") A: platformBuildVersionCode=(type 0x10)0x1 A: platformBuildVersionName="1.0.0" (Raw: "1.0.0") E: uses-sdk (line=7) A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1b E: uses-permission (line=16) A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET") E: application (line=24) A: android:label(0x01010001)="hello" (Raw: "hello") A: android:icon(0x01010002)=@0x7f020000 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication") A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff E: activity (line=29) A: android:theme(0x01010000)=@0x7f030000 A: android:name(0x01010003)="com.example.hello.MainActivity" (Raw: "com.example.hello.MainActivity") A: android:launchMode(0x0101001d)=(type 0x10)0x1 A: android:configChanges(0x0101001f)=(type 0x11)0x400035b4 A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10 A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff E: meta-data (line=43) A: android:name(0x01010003)="io.flutter.app.android.SplashScreenUntilFirstFrame" (Raw: "io.flutter.app.android.SplashScreenUntilFirstFrame") A: android:value(0x01010024)=(type 0x12)0xffffffff E: intent-filter (line=47) E: action (line=48) A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN") E: category (line=50) A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER") E: service (line=54) A: android:name(0x01010003)="com.example.hello.HelloService" (Raw: "com.example.hello.HelloService") [ +13 ms] executing: C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb -s emulator-5554 shell -x logcat -v time -t 1 [ +46 ms] Exit code 0 from: C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb -s emulator-5554 shell -x logcat -v time -t 1 [ ] --------- beginning of main 12-17 06:44:12.264 W/ctxmgr ( 2633): [AclManager]No 2 for (accnt=account#-517948760#, com.google.android.gms(10020):IndoorOutdoorProducer, vrsn=12862000, 0, 3pPkg = null , 3pMdlId = null , pid = 2633). Was: 3 for 57, account#-517948760# [ +2 ms] executing: C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb -s emulator-5554 shell -x logcat -v time [ +418 ms] DependencyChecker: nothing is modified after 2018-12-17 14:40:53.000. [ +3 ms] executing: C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb version [ +35 ms] Android Debug Bridge version 1.0.40 Version 4986621 Installed as C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb.EXE [ +3 ms] executing: C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb start-server [ +42 ms] Building APK [ +24 ms] Gradle task 'assembleDebug'... [ +12 ms] executing: [C:\Users\addis\OneDrive\temp\hello\android\] C:\Users\addis\OneDrive\temp\hello\android\gradlew.bat -Pverbose=true -Ptarget=C:\Users\addis\OneDrive\temp\hello\lib/main.dart -Ptrack-widget-creation=false -Pfilesystem-scheme=org-dartlang-root assembleDebug [+1711 ms] > Task :app:flutterBuildX86Jar UP-TO-DATE [ +1 ms] > Task :app:checkDebugClasspath UP-TO-DATE [ ] > Task :app:preBuild UP-TO-DATE [ ] > Task :app:preDebugBuild UP-TO-DATE [ ] > Task :app:compileDebugAidl NO-SOURCE [ ] > Task :app:compileDebugRenderscript UP-TO-DATE [ ] > Task :app:checkDebugManifest UP-TO-DATE [ ] > Task :app:generateDebugBuildConfig UP-TO-DATE [ ] > Task :app:prepareLintJar UP-TO-DATE [ ] > Task :app:cleanMergeDebugAssets [ +91 ms] > Task :app:flutterBuildDebug UP-TO-DATE [ ] > Task :app:mergeDebugShaders UP-TO-DATE [ ] > Task :app:compileDebugShaders UP-TO-DATE [ ] > Task :app:generateDebugAssets UP-TO-DATE [ ] > Task :app:mergeDebugAssets [ +298 ms] > Task :app:copyFlutterAssetsDebug [ +1 ms] > Task :app:mainApkListPersistenceDebug UP-TO-DATE [ ] > Task :app:generateDebugResValues UP-TO-DATE [ ] > Task :app:generateDebugResources UP-TO-DATE [ ] > Task :app:mergeDebugResources UP-TO-DATE [ ] > Task :app:createDebugCompatibleScreenManifests UP-TO-DATE [ ] > Task :app:processDebugManifest UP-TO-DATE [ ] > Task :app:splitsDiscoveryTaskDebug UP-TO-DATE [ ] > Task :app:processDebugResources UP-TO-DATE [ ] > Task :app:generateDebugSources UP-TO-DATE [ ] > Task :app:javaPreCompileDebug UP-TO-DATE [ ] > Task :app:compileDebugJavaWithJavac UP-TO-DATE [ ] > Task :app:compileDebugNdk NO-SOURCE [ ] > Task :app:compileDebugSources UP-TO-DATE [ ] > Task :app:transformClassesWithDexBuilderForDebug UP-TO-DATE [ ] > Task :app:transformDexArchiveWithExternalLibsDexMergerForDebug UP-TO-DATE [ ] > Task :app:transformDexArchiveWithDexMergerForDebug UP-TO-DATE [ ] > Task :app:mergeDebugJniLibFolders UP-TO-DATE [ ] > Task :app:transformNativeLibsWithMergeJniLibsForDebug UP-TO-DATE [ ] > Task :app:checkDebugLibraries UP-TO-DATE [ ] > Task :app:processDebugJavaRes NO-SOURCE [ +89 ms] > Task :app:transformResourcesWithMergeJavaResForDebug UP-TO-DATE [ ] > Task :app:validateSigningDebug UP-TO-DATE [ ] > Task :app:packageDebug UP-TO-DATE [ ] > Task :app:assembleDebug UP-TO-DATE [ ] 31 actionable tasks: 3 executed, 28 up-to-date [ +385 ms] Gradle task 'assembleDebug'... (completed) [ +46 ms] calculateSha: LocalDirectory: 'C:\Users\addis\OneDrive\temp\hello\build\app\outputs\apk'/app.apk [ +374 ms] Built build\app\outputs\apk\debug\app-debug.apk. [ +1 ms] executing: C:\Users\addis\AppData\Local\Android\sdk\build-tools\28.0.3\aapt dump xmltree C:\Users\addis\OneDrive\temp\hello\build\app\outputs\apk\app.apk AndroidManifest.xml [ +33 ms] Exit code 0 from: C:\Users\addis\AppData\Local\Android\sdk\build-tools\28.0.3\aapt dump xmltree C:\Users\addis\OneDrive\temp\hello\build\app\outputs\apk\app.apk AndroidManifest.xml [ ] N: android=http://schemas.android.com/apk/res/android E: manifest (line=2) A: android:versionCode(0x0101021b)=(type 0x10)0x1 A: android:versionName(0x0101021c)="1.0.0" (Raw: "1.0.0") A: package="com.example.hello" (Raw: "com.example.hello") A: platformBuildVersionCode=(type 0x10)0x1 A: platformBuildVersionName="1.0.0" (Raw: "1.0.0") E: uses-sdk (line=7) A: android:minSdkVersion(0x0101020c)=(type 0x10)0x10 A: android:targetSdkVersion(0x01010270)=(type 0x10)0x1b E: uses-permission (line=16) A: android:name(0x01010003)="android.permission.INTERNET" (Raw: "android.permission.INTERNET") E: application (line=24) A: android:label(0x01010001)="hello" (Raw: "hello") A: android:icon(0x01010002)=@0x7f020000 A: android:name(0x01010003)="io.flutter.app.FlutterApplication" (Raw: "io.flutter.app.FlutterApplication") A: android:debuggable(0x0101000f)=(type 0x12)0xffffffff E: activity (line=29) A: android:theme(0x01010000)=@0x7f030000 A: android:name(0x01010003)="com.example.hello.MainActivity" (Raw: "com.example.hello.MainActivity") A: android:launchMode(0x0101001d)=(type 0x10)0x1 A: android:configChanges(0x0101001f)=(type 0x11)0x400035b4 A: android:windowSoftInputMode(0x0101022b)=(type 0x11)0x10 A: android:hardwareAccelerated(0x010102d3)=(type 0x12)0xffffffff E: meta-data (line=43) A: android:name(0x01010003)="io.flutter.app.android.SplashScreenUntilFirstFrame" (Raw: "io.flutter.app.android.SplashScreenUntilFirstFrame") A: android:value(0x01010024)=(type 0x12)0xffffffff E: intent-filter (line=47) E: action (line=48) A: android:name(0x01010003)="android.intent.action.MAIN" (Raw: "android.intent.action.MAIN") E: category (line=50) A: android:name(0x01010003)="android.intent.category.LAUNCHER" (Raw: "android.intent.category.LAUNCHER") E: service (line=54) A: android:name(0x01010003)="com.example.hello.HelloService" (Raw: "com.example.hello.HelloService") [ +1 ms] Stopping app 'app.apk' on Android SDK built for x86. [ ] executing: C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb -s emulator-5554 shell am force-stop com.example.hello [ +79 ms] executing: C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb -s emulator-5554 shell pm list packages com.example.hello [ +119 ms] package:com.example.hello package:com.example.helloservice [ +4 ms] executing: C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb -s emulator-5554 shell cat /data/local/tmp/sky.com.example.hello.sha1 [ +60 ms] b5da419049aa8b7981c29712282657f1896f0e1a [ ] Latest build already installed. [ ] Android SDK built for x86 startApp [ +1 ms] executing: C:\Users\addis\AppData\Local\Android\sdk\platform-tools\adb -s emulator-5554 shell am start -a android.intent.action.RUN -f 0x20000000 --ez enable-background-compilation true --ez enable-dart-profiling true --ez enable-checked-mode true com.example.hello/com.example.hello.MainActivity [ +121 ms] Starting: Intent { act=android.intent.action.RUN flg=0x20000000 cmp=com.example.hello/.MainActivity (has extras)} [ +1 ms] Waiting for observatory port to be available... ``` ``` No issues found! (ran in 15.2s) ``` ``` [√] Flutter (Channel stable, v1.0.0, on Microsoft Windows [Version 10.0.17134.407], locale en-SG) • Flutter version 1.0.0 at C:\flutter • Framework revision 5391447fae (2 weeks ago), 2018-11-29 19:41:26 -0800 • Engine revision 7375a0f414 • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297) [√] Android toolchain - develop for Android devices (Android SDK 28.0.3) • Android SDK at C:\Users\addis\AppData\Local\Android\sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-28, build-tools 28.0.3 • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06) • All Android licenses accepted. [√] Android Studio (version 3.2) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin version 31.2.1 • Dart plugin version 181.5656 • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06) [√] VS Code, 64-bit edition (version 1.29.1) • VS Code at C:\Program Files\Microsoft VS Code • Flutter extension version 2.21.1 [√] Connected device (1 available) • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator) ```
platform-android,tool,P2,team-android,triaged-android
low
Critical
391,599,512
TypeScript
Allow local .js/.ts files to be typed by their corresponding .d.ts file
## Suggestion If I have `source/index.js` which has: ``` javascript function isObject(value) { // null is object, hence the extra check return value !== null && typeof value === 'object' } ``` And then I supply a `source/index.d.ts` file which has: ``` javascript /** Checks to see if a value is an object */ export function isObject(value: any): boolean ``` And I update `package.json:types` to `source/index.d.ts`. Then I should not receive the following error in `source/index.js`: ``` [ts] Parameter 'value' implicitly has an 'any' type. [7006] (parameter) value: any ``` And I should get complete intellisense. ## Use Cases This approach has the following benefits: 1. Source files can run without compilation, this has been incredibly useful for @bevry's hundreds of packages, which are all written in jsdoc'd esnext that runs on mostly node 4 and above, with compilation only for older node versions (but most of the time, it is our source code that is running, thanks to [editions](https://editions.bevry.me)) 2. JSDoc types do not provide intellisense nor type checking for typescript consumers 3. TypeDoc for documentation seems nicer than JSDoc, especially with overloads 4. Going all in on TypeScript may be too much to ask for, for many module authors - as a typescript project requires types for all its dependencies, as well as accurate (rather than merely simplistic) mappings, which some of the time, is just too inconvenient to bother with - [such as this](https://stackoverflow.com/q/53612877/130638), as well as [eachr](https://github.com/bevry/eachr/tree/dev-typescript-dts) which a pure typescript conversion seems impossible to me (after days of effort, as typescript always whines about incorrect types) Alternatives to this would be: 1. Have typescript projects support intellisense and type checking for jsdoc js files 2. Automatically generate .d.ts files for jsdoc js files For now, the best workaround seems to be: 1. Spend weeks upon weeks converting your hundreds of modules to typescript to satisfy typescript's need for types for everything 2. Provide jsdoc .js files, and manual .d.ts files ## Examples - https://github.com/bevry/typechecker/tree/dev-typescript-dts - https://github.com/bevry/eachr/tree/dev-typescript-dts ## Checklist My suggestion meets these guidelines: * [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [ ] This wouldn't change the runtime behavior of existing JavaScript code * [ ] This could be implemented without emitting different JS based on the types of the expressions * [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals). I haven't filled out this checklist as I do not know enough about typescript's inner workings to be able to fill it out.
Suggestion,Awaiting More Feedback
low
Critical
391,600,651
youtube-dl
iprima.cz ERROR: No video formats found
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2018.12.17*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2018.12.17** ### Before submitting an *issue* make sure you have: - [x] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones - [x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser ### What is the purpose of your *issue*? - [x] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows: Add the `-v` flag to **your command line** you run youtube-dl with (`youtube-dl -v <your command line>`), copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['-v', 'https://prima.iprima.cz/filmy/seznamka'] [debug] Encodings: locale cp1250, fs mbcs, out cp852, pref cp1250 [debug] youtube-dl version 2018.12.17 [debug] Python version 3.4.4 (CPython) - Windows-10-10.0.17763 [debug] exe versions: ffmpeg N-69406-ga73c411, ffprobe 3.3.2 [debug] Proxy map: {} [IPrima] seznamka: Downloading webpage [IPrima] p383852: Downloading player ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last): File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5g6wx9_e\build\youtube_dl\YoutubeDL.py", line 793, in extract_info File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5g6wx9_e\build\youtube_dl\extractor\common.py", line 508, in extract File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5g6wx9_e\build\youtube_dl\extractor\iprima.py", line 124, in _real_extract File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp5g6wx9_e\build\youtube_dl\extractor\common.py", line 1292, in _sort_formats youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. ``` --- ### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://prima.iprima.cz/filmy/seznamka - Single video: https://max.iprima.cz/filmy/pohadky-pro-emu Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights. --- ### Description of your *issue*, suggested solution and other information No video formats found. Videos are playable in web browser. test account Username: [email protected] Password: bugmenot
geo-restricted
low
Critical
391,601,838
create-react-app
Put TypeScript configuration in react-scripts instead of individual project? (TS3.2+)
### Is this a bug report? No ### Motivation [TypeScript 3.2](https://blogs.msdn.microsoft.com/typescript/2018/11/29/announcing-typescript-3-2/#configuration-inheritance-via-node_modules-packages), released November 29th, 2018, now uses [Node.js-based resolution for tsconfig.json inheritance](https://blogs.msdn.microsoft.com/typescript/2018/11/29/announcing-typescript-3-2/#configuration-inheritance-via-node_modules-packages) > TypeScript 3.2 now resolves `tsconfig.jsons` from `node_modules`. When using a bare path for the `"extends"` field in `tsconfig.json`, TypeScript will dive into `node_modules` packages for us. > > ```js > { > "extends": "@my-team/tsconfig-base", > "include": ["./**/*"] > "compilerOptions": { > // Override certain options on a project-by-project basis. > "strictBindCallApply": false, > } > } > ``` TypeScript will look for `"tsconfig"` field in `package.json` to determine the configuration file to use. Therefore, the generated `tsconfig.json` could be reduced to ```js { "extends": "react-scripts", "include": ["src"] } ``` This would further reduce configuration in create-react-app projects.
issue: proposal
low
Critical
391,604,021
flutter
FEATURE REQUEST: NetworkImage should accept different protocols
NetworkImage uses HTTP and accepts a **url String**, what if I want to use another protocol like gRPC? Should I rewrite the class? (BAD)
c: new feature,framework,P3,team-framework,triaged-framework
low
Minor
391,624,367
TypeScript
Improve structure, formatting, (human) parsability and readabiliy of errors
## Suggestion Comparing my DX/UX experience from working with flow versus TypeScript, the error messages is one of the few things that I preferred how flow does it. Especially after flow v0.66 release. I believe they integrated alot from the [glow](https://github.com/jamiebuilds/glow) project. I would love it if typescript would adopt some for the formatting and helpful information that flow has in their error messages. This blog post explains more about the flow 0.66 error message changes: http://medium.com/flow-type/better-flow-error-messages-for-the-javascript-ecosystem-73b6da948ae2 Here are a couple of things I can think of that would help me find the actual problem/conflict that I can take action on: - prettifying/formatting the outputted types - syntax highlighting - bold/highlight the conflicting parts ## Use Cases Every time typescript finds an error (which us developers will have to read and understand and take action on :) ). I am talking both on the command line but also in IDEs like vscode. There is an issue related to this in the vscode repo here: https://github.com/Microsoft/vscode/issues/54503 ## Examples Heres and example of the ginormous unstructured blob of text that is a ts error with big types involved: ```Type '({ expandedRowIds, orderBy, currentPage, filters: { columns: columnFilters, period, categoryIds }, ...restUrlQueryState }: Pick<Overwrite<DataGridUrlQueryStateUrlSerialized, { filters: { columns: { promotionName?: string | undefined; startDate?: string | undefined; endDate?: string | undefined; "sumFacts.switching.amount"?: string | undefined; "sumFacts.netLift.profit"?: string | undefined; "sumFacts.netLift.amount"?: string | undefined; }; period: Date[]; categoryIds: string[]; }; }>, "hiddenColumnNames" | "filters" | "orderBy" | "expandedRowIds" | "currentPage">, pageSize: any) => Dictionary<any>' is not assignable to type '(a: Overwrite<DataGridUrlQueryStateUrlSerialized, { filters: { columns: { promotionName?: string | undefined; startDate?: string | undefined; endDate?: string | undefined; "sumFacts.switching.amount"?: string | undefined; "sumFacts.netLift.profit"?: string | undefined; "sumFacts.netLift.amount"?: string | undefined; }; period: Date[]; categoryIds: string[]; }; }>) => DataGridQueryVariables'.``` ## Checklist My suggestion meets these guidelines: * [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [ ] This wouldn't change the runtime behavior of existing JavaScript code * [ ] This could be implemented without emitting different JS based on the types of the expressions * [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Committed,Domain: Error Messages
medium
Critical
391,675,290
pytorch
Momentum problem (1-momentum is correct?) in BatchNorm2d
## 🐛 Bug In BatchNorm2d' doc, the explanation of momentum is: `\hat{x}_\text{new} = (1 - \text{momentum}) \times \hat{x} + \text{momemtum} \times x_t$` where `x_t` is the newly computed batch statistics, `\hat{x}` is the estimated statistics in history. While in my experiments, when momentum set to 0, the batchnorm operates just use the newly computed statistics. So I guess maybe the following explanation is correct: `\hat{x}_\text{new} = \text{momemtum\times \hat{x} + (1 - \text{momentum}) \times x_t$` ## To Reproduce `b_x` is a torch.Tensor with shape (8, 3, 299, 299), which read from an image `mol` is the model load from `Inception V3` I have set the momentum as 0 in [Inception v3 model struct](https://github.com/pytorch/vision/blob/master/torchvision/models/inception.py): ```python class BasicConv2d(nn.Module): def __init__(self, in_channels, out_channels, **kwargs): super(BasicConv2d, self).__init__() self.conv = nn.Conv2d(in_channels, out_channels, bias=False, **kwargs) self.bn = nn.BatchNorm2d(out_channels, eps=0.001, momentum=0) def forward(self, x): x = self.conv(x) x = self.bn(x) return F.relu(x, inplace=True) ``` Then I calculate the mean and var: ``` python conv = mol.Conv2d_1a_3x3.conv(b_x) dim = conv.shape m = (conv.sum(0).sum(1).sum(1)/(dim[0]*dim[2]*dim[3])).view(1, -1, 1, 1) var = (((conv-m)**2).sum(0).sum(1).sum(1)/(dim[0]*dim[2]*dim[3]-1)).view(1, -1, 1, 1) + 0.001 tmp = (conv - m) / torch.sqrt(var) tmp = tmp * mol.Conv2d_1a_3x3.bn.weight.view(1, -1, 1, 1) + mol.Conv2d_1a_3x3.bn.bias.view(1, -1, 1, 1) bn = mol.Conv2d_1a_3x3.bn(conv) print((bn-tmp).mean(), (bn-tmp).std()) ``` The result is that `bn=tmp` while `momentum = 0` ## Expected behavior Expected `bn=tmp` while `momentum = 1` ## Environment - PyTorch Version 0.4.1: - Windows: - pip: - Python version: 3.6.5 cc @brianjo @mruberry @albanD @jbschlosser
todo,module: docs,module: nn,triaged
low
Critical
391,676,703
opencv
Add support for cv.imwrite for opencvJS.
opencvJS running on a browser does not have support for [imwrite](https://docs.opencv.org/master/d4/da8/group__imgcodecs.html#gabbc7ef1aa2edfaa87772f1202d67e0ce). We should consider implementing using the upcoming [W3C writable files](https://github.com/WICG/writable-files), when the proposal matures and there is support from browser vendors. 32-bit float (CV_32F) images can be saved in PFM, TIFF, OpenEXR, and Radiance HDR formats. These HDR/high quality images cannot be displayed on the screen using cv.imshow(canvas, mat) because of [canvas's limitation of using only cv.CV_8UC4](https://docs.opencv.org/master/df/d24/tutorial_js_image_display.html). So it is important to save the images and then display using `<img>` element.
category: javascript (js)
low
Minor
391,689,516
TypeScript
Adding generic parameter to a lambda function removes typing from the function argument
**TypeScript Version:** 3.2.2 **Search Terms:** generic removes parameter type **Code** ```ts // OKAY // declare const labmda function with typings, then implement with minimal type annotations. // "input" has type of "string". export const foo: (input: string) => string = (input) => (input); // OKAY // declare const lambda generic function without typings, then implement with full inline type annotations. // "input" has type of "string". export const bar = <TResult>(input: string) => ({ } as Partial<TResult>); // ERROR // declare const labmda generic function with typings, then implement with minimal type annotations. // "input" has type of "any". export const baz: <TResult>(input: string) => Partial<TResult> = <TResult>(input) => ({ [input]: input } as Partial<TResult>); ``` **Expected behavior:** `input` is typed as `string`. **Actual behavior:** `input` is typed as `any`. **Playground Link:** https://www.typescriptlang.org/play/index.html#src=%2F%2F%20OKAY%0D%0A%2F%2F%20declare%20const%20labmda%20function%20with%20typings%2C%20then%20implement%20with%20minimal%20type%20annotations.%0D%0A%2F%2F%20%22input%22%20has%20type%20of%20%22string%22.%0D%0Aexport%20const%20foo%3A%20(input%3A%20string)%20%3D%3E%20string%0D%0A%20%20%20%20%3D%20(input)%20%3D%3E%20(input)%3B%0D%0A%0D%0A%2F%2F%20OKAY%0D%0A%2F%2F%20declare%20const%20lambda%20generic%20function%20without%20typings%2C%20then%20implement%20with%20full%20inline%20type%20annotations.%0D%0A%2F%2F%20%22input%22%20has%20type%20of%20%22string%22.%0D%0Aexport%20const%20bar%0D%0A%20%20%20%20%3D%20%3CTResult%3E(input%3A%20string)%20%3D%3E%20(%7B%20%7D%20as%20Partial%3CTResult%3E)%3B%0D%0A%0D%0A%2F%2F%20ERROR%0D%0A%2F%2F%20declare%20const%20labmda%20generic%20function%20with%20typings%2C%20then%20implement%20with%20minimal%20type%20annotations.%0D%0A%2F%2F%20%22input%22%20has%20type%20of%20%22any%22.%0D%0Aexport%20const%20baz%3A%20%3CTResult%3E(input%3A%20string)%20%3D%3E%20Partial%3CTResult%3E%0D%0A%20%20%20%20%3D%20%3CTResult%3E(input)%20%3D%3E%20(%7B%20%5Binput%5D%3A%20input%20%7D%20as%20Partial%3CTResult%3E)%3B _(NOTE: options -> `noImplicitAny` to have the issue highlighted as an error.)_ **Related Issues:** https://github.com/Microsoft/TypeScript/issues/18606 I think this issue might be related, but I don't understand it enough to judge. If this is the same issue then the answer is "this is correct, and a limitation of the type system", which is fair enough.
Bug,Domain: Contextual Types
low
Critical
391,706,687
vue-element-admin
Can git-flow be implemented?
It would be good to implement the git-flow to develop in a more organized and standardized way, you could say that it is the standard way of working in the git world.
enhancement :star:
low
Minor
391,792,187
kubernetes
Lock down allowed upgrade protocols in apiserver proxy to spdy and websockets
From [CVE-2018-1002105](https://github.com/kubernetes/kubernetes/issues/71411) [post-mortem](https://docs.google.com/document/d/1tGpqEM56cSBPfl-qxIs_CGdlABMZXEKEDhCI7eOwGT0/edit#) /assign /area security /area apiserver /priority important-longterm /kind cleanup /sig api-machinery
priority/important-soon,area/security,kind/cleanup,area/apiserver,sig/api-machinery,lifecycle/frozen
low
Minor
391,792,504
kubernetes
Aggregator: prevent upgrade on known paths that do not serve upgrade requests (like discovery, healthz, etc)
From [CVE-2018-1002105](https://github.com/kubernetes/kubernetes/issues/71411) [post-mortem](https://docs.google.com/document/d/1tGpqEM56cSBPfl-qxIs_CGdlABMZXEKEDhCI7eOwGT0/edit#) /area security /area apiserver /priority important-longterm /kind cleanup /sig api-machinery
area/security,kind/cleanup,area/apiserver,sig/api-machinery,priority/important-longterm,lifecycle/frozen
low
Minor
391,813,917
kubernetes
Investigate adding per-request binding or assertions to apiserver proxy
Investigate adding per-request binding or assertions that would let backends verify a particular request was intentionally forwarded from the apiserver proxy From [CVE-2018-1002105](https://github.com/kubernetes/kubernetes/issues/71411) [post-mortem](https://docs.google.com/document/d/1tGpqEM56cSBPfl-qxIs_CGdlABMZXEKEDhCI7eOwGT0/edit#) /area security /area apiserver /priority important-longterm /kind cleanup /sig api-machinery
area/security,area/apiserver,sig/api-machinery,kind/feature,priority/important-longterm,lifecycle/frozen
low
Minor
391,815,448
TypeScript
Distinguish between plain object types and class types
## Search Terms - plain object class type ## Suggestion Some way to distinguish an object type that only has `Object` in its prototype chain. ## Use Cases In [this library](https://github.com/mweststrate/immer), we use mapped types to convert immutable objects/arrays into their mutable representation. We _never_ do this for class instances, so I need a way to skip the mapped type when an object type is actually a class type (in order to preserve readonly properties on class instances). ## Examples I have no suggestions for such syntax. ## Checklist My suggestion meets these guidelines: * [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals). ## Related https://stackoverflow.com/questions/53819550/distinguish-between-plain-objects-and-class-types#53819550
Suggestion,Needs Proposal
medium
Critical
391,826,358
vue
Impossible to preserve directive dom changes when the dom element is shared by multiple vnodes.
### Version 2.5.17 ### Reproduction link [https://codesandbox.io/s/8y0yqono38](https://codesandbox.io/s/8y0yqono38) ### Steps to reproduce Create a wrapper component that has another custom component as its root node. Put a directive on the wrapper component that adds a class to the element. Do anything that updates the child's class. The classes assigned in the directive of the parent vnode will be wiped out, and the directive has no way of knowing it. I _think_ this is because the vnodes were merged into the same element. So, the child vnode gets patched, causing the class update and the dom change to the same element that the parent vnode is using, but, because no actual patch happened to the parent vnode, the parent directive never has a chance to readd it's class. I think this probably _technically_ correct behavior, but it still presents (in my opinion) an issue with directive functionality. Which is that my host dom element can be mutated by a different vnode and I'm not aware of it. ### What is expected? The `update` trigger runs when my host element is mutated. ### What is actually happening? The class the directive adds is overwritten and my directive has no chance to readd the class. <!-- generated by vue-issues. DO NOT REMOVE -->
improvement
medium
Minor
391,837,797
go
strconv: ParseBool errors are verbose
Failure to parse a boolean flag results in this error: https://play.golang.org/p/cBBLtiFyWhY: ```invalid boolean value "garbage" for -b: strconv.ParseBool: parsing "garbage": invalid syntax``` Room for improvement: - display the offending value only once - don't mention strconv.ParseBool, as it is an internal detail. - state what values are allowed, perhaps? The other strconv.Parse* functions are similarly verbose. I've gotten into the habit of throwing away their errors and writing my own. e.g. "invalid int: %q".
NeedsDecision
low
Critical
391,839,342
flutter
Attempting to install a non-code-signed iOS app should provide a meaningful error
``` flutter build ios --no-codesign flutter install -v ``` Will produce a lot of logs that end with: ``` Install failed #0 throwToolExit (package:flutter_tools/src/base/common.dart:26:3) #1 InstallCommand.runCommand (package:flutter_tools/src/commands/install.dart:44:7) <asynchronous suspension> #2 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:401:18) #3 _asyncThenWrapperHelper.<anonymous closure> (dart:async/runtime/libasync_patch.dart:77:64) #4 _rootRunUnary (dart:async/zone.dart:1132:38) #5 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #6 _FutureListener.handleValue (dart:async/future_impl.dart:129:18) #7 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:642:45) #8 Future._propagateToListeners (dart:async/future_impl.dart:671:32) #9 Future._complete (dart:async/future_impl.dart:476:7) #10 _SyncCompleter.complete (dart:async/future_impl.dart:51:12) #11 _AsyncAwaitCompleter.complete.<anonymous closure> (dart:async/runtime/libasync_patch.dart:33:20) #12 _rootRun (dart:async/zone.dart:1124:13) #13 _CustomZone.run (dart:async/zone.dart:1021:19) #14 _CustomZone.bindCallback.<anonymous closure> (dart:async/zone.dart:947:23) #15 _microtaskLoop (dart:async/schedule_microtask.dart:41:21) #16 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) #17 _runPendingImmediateCallback (dart:isolate/runtime/libisolate_patch.dart:115:13) #18 _RawReceivePortImpl._handleMessage (dart:isolate/runtime/libisolate_patch.dart:172:5) ``` It would be very nice if attempting to install a non-code-signed app would produce a meaningful error along the lines of "cannot install a non-code-signed app." I know this is a silly mistake, but it could be very useful for novices to provide a little bit of info here. --------- ``` ❯ flutter doctor -v [✓] Flutter (Channel beta, v1.0.0, on Mac OS X 10.14.2 18C54, locale en-US) • Flutter version 1.0.0 at /Users/maxlapides/flutter • Framework revision 5391447fae (3 weeks ago), 2018-11-29 19:41:26 -0800 • Engine revision 7375a0f414 • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297) [✓] Android toolchain - develop for Android devices (Android SDK 27.0.3) • Android SDK at /Users/maxlapides/Library/Android/sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-27, build-tools 27.0.3 • ANDROID_HOME = /Users/maxlapides/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06) • All Android licenses accepted. [✓] iOS toolchain - develop for iOS devices (Xcode 10.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 10.1, Build version 10B61 • ios-deploy 1.9.4 • CocoaPods version 1.6.0.beta.1 [✓] Android Studio (version 3.2) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 29.1.1 • Dart plugin version 181.5656 • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06) [✓] VS Code (version 1.30.0) • VS Code at /Applications/Visual Studio Code.app/Contents • Flutter extension version 2.21.1 [✓] Connected device (3 available) • SAMSUNG SM G920A • 03157df3c5558209 • android-arm64 • Android 5.1.1 (API 22) • Max's iPhone • 65760f04a8cdf8dc55bf798b8cf0ab5cf488674c • ios • iOS 12.1 • iPhone XS • 9CFC4B23-BE03-4DC9-B1CD-5E1226F5A183 • ios • iOS 12.1 (simulator) ```
platform-ios,tool,a: quality,P3,team-ios,triaged-ios
low
Critical
391,841,225
pytorch
CMake Error at CMakeLists.txt:10 (find_package) in C++
## 🐛 Bug <!-- A clear and concise description of what the bug is. --> ## To Reproduce Steps to reproduce the behavior: 1. Go to the eclipse-workspace and run `cmake -G "Eclipse CDT4 - Unix Makefiles" ./` to create a Eclipse project. ## Expected behavior It should create a CMake project with Eclipse. ## Environment I am just running a simple code, #include <torch/torch.h> #include <iostream> ``` int main() { torch::Tensor tensor = torch::rand({2, 3}); std::cout << tensor << std::endl; } ``` - PyTorch Version (e.g., 1.0): C++ torch, stable version - OS (e.g., Linux): Ubuntu 18 - How you installed PyTorch (`conda`, `pip`, source): NA - Build command you used (if compiling from source): NA - Python version: NA - CUDA/cuDNN version: None - GPU models and configuration: None - Any other relevant information: NA ## Additional context I have the `CMakeLists.txt` file which includes: ``` cmake_minimum_required(VERSION 3.0 FATAL_ERROR) project(test) set(Torch_DIR "/home/afshin/libtorch/share;${Torch_DIR}") find_package(Torch REQUIRED) add_executable(test test.cpp) target_link_libraries(test "${TORCH_LIBRARIES}") set_property(TARGET test PROPERTY CXX_STANDARD 11) ``` I get the following log and error: ``` -- The C compiler identification is GNU 7.3.0 -- The CXX compiler identification is GNU 7.3.0 -- Could not determine Eclipse version, assuming at least 3.6 (Helios). Adjust CMAKE_ECLIPSE_VERSION if this is wrong. -- Check for working C compiler: /usr/bin/cc -- Check for working C compiler: /usr/bin/cc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Check for working CXX compiler: /usr/bin/c++ -- Check for working CXX compiler: /usr/bin/c++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done CMake Error at CMakeLists.txt:6 (find_package): By not providing "FindTorch.cmake" in CMAKE_MODULE_PATH this project has asked CMake to find a package configuration file provided by "Torch", but CMake did not find one. Could not find a package configuration file provided by "Torch" with any of the following names: TorchConfig.cmake torch-config.cmake Add the installation prefix of "Torch" to CMAKE_PREFIX_PATH or set "Torch_DIR" to a directory containing one of the above files. If "Torch" provides a separate development package or SDK, be sure it has been installed. -- Configuring incomplete, errors occurred! See also "/home/afshin/eclipse-workspace/test_cmake/CMakeFiles/CMakeOutput.log". ``` I also searched for `CMakeLists.txt` using locate command, but I could not find anything. Apparently, it also cannot find `TorchConfig.cmake` and torch-config.cmake files. I added the corresponding path into the CMakeLists.txt file by: `set(Torch_DIR "/home/afshin/libtorch/share;${Torch_DIR}") ` but, no success. I guess `TorchConfig.cmake` should have be created in the compile time which is not. I appreciate any help. Thsank, Afshin cc @malfet @seemethere @walterddr
module: build,triaged
low
Critical
391,863,866
rust
Tracking issue: --persist-doctests flag for rustdoc
First implemented in https://github.com/rust-lang/rust/pull/56189, this flag allows users to save the compiled binaries created when rustdoc runs documentation tests. Pending work: - [x] Land https://github.com/rust-lang/rust/pull/56189 - [ ] Change the folder naming scheme? i.e. https://github.com/rust-lang/rust/pull/56189#issuecomment-445865048 - [ ] Related option to also save the processed code, for debugging purposes? - [ ] Ability to cross-compile doctests and either save the binaries or run them through some test runner - [ ] Combining the binaries into a singular test runner, like how libtest saves a single binary that runs unit tests
T-rustdoc,B-unstable,C-tracking-issue,A-doctests
low
Critical
391,877,195
godot
get_tree().root can't be edited
**Godot version:** cf07169 **OS/device including version:** Ubuntu/Any **Issue description:** Trying to change properties of the scene's root with `get_tree().root` will result in a crash. Following error is outputted: "Invalid set index 'root' (on base: 'SceneTree') with value of type 'Viewport'." Editing the root is still possible when referring to it with `$"/root/"` instead. In my opinion both ways of writing should be interchangeable.
bug,topic:gdscript,confirmed
low
Critical
391,878,743
pytorch
libtorch without cmake
## 🐛 Bug I have run the example-app (https://pytorch.org/cppdocs/installing.html) using libtorch and cmake. Now I am going to run it only using an IDE such as Eclipse. I have tried it; however, using <torch/torch.h> there’s a whole bunch of include files that g++ can’t find. So could you please itemize the necessary steps to run libtorch not using cmake? (As it is mentioned in the above link "CMake is not a hard requirement for using LibTorch")
module: build,module: cpp,triaged
low
Critical
391,885,820
flutter
IconButton tooltip is incorrectly aligned on Android, compared to native implementation
On Android, holding down on a button in the AppBar/Toolbar/etc gives a tooltip. This tooltip is wrongly aligned in Flutter, see the Gmail app left, and a Flutter demo app right. <img src="https://user-images.githubusercontent.com/5138348/50114609-3a8f9c80-0245-11e9-8c97-4f971c66a77a.jpg" height="400" /> <img src="https://user-images.githubusercontent.com/5138348/50114611-3a8f9c80-0245-11e9-8f59-7f2334bcda53.jpg" height="400" /> The flutter app can be created using the following code: ```dart import 'package:flutter/material.dart'; void main() => runApp(MyApp()); class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return MaterialApp( title: "Flutter Demo", theme: ThemeData( primarySwatch: Colors.blue, ), home: MyHomePage(), ); } } class MyHomePage extends StatelessWidget { @override Widget build(BuildContext context) { return Scaffold( appBar: AppBar( leading: IconButton( icon: new Icon( Icons.arrow_back, ), onPressed: () {}, tooltip: "Back", ), title: Text("Flutter Demo"), ), body: new Container(), ); } } ``` Flutter doctor: ``` [√] Flutter (Channel beta, v1.0.0, on Microsoft Windows [Version 10.0.17134.471], locale en-GB) • Flutter version 1.0.0 at D:\Dev\Flutter\flutter • Framework revision 5391447fae (3 weeks ago), 2018-11-29 19:41:26 -0800 • Engine revision 7375a0f414 • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297) [√] Android toolchain - develop for Android devices (Android SDK 28.0.3) • Android SDK at D:/Dev/Android • Android NDK location not configured (optional; useful for native profiling support) • Platform android-28, build-tools 28.0.3 • Java binary at: C:\Program Files\Java\jdk1.8.0_45\bin\java • Java version Java(TM) SE Runtime Environment (build 1.8.0_45-b15) • All Android licenses accepted. [√] Android Studio (version 3.1) • Android Studio at D:\Dev\Android Studio • Flutter plugin version 28.0.1 • Dart plugin version 173.4700 • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1024-b02) [!] Android Studio • Android Studio at D:/Dev/Android\ X Flutter plugin not installed; this adds Flutter specific functionality. X Dart plugin not installed; this adds Dart specific functionality. X android-studio-dir = D:/Dev/Android\ X Unable to find bundled Java version. • Try updating or re-installing Android Studio. • Consider removing your android-studio-dir setting by running: flutter config --android-studio-dir= [!] IntelliJ IDEA Ultimate Edition (version 2018.1) • IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA 2018.1.4 X Flutter plugin not installed; this adds Flutter specific functionality. X Dart plugin not installed; this adds Dart specific functionality. • For information about installing plugins, see https://flutter.io/intellij-setup/#installing-the-plugins [√] VS Code, 64-bit edition (version 1.29.1) • VS Code at C:\Program Files\Microsoft VS Code • Flutter extension version 2.21.1 [√] Connected device (1 available) • SM G930F • ce091609f588b10d04 • android-arm64 • Android 8.0.0 (API 26) ! Doctor found issues in 2 categories. ```
platform-android,framework,f: material design,a: accessibility,a: fidelity,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-android,triaged-android
low
Major
391,887,468
go
encoding/json: omitempty for arrays is confusing
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.11.2 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Yes. ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary></details> ```bash $ go env GOARCH="amd64" GOOS="darwin" ``` ### What did you do? https://play.golang.org/p/NlRBFTZHFYd ```go func main() { type Foo struct { ID [16]byte `json:",omitempty"` } var f Foo j, _ := json.Marshal(f) fmt.Println(string(j)) } ``` ### What did you expect to see? ```json {} ``` ### What did you see instead? ```json {"ID":[0,0,0,0,0,0,0,0,0,0,0,0,0,0,0,0]} ``` This is caused by `isEmptyValue` inside `encoding/json` checking to see if the length of the array is 0. For people actually using an array (and not a slice), it is unlikely that they would ever use an array of zero length. It is likely, however, that they might want to omit the result if all of the values in the array are empty. For example, if a user is using `[16]byte` to represent a UUID, they might want to omit encoding it if it is all zeroes. This was brought up in #11939, specifically [this comment](https://github.com/golang/go/issues/11939#issuecomment-429184373). It would be nice if we could do this generically for arrays with values we can determine are empty.
Documentation,NeedsInvestigation
medium
Major
391,910,805
pytorch
AttributeError: module 'caffe2.python._import_c_extension' has no attribute 'get_cudnn_version' when Caffe2 is not built with CuDNN
Steps to reproduce: 1. Build caffe2 without CuDNN (e.g., have CUDA but don't install CuDNN) 2. Run `python caffe2/python/data_parallel_model_test.py DataParallelModelTest.test_equiv` Expected: It should work, or maybe it gives me an error/skip saying I can't run this test without CuDNN Actual: ``` python caffe2/python/data_parallel_model_test.py DataParallelModelTest.test_equiv Traceback (most recent call last): File "caffe2/python/data_parallel_model_test.py", line 18, in <module> from caffe2.python import brew, core, cnn, data_parallel_model, dyndep, \ File "/data/users/ezyang/pytorch-tmp/caffe2/python/brew.py", line 12, in <module> from caffe2.python.model_helper import ModelHelper File "/data/users/ezyang/pytorch-tmp/caffe2/python/model_helper.py", line 8, in <module> from caffe2.python import core, scope, workspace, helpers File "/data/users/ezyang/pytorch-tmp/caffe2/python/core.py", line 15, in <module> from caffe2.python import scope, utils, workspace File "/data/users/ezyang/pytorch-tmp/caffe2/python/workspace.py", line 53, in <module> GetCuDNNVersion = C.get_cudnn_version AttributeError: module 'caffe2.python._import_c_extension' has no attribute 'get_cudnn_version' ``` Note to people with this problem: You can fix the problem by making sure Caffe2 is built with CuDNN.
caffe2
low
Critical
391,915,749
flutter
iOS should provide a way to enable the semantic tree for testing frameworks
Currently, on a physical iOS device, the engine only builds the semantics tree if: ``` bool enabled = UIAccessibilityIsVoiceOverRunning() || UIAccessibilityIsSwitchControlRunning(); ``` This is a problem for testing frameworks that want to find elements by semantic label, e.g. the following EarlGrey code works on a Simulator but not on a physical device: ``` [[EarlGrey selectElementWithMatcher:grey_accessibilityLabel(@"POP")] performAction:grey_tap()]; ``` in the ios_add2app tests. One (bad) solution for this would be to check if the `EarlGreyImpl` class is defined and enable semantics in that case - but what about other test frameworks, etc. We should provide some way for test users to force the semantics to be enabled, perhaps by one of the following. /cc @cbracken @chinmaygarde @xster @jamesderlin
a: tests,platform-ios,engine,a: accessibility,a: existing-apps,P2,team-ios,triaged-ios
low
Major
391,967,195
rust
Uses of GlobalAlloc::realloc yield useless code in lto+opt-level=2 builds
I noticed this in Firefox (where we do build with `-C lto -C opt-level=2`). Essentially any use of an API that ends up calling __rust_realloc generates useless code. A small testcase is: ```rust #[no_mangle] pub extern "C" fn qux(v: &mut Vec<usize>) { v.push(42); } ``` which, with the following `Cargo.toml` config: ``` [profile.release] lto = true opt-level = 2 panic = "abort" codegen-units = 1 rpath = false [lib] crate-type = ["cdylib"] ``` generates the following assembly: ```asm 0000000000003200 <qux>: 3200: 55 push %rbp 3201: 41 57 push %r15 3203: 41 56 push %r14 3205: 41 55 push %r13 3207: 41 54 push %r12 3209: 53 push %rbx 320a: 50 push %rax 320b: 49 89 fd mov %rdi,%r13 320e: 48 8b 4f 10 mov 0x10(%rdi),%rcx 3212: 48 3b 4f 08 cmp 0x8(%rdi),%rcx 3216: 75 55 jne 326d <qux+0x6d> 3218: 49 89 ce mov %rcx,%r14 321b: 49 83 c6 01 add $0x1,%r14 321f: 0f 82 e2 00 00 00 jb 3307 <qux+0x107> 3225: 48 8d 04 09 lea (%rcx,%rcx,1),%rax 3229: 49 39 c6 cmp %rax,%r14 322c: 4c 0f 42 f0 cmovb %rax,%r14 3230: ba 08 00 00 00 mov $0x8,%edx 3235: 45 31 ff xor %r15d,%r15d 3238: 4c 89 f0 mov %r14,%rax 323b: 48 f7 e2 mul %rdx 323e: 49 89 c4 mov %rax,%r12 3241: 0f 91 c0 setno %al 3244: 0f 80 bd 00 00 00 jo 3307 <qux+0x107> 324a: 41 88 c7 mov %al,%r15b 324d: 49 c1 e7 03 shl $0x3,%r15 3251: 48 85 c9 test %rcx,%rcx 3254: 74 1d je 3273 <qux+0x73> 3256: 49 8b 6d 00 mov 0x0(%r13),%rbp 325a: 4d 85 e4 test %r12,%r12 325d: 74 3f je 329e <qux+0x9e> 325f: 48 89 ef mov %rbp,%rdi 3262: 4c 89 e6 mov %r12,%rsi 3265: ff 15 35 2d 02 00 callq *0x22d35(%rip) # 25fa0 <realloc@GLIBC_2.2.5> 326b: eb 6a jmp 32d7 <qux+0xd7> 326d: 49 8b 5d 00 mov 0x0(%r13),%rbx 3271: eb 78 jmp 32eb <qux+0xeb> 3273: 4d 39 e7 cmp %r12,%r15 3276: 76 56 jbe 32ce <qux+0xce> 3278: 48 c7 04 24 00 00 00 movq $0x0,(%rsp) 327f: 00 3280: 48 89 e7 mov %rsp,%rdi 3283: 4c 89 fe mov %r15,%rsi 3286: 4c 89 e2 mov %r12,%rdx 3289: ff 15 39 2d 02 00 callq *0x22d39(%rip) # 25fc8 <posix_memalign@GLIBC_2.2.5> 328f: 85 c0 test %eax,%eax 3291: 75 7b jne 330e <qux+0x10e> 3293: 48 8b 1c 24 mov (%rsp),%rbx 3297: 48 85 db test %rbx,%rbx 329a: 75 43 jne 32df <qux+0xdf> 329c: eb 70 jmp 330e <qux+0x10e> 329e: 48 c7 04 24 00 00 00 movq $0x0,(%rsp) 32a5: 00 32a6: 48 89 e7 mov %rsp,%rdi 32a9: be 08 00 00 00 mov $0x8,%esi 32ae: 31 d2 xor %edx,%edx 32b0: ff 15 12 2d 02 00 callq *0x22d12(%rip) # 25fc8 <posix_memalign@GLIBC_2.2.5> 32b6: 85 c0 test %eax,%eax 32b8: 75 54 jne 330e <qux+0x10e> 32ba: 48 8b 1c 24 mov (%rsp),%rbx 32be: 48 85 db test %rbx,%rbx 32c1: 74 4b je 330e <qux+0x10e> 32c3: 48 89 ef mov %rbp,%rdi 32c6: ff 15 d4 2b 02 00 callq *0x22bd4(%rip) # 25ea0 <free@GLIBC_2.2.5> 32cc: eb 11 jmp 32df <qux+0xdf> 32ce: 4c 89 e7 mov %r12,%rdi 32d1: ff 15 a9 2c 02 00 callq *0x22ca9(%rip) # 25f80 <malloc@GLIBC_2.2.5> 32d7: 48 89 c3 mov %rax,%rbx 32da: 48 85 db test %rbx,%rbx 32dd: 74 2f je 330e <qux+0x10e> 32df: 49 89 5d 00 mov %rbx,0x0(%r13) 32e3: 4d 89 75 08 mov %r14,0x8(%r13) 32e7: 49 8b 4d 10 mov 0x10(%r13),%rcx 32eb: 48 c7 04 cb 2a 00 00 movq $0x2a,(%rbx,%rcx,8) 32f2: 00 32f3: 49 83 45 10 01 addq $0x1,0x10(%r13) 32f8: 48 83 c4 08 add $0x8,%rsp 32fc: 5b pop %rbx 32fd: 41 5c pop %r12 32ff: 41 5d pop %r13 3301: 41 5e pop %r14 3303: 41 5f pop %r15 3305: 5d pop %rbp 3306: c3 retq 3307: e8 84 9f 00 00 callq d290 <_ZN5alloc7raw_vec17capacity_overflow17h0432b49d9a8429deE> 330c: 0f 0b ud2 330e: 4c 89 e7 mov %r12,%rdi 3311: 4c 89 fe mov %r15,%rsi 3314: e8 87 9f 00 00 callq d2a0 <_ZN5alloc5alloc18handle_alloc_error17h612a63a56f8c2099E> 3319: 0f 0b ud2 331b: 0f 1f 44 00 00 nopl 0x0(%rax,%rax,1) ``` That's a lot of code, and the most notable in here is that there's a call to `realloc`, two calls to `posix_memalign`, one to `free` and one to `malloc`. Now, to understand what's going on, let's write our own copy of the `GlobalAlloc` implementation: ```rust use std::alloc::{GlobalAlloc, Layout}; use std::cmp; use std::ptr; use libc; #[no_mangle] pub extern "C" fn qux(v: &mut Vec<usize>) { v.push(42); } struct System; const MIN_ALIGN: usize = 16; unsafe impl GlobalAlloc for System { #[inline] unsafe fn alloc(&self, layout: Layout) -> *mut u8 { if layout.align() <= MIN_ALIGN && layout.align() <= layout.size() { libc::malloc(layout.size()) as *mut u8 } else { #[cfg(target_os = "macos")] { if layout.align() > (1 << 31) { return ptr::null_mut() } } aligned_malloc(&layout) } } #[inline] unsafe fn alloc_zeroed(&self, layout: Layout) -> *mut u8 { if layout.align() <= MIN_ALIGN && layout.align() <= layout.size() { libc::calloc(layout.size(), 1) as *mut u8 } else { let ptr = self.alloc(layout.clone()); if !ptr.is_null() { ptr::write_bytes(ptr, 0, layout.size()); } ptr } } #[inline] unsafe fn dealloc(&self, ptr: *mut u8, _layout: Layout) { libc::free(ptr as *mut libc::c_void) } #[inline] unsafe fn realloc(&self, ptr: *mut u8, layout: Layout, new_size: usize) -> *mut u8 { if layout.align() <= MIN_ALIGN && layout.align() <= new_size { libc::realloc(ptr as *mut libc::c_void, new_size) as *mut u8 } else { realloc_fallback(self, ptr, layout, new_size) } } } unsafe fn aligned_malloc(layout: &Layout) -> *mut u8 { let mut out = ptr::null_mut(); let ret = libc::posix_memalign(&mut out, layout.align(), layout.size()); if ret != 0 { ptr::null_mut() } else { out as *mut u8 } } unsafe fn realloc_fallback( alloc: &System, ptr: *mut u8, old_layout: Layout, new_size: usize, ) -> *mut u8 { // Docs for GlobalAlloc::realloc require this to be valid: let new_layout = Layout::from_size_align_unchecked(new_size, old_layout.align()); let new_ptr = GlobalAlloc::alloc(alloc, new_layout); if !new_ptr.is_null() { let size = cmp::min(old_layout.size(), new_size); ptr::copy_nonoverlapping(ptr, new_ptr, size); GlobalAlloc::dealloc(alloc, ptr, old_layout); } new_ptr } #[global_allocator] static HEAP: System = System; ``` (this compiles to the same assembly) What's going on here is that `layout.align()` is, in our inlined case, a constant for the alignment of `usize`, which is 8 on x86_64, so `layout.align() <= MIN_ALIGN` is always true. However, because the `new_size` given to `realloc` is not `NonZero` (despite the GlobalAlloc documentation specifying the value can never be 0), LLVM doesn't know that the condition `layout.align() <= new_size` is also always true, so it ends up creating code for both `libc::realloc` and `realloc_fallback` branches. Changing the condition in `realloc` to force `new_size == 0` to go through `libc::realloc` gets rid of the call to `free` and one call to `posix_memalign`. Sadly, doing the same with `layout.size() == 0` in `alloc` to call `libc::malloc` doesn't get right of the other `posix_memalign` call. I guess the compiler still thinks that the new size computed in `RawVec::reserve_internal` can be somewhere between `layout.align()` and `layout.size()`, which is actually not possible. Assuming we can somehow get the compiler to get rid of that useless `posix_memalign`, that still leaves us with, essentially, code doing `new_ptr = if ptr { libc::realloc(ptr, new_size) } else { libc::malloc(new_size) }`, which, considering the API guarantees of `libc::realloc`, is a branch and a function call too much, since `new_ptr = libc::realloc(ptr, new_size)` would work just as well, `libc::realloc(ptr::null_mut(), new_size)` being the same as `libc::malloc(new_size)`. Sadly, there's nothing in the Alloc API that would allow to fold this. Cc: @SimonSapin
I-slow,A-allocators,T-compiler,C-bug,I-heavy
low
Critical
392,051,857
godot
Moving anchors together with the object
**Godot version:** 11d7738 **Issue description:** The only way to have an object resize proportionally with the screen (same behaviour as % in CSS) is to move the anchors around and have always margin 0. The current workflow for this kind of task is clunky as there is no way to move the anchors together with the object in the 2D view. Related to #1276 **Proposal** I don't have a clear idea yet on how this feature should look like, as i foresee many problems for when people just want to move only the margins. I'd like to discuss here and see if there is a nice solution to this problem @groud @JFonS I'd like your opinion on this :)
enhancement,discussion,topic:editor,usability
low
Minor
392,092,994
go
x/build/cmd/buildlet: remaining processes not killed
When `buildlet` times out, some processes remain in background and they need to be killed manually. It seems that `buildlet` only kills its first children and not all its offsprings. It occurs on aix/ppc64 builder. But I think it's a more general issue. Here are some processes remaining after builds had failed on aix/ppc64. `cmd/buildlet` seems to only kill "go tool dist test ... " ``` root 15008262 1 0 14:43:03 - 0:00 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/pkg/tool/aix_ppc64/dist test --no-rebuild --banner=XXXBANNERXXX: test:1_10 root 7930506 15008262 0 14:43:06 - 0:01 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/test/runtest.exe --shard=1 --shards=10 root 15860332 7930506 0 14:43:15 - 0:00 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/bin/go run -gcflags= fixedbugs/issue4667.go root 16449854 15860332 117 14:43:16 - 244:33 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/pkg/tool/aix_ppc64/link -o /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/go-build817241358/b001/exe/issue4667 -importcfg /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/go-build817241358/b001/importcfg.link -s -w -buildmode=exe -buildid=0SI_pU16NxBjYDL8rkvo/L9t_iML1T1ahnSRDhIh8/1p0X_Ta401ybIH1jFEpb/0SI_pU16NxBjYDL8rkvo -extld=gcc /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/go-build817241358/b001/_pkg_.a root 4391522 1 0 03:47:21 - 0:00 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/pkg/tool/aix_ppc64/dist test --no-rebuild --banner=XXXBANNERXXX: test:3_10 root 10158466 4391522 0 03:47:24 - 0:01 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/test/runtest.exe --shard=3 --shards=10 root 10748370 10158466 356 03:47:34 - 1877:52 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/bin/go build -gcflags -S=2 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/test/codegen/memcombine.go root 12583384 1 0 14:07:27 - 0:00 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/pkg/tool/aix_ppc64/dist test --no-rebuild --banner=XXXBANNERXXX: test:2_10 root 20709728 12583384 0 14:07:29 - 0:01 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/test/runtest.exe --shard=2 --shards=10 root 14418236 20709728 0 14:07:35 - 0:00 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/bin/go tool compile -e /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/test/fixedbugs/bug151.go root 17760658 14418236 469 14:07:35 - 1051:28 /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/pkg/tool/aix_ppc64/compile -e /ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/test/fixedbugs/bug151.go ``` Looking at the code, `killProcessTree` is called when the builder is killed by the coordinator (right?). However, in my understanding, it only kills one process and not the whole process tree (cf https://github.com/golang/build/blob/master/cmd/buildlet/buildlet.go#L1590). I think it should call syscall.Kill with -p.Pid in order to kill the whole process group. Maybe it's a duplicate of #15778.
Builders
low
Critical
392,129,301
godot
Project settings hold editor infos
**Godot version:** 11d7738 **Issue description:** Seems like Godot is storing editor specific data inside the project settings. I believe this is a leftover of some sort before the editor had its own settings? ![image](https://user-images.githubusercontent.com/7917475/50152927-4458e480-02c5-11e9-8220-7842b7949b49.png) **Bonus:** Why is there a "Active" toggle that has as a tooltip "Internal Editor Setting,don't touch"? Should it be directly renamed to "DONT TOUCH THIS PLS" ?
discussion,topic:editor
low
Major
392,145,923
vue
Add an option to throw global errors, making it possible for debuggers to automatically break on error.
### What problem does this feature solve? Currently, the [globalHandleError](https://github.com/nialna/vue/blob/dev/src/core/util/error.js#L27) function will intercept all errors thrown in components and log them. It can also pass them to an external error handler, but that external error handler won't be able to throw it because the call to `config.errorHandler` is wrapped in a try catch. In vanilla JS, when an unhandled error happens in your code, the debugger can break immediately, giving you access to the stack and context. When using VueJS, we have no way of doing this because the errors are always handled by Vue. ### What does the proposed API look like? The simplest way I can think of is to add a new `config` option, for example: ```js Vue.config.throwUnhandledErrors = true; ``` Then in `globalHandleError`, we could check for that flag and throw errors: ```js function globalHandleError (err, vm, info) { if (config.throwUnhandledErrors) { throw(err); } else if (config.errorHandler) { try { return config.errorHandler.call(null, err, vm, info) } catch (e) { logError(e, null, 'config.errorHandler') } } logError(err, vm, info) } ``` <!-- generated by vue-issues. DO NOT REMOVE -->
feature request
medium
Critical
392,160,218
rust
A type inference problem with struct fields and collect method
Hi, I found a type inference problem like below. You can check it in Rust Playground from link. If it's possible, i would like to write code with less type annotation. https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=da38ac68e6aba30ab33c0ddc42ecdd3b ``` #![allow(unused)] struct Foo { vector: Vec<i32>, } fn main() { let v1 = vec![1, 2, 3, 4]; let v2 = v1.into_iter().map(|num| num + 1).collect(); // enabling below code will require type annotation of v2 in above line. // println!("v2 len: {}", v2.len()); let _foo = Foo { vector: v2, // I thick compiler can determine type of v2 here. }; } ```
A-inference
low
Critical
392,162,534
pytorch
[JIT] Batch op. batch_sum return a mask which is on cpu
## 🐛 Bug <!-- A clear and concise description of what the bug is. --> ## To Reproduce Steps to reproduce the behavior: 1. Create a computation graph with a sum operation and another operation which is on gpu. ``` TensorIterator expected type CUDAByteType but got CPUByteType (check_type_conversions at ../aten/src/ATen/native/TensorIterator.cpp:547) frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0x6a (0x7f860917d8fa in /usr/local/lib/python3.5/dist-packages/torch/lib/libc10.so) frame #1: at::TensorIterator::check_type_conversions() + 0x24d (0x7f8668082b2d in /usr/local/lib/python3.5/dist-packages/torch/lib/libcaffe2.so) frame #2: at::TensorIterator::Builder::build() + 0x2ef (0x7f8668087d3f in /usr/local/lib/python3.5/dist-packages/torch/lib/libcaffe2.so) frame #3: at::TensorIterator::binary_op(at::Tensor&, at::Tensor const&, at::Tensor const&) + 0x309 (0x7f8668089589 in /usr/local/lib/python3.5/dist-packages/torch/lib/libcaffe2.so) frame #4: at::native::mul_out(at::Tensor&, at::Tensor const&, at::Tensor const&) + 0x95 (0x7f8667f284e5 in /usr/local/lib/python3.5/dist-packages/torch/lib/libcaffe2.so) frame #5: at::native::mul(at::Tensor const&, at::Tensor const&) + 0x43 (0x7f8667f29553 in /usr/local/lib/python3.5/dist-packages/torch/lib/libcaffe2.so) frame #6: at::TypeDefault::mul(at::Tensor const&, at::Tensor const&) const + 0x4d (0x7f86682a601d in /usr/local/lib/python3.5/dist-packages/torch/lib/libcaffe2.so) frame #7: torch::autograd::VariableType::mul(at::Tensor const&, at::Tensor const&) const + 0x302 (0x7f8609808842 in /usr/local/lib/python3.5/dist-packages/torch/lib/libtorch.so.1) frame #8: <unknown function> + 0x54df7b (0x7f86098d3f7b in /usr/local/lib/python3.5/dist-packages/torch/lib/libtorch.so.1) frame #9: <unknown function> + 0x5c0e43 (0x7f8609946e43 in /usr/local/lib/python3.5/dist-packages/torch/lib/libtorch.so.1) frame #10: torch::jit::InterpreterState::run(std::vector<c10::IValue, std::allocator<c10::IValue> >&) + 0x31 (0x7f8609942651 in /usr/local/lib/python3.5/dist-packages/torch/lib/libtorch.so.1) frame #11: torch::jit::GraphExecutor::run(std::vector<c10::IValue, std::allocator<c10::IValue> >&) + 0x1c4 (0x7f8609924a74 in /usr/local/lib/python3.5/dist-packages/torch/lib/libtorch.so.1) frame #12: ./MainRandomizeRnnDistance() [0x47fd12] frame #13: ./MainRandomizeRnnDistance() [0x45da0d] frame #14: __libc_start_main + 0xf0 (0x7f85ffef3830 in /lib/x86_64-linux-gnu/libc.so.6) frame #15: ./MainRandomizeRnnDistance() [0x459fe9] ``` ## Expected behavior Having no problem. ## Environment Collecting environment information... PyTorch version: 1.0.0a0+5510196 Is debug build: No CUDA used to build PyTorch: 9.0.176 OS: Ubuntu 16.04.5 LTS GCC version: (GCC) 8.2.0 CMake version: version 3.12.0 Python version: 3.5 Is CUDA available: Yes CUDA runtime version: 9.0.176 GPU models and configuration: GPU 0: GeForce GTX 1070 Nvidia driver version: 410.78 cuDNN version: Probably one of the following: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.3.1 /usr/lib/x86_64-linux-gnu/libcudnn_static_v7.a Versions of relevant libraries: [pip] Could not collect [conda] Could not collect ## Additional context I think this can be solved by the following change ``` @torch.jit.script def batch_sum(data, mask, dims): data = data * mask.type_as(data) for _ in range(dims.size(0)): data = data.sum(1) mask = torch.ones([data.size(0)], dtype=torch.uint8).type_as(mask) #mask = torch.ones([data.size(0)], dtype=torch.uint8) dims = dims[:0] # empty tensor return data, mask, dims ```
needs reproduction,oncall: jit
low
Critical
392,176,263
opencv
LUT for 32-bit int
Table translation (LUT) is a frequently function while image processing and analysis. But it is usually necessary not for byte (CV_8U), but for 32-bit integer matrices. For example, we have a map of 100000 objects, recognized on the image (like connected components or results of superpixel), and we join them to some 1000 clusters according different rules (on the base of color, borders between objects, gradients, etc.) - after this, we need to remap the matrix by table int[100000]. Of course, we always can write the loop manually. But, on the one hand, OpenCV could provide maximally quick implementation, optimized for GPU, multithreading and other cases. On the other hand, many algorithms are written not in C++, but in Python, Java (like in my case), etc. Simple loop in Java works essentially slower, than your current LUT implementation, and it is especially important when all data are stored in GPU memory (UMat). I think it could be a good idea to add LUT version for CV_32S input type in next OpenCV version. What do you think?
feature,priority: low
low
Major
392,192,777
go
runtime: externally linked programs don't detect deadlocks
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.11.4 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Yes (also master as of last week) ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/home/a/.cache/go-build" GOEXE="" GOFLAGS="-mod=vendor" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/home/a/n/go/" GOPROXY="" GORACE="" GOROOT="/usr/local/go" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" GCCGO="gccgo" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build536260035=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? Did `go run -buildmode=pie` with this: ``` package main func main() { ch1 := make(chan string) ch2 := make(chan string) go func() { <-ch1 ch2 <- "done" }() <-ch2 ch1 <- "done" } ``` ### What did you expect to see? Process dies with the "all goroutines are asleep" message. ### What did you see instead? Not dead but forever sleeping.
help wanted,NeedsFix,compiler/runtime
low
Critical
392,241,050
opencv
Unstable result of useOpenCL in multithreading Java environment
I detected, that `useOpenCL` returns different values when I intensively call OpenCV functions in Java from different threads. (My test sequentially calls several simple OpenCV UMat functions, each function in a separate thread, and repeats all this 150 times in a simple loop.) Sometimes useOpenCL returns `true`, sometimes `false`. In single-thread mode it always returns `true`. Other function `haveOpenCL` always returns `true`. The details are here: https://github.com/bytedeco/javacpp-presets/issues/659 Can you comment the issue? In JavaCPP they say that it looks as a bug in OpenCV. Is it really so? Or, maybe, `useOpenCL` returns only "recommendation" to use GPU (the device is available and ready-to-use), and sometimes the device is "busy" and this function returns `false` - though we can use UMat functions? Should I use `haveOpenCL` (instead of `useOpenCL`) , at the very beginning of my app, to decide, does make sense usage UMat in all algorithms or Mat will be better choice?
incomplete
low
Critical
392,338,237
godot
Calling `set()` and `get()` with invalid property name should raise an error
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** <!-- Specify commit hash if non-official. --> Godot 3.1-dev (3c999ae1a) **OS/device including version:** <!-- Specify GPU model and drivers if graphics-related. --> Linux Mint 19 **Issue description:** <!-- What happened, and what was expected. --> When you call `set()` or `get()` with an invalid property name (or value), there's no error message. It makes hard to find typos in the code. **Steps to reproduce:** * Call `set()` (or `get()`) with a property name that does not exist. * Notice how no errors are logged. **Minimal reproduction project:** [set-get-no-error.zip](https://github.com/godotengine/godot/files/2692285/set-get-no-error.zip)
enhancement,topic:core,topic:gdscript,usability
low
Critical
392,358,111
flutter
Benchmark TextField performance
The text field makes many repeated calls to `GetRectsForRange/GetBoxesForRange` which is not a trivial task. With the introduction of even more calls to it in https://github.com/flutter/flutter/commit/f8964ae250354e655ac81e1be3201ffadd8ce3b2, as well as the discovery and fixing of https://github.com/flutter/flutter/issues/24796, we should benchmark the text field to prevent regressions and ensure it is performant.
a: text input,team,framework,engine,c: performance,P2,team-engine,triaged-engine
low
Major
392,374,961
rust
Docs: std::alloc::set_alloc_error_hook clarifications
In using this function I am wondering a few things: - What happens if I oom while handling an oom? Is the oom handler called again? Does the process immediately abort (ala panic)? - Does triggering oom remove the custom oom handler? The presence of `take_alloc_error_hook` makes it seem like that may the case, but it is not. It looks like the custom handler stays in place through its invocation. Docs would be better to mention that it's possible to oom recursively and invoke your oom handler recursively. - Is OOM the only time that memory allocation fails? The document doesn't mention "out of memory", but the situation this handles is commonly called "OOM". The docs would better mention "out of memory" and whether there is a distinction between allocation failure types. - Does `take_alloc_error_hook` restore the default error hook? Are the answers to these questions known and intended? Please add them to the docs. Here are some harder questions: Can I and should I try to recover from an oom? The oom handling mechanism calls abort after calling the oom handler, but what if I panic in the handler? I could empty my caches or otherwise mess with the allocator, panic, catch the panic, and try to continue. Is that a valid and intended use case?
C-enhancement,T-libs-api,A-docs
low
Critical
392,395,159
scrcpy
Notifications won't swipe off lock screen.
I can slide them to the right at whatever speed with the mouse, but they don't slide off the screen and go away as what happens when you do it with your finger. Moto g5 plus, android 8.1.
input events
low
Minor
392,418,409
pytorch
Projective Transformation grid generator
## 🚀 Feature <!-- A clear and concise description of the feature proposal --> An analogous function to `torch.nn.functional.affine_grid` that takes a full 3x3 projective transformation matrix of the form ``` [[a, b, c], [d, e, f], [g, h, 1]] ``` would be really nice. ## Motivation Reproducing the projective transformation results from Spatial Transformer Networks. <!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too --> ## Pitch <!-- A clear and concise description of what you want to happen. --> A new projective_transform function added with a special case that checks if the bottom row of the input matrix is `[0, 0, 1]` and performs the more optimized affine transform. The old affine transform function should be deprecated (as affine transforms are just a subset of projective transforms). ## Alternatives <!-- A clear and concise description of any alternative solutions or features you've considered, if any. --> Maybe a generalized function that takes a lambda mapping original coordinates to image coordinates.
todo,triaged,enhancement
medium
Major
392,428,699
flutter
Cannot guard a call to State.setState() from within State.dispose().
I have a method with a call to setState(). This method will be called from within State.dispose(), as well as from elsewhere within the lifespan of the State object. (it's a shutdown handler on an object, but I've abstracted that away in my simplified example below), but I cannot seem to guard the usage of setState() (with State.mounted) on the being-disposed-of State object. I'd like to make sure I don't call setState() when calling foo() from within dispose(). (But use setState() normally when calling from elsewhere). Guarding it with State.mounted is not working. If I call the method before super.dispose() ```dart void foo() { if (this.mounted) setState((){...}); } @override void dispose() { foo(); super.dispose(); } ``` Then I get this error, showing that setState() was called: The following assertion was thrown while finalizing the widget tree: flutter: 'package:flutter/src/widgets/framework.dart': Failed assertion: line 3473 pos 12: flutter: '_debugLifecycleState != _ElementLifecycle.defunct': is not true. flutter: flutter: Either the assertion indicates an error in the framework itself, or we should provide substantially flutter: more information in this error message to help you determine and fix the underlying cause. flutter: In either case, please report this assertion by filing a bug on GitHub: flutter: https://github.com/flutter/flutter/issues/new?template=BUG.md flutter: flutter: When the exception was thrown, this was the stack: flutter: #2 Element.markNeedsBuild (package:flutter/src/widgets/framework.dart:3473:12) flutter: #3 State.setState (package:flutter/src/widgets/framework.dart:1146:14) flutter: #4 _SubWidgetState.foo (package:experimental.sparklight.prototypes.audioplugintester/src/sub_widget.dart:44:9) flutter: #5 _SubWidgetState.dispose (package:experimental.sparklight.prototypes.audioplugintester/src/sub_widget.dart:52:5) flutter: #6 StatefulElement.unmount (package:flutter/src/widgets/framework.dart:3900:12) I acknowledge that this makes some sense, as super.dispose() has not been run, so the superclass cleanup has not take place yet, so [mounted] is still true. However, when I move the foo() to _after_ super.dispose(): ```dart void foo() { if (this.mounted) setState((){...}); } @override void dispose() { super.dispose(); foo(); } ``` I get a different message (but a similar-looking stack) [VERBOSE-2:shell.cc(184)] Dart Error: Unhandled exception: setState() called after dispose(): _SubWidgetState#68e4a(lifecycle state: defunct) This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback. The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree. This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose(). When the exception was thrown, this was the stack: flutter: #0 State.setState.<anonymous closure> (package:flutter/src/widgets/framework.dart:1103:9) flutter: #1 State.setState (package:flutter/src/widgets/framework.dart:1129:6) flutter: #2 _SubWidgetState.foo (package:experimental.sparklight.prototypes.audioplugintester/src/sub_widget.dart:44:9) flutter: #3 _SubWidgetState.dispose (package:experimental.sparklight.prototypes.audioplugintester/src/sub_widget.dart:55:5) flutter: #4 StatefulElement.unmount (package:flutter/src/widgets/framework.dart:3900:12) showing that [mounted] is still true. This contradicts the comments in framework.dart for dispose(): /// The framework calls this method when this [State] object will never /// build again. After the framework calls [dispose], the [State] object is /// considered unmounted and the [mounted] property is false. It is an error /// to call [setState] at this point. This stage of the lifecycle is terminal: /// there is no way to remount a [State] object that has been disposed. and for setState() /// It is an error to call this method after the framework calls [dispose]. /// You can determine whether it is legal to call this method by checking /// whether the [mounted] property is true. Others have suggested adding my own ivar flag (i.e. _isDisposing, which is set to true at the start of my overridden State.dispose() and used as the guard in foo()) or multiple versions of foo() (i.e. foo() and fooWithoutSetState()). However, I'd prefer to not have to track the State lifecycle myself, nor add extra complexity in the number of methods. Thanks for looking!
framework,d: api docs,has reproducible steps,P2,found in release: 3.3,found in release: 3.5,team-framework,triaged-framework
low
Critical
392,448,297
pytorch
F.grid_sample doesn't respect padding_mode when height of inputs is 1
## 🐛 Bug The function `F.grid_sample` takes two args: `inputs`and `coords`. For the sake of simplicity I'm going to describe this issue for the case when `inputs` represents a grayscale image and has a shape `[1, 1, IH, IW]`. The `coords` argument has shape `[1, OH, OW, 2]`, where the final dimension of size 2 is an x and y coordinate in normalized input space, where `-1,-1` is the top left of the image and `+1,+1` is the bottom right. The `[1, C, OH, OW]` output is constructed by sampling values from the input at the xy-coordinate specified in the `coords` argument. Bilinear interpolation is used when the xy-coordinate (after de-normalization) doesn't fall cleanly within a single pixel in `inputs`. The bug has to do with the behavior when a value in `coords` falls outside of the range `[-1,1]`. The docs state that the value should be bilinearly based on the border mode (the default behaves as if the entire input image was surrounded with zeros). This works in most cases. However, this fails in the case where `IH=1`. ## To Reproduce First consider the working case. Lets just make a 2x2 image and sample "under it" at the normalized position `(0, 30)` (which is very far under the sample image). ``` # Make a 2x2 image inputs = torch.Tensor([ [1, 2], [1, 2] ])[None, None] # Sample at a position way outside of the image coords = torch.Tensor([0, 30])[None, None, None] print(F.grid_sample(inputs, coords)) ``` This code correctly returns that the sampled value is `tensor([[[[0.]]]])` (because, again, we are way off the image). However, if we remove a row from the image (making it have shape (1, 2)) and we sample way underneath the image again, we get a non-zero result. ``` inputs = torch.Tensor([ [1, 2], ])[None, None] coords = torch.Tensor([0, 30])[None, None, None] print(F.grid_sample(inputs, coords)) ``` This outputs `tensor([[[[1.5000]]]])`, which seems to indicate that torch is treating the image as if it is infinitely tiled in the Y direction. ## Environment PyTorch version: 1.0.0 (also tested on 0.4.1) Is debug build: No CUDA used to build PyTorch: 9.0.176 OS: Ubuntu 16.04.5 LTS GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609 CMake version: version 3.13.1 Python version: 3.6 Is CUDA available: Yes CUDA runtime version: 8.0.61 GPU models and configuration: GPU 0: GeForce GTX 1050 Nvidia driver version: 384.130 cuDNN version: Probably one of the following: /usr/lib/x86_64-linux-gnu/libcudnn.so.6.0.21 /usr/lib/x86_64-linux-gnu/libcudnn_static_v6.a <!-- Add any other context about the problem here. --> cc @brianjo @mruberry
module: docs,triaged,module: interpolation
low
Critical
392,521,875
vscode
Prevent Find/Replace bar from returning after Next Match (F3)
In regular Visual Studio, when you press Ctrl+F to find, you type your search text and press Enter. Because the Find/Replace "dialog" does not automatically go away, I've learned to immediately press Esc to get rid of it. At that point, I can press F3 to repeat search (next match) or Shift+F3 for previous match and the dialog remains hidden. This is not true in Visual Studio Code -- even after pressing Esc to make the Find/Replace bar go away, it reappears after every F3, which is maddening. I've already given the dialog everything it needs. Please make it possible for it to remain hidden until summoned again with Ctrl+F.
feature-request,editor-find
medium
Major
392,523,822
go
cmd/compile: make argument size of -S output more accurate
I would like to seek clarification about the correct argument size for assembly functions. Specifically, `asmdecl` requires different sizes from those reported by `go tool compile -S`. See the following gist for an example: https://gist.github.com/mmcloughlin/598774c255f40605e613ffb3361e240c I'll copy the main points here. The function implemented is: ```go package argsize func Index3(a [7]byte) byte func Expect(a [7]byte) byte { return a[3] } ``` with assembly ```asm TEXT ·Index3(SB),0,$0-16 MOVB a_3+3(FP), AL MOVB AL, ret+8(FP) RET ``` `go tool compile -S` reports argument size 16 ``` "".Expect STEXT nosplit size=10 args=0x10 locals=0x0 0x0000 00000 (argsize.go:6) TEXT "".Expect(SB), NOSPLIT|ABIInternal, $0-16 ``` while `asmdecl` requires size 9 ``` ./argsize.s:1:1: [amd64] Index3: wrong argument size 16; expected $...-9 ``` Is this behaving as intended? cc @alandonovan @josharian
NeedsFix,compiler/runtime
low
Minor
392,528,131
rust
Tracking issue: platform-specific APIs for SGX target
This issue tracks the functionality available behind the `sgx_platform` feature gate. Relevant PRs: * #56978 * #57119 TODO: * [ ] arch module * More details in https://github.com/fortanix/rust-sgx/issues/15 * At the very least the `AlignXXX<[u8; _]>` types should be replaced by the actual types (from the [`sgx-isa` crate](https://crates.io/crates/sgx-isa)). Concern: that would make `std` dependent on the `bitflags` crate. * [ ] ffi module * No concerns * [ ] io module * No concerns * [ ] mem module * No concerns, but no evidence of real-world usage * [ ] thread module * No concerns * [ ] usercalls module * This is all pretty untested outside of std For more information about the target, see https://edp.fortanix.com
T-lang,T-libs-api,B-unstable,C-tracking-issue,O-SGX,Libs-Tracked,S-tracking-design-concerns
low
Major
392,576,329
node
regression: child_process stdin pipe close event not emitted
### Summary * **Version**: v8.12.0 and newer, all v10.x and all v11.x * **Platform**: Linux and macOS amd64 * **Subsystem**: child_process Since #18701 Node.js doesn't emit a close event when a child process closes its stdin pipe. The close is only detected if the parent tries to write to the child's stdin and receives an EPIPE. The original behaviour is preferable because it allows immediate detection of the close event, rather than waiting for a failed write. ### Reproducer This works as expected in v8.11.4 and fails in all newer versions of v8.x, as well as all v10.x and all v11.x. ```js const {spawn} = require('child_process'); const cp = spawn( 'node', [ '-e', 'fs.closeSync(0); setTimeout(() => {}, 2000)' ], {stdio: ['pipe', 'inherit', 'inherit']} ) setTimeout(() => { console.log('BUGGY! stdin close event was not emitted') process.exit(1); }, 1000); cp.stdin.on('close', () => { console.log('Ok!') process.exit(0); }); ``` ### Problem detail As far as I can tell the only way the close event can be emitted is if the `Socket` constructor calls `this.read(0)`. This triggers `onStreamRead()` to be called, which does `stream.push(null)` and eventually results in the close event. This is a little weird because stdin isn't a readable stream :) In Node 8.11.4 this worked because `child_process.js:createSocket()` called the `Socket` constructor with `options.readable === undefined`. So the `Socket` constructor sees that `options.readable !== false` and runs `this.read(0)` In PR #18701 `createSocket()` was changed to call the `Socket` constructor with `options.readable === true`. This stops `this.read(0)` from being called and the close event is not emitted. ### Hacky solution ```diff --- a/lib/internal/child_process.js +++ b/lib/internal/child_process.js @@ -286,3 +286,3 @@ function flushStdio(subprocess) { function createSocket(pipe, readable) { - return net.Socket({ handle: pipe, readable, writable: !readable }); + return net.Socket({ handle: pipe, readable, writable: !readable, childProcess: true }); } --- a/lib/net.js +++ b/lib/net.js @@ -315,3 +315,5 @@ function Socket(options) { // buffer. if not, then this will happen when we connect - if (this._handle && options.readable !== false) { + if (options.childProcess) { + this.read(0); + } else if (this._handle && options.readable !== false) { if (options.pauseOnCreate) { ``` This passes the full test suite with a minor change to `test-pipewrap.js`. I haven't raised a PR because I'm sure somebody could think of a better solution. If someone can point me in the right direction I'm happy to try and implement it. Thanks :)
confirmed-bug,child_process,net,stream
low
Critical
392,577,364
vscode
Microsoft Surface Precision Mouse - "Accelerated Vertical Scrolling" breaks smooth scroll
<!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ --> <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: 1.30.1 - OS Version: Win 10 1809 Steps to Reproduce: 1. Use a Microsoft Surface Precision Mouse (I used it in bluetooth mode). 2. Activate `Accelerated Vertical Scrolling` in the *Microsoft Mouse and Keyboard Cente* (it's enabled by default). 3. Scroll in vscode is not smooth anymore. Other applications like chrome are still smooth however. ![image](https://user-images.githubusercontent.com/9069888/50219991-438d8480-0391-11e9-9b3f-8da1c825d89d.png) <!-- Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: **Yes**
feature-request,windows,trackpad/scroll
low
Minor
392,582,456
go
syscall: modest improvement to Windows DLL-preloading protection
### What version of Go are you using (`go version`)? <pre> go version go1.11 windows/amd64 </pre> ### Does this issue reproduce with the latest release? yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\Alex\AppData\Local\go-build set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOOS=windows set GOPATH=C:\MyGo set GOPROXY= set GORACE= set GOROOT=C:\Go set GOTMPDIR= set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64 set GCCGO=gccgo set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD= set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-LC:/winsdklibs64 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\Alex\AppData\Local\Temp\go-build831000242=/tmp/go-build -gno-record-gcc-switches </pre></details> ### What did you do? I'm looking into protecting my project from DLL-preloading attacks. Many of the vendored libraries I use use the syscall/windows LoadDLL call rather than the safer x/sys/windows LazySystemDLL method. I note that syscall/windows LoadDLL has some limited protection for a preset list of system DLLs via sysdll.IsSystemDLL . However this is case-sensitive, when LoadLibrary etc. are case insensitive. Therefore: `windows.LoadDLL("advapi32.dll")` is protected but `windows.LoadDLL("Advapi32.dll")` is not A simple tweak would be to string.ToUpper in sysdll.Add and string.ToUpper in the check in LoadDLL
Security,OS-Windows,NeedsDecision,compiler/runtime
low
Critical
392,583,590
flutter
CupertinoTextField should not allow horizontal scrolling
If you have a `CupertinoTextField` and you write a lot of text in it, so it doesn't fit and you need to scroll the text, then if you scroll horizontally in the `CupertinoTextField` you can actually scroll to different positions of the text. This is not possible in native Cupertino widgets. If you try to do the same thing in a Swift/Obj-C iOS app then you will see it is not possible, you can do this only by dragging the marker selectors. ## Steps to Reproduce Any `CupertinoTextField` is like this. This is not something specific to an isolated case. ## Logs ``` [✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.14.1 18B75, locale en-RO) • Flutter version 1.0.0 at /Users/tudor/dev/flutter • Framework revision 5391447fae (3 weeks ago), 2018-11-29 19:41:26 -0800 • Engine revision 7375a0f414 • Dart version 2.1.0 (build 2.1.0-dev.9.4 f9ebf21297) [✓] Android toolchain - develop for Android devices (Android SDK 28.0.3) • Android SDK at /Users/tudor/Library/Android/sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-28, build-tools 28.0.3 • ANDROID_HOME = /Users/tudor/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06) • All Android licenses accepted. [✓] iOS toolchain - develop for iOS devices (Xcode 10.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 10.1, Build version 10B61 • ios-deploy 1.9.4 • CocoaPods version 1.5.3 [✓] Android Studio (version 3.2) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 29.1.1 • Dart plugin version 181.5656 • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06) [✓] Connected device (1 available) • Tudor’s iPhone 7 • 6c6f39c58d86256962f6a336f8ebef46f202225e • ios • iOS 12.1.2 • No issues found! ```
a: text input,framework,a: fidelity,f: cupertino,c: proposal,P2,team-design,triaged-design
low
Major
392,584,751
TypeScript
Confusing enum reverse string lookup behaviour in strict mode
## Summary Code below. Typescript in --strict mode will reject enum reverse lookups using arbitrary strings with this very confusing error message: > Element implicitly has an 'any' type because index expression is not of type 'number'. A workaround is to cast the string to a subset of all possible enum keys but that's impractical with large enums (or is there an easy way to say "any key of enum X" in TS?). *My real world use case: I have a react app with a `<select>` filter on various items, and a bunch of `<option>` values, all of which are part of an integer enum. I have to use the string representation in the dom, so the state of the filter has to be the string representation. When I check the item's enum value I already know it can only be one of those enum members.* This report is three-fold: 1. Is this behaviour intended? There are cases where it can definitely catch a reverse lookup that can fail. 2. If it is intended, then what is the correct way to declare that the lookup will always be valid? `let typeFilter: "FOO" | "BAR" = "FOO"` is impractical and increases risk of errors. 3. **Regardless of the above, the error message should be fixed**. The element highlighted (`typeFilter`) does not in fact have an "any" type, and `Type[typeFilter]` will not be `any` either (in fact, `Type[typeFilter] as Type` does not fix it). An error such as "Reverse lookup on enum Type may fail because typeFilter is of type 'string'" is much clearer already. ## Details **TypeScript Version:** 3.2.2 **Search Terms:** enum reverse string lookup **Code** ```ts // test.ts // Compile with `tsc --strict test.ts` export enum Type { FOO = 0, BAR = 1, } const Test = () => { // Change the following line to `let typeFilter: "FOO" | "BAR" = "FOO";` and it will work let typeFilter = "FOO"; if (Type[typeFilter] != Type.FOO) { return; } }; export default Test; ``` **Actual behavior:** ``` test.ts:9:11 - error TS7015: Element implicitly has an 'any' type because index expression is not of type 'number'. 9 if (Type[typeFilter] != Type.FOO) { ~~~~~~~~~~ Found 1 error. ``` **Playground Link:** [Playground](http://www.typescriptlang.org/play/#src=export%20enum%20Type%20%7B%0D%0A%09FOO%20%3D%200%2C%0D%0A%09BAR%20%3D%201%2C%0D%0A%7D%0D%0A%0D%0Aconst%20Test%20%3D%20()%20%3D%3E%20%7B%0D%0A%09let%20typeFilter%20%3D%20%22FOO%22%3B%0D%0A%0D%0A%09if%20(Type%5BtypeFilter%5D%20!%3D%20Type.FOO)%20%7B%0D%0A%09%09return%3B%0D%0A%09%7D%0D%0A%7D%3B%0D%0A%0D%0Aexport%20default%20Test%3B) **Related Issues:** Maybe #27297
Suggestion,Domain: Error Messages,Experience Enhancement
low
Critical
392,608,529
angular
State transition to void triggered for animated children while still existing in DOM
# 🐞 bug report ### Affected Package The issue is caused by package `@angular/animation` (any version) ### Description 1. There is an array of numbers 2. There is a parent container that generates multiple child items with a ngFor loop using that array. 3. Each item gets its number from the array assigned. 3. Every item has an animation attached to visualize active or inactive states. The parent container has an animation attached to coordinate staggering of the children. 4. When removing an item by modifying the array of numbers the item is removed. 5. This usually works and the item disappears (no animation involved) When the array contains identical numbers and you remove one of the duplicate numbers you run into a problem. As expected this will cause remaining siblings to move to the left but you will get a list of "dead" components— but only from the animation perspective as the child animation have been transitioned to state void while remaining safe & sound in the DOM. I can reproduce this problem in a small stackblitz where I go into more details by referring to parts of the demo. ## 🔬 Minimal Reproduction Preview: https://animation-dom-move-bug.stackblitz.io/ Source: https://stackblitz.com/edit/animation-dom-move-bug ## 🔥 Exception or Error My small [stackblitz demo](https://stackblitz.com/edit/animation-dom-move-bug) shows the error and you can reproduce it perfectly: **Do this:** Click on "remove 2" and you will see what's happening in this gif. ![bug](https://user-images.githubusercontent.com/1701755/50223899-b819f080-039c-11e9-9723-0427bf6377b6.gif) Yellow stands for state void. You can see a yellow to green animation at the beginning of the gif loop that's the transition (void => active). After clicking the remove button you will see yellow items. I call them dead. Still in DOM but in state void. Just look at the all yellow numbers after you clicked the remove button. Also look into the console, you will see plenty of state transitions from active to void which is wrong. ## 🌍 Your Environment **Angular Version:** Latest Angular 7, see the stackblitz demo. **Anything else relevant?** Here some related issues I think #23534 #26078
type: bug/fix,area: animations,freq2: medium,P3
low
Critical
392,619,577
rust
Suggest type or module with similar name when code is incorrect
Given the following code: ```rust use std::ffi::CString; fn main() { let s = Cstring::new("hello").unwrap(); } ``` rustc gives me this output: ``` error[E0433]: failed to resolve: use of undeclared type or module `Cstring` --> main.rs:4:13 | 4 | let s = Cstring::new("hello").unwrap(); | ^^^^^^^ use of undeclared type or module `Cstring` warning: unused import: `std::ffi::CString` --> main.rs:1:5 | 1 | use std::ffi::CString; | ^^^^^^^^^^^^^^^^^ | = note: #[warn(unused_imports)] on by default error: aborting due to previous error For more information about this error, try `rustc --explain E0433`. ``` when it should give something like this: ``` error[E0433]: failed to resolve: use of undeclared type or module `Cstring` --> main.rs:4:13 | 4 | let s = Cstring::new("hello").unwrap(); | ^^^^^^^ did you mean `CString`? ``` <!-- TRIAGEBOT_START --> <!-- TRIAGEBOT_ASSIGN_START --> <!-- TRIAGEBOT_ASSIGN_DATA_START$${"user":"phansch"}$$TRIAGEBOT_ASSIGN_DATA_END --> <!-- TRIAGEBOT_ASSIGN_END --> <!-- TRIAGEBOT_END -->
C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics,D-papercut
low
Critical
392,656,257
flutter
[video_player] Initialization error when initializing multiple videos
I'm initializing video but this message comes up and never initialized video. I'm displaying loading indicator until video gets initialized. So, view never changes from loading indicator. Is there any workaround? ``` W/art (16464): Suspending all threads took: 7.008ms E/ACodec (16464): [OMX.google.aac.decoder] Now Loaded E/ACodec (16464): [OMX.google.aac.decoder] Now Loaded Restarted application in 3,682ms. I/ExoPlayerImpl(16464): Release 2bfc15e [ExoPlayerLib/2.9.1] [KXU, SHV40, SHARP, 25] [goog.exo.core] E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-1] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-1] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-1] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-1] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-1] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-1] cancelBuffer: BufferQueue has been abandoned E/ACodec (16464): [OMX.qcom.video.decoder.avc] Now Loaded E/ACodec (16464): [OMX.google.aac.decoder] Now Loaded I/ExoPlayerImpl(16464): Release 7f037e0 [ExoPlayerLib/2.9.1] [KXU, SHV40, SHARP, 25] [goog.exo.core] E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-0] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-0] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-0] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-0] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-0] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-0] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-0] cancelBuffer: BufferQueue has been abandoned E/ACodec (16464): [OMX.qcom.video.decoder.avc] Now Loaded E/ACodec (16464): [OMX.google.aac.decoder] Now Loaded I/ExoPlayerImpl(16464): Release 850f20c [ExoPlayerLib/2.9.1] [KXU, SHV40, SHARP, 25] [goog.exo.core] E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-2] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-2] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-2] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-2] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-2] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-2] cancelBuffer: BufferQueue has been abandoned E/BufferQueueProducer(16464): [SurfaceTexture-0-16464-2] cancelBuffer: BufferQueue has been abandoned E/ACodec (16464): [OMX.qcom.video.decoder.avc] Now Loaded E/ACodec (16464): [OMX.google.aac.decoder] Now Loaded I/ExoPlayerImpl(16464): Init 7fa0991 [ExoPlayerLib/2.9.1] [KXU, SHV40, SHARP, 25] I/ExoPlayerImpl(16464): Init 5a06764 [ExoPlayerLib/2.9.1] [KXU, SHV40, SHARP, 25] I/ExoPlayerImpl(16464): Init 92eb193 [ExoPlayerLib/2.9.1] [KXU, SHV40, SHARP, 25] I/ExoPlayerImpl(16464): Init 3db59c9 [ExoPlayerLib/2.9.1] [KXU, SHV40, SHARP, 25] E/ACodec (16464): [OMX.qcom.video.decoder.avc] Now Loaded E/ACodec (16464): [OMX.google.aac.decoder] Now Loaded E/ACodec (16464): [OMX.qcom.video.decoder.avc] Now Loaded E/ACodec (16464): [OMX.qcom.video.decoder.avc] Now Loaded E/ACodec (16464): [OMX.google.aac.decoder] Now Loaded E/ACodec (16464): [OMX.google.aac.decoder] Now Loaded E/ACodec (16464): [OMX.qcom.video.decoder.avc] Now Loaded E/ACodec (16464): [OMX.qcom.video.decoder.avc] configureCodec returning error -12 E/ACodec (16464): signalError(omxError 0x80001001, internalError -12) E/MediaCodec(16464): Codec reported err 0xfffffff4, actionCode 0, while in state 3 E/MediaCodec(16464): configure failed with err 0xfffffff4, resetting... E/ACodec (16464): [OMX.qcom.video.decoder.avc] Now Loaded W/MediaCodecRenderer(16464): Failed to initialize decoder: OMX.qcom.video.decoder.avc W/MediaCodecRenderer(16464): android.media.MediaCodec$CodecException: Error 0xfffffff4 W/MediaCodecRenderer(16464): at android.media.MediaCodec.native_configure(Native Method) W/MediaCodecRenderer(16464): at android.media.MediaCodec.configure(MediaCodec.java:1884) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.video.MediaCodecVideoRenderer.configureCodec(MediaCodecVideoRenderer.java:483) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.initCodec(MediaCodecRenderer.java:805) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.initCodecWithFallback(MediaCodecRenderer.java:745) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.maybeInitCodec(MediaCodecRenderer.java:474) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.reinitializeCodec(MediaCodecRenderer.java:1261) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.onInputFormatChanged(MediaCodecRenderer.java:1111) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.video.MediaCodecVideoRenderer.onInputFormatChanged(MediaCodecVideoRenderer.java:552) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:647) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:536) W/MediaCodecRenderer(16464): at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:303) W/MediaCodecRenderer(16464): at android.os.Handler.dispatchMessage(Handler.java:98) W/MediaCodecRenderer(16464): at android.os.Looper.loop(Looper.java:154) W/MediaCodecRenderer(16464): at android.os.HandlerThread.run(HandlerThread.java:61) E/ExoPlayerImplInternal(16464): Playback error. E/ExoPlayerImplInternal(16464): com.google.android.exoplayer2.ExoPlaybackException: com.google.android.exoplayer2.mediacodec.MediaCodecRenderer$DecoderInitializationException: Decoder init failed: OMX.qcom.video.decoder.avc, Format(2, null, null, video/avc, null, -1, null, [1280, 720, -1.0], [-1, -1]) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.maybeInitCodec(MediaCodecRenderer.java:479) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.reinitializeCodec(MediaCodecRenderer.java:1261) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.onInputFormatChanged(MediaCodecRenderer.java:1111) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.video.MediaCodecVideoRenderer.onInputFormatChanged(MediaCodecVideoRenderer.java:552) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:647) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:536) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:303) E/ExoPlayerImplInternal(16464): at android.os.Handler.dispatchMessage(Handler.java:98) E/ExoPlayerImplInternal(16464): at android.os.Looper.loop(Looper.java:154) E/ExoPlayerImplInternal(16464): at android.os.HandlerThread.run(HandlerThread.java:61) E/ExoPlayerImplInternal(16464): Caused by: com.google.android.exoplayer2.mediacodec.MediaCodecRenderer$DecoderInitializationException: Decoder init failed: OMX.qcom.video.decoder.avc, Format(2, null, null, video/avc, null, -1, null, [1280, 720, -1.0], [-1, -1]) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.initCodecWithFallback(MediaCodecRenderer.java:753) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.maybeInitCodec(MediaCodecRenderer.java:474) E/ExoPlayerImplInternal(16464): ... 9 more E/ExoPlayerImplInternal(16464): Caused by: android.media.MediaCodec$CodecException: Error 0xfffffff4 E/ExoPlayerImplInternal(16464): at android.media.MediaCodec.native_configure(Native Method) E/ExoPlayerImplInternal(16464): at android.media.MediaCodec.configure(MediaCodec.java:1884) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.video.MediaCodecVideoRenderer.configureCodec(MediaCodecVideoRenderer.java:483) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.initCodec(MediaCodecRenderer.java:805) E/ExoPlayerImplInternal(16464): at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.initCodecWithFallback(MediaCodecRenderer.java:745) E/ExoPlayerImplInternal(16464): ... 10 more ``` **flutter doctor** ``` Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, v1.0.0, on Mac OS X 10.13.6 17G4015, locale ja-JP) [✓] Android toolchain - develop for Android devices (Android SDK 28.0.3) [✓] iOS toolchain - develop for iOS devices (Xcode 10.1) [✓] Android Studio (version 3.2) [✓] VS Code (version 1.30.1) [!] Connected device ! No devices available ```
c: crash,customer: crowd,p: video_player,package,team-ecosystem,has reproducible steps,P2,found in release: 2.5,found in release: 2.6,triaged-ecosystem
low
Critical
392,674,680
node
Makefile dependency tree is incomplete, makefiles do not build only as necessary
* Version: master * Platform:Linux samtu 4.18.0-12-generic #13-Ubuntu SMP Wed Nov 14 15:17:05 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux * Subsystem: gyp/make The makefiles generated by gyp are not working for development (they work better for single-shot CI builds). Perhaps I'm missing something, please tell me if I am, but I've done some asking around to people who know the gyp system, and have some agreement on these points. - `make node; make node` Make should do *nothing* if no source code has been changed, but `make node` relinks both `node` *and* `cctest` (!?) every time it is run. - `make -C out node` is faster, ~but~ and builds just node, not cctest, but it does it even if no source has changed. However, its build/dependency tree is incomplete! It doesn't run js2c so if any js source files are changed they will not be built-in with js2c. Fast and wrong is worse than slow. - `make -C out/Release node` as above - ` make -j4 node; make -j1 test` often required. parallel make is not working for test. Various symptoms of brokenness occur (irc has some discussion). Sounds like this could be related to the dependency relationships not being correctly specified, causing build rules to run in parallel when they cannot, and thus be racy. - `./configure --shared-openssl-includes` will cause openssl include paths to be passed to dependencies that don't use openssl. This might appear harmless, but it (for example) causes ccache to rebuild icu, even though icu doesn't use openssl. Possible fix: https://github.com/nodejs/node/blob/eef6504cf7b95ada170ec9878089ce57fde551d8/common.gypi#L549-L560, add `OPENSSL_THREADS` to the else clause (I haven't tried yet). Ninja notes: Ninja (`./configure --ninja`) doesn't have the above problems for building, its dependency tree is correct (it builds nothing when nothing has changed, and it reruns js2c when js files have changed). However, it is either incomplete or not integrated with the rest of the build (I'm not sure how its intended to work). It doesn't make the top-level `node` symlink (at least `test-doc` relies on this), so a `ln -s out/Release/node node` is required for `make test-doc`. As for `make test`, it won't use the ninja build output, because it relies on .PHONY targets, so it always (effectively) does a `make -C out all`.
confirmed-bug,build
low
Critical
392,738,151
TypeScript
Async Transformers
I was using Compiler API and basically changed program.emit at host.afterProgramCreate just like examples and hooked my transformers into emit function. But one thing i couldn't find anywhere is a async transformer. Im using PostCSS and some other stuff like that and implementing those to a single typescript compiler but some plugins are async in postcss and i cant use them at the moment. Is there any way to implement this that im missing or undocumented ? And in case somebody offers to use webpack my code is mostly javascript based and i need really good static analysis for it with type data included that's also reason i use typescript's api instead of using babel which have those cases mostly covered with plugins. I'm implementing all-in-one solution for my company/community project so ideally it needs to be inside typescript compiler.
Suggestion,API,Awaiting More Feedback
low
Major
392,799,232
godot
Default implicit and explicit values both return null from a ShaderMaterial
Godot 3.0.6 Godot 3.1 alpha3 This is a variant of #17887, that I thought was fixed by #21806: In my plugin I want to display parameters in a dialog (so not the inspector), based on shader material parameters, however these come as null if they were never set through the material, forcing me to spend time re-implement a workaround to handle default values manually for each case. In 3.0.6 that workaround is particularly tedious to write because I need to iterate the param list and check all types. Also, `hint_range` comes as a single string to reparse and default values are inaccessible. ```gdscript extends Node func _ready(): var mat = ShaderMaterial.new() mat.shader = load("res://test.shader") # This one has an explicit default value in the shader var explicit = mat.get_shader_param("explicit") # This one has an implicit default value (usually zero) var implicit = mat.get_shader_param("implicit") # Both print null print("Explicit: ", explicit) print("Implicit: ", implicit) ``` [ShaderMaterialDefaultValue.zip](https://github.com/godotengine/godot/files/2696691/ShaderMaterialDefaultValue.zip) In 3.1, the workaround would be simpler: ```gdscript static func _get_shader_param(mat, name): var v = mat.get_shader_param(name) if v != null: return v return VisualServer.material_get_param_default(mat.get_rid(), name) ``` However it still returns null in both cases, despite the values showing correctly if I do the same actions in the inspector.
bug,confirmed,topic:shaders
low
Major
392,840,597
flutter
Show a warning if gradle is about to crash because of non-ascii characters
A gradle bug causes the gradle daemon to crash if there are non-ascii characters in any environment variable and the locale is not properly set (https://github.com/gradle/gradle/issues/3117). We bumped into this issue a few times on CI (#24935). It would be useful for the flutter tool to detect this state and show a warning. Repro steps (makes gradle crash): **WARNING this puts gradle in a bad state on my machine and my only way out of it was rebooting, try only if you have time to reboot 😄** ```bash unset LANG export SOME_ENV="א" flutter build apk ```
c: new feature,tool,t: flutter doctor,t: gradle,P2,team-tool,triaged-tool
low
Critical
392,862,086
pytorch
JIT is not compatible with data parallel
## 🐛 Bug JIT is not compatible with data parallel. So no one can train any model using more than one GPU. Data parallel is such a fundamental module. It makes the JIT totally unpractical for training (except toy models), even in 1.0 **stable** version. ## To Reproduce Steps to reproduce the behavior: 1. Use resnet 18 script module from https://github.com/pytorch/pytorch/blob/0b219538cfb70503baa74053d3e827951e0ea6f9/test/test_jit.py#L5882-L5983 1. `model = torch.nn.DataParallel(model)` 1. Get the following error > Traceback (most recent call last): > File "train.py", line 459, in <module> > main() > File "train.py", line 333, in main > train(train_loader, model, criterion, optimizer, epoch) > File "train.py", line 394, in train > output = model(input) > File "/usr/local/lib/python3.6/dist-packages/torch/nn/modules/module.py", line 489, in __call__ > result = self.forward(*input, **kwargs) > File "/usr/local/lib/python3.6/dist-packages/torch/nn/parallel/data_parallel.py", line 142, in forward > replicas = self.replicate(self.module, self.device_ids[:len(inputs)]) > File "/usr/local/lib/python3.6/dist-packages/torch/nn/parallel/data_parallel.py", line 147, in replicate > return replicate(module, device_ids) > File "/usr/local/lib/python3.6/dist-packages/torch/nn/parallel/replicate.py", line 31, in replicate > replica._parameters = replica._parameters.copy() > AttributeError: 'OrderedParameterDict' object has no attribute 'copy' If I firstly run `model = torch.nn.DataParallel(model)` for a nn.Module, then trace it, although the code runs, the loss doesn't decrease. <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior The code runs and the model gets trained ## Environment PyTorch version: 1.0.0 Is debug build: No CUDA used to build PyTorch: 9.0.176 OS: Ubuntu 16.04.4 LTS GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609 CMake version: version 3.5.1 Python version: 3.6 Is CUDA available: Yes CUDA runtime version: Could not collect GPU models and configuration: GPU 0: Tesla P40 GPU 1: Tesla P40 GPU 2: Tesla P40 Nvidia driver version: 390.77 cuDNN version: Probably one of the following: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.0.5 /usr/lib/x86_64-linux-gnu/libcudnn_static_v7.a Versions of relevant libraries: [pip] Could not collect [conda] Could not collect ## Additional context Related issue: #12875 Data parallel is such a fundamental module, I can't imagine JIT is not compatible with it and no official programmer have tested it. It makes the JIT totally unpractical for training (except toy models)
oncall: jit
medium
Critical
392,865,105
ant-design
Menu item with icon and text in inline collapse
- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate. ### What problem does this feature solve? In the inline collapse menu, can only show the icon which is ambiguous to user, if we can put a text under it which can make it more clear meaning to user ### What does the proposed API look like? Create two components which similar to MenuItem and SubMenu, here is an example of MenuItemCollapse which will show icon and text in single menu item. Example code to use: <Menu.ItemCollapse key="1"> <Icon type="pie-chart" /> <span>Option 1</span> </Menu.ItemCollapse> <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
💡 Feature Request,Inactive
low
Minor
392,866,913
flutter
Let Flutter be installable via dnf
## Steps to Reproduce <!-- Please tell us exactly how to reproduce the problem you are running into. --> 1. `sudo dnf install flutter` ## Logs ``` Last metadata expiration check: 0:52:16 ago on Wed 19 Dec 2018 06:10:23 PM PST. No match for argument: flutter Error: Unable to find a match ``` <!-- If possible, paste the output of running `flutter doctor -v` here. --> Unable to get to that
c: new feature,tool,platform-linux,P3,team-tool,triaged-tool
low
Critical
392,900,637
go
x/mobile: Failed to build GO app for android platform
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.11.1 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="/home/mhirpara/work/go/bin" GOCACHE="/home/mhirpara/.cache/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/home/mhirpara/work/go" GOPROXY="" GORACE="" GOROOT="/usr/lib/go" GOTMPDIR="" GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64" GCCGO="gccgo" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build255459644=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? Trying to compile below GO app, which include C calls, for android platform. ``` package main // #include <unistd.h> // int // am_session_leader() // { // return (getsid(0)); // } import "C" import ( "fmt" ) func main() { fmt.Println(C.am_session_leader()) } ``` <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> ### What did you expect to see? Expectation is to build this app for Android Platform, just like other platforms and should be able to run. ### What did you see instead? I see build errors as below: ``` # command-line-arguments ./main.go:7: error: undefined reference to 'getsid' ./main.go:7: error: undefined reference to 'getsid' clang70: error: linker command failed with exit code 1 (use -v to see invocation) # command-line-arguments ./main.go:7:12: warning: implicit declaration of function 'getsid' is invalid in C99 [-Wimplicit-function-declaration] ``` Commands: ``` GOOS=android GOARCH=arm GOROOT=/usr/lib/go CGO_ENABLED=1 CC=/home/mhirpara/work/go/pkg/gomobile/ndk-toolchains/arm/bin/arm-linux-androideabi-gcc go build main.go OR gomobile build -x -target=android github.com/mehulhirpara/learning/cgo-getsid ```
mobile
low
Critical
392,948,287
pytorch
IDEEP error:could not initialize a memory descriptor
I translate a caffe model to caffe2 model. Then I try to use the IDEEP device option to do forward compution , I got the error message "IDEEP error:could not initialize a memory descriptor" .
caffe2
low
Critical
392,954,194
pytorch
caffe2: multi-thread(or multi-instance) predict is much slower than the single thread or single instance
the caffe2 forward is much slower(one more times) than single thread or single instance, any one know how to deal with it? thanks .
caffe2
low
Major
393,008,800
godot
VRAM compressed texture takes a lot of space when imported
I'm using Godot.alpha3 on OSX 10.14 `Video RAM` compressed textures are too big. 4kX4k texture takes 16mb on the drive. This is also affects exported game size. ``` [.]: ls -lah ghost.png -rw-r--r-- 1 jkbo staff 480K Dec 20 14:16 ghost.png [.]: ls -lah .import/ghost.png-f343bb4bd35f12f8f631dffe3b7d2891.* -rw-r--r-- 1 jkbo staff 16M Dec 20 14:17 .import/ghost.png-f343bb4bd35f12f8f631dffe3b7d2891.etc2.stex -rw-r--r-- 1 jkbo staff 91B Dec 20 14:17 .import/ghost.png-f343bb4bd35f12f8f631dffe3b7d2891.md5 -rw-r--r-- 1 jkbo staff 16M Dec 20 14:17 .import/ghost.png-f343bb4bd35f12f8f631dffe3b7d2891.s3tc.stex -rw-r--r-- 1 jkbo staff 551K Dec 20 14:16 .import/ghost.png-f343bb4bd35f12f8f631dffe3b7d2891.stex ``` There is my import settings: <img width="416" alt="screenshot 2018-12-20 at 14 40 06" src="https://user-images.githubusercontent.com/122736/50282863-2d50f880-0465-11e9-94f8-e558ff096181.png">
enhancement,discussion,topic:import,topic:3d
low
Major
393,118,443
create-react-app
Chrome debugger breakpoints fail with react-scripts 2.x after hot-update
### Is this a bug report? yes ### Did you try recovering your dependencies? test-cra $npm --version 5.6.0 test-cra $yarn --version 1.12.3 ### Which terms did you search for in User Guide? I looked for "hot-update" and "breakpoint" ### Environment System: OS: macOS High Sierra 10.13.6 CPU: x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz Binaries: Node: 8.11.1 - ~/.nvm/versions/node/v8.11.1/bin/node Yarn: 1.12.3 - /usr/local/bin/yarn npm: 5.6.0 - ~/.nvm/versions/node/v8.11.1/bin/npm Browsers: Chrome: 71.0.3578.98 Firefox: 63.0.1 Safari: 11.1.2 npmPackages: react: ^16.7.0 => 16.7.0 react-dom: ^16.7.0 => 16.7.0 react-scripts: 2.1.1 => 2.1.1 npmGlobalPackages: create-react-app: Not Found ### Steps to Reproduce 1. ran "yarn create react-app test-cra" 2. ran "yarn install" 3. ran "yarn start" 4. Chrome opened a window for http://localhost:3000, with the app in it 5. I opened Chrome dev tools and went to the source tab 6. I hit cmd-P and opened App.js 7. I set a breakpoint at line 7, the first line of the render() method 8. I clicked on the "reload this page" arrow in the "React App" browser window 9. the debugger in dev tools window stopped at the breakpoint 10. I hit F8 to unpause ** this is all good, and I am able to repeat steps 8-10 successfully any number of times 11. in IntelliJ I edited the App.js file so it was like this: ``` import React, { Component } from 'react'; import logo from './logo.svg'; import './App.css'; class App extends Component { render() { return ( <div className="App"> <header className="App-header"> <img src={logo} className="App-logo" alt={this.foo} /> <p> Edit <code>src/App.js</code> and save to reload. </p> <a className="App-link" href="https://reactjs.org" target="_blank" rel="noopener noreferrer" > Learn React </a> </header> </div> ); } foo = 'bar'; } export default App; ``` NOTE: I did not move the position of the breakpointed line within the file. 12. I saw that the app recompiled and reloaded successfully. The code as pasted above is what appeared in the devtools source tab, and the breakpoint was positioned at the same place. However, the debugger did not stop at the breakpoint. 13. I clicked on the "reload this page" arrow in the "React App" browser window, but the debugger does not stop there anymore. I see that at the bottom of the Source tab, it now says "(source mapped from main.{guid}.hot-update.js)". 14. I stopped execution of the yarn start task with control-C. 15. I re-ran "yarn start". 16. the debugger does not stop on the initial page load, but it does stop on every subsequent page load (when I click the "reload this page" arrow). 17. I see that on the bottom of the devtools Source tab, it now says "(source mapped from main.chunk.js)". My apologies if the format of how I described this is not matching the following bullet points - I think I have done what they ask, but in a more interleaved fashion. I think the essence is that I have described a reproducible demo with what I expected, what I did, and what happened as a result. NOTES: this does NOT happen to me when I am using react-scripts 1.1.4 (in the full-blown app where I encountered the issue) but only appeared when I upgraded to 2.x (first 2.0.5 and now 2.1.1). Thanks very much for your help with this!
issue: bug
high
Critical
393,156,744
rust
Rustc_driver cann't correctly find codegen dirs with multiple subfolders in libdir.
When rust compiled and installed with multiple subfolders in libdir it cann't correctly found directory with codegen-backends. See https://github.com/rust-lang/rust-clippy/issues/3565 ```rust // use `parent` twice to chop off the file name and then also the // directory containing the dll which should be either `lib` or `bin`. if let Some(path) = dll.parent().and_then(|p| p.parent()) { ``` https://github.com/rust-lang/rust/blob/master/src/librustc_driver/lib.rs#L302 It would be work if `rustc_driver` was placed in `/usr/lib64/librustc_driver-62d9b292bf74f4a6.so` so it get `/usr` as sysroot but it placed in `/usr/lib64/rust-9999/librustc_driver-62d9b292bf74f4a6.so` so it get incorrect `/usr/lib64`. I suppose it could be two possible solutions: The first is about to iterate parents until root will be reached. The second is to calculate number of parents need to be removed with `find_libdir` from `filesearch.rs`. Which are better or there are some other ways to solve this? P.S. Looks like it doesn't fail for system-wide installed rustc and clippy because `filesearch::get_or_default_sysroot` got correct `/usr` sysroot from binaries in `/usr/bin`. If them will be moved same way as `gcc` in Gentoo it will break as well: ```bash $ echo `which gcc` /usr/x86_64-pc-linux-gnu/gcc-bin/7.3.0/gcc ```
A-driver,T-compiler
low
Major
393,159,498
vue
Transition is erroneously run when placed with bizarre sequence of sibling elements.
### Version 2.5.21 ### Reproduction link [https://jsfiddle.net/analyzeplatypus/eywraw8t/513878/](https://jsfiddle.net/analyzeplatypus/eywraw8t/513878/) ![screen recording 2018-12-20 at 8 21 07 pm mov](https://user-images.githubusercontent.com/18376110/50303197-00b4d500-0495-11e9-9f02-145099a68d15.gif) ### Steps to reproduce The fiddle contains a seemingly random sequence of elements that illustrates the issue (described below). 1. Open the JSFiddle 2. Click the "Change" button 3. The transition plays (it should not). Try removing any of the DOM elements and the errant transition no longer plays! ### What is expected? The transition should not run. (CSS transition classes should not be applied, hooks should not be called, etc.) ### What is actually happening? The transition is run (CSS transition classes are applied). --- I came across this while building a complex form with multiple buttons that appear/disappear based on form state. I noticed duplicated buttons in one of my unit tests, and found that a transition was being run even though its child's `v-if` binding was not being changed. I duplicated the component and whittled it down until I arrived at the attached JSFiddle. This issue appears when the following sequence of elements are aligned: 1. A boolean entry in the Vue component's `data` dictionary (`hasChanges: false`, in the JSFiddle) The DOM contains 2. A `<div>` whose `v-if` is bound to the boolean entry (1). 2. A `<transition>` containing a button which modifies the boolean entry (1). 3. An empty `<transition>` element. 4. A `<div>` whose `v-if` is bound to the boolean entry (1) modified by logical NOT (!). (In the fiddle, `v-if="!hasChanges"`). With this exact structure, modifying the boolean entry (1) will run the transition - even though the transition is not bound to the boolean at all! If you remove any of the above elements, **or even reorder them** (!) the errant transition will not run (which is the correct behavior). Why does the transition run when placed with this particular set of siblings in this particular order? <!-- generated by vue-issues. DO NOT REMOVE -->
bug,has workaround,transition
low
Major
393,171,805
godot
DynamicFont causes frame drops
**Godot version:** Godot 3.1-dev (a custom version forked in September) **OS/device including version:** Android/iOS **Issue description:** Using DynamicFont causes noticeable frame drops when first shown. My guess is that the font textures are generated at that point and it's a slow enough to take some frames worth of time to be done. This is particular noticeable on less powerful devices such as smartphones. It's definitely related to DynanicFont since when we replaced that to bitmap fonts (generated using Godot 2 importer) the frame drops went away. **Minimal reproduction project:** I really couldn't reproduce this in a small project as it is not slow enough to make a difference. This seems to be more of a problem if the FPS is already below the vsync time.
bug,topic:core
low
Major
393,200,994
flutter
Support Unix .ar archives in license tool
Implement .ar and .tar parsers in the license tool and `ArBinaryFile` and `TarBinaryFile` classes in filesystem.dart. See: https://github.com/flutter/engine/blob/55f022fc9c1e7f08420844bdc71f6d98bf9b4b46/tools/licenses/lib/filesystem.dart#L287-L290 We're doing a check for .ar filetype magic there (!<arch> + an LF). Rather than treating .ar files (and .tar files right above that) as opaque blobs, we should treat them roughly equivalently to a directory root in the tool and scan the contents for copyright/licence info the same way as we would a directory. /cc @Hixie
c: new feature,team,engine,c: proposal,P2,team-engine,triaged-engine
low
Minor
393,208,402
TypeScript
Excessive stack depth comparing types with TS 3.2
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.2.2 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** error TS2321: Excessive stack depth comparing types lodash **Code** ```ts import { PartialDeep, pick } from 'lodash'; type MapFunc<T> = (data: PartialDeep<T>) => PartialDeep<T>; function testFunc<T>(): MapFunc<T> { return data => pick<PartialDeep<T>>(data, []) as PartialDeep<T>; } ``` ```json { "compilerOptions": { "target": "es2018", "module": "commonjs", "lib": ["es2018", "dom"], "strict": true, "noEmitOnError": true } } ``` **Expected behavior:** This code should compile with TS 3.2 as it will with TS 3.1 **Actual behavior:** Compliation fails with the following error ``` error TS2321: Excessive stack depth comparing types 'PartialDeep<T>' and 'PartialDeep<PartialDeep<T>>'. Found 2 errors. ```
Bug,Domain: Mapped Types
medium
Critical
393,215,469
flutter
Decouple scrollable's cacheExtent and implicit accessibility scrolling
We should let people toggle `cacheExtent` for the purposes of pre-fetching and caching etc. But it's currently tied to implicit accessibility scrolling. Sounds like that's already a flag on SemanticsFlag so it should theoretically be composed with list views to prevent implicit scrolling (such as in case of PageViews where it should never implicitly scroll regardless of cacheExtent) https://docs.flutter.io/flutter/dart-ui/SemanticsFlag/hasImplicitScrolling-constant.html. But the flag is not currently used in the iOS accessibility bridge. Implement something similar to https://github.com/flutter/engine/pull/5941. i.e. reads to kIsHidden should also be gated behind hasImplicitScrolling. cc @goderbauer
platform-ios,framework,engine,a: accessibility,f: scrolling,P2,team-ios,triaged-ios
low
Minor
393,254,644
youtube-dl
Site Support Request - www.enhancetv.com.au
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2018.12.17*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x ] I've **verified** and **I assure** that I'm running youtube-dl **2018.12.17** ### Before submitting an *issue* make sure you have: - [x ] At least skimmed through the [README](https://github.com/rg3/youtube-dl/blob/master/README.md), **most notably** the [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones - [ x] Checked that provided video/audio/playlist URLs (if any) are alive and playable in a browser ### What is the purpose of your *issue*? - [ ] Bug report (encountered problems with youtube-dl) - [x ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other ### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://www.enhancetv.com.au/video/time-team/11342 Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
account-needed
low
Critical
393,261,214
pytorch
Improve one_hot
As discussed in https://github.com/pytorch/pytorch/pull/15208, the following improve can be made on `torch.nn.functional.ont_hot`: - Make the `num_classes` parameter `int64_t?` instead of `int64_t num_classes = -1` - Add optional dtype argument - Add optional dim argument cc: @zou3519 @vadimkantorov cc @albanD @mruberry
module: nn,triaged,function request
low
Major
393,276,861
go
proposal: cmd/go: add GOARM=8 for further optimization on armv7/aarch32
Currently an ARM program built by go will call runtime.udiv() for a division, in which it detect if a hardware divider is available, or use software division. The main reason is that a hardware divider is an optional component for an ARMv7 machine. But in the real world, most ARMv7 SOC has it, such as RaspberryPi2. GOARM=8 implies that the program will run in the aarch32 mode (ARMv7 compatible) of an arm64 machine, on which a hardware divider is a must. So 1. the compiler will directly generate a SDIV/UDIV for div and mod operations. 2. the program built with GOARM=8 can also run on ARMv7 with a HW Dividor, like RP2. The go1 benchmark does show some improvement for directly generation of SDIV/UDIV against runtime detection. name old time/op new time/op delta BinaryTree17-4 20.6s ± 0% 20.5s ± 1% -0.30% (p=0.000 n=40+40) Fannkuch11-4 9.31s ± 0% 9.27s ± 0% -0.42% (p=0.000 n=40+39) FmtFprintfEmpty-4 297ns ± 0% 298ns ± 0% +0.34% (p=0.000 n=38+40) FmtFprintfString-4 588ns ± 0% 599ns ± 0% +1.81% (p=0.000 n=36+40) FmtFprintfInt-4 633ns ± 0% 637ns ± 0% +0.56% (p=0.000 n=40+29) FmtFprintfIntInt-4 960ns ± 0% 953ns ± 0% -0.71% (p=0.000 n=40+40) FmtFprintfPrefixedInt-4 1.05µs ± 0% 1.05µs ± 0% ~ (p=0.194 n=35+38) FmtFprintfFloat-4 1.95µs ± 0% 1.75µs ± 0% -10.12% (p=0.000 n=38+40) FmtManyArgs-4 3.55µs ± 0% 3.42µs ± 0% -3.68% (p=0.000 n=40+40) GobDecode-4 37.4ms ± 1% 37.4ms ± 1% ~ (p=0.320 n=37+39) GobEncode-4 34.7ms ± 1% 34.4ms ± 1% -0.80% (p=0.000 n=40+40) Gzip-4 2.06s ± 1% 2.07s ± 1% +0.44% (p=0.000 n=39+38) Gunzip-4 254ms ± 0% 254ms ± 0% +0.16% (p=0.000 n=40+38) HTTPClientServer-4 823µs ± 2% 817µs ± 2% -0.70% (p=0.008 n=37+37) JSONEncode-4 79.4ms ± 0% 76.0ms ± 1% -4.23% (p=0.000 n=32+40) JSONDecode-4 308ms ± 0% 304ms ± 0% -1.06% (p=0.000 n=40+39) Mandelbrot200-4 17.6ms ± 0% 17.6ms ± 0% ~ (p=0.210 n=34+38) GoParse-4 18.9ms ± 1% 18.7ms ± 1% -1.10% (p=0.000 n=39+40) RegexpMatchEasy0_32-4 500ns ± 0% 502ns ± 2% +0.35% (p=0.014 n=39+40) RegexpMatchEasy0_1K-4 3.82µs ± 0% 3.82µs ± 0% +0.15% (p=0.000 n=40+40) RegexpMatchEasy1_32-4 546ns ± 0% 548ns ± 1% +0.44% (p=0.000 n=40+40) RegexpMatchEasy1_1K-4 4.78µs ± 0% 4.79µs ± 0% +0.16% (p=0.000 n=38+37) RegexpMatchMedium_32-4 737ns ± 2% 741ns ± 3% +0.53% (p=0.026 n=40+40) RegexpMatchMedium_1K-4 164µs ± 0% 162µs ± 0% -0.72% (p=0.000 n=39+35) RegexpMatchHard_32-4 10.6µs ± 0% 10.5µs ± 0% -0.86% (p=0.000 n=40+40) RegexpMatchHard_1K-4 316µs ± 0% 312µs ± 0% -1.13% (p=0.000 n=38+40) Revcomp-4 40.5ms ± 3% 40.8ms ± 2% +0.85% (p=0.001 n=40+39) Template-4 395ms ± 0% 387ms ± 0% -2.07% (p=0.000 n=40+39) TimeParse-4 2.68µs ± 0% 2.65µs ± 0% -1.12% (p=0.000 n=40+40) TimeFormat-4 5.42µs ± 0% 5.29µs ± 0% -2.30% (p=0.000 n=38+37) [Geo mean] 304µs 302µs -0.88% name old speed new speed delta GobDecode-4 20.5MB/s ± 1% 20.5MB/s ± 1% ~ (p=0.284 n=37+39) GobEncode-4 22.1MB/s ± 1% 22.3MB/s ± 1% +0.81% (p=0.000 n=40+38) Gzip-4 9.41MB/s ± 1% 9.37MB/s ± 1% -0.41% (p=0.000 n=38+38) Gunzip-4 76.5MB/s ± 0% 76.4MB/s ± 0% -0.16% (p=0.000 n=40+38) JSONEncode-4 24.4MB/s ± 0% 25.5MB/s ± 1% +4.42% (p=0.000 n=32+40) JSONDecode-4 6.31MB/s ± 0% 6.37MB/s ± 0% +1.02% (p=0.000 n=40+35) GoParse-4 3.06MB/s ± 1% 3.10MB/s ± 1% +1.13% (p=0.000 n=39+40) RegexpMatchEasy0_32-4 63.9MB/s ± 0% 63.7MB/s ± 2% ~ (p=0.070 n=39+40) RegexpMatchEasy0_1K-4 268MB/s ± 0% 268MB/s ± 0% -0.15% (p=0.000 n=40+40) RegexpMatchEasy1_32-4 58.6MB/s ± 0% 58.3MB/s ± 1% -0.44% (p=0.000 n=40+40) RegexpMatchEasy1_1K-4 214MB/s ± 0% 214MB/s ± 0% -0.16% (p=0.000 n=38+37) RegexpMatchMedium_32-4 1.36MB/s ± 3% 1.35MB/s ± 3% -0.70% (p=0.022 n=40+40) RegexpMatchMedium_1K-4 6.26MB/s ± 0% 6.31MB/s ± 0% +0.73% (p=0.000 n=37+40) RegexpMatchHard_32-4 3.01MB/s ± 1% 3.04MB/s ± 0% +1.03% (p=0.000 n=40+40) RegexpMatchHard_1K-4 3.25MB/s ± 0% 3.28MB/s ± 0% +1.05% (p=0.000 n=40+40) Revcomp-4 62.8MB/s ± 4% 62.3MB/s ± 2% -0.86% (p=0.001 n=40+39) Template-4 4.91MB/s ± 0% 5.01MB/s ± 0% +2.11% (p=0.000 n=40+39) [Geo mean] 17.0MB/s 17.1MB/s +0.53%
Proposal,Proposal-Hold
low
Major
393,289,553
pytorch
Transplant caffe2 on my DNN-accelerator
## ❓ Questions and Help ### Please note that this issue tracker is not a help form and this issue will be closed. We have a set of [listed resources available on the website](https://pytorch.org/resources). Our primary means of support is our discussion forum: - [Discussion Forum](https://discuss.pytorch.org/) If I want to transplant caffe2 on my DNN-accelerator (make my accelerator to be the backend like GPU), besides implementing my operators algorithm, what else should I do on the caffe2 framework?
caffe2
low
Minor
393,345,450
TypeScript
Improve exception reporting
## Search Terms Crash, Maximum call stack size exceeded, fork-ts-checker-webpack-plugin ## Suggestion Improve crash logs by dumping statements, file names, line number and everything that might help to identify faulty statement. <!-- A summary of what you'd like to see added or changed --> I just upgraded packages and toolchain for large rect\typescript project. I am using webpack with fork-ts-checker-webpack-plugin for type checks. Plugin works fine with 3.1.6 and crashing with 3.2.2. Does not work with 3.3.0-dev.20181220 as well. I found that dev version 3.2.0-dev.20181030 works ok, and 3.2.0-dev.20181031 is crashing. Here is a crash log ``` RangeError: Maximum call stack size exceeded at resolveNameHelper (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:31504:35) at resolveName (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:31502:20) at resolveEntityName (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:32353:26) at resolveTypeReferenceName (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:38055:20) at getTypeFromTypeReference (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:38240:30) at getTypeFromTypeNode (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:39667:28) at getConstraintFromTypeParameter (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:37898:72) at fillMissingTypeArguments (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:37447:33) at getTypeFromClassOrInterfaceReference (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:37999:78) ``` ## Use Cases It is rather impossible to identify faulty statements manually. I cannot distill what exactly is causing that, so detailed exception logging would be very helpfull ## Examples [Exception evaluating c:/code/example.tsx ] [class: ABC] [method: func()] [expression: a = b + c; ] RangeError: Maximum call stack size exceeded at resolveNameHelper (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:31504:35) at resolveName (C:\code\spkg\web\node_modules\typescript\lib\typescript.js:31502:20) ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Bug,Crash
low
Critical
393,366,430
go
runtime: unexpected signal during runtime execution on Debian
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go1.10.1 linux/amd64 </pre> ### Does this issue reproduce with the latest release? No ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/home/tiger/.cache/" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/opt/tiger/compile_path" GORACE="" GOROOT="/usr/local/go" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" GCCGO="gccgo" CC="gcc" CXX="g++" CGO_ENABLED="1" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build590147109=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> My service started in a docker container and happened to throw panic. I cannot figure it out. The stack shows as follow: ``` fatal error: unexpected signal during runtime execution [signal SIGSEGV: segmentation violation code=0x1 addr=0x34 pc=0x4341f1] runtime stack: runtime: unexpected return pc for runtime.schedule called from 0x100000002 stack: frame={sp:0x7fa5c902ed78, fp:0x7fa5c902edc0} stack=[0x7fa5c882f2b0,0x7fa5c902eeb0) 00007fa5c902ec78: 0000000000000034 0000000000000001 00007fa5c902ec88: 000000000249e56c 0000000000000000 00007fa5c902ec98: 00007fa5c902ecc0 0000000000457b8c <runtime.dopanic.func1+60> 00007fa5c902eca8: 000000c4200f0600 000000000042c921 <runtime.throw+129> 00007fa5c902ecb8: 00007fa5c902ed08 00007fa5c902ecf8 00007fa5c902ecc8: 000000000042c84a <runtime.dopanic+74> 00007fa5c902ecd8 00007fa5c902ecd8: 0000000000457b50 <runtime.dopanic.func1+0> 000000c4200f0600 00007fa5c902ece8: 000000000042c921 <runtime.throw+129> 00007fa5c902ed08 00007fa5c902ecf8: 00007fa5c902ed18 000000000042c921 <runtime.throw+129> 00007fa5c902ed08: 0000000000000000 000000000000002a 00007fa5c902ed18: 00007fa5c902ed68 00000000004423be <runtime.sigpanic+654> 00007fa5c902ed28: 00000000024f5aac 000000000000002a 00007fa5c902ed38: 0000000000439fd7 <runtime.runqsteal+87> 000000c420050a00 00007fa5c902ed48: 000000c42004c5e8 000000c4200f0600 00007fa5c902ed58: 0000000000000000 000b947b2004c000 00007fa5c902ed68: 00007fa5c902ee10 00000000004341f1 <runtime.schedule+225> 00007fa5c902ed78: <000000c42004c000 000000c420050a00 00007fa5c902ed88: 000000c400000000 0000000000000000 00007fa5c902ed98: 00007fa5c902edd0 0000000000000004 00007fa5c902eda8: 0000000000000000 0000000400000003 00007fa5c902edb8: !0000000100000002 >000000c42004c000 00007fa5c902edc8: 000000c4201f6800 00007fa5c902edf0 00007fa5c902edd8: 0000000000432bc8 <runtime.wakep+72> 0000000000000000 00007fa5c902ede8: 000000c42004a000 00000000004331c5 <runtime.execute+261> 00007fa5c902edf8: 000000c4200f0600 000000c42004c000 00007fa5c902ee08: 00007fa5c902ed88 00007fa5c902ee58 00007fa5c902ee18: 000000000043424b <runtime.schedule+315> 000000c42004c000 00007fa5c902ee28: 0000000000000000 0000000000436300 <runtime.gfput+256> 00007fa5c902ee38: 00007fa5c902ee58 000000000043d435 <runtime.selparkcommit+133> 00007fa5c902ee48: 000000c4200f0600 000000c4222fa120 00007fa5c902ee58: 00007fa5c902ee88 0000000000434576 <runtime.park_m+182> 00007fa5c902ee68: 000000c4201f2a80 0000000000000000 00007fa5c902ee78: 00007fa5cc7d0601 000000c4200f0600 00007fa5c902ee88: 000000c421a4e268 000000000045925b <runtime.mcall+91> 00007fa5c902ee98: 000000c4201f2a80 0000000000000000 00007fa5c902eea8: 0100000000000000 runtime.throw(0x24f5aac, 0x2a) /usr/local/go/src/runtime/panic.go:616 +0x81 runtime.sigpanic() /usr/local/go/src/runtime/signal_unix.go:372 +0x28e runtime: unexpected return pc for runtime.schedule called from 0x100000002 stack: frame={sp:0x7fa5c902ed78, fp:0x7fa5c902edc0} stack=[0x7fa5c882f2b0,0x7fa5c902eeb0) 00007fa5c902ec78: 0000000000000034 0000000000000001 00007fa5c902ec88: 000000000249e56c 0000000000000000 00007fa5c902ec98: 00007fa5c902ecc0 0000000000457b8c <runtime.dopanic.func1+60> 00007fa5c902eca8: 000000c4200f0600 000000000042c921 <runtime.throw+129> 00007fa5c902ecb8: 00007fa5c902ed08 00007fa5c902ecf8 00007fa5c902ecc8: 000000000042c84a <runtime.dopanic+74> 00007fa5c902ecd8 00007fa5c902ecd8: 0000000000457b50 <runtime.dopanic.func1+0> 000000c4200f0600 00007fa5c902ece8: 000000000042c921 <runtime.throw+129> 00007fa5c902ed08 00007fa5c902ecf8: 00007fa5c902ed18 000000000042c921 <runtime.throw+129> 00007fa5c902ed08: 0000000000000000 000000000000002a 00007fa5c902ed18: 00007fa5c902ed68 00000000004423be <runtime.sigpanic+654> 00007fa5c902ed28: 00000000024f5aac 000000000000002a 00007fa5c902ed38: 0000000000439fd7 <runtime.runqsteal+87> 000000c420050a00 00007fa5c902ed48: 000000c42004c5e8 000000c4200f0600 00007fa5c902ed58: 0000000000000000 000b947b2004c000 00007fa5c902ed68: 00007fa5c902ee10 00000000004341f1 <runtime.schedule+225> 00007fa5c902ed78: <000000c42004c000 000000c420050a00 00007fa5c902ed88: 000000c400000000 0000000000000000 00007fa5c902ed98: 00007fa5c902edd0 0000000000000004 00007fa5c902eda8: 0000000000000000 0000000400000003 00007fa5c902edb8: !0000000100000002 >000000c42004c000 00007fa5c902edc8: 000000c4201f6800 00007fa5c902edf0 00007fa5c902edd8: 0000000000432bc8 <runtime.wakep+72> 0000000000000000 00007fa5c902ede8: 000000c42004a000 00000000004331c5 <runtime.execute+261> 00007fa5c902edf8: 000000c4200f0600 000000c42004c000 00007fa5c902ee08: 00007fa5c902ed88 00007fa5c902ee58 00007fa5c902ee18: 000000000043424b <runtime.schedule+315> 000000c42004c000 00007fa5c902ee28: 0000000000000000 0000000000436300 <runtime.gfput+256> 00007fa5c902ee38: 00007fa5c902ee58 000000000043d435 <runtime.selparkcommit+133> 00007fa5c902ee48: 000000c4200f0600 000000c4222fa120 00007fa5c902ee58: 00007fa5c902ee88 0000000000434576 <runtime.park_m+182> 00007fa5c902ee68: 000000c4201f2a80 0000000000000000 00007fa5c902ee78: 00007fa5cc7d0601 000000c4200f0600 00007fa5c902ee88: 000000c421a4e268 000000000045925b <runtime.mcall+91> 00007fa5c902ee98: 000000c4201f2a80 0000000000000000 00007fa5c902eea8: 0100000000000000 runtime.schedule() /usr/local/go/src/runtime/proc.go:2547 +0xe1 // some goroutines maybe helpful to show what happened goroutine 1 [select, 11 minutes]: code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite.waitSignal(0xc42239f140, 0x0, 0x0) /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite/kite.go:138 +0x1cf code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite.Run(0xc400000018, 0x25ed2b8) /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite/kite.go:126 +0x66 main.main() /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/server.go:78 +0x5d6 goroutine 5 [select]: code.byted.org/video/stream_service/vendor/code.byted.org/gopkg/metrics.(*Sender).emitCounterLoop(0xc4200e2100) /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/gopkg/metrics/sender.go:221 +0x167 created by code.byted.org/video/stream_service/vendor/code.byted.org/gopkg/metrics.(*Sender).runLoops /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/gopkg/metrics/sender.go:213 +0x3f ... goroutine 2268 [IO wait]: internal/poll.runtime_pollWait(0x7fa5cc7846a0, 0x72, 0x0) /usr/local/go/src/runtime/netpoll.go:173 +0x57 internal/poll.(*pollDesc).wait(0xc4201d8998, 0x72, 0xc4222bf200, 0x0, 0x0) /usr/local/go/src/internal/poll/fd_poll_runtime.go:85 +0x9b internal/poll.(*pollDesc).waitRead(0xc4201d8998, 0xffffffffffffff00, 0x0, 0x0) /usr/local/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d internal/poll.(*FD).Accept(0xc4201d8980, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0) /usr/local/go/src/internal/poll/fd_unix.go:372 +0x1a8 net.(*netFD).accept(0xc4201d8980, 0xa17e614831, 0x3b8c160, 0x1) /usr/local/go/src/net/fd_unix.go:238 +0x42 net.(*TCPListener).accept(0xc4202be3a8, 0x458530, 0xc42d0abe38, 0xc42d0abe40) /usr/local/go/src/net/tcpsock_posix.go:136 +0x2e net.(*TCPListener).Accept(0xc4202be3a8, 0x25ed4a8, 0xc420da2f00, 0x26f0d00, 0xc440373ad8) /usr/local/go/src/net/tcpsock.go:259 +0x49 code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite.(*RpcServer).AcceptLoop(0xc420da2f00, 0x0, 0x0) /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite/kite_server.go:106 +0x4b code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite.(*RpcServer).Serve(0xc420da2f00, 0x0, 0x0) /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite/kite_server.go:189 +0x118 code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite.Run.func1(0xc42239f140) /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite/kite.go:124 +0x2d created by code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite.Run /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite/kite.go:123 +0x58 ... goroutine 2277 [IO wait, 11 minutes]: internal/poll.runtime_pollWait(0x7fa5cc784910, 0x72, 0x0) /usr/local/go/src/runtime/netpoll.go:173 +0x57 internal/poll.(*pollDesc).wait(0xc420d7f398, 0x72, 0xc422944f00, 0x0, 0x0) /usr/local/go/src/internal/poll/fd_poll_runtime.go:85 +0x9b internal/poll.(*pollDesc).waitRead(0xc420d7f398, 0xffffffffffffff00, 0x0, 0x0) /usr/local/go/src/internal/poll/fd_poll_runtime.go:90 +0x3d internal/poll.(*FD).Accept(0xc420d7f380, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0) /usr/local/go/src/internal/poll/fd_unix.go:372 +0x1a8 net.(*netFD).accept(0xc420d7f380, 0x7fa5cc7d0d90, 0x0, 0x25f12c0) /usr/local/go/src/net/fd_unix.go:238 +0x42 net.(*TCPListener).accept(0xc4201bc128, 0xc4229b1e10, 0x412758, 0x30) /usr/local/go/src/net/tcpsock_posix.go:136 +0x2e net.(*TCPListener).AcceptTCP(0xc4201bc128, 0x2235680, 0xc421a30cc0, 0x210ab60) /usr/local/go/src/net/tcpsock.go:246 +0x49 net/http.tcpKeepAliveListener.Accept(0xc4201bc128, 0xc420044110, 0x210ab60, 0x3b6f970, 0x23954e0) /usr/local/go/src/net/http/server.go:3216 +0x2f net/http.(*Server).Serve(0xc420106f70, 0x26ecbc0, 0xc4201bc128, 0x0, 0x0) /usr/local/go/src/net/http/server.go:2770 +0x1a5 net/http.(*Server).ListenAndServe(0xc420106f70, 0xc420106f70, 0x1) /usr/local/go/src/net/http/server.go:2711 +0xa9 net/http.ListenAndServe(0xc420eaafb8, 0x6, 0x0, 0x0, 0x1, 0x0) /usr/local/go/src/net/http/server.go:2969 +0x7a code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite.startDebugServer.func2() /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite/debug.go:40 +0xb2 created by code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite.startDebugServer /opt/tiger/compile_go_path/src/code.byted.org/video/stream_service/vendor/code.byted.org/kite/kite/debug.go:37 +0x101 ``` I suspect some goroutines waiting for too long to make runtime scheduler abnormal, but I cannot reproduce it.
NeedsInvestigation,compiler/runtime
low
Critical
393,397,772
rust
A perf regression between 2018-12-20 and 2018-12-21
Instructions and wall-time took a [noticeable hit](https://perf.rust-lang.org/compare.html?start=2018-12-20&end=6d34ec18c7d7e574553f6347ecf08e1e1c45c13d&stat=instructions%3Au) due to one of [these changes](https://github.com/rust-lang/rust/compare/e42247f949fe2ce64d688f1585a2dbbc66720406...6d34ec18c7d7e574553f6347ecf08e1e1c45c13d). instructions: ``` style-servo-check avg: 43.0% min: 23.4% max: 55.9% style-servo-opt avg: 14.4% min: 2.9% max: 49.5% style-servo-debug avg: 20.5% min: 7.1% max: 44.0% sentry-cli-check avg: 29.6% min: 14.9% max: 41.4% inflate-check avg: 10.6% min: 3.4% max: 33.6% syn-check avg: 23.9% min: 13.3% max: 28.6% inflate-opt avg: 7.3%? min: 0.8%? max: 26.0%? inflate-debug avg: 9.2% min: 3.5% max: 25.6% syn-debug avg: 12.7% min: 6.9% max: 20.4% syn-opt avg: 6.6%? min: 1.9%? max: 20.3%? sentry-cli-opt avg: 5.4% min: 1.1% max: 18.4% ripgrep-check avg: 12.0% min: 6.4% max: 16.1% ``` wall-time: ``` style-servo-check avg: 21.8% min: 12.3% max: 29.1% style-servo-opt avg: 11.5% min: 5.3% max: 22.2% sentry-cli-check avg: 15.9% min: 7.9% max: 21.3% syn-check avg: 13.6% min: 7.6% max: 18.6% style-servo-debug avg: 14.2% min: 7.8% max: 18.4% inflate-check avg: 10.1% min: 7.2% max: 17.0% inflate-opt avg: 4.3%? min: 0.3%? max: 14.4%? inflate-debug avg: 7.3% min: 4.9% max: 12.7% syn-opt avg: 5.5%? min: 3.4%? max: 10.2%? ``` Cc @varkor (I [narrowed it down](https://perf.rust-lang.org/compare.html?start=09d6ab90e556bf692ff3f8790d97b3ca4fee94b0&end=3f7c718926ab697f91730a987829658146540413&stat=instructions%3Au))
I-slow,I-compiletime,T-compiler
low
Critical
393,412,054
javascript-algorithms
Add Splay Tree
enhancement
medium
Minor
393,415,179
TypeScript
Incompatible type error in regular js with JSDoc generic type annotations
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.3.0-dev.20181221 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** types incompatible, jsdoc, generic **Code** Here I am using regular javascript code with JSDoc type annotations to add typings. ```JavaScript /** * @type {(f: (p1: U) => V, g: (p1: T) => U) => (p1: T) => V} * @template T, U, V */ const compose2 = (f, g) => (p1) => f(g(p1)) /** * @type {(a: number) => number} */ const f = a => a /** * @type {(a: number) => number} */ const g = a => a const c = compose2(f, g) ``` **Expected behavior:** I think no error about types are incompatible should be displayed. The generic types should be replaced with the actual ones. (in contrast if I write a similar type notation for `compose2` via `d.ts` file it works flawlessly) **Actual behavior:** a ts(2345) error: ![image](https://user-images.githubusercontent.com/2802924/50338600-0ce07700-0515-11e9-912d-e83962e7603d.png) **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> **Related Issues:** <!-- Did you find other bugs that looked similar? -->
Bug,Domain: JSDoc
low
Critical
393,428,673
flutter
Scrollbar resizing and jumping
Hi everyone. I have noticed that scrollbar working fine with Lists without pagination and with items of the same size. While we have pagination and items are of different size (like chat with many messages) - scrollbar behaves strange - it is jumping and resizing itself You can find reference to video here: https://drive.google.com/open?id=1sCmo5_22juM45q0kT82nQdvPwzCwJ-zU Please let me know what can I do, or, if there any solutions for that? Thank you in advance
framework,f: scrolling,has reproducible steps,P2,found in release: 2.8,found in release: 2.10,team-framework,triaged-framework
low
Critical
393,476,613
godot
Unable to achieve the desired function about getting properties value from scene drag-and-drop nodes in visualscript
**Godot version:** godot3.1 alpha3 **OS/device including version:** manjaro gnome x64 Intel® Core™ i3-2350M CPU @ 2.30GHz × 4 Intel® Sandybridge Mobile OpenGL ES 3.0 Renderer: Mesa DRI Intel(R) Sandybridge Mobile intel hd 3000 **Issue description:** It can not get player attributes value. ![2018-12-21 21-22-09](https://user-images.githubusercontent.com/33272474/50348004-88244600-0572-11e9-9bdf-59c17b9739b7.png) But it can. ![2018-12-21 21-43-52](https://user-images.githubusercontent.com/33272474/50348005-89ee0980-0572-11e9-926e-b215a204fe61.png) **Steps to reproduce:** ![peek 2018-12-21 22-57](https://user-images.githubusercontent.com/33272474/50348593-2a90f900-0574-11e9-9680-493b448bac07.gif) **Minimal reproduction project:** [test111.zip](https://github.com/godotengine/godot/files/2703247/test111.zip)
topic:visualscript
low
Minor
393,531,535
godot
Dynamic properties are not '.' accessible when accessing external Nodes.
**Godot version:** Godot 3.1 alpha: a92e885 **Issue description:** When using `_get`, `_set`, and `_get_property_list` to expose a property dynamically, I have found that it functions inconsistently. - Works - Test scene 3) A node exposes its own dynamic property and then prints said property using `self.<property>`. - Test scene 2) A node has an exposed Resource property with a script assigned in the Inspector. The Resource script then exposes a dynamic property. The Node prints the resource variable's dynamic property. - Doesn't work - Test scene 1) The *exact* same code from scene 3 is used (without the print statement), but it's placed on a child node. The parent node then attempts to get the child and print the dynamic property. I am unable to identify the reason that this occurs, so I've concluded that it is likely a bug of some kind. Note that using `.set(<property>, <value>)` and `.get(<property>)` still works, but not using dot notation. **Minimal reproduction project:** [test_dynamic_properties.zip](https://github.com/godotengine/godot/files/2703594/test_dynamic_properties.zip)
bug,topic:gdscript,confirmed
low
Critical
393,552,991
flutter
WidgetTester.getSemantics should deal better with force-merged semantics
`WidgetTester.getSemantics` [1] is not really aware of the semantics behind `MergeSemantics` [2], which force-merged individual SemanticsNodes into one. Instead of returning a SemanticsNode that contains the force-merged data, it returns individual un-merged SemanticsNodes. This makes it very hard to test the code that does the force-merging in [3]. We need to change `getSemantics` to better deal with force-merging. The individual nodes it currently returns are meaningless after force-merging. And accessing the forceMerged data in a test is .. awkward right now. Example: ```dart testWidgets('force-merge', (WidgetTester tester) async { final SemanticsTester semantics = SemanticsTester(tester); final Key key = GlobalKey(); await tester.pumpWidget(MaterialApp( home: Card( elevation: 10.0, child: Column( children: <Widget>[ const Text('abs. elevation: 10.0'), MergeSemantics( child: Semantics( explicitChildNodes: true, // just to be sure that it's going to be an explicit merge child: Column( children: const <Widget>[ Card( elevation: 15.0, child: Text('abs. elevation 25.0'), ), Card( elevation: 5.0, child: Text('abs. elevation 15.0'), ) ], ), ), ), ], ) ) )); final SemanticsNode node = tester.getSemantics(find.text('abs. elevation 25.0')); // The following line fails because we're getting back the unmerged node... expect(node.label, 'abs. elevation 25.0\nabs. elevation 15.0'); // ... instead we have to do the following awkward workaround to get the merged data: SemanticsData mergedChildData; elevation10.visitChildren((SemanticsNode child) { expect(mergedChildData, isNull); mergedChildData = child.getSemanticsData(); return true; }); expect(mergedChildData.label, 'abs. elevation 25.0\nabs. elevation 15.0'); semantics.dispose(); }); ``` [1] https://master-docs.flutter.io/flutter/flutter_test/WidgetTester/getSemantics.html [2] https://master-docs.flutter.io/flutter/widgets/MergeSemantics-class.html [3] https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/semantics/semantics.dart#L1652-L1708
a: tests,framework,a: accessibility,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-framework,triaged-framework
low
Minor
393,560,545
angular
DEV mode change detection - Show warning if object reference changes in subsequent check
# 🚀 feature request ### Relevant Package This feature request is for `@angular/core` ### Description When Angular does change detection, it will re-render the view whenever a property binding changes. There is a slight issue with _what_ Angular considers a "change". If an object reference changes to an object identical to the first one, Angular will update the view with this new object, even if the view ends up being identical to the previous one. This situation is easy for new developers to fall into, as it very easy to write a function like: ``` divClasses() { return { red: this.isRed }; } ``` and then bind it to an `[ngClass]` directive, which will remove and re-apply the `red` class every change detection call, because `divClasses()` returns a new object every time it is run. ``` <div [ngClass]="divClasses()"></div><!-- This div will be updated every time change detection is ran. --> ``` This causes two big problems, the first being inefficient view rendering. Change detection only needs to update the view whenever the component's `isRed` value changes, but it ends up updating the view every single time change detection is run. This would slow down the page and negatively impact the end user's experience. The less obvious problem is the possibility of change detection recursion. If the application has a `MutationObserver` somewhere, watching for DOM changes, the above function will cause it to run every time change detection is ran. If this `MutationObserver` also triggers a change detection check, the page will hang as the `divClasses()` function updates the view, triggering the `MutationObserver`, which triggers change detection again. This might not even directly be the developer's fault, as the `MutationObserver` could be from a 3rd party library. I recently spent a day and a half attempting to debug an application hanging in this way. Funnily enough, the problem was made worse by a 3rd party library which modified `console.log` to run change detection - which caused recursion to happen again. Ultimately, I suspect this scenario might be the cause of issues like https://github.com/valor-software/ngx-bootstrap/issues/3047, https://github.com/angular/angular/issues/20450, or https://github.com/angular/angular/issues/24614. ### Describe the solution you'd like To be clear, my proposed "fix" does *NOT* involve modifying Angular's change detection to deeply compare object references. Discussion on this bug: https://github.com/angular/angular/issues/24614 was ultimately tabled because the proposed fix involved deep equality checks, which would be inefficient and very time consuming to check larger objects. Ultimately, the issue here seems to be with functions like my example `divClasses()`, which inadvertently abuse change detection to unnecessarily update the view. If there was some way to alert the developer that a function they've written was possibly faulty, that would probably be the way to go. Currently, Angular displays warnings for change detection when the application is running in dev mode for a similar scenario. If change detection itself causes a property/function to change its output, Angular currently displays a warning about what happened. Could it be possible to display a similar warning for whenever a function returns a different object reference on subsequent change detection calls? A reference check would not be very expensive, and this may end up helping the application developer optimize their program.
feature,area: core,core: change detection,core: debug tools,feature: under consideration
low
Critical
393,563,742
bitcoin
Fail on unknown config file options
A solution would be to either make all binaries be aware of each other's options, or to permit config file options that only apply to specific binaries (`bitcoind`, `bitcoin-qt`, `bitcoin-cli`) or the wallet. (https://github.com/bitcoin/bitcoin/pull/13799#issue-204717028)
Utils/log/libs
low
Major
393,581,815
pytorch
LibTorch: include cmake files for all distributed headers
I'm planning to add libtorch support to a project that already uses pybind11, and I got a few errors because libtorch also bundled pybind11, which is automatically added to the include path. While it's easy enough to use the bundled pybind11 in our project, there is no clean way to reference this in cmake since the libtorch distribution does not include a cmake config file for pybind11. I would suggest adding it, so that one can properly reference the bundled pybind11 version.
module: cpp,triaged
low
Critical
393,603,264
TypeScript
[bug] A method return type of 'this' is incorrectly converted to 'any' in declaration output
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** `^3.3.0-dev.20181129` **Code** ```ts import * as events from 'events' // EventArgs is used to create the event payload arguments for methods like // EventEmitter.emit. This makes it possible to require a payload argument if // the type is not `undefined`, or to not require an event payload argument if // the type is `undefined`. type EventArgs< EventTypes, K extends keyof EventTypes > = EventTypes[K] extends undefined ? [] : [EventTypes[K]] // our own version of EventEmitter with type-safe events (because the // @types/node definition makes all events type `any`). export interface IEventEmitter<EventTypes> { new (): IEventEmitter<EventTypes> addListener<EventName extends keyof EventTypes>( event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void, ): this on<EventName extends keyof EventTypes>( event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void, ): this once<EventName extends keyof EventTypes>( event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void, ): this removeListener<EventName extends keyof EventTypes>( event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void, ): this removeAllListeners<EventName extends keyof EventTypes>( event?: EventName, ): this emit<EventName extends keyof EventTypes>( event: EventName, ...args: EventArgs<EventTypes, EventName> ): boolean eventNames<EventName extends keyof EventTypes>(): Array<EventName> setMaxListeners(n: number): this getMaxListeners(): number listeners<EventName extends keyof EventTypes>( event: EventName, ): (...args: EventArgs<EventTypes, EventName>) => void[] listenerCount<EventName extends keyof EventTypes>(type: EventName): number prependListener<EventName extends keyof EventTypes>( event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void, ): this prependOnceListener<EventName extends keyof EventTypes>( event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void, ): this } // This creates an EventEmitter class that uses our type definition. The // implementation still comes from Node's EventEmitter. // // eslint-disable-next-line typescript/explicit-function-return-type export function makeEventEmitterClass<EventTypes>() { // merge the IEventEmitter interface and EventEmitter as IEventEmitter // implementation into one. // XXX Is there a better way? const EventEmitter = class extends ((events.EventEmitter as unknown) as IEventEmitter<EventTypes>) {} // implements IEventEmitter<EventTypes> {} return EventEmitter } ``` **Expected behavior:** Declaration file should not use `any` for method return types that return `this`. I expect output like the following: ```ts declare type EventArgs<EventTypes, K extends keyof EventTypes> = EventTypes[K] extends undefined ? [] : [EventTypes[K]]; export interface IEventEmitter<EventTypes> { new (): IEventEmitter<EventTypes>; addListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; on<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; once<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; removeListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; removeAllListeners<EventName extends keyof EventTypes>(event?: EventName): IEventEmitter<EventTypes>; emit<EventName extends keyof EventTypes>(event: EventName, ...args: EventArgs<EventTypes, EventName>): boolean; eventNames<EventName extends keyof EventTypes>(): Array<EventName>; setMaxListeners(n: number): IEventEmitter<EventTypes>; getMaxListeners(): number; listeners<EventName extends keyof EventTypes>(event: EventName): (...args: EventArgs<EventTypes, EventName>) => void[]; listenerCount<EventName extends keyof EventTypes>(type: EventName): number; prependListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; prependOnceListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; } export declare function makeEventEmitterClass<EventTypes>(): { new (): { new (): IEventEmitter<EventTypes>; addListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; on<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; once<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; removeListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; removeAllListeners<EventName extends keyof EventTypes>(event?: EventName | undefined): IEventEmitter<EventTypes>; emit<EventName extends keyof EventTypes>(event: EventName, ...args: EventArgs<EventTypes, EventName>): boolean; eventNames<EventName extends keyof EventTypes>(): EventName[]; setMaxListeners(n: number): IEventEmitter<EventTypes>; getMaxListeners(): number; listeners<EventName extends keyof EventTypes>(event: EventName): (...args: EventArgs<EventTypes, EventName>) => void[]; listenerCount<EventName extends keyof EventTypes>(type: EventName): number; prependListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; prependOnceListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; }; addListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; on<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; once<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; removeListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; removeAllListeners<EventName extends keyof EventTypes>(event?: EventName | undefined): IEventEmitter<EventTypes>; emit<EventName extends keyof EventTypes>(event: EventName, ...args: EventArgs<EventTypes, EventName>): boolean; eventNames<EventName extends keyof EventTypes>(): EventName[]; setMaxListeners(n: number): IEventEmitter<EventTypes>; getMaxListeners(): number; listeners<EventName extends keyof EventTypes>(event: EventName): (...args: EventArgs<EventTypes, EventName>) => void[]; listenerCount<EventName extends keyof EventTypes>(type: EventName): number; prependListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; prependOnceListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; }; export {}; //# sourceMappingURL=index.d.ts.map ``` **Actual behavior:** Example of wrong output: ```ts declare type EventArgs<EventTypes, K extends keyof EventTypes> = EventTypes[K] extends undefined ? [] : [EventTypes[K]]; export interface IEventEmitter<EventTypes> { new (): IEventEmitter<EventTypes>; addListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): this; on<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): this; once<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): this; removeListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): this; removeAllListeners<EventName extends keyof EventTypes>(event?: EventName): this; emit<EventName extends keyof EventTypes>(event: EventName, ...args: EventArgs<EventTypes, EventName>): boolean; eventNames<EventName extends keyof EventTypes>(): Array<EventName>; setMaxListeners(n: number): this; getMaxListeners(): number; listeners<EventName extends keyof EventTypes>(event: EventName): (...args: EventArgs<EventTypes, EventName>) => void[]; listenerCount<EventName extends keyof EventTypes>(type: EventName): number; prependListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): this; prependOnceListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): this; } export declare function makeEventEmitterClass<EventTypes>(): { new (): { new (): IEventEmitter<EventTypes>; // RIGHT HERE, the next lines have 'any' addListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): any; on<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): any; once<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): any; removeListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): any; removeAllListeners<EventName extends keyof EventTypes>(event?: EventName | undefined): any; emit<EventName extends keyof EventTypes>(event: EventName, ...args: EventArgs<EventTypes, EventName>): boolean; eventNames<EventName extends keyof EventTypes>(): EventName[]; setMaxListeners(n: number): any; getMaxListeners(): number; listeners<EventName extends keyof EventTypes>(event: EventName): (...args: EventArgs<EventTypes, EventName>) => void[]; listenerCount<EventName extends keyof EventTypes>(type: EventName): number; prependListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): any; prependOnceListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): any; }; addListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; on<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; once<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; removeListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; removeAllListeners<EventName extends keyof EventTypes>(event?: EventName | undefined): IEventEmitter<EventTypes>; emit<EventName extends keyof EventTypes>(event: EventName, ...args: EventArgs<EventTypes, EventName>): boolean; eventNames<EventName extends keyof EventTypes>(): EventName[]; setMaxListeners(n: number): IEventEmitter<EventTypes>; getMaxListeners(): number; listeners<EventName extends keyof EventTypes>(event: EventName): (...args: EventArgs<EventTypes, EventName>) => void[]; listenerCount<EventName extends keyof EventTypes>(type: EventName): number; prependListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; prependOnceListener<EventName extends keyof EventTypes>(event: EventName, listener: (...args: EventArgs<EventTypes, EventName>) => void): IEventEmitter<EventTypes>; }; export {}; //# sourceMappingURL=index.d.ts.map ``` This caused chaining method calls in my app not to work. **Playground Link:** N/A **Related Issues:** <!-- Did you find other bugs that looked similar? -->
Bug
low
Critical
393,632,675
TypeScript
Type inference of generics does not work only when callback takes argument
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> I encountered a strange behavior of type inference about the generic arguments and intersection type. The error described below occurs only when the `strictFunctionTypes` option is enabled. --- <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** Version 3.3.0-dev.20181221 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** - `strictFunctionTypes` - `argument intersection type` - `generic argument` - `generic intersection type` **Code** tsconfig.json: ```json { "compilerOptions": { "moduleResolution": "node", "target": "es6", "module":"commonjs", "strictFunctionTypes": true, "outDir": "dist" }, "include": ["*.ts"] } ``` source: ```ts const run = <P1, P2>( makeProps1: (s: string) => P1, makeProps2: () => P2, useBoth: (props: P1 & P2) => void ) => {}; const foo = (props: { n: number; b: boolean }) => {}; // This works as expected. run(() => ({ n: 1 }), () => ({ b: true }), foo); // But if the first argument function takes a parameter `s`, it results in a compile error. run(s => ({ n: 1 }), () => ({ b: true }), foo); ``` **Expected behavior:** The type of `run` is inferred correctly from `run(s => ({ n: 1 }), () => ({ b: true }), foo)` as below and the code compiles. ``` const run: <{ n: number; }, { b: boolean; }>(makeProps1: (s: string) => { n: number; }, makeProps2: () => { b: boolean; }, useBoth: (props: { n: number; } & { b: boolean; }) => void) => void ``` This type is generated from `run(() => ({ n: 1 }), () => ({ b: true }), foo)`. I copied it from Playground's tooltip. **Actual behavior:** It results in the compile error. output of `npx tsc`: ``` repro.ts:9:43 - error TS2345: Argument of type '(props: { n: number; b: boolean; }) => void' is not assignable to parameter of type '(props: { b: boolean; }) => void'. Types of parameters 'props' and 'props' are incompatible. Property 'n' is missing in type '{ b: boolean; }' but required in type '{ n: number; b: boolean; }'. 9 run(s => ({ n: 1 }), () => ({ b: true }), foo); ~~~ repro.ts:7:23 7 const foo = (props: { n: number; b: boolean }) => {}; ~ 'n' is declared here. Found 1 error. ``` This is because the return type of `makeProps1` is inferred as `{}` instead of `{ n: number; }`. ``` const run: <{}, { b: boolean; }>(makeProps1: (s: string) => {}, makeProps2: () => { b: boolean; }, useBoth: (props: { b: boolean; }) => void) => void ``` **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> [Here][playground]. Note that this problem occurs only when the `strictFunctionTypes` option is enabled. [playground]: http://www.typescriptlang.org/play/#src=const%20run%20%3D%20%3CP1%2C%20P2%3E(%0A%20%20makeProps1%3A%20(s%3A%20string)%20%3D%3E%20P1%2C%0A%20%20makeProps2%3A%20()%20%3D%3E%20P2%2C%0A%20%20useBoth%3A%20(props%3A%20P1%20%26%20P2)%20%3D%3E%20void%0A)%20%3D%3E%20%7B%7D%3B%0A%0Aconst%20foo%20%3D%20(props%3A%20%7B%20n%3A%20number%3B%20b%3A%20boolean%20%7D)%20%3D%3E%20%7B%7D%3B%0A%0Arun(s%20%3D%3E%20(%7B%20n%3A%201%20%7D)%2C%20()%20%3D%3E%20(%7B%20b%3A%20true%20%7D)%2C%20foo)%3B%0A **Related Issues:** <!-- Did you find other bugs that looked similar? --> I could not find. **Other Investigation**: In the code below, the type inference works as expected: ```typescript const run2 = <P1, P2>( makeProps1: (s: string) => P1, makeProps2: () => P2, useProps1: (p: P1) => void, useProps2: (p: P2) => void ) => {}; // The first argument function takes a parameter `s` but it does not change the type inference behavior. run2( s => ({ n: 1 }), () => ({ b: true }), (p1: { n: number }) => {}, (p2: { b: boolean }) => {} ); ``` So it seems that the error only occurs when the generic types (`P1`, `P2`) are used as intersection type.
Bug
low
Critical
393,652,542
TypeScript
output declaration type not as expect
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.3.0-dev.201xxxxx <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** **Code** im not sure whats wrong - node: v11.5.0 - ts: Version 3.3.0-dev.20181214 - [tsconfig.json](https://github.com/bluelovers/novel-travis-test/blob/master/tsconfig.json) [init.ts](https://github.com/bluelovers/novel-travis-test/blob/master/script/init.ts#L24) ```ts import { loadCacheConfig, loadMainConfig, loadConfig } from '@node-novel/task/lib/config'; export let CacheConfig = loadCacheConfig(PROJECT_ROOT); export let CLONE_DEPTH = process.env.CLONE_DEPTH || 50; ``` @node-novel/task/lib/config ```ts import { IConfig } from '../index'; export declare function loadMainConfig(cwd?: string): { config: IConfig; filepath: string; }; export declare function loadCacheConfig(cwd?: string): { config: { last: string | number; last_from?: string | number; done?: number; last_push_head?: string; }; filepath: string; }; export declare function transform(result: any): any; export declare function loadConfig<T>(name: string, options?: any): { config: T; filepath: string; }; export default loadConfig; ``` **Expected behavior:** init.d.ts ```ts export declare let CacheConfig: { config: { last: string | number; last_from?: string | number; done?: number; last_push_head?: string; }; filepath: string; }; export declare let CLONE_DEPTH: string | number; ``` **Actual behavior:** init.d.ts ```ts export declare let CacheConfig: { config: { last: import("node-novel-info").INumber; last_from?: import("node-novel-info").INumber; done?: number; last_push_head?: string; }; filepath: string; }; export declare let CLONE_DEPTH: import("node-novel-info").INumber; ``` **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> **Related Issues:** <!-- Did you find other bugs that looked similar? -->
Bug
low
Critical
393,661,163
javascript-algorithms
Provide use cases for the abstraction
I suppose this falls under a feature request.. I think there is a lot of great content here. However, honestly they would become far more valuable (to me, at least) if there were use cases detailed in the README.md of each algorithm.
enhancement
low
Minor
393,702,545
go
x/build/maintner: GitHub issue events are not consistent with API values
Moved from #28226… There are some issues that have events missing within the maintner corpus. This makes it impossible to create an accurate milestone burndown chart where you want to query for the state of an issue at a particular time window. A few examples of issues in maintner that have incomplete event lists: ``` === Issue events for golang.org/issues/28559 labeled milestone: label:Testing labeled milestone: label:help wanted labeled milestone: label:OS-OpenBSD labeled milestone: label:Builders labeled milestone: label:NeedsInvestigation milestoned milestone: Go1.12 label: ``` It does not record the final “closed” event: https://api.github.com/repos/golang/go/issues/28559/events ``` === Issue events for golang.org/issues/28306 mentioned milestone: label: subscribed milestone: label: mentioned milestone: label: subscribed milestone: label: assigned milestone: label: labeled milestone: label:Documentation labeled milestone: label:NeedsInvestigation milestoned milestone: Go1.12 label: renamed milestone: label: ``` The above event log is missing a few milestone-related events: https://api.github.com/repos/golang/go/issues/28306/events
help wanted,Builders,NeedsInvestigation
medium
Critical
393,710,084
TypeScript
Allow identifiers in types to resolve to unit-typed values
## Search Terms constant type literal, Cannot find name, type identifier, unit value ## Suggestion When declaring a constant like `const UNSPECIFIED = "UNSPECIFIED";`, I'd like the identifier `UNSPECIFIED` to be usable as a type (equivalent to the `"UNSPECIFIED"` literal type), just like how you can use `null`, string literals, and enum values as types. There are lots of workarounds and alternatives, but all of them have caused confusion or unease within my team, and I think it's possible to make this straightforward syntax work. As mentioned in https://github.com/Microsoft/TypeScript/issues/6151#issuecomment-165840507 , simply declaring `UNSPECIFIED` in the type namespace would be a breaking change, so my suggestion is to instead extend type name resolution to *look in the value namespace as a fallback*, which is backcompat. Here's my attempt at formalizing this behavior: * When resolving an identifier node in a type context, let `ID` be the identifier's name. * First search the type namespace for the name `ID`. If a type with that name exists, use it. * If no type matched, then search the value namespace to see a value exists with name `ID`. * If a value matched, determine the value's type. * If the type of `ID` is a unit type (string literal, enum value, etc), then treat this node as if it was written `typeof ID`. * If `ID`'s type is not a unit type, give the error message "Cannot use non-unit value ID as a type". * If no value matched, give the error message "Cannot find name ID". (I understand that there may be implementation roadblocks with this approach, just throwing it out there as a suggestion in case it is reasonable like I'm hoping.) Some related improvements that would also be nice: * Simply improving the error message from `Cannot find name "UNSPECIFIED"` to something like `"UNSPECIFIED" is a value, not a type"` would be really helpful. This is already filed as https://github.com/Microsoft/TypeScript/issues/27630 . It would be especially helpful if the error message pointed to an officially-recommended workaround. * In addition to changing identifier resolution, ideally more complex expressions could also be resolved in this way, particularly property accesses. In my example in https://github.com/Microsoft/TypeScript/issues/17592#issuecomment-449440944 , ideally `Events.Pause` would be usable as a type, and if it was, there would be a pattern for a "union enum" without special language support. It would also allow accessing constants from nested objects (as long as the constant has a literal type) and `import *` statements. You could even go so far as to say "any expresssion `E` is a shorthand for `typeof E`", though I think for complex expressions like function invocations, it could be confusing. This proposal requires the relevant values to have literal types, which is mostly true already. Some prior discussions and future suggestions around that: https://github.com/Microsoft/TypeScript/issues/6167, https://github.com/Microsoft/TypeScript/pull/10676, https://github.com/Microsoft/TypeScript/issues/26979 . ## Use Cases See the code snippets below for concrete use cases of literal types in general, though I imagine those are fairly well-understood. My team is in the process of everyone learning TypeScript and porting a large JavaScript codebase to TypeScript, and this has been one of the bigger issues we've run into. The general advice we've concluded on is "TypeScript doesn't handle constants as types very well; enums work a lot better". ### Current approaches and their shortcomings #### Use an enum Switching from enum-style constants to actual enums is helpful, but there are some shortcomings: * This requires changing all usages, including JS files using these constants. We prefer to keep emitted code changes to a minimum when porting JS to TS, and having to update all usages introduces risk. * It's awkward to make a one-value enum, like with the `UNSPECIFIED` example. We won't always want a list of choices, sometimes we just want a single special value that we can compare against. * Since enum values are always written as a property access, they're not as concise as constants. #### Use `typeof UNSPECIFIED` as the type For example, you could write `type MaybeFolder = Folder | typeof UNSPECIFIED`. This works, but has been confusing enough in practice that I think it's best to avoid, mostly because people feel that `typeof UNSPECIFIED` should be `string`. It generally has a feel of advanced/mysterious TypeScript trickery. It makes sense if you have deep knowledge of how TypeScript works, but it's not intuitive or clear. #### Explicitly define both a value and a type There are a few ways to write it, but here's one example: ```typescript export const UNSPECIFIED = "UNSPECIFIED"; export type UNSPECIFIED = typeof UNSPECIFIED; ``` This is nice in that it's self-contained, but it's doubly-confusing because not only does it use the `typeof` trick, it uses the surprising fact that you can export the same name twice, once in the value namespace and once in the type namespace. We're currently using this pattern for a small number of shared constants, but it seems awkward for people to write new instances of it. #### Always use a string literal type instead of a constant value Just using `"UNSPECIFIED"` as the type works out pretty well, but has some disadvantages: * It doesn't work as well with editor tooling like jump-to-definition. * It *feels* wrong/unsafe/ugly, especially to someone not as familiar with TypeScript. #### Use `null` In some cases, `null` can be used to denote an alternate value, e.g. `Folder | null`. This is concise, but makes the intentions less clear. ## Examples This can be used to concisely create a safer `null` variant: ```typescript interface Folder { name: string; } const NO_ACCESS = "NO_ACCESS"; function formatFolder(folder: Folder | NO_ACCESS): string { if (folder === NO_ACCESS) { return "(Insufficient permissions)" } else { return folder.name; } } ``` Similarly, it can be used to extend enums with ad-hoc values: ```typescript enum ColorOption { RED = "RED", GREEN = "GREEN", BLUE = "BLUE", } const UNSPECIFIED = "UNSPECIFIED"; interface ColorPickerUIState { colorChoice: ColorOption | UNSPECIFIED; } ``` It can also be used for enum-like use cases for legacy code that doesn't yet use enums: ```typescript const RED = "RED"; const GREEN = "GREEN"; const BLUE = "BLUE"; const ORANGE = "ORANGE"; const YELLOW = "YELLOW"; const PURPLE = "PURPLE"; type PrimaryColor = RED | GREEN | BLUE; ``` To demonstrate a few examples of name resolution: ```typescript const number = true; // "number" refers to plain number type, since type names always take precedence. const x: number = 3; type T1 = string; type T2 = string; function foo() { const T2 = "T2"; const T3 = "T3"; // Param type resolves to string | string | "T3". function f(val: T1 | T2 | T3) {} } ``` ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Critical
393,723,452
TypeScript
Void parameter still required when type extends generic
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.2.2 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** void parameter type extends generic **Code** ```ts function works1(n: number, b: void) { } works1(12); function works2(n: number, b: 1 extends 1 ? void : number) { } works2(12); function fails<T>(n: number, b: T extends 1 ? void : number) { } fails<2>(12, 2); // works, requires both params fails<1>(12); // fails, requires 2 parameters even though second param is void ``` **Expected behavior:** That I can ignore the second parameter since its void **Actual behavior:** Ts tells me I am missing a parameter https://www.typescriptlang.org/play/index.html#src=function%20works1(n%3A%20number%2C%20b%3A%20void)%20%7B%20%7D%0D%0A%0D%0Aworks1(12)%3B%0D%0A%0D%0Afunction%20works2(n%3A%20number%2C%20b%3A%201%20extends%201%3F%20void%20%3A%20number)%20%7B%20%7D%0D%0A%0D%0Aworks2(12)%3B%0D%0A%0D%0Afunction%20fails%3CT%3E(n%3A%20number%2C%20b%3A%20T%20extends%201%3Fvoid%3Anumber)%20%7B%20%7D%0D%0A%0D%0Afails%3C2%3E(12%2C2)%3B%20%20%2F%2Fworks%2C%20requires%20both%20params%0D%0Afails%3C1%3E(12)%3B%20%20%2F%2F%20requires%202%20parameters%20even%20though%20second%20param%20is%20void%0D%0A
Bug
medium
Critical
393,735,918
go
fmt: Fscan might not work on tracefs "id" files
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.11 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Use `fmt.Fscan` on a tracefs `id` file. For example `/sys/kernel/debug/tracing/events/tcp/tcp_set_state/id` ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/home/elazar/.cache/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/home/elazar/go" GOPROXY="" GORACE="" GOROOT="/usr/local/go" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" GCCGO="gccgo" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build929178475=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? https://play.golang.org/p/sKRnsBHZ6Gc ### What did you expect to see? The same event ID I see when `cat`ing the file. ### What did you see instead? Just the first digit, `1`. For the record "id" in tracefs is not implemented by `seq_file`: ```C static ssize_t event_id_read(struct file *filp, char __user *ubuf, size_t cnt, loff_t *ppos) { int id = (long)event_file_data(filp); char buf[32]; int len; // Elazar: This is probably the culprit. Can be removed, simple_read_from_buf handles it. if (*ppos) return 0; if (unlikely(!id)) return -ENODEV; len = sprintf(buf, "%d\n", id); return simple_read_from_buffer(ubuf, cnt, ppos, buf, len); } ``` Still relevant in `master` [branch](https://github.com/torvalds/linux/blob/master/kernel/trace/trace_events.c#L1315) It seems that `simple_read_from_buffer` somehow doesn't keep track of the `ppos`, though it should. For example ```C #include <stdio.h> #include <stdint.h> #include <sys/types.h> #include <sys/stat.h> #include <fcntl.h> #include <unistd.h> int main(int argc, char **argv) { if (argc < 2) return 1; int fd = open(argv[1], O_RDONLY); char c; read(fd, &c, 1); printf("Got %c\n", c); read(fd, &c, 1); printf("Got %c\n", c); } // output: // Got 1 // Got 1 ``` While this might be a kernel bug per se, one might consider a workaround, since it's pretty widespread.
NeedsInvestigation
low
Critical
393,740,519
rust
[idea] Add an option put the metadata in a separate file
# Detailed design When `-Zsplit-metadata` is passed to rustc, it will put the metadata normally inside a `rlib` or `dylib` in a separate `rmeta` file. The `rlib`/`dylib` will contain the SVH to prevent accidentally mixing the `rmeta` and `rlib`/`dylib` of different compilations. # Advantages This would make the increase in size of #56987 easily fixable by deleting the `rlib` files, while keeping the `rmeta` files. Those are not necessary anyway, because `rustc_driver.so` already contains the code. This will decrease `staticlib`, `dylib` and `cdylib` compilation time, because there is no need to copy all object files to a new archive to remove the `rust.metadata.bin` file from the `rlib`. https://github.com/rust-lang/rust/blob/6d9640b6f6275a4b59e2a59705e18807329b9300/src/librustc_codegen_llvm/back/link.rs#L1340-L1342 # Disadvantages Rustc and cargo get a bit more complex.
A-metadata,T-compiler,C-feature-request
low
Major
393,742,652
go
x/text: support error and fmt.Stringer values
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.11.4 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Yes, this is the latest release ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/Users/fgm/Library/Caches/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/fgm/src/go" GOPROXY="" GORACE="" GOROOT="/usr/local/go" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GCCGO="gccgo" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/0g/p780bc554njc4qj110_8rmbr0000gn/T/go-build831580697=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? - Tried to produce translated custom errors. - https://play.golang.org/p/liw_jlauDmw (won't run on playground because of imports) ### What did you expect to see? - string values for `err` are extracted and translations running displays the error in french. ### What did you see instead? - "panic: key argument is not a Reference" ### Diagnostic This happens because `message.lookupAndFormat()` can only handle plain strings and message.key (unexported type) as translation keys. It would make it easier to have translatable errors and other higher-level data if the switch handled `error` and `fmt.Stringer` values. - Values of type `error` could be converted to strings using their `Error()` method, and thereafter handled as strings (`id, mgs = v, v`) - Values implementing `fmt.Stringer` could be converted to strings using their `String()` method, and handled the same way.
NeedsDecision,FeatureRequest
low
Critical
393,747,605
TypeScript
Accessing protected properties with `this` argument specifier differs with interface
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.2.2 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** function this parameter class interface protected property **Code** ```ts abstract class Test { constructor(protected foo: string) {} public abstract trace(): string; } function TraceA(this: Test): string { return `${this.foo}`; } function TraceB(this: Test): string { return `<pre>${this.foo}</pre>`; } function getTestInstance(strategy: 'A' | 'B') { return class StrategyTest extends Test { public trace = strategy === 'A' ? TraceA : TraceB; } } ``` ```ts abstract class TestInterface<P> { constructor(protected foo: P) {} public abstract trace(): string; } function TraceInterfaceA<P>(this: TestInterface<P>): string { return `${this.foo}`; // Property 'foo' is protected and only accessible through an instance of class 'TestInterface<P>'.ts(2446) } function TraceInterfaceB<P>(this: TestInterface<P>): string { return `<pre>${this.foo}</pre>`; // Property 'foo' is protected and only accessible through an instance of class 'TestInterface<P>'.ts(2446) } function getTestInterfaceInstance(strategy: 'A' | 'B') { return class StrategyTestInterface<P> extends TestInterface<P> { public trace = strategy === 'A' ? TraceA : TraceB; } } ``` **Expected behavior:** If I'm not wrong, with `this` argument on `Function`, we allow only to access to public attributes, don't we? So we are supposed to get an error on the `Test` class implementation. Or if the latest decision is to allow access to protected attributes, so we aren't supposed to received an error in the `TestInterface` example. **Actual behavior:** Without the interface, we can access to protected attributes, but when an interface is provided to the generic Class definition, we lose the ability to reach protected properties. **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> [TSPlayground](https://www.typescriptlang.org/play/#src=abstract%20class%20Test%20%7B%0D%0A%20%20%20%20constructor(protected%20foo%3A%20string)%20%7B%7D%0D%0A%20%20%20%20public%20abstract%20trace()%3A%20string%3B%0D%0A%7D%0D%0A%0D%0Afunction%20TraceA(this%3A%20Test)%3A%20string%20%7B%0D%0A%20%20%20%20return%20%60%24%7Bthis.foo%7D%60%3B%0D%0A%7D%0D%0A%0D%0Afunction%20TraceB(this%3A%20Test)%3A%20string%20%7B%0D%0A%20%20%20%20return%20%60%3Cpre%3E%24%7Bthis.foo%7D%3C%2Fpre%3E%60%3B%0D%0A%7D%0D%0A%0D%0Afunction%20getTestInstance(strategy%3A%20'A'%20%7C%20'B')%20%7B%0D%0A%20%20%20%20return%20class%20StrategyTest%20extends%20Test%20%7B%0D%0A%20%20%20%20%20%20%20%20public%20trace%20%3D%20strategy%20%3D%3D%3D%20'A'%20%3F%20TraceA%20%3A%20TraceB%3B%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A%0D%0A%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%2F%0D%0A%0D%0Aabstract%20class%20TestInterface%3CP%3E%20%7B%0D%0A%20%20%20%20constructor(protected%20foo%3A%20P)%20%7B%7D%0D%0A%20%20%20%20public%20abstract%20trace()%3A%20string%3B%0D%0A%7D%0D%0A%0D%0Afunction%20TraceInterfaceA%3CP%3E(this%3A%20TestInterface%3CP%3E)%3A%20string%20%7B%0D%0A%20%20%20%20return%20%60%24%7Bthis.foo%7D%60%3B%0D%0A%7D%0D%0A%0D%0Afunction%20TraceInterfaceB%3CP%3E(this%3A%20TestInterface%3CP%3E)%3A%20string%20%7B%0D%0A%20%20%20%20return%20%60%3Cpre%3E%24%7Bthis.foo%7D%3C%2Fpre%3E%60%3B%0D%0A%7D%0D%0A%0D%0Afunction%20getTestInterfaceInstance(strategy%3A%20'A'%20%7C%20'B')%20%7B%0D%0A%20%20%20%20return%20class%20StrategyTestInterface%3CP%3E%20extends%20TestInterface%3CP%3E%20%7B%0D%0A%20%20%20%20%20%20%20%20public%20trace%20%3D%20strategy%20%3D%3D%3D%20'A'%20%3F%20TraceA%20%3A%20TraceB%3B%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A) **Related Issues:** <!-- Did you find other bugs that looked similar? --> #12510 Cannot access protected members when specifying 'this' type #17694 Accessing private method with `this` argument specifier
Bug
low
Critical
393,754,506
flutter
Feature Request: Show/hide splashscreen in dart
When launching my Flutter application, the splashscreen is shown. After the first Flutter frame is rendered, the splashscreen will be hidden and the Flutter view will be loaded and shown. However during loading the Flutter view it needs some time to store a big asset image in the image cache. The asset image is actually the same as the splashscreen image, but now as background image loaded from the assets folder. I can preload this image like this: ```dart preloadBackground() async { final ImageConfiguration config = createLocalImageConfiguration(context); Image image = Image.asset('assets/background.jpg'); Completer<ui.Image> completer = new Completer<ui.Image>(); image.image.resolve(config).addListener((ImageInfo info, bool _) { completer.complete(info.image); }); await completer.future; } ``` However it needs the BuildContext for this, and once we can pass the buildContext it also renders the page. So it shows a white screen for some seconds even with preloading. I also tried lowering the resolution of the background image, but then you can see a big quality difference between the splashscreen and the AssetImage. This is just an example but I can image other useful scenarios, for example if you want to preload images or data from the internet before the Flutter view is shown. So it would be great if we can show/hide the splash screen after launching the flutter application, like in Cordova: `navigator.splashscreen.show();` `navigator.splashscreen.hide();` And then we also need a settings like: ``` <meta-data android:name="io.flutter.app.android.HideSplashScreenAfterFirstFrame" android:value="false" /> ``` And the equivalent setting in the plist file for iOS. What do you guys think?
c: new feature,framework,engine,P2,team-engine,triaged-engine
low
Major
393,782,326
TypeScript
Missing 'used before declaration' error with IIFE
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.2.1 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** **Code** ```ts class C { a = (() => this.b)(); b = ''; } ``` **Expected behavior:** Error `Property 'b' is used before its initialization.` Control flow analysis inlines IIFEs, but it seems the use-before-declare check doesn't. **Actual behavior:** No error **Playground Link:** https://agentcooper.github.io/typescript-play/#code/MYGwhgzhAEDC0G8BQ1XTNAvNAFDglFgHzQAuAFgJYQB0ARvgQNwpp1bQDknLAvkA **Related Issues:** Found while investigating https://github.com/Microsoft/TypeScript/issues/29125
Suggestion,In Discussion
low
Critical