url
stringlengths 79
94
| original_message
stringlengths 5
2.73k
| message
stringlengths 0
2.61k
| original_label
stringclasses 4
values | is_good
bool 2
classes | is_bad
bool 2
classes | binary_label
float64 0
1
⌀ |
|---|---|---|---|---|---|---|
https://github.com/square/okhttp/commit/743a260b2ad8fa9830a953710dca53ea7525151b | Migrate Logging tests to Junit5 (#6355) | Migrate Logging tests to Junit5 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/eba8a830929c2a696c48e702a0e22766ed9ab516 | Enable GitHub Code Security Scanning (#1) (#6304)
Add codeql-analysis.yml to configure GitHub workflow for code security scanning. Added Setup Java action to override default Java 8. | Enable GitHub Code Security Scanning (#1)
Add codeql-analysis.yml to configure GitHub workflow for code security scanning. Added Setup Java action to override default Java 8. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/2fd0da8bc4a9c9d61b93af83b87383eacba850a3 | Update concurrency.md (#6290) | Update concurrency.md | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/45a79c9c8572eb6c7273bcceb359773386a3fb2c | Android 11 (#6286) | Android 11 | No What | false | true | 0 |
https://github.com/square/okhttp/commit/8c2f383f14e354a45d0f9f16f5b0fa35b7244a51 | Document interceptor throwing modes (#6235) | Document interceptor throwing modes | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/0e0f3a2d8d95278bf362eaeb08f13516e383fafd | Push OkHttp 3.14.x into the sea. It is no longer supported. (#6179)
OkHttp 4.x is our only branch receiving security fixes, bug fixes, and
new features.
OkHttp 3.12.x gets security fixes only. | Push OkHttp 3.14.x into the sea. It is no longer supported.
OkHttp 4.x is our only branch receiving security fixes, bug fixes, and
new features.
OkHttp 3.12.x gets security fixes only. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/e736f927f82bcde9490b0e195f89d0a8884ba68b | DER encoder (#6139)
I haven't yet implemented certificate encoding | DER encoder
I haven't yet implemented certificate encoding | Why and What | false | false | null |
https://github.com/square/okhttp/commit/370ebcffe67ef552e30e866bd622da5291a6f5b3 | Prepare next development version. | Prepare next development version. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/ef7c5f358e2ac8dad806952c70c7af9061a6f7af | Prepare for release 4.7.0. | Prepare for release 4.7.0. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/e2809002b94e1db3fa0e2ad0ca75c4c1e4a19d23 | Document auth retries function (#6031)
* Document auth retries function
* Update Authenticator.kt | Document auth retries function
* Document auth retries function
* Update Authenticator.kt | Why and What | false | false | null |
https://github.com/square/okhttp/commit/8cebf9012bbdfdbad6b833effc545ff5b8b8e48b | Cache Events (#6015)
Provide EventListener methods to understand the impact of caching. | Cache Events
Provide EventListener methods to understand the impact of caching. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/93ac4fa3b956e8747347fa36e394d40500883d7e | Android Cache Test (#6010) | Android Cache Test | Why and What | false | false | null |
https://github.com/square/okhttp/commit/5c10006e0a0299ff39ad2e5ee425057b20644afd | Centralise logging behind JUL (#6005)
Use JUL, but wire up to the Android Log.
Use `adb shell setprop log.tag.okhttp.Http2 DEBUG` to enable logging for known levels. | Centralise logging behind JUL
Use JUL, but wire up to the Android Log.
Use `adb shell setprop log.tag.okhttp.Http2 DEBUG` to enable logging for known levels. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/8036ad42b0bb7bdc18c0dc12438fdbba7aa7f255 | Check in the old public suffix DB | Check in the old public suffix DB | No Why | false | false | null |
https://github.com/square/okhttp/commit/d56eb776e55f4ad531730c396a38902b24c5ee52 | Android docs for selecting devices | Android docs for selecting devices | Why and What | false | false | null |
https://github.com/square/okhttp/commit/bc3c787ea2df854ac399603d5c67111716137d31 | Refactor Jdk9PlatformTest by using DelegatingSSLSocket
Cont. https://github.com/square/okhttp/pull/5972
We can use DelegatingSSLSocket instead of overriding SSLSocket abstract class. | Refactor Jdk9PlatformTest by using DelegatingSSLSocket
Cont. https://github.com/square/okhttp/pull/5972
We can use DelegatingSSLSocket instead of overriding SSLSocket abstract class. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/ba5d3e278b027ee7a2cb741a1bec3646f9d11e16 | Migrate from Travis to GitHub Action for publishing | Migrate from Travis to GitHub Action for publishing | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/d9c8fbf3b273fe25aad0cd41f053547c1ed1b557 | Confirm MockWebServer shutdown is idempotent (#5946) | Confirm MockWebServer shutdown is idempotent | No What | false | false | null |
https://github.com/square/okhttp/commit/02052b01f6cd1533dd5490ceb61ab6391c4cf2f8 | Convert DiskLruCacheTest to Kotlin (#5933)
* Rename DiskLruCacheTest.java to DiskLruCacheTest.kt
* Convert DiskLruCacheTest to Kotlin | Convert DiskLruCacheTest to Kotlin
* Rename DiskLruCacheTest.java to DiskLruCacheTest.kt
* Convert DiskLruCacheTest to Kotlin | Why and What | false | false | null |
https://github.com/square/okhttp/commit/1a07f49bcb32ba1dd100833c5c539c7cbd58ffa5 | Kotlin 1.3.71 and misc dep upgrades (#5925) | Kotlin 1.3.71 and misc dep upgrades | Why and What | false | false | null |
https://github.com/square/okhttp/commit/0ea6ca0faae126db31fa81462b8ff7a0f64f387c | Allowlist Sample for connecting to Dev servers (#5868) | Allowlist Sample for connecting to Dev servers | Why and What | false | false | null |
https://github.com/square/okhttp/commit/08e23fcd02ccbd453b2037128b66f57bc7c8f1d2 | Add a canceled event to EventListener | Add a canceled event to EventListener | No Why | false | false | null |
https://github.com/square/okhttp/commit/5ba145aa6c737878281c3fc655657002320b71c0 | Limit recovery attempts for REFUSED_STREAM errors
We limit per-connection retries but not per-call retries, so this was
creating large numbers of connections each of which called the server
and accepted yet another REFUSED_STREAM.
Instead we fail sooner with a StreamResetException.
This shows that the ExchangeFinder interface is still somewhat inadequate
to support all of the use cases we have. | Limit recovery attempts for REFUSED_STREAM errors
We limit per-connection retries but not per-call retries, so this was
creating large numbers of connections each of which called the server
and accepted yet another REFUSED_STREAM.
Instead we fail sooner with a StreamResetException.
This shows that the ExchangeFinder interface is still somewhat inadequate
to support all of the use cases we have. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/82f773376e19bb7e10916627349fad06e45f90cb | Add HTTP/2 and TLSv1.3 columns to our security providers doc | Add HTTP/2 and TLSv1.3 columns to our security providers doc | Why and What | false | false | null |
https://github.com/square/okhttp/commit/7c4c8c724dd8e05c4907c46309d0290dc44764fb | Use Checkstyle's built-in Google style
The boilerplate to set this up is unfortunate. | Use Checkstyle's built-in Google style
The boilerplate to set this up is unfortunate. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/ed9af27531b02f5ef334b7d606ef35c66f541958 | Android 10 support for X509TrustManager (#5688) | Android 10 support for X509TrustManager | Why and What | false | false | null |
https://github.com/square/okhttp/commit/3e61ce3cf09e8ff2723ea70390ce0132f72bf14a | Test Android with Play provider (#5679) | Test Android with Play provider | Why and What | false | false | null |
https://github.com/square/okhttp/commit/96e596117e25d108bf9b96ad2899d3610f9915a0 | Use our test rule instead of the Maven Surefire listener
Closes: https://github.com/square/okhttp/issues/4894 | Use our test rule instead of the Maven Surefire listener
Closes: https://github.com/square/okhttp/issues/4894 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/20cd3a08935c78c75dae015964608b2c233d629d | Increase severity of bridge methods to ERROR. (#5160)
Delete the KotlinSourceCompatibilityTest. It has served its purpose. | Increase severity of bridge methods to ERROR.
Delete the KotlinSourceCompatibilityTest. It has served its purpose. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/b2460b7bffca38d908607262c84b963ff36f9693 | OkHttp 4 upgrade guide | OkHttp 4 upgrade guide | Why and What | false | false | null |
https://github.com/square/okhttp/commit/b5efb41a636154cb8bbc7c5ea3c8244090692d28 | Degrade connections after a timeout
This is based roughly on the 'Degraded Connections' proposal here
https://github.com/square/okhttp/issues/3146#issuecomment-471196032
I'm using 1000 ms instead of 500 ms. That's about the cost of a (slow)
TLS handshake, which is what callers would need to do if we degrade
unnecessarily. | Degrade connections after a timeout
This is based roughly on the 'Degraded Connections' proposal here
https://github.com/square/okhttp/issues/3146#issuecomment-471196032
I'm using 1000 ms instead of 500 ms. That's about the cost of a (slow)
TLS handshake, which is what callers would need to do if we degrade
unnecessarily. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/0827fc62da61fce5cf7bedb088575fe41573b39d | Update Headers factories to be idiomatic Kotlin | Update Headers factories to be idiomatic Kotlin | No Why | false | false | null |
https://github.com/square/okhttp/commit/a0a3ef543cd5bf199878e14e34b2167e6cf9c575 | Beef up Request's toString
Previously it unconditionally showed tags even if empty and would not show headers. | Beef up Request's toString
Previously it unconditionally showed tags even if empty and would not show headers. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/96eb1111eb17553931fb55d86f21bb7fa4fccfa6 | Implement date formatting and parsing as extensions (#5134) | Implement date formatting and parsing as extensions | Why and What | false | false | null |
https://github.com/square/okhttp/commit/df572ee9fda255b083e5ad0414b8cdd331d07254 | Convert hex digit parser to extension function | Convert hex digit parser to extension function | No Why | false | false | null |
https://github.com/square/okhttp/commit/0137eb9dbad165caea7189c5c3e09382563ef8bd | Remove unnecessary use of grouping parentheses
Let's remove warnings found by errorprone.
- attempt
```
okhttp/okhttp/src/test/java/okhttp3/CallTest.java:2056: warning: [UnnecessaryParentheses] Unnecessary use of grouping parentheses
sink.writeUtf8('attempt ' + (attempt++));
^
(see https://errorprone.info/bugpattern/UnnecessaryParentheses)
Did you mean 'sink.writeUtf8('attempt ' + attempt++);'?
```
- isEaualTo
```
okhttp/src/test/java/okhttp3/OkHttpClientTest.java:287: warning: [UnnecessaryParentheses] Unnecessary use of grouping parentheses
assertThat(expected.getMessage()).isEqualTo(('protocols must not contain null'));
^
(see https://errorprone.info/bugpattern/UnnecessaryParentheses)
``` | Remove unnecessary use of grouping parentheses
Let's remove warnings found by errorprone.
- attempt
```
okhttp/okhttp/src/test/java/okhttp3/CallTest.java:2056: warning: [UnnecessaryParentheses] Unnecessary use of grouping parentheses
sink.writeUtf8('attempt ' + (attempt++));
^
(see https://errorprone.info/bugpattern/UnnecessaryParentheses)
Did you mean 'sink.writeUtf8('attempt ' + attempt++);'?
```
- isEaualTo
```
okhttp/src/test/java/okhttp3/OkHttpClientTest.java:287: warning: [UnnecessaryParentheses] Unnecessary use of grouping parentheses
assertThat(expected.getMessage()).isEqualTo(('protocols must not contain null'));
^
(see https://errorprone.info/bugpattern/UnnecessaryParentheses)
``` | Why and What | false | false | null |
https://github.com/square/okhttp/commit/620be4c97baf5d20cb21c55a11a6191b2511f1ce | Use TaskRunner in MockWebServer
The utility here is negligible. We're sharing threads between HTTP,
HTTP/2 and web sockets now. | Use TaskRunner in MockWebServer
The utility here is negligible. We're sharing threads between HTTP,
HTTP/2 and web sockets now. | No Why | false | false | null |
https://github.com/square/okhttp/commit/460ee26ff69be9d70f24d2918f417f3faed9559f | Idiomatic Kotlin for Multipart | Idiomatic Kotlin for Multipart | Neither Why nor What | false | false | null |
https://github.com/square/okhttp/commit/b3027a52edfe25824ca96a4eaab3dfc08b622016 | Replace Math.min() with minOf (#5071)
* Replace Math.min() with minOf
* Fix | Replace Math.min() with minOf
* Replace Math.min() with minOf
* Fix | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/53e0f9e7fb39f7babd6388a7a56e9c7e827667e7 | Adopt idiomatic Kotlin in Headers | Adopt idiomatic Kotlin in Headers | No Why | false | false | null |
https://github.com/square/okhttp/commit/5fbf7cccd19c6f144a59cc2487e8a93636ecac0c | Cancel calls on unexpected exceptions
Closes: https://github.com/square/okhttp/issues/5151 | Cancel calls on unexpected exceptions
Closes: https://github.com/square/okhttp/issues/5151 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/e3e829d2060542d50f33d1a9864f7ace82c9db5c | API change: Make OkHttpClient accessors final
If we want these to be vals to Kotlin, they can't be open. I think the
motivation to make these non-final was pretty weak, and I don't mind
breaking API compatibility here. | API change: Make OkHttpClient accessors final
If we want these to be vals to Kotlin, they can't be open. I think the
motivation to make these non-final was pretty weak, and I don't mind
breaking API compatibility here. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/a2716d984bdf0930657aebb08c2b12c565130de3 | Fix master build (#5477) | Fix master build | No What | false | true | 0 |
https://github.com/square/okhttp/commit/58a0a363d0c5f7a7c2fb6736bf96b459f40d39c5 | Convert MockWebServer to Kotlin | Convert MockWebServer to Kotlin | No Why | false | false | null |
https://github.com/square/okhttp/commit/a1265b6140a8fe336602b969960d4048ebd1d3da | Fix a regression in combining cache headers
This was introduced with our migration to Kotlin. Iterating over the indices
of the header names doesn't work because header names are not distinct.
Closes: https://github.com/square/okhttp/issues/5413 | Fix a regression in combining cache headers
This was introduced with our migration to Kotlin. Iterating over the indices
of the header names doesn't work because header names are not distinct.
Closes: https://github.com/square/okhttp/issues/5413 | No What | false | false | null |
https://github.com/square/okhttp/commit/f9d92d47f8b02d5cac75023410bf06c9fd67c3ab | 3.12.3 backports some bug fixes | 3.12.3 backports some bug fixes | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/99b83a3b20e6fe22b6ea587599fde1423056af2d | Include prerequisites in the releasing guide.
https://github.com/cashapp/barber/blob/master/docs/releasing.md | Include prerequisites in the releasing guide.
https://github.com/cashapp/barber/blob/master/docs/releasing.md | No Why | false | false | null |
https://github.com/square/okhttp/commit/bc6776c751b4cd93551a2a20f56429bb78296829 | Convert Http2Connection to Kotlin (#5014)
* Rename Http2Connection to .kt
* Convert Http2Connection to Kotlin | Convert Http2Connection to Kotlin
* Rename Http2Connection to .kt
* Convert Http2Connection to Kotlin | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/2d75be404a6c5371faded5dcdcadd26f64199e0a | Convert HttpDate to Kotlin (#5000)
* Convert HttpDate to Kotlin
* Idiomatic Kotlin
* Revert back to if condition | Convert HttpDate to Kotlin
* Convert HttpDate to Kotlin
* Idiomatic Kotlin
* Revert back to if condition | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/1e386df1fe6293d1d00ce8a8cc98e75e1bf2d858 | Convert RetryAndFollowUpInterceptor to Kotlin
Update RetryAndFollowUpInterceptor.kt | Convert RetryAndFollowUpInterceptor to Kotlin
Update RetryAndFollowUpInterceptor.kt | No Why | false | false | null |
https://github.com/square/okhttp/commit/23ca0ea3bb33706f8e75412ab7d3ce1faa15a1d6 | Convert Http2Reader, Http2Writer to Kotlin (#4982)
* Rename Http2.java to .kt (and others)
* Convert Http2Reader, Http2Writer to Kotlin | Convert Http2Reader, Http2Writer to Kotlin
* Rename Http2.java to .kt (and others)
* Convert Http2Reader, Http2Writer to Kotlin | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/2a1f328d58de8d12861cdcf4be1c9f8902687e8d | Add proxy event logging (#5300) | Add proxy event logging | Why and What | false | false | null |
https://github.com/square/okhttp/commit/7292e54a63733493553a98184080c90168370399 | Update the changelog for OkHttp 4.0.1 | Update the changelog for OkHttp 4.0.1 | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/930d4d07d836aef3c2681867d6ab9e73c23aacfb | Passing conscrypt test (#5270) | Passing conscrypt test | No What | false | false | null |
https://github.com/square/okhttp/commit/bdd6c3944f239d74d8b1288d8c50351fcc76d1ea | Testing with JDK 12 and latest 11.0.3 (#5212)
JDK 12 and be more specific about when we expect failures, e.g. 11.0.3 has fixes we should take into account. | Testing with JDK 12 and latest 11.0.3
JDK 12 and be more specific about when we expect failures, e.g. 11.0.3 has fixes we should take into account. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/675cb843cee2ca2579e9f49d777e7fa1c14b2f6f | Tolerate null-hostile lists in public API | Tolerate null-hostile lists in public API | No Why | true | false | 1 |
https://github.com/square/okhttp/commit/c6c7ce7dadf2ccaa04122f57a278a4a96d1f5c50 | DiskLruCache snapshot() method removing entries that are being cached (#3905)
Fixed a bug I found.
When using DiskLruCache, hasNext() method of Iterator<Snapshot> returned by snapshot() method iterates through lruEntries, however if entry is not completed yet, it is removed (together with dirtyFiles) as cleanFiles don't exist yet - during saving response to disk. This caused sometimes file not being cached at all. | DiskLruCache snapshot() method removing entries that are being cached
Fixed a bug I found.
When using DiskLruCache, hasNext() method of Iterator<Snapshot> returned by snapshot() method iterates through lruEntries, however if entry is not completed yet, it is removed (together with dirtyFiles) as cleanFiles don't exist yet - during saving response to disk. This caused sometimes file not being cached at all. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/18f2b5e6e69de28f420298862378abfd243096ce | Fix source compatibility for some Kotlin callsites. (#4887)
We had a problem where boolean vals needed to be reverted back to
boolean funs. I'd like to go back to vals later, but supporting existing
source patterns is more important.
We also had a problem where single abstract method types (SAM types)
could be supplied as lambas when calling into Java but not when calling
into Kotlin.
I found these by pointing KotlinSourceCompatibilityTest at the OkHttp
Get there like this:
git co 7eb897ab2e223632b3316bf46a15d37307a3d3b6^
git co 7eb897ab2e223632b3316bf46a15d37307a3d3b6 okhttp/build.gradle
git co 7eb897ab2e223632b3316bf46a15d37307a3d3b6 build.gradle | Fix source compatibility for some Kotlin callsites.
We had a problem where boolean vals needed to be reverted back to
boolean funs. I'd like to go back to vals later, but supporting existing
source patterns is more important.
We also had a problem where single abstract method types (SAM types)
could be supplied as lambas when calling into Java but not when calling
into Kotlin.
I found these by pointing KotlinSourceCompatibilityTest at the OkHttp
Get there like this:
git co 7eb897ab2e223632b3316bf46a15d37307a3d3b6^
git co 7eb897ab2e223632b3316bf46a15d37307a3d3b6 okhttp/build.gradle
git co 7eb897ab2e223632b3316bf46a15d37307a3d3b6 build.gradle | Why and What | false | false | null |
https://github.com/square/okhttp/commit/eae6f32101a5be6bf20621b7765791d32cb70f09 | Fix correctness of WebSocketReader reserved flags test | Fix correctness of WebSocketReader reserved flags test | No What | true | false | 1 |
https://github.com/square/okhttp/commit/008c7834929e8ec91ea8144ac9a30c9fb06e0636 | Run cron schedule in circleci (#4862) | Run cron schedule in circleci | Why and What | false | false | null |
https://github.com/square/okhttp/commit/489c92400f579bace0950c910de2dca03959785e | Revise the upgrading guide for OkHttp 4.x.
Also change the old OkHttp 3.x Javadoc to set the new docs as canonical.
https://publicobject.com/2017/02/14/canonical-urls-for-javadocs/ | Revise the upgrading guide for OkHttp 4.x.
Also change the old OkHttp 3.x Javadoc to set the new docs as canonical.
https://publicobject.com/2017/02/14/canonical-urls-for-javadocs/ | Why and What | false | false | null |
https://github.com/square/okhttp/commit/5569a0d20f4669ddde8227d8777de54ddf373181 | Remove obsolete @JvmField | Remove obsolete @JvmField | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/8603e2d20e4335a7a530f90a2f6439d16b8767de | Prepare for release 4.0.0-RC2. | Prepare for release 4.0.0-RC2. | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/e7a704a1cea504d293eec9c93cf4dcaa4ec376f3 | Update javadoc | Update javadoc | No Why | false | true | 0 |
https://github.com/square/okhttp/commit/4fb3842fe87eb11a1d75b7577e69603ff63cfb4e | Convert CertificatePinner to a data class | Convert CertificatePinner to a data class | No Why | false | false | null |
https://github.com/square/okhttp/commit/0e9a5c8054f8ae9b2bc4c41f32790fb52fd73944 | Make error-prone validate missing override annotations | Make error-prone validate missing override annotations | No Why | true | false | 1 |
https://github.com/square/okhttp/commit/e8b271e69a0449d1859de21c6a098e1db1c36e9a | Save reports (#4821) | Save reports | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/a7603602ca8b58c5a32117f03189d6d6a7c8e7be | add @overide for subclass override method | add @overide for subclass override method | No Why | false | false | null |
https://github.com/square/okhttp/commit/967635662ab7b853508872c743629249cec2bb0c | Clean up Address.kt | Clean up Address.kt | Why and What | false | false | null |
https://github.com/square/okhttp/commit/422458316520e5d4e86dad88d8a40359a40bf3f0 | Revert 'Measure time'
This reverts commit 853a80d3ff56facc18ed3efcec32fcc9eb959dc9. | Revert 'Measure time'
This reverts commit 853a80d3ff56facc18ed3efcec32fcc9eb959dc9. | No Why | false | false | null |
https://github.com/square/okhttp/commit/87bfe81744b407ddba3b6fc154949204af546ea5 | Fix flaky DuplexTest.duplexWithRedirect
The test is flaky because the server sometimes acts on the 301 response and resets the stream before the action added by MockDuplexResponseBody.sendResponse() is executed. This action then fails because it tries to write to a reset stream. mockDuplexResponseBody.awaitSuccess() then throws and fails the test.
The change enforces the de-facto sequence on most runs, where the 301 response is handled only after the Duplex response is sent.
Fixes https://github.com/square/okhttp/issues/4743 | Fix flaky DuplexTest.duplexWithRedirect
The test is flaky because the server sometimes acts on the 301 response and resets the stream before the action added by MockDuplexResponseBody.sendResponse() is executed. This action then fails because it tries to write to a reset stream. mockDuplexResponseBody.awaitSuccess() then throws and fails the test.
The change enforces the de-facto sequence on most runs, where the 301 response is handled only after the Duplex response is sent.
Fixes https://github.com/square/okhttp/issues/4743 | No What | true | false | 1 |
https://github.com/square/okhttp/commit/d04b9b0cca894c7aef4c52d77e3f599bd6ef612e | Skip hpack if tests are missing (#4770) | Skip hpack if tests are missing | Why and What | false | false | null |
https://github.com/square/okhttp/commit/8512256dff756888fc967f1763c3d882c892edda | change var to val, readonly is better | change var to val, readonly is better | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/43f93d014c6cf42847ba88fe67dc2d7237bbfb4b | Fix flaky testRfc2109Response()
The time delta in the cookie max-age is rounded down, so is at most 59 seconds. Possibly a GC or some other hiccup can occasionally make it lower, so allow some room for error.
Fixes https://github.com/square/okhttp/issues/4733. | Fix flaky testRfc2109Response()
The time delta in the cookie max-age is rounded down, so is at most 59 seconds. Possibly a GC or some other hiccup can occasionally make it lower, so allow some room for error.
Fixes https://github.com/square/okhttp/issues/4733. | No What | false | false | null |
https://github.com/square/okhttp/commit/7fa3f9fc49b9e526fcc0168bf7ee082c29956359 | Configure travis caching for gradle. | Configure travis caching for gradle. | No Why | false | false | null |
https://github.com/square/okhttp/commit/e7a04f92a2f5d1fa13866b333dada999c3c11fd8 | Release websocket transmitter before failing response #4695 | Release websocket transmitter before failing response #4695 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/59e68cd2bcba789e7faca70f8910afd2edeed2be | Introduce Exchange.
This is the payoff that preceding changes have been working towards.
This splits StreamAllocation into three parts:
- ExchangeFinder: strategy to allocate connections for exchanges
- Exchange: a single request/response pair
- Transmitter: a sequence of exchanges for a Call
The refactoring isn't totally complete, but this should be the last
big one.
https://github.com/square/okhttp/issues/4603 | Introduce Exchange.
This is the payoff that preceding changes have been working towards.
This splits StreamAllocation into three parts:
- ExchangeFinder: strategy to allocate connections for exchanges
- Exchange: a single request/response pair
- Transmitter: a sequence of exchanges for a Call
The refactoring isn't totally complete, but this should be the last
big one.
https://github.com/square/okhttp/issues/4603 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/aac6c8da0720c53ccd8aa8385f8f250f78a7b61c | Introduce EventListener.requestFailed, responseFailed events
These replace requestBodyEnd() / responseBodyEnd() in some failure scenarios.
They may also be issued in cases where no event was published previously. | Introduce EventListener.requestFailed, responseFailed events
These replace requestBodyEnd() / responseBodyEnd() in some failure scenarios.
They may also be issued in cases where no event was published previously. | No Why | false | false | null |
https://github.com/square/okhttp/commit/512f3528daf902fb74ad0e128420763cb91bdd35 | Jdk8WithJettyBootPlatform - load through bootstrap | Jdk8WithJettyBootPlatform - load through bootstrap | No Why | false | true | 0 |
https://github.com/square/okhttp/commit/652f3a1d36298f15677a7eda7838fa5c04d6016b | HTTP/1 >> HTTP1 | HTTP/1 >> HTTP1 | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/c8b1ee602bcd1541dd3f9eebb72aef08338f6224 | Support follow-ups for duplex requests.
https://github.com/square/okhttp/issues/4267 | Support follow-ups for duplex requests.
https://github.com/square/okhttp/issues/4267 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/2594c6c695f2898bba947ea86a7aaac8dcfd4dc4 | Don't call callEnd() twice when application interceptors proceed twice.
I'm working towards reducing the role StreamAllocation plays.
https://github.com/square/okhttp/issues/4603 | Don't call callEnd() twice when application interceptors proceed twice.
I'm working towards reducing the role StreamAllocation plays.
https://github.com/square/okhttp/issues/4603 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/2b5337d14ecce5f965ea0d0001f30565f0e1d4a0 | Fix some maven problems that are blocking the 3.13 release | Fix some maven problems that are blocking the 3.13 release | No What | false | false | null |
https://github.com/square/okhttp/commit/94c38da706a99f2be825c67718c150b58eb08928 | Permit multipart filenames to contain non-ascii characters
Closes: https://github.com/square/okhttp/issues/4564 | Permit multipart filenames to contain non-ascii characters
Closes: https://github.com/square/okhttp/issues/4564 | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/0dc50f11122d9e1a5f6546a2159ecb46e07727c3 | Run IntelliJ inspections on the codebase
Some nullability warnings, some diamond operators, adopting Objects.equals(),
and some dead code elimination. | Run IntelliJ inspections on the codebase
Some nullability warnings, some diamond operators, adopting Objects.equals(),
and some dead code elimination. | No Why | true | false | 1 |
https://github.com/square/okhttp/commit/bdc7681b3ba16ae311d2dd21160d61315e8942ca | Drop code for Android 2.3 through 4.4.
No more Gingerbread, Honeycomb, Ice Cream Sandwich, Jelly Bean or KitKat. | Drop code for Android 2.3 through 4.4.
No more Gingerbread, Honeycomb, Ice Cream Sandwich, Jelly Bean or KitKat. | No Why | false | false | null |
https://github.com/square/okhttp/commit/97ba25854476bc5ff9ea4b8d3b4a78f6e9cf1a3e | Update issue templates | Update issue templates | Why and What | false | false | null |
https://github.com/square/okhttp/commit/0685dfaa7ff71a8f16b1b71f417b08eff13ec55f | Move TLSv1 and TLSv1.1 to COMPATIBLE_TLS.
We no longer connect to TLSv1.0 or TLSv1.1 servers out-of-the-box; instead
it is necessary to enable COMPATIBLE_TLS in the OkHttpClient configuration.
This is in the path to later removing these TLS versions completely; that
is scheduled for March 2020 by some browsers.
https://github.com/square/okhttp/issues/4319 | Move TLSv1 and TLSv1.1 to COMPATIBLE_TLS.
We no longer connect to TLSv1.0 or TLSv1.1 servers out-of-the-box; instead
it is necessary to enable COMPATIBLE_TLS in the OkHttpClient configuration.
This is in the path to later removing these TLS versions completely; that
is scheduled for March 2020 by some browsers.
https://github.com/square/okhttp/issues/4319 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/8c2a4cfffacc9bb8272182d327b05488a1810c80 | Don't crash on IPv4-mapped IPv6 addresses
https://github.com/square/okhttp/issues/4451 | Don't crash on IPv4-mapped IPv6 addresses
https://github.com/square/okhttp/issues/4451 | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/fe5d3eb89549d9ed7433bb88d364832e66b76cdc | Change contributing guide in repo to match wiki (#4414) | Change contributing guide in repo to match wiki | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/fa24d3dd7465f79aa35c3c7066a3269975be87e2 | Exclude 'internal' packages in generated Javadocs | Exclude 'internal' packages in generated Javadocs | No Why | false | false | null |
https://github.com/square/okhttp/commit/4b204037e6415a486df4eadb0c659c666e6b9aba | Remove overlapping package-info.java | Remove overlapping package-info.java | Why and What | false | false | null |
https://github.com/square/okhttp/commit/5373160d20aa3f6036ff5ebc91137888c4abffbe | Whole operation timeouts
Strictly-speaking this change is backwards-incompatible because it adds
a new method to the Call interface. The method returns the call's timeout.
The trickiest part of this is signaling the end of the call, which
occurs after the last byte is consumed of the last follow up request,
or when the call fails. Fortunately this is made easier by borrowing
the sites used by EventListener, which already plots out where calls
end.
https://github.com/square/okhttp/issues/2840 | Whole operation timeouts
Strictly-speaking this change is backwards-incompatible because it adds
a new method to the Call interface. The method returns the call's timeout.
The trickiest part of this is signaling the end of the call, which
occurs after the last byte is consumed of the last follow up request,
or when the call fails. Fortunately this is made easier by borrowing
the sites used by EventListener, which already plots out where calls
end.
https://github.com/square/okhttp/issues/2840 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/70bf8e78b7dbf8ed08dfd93596ba6ebfca52d3a3 | CipherSuite init speedup (#4340) | CipherSuite init speedup | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/c951e6ed887ad8b9595652f39dad646590b22037 | APIs to set date headers | APIs to set date headers | No Why | false | true | 0 |
https://github.com/square/okhttp/commit/be245e75cdfe87f077743ba9e72c66e04c3ded02 | Document HttpLoggingInterceptor.redactHeader() | Document HttpLoggingInterceptor.redactHeader() | Why and What | false | false | null |
https://github.com/square/okhttp/commit/474c23aa3035dc34eb6487ee7e2d4ba03bfb8c7a | Properly parse RFC 7235 authentication headers (#4249) (#4252) | Properly parse RFC 7235 authentication headers (#4249) | Why and What | false | false | null |
https://github.com/square/okhttp/commit/63ed542534eec2b1eb124531452a467b5541baa7 | API for handling an unexpected SSE response | API for handling an unexpected SSE response | No Why | false | false | null |
https://github.com/square/okhttp/commit/a01b5115985e555761fee9f9dafb9d7f14ad13cd | MockWebserver fix for IPv6 addresses (#4235)
Wrap IPv6 addresses with [] and return '/' path URIs for proxy CONNECT | MockWebserver fix for IPv6 addresses
Wrap IPv6 addresses with [] and return '/' path URIs for proxy CONNECT | Why and What | false | false | null |
https://github.com/square/okhttp/commit/5a17198acef96906dc6698245ad3192a1b4f6384 | remove experimental doc | remove experimental doc | No Why | false | true | 0 |
Subsets and Splits