url
stringlengths 79
94
| original_message
stringlengths 5
2.73k
| message
stringlengths 0
2.61k
| original_label
stringclasses 4
values | is_good
bool 2
classes | is_bad
bool 2
classes | binary_label
float64 0
1
⌀ |
|---|---|---|---|---|---|---|
https://github.com/square/okhttp/commit/cabd391637d9fa4fdeb7238c844b0c528722fe1b | Use HTML entity for ampersand. | Use HTML entity for ampersand. | No Why | false | false | null |
https://github.com/square/okhttp/commit/4c1436b3d6e6a7f9722bbcaa4d9a286747168ec0 | HTTP/2 initial window size is 65535 not 65536. | HTTP/2 initial window size is 65535 not 65536. | No What | false | false | null |
https://github.com/square/okhttp/commit/3a8967322d06ff2d8445aa277ae103653adf4eee | Use Okio's appending sink for File. | Use Okio's appending sink for File. | No Why | false | false | null |
https://github.com/square/okhttp/commit/80cb022e49e63cbf304654f41153d5d4fd2cde50 | fix #789: Reorder test to ensure call is canceled before its body is returned. | Why and What | false | false | null |
|
https://github.com/square/okhttp/commit/9375aa8c4f954c086af05933191a5f9eed6c49eb | Correct reference to RC1. | Correct reference to RC1. | No Why | false | false | null |
https://github.com/square/okhttp/commit/cc38140be4c7e41330cf7749c3eeba23c85f9522 | Added support for http/2 draft 12, which is incompatible with previous priority schemes. | Added support for http/2 draft 12, which is incompatible with previous priority schemes. | No Why | false | false | null |
https://github.com/square/okhttp/commit/26401d816215e1050b8c1cc070ddc7f6210df523 | Use Okio 1.4.0 final. | Use Okio 1.4.0 final. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/1ba78fa29d1c0667bf7fb5efac2a9898d1d98b43 | Some POST samples. | Some POST samples. | No Why | false | true | 0 |
https://github.com/square/okhttp/commit/65a64c54072ea9a169098ff087cccfe726de03d5 | APIs to set and remove path segments. | APIs to set and remove path segments. | No Why | false | false | null |
https://github.com/square/okhttp/commit/2ec2027fc00e24a83cd7bb7fef8b11e7c751bc13 | Add missing copyright headers.
https://github.com/square/okhttp/issues/880 | Add missing copyright headers.
https://github.com/square/okhttp/issues/880 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/7e28b1d6b6834879556b9c3caa62e49e428351cc | Change HttpResponseCache to not implement java.net.ResponseCache.
This marks some methods as @Deprecated and internal-only.
Unfortunately we don't have a great mechanism to hide them from
the documented API. | Change HttpResponseCache to not implement java.net.ResponseCache.
This marks some methods as @Deprecated and internal-only.
Unfortunately we don't have a great mechanism to hide them from
the documented API. | No Why | false | false | null |
https://github.com/square/okhttp/commit/53ebedf932b71bed7b05220e31b24388301168a4 | Implement query parameter management.
The tricky part of this is '+' and ' ' management. | Implement query parameter management.
The tricky part of this is '+' and ' ' management. | No Why | false | false | null |
https://github.com/square/okhttp/commit/770a1f954dfbd1b956ffceaf67c38f10a4de4401 | Small cleanups.
Return the OkHttpClient on setters.
Remove some completed TODOs in Call.
Link to Okio in Javadoc. | Small cleanups.
Return the OkHttpClient on setters.
Remove some completed TODOs in Call.
Link to Okio in Javadoc. | No Why | false | false | null |
https://github.com/square/okhttp/commit/28434ce17d1b0bfb7f398d047e825f0f76b6e403 | Add wildcard hostnames support in CertificatePinner | Add wildcard hostnames support in CertificatePinner | No Why | true | false | 1 |
https://github.com/square/okhttp/commit/d3c57bd4f38d5d3944da88266dd9b474a84d802b | HttpURL parsing.
This includes everything but character encoding. The implementation
is built around one oversized method that runs top to bottom; I found
this was easier to follow than the switch statement recommended by the
URL standard. | HttpURL parsing.
This includes everything but character encoding. The implementation
is built around one oversized method that runs top to bottom; I found
this was easier to follow than the switch statement recommended by the
URL standard. | No Why | false | false | null |
https://github.com/square/okhttp/commit/e19326c0337758817e5879f9e1bef452d27f9a4a | Add MockWebServerRule. | Add MockWebServerRule. | Neither Why nor What | false | false | null |
https://github.com/square/okhttp/commit/92e427d7c66091c9731afd02f83f2d4ba08dc395 | Close the source after reading regardless of result. | Close the source after reading regardless of result. | No Why | false | false | null |
https://github.com/square/okhttp/commit/d017be5b0042d2142d9b541c1403aa393c2c7fdd | Test differences between user and network responses for gzip. | Test differences between user and network responses for gzip. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/5b6f64a46220911466350202ae974f167497225a | Fix HTTP post retransmit in the new API.
We don't buffer response bodies in the new API. But we should retransmit
POST bodies when a request fails. | Fix HTTP post retransmit in the new API.
We don't buffer response bodies in the new API. But we should retransmit
POST bodies when a request fails. | No What | false | false | null |
https://github.com/square/okhttp/commit/35d0922f46c95bd73b1d070b6963cf3512167854 | Add convenience overload for ByteString-backed RequestBody. | Add convenience overload for ByteString-backed RequestBody. | No Why | false | false | null |
https://github.com/square/okhttp/commit/2e07d308d2189e9ffef4fa958fa20f467ffdcfe5 | Custom trust recipe.
To my great delight, Java and Android can read .pem files without
the BKS or JKS store files we typically use to distribute trusted
certificates.
This recipe includes a big copy-and-pasteable method for converting
an InputStream of PEM files into an SSLContext. The rest of it is
warnings about how dangerous that is.
Closes https://github.com/square/okhttp/issues/1336 | Custom trust recipe.
To my great delight, Java and Android can read .pem files without
the BKS or JKS store files we typically use to distribute trusted
certificates.
This recipe includes a big copy-and-pasteable method for converting
an InputStream of PEM files into an SSLContext. The rest of it is
warnings about how dangerous that is.
Closes https://github.com/square/okhttp/issues/1336 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/1ab086360755fcb13356617fe6d738171889d810 | Add a test for interceptors throwing unchecked exceptions.
Our behavior here is not good. Right now it looks like we're leaking
resources; nothing is releasing the socket in a 'finally' clause when
interceptors crash. We're also not notifying the callback that the
call has failed; that's left hanging.
That said, we don't expect applications to recover from these
exceptions.
Closes https://github.com/square/okhttp/issues/1482 | Add a test for interceptors throwing unchecked exceptions.
Our behavior here is not good. Right now it looks like we're leaking
resources; nothing is releasing the socket in a 'finally' clause when
interceptors crash. We're also not notifying the callback that the
call has failed; that's left hanging.
That said, we don't expect applications to recover from these
exceptions.
Closes https://github.com/square/okhttp/issues/1482 | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/2d47bc2631048fc713dbc7dbb6e7603619fce776 | Add a test for corner-case behavior.
I'm looking to make HttpURLConnectionImpl delegate to Job, and that means
writing tests for all the weird things it does above HttpEngine. | Add a test for corner-case behavior.
I'm looking to make HttpURLConnectionImpl delegate to Job, and that means
writing tests for all the weird things it does above HttpEngine. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/4f0cf03bed4180e4e277a99e1194cc17b0d198d4 | Expose running and queued call counts for monitoring | Expose running and queued call counts for monitoring | No Why | false | false | null |
https://github.com/square/okhttp/commit/60f5406dcc094d0431420139bd002e8bdd4ea5d5 | Move TLS retries / fallback into Connection.
API changes:
1) Added: Address.getCertificatePinner()
2) Incompatible API change: Address constructor no longer
includes ConnectionSpecs. Removed getConnectionSpecs().
3) Added: ConnectionSpec.isCompatible(SSLSocket)
4) Added: TlsVersion.javaName()
Implicit / semantic / internal changes:
1) Connection now handles all attempts to connect via a route
(effectively a {proxy, socket address} pair), rather than just
one attempt. i.e. Connection now handles all the TLS negotiation
fallbacks internally.
2) Route no longer deals with TLS versions. Individual TLS
failures are not counted against a Route. If no connection
attempts to a route were successful the failure is counted
against the route.
3) The code makes a distinction between when various
IOExceptions occur, with the intention making retries a bit
smarter. It is now more obvious which exceptions happen during
setup (RequestException), connection (RouteException),
HTTP communication and thus which can be retried and whether
the request might have been sent. | Move TLS retries / fallback into Connection.
API changes:
1) Added: Address.getCertificatePinner()
2) Incompatible API change: Address constructor no longer
includes ConnectionSpecs. Removed getConnectionSpecs().
3) Added: ConnectionSpec.isCompatible(SSLSocket)
4) Added: TlsVersion.javaName()
Implicit / semantic / internal changes:
1) Connection now handles all attempts to connect via a route
(effectively a {proxy, socket address} pair), rather than just
one attempt. i.e. Connection now handles all the TLS negotiation
fallbacks internally.
2) Route no longer deals with TLS versions. Individual TLS
failures are not counted against a Route. If no connection
attempts to a route were successful the failure is counted
against the route.
3) The code makes a distinction between when various
IOExceptions occur, with the intention making retries a bit
smarter. It is now more obvious which exceptions happen during
setup (RequestException), connection (RouteException),
HTTP communication and thus which can be retried and whether
the request might have been sent. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/0a67394f2a6401ae181d601e3724703829506bf6 | Exceptions from peer closing should not be propagated. | Exceptions from peer closing should not be propagated. | No What | false | false | null |
https://github.com/square/okhttp/commit/353ec0b0cdbf46ddbc2755e482c62ec711badf90 | Fix for SslContextBuilder/MockWebServer disagreeing about localhost
MockWebServer binds to getByName('localhost'), SslContextBuilder was using
InetAddress.getByName(null) (null == any loopback). On Android, null
returns IPv6 loopback, which has the name 'ip6-localhost'. | Fix for SslContextBuilder/MockWebServer disagreeing about localhost
MockWebServer binds to getByName('localhost'), SslContextBuilder was using
InetAddress.getByName(null) (null == any loopback). On Android, null
returns IPv6 loopback, which has the name 'ip6-localhost'. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/ff7946416d86aedcf154b868ba869241cd4816e9 | Add some pings to force happens-before in SPDY tests.
Previously we were relying on accidents to get our tests to pass. There
may still be some that require work, but this should fix the three tests
that I saw fail.
https://github.com/square/okhttp/issues/525 | Add some pings to force happens-before in SPDY tests.
Previously we were relying on accidents to get our tests to pass. There
may still be some that require work, but this should fix the three tests
that I saw fail.
https://github.com/square/okhttp/issues/525 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/b03026067b3686e45d4e11886eaccf084c36b01e | Update to HTTP/2 Draft 10 and HPACK Draft 6. | Update to HTTP/2 Draft 10 and HPACK Draft 6. | No Why | false | false | null |
https://github.com/square/okhttp/commit/ff5390d6dcaf79ef09a3ef94dbb7e8ac39572a7f | Allow specifying a socket factory for connections.
This socket factory will be used for all non-proxy connections and HTTP proxy connections. | Allow specifying a socket factory for connections.
This socket factory will be used for all non-proxy connections and HTTP proxy connections. | No Why | true | false | 1 |
https://github.com/square/okhttp/commit/6c57d76915a7e79cc8b8f743ccd8ecc35889ce7c | Track Connection ownership.
Connection ownership is somewhat racy: when an HttpURLConnection reads
the last byte of a connection, its ownership is released and given to
the connection pool. | Track Connection ownership.
Connection ownership is somewhat racy: when an HttpURLConnection reads
the last byte of a connection, its ownership is released and given to
the connection pool. | No Why | false | false | null |
https://github.com/square/okhttp/commit/4c86085429edbeef0a383941936ee7b64cc3805e | Drop ALPN support.
https://github.com/square/okhttp/issues/666 | Drop ALPN support.
https://github.com/square/okhttp/issues/666 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/cb7de5bb40a506700565b9732e1574ce9161b442 | Remove 'jar-with-dependencies' qualifier from download link.
This link is used when the jQuery Maven Artifact plugin cannot resolve the absolute URL of the latest artifact. | Remove 'jar-with-dependencies' qualifier from download link.
This link is used when the jQuery Maven Artifact plugin cannot resolve the absolute URL of the latest artifact. | No Why | false | false | null |
https://github.com/square/okhttp/commit/6cf56de5d0701ff26aa6043c552e17c4665c1287 | Return HttpResponseCache to previous (e.g. KitKat) behavior
This change required to handle this Android scenario:
When this version of OkHttp is packaged into Android in a future
release (in com.android.okhttp...) there is a possibility that
an older version of OkHttp bundled with application
(in com.squareup.okhttp...) will pick up the newer HttpResponseCache
via ResponseCache.getDefault(). It will attempt to use the get() / put()
methods. Commit e2599be9e073f1be8e929597c358e2664ab0c9a9 was
intended to restore HttpResponseCache get() and put() and avoid the
UnsupportedOperationException that would be thrown.
Unfortunately, it didn't quite do it:
In KitKat and older versions OkHttp, in HttpResponseCache the behavior
was to ignore any calls to put(URI, URLConnection) including
any HttpURLConnection/HttpsURLConnection that wasn't its own
(i.e. only ones from com.android.okhttp would be cached). The previous
fix to HttpResponseCache re-introduced get()/put() but didn't implement
the necessary instanceof checks.
Jesse also informs me that coexistance with other implementations
of HttpURLConnection is not required (since OkHttp replaces the
HTTP implementation on the desktop). I have also since discovered
that HttpResponseCache didn't implement the cache-control logic
required to follow the letter of the Java API anyway, which means
that HttpResponseCache is not suitable for use in cases where
the Http(s)URLConnection implementation expects a fully compliant
implementation.
Also addressed nits from e2599be9e073f1be8e929597c358e2664ab0c9a9. | Return HttpResponseCache to previous (e.g. KitKat) behavior
This change required to handle this Android scenario:
When this version of OkHttp is packaged into Android in a future
release (in com.android.okhttp...) there is a possibility that
an older version of OkHttp bundled with application
(in com.squareup.okhttp...) will pick up the newer HttpResponseCache
via ResponseCache.getDefault(). It will attempt to use the get() / put()
methods. Commit e2599be9e073f1be8e929597c358e2664ab0c9a9 was
intended to restore HttpResponseCache get() and put() and avoid the
UnsupportedOperationException that would be thrown.
Unfortunately, it didn't quite do it:
In KitKat and older versions OkHttp, in HttpResponseCache the behavior
was to ignore any calls to put(URI, URLConnection) including
any HttpURLConnection/HttpsURLConnection that wasn't its own
(i.e. only ones from com.android.okhttp would be cached). The previous
fix to HttpResponseCache re-introduced get()/put() but didn't implement
the necessary instanceof checks.
Jesse also informs me that coexistance with other implementations
of HttpURLConnection is not required (since OkHttp replaces the
HTTP implementation on the desktop). I have also since discovered
that HttpResponseCache didn't implement the cache-control logic
required to follow the letter of the Java API anyway, which means
that HttpResponseCache is not suitable for use in cases where
the Http(s)URLConnection implementation expects a fully compliant
implementation.
Also addressed nits from e2599be9e073f1be8e929597c358e2664ab0c9a9. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/6b17f9edf338173c6491cc30feeb6e4ff539be9d | Doc: OkHttpClient should be treated as immutable once shared
...given that requirement, it's safe for many threads to call the
open() method concurrently to open their own connections.
https://github.com/square/okhttp/pull/634#discussion_r10487815 | Doc: OkHttpClient should be treated as immutable once shared
...given that requirement, it's safe for many threads to call the
open() method concurrently to open their own connections.
https://github.com/square/okhttp/pull/634#discussion_r10487815 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/c8638813ff5f90715417e489b342aae5e410c5b2 | Build setup tweak to work around release plugin bug.
http://jira.codehaus.org/browse/MRELEASE-812 | Build setup tweak to work around release plugin bug.
http://jira.codehaus.org/browse/MRELEASE-812 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/8f035fc347f1ba9e4155ce99242c1a4f7d6e16dd | Restore support for ResponseCache.setDefault(). | Restore support for ResponseCache.setDefault(). | No Why | false | false | null |
https://github.com/square/okhttp/commit/cf63fcc48ae3e1dc3fb32120ca2fb04877fa041e | Remove creation of 'fat' jar.
Since the 'okhttp-protocols' module no longer exists we do not need to create this. | Remove creation of 'fat' jar.
Since the 'okhttp-protocols' module no longer exists we do not need to create this. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/6d8e198e2dd1ef808e81c57a9e88aa6218e0dbab | New mockwebserver docs. | New mockwebserver docs. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/5c3cfd9148500c19794aec4ba44c426247b7bd72 | Confirm that we use GMT formatting in setIfModifiedSince(). | Confirm that we use GMT formatting in setIfModifiedSince(). | No Why | false | false | null |
https://github.com/square/okhttp/commit/29ffd5237ec89577a67c781c746ce72f968efabe | Test for redirect leak bug. | Test for redirect leak bug. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/97524fb5c9b94b1544a641f115318a41d976a801 | Use OkBuffer in Http20Draft09Test. | Use OkBuffer in Http20Draft09Test. | No Why | false | false | null |
https://github.com/square/okhttp/commit/dac5aed3d5f9307b9d1ab0a8c7840b232d053ef3 | Move connection pooling logic.
Previously we had this ugly, awkward release() method that
attempted to manage connection pooling, discarding streams
for caching, and closing broken streams.
Move connection reuse to HttpConnection, with policy informed
by HttpEngine. It specifies what to do when the connection
becomes idle: pool, close or hold. The connection does what
it's told. | Move connection pooling logic.
Previously we had this ugly, awkward release() method that
attempted to manage connection pooling, discarding streams
for caching, and closing broken streams.
Move connection reuse to HttpConnection, with policy informed
by HttpEngine. It specifies what to do when the connection
becomes idle: pool, close or hold. The connection does what
it's told. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/15099af48064c22bc3357b01c9efcb1aa43c4819 | Flush control frames; don't flush user frames. | Flush control frames; don't flush user frames. | No Why | false | false | null |
https://github.com/square/okhttp/commit/08bc3c8808ec4495a1284ed6eb2325d44b435d33 | Add MockWebServer.setNpnProtocols | Add MockWebServer.setNpnProtocols | No Why | false | false | null |
https://github.com/square/okhttp/commit/855c114f4f6fce3e0e1ae71479f89c9d5ad066d6 | Read/write access for byte, short and int.
This is big-endian only because that's all we use in OkHttp. | Read/write access for byte, short and int.
This is big-endian only because that's all we use in OkHttp. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/35b031fb63534b9664e622ca4ecf5b19536f63a8 | Fix mockwebserver jar download 404 | Fix mockwebserver jar download 404 | No What | false | false | null |
https://github.com/square/okhttp/commit/5fe67f1bfc00a1c2027802515079137f6fd70bea | Implement moving bytes between OkBuffers.
This is more complicated than I'd anticipated. | Implement moving bytes between OkBuffers.
This is more complicated than I'd anticipated. | No Why | false | false | null |
https://github.com/square/okhttp/commit/32a2b1d8d000a19d4a340cc1d77a68973a9d65dc | OkBuffer API sketch.
I'm unhappy with java.io:
* No timeouts.
* Every layer needs to copy bytes around. Always copying bytes.
* Features like mark/reset and available() are clumsy.
* Its awkard in mixed text/binary protocols like HTTP because
character decoding is separate and takes over the stream.
Unfortunately java.nio isn't better, just different:
* It's complex.
* Buffers are fixed size.
* No built-in buffer pooling.
* Features like mark/reset/position are clumsy.
This is an obnoxious attempt at a 3rd I/O interface, mostly
inspired by InputStream and OutputStream, but using growable
buffers instead of byte arrays as the core data container. | OkBuffer API sketch.
I'm unhappy with java.io:
* No timeouts.
* Every layer needs to copy bytes around. Always copying bytes.
* Features like mark/reset and available() are clumsy.
* Its awkard in mixed text/binary protocols like HTTP because
character decoding is separate and takes over the stream.
Unfortunately java.nio isn't better, just different:
* It's complex.
* Buffers are fixed size.
* No built-in buffer pooling.
* Features like mark/reset/position are clumsy.
This is an obnoxious attempt at a 3rd I/O interface, mostly
inspired by InputStream and OutputStream, but using growable
buffers instead of byte arrays as the core data container. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/69cabb714e2a9972a69be991e660bae99b356824 | Improve some Markdown | Improve some Markdown | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/241814257b774f39896d7384c3452ef22612307f | Backfill spdy and http/2 related tests wrt zero-length messages. | Backfill spdy and http/2 related tests wrt zero-length messages. | No Why | false | false | null |
https://github.com/square/okhttp/commit/97741e94fba896f2aede30aecb789efe409202cf | Don't unzip if there isn't a response body.
https://github.com/square/okhttp/issues/358 | Don't unzip if there isn't a response body.
https://github.com/square/okhttp/issues/358 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/0c5b5454bc8e9c24160a5df1f5b83a0532323ee1 | Read priority flag on http/2 headers frame. | Read priority flag on http/2 headers frame. | No Why | false | false | null |
https://github.com/square/okhttp/commit/04e1002ad11b41d6483e614c673cfaa81ae1a551 | Support more than 64 referenced headers in HPACK. | Support more than 64 referenced headers in HPACK. | No Why | false | false | null |
https://github.com/square/okhttp/commit/46a0852c202acf68cd890867a35f8e51b81c2948 | Don't attempt TLS modes we know will fail.
https://github.com/square/okhttp/issues/442 | Don't attempt TLS modes we know will fail.
https://github.com/square/okhttp/issues/442 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/9eb276043fc14cda856671ccdba4065bba2a7bae | Small docs fixes. Remove OkHttp 2 warnings. | Small docs fixes. Remove OkHttp 2 warnings. | No Why | false | false | null |
https://github.com/square/okhttp/commit/3eda83ab14d334bf5a5cb900674df1552de74e73 | Platform.getMtu is unused.
This was a failed experiment. | Platform.getMtu is unused.
This was a failed experiment. | No Why | false | false | null |
https://github.com/square/okhttp/commit/59a6804c91328c2d1eb096054590b213ab711d22 | Tests for canceling async requests. | Tests for canceling async requests. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/30ecba897fb624df201f0a014b54a604418a0e73 | Use Request and Response types in OkResponseCache.
This breaks support for java.net.ResponseCache implementations. That's
good. That API is akward and can't support important features like
conditional GETs and hit tracking. | Use Request and Response types in OkResponseCache.
This breaks support for java.net.ResponseCache implementations. That's
good. That API is akward and can't support important features like
conditional GETs and hit tracking. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/37c01895cca5ec2bec26a3d381611f0938acd6d0 | Define async APIs and switch Job to use HttpEngine directly.
Using HttpEngine directly introduces some duplicated code with
HttpURLConnection. It also breaks the response cache. I think
this is the best route going forward; and eventually we could
invert this relationship to have HttpURLConnection depending on
Job directly rather than vice versa. | Define async APIs and switch Job to use HttpEngine directly.
Using HttpEngine directly introduces some duplicated code with
HttpURLConnection. It also breaks the response cache. I think
this is the best route going forward; and eventually we could
invert this relationship to have HttpURLConnection depending on
Job directly rather than vice versa. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/1c90331a3dc9856e31fac14b58d856cb2dd83d89 | getMtu issue | getMtu issue | No What | false | true | 0 |
https://github.com/square/okhttp/commit/af5e60af84da628125b6fa832bdb45093c4bba71 | issue #364: spdy should set content-length when it is known. | issue #364: spdy should set content-length when it is known. | No What | false | false | null |
https://github.com/square/okhttp/commit/742cee9e41eebb3f8af3b830f7b62ef898a14976 | Static HTTPS/SPDY3/HTTP2 server example | Static HTTPS/SPDY3/HTTP2 server example | No Why | false | true | 0 |
https://github.com/square/okhttp/commit/c74050b71c0bf06693c8c772fd9e30ee6a68317a | Added description and download info for MockWebServer. | Added description and download info for MockWebServer. | No Why | true | false | 1 |
https://github.com/square/okhttp/commit/8f03548249d3292ab95fc5cf016b51133705e771 | Fix checkstyle issues in new Cookie code. | Fix checkstyle issues in new Cookie code. | No What | false | false | null |
https://github.com/square/okhttp/commit/29ab48bf0dfbac1b249f2233de08fa948bad11d8 | Fix a race condition in Connection.isExpired().
This was causing some SPDY connections to be evicted early,
and preventing connection reuse.
The spdyConnectionReuse test becomes flaky with the
fix that makes MockWebServer use different sequenceNumbers
for different requests on the same socket. With the fix
the test is no longer flaky. The old test wasn't good enough
to detect what it wanted to detect!
This race has existed in the code since we added more
aggressive time-based expiration in January 2013. In my
basic tests the race impacted ~20% of connections on a
desktop VM. It may have been more on mobile. | Fix a race condition in Connection.isExpired().
This was causing some SPDY connections to be evicted early,
and preventing connection reuse.
The spdyConnectionReuse test becomes flaky with the
fix that makes MockWebServer use different sequenceNumbers
for different requests on the same socket. With the fix
the test is no longer flaky. The old test wasn't good enough
to detect what it wanted to detect!
This race has existed in the code since we added more
aggressive time-based expiration in January 2013. In my
basic tests the race impacted ~20% of connections on a
desktop VM. It may have been more on mobile. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/638ae21c7a6edc0e51bc624a80dfbc6fb8aa4236 | safer check for invalid values, without catching OOM | safer check for invalid values, without catching OOM | No What | false | false | null |
https://github.com/square/okhttp/commit/d3a92ff9d511b40ce65f24f95901f53a1240dc74 | spdy 3 support length 0 header value | spdy 3 support length 0 header value | No What | false | false | null |
https://github.com/square/okhttp/commit/bc3aa64462552d3e1c2e621e0cb15880b71b933c | Revert '[maven-release-plugin] prepare release parent-1.2'
This reverts commit ad928c668de84199f277f083627a262485a987d1. | Revert '[maven-release-plugin] prepare release parent-1.2'
This reverts commit ad928c668de84199f277f083627a262485a987d1. | No Why | false | false | null |
https://github.com/square/okhttp/commit/00a50d1919549b51d941aeb893b2a5ed465aa472 | Teach MockWebServer SPDY.
Kill MockSpdyServer in the process. | Teach MockWebServer SPDY.
Kill MockSpdyServer in the process. | No Why | false | false | null |
https://github.com/square/okhttp/commit/9ddc3d75de2b4ad83e2551c1d4dfc7fa5f4f3e56 | Only exclude Javadoc from 'internal' package in the main artifact. | Only exclude Javadoc from 'internal' package in the main artifact. | No Why | false | false | null |
https://github.com/square/okhttp/commit/76275fc9733168320d9472b8982c7d38956058fb | Really support requests greater than 2 GiB.
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@45 cf848351-439f-e86a-257f-67fa721851d5 | Really support requests greater than 2 GiB.
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@45 cf848351-439f-e86a-257f-67fa721851d5 | No What | false | false | null |
https://github.com/square/okhttp/commit/ef09f798a32dc4d0593388054e446f199c14ec8f | Don't use IOException APIs not in Gingerbread | Don't use IOException APIs not in Gingerbread | No Why | false | false | null |
https://github.com/square/okhttp/commit/5f87fc19ab269a929b61c088a806a674644caa6a | Introduce a Policy interface between engine and connection.
This breaks the direct dependency from HttpEngine to
HttpURLConnectionImpl. With this dependency broken, we
can start to use HttpEngine directly from Dispatcher and
Job. | Introduce a Policy interface between engine and connection.
This breaks the direct dependency from HttpEngine to
HttpURLConnectionImpl. With this dependency broken, we
can start to use HttpEngine directly from Dispatcher and
Job. | No Why | false | false | null |
https://github.com/square/okhttp/commit/4910039a572abc6d20cac48eb2c5e92591520537 | Support querying & setting transport lists on connections.
The list is specified via a magic request property
'X-Android-Transports' and can be queried via the request
property 'X-Android-Selected-Transport'.
System wide defaults / switches don't need any changes
to okhttp. They can be set as options on the OkHttpClient
used by the platform UrlStreamHandlers. | Support querying & setting transport lists on connections.
The list is specified via a magic request property
'X-Android-Transports' and can be queried via the request
property 'X-Android-Selected-Transport'.
System wide defaults / switches don't need any changes
to okhttp. They can be set as options on the OkHttpClient
used by the platform UrlStreamHandlers. | No Why | false | false | null |
https://github.com/square/okhttp/commit/1192af61fd1f6a102a7d74422e83dfb1fc9a94b9 | Add current AOSP class name for OpenSSLSocketImpl
AOSP moved OpenSSLSocketImpl to com.android.org.conscrypt.* so add that
as the first choice for unbundled apps.
Change-Id: I7bad6533dcb86ee1cac3b15f42dd386bd651eaed | Add current AOSP class name for OpenSSLSocketImpl
AOSP moved OpenSSLSocketImpl to com.android.org.conscrypt.* so add that
as the first choice for unbundled apps.
Change-Id: I7bad6533dcb86ee1cac3b15f42dd386bd651eaed | No Why | false | false | null |
https://github.com/square/okhttp/commit/53e12cca33f7d24cd8ea6c6ead262559b3553fbb | Request entity tests for the Apache client shim. | Request entity tests for the Apache client shim. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/a39032cb0af0de4cbc1c18397c64f67074981538 | Make ConnectionPoolTest less flaky
I was seeing flaky results in the debugger because pooled
connections were being evicted as the test ran. | Make ConnectionPoolTest less flaky
I was seeing flaky results in the debugger because pooled
connections were being evicted as the test ran. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/abb3ab4f50a99119caf0871fe95234a3e619dc82 | New Javadocs.
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@20 cf848351-439f-e86a-257f-67fa721851d5 | New Javadocs.
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@20 cf848351-439f-e86a-257f-67fa721851d5 | Neither Why nor What | false | true | 0 |
https://github.com/square/okhttp/commit/ec1f3e9073439c03b22de4f2314724d6066efb4b | Rebuild Javadoc
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@19 cf848351-439f-e86a-257f-67fa721851d5 | Rebuild Javadoc
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@19 cf848351-439f-e86a-257f-67fa721851d5 | No Why | false | true | 0 |
https://github.com/square/okhttp/commit/4ebac2656c870a090141106ad9ce267d25863301 | Upgrade from ant to maven.
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@12 cf848351-439f-e86a-257f-67fa721851d5 | Upgrade from ant to maven.
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@12 cf848351-439f-e86a-257f-67fa721851d5 | No Why | false | false | null |
https://github.com/square/okhttp/commit/eb5e72280b56427139bb14ffe14036f8dca6dba3 | Use consistent camel casing of 'SSL'. | Use consistent camel casing of 'SSL'. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/ae9d97110b6111f374e078eaa34694fdcff93da8 | Revert 'Consistent casing of 'SSL' in method names.'
This reverts commit ea4297ded736c5b606a772fef9d0d7929697e159. | Revert 'Consistent casing of 'SSL' in method names.'
This reverts commit ea4297ded736c5b606a772fef9d0d7929697e159. | No Why | false | false | null |
https://github.com/square/okhttp/commit/739cb3ec6c41f58e6b6a75d18c912ad1111f8061 | More interesting example tests
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@6 cf848351-439f-e86a-257f-67fa721851d5 | More interesting example tests
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@6 cf848351-439f-e86a-257f-67fa721851d5 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/62177b80f051ffa1f0f95c15fd20482db2006b24 | Add Javadoc
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@5 cf848351-439f-e86a-257f-67fa721851d5 | Add Javadoc
git-svn-id: https://mockwebserver.googlecode.com/svn/trunk@5 cf848351-439f-e86a-257f-67fa721851d5 | No Why | false | true | 0 |
https://github.com/square/okhttp/commit/59b1c1dc5290b9f96ebeefb7ea2369d58042fed3 | Pom version updates. Drop unused dependencies. | Pom version updates. Drop unused dependencies. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/0ff5ce5a6dd22b24c0c080e6fe8b734ec0859418 | Update website to the latest design. | Update website to the latest design. | No Why | false | false | null |
https://github.com/square/okhttp/commit/954e8f5453a23d52f6a2a09aac469ca73460e0f5 | Dependency-free examples for the OkHttp front page.
I'm going to include code snippets from these. | Dependency-free examples for the OkHttp front page.
I'm going to include code snippets from these. | No Why | false | false | null |
https://github.com/square/okhttp/commit/63c5a42ecdc53d51cc6d617d4fcc05cb2e7a9dba | Don't explode if we can't find an interface for a local address.
We'll likely explode later when attempting to use the socket.
But that will fail with an IOException, unlike this which was
failing with a NullPointerException. | Don't explode if we can't find an interface for a local address.
We'll likely explode later when attempting to use the socket.
But that will fail with an IOException, unlike this which was
failing with a NullPointerException. | No What | false | false | null |
https://github.com/square/okhttp/commit/58c42623d084b05c249f1948686f250413a3611a | Minor doc fix. | Minor doc fix. | Why and What | false | true | 0 |
https://github.com/square/okhttp/commit/6ed0f2c2cbf5872684bcc50a883fb6d5d0ac207f | Update to the latest DiskLruCache.
Includes everything thru 8842981cbcfe20eb4721c0a2c867fa9a18233062 | Update to the latest DiskLruCache.
Includes everything thru 8842981cbcfe20eb4721c0a2c867fa9a18233062 | No Why | false | false | null |
https://github.com/square/okhttp/commit/4e3da9d43076937819a397fadddcd6514c9f6f2d | FaultRecoveringOutputStream.
This is the first step in a change that'll permit the underlying
socket stream to change out-from-under-you while you're uploading
POST data to a server.
It'll recover from failures writing the request body that occur
within the first N bytes, where N will be determined by the number
of bytes that can be written without positive confirmation.
See https://github.com/square/okhttp/issues/137 | FaultRecoveringOutputStream.
This is the first step in a change that'll permit the underlying
socket stream to change out-from-under-you while you're uploading
POST data to a server.
It'll recover from failures writing the request body that occur
within the first N bytes, where N will be determined by the number
of bytes that can be written without positive confirmation.
See https://github.com/square/okhttp/issues/137 | Why and What | false | false | null |
https://github.com/square/okhttp/commit/0665b628fafec38271d7a66421ae04c7fd35dd29 | Add support for following HTTP 307 temporary redirects.
Fixes Android bug 41739. | Add support for following HTTP 307 temporary redirects.
Fixes Android bug 41739. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/2d45a13249943cafa73460b35c3c366e5742eb6f | Mechanically change OkHttp to Square's Java style. | Mechanically change OkHttp to Square's Java style. | No Why | false | false | null |
https://github.com/square/okhttp/commit/b9580d68e9bc34eef397e9bc7f13091f1e3f1528 | Be more careful around IOExceptions.
This adds a first test where a frame is truncated. That has some
unpleasant consequences for the other tests because it means the
MockSpdyPeer is more aggressive about closing the socket when all
frames have been sent.
It also reduces the use of exceptions for flow control when handling
bogus incoming frames. This is a bit worse and a bit better; my
goal is to make it easier to differentiate between protocol-level
problems (bogus frames) from transport-level problems (closed sockets
and EOF streams). | Be more careful around IOExceptions.
This adds a first test where a frame is truncated. That has some
unpleasant consequences for the other tests because it means the
MockSpdyPeer is more aggressive about closing the socket when all
frames have been sent.
It also reduces the use of exceptions for flow control when handling
bogus incoming frames. This is a bit worse and a bit better; my
goal is to make it easier to differentiate between protocol-level
problems (bogus frames) from transport-level problems (closed sockets
and EOF streams). | Why and What | false | false | null |
https://github.com/square/okhttp/commit/3d2547f18886e771aaa9baa996a21136c93460c4 | Restore tests for response caching + TLS.
One of the test cases bitrotted to failure as a consequence
of the HTTP route selector change. I stopped assigning the
socket, which it needed to cache the TLS metadata. This is
fixed. | Restore tests for response caching + TLS.
One of the test cases bitrotted to failure as a consequence
of the HTTP route selector change. I stopped assigning the
socket, which it needed to cache the TLS metadata. This is
fixed. | No Why | false | false | null |
https://github.com/square/okhttp/commit/50999cceb5f5bcdaf79baa5ac7eeef90c72bda8d | Move out of the libcore package.
To promote the code into AOSP, we'll keep this package as-is
and do the jarjar in Android instead. | Move out of the libcore package.
To promote the code into AOSP, we'll keep this package as-is
and do the jarjar in Android instead. | Why and What | true | false | 1 |
https://github.com/square/okhttp/commit/40ff76547064c3fb5acb9047a6f679dd4379a4d0 | Make HttpConnection.connect return full working connections.
Previously the returned connections required the caller to
do extra work: setting up tunnels (which could require auth)
and performing an SSL handshake. With this change we make a
complete working connection in HttpConnection.connect().
This will make it easier to fix fallback when a single domain
has multiple IP addresses and some of those addresses are not
reachable.
This will also make it easier to do SPDY through HTTP proxies. | Make HttpConnection.connect return full working connections.
Previously the returned connections required the caller to
do extra work: setting up tunnels (which could require auth)
and performing an SSL handshake. With this change we make a
complete working connection in HttpConnection.connect().
This will make it easier to fix fallback when a single domain
has multiple IP addresses and some of those addresses are not
reachable.
This will also make it easier to do SPDY through HTTP proxies. | Why and What | false | false | null |
https://github.com/square/okhttp/commit/cbb33cbd05947c7680fe3519678323641a56fa8c | Fix a severe bug where multiple TLS tunnels were attempted.
The previous code would attempt a TLS tunnel on reused
HTTPS connections, even after the tunnel had been established.
This is a severe protocol error! | Fix a severe bug where multiple TLS tunnels were attempted.
The previous code would attempt a TLS tunnel on reused
HTTPS connections, even after the tunnel had been established.
This is a severe protocol error! | No What | true | false | 1 |
https://github.com/square/okhttp/commit/68ebb704fb73ad1545ae82287f8b2a5f68d8e69d | Address some todos around stream failures and peer errors. | Address some todos around stream failures and peer errors. | Why and What | false | false | null |
Subsets and Splits