commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Fix some bugs with the cfb1 bitsize handling
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5426)
| 604e591ed75eff9296c21ee5fe93f3e9ec246094 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/604e591ed75eff9296c21ee5fe93f3e9ec246094 | 2018-02-21 15:48:02+01:00 |
Fix access zero memory if SSL_DEBUG is enabled
If compile OpenSSL with SSL_DEBUG macro, some test cases will cause the
process crashed in the debug code.
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/7707)
| 5a4481f0e0bbf836c7f41805e84617784cb6b1db | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/5a4481f0e0bbf836c7f41805e84617784cb6b1db | 2018-11-26 16:57:55+08:00 |
ssl sigalg extension: fix NULL pointer dereference
As the variable peer_sigalgslen is not cleared on ssl rehandshake, it's
possible to crash an openssl tls secured server remotely by sending a
manipulated hello message in a rehandshake.
On such a manipulated rehandshake, tls1_set_shared_sigalgs() calls
tls12_shared_sigalgs() with the peer_sigalgslen of the previous
handshake, while the peer_sigalgs has been freed.
As a result tls12_shared_sigalgs() walks over the available
peer_sigalgs and tries to access data of a NULL pointer.
This issue was introduced by c589c34e61 (Add support for the TLS 1.3
signature_algorithms_cert extension, 2018-01-11).
Signed-off-by: Peter Kästle <[email protected]>
Signed-off-by: Samuel Sapalski <[email protected]>
CVE-2021-3449
CLA: trivial
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
| 02b1636fe3db274497304a3e95a4e32ced7e841b | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/02b1636fe3db274497304a3e95a4e32ced7e841b | 2021-03-15 13:19:56+01:00 |
Spelling
Reviewed-by: Andy Polyakov <[email protected]>
Reviewed-by: Kurt Roeckx <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/1264) | 9d22666eb89af7f4ca5c3d52490b7da89276cf90 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/9d22666eb89af7f4ca5c3d52490b7da89276cf90 | 2016-06-28 22:39:55+02:00 |
Add a test for correct handling of the cryptopro bug extension
This was complicated by the fact that we were using this extension for our
duplicate extension handling tests. In order to add tests for cryptopro
bug the duplicate extension handling tests needed to change first.
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/7984)
| 9effc496ad8a9b0ec737c69cc0fddf610a045ea4 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/9effc496ad8a9b0ec737c69cc0fddf610a045ea4 | 2019-01-04 16:55:15+00:00 |
Fix bug in entropy gathering.
This only impacts FIPS mode or someone who has enabled the FIPS 140.2
4.9.2 Conditional Tests. i.e. nobody currently.
Fix a significant issue in the entropy gathering for the continuous RNG
testing. The impact is using an uninitialised buffer instead of the gathered
entropy.
Reviewed-by: Kurt Roeckx <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/8789)
| b8621bdde70690361a36dca52688a3d946c3fe0f | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b8621bdde70690361a36dca52688a3d946c3fe0f | 2019-04-19 16:23:23+10:00 |
Fix a memleak on an error path in the pkcs12 test helpers
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/15269)
| a113826eac59a1e897c679beaa5934542c46952d | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a113826eac59a1e897c679beaa5934542c46952d | 2021-05-13 15:13:22+01:00 |
drbg: ensure fork-safety without using a pthread_atfork handler
When the new OpenSSL CSPRNG was introduced in version 1.1.1,
it was announced in the release notes that it would be fork-safe,
which the old CSPRNG hadn't been.
The fork-safety was implemented using a fork count, which was
incremented by a pthread_atfork handler. Initially, this handler
was enabled by default. Unfortunately, the default behaviour
had to be changed for other reasons in commit b5319bdbd095, so
the new OpenSSL CSPRNG failed to keep its promise.
This commit restores the fork-safety using a different approach.
It replaces the fork count by a fork id, which coincides with
the process id on UNIX-like operating systems and is zero on other
operating systems. It is used to detect when an automatic reseed
after a fork is necessary.
To prevent a future regression, it also adds a test to verify that
the child reseeds after fork.
CVE-2019-1549
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/9832)
| 849529257c9979c7ca0d28e8b80a47bc4a36d4f2 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/849529257c9979c7ca0d28e8b80a47bc4a36d4f2 | 2019-05-27 21:03:09+02:00 |
Fix an error code spelling.
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/952) | 8fdc99cb5dbf1a79b106cc635c82f59956e39108 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/8fdc99cb5dbf1a79b106cc635c82f59956e39108 | 2016-04-04 20:42:27+02:00 |
various spelling fixes
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/952) | 8483a003bfca5fac61cda3daea4db2ca20d10ef2 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/8483a003bfca5fac61cda3daea4db2ca20d10ef2 | 2016-03-10 21:34:48+01:00 |
Fix a bug in create_ssl_ctx_pair()
The max protocol version was only being set on the server side. It should
have been done on both the client and the server.
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/6113)
| 6021d8ec5affe07116cdae81fa3db81d67996aac | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6021d8ec5affe07116cdae81fa3db81d67996aac | 2018-04-27 12:09:08+01:00 |
Avoid overflow in EVP_EncodeUpdate
An overflow can occur in the EVP_EncodeUpdate function which is used for
Base64 encoding of binary data. If an attacker is able to supply very large
amounts of input data then a length check can overflow resulting in a heap
corruption. Due to the very large amounts of data involved this will most
likely result in a crash.
Internally to OpenSSL the EVP_EncodeUpdate function is primarly used by the
PEM_write_bio* family of functions. These are mainly used within the
OpenSSL command line applications, so any application which processes
data from an untrusted source and outputs it as a PEM file should be
considered vulnerable to this issue.
User applications that call these APIs directly with large amounts of
untrusted data may also be vulnerable.
Issue reported by Guido Vranken.
CVE-2016-2105
Reviewed-by: Richard Levitte <[email protected]>
| ee1e3cac2e83abc77bcc8ff98729ca1e10fcc920 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ee1e3cac2e83abc77bcc8ff98729ca1e10fcc920 | 2016-03-04 10:17:17+00:00 |
FIX strncpy warning in apps/cmp.c.
bugfix: #12872
strncpy here has compiling warning of -Wstringop-truncation, change
into BIO_snprintf as before.
Change-Id: I362872c4ad328cadd4c7a5a5da3165655fa26c0d
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/12889)
| ebcae87f6b62ed9b79a1255dbb3c69c635cea4d8 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ebcae87f6b62ed9b79a1255dbb3c69c635cea4d8 | 2020-09-15 01:59:02+00:00 |
Fix bug in TLSv1.3 PSK processing
The recent SSL error overhaul left a case where an error occurs but
SSLfatal() is not called.
Credit to OSSfuzz for finding this issue.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/4847)
| 2894e9cb6de62baec5b17d4f248b4ff12eb62005 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/2894e9cb6de62baec5b17d4f248b4ff12eb62005 | 2017-12-05 13:36:13+00:00 |
Make BN_GF2m_mod_arr more constant time
Experiments have shown that the lookup table used by BN_GF2m_mod_arr
introduces sufficient timing signal to recover the private key for an
attacker with access to cache timing information on the victim's host.
This only affects binary curves (which are less frequently used).
No CVE is considered necessary for this issue.
The fix is to replace the lookup table with an on-the-fly calculation of
the value from the table instead, which can be performed in constant time.
Thanks to Youngjoo Shin for reporting this issue.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/6270)
| b336ce57f2d5cca803a920d2a9e622b588cead3c | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b336ce57f2d5cca803a920d2a9e622b588cead3c | 2018-05-16 09:58:27+01:00 |
crypto: Fix various typos, repeated words, align some spelling to LDP.
partially revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- file name -> filename
- host name -> hostname
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19059)
| 1567a821a4616f59748fa8982724f88e542867d6 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/1567a821a4616f59748fa8982724f88e542867d6 | 2022-08-23 20:33:58+02:00 |
Don't overflow the output length in EVP_CipherUpdate calls
CVE-2021-23840
Reviewed-by: Paul Dale <[email protected]>
| c9fb704cf3af5524eb8e79961e31b60eee8c3c47 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/c9fb704cf3af5524eb8e79961e31b60eee8c3c47 | 2021-02-02 17:17:23+00:00 |
Fix a read buffer overrun in X509_aux_print().
The ASN1_STRING_get0_data(3) manual explitely cautions the reader
that the data is not necessarily NUL-terminated, and the function
X509_alias_set1(3) does not sanitize the data passed into it in any
way either, so we must assume the return value from X509_alias_get0(3)
is merely a byte array and not necessarily a string in the sense
of the C language.
I found this bug while writing manual pages for X509_print_ex(3)
and related functions. Theo Buehler <[email protected]> checked my
patch to fix the same bug in LibreSSL, see
http://cvsweb.openbsd.org/src/lib/libcrypto/asn1/t_x509a.c#rev1.9
As an aside, note that the function still produces incomplete and
misleading results when the data contains a NUL byte in the middle
and that error handling is consistently absent throughout, even
though the function provides an "int" return value obviously intended
to be 1 for success and 0 for failure, and even though this function
is called by another function that also wants to return 1 for success
and 0 for failure and even does so in many of its code paths, though
not in others. But let's stay focussed. Many things would be nice
to have in the wide wild world, but a buffer overflow must not be
allowed to remain in our backyard.
CLA: trivial
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/16108)
| c5dc9ab965f2a69bca964c709e648158f3e4cd67 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/c5dc9ab965f2a69bca964c709e648158f3e4cd67 | 2021-07-18 17:48:06+02:00 |
Fix two spelling errors
CLA: trivial
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/8447)
| 3dcbb6c4a395d56dfa561145d89017ff958bb18e | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/3dcbb6c4a395d56dfa561145d89017ff958bb18e | 2019-03-09 19:05:31+01:00 |
ECDSA: remove nonce padding (delegated to EC_POINT_mul)
* EC_POINT_mul is now responsible for constant time point multiplication
(for single fixed or variable point multiplication, when the scalar is
in the range [0,group_order), so we need to strip the nonce padding
from ECDSA.
* Entry added to CHANGES
* Updated EC_POINT_mul documentation
- Integrate existing EC_POINT_mul and EC_POINTs_mul entries in the
manpage to reflect the shift in constant-time expectations when
performing a single fixed or variable point multiplication;
- Add documentation to ec_method_st to reflect the updated "contract"
between callers and implementations of ec_method_st.mul.
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Andy Polyakov <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/6070)
| fe2d3975880e6a89702f18ec58881307bf862542 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/fe2d3975880e6a89702f18ec58881307bf862542 | 2018-04-24 16:00:08+03:00 |
openssl.pod: Add documentation for using the loader_attic engine
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/13551)
| acfccbd5ee09e453ac5e8f39744540907b0cac2b | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/acfccbd5ee09e453ac5e8f39744540907b0cac2b | 2020-11-27 14:09:22+01:00 |
Fix a bug in ecp_nistp224.c.
felem_neg does not produce an output within the tight bounds suitable
for felem_contract. This affects build configurations which set
enable-ec_nistp_64_gcc_128.
point_double and point_add, in the non-z*_is_zero cases, tolerate and
fix up the wider bounds, so this only affects point_add calls where the
other point is infinity. Thus it only affects the final addition in
arbitrary-point multiplication, giving the wrong y-coordinate. This is a
no-op for ECDH and ECDSA, which only use the x-coordinate of
arbitrary-point operations.
Note: ecp_nistp521.c has the same issue in that the documented
preconditions are violated by the test case. I have not addressed this
in this PR. ecp_nistp521.c does not immediately produce the wrong
answer; felem_contract there appears to be a bit more tolerant than its
documented preconditions. However, I haven't checked the point_add
property above holds. ecp_nistp521.c should either get this same fix, to
be conservative, or have the bounds analysis and comments reworked for
the wider bounds.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5779)
| dc55e4f70f401c5869410d6a0c068c18c3fd53ec | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/dc55e4f70f401c5869410d6a0c068c18c3fd53ec | 2018-03-28 12:21:45-04:00 |
add documentation
Reviewed-by: Bernd Edlinger <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/7848)
| 9058d9bcd0a0391353720f7728a48596b575ad64 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/9058d9bcd0a0391353720f7728a48596b575ad64 | 2018-12-06 21:36:08+02:00 |
x509_att.c: improve error checking and reporting and coding style
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/18931)
| ba9e3721febb073397248154a846f2088efd6409 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ba9e3721febb073397248154a846f2088efd6409 | 2022-08-01 16:33:35+02:00 |
Fix BN_hex2bn/BN_dec2bn NULL ptr/heap corruption
In the BN_hex2bn function the number of hex digits is calculated using
an int value |i|. Later |bn_expand| is called with a value of |i * 4|.
For large values of |i| this can result in |bn_expand| not allocating any
memory because |i * 4| is negative. This leaves ret->d as NULL leading
to a subsequent NULL ptr deref. For very large values of |i|, the
calculation |i * 4| could be a positive value smaller than |i|. In this
case memory is allocated to ret->d, but it is insufficiently sized
leading to heap corruption. A similar issue exists in BN_dec2bn.
This could have security consequences if BN_hex2bn/BN_dec2bn is ever
called by user applications with very large untrusted hex/dec data. This is
anticipated to be a rare occurrence.
All OpenSSL internal usage of this function uses data that is not expected
to be untrusted, e.g. config file data or application command line
arguments. If user developed applications generate config file data based
on untrusted data then it is possible that this could also lead to security
consequences. This is also anticipated to be a rare.
Issue reported by Guido Vranken.
CVE-2016-0797
Reviewed-by: Andy Polyakov <[email protected]>
| 99ba9fd02fd481eb971023a3a0a251a37eb87e4c | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/99ba9fd02fd481eb971023a3a0a251a37eb87e4c | 2016-02-22 10:27:18+00:00 |
apps & al : Fix various typos, repeated words, align some spelling to LDP.
Mostly revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19059)
| 9929c81702381bff54f833d6fe0a3304f4e2b635 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/9929c81702381bff54f833d6fe0a3304f4e2b635 | 2022-08-23 20:45:13+02:00 |
s390x assembly pack: fix formal interface bug in chacha module
Signed-off-by: Patrick Steuer <[email protected]>
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/8257)
| b2b580fe445e064da50c13d3e00f71022da16ece | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b2b580fe445e064da50c13d3e00f71022da16ece | 2019-02-15 22:59:09+01:00 |
PBKDF2 implementation: refactor to avoid memleak
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/9662)
| b1f15129933fdc98134ef2fcafb1ecea710f5920 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b1f15129933fdc98134ef2fcafb1ecea710f5920 | 2019-08-30 15:11:08+02:00 |
bugfix in ossl_cmp_msg_protect(): set senderKID and extend extraCerts also for unprotected CMP requests
Reviewed-by: Tim Hudson <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/12822)
| 543a802fabc6e53cd7b50b5561b9b0abbf769667 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/543a802fabc6e53cd7b50b5561b9b0abbf769667 | 2020-09-04 17:09:13+02:00 |
GH753: More spelling fix
Signed-off-by: Rich Salz <[email protected]>
Reviewed-by: Kurt Roeckx <[email protected]>
| b6453a68bbb34c901a2eaf24012d0a3afcbf52ff | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b6453a68bbb34c901a2eaf24012d0a3afcbf52ff | 2016-02-26 20:30:15+01:00 |
chacha20/poly1305: make sure to clear the buffer at correct position
The offset to the memory to clear was incorrect, causing a heap buffer
overflow.
CVE-2016-7054
Thanks to Robert Święcki for reporting this
Reviewed-by: Rich Salz <[email protected]>
| bf52165bda53524a267c784696bd074111a2f178 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/bf52165bda53524a267c784696bd074111a2f178 | 2016-11-04 14:21:46+01:00 |
Workaround an IO::Socket::IP bug
Workaround an apparent IO:Socket::IP bug where a seemingly valid
server socket is being returned even though a valid connection does not
exist. This causes the tests to intermittently hang. We additionally check
that the peerport looks ok to verify that the returned socket looks usable.
Reviewed-by: Richard Levitte <[email protected]>
| 6ae545248109710365189047ba945700ab8afff3 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6ae545248109710365189047ba945700ab8afff3 | 2016-05-16 16:54:28+01:00 |
Fix CVE-2022-3602 in punycode decoder.
An off by one error in the punycode decoder allowed for a single unsigned int
overwrite of a buffer which could cause a crash and possible code execution.
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(cherry picked from commit fe3b639dc19b325846f4f6801f2f4604f56e3de3)
| 3b421ebc64c7b52f1b9feb3812bdc7781c784332 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/3b421ebc64c7b52f1b9feb3812bdc7781c784332 | 2022-10-27 10:21:41+11:00 |
Fix an overflow bug in rsaz_512_sqr
There is an overflow bug in the x64_64 Montgomery squaring procedure used in
exponentiation with 512-bit moduli. No EC algorithms are affected. Analysis
suggests that attacks against 2-prime RSA1024, 3-prime RSA1536, and DSA1024 as a
result of this defect would be very difficult to perform and are not believed
likely. Attacks against DH512 are considered just feasible. However, for an
attack the target would have to re-use the DH512 private key, which is not
recommended anyway. Also applications directly using the low level API
BN_mod_exp may be affected if they use BN_FLG_CONSTTIME.
CVE-2019-1551
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Bernd Edlinger <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/10574)
| 8c6f86c7c5350fadf22d32d6cd4712e2ad4447ba | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/8c6f86c7c5350fadf22d32d6cd4712e2ad4447ba | 2019-12-04 12:48:21+01:00 |
util/find-doc-nits: improve error diagnostics on missing man section numbers in links
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/20369)
| 9a2f78e14a67eeaadefc77d05f0778fc9684d26c | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/9a2f78e14a67eeaadefc77d05f0778fc9684d26c | 2023-02-24 14:04:10+01:00 |
Reject invalid PSS parameters.
Fix a bug where invalid PSS parameters are not rejected resulting in a
NULL pointer exception. This can be triggered during certificate
verification so could be a DoS attack against a client or a server
enabling client authentication.
Thanks to Brian Carpenter for reporting this issues.
CVE-2015-0208
Reviewed-by: Tim Hudson <[email protected]>
| 09f06923e636019c39c807cb59c481375e720556 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/09f06923e636019c39c807cb59c481375e720556 | 2015-03-09 23:16:33+00:00 |
pariscid.pl: fix nasty typo in CRYPTO_memcmp.
Comparison was effectively reduced to least significant bits.
CVE-2018-0733
Reviewed-by: Matt Caswell <[email protected]>
| 0b020b14882173918b9cc3e8e3bd85fb9ffac948 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/0b020b14882173918b9cc3e8e3bd85fb9ffac948 | 2018-03-21 23:48:10+01:00 |
Fix a bug for aarch64 BigEndian
FIXES #10692 #10638
a bug for aarch64 bigendian with instructions 'st1' and 'ld1' on AES-GCM mode.
CLA: trivial
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/10751)
| bc8b648f744566031ce84d77333dbbcb9689e975 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/bc8b648f744566031ce84d77333dbbcb9689e975 | 2020-01-03 22:56:18+08:00 |
Fix encoding bug in i2c_ASN1_INTEGER
Fix bug where i2c_ASN1_INTEGER mishandles zero if it is marked as
negative.
Thanks to Huzaifa Sidhpurwala <[email protected]> and
Hanno Böck <[email protected]> for reporting this issue.
Reviewed-by: Rich Salz <[email protected]>
| a0eed48d37a4b7beea0c966caf09ad46f4a92a44 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a0eed48d37a4b7beea0c966caf09ad46f4a92a44 | 2015-04-16 16:43:09+01:00 |
Add documentation for SSL_key_update() and SSL_get_key_update_type()
This also adds documentation for the pre-existing and related
SSL_renegotiate*() functions.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/2609) | 398206375688f053774ab0622a59db69fb2e2b99 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/398206375688f053774ab0622a59db69fb2e2b99 | 2017-02-14 15:25:22+00:00 |
Add documentation for the SSL_export_keying_material() function
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3735)
| 23cec1f4b4801c643853bf2eb07d7eae5f4fe7cb | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/23cec1f4b4801c643853bf2eb07d7eae5f4fe7cb | 2017-06-21 13:55:02+01:00 |
Fix various typos, repeated words, align some spelling to LDP.
Partially revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19059)
| d7f3a2cc8691c062ef5bdeef28b66f80c8f7d5c3 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/d7f3a2cc8691c062ef5bdeef28b66f80c8f7d5c3 | 2022-08-23 20:40:44+02:00 |
Fix spelling errors in CMS.
Unfortunately it affects error code macros in public cms.h header, for
which reason misspelled names are preserved for backward compatibility.
Reviewed-by: Andy Polyakov <[email protected]>
Reviewed-by: Kurt Roeckx <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3463)
| df578aa01314acd072038b703ac3ec002208da03 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/df578aa01314acd072038b703ac3ec002208da03 | 2017-05-19 00:16:30+00:00 |
Use --debug with no-caching build as sanitizers need it
The memleak test otherwise fails.
Also disable async, dtls, and old tls versions to test some
different combination of disableables and speed up tests.
Fixes #14337
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/14536)
| bd55a0be1b5696f643863718e7aa916feccafdf4 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/bd55a0be1b5696f643863718e7aa916feccafdf4 | 2021-03-12 15:23:03+01:00 |
Fix a hang with SSL_peek()
If while calling SSL_peek() we read an empty record then we go into an
infinite loop, continually trying to read data from the empty record and
never making any progress. This could be exploited by a malicious peer in
a Denial Of Service attack.
CVE-2016-6305
GitHub Issue #1563
Reviewed-by: Rich Salz <[email protected]>
| b8d243956296458d1782af0d6e7ecfe6deae038a | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b8d243956296458d1782af0d6e7ecfe6deae038a | 2016-09-10 21:24:40+01:00 |
various spelling fixes
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
| 620d540bd47a96fb6905fbbdd8ea5167a8841a3e | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/620d540bd47a96fb6905fbbdd8ea5167a8841a3e | 2016-03-10 21:34:48+01:00 |
Updated CHANGES.md and NEWS.md for CVE-2023-0465
Also updated the entries for CVE-2023-0464
Related-to: CVE-2023-0465
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/20585)
| 986f9a674d49d1e13459e04bd721237c721c44f4 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/986f9a674d49d1e13459e04bd721237c721c44f4 | 2023-03-23 15:31:25+00:00 |
X509V3_set_ctx(): Improve documentation
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/17358)
| b6144bb8c1be63935ae09e1992c04fbe6e0f88a8 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b6144bb8c1be63935ae09e1992c04fbe6e0f88a8 | 2021-12-27 19:14:03+01:00 |
Bugfix: unsafe return check of EVP_PKEY_fromdata
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/16783)
| d11cab47810715ba472070300b180944a1d93633 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/d11cab47810715ba472070300b180944a1d93633 | 2021-10-08 17:01:47+08:00 |
Fix misspelling errors and typos reported by codespell
Fixes #10998
Reviewed-by: Shane Lontis <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/11000)
| 7fa8bcfe4342df41919f5564b315f9c85d0a02d6 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/7fa8bcfe4342df41919f5564b315f9c85d0a02d6 | 2020-02-02 22:54:01+01:00 |
Temporarily disable the explicit enable-asan build
The explicit enable-asan build fails in the memleak test for unknown
reasons. Therefore we disable it temporarily to get a green Travis.
Other builds that use -fsanitize=address in Travis seem to pass.
[extended tests]
Reviewed-by: Nicola Tuveri <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/10689)
| 5f95fbf39987848fc50fc8acf42eb8f4a7ec8666 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/5f95fbf39987848fc50fc8acf42eb8f4a7ec8666 | 2019-12-23 17:14:58+00:00 |
Configure: fix small spelling error
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5533)
| ed504a20843fce750ac8d1b55d5bb142421ad3df | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ed504a20843fce750ac8d1b55d5bb142421ad3df | 2018-03-06 21:03:21+01:00 |
apps/speed: allow to continue tests after any init failure handling.
previouly the exit(1) call was aborting the whole execution.
Improve error message.
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/10078)
| af0857f0e7ae46b7c3df2eca496cfcb71f1ff904 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/af0857f0e7ae46b7c3df2eca496cfcb71f1ff904 | 2019-10-19 16:38:21+02:00 |
Add documentation about Capabilities
Document the OSSL_PROVIDER_get_capabilities() function as well as the
provider side support for capabilities.
Reviewed-by: Shane Lontis <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/11914)
| 3c49e4ff519abee92d9557eca8653ab82cd5787c | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/3c49e4ff519abee92d9557eca8653ab82cd5787c | 2020-05-21 15:57:35+01:00 |
Avoid possible memleak in X509_policy_check()
When tree_calculate_user_set() fails, a jump to error failed to
deallocate a possibly allocated |auth_nodes|.
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3850)
| 67f060acefae34d820ccdb2f560d86ed10633500 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/67f060acefae34d820ccdb2f560d86ed10633500 | 2017-07-05 11:03:34+02:00 |
Fix OCSP_basic_verify signer certificate validation
The function `OCSP_basic_verify` validates the signer certificate on an OCSP
response. The internal function, ocsp_verify_signer, is responsible for this
and is expected to return a 0 value in the event of a failure to verify.
Unfortunately, due to a bug, it actually returns with a postive success
response in this case. In the normal course of events OCSP_basic_verify
will then continue and will fail anyway in the ocsp_check_issuer function
because the supplied "chain" value will be empty in the case that
ocsp_verify_signer failed to verify the chain. This will cause
OCSP_basic_verify to return with a negative result (fatal error). Normally
in the event of a failure to verify it should return with 0.
However, in the case of the OCSP_NOCHECKS flag being used, OCSP_basic_verify
will return with a positvie result. This could lead to callers trusting an
OCSP Basic response when it should not be.
CVE-2022-1343
Fixes #18053
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
| 21f89f542d745adbf1131338929ae538e200d50d | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/21f89f542d745adbf1131338929ae538e200d50d | 2022-04-13 16:36:54+01:00 |
Fix memleak in PKCS12_pbe_crypt_ex()
Makes sure that the variable 'out' is free on every error path.
Fixes #18689
Reviewed-by: Dmitry Belyavskiy <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/18808)
| af801ec89205aaf6ebf8522d510d0b1fc29e3233 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/af801ec89205aaf6ebf8522d510d0b1fc29e3233 | 2022-07-15 11:21:30+02:00 |
Fix a WPACKET bug
If we request more bytes to be allocated than double what we have already
written, then we grow the buffer by the wrong amount.
Reviewed-by: Emilia Käsper <[email protected]>
| f789b04f407c2003da62d2b91b587629f1a781d0 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/f789b04f407c2003da62d2b91b587629f1a781d0 | 2016-09-23 16:41:50+01:00 |
apps/cmp.c: Improve documentation of -secret, -cert, and -key options
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/12825)
| ef2d3588e8d4dea8910ab1f7dfec768403efb265 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ef2d3588e8d4dea8910ab1f7dfec768403efb265 | 2020-08-28 13:28:24+02:00 |
Generate some certificates with the certificatePolicies extension
Related-to: CVE-2023-0465
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/20585)
| a4e726428608e352283d745cb0716248d29ecf26 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a4e726428608e352283d745cb0716248d29ecf26 | 2023-03-07 15:22:40+00:00 |
bn/asm/x86_64-mont5.pl: fix carry bug in bn_sqr8x_internal.
CVE-2017-3732
Reviewed-by: Rich Salz <[email protected]>
| 3f4bcf5bb664b47ed369a70b99fac4e0ad141bb3 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/3f4bcf5bb664b47ed369a70b99fac4e0ad141bb3 | 2017-01-21 21:30:49+01:00 |
Fix NULL dereference in SSL_check_chain() for TLS 1.3
In the tls1_check_sig_alg() helper function, we loop through the list of
"signature_algorithms_cert" values received from the client and attempt
to look up each one in turn in our internal table that maps wire
codepoint to string-form name, digest and/or signature NID, etc., in
order to compare the signature scheme from the peer's list against what
is used to sign the certificates in the certificate chain we're
checking. Unfortunately, when the peer sends a value that we don't
support, the lookup returns NULL, but we unconditionally dereference the
lookup result for the comparison, leading to an application crash
triggerable by an unauthenticated client.
Since we will not be able to say anything about algorithms we don't
recognize, treat NULL return from lookup as "does not match".
We currently only apply the "signature_algorithm_cert" checks on TLS 1.3
connections, so previous TLS versions are unaffected. SSL_check_chain()
is not called directly from libssl, but may be used by the application
inside a callback (e.g., client_hello or cert callback) to verify that a
candidate certificate chain will be acceptable to the client.
CVE-2020-1967
Reviewed-by: Matt Caswell <[email protected]>
| a87f3fe01a5a894aa27ccd6a239155fd129988e4 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a87f3fe01a5a894aa27ccd6a239155fd129988e4 | 2020-04-10 12:27:28-07:00 |
Fix infinite verification loops due to has_san_id
Where name constraints apply, X509_verify() would incorrectly report an
internal error in the event that a certificate has no SAN extension.
CVE-2021-4044
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
| 6894e20b50c1204bfc990093b4e7ccd10f92865d | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6894e20b50c1204bfc990093b4e7ccd10f92865d | 2021-11-29 03:41:20+00:00 |
Fix memleaks in async api
Fixes: #5950
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/6038)
| 74a8acbdfb2c7f398d1ae2fe914cd32b437f6df4 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/74a8acbdfb2c7f398d1ae2fe914cd32b437f6df4 | 2018-04-26 18:39:51+02:00 |
Add documentation for the new custom extensions API
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3139) | 314aec07ef25844c498794f49dfb1fdf6b467323 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/314aec07ef25844c498794f49dfb1fdf6b467323 | 2017-04-06 17:33:23+01:00 |
Fix doc-nits for list command
Bug was introduced in #13669
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Nicola Tuveri <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/13728)
| fdf05eb7611a1fdb283162228985286a09d07940 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/fdf05eb7611a1fdb283162228985286a09d07940 | 2020-12-22 09:40:46+01:00 |
DOCS: Add documentation for EVP_PKEY_CTX_set_rsa_pss_keygen_mgf1_md_name()
At the same, align documentation markup to be closer to man-pages(7)
recommendations.
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/12188)
| 22063850586945fd98ad3656df21c16adfef89ae | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/22063850586945fd98ad3656df21c16adfef89ae | 2020-06-18 12:28:36+02:00 |
Fix DHE Null CKE vulnerability
If client auth is used then a server can seg fault in the event of a DHE
cipher being used and a zero length ClientKeyExchange message being sent
by the client. This could be exploited in a DoS attack.
CVE-2015-1787
Reviewed-by: Richard Levitte <[email protected]>
| d3cc5e610d1719a35cda52c9152134b490a8c944 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/d3cc5e610d1719a35cda52c9152134b490a8c944 | 2015-03-10 16:38:32+00:00 |
correct spelling errors detected by Debian lintian
CLA: trivial
Reviewed-by: Matthias St. Pierre <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5801)
| aa3b328541ff67dde7c40ae73dd11a296647ae3d | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/aa3b328541ff67dde7c40ae73dd11a296647ae3d | 2018-03-29 22:10:26+02:00 |
Add documentation for the newly added EVP_PKEY_new*() functions
Also adds some documentation for related existing functions/macros
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5520)
| d45a97f475d944c9d4ce1103fb1d3f3a68ccd8cd | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/d45a97f475d944c9d4ce1103fb1d3f3a68ccd8cd | 2018-03-05 17:41:49+00:00 |
crypto/evp: harden AEAD ciphers.
Originally a crash in 32-bit build was reported CHACHA20-POLY1305
cipher. The crash is triggered by truncated packet and is result
of excessive hashing to the edge of accessible memory. Since hash
operation is read-only it is not considered to be exploitable
beyond a DoS condition. Other ciphers were hardened.
Thanks to Robert Święcki for report.
CVE-2017-3731
Reviewed-by: Rich Salz <[email protected]>
| 2198b3a55de681e1f3c23edb0586afe13f438051 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/2198b3a55de681e1f3c23edb0586afe13f438051 | 2017-01-19 00:20:49+01:00 |
Add test for CVE-2020-1967
Add to test_sslsigalgs a TLSProxy test that injects a
"signature_algorithms_cert" extension that contains an unallocated
codepoint.
The test currently fails, since s_server segfaults instead of
ignoring the unrecognized value.
Since "signature_algorithms" and "signature_algorithms_cert" are very
similar, also add the analogous test for "signature_algorithms".
Reviewed-by: Matt Caswell <[email protected]>
| 3656c08ab4b1b892730cb5e808b6f4298b08a2e6 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/3656c08ab4b1b892730cb5e808b6f4298b08a2e6 | 2020-04-10 12:27:28-07:00 |
Add documentation for SSL version methods
[skip ci]
Reviewed-by: Rich Salz <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3049) | 86fde069d484188117a21563baf17e4ed0a4eeef | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/86fde069d484188117a21563baf17e4ed0a4eeef | 2017-03-28 15:33:54+10:00 |
Add documentation for BN_with_flags
Following on from the previous commit this adds some documentation for the
BN_with_flags function which is easy to misuse.
Reviewed-by: Emilia Käsper <[email protected]>
| e113c9c59dcb419dd00525cec431edb854a6c897 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e113c9c59dcb419dd00525cec431edb854a6c897 | 2015-11-24 16:08:34+00:00 |
Add documentation for the storeutl app
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3542)
| 8f507bc5d5fa3b848acb3db8618b55b5f643f6b3 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/8f507bc5d5fa3b848acb3db8618b55b5f643f6b3 | 2016-12-13 13:47:13+01:00 |
Improve documentation, layout, and code comments regarding self-issued certs etc.
Reviewed-by: Viktor Dukhovni <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/10587)
| ade08735f9d0ac85d611c5abee8a1df651bbca13 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ade08735f9d0ac85d611c5abee8a1df651bbca13 | 2019-12-23 15:40:47+01:00 |
Improve error reporting in key exchange provider implementations
Added some error reporting in dh_exch.c and unified error reporting
with it in other key exchange methods.
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/14367)
| 77b03f0e8fd97a57f84294d085e7730de5b4da4c | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/77b03f0e8fd97a57f84294d085e7730de5b4da4c | 2021-03-01 16:07:15+01:00 |
Prevent DTLS Finished message injection
Follow on from CVE-2016-2179
The investigation and analysis of CVE-2016-2179 highlighted a related flaw.
This commit fixes a security "near miss" in the buffered message handling
code. Ultimately this is not currently believed to be exploitable due to
the reasons outlined below, and therefore there is no CVE for this on its
own.
The issue this commit fixes is a MITM attack where the attacker can inject
a Finished message into the handshake. In the description below it is
assumed that the attacker injects the Finished message for the server to
receive it. The attack could work equally well the other way around (i.e
where the client receives the injected Finished message).
The MITM requires the following capabilities:
- The ability to manipulate the MTU that the client selects such that it
is small enough for the client to fragment Finished messages.
- The ability to selectively drop and modify records sent from the client
- The ability to inject its own records and send them to the server
The MITM forces the client to select a small MTU such that the client
will fragment the Finished message. Ideally for the attacker the first
fragment will contain all but the last byte of the Finished message,
with the second fragment containing the final byte.
During the handshake and prior to the client sending the CCS the MITM
injects a plaintext Finished message fragment to the server containing
all but the final byte of the Finished message. The message sequence
number should be the one expected to be used for the real Finished message.
OpenSSL will recognise that the received fragment is for the future and
will buffer it for later use.
After the client sends the CCS it then sends its own Finished message in
two fragments. The MITM causes the first of these fragments to be
dropped. The OpenSSL server will then receive the second of the fragments
and reassemble the complete Finished message consisting of the MITM
fragment and the final byte from the real client.
The advantage to the attacker in injecting a Finished message is that
this provides the capability to modify other handshake messages (e.g.
the ClientHello) undetected. A difficulty for the attacker is knowing in
advance what impact any of those changes might have on the final byte of
the handshake hash that is going to be sent in the "real" Finished
message. In the worst case for the attacker this means that only 1 in
256 of such injection attempts will succeed.
It may be possible in some situations for the attacker to improve this such
that all attempts succeed. For example if the handshake includes client
authentication then the final message flight sent by the client will
include a Certificate. Certificates are ASN.1 objects where the signed
portion is DER encoded. The non-signed portion could be BER encoded and so
the attacker could re-encode the certificate such that the hash for the
whole handshake comes to a different value. The certificate re-encoding
would not be detectable because only the non-signed portion is changed. As
this is the final flight of messages sent from the client the attacker
knows what the complete hanshake hash value will be that the client will
send - and therefore knows what the final byte will be. Through a process
of trial and error the attacker can re-encode the certificate until the
modified handhshake also has a hash with the same final byte. This means
that when the Finished message is verified by the server it will be
correct in all cases.
In practice the MITM would need to be able to perform the same attack
against both the client and the server. If the attack is only performed
against the server (say) then the server will not detect the modified
handshake, but the client will and will abort the connection.
Fortunately, although OpenSSL is vulnerable to Finished message
injection, it is not vulnerable if *both* client and server are OpenSSL.
The reason is that OpenSSL has a hard "floor" for a minimum MTU size
that it will never go below. This minimum means that a Finished message
will never be sent in a fragmented form and therefore the MITM does not
have one of its pre-requisites. Therefore this could only be exploited
if using OpenSSL and some other DTLS peer that had its own and separate
Finished message injection flaw.
The fix is to ensure buffered messages are cleared on epoch change.
Reviewed-by: Richard Levitte <[email protected]>
| 5cb4d6466a14665f8cd659b6dd7746183f2c60bd | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/5cb4d6466a14665f8cd659b6dd7746183f2c60bd | 2016-06-30 15:06:27+01:00 |
Fix for CVE-2015-0291
If a client renegotiates using an invalid signature algorithms extension
it will crash a server with a NULL pointer dereference.
Thanks to David Ramos of Stanford University for reporting this bug.
CVE-2015-0291
Reviewed-by: Tim Hudson <[email protected]>
| 34e3edbf3a10953cb407288101fd56a629af22f9 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/34e3edbf3a10953cb407288101fd56a629af22f9 | 2015-03-03 13:20:57+00:00 |
Fix GENERAL_NAME_cmp for x400Address (master)
CVE-2023-0286
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
| 7880536fe17c2b5450e279155bedd51771d28c9f | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/7880536fe17c2b5450e279155bedd51771d28c9f | 2023-01-17 17:45:42+00:00 |
add test for CVE-2016-7053
Reviewed-by: Richard Levitte <[email protected]>
| a378a46985698bf2576b2990e7faf21f62dd176a | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a378a46985698bf2576b2990e7faf21f62dd176a | 2016-10-14 12:02:12+01:00 |
Add documentation for some of the missing environment variables.
Where document already exists, it has been linked to.
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/17044)
| 7f6496275157f8e40f544f75a223c2c0dc6b389e | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/7f6496275157f8e40f544f75a223c2c0dc6b389e | 2021-11-16 10:31:44+10:00 |
Fix a failure to NULL a pointer freed on error.
Reported by the LibreSSL project as a follow on to CVE-2015-0209
Reviewed-by: Richard Levitte <[email protected]>
| 5e5d53d341fd9a9b9cc0a58eb3690832ca7a511f | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/5e5d53d341fd9a9b9cc0a58eb3690832ca7a511f | 2015-03-19 10:16:32+00:00 |
doc: add documentation for TLS13_KDF
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Shane Lontis <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/16203)
| 94eb3cdd34bf391f50a59bbfcc6cb83138a77261 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/94eb3cdd34bf391f50a59bbfcc6cb83138a77261 | 2021-08-02 21:44:38+10:00 |
Remove broken DSA private key workarounds.
Remove old code that handled various invalid DSA formats in ancient
software.
This also fixes a double free bug when parsing malformed DSA private keys.
Thanks to Adam Langley (Google/BoringSSL) for discovering this bug using
libFuzzer.
CVE-2016-0705
Reviewed-by: Emilia Käsper <[email protected]>
| ab4a81f69ec88d06c9d8de15326b9296d7f498ed | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ab4a81f69ec88d06c9d8de15326b9296d7f498ed | 2016-02-18 13:09:24+00:00 |
Add documentation for EVP_EncodeInit() and similar functions
Reviewed-by: Richard Levitte <[email protected]>
| d202a602e07b7090e3e5d75216b47cc7eb6fd4b6 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/d202a602e07b7090e3e5d75216b47cc7eb6fd4b6 | 2016-04-25 11:54:30+01:00 |
a_strex.c: improve documentation of 'tag2nbyte' lookup table
The 'tag2nbyte' lookup table maps the tags of ASN1 string types
to their respective character widths. It is used for example by
ASN1_STRING_to_UTF8(). This commit adds the tag names as comments.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/6062)
| d8f436f3cf771d519573460b14ece6ed01a157ff | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/d8f436f3cf771d519573460b14ece6ed01a157ff | 2018-04-20 17:55:02+02:00 |
Add documentation for the -no_alt_chains option for various apps, as well as
the X509_V_FLAG_NO_ALT_CHAINS flag.
Reviewed-by: Dr. Stephen Henson <[email protected]>
| fa7b01115bc33d9b40936688bb3c952dc93b645a | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/fa7b01115bc33d9b40936688bb3c952dc93b645a | 2015-01-27 11:15:15+00:00 |
RT3809: basicConstraints is critical
This is really a security bugfix, not enhancement any more.
Everyone knows critical extensions.
Reviewed-by: Dr. Stephen Henson <[email protected]>
| a7be5759cf9d8e2bf7c1ecd0efa2d53aae9ab706 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a7be5759cf9d8e2bf7c1ecd0efa2d53aae9ab706 | 2016-06-12 22:21:54-04:00 |
Add documentation for the Asymmetric Cipher Operation
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/10152)
| 11d876df50d90ec4b26364c4b7d317ea19139e13 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/11d876df50d90ec4b26364c4b7d317ea19139e13 | 2019-10-29 09:24:24+00:00 |
crypto/*: Fix various typos, repeated words, align some spelling to LDP.
partially revamped from #16712
- fall thru -> fall through
- time stamp -> timestamp
- host name -> hostname
- ipv6 -> IPv6
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19059)
| c7340583097a80a4fe42bacea745b2bbaa6d16db | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/c7340583097a80a4fe42bacea745b2bbaa6d16db | 2022-08-23 20:37:03+02:00 |
Add documentation for SSL_stateless()
Fixes #4283
Reviewed-by: Ben Kaduk <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/4435)
| 1e6122774a75ee4a59b5de129eac122222905b52 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/1e6122774a75ee4a59b5de129eac122222905b52 | 2017-09-28 15:05:58+01:00 |
Add documentation of the old names kept as alias macros
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/15405)
| 31b7f23d2f958491d46c8a8e61c2b77b1b546f3e | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/31b7f23d2f958491d46c8a8e61c2b77b1b546f3e | 2021-05-28 17:36:16+02:00 |
QUIC: Add documentation for stream and connection shutdown functions
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19897)
| 522fb49dbcd283c00c77ebcc7a650c54ac6eba5b | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/522fb49dbcd283c00c77ebcc7a650c54ac6eba5b | 2023-01-05 08:35:07+00:00 |
Fix a possible memleak
If there's a failure allocating md_data, the destination pctx will have
a shared pointer with the source EVP_MD_CTX, which will lead to problems
when either the source or the destination is freed.
Reviewed-by: Stephen Henson <[email protected]>
| 6aa0ba4bb2833b1e0d6ae98c54c79bfed8257c3a | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6aa0ba4bb2833b1e0d6ae98c54c79bfed8257c3a | 2015-12-18 13:03:45+01:00 |
Update documentation
Add documentation for EVP_DigestSignInit_ex() and
EVP_DigestVerifyInit_ex(), and add an appropriate CHANGES entry.
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/10013)
| a0b6c1ffd0261152c523c5c000e9c025b39fd630 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a0b6c1ffd0261152c523c5c000e9c025b39fd630 | 2019-09-23 16:43:08+01:00 |
Add documentation for CPUID bit #64+17
CLA: trivial
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19670)
| ec7689186f3ea5c1a4d1564089cd8df287dfcf3c | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ec7689186f3ea5c1a4d1564089cd8df287dfcf3c | 2022-11-14 12:56:32+01:00 |
Add documentation for SSL_SESSION_set_max_early_data()
Reviewed-by: Ben Kaduk <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3926)
| e17e1df77e651e557ad8fc67e2bea0bbcf98f153 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e17e1df77e651e557ad8fc67e2bea0bbcf98f153 | 2017-07-13 18:02:18+01:00 |
v2i_AUTHORITY_KEYID(): Improve error reporting on parsing config values/options
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/16345)
| 6e98b7f153fcf9dfad1053fbb3a592166837c6fc | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6e98b7f153fcf9dfad1053fbb3a592166837c6fc | 2021-08-17 19:12:55+02:00 |
Few cleanups in s_client, s_server apps.
Discard useless static engine_id
Add a const qualifier
Fix some spelling
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
| bde136c89f87b66d49e9d03e3b34c68b6b1d1e26 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/bde136c89f87b66d49e9d03e3b34c68b6b1d1e26 | 2016-03-18 19:02:17+01:00 |
Subsets and Splits