commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
Add documentation for CRYPTO_memcmp.
Reviewed-by: Matthias St. Pierre <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/9225)
| 0ccff7a7ea82a921f780a483fc91c6b90a1378d9 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/0ccff7a7ea82a921f780a483fc91c6b90a1378d9 | 2019-06-24 09:18:48+10:00 |
Fix bug in EDDSA speed test
The pkey created in one loop was being fed into the keygen of the next loop - since it was not set to NULL after the
free. This meant that the 2 EVP_MD_CTX objects that still had ref counts to this key were getting confused.
All other tests clear the key after freeing the key if they loop (some do this by declaring/initing the pkey inside the loop).
The offending code is a recent addition to the speed app.
This was found using the -async_jobs option.
Similar code was tried for an RSA key using 111 which resulted in the same issue.
Found while trying to test issue #128867 (It is not known if this will fix that issue yet).
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Tim Hudson <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/12975)
| 4f5b222b84432a11c44d8c9a11c7fa98351db79b | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/4f5b222b84432a11c44d8c9a11c7fa98351db79b | 2020-09-25 13:50:25+10:00 |
Fix spelling: adroideabi -> androideabi
CLA: trivial
Reviewed-by: Rich Salz <[email protected]>
Reviewed-by: Ben Kaduk <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5029)
| bebef673607b9701bc21a0f7b7dbf92434af2588 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/bebef673607b9701bc21a0f7b7dbf92434af2588 | 2018-01-07 21:57:25+08:00 |
Drop a spurious printf in evp_test.c
A spurious printf was added to evp_test.c - probably for debugging
purposes. This actually causes runtime errors in some cases because the
name being printed can be NULL.
Fixes #19814
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19820)
| 12c20c5486b6440a9b667c93f130a8fdea029b81 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/12c20c5486b6440a9b667c93f130a8fdea029b81 | 2022-12-02 09:27:34+00:00 |
Add documentation
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/1252) | a68d8c7b77a3d46d591b89cfd0ecd2a2242e4613 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a68d8c7b77a3d46d591b89cfd0ecd2a2242e4613 | 2017-01-12 12:22:12-05:00 |
Use the return value from write(2)
This prevents a warning when building with crypto-mdebug.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3836)
| 43a0449fe6ce18b750803be8a115a412a7235496 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/43a0449fe6ce18b750803be8a115a412a7235496 | 2017-07-04 09:56:05+10:00 |
Pass correct maximum output length to provider derive operation
And improve error checking in EVP_PKEY_derive* calls.
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/13869)
| 6d9a54c6e661094c0668f0307213789c2d9be3ec | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6d9a54c6e661094c0668f0307213789c2d9be3ec | 2021-01-14 14:40:23+01:00 |
Adapt CIPHER_DEBUG to the new generic trace API
Co-authored-by: Dr. Matthias St. Pierre <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/8198)
| 77359d22c97d1636eccf1fa583dc295228835144 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/77359d22c97d1636eccf1fa583dc295228835144 | 2018-12-12 23:57:48+01:00 |
QUIC TXP: Fix bug in send stream handling, cleanup
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19703)
| 05f97354bb6fe29731a8a25a475a115a2c44720a | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/05f97354bb6fe29731a8a25a475a115a2c44720a | 2022-12-16 13:26:33+00:00 |
Replumbing: add documentation for the provider configuration module
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/8549)
| b6670f690c4244e63dbc02a2ba25061f9c53945f | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b6670f690c4244e63dbc02a2ba25061f9c53945f | 2019-03-30 22:25:00+01:00 |
Improve testing of elliptic curve validation
Add a test recipe (test/recipes/15-test_ecparams.t) which uses 'openssl
ecparam' to check the test vectors.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/2544) | 691e302be3ededfcdef10c5f4c0d024ef1545b48 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/691e302be3ededfcdef10c5f4c0d024ef1545b48 | 2017-02-03 00:31:09+01:00 |
Improve readability of f_impl.c and f_impl.h
Reviewed-by: Bernd Edlinger <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5105)
| 8e32ec7a568b377f7fbcbee6b1bcf7fd8bbe2e88 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/8e32ec7a568b377f7fbcbee6b1bcf7fd8bbe2e88 | 2018-02-14 14:35:01+00:00 |
Many spelling fixes/typo's corrected.
Around 138 distinct errors found and fixed; thanks!
Reviewed-by: Kurt Roeckx <[email protected]>
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3459)
| 46f4e1bec51dc96fa275c168752aa34359d9ee51 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/46f4e1bec51dc96fa275c168752aa34359d9ee51 | 2017-11-11 19:03:10-05:00 |
Fix X509_NAME decode for malloc failures.
The original X509_NAME decode free code was buggy: this
could result in double free or leaks if a malloc failure
occurred.
Simplify and fix the logic.
Thanks to Guido Vranken for reporting this issue.
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/1691) | 6dcba070a94b1ead92f3e327cf207a0b7db6596f | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6dcba070a94b1ead92f3e327cf207a0b7db6596f | 2016-10-02 15:21:29+01:00 |
PKCS12 app: Improve readability w.r.t. enc_flag, renamed to enc_name
Reviewed-by: Dmitry Belyavskiy <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/16416)
| 870871e5df4f47611c38e81d3f50e38cbf362082 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/870871e5df4f47611c38e81d3f50e38cbf362082 | 2021-08-24 12:27:12+02:00 |
OpenSSL::config: Fix trivial bugs
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19285)
| 2ba5bffa26c0c4677f48e730628c0b54c31c734c | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/2ba5bffa26c0c4677f48e730628c0b54c31c734c | 2022-09-27 18:51:57+02:00 |
Fix POLICYINFO printing to not assume NUL terminated strings
ASN.1 strings may not be NUL terminated. Don't assume they are.
CVE-2021-3712
Reviewed-by: Viktor Dukhovni <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
| 1747d4658b3830951068a6a6c1fa2b45c4731fb3 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/1747d4658b3830951068a6a6c1fa2b45c4731fb3 | 2021-08-18 12:31:38+01:00 |
Fix range_should_be_prefix() to actually return the correct result
range_should_be_prefix() was misidentifying whether an IP address range
should in fact be represented as a prefix. This was due to a bug introduced
in commit 42d7d7dd which made this incorrect change:
- OPENSSL_assert(memcmp(min, max, length) <= 0);
+ if (memcmp(min, max, length) <= 0)
+ return -1;
This error leads to incorrect DER being encoded/accepted.
Reported by Theo Buehler (@botovq)
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/18524)
| 30532e59f475e0066c030693e4d614311a9e0cae | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/30532e59f475e0066c030693e4d614311a9e0cae | 2022-06-10 15:58:58+01:00 |
Don't free NCONF obtained values
Bug reported by Michel Sales.
Reviewed-by: Rich Salz <[email protected]>
| ebc4815fa56b64d711ada36899a35182a99cbbdb | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ebc4815fa56b64d711ada36899a35182a99cbbdb | 2016-03-06 20:01:20-05:00 |
evp/e_chacha20_poly1305.c: improve performance for short TLS records.
Inputs not longer than 64 bytes are processed ~10% faster, longer
lengths not divisble by 64, e.g. 255, up to ~20%. Unfortunately it's
impossible to measure with apps/speed.c, -aead benchmarks TLS-like
call sequence, but not exact. It took specially crafted code path...
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/6597)
| a091e212fc55244fe03a4c7db7d8978c5b5014cb | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a091e212fc55244fe03a4c7db7d8978c5b5014cb | 2018-06-27 12:16:52+02:00 |
More comments
Conflicts:
crypto/dsa/dsa_vrf.c
crypto/ec/ec2_smpl.c
crypto/ec/ecp_smpl.c
Conflicts:
demos/bio/saccept.c
ssl/d1_clnt.c
Conflicts:
bugs/dggccbug.c
demos/tunala/cb.c
Reviewed-by: Tim Hudson <[email protected]>
| 23a22b4cf72b0c2aadcd65001d4a28941d570547 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/23a22b4cf72b0c2aadcd65001d4a28941d570547 | 2015-01-16 14:43:29+00:00 |
Fix bug in strncpy() use of sk_ASN1_UTF8STRING2text() in asn1_lib.c
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/11300)
| b4ba2b7ce0933bede5d3b59a5abbde8fa3de2228 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b4ba2b7ce0933bede5d3b59a5abbde8fa3de2228 | 2020-03-20 15:15:34+01:00 |
Fix possible null pointer dereference of evp_pkey_get_legacy()
evp_pkey_get_legacy() will return NULL on failure, however several
uses of it or its wrappers does not check the return value of
evp_pkey_get_legacy(), which could lead to NULL pointer dereference.
Fix those possible bugs by adding NULL checking.
Reviewed-by: Shane Lontis <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/17967)
| b9a86d5dd8b5bd33be42390bcbb5121fe0ae71a1 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b9a86d5dd8b5bd33be42390bcbb5121fe0ae71a1 | 2022-03-25 20:28:32+08:00 |
Fix bug in err_string_data_cmp
Unsigned overflow. Thanks to Brian Carpenter for reporting this.
Reviewed-by: Tim Hudson <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3887)
| c784a838e0947fcca761ee62def7d077dc06d37f | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/c784a838e0947fcca761ee62def7d077dc06d37f | 2017-07-08 12:43:55-04:00 |
evp_rand: fix bug in gettable_ctx/settable_ctx calls
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/12931)
| d8e52fd05e350ee308715c46ac13dbea2899a6ce | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/d8e52fd05e350ee308715c46ac13dbea2899a6ce | 2020-09-22 08:29:58+10:00 |
bn/asm/x86_64-mont5.pl: fix carry propagating bug (CVE-2015-3193).
Reviewed-by: Richard Levitte <[email protected]>
| 29851264f11ccc70c6c0140d7e3d8d93ef5c9b11 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/29851264f11ccc70c6c0140d7e3d8d93ef5c9b11 | 2015-12-01 09:00:32+01:00 |
QUIC MSST: Add documentation for new APIs
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/20765)
| 1e4a9d882f77977f518dcad418b05822efb172fe | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/1e4a9d882f77977f518dcad418b05822efb172fe | 2023-04-18 19:30:56+01:00 |
Small fixup, an extra line slipped in
The previous 'Relax the requirements for a debug build' commit had
an extra line of code that shouldn't have been there. This fixes it.
Reviewed-by: Viktor Dukhovni <[email protected]>
| 1de8e63f86e1f1a60961489c47be55bb5f03e8d7 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/1de8e63f86e1f1a60961489c47be55bb5f03e8d7 | 2016-01-14 22:05:09+01:00 |
Remove SSL_OP_MICROSOFT_BIG_SSLV3_BUFFER and SSL_OP_TLS_D5_BUG support.
Suggested by David Benjamin
Reviewed-by: Rich Salz <[email protected]>
Reviewed-by: Viktor Dukhovni <[email protected]>
MR: #1520
| 1c9ed1d8a715e70c5e0d8c08f3a47e1a6fa9fd89 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/1c9ed1d8a715e70c5e0d8c08f3a47e1a6fa9fd89 | 2015-12-22 13:48:01+01:00 |
aes/asm/bsaes-armv7: fix kernel-side XTS and harmonize with Linux.
XTS bug spotted and fix suggested by Adrian Kotelba.
Reviewed-by: Tim Hudson <[email protected]>
| e620e5ae37bc3fc5e457ebf3edcdd01b20f8c5dd | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e620e5ae37bc3fc5e457ebf3edcdd01b20f8c5dd | 2015-02-24 10:07:22+01:00 |
Fix broken links, mainly typo's
Also tweak find-doc-nits while fixing a bug (don't need .in files)
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/10239)
| 1b0d1bf7f177f1a0c979af8e4abbd6ed45d464d7 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/1b0d1bf7f177f1a0c979af8e4abbd6ed45d464d7 | 2019-10-05 14:03:57-04:00 |
Fix another build break for no-mem-debug
Reviewed-by: Richard Levitte <[email protected]>
| 7b0a09f9cc169647d93cc2a38c7274684e35f723 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/7b0a09f9cc169647d93cc2a38c7274684e35f723 | 2016-01-07 16:16:22-05:00 |
Find debug- targets that can be combined with their non-debug counterparts and do so
Reviewed-by: Andy Polyakov <[email protected]>
| 7910044064e106073c097a6940d25fe36401266b | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/7910044064e106073c097a6940d25fe36401266b | 2015-03-12 14:55:05+01:00 |
Add SSL tests for certificates with embedded SCTs
The only SSL tests prior to this tested using certificates with no
embedded Signed Certificate Timestamps (SCTs), which meant they couldn't
confirm whether Certificate Transparency checks in "strict" mode were
working.
These tests reveal a bug in the validation of SCT timestamps, which is
fixed by the next commit.
Reviewed-by: Rich Salz <[email protected]>
Reviewed-by: Andy Polyakov <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3138) | 2094ea070a1fb6aa06b8e939e6cb735edc2c178b | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/2094ea070a1fb6aa06b8e939e6cb735edc2c178b | 2017-04-06 13:21:27+01:00 |
Also change the non-debug versions to use size_t
Reviewed-by: Richard Levitte <[email protected]>
MR: #1518
| f5d97098a4c5d1c91887a3f2e0a31c1e20ca32e3 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/f5d97098a4c5d1c91887a3f2e0a31c1e20ca32e3 | 2015-12-22 11:26:39+01:00 |
bugfix in apps/cmp.c and cmp_client.c: inconsistencies on retrieving extraCerts in code and doc
Reviewed-by: Tim Hudson <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/12822)
| bb30bce22b1f1e0dd6e3e33f28ddb24dc5b285ab | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/bb30bce22b1f1e0dd6e3e33f28ddb24dc5b285ab | 2020-09-08 15:30:33+02:00 |
Run-checker merge CI: Memleak test does not work without ubsan
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Hugo Landau <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19874)
| 1ca61aa56090356bbdbb16cf48916fbd9886c78d | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/1ca61aa56090356bbdbb16cf48916fbd9886c78d | 2022-12-09 12:13:36+01:00 |
apps/cmp.c: Improve documentation of -extracerts, -untrusted, and -otherpass
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/12825)
| 7a7d6b514fb2c95570896e512e165a38c9ecac46 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/7a7d6b514fb2c95570896e512e165a38c9ecac46 | 2020-08-28 14:55:38+02:00 |
Fix bug in scrypt KDF provider dup method
The scrypt KDF provider's dup method calls kdf_scrypt_new passing a
libctx, but a provider context is expected. Since the provider context
is passed as void *, this was not caught.
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/17873)
| e04c2c02e8e6b9ec71d93c26c14167ceb2165ce8 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e04c2c02e8e6b9ec71d93c26c14167ceb2165ce8 | 2022-03-11 14:02:39+00:00 |
spelling fixes, just comments and readme.
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/1413) | 6025001707fd65679d758c877200469d4e72ea88 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6025001707fd65679d758c877200469d4e72ea88 | 2016-08-05 19:56:58+02:00 |
unify spelling of serialize
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/12104)
| aa97970c1a69ae15b4191aa58cdb56e016f15922 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/aa97970c1a69ae15b4191aa58cdb56e016f15922 | 2020-06-11 09:42:34+10:00 |
Fix CVE-2022-3786 in punycode decoder.
Fixed the ossl_a2ulabel() function which also contained a potential
buffer overflow, albeit without control of the contents.
This overflow could result in a crash (causing a denial of service).
The function also did not NUL-terminate the output in some cases.
The two issues fixed here were dentified and reported
by Viktor Dukhovni while researching CVE-2022-3602.
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(cherry picked from commit c42165b5706e42f67ef8ef4c351a9a4c5d21639a)
| 680e65b94c916af259bfdc2e25f1ab6e0c7a97d6 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/680e65b94c916af259bfdc2e25f1ab6e0c7a97d6 | 2022-10-27 10:22:47+11:00 |
Avoid negative array index in BIO_debug_callback()
BIO_snprintf() can return -1 on truncation (and overflow as of commit
9cb177301fdab492e4cfef376b28339afe3ef663). Though neither can
realistically occur while printing a pointer and short fixed string into
a buffer of length 256, the analysis to confirm that this the case goes
somewhat far up the call chain, and not all static analyzers can
successfully follow the chain of logic.
It's easy enough to clamp the returned length to be nonnegative before
continuing, which appeases the static analyzer and does not harm the
subsequent code.
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
| a1673e1536729d49cb758b988ac7be368e9b1fdb | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/a1673e1536729d49cb758b988ac7be368e9b1fdb | 2016-03-08 16:44:57-06:00 |
Fix faulty check of padding in x_long.c
Bug uncovered by test
[extended tests]
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3088) | 79b3452faf04f2572f57eb37b618cc603d9983da | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/79b3452faf04f2572f57eb37b618cc603d9983da | 2017-03-31 21:31:43+02:00 |
Improve documentation of BIO_FLAGS_BASE64_NO_NL flag.
Fixes #12491.
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/17744)
| 8bfb7506d210841f2ee4eda8afe96441a0e33fa5 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/8bfb7506d210841f2ee4eda8afe96441a0e33fa5 | 2022-02-21 13:25:25+01:00 |
crypto/ui/ui_openssl.c: let new-line through after query in Windows path.
Originally new-line was suppressed, because double new-line was
observed under wine. But it appears rather to be a wine bug,
because on real Windows new-line is much needed.
Reviewed-by: Richard Levitte <[email protected]>
| 6ebce6803eccc29d00b8b15a858872a1b94d0cf0 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6ebce6803eccc29d00b8b15a858872a1b94d0cf0 | 2016-08-01 10:48:13+02:00 |
Improve some BN documentation.
Thanks to Nicolas Schodet for pointing this out.
Reviewed-by: Tim Hudson <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5141)
| b713c4fff76d84eb67436045b46cc775f40deb47 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b713c4fff76d84eb67436045b46cc775f40deb47 | 2018-01-22 14:41:09-05:00 |
Work around Travis "virtual memory exhausted" error
One particular build was running out of memory. By swapping to debug mode
we reduce the optimisation level which should reduce the amount of memory
required.
[extended tests]
Reviewed-by: Andy Polyakov <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3601) | 042597b0ace7e3adc8a79f6e096eef659ce1d9d5 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/042597b0ace7e3adc8a79f6e096eef659ce1d9d5 | 2017-06-01 17:35:23+01:00 |
err_set_debug(): Prevent possible recursion on malloc failure
Fixes #19331
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19332)
| ed49476a16b8ff2688a53a2ba7e011e6911620f8 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/ed49476a16b8ff2688a53a2ba7e011e6911620f8 | 2022-10-03 10:40:40+02:00 |
Fix DTLS unprocessed records bug
During a DTLS handshake we may get records destined for the next epoch
arrive before we have processed the CCS. In that case we can't decrypt or
verify the record yet, so we buffer it for later use. When we do receive
the CCS we work through the queue of unprocessed records and process them.
Unfortunately the act of processing wipes out any existing packet data
that we were still working through. This includes any records from the new
epoch that were in the same packet as the CCS. We should only process the
buffered records if we've not got any data left.
Reviewed-by: Richard Levitte <[email protected]>
| 738ad946ddf7cbb839447981304df89f5f83b18b | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/738ad946ddf7cbb839447981304df89f5f83b18b | 2016-07-05 09:51:08+01:00 |
Fix encrypt-then-mac implementation for DTLS
OpenSSL 1.1.0 will negotiate EtM on DTLS but will then not actually *do* it.
If we use DTLSv1.2 that will hopefully be harmless since we'll tend to use
an AEAD ciphersuite anyway. But if we're using DTLSv1, then we certainly
will end up using CBC, so EtM is relevant — and we fail to interoperate with
anything that implements EtM correctly.
Fixing it in HEAD and 1.1.0c will mean that 1.1.0[ab] are incompatible with
1.1.0c+... for the limited case of non-AEAD ciphers, where they're *already*
incompatible with other implementations due to this bug anyway. That seems
reasonable enough, so let's do it. The only alternative is just to turn it
off for ever... which *still* leaves 1.0.0[ab] failing to communicate with
non-OpenSSL implementations anyway.
Tested against itself as well as against GnuTLS both with and without EtM.
Reviewed-by: Tim Hudson <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
| e23d5071ec4c7aa6bb2b0f2c3e0fc2182ed7e63f | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e23d5071ec4c7aa6bb2b0f2c3e0fc2182ed7e63f | 2016-10-12 23:12:04+01:00 |
CRL critical extension bugfix
More importantly, port CRL test from boringSSL crypto/x509/x509_test.cc
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/1775) | 2b40699082d1e5d0e94811542c4f0633ab2d5989 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/2b40699082d1e5d0e94811542c4f0633ab2d5989 | 2016-11-28 15:33:40-05:00 |
cmp_mock_srv.c: improve comment on cert to be produced from request template
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: David von Oheimb <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/21086)
| 5def4bbb4be5477146a0fbb4f14ee02df026419c | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/5def4bbb4be5477146a0fbb4f14ee02df026419c | 2023-05-30 21:15:09+02:00 |
chacha/asm/chacha-ppc.pl: improve performance by 40/80% on POWER8/9.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/6419)
| 791cc3029bd2aee7fc6b766b9841ce1e0a14484a | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/791cc3029bd2aee7fc6b766b9841ce1e0a14484a | 2018-06-05 19:59:19+02:00 |
Mark a HelloRequest record as read if we ignore it
Otherwise the client will try to process it again. The second time around
it will try and move the record data into handshake fragment storage and
realise that there is no data left. At that point it marks it as read
anyway. However, it is a bug that we go around the loop a second time, so
we prevent that.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/2200) | 290a0419f0c13a30fb3a1d1a279125c8aeafd17e | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/290a0419f0c13a30fb3a1d1a279125c8aeafd17e | 2017-01-09 17:29:44+00:00 |
ec/curve448/f_generic.c: fix VC-WIN32 debug build failure.
Debugging asserts had implicit casts that triggered the warnings.
However, instead of making the casts explicit it's more appropriate
to perform checks that ensure that implicit casts were safe.
ec/curve448/scalar.c: size_t-fy scalar_decode_short.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5494)
| 9cbcea7e68f0e805109d7d253c31f02ba37b3b2b | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/9cbcea7e68f0e805109d7d253c31f02ba37b3b2b | 2018-03-02 22:16:29+01:00 |
cms: fix memleaks in cms_env.c
CLA: trivial
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/16403)
(cherry picked from commit 58e1e397c6774be11b903c0f88e85bd2b8c4206f)
| 5327da81f0c70e35bdd8860af9af351313ca4ae2 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/5327da81f0c70e35bdd8860af9af351313ca4ae2 | 2021-08-24 22:43:18+08:00 |
VMS getnameinfo() seems to have a bug with returned service string
It seems like it gives back gibberish. If we asked for a numeric
service, it's easy to check for a digit in the first position, and
if there isn't any, rewrite it using older methods.
Reviewed-by: Rich Salz <[email protected]>
| d40cf9bc9c0913310ef2232b13d8e15e73e9d2b4 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/d40cf9bc9c0913310ef2232b13d8e15e73e9d2b4 | 2016-02-10 05:12:52+01:00 |
Fix BIO_f_cipher() flushing
If an error occurs during a flush on a BIO_f_cipher() then in some cases
we could get into an infinite loop. We add a check to make sure we are
making progress during flush and exit if not.
This issue was reported by Octavio Galland who also demonstrated an
infinite loop in CMS encryption as a result of this bug.
The security team has assessed this issue as not a CVE. This occurs on
*encryption* only which is typically processing trusted data. We are not
aware of a way to trigger this with untrusted data.
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19918)
| e51dd6ee1bac6b54debea3f48c6f58b761229b73 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e51dd6ee1bac6b54debea3f48c6f58b761229b73 | 2022-12-06 14:18:53+00:00 |
Fix aesni_xts compile error
Block copy bug..
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/9900)
| f407a9a998f95f693a7127bc76a2c922dfaedbdb | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/f407a9a998f95f693a7127bc76a2c922dfaedbdb | 2019-09-15 19:29:02+10:00 |
Fix a failure to NULL a pointer freed on error.
Inspired by BoringSSL commit 517073cd4b by Eric Roman <[email protected]>
CVE-2015-0209
Reviewed-by: Emilia Käsper <[email protected]>
| 9e442d485008046933cdc7da65080f436a4af089 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/9e442d485008046933cdc7da65080f436a4af089 | 2015-02-09 11:38:41+00:00 |
sha/asm/keccak1600-avx512.pl: absorb bug-fix and minor optimization.
Hardware used for benchmarking courtesy of Atos, experiments run by
Romain Dolbeau <[email protected]>. Kudos!
Reviewed-by: Rich Salz <[email protected]>
| 0d7903f83f84bba1d29225efd999c633a0c5ba01 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/0d7903f83f84bba1d29225efd999c633a0c5ba01 | 2017-07-20 13:56:17+02:00 |
Fix bug in OPENSSL_LH_flush
Fixes #18139.
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/18141)
| e5da68183410c06f7b350a0721bc2bd6057e438e | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e5da68183410c06f7b350a0721bc2bd6057e438e | 2022-04-21 16:10:33+01:00 |
Fix bug in OSSL_CMP_SRV_process_request() on transaction renewal
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Viktor Dukhovni <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/11736)
| 045229cfe88aba44f8b67e7306281f6fbf516625 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/045229cfe88aba44f8b67e7306281f6fbf516625 | 2020-05-04 19:53:09+02:00 |
VMS: don't use /DSF, turn off CALL_DEBUG instead
It turns out that /DSF didn't do any good for our purposes. Instead,
remove the CALL_DEBUG flag from any image we link. This ensures that
we can have debugging information in the image files, but don't
automatically end up in a debugging session upon image activation.
Unfortunately, this means the CALL_DEBUG must be turned on when there
is a need to run with the debugger activated, and to turn it off when
done. This has been documented in NOTES.VMS.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/2957) | 1ae4c07e50a4988c7e2263ad669dc75fe2d494cb | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/1ae4c07e50a4988c7e2263ad669dc75fe2d494cb | 2017-03-15 02:52:20+01:00 |
Improve the documentation of cert path building and validation
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/13735)
| f9ac6f6956a23bd89e1d6bc9b5dcbb3df06544a1 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/f9ac6f6956a23bd89e1d6bc9b5dcbb3df06544a1 | 2020-12-23 23:29:04+01:00 |
[doc/man3][OSSL_ENCODER] Move NOTES to the bottom
For consistency with `OSSL_DECODER.pod`, and `man-pages(7)`, the `NOTES`
section is moved at the end of the file.
According to `man-pages(7)` the recommended section order is:
> NAME
> SYNOPSIS
> CONFIGURATION [Normally only in Section 4]
> DESCRIPTION
> OPTIONS [Normally only in Sections 1, 8]
> EXIT STATUS [Normally only in Sections 1, 8]
> RETURN VALUE [Normally only in Sections 2, 3]
> ERRORS [Typically only in Sections 2, 3]
> ENVIRONMENT
> FILES
> VERSIONS [Normally only in Sections 2, 3]
> CONFORMING TO
> NOTES
> BUGS
> EXAMPLE
> SEE ALSO
This commit does not attempt to fix the order in all pages but focuses
only on `OSSL_ENCODER` which has a "twin" man page in `OSSL_DECODER`,
making the inconsistent section order quite jarring.
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/13932)
| 3a962b2093a6226daa26e4d1855d4eb9f2e5035b | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/3a962b2093a6226daa26e4d1855d4eb9f2e5035b | 2021-01-22 18:50:12+02:00 |
Fix bug in async_fibre_makecontext for POSIX
async_fibre_makecontext was initialise the fibre first and then calling
getcontext(). It should be the other way around because the getcontext
call may overwrite some of the things we just initialised. This didn't
cause an issue on Linux and so the problem went unnoticed. On OS-X it
causes a crash.
Reviewed-by: Rich Salz <[email protected]>
| 90fa7296c22583a0a42203b078979bbfb2fcb11d | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/90fa7296c22583a0a42203b078979bbfb2fcb11d | 2015-10-11 16:17:27+01:00 |
bn/asm/rsax-x86_64.pl: constant-time gather procedure.
Performance penalty is 2% on Linux and 5% on Windows.
CVE-2016-0702
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
| 5ea08bd2fe6538cbccd89f07e6f1cdd5d3e75e3f | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/5ea08bd2fe6538cbccd89f07e6f1cdd5d3e75e3f | 2016-01-25 23:06:45+01:00 |
fix aes-xts bug on aarch64 big-endian env.
Signed-off-by: Liu-ErMeng <[email protected]>
Reviewed-by: Tom Cosgrove <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/20797)
| 4df13d1054e143f1cbf13fa347491807289f87b7 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/4df13d1054e143f1cbf13fa347491807289f87b7 | 2023-04-21 16:04:51+08:00 |
Fix build error for aarch64 big endian.
Modified rev to rev64, because rev only takes integer registers.
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90827
Otherwise, the following error will occur.
Error: operand 1 must be an integer register -- `rev v31.16b,v31.16b'
CLA: trivial
Signed-off-by: Lei Maohui <[email protected]>
Reviewed-by: Shane Lontis <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/9151)
| 7b0fceed21c8929e0c6694f57018aa1dbba03e15 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/7b0fceed21c8929e0c6694f57018aa1dbba03e15 | 2019-06-13 12:17:30+09:00 |
Improve documentation of -no_ssl3, -no_tls1, -no_tls1_1, -no_tls1_2, -no_tls1_3 options
Fixes #19014
CLA: trivial
Reviewed-by: Tom Cosgrove <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Hugo Landau <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/20834)
| 06565f36e78e6155834875ad544bb48838a812e4 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/06565f36e78e6155834875ad544bb48838a812e4 | 2023-04-26 08:11:01+00:00 |
Fix CMP code to not assume NUL terminated strings
ASN.1 strings may not be NUL terminated. Don't assume they are.
CVE-2021-3712
Reviewed-by: Viktor Dukhovni <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: David Benjamin <[email protected]>
| 95f8c1e142df835d03b5b62521383a462fc5470d | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/95f8c1e142df835d03b5b62521383a462fc5470d | 2021-08-18 17:37:23+01:00 |
Update secmemtest and memeleaktest to use the test infrastructure.
It isn't easy to use the test framework since it turns memory debugging
on as well and the CRYPTO_mem_leaks_fp function cannot be called twice.
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3169) | 789dfc478eea50d8f47f192ef8f3d359ae386c78 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/789dfc478eea50d8f47f192ef8f3d359ae386c78 | 2017-04-10 10:05:55+10:00 |
Fix spelling in pod files
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
| 24c2cd3967ed23acc0bd31a3781c4525e2e42a2c | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/24c2cd3967ed23acc0bd31a3781c4525e2e42a2c | 2016-05-01 19:52:58+02:00 |
Fix memory issues in BIO_*printf functions
The internal |fmtstr| function used in processing a "%s" format string
in the BIO_*printf functions could overflow while calculating the length
of a string and cause an OOB read when printing very long strings.
Additionally the internal |doapr_outch| function can attempt to write to
an OOB memory location (at an offset from the NULL pointer) in the event of
a memory allocation failure. In 1.0.2 and below this could be caused where
the size of a buffer to be allocated is greater than INT_MAX. E.g. this
could be in processing a very long "%s" format string. Memory leaks can also
occur.
These issues will only occur on certain platforms where sizeof(size_t) >
sizeof(int). E.g. many 64 bit systems. The first issue may mask the second
issue dependent on compiler behaviour.
These problems could enable attacks where large amounts of untrusted data
is passed to the BIO_*printf functions. If applications use these functions
in this way then they could be vulnerable. OpenSSL itself uses these
functions when printing out human-readable dumps of ASN.1 data. Therefore
applications that print this data could be vulnerable if the data is from
untrusted sources. OpenSSL command line applications could also be
vulnerable where they print out ASN.1 data, or if untrusted data is passed
as command line arguments.
Libssl is not considered directly vulnerable. Additionally certificates etc
received via remote connections via libssl are also unlikely to be able to
trigger these issues because of message size limits enforced within libssl.
CVE-2016-0799
Issue reported by Guido Vranken.
Reviewed-by: Andy Polyakov <[email protected]>
| 9cb177301fdab492e4cfef376b28339afe3ef663 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/9cb177301fdab492e4cfef376b28339afe3ef663 | 2016-02-25 13:09:46+00:00 |
Fix CRL time comparison.
Thanks to David Benjamin <[email protected]> for reporting this bug.
Reviewed-by: Rich Salz <[email protected]>
| e032117db251968bd09badc7d4718c2497302e55 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e032117db251968bd09badc7d4718c2497302e55 | 2016-07-29 17:54:52+01:00 |
Remove the CRYPTO_mem_leaks adjustment for the BIO
CRYPTO_mem_leaks attempts to adjust the count of bytes leaks to not
include the BIO that is being used to print the results out. However this
does not work properly. In all internal cases we switch off recording
the memory allocation during creation of the BIO so it makes no difference.
In other cases if the BIO allocates any additional memory during
construction then the adjustment will be wrong anyway. It also skips over
the BIO memory during print_leak anyway, so the BIO memory is never
added into the total. In other words this was broken in lots of ways and
has been since it was first added.
The simplest solution is just to make it the documented behaviour that
you must turn off memory logging when creating the BIO, and remove all
the adjustment stuff completely. The adjustment code was only ever in
master and never made it to a release branch so there is no loss of
functionality.
This commit also fixes a compilation failure when using
enable-crypto-mdebug.
Reviewed-by: Rich Salz <[email protected]>
| b3895f42a9a90a74097c75e39d87ed3212be18dd | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b3895f42a9a90a74097c75e39d87ed3212be18dd | 2016-03-30 18:12:59+01:00 |
RSA key generation: ensure BN_mod_inverse and BN_mod_exp_mont both get called with BN_FLG_CONSTTIME flag set.
Based on an original patch by Billy Brumley
CVE-2018-0737
Reviewed-by: Rich Salz <[email protected]>
| 54f007af94b8924a46786b34665223c127c19081 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/54f007af94b8924a46786b34665223c127c19081 | 2018-04-12 12:07:53+01:00 |
Travis build matrix adjustments
- do not exclude all clang builds on Linux
- exclude the constantly timeouting -fsanitize=address build on OS/X
- drop some mostly duplicate builds
- change the base linux distro to Bionic
- drop sudo as that is no longer needed - always on
- drop -D__NO_STRING_INLINES where not needed
- memleak test is not working with old clang
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/11468)
| fbc6efbbc16fc1410f776431395ea2b2ad691d4c | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/fbc6efbbc16fc1410f776431395ea2b2ad691d4c | 2020-04-03 17:26:57+02:00 |
Fix build failure with CIPHER_DEBUG
Signed-off-by: Rich Salz <[email protected]>
Reviewed-by: Kurt Roeckx <[email protected]>
| b7557ccf361d61455535d1305f94d04da7235fdb | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/b7557ccf361d61455535d1305f94d04da7235fdb | 2016-01-19 21:15:33+00:00 |
cmp_vfy.c: Fix bug: must verify msg signature also in 3GPP mode
Reviewed-by: Shane Lontis <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/11808)
| 7b1a3a506273bc043cefd7c2202300a9bf81daa0 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/7b1a3a506273bc043cefd7c2202300a9bf81daa0 | 2020-08-18 16:03:29+02:00 |
Use leak sanitizer instead of internal mdebug to check for memory leaks
The leak sanitizer gives better reports (complete stack traces) and
works as a wrapper around the application instead of relying on
cooperative enabling and disabling calls (which are too easy to get
unbalanced).
Related to #8322
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/9294)
| 22c22369bc09988eb8c6fdf4f543581a78fd3eb1 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/22c22369bc09988eb8c6fdf4f543581a78fd3eb1 | 2019-07-02 16:23:27+02:00 |
Reject excessively large primes in DH key generation.
CVE-2018-0732
Signed-off-by: Guido Vranken <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
Reviewed-by: Viktor Dukhovni <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/6457)
| 91f7361f47b082ae61ffe1a7b17bb2adf213c7fe | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/91f7361f47b082ae61ffe1a7b17bb2adf213c7fe | 2018-06-11 19:38:54+02:00 |
Deprecated {OPENSSL,CRYPTO}_debug_mem_{push,pop}
They were only used for recursive ASN1 parsing.
Even if the internal memory-debugging facility remains,
this simplification seems worthwhile.
Reviewed-by: Shane Lontis <[email protected]>
Reviewed-by: Matthias St. Pierre <[email protected]>
Reviewed-by: Richard Levitte <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/9342)
| e7aa7c11c71e84b2d6c06b1c81d130e8c1fba296 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e7aa7c11c71e84b2d6c06b1c81d130e8c1fba296 | 2019-07-10 16:22:12-04:00 |
chacha/asm/chacha-ppc.pl: fix big-endian build.
It's kind of a "brown-bag" bug, as I did recognize the problem and
verified an ad-hoc solution, but failed to follow up with cross-checks
prior filing previous merge request.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/6435)
| 10f279713ae39736ca1c7bcb09e240c7c5fb298a | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/10f279713ae39736ca1c7bcb09e240c7c5fb298a | 2018-06-07 14:04:34+02:00 |
Drop the optimisation level for ppc64le cross-compile
The default cross compiler (gcc 9.4.0) for ppc64le on Ubunut 20.04 seems
buggy and causes a seg fault in sslapitest. This doesn't impact any other
CI cross compile platforms and does not seem to impact the gcc 10.3.0 cross
compiler.
We just drop the optimisation level on that platform.
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Hugo Landau <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/19056)
| 200d9521a0d406a7d02778d1c6c5a5230caeecf5 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/200d9521a0d406a7d02778d1c6c5a5230caeecf5 | 2022-08-24 15:10:56+01:00 |
Fix common test framework options
PR#6975 added the ability to our test framework to have common options to
all tests. For example providing the option "-test 5" to one of our test
programs will just run test number 5. This can be useful when debugging
tests.
Unforuntately this does not work well for a number of tests. In particular
those tests that call test_get_argument() without first skipping over these
common test options will not get the expected value. Some tests did this
correctly but a large number did not.
A helper function is introduced, test_skip_common_options(), to make this
easier for those tests which do not have their own specialised test option
handling, but yet still need to call test_get_argument(). This function
call is then added to all those tests that need it.
Reviewed-by: Shane Lontis <[email protected]>
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/10975)
| 8d242823ed2270e2907914fb09004ae30263fb00 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/8d242823ed2270e2907914fb09004ae30263fb00 | 2020-01-30 15:30:17+00:00 |
x509: improve error reporting
Distinguish between not being able to extract a public key versus not knowing
the key's type.
Alternative to #15921
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/15944)
| 10af976962b2383bb3044120a764037361b8bff7 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/10af976962b2383bb3044120a764037361b8bff7 | 2021-06-29 11:43:00+10:00 |
Add a test for setting initial SNI in CH but not using it with early_data
Test for the bug where early_data is not accepted by the server when it
does not have an SNI callback set up, but the client sent a servername in
the initial ClientHello establishing the session.
Reviewed-by: Rich Salz <[email protected]>
Reviewed-by: Ben Kaduk <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/4519)
| 141e470947327e0c4e8ef3c299b42d01064c484c | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/141e470947327e0c4e8ef3c299b42d01064c484c | 2017-10-11 14:42:25+01:00 |
Fix Seg fault in DTLSv1_listen
The DTLSv1_listen function is intended to be stateless and processes
the initial ClientHello from many peers. It is common for user code to
loop over the call to DTLSv1_listen until a valid ClientHello is received
with an associated cookie. A defect in the implementation of DTLSv1_listen
means that state is preserved in the SSL object from one invokation to the
next that can lead to a segmentation fault. Erorrs processing the initial
ClientHello can trigger this scenario. An example of such an error could
be that a DTLS1.0 only client is attempting to connect to a DTLS1.2 only
server.
CVE-2015-0207
Reviewed-by: Richard Levitte <[email protected]>
| e83ee04bb7de800cdb71d522fa562e99328003a3 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/e83ee04bb7de800cdb71d522fa562e99328003a3 | 2015-03-09 16:09:04+00:00 |
Fix a memleak in tls13_generate_secret.
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3660) | 71d8c138cf0a72663cd401d753564eecd8c23289 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/71d8c138cf0a72663cd401d753564eecd8c23289 | 2017-06-12 19:30:10+02:00 |
Test ocsp with invalid responses and the "-no_cert_checks" option
The "-no_cert_checks" option causes the flag OCSP_NOCHECKS to be set.
The bug fixed in the previous commit will cause the ocsp app to respond with
a success result in the case when the OCSP response signing certificate
fails to verify and -no_cert_checks is used - so we test that it fails in
this case.
Reviewed-by: Paul Dale <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
| 6ee1f4f40b5100ef2744866a727bb4b9ef8ea39e | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6ee1f4f40b5100ef2744866a727bb4b9ef8ea39e | 2022-04-13 16:47:35+01:00 |
bio: improve error checking fixing coverity 1485659 & 1485665
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/15635)
| 37bbe449294b63f87b03e792cae465b0b095299a | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/37bbe449294b63f87b03e792cae465b0b095299a | 2021-06-07 09:20:16+10:00 |
improve comment: use "optimization" for clarity
The previous word was a misspelling of nicety
Reviewed-by: Richard Levitte <[email protected]>
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/3464) | 6bcb4175e64f1883b8125d18d8898d30391b19bf | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/6bcb4175e64f1883b8125d18d8898d30391b19bf | 2017-05-14 09:17:30+00:00 |
Fix NULL pointer dereference for BN_mod_exp2_mont
This fixes a bug whereby BN_mod_exp2_mont can dereference a NULL pointer
if BIGNUM argument m represents zero.
Regression test added. Fixes #17648.
Reviewed-by: Matt Caswell <[email protected]>
Reviewed-by: Tomas Mraz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/17783)
| 43135a5d2274c24e97f50e16ce492c22eb717ab2 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/43135a5d2274c24e97f50e16ce492c22eb717ab2 | 2022-03-01 14:08:12+00:00 |
ERR: Add new building blocks for reporting errors
The new building block are ERR_new(), ERR_set_debug(),
ERR_set_error(), ERR_vset_error(), which allocate a new error record
and set the diverse data in them. They are designed in such a way
that it's reasonably easy to create macros that use all of them but
then rely completely on the function signature of ERR_set_error() or
ERR_vset_error().
Reviewed-by: Paul Dale <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/9452)
| 7c0e20dc6f11aa506abc99ccc90b3a39c48c3052 | openssl | neuralsentry | 1 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/7c0e20dc6f11aa506abc99ccc90b3a39c48c3052 | 2019-07-24 13:03:32+02:00 |
Fix spelling
Signed-off-by: Kurt Roeckx <[email protected]>
Reviewed-by: Matt Caswell <[email protected]>
GH: #1021
| d5e86796843ff0b1dab087ce2a6f867768436b63 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/d5e86796843ff0b1dab087ce2a6f867768436b63 | 2016-05-03 19:34:03+02:00 |
Update evp_test to make sure passing partial block to "Update" is ok
The previous commit fixed a bug where a partial block had been passed to
an "Update" function and it wasn't properly handled. We should catch this
type of error in evp_test.
Reviewed-by: Rich Salz <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/2275) | 0b96d77a62d8ac9a45ac1dda47560ced676b5b8d | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/0b96d77a62d8ac9a45ac1dda47560ced676b5b8d | 2017-01-23 12:45:33+00:00 |
Remove debugging prints from util/add-depends.pl
Reviewed-by: Andy Polyakov <[email protected]>
(Merged from https://github.com/openssl/openssl/pull/5608)
| 4ba5ce651790264cdd0e1af3564cf68f8be9ac81 | openssl | neuralsentry | 0 | https://github.com/openssl/openssl | https://github.com/openssl/openssl/commit/4ba5ce651790264cdd0e1af3564cf68f8be9ac81 | 2018-03-13 19:38:04+01:00 |
Subsets and Splits