commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
qjson: replace QString in JSONLexer with GString JSONLexer only needs a simple resizable buffer. json-streamer.c can allocate memory for each token instead of relying on reference counting of QStrings. Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> [Straightforwardly rebased on my patches, checkpatch made happy] Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]>
d2ca7c0b0d876cf0e219ae7a92252626b0913a28
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d2ca7c0b0d876cf0e219ae7a92252626b0913a28
2015-11-26 09:31:22+01:00
target-mips: add PC, XNP reg numbers to RDHWR Add Performance Counter (4) and XNP (5) register numbers to RDHWR. Add check_hwrena() to simplify access control checkings. Add RDHWR support to microMIPS R6. Signed-off-by: Yongbok Kim <[email protected]> Reviewed-by: Leon Alrae <[email protected]> Signed-off-by: Leon Alrae <[email protected]>
b00c72180c36510bf9b124e190bd520e3b7e1358
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b00c72180c36510bf9b124e190bd520e3b7e1358
2015-10-30 14:35:52+00:00
postcopy: OS support test Provide a check to see if the OS we're running on has all the bits needed for postcopy. Creates postcopy-ram.c which will get most of the other helpers we need. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Amit Shah <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
eb59db53a4f23420f127ec7aad2a672f787df697
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/eb59db53a4f23420f127ec7aad2a672f787df697
2015-11-10 15:00:26+01:00
hw/acpi/aml-build: remove useless glib version check 2.22 is the minimum version required Signed-off-by: Marc-André Lureau <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
3c15d3a45045de82c744c49ff471d4c7ba405187
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3c15d3a45045de82c744c49ff471d4c7ba405187
2015-11-06 15:42:37+03:00
qemu-iotests: fix -valgrind option for check Commit 934659c switched the iotests to run qemu-io from a bash subshell, in order to catch segfaults. This method is incompatible with the current valgrind_qemu_io() bash function. Move the valgrind usage into the exec subshell in _qemu_io_wrapper(), while making sure the original return value is passed back to the caller. Update test output for tests 039, 061, and 137 as it looks for the specific subshell command when the process is terminated. Reported-by: Kevin Wolf <[email protected]> Signed-off-by: Jeff Cody <[email protected]> Message-id: 0066fd85d26ca641a1c25135ff2479b7985701cf.1446232490.git.jcody@redhat.com Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Max Reitz <[email protected]>
e6c17669eb0868013d9a17050d8eb2d598f06067
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e6c17669eb0868013d9a17050d8eb2d598f06067
2015-11-11 16:55:28+01:00
block: Convert to new qapi union layout We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This leads to spurious collisions if a tag value matches a non-variant member's name. Make the conversion to the new layout for block-related code. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [Commit message tweaked slightly] Signed-off-by: Markus Armbruster <[email protected]>
6a8f9661dc3c088ed0d2f5b41d940190407cbdc5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6a8f9661dc3c088ed0d2f5b41d940190407cbdc5
2015-11-02 08:30:27+01:00
vl.c: Replace fprintf(stderr) with error_report() Straightforward replacement, except for qemu_kill_report(), which printed a common part of its error message first, then the applicable special part. Print each complete message with a single error_report() instead. Multi-line messages were replaced by error_report() followed by error_printf(). The following changes were made to the error messages: * The "invalid date format" message was reworded to better fit the new error_report()+error_printf() pattern. * On the remaining messages, only the trailing newlines, "qemu:" and "error:" message prefixes were removed. Signed-off-by: Eduardo Habkost <[email protected]> Message-Id: <[email protected]> [Squashed in Message-Id: <[email protected]> and updated commit message] Signed-off-by: Markus Armbruster <[email protected]>
f61eddcb2bb5cbbdd1d911b7e937db9affc29028
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f61eddcb2bb5cbbdd1d911b7e937db9affc29028
2015-11-03 09:37:50+01:00
tests: add ivshmem qtest Adds 4 ivshmemtests: - single qemu instance and basic IO - pair of instances, check memory sharing - pair of instances with server, and MSIX - hot plug/unplug A temporary shm is created as well as a directory to place server socket, both should be clear on exit and abort. Cc: Cam Macdonell <[email protected]> Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Claudio Fontana <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
ddef6a0d68f641ca89466c697d191d07b7e6718c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ddef6a0d68f641ca89466c697d191d07b7e6718c
2015-10-26 10:19:48+01:00
qapi-visit: Convert to new qapi union layout We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This leads to spurious collisions if a tag value matches a non-variant member's name. Make the conversion to the new layout for qapi-visit.py. Generated code changes look like: |@@ -4912,16 +4912,16 @@ void visit_type_MemoryDeviceInfo(Visitor | if (!*obj) { | goto out_obj; | } |- visit_type_MemoryDeviceInfoKind(v, &(*obj)->kind, "type", &err); |+ visit_type_MemoryDeviceInfoKind(v, &(*obj)->type, "type", &err); | if (err) { | goto out_obj; | } |- if (!visit_start_union(v, !!(*obj)->data, &err) || err) { |+ if (!visit_start_union(v, !!(*obj)->u.data, &err) || err) { | goto out_obj; | } |- switch ((*obj)->kind) { |+ switch ((*obj)->type) { | case MEMORY_DEVICE_INFO_KIND_DIMM: |- visit_type_PCDIMMDeviceInfo(v, &(*obj)->dimm, "data", &err); |+ visit_type_PCDIMMDeviceInfo(v, &(*obj)->u.dimm, "data", &err); | break; | default: | abort(); |@@ -4930,7 +4930,7 @@ out_obj: | error_propagate(errp, err); | err = NULL; | if (*obj) { |- visit_end_union(v, !!(*obj)->data, &err); |+ visit_end_union(v, !!(*obj)->u.data, &err); | } | error_propagate(errp, err); | err = NULL; Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [Commit message tweaked slightly] Signed-off-by: Markus Armbruster <[email protected]>
150d0564a4c626642897c748f7906260a13c14e1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/150d0564a4c626642897c748f7906260a13c14e1
2015-11-02 08:30:27+01:00
target-i386: Enable "check" mode by default Current default behavior of QEMU is to silently disable features that are not supported by the host when a CPU model is requested in the command-line. This means that in addition to risking breaking guest ABI by default, we are silent about it. I would like to enable "enforce" by default, but this can easily break existing production systems because of the way libvirt makes assumptions about CPU models today (this will change in the future, once QEMU provide a proper interface for checking if a CPU model is runnable). But there's no reason we should be silent about it. So, change target-i386 to enable "check" mode by default so at least we have some warning printed to stderr (and hopefully logged somewhere) when QEMU disables a feature that is not supported by the host system. Reviewed-by: Igor Mammedov <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
15e41345906d29a319cc9cdf566347bf79134d24
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/15e41345906d29a319cc9cdf566347bf79134d24
2015-10-27 16:12:15-02:00
kvm: Move x86-specific functions into target-i386/kvm.c The functions for checking xcrs, xsave and pit_state2 are only used on x86, so they should reside in target-i386/kvm.c. Signed-off-by: Thomas Huth <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
28143b409f698210d85165ca518235ac7e7c5ac5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/28143b409f698210d85165ca518235ac7e7c5ac5
2015-10-19 10:13:07+02:00
block: Fix BB AIOCB AioContext without BDS Fix the BlockBackend's AIOCB AioContext for aborting AIO in case there is no BDS. If there is no implementation of AIOCBInfo::get_aio_context() the AioContext is derived from the BDS the AIOCB belongs to. If that BDS is NULL (because it has been removed from the BB) this will not work. This patch makes blk_get_aio_context() fall back to the main loop context if the BDS pointer is NULL and implements AIOCBInfo::get_aio_context() (blk_aiocb_get_aio_context()) which invokes blk_get_aio_context(). Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
4981bdec0d9b3ddd3e1474de5aa9918f120b54f7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4981bdec0d9b3ddd3e1474de5aa9918f120b54f7
2015-10-23 18:18:23+02:00
target-arm: Fix GDB breakpoint handling GDB breakpoints have higher priority so they have to be checked first. Should GDB breakpoint match, just return from the debug exception handler. Signed-off-by: Sergey Fedorov <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
e63a2d4d9ed73e33a0b7483085808048be8bbcb1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e63a2d4d9ed73e33a0b7483085808048be8bbcb1
2015-10-16 14:48:56+01:00
qapi: Unbox base members Rather than storing a base class as a pointer to a box, just store the fields of that base class in the same order, so that a child struct can be directly cast to its parent. This gives less malloc overhead, less pointer dereferencing, and even less generated code. Compare to the earlier commit 1e6c1616a "qapi: Generate a nicer struct for flat unions" (although that patch had fewer places to change, as less of qemu was directly using qapi structs for flat unions). It also allows us to turn on automatic type-safe wrappers for upcasting to the base class of a struct. Changes to the generated code look like this in qapi-types.h: | struct SpiceChannel { |- SpiceBasicInfo *base; |+ /* Members inherited from SpiceBasicInfo: */ |+ char *host; |+ char *port; |+ NetworkAddressFamily family; |+ /* Own members: */ | int64_t connection_id; as well as additional upcast functions like qapi_SpiceChannel_base(). Meanwhile, changes to qapi-visit.c look like: | static void visit_type_SpiceChannel_fields(Visitor *v, SpiceChannel **obj, Error **errp) | { | Error *err = NULL; | |- visit_type_implicit_SpiceBasicInfo(v, &(*obj)->base, &err); |+ visit_type_SpiceBasicInfo_fields(v, (SpiceBasicInfo **)obj, &err); | if (err) { (the cast is necessary, since our upcast wrappers only deal with a single pointer, not pointer-to-pointer); plus the wholesale elimination of some now-unused visit_type_implicit_FOO() functions. Without boxing, the corner case of one empty struct having another empty struct as its base type now requires inserting a dummy member (previously, the 'Base *base' member sufficed). And now that we no longer consume a 'base' member in the generated C struct, we can delete the former negative struct-base-clash-base test. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [Commit message tweaked slightly] Signed-off-by: Markus Armbruster <[email protected]>
ddf21908961073199f3d186204da4810f2ea150b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ddf21908961073199f3d186204da4810f2ea150b
2015-11-02 08:30:26+01:00
target-i386/kvm: Hyper-V HV_X64_MSR_RESET support HV_X64_MSR_RESET msr is used by Hyper-V based Windows guest to reset guest VM by hypervisor. This msr is stateless so no migration/fetch/update is required. This code checks cpu option "hv-reset" and support by kernel. If both conditions are met appropriate Hyper-V features cpuid bit is set. Signed-off-by: Andrey Smetanin <[email protected]> Signed-off-by: Denis V. Lunev <[email protected]> CC: Paolo Bonzini <[email protected]> CC: Richard Henderson <[email protected]> CC: Eduardo Habkost <[email protected]> CC: "Andreas Färber" <[email protected]> CC: Marcelo Tosatti <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
744b8a9440fa2bd78ae64861667337439e25a6dc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/744b8a9440fa2bd78ae64861667337439e25a6dc
2015-10-12 18:29:26+02:00
qapi-tests: New tests for union, alternate command arguments A command's 'data' must be a struct type, given either as a dictionary, or as struct type name. Existing test case data-int.json covers simple type 'int'. Add test cases for type names referring to union and alternate types. The latter is caught (good), but the former is not (bug). Events have the same problem, but since they get checked by the same code, we don't bother to duplicate the tests. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]>
d9658d58e33128df32093b7a84bed76b527fb884
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d9658d58e33128df32093b7a84bed76b527fb884
2015-09-04 15:47:15+02:00
virtio-scsi: use virtqueue_map_sg() when loading requests The VirtQueueElement struct is serialized during migration but the in_sg[]/out_sg[] iovec arrays are not usable on the destination host because the pointers are meaningless. Use virtqueue_map_sg() to refresh in_sg[]/out_sg[] to valid pointers based on in_addr[]/out_addr[] hwaddrs. Cc: Paolo Bonzini <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1cc933453bf2baae1feb7c8e757bdfd0ef639002
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1cc933453bf2baae1feb7c8e757bdfd0ef639002
2015-07-30 15:43:58+02:00
tests: remove irrelevant assertions from test-aio In these tests, the purpose of the initial calls to aio_poll and g_main_context_iteration is simply to put the AioContext in a known state; the return value of the function does not really matter. The next patch will change those return values; change the assertions to a while loop which expresses the intention better. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Tested-by: Richard W.M. Jones <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
12d69ac03b45156356b240424623719f15d8143e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/12d69ac03b45156356b240424623719f15d8143e
2015-07-22 12:41:40+01:00
framebuffer: set DIRTY_MEMORY_VGA on RAM that is used for the framebuffer The MemoryRegionSection contains enough information to access the RAM region underlying the framebuffer, and can be cached inside the display device. By doing this, the new framebuffer_update_memory_section function can enable dirty memory logging on the relevant RAM region. The function must be called whenever the stride or base of the framebuffer changes; a simple way to cover these cases is to call it on every full frame invalidation, which is a rare case. framebuffer_update_display now works entirely on a MemoryRegionSection, without going through cpu_physical_memory_map/unmap. Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
c1076c3e13a86140cc2ba29866512df8460cc7c2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c1076c3e13a86140cc2ba29866512df8460cc7c2
2015-07-24 13:57:45+02:00
target-s390x: fix CONVERT TO BINARY (CVD, CVDY) current_number being shift left by more than 32 bits, we can't use a simple int. Similarly use an int64_t type for the input binary value, to not get the -2^31 case wrong. Finally don't initialize shift to 4, it's already done in the for loop. Signed-off-by: Aurelien Jarno <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
92f2b4e71e988ad2751c71717e9fe3387753442a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/92f2b4e71e988ad2751c71717e9fe3387753442a
2015-07-07 17:51:47+02:00
ich9: add smm_enabled field and arguments Q35's ACPI device is hard-coding SMM availability to KVM. Place the logic where the board is created instead, so that it will be possible to override it. Acked-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
fba72476c6b7be60ac74c5bcdc06c61242d1fe4f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fba72476c6b7be60ac74c5bcdc06c61242d1fe4f
2015-07-06 17:59:44+02:00
target-arm: kvm: Differentiate registers based on write-back levels Some registers like the CNTVCT register should only be written to the kernel as part of machine initialization or on vmload operations, but never during runtime, as this can potentially make time go backwards or create inconsistent time observations between VCPUs. Introduce a list of registers that should not be written back at runtime and check this list on syncing the register state to the KVM state. Signed-off-by: Christoffer Dall <[email protected]> Message-id: [email protected] [PMM: tweaked a few comments, added the new argument to the stub write_list_to_kvmstate() in target-arm/kvm-stub.c] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
4b7a6bf402bd064605c287eecadc493ccf2d4897
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4b7a6bf402bd064605c287eecadc493ccf2d4897
2015-07-21 11:18:45+01:00
qemu-iotests: Add test case for mirror with unmap This checks that the discard on mirror source that effectively zeroes data is also reflected by the data of target. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: John Snow <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
c615091793f53ff33b8f6c1b1ba711cf7c93e97b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c615091793f53ff33b8f6c1b1ba711cf7c93e97b
2015-07-02 10:06:23+01:00
target-mips: add microMIPS32 R6 opcode enum Add microMIPS32 Release 6 opcode enum. Remove RI checking for pre-R6 reserved opcode. Signed-off-by: Yongbok Kim <[email protected]> Reviewed-by: Aurelien Jarno <[email protected]> Signed-off-by: Leon Alrae <[email protected]>
3a1f426828cd8ffeec1a4fa8ca6ca3ed4f800edb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3a1f426828cd8ffeec1a4fa8ca6ca3ed4f800edb
2015-06-26 09:22:25+01:00
target-arm: Split DISAS_YIELD from DISAS_WFE Currently we use DISAS_WFE for both WFE and YIELD instructions. This is functionally correct because at the moment both of them are implemented as "yield this CPU back to the top level loop so another CPU has a chance to run". However it's rather confusing that YIELD ends up calling HELPER(wfe), and if we ever want to implement real behaviour for WFE and SEV it's likely to trip us up. Split out the yield codepath to use DISAS_YIELD and a new HELPER(yield) function, and have HELPER(wfe) call HELPER(yield). Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected] Reviewed-by: Peter Crosthwaite <[email protected]>
049e24a191c212d9468db84169197887f2c91586
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/049e24a191c212d9468db84169197887f2c91586
2015-07-06 10:05:44+01:00
vl: Use error_report() for --display errors Results in nicer error messages. Before this patch: Invalid GTK option string: gtk,lirum-larum After: qemu-system-x86_64: -display gtk,lirum-larum: Invalid GTK option string Of course, the thing ought to use QemuOpts instead of parsing by hand. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Luiz Capitulino <[email protected]>
c6bf0f7ffa90c720377eb6bddd27037041acbc5b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c6bf0f7ffa90c720377eb6bddd27037041acbc5b
2015-06-22 18:20:39+02:00
block: Change bitmap truncate conditional to assertion This is an artifact of an older version that had both all-bitmap and single-bitmap truncate functions, and some info got lost in the shuffle. Bitmaps can only be frozen during a backup operation, and a backup operation should prevent a resize operation, so just assert that this cannot happen. Suggested-by: Kevin Wolf <[email protected]> Signed-off-by: John Snow <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
06207b0ff596aa4bb192d1fafc593847ed888e39
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/06207b0ff596aa4bb192d1fafc593847ed888e39
2015-06-12 15:54:01+02:00
net/socket: Drop net_socket_can_send This callback is called by main loop before polling s->fd, if it returns false, the fd will not be polled in this iteration. This is redundant with checks inside read callback. After this patch, the data will be sent to peer when it arrives. If the device can't receive, it will be queued to incoming_queue, and when the device status changes, this queue will be flushed. If the peer is not ready, disable the read poll until send completes. Signed-off-by: Fam Zheng <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
6e99c631f116221d169ea53953d91b8aa74d297a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6e99c631f116221d169ea53953d91b8aa74d297a
2015-06-12 13:26:21+01:00
target-s390x: mvc_fast_memmove: access memory through softmmu mvc_fast_memmove is bypassing the softmmu functions, getting the physical source and destination addresses using the mmu_translate function and accessing the corresponding physical memory. This prevents watchpoints to work correctly. Instead use the tlb_vaddr_to_host function to get the host addresses corresponding to the guest source and destination addresses through the softmmu code and fallback to the byte level code in case the corresponding address are not in the QEMU TLB or being examined through a watchpoint. As a bonus it works even for area crossing pages by splitting the are into chunks contained in a single page, bringing some performances improvements. We can therefore remove the 8-byte loads/stores method, as it is now quite unlikely to be used. At the same time change the name of the function to fast_memmove as it's not specific to mvc and use the same argument order as the C memmove function. Signed-off-by: Aurelien Jarno <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
6da528d14de29138ca5ac43d6d059889dd24f464
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6da528d14de29138ca5ac43d6d059889dd24f464
2015-06-17 12:40:51+02:00
Move loadvm_handlers into MigrationIncomingState In postcopy we need the loadvm_handlers to be used in a couple of different instances of the loadvm loop/routine, and thus it can't be local any more. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: David Gibson <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
1a8f46f8d61ef885ff9d0bda251e4e9830c932ef
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1a8f46f8d61ef885ff9d0bda251e4e9830c932ef
2015-06-12 06:54:01+02:00
qemu-nbd: Switch to qemu_set_fd_handler Achieved by: - Remembering the server fd with a global variable, in order to access it from nbd_client_closed. - Checking nbd_can_accept() and updating server_fd handler whenever client connects or disconnects. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
e4afbf4fb4d026510700cb40bb72dea9aef14e3b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e4afbf4fb4d026510700cb40bb72dea9aef14e3b
2015-06-05 17:09:58+02:00
qapi: use valid JSON in schema * qapi-schema.json: JSON doesn't allow trailing commas. Signed-off-by: Eric Blake <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
c85a128480a3d05d2002728c449a32e32663e7de
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c85a128480a3d05d2002728c449a32e32663e7de
2013-04-12 09:41:54-04:00
ui: add egl-helpers Add helper functions to initialize OpenGL using egl. Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Max Reitz <[email protected]>
7ced9e9f6da2257224591b91727cfeee4f3977fb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7ced9e9f6da2257224591b91727cfeee4f3977fb
2015-05-29 11:11:38+02:00
monitor: Improve and document client_migrate_info protocol error Protocol must be spice, vnc isn't implemented. Fix up documentation. Attempts to use vnc or any other unknown protocol yield the misleading error message "Invalid parameter 'protocol'". Improve it to "Parameter 'protocol' expects spice". Cc: Gerd Hoffmann <[email protected]> Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by. Gerd Hoffmann <[email protected]> Reviewed-by: Luiz Capitulino <[email protected]>
13cadefbda71e119db79fe0b7a4efd26a6d005bd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/13cadefbda71e119db79fe0b7a4efd26a6d005bd
2015-06-02 09:59:13+02:00
hw/pci-bridge: disable SHPC in PXB OVMF downloads the ACPI linker/loader script from QEMU when the edk2 PCI Bus driver globally signals the firmware that PCI enumeration and resource allocation have completed. At this point QEMU regenerates the ACPI payload in an fw_cfg read callback, and this is when the PXB's _CRS gets populated. Unfortunately, when this happens, the PCI_COMMAND_MEMORY bit is clear in the root bus's command register, *unlike* under SeaBIOS. The consequences unfold as follows: - When build_crs() fetches dev->io_regions[i].addr, it is all-bits-one, because pci_update_mappings() --> pci_bar_address() calculated it as PCI_BAR_UNMAPPED, due to the PCI_COMMAND_MEMORY bit being clear. - Consequently, the SHPC MMIO BAR (bar 0) of the bridge is not added to the _CRS, *despite* having been programmed in PCI config space. - Similarly, the SHPC MMIO BAR of the PXB is not removed from the main root bus's DWordMemory descriptor. - Guest OSes (Linux and Windows alike) notice the pre-programmed SHPC BAR within the PXB's config space, and notice that it conflicts with the main root bus's memory resource descriptors. Linux reports pci 0000:04:00.0: BAR 0: can't assign mem (size 0x100) pci 0000:04:00.0: BAR 0: trying firmware assignment [mem 0x88200000-0x882000ff 64bit] pci 0000:04:00.0: BAR 0: [mem 0x88200000-0x882000ff 64bit] conflicts with PCI Bus 0000:00 [mem 0x88200000-0xfebfffff] While Windows Server 2012 R2 reports https://technet.microsoft.com/en-us/library/cc732199%28v=ws.10%29.aspx This device cannot find enough free resources that it can use. If you want to use this device, you will need to disable one of the other devices on this system. (Code 12) This issue was apparently encountered earlier, see the "hack" in: https://lists.nongnu.org/archive/html/qemu-devel/2015-01/msg02983.html and the current hole-punching logic in build_crs() and build_ssdt() is probably supposed to remedy exactly that problem -- however, for OVMF they don't work, because at the end of the PCI enumeration and resource allocation, which cues the ACPI linker/loader client, the command register is clear. The "shpc" property of "pci-bridge", introduced in the previous patches, allows us to disable the standard hotplug controller cleanly, eliminating the SHPC bar and the conflict. Cc: Michael S. Tsirkin <[email protected]> Cc: Marcel Apfelbaum <[email protected]> Signed-off-by: Laszlo Ersek <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
d10dda2d60c8c225a89a53d53add799b69f6bb46
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d10dda2d60c8c225a89a53d53add799b69f6bb46
2015-06-23 22:57:49+02:00
spapr_events: re-use EPOW event infrastructure for hotplug events This extends the data structures currently used to report EPOW events to guests via the check-exception RTAS interfaces to also include event types for hotplug/unplug events. This is currently undocumented and being finalized for inclusion in PAPR specification, but we implement this here as an extension for guest userspace tools to implement (existing guest kernels simply log these events via a sysfs interface that's read by rtas_errd, and current versions of rtas_errd/powerpc-utils already support the use of this mechanism for initiating hotplug operations). We also add support for queues of pending RTAS events, since in the case of hotplug there's chance for multiple events being in-flight at any point in time. Signed-off-by: Nathan Fontenot <[email protected]> Signed-off-by: Michael Roth <[email protected]> Reviewed-by: David Gibson <[email protected]> Signed-off-by: David Gibson <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
31fe14d15d08d613ff38abb249911e98c7966b86
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/31fe14d15d08d613ff38abb249911e98c7966b86
2015-06-03 23:56:53+02:00
qcow2: make qcow2_cache_put() a void function This function never receives an invalid table pointer, so we can make it void and remove all the error checking code. Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
a3f1afb43a09e4577571c044c48f2ba9e6e4ad06
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a3f1afb43a09e4577571c044c48f2ba9e6e4ad06
2015-05-22 17:08:01+02:00
target-alpha: Disallow literal operand to 1C.30 to 1C.37 Before 64f45e49 we used to have literal checks for 4 of these 8 opcodes. Confirmed that real hardware doesn't allow them. Reported-by: Al Viro <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
ed0851380c8ed181ddd6ed3542b14fcb0bca6700
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ed0851380c8ed181ddd6ed3542b14fcb0bca6700
2015-05-18 13:03:47-07:00
target-arm: Extend FP checks to use an EL Extend the ARM disassemble context to take a target exception EL instead of a boolean enable. This change reverses the polarity of the check making a value of 0 indicate floating point enabled (no exception). Signed-off-by: Greg Bellows <[email protected]> [PMM: Use a common TB flag field for AArch32 and AArch64; CPTR_EL2 exists in v7; CPTR_EL2 should trap for EL2 accesses; CPTR_EL2 should not trap for secure accesses; CPTR_EL3 should trap for EL3 accesses; CPACR traps for secure accesses should trap to EL3 if EL3 is AArch32] Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]>
9dbbc748d671c70599101836cd1c2719d92f3017
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9dbbc748d671c70599101836cd1c2719d92f3017
2015-05-29 11:28:53+01:00
console: add dpy_ui_info_supported Allow ui code to check whenever the emulated display supports display change notifications. Signed-off-by: Gerd Hoffmann <[email protected]>
b7fb49f0c709a406f79372be397367ff2550373b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b7fb49f0c709a406f79372be397367ff2550373b
2015-05-06 08:38:05+02:00
s390x/kvm: passing max memory size to accelerator With "KVM: s390: Allow userspace to limit guest memory size" KVM is able to do some optimizations based on the guest memory limit. The guest memory limit is computed by the initial definition and with the notion of hotplugged memory. Reviewed-by: Thomas Huth <[email protected]> Reviewed-by: Guenther Hutzl <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Signed-off-by: Dominik Dingel <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Message-Id: <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
a310b283e357b54533c8168a92e8f1068efdc4d1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a310b283e357b54533c8168a92e8f1068efdc4d1
2015-03-10 09:26:23+01:00
hw/intc/arm_gic: Add Interrupt Group Registers The Interrupt Group Registers allow the guest to configure interrupts into one of two groups, where Group0 are higher priority and may be routed to IRQ or FIQ, and Group1 are lower priority and always routed to IRQ. (In a GIC with the security extensions Group0 is Secure interrupts and Group 1 is NonSecure.) The GICv2 always supports interrupt grouping; the GICv1 does only if it implements the security extensions. This patch implements the ability to read and write the registers; the actual functionality the bits control will be added in a subsequent patch. Signed-off-by: Fabian Aggeler <[email protected]> Signed-off-by: Greg Bellows <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected] Message-id: [email protected] [PMM: bring GIC_*_GROUP macros into line with the others, ie a simple SET/CLEAR/TEST rather than GROUP0/GROUP1; utility gic_has_groups() function; minor style fixes; bump vmstate version] Signed-off-by: Peter Maydell <[email protected]>
c27a5ba94874cb3a29e21b3ad4bd5e504aea93b2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c27a5ba94874cb3a29e21b3ad4bd5e504aea93b2
2015-05-12 11:57:17+01:00
target-arm: A64: Avoid signed shifts in disas_ldst_pair() Avoid shifting potentially negative signed offset values in disas_ldst_pair() by keeping the offset in a uint64_t rather than an int64_t. Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected]
c2ebd862a54b7e12175d65c03ba259926cb2237a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c2ebd862a54b7e12175d65c03ba259926cb2237a
2015-02-13 05:46:09+00:00
vhost-scsi: expose the TYPE_FW_PATH_PROVIDER interface In the way, we can make the bootindex property take effect. At the meanwhile, the firmware path name of vhost-scsi is "channel@channel/vhost-scsi@target,lun". Signed-off-by: Gonglei <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1956cf6fa1039647327ef333dc09b43775907305
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1956cf6fa1039647327ef333dc09b43775907305
2015-02-11 21:47:51+01:00
block-backend: expose bs->bl.max_transfer_length Signed-off-by: Peter Lieven <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
454057b7d9b9ad141bd5df8c4075745e56b4870f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/454057b7d9b9ad141bd5df8c4075745e56b4870f
2015-02-06 17:24:21+01:00
scsi: give device a parent before setting properties This mimics what is done in qdev_device_add, and lets the device be freed in case something goes wrong. Otherwise, object_unparent returns immediately without freeing the device, which is on the other hand left in the parent bus's list of children. scsi_bus_legacy_handle_cmdline then returns an error, and the HBA is destroyed as well with object_unparent. But the lingering device that was not removed in scsi_bus_legacy_add_drive cannot be removed now either, and bus_unparent gets stuck in an infinite loop trying to empty the list of children. The right fix of course would be to assert in bus_add_child that the device already has a bus, and remove the "safety net" that adds the drive to the QOM tree in device_set_realized. I am not yet sure whether that would entail changing all callers to qdev_create (as well as isa_create and usb_create and the corresponding _try_create versions). Reported-by: Markus Armbruster <[email protected]> Tested-by: Markus Armbruster <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
2264750483107c45877d29813c497b4c87f64cb6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2264750483107c45877d29813c497b4c87f64cb6
2015-02-27 14:43:44+01:00
block: change default for discard and write zeroes to INT_MAX do not trim requests if the driver does not supply a limit through BlockLimits. For write zeroes we still keep a limit for the unsupported path to avoid allocating a big bounce buffer. Suggested-by: Kevin Wolf <[email protected]> Suggested-by: Denis V. Lunev <[email protected]> Signed-off-by: Peter Lieven <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
98764152ad8ec9fa4e7bb6d8e10f8a7a7ce273d7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/98764152ad8ec9fa4e7bb6d8e10f8a7a7ce273d7
2015-02-06 17:24:21+01:00
sdhci: Remove class "virtual" methods The SDHCIClass defines a series of class "methods". However, no code in the QEMU tree overrides these methods or even uses them outside of sdhci.c. Remove the virtual methods and replace them with direct calls to the underlying functions. This simplifies the process of extending the sdhci code to support PCI devices (which have a different parent class). Signed-off-by: Kevin O'Connor <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
d368ba4376b2c1c24175c74b3733b8fe64dbe8a6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d368ba4376b2c1c24175c74b3733b8fe64dbe8a6
2014-12-15 17:34:44+01:00
block/raw-posix: Only sync after successful preallocation The loop which filled the file with zeroes may have been left early due to an error. In that case, the fsync() should be skipped. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
731de38052b245eab79e417aeac5e1dcebe6437f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/731de38052b245eab79e417aeac5e1dcebe6437f
2014-11-18 12:09:00+01:00
qga: add guest-set-user-password command Add a new 'guest-set-user-password' command for changing the password of guest OS user accounts. This command is needed to enable OpenStack to support its API for changing the admin password of guests running on KVM/QEMU. It is not practical to provide a command at the QEMU level explicitly targetting administrator account password change only, since different guest OS have different names for the admin account. While UNIX systems use 'root', Windows systems typically use 'Administrator' and even that can be renamed. Higher level apps like OpenStack have the ability to figure out the correct admin account name since they have info that QEMU/libvirt do not. The command accepts either the clear text password string, encoded in base64 to make it 8-bit safe in JSON: $ echo -n "123456" | base64 MTIzNDU2 $ virsh -c qemu:///system qemu-agent-command f21x86_64 \ '{ "execute": "guest-set-user-password", "arguments": { "crypted": false, "username": "root", "password": "MTIzNDU2" } }' {"return":{}} Or a password that has already been run though a crypt(3) like algorithm appropriate for the guest, again then base64 encoded: $ echo -n '$6$n01A2Tau$e...snip...DfMOP7of9AJ1I8q0' | base64 JDYkb...snip...YT2Ey $ virsh -c qemu:///system qemu-agent-command f21x86_64 \ '{ "execute": "guest-set-user-password", "arguments": { "crypted": true, "username": "root", "password": "JDYkb...snip...YT2Ey" } }' NB windows support is desirable, but not implemented in this patch. Signed-off-by: Daniel P. Berrange <[email protected]> Signed-off-by: Michael Roth <[email protected]>
215a2771a7b6b29037ee8deba484815d816b6fdd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/215a2771a7b6b29037ee8deba484815d816b6fdd
2015-02-16 15:52:18-06:00
ahci: Check cmd_fis[1] more explicitly Instead of checking for a known byte, inspect the fields of this byte explicitly to produce more meaningful error messages and improve the readability of this section. Signed-off-by: John Snow <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
102e56254dbf5f789e43d7eb29023f296cb67536
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/102e56254dbf5f789e43d7eb29023f296cb67536
2014-11-14 09:20:35+00:00
sysbus: Expose IRQ enumeration helpers Sysbus devices can get their IRQ lines connected to other devices. It is possible to figure out which IRQ line a connection is on and whether a sysbus device even provides an IRQ connector at a specific offset. This patch exposes helpers to make this information publicly accessible. We will need it for the platform bus dynamic sysbus enumeration. Signed-off-by: Alexander Graf <[email protected]>
b797318666dade9675a253d311125ae7b568e2f8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b797318666dade9675a253d311125ae7b568e2f8
2014-11-04 23:26:14+01:00
tests: virtio-net: Check if hot-plug/unplug works Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
9224709b7bde6d6a81fad4c1aa2c2479cf840a60
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9224709b7bde6d6a81fad4c1aa2c2479cf840a60
2014-10-15 05:03:12+02:00
qcow2: Fix refcount blocks beyond image end If the qcow2 check function detects a refcount block located beyond the image end, grow the image appropriately. This cannot break anything and is the logical fix for such a case. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
001c158defb65e88e6c50c85d6f20501f7149ddd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/001c158defb65e88e6c50c85d6f20501f7149ddd
2014-10-23 15:34:01+02:00
block/iscsi: set max_transfer_length Copy the max_xfer_len from the BlockLimits VPD or use the maximum value fitting in the CDB. The helper function sector_limits_lun2qemu is introduced to convert and cap the limits from the VPD to the maximum power of two fitting in an integer; integer is the range for nb_sectors throughout the block layer. Signed-off-by: Peter Lieven <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
52f6fa1430209125d1c13fec7d6bbb501aedf322
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/52f6fa1430209125d1c13fec7d6bbb501aedf322
2014-11-03 09:48:41+00:00
scsi-generic: Handle canceled request in scsi_command_complete Now that we always called the cb in bdrv_aio_cancel, let's make scsi-generic callbacks check io_canceled flag similarly to scsi-disk. Signed-off-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
6c25fa6cf8b58db72956e880d76e4adc301bb472
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6c25fa6cf8b58db72956e880d76e4adc301bb472
2014-09-30 13:30:51+02:00
linux-user: Simplify timerid checks on g_posix_timers range We check whether the passed in timer id is negative on all calls that involve g_posix_timers. However, these checks are bogus. First off we limit the timer_id to 16 bits which is not what Linux does. Then we check whether it's negative which it can't be because we masked it. We can safely remove the masking. For the negativity check we can just treat the timerid as unsigned and only check for upper boundaries. Signed-off-by: Alexander Graf <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
e52a99f756eff14935edd1893dc9ec7660078f82
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e52a99f756eff14935edd1893dc9ec7660078f82
2014-10-06 21:52:45+03:00
ahci: Add test_hba_spec to ahci-test. Add a test routine that checks the boot-up values of the HBA configuration memory space against the AHCI 1.3 specification and Intel ICH9 data sheet (for Q35 machines) for adherence and sane values. The HBA is not yet engaged or put into the idle state. [Replaced g_assert_false(...) with g_assert(!...) for glib <2.38 compatibility, reported by Peter Maydell <[email protected]>. --Stefan] Signed-off-by: John Snow <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
c2f3029fbc5e7beb4cfb7ac264e10838fada524e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c2f3029fbc5e7beb4cfb7ac264e10838fada524e
2014-09-22 11:39:42+01:00
qdev: expose DeviceState.hotplugged field as a property so that management could detect via QOM interface if device was hotplugged Signed-off-by: Igor Mammedov <[email protected]> Acked-by: Peter Crosthwaite <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
d012ffc189197962c8ac179611396f6af92c1860
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d012ffc189197962c8ac179611396f6af92c1860
2014-06-19 16:41:47+03:00
vhost-user: fix VIRTIO_NET_F_MRG_RXBUF negotiation Header length check should happen only if backend is kernel. For user backend there is no reason to reset this bit. vhost-user code does not define .has_vnet_hdr_len so VIRTIO_NET_F_MRG_RXBUF cannot be negotiated even if both sides support it. Signed-off-by: Damjan Marion <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
d8e80ae37a7acfea416ad9abbe76b453a73d9cc0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d8e80ae37a7acfea416ad9abbe76b453a73d9cc0
2014-09-18 21:51:24+03:00
libqos: Added basic virtqueue support to virtio implementation Add status changing and feature negotiation. Add basic virtqueue support for adding and sending virtqueue requests. Add ISR checking. [Squashed request endianness fix by Greg Kurz <[email protected]> --Stefan] Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Marc Marí <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
bf3c63d2010c5ef52f8b988bee2a1486a056795f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bf3c63d2010c5ef52f8b988bee2a1486a056795f
2014-09-08 11:12:43+01:00
serial: check if backed by a physical serial port at realize time Right now, s->poll_msl may linger at "0" value for an arbitrarily long time, until serial_update_msl is called for the first time. This is unnecessary, and will lead to the s->poll_msl field being unnecessarily migrated. We can call serial_update_msl immediately at realize time (via serial_reset) and be done with it. The memory-mapped UART was already doing that, but not the ISA and PCI variants. Regarding the delta bits, be consistent with what serial_reset does when the serial port is not backed by a physical serial port, and always clear them at reset time. Signed-off-by: Paolo Bonzini <[email protected]>
a30cf8760f4a59797fc060c3c5a13b7749551d0c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a30cf8760f4a59797fc060c3c5a13b7749551d0c
2014-09-19 10:50:07+02:00
linux-user: Detect fault in sched_rr_get_interval Properly detect a fault when attempting to store into an invalid struct timespec pointer. Signed-off-by: Tom Musta <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
d4290c40a4bf297e9af132be81d51bf796882ff2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d4290c40a4bf297e9af132be81d51bf796882ff2
2014-08-22 15:06:35+03:00
pc-bios/s390-ccw: support all virtio block size The block size value may be given "as is" OR as a base value and a shift count (exponent). So, we have to use calculation to get the proper number in the code. The main expression reads as (blk_cfg.blk_size << blk_cfg.physical_block_exp) E.g., various combinations between blk_size=1/physical_block_exp=12 and blk_size=4096/physical_block_exp=0 are valid for 4K blocks. Signed-off-by: Eugene (jno) Dvurechenski <[email protected]> Acked-by: Christian Borntraeger <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
92cb05574b7bd489be81f9c58497dc7dfe5d8859
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/92cb05574b7bd489be81f9c58497dc7dfe5d8859
2014-09-01 09:23:02+02:00
iotests: Add test for qcow2's cache options Add a test which tests various combinations of qcow2's cache options (some of which are valid, some of which are not). Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
a1cb48a3bffdb62c429297ac7057d1ce76fc4839
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a1cb48a3bffdb62c429297ac7057d1ce76fc4839
2014-08-20 11:51:28+02:00
spice: auth fixes Set auth to sasl when sasl is enabled, this makes "info spice" correctly display sasl auth. Also throw an error in case someone tries to set a spice password via monitor without auth mode being "spice". Signed-off-by: Gerd Hoffmann <[email protected]>
b1ea7b79e1675355ea7abe2548ad71dcf7d64b60
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b1ea7b79e1675355ea7abe2548ad71dcf7d64b60
2014-07-11 10:12:47+02:00
nic: do not destroy memory regions in cleanup functions The memory regions should be destroyed in the unrealize function; since these NICs are not even qdev-ified, they cannot be unplugged and they do not have to do anything to destroy their memory regions. Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Peter Crosthwaite <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
eed79309502034d348880414e1dc156c0c4b196c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/eed79309502034d348880414e1dc156c0c4b196c
2014-08-17 23:25:24+02:00
block/backup: Fix hang for unaligned image size When doing a block backup of an image with an unaligned size (with respect to the BACKUP_CLUSTER_SIZE), qemu would check the allocation status of sectors after the end of the image. bdrv_is_allocated() returns a result that is valid for 0 sectors in this case, so the backup job ran into an endless loop. Stop looping when seeing a result valid for 0 sectors, we're at EOF then. The test case looks somewhat unrelated at first sight because I originally tried to reproduce a different suspected bug that turned out to not exist. Still a good test case and it accidentally found this one. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]>
d40593dd9033d39a5e4cc32915c5eb28f3e858b6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d40593dd9033d39a5e4cc32915c5eb28f3e858b6
2014-07-09 15:50:11+02:00
pflash_cfi01: write flash contents to bdrv on incoming migration A drive that backs a pflash device is special: - it is very small, - its entire contents are kept in a RAMBlock at all times, covering the guest-phys address range that provides the guest's view of the emulated flash chip. The pflash device model keeps the drive (the host-side file) and the guest-visible flash contents in sync. When migrating the guest, the guest-visible flash contents (the RAMBlock) is migrated by default, but on the target host, the drive (the host-side file) remains in full sync with the RAMBlock only if: - the source and target hosts share the storage underlying the pflash drive, - or the migration requests full or incremental block migration too, which then covers all drives. Due to the special nature of pflash drives, the following scenario makes sense as well: - no full nor incremental block migration, covering all drives, alongside the base migration (justified eg. by shared storage for "normal" (big) drives), - non-shared storage for pflash drives. In this case, currently only those portions of the flash drive are updated on the target disk that the guest reprograms while running on the target host. In order to restore accord, dump the entire flash contents to the bdrv in a post_load() callback. - The read-only check follows the other call-sites of pflash_update(); - both "pfl->ro" and pflash_update() reflect / consider the case when "pfl->bs" is NULL; - the total size of the flash device is calculated as in pflash_cfi01_realize(). When using shared storage, or requesting full or incremental block migration along with the normal migration, the patch should incur a harmless rewrite from the target side. It is assumed that, on the target host, RAM is loaded ahead of the call to pflash_post_load(). Suggested-by: Paolo Bonzini <[email protected]> Signed-off-by: Laszlo Ersek <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
4c0cfc72b31a79f737a64ebbe0411e4b83e25771
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4c0cfc72b31a79f737a64ebbe0411e4b83e25771
2014-09-08 11:12:43+01:00
virtio-blk: replace x-iothread with iothread link property Up until now -device virtio-blk-pci,x-iothread=<id> was used to assign an IOThread. This was a temporary solution while we cleaned up QOM link properties. This patch switches over to a QOM link property since it is now possible to restrict the setter to unrealized instances and automatically unref the IOThread when the virtio-blk-pci device is freed. Since the "iothread" property is a QOM property and not a qdev property, we must alias it explicitly for virtio-blk-pci, as well as CCW and s390-virtio. Signed-off-by: Stefan Hajnoczi <[email protected]>
467b3f33e9b094bf6db5a4d6e6905f077edca0fb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/467b3f33e9b094bf6db5a4d6e6905f077edca0fb
2014-07-01 09:15:02+02:00
Handle G_IO_HUP in tcp_chr_read for tcp chardev Since commit cdaa86a54b232572bba594bf87a7416e527e460c ("Add G_IO_HUP handler for socket chardev") GLib limitation results in a bug on Windows host. Steps to reproduce: Start qemu: qemu-system-i386 -qmp tcp:127.0.0.1:4444:server:nowait Connect with telnet: telnet 127.0.0.1 4444 Try sending some data from telnet. Expected result: answers from QEMU. Observed result: no answers (actually tcp_chr_read is not called at all). Due to GLib limitations it is not possible to create several watches on one channel on Windows hosts. See bug #338943 in GNOME bugzilla for details: https://bugzilla.gnome.org/show_bug.cgi?id=338943 This reimplements commit cdaa86a54b232572bba594bf87a7416e527e460c ("Add G_IO_HUP handler for socket chardev") using a single watch: Handle G_IO_HUP in tcp_chr_read instead. It is already watched by a corresponding watch. Remove the second watch with its handler. Cc: Antonios Motakis <[email protected]> Cc: Nikolay Nikolaev <[email protected]> Cc: Michael S. Tsirkin <[email protected]> Signed-off-by: Kirill Batuzov <[email protected]> Signed-off-by: Nikita Belov <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
812c1057f6175ac9a9829fa2920a2b5783814193
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/812c1057f6175ac9a9829fa2920a2b5783814193
2014-07-06 09:13:54+03:00
numa: Keep track of NUMA nodes present on the command-line Based on "enable sparse node numbering" patch from Nishanth Aravamudan, but without the code to actually support sparse node IDs. This just adds the code to keep track of present/non-present nodes on the command-line, without changing any behavior. Signed-off-by: Nishanth Aravamudan <[email protected]> [Rename max_numa_node to max_numa_nodeid -Eduardo] [Initialize max_numa_nodeid to 0 -Eduardo] [Use MAX() macro when setting max_numa_nodeid -Eduardo] Signed-off-by: Eduardo Habkost <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Hu Tao <[email protected]> Reviewed-by: Eric Blake <[email protected]>
1af878e0497a885b6cbdd3a6d91d399f4851d99c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1af878e0497a885b6cbdd3a6d91d399f4851d99c
2014-06-29 18:59:41+03:00
Allow mismatched virtio config-len Commit 'virtio: validate config_len on load' restricted config_len loaded from the wire to match the config_len that the device had. Unfortunately, there are cases where this isn't true, the one we found it on was the wce addition in virtio-blk. Allow mismatched config-lengths: *) If the version on the wire is shorter then fine *) If the version on the wire is longer, load what we have space for and skip the rest. (This is [email protected]'s rework of what I originally posted) Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
2f5732e9648fcddc8759a8fd25c0b41a38352be6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2f5732e9648fcddc8759a8fd25c0b41a38352be6
2014-06-29 18:59:41+03:00
iotests: Allow out-of-tree run As out-of-tree builds are preferred for qemu, running the qemu-iotests in that out-of-tree build should be supported as well. To do so, a symbolic link has to be created pointing to the check script in the source directory. That script will check whether it has been run through a symlink, and if so, will assume it is run in the build tree. All output and temporary operations performed by iotests are then redirected here and, unless specified otherwise by the user, QEMU_PROG etc. will be set to paths appropriate for the build tree. Also, drop making every test case executable if it is not yet, as this would modify the source tree which is not desired for out-of-tree runs and should be fixed in the repository anyway. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
e8f8624d3b920de968c56e76691f419b16d1ee4a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e8f8624d3b920de968c56e76691f419b16d1ee4a
2014-06-27 20:00:00+02:00
vfio: Add vfio_container_ioctl() While most operations with VFIO IOMMU driver are generic and used inside vfio.c, there are still some operations which only specific VFIO IOMMU drivers implement. The first example of it will be reading a DMA window start from the host. This adds a helper which passes an ioctl request to the container's fd. The helper will check if @req is known. For this, stub is added. This return -1 on any requests for now. Signed-off-by: Alexey Kardashevskiy <[email protected]> Acked-by: Alex Williamson <[email protected]> Acked-by: Alex Williamson <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
6d8be4c3434783a59ae29f7ea6a792b56c812349
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6d8be4c3434783a59ae29f7ea6a792b56c812349
2014-06-27 13:48:23+02:00
mirror: Go through ready -> complete process for 0 len image When mirroring or active committing a zero length image, BLOCK_JOB_READY is not reported now, instead the job completes because we short circuit the mirror job loop. This is inconsistent with non-zero length images, and only confuses management software. Let's do the same thing when seeing a 0-length image: report ready immediately; wait for block-job-cancel or block-job-complete; clear the cancel flag as existing non-zero image synced case (cancelled after ready); then jump to the exit. Reported-by: Eric Blake <[email protected]> Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
9e48b025400b2d284e17860862b0a4aa02c6032d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9e48b025400b2d284e17860862b0a4aa02c6032d
2014-06-26 13:50:57+02:00
KVM: Fix GSI number space limit KVM tells us the number of GSIs it can handle inside the kernel. That value is basically KVM_MAX_IRQ_ROUTES. However when we try to set the GSI mapping table, it checks for r = -EINVAL; if (routing.nr >= KVM_MAX_IRQ_ROUTES) goto out; erroring out even when we're only using all of the GSIs. To make sure we never hit that limit, let's reduce the number of GSIs we get from KVM by one. Cc: [email protected] Signed-off-by: Alexander Graf <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
00008418aa22700f6c49e794e79f53aeb157d10f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/00008418aa22700f6c49e794e79f53aeb157d10f
2014-06-18 16:54:18+02:00
target-arm/translate-a64.c: Remove dead ?: in disas_simd_3same_int() In disas_simd_3same_int(), none of the instructions permit is_q to be false with size == 3 (this would be a vector operation with a one-element vector, and the instruction set encodes those as scalar operations). Replace the always-true ?: check with an assert. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Peter Crosthwaite <[email protected]> Message-id: [email protected]
220ad4ca846d8e0734dd2d2af38c61a6f5436d66
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/220ad4ca846d8e0734dd2d2af38c61a6f5436d66
2014-06-19 18:06:24+01:00
target-i386: move check_io helpers to seg_helper.c Prepare for adding _kernel accessors there in the next patch. Signed-off-by: Paolo Bonzini <[email protected]>
81cf8d8adc64203567e03326c13ea4abec9fe5df
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/81cf8d8adc64203567e03326c13ea4abec9fe5df
2014-06-05 16:10:34+02:00
target-ppc: Add POWER8's TM SPRs This adds TM (Transactional Memory) SPRs. This adds generic spr_read_prev_upper32()/spr_write_prev_upper32() to handle upper half SPRs such as TEXASRU which is upper half of TEXASR. Since this is not the only register like that and their numbers go consequently, it makes sense to generalize the helpers. This adds a gen_msr_facility_check() helper which purpose is to generate the Facility Unavailable exception if the facility is disabled. It is a copy of gen_fscr_facility_check() but it checks for enabled facility in MSR rather than FSCR/HFSCR. It still sets the interrupt cause in FSCR/HFSCR (whichever is passed to the helper). This adds spr_read_tm/spr_write_tm/spr_read_tm_upper32/spr_write_tm_upper32 which are used for TM SPRs. This adds TM-relates MSR bits definitions. This enables TM in POWER8 CPU class' msr_mask. Signed-off-by: Alexey Kardashevskiy <[email protected]> Reviewed-by: Tom Musta <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
cdcdda27fc843873875e7e444e0164ba2a5e9942
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cdcdda27fc843873875e7e444e0164ba2a5e9942
2014-06-16 13:24:45+02:00
kvm: Enable -cpu option to hide KVM The latest Nvidia driver (337.88) specifically checks for KVM as the hypervisor and reports Code 43 for the driver in a Windows guest when found. Removing or changing the KVM signature is sufficient for the driver to load and work. This patch adds an option to easily allow the KVM hypervisor signature to be hidden using '-cpu kvm=off'. We continue to expose KVM via the cpuid value by default. The state of this option does not supercede or replace -enable-kvm or the accel=kvm machine option. This only changes the visibility of KVM to the guest and paravirtual features specifically tied to the KVM cpuid. Signed-off-by: Alex Williamson <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
f522d2acc549dd11f495048330aa5f3f424a7dfa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f522d2acc549dd11f495048330aa5f3f424a7dfa
2014-06-03 18:40:48+02:00
qapi: Normalize marshalling's visitor initialization and cleanup Input and output marshalling functions do it differently. Change them to work the same: initialize the I/O visitor, use it, clean it up, initialize the dealloc visitor, use it, clean it up. This delays dealloc visitor initialization in output marshalling functions, and input visitor cleanup in input marshalling functions. No functional change, but the latter will be convenient when I change the error handling. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
f9bee751be1292c9433a95d835474dc38a134a95
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f9bee751be1292c9433a95d835474dc38a134a95
2014-05-15 14:00:45-04:00
armv7m_nvic: fix CPUID Base Register cp15.c0_cpuid is never initialized for ARMv7-M; take the value directly from cpu->midr instead. Signed-off-by: Rabin Vincent <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
e3da9921ebc554fad3224a9fdda9a7425ffd9ef7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e3da9921ebc554fad3224a9fdda9a7425ffd9ef7
2014-05-01 15:24:44+01:00
exec: Limit translation limiting in address_space_translate to xen The address_space_translate() function cuts the returned plen (page size) to hardcoded TARGET_PAGE_SIZE. This function can be used on pages bigger than that so this limiting should not be used on such pages. Since originally the limiting was introduced for XEN, we can safely limit this piece of code to XEN. So does the patch. Suggested-by: Paolo Bonzini <[email protected]> Signed-off-by: Alexey Kardashevskiy <[email protected]> Signed-off-by: Stefano Stabellini <[email protected]>
fe680d0dac85e0f2d6c3b53838c250f6e0b1f49b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fe680d0dac85e0f2d6c3b53838c250f6e0b1f49b
2014-05-07 16:14:36+00:00
SMBIOS: Build aggregate smbios tables and entry point Build an aggregate set of smbios tables and an entry point structure. Insert tables and entry point into fw_cfg respectively under "etc/smbios/smbios-tables" and "etc/smbios/smbios-anchor". Machine types <= 2.0 will for now continue using field-by-field overrides to SeaBIOS defaults, but for machine types 2.1 and up we expect the BIOS to look for and use the aggregate tables generated by this patch. Signed-off-by: Gabriel Somlo <[email protected]> [ kraxel: fix 32bit build ] Signed-off-by: Gerd Hoffmann <[email protected]>
c97294ec1b9e36887e119589d456557d72ab37b5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c97294ec1b9e36887e119589d456557d72ab37b5
2014-05-05 13:14:48+02:00
sdl2: add ui info setting. Allows you to resize the sdl2 window and have the guest notice. [ kraxel: zero-initialize QemuUIInfo ] Signed-off-by: Dave Airlie <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
8b15d9f1d2954c405bbbf53968f0f5660f946311
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8b15d9f1d2954c405bbbf53968f0f5660f946311
2014-04-29 10:46:33+02:00
block: Remove BDRV_O_COPY_ON_READ for bs->file Copy on Read makes sense on the format level where backing files are implemented, but it's not required on the protocol level. While it shouldn't actively break anything to have COR enabled on both layers, needless serialisation and allocation checks may impact performance. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]>
5669b44de5b3b607a3a4749e0c8c5ddfd723e76b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5669b44de5b3b607a3a4749e0c8c5ddfd723e76b
2014-04-30 11:05:00+02:00
curl: Fix hang reading from slow connections When receiving a new aio read request, we first look for an existing transaction whose range will cover the read request by the time it completes. However, we weren't checking that the existing transaction was still active. If it had timed out, we were adding the request to a transaction which would never complete and had already been cancelled, resulting in a hang. Signed-off-by: Matthew Booth <[email protected]> Tested-by: Richard W.M. Jones <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
b7079df4100069959f4e9d90d5cb5ba7d4ebbf1a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b7079df4100069959f4e9d90d5cb5ba7d4ebbf1a
2014-04-30 16:34:21+02:00
block: Add errp to bdrv_new() This patch adds an errp parameter to bdrv_new() and updates all its callers. The next patches will make use of this in order to check for duplicate IDs. Most of the callers know that their ID is fine, so they can simply assert that there is no error. Behaviour doesn't change with this patch yet as bdrv_new() doesn't actually assign errors to errp. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]>
98522f63f40adaebc412481e1d2e9170160d4539
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/98522f63f40adaebc412481e1d2e9170160d4539
2014-04-22 12:00:20+02:00
block/bochs: Fix error handling for seek_to_sector() Currently, seek_to_sector() returns -1 both for errors and unallocated sectors, resulting in silent errors. As 0 is an invalid offset of data clusters (bitmap_offset is greater than 0 because s->data_offset is greater than 0), just return 0 for unallocated sectors and -errno in case of error. This should then be propagated by bochs_read(), the sole user of seek_to_sector(). That function also has a case of "return -1 in case of error", which is fixed by this patch as well. bochs_read() is called by bochs_co_read() which passes the return value through, therefore it is indeed correct for bochs_read() to return -errno. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
e1b42f456fad6e797eaf795ed2e400c4e47d5eb4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e1b42f456fad6e797eaf795ed2e400c4e47d5eb4
2014-04-30 14:46:17+02:00
dmg: drop broken bdrv_pread() loop It is not necessary to check errno for EINTR and the block layer does not produce short reads. Therefore we can drop the loop that attempts to read a compressed chunk. The loop is buggy because it incorrectly adds the transferred bytes twice: do { ret = bdrv_pread(...); i += ret; } while (ret >= 0 && ret + i < s->lengths[chunk]); Luckily we can drop the loop completely and perform a single bdrv_pread(). Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
b404bf854217dbe8a5649449eb3ad33777f7d900
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b404bf854217dbe8a5649449eb3ad33777f7d900
2014-04-01 15:22:35+02:00
target-arm: A64: Add assertion that FP access was checked Because unallocated encodings generate different exception syndrome information from traps due to FP being disabled, we can't do a single "is fp access disabled" check at a high level in the decode tree. To help in catching bugs where the access check was forgotten in some code path, we set this flag when the access check is done, and assert that it is set at the point where we actually touch the FP regs. This requires us to pass the DisasContext to the vec_reg_offset and fp_reg_offset functions. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Peter Crosthwaite <[email protected]>
90e496386fe7fd32c189561f846b7913f95b8cf4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/90e496386fe7fd32c189561f846b7913f95b8cf4
2014-04-17 21:34:03+01:00
qemu-iotests: add cloop input validation tests Add a cloop format-specific test case. Later patches add tests for input validation to the script. Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
05560fcebb1528f4354f6f24d1eb8cdbcdf2c4b2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/05560fcebb1528f4354f6f24d1eb8cdbcdf2c4b2
2014-04-01 13:59:46+02:00
tcg-aarch64: Remove redundant CPU_TLB_ENTRY_BITS check Removed from other targets in 56bbc2f967ce185fa1c5c39e1aeb5b68b26242e9. Reviewed-by: Alex Bennée <[email protected]> Reviewed-by: Claudio Fontana <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
3353d0dcc331f15dbbadfc42772d57c864017d4b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3353d0dcc331f15dbbadfc42772d57c864017d4b
2014-03-08 21:23:02-08:00
qapi: Clean up superfluous null check in qapi_dealloc_type_str() Argument can't be null. No other Visitor method type_str() checks for null. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
25a7017555f1b4aeb543b5d323ff4afb8f9c5437
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/25a7017555f1b4aeb543b5d323ff4afb8f9c5437
2014-03-03 11:17:45-05:00
iscsi: Use bs->sg for everything else than disks The current iscsi block driver code makes the rather arbitrary decision that TYPE_MEDIUM_CHANGER and TYPE_TAPE devices have bs->sg = 1 and all other device types are disks. Instead of this, check for TYPE_DISK to expose the disk interface and make everything else bs->sg = 1. In particular, this includes devices with TYPE_STORAGE_ARRAY, which is what LUN 0 of an iscsi target is. (See https://bugzilla.redhat.com/show_bug.cgi?id=1067784 for the exact scenario.) Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Benoit Canet <[email protected]> Acked-by: Paolo Bonzini <[email protected]>
f47c3f5a800a927238d20de9f99b5c77f0bc3fe0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f47c3f5a800a927238d20de9f99b5c77f0bc3fe0
2014-03-05 16:58:20+01:00
block: gluster - code movements, state storage changes In preparation for supporting reopen on gluster, move flag parsing out to a function. Also, add a NULL check in the gconf cleanup. Signed-off-by: Jeff Cody <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
1b37b3442f78a77844fdaf7f53e5f04e4ce8f1d6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1b37b3442f78a77844fdaf7f53e5f04e4ce8f1d6
2014-02-28 18:59:06+01:00
target-ppc: add PowerPCCPU::cpu_dt_id Normally CPUState::cpu_index is used to pick the right CPU for various operations. However default consecutive numbering does not always work for POWERPC. These indexes are reflected in /proc/device-tree/cpus/PowerPC,POWER7@XX and used to call KVM VCPU's ioctls. In order to achieve this, kvmppc_fixup_cpu() was introduced. Roughly speaking, it multiplies cpu_index by the number of threads per core. This approach has disadvantages such as: 1. NUMA configuration stays broken after the fixup; 2. CPU-targeted commands from the QEMU Monitor do not work properly as CPU indexes have been fixed and there is no clear way for the user to know what the new CPU indexes are. This introduces a @cpu_dt_id field in the CPUPPCState struct which is initialized from @cpu_index by default and can be fixed later to meet the device tree requirements. This adds an API to handle @cpu_dt_id. This removes kvmppc_fixup_cpu() as it is not more needed, @cpu_dt_id is calculated in ppc_cpu_realize(). This will be used later in machine code. Signed-off-by: Alexey Kardashevskiy <[email protected]> Acked-by: Mike Day <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
0ce470cd4ca88e84e547a3b95159d23ce6be419e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0ce470cd4ca88e84e547a3b95159d23ce6be419e
2014-03-05 03:07:03+01:00
net: virtio-net and vmxnet3 use offloading API With this patch, virtio-net and vmxnet3 frontends make use of the qemu_peer_* API for backend offloadings manipulations, instead of calling TAP-specific functions directly. We also remove the existing checks which prevent those frontends from using offloadings with backends different from TAP (e.g. netmap). Signed-off-by: Vincenzo Maffione <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
cf528b89580797050b8cf60fee6247f35531a675
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cf528b89580797050b8cf60fee6247f35531a675
2014-02-25 11:50:17+01:00
target-arm: Add utility function for checking AA32/64 state of an EL There are various situations where we need to behave differently depending on whether a given exception level is in AArch64 or AArch32 state. The state of the current exception level is stored in env->aarch64, but there's no equivalent guest-visible architected state bits for the status of the exception levels "above" the current one which may still affect execution. At the moment we only support EL1 (ie no EL2 or EL3) and insist that AArch64 capable CPUs run with EL1 in AArch64 state, but these may change in the future, so abstract out the "what state is this?" check into a utility function which can be enhanced later if necessary. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Peter Crosthwaite <[email protected]>
1f79ee32b556cad0b6db6f7c866ac4e6b4244cc1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1f79ee32b556cad0b6db6f7c866ac4e6b4244cc1
2014-02-26 17:20:07+00:00