commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
vvfat: correctly create base short names for non-ASCII filenames More specifically, create short name from filename and change blacklist of invalid chars to whitelist of valid chars. Windows 9x also now correctly see long file names of filenames containing a space, but Scandisk still complains about mismatch between SFN and LFN. [kwolf: Build fix for this intermediate patch (it included declarations for variables that are only used in the next patch) ] Specification: "FAT: General overview of on-disk format" v1.03, pages 30-31 Signed-off-by: Hervé Poussineau <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
0c36111f57ec2188f679e7fa810291b7386bdca1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0c36111f57ec2188f679e7fa810291b7386bdca1
2017-07-10 13:18:05+02:00
Add memory_region_init_ram_from_fd() Add a new function to initialize a RAM memory region with a file descriptor to be mmap-ed. Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
fea617c58b777495b9285f3dc6b33f2898352886
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fea617c58b777495b9285f3dc6b33f2898352886
2017-06-15 11:04:05+02:00
tests: Remove test cases for alternates of 'number' and 'int' Alternates with both a 'number' and an 'int' branch will become invalid when the next patch merges of QFloat and QInt into QNum. More sophisticated alternate code could keep them valid, but since we have no users outside tests, simply drop the tests. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
7c877c80308a8d0166029494e2e236c1f95336e8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7c877c80308a8d0166029494e2e236c1f95336e8
2017-06-19 14:56:29+02:00
usb: Simplify the parameter parsing of the legacy usb serial device Coverity complains about the current code, so let's get rid of the now unneeded while loop and simply always emit "unrecognized serial USB option" for all unsupported options. Signed-off-by: Thomas Huth <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
e14935df26c2c10b3445b1910f4ff76f3fb1a1b1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e14935df26c2c10b3445b1910f4ff76f3fb1a1b1
2017-05-29 14:03:35+02:00
hw/ppc/spapr: Adjust firmware name for PCI bridges SLOF uses "pci" as name for PCI bridges nodes in the device tree instead of "pci-bridges", so booting via bootindex from a device behind a PCI bridge currently does not work since QEMU passes the wrong name in the "qemu,boot-list" property. Fix it by changing the name of the PCI bridge nodes to "pci" instead. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1459170 Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: David Gibson <[email protected]>
4871dd4c3f70f528147f426fe42676b4193cb3b7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4871dd4c3f70f528147f426fe42676b4193cb3b7
2017-06-08 14:38:27+10:00
qemu-img: add support for --object with 'dd' command The qemu-img dd command added --image-opts support, but missed the corresponding --object support. This prevented passing secrets (eg auth passwords) needed by certain disk images. Reviewed-by: Fam Zheng <[email protected]> Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
83d4bf943e09cbcb011e255c872724e95fe4856e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/83d4bf943e09cbcb011e255c872724e95fe4856e
2017-05-29 15:39:53+02:00
numa: Silence incomplete mapping warning under qtest Silence "make check" warnings triggered by the numa/mon/cpus/partial test case. Suggested-by: Markus Armbruster <[email protected]> Signed-off-by: Igor Mammedov <[email protected]> Message-Id: <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
c6ff347c8078bb86f75d38955641cb73e9d5b309
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c6ff347c8078bb86f75d38955641cb73e9d5b309
2017-05-22 14:24:52-03:00
tests: acpi: extend cphp and memhp testcase with numa distance check Signed-off-by: He Chen <[email protected]> Message-Id: <[email protected]> Reviewed-by: Igor Mammedov <[email protected]> [ehabkost: regenerated tests/acpi-tst-data, included SLIT table] Signed-off-by: Eduardo Habkost <[email protected]>
fda4096fca83dcdc72e0fc0e4a1ae6e7724fb5e0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fda4096fca83dcdc72e0fc0e4a1ae6e7724fb5e0
2017-05-11 16:08:48-03:00
tests/check-qdict: Fix missing brackets Gcc 7 (on Fedora 26) spotted odd use of integers instead of a boolean; it's got a point. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
de4598f0c5a734863f74b7984604bfb8a89fbccd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/de4598f0c5a734863f74b7984604bfb8a89fbccd
2017-05-08 20:32:14+02:00
qcow2: Nicer variable names in qcow2_update_snapshot_refcount() In order to keep checkpatch happy when the next patch changes indentation, we first have to shorten some long lines. The easiest approach is to use a new variable in place of 'offset & L2E_OFFSET_MASK', except that 'offset' is the best name for that variable. Change '[old_]offset' to '[old_]entry' to make room. While touching things, also fix checkpatch warnings about unusual 'for' statements. Suggested by Max Reitz <[email protected]> Signed-off-by: Eric Blake <[email protected]> Message-id: [email protected] Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Max Reitz <[email protected]>
b32cbae11107e9e172e5c58425a2a8362e7382ed
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b32cbae11107e9e172e5c58425a2a8362e7382ed
2017-05-11 14:28:06+02:00
sockets: Rename SocketAddress to SocketAddressLegacy The next commit will rename SocketAddressFlat to SocketAddress, and the commit after that will replace most uses of SocketAddressLegacy by SocketAddress, replacing most of this commit's renames right back. Note that checkpatch emits a few "line over 80 characters" warnings. The long lines are all temporary; the SocketAddressLegacy replacement will shorten them again. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
dfd100f242370886bb6732f70f1f7cbd8eb9fedc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dfd100f242370886bb6732f70f1f7cbd8eb9fedc
2017-05-09 09:14:40+02:00
block: Remove NULL check in bdrv_co_flush Reported by Coverity. We already use bs in bdrv_inc_in_flight before checking for NULL. It is unnecessary as all callers pass non-NULL bs, so drop it. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
e914404efb9d2af79e08750c6700b642ea0d2ec7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e914404efb9d2af79e08750c6700b642ea0d2ec7
2017-04-27 15:39:50+02:00
hmp: gpa2hva and gpa2hpa hostaddr command These commands are useful when testing machine-check passthrough. gpa2hva is useful to inject a MADV_HWPOISON madvise from gdb, while gpa2hpa is useful to inject an error with the mce-inject kernel module. Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
e9628441df3a7aa0ee83601a0cc9111b91e2319a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e9628441df3a7aa0ee83601a0cc9111b91e2319a
2017-04-26 14:42:31+01:00
target-s390x: Mask the SIGP order_code to 8bit. According to "CPU Signaling and Response", "Signal-Processor Orders", the order field is bit position 56-63. Without this, the Linux guest kernel is sometimes unable to stop emulation and enters an infinite loop of "XXX unknown sigp: 0xffffffff00000005". Signed-off-by: Philipp Kern <[email protected]> Reviewed-by: Thomas Huth <[email protected]> [agraf: add comment according to email] Signed-off-by: Alexander Graf <[email protected]>
601b9a9008c5a612d76073bb3f178621cff41980
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/601b9a9008c5a612d76073bb3f178621cff41980
2017-04-25 13:39:43+02:00
cpus: check cpu->running in cpu_get_icount_raw() The lifetime of current_cpu is now the lifetime of the vCPU thread. However get_icount_raw() can apply a fudge factor if called while code is running to take into account the current executed instruction count. To ensure this is always the case we also check cpu->running. Signed-off-by: Alex Bennée <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
243c5f77f6734776a45d50612b0f3ca2f2f6448e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/243c5f77f6734776a45d50612b0f3ca2f2f6448e
2017-04-10 10:22:28+01:00
sm501: Fix hardware cursor Rework HWC handling to simplify it and fix cursor not updating on screen as needed. Previously cursor was not updated because checking for changes in a line overrode the update flag set for the cursor but fixing this is not enough because the cursor should also be updated if its shape or location changes. Introduce hwc_invalidate() function to handle that similar to other display controller models. Signed-off-by: BALATON Zoltan <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Tested-by: Aurelien Jarno <[email protected]> Message-id: 6970a5e9868b7246656c1d02038dc5d5fa369507.1492787889.git.balaton@eik.bme.hu Signed-off-by: Peter Maydell <[email protected]>
6a2a5aae02b9a0b53807b9ad91f15cd4988781f9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6a2a5aae02b9a0b53807b9ad91f15cd4988781f9
2017-04-24 12:32:12+01:00
s390x: register I/O adapters per ISC during init The I/O adapters should exist as soon as the bus/infrastructure exists, and not only when the guest is actually trying to do something with them. While the lazy allocation was not wrong, allocating at init time is cleaner, both for the architecture and the code. Let's adjust this by having each device type (currently for PCI and virtio-ccw) register the adapters for each ISC (as now we don't know which ISC the guest will use) as soon as it initializes. Use a two-dimensional array io_adapters[type][isc] to store adapters in ChannelSubSys, so that we can conveniently get the adapter id by the helper function css_get_adapter_id(type, isc). Signed-off-by: Fei Li <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
dde522bbc5feb2862afb243bb49c590fe65dce66
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dde522bbc5feb2862afb243bb49c590fe65dce66
2017-04-21 09:32:09+02:00
hw/intc/arm_gicv3_kvm: Check KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS in reset KVM_DEV_ARM_VGIC_GRP_CPU_SYSREGS needs to be checked before attempting to read ICC_CTLR_EL1; otherwise kernel versions not exposing this kvm device group will be incompatible with qemu 2.9. Fixes: 07a5628 ("hw/intc/arm_gicv3_kvm: Reset GICv3 cpu interface registers") Signed-off-by: Eric Auger <[email protected]> Reported-by: Prakash B <[email protected]> Tested-by: Alexander Graf <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
e7d54416cf7a30928a455ddf86ca57d766e9a902
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e7d54416cf7a30928a455ddf86ca57d766e9a902
2017-03-31 12:41:14+01:00
rbd: Revert -blockdev parameter password-secret This reverts a part of commit 8a47e8e. We're having second thoughts on the QAPI schema (and thus the external interface), and haven't reached consensus, yet. Issues include: * BlockdevOptionsRbd member @password-secret isn't actually a password, it's a key generated by Ceph. * We're not sure where member @password-secret belongs (see the previous commit). * How @password-secret interacts with settings from a configuration file specified with @conf is undocumented. Let's avoid painting ourselves into a corner now, and revert the feature for 2.9. Note that users can still configure an authentication key with a configuration file. They probably do that anyway if they use Ceph outside QEMU as well. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Jeff Cody <[email protected]> Message-id: [email protected] Signed-off-by: Jeff Cody <[email protected]>
577d8c9a811fc697b4cc68fbbe5c509b028e0768
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/577d8c9a811fc697b4cc68fbbe5c509b028e0768
2017-03-28 10:01:21-04:00
nbd-client: fix handling of hungup connections After the switch to reading replies in a coroutine, nothing is reentering pending receive coroutines if the connection hangs. Move nbd_recv_coroutines_enter_all to the reply read coroutine, which is the place where hangups are detected. nbd_teardown_connection can simply wait for the reply read coroutine to detect the hangup and clean up after itself. This wouldn't be enough though because nbd_receive_reply returns 0 (rather than -EPIPE or similar) when reading from a hung connection. Fix the return value check in nbd_read_reply_entry. This fixes qemu-iotests 083. Reported-by: Max Reitz <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Max Reitz <[email protected]>
a12a712a7dfbd2e2f4882ef2c90a9b2162166dd7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a12a712a7dfbd2e2f4882ef2c90a9b2162166dd7
2017-03-27 16:50:36+02:00
hw/acpi/vmgenid: prevent more than one vmgenid device A system with multiple VMGENID devices is undefined in the VMGENID spec by omission. Cc: "Michael S. Tsirkin" <[email protected]> Cc: Ben Warren <[email protected]> Cc: Igor Mammedov <[email protected]> Cc: Paolo Bonzini <[email protected]> Signed-off-by: Laszlo Ersek <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Igor Mammedov <[email protected]>
f92063028a0ea9e15d8f962644bce76c0e8aa7d1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f92063028a0ea9e15d8f962644bce76c0e8aa7d1
2017-03-22 18:29:27+02:00
cirrus: fix cirrus_invalidate_region off_cur_end is exclusive, so off_cur_end == cirrus_addr_mask is valid. Fix calculation to make sure to allow that, otherwise the assert added by commit f153b563f8cf121aebf5a2fff5f0110faf58ccb3 can trigger for valid blits. Test case: boot windows nt 4.0 Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected]
e048dac616748273c2153490e9fdf1da242f0cad
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e048dac616748273c2153490e9fdf1da242f0cad
2017-03-16 08:58:15+01:00
hw/acpi/vmgenid: prevent device realization on pre-2.5 machine types The WRITE_POINTER linker/loader command that underlies VMGENID depends on commit baf2d5bfbac0 ("fw-cfg: support writeable blobs", 2017-01-12), which in turn depends on fw_cfg DMA. DMA for fw_cfg is enabled in 2.5+ machine types only (see commit e6915b5f3a87, "fw_cfg: unbreak migration compatibility for 2.4 and earlier machines", 2016-02-18). Cc: "Michael S. Tsirkin" <[email protected]> Cc: Ben Warren <[email protected]> Cc: Igor Mammedov <[email protected]> Cc: Paolo Bonzini <[email protected]> Signed-off-by: Laszlo Ersek <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Ben Warren <[email protected] <mailto:[email protected]>> Reviewed-by: Igor Mammedov <[email protected]>
f2a1ae45d8ec5ad494e66a9234499a2e0fbf4b40
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f2a1ae45d8ec5ad494e66a9234499a2e0fbf4b40
2017-03-22 18:27:35+02:00
target/nios2: take BQL around interrupt check The interrupt controller does not have its own locking. Signed-off-by: Paolo Bonzini <[email protected]>
c0d24e7f70816c8af51ebe9dc74aa276a81858dd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c0d24e7f70816c8af51ebe9dc74aa276a81858dd
2017-03-14 13:26:37+01:00
qapi: Avoid unwanted blank lines in QAPIDoc We silently fix missing #optional tags for QAPIDoc by appending a line "#optional" to the section's .content. However, this interferes with .__repr__ stripping trailing blank lines from .content. Use new ArgSection instance variable .optional instead, and leave .content alone. To permit testing .optional in texi_body(), clean up texi_enum()'s hack to add empty documentation for undocumented enum values: add an ArgSection instead of ''. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]>
b116fd8e302d0ff7cabf431e78ce078127b51f85
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b116fd8e302d0ff7cabf431e78ce078127b51f85
2017-03-16 07:13:02+01:00
cirrus: add option to disable blitter Ok, we have this beast in the cirrus code which is not used at all by modern guests, except when you try to find security holes in qemu. So, add an option to disable blitter altogether. Guests released within the last ten years should not show any rendering issues if you turn off blitter support. There are no known bugs in the cirrus blitter code. But in the past we hoped a few times already that we've finally nailed the last issue. So having some easy way to mitigate in case yet another blitter issue shows up certainly makes me sleep a bit better at night. For completeness: The by far better way to mitigate is to switch away from cirrus and use stdvga instead. Or something more modern like virtio-vga in case your guest has support for it. Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected]
827bd5172641f2a360ff9a3bad57bcf82e7f03f0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/827bd5172641f2a360ff9a3bad57bcf82e7f03f0
2017-03-16 08:58:15+01:00
armv7m: Check exception return consistency Implement the exception return consistency checks described in the v7M pseudocode ExceptionReturn(). Inspired by a patch from Michael Davidsaver's series, but this is a reimplementation from scratch based on the ARM ARM pseudocode. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Alex Bennée <[email protected]>
aa488fe3bb5460c6675800ccd80f6dccbbd70159
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/aa488fe3bb5460c6675800ccd80f6dccbbd70159
2017-02-28 12:08:19+00:00
block: Request child permissions in format drivers This makes use of the .bdrv_child_perm() implementation for formats that we just added. All format drivers expose the permissions they actually need nows, so that they can be set accordingly and updated when parents are attached or detached. The only format not included here is raw, which was already converted with the other filter drivers. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Acked-by: Fam Zheng <[email protected]>
862f215fabf31c80c953155fcb223fea5320bbdf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/862f215fabf31c80c953155fcb223fea5320bbdf
2017-02-28 20:40:36+01:00
qapi: Make input visitors detect unvisited list tails Fix the design flaw demonstrated in the previous commit: new method check_list() lets input visitors report that unvisited input remains for a list, exactly like check_struct() lets them report that unvisited input remains for a struct or union. Implement the method for the qobject input visitor (straightforward), and the string input visitor (less so, due to the magic list syntax there). The opts visitor's list magic is even more impenetrable, and all I can do there today is a stub with a FIXME comment. No worse than before. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]>
a4a1c70dc759e5b81627e96564f344ab43ea86eb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a4a1c70dc759e5b81627e96564f344ab43ea86eb
2017-03-05 09:14:20+01:00
vmstate-static-checker: update white list with spapr_pci To fix migration between 2.7 and 2.8, some fields have been renamed and managed with the help of a PHB property (pre_2_8_migration): 5c4537b spapr: Fix 2.7<->2.8 migration of PCI host bridge So we need to add them to the white list: dma_liobn[0], mem_win_addr, mem_win_size, io_win_addr, io_win_size become mig_liobn, mig_mem_win_addr, mig_mem_win_size, mig_io_win_addr, mig_io_win_size CC: David Gibson <[email protected]> CC: Dr. David Alan Gilbert <[email protected]> CC: Thomas Huth <[email protected]> CC: Greg Kurz <[email protected]> CC: Alexey Kardashevskiy <[email protected]> Signed-off-by: Laurent Vivier <[email protected]> Message-Id: <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Reviewed-by: David Gibson <[email protected]> Signed-off-by: Dr. David Alan Gilbert <[email protected]>
9cd49026aa3af71a06587a41ece54a8c25c57f88
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9cd49026aa3af71a06587a41ece54a8c25c57f88
2017-02-28 11:30:22+00:00
test-cutils: Cover qemu_strtosz() around range limits Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-Id: <[email protected]>
0b742797aaada3a2e243175a69d542d2ed997aac
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0b742797aaada3a2e243175a69d542d2ed997aac
2017-02-23 20:35:36+01:00
check-qjson: Simplify around compare_litqobj_to_qobj() Make compare_litqobj_to_qobj() cope with null, and drop non-null assertions from callers. compare_litqobj_to_qobj() already checks the QType matches; drop the redundant assertions from callers. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]>
9eaaf971683c99ed197fa1b7d1a3ca9baabfb3ee
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9eaaf971683c99ed197fa1b7d1a3ca9baabfb3ee
2017-02-22 19:51:54+01:00
slirp: Convert mbufs to use g_malloc() and g_free() The mbuf code currently doesn't check the result of doing a malloc() or realloc() of its data (spotted by Coverity, CID 1238946). Since the m_inc() API assumes that extending an mbuf must succeed, just convert to g_malloc() and g_free(). Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Signed-off-by: Samuel Thibault <[email protected]>
70f2e64e4dde21ba8b2e8d3fd682533c89a53487
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/70f2e64e4dde21ba8b2e8d3fd682533c89a53487
2017-02-26 15:39:05+01:00
usb: ohci: fix error return code in servicing td It should return 1 if an error occurs when reading td. This will avoid an infinite loop issue in ohci_service_ed_list. Signed-off-by: Li Qiang <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
6ebc069d67735763954cb04a2d997c83a2ebe103
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6ebc069d67735763954cb04a2d997c83a2ebe103
2017-02-23 16:18:03+01:00
target/ppc/POWER9: Direct all instr and data storage interrupts to the hypv The vpm0 bit was removed from the LPCR in POWER9, this bit controlled whether ISI and DSI interrupts were directed to the hypervisor or the partition. These interrupts now go to the hypervisor irrespective, thus it is no longer necessary to check the vmp0 bit in the LPCR. Signed-off-by: Suraj Jitindar Singh <[email protected]> Signed-off-by: David Gibson <[email protected]>
506590836144af7d0de3fc4c691bb5ed49d41645
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/506590836144af7d0de3fc4c691bb5ed49d41645
2017-02-22 11:28:28+11:00
aio-posix: partially inline aio_dispatch into aio_poll This patch prepares for the removal of unnecessary lockcnt inc/dec pairs. Extract the dispatching loop for file descriptor handlers into a new function aio_dispatch_handlers, and then inline aio_dispatch into aio_poll. aio_dispatch can now become void. Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Reviewed-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
a153bf52b37e148f052b0869600877130671a03d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a153bf52b37e148f052b0869600877130671a03d
2017-02-21 11:39:39+00:00
aio: push aio_context_acquire/release down to dispatching The AioContext data structures are now protected by list_lock and/or they are walked with FOREACH_RCU primitives. There is no need anymore to acquire the AioContext for the entire duration of aio_dispatch. Instead, just acquire it before and after invoking the callbacks. The next step is then to push it further down. Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Reviewed-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
0836c72f70143ba7d4277d89efc7643c526dd90a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0836c72f70143ba7d4277d89efc7643c526dd90a
2017-02-21 11:14:08+00:00
COLO: fix setting checkpoint-delay not working properly If we set checkpoint-delay through command 'migrate-set-parameters', It will not take effect until we finish last sleep chekpoint-delay, That's will be offensive espeically when we want to change its value from an extreme big one to a proper value. Fix it by using timer to realize checkpoint-delay. Signed-off-by: zhanghailiang <[email protected]> Message-Id: <[email protected]> Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]>
479125d53eb8509d69a0548f131028a65fcbd65a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/479125d53eb8509d69a0548f131028a65fcbd65a
2017-02-13 17:27:13+00:00
iotests: record separate timings per format,protocol pair The 'check' program records timings for each test that is run. These timings are only valid, however, for a particular format/protocol combination. So if frequently running 'check' with a variety of different formats or protocols, the times printed can be very misleading. Instead of having a single 'check.time' file, maintain multiple 'check.time-$IMGPROTO-$IMGFMT' files. Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Max Reitz <[email protected]>
36bd4228126139a382a4fdbc49c96798a9894626
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/36bd4228126139a382a4fdbc49c96798a9894626
2017-02-12 00:47:42+01:00
hw: Drop superfluous special checks for orphaned -drive We've traditionally rejected orphans here and there, but not systematically. For instance, the sun4m machines have an onboard SCSI HBA (bus=0), and have always rejected bus>0. Other machines with an onboard SCSI HBA don't. Commit a66c9dc made all orphans trigger a warning, and the previous commit turned this into an error. The checks "here and there" are now redundant. Drop them. Note that the one in mips_jazz.c was wrong: it rejected bus > MAX_FD, but MAX_FD is the number of floppy drives per bus. Error messages change from $ qemu-system-x86_64 -drive if=ide,bus=2 qemu-system-x86_64: Too many IDE buses defined (3 > 2) $ qemu-system-mips64 -M magnum,accel=qtest -drive if=floppy,bus=2,id=fd1 qemu: too many floppy drives $ qemu-system-sparc -M LX -drive if=scsi,bus=1 qemu: too many SCSI bus to $ qemu-system-x86_64 -drive if=ide,bus=2 qemu-system-x86_64: -drive if=ide,bus=2: machine type does not support if=ide,bus=2,unit=0 $ qemu-system-mips64 -M magnum,accel=qtest -drive if=floppy,bus=2,id=fd1 qemu-system-mips64: -drive if=floppy,bus=2,id=fd1: machine type does not support if=floppy,bus=2,unit=0 $ qemu-system-sparc -M LX -drive if=scsi,bus=1 qemu-system-sparc: -drive if=scsi,bus=1: machine type does not support if=scsi,bus=1,unit=0 Cc: John Snow <[email protected]> Cc: "Hervé Poussineau" <[email protected]> Cc: Mark Cave-Ayland <[email protected]> Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: John Snow <[email protected]>
8f2d75e81d5eb2715be653010258ce9d57549de7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8f2d75e81d5eb2715be653010258ce9d57549de7
2017-02-21 13:17:45+01:00
vfio: allow to notify unmap for very large region Linux vfio driver supports to do VFIO_IOMMU_UNMAP_DMA for a very big region. This can be leveraged by QEMU IOMMU implementation to cleanup existing page mappings for an entire iova address space (by notifying with an IOTLB with extremely huge addr_mask). However current vfio_iommu_map_notify() does not allow that. It make sure that all the translated address in IOTLB is falling into RAM range. The check makes sense, but it should only be a sensible checker for mapping operations, and mean little for unmap operations. This patch moves this check into map logic only, so that we'll get faster unmap handling (no need to translate again), and also we can then better support unmapping a very big region when it covers non-ram ranges or even not-existing ranges. Acked-by: Alex Williamson <[email protected]> Signed-off-by: Peter Xu <[email protected]> Reviewed-by: David Gibson <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
dfbd90e5b9b772b1c5a52bad9f6dbabb385a7dc2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dfbd90e5b9b772b1c5a52bad9f6dbabb385a7dc2
2017-02-17 21:52:31+02:00
xhci: don't kick in xhci_submit and xhci_fire_ctl_transfer xhci_submit and xhci_fire_ctl_transfer are is called from xhci_kick_epctx processing loop only, so there is no need to call xhci_kick_epctx make sure processing continues. Also eecursive calls into xhci_kick_epctx can cause trouble. Drop the xhci_kick_epctx calls. Cc: [email protected] Fixes: 94b037f2a451b3dc855f9f2c346e5049a361bd55 Reported-by: Fabian Lesniak <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected]
ddb603ab6c981c1d67cb42266fc700c33e5b2d8f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ddb603ab6c981c1d67cb42266fc700c33e5b2d8f
2017-02-06 10:23:18+01:00
cirrus: handle negative pitch in cirrus_invalidate_region() cirrus_invalidate_region() calls memory_region_set_dirty() on a per-line basis, always ranging from off_begin to off_begin+bytesperline. With a negative pitch off_begin marks the top most used address and thus we need to do an initial shift backwards by a line for negative pitches of backward blits, otherwise the first iteration covers the line going from the start offset forwards instead of backwards. Additionally since the start address is inclusive, if we shift by a full `bytesperline` we move to the first address *not* included in the blit, so we only shift by one less than bytesperline. Signed-off-by: Wolfgang Bumiller <[email protected]> Message-id: [email protected] [ kraxel: codestyle fixes ] Signed-off-by: Gerd Hoffmann <[email protected]>
f153b563f8cf121aebf5a2fff5f0110faf58ccb3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f153b563f8cf121aebf5a2fff5f0110faf58ccb3
2017-02-01 09:41:53+01:00
ppc/spapr: implement H_SIGNAL_SYS_RESET The H_SIGNAL_SYS_RESET hcall allows a guest CPU to raise a system reset exception on CPUs within the same guest -- all CPUs, all-but-self, or a specific CPU (including self). This has not made its way to a PAPR release yet, but we have an hcall number assigned. H_SIGNAL_SYS_RESET = 0x380 Syntax: hcall(uint64 H_SIGNAL_SYS_RESET, int64 target); Generate a system reset NMI on the threads indicated by target. Values for target: -1 = target all online threads including the caller -2 = target all online threads except for the caller All other negative values: reserved Positive values: The thread to be targeted, obtained from the value of the "ibm,ppc-interrupt-server#s" property of the CPU in the OF device tree. Semantics: - Invalid target: return H_Parameter. - Otherwise: Generate a system reset NMI on target thread(s), return H_Success. Signed-off-by: Nicholas Piggin <[email protected]> Signed-off-by: David Gibson <[email protected]>
1c7ad77e56767fb36a7ccc954d304d4ac768b374
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1c7ad77e56767fb36a7ccc954d304d4ac768b374
2017-01-31 10:10:13+11:00
nios2: Add disas entries Add nios2 disassembler support. This patch is composed from binutils files from commit "Opcodes and assembler support for Nios II R2". The files from binutils used in this patch are: include/opcode/nios2.h include/opcode/nios2r1.h include/opcode/nios2r2.h opcodes/nios2-opc.c opcodes/nios2-dis.c Checkpatch says total: 114 errors, 0 warnings, 3609 lines checked , which is caused by a different coding style in those files. These warnings and errors are not addressed To let these files be easily synchronized between binutils and qemu. Signed-off-by: Marek Vasut <[email protected]> Cc: Chris Wulff <[email protected]> Cc: Jeff Da Silva <[email protected]> Cc: Ley Foon Tan <[email protected]> Cc: Sandra Loosemore <[email protected]> Cc: Yves Vandervennet <[email protected]> Reviewed-by: Alexander Graf <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
3f0c3423093fe7a07af3806cc773bf7d71adf8c9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3f0c3423093fe7a07af3806cc773bf7d71adf8c9
2017-01-24 13:10:35-08:00
hw/ppc/spapr: Fix boot path of usb-host storage devices When passing through an USB storage device to a pseries guest, it is currently not possible to automatically boot from the device if the "bootindex" property has been specified, too (e.g. when using "-device nec-usb-xhci -device usb-host,hostbus=1,hostaddr=2,bootindex=0" at the command line). The problem is that QEMU builds a device tree path like "/pci@800000020000000/usb@0/usb-host@1" and passes it to SLOF in the /chosen/qemu,boot-list property. SLOF, however, probes the USB device, recognizes that it is a storage device and thus changes its name to "storage", and additionally adds a child node for the SCSI LUN, so the correct boot path in SLOF is something like "/pci@800000020000000/usb@0/storage@1/disk@101000000000000" instead. So when we detect an USB mass storage device with SCSI interface, we've got to adjust the firmware boot-device path properly that SLOF can automatically boot from the device. Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1354177 Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: David Gibson <[email protected]>
b99260ebbb5844da9e77fbcaa73b7b6980a68acf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b99260ebbb5844da9e77fbcaa73b7b6980a68acf
2017-01-31 10:10:13+11:00
target/xtensa: implement MEMCTL SR MEMCTL SR controls zero overhead loop buffer and number of ways enabled in L1 caches. Signed-off-by: Max Filippov <[email protected]>
9e03ade4411c81a7f7d974dcedf0390835ce4096
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9e03ade4411c81a7f7d974dcedf0390835ce4096
2017-01-15 13:01:56-08:00
aio-posix: remove walking_handlers, protecting AioHandler list with list_lock Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
2bbf11d753761ca537333c2bd7ddadb06758f62c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2bbf11d753761ca537333c2bd7ddadb06758f62c
2017-01-16 13:25:18+00:00
tcg/s390: Expose host facilities to tcg-target.h This lets us expose facilities to TCG_TARGET_HAS_* defines directly, rather than hiding behind function calls. Signed-off-by: Richard Henderson <[email protected]>
b2c98d9d392c87c9b9e975d30f79924719d9cbbe
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b2c98d9d392c87c9b9e975d30f79924719d9cbbe
2017-01-10 08:06:10-08:00
qmp: Report QOM type name on query-cpu-definitions The new typename attribute on query-cpu-definitions will be used to help management software use device-list-properties to check which properties can be set using -cpu or -global for the CPU model. Signed-off-by: Eduardo Habkost <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
8ed877b78498c89aa7ce5c76aa20841ff5072796
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8ed877b78498c89aa7ce5c76aa20841ff5072796
2017-01-12 15:51:36-02:00
nvdimm acpi: drop the lock of fit buffer as there is a global lock to protect vm-exit handlers and QMP/monitor, this lock can be dropped Suggested-by: Igor Mammedov <[email protected]> Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Igor Mammedov <[email protected]>
12f86b5b3e1bdf75e0a467d771c16cc42f3a1f1a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/12f86b5b3e1bdf75e0a467d771c16cc42f3a1f1a
2016-11-15 17:20:37+02:00
cadence_uart: Check if receiver timeout counter is disabled When register Rcvr_timeout_reg0 (R_RTOR in cadence_uart.c) is set to 0, the receiver timeout counter should be disabled. See page 1801 of "Zynq-7000 AP SoC Technical Reference Manual". This commit adds a such a check before setting the receive timeout interrupt. Signed-off-by: Andrew Gacek <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
2494c9f6405a1979319f12d1bb4e9a6eb28a529d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2494c9f6405a1979319f12d1bb4e9a6eb28a529d
2016-12-27 14:59:23+00:00
virtio-crypto: set capacity of algorithms supported Expose the capacity of algorithms supported by virtio crypto device to the frontend driver using pci configuration space. Signed-off-by: Gonglei <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
050652d9be4c723da2a36f2e9ca5be20e27e93b7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/050652d9be4c723da2a36f2e9ca5be20e27e93b7
2016-11-01 19:21:08+02:00
9pfs: limit xattr size in xattrcreate We shouldn't allow guests to create extended attribute with arbitrary sizes. On linux hosts, the limit is XATTR_SIZE_MAX. Let's use it. Signed-off-by: Greg Kurz <[email protected]>
3b79ef2cf48805dc693a8b0c82e05e0abeaa64f8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3b79ef2cf48805dc693a8b0c82e05e0abeaa64f8
2016-11-01 12:03:02+01:00
Fix cursesw detection On systems which do not provide ncursesw.pc and whose /usr/include/curses.h does not include wide support, we should not only try with no -I, i.e. /usr/include, but also with -I/usr/include/ncursesw. To properly detect for wide support with and without -Werror, we need to check for the presence of e.g. the WACS_DEGREE macro. We also want to stop at the first curses_inc_list configuration which works, and make sure to set IFS to : at each new loop. Signed-off-by: Samuel Thibault <[email protected]> Tested-by: Cornelia Huck <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
7c7030029626db81f4e7a003945f293fdd764611
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7c7030029626db81f4e7a003945f293fdd764611
2016-11-10 15:29:58+00:00
raw_bsd: add offset and size options Added two new options 'offset' and 'size'. This makes it possible to use only part of the file as a device. This can be used e.g. to limit the access only to single partition in a disk image or use a disk inside a tar archive (like OVA). When 'size' is specified we do our best to honour it. Signed-off-by: Tomáš Golembiovský <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
2fdc70452a59484c85359dc8d5a0650245288781
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2fdc70452a59484c85359dc8d5a0650245288781
2016-10-31 16:52:39+01:00
ppc/pnv: add a core mask to PnvChip This will be used to build real HW ids for the cores and enforce some limits on the available cores per chip. Signed-off-by: Cédric Le Goater <[email protected]> Reviewed-by: David Gibson <[email protected]> Signed-off-by: David Gibson <[email protected]>
397a79e7575c4ea98507ff9d1d2629b58725d484
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/397a79e7575c4ea98507ff9d1d2629b58725d484
2016-10-28 09:38:25+11:00
mirror: use bdrv_drained_begin/bdrv_drained_end Ensure that there are no changes between the last check to bdrv_get_dirty_count and the switch to the target. There is already a bdrv_drained_end call, we only need to ensure that bdrv_drained_begin is not called twice. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Message-Id: <[email protected]> Signed-off-by: Fam Zheng <[email protected]>
9a0cec664eefed475a5954006e29f2fd7cd29d2a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9a0cec664eefed475a5954006e29f2fd7cd29d2a
2016-10-28 21:50:18+08:00
tcg: Add atomic128 helpers Force the use of cmpxchg16b on x86_64. Wikipedia suggests that only very old AMD64 (circa 2004) did not have this instruction. Further, it's required by Windows 8 so no new cpus will ever omit it. If we truely care about these, then we could check this at startup time and then avoid executing paths that use it. Reviewed-by: Emilio G. Cota <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
7ebee43ee3e2fcd7b5063058b7ef74bc43216733
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7ebee43ee3e2fcd7b5063058b7ef74bc43216733
2016-10-26 08:29:01-07:00
atomics: Add parameters to macros Making these functional rather than object macros will prevent later problems with complex macro expansion. Reviewed-by: Emilio G. Cota <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
d1a9f2d12fcfc942924956fbe321aedf4226ccb7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d1a9f2d12fcfc942924956fbe321aedf4226ccb7
2016-10-26 08:28:46-07:00
tcg: comment on which functions have to be called with tb_lock held softmmu requires more functions to be thread-safe, because translation blocks can be invalidated from e.g. notdirty callbacks. Probably the same holds for user-mode emulation, it's just that no one has ever tried to produce a coherent locking there. This patch will guide the introduction of more tb_lock and tb_unlock calls for system emulation. Note that after this patch some (most) of the mentioned functions are still called outside tb_lock/tb_unlock. The next one will rectify this. Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Alex Bennée <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
7d7500d99895f888f97397ef32bb536bb0df3b74
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7d7500d99895f888f97397ef32bb536bb0df3b74
2016-10-31 10:51:16+01:00
xhci: limit the number of link trbs we are willing to process Needed to avoid we run in circles forever in case the guest builds an endless loop with link trbs. Reported-by: Li Qiang <[email protected]> Tested-by: P J P <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected]
05f43d44e4bc26611ce25fd7d726e483f73363ce
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/05f43d44e4bc26611ce25fd7d726e483f73363ce
2016-10-12 12:36:36+02:00
ui: move some initialization out of vnc_init_state Most of the fields in VncState are initialized in the vnc_connect() method, but some are done in vnc_init_state() instead. The purpose of having vnc_init_state() is to delay starting of the VNC wire protocol until after the websockets handshake has completed. As such the vnc_init_state() method only needs to be used for initialization that is dependant on the wire protocol running. This also lets us get rid of the initialized boolean flag from the VncState struct. Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
90cd03a30ee96779ee9ae36a84b387452e256358
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/90cd03a30ee96779ee9ae36a84b387452e256358
2016-10-13 09:22:30+02:00
qapi: rename *qmp-*-visitor* to *qobject-*-visitor* The QMP visitors have no direct dependency on QMP. It is valid to use them anywhere that one has a QObject. Rename them to better reflect their functionality as a generic QObject to QAPI converter. This is the first of three parts: rename the files. The next two parts will rename C identifiers. The split is necessary to make git rename detection work. Reviewed-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> [Split into file and identifier rename, two comments touched up] Signed-off-by: Markus Armbruster <[email protected]>
b3db211f3c80bb996a704d665fe275619f728bd4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b3db211f3c80bb996a704d665fe275619f728bd4
2016-10-25 16:25:48+02:00
block: Update bs->open_flags earlier in bdrv_open_common() We're only doing this immediately before opening the image, but bs->open_flags is used earlier in the function. At the moment this is not causing problems because none of the checked flags are modified by update_flags_from_options(), but this will change when we introduce the "read-only" option. This patch calls update_flags_from_options() at the beginning of the function, immediately after creating the QemuOpts. Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
9b7e8691670fab57c387b6955dc14a09696ae034
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9b7e8691670fab57c387b6955dc14a09696ae034
2016-09-23 13:36:10+02:00
maint: Ignore generated version file Commit 67a1de0d created a generated version file, and, in some circumstances, also a temporary file. Make sure 'git add .' won't check them into the repository. Signed-off-by: Eric Blake <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
e2f310ec384d51c85c1498b49d66893d6dd036b7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e2f310ec384d51c85c1498b49d66893d6dd036b7
2016-09-13 18:12:34+03:00
cadence_gem: Correct indentation Fix up the indentation inside the for loop that was introduced in the previous patch. This commit is almost empty if viewed using 'git show -w', except for a few changes that were required to avoid the 80 charecter line limit. Signed-off-by: Alistair Francis <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Message-id: b40d1b12d24be9f0ac5d72f86249103e0c1c720a.1469727764.git.alistair.francis@xilinx.com Signed-off-by: Peter Maydell <[email protected]>
77524d1157cf7c18b980c9d6f95879f2ce7e56e2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/77524d1157cf7c18b980c9d6f95879f2ce7e56e2
2016-09-22 18:13:07+01:00
crypto: make PBKDF iterations configurable for LUKS format As protection against bruteforcing passphrases, the PBKDF algorithm is tuned by counting the number of iterations needed to produce 1 second of running time. If the machine that the image will be used on is much faster than the machine where the image is created, it can be desirable to raise the number of iterations. This change adds a new 'iter-time' property that allows the user to choose the iteration wallclock time. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]>
3bd18890cab82735ae2565fa50aa122e1b4a0ef0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3bd18890cab82735ae2565fa50aa122e1b4a0ef0
2016-09-19 16:30:45+01:00
nbd: Fix bad flag detection on server Commit ab7c548e added a check for invalid flags, but used an early return on error instead of properly going through the cleanup label. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
5bee0f4717c4c67394aaade0c5a9cee3d42cc614
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5bee0f4717c4c67394aaade0c5a9cee3d42cc614
2016-08-03 18:44:56+02:00
block: Add .bdrv_co_pdiscard() driver callback There's enough drivers with a sector-based callback that it will be easier to switch one at a time. This patch adds a byte-based callback, and then after all drivers are swapped, we'll drop the sector-based callback. [checkpatch doesn't like the space after coroutine_fn in block_int.h, but it's consistent with the rest of the file] Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
47a5486d598e0cfef6c87c5f44b85955a5f2c4ff
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/47a5486d598e0cfef6c87c5f44b85955a5f2c4ff
2016-07-20 14:11:55+01:00
aux: fix break that wanted to break two levels out The last "ret = AUX_I2C_NACK;" is dead, because it is always overridden by AUX_I2C_ACK. What really the code wants is to jump out of the switch statement, and a "return" will not cut it because it would omit a debug printf. Change the logic so that we can break out of the while loop. For clarity, hoist the bus->last_* assignments up, right after i2c_start_transfer. Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
5229f45bd98558af84d806a98032df3cb741c357
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5229f45bd98558af84d806a98032df3cb741c357
2016-07-07 13:47:00+01:00
arm: virt: Parse cpu_model only once Considering that features are converted to global properties and global properties are automatically applied to every new instance of created CPU (at object_new() time), there is no point in parsing cpu_model string every time a CPU created. So move parsing outside CPU creation loop and do it only once. Parsing also should be done before any CPU is created so that features would affect the first CPU a well. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
09f71b054a95161950a03fafc9023637929bd404
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/09f71b054a95161950a03fafc9023637929bd404
2016-07-07 15:25:05-03:00
block: Move request_alignment into BlockLimit It makes more sense to have ALL block size limit constraints in the same struct. Improve the documentation while at it. Simplify a couple of conditionals, now that we have audited and documented that request_alignment is always non-zero. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
a5b8dd2ce83208cd7d6eb4562339ecf5aae13574
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a5b8dd2ce83208cd7d6eb4562339ecf5aae13574
2016-07-05 16:46:26+02:00
test: port postcopy test to ppc64 As userfaultfd syscall is available on powerpc, migration postcopy can be used. This patch adds the support needed to test this on powerpc, instead of using a bootsector to run code to modify memory, we use a FORTH script in "boot-command" property. As spapr machine doesn't support "-prom-env" argument (the nvram is initialized by SLOF and not by QEMU), "boot-command" is provided to SLOF via a file mapped nvram (with "-drive file=...,if=pflash") Signed-off-by: Laurent Vivier <[email protected]> Signed-off-by: David Gibson <[email protected]>
aaf89c8a49a8c1259b6b181d701070c6df83f3d7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/aaf89c8a49a8c1259b6b181d701070c6df83f3d7
2016-07-29 12:02:31+10:00
hw/mips: implement Global Interrupt Controller The Global Interrupt Controller (GIC) is responsible for mapping each internal and external interrupt to the correct location for servicing. The internal representation of registers is different from the specification in order to consolidate information for each GIC Interrupt Sources and Virtual Processors with same functionalities. For example SH_MAP00_VP00 registers are defined like each bit represents a VP but in this implementation the equivalent map_vp contains VP number in integer form for ease accesses. When it is being accessed via read write functions an internal data is converted back into the original format as the specification. Limitations: Level triggering only GIC CounterHi not implemented (Countbits = 32bits) DINT not implemented Local WatchDog, Fast Debug Channel, Perf Counter not implemented Signed-off-by: Yongbok Kim <[email protected]> Signed-off-by: Leon Alrae <[email protected]>
e8bd336dd1af6d1073e9411bd1c47b045988b30a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e8bd336dd1af6d1073e9411bd1c47b045988b30a
2016-07-12 09:10:12+01:00
hw/intc/arm_gicv3: Wire up distributor and redistributor MMIO regions Wire up the MMIO functions exposed by the distributor and the redistributor into MMIO regions exposed by the GICv3 device. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Shannon Zhao <[email protected]> Tested-by: Shannon Zhao <[email protected]> Message-id: [email protected]
287c181ae4132d7cc75ea422051f2c90e90b6493
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/287c181ae4132d7cc75ea422051f2c90e90b6493
2016-06-17 15:23:51+01:00
target-i386: Call cpu_exec_init() on realize QOM instance_init functions are not supposed to have any side-effects, as new objects may be created at any moment for querying property information (see qmp_device_list_properties()). Calling cpu_exec_init() also affects QEMU's ability to handle errors during CPU creation, as some actions done by cpu_exec_init() can't be reverted. Move cpu_exec_init() call to realize so a simple object_new() won't trigger it, and so that it is called after some basic validation of CPU parameters. Reviewed-by: Igor Mammedov <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
42ecabaae16c0054dde6d8b0fdf90a8c7cce270d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/42ecabaae16c0054dde6d8b0fdf90a8c7cce270d
2016-05-23 19:47:37-03:00
qemu-img: check block status of backing file when converting. When converting images, check the block status of its backing file chain to avoid needlessly reading zeros. Signed-off-by: Ren Kimura <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
263a6f4c3aa9b6cd9f58d1368b318d948156a4e8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/263a6f4c3aa9b6cd9f58d1368b318d948156a4e8
2016-05-12 15:33:23+02:00
target-i386: Move TCG initialization check to tcg_x86_init() Instead of requiring cpu.c to check if TCG was already initialized, simply let the function be called multiple times. Suggested-by: Igor Mammedov <[email protected]> Reviewed-by: Igor Mammedov <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
4fe15cdedf8728e58b8e475f8b1a26fb16aa9caa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4fe15cdedf8728e58b8e475f8b1a26fb16aa9caa
2016-05-23 19:47:37-03:00
s390x/ipl: Add type and length checks for IplParameterBlock values We can check for valid type and lengths of the IplParameterBlock fields when receiving the struct from the guest. Length of the IplParameterBlock can be less than 4K. To play safe we can read and write only required amount of data. Signed-off-by: Alexander Yarygin <[email protected]> Reviewed-by: David Hildenband <[email protected]> Acked-by: Christian Borntraeger <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
9946a9113cf5d84c9381342100343aa97f736ee0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9946a9113cf5d84c9381342100343aa97f736ee0
2016-05-17 15:50:29+02:00
block: add support for encryption secrets in block I/O tests The LUKS block driver tests will require the ability to specify encryption secrets with block devices. This requires using the --object argument to qemu-img/qemu-io to create a 'secret' object. When the IMGKEYSECRET env variable is set, it provides the password to be associated with a secret called 'keysec0' The _qemu_img_wrapper function isn't modified as that needs to cope with differing syntax for subcommands, so can't be made to use the image opts syntax unconditionally. Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
b7e875b2f98c2724b5f915f5808f8828fd9b05a8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b7e875b2f98c2724b5f915f5808f8828fd9b05a8
2016-05-12 15:33:24+02:00
linux-user: add rtnetlink(7) support rtnetlink is needed to use iproute package (ip addr, ip route) and dhcp client. Examples: Without this patch: # ip link Cannot open netlink socket: Address family not supported by protocol # ip addr Cannot open netlink socket: Address family not supported by protocol # ip route Cannot open netlink socket: Address family not supported by protocol # dhclient eth0 Cannot open netlink socket: Address family not supported by protocol Cannot open netlink socket: Address family not supported by protocol With this patch: # ip link 1: lo: <LOOPBACK,UP,LOWER_UP> mtu 65536 qdisc noqueue state UNKNOWN mode DEFAULT link/loopback 00:00:00:00:00:00 brd 00:00:00:00:00:00 51: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP mode DEFAULT qlen 1000 link/ether 00:16:3e:89:6b:d7 brd ff:ff:ff:ff:ff:ff # ip addr show eth0 51: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP qlen 1000 link/ether 00:16:3e:89:6b:d7 brd ff:ff:ff:ff:ff:ff inet 192.168.122.197/24 brd 192.168.122.255 scope global eth0 valid_lft forever preferred_lft forever inet6 fe80::216:3eff:fe89:6bd7/64 scope link valid_lft forever preferred_lft forever # ip route default via 192.168.122.1 dev eth0 192.168.122.0/24 dev eth0 proto kernel scope link src 192.168.122.197 # ip addr flush eth0 # ip addr add 192.168.122.10 dev eth0 # ip addr show eth0 51: eth0: <BROADCAST,MULTICAST,UP,LOWER_UP> mtu 1500 qdisc fq_codel state UP qlen 1000 link/ether 00:16:3e:89:6b:d7 brd ff:ff:ff:ff:ff:ff inet 192.168.122.10/32 scope global eth0 valid_lft forever preferred_lft forever # ip route add 192.168.122.0/24 via 192.168.122.10 # ip route 192.168.122.0/24 via 192.168.122.10 dev eth0 Signed-off-by: Laurent Vivier <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
6c5b5645ae0b73c052df962e18e48d87bb7385e0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6c5b5645ae0b73c052df962e18e48d87bb7385e0
2016-06-07 11:33:36+03:00
qapi-commands: Wrap argument visit in visit_start_struct The qmp-input visitor was allowing callers to play rather fast and loose: when visiting a QDict, you could grab members of the root dictionary without first pushing into the dict; among the culprit callers was the generated marshal code on the 'arguments' dictionary of a QMP command. But we are about to tighten the input visitor, at which point the generated marshal code MUST follow the same paradigms as everyone else, of pushing into the struct before grabbing its keys. Generated code grows as follows: |@@ -515,7 +641,12 @@ void qmp_marshal_blockdev_backup(QDict * | BlockdevBackup arg = {0}; | | v = qmp_input_get_visitor(qiv); |+ visit_start_struct(v, NULL, NULL, 0, &err); |+ if (err) { |+ goto out; |+ } | visit_type_BlockdevBackup_members(v, &arg, &err); |+ visit_end_struct(v, err ? NULL : &err); | if (err) { | goto out; | } |@@ -527,7 +715,9 @@ out: | qmp_input_visitor_cleanup(qiv); | qdv = qapi_dealloc_visitor_new(); | v = qapi_dealloc_get_visitor(qdv); |+ visit_start_struct(v, NULL, NULL, 0, NULL); | visit_type_BlockdevBackup_members(v, &arg, NULL); |+ visit_end_struct(v, NULL); | qapi_dealloc_visitor_cleanup(qdv); | } The use of 'err ? NULL : &err' is temporary; a later patch will clean that up when it splits visit_end_struct(). Prior to this patch, the fact that there was no final visit_end_struct() meant that even though we are using a strict input visit, the marshalling code was not detecting excess input at the top level (only in nested levels). Fortunately, we have code in monitor.c:qmp_check_client_args() that also checks for no excess arguments at the top level. But as the generated code is more compact than the manual check, a later patch will clean up monitor.c to drop the redundancy added here. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
ed8415351941715f606749d6cdd64553b0de3f01
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ed8415351941715f606749d6cdd64553b0de3f01
2016-05-12 09:47:54+02:00
block/vpc: tests for auto-detecting VPC and Hyper-V VHD images This tests auto-detection, and overrides, of VHD image sizes created by Virtual PC, Hyper-V, and Disk2vhd. This adds three sample images: hyperv2012r2-dynamic.vhd.bz2 - dynamic VHD image created with Hyper-V virtualpc-dynamic.vhd.bz2 - dynamic VHD image created with Virtual PC d2v-zerofilled.vhd.bz2 - dynamic VHD image created with Disk2vhd Signed-off-by: Jeff Cody <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
798609bbe29df4edf4bbec46927fc12862b02378
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/798609bbe29df4edf4bbec46927fc12862b02378
2016-03-14 16:46:42+01:00
nbd: enable use of TLS with NBD block driver This modifies the NBD driver so that it is possible to request use of TLS. This is done by providing the 'tls-creds' parameter with the ID of a previously created QCryptoTLSCreds object. For example $QEMU -object tls-creds-x509,id=tls0,endpoint=client,\ dir=/home/berrange/security/qemutls \ -drive driver=nbd,host=localhost,port=9000,tls-creds=tls0 The client will drop the connection if the NBD server does not provide TLS. Signed-off-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
75822a12c046646684bc8cad6296842b60e7b6bb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/75822a12c046646684bc8cad6296842b60e7b6bb
2016-02-16 17:16:33+01:00
qapi: Don't special-case simple union wrappers Simple unions were carrying a special case that hid their 'data' QMP member from the resulting C struct, via the hack method QAPISchemaObjectTypeVariant.simple_union_type(). But by using the work we started by unboxing flat union and alternate branches, coupled with the ability to visit the members of an implicit type, we can now expose the simple union's implicit type in qapi-types.h: | struct q_obj_ImageInfoSpecificQCow2_wrapper { | ImageInfoSpecificQCow2 *data; | }; | | struct q_obj_ImageInfoSpecificVmdk_wrapper { | ImageInfoSpecificVmdk *data; | }; ... | struct ImageInfoSpecific { | ImageInfoSpecificKind type; | union { /* union tag is @type */ | void *data; |- ImageInfoSpecificQCow2 *qcow2; |- ImageInfoSpecificVmdk *vmdk; |+ q_obj_ImageInfoSpecificQCow2_wrapper qcow2; |+ q_obj_ImageInfoSpecificVmdk_wrapper vmdk; | } u; | }; Doing this removes asymmetry between QAPI's QMP side and its C side (both sides now expose 'data'), and means that the treatment of a simple union as sugar for a flat union is now equivalent in both languages (previously the two approaches used a different layer of dereferencing, where the simple union could be converted to a flat union with equivalent C layout but different {} on the wire, or to an equivalent QMP wire form but with different C representation). Using the implicit type also lets us get rid of the simple_union_type() hack. Of course, now all clients of simple unions have to adjust from using su->u.member to using su->u.member.data; while this touches a number of files in the tree, some earlier cleanup patches helped minimize the change to the initialization of a temporary variable rather than every single member access. The generated qapi-visit.c code is also affected by the layout change: |@@ -7393,10 +7393,10 @@ void visit_type_ImageInfoSpecific_member | } | switch (obj->type) { | case IMAGE_INFO_SPECIFIC_KIND_QCOW2: |- visit_type_ImageInfoSpecificQCow2(v, "data", &obj->u.qcow2, &err); |+ visit_type_q_obj_ImageInfoSpecificQCow2_wrapper_members(v, &obj->u.qcow2, &err); | break; | case IMAGE_INFO_SPECIFIC_KIND_VMDK: |- visit_type_ImageInfoSpecificVmdk(v, "data", &obj->u.vmdk, &err); |+ visit_type_q_obj_ImageInfoSpecificVmdk_wrapper_members(v, &obj->u.vmdk, &err); | break; | default: | abort(); Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
32bafa8fdd098d52fbf1102d5a5e48d29398c0aa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/32bafa8fdd098d52fbf1102d5a5e48d29398c0aa
2016-03-18 10:29:26+01:00
nbd: make server compliant with fixed newstyle spec If the client does not request the fixed new style protocol, then we should only accept NBD_OPT_EXPORT_NAME. All other options are only valid when fixed new style has been activated. The qemu-nbd client doesn't currently request fixed new style protocol, but this change won't break qemu-nbd, because it fortunately only ever uses NBD_OPT_EXPORT_NAME, so was never triggering the non-compliant server behaviour. Signed-off-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
26afa868dbd8641070c0a8d851b082b603c04fa1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/26afa868dbd8641070c0a8d851b082b603c04fa1
2016-02-16 17:14:24+01:00
hw/net/spapr_llan: Fix receive buffer handling for better performance tl;dr: This patch introduces an alternate way of handling the receive buffers of the spapr-vlan device, resulting in much better receive performance for the guest. Full story: One of our testers recently discovered that the performance of the spapr-vlan device is very poor compared to other NICs, and that a simple "ping -i 0.2 -s 65507 someip" in the guest can result in more than 50% lost ping packets (especially with older guest kernels < 3.17). After doing some analysis, it was clear that there is a problem with the way we handle the receive buffers in spapr_llan.c: The ibmveth driver of the guest Linux kernel tries to add a lot of buffers into several buffer pools (with 512, 2048 and 65536 byte sizes by default, but it can be changed via the entries in the /sys/devices/vio/1000/pool* directories of the guest). However, the spapr-vlan device of QEMU only tries to squeeze all receive buffer descriptors into one single page which has been supplied by the guest during the H_REGISTER_LOGICAL_LAN call, without taking care of different buffer sizes. This has two bad effects: First, only a very limited number of buffer descriptors is accepted at all. Second, we also hand 64k buffers to the guest even if the 2k buffers would fit better - and this results in dropped packets in the IP layer of the guest since too much skbuf memory is used. Though it seems at a first glance like PAPR says that we should store the receive buffer descriptors in the page that is supplied during the H_REGISTER_LOGICAL_LAN call, chapter 16.4.1.2 in the LoPAPR spec declares that "the contents of these descriptors are architecturally opaque, none of these descriptors are manipulated by code above the architected interfaces". That means we don't have to store the RX buffer descriptors in this page, but can also manage the receive buffers at the hypervisor level only. This is now what we are doing here: Introducing proper RX buffer pools which are also sorted by size of the buffers, so we can hand out a buffer with the best fitting size when a packet has been received. To avoid problems with migration from/to older version of QEMU, the old behavior is also retained and enabled by default. The new buffer management has to be enabled via a new "use-rx-buffer-pools" property. Now with the new buffer pool management enabled, the problem with "ping -s 65507" is fixed for me, and the throughput of a simple test with wget increases from creeping 3MB/s up to 20MB/s! Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: David Gibson <[email protected]>
831e8822530bb511a24329494f9121ad1f8b94ab
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/831e8822530bb511a24329494f9121ad1f8b94ab
2016-03-24 11:17:34+11:00
checkpatch: Eliminate false positive in case of space before square bracket in a definition Now, macro definition such as "#define abc(x) [x] = y" should pass without an error. Signed-off-by: Leonid Bloch <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
8800cf0a336147478dff6f2b0a47d8285b828f6d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8800cf0a336147478dff6f2b0a47d8285b828f6d
2016-02-15 20:02:09+01:00
xen: Drop __XEN_LATEST_INTERFACE_VERSION__ checks from prior to Xen 4.2 We assume (and check for in configure) 4.2 or later now. In reality all of the removed checks are for far older versions. FMT_ioreq_size is no longer needed. Signed-off-by: Ian Campbell <[email protected]> Reviewed-by: Stefano Stabellini <[email protected]> Signed-off-by: Stefano Stabellini <[email protected]>
47d3df2387ed6927732584ffa4159c26d9f4dee8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/47d3df2387ed6927732584ffa4159c26d9f4dee8
2016-02-10 12:01:32+00:00
ssi: Move ssi.h into a separate directory Move the ssi.h include file into the ssi directory. While touching the code also fix the typdef lines as checkpatch complains. Signed-off-by: Alistair Francis <[email protected]> Reviewed-by: Peter Crosthwaite <[email protected]> Signed-off-by: Peter Crosthwaite <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
8fd06719e7d37f91f1b843af4cdcdfe7eb3e4a69
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8fd06719e7d37f91f1b843af4cdcdfe7eb3e4a69
2016-01-21 14:15:03+00:00
block: Release named dirty bitmaps in bdrv_close() bdrv_delete() is not very happy about deleting BlockDriverStates with dirty bitmaps still attached to them. In the past, we got around that very easily by relying on bdrv_close_all() bypassing bdrv_delete(), and bdrv_close() simply ignoring that condition. We should fix that by releasing all named dirty bitmaps in bdrv_close() (there should not be any unnamed bitmaps left) and moving the assertion from bdrv_delete() there. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
c5acdc9ab4e6aa9b05e6242114479333b15d496b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c5acdc9ab4e6aa9b05e6242114479333b15d496b
2016-02-02 17:50:46+01:00
qapi: Don't box struct branch of alternate There's no reason to do two malloc's for an alternate type visiting a QAPI struct; let's just inline the struct directly as the C union branch of the struct. Surprisingly, no clients were actually using the struct member prior to this patch outside of the testsuite; an earlier patch in the series added some testsuite coverage to make the effect of this patch more obvious. In qapi.py, c_type() gains a new is_unboxed flag to control when we are emitting a C struct unboxed within the context of an outer struct (different from our other two modes of usage with no flags for normal local variable declarations, and with is_param for adding 'const' in a parameter list). I don't know if there is any more pythonic way of collapsing the two flags into a single parameter, as we never have a caller setting both flags at once. Ultimately, we want to also unbox branches for QAPI unions, but as that touches a lot more client code, it is better as separate patches. But since unions and alternates share gen_variants(), I had to hack in a way to test if we are visiting an alternate type for setting the is_unboxed flag: look for a non-object branch. This works because alternates have at least two branches, with at most one object branch, while unions have only object branches. The hack will go away in a later patch. The generated code difference to qapi-types.h is relatively small: | struct BlockdevRef { | QType type; | union { /* union tag is @type */ | void *data; |- BlockdevOptions *definition; |+ BlockdevOptions definition; | char *reference; | } u; | }; The corresponding spot in qapi-visit.c calls visit_type_FOO(), which first calls visit_start_struct() to allocate or deallocate the member and handle a layer of {} from the JSON stream, then visits the members. To peel off the indirection and the memory management that comes with it, we inline this call, then suppress allocation / deallocation by passing NULL to visit_start_struct(), and adjust the member visit: | switch ((*obj)->type) { | case QTYPE_QDICT: |- visit_type_BlockdevOptions(v, name, &(*obj)->u.definition, &err); |+ visit_start_struct(v, name, NULL, 0, &err); |+ if (err) { |+ break; |+ } |+ visit_type_BlockdevOptions_fields(v, &(*obj)->u.definition, &err); |+ error_propagate(errp, err); |+ err = NULL; |+ visit_end_struct(v, &err); | break; | case QTYPE_QSTRING: | visit_type_str(v, name, &(*obj)->u.reference, &err); The visit of non-object fields is unchanged. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [Commit message tweaked] Signed-off-by: Markus Armbruster <[email protected]>
becceedc4d9bc1435099c90a0514945a89844d3a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/becceedc4d9bc1435099c90a0514945a89844d3a
2016-02-19 11:08:57+01:00
9pfs: rename virtio-9p-synth.{c,h} to 9p-synth.{c,h} These two files are not virtio specific. Rename them to use generic names. Fix includes in various C files. Change define guards and comments in header files. Signed-off-by: Wei Liu <[email protected]> Signed-off-by: Aneesh Kumar K.V <[email protected]>
364031f17932814484657e5551ba12957d993d7e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/364031f17932814484657e5551ba12957d993d7e
2016-01-08 12:40:55+05:30
pc: Move enforce_aligned_dimm to PCMachineClass enforce_aligned_dimm never changes after the machine is initialized, so it can be simply set in PCMachineClass like all the other compat fields. Cc: Igor Mammedov <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
16a9e8a5bcc1fb0796828eb654a4f926734e59af
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/16a9e8a5bcc1fb0796828eb654a4f926734e59af
2015-12-22 17:45:12+02:00
hw/arm/virt: Fix property "gic-version" error handling virt_set_gic_version() calls exit(1) when passed an invalid property value. Property setters are not supposed to do that. Screwed up in commit b92ad39. Harmless, because the property belongs to a machine. Set an error object instead. Cc: Peter Maydell <[email protected]> Cc: [email protected] Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Peter Maydell <[email protected]>
7b55044f9d96ec518e7ab58bd8a3637b52a35f79
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7b55044f9d96ec518e7ab58bd8a3637b52a35f79
2016-01-13 11:58:58+01:00
target-arm: Use the right MMU index in arm_regime_using_lpae_format arm_regime_using_lpae_format checks whether the LPAE extension is used for stage 1 translation regimes. MMU indexes not exclusively of a stage 1 regime won't work with this method. In case of ARMMMUIdx_S12NSE0 or ARMMMUIdx_S12NSE1, offset these values by ARMMMUIdx_S1NSE0 to get the right index indicating a stage 1 translation regime. Rename also the function to arm_s1_regime_using_lpae_format and update the comments to reflect the change. Signed-off-by: Alvise Rigo <[email protected]> Message-id: [email protected] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
deb2db996cbb9470b39ae1e383791ef34c4eb3c2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/deb2db996cbb9470b39ae1e383791ef34c4eb3c2
2016-01-15 14:10:02+00:00
qemu-char: convert to use error checked base64 decode Switch from using g_base64_decode over to qbase64_decode in order to get error checking of the base64 input data. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]>
e9cf2fe07ff70e939f80c624b44c10a4442eef0b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e9cf2fe07ff70e939f80c624b44c10a4442eef0b
2015-12-18 16:25:08+00:00
qemu-iotests: Test reopen with node-name/driver options 'node-name' and 'driver' should not be changed during a reopen operation. It is, however, valid to specify them with the same value as they already had. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]>
0a8111e0fbeccdf94ee011bc3b3013a45166a9a8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0a8111e0fbeccdf94ee011bc3b3013a45166a9a8
2015-12-18 14:34:43+01:00
virtio-pci: unbreak queue_enable read Guest always get zero when reading queue_enable. This violates spec. Fixing this by setting the queue_enable to true during any guest writing and setting it to zero during reset. Cc: Michael S. Tsirkin <[email protected]> Signed-off-by: Jason Wang <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
393f04d3ab40d03aa2fde0017ff7f02fc34cbd4e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/393f04d3ab40d03aa2fde0017ff7f02fc34cbd4e
2015-11-12 15:49:33+02:00