commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
qapi: More rigourous checking of types Now that we know every expression is valid with regards to its keys, we can add further tests that those keys refer to valid types. With this patch, all uses of a type (the 'data': of command, type, union, alternate, and event; the 'returns': of command; the 'base': of type and union) must resolve to an appropriate subset of metatypes declared by the current qapi parse; this includes recursing into each member of a data dictionary. Dealing with '**' and nested anonymous structs will be done in later patches. Update the testsuite to match improved output. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
dd883c6f0547f02ae805d02852ff3691f6d08f85
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dd883c6f0547f02ae805d02852ff3691f6d08f85
2015-05-05 18:39:01+02:00
rcu tests: fix compilation on 32-bit ppc 32-bit PPC cannot do atomic operations on long long. Inside the loops, we are already using local counters that are summed at the end of the run---with some exceptions (rcu_stress_count for rcutorture, n_nodes for test-rcu-list): fix them to use the same technique. For test-rcu-list, remove the mostly unused member "val" from the list. Then, use a mutex to protect the global counts. Performance does not matter there because every thread will only enter the critical section once. Remaining uses of atomic instructions are for ints or pointers. Reported-by: Andreas Faerber <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
8a5956ad6392f115521dad774055c737c49fb0dd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8a5956ad6392f115521dad774055c737c49fb0dd
2015-03-25 13:37:10+01:00
virtio: validate the existence of handle_output before calling it We don't validate the existence of handle_output which may let a buggy guest to trigger a SIGSEV easily. E.g: 1) write 10 to queue_sel to a virtio net device with only 1 queue 2) setup an arbitrary pfn 3) then notify queue 10 Fixing this by validating the existence of handle_output before. Cc: [email protected] Cc: Michael S. Tsirkin <[email protected]> Signed-off-by: Jason Wang <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Don Koch <[email protected]> Reviewed-by: Fam Zheng <[email protected]>
9e0f5b8108e248b78444c9a2ec41a8309825736c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9e0f5b8108e248b78444c9a2ec41a8309825736c
2015-03-16 15:29:51+01:00
virtio-blk: Check return value of blk_aio_ioctl Since commit 1dc936aa84 (virtio-blk: Use blk_aio_ioctl) we silently lose the request if blk_aio_ioctl returns NULL (not implemented). Fix it by directly returning VIRTIO_BLK_S_UNSUPP as we used to do. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> [ kwolf: Fixed build error on win32 ] Signed-off-by: Kevin Wolf <[email protected]>
a209f4615c6853a226e847810b6c607c71b6a046
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a209f4615c6853a226e847810b6c607c71b6a046
2015-03-10 14:01:45+01:00
scsi-hd: fix property unset case Commit c53659f0 ("BlockConf: Call backend functions to detect geometry and blocksizes") causes a segmentation fault on the invalid configuration of a scsi device without a drive. Let's check for conf.blk before calling blkconf_blocksizes. The error will be handled later on in scsi_realize anyway. Reported-by: Max Reitz <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Ekaterina Tumanova <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
df1d4c341a735334de23513f17bf110c8c49b3e7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/df1d4c341a735334de23513f17bf110c8c49b3e7
2015-03-10 14:02:24+01:00
bios linker: validate pointer within table buios linker assumes pointer parameter it gets is within table, validate this. Signed-off-by: Michael S. Tsirkin <[email protected]>
12e63900f01ce54702745d83f985e26042adda9b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/12e63900f01ce54702745d83f985e26042adda9b
2015-02-26 12:42:15+01:00
timer: replace time() with QEMU_CLOCK_HOST This patch replaces time() function calls with calls to qemu_clock_get_ns(QEMU_CLOCK_HOST). It makes such requests deterministic in record/replay mode of icount. Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <20150227131102.11912.89850.stgit@PASHA-ISP> Signed-off-by: Paolo Bonzini <[email protected]>
2ed1ebcf65edf6757d8904000889ce52cc0a9d1b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2ed1ebcf65edf6757d8904000889ce52cc0a9d1b
2015-02-27 15:15:50+01:00
qemu-img: Suppress unhelpful extra errors in convert, resize add_old_style_options() for img_convert() and img_resize() use qemu_opt_set(), which reports errors with qerror_report_err(). Its error messages aren't helpful here, the caller reports one that actually makes sense. Reproducer: $ qemu-img convert -B raw in.img out.img qemu-img: Invalid parameter 'backing_file' qemu-img: Backing file not supported for file format 'raw' Switch to qemu_opt_set_err() to get rid of the unwanted messages. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]>
6750e795b167e3defab36502e61b8c57ede119eb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6750e795b167e3defab36502e61b8c57ede119eb
2015-02-26 14:48:16+01:00
s390x/mmu: Add support for read-only regions If the "DAT-protection" bit is set in the region table entry and EDAT is enabled, only read accesses are allowed in the corresponding memory area. Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
43d49b0115aef2ead5125d4aa9719852d47ef6fc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/43d49b0115aef2ead5125d4aa9719852d47ef6fc
2015-02-18 09:37:14+01:00
s390x/mmu: Check table length and offset fields The ACSEs have a table length field and the region entries have table length and offset fields which must be checked during translation to see whether the given virtual address is really covered by the translation table. Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
5d180439d07774c5a2477cf9901c9b51c9edd74b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5d180439d07774c5a2477cf9901c9b51c9edd74b
2015-02-18 09:37:14+01:00
exec: protect mru_block with RCU Hence, freeing a RAMBlock has to be switched to call_rcu. Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
43771539d4666cba16298fc6b0ea63867425277c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/43771539d4666cba16298fc6b0ea63867425277c
2015-02-16 17:30:19+01:00
qemu-sockets: improve error reporting in unix_listen_opts Coverity complains about not checking the returned value of mkstemp. While at it, also improve error checking for snprintf, and refine error messages in general. Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
b658c53d2b87c1e9e0ade887a70ecb0de1474a7b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b658c53d2b87c1e9e0ade887a70ecb0de1474a7b
2015-02-10 09:27:20+03:00
vhost-scsi: add a property for booting Because Qemu only accept an wwpn argument for vhost-scsi, we cannot assign a tpgt. That's say tpg is transparent for Qemu, Qemu doesn't know which tpg can boot, but vhost-scsi driver module doesn't know too for one assigned wwpn. At present, we assume that the first tpg can boot only, and add a boot_tpgt property that defaults to 0. Of course, people can pass a valid value by qemu command line. Suggested-by: Paolo Bonzini <[email protected]> Signed-off-by: Gonglei <[email protected]> Acked-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
9143d5f0f14c1eef92a362b3b976606ad2874daa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9143d5f0f14c1eef92a362b3b976606ad2874daa
2015-02-11 21:47:52+01:00
block/dmg: factor out block type check In preparation for adding bzip2 support, split the type check into a separate function. Make all offsets relative to the begin of a chunk such that it is easier to recognize the position without having to add up all offsets. Some comments are added to describe the fields. There is no functional change. Signed-off-by: Peter Wu <[email protected]> Reviewed-by: John Snow <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
a8b10c6ead7f62e8eadbdaf944f371889c3c4c29
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a8b10c6ead7f62e8eadbdaf944f371889c3c4c29
2015-02-06 17:24:21+01:00
gen-icount: check cflags instead of use_icount global Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
cd42d5b23691ad73edfd6dbcfc935a960a9c5a65
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cd42d5b23691ad73edfd6dbcfc935a960a9c5a65
2015-01-03 09:22:12+01:00
qemu-iotests: Add supported os parameter for python tests If I understand correctly, qemu-iotests never meant to be portable. We only support Linux for all the shell cases, but didn't specify it for python tests. Now add this and default all the python tests as Linux only. If we cares enough later, we can override the parameter in individual cases. Signed-off-by: Fam Zheng <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
bc521696607c5348fcd8a9e57b408d0ac0dbe2f8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bc521696607c5348fcd8a9e57b408d0ac0dbe2f8
2015-01-13 13:43:28+00:00
spice: reduce refresh rate in native mode Now that cursor updates are out of the way qxl needs the refresh timer only when when running in vga mode, for dirty bitmap checking. In native qxl mode the guest will notify us, so we don't need to poll and can use the idle interval (one refresh wakeup every few seconds). Cc: Marc-André Lureau <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
3dcadce5076d4b42fa395c39662d65e050b77784
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3dcadce5076d4b42fa395c39662d65e050b77784
2014-12-16 14:15:29+01:00
target-arm: make PAR banked When EL3 is running in AArch32 (or ARMv7 with Security Extensions) PAR has a secure and a non-secure instance. Signed-off-by: Fabian Aggeler <[email protected]> Signed-off-by: Greg Bellows <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
01c097f7960b330c4bf038d34bae17ad6c1ba499
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/01c097f7960b330c4bf038d34bae17ad6c1ba499
2014-12-11 12:07:52+00:00
target-arm: make IFSR banked When EL3 is running in AArch32 (or ARMv7 with Security Extensions) IFSR has a secure and a non-secure instance. Adds IFSR32_EL2 definition and storage. Signed-off-by: Fabian Aggeler <[email protected]> Signed-off-by: Greg Bellows <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
88ca1c2d70523486a952065f3ed7b8fc823b5863
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/88ca1c2d70523486a952065f3ed7b8fc823b5863
2014-12-11 12:07:51+00:00
pc: explicitly check maxmem limit when adding DIMM Currently maxmem limit is not checked and depends on hotplug region container not being able to fit more RAM than maxmem. Do check explicitly so that it would be possible to change hotplug container size later to deal with fragmentation. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
b03541fa7722d64a1c961a8467d778d7e086a933
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b03541fa7722d64a1c961a8467d778d7e086a933
2014-11-24 20:57:10+02:00
net: The third parameter of getsockname should be initialized Signed-off-by: zhanghailiang <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
ed6273e26fdfb94a282dbbf1234a75422c6b4c4b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ed6273e26fdfb94a282dbbf1234a75422c6b4c4b
2014-11-18 15:04:35+00:00
apic_common: migrate missing fields This patch adds missed sipi_vector and wait_for_sipi fields to a new subsection of the vmstate of the apic_common module. Saving and loading of these fields makes migration of the apic state deterministic. Signed-off-by: Pavel Dovgalyuk <[email protected]> [Initialize the field in pre_load and kvm_apic_realize. - Paolo] Signed-off-by: Paolo Bonzini <[email protected]>
c2c00148ec54f77c9432fec16585834e1d677fda
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c2c00148ec54f77c9432fec16585834e1d677fda
2014-11-13 16:13:27+01:00
block/vdi: Limit maximum size even futher The block layer read and write functions do not like requests which are bigger than INT_MAX bytes. Since the VDI bmap is read and written in a single operation, its size is therefore limited accordingly. This reduces the maximum VDI image size supported by QEMU to half of what it currently is (down to approximately 512 TB). The VDI test 084 has to be adapted accordingly. Actually, one could clearly see that it was broken from the "Could not open 'TEST_DIR/t.IMGFMT': Invalid argument" line for an image which was supposed to work just fine. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Peter Lieven <[email protected]>
d20418ee514774626ac47a1ad0aa9149c7249cf0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d20418ee514774626ac47a1ad0aa9149c7249cf0
2014-11-09 23:39:50+01:00
linuxboot: compute initrd loading address Even though hw/i386/pc.c tries to compute a valid loading address for the initrd, close to the top of RAM, this does not take into account other data that is malloced into that memory by SeaBIOS. Luckily we can easily look at the memory map to find out how much memory is used up there. This patch places the initrd in the first four gigabytes, below the first hole (as returned by INT 15h, AX=e801h). Without this patch: [ 0.000000] init_memory_mapping: [mem 0x07000000-0x07fdffff] [ 0.000000] RAMDISK: [mem 0x0710a000-0x07fd7fff] With this patch: [ 0.000000] init_memory_mapping: [mem 0x07000000-0x07fdffff] [ 0.000000] RAMDISK: [mem 0x07112000-0x07fdffff] So linuxboot is able to use the 64k that were added as padding for QEMU <= 2.1. Acked-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
cdebec5e40bd0af82da0659f37af85ee2aa2c9d1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cdebec5e40bd0af82da0659f37af85ee2aa2c9d1
2014-10-09 15:36:15+02:00
blockdev: Orphaned drive search When users use command line options like -hda, -cdrom, or even -drive if=ide, it is up to the board initialization routines to pick up these drives and create backing devices for them. Some boards, like Q35, have not been doing this. However, there is no warning explaining why certain drive specifications are just silently ignored, so this function adds a check to print some warnings to assist users in debugging these sorts of issues in the future. This patch will not warn about drives added with if_none, for which it is not possible to tell in advance if the omission of a backing device is an issue. A warning in these cases is considered appropriate. Signed-off-by: John Snow <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
a66c9dc734fb30de1e18e9dc217f2d37e16c492a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a66c9dc734fb30de1e18e9dc217f2d37e16c492a
2014-10-03 10:30:33+01:00
target-arm: Report a valid L1Ip field in CTR_EL0 for CPU type "any" For the CPU type "any" (only used with linux-user) we were reporting the L1Ip field as 0b00, which is reserved. Change this field to 0b10 instead, indicating a VIPT icache as the comment describes. Reported-by: Laurent Desnogues <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Laurent Desnogues <[email protected]> Message-id: [email protected]
0e7b176ae01d5a664d4cbf619a7315819494e6cb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0e7b176ae01d5a664d4cbf619a7315819494e6cb
2014-10-24 12:19:13+01:00
raw-posix: Fix build without posix_fallocate() Check for the presence of posix_fallocate() in configure and only compile in support for PREALLOC_MODE_FALLOC when it's there. Signed-off-by: Kevin Wolf <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
ed9114356b587b362f5ed10e75366a4f07ed32af
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ed9114356b587b362f5ed10e75366a4f07ed32af
2014-09-29 16:28:24+01:00
.travis.yml: remove "make check" from main matrix There are problems with unreliability in "make check" which still need to be tracked down. As the tests are broadly the same for all targets if added one explicit target to the matrix to run it. However this does build all softmmu targets to ensure they at least "run" Signed-off-by: Alex Bennée <[email protected]> Reviewed-by: Alexander Graf <[email protected]> Reviewed-by: Brian Jackson <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
ed173cb704f01a62143a3ef0dcf8b493bc795c23
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ed173cb704f01a62143a3ef0dcf8b493bc795c23
2014-09-26 21:05:06+04:00
tests: avoid running duplicate qom-tests Since 3687d532 we've been unconditionally adding qom-test to our qtests for every arch. However, some archs inherit their tests from Makefile variables for other archs, such as i386/x86_64, microblaze/microblazeel, and xtensa/xtensaeb. Since these are evaluated in a lazy manner, we ultimately end up adding qom-test twice. In the case x86_64, where we have a large number of machine types that we rerun qom-test for, this has lead to a fairly noticeable increase in the overall run-time of `make check` (78s vs. 42s on my machine). Similar speed-ups are visible for other such archs, but not nearly as significant. Fix this by only adding qom-test to an arch's test list if it's not already present. Signed-off-by: Michael Roth <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Reviewed-by: Andreas Färber <[email protected]> Cc: [email protected] Signed-off-by: Michael Tokarev <[email protected]>
2b8419cb4911731db6c883fa7b0428ad4a355d9d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2b8419cb4911731db6c883fa7b0428ad4a355d9d
2014-09-26 21:03:26+04:00
block: Validate node-name The device_name of a BlockDriverState is currently checked because it is always used as a QemuOpts ID and qemu_opts_create() checks whether such IDs are wellformed. node-name is supposed to share the same namespace, but it isn't checked currently. This patch adds explicit checks both for device_name and node-name so that the same rules will still apply even if QemuOpts won't be used any more at some point. qemu-img used to use names with spaces in them, which isn't allowed any more. Replace them with underscores. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]>
9aebf3b89281a173d2dfeee379b800be5e3f363e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9aebf3b89281a173d2dfeee379b800be5e3f363e
2014-09-25 15:24:32+02:00
blkdebug: show an error for invalid event names It is easy to typo a blkdebug configuration and waste a lot of time figuring out why no rules are matching. Push the Error** down into add_rule() so we can report an error when the event name is invalid. Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Gonglei <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
d4362d642e5cfd50671eba250b5888a89a88691a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d4362d642e5cfd50671eba250b5888a89a88691a
2014-09-25 15:24:14+02:00
ppc: synchronize excp_vectors for injecting exception This patch synchronizes env->excp_vectors[] with env->iovr[]. This is required for using the existing interrupt injection mechanism for kvm. Signed-off-by: Bharat Bhushan <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
c371c2e3e0d7ad979dc2bb9763223287fabdcc24
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c371c2e3e0d7ad979dc2bb9763223287fabdcc24
2014-09-08 12:50:49+02:00
ide/ahci: Check for -ECANCELED in aio callbacks Before, bdrv_aio_cancel will either complete the request (like normal) and call CB with an actual return code, or skip calling the request (for example when the IO req is not submitted by thread pool yet). We will change bdrv_aio_cancel to do it differently: always call CB before return, with either [1] a normal req completion ret code, or [2] ret == -ECANCELED. So the callers' callback must accept both cases. The existing logic works with case [1], but not [2]. The simplest transition of callback code is do nothing in case [2], just as if the CB is not called by the bdrv_aio_cancel() call. Suggested-by: Paolo Bonzini <[email protected]> Signed-off-by: Fam Zheng <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
0d910cfeaf2076b116b4517166d5deb0fea76394
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0d910cfeaf2076b116b4517166d5deb0fea76394
2014-09-22 11:38:55+01:00
spapr: Refactor spapr_populate_memory() to allow memoryless nodes Current QEMU does not support memoryless NUMA nodes, however actual hardware may have them so it makes sense to have a way to emulate them in QEMU. This prepares SPAPR for that. This moves 2 calls of spapr_populate_memory_node() into the existing loop over numa nodes so first several nodes may have no memory and this still will work. If there is no numa configuration, the code assumes there is just a single node at 0 and it has all the guest memory. Signed-off-by: Alexey Kardashevskiy <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
7db8a127e373e468d1f61e46e01e50d1aa33e827
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7db8a127e373e468d1f61e46e01e50d1aa33e827
2014-09-08 12:50:48+02:00
virtio-net: don't run bh on vm stopped commit 783e7706937fe15523b609b545587a028a2bdd03 virtio-net: stop/start bh when appropriate is incomplete: BH might execute within the same main loop iteration but after vmstop, so in theory, we might trigger an assertion. I was unable to reproduce this in practice, but it seems clear enough that the potential is there, so worth fixing. Cc: [email protected] Reported-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
e8bcf842001739765b8dcc1996d86a0ffd2054d5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e8bcf842001739765b8dcc1996d86a0ffd2054d5
2014-09-04 17:19:09+01:00
intel-iommu: introduce Intel IOMMU (VT-d) emulation Add support for emulating Intel IOMMU according to the VT-d specification for the q35 chipset machine. Implement the logics for DMAR (DMA remapping) without PASID support. The emulation supports register-based invalidation and primary fault logging. Signed-off-by: Le Tan <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
1da12ec4c81330eb1ed1f29a78854bea87a23595
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1da12ec4c81330eb1ed1f29a78854bea87a23595
2014-08-28 23:10:22+02:00
ahci: Fix FIS decomposition This patch introduces a few changes to how FIS packets are deciphered in the AHCI virtual device. The summary of changes can be grouped into two pieces: [A] Changes to how we apply a preliminary sieve to FISes, [B] Changes in how we internalize a decomposed FIS. == Changes to how we apply a preliminary sieve to FISes == (1) Packets may now either update the Control register or the Command register, but not both. This is according to the SATA 3.2 specification which states: "...the device either initiates processing of the command indicated in the Command register or initiates processing of the control request indicated [...] depending on the state of the C bit in the FIS." See SATA 3.2 section 10.5.5.4, "Reception" in the 10.5.5 "Register Host to Device FIS" section. This change accounts for the first two regions of change within the diff. All other changes belong to the following changes. == Changes in how we internalize a decomposed FIS == (2) Instead of trying to extract the sector number out of the FIS from bytes 4-10 and setting it with ide_set_sector, we set the appropriate IDEState registers and trust that ide_get_sector can retrieve the correct sector later. By "constructing" the sector for use with ide_set_sector, we are duplicating the mechanisms of ide_get_sector. This change makes the FIS decomposition more obvious. SATA 3.2 as a specification does not make the legacy register mapping with respect to the D2H FIS obvious. However, SATA 3.2 section 10.5.5.1 "Register Host to Device FIS layout" describes all of the "cmd_fis" bytes: 0 - FIS Type (0x27) 1 - Port Multiplier Port and Command Update flag 2 - ATA Command 3 - Features_Low 4 - LBA 7:0 5 - LBA 15:8 6 - LBA 23:16 7 - Device, AKA "Drive Select." 8 - LBA 31:24 9 - LBA 39:32 10 - LBA 47:40 11 - Features_High 12 - Count Low 13 - Count High 14 - ICC 15 - Control 16-19 - Auxiliary (for NCQ, defined per-command) Most of these registers map to existing IDEState registers in obvious ways, especially features, select, hob_features, and nsector (count). ICC is reserved in older specifications but is not supported in our implementation, and remains unused here. The Control register is not valid for a command that is trying to update the command register and is to be considered reserved at this point. What is not obvious is the LBA register mappings, but SATA 1.0 can help inform of us legacy device support, see SATA 1.0 section 8.5.2 "Register - Host to Device." LBA 7:0 - Sector Number (sector) LBA 15:8 - Cyl Low (lcyl) LBA 23:16 - Cyl High (hcyl) LBA 31:24 - Sector Num Exp. (hob_sector) LBA 39:32 - Cyl Low Exp. (hob_lcyl) LBA 47:40 - Cyl High Exp. (hob_hcyl) These mappings help guide which registers the FIS should be decomposed into/towards for CHS, LBA28 and LBA48 commands. As a note: The prior confusion that can be seen in the documentation arises from the fact that CHS and LBA28 commands use the low nybble of the drive select register to store LBA 27:24, whereas LNA48 commands use the hob_sector, hob_lcyl and hob_hcyl registers as explained above. The decomposition as it stands now will correctly decompose CHS, LBA28 and LBA48 commands into their appropriate registers where the core IDE/ATAPI layers can deal with them correctly. See the below point for more information. (3) We save cmd_fis[7] as ide_state->select, which informs decisions about if we are using LBA or CHS. This corrects a bug in AHCI wherein we attempt to set and/or retrieve the sector number by using ide_set_sector and ide_get_sector, which depend on the select register to determine if we are using LBA or CHS. Without this adjustment, LBA48 read/writes are currently broken. Thanks to Eniac Zheng @ HP for pointing this out. (4) Save cmd_fis[11] as ide_state->hob_feature, as defined in SATA 3.2. (5) For several ATA commands, the sector count register set to 0 is a magic number that means 256 sectors. For LBA48 commands, this means 65,536 sectors. We drop the magic sector correction here, and trust the ide core layer to handle the conversion appropriately, in ide_cmd_lba48_transform(). As it stands, the current AHCI code is only compliant with LBA28 commands. By simply removing the magic, it will work with LBA28 and LBA48. (6) We expand FIS decomposition to include both ATAPI and IDE devices. We leave the logic of determining if the fields are valid or not to the respective layers. This change intends to make it clearer that AHCI is only a composition mechanism for the FIS packets: the meanings of the registers is best left to the implementation layers for those devices. (7) Forcefully setting the feature, hcyl and lcyl registers for ATAPI commands is removed. - The hcyl and lcyl magic present here is valid at boot only, and should not be overridden for every PACKET command. - The feature register is defined as valid for the PACKET command, so we should not suppress it. The ATAPI layer does not even currently depend on or require 0x01 as mandatory. Signed-off-by: John Snow <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
1cbdd96813474de4191b0b37b859a5460373093b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1cbdd96813474de4191b0b37b859a5460373093b
2014-11-14 09:20:35+00:00
checkpatch.pl: adjust typedef definition to QEMU coding style Most QEMU typedefs are camelcase, starting with one uppercase letter and containing at least one lowercase letter. There are a few all-uppercase types, add the most common too. This fixes recognition of types in lines such as static __attribute__((unused)) inline void tcg_out8(TCGContext *s, uint8_t v) (Example provided by Peter Maydell). Reported-by: Alexey Kardashevskiy <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Cc: Peter Maydell <[email protected]> Cc: Stefan Weil <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
a6859deb6908261c9a9adf9cc4b8863fc0897b5c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a6859deb6908261c9a9adf9cc4b8863fc0897b5c
2014-08-26 13:44:28+02:00
pc-dimm: validate node property If user specifies a node number that exceeds the available numa nodes in emulated system for pc-dimm device, the device will report an invalid _PXM to OSPM. Fix this by checking the node property value. Cc: [email protected] Signed-off-by: Hu Tao <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
cfe0ffd0272f1a6d34d27ac1a7072d1c42d33ad3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cfe0ffd0272f1a6d34d27ac1a7072d1c42d33ad3
2014-08-14 13:20:59+02:00
block: vpc - use block layer ops in vpc_create, instead of posix calls Use the block layer to create, and write to, the image file in the VPC .bdrv_create() operation. This has a couple of benefits: Images can now be created over protocols, and hacks such as NOCOW are not needed in the image format driver, and the underlying file protocol appropriate for the host OS can be relied upon. Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Jeff Cody <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
fef6070eff233400015cede968b0afe46c80bb0f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fef6070eff233400015cede968b0afe46c80bb0f
2014-08-15 15:07:15+02:00
virtio-rng: Add human-readable error message for negative max-bytes parameter If a negative integer is used for the max_bytes parameter, QEMU currently calls abort() and leaves behind a core dump. This patch replaces the abort with a simple error message to make the reason for the termination clearer. This also ensures device-hotplug with invalid input doesn't cause qemu to quit. There is an underlying insufficiency in the parameter parsing code of QEMU that renders it unable to reject negative values for unsigned properties, thus the error message "a non-negative integer below 2^63" is the most user-friendly and correct message we can give until the underlying insufficiency is corrected. Signed-off-by: John Snow <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Amit Shah <[email protected]>
713e8a102222b6b8ca65050d13b287f5705831b0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/713e8a102222b6b8ca65050d13b287f5705831b0
2014-07-22 17:18:55+05:30
AioContext: speed up aio_notify In many cases, the call to event_notifier_set in aio_notify is unnecessary. In particular, if we are executing aio_dispatch, or if aio_poll is not blocking, we know that we will soon get to the next loop iteration (if necessary); the thread that hosts the AioContext's event loop does not need any nudging. The patch includes a Promela formal model that shows that this really works and does not need any further complication such as generation counts. It needs a memory barrier though. The generation counts are not needed because any change to ctx->dispatching after the memory barrier is okay for aio_notify. If it changes from zero to one, it is the right thing to skip event_notifier_set. If it changes from one to zero, the event_notifier_set is unnecessary but harmless. Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
0ceb849bd336a5f9b6e1ed56d45cf5773d251ad8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0ceb849bd336a5f9b6e1ed56d45cf5773d251ad8
2014-07-09 15:50:11+02:00
exec: fix migration with devices that use address_space_rw Devices that use address_space_rw to write large areas to memory (as opposed to address_space_map/unmap) were broken with respect to migration since fe680d0 (exec: Limit translation limiting in address_space_translate to xen, 2014-05-07). Such devices include IDE CD-ROMs. The reason is that invalidate_and_set_dirty (called by address_space_rw but not address_space_map/unmap) was only setting the dirty bit for the first page in the translation. To fix this, introduce cpu_physical_memory_set_dirty_range_nocode that is the same as cpu_physical_memory_set_dirty_range except it does not muck with the DIRTY_MEMORY_CODE bitmap. This function can be used if the caller invalidates translations with tb_invalidate_phys_page_range. There is another difference between cpu_physical_memory_set_dirty_range and cpu_physical_memory_set_dirty_flag; the former includes a call to xen_modified_memory. This is handled separately in invalidate_and_set_dirty, and is not needed in other callers of cpu_physical_memory_set_dirty_range_nocode, so leave it alone. Just one nit: now that invalidate_and_set_dirty takes care of handling multiple pages, there is no need for address_space_unmap to wrap it in a loop. In fact that loop would now be O(n^2). Reported-by: Dave Gilbert <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Tested-by: Gerd Hoffmann <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
6886867e9880830d735d8ae6f6cc63ed9eb2be0c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6886867e9880830d735d8ae6f6cc63ed9eb2be0c
2014-07-22 10:38:50+02:00
AioContext: do not rely on aio_poll(ctx, true) result to end a loop Currently, whenever aio_poll(ctx, true) has completed all pending work it returns true *and* the next call to aio_poll(ctx, true) will not block. This invariant has its roots in qemu_aio_flush()'s implementation as "while (qemu_aio_wait()) {}". However, qemu_aio_flush() does not exist anymore and bdrv_drain_all() is implemented differently; and this invariant is complicated to maintain and subtly different from the return value of GMainLoop's g_main_context_iteration. All calls to aio_poll(ctx, true) except one are guarded by a while() loop checking for a request to be incomplete, or a BlockDriverState to be idle. The one remaining call (in iothread.c) uses this to delay the aio_context_release/acquire pair until the AioContext is quiescent, however: - we can do the same just by using non-blocking aio_poll, similar to how vl.c invokes main_loop_wait - it is buggy, because it does not ensure that the AioContext is released between an aio_notify and the next time the iothread goes to sleep. This leads to hangs when stopping the dataplane thread. In the end, these semantics are a bad match for the current users of AioContext. So modify that one exception in iothread.c, which also fixes the hangs, as well as the testcase so that it use the same idiom as the actual QEMU code. Reported-by: Christian Borntraeger <[email protected]> Tested-by: Christian Borntraeger <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
acfb23ad3dd8d0ab385a10e483776ba7dcf927ad
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/acfb23ad3dd8d0ab385a10e483776ba7dcf927ad
2014-07-14 12:03:20+02:00
nbd: Don't export a block device with no medium. The device is exported with erroneous values and can't be read. Before the patch: $ sudo nbd-client localhost -p 10809 /dev/nbd0 -name floppy0 Negotiation: ..size = 17592186044415MB bs=1024, sz=18446744073709547520 bytes $ sudo mount /dev/nbd0 /mnt/tmp/ mount: block device /dev/nbd0 is write-protected, mounting read-only mount: /dev/nbd0: can't read superblock After the patch: (qemu) nbd_server_add ide0-hd0 (qemu) nbd_server_add floppy0 Device 'floppy0' has no medium Signed-off-by: Hani Benhabiles <[email protected]> Cc: [email protected] Signed-off-by: Paolo Bonzini <[email protected]>
60fe4fac22895576973e317d7148b084c31cc64c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/60fe4fac22895576973e317d7148b084c31cc64c
2014-06-27 16:06:48+02:00
irq: Slim conversion of qemu_irq to QOM As a prequel to any big Pin refactoring plans, do an in-place conversion of qemu_irq to an Object, so that we can reference it in link<> properties. Signed-off-by: Andreas Färber <[email protected]> [ PC Changes: * Removed array-alloctor ref counting logic (limit changes just to * single IRQ allocator) * Removed WIP marking from subject line ] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Crosthwaite <[email protected]> Acked-by: Paolo Bonzini <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
615c4895703164134379b68214130dd502721174
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/615c4895703164134379b68214130dd502721174
2014-07-01 04:12:48+02:00
signal/ppc/{save,restore}_user_regs remove __put/get error checks As __get_user and __put_user do not return errors, remove the if checks from around them. This allows making the save/restore functions void. Signed-off-by: Riku Voipio <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Cc: Alexander Graf <[email protected]>
c650c008e326f3a1e84083bc269265456057a212
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c650c008e326f3a1e84083bc269265456057a212
2014-06-17 08:52:07+03:00
KVM: PPC: Expose fixup hcall capability New kvm versions expose a PPC_FIXUP_HCALL capability. Make it visible to machine code so we can take decisions based on it. Signed-off-by: Alexander Graf <[email protected]>
87a91de61a34a7f3222203556df8a67f187360cd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/87a91de61a34a7f3222203556df8a67f187360cd
2014-06-16 13:24:41+02:00
s390x: cleanup interrupt injection Remove the need for a cpu to inject a floating interrupt on kvm. Acked-by: Thomas Huth <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
de13d2161473d02ae97ec0f8e4503147554892dd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/de13d2161473d02ae97ec0f8e4503147554892dd
2014-06-10 09:50:27+02:00
net: cadence_gem: Add Tx descriptor fetch printf Add a debug printf for TX descriptor fetching. This is helpful to anyone needing to debug TX ring buffer traversal. It is also now consistent with the RX code which has a similar printf. Signed-off-by: Peter Crosthwaite <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
fa15286a758eb036258bffae2b6c128e2a477cc3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fa15286a758eb036258bffae2b6c128e2a477cc3
2014-06-10 19:39:34+04:00
target-i386: simplify SMAP handling in MMU_KSMAP_IDX Do not use this MMU index at all if CR4.SMAP is false, and drop the SMAP check from x86_cpu_handle_mmu_fault. Signed-off-by: Paolo Bonzini <[email protected]>
f57584dc874f0ba92403b4ade631c232564fb027
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f57584dc874f0ba92403b4ade631c232564fb027
2014-06-05 16:10:34+02:00
target-ppc: Merge 970FX and 970MP into a single 970 class The differences between classes were: 1. SLB size, was 32 for 970 and 64 for others, should be 64 for all; 2. check_pow() callback, HID0 format is the same so should be the same 0x01C00000 which means "deep nap", "doze" and "nap" bits set; 3. LPCR - 970 does not have it but 970MP had one (by mistake). This fixes wrong differences and makes one 970 class. This fixes wrong registration of LPCR which is not present on 970. This defines HID0 bits and uses them in check_pow_970(). This does not copy MSR_SHV (Hypervisor State, HV) bit from 970FX to 970 class as we do not emulate hypervisor in QEMU anyway. This does not remove check_pow_970FX now as it is still used by POWER5+ class, this will be addressed later. Signed-off-by: Alexey Kardashevskiy <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
bbc01ca7f265f2c5be8aee7c9ce1d10aa26063f5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bbc01ca7f265f2c5be8aee7c9ce1d10aa26063f5
2014-06-16 13:24:42+02:00
vfio: Fix 128 bit handling Upcoming VFIO on SPAPR PPC64 support will initialize the IOMMU memory region with UINT64_MAX (2^64 bytes) size so int128_get64() will assert. The patch takes care of this check. The existing type1 IOMMU code is not expected to map all 64 bits of RAM so the patch does not touch that part. Signed-off-by: Alexey Kardashevskiy <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Alex Williamson <[email protected]>
7532d3cbf148f72c9476484223b94a188ab59706
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7532d3cbf148f72c9476484223b94a188ab59706
2014-05-30 13:02:02-06:00
target-xtensa: fix cross-page jumps/calls at the end of TB Use tb->pc instead of dc->pc to check for cross-page jumps. When TB translation stops at the page boundary dc->pc points to the next page allowing chaining to TBs in it, which is wrong. Cc: [email protected] Signed-off-by: Max Filippov <[email protected]>
433d33c555deeed375996e338df1a9510df401c6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/433d33c555deeed375996e338df1a9510df401c6
2014-05-26 12:33:54+04:00
console: nicer initial screen Now that we have a function to create a fancy DisplaySurface with a message for the user, to handle non-existing graphics hardware, we can make it more generic and use it for other things too. This patch adds a text line to the in initial DisplaySurface, notifying the user that the display isn't initialized yet by the guest. You can see this in action when starting qemu with '-S'. Also when booting ovmf in qemu (which needs a few moments to initialize itself before it initializes the vga). Signed-off-by: Gerd Hoffmann <[email protected]>
521a580d2352ad30086babcabb91e6338e47cf62
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/521a580d2352ad30086babcabb91e6338e47cf62
2014-05-26 08:41:02+02:00
qcow2: Catch bdrv_getlength() error The call to bdrv_getlength() from qcow2_check_refcounts() may result in an error. Check this and abort if necessary. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
a49139af77850d64d74f9ffe43cabe7aa4f19de0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a49139af77850d64d74f9ffe43cabe7aa4f19de0
2014-04-30 14:46:17+02:00
input: switch sparc32 kbd to new input api Nasty 0xe0 logic is gone. We map through QKeyCode now, giving us a nice, readable mapping table. Quick smoke test in OpenFirmware looks ok. Careful check from arch maintainers would be very nice, especially on the capslock and numlock logic. I'm not fully sure whenever I got it translated correctly and also what it is supposed to do in the first place ... Signed-off-by: Gerd Hoffmann <[email protected]>
65e7545ea3c65a6468fb59418a6dbe66ef71d6d1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/65e7545ea3c65a6468fb59418a6dbe66ef71d6d1
2014-05-16 08:30:12+02:00
block: Fix nb_sectors check in bdrv_check_byte_request() nb_sectors is signed, check for negative values. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]>
54db38a47978381e23e7f6479c31a97b5d352f7e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/54db38a47978381e23e7f6479c31a97b5d352f7e
2014-04-22 11:57:02+02:00
block: Expose host_* drivers in blockdev-add All the functionality to use the host_device, host_cdrom and host_floppy drivers is already there, they just need to be added to the schema. The block driver names containing underscores are preexisting and cannot be changed without breaking command line compatibility. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
a28315ebaf3910b65ef51abefc4ef040265afc19
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a28315ebaf3910b65ef51abefc4ef040265afc19
2014-04-25 18:05:06+02:00
curl: Remove erroneous sleep waiting for curl completion The driver will not start more than a fixed number of curl sessions. If it needs more, it must wait for the completion of an existing one. The driver was sleeping, which will prevent the main loop from running, and therefore the event it's waiting on. It was also directly calling its internal handler rather than waiting on existing registered handlers to be called from the main loop. This change causes it simply to wait for a period of time whilst allowing the main loop to execute. Signed-off-by: Matthew Booth <[email protected]> Tested-by: Richard W.M. Jones <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
e466183718bfaaf347a3c02499473068a0072114
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e466183718bfaaf347a3c02499473068a0072114
2014-04-30 16:34:11+02:00
target-arm: Split out private-to-target functions into internals.h Currently cpu.h defines a mixture of functions and types needed by the rest of QEMU and those needed only by files within target-arm/. Split the latter out into a new header so they aren't needlessly exposed further than required. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Peter Crosthwaite <[email protected]>
ccd380876b79c3b46f85720c1be8e2cd40509460
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ccd380876b79c3b46f85720c1be8e2cd40509460
2014-04-17 21:34:03+01:00
block/iscsi: speed up read for unallocated sectors this patch implements a cache that tracks if a page on the iscsi target is allocated or not. The cache is implemented in a way that it allows for false positives (e.g. pretending a page is allocated, but it isn't), but no false negatives. The cached allocation info is then used to speed up the read process for unallocated sectors by issueing a GET_LBA_STATUS request for all sectors that are not yet known to be allocated. If the read request is confirmed to fall into an unallocated range we directly return zeroes and do not transfer the data over the wire. Tests have shown that a relatively small amount of GET_LBA_STATUS requests happens a vServer boot time to fill the allocation cache (all those blocks are not queried again). Not to transfer all the data of unallocated sectors saves a lot of time, bandwidth and storage I/O load during block jobs or storage migration and it saves a lot of bandwidth as well for any big sequential read of the whole disk (e.g. block copy or speed tests) if a significant number of blocks is unallocated. Signed-off-by: Peter Lieven <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
b03c38057b7ac4ffb60fa98a26dd4c8d5fa9c54c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b03c38057b7ac4ffb60fa98a26dd4c8d5fa9c54c
2014-04-29 11:14:25+02:00
target-i386: reorder fields in cpu/msr_hyperv_hypercall subsection The subsection already exists in one well-known enterprise Linux distribution, but for some strange reason the fields were swapped when forward-porting the patch to upstream. Limit headaches for said enterprise Linux distributor when the time will come to rebase their version of QEMU. Signed-off-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
466e6e9d13d56bbb6da1d2396d7d6347df483af0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/466e6e9d13d56bbb6da1d2396d7d6347df483af0
2014-04-05 10:49:05+01:00
qcow2: Fix backing file name length check len could become negative and would pass the check then. Nothing bad happened because bdrv_pread() happens to return an error for negative length values, but make variables for sizes unsigned anyway. This patch also changes the behaviour to error out on invalid lengths instead of silently truncating it to 1023. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
6d33e8e7dc9d40ea105feed4b39caa3e641569e8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6d33e8e7dc9d40ea105feed4b39caa3e641569e8
2014-04-01 14:19:09+02:00
gtk: Don't warp absolute pointer This matches the behavior of SDL, and makes the mouse usable when using -display gtk -vga qxl https://bugzilla.redhat.com/show_bug.cgi?id=1051724 Signed-off-by: Cole Robinson <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
2bda66028b4962c36d4eabe2995edab12df93691
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2bda66028b4962c36d4eabe2995edab12df93691
2014-03-17 14:34:28+01:00
qdev: Fix bus dependency of DeviceState::hotpluggable getter Commit 1a37eca107cece3ed454bae29eef0bd1fac4a244 (qdev: add "hotpluggable" property to Device) added a property "hotpluggable" to each device, with its getter accessing parent_bus->allow_hotplug. Add a NULL check. Cc: Igor Mammedov <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
2b81b35f8f18d6874d1a0605ac5e40028966051b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2b81b35f8f18d6874d1a0605ac5e40028966051b
2014-03-12 20:13:02+01:00
mirror: fix throttling delay calculation The throttling delay calculation was using an inaccurate sector count to calculate the time to sleep. This broke rate-limiting for the block mirror job. Move the delay calculation into mirror_iteration() where we know how many sectors were transferred. This lets us calculate an accurate delay time. Reported-by: Joaquim Barrera <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
cc8c9d6c6f28e4e376a6561a2a31524fd069bc2d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cc8c9d6c6f28e4e376a6561a2a31524fd069bc2d
2014-03-25 14:09:50+01:00
signal: added a wrapper for sigprocmask function Create a wrapper for signal mask changes initiated by the guest; (this includes syscalls and also the sigreturns from signal.c) this will give us a place to put code which prevents the guest from changing the handling of signals used by QEMU itself internally. The wrapper is called from all the guest-initiated sigprocmask, but is not called from internal qemu sigprocmask calls. Signed-off-by: Alex Barcelo <[email protected]> [PMM: Added calls to wrapper for sigprocmask uses in signal.c when setting the signal mask on entry and exit from signal handlers, since these also are guest-provided signal masks.] Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
1c275925bfbbc2de84a8f0e09d1dd70bbefb6da3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1c275925bfbbc2de84a8f0e09d1dd70bbefb6da3
2014-03-17 11:44:32+02:00
s390-ccw.img: Fix sporadic reboot hangs: Initialize next_idx The current code does not initialize next_idx in the virtio ring. As the ccw bios will always use guest memory at a fixed location, this queue might != 0 after a reboot. Lets make the initialization explicit. Signed-off-by: Christian Borntraeger <[email protected]> Reviewed-by: Cornelia Huck <[email protected]>
d1028f1b5b4cf83e8af5f48996cf392fb12d391a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d1028f1b5b4cf83e8af5f48996cf392fb12d391a
2014-02-27 09:51:25+01:00
target-arm: Define names for SCTLR bits The SCTLR is full of bits for enabling or disabling various things, and so there are many places in the code which check if certain bits are set. Define some named constants for the SCTLR bits so these checks are easier to read. Signed-off-by: Peter Maydell <[email protected]>
76e3e1bcaefe0da394f328854cb72f9449f23732
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/76e3e1bcaefe0da394f328854cb72f9449f23732
2014-02-20 10:35:51+00:00
check-qdict: Adjust test for qdict_array_split() Test the new functionality of qdict_array_split(), that is, splitting off single objects. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
7841c768846dcfa5a162ff46a8e98429aa0d2238
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7841c768846dcfa5a162ff46a8e98429aa0d2238
2014-02-21 22:11:26+01:00
qemu-config: Sections must consist of keys In config_parse_qdict_section(), the QList returned by qdict_array_split() is assumed to only contain QDicts. Currently, this is true but it may (and will) change in the future. Therefore, check whether the assumption actually holds. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
ae39c4b2015dd5ee35021d0f4212bb1304106524
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ae39c4b2015dd5ee35021d0f4212bb1304106524
2014-02-21 22:11:17+01:00
qjson.h: Remove spurious GCC_FMT_ATTR markup from qobject_from_json() declaration The function qobject_from_json() doesn't actually allow its argument to be a format string -- it passes a NULL va_list* to qobject_from_jsonv(), and the parser code will then never actually interpret %-escape sequences (it tests whether the va_list pointer is NULL and will stop with a parse error). The spurious attribute markup causes clang warnings in some of the test cases where we programmatically construct JSON to feed to qobject_from_json(): tests/test-qmp-input-visitor.c:76:35: warning: format string is not a string literal (potentially insecure) [-Wformat-security] data->obj = qobject_from_json(json_string); ^~~~~~~~~~~ Remove the incorrect attribute. Signed-off-by: Peter Maydell <[email protected]> Suggested-by: Paolo Bonzini <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Andreas Färber <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
aa830cdc28edb69c1fe81c8fd9471ab288ad0926
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/aa830cdc28edb69c1fe81c8fd9471ab288ad0926
2014-03-03 09:45:46+04:00
target-mips: add user-mode FR switch support for MIPS32r5 Description of UFR feature: Required in MIPS32r5 if floating point is implemented and user-mode FR switching is supported. The UFR register allows user-mode to clear StatusFR by executing a CTC1 to UFR with GPR[0] as input, and read StatusFR by executing a CFC1 to UFR. helper_ctc1 has been extended with an additional parameter rt to check requirements for UFR feature. Definition of mips32r5-generic has been modified to include support for UFR. Signed-off-by: Petar Jovanovic <[email protected]> Reviewed-by: Eric Johnson <[email protected]>
736d120af4bf5f3e13b2f90c464b3a24847f78f0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/736d120af4bf5f3e13b2f90c464b3a24847f78f0
2014-02-10 16:46:38+01:00
target-i386: Move KVM default-vendor hack to instance_init As we will not have a cpu_x86_find_by_name() function anymore, move the KVM default-vendor hack to instance_init. Unfortunately we can't move that code to class_init because it depends on KVM being initialized. Signed-off-by: Eduardo Habkost <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
7c08db30e6a43f7083a881eb07bfbc878e001e08
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7c08db30e6a43f7083a881eb07bfbc878e001e08
2014-02-03 17:33:55+01:00
pcihp: make pci_read() mmio calback compatible with legacy ACPI hotplug due to recent change introduced by: "pcihp: reduce number of device check events" 'up' field is cleared right after it's read. This is incompatible with legacy BIOS ACPI code where PCNF ACPI method reads this field 32 times. To make pci_read mmio callback compatible with legacy 'up' behavior, pcihp code will need to know in which mode it runs add 'legacy_piix' field to AcpiPciHpState structure and alter register behavior accordingly. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
99d09dd32820f5702031e3c08c81f8c209dc2220
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/99d09dd32820f5702031e3c08c81f8c209dc2220
2014-02-05 16:55:49+02:00
block: Allow waiting for overlapping requests between begin/end Previously, it was not possible to use wait_for_overlapping_requests() between tracked_request_begin()/end() because it would wait for itself. Ignore the current request in the overlap check and run more of the bdrv_co_do_preadv/pwritev code with a BdrvTrackedRequest present. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Benoit Canet <[email protected]>
65afd211c71fc91750d8a18f9604c1e57a5202fb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/65afd211c71fc91750d8a18f9604c1e57a5202fb
2014-01-24 17:40:02+01:00
target-arm: A64: add support for ld/st pair This patch support the basic load and store pair instructions and includes the generic helper functions: * do_gpr_st() * do_fp_st() * do_gpr_ld() * do_fp_ld() * read_cpu_reg_sp() * gen_check_sp_alignment() The last function gen_check_sp_alignment() is a NULL op currently but put in place to make it easy to add SP alignment checking later. Signed-off-by: Alex Bennée <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
4a08d4758faf4d6497a5f6fa6be6f048a5359420
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4a08d4758faf4d6497a5f6fa6be6f048a5359420
2013-12-23 23:27:28+00:00
target-arm: Split A64 from A32/T32 gen_intermediate_code_internal() The A32/T32 gen_intermediate_code_internal() is complicated because it has to deal with: * conditionally executed instructions * Thumb IT blocks * kernel helper page * M profile exception-exit special casing None of these apply to A64, so putting the "this is A64 so call the A64 decoder" check in the middle of the A32/T32 loop is confusing and means the A64 decoder's handling of things like conditional jump and singlestepping has to take account of the conditional-execution jumps the main loop might emit. Refactor the code to give A64 its own gen_intermediate_code_internal function instead. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
40f860cd6c1aa0d3399e3f8158f20bdc5b2bfbfe
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/40f860cd6c1aa0d3399e3f8158f20bdc5b2bfbfe
2013-12-17 19:42:31+00:00
block drivers: expose requirement for write same alignment from formats This will let misaligned but large requests use zero clusters. This is important because the cluster size is not guest visible. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Peter Lieven <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
cffb1ec600de83f693a23578fc2f344c1af9b96f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cffb1ec600de83f693a23578fc2f344c1af9b96f
2013-12-03 15:26:49+01:00
virtio-rng: add check of period If period is assigned to 0, limit timer will expire immediately. It causes a qemu warning: "main-loop: WARNING: I/O thread spun for 1000 iterations" This limit is meaningless. This patch forbids to assign 0 to period. Reviewed-by: Amit Shah <[email protected]> Signed-off-by: Amos Kong <[email protected]> Message-id: [email protected] Signed-off-by: Anthony Liguori <[email protected]>
d44bb8604e87ecd3823f12f0c92d5e56d613de0d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d44bb8604e87ecd3823f12f0c92d5e56d613de0d
2013-11-21 07:55:26-08:00
uas: Fix / cleanup usb_uas_task error handling -The correct error if we cannot find the dev is INCORRECT_LUN rather then INVALID_INFO_UNIT -Move the device not found check to the top so we only need to do it once -Remove the dev->lun != lun checks, dev is returned by scsi_device_find which searches by lun, so this will never trigger Signed-off-by: Hans de Goede <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
5eb6d9e3ef1fac096ab5b3f5c14e1f4079dd7367
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5eb6d9e3ef1fac096ab5b3f5c14e1f4079dd7367
2013-11-26 09:21:17+01:00
qemu-img: add support for skipping zeroes in input during convert we currently do not check if a sector is allocated during convert. This means if a sector is unallocated that we allocate a bounce buffer of zeroes, find out its zero later and do not write it in the best case. In the worst case this can lead to reading blocks from a raw device (like iSCSI) altough we could easily know via get_block_status that they are zero and simply skip them. This patch also fixes the progress output not being at 100% after a successful conversion. Signed-off-by: Peter Lieven <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
13c28af87a5541a9b09a59502b876a1725fb502d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/13c28af87a5541a9b09a59502b876a1725fb502d
2013-12-05 11:45:24+01:00
pc: disable pci-info The BIOS that we ship in 1.7 does not use pci info from host and so far isn't going to use it. Taking in account problems it caused see 9604f70fdf and to avoid future incompatibility issues, it's safest to disable that interface by default for all machine types including 1.7 as it was never exposed/used by guest. And properly remove/cleanup it during 1.8 development cycle. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Gerd Hoffmann <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
7f1bb742be39184b469d53c0901240b12bb85589
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7f1bb742be39184b469d53c0901240b12bb85589
2013-11-14 09:12:13+02:00
qemu-char: add support for U-prefixed symbols This patch adds support for Unicode symbols in keymap files. This feature was already used in some keyboard layouts in QEMU generated from XKB (e.g. Arabic) but it wasn't implemented in QEMU source code. There is no need for check of validity of the hex string after U character because strtol returns 0 in case the conversion was unsuccessful. Signed-off-by: Jan Krupa <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
828071592470d0703a283433ea195295dab0ad7d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/828071592470d0703a283433ea195295dab0ad7d
2013-11-13 15:48:38+04:00
qcow2: Add overlap-check options Add runtime options to tune the overlap checks to be performed before write accesses. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
05de7e86cab3ed3830de38b38b39bbc711bc1158
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/05de7e86cab3ed3830de38b38b39bbc711bc1158
2013-10-11 16:50:00+02:00
qcow2: Correct endianness in overlap check If an inactive L1 table is loaded from disk, its entries are in big endian and have to be converted to host byte order before using them. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
1e242b5544a48bc43eca9c637dc91ec06bcf3a31
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1e242b5544a48bc43eca9c637dc91ec06bcf3a31
2013-10-02 11:06:35+02:00
timer: make qemu_clock_enable sync between disable and timer's cb After disabling the QemuClock, we should make sure that no QemuTimers are still in flight. To implement that with light overhead, we resort to QemuEvent. The caller of disabling will wait on QemuEvent of each timerlist. Note, qemu_clock_enable(foo,false) can _not_ be called from timer's cb. Also, the callers of qemu_clock_enable() should be protected by the BQL. Signed-off-by: Liu Ping Fan <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
3c05341157f4d08dc3cc8ffa675a0aaa4818d028
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3c05341157f4d08dc3cc8ffa675a0aaa4818d028
2013-10-17 17:30:56+02:00
x86: fix migration from pre-version 12 On KVM, the KVM_SET_XSAVE would be executed with a 0 xstate_bv, and not restore anything. Since FP and SSE data are always valid, set them in xstate_bv at reset time. In fact, that value is the same that KVM_GET_XSAVE returns on pre-XSAVE hosts. Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Gleb Natapov <[email protected]>
c74f41bbcc83d12787ac42f2c74fc2be54e9f222
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c74f41bbcc83d12787ac42f2c74fc2be54e9f222
2013-10-02 18:58:23+03:00
Fix VNC SASL authentication when using a QXL device ui/vnc.c:vnc_display_open() and spice-server/server/reds.c:do_spice_init() are both calling sasl_server_init(). If spice_server_set_sasl_appname() hasn't been called, spice-server will call it with "spice" as an appname, causing cyrus-sasl to try to use a /etc/sasl2/spice.conf config file rather than the /etc/sasl2/qemu.conf file that QEMU uses. When using -spice sasl on the command line, QEMU properly calls spice_server_set_sasl_appname() to set the SASL appname as "qemu", but when using a QXL device without using SPICE, spice_server_init() is called from qemu_spice_add_interface() without setting the appname to "qemu", which then causes the VNC code to try to use spice.conf instead of qemu.conf. Signed-off-by: Christophe Fergeau <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
764eb39d1b6f614e9734ea3ed1b7dcf6c3aaa260
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/764eb39d1b6f614e9734ea3ed1b7dcf6c3aaa260
2013-10-17 12:25:25+02:00
s390/kvm: Add check for priviledged SCLP handler The SCLP instruction is priviledged, so we should make sure that we generate an exception when it is called from the problem state. Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
3ac85fb66626ea91641f5fb9ad9069aab94754f5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3ac85fb66626ea91641f5fb9ad9069aab94754f5
2013-09-20 12:46:52+02:00
smbios: Make multiple -smbios type= accumulate sanely Currently, -smbios type=T,NAME=VAL,... adds one field (T,NAME) with value VAL to fw_cfg for each unique NAME. If NAME occurs multiple times, the last one's VAL is used (before the QemuOpts conversion, the first one was used). Multiple -smbios can add multiple fields with the same (T, NAME). SeaBIOS reads all of them from fw_cfg, but uses only the first field (T, NAME). The others are ignored. "First one wins, subsequent ones get ignored silently" isn't nice. We commonly let the last option win. Useful, because it lets you -readconfig first, then selectively override with command line options. Clean up -smbios to work the common way. Accumulate the settings, with later ones overwriting earlier ones. Put the result into fw_cfg (no more useless duplicates). Bonus cleanup: qemu_uuid_parse() no longer sets SMBIOS system uuid by side effect. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
fc3b32958a80bca13309e2695de07b43dd788421
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fc3b32958a80bca13309e2695de07b43dd788421
2013-09-28 23:49:39+03:00
qemu-img: always probe the input image for allocated sectors qemu-img convert can assume "that sectors which are unallocated in the input image are present in both the output's and input's base images". However it is only doing this if the output image returns true for bdrv_has_zero_init(). Testing bdrv_has_zero_init() does not make much sense if the output image is copy-on-write, because a copy-on-write image is never initialized to zero (it is initialized to the content of the backing file). There is nothing here that makes has_zero_init images special. The input and output must be equal for the operation to make sense, and that's it. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
e4a86f88cc6b214c37b4abe9160e41f0338ce4cd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e4a86f88cc6b214c37b4abe9160e41f0338ce4cd
2013-09-06 15:25:09+02:00
qcow2-refcount: Snapshot update for zero clusters Account for all cluster types in qcow2_update_snapshot_refcounts; this prevents this function from updating the refcount of unallocated zero clusters which effectively led to wrong adjustments of the refcount of cluster 0 (the main qcow2 header). This in turn resulted in images with (unallocated) zero clusters having a cluster 0 refcount greater than one after creating a snapshot. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
8b81a7b6ba8686f35f9cb0acdd54004d63206f03
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8b81a7b6ba8686f35f9cb0acdd54004d63206f03
2013-08-30 15:28:52+02:00
block/curl: drop curl_aio_flush() .io_flush() is no longer called so drop curl_aio_flush(). The acb[] array that the function checks is still used in other parts of block/curl.c. Therefore we cannot remove acb[], it is needed. Signed-off-by: Stefan Hajnoczi <[email protected]>
0d1460226fb05c92fa3ad869ca39090ff13cf6bc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0d1460226fb05c92fa3ad869ca39090ff13cf6bc
2013-08-19 15:45:35+02:00
char/serial: cosmetic fixes. Some cosmetic fixes to char/serial fixing some checkpatch errors. Cc: [email protected] Signed-off-by: Peter Crosthwaite <[email protected]> Reviewed-by: Andreas Färber <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
7f4f0a227fe0b24c35d0898f9ae7d5909fb51137
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7f4f0a227fe0b24c35d0898f9ae7d5909fb51137
2013-06-11 23:45:44+04:00
ide-test: Add FLUSH CACHE test case This checks in particular that BSY is set while the flush request is in flight. Signed-off-by: Kevin Wolf <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bd07684aacfb61668ae2c25b7dd00b64f3d7c7f3
2013-06-06 11:27:29+02:00
make user networking hostfwd work with restrict=y This patch allows the hostfwd option to override the restrict=y setting in the user network stack, as explicitly stated in the documentation on the restrict option: restrict=on|off If this option is enabled, the guest will be isolated, i.e. it will not be able to contact the host and no guest IP packets will be routed over the host to the outside. This option does not affect any explicitly set forwarding rules. Qemu bug tracker: https://bugs.launchpad.net/qemu/+bug/829455 Signed-off-by: Gertjan Halkes <[email protected]> Signed-off-by: Jan Kiszka <[email protected]>
b5a87d26e848945eb891f4d7e4a7f2be514e08d5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b5a87d26e848945eb891f4d7e4a7f2be514e08d5
2013-06-19 12:44:38+02:00
hmp: Make "info block" output more readable HMP is meant for humans and you should notice it. This changes the output format to use a bit more space to display the information more readable and leaves out irrelevant information (e.g. mention only that an image is encrypted, but not when it's not; display I/O limits only if throttling is in effect; ...) Before: (qemu) info block ide0-hd0: removable=0 io-status=ok file=/tmp/overlay.qcow2 backing_file=/tmp/backing.img backing_file_depth=1 ro=0 drv=qcow2 encrypted=1 bps=0 bps_rd=0 bps_wr=0 iops=1024 iops_rd=0 iops_wr=0 ide1-cd0: removable=1 locked=0 tray-open=0 io-status=ok file=/home/kwolf/images/iso/Fedora-18-x86_64-Live-Desktop.iso ro=1 drv=raw encrypted=0 bps=0 bps_rd=0 bps_wr=0 iops=0 iops_rd=0 iops_wr=0 floppy0: removable=1 locked=0 tray-open=0 [not inserted] sd0: removable=1 locked=0 tray-open=0 [not inserted] After: (qemu) info block ide0-hd0: /tmp/overlay.qcow2 (qcow2, encrypted) Backing file: /tmp/backing.img (chain depth: 1) I/O limits: bps=0 bps_rd=0 bps_wr=0 iops=1024 iops_rd=0 iops_wr=0 ide1-cd0: /home/kwolf/images/iso/Fedora-18-x86_64-Live-Desktop.iso (raw, read-only) Removable device: not locked, tray closed floppy0: [not inserted] Removable device: not locked, tray closed sd0: [not inserted] Removable device: not locked, tray closed Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Acked-by: Anthony Liguori <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
fbe2e26c15af35e4d157874dc80f6a19eebaa83b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fbe2e26c15af35e4d157874dc80f6a19eebaa83b
2013-06-28 16:14:39-04:00
i8254: Convert PITCommonState to QOM realizefn Instead of having the parent provide PITCommonClass::init, let the children override DeviceClass::realize themselves. This pushes the responsibility for saving and calling the parent's realizefn to the children. Signed-off-by: Andreas Färber <[email protected]>
a15d09127b104d1c35fc22bdd65263fe62462b30
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a15d09127b104d1c35fc22bdd65263fe62462b30
2013-06-07 14:55:24+02:00