commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
qemu-timer: check active_timers outside lock/event This avoids taking the active_timers_lock or resetting/setting the timers_done_ev if there are no active timers. This removes a small (2-3%) source of overhead for dataplane. The list is then checked again inside the lock, or a NULL pointer could be dereferenced. Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
8caa05d8891d0a09dc4c00908c24c6ddfd872bbe
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8caa05d8891d0a09dc4c00908c24c6ddfd872bbe
2016-12-22 16:00:24+01:00
qdev: hotplug: drop HotplugHandler.post_plug callback as nvdimm acpi is okay to build fit when the nvdimm device has not been 'realized' Suggested-by: Igor Mammedov <[email protected]> Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Igor Mammedov <[email protected]>
c7f8d0f3a52b5ef8fdcd305cce438f67d7e06a9f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c7f8d0f3a52b5ef8fdcd305cce438f67d7e06a9f
2016-11-15 17:20:37+02:00
nbd: Don't inf-loop on early EOF Commit 7d3123e converted a single read_sync() into a while loop that assumed that read_sync() would either make progress or give an error. But when the server hangs up early, the client sees EOF (a read_sync() of 0) and never makes progress, which in turn caused qemu-iotest './check -nbd 83' to go into an infinite loop. Rework the loop to accomodate reads cut short by EOF. Reported-by: Max Reitz <[email protected]> Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
a5068244b4f0c994791303b6186b6f732adab6c2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a5068244b4f0c994791303b6186b6f732adab6c2
2016-11-10 16:01:30+01:00
tests: Avoid qobject_from_jsonf("%"PRId64) The qobject_from_jsonf() function implements a pseudo-printf language for creating a QObject; however, it is hard-coded to only parse a subset of formats understood by -Wformat, and is not a straight synonym to bare printf(). In particular, any use of an int64_t integer works only if the system's definition of PRId64 matches what the parser expects; which works on glibc (%lld or %ld depending on 32- vs. 64-bit) and mingw (%I64d), but not on Mac OS (%qd). Rather than enhance the parser, it is just as easy to force the use of int (where the value is small enough) or long long instead of int64_t, which we know always works. This should cover all remaining testsuite uses of qobject_from_json[fv]() that were trying to rely on PRId64, although my proof for that was done by adding in asserts and checking that 'make check' still passed, where such asserts are inappropriate during hard freeze. A later series in 2.9 may remove all dynamic JSON parsing, but that's a bigger task. Reported by: G 3 <[email protected]> Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> [Rename value64 to value_ll] Signed-off-by: Markus Armbruster <[email protected]>
29a6731afb20707ab0c1f9be997bef74cef34665
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/29a6731afb20707ab0c1f9be997bef74cef34665
2016-12-05 17:09:34+01:00
block: add gluster ifdef guard checks for SEEK_DATA/SEEK_HOLE support Add checks to see if the system compiling QEMU has support for SEEK_HOLE/SEEK_DATA. If the system does not, we will flag that seek data is unsupported in gluster. Note: this is not a check on whether the gluster server itself supports SEEK_DATA (that is already done during runtime), but rather if the compilation environment supports SEEK_DATA. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Jeff Cody <[email protected]> Tested-by: Eric Blake <[email protected]> Message-id: 00370bce5c98140d6c56ad5145635ec6551265cc.1475876377.git.jcody@redhat.com Signed-off-by: Jeff Cody <[email protected]>
d9b789745b88df367674e45c55df29e9c7de8d8a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d9b789745b88df367674e45c55df29e9c7de8d8a
2016-11-01 07:55:57-04:00
COLO: Synchronize PVM's state to SVM periodically Do checkpoint periodically, the default interval is 200ms. Signed-off-by: zhanghailiang <[email protected]> Signed-off-by: Li Zhijian <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Amit Shah <[email protected]> Signed-off-by: Amit Shah <[email protected]>
18cc23d72cabf708d5a7e6b5948ec0420a1a2ebd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/18cc23d72cabf708d5a7e6b5948ec0420a1a2ebd
2016-10-30 15:17:39+05:30
memory: Replace skip_dump flag with "ram_device" Setting skip_dump on a MemoryRegion allows us to modify one specific code path, but the restriction we're trying to address encompasses more than that. If we have a RAM MemoryRegion backed by a physical device, it not only restricts our ability to dump that region, but also affects how we should manipulate it. Here we recognize that MemoryRegions do not change to sometimes allow dumps and other times not, so we replace setting the skip_dump flag with a new initializer so that we know exactly the type of region to which we're applying this behavior. Signed-off-by: Alex Williamson <[email protected]> Acked-by: Paolo Bonzini <[email protected]>
21e00fa55f3fdfcbb20da7c6876c91ef3609b387
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/21e00fa55f3fdfcbb20da7c6876c91ef3609b387
2016-10-31 09:53:03-06:00
COLO: Add a new RunState RUN_STATE_COLO Guest will enter this state when paused to save/restore VM state under COLO checkpoint. Cc: Eric Blake <[email protected]> Cc: Markus Armbruster <[email protected]> Signed-off-by: zhanghailiang <[email protected]> Signed-off-by: Li Zhijian <[email protected]> Signed-off-by: Gonglei <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Amit Shah <[email protected]> Signed-off-by: Amit Shah <[email protected]>
21142ba7ffbf62bd8914af4595184415c50f8f39
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/21142ba7ffbf62bd8914af4595184415c50f8f39
2016-10-30 15:17:39+05:30
nfs: move nfs_set_events out of the while loops nfs_set_events only needs to be called once before entering the while loop; afterwards, nfs_process_read and nfs_process_write take care of it. Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Signed-off-by: Fam Zheng <[email protected]>
aa92d6c4609e174fc6884e4b7b87367fac33cbe9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/aa92d6c4609e174fc6884e4b7b87367fac33cbe9
2016-10-28 21:50:18+08:00
target-lm32: disable asm logging via LOG_DIS() The lm32 target already has a disassembler which logs the assembly instructions with "-d in_asm". Therefore, turn of the LOG_DIS() macro to prevent logging the assembly instructions twice. Also turn the macro in a one which is always compiled to catch any errors while the macro is turned off. Signed-off-by: Michael Walle <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
19f846b19f4bb5ef187da057d40f0507e3842625
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/19f846b19f4bb5ef187da057d40f0507e3842625
2016-10-28 18:17:23+03:00
spapr_nvram: Pre-initialize the NVRAM to support the -prom-env parameter In case we do not load the NVRAM contents from a file and the user specified the "-prom-env" parameter, use the new CHRP NVRAM helper functions to pre-initialize the NVRAM partitions, so that the SLOF firmware now can pick up the environment variables from the -prom-env parameter, too. Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: David Gibson <[email protected]>
61f20b9dc5b78c603354a4ec170079479dcb6657
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/61f20b9dc5b78c603354a4ec170079479dcb6657
2016-10-28 09:38:27+11:00
tests: Restore check-qdict unit test Commit ea3af47 accidentally dropped check-qdict from the list of unit tests. Put it back. Signed-off-by: Markus Armbruster <[email protected]> Message-id: [email protected] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
4429532b48a25740817aa0901a4355a5de991e5b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4429532b48a25740817aa0901a4355a5de991e5b
2016-10-25 11:39:10+01:00
char: start converting mux driver to use CharBackend Start using qemu_chr_fe* CharBackend functions: initialize a CharBackend and use qemu_chr_fe_set_handlers(). Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
ecb672d14f092f481000ac9cd9d7dc0500692eba
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ecb672d14f092f481000ac9cd9d7dc0500692eba
2016-10-24 15:27:20+02:00
COLO: Introduce checkpointing protocol We need communications protocol of user-defined to control the checkpointing process. The new checkpointing request is started by Primary VM, and the interactive process like below: Checkpoint synchronizing points: Primary Secondary initial work 'checkpoint-ready' <-------------------- @ 'checkpoint-request' @ --------------------> Suspend (Only in hybrid mode) 'checkpoint-reply' <-------------------- @ Suspend&Save state 'vmstate-send' @ --------------------> Send state Receive state 'vmstate-received' <-------------------- @ Release packets Load state 'vmstate-load' <-------------------- @ Resume Resume (Only in hybrid mode) Start Comparing (Only in hybrid mode) NOTE: 1) '@' who sends the message 2) Every sync-point is synchronized by two sides with only one handshake(single direction) for low-latency. If more strict synchronization is required, a opposite direction sync-point should be added. 3) Since sync-points are single direction, the remote side may go forward a lot when this side just receives the sync-point. 4) For now, we only support 'periodic' checkpoint, for which the Secondary VM is not running, later we will support 'hybrid' mode. Signed-off-by: zhanghailiang <[email protected]> Signed-off-by: Li Zhijian <[email protected]> Signed-off-by: Gonglei <[email protected]> Cc: Eric Blake <[email protected]> Cc: Markus Armbruster <[email protected]> Cc: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Amit Shah <[email protected]> Signed-off-by: Amit Shah <[email protected]>
4f97558e100f66f953ba7576b0ced146e6846997
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4f97558e100f66f953ba7576b0ced146e6846997
2016-10-30 15:17:39+05:30
qemu-doc: merge qemu-tech and qemu-doc Merge what is left of qemu-tech into the main manual as an appendix. Ultimately we should have a new internals manual built from docs/, and then the "Translator Internals" parts of qemu-tech could move to docs/ as well. The bits on limitation and features of CPU emulation should remain in qemu-doc. Reviewed-by: Emilio G. Cota <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
78e87797ba0b6612fc1c95216a0b81c744fb85b0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/78e87797ba0b6612fc1c95216a0b81c744fb85b0
2016-10-07 10:05:54+02:00
target-i386: Move xsave component mask to features array This will reuse the existing check/enforce logic in x86_cpu_filter_features() to check the xsave component bits against GET_SUPPORTED_CPUID. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
96193c22ab39ea24f81e386ad7883260ff24f5fd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/96193c22ab39ea24f81e386ad7883260ff24f5fd
2016-09-27 17:03:34-03:00
ui: refactor method for setting up VncDisplay auth types There is a lot of repeated code in the auth type setup method, particularly around checking TLS credential types. Refactor it to reduce duplication and instead of having one method do both plain and websockets at once, call it separately for each. Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
eda24e188637e2f86db31c3edb76d457212fdcb1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/eda24e188637e2f86db31c3edb76d457212fdcb1
2016-10-13 09:22:20+02:00
tests: allow to specify list of formats to test for check-block.sh This would make code better and allow to test specific format. Signed-off-by: Denis V. Lunev <[email protected]> CC: Stefan Hajnoczi <[email protected]> CC: Kevin Wolf <[email protected]> CC: Paolo Bonzini <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
c2519009b428fb19a9fdbc707e786b1cebd4994f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c2519009b428fb19a9fdbc707e786b1cebd4994f
2016-09-23 13:36:09+02:00
libqos: define SPAPR libqos functions Define spapr_alloc_init()/spapr_alloc_init_flags()/spapr_alloc_uninit() to allocate and use SPAPR guest memory Define qtest_spapr_vboot()/qtest_spapr_boot()/qtest_spapr_shutdown() to start SPAPR guest with QOSState initialized for it (memory management) Move qtest_irq_intercept_in() from generic part to PC part. Signed-off-by: Laurent Vivier <[email protected]> Reviewed-by: Greg Kurz <[email protected]> Reviewed-by: David Gibson <[email protected]> Signed-off-by: David Gibson <[email protected]>
8d6ef7c9fe880c710dd55cfe7a0f076be475bede
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8d6ef7c9fe880c710dd55cfe7a0f076be475bede
2016-09-23 10:29:40+10:00
commit: Add 'base' to the reopen queue before 'overlay_bs' Now that we're checking for duplicates in the reopen queue, there's no need to force a specific order in which the queue is constructed so we can revert 3db2bd5508c86a1605258bc77c9672d93b5c350e. Since both ways of constructing the queue are now valid, this patch doesn't have any effect on the behavior of QEMU and is not strictly necessary. However it can help us check that the fix for the reopen queue is robust: if it stops working properly at some point, iotest 040 will break. Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
0fe282bb4b29ad51adefc2e500bcecfb3c499e10
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0fe282bb4b29ad51adefc2e500bcecfb3c499e10
2016-09-23 13:36:10+02:00
linux-user: Fix memchr() argument in open_self_cmdline() In open_self_cmdline() we look for a 0 in the buffer we read from /prc/self/cmdline. We were incorrectly passing the length of our buf[] array to memchr() as the length to search, rather than the number of bytes we actually read into it, which could be shorter. This was spotted by Coverity (because it could result in our trying to pass a negative length argument to write()). Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
ba4b3f668abf1fcde204c8f3185ea6edeec6eaa3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ba4b3f668abf1fcde204c8f3185ea6edeec6eaa3
2016-08-04 16:35:30+03:00
x86-iommu: introduce IEC notifiers This patch introduces x86 IOMMU IEC (Interrupt Entry Cache) invalidation notifier list. When vIOMMU receives IEC invalidate request, all the registered units will be notified with specific invalidation requests. Intel IOMMU is the first provider that generates such a event. Signed-off-by: Peter Xu <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
02a2cbc872df99205eeafd399f01c210e0b797c4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/02a2cbc872df99205eeafd399f01c210e0b797c4
2016-07-21 20:43:49+03:00
spapr_pci: Add a 64-bit MMIO window On real hardware, and under pHyp, the PCI host bridges on Power machines typically advertise two outbound MMIO windows from the guest's physical memory space to PCI memory space: - A 32-bit window which maps onto 2GiB..4GiB in the PCI address space - A 64-bit window which maps onto a large region somewhere high in PCI address space (traditionally this used an identity mapping from guest physical address to PCI address, but that's not always the case) The qemu implementation in spapr-pci-host-bridge, however, only supports a single outbound MMIO window, however. At least some Linux versions expect the two windows however, so we arranged this window to map onto the PCI memory space from 2 GiB..~64 GiB, then advertised it as two contiguous windows, the "32-bit" window from 2G..4G and the "64-bit" window from 4G..~64G. This approach means, however, that the 64G window is not naturally aligned. In turn this limits the size of the largest BAR we can map (which does have to be naturally aligned) to roughly half of the total window. With some large nVidia GPGPU cards which have huge memory BARs, this is starting to be a problem. This patch adds true support for separate 32-bit and 64-bit outbound MMIO windows to the spapr-pci-host-bridge implementation, each of which can be independently configured. The 32-bit window always maps to 2G.. in PCI space, but the PCI address of the 64-bit window can be configured (it defaults to the same as the guest physical address). So as not to break possible existing configurations, as long as a 64-bit window is not specified, a large single window can be specified. This will appear the same way to the guest as the old approach, although it's now implemented by two contiguous memory regions rather than a single one. For now, this only adds the possibility of 64-bit windows. The default configuration still uses the legacy mode. Signed-off-by: David Gibson <[email protected]> Reviewed-by: Laurent Vivier <[email protected]>
daa23699031693b434ec263b212f77ba505e353e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/daa23699031693b434ec263b212f77ba505e353e
2016-10-16 12:03:09+11:00
target-i386: Add x86_cpu_unrealizefn() First remove VCPU from exec loop and only then remove lapic. Signed-off-by: Chen Fan <[email protected]> Signed-off-by: Gu Zheng <[email protected]> Signed-off-by: Zhu Guihua <[email protected]> Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
c884776e9dc947105827bd6c22192863f97267d2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c884776e9dc947105827bd6c22192863f97267d2
2016-07-20 12:02:20-03:00
vl: exit if a bad property value is passed to -global When passing '-global driver=host-powerpc64-cpu,property=compat,value=foo' on the command line, without this patch, we get the following warning per device (which means many lines if the guests has many cpus): qemu-system-ppc64: Warning: can't apply global host-powerpc64-cpu.compat=foo: Invalid compatibility mode "foo" ... and QEMU continues execution, ignoring the property. With this patch, we get a single line: qemu-system-ppc64: can't apply global host-powerpc64-cpu.compat=foo: Invalid compatibility mode "foo" ... and QEMU exits. The previous behavior is kept for hotplugged devices since we don't want QEMU to exit when doing device_add. Reviewed-by: David Gibson <[email protected]> Signed-off-by: Greg Kurz <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
03f28efbbb0ee521611e0eb28b45096b3598fb34
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/03f28efbbb0ee521611e0eb28b45096b3598fb34
2016-07-27 11:25:06-03:00
target-i386: Set physical address bits based on host Add the host-phys-bits boolean property, if true, take phys-bits from the hosts physical bits value, overriding either the default or the user specified value. We can also use the value we read from the host to check the users explicitly set value and warn them if it doesn't match. Note: a) We only read the hosts value in KVM mode (because on non-x86 we get an abort if we try) b) We don't warn about trying to use host-phys-bits in TCG mode, we just fall back to the TCG default. This allows the machine type to set the host-phys-bits flag if it wants and then to work in both TCG and KVM. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
11f6fee576680a2d482123535da920f8ceb33eb5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/11f6fee576680a2d482123535da920f8ceb33eb5
2016-07-20 11:58:44-03:00
block: Convert bdrv_co_discard() to byte-based Another step towards byte-based interfaces everywhere. Replace the sector-based bdrv_co_discard() with a new byte-based bdrv_co_pdiscard(), which silently ignores any unaligned head or tail. Driver callbacks will be converted in followup patches. By calculating the alignment outside of the loop, and clamping the max discard to an aligned value, we can simplify the actions done within the loop. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
9f1963b3f72521f75a549f8afd61b19e7da63c6f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9f1963b3f72521f75a549f8afd61b19e7da63c6f
2016-07-20 14:11:54+01:00
cris: Fix broken header guard in hw/cris/boot.h Found with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
82751a32be872e71c22167234ac88ba52bf96a37
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/82751a32be872e71c22167234ac88ba52bf96a37
2016-07-12 16:20:46+02:00
Clean up ill-advised or unusual header guards Cleaned up with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
2a6a4076e117113ebec97b1821071afccfdfbc96
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2a6a4076e117113ebec97b1821071afccfdfbc96
2016-07-12 16:20:46+02:00
ast2400: replace aspeed_smc_is_implemented() aspeed_smc_is_implemented() filters invalid registers in a peculiar way. Let's remove it and open code the if conditions. It serves the same purpose, the aesthetic is better, and new registers can easily be added. Signed-off-by: Cédric Le Goater <[email protected]> Message-id: [email protected] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
97c2ed5dbdda978e29618f356f11caa99a7df601
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/97c2ed5dbdda978e29618f356f11caa99a7df601
2016-07-14 16:51:38+01:00
qapi-event: Simplify visit of non-implicit data Commit 7ce106a9 documented why we don't generated a visit_type_FOO() for implicit types; and therefore events with an anonymous type for 'data' have to open-code a visit. Note that the open-coded visit in qapi-event.c is slightly different from what is done in qapi-visit.c for normal types, in part because we don't have to check for *obj being NULL or free things on error. But where the type is not implicit, it is nicer to reuse the normal visit instead of open-coding a duplicate. At the moment, the only event with a non-implicit 'data' is in the testsuite, where test-qapi-event.c changes as follows: |@@ -155,6 +155,7 @@ void qapi_event_send___org_qemu_x_event( | __org_qemu_x_Struct param = { | __org_qemu_x_member1, (char *)__org_qemu_x_member2, has_q_wchar_t, q_wchar_t | }; |+ __org_qemu_x_Struct *arg = &param; | | emit = qmp_event_get_func_emit(); | if (!emit) { |@@ -164,16 +165,7 @@ void qapi_event_send___org_qemu_x_event( | qmp = qmp_event_build_dict("__ORG.QEMU_X-EVENT"); | | v = qmp_output_visitor_new(&obj); |- |- visit_start_struct(v, "__ORG.QEMU_X-EVENT", NULL, 0, &err); |- if (err) { |- goto out; |- } |- visit_type___org_qemu_x_Struct_members(v, &param, &err); |- if (!err) { |- if (!err) { |- visit_check_struct(v, &err); |- } |- visit_end_struct(v, NULL); |+ visit_type___org_qemu_x_Struct(v, "__ORG.QEMU_X-EVENT", &arg, &err); | if (err) { | goto out; | } Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
4d0b268fdb17a1fed10fe980e77fd388e5427bfd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4d0b268fdb17a1fed10fe980e77fd388e5427bfd
2016-07-19 13:21:08+02:00
tests: Use "command -v" instead of which(1) in shell scripts When which(1) is not installed, we would complain "perl not found" because it's the first set_prog_path check. The error message is wrong. Fix it by using "command -v", a native way to query the existence of a command. Suggested-by: Eric Blake <[email protected]> Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
e465ce7d09939d631f1861e0bd8873417c1c0d65
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e465ce7d09939d631f1861e0bd8873417c1c0d65
2014-12-10 10:31:12+01:00
qapi: Change Netdev into a flat union This is a mostly-mechanical conversion that creates a new flat union 'Netdev' QAPI type that covers all the branches of the former 'NetClientOptions' simple union, where the branches are now listed in a new 'NetClientDriver' enum rather than generated from the simple union. The existence of a flat union has no change to the command line syntax accepted for new code, and will make it possible for a future patch to switch the QMP command to parse a boxed union for no change to valid QMP; but it does have some ripple effect on the C code when dealing with the new types. While making the conversion, note that the 'NetLegacy' type remains unchanged: it applies only to legacy command line options, and will not be ported to QMP, so it should remain a wrapper around a simple union; to avoid confusion, the type named 'NetClientOptions' is now gone, and we introduce 'NetLegacyOptions' in its place. Then, in the C code, we convert from NetLegacy to Netdev as soon as possible, so that the bulk of the net stack only has to deal with one QAPI type, not two. Note that since the old legacy code always rejected 'hubport', we can just omit that branch from the new 'NetLegacyOptions' simple union. Based on an idea originally by Zoltán Kővágó <[email protected]>: Message-Id: <01a527fbf1a5de880091f98cf011616a78adeeee.1441627176.git.DirtY.iCE.hu@gmail.com> although the sed script in that patch no longer applies due to other changes in the tree since then, and I also did some manual cleanups (such as fixing whitespace to keep checkpatch happy). Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> [Fixup from Eric squashed in] Signed-off-by: Markus Armbruster <[email protected]>
f394b2e20d9a666fb194fb692179a0eeaca5daea
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f394b2e20d9a666fb194fb692179a0eeaca5daea
2016-07-19 20:18:02+02:00
pc-bios/s390-ccw: Pass selected SCSI device to IPL There is ,bootindex=%d argument to specify the lookup order of boot devices. If a bootindex assigned to the device, then IPL Parameter Info Block is created for that device when it is IPLed from. If it is a mere SCSI device (not FCP), then IPIB is created with a special SCSI type and its fields are used to store SCSI address of the device. This new ipl block is private to qemu for now. If the device to IPL from is specified this way, then SCSI bus lookup is bypassed and prescribed devices uses the address specified. Signed-off-by: Eugene (jno) Dvurechenski <[email protected]> Signed-off-by: Alexander Yarygin <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
b39b7718dc23e9890ea7e770f543e6f2d17cb31b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b39b7718dc23e9890ea7e770f543e6f2d17cb31b
2016-07-11 09:48:05+02:00
scsi: Advertise limits by blocksize, not 512 s->blocksize may be larger than 512, in which case our tweaks to max_xfer_len and opt_xfer_len must be scaled appropriately. CC: [email protected] Reported-by: Fam Zheng <[email protected]> Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
efaf4781a995aacd22b1dd521b14e4644bafae14
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/efaf4781a995aacd22b1dd521b14e4644bafae14
2016-07-05 16:46:25+02:00
docs: add NVDIMM ACPI documentation It describes the basic concepts of NVDIMM ACPI and the interfaces between QEMU and the ACPI BIOS Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
15b82b1dc59040245f16a24c16825efe8c389050
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/15b82b1dc59040245f16a24c16825efe8c389050
2016-06-24 05:13:57+03:00
MC146818 RTC: add GPIO access to output IRQ The MC146818 RTC device has output IRQ line. Currently the corresponding field is only accessible through direct access. Such access violates Qemu model. The patch makes the field accessible through GPIO. It also updates the setting of the IRQ during initialization. Signed-off-by: Efimov Vasily <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
3638439d541835f20fb76346f14549800046af76
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3638439d541835f20fb76346f14549800046af76
2016-06-29 14:03:46+02:00
checkpatch: There is no qemu_strtod() Maybe there should be; but until there is, we should not flag strtod() calls as something to replaced with qemu_strtod(). We also lack qemu_strtof() and qemu_strtold(), but as no one has been using strtof() or strtold(), it's not worth complicating the regex for them. (Ironically, I had to use 'git commit -n' since checkpatch uses TAB indents, in violation of its own recommendations.) Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
01fb8e192d2cb139622df22983360836e39a64ff
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/01fb8e192d2cb139622df22983360836e39a64ff
2016-06-30 15:24:36+02:00
target-i386: Move xcc->kvm_required check to realize time It will allow to drop custom cpu_x86_init() and use cpu_generic_init() instead, reducing cpu_x86_create() to a simple 3-liner. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
104494ea25ef6286d79e2f17d609f7ef4cd2dcce
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/104494ea25ef6286d79e2f17d609f7ef4cd2dcce
2016-06-14 16:17:09-03:00
nvdimm acpi: check revision Currently only revision 1 is supported Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
d15fc53f8d564ba977f64df96b0114b58f36d154
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d15fc53f8d564ba977f64df96b0114b58f36d154
2016-06-24 05:13:57+03:00
exec: [tcg] Track which vCPU is performing translation and execution Information is tracked inside the TCGContext structure, and later used by tracing events with the 'tcg' and 'vcpu' properties. The 'cpu' field is used to check tracing of translation-time events ("*_trans"). The 'tcg_env' field is used to pass it to execution-time events ("*_exec"). Signed-off-by: Lluís Vilanova <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
7c2550432abe62f53e6df878ceba6ceaf71f0e7e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7c2550432abe62f53e6df878ceba6ceaf71f0e7e
2016-06-20 15:30:01+01:00
pc-dimm: get memory region from ->get_memory_region() Curretly, the memory region of backed memory is all directly mapped to guest's address space, however, it will be not true for nvdimm device if we introduce nvdimm label which only can be indirectly accessed by ACPI DSM method Also it improves the comments a bit to reflect this fact Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]>
3c3e88a814ef4eb8b2f8bf81863baec24838d998
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3c3e88a814ef4eb8b2f8bf81863baec24838d998
2016-06-07 15:39:28+03:00
hw/ptimer: Introduce ptimer_get_limit Currently ptimer users are used to store copy of the limit value, because ptimer doesn't provide facility to retrieve the limit. Let's provide it. Signed-off-by: Dmitry Osipenko <[email protected]> Reviewed-by: Peter Crosthwaite <[email protected]> Message-id: 8f1fa9f90d8dbf8086fb02f3b4835eaeb4089cf6.1464367869.git.digetx@gmail.com Signed-off-by: Peter Maydell <[email protected]>
578c4b2f23debf68a0e081279f91be0e96525824
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/578c4b2f23debf68a0e081279f91be0e96525824
2016-06-06 16:59:31+01:00
i2c: add aspeed i2c controller The Aspeed AST2400 integrates a set of 14 I2C/SMBus bus controllers directly connected to the APB bus. They can be programmed as master or slave but the propopsed model only supports the master mode. On the TODO list, we also have : - improve and harden the state machine. - bus recovery support (used by the Linux driver). - transfer mode state machine bits. this is not strictly necessary as it is mostly used for debug. The bus busy bit is deducted from the I2C core engine of qemu. - support of the pool buffer: 2048 bytes of internal SRAM (not used by the Linux driver). Signed-off-by: Cédric Le Goater <[email protected]> Reviewed-by: Andrew Jeffery <[email protected]> Message-id: [email protected] [PMM: removed unused functions aspeed_i2c_bus_get_state() and aspeed_i2c_bus_set_state()] Signed-off-by: Peter Maydell <[email protected]>
1602001195dca96aaea8b16f740ac860238555a5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1602001195dca96aaea8b16f740ac860238555a5
2016-06-06 16:59:29+01:00
migration: ensure qemu_fflush() always writes full data amount The QEMUFile writev_buffer / put_buffer functions are expected to write out the full set of requested data, blocking until complete. The qemu_fflush() caller does not expect to deal with partial writes. Clarify the function comments and add a sanity check to the code to catch mistaken implementations. Reviewed-by: Dr. David Alan Gilbert <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Message-Id: <[email protected]> Signed-off-by: Amit Shah <[email protected]>
baf51e7739a4d176284d2e38e1755afeafcd2ee0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/baf51e7739a4d176284d2e38e1755afeafcd2ee0
2016-05-26 11:31:14+05:30
cpu: Reclaim vCPU objects In order to deal well with the kvm vcpus (which can not be removed without any protection), we do not close KVM vcpu fd, just record and mark it as stopped into a list, so that we can reuse it for the appending cpu hot-add request if possible. It is also the approach that kvm guys suggested: https://www.mail-archive.com/[email protected]/msg102839.html Signed-off-by: Chen Fan <[email protected]> Signed-off-by: Gu Zheng <[email protected]> Signed-off-by: Zhu Guihua <[email protected]> Signed-off-by: Bharata B Rao <[email protected]> [- Explicit CPU_REMOVE() from qemu_kvm/tcg_destroy_vcpu() isn't needed as it is done from cpu_exec_exit() - Use iothread mutex instead of global mutex during destroy - Don't cleanup vCPU object from vCPU thread context but leave it to the callers (device_add/device_del)] Reviewed-by: Thomas Huth <[email protected]> Reviewed-by: David Gibson <[email protected]> Signed-off-by: David Gibson <[email protected]>
4c055ab54fae39b6329c57bcb5334d59b920463e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4c055ab54fae39b6329c57bcb5334d59b920463e
2016-05-30 14:03:59+10:00
linux-user: Support for restarting system calls for OpenRISC targets Update the OpenRISC main loop code: * on TARGET_ERESTARTSYS, wind guest PC backwards to repeat syscall insn * handle TARGET_QEMU_ESIGRETURN in the main loop as the indication that the main loop should not touch any guest CPU state (We don't implement sigreturn on this target so there is no code there to update.) Signed-off-by: Timothy Edward Baldwin <[email protected]> Message-id: 1441497448-32489-31-git-send-email-T.E.Baldwin99@members.leeds.ac.uk Reviewed-by: Peter Maydell <[email protected]> [PMM: tweak commit message; drop TARGET_USE_ERESTARTSYS define] Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
7fe7231a4904529404e85517888112c0acc0de4e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7fe7231a4904529404e85517888112c0acc0de4e
2016-05-27 14:49:50+03:00
cpus: call the core nmi injection function We can call the common function here directly since x86 specific actions will be taken care of by the arch specific nmi handler Signed-off-by: Bandan Das <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
1453e6627d19a8d6d54480c6980f5cef5dfc6833
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1453e6627d19a8d6d54480c6980f5cef5dfc6833
2016-05-23 16:53:47+02:00
translate-all: add missing munmap of the code_gen guard page for MIPS Signed-off-by: Emilio G. Cota <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
8bdf4997823126a39bd4c99e4b2283b02cc7865f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8bdf4997823126a39bd4c99e4b2283b02cc7865f
2016-05-12 14:06:41-10:00
qmp-input: Clean up stack handling Management of the top of stack was a bit verbose; creating a temporary variable and adding some comments makes the existing code more legible before the next few patches improve things. No semantic changes other than asserting that we are always visiting a QObject, and not a NULL value. In particular, the check for 'name && qobject_type(qobj) == QTYPE_QDICT)' is a bit overkill (a dict visit should always have a name); a later patch revisits that, while this patch is only changing one layer of indentation due to dropping 'if (qobj)'. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
b471d012e5d7bec1d2272738141e121b5581fcdf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b471d012e5d7bec1d2272738141e121b5581fcdf
2016-05-12 09:47:54+02:00
qemu-img: Fix preallocation with -S 0 for convert When passing -S 0 to qemu-img convert, the target image is supposed to be fully allocated. Right now, this is not the case if the source image contains areas which bdrv_get_block_status() reports as being zero. This patch changes a zeroed area's status from BLK_ZERO to BLK_DATA before invoking convert_write() if -S 0 has been specified. In addition, the check whether convert_read() actually needs to do anything (basically only if the current area is a BLK_DATA area) is pulled out of that function to the caller. If -S 0 has been specified, zeroed areas need to be written as data to the output, thus they then have to be accounted when calculating the progress made. This patch changes the reference output for iotest 122; contrary to what it assumed, -S 0 really should allocate everything in the output, not just areas that are filled with zeros (as opposed to being zeroed). Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
aad15de4275d2fc90acdf6101493dfee4e39b803
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/aad15de4275d2fc90acdf6101493dfee4e39b803
2016-03-30 12:16:03+02:00
hyperv: cpu hotplug fix with HyperV enabled With Hyper-V enabled CPU hotplug stops working. The CPU appears in device manager on Windows but does not appear in peformance monitor and control panel. The root of the problem is the following. Windows checks HV_X64_CPU_DYNAMIC_PARTITIONING_AVAILABLE bit in CPUID. The presence of this bit is enough to cure the situation. The bit should be set when CPU hotplug is allowed for HyperV VM. The check that hot_add_cpu callback is defined is enough from the protocol point of view. Though this callback is defined almost always thus there is no need to export that knowledge in the other way. Signed-off-by: Denis V. Lunev <[email protected]> Reviewed-by: Roman Kagan <[email protected]> CC: Paolo Bonzini <[email protected]> CC: Richard Henderson <[email protected]> CC: Eduardo Habkost <[email protected]> CC: "Andreas Färber" <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
4467c6c118b85133846785f517e5733112e811b4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4467c6c118b85133846785f517e5733112e811b4
2016-03-14 17:26:06-03:00
s390x/cpu: Cleanup init in preparation for hotplug Ensure a valid cpu_model is set upfront by setting the default value directly into the MachineState when none is specified. This is needed to ensure hotplugged CPUs share the same cpu_model. Signed-off-by: Matthew Rosato <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Message-Id: <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
d2eae20790e825656b205dbe347826ff991fb3d8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d2eae20790e825656b205dbe347826ff991fb3d8
2016-03-10 10:37:15+01:00
spapr_pci: kill useless variable in rtas_ibm_change_msi() The num local variable is initialized to zero and has no writer. Signed-off-by: Greg Kurz <[email protected]> Signed-off-by: David Gibson <[email protected]>
d4a63ac8b19eb208465f27fde63f3cff7018fdfd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d4a63ac8b19eb208465f27fde63f3cff7018fdfd
2016-02-28 16:19:02+11:00
qapi: Rename 'fields' to 'members' in generated C code C types and JSON objects don't have fields, but members. We shouldn't gratuitously invent terminology. This patch is a strict renaming of static genarated functions, plus the naming of the dummy filler member for empty structs, before the next patch exposes some of that naming to the rest of the code base. Suggested-by: Markus Armbruster <[email protected]> Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
c81200b01422783cd29796ef4ccc275d05f9ce67
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c81200b01422783cd29796ef4ccc275d05f9ce67
2016-03-05 10:41:09+01:00
target-arm: Add Hyp mode checks to bad_mode_switch() We don't actually support Hyp mode yet, but add the correct checks for it to the bad_mode_switch() function for completeness. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Sergey Fedorov <[email protected]> Message-id: [email protected]
e6c8fc07b4fce0729bb747770756835f4b0ca7f4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e6c8fc07b4fce0729bb747770756835f4b0ca7f4
2016-02-26 15:09:41+00:00
qemu-iotests: Extend iotest 093 to test bursts This patch adds a new test that checks that the burst settings ('iops_max', 'iops_max_length', etc.) of the throttling code work as expected. Signed-off-by: Alberto Garcia <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
a90cade023ab5559f43583958f871d28d9bb7b32
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a90cade023ab5559f43583958f871d28d9bb7b32
2016-02-22 14:08:06+01:00
blockdev: Keep track of monitor-owned BDS As a side effect, we can now make x-blockdev-del's check whether a BDS is actually owned by the monitor explicit. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
9c4218e957331e1ba0ba7565730b0b71c49b8d70
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9c4218e957331e1ba0ba7565730b0b71c49b8d70
2016-02-02 17:50:46+01:00
qmp-shell: fix pretty printing of JSON responses Pretty printing of JSON responses is important to be able to understand large responses from query commands in particular. Unfortunately this was broken during the addition of the verbose flag in commit 1ceca07e48ead0dd2e41576c81d40e6a91cafefd Author: John Snow <[email protected]> Date: Wed Apr 29 15:14:04 2015 -0400 scripts: qmp-shell: Add verbose flag This is because that change turned the python data structure into a formatted JSON string before the pretty print was given it. So we're just pretty printing a string, which is a no-op. The original pretty printer would output python objects. (QEMU) query-chardev { u'return': [ { u'filename': u'vc', u'frontend-open': False, u'label': u'parallel0'}, { u'filename': u'vc', u'frontend-open': True, u'label': u'serial0'}, { u'filename': u'unix:/tmp/qemp,server', u'frontend-open': True, u'label': u'compat_monitor0'}]} This fixes the problem by switching to outputting pretty formatted JSON text instead. This has the added benefit that the pretty printed output is now valid JSON text. Due to the way the verbose flag was handled, the pretty printing now applies to the command sent, as well as its response: (QEMU) query-chardev { "execute": "query-chardev", "arguments": {} } { "return": [ { "frontend-open": false, "label": "parallel0", "filename": "vc" }, { "frontend-open": true, "label": "serial0", "filename": "vc" }, { "frontend-open": true, "label": "compat_monitor0", "filename": "unix:/tmp/qmp,server" } ] } Signed-off-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]> Tested-by: Kashyap Chamarthy <[email protected]> Reviewed-by: John Snow <[email protected]> [Bonus fix: multiple -p now work] Signed-off-by: Markus Armbruster <[email protected]>
e55250c6cb4cf836f9188095a21c85f663aac06b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e55250c6cb4cf836f9188095a21c85f663aac06b
2016-03-04 17:16:32+01:00
pseries: Simplify handling of the hash page table fd When migrating the 'pseries' machine type with KVM, we use a special fd to access the hash page table stored within KVM. Usually, this fd is opened at the beginning of migration, and kept open until the migration is complete. However, if there is a guest reset during the migration, the fd can become stale and we need to re-open it. At the moment we use an 'htab_fd_stale' flag in sPAPRMachineState to signal this, which is checked in the migration iterators. But that's rather ugly. It's simpler to just close and invalidate the fd on reset, and lazily re-open it in migration if necessary. This patch implements that change. This requires a small addition to the machine state's instance_init, so that htab_fd is initialized to -1 (telling the migration code it needs to open it) instead of 0, which could be a valid fd. Signed-off-by: David Gibson <[email protected]> Reviewed-by: Alexey Kardashevskiy <[email protected]>
715c54071a43ab978dc12b9da22a5016203ed284
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/715c54071a43ab978dc12b9da22a5016203ed284
2016-02-17 09:59:30+11:00
fdc: add disk field Currently, 'drive' is used both to represent the current diskette type as well as the current drive type. This patch adds a 'disk' field that is updated explicitly to match the type of the disk. As of this patch, disk and drive are always the same, but forthcoming patches to change the behavior of pick_geometry will invalidate this assumption. disk does not need to be migrated because it is not user-visible state nor is it currently used for any calculations. It is purely informative, and will be rebuilt automatically via fd_revalidate on the new host. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: John Snow <[email protected]> Message-id: [email protected]
16c1e3ece4052ebeb2fdf3b6560cca431d0359b9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/16c1e3ece4052ebeb2fdf3b6560cca431d0359b9
2016-01-25 14:35:23-05:00
iotests: 018: Use TEST_IMG override instead of "mv" Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Max Reitz <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
9b337ae90a395c3f5d79716cd160167734b8a609
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9b337ae90a395c3f5d79716cd160167734b8a609
2016-01-07 21:30:17+01:00
io: use memset instead of { 0 } for initializing array Some versions of GCC on OS-X complain about CMSG_SPACE not being constant size, which prevents use of { 0 } io/channel-socket.c: In function 'qio_channel_socket_writev': io/channel-socket.c:497:18: error: variable-sized object may not be initialized char control[CMSG_SPACE(sizeof(int) * SOCKET_MAX_FDS)] = { 0 }; The compiler is at fault here, but it is nicer to avoid tickling this compiler bug by using memset instead. Reviewed-By: John Arbuckle <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]>
ccf1e2dcd6091eea1fc2341c63201aa1a6094978
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ccf1e2dcd6091eea1fc2341c63201aa1a6094978
2016-01-20 11:31:01+00:00
block: Rename BLOCK_OP_TYPE_MIRROR to BLOCK_OP_TYPE_MIRROR_SOURCE It's necessary to distinguish source and target before we can add blockdev-mirror, because we would want a concrete type of operation to check on target bs before starting. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Max Reitz <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
05e4d14bf308641c0c2888a6700f080fe40a074a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/05e4d14bf308641c0c2888a6700f080fe40a074a
2016-01-07 21:30:17+01:00
eepro100: Prevent two endless loops http://lists.nongnu.org/archive/html/qemu-devel/2015-11/msg04592.html shows an example how an endless loop in function action_command can be achieved. During my code review, I noticed a 2nd case which can result in an endless loop. Reported-by: Qinghao Tang <[email protected]> Signed-off-by: Stefan Weil <[email protected]> Signed-off-by: Jason Wang <[email protected]>
00837731d254908a841d69298a4f9f077babaf24
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/00837731d254908a841d69298a4f9f077babaf24
2015-11-27 10:39:55+08:00
vmw_pvscsi: Introduce 'x-old-pci-configuration' backword compatability property Following the previous patches, which introduced various changes in pvscsi's pci configuration space (device subsystem id and revision, msi offset), this patch introduces a boolean property 'x-old-pci-configuration' to pvscsi. Its default value is false, exposing the above changes in the pci config space. Setting 'x-old-pci-configuration' to 'on' preserves the old behavior, which allows migration to older versions. Signed-off-by: Shmulik Ladkani <[email protected]> Message-Id: <1449994112-7054-4-git-send-email-shmulik.ladkani@ravellosystems.com> Signed-off-by: Paolo Bonzini <[email protected]>
952970ba5651e8f6d1fec7de0366c63a79cadfdb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/952970ba5651e8f6d1fec7de0366c63a79cadfdb
2015-12-17 15:24:34+01:00
ohci: delay first SOF interrupt On overcommitted CPU, kernel can be so slow that an interrupt can be triggered by the device whereas the driver is not ready to receive it. This drives us into an infinite loop. This does not happen on real hardware because real hardware never send interrupt immediately after the controller has been moved to OPERATION state. This patch tries to delay the first SOF interrupt to let driver exits from the critical section (which is not protected against interrupts...) Some details: - ohci_irq(): the OHCI interrupt handler, acknowledges the SOF IRQ only if the state of the driver (rh_state) is OHCI_STATE_RUNNING. So if this interrupt happens and the driver is not in this state, the function is called again and again, moving the system to a CPU starvation. - ohci_rh_resume(): the driver re-enables operation with OHCI_USB_OPER. In QEMU this start the SOF timer and QEMU starts to send IRQs. As the driver is not in OHCI_STATE_RUNNING and not protected against IRQ, the ohci_irq() can be called and the driver never moved to OHCI_STATE_RUNNING. Suggested-by: Gerd Hoffmann <[email protected]> Signed-off-by: Laurent Vivier <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
fd0a10cd20a1c5ae829be32f3364dae88f435c4e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fd0a10cd20a1c5ae829be32f3364dae88f435c4e
2016-01-08 09:29:24+01:00
nvdimm acpi: build ACPI NFIT table NFIT is defined in ACPI 6.0: 5.2.25 NVDIMM Firmware Interface Table (NFIT) Currently, we only support PMEM mode. Each device has 3 structures: - SPA structure, defines the PMEM region info - MEM DEV structure, it has the @handle which is used to associate specified ACPI NVDIMM device we will introduce in later patch. Also we can happily ignored the memory device's interleave, the real nvdimm hardware access is hidden behind host - DCR structure, it defines vendor ID used to associate specified vendor nvdimm driver. Since we only implement PMEM mode this time, Command window and Data window are not needed The NVDIMM functionality is controlled by the parameter, 'nvdimm', which is introduced for the machine, there is a example to enable it: -machine pc,nvdimm -m 8G,maxmem=100G,slots=100 -object \ memory-backend-file,id=mem1,share,mem-path=/tmp/nvdimm1,size=10G -device \ nvdimm,memdev=mem1,id=nv1 It is disabled on default Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
87252e1b61cb6e651da6cd3e9996ade8bd59a388
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/87252e1b61cb6e651da6cd3e9996ade8bd59a388
2015-12-22 18:39:20+02:00
aio: Introduce aio_context_setup This is the place to initialize platform specific bits of AioContext. Signed-off-by: Fam Zheng <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
37fcee5d1154b7a03c13582e128bcc31ad43e954
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/37fcee5d1154b7a03c13582e128bcc31ad43e954
2015-11-09 09:59:32+00:00
target-arm/translate-a64.c: Correct unallocated checks for ldst_excl The checks for the unallocated encodings in the ldst_excl group (exclusives and load-acquire/store-release) were not correct. This error meant that in turn we ended up with code attempting to handle the non-existent case of "non-exclusive load-acquire/store-release pair". Delete that broken and now unreachable code. Reported-by: Laurent Desnogues <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Laurent Desnogues <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]> Reviewed-by: Sergey Fedorov <[email protected]>
e14f0eb12f920fd96b9f79d15cedd437648e8667
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e14f0eb12f920fd96b9f79d15cedd437648e8667
2015-11-24 14:12:15+00:00
replay: replay blockers for devices Some devices are not supported by record/replay subsystem. This patch introduces replay blocker which denies starting record/replay if such devices are included into the configuration. Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]>
0194749ac4131e1bed8e166c5d5cf541678ef204
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0194749ac4131e1bed8e166c5d5cf541678ef204
2015-11-06 10:16:03+01:00
replay: command line options This patch introduces command line options for enabling recording or replaying virtual machine behavior. These options are added to icount command line parameter. They include 'rr' which switches between record and replay and 'rrfile' for specifying the filename for replay log. Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]>
4c27b859722089e0270fd4f41b4b3c63b6647439
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4c27b859722089e0270fd4f41b4b3c63b6647439
2015-11-06 10:16:03+01:00
target-i386: Enable clflushopt/clwb/pcommit instructions These instructions are used by NVDIMM drivers and the specification is located at: https://software.intel.com/sites/default/files/managed/0d/53/319433-022.pdf There instructions are available on Skylake Server. Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
f7fda280948a5e74aeb076ef346b991ecb173c56
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f7fda280948a5e74aeb076ef346b991ecb173c56
2015-11-05 17:35:04-02:00
ivshmem: print error on invalid peer id The server shouldn't send invalid peer id, so print an error if it's the case. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Claudio Fontana <[email protected]>
ffa99afd6e4d354cdfae44cc43a2ca7ef056eb35
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ffa99afd6e4d354cdfae44cc43a2ca7ef056eb35
2015-10-24 18:02:49+02:00
tests: Convert to new qapi union layout We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This leads to spurious collisions if a tag value matches a non-variant member's name. Make the conversion to the new layout for testsuite code. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [Commit message tweaked slightly] Signed-off-by: Markus Armbruster <[email protected]>
c363acef772647f66becdbf46dd54e70e67f3cc9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c363acef772647f66becdbf46dd54e70e67f3cc9
2015-11-02 08:30:27+01:00
block/raw_bsd: Drop raw_is_inserted() With the new automatically-recursive implementation of bdrv_is_inserted() checking by default whether all the children of a BDS are inserted, we can drop raw's own implementation. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
1354c473789a91ba603d40bdf2521e3221c0a69f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1354c473789a91ba603d40bdf2521e3221c0a69f
2015-10-23 18:18:23+02:00
vmsvga: more cursor checks Check the cursor size more carefully. Also switch to unsigned while being at it, so they can't be negative. Signed-off-by: Gerd Hoffmann <[email protected]>
5829b097204189c56dd1fb62c7f827360394bb39
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5829b097204189c56dd1fb62c7f827360394bb39
2015-10-20 09:26:36+02:00
qga: add QGA_CONF environment variable Having a environment variable allows to override default configuration path, useful for testing. Note that this can't easily be an argument, since loading config is done before parsing the arguments. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Michael Roth <[email protected]> Signed-off-by: Michael Roth <[email protected]>
8e34bf364ae518503642d28bdd43661090ae21bd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8e34bf364ae518503642d28bdd43661090ae21bd
2015-10-19 18:28:06-05:00
target-i386: Make check_hw_breakpoints static The function is now only used from within a single file. Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Richard Henderson <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
dd941cdcfec536aad6a310a153778142ed9f3e92
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dd941cdcfec536aad6a310a153778142ed9f3e92
2015-10-02 16:22:01-03:00
utils: rename strtosz to use qemu prefix Not only it makes sense, but it gets rid of checkpatch warning: WARNING: consider using qemu_strtosz in preference to strtosz Also remove get rid of tabs to please checkpatch. Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
4677bb40f809394bef5fa07329dea855c0371697
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4677bb40f809394bef5fa07329dea855c0371697
2015-09-25 12:04:41+02:00
s390x/event-facility: fix receive mask check For selective read event, we need to check if any event is requested that is not active instead of whether none of the requested events is active. Reviewed-by: David Hildenbrand <[email protected]> Reviewed-by: Eric Farman <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
3335ddddf9e5ba7743dc8e3f767f4ef857ccd20c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3335ddddf9e5ba7743dc8e3f767f4ef857ccd20c
2015-09-07 16:10:42+02:00
linux-user: add name_to_handle_at/open_by_handle_at This patch allows to run example given by open_by_handle_at(2): The following shell session demonstrates the use of these two programs: $ echo 'Can you please think about it?' > cecilia.txt $ ./t_name_to_handle_at cecilia.txt > fh $ ./t_open_by_handle_at < fh open_by_handle_at: Operation not permitted $ sudo ./t_open_by_handle_at < fh # Need CAP_SYS_ADMIN Read 31 bytes $ rm cecilia.txt Now we delete and (quickly) re-create the file so that it has the same content and (by chance) the same inode.[...] $ stat --printf="%i\n" cecilia.txt # Display inode number 4072121 $ rm cecilia.txt $ echo 'Can you please think about it?' > cecilia.txt $ stat --printf="%i\n" cecilia.txt # Check inode number 4072121 $ sudo ./t_open_by_handle_at < fh open_by_handle_at: Stale NFS file handle See the man page for source code. Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Laurent Vivier <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
0f0426f343886fb5c9f137c2830f35cc2dae7327
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0f0426f343886fb5c9f137c2830f35cc2dae7327
2015-09-28 16:44:46+03:00
ipxe: don't override GITVERSION We had build problems due to the git version checking in the ipxe build system in the past. Don't remember the details, but the problem seems to be gone now, so lets remove the workaround. Signed-off-by: Gerd Hoffmann <[email protected]> [ most likely ipxe commit 6153c09c41034250408f3596555fcaae715da46c: [build] Set GITVERSION only if there is a git repository ] Reviewed-by: Laszlo Ersek <[email protected]>
f927f16213506a493ac416d9a9fa73c7460a766e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f927f16213506a493ac416d9a9fa73c7460a766e
2015-09-03 14:46:24+02:00
qapi: Document flaws in checking of names We don't actually enforce our "other than downstream extensions [...], all names should begin with a letter" rule. Add a FIXME. We should reject names that differ only in '_' vs. '.' vs. '-', because they're liable to clash in generated C. Add a FIXME. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]>
d90675fa4bc256238b3dd3a7fdd5f9029eca00b8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d90675fa4bc256238b3dd3a7fdd5f9029eca00b8
2015-09-04 15:47:14+02:00
s390/sclp: rework sclp event facility initialization + device realization The current code only works by chance. The event facility is a sysbus device, but specifies in its class structure as parent the DeviceClass (instead of a device class). The init function in return lies therefore at the same position as the init function of SysBusDeviceClass and gets triggered instead - a very bad idea of doing that (e.g. the parameter types don't match). Let's bring the initialization code up to date, initializing the event facility + child events in .instance_init and moving the realization of the child events out of the init call, into the realization step. Device realization is now automatically performed when the event facility itself is realized. That realization implicitly triggers realization of the child bus, which in turn initializes the events. Please note that we have to manually propagate the realization of the bus children, common code still has a TODO set for that task. Reviewed-by: Matthew Rosato <[email protected]> Signed-off-by: David Hildenbrand <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
f6102c329c43d7d5e0bee1fc2fe4043e05f9810c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f6102c329c43d7d5e0bee1fc2fe4043e05f9810c
2015-09-07 16:10:43+02:00
xen: Drop net_rx_ok Let net_rx_packet() (which checks the same conditions) drops the packet if the device is not ready. Drop net_xen_info.can_receive and update the return value for the buffer full case. We rely on the qemu_flush_queued_packets() in net_event() to wake up the peer when the buffer becomes available again. Signed-off-by: Fam Zheng <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
7bba83bf80eae9c9e323319ff40d0ca477b0a77a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7bba83bf80eae9c9e323319ff40d0ca477b0a77a
2015-07-28 11:35:54+01:00
tcg/optimize: allow constant to have copies Now that copies and constants are tracked separately, we can allow constant to have copies, deferring the choice to use a register or a constant to the register allocation pass. This prevent this kind of regular constant reloading: -OUT: [size=338] +OUT: [size=298] mov -0x4(%r14),%ebp test %ebp,%ebp jne 0x7ffbe9cb0ed6 mov $0x40002219f8,%rbp mov %rbp,(%r14) - mov $0x40002219f8,%rbp mov $0x4000221a20,%rbx mov %rbp,(%rbx) mov $0x4000000000,%rbp mov %rbp,(%r14) - mov $0x4000000000,%rbp mov $0x4000221d38,%rbx mov %rbp,(%rbx) mov $0x40002221a8,%rbp mov %rbp,(%r14) - mov $0x40002221a8,%rbp mov $0x4000221d40,%rbx mov %rbp,(%rbx) mov $0x4000019170,%rbp mov %rbp,(%r14) - mov $0x4000019170,%rbp mov $0x4000221d48,%rbx mov %rbp,(%rbx) mov $0x40000049ee,%rbp mov %rbp,0x80(%r14) mov %r14,%rdi callq 0x7ffbe99924d0 mov $0x4000001680,%rbp mov %rbp,0x30(%r14) mov 0x10(%r14),%rbp mov $0x4000001680,%rbp mov %rbp,0x30(%r14) mov 0x10(%r14),%rbp shl $0x20,%rbp mov (%r14),%rbx mov %ebx,%ebx mov %rbx,(%r14) or %rbx,%rbp mov %rbp,0x10(%r14) mov %rbp,0x90(%r14) mov 0x60(%r14),%rbx mov %rbx,0x38(%r14) mov 0x28(%r14),%rbx mov $0x4000220e60,%r12 mov %rbx,(%r12) mov $0x40002219c8,%rbx mov %rbp,(%rbx) mov 0x20(%r14),%rbp sub $0x8,%rbp mov $0x4000004a16,%rbx mov %rbx,0x0(%rbp) mov %rbp,0x20(%r14) mov $0x19,%ebp mov %ebp,0xa8(%r14) mov $0x4000015110,%rbp mov %rbp,0x80(%r14) xor %eax,%eax jmpq 0x7ffbebcae426 lea -0x5f6d72a(%rip),%rax # 0x7ffbe3d437b3 jmpq 0x7ffbebcae426 Signed-off-by: Aurelien Jarno <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
299f80130401153af1a6ddb3cc011781bcd47600
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/299f80130401153af1a6ddb3cc011781bcd47600
2015-08-24 11:10:54-07:00
rbd: make qemu's cache setting override any ceph setting To be safe, when cache=none is used ceph settings should not be able to override it to turn on caching. This was previously possible with rbd_cache=true in the rbd device configuration or a ceph configuration file. Similarly, rbd settings could have turned off caching when qemu requested it, although this would just be a performance problem. Fix this by changing rbd's cache setting to match qemu after all other ceph settings have been applied. Signed-off-by: Josh Durgin <[email protected]> Reviewed-by: Jeff Cody <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
99a3c89d5d538dc6c360e35dffb797cfe06e9cda
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/99a3c89d5d538dc6c360e35dffb797cfe06e9cda
2015-07-14 17:15:23+02:00
libqos/ahci: edit wait to be ncq aware The wait command should check to make sure SACT is clear as well as the Command Issue register. Signed-off-by: John Snow <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected]
4de484698bdda6c5e093dfbe4368cdb364fdf87f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4de484698bdda6c5e093dfbe4368cdb364fdf87f
2015-07-04 02:06:03-04:00
l2tpv3: Drop l2tpv3_can_send This callback is called by main loop before polling s->fd, if it returns false, the fd will not be polled in this iteration. This is redundant with checks inside read callback. After this patch, the data will be copied from s->fd to s->msgvec when it arrives. If the device can't receive, it will be queued to incoming_queue, and when the device status changes, this queue will be flushed. Signed-off-by: Fam Zheng <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
95b1416ae93106923f733941e52dfe55c4318643
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/95b1416ae93106923f733941e52dfe55c4318643
2015-06-12 13:26:21+01:00
virtio-scsi: move qdev properties into virtio-scsi.c As only one place in virtio-scsi.c uses DEFINE_VIRTIO_SCSI_PROPERTIES and DEFINE_VIRTIO_SCSI_FEATURES, there is no need to expose them. Inline them into virtio-scsi.c to avoid wrongly use. Signed-off-by: Shannon Zhao <[email protected]> Signed-off-by: Shannon Zhao <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Acked-by: Cornelia Huck <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
0c63237a90f37fffe8a8016f24f61bb228653e86
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0c63237a90f37fffe8a8016f24f61bb228653e86
2015-06-10 18:15:34+02:00
memory: use mr->ram_addr in "is this RAM?" assertions mr->terminates alone doesn't guarantee that we are looking at a RAM region. mr->ram_addr also has to be checked, in order to distinguish RAM and I/O regions. So, do the following: 1) add a new define RAM_ADDR_INVALID, and test it in the assertions instead of mr->terminates 2) IOMMU regions were not setting mr->ram_addr to a bogus value, initialize it in the instance_init function so that the new assertions would fire for IOMMU regions as well. Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
ec05ec26f940564b1e07bf88857035ec27e21dd8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ec05ec26f940564b1e07bf88857035ec27e21dd8
2015-06-05 17:10:00+02:00
mc146818rtc: Reset the periodic timer on load When loading a VM from a snapshot or migration, clock changes can cause the periodic timer to stall or loop rapidly. qemu-timer has a reset notifier mechanism that is used to avoid timer stalls or loops if the host clock changes while the VM is running when using QEMU_CLOCK_HOST. However, when loading a snapshot or migration, qemu-timer is initialized and fires the reset notifier before mc146818rtc is initialized and has registered its reset handler. In addition, this mechanism isn't used when using QEMU_CLOCK_REALTIME, which might also change when loading a snapshot or migration. To correct that problem, this commit resets the periodic timer after loading from a snapshot or migration if the clock has either jumped backward or has jumped forward by more than the clock jump limit that is used by the reset notifier code in qemu-timer. Signed-off-by: Paul Donohue <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
ae46e23964ad45d5bc72374040e87d8f52ac2178
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ae46e23964ad45d5bc72374040e87d8f52ac2178
2015-06-19 12:27:14+02:00
ui/console: remove dpy_gfx_update_dirty dpy_gfx_update_dirty expects DIRTY_MEMORY_VGA logging to be always on, but that will not be the case soon. Because it computes the memory region on the fly for every update (with memory_region_find), it cannot enable/disable logging by itself. We could always treat updates as invalidations if dirty logging is not enabled, assuming that the board will enable logging on the RAM region that includes the framebuffer. However, the function is unused, so just drop it. Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
42af3e3a02f6d0c38c46465b7f0311eabf532f77
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/42af3e3a02f6d0c38c46465b7f0311eabf532f77
2015-06-05 17:09:59+02:00
target-s390x: use softmmu functions for mvcp/mvcs mvcp and mvcs helper get access to the physical memory by a call to mmu_translate for the virtual to real conversion and then using ldb_phys and stb_phys to physically access the data. In practice this is quite slow because it bypasses the QEMU softmmu TLB and because stb_phys calls try to invalidate the corresponding memory for each access. Instead use cpu_ldb_{primary,secondary} for the loads and cpu_stb_{primary,secondary} for the stores. Ideally this should be further optimized by a call to memcpy, but that already improves the boot time of a guest by a factor 1.8. Signed-off-by: Aurelien Jarno <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
a3084e8055067b3fe8ed653a609021d2ab368564
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a3084e8055067b3fe8ed653a609021d2ab368564
2015-06-05 01:37:59+02:00
virtio-s390: introduce virito s390 queue limit Cc: Alexander Graf <[email protected]> Cc: Richard Henderson <[email protected]> Signed-off-by: Jason Wang <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
74c85296dc880568005b8e7572e08a39d66bcdca
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/74c85296dc880568005b8e7572e08a39d66bcdca
2015-05-31 16:45:38+02:00
hw/acpi: piix4_pm_init(): take fw_cfg object no more This PIIX4 init function has no more reason to receive a pointer to the FwCfg object. Remove the parameter from the prototype, and update callers. As a result, the pc_init1() function no longer needs to save the return value of pc_memory_init() and xen_load_linux(), which makes it more similar to pc_q35_init(). The return type & value of pc_memory_init() and xen_load_linux() are not changed themselves; maybe we'll need their return values sometime later. RHBZ: https://bugzilla.redhat.com/show_bug.cgi?id=1204696 Cc: Amit Shah <[email protected]> Cc: "Michael S. Tsirkin" <[email protected]> Cc: Paolo Bonzini <[email protected]> Cc: Richard Henderson <[email protected]> Cc: Eduardo Habkost <[email protected]> Cc: Aurelien Jarno <[email protected]> Cc: Leon Alrae <[email protected]> Signed-off-by: Laszlo Ersek <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Laszlo Ersek <[email protected]>
6e7d82497dc8da7d420c8fa6632d759e08a18bc3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6e7d82497dc8da7d420c8fa6632d759e08a18bc3
2015-06-04 11:25:42+02:00
util: move read_password method out of qemu-img into osdep/oslib The qemu-img.c file has a read_password() method impl that is used to prompt for passwords on the console, with impls for POSIX and Windows. This will be needed by qemu-io.c too, so move it into the QEMU osdep/oslib files where it can be shared without code duplication Signed-off-by: Daniel P. Berrange <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
d57e4e482e3997b1382625c84149ad0b69155fc0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d57e4e482e3997b1382625c84149ad0b69155fc0
2015-05-22 17:08:01+02:00
virtio-ccw: implement ->device_plugged Let's move operations that are only valid after the backend has been realized to a ->device_plugged callback, just as virtio-pci does. Also reorder setting up the host feature bits to the sequence used by virtio-pci. While we're at it, also add a ->device_unplugged callback to stop ioeventfd, just to be on the safe side. Reviewed-by: Shannon Zhao <[email protected]> Signed-off-by: Cornelia Huck <[email protected]> Message-Id: <[email protected]>
fb846a094fdee7bb6a88b48aeed0d97a8080a20d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fb846a094fdee7bb6a88b48aeed0d97a8080a20d
2015-05-08 10:36:02+02:00
util: socket: Add missing localaddr and localport option for DGRAM socket The 'socket_optslist' structure does not contain the 'localaddr' and 'localport' options that are parsed in case you are creating a 'connect' type UDP character device. I've noticed it happening after commit f43e47dbf6de24db20ec9b588bb6cc762 made qemu abort() after seeing the invalid option. A minimal reproducer for the case is: $ qemu-system-x86_64 -chardev udp,id=charrng0,host=127.0.0.1,port=1234,localaddr=,localport=1234 qemu-system-x86_64: -chardev udp,id=charrng0,host=127.0.0.1,port=1234,localaddr=,localport=1234: Invalid parameter 'localaddr' Aborted (core dumped) Prior to the commit mentioned above the error would be printed but the value for localaddr and localport was simply ignored. I did not go through the code to find out when it was broken. Add the two fields so that the options can again be parsed correctly and qemu doesn't abort(). Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1220252 Signed-off-by: Peter Krempa <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
b8981dc9aae25fa79e5f35609e63f50f078a572d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b8981dc9aae25fa79e5f35609e63f50f078a572d
2015-06-03 14:21:23+03:00