commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
configure: build SDL if only SDL2 available
Right now if SDL2 is installed but not SDL1, default configure will
entirely disable SDL. Check upfront for SDL2 using pkg-config, but
still prefer SDL1 if both versions are installed.
Signed-off-by: Cole Robinson <[email protected]>
Message-id: c9e570b5964d128a3595efe3170129a3da459776.1462557436.git.crobinso@redhat.com
Signed-off-by: Gerd Hoffmann <[email protected]>
|
ee8466d0ea1db1d19e1d56817df0668eeb6924eb
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ee8466d0ea1db1d19e1d56817df0668eeb6924eb
|
2016-05-11 08:02:40+02:00
|
linux-user: arm: Handle (ignore) EXCP_YIELD in ARM cpu_loop()
The new-in-ARMv8 YIELD instruction has been implemented to throw
an EXCP_YIELD back up to the QEMU main loop. In system emulation
we use this to decide to schedule a different guest CPU in SMP
configurations. In usermode emulation there is nothing to do,
so just ignore it and resume the guest.
This prevents an abort with "unhandled CPU exception 0x10004"
if the guest process uses the YIELD instruction.
Reported-by: Hunter Laux <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
Message-id: [email protected]
|
f911e0a323f29ecc780a94380cfbf9f574c19eb7
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/f911e0a323f29ecc780a94380cfbf9f574c19eb7
|
2016-04-04 17:33:51+01:00
|
spice: Disallow use of gl + TCP port
Currently, virgl support has to go through a local unix socket, trying
to connect to a VM using -spice gl through spice://localhost:5900 will
only result in a black screen.
This commit errors out when the user tries to start a VM with both GL
support and a port/tls-port set.
This would fit better in spice-server, but currently QEMU does not call
into spice-server when parsing 'gl' on its command line, so we have to
do this check in QEMU instead.
Signed-off-by: Christophe Fergeau <[email protected]>
Reviewed-by: Marc-André Lureau <[email protected]>
Message-id: [email protected]
[ applied codestyle fix: break long line ]
Signed-off-by: Gerd Hoffmann <[email protected]>
|
569a93cbbe428bb5c583ae4bf31447eb3acc30fe
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/569a93cbbe428bb5c583ae4bf31447eb3acc30fe
|
2016-03-24 08:04:01+01:00
|
exec: fix error handling in file_ram_alloc
One instance of double closing, and invalid close(-1) in some cases
of "goto error".
Reviewed-by: Laszlo Ersek <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
5c3ece79cd0b7b4ed065f4285e7a0262bbfc283b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5c3ece79cd0b7b4ed065f4285e7a0262bbfc283b
|
2016-03-22 22:20:18+01:00
|
contrib/ivshmem-server: Print "not for production" warning
The code is okay for illustrating how things work and for testing, but
its error handling make it unfit for production use. Print a warning
to protect the innocent.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Marc-André Lureau <[email protected]>
Message-Id: <[email protected]>
|
a335c6f204eefba8ff935bcee8f31f51d2174119
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a335c6f204eefba8ff935bcee8f31f51d2174119
|
2016-03-21 21:29:03+01:00
|
target-tricore: Move general CHECK_REG_PAIR of decode_rrr_divide
The add.f and sub.f to be implemented don't use 64 bit registers
and a general usage of CHECK_REG_PAIR would always generate an
exception for them.
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Bastian Koppelmann <[email protected]>
Message-Id: <[email protected]>
|
c433a17141fb2a400ecb656e55d8d21caa2e2390
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c433a17141fb2a400ecb656e55d8d21caa2e2390
|
2016-03-23 09:22:48+01:00
|
vfio: Eliminate vfio_container_ioctl()
vfio_container_ioctl() was a bad interface that bypassed abstraction
boundaries, had semantics that sat uneasily with its name, and was unsafe
in many realistic circumstances. Now that spapr-pci-vfio-host-bridge has
been folded into spapr-pci-host-bridge, there are no more users, so remove
it.
Signed-off-by: David Gibson <[email protected]>
Reviewed-by: Alexey Kardashevskiy <[email protected]>
Acked-by: Alex Williamson <[email protected]>
|
3356128cd13d7ec7689b7cddd3efbfbc5339a262
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3356128cd13d7ec7689b7cddd3efbfbc5339a262
|
2016-03-16 09:55:11+11:00
|
qapi: Simplify semantics of visit_next_list()
The semantics of the list visit are somewhat baroque, with the
following pseudocode when FooList is used:
start()
for (prev = head; cur = next(prev); prev = &cur) {
visit(&cur->value)
}
Note that these semantics (advance before visit) requires that
the first call to next() return the list head, while all other
calls return the next element of the list; that is, every visitor
implementation is required to track extra state to decide whether
to return the input as-is, or to advance. It also requires an
argument of 'GenericList **' to next(), solely because the first
iteration might need to modify the caller's GenericList head, so
that all other calls have to do a layer of dereferencing.
Thankfully, we only have two uses of list visits in the entire
code base: one in spapr_drc (which completely avoids
visit_next_list(), feeding in integers from a different source
than uint8List), and one in qapi-visit.py. That is, all other
list visitors are generated in qapi-visit.c, and share the same
paradigm based on a qapi FooList type, so we can refactor how
lists are laid out with minimal churn among clients.
We can greatly simplify things by hoisting the special case
into the start() routine, and flipping the order in the loop
to visit before advance:
start(head)
for (tail = *head; tail; tail = next(tail)) {
visit(&tail->value)
}
With the simpler semantics, visitors have less state to track,
the argument to next() is reduced to 'GenericList *', and it
also becomes obvious whether an input visitor is allocating a
FooList during visit_start_list() (rather than the old way of
not knowing if an allocation happened until the first
visit_next_list()). As a minor drawback, we now allocate in
two functions instead of one, and have to pass the size to
both functions (unless we were to tweak the input visitors to
cache the size to start_list for reuse during next_list, but
that defeats the goal of less visitor state).
The signature of visit_start_list() is chosen to match
visit_start_struct(), with the new parameters after 'name'.
The spapr_drc case is a virtual visit, done by passing NULL for
list, similarly to how NULL is passed to visit_start_struct()
when a qapi type is not used in those visits. It was easy to
provide these semantics for qmp-output and dealloc visitors,
and a bit harder for qmp-input (several prerequisite patches
refactored things to make this patch straightforward). But it
turned out that the string and opts visitors munge enough other
state during visit_next_list() to make it easier to just
document and require a GenericList visit for now; an assertion
will remind us to adjust things if we need the semantics in the
future.
Several pre-requisite cleanup patches made the reshuffling of
the various visitors easier; particularly the qmp input visitor.
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
d9f62dde1303286b24ac8ce88be27e2b9b9c5f46
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d9f62dde1303286b24ac8ce88be27e2b9b9c5f46
|
2016-05-12 09:47:55+02:00
|
ipmi: remove IPMI_CHECK_RESERVATION() macro
Some IPMI command handlers in the BMC simulator use a macro
IPMI_CHECK_RESERVATION() to check a SDR reservation but the macro
implicitly uses local variables. This patch simply removes it.
Signed-off-by: Cédric Le Goater <[email protected]>
Acked-by: Corey Minyard <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
7f996411ad3c41e064c1f14aaa48afda09242f5e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7f996411ad3c41e064c1f14aaa48afda09242f5e
|
2016-03-11 16:59:13+02:00
|
acpi: add aml_create_field()
It will be used by nvdimm acpi
Signed-off-by: Xiao Guangrong <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
39b6dbd8d7bbaa864ce42dcdcffe79313de9f2d6
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/39b6dbd8d7bbaa864ce42dcdcffe79313de9f2d6
|
2016-03-11 14:54:27+02:00
|
block: Remove dirty bitmaps from bdrv_move_feature_fields()
This patch changes dirty bitmaps from following a BlockBackend in graph
changes to sticking with the node they were created at. For the full
discussion, read the following mailing list thread:
[Qemu-block] block: Dirty bitmaps and COR in bdrv_move_feature_fields()
https://lists.nongnu.org/archive/html/qemu-block/2016-02/msg00745.html
In summary, the justification for this change is:
* When moving the dirty bitmap to the top of the tree was introduced in
bdrv_append() in commit a9fc4408, it didn't actually have any effect
because there could never be a bitmap in use when bdrv_append() was
called (op blockers would prevent this). This is still true today for
all internal uses of dirty bitmaps.
* Support for user-defined dirty bitmaps was introduced in 2.4, but we
discouraged users from using it because we didn't consider it ready
yet.
Moreover, in 2.5, the bdrv_swap() removal introduced a bug that left
dangling pointers if a dirty bitmap was present (the anchors of the
dirty bitmap were swapped, but the back link in the first element
wasn't updated), so it didn't even work correctly.
* block-dirty-bitmap-add takes an arbitrary node name, even if no
BlockBackend is attached. This suggests that it is a node level
operation and not a BlockBackend one. Consequently, there is no reason
for dirty bitmaps to stay with a BlockBackend that was attached to the
node they were created for.
* It was suggested that block-dirty-bitmap-add could track the node if a
node name was specified, and track the BlockBackend if the device name
was specified. This would however be inconsistent with other QMP
commands. Commands that accept both device and node names currently
interpret the device name just as an alias for the current root node
of that BlockBackend.
* Dirty bitmaps have a name that is only unique amongst the bitmaps in a
specific node. Moving bitmaps could lead to name clashes. Automatic
renaming would involve too much magic.
* Persistent bitmaps are stored in a specific node. Moving them around
automatically might be at least surprising, but it would probably also
become a real problem because that would have to happen atomically
without the management tool knowing of the operation.
At the end of the day it seems to be very clear that it was a mistake to
include dirty bitmaps in bdrv_move_feature_fields(). The functionality
of moving bitmaps and/or attaching them to a BlockBackend instead will
probably be needed, but it should be done with a new explicit QMP
command or option.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
|
7a827aaec8c4bb56826f07605b895909b5fa4dde
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7a827aaec8c4bb56826f07605b895909b5fa4dde
|
2016-03-30 11:59:32+02:00
|
ivshmem: Clean up MSI-X conditions
There are three predicates related to MSI-X:
* ivshmem_has_feature(s, IVSHMEM_MSI) is true unless the non-MSI-X
variant of the device is selected with msi=off.
* msix_present() is true when the device has the PCI capability MSI-X.
It's initially false, and becomes true during successful realize of
the MSI-X variant of the device. Thus, it's the same as
ivshmem_has_feature(s, IVSHMEM_MSI) for realized devices.
* msix_enabled() is true when msix_present() is true and guest software
has enabled MSI-X.
Code that differs between the non-MSI-X and the MSI-X variant of the
device needs to be guarded by ivshmem_has_feature(s, IVSHMEM_MSI) or
by msix_present(), except the latter works only for realized devices.
Code that depends on whether MSI-X is in use needs to be guarded with
msix_enabled().
Code review led me to two minor messes:
* ivshmem_vector_notify() calls msix_notify() even when
!msix_enabled(), unlike most other MSI-X-capable devices. As far as
I can tell, msix_notify() does nothing when !msix_enabled(). Add
the guard anyway.
* Most callers of ivshmem_use_msix() guard it with
ivshmem_has_feature(s, IVSHMEM_MSI). Not necessary, because
ivshmem_use_msix() does nothing when !msix_present(). That's
ivshmem's only use of msix_present(), though. Guard it
consistently, and drop the now redundant msix_present() check.
While there, rename ivshmem_use_msix() to ivshmem_msix_vector_use().
Signed-off-by: Markus Armbruster <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Marc-André Lureau <[email protected]>
|
082751e82bed9482fc75863e0b305949bb230c6a
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/082751e82bed9482fc75863e0b305949bb230c6a
|
2016-03-21 21:29:00+01:00
|
s390x/css: Use static initialization for channel_subsys fields
machine_init() will be gone, but we don't need it if we just
initialize the channel_subsys fields statically.
Cc: Cornelia Huck <[email protected]>
Cc: Christian Borntraeger <[email protected]>
Cc: Richard Henderson <[email protected]>
Cc: Alexander Graf <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Cornelia Huck <[email protected]>
[adapted on top of indicator changes]
Signed-off-by: Cornelia Huck <[email protected]>
|
bc994b74ea38579e18f9d9144021c6f8de597a34
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/bc994b74ea38579e18f9d9144021c6f8de597a34
|
2016-03-01 12:15:29+01:00
|
pcie_aer: expose pcie_aer_msg() interface
For vfio device, we need to propagate the aer error to
Guest OS. we use the pcie_aer_msg() to send aer error
to guest.
Signed-off-by: Chen Fan <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Alex Williamson <[email protected]>
|
40f8f0c31b6009e802175463c97f3b9e6f7c5d0f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/40f8f0c31b6009e802175463c97f3b9e6f7c5d0f
|
2016-02-19 09:42:28-07:00
|
balloon: Use only 'pc-dimm' type dimm for ballooning
For now there are only two dimm's: pc-dimm and nvdimm. This patch is
actually needed to disable ballooning on nvdimm. But, to avoid future
bugs, instead of disallowing nvdimm, we allow only pc-dimm. So, if
someone adds new dimm which should be balloon-able, then this ability
should be explicitly specified here.
Why ballooning for nvdimm should be disabled for now:
NVDIMM for now is planned to use as a backing store for DAX filesystem
in the guest and thus this memory is excluded from guest memory
management and LRUs.
In this case libvirt running QEMU along with configured balloon almost
immediately inflates balloon and effectively kill the guest as
qemu counts nvdimm as part of the ram.
Counting dimm devices as part of the ram for ballooning was started from
commit 463756d03:
virtio-balloon: Fix balloon not working correctly when hotplug memory
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Signed-off-by: Denis V. Lunev <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
2b75f848238651ef1bb407f66fa38d68775782bf
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2b75f848238651ef1bb407f66fa38d68775782bf
|
2016-02-25 13:14:18+02:00
|
vhost: simplify vhost_needs_vring_endian()
After the call to virtio_vdev_has_feature(), we only care for legacy
devices, so we don't need the extra check in virtio_is_big_endian().
Also the device_endian field is always set (VIRTIO_DEVICE_ENDIAN_UNKNOWN
may only happen on a virtio_load() path that cannot lead here), so we
don't need the assert() either.
This open codes the device_endian checking in vhost_needs_vring_endian().
It also adds a comment to explain the logic, as recent reviews showed the
cross-endian tweaks aren't that obvious.
Signed-off-by: Greg Kurz <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Laurent Vivier <[email protected]>
Reviewed-by: Cornelia Huck <[email protected]>
|
46f70ff148ae01e2dc96e64c393e295a0092555d
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/46f70ff148ae01e2dc96e64c393e295a0092555d
|
2016-02-16 12:05:18+02:00
|
char: fix handling of QIO_CHANNEL_ERR_BLOCK
If io_channel_send_full gets QIO_CHANNEL_ERR_BLOCK it
and has already sent some of the data, it should return
that amount of data, not EAGAIN, as that would cause
the caller to re-try already sent data.
Unfortunately due to a previous rebase conflict resolution
error, the code for dealing with this was in the wrong
part of the conditional, and so mistakenly ran on other
I/O errors.
This be seen running
qemu-system-x86_64 -monitor stdio
and entering 'info mtree', when running on a slow console
(eg a slow remote ssh session). The monitor would get into
an indefinite loop writing the same data until it managed
to send it all without getting EAGAIN.
Reported-by: Igor Mammedov <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
e046fb449947a48e013bf25d806ecb60e5a88319
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e046fb449947a48e013bf25d806ecb60e5a88319
|
2016-02-16 09:27:59+01:00
|
nbd: always query export list in fixed new style protocol
With the new style protocol, the NBD client will currenetly
send NBD_OPT_EXPORT_NAME as the first (and indeed only)
option it wants. The problem is that the NBD protocol spec
does not allow for returning an error message with the
NBD_OPT_EXPORT_NAME option. So if the server mandates use
of TLS, the client will simply see an immediate connection
close after issuing NBD_OPT_EXPORT_NAME which is not user
friendly.
To improve this situation, if we have the fixed new style
protocol, we can sent NBD_OPT_LIST as the first option
to query the list of server exports. We can check for our
named export in this list and raise an error if it is not
found, instead of going ahead and sending NBD_OPT_EXPORT_NAME
with a name that we know will be rejected.
This improves the error reporting both in the case that the
server required TLS, and in the case that the client requested
export name does not exist on the server.
If the server does not support NBD_OPT_LIST, we just ignore
that and carry on with NBD_OPT_EXPORT_NAME as before.
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
9344e5f554690d5e379b5426daebadef7c87baf5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/9344e5f554690d5e379b5426daebadef7c87baf5
|
2016-02-16 17:16:11+01:00
|
sd: limit 'req.cmd' while using as an array index
While processing standard SD commands, the 'req.cmd' value could
lead to OOB read when used as an index into 'sd_cmd_type' or
'sd_cmd_class' arrays. Limit 'req.cmd' value to avoid such an
access.
Reported-by: Qinghao Tang <[email protected]>
Signed-off-by: Prasad J Pandit <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
97f4ed3b71cca015e82bb601a17cd816b83fff05
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/97f4ed3b71cca015e82bb601a17cd816b83fff05
|
2016-02-11 11:17:32+00:00
|
.travis.yml: run make check for all matrix targets
We only ran make check once before it used to be an unreliable target.
It was only a stop gap measure and we should be able to revert it now.
This also stops us needing a large all-MMU build.
We disable "make check" for a couple of the extra config targets which
are currently broken.
Signed-off-by: Alex Bennée <[email protected]>
Reviewed-by: David Gibson <[email protected]>
Tested-by: David Gibson <[email protected]>
|
01337fbd7f7bd8da33e0a55b1d3586e3f36c70f5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/01337fbd7f7bd8da33e0a55b1d3586e3f36c70f5
|
2016-02-08 18:49:52+00:00
|
target-arm: Rename check_s2_startlevel to check_s2_mmu_setup
Rename check_s2_startlevel to check_s2_mmu_setup in preparation
for additional checks.
Signed-off-by: Edgar E. Iglesias <[email protected]>
Reviewed-by: Alex Bennée <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
a0e966c93a0968d29ef51447d08a6b7be6f4d757
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a0e966c93a0968d29ef51447d08a6b7be6f4d757
|
2016-02-03 13:46:33+00:00
|
get_maintainer.pl: fall back to git if only lists are found
It's not 100% obvious to project newcomers that all patches should be sent
there; checkpatch doesn't say so, and since it mentions other lists to CC,
the wording "the list" from the SubmitAPatch wiki page can be taken
to mean only those lists, not the main list too. We would like therefore
to add a catch-all entry for [email protected].
On its own, this would break fallback to git, because now every file
has a maintainer of sorts. Modify get_maintainer.pl so that mailing
lists (L: lines) no longer prevent the fallback, only humans (M:
entries).
Several pre-existing entries have a list but no human. These now
fall back to git. That's a feature.
Cc: Paolo Bonzini <[email protected]>
Cc: Markus Armbruster <[email protected]>
Cc: John Snow <[email protected]>
Signed-off-by: Stephen Warren <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
4db84796e75680aaae737fae01d9e8fe100ba028
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4db84796e75680aaae737fae01d9e8fe100ba028
|
2016-02-09 17:07:55+01:00
|
intel_iommu: large page support
Current intel_iommu only supports 4K page which may not be sufficient
to cover guest working set. This patch tries to enable 2M and 1G mapping
for intel_iommu. This is also useful for future device IOTLB
implementation to have a better hit rate.
Major work is adding a page mask field on IOTLB entry to make it
support large page. And also use the slpte level as key to do IOTLB
lookup. MAMV was increased to 18 to support direct invalidation for 1G
mapping.
Cc: Michael S. Tsirkin <[email protected]>
Cc: Paolo Bonzini <[email protected]>
Cc: Richard Henderson <[email protected]>
Cc: Eduardo Habkost <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
d66b969b0d9c8eefdcbff4b48535b0fe1501d139
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d66b969b0d9c8eefdcbff4b48535b0fe1501d139
|
2016-02-06 20:44:10+02:00
|
9pfs: rename virtio-9p-coth.{c,h} to coth.{c,h}
Those two files are not virtio specific. Rename them to use generic
names.
Fix includes in various C files. Change define guards and comments in
header files.
Signed-off-by: Wei Liu <[email protected]>
Signed-off-by: Aneesh Kumar K.V <[email protected]>
|
fe52840c8760122257be7b7e4893dd951480a71f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fe52840c8760122257be7b7e4893dd951480a71f
|
2016-01-08 12:04:43+05:30
|
iotests: 034: Use TEST_IMG override instead of "mv"
Signed-off-by: Fam Zheng <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Message-id: [email protected]
Signed-off-by: Max Reitz <[email protected]>
|
5581018400848d7abf09f7cffc1a96e84b3185a1
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5581018400848d7abf09f7cffc1a96e84b3185a1
|
2016-01-07 21:30:17+01:00
|
vmdk: Clean up control flow in vmdk_parse_extents() a bit
Factor out loop stepping to turn a while-loop with goto into a
for-loop with continue.
Cc: Fam Zheng <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Message-Id: <[email protected]>
|
e4937694b66d1468aec3cd95e90888f291c3f599
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e4937694b66d1468aec3cd95e90888f291c3f599
|
2016-01-13 15:16:18+01:00
|
scripts/kvm/kvm_stat: Fixup filtering
When filtering, the group leader event should not be disabled, as all
other events under it will also be disabled. Also we should make sure
that values from disabled fields will not be displayed.
This also filters the fields from the log and batch output for better
readability.
Also the drilldown update now directly checks for the stats' field
filter and (un)sets drilldown accordingly.
Signed-off-by: Janosch Frank <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
126b33e6191cd21ba7e05673eb1428b73bf2d34e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/126b33e6191cd21ba7e05673eb1428b73bf2d34e
|
2016-01-26 15:58:13+01:00
|
io: bind to loopback IP addrs in test suite
The test suite currently binds to 0.0.0.0 or ::, which covers
all interfaces of the machine. It is bad practice for test
suite to open publically accessible ports on a machine, so
switch to use loopback addrs 127.0.0.1 or ::1.
Reported-by: Peter Maydell <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
|
e4d2edc9d0c58de421eb349871e90b67edec0b9c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e4d2edc9d0c58de421eb349871e90b67edec0b9c
|
2015-12-22 18:19:08+00:00
|
main-loop: suppress warnings under qtest
commit 01c22f2cdd4fcf02276ea10f48253850a5fd7259 ("main-loop: Suppress
"I/O thread spun" warnings for qtest") doesn't actually disable the
warning for everyone since some tests don't run under the qtest
accelerator.
Check qtest_driver instead.
Cc: Peter Maydell <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
21a24302e85024dd7b2a151158adbc1f5dc5c4dd
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/21a24302e85024dd7b2a151158adbc1f5dc5c4dd
|
2015-12-02 12:01:43+01:00
|
target-i386/hyperv: Hyper-V SynIC SINT routing and vcpu exit
Hyper-V SynIC(synthetic interrupt controller) helpers for
Hyper-V SynIC irq routing setup, irq injection, irq ack
notifications event/message pages changes tracking for future use.
Signed-off-by: Andrey Smetanin <[email protected]>
Reviewed-by: Roman Kagan <[email protected]>
Signed-off-by: Denis V. Lunev <[email protected]>
CC: Paolo Bonzini <[email protected]>
CC: Richard Henderson <[email protected]>
CC: Eduardo Habkost <[email protected]>
CC: "Andreas Färber" <[email protected]>
CC: Marcelo Tosatti <[email protected]>
CC: Roman Kagan <[email protected]>
CC: Denis V. Lunev <[email protected]>
CC: [email protected]
Signed-off-by: Paolo Bonzini <[email protected]>
|
50efe82c3c27195162dd8df273eadd77d8aecad3
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/50efe82c3c27195162dd8df273eadd77d8aecad3
|
2015-12-17 15:24:34+01:00
|
tests/guest-debug: introduce basic gdbstub tests
The aim of these tests is to combine with an appropriate kernel
image (with symbol-file vmlinux) and check it behaves as it should.
Given a kernel it checks:
- single step
- software breakpoint
- hardware breakpoint
- access, read and write watchpoints
On success it returns 0 to the calling process.
I've not plumbed this into the "make check" logic though as we need a
solution for providing non-host binaries to the tests. However the test
is structured to work with pretty much any Linux kernel image as it
uses the basic kernel_init code which is common across architectures.
Signed-off-by: Alex Bennée <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
261f4d6d3e5445f887e070f047968e756c30cf06
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/261f4d6d3e5445f887e070f047968e756c30cf06
|
2015-12-17 13:37:15+00:00
|
ui/cocoa.m: Prevent activation clicks from going to guest
When QEMU is brought to the foreground, the click event that activates QEMU
should not go to the guest. Accidents happen when they do go to the guest
without giving the user a chance to handle them. In particular, if the
guest input device is not an absolute-position one then the location of
the guest cursor (and thus the click) will likely not be the location of
the host cursor when it is clicked, and could be completely obscured
below another window. Don't send mouse clicks to QEMU unless the
window either has focus or has grabbed mouse events.
Reported-by: John Arbuckle <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: John Arbuckle <[email protected]>
Message-id: [email protected]
|
8d3a5d9b0f76e3f965ce2b845f6e9027fd98fd30
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8d3a5d9b0f76e3f965ce2b845f6e9027fd98fd30
|
2015-12-01 21:22:41+00:00
|
hw/ppc/ppc405_boards: Fix infinite recursion by converting taihu_cpld from old_mmio
The taihu_cpld_writel() function had an obvious typo that meant that
if it was ever called it would go into an infinite recursion. Newer
versions of clang will detect and warn about this:
hw/ppc/ppc405_boards.c:481:1: warning: all paths through this function will call itself [-Winfinite-recursion]
Fix this by converting taihu_cpld from the legacy old_mmio accessors
to new-style ones, with an impl {} declaration to cause the core
memory code to do the splitting of 16 bit and 32 bit accesses into
multiple 8-bit accesses.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Paolo Bonzini <[email protected]>
Signed-off-by: David Gibson <[email protected]>
|
e2a176dfda32f5cf80703c2921a19fe75850c38c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e2a176dfda32f5cf80703c2921a19fe75850c38c
|
2015-11-30 19:39:00+11:00
|
target-i386: kvm: Abort if MCE bank count is not supported by host
Instead of silently changing the number of banks in mcg_cap based
on kvm_get_mce_cap_supported(), abort initialization if the host
doesn't support MCE_BANKS_DEF banks.
Note that MCE_BANKS_DEF was always 10 since it was introduced in
QEMU, and Linux always returned 32 at KVM_CAP_MCE since
KVM_CAP_MCE was introduced, so no behavior is being changed and
the error can't be triggered by any Linux version. The point of
the new check is to ensure we won't silently change the bank
count if we change MCE_BANKS_DEF or make the bank count
configurable in the future.
Signed-off-by: Eduardo Habkost <[email protected]>
[Avoid Yoda condition and \n at end of error_report. - Paolo]
Signed-off-by: Paolo Bonzini <[email protected]>
Message-Id: <[email protected]>
|
49b69cbfcd6e32e2178d6ff7e5d60689c3f79c6e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/49b69cbfcd6e32e2178d6ff7e5d60689c3f79c6e
|
2015-11-26 16:48:07+01:00
|
s390x/pci: fix up IOMMU size
Present code uses @size==UINT64_MAX to initialize IOMMU. It infers that it
can map any 64-bit IOVA whatsoever. But in fact, the largest DMA range for
each PCI Device on s390x is from ZPCI_SDMA_ADDR to ZPCI_EDMA_ADDR. The largest
value is returned from hardware, which is to indicate the largest range
hardware can support. But the real IOMMU size for specific PCI Device is
obtained once qemu intercepts mpcifc instruction that guest is requesting a
DMA range for that PCI Device. Therefore, before intercepting mpcifc instruction,
qemu cannot be aware of the size of IOMMU region that guest will use.
Moreover, iommu replay during device initialization for the whole region in
4k steps takes a very long time.
In conclusion, this patch intializes IOMMU region for each PCI Device when
intercept mpcifc instruction which is to register DMA range for the PCI Device.
And then, destroy IOMMU region when guest wants to deregister IOAT.
Signed-off-by: Yi Min Zhao <[email protected]>
Reviewed-by: Cornelia Huck <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
|
f0a399dbae6a2d0e2e15eb7ce0783286bbd9fe04
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/f0a399dbae6a2d0e2e15eb7ce0783286bbd9fe04
|
2015-12-01 09:57:28+01:00
|
qga: Better mapping of SEEK_* in guest-file-seek
Exposing OS-specific SEEK_ constants in our qapi was a mistake
(if the host has SEEK_CUR as 1, but the guest has it as 2, then
the semantics are unclear what should happen); if we had a time
machine, we would instead expose only a symbolic enum. It's too
late to change the fact that we have an integer in qapi, but we
can at least document what mapping we want to enforce for all
qga clients (and luckily, it happens to be the mapping that both
Linux and Windows use); then fix the code to match that mapping.
It also helps us filter out unsupported SEEK_DATA and SEEK_HOLE.
In the future, we may wish to move our QGA_SEEK_* constants into
qga/qapi-schema.json, along with updating the schema to take an
alternate type (either the integer, or the string value of the
enum name) - but that's too much risk during hard freeze.
Signed-off-by: Eric Blake <[email protected]>
Signed-off-by: Michael Roth <[email protected]>
|
0a982b1bf3953dc8640c4d6e619fb1132ebbebc3
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0a982b1bf3953dc8640c4d6e619fb1132ebbebc3
|
2015-11-25 17:56:45-06:00
|
makefile: fix qemu-ga make install for --disable-tools
ab59e3e introduced a fix for `make install` on w32 that involved
filtering out qemu-ga from $TOOLS install recipe so that we could
append $(EXESUF) to it before attempting to install the binary
via install-prog function.
install-prog takes a list of binaries to install to a particular
directory. If the list is empty it breaks. We guard against this
by ensuring $TOOLS is not empty prior to calling.
However, ab59e3e introduces extra filtering after this check which
can still result on us attempting to call install-prog with an
empty list of binaries. In particular, this occurs if we
build with the --disable-tools configure option, which results
in qemu-ga being the only member of $TOOLS.
Fix this by doing a simple s/qemu-ga/qemu-ga$(EXESUF)/ pass through
$TOOLS instead of filtering out qemu-ga to handle it seperately.
Reported-by: Steve Ellcey <[email protected]>
Cc: Stefan Weil <[email protected]>
Signed-off-by: Michael Roth <[email protected]>
|
68aa262ad09c81b8b1284340cc0d26b65c605df5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/68aa262ad09c81b8b1284340cc0d26b65c605df5
|
2015-11-25 10:21:54-06:00
|
disas/arm: avoid clang shifting negative signed warning
clang 3.7.0 on x86_64 warns about the following:
disas/arm.c:1782:17: warning: shifting a negative signed value is undefined [-Wshift-negative-value]
imm |= (-1 << 7);
~~ ^
Note that this patch preserves the tab indent in this source file
because the surrounding code still uses tabs.
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
02460c3b4287776062715b95c59cd8829015615d
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/02460c3b4287776062715b95c59cd8829015615d
|
2015-11-17 18:35:56+08:00
|
target-mips: Fix exceptions while UX=0
Commit 01f728857941 ("target-mips: Status.UX/SX/KX enable 32-bit address
wrapping") added a new hflag MIPS_HFLAG_AWRAP, which indicates that
64-bit addressing is disallowed in the current mode, so hflag users
don't need to worry about the complexities of working that out, for
example checking both MIPS_HFLAG_KSU and MIPS_HFLAG_UX.
However when exceptions are taken outside of exception level,
mips_cpu_do_interrupt() manipulates the env->hflags directly rather than
using compute_hflags() to update them, and this code wasn't updated
accordingly. As a result, when UX is cleared, MIPS_HFLAG_AWRAP is set,
but it doesn't get cleared on entry back into kernel mode due to an
exception. Kernel mode then cannot access the 64-bit segments resulting
in a nested exception loop. The same applies to errors and debug
exceptions.
Fix by updating mips_cpu_do_interrupt() to clear the MIPS_HFLAG_WRAP
flag when necessary, according to compute_hflags().
Fixes: 01f728857941 ("target-mips: Status.UX/SX/KX enable 32-bit...")
Signed-off-by: James Hogan <[email protected]>
Cc: Leon Alrae <[email protected]>
Cc: Aurelien Jarno <[email protected]>
Reviewed-by: Leon Alrae <[email protected]>
Signed-off-by: Leon Alrae <[email protected]>
|
7871abb94c2f4adc39f2487f6edf5e69ba872a65
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7871abb94c2f4adc39f2487f6edf5e69ba872a65
|
2015-11-24 11:01:03+00:00
|
qom: Replace object property list with GHashTable
ARM GICv3 systems with large number of CPUs create lots of IRQ pins. Since
every pin is represented as a property, number of these properties becomes
very large. Every property add first makes sure there's no duplicates.
Traversing the list becomes very slow, therefore QEMU initialization takes
significant time (several seconds for e. g. 16 CPUs).
This patch replaces list with GHashTable, making lookup very fast. The only
drawback is that object_child_foreach() and object_child_foreach_recursive()
cannot add or remove properties during traversal, since GHashTableIter does
not have modify-safe version. However, the code seems not to modify objects
via these functions.
Signed-off-by: Pavel Fedin <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
Tested-by: Pavel Fedin <[email protected]>
[AF: Fixed object_property_del_{all,child}() issues;
g_hash_table_contains() -> g_hash_table_lookup(), suggested by Daniel]
Reviewed-by: Daniel P. Berrange <[email protected]>
Signed-off-by: Andreas Färber <[email protected]>
|
b604a854e843505007c59d68112c654556102a20
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b604a854e843505007c59d68112c654556102a20
|
2015-11-19 15:00:15+01:00
|
arm: highbank: Implement PSCI and dummy monitor
Firstly, enable monitor mode and PSCI, both of which are features of
this board.
In addition to PSCI, this board also uses SMC for cache maintenance
ops. This means we need a secure monitor to catch these and nop them.
Use the ARM boot board-setup feature to implement this. The SMC trap
implements the needed nop while all other traps will pen the CPU.
As a KVM CPU cannot run in secure mode, do not do the board-setup if
not running TCG. Report a warning explaining the limitation in this
case.
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Crosthwaite <[email protected]>
Message-id: 0fd0d12f0fa666c86616c89447861a70dbe27312.1447007690.git.crosthwaite.peter@gmail.com
Signed-off-by: Peter Maydell <[email protected]>
|
40340e5f221935723bffbca305f3090e8866c818
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/40340e5f221935723bffbca305f3090e8866c818
|
2015-11-10 13:37:33+00:00
|
replay: initialization and deinitialization
This patch introduces the functions for enabling the record/replay and for
freeing the resources when simulator closes.
Reviewed-by: Paolo Bonzini <[email protected]>
Signed-off-by: Pavel Dovgalyuk <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Pavel Dovgalyuk <[email protected]>
|
7615936ebf4e60c4565268a30df2356c841526f8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7615936ebf4e60c4565268a30df2356c841526f8
|
2015-11-06 10:16:03+01:00
|
aio: Introduce aio-epoll.c
To minimize code duplication, epoll is hooked into aio-posix's
aio_poll() instead of rolling its own. This approach also has both
compile-time and run-time switchability.
1) When QEMU starts with a small number of fds in the event loop, ppoll
is used.
2) When QEMU starts with a big number of fds, or when more devices are
hot plugged, epoll kicks in when the number of fds hits the threshold.
3) Some fds may not support epoll, such as tty based stdio. In this
case, it falls back to ppoll.
A rough benchmark with scsi-disk on virtio-scsi dataplane (epoll gets
enabled from 64 onward). Numbers are in MB/s.
===============================================
| master | epoll
| |
scsi disks # | read randrw | read randrw
-------------|----------------|----------------
1 | 86 36 | 92 45
8 | 87 43 | 86 41
64 | 71 32 | 70 38
128 | 48 24 | 58 31
256 | 37 19 | 57 28
===============================================
To comply with aio_{disable,enable}_external, we always use ppoll when
aio_external_disabled() is true.
[Removed #ifdef CONFIG_EPOLL around AioContext epollfd field declaration
since the field is also referenced outside CONFIG_EPOLL code.
--Stefan]
Signed-off-by: Fam Zheng <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
fbe3fc5cb3cd9f9064e98c549684e821c353fe41
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fbe3fc5cb3cd9f9064e98c549684e821c353fe41
|
2015-11-09 09:59:47+00:00
|
backends/hostmem-file: Allow to specify full pathname for backing file
This allows to explicitly specify file name to use with the backend. This
is important when using it together with ivshmem in order to make it backed
by hugetlbfs. By default filename is autogenerated using mkstemp(), and the
file is unlink()ed after creation, effectively making it anonymous. This is
not very useful with ivshmem because it ends up in a memory which cannot be
accessed by something else.
Distinction between directory and file name is done by stat() check. If an
existing directory is given, the code keeps old behavior. Otherwise it
creates or opens a file with the given pathname.
Signed-off-by: Pavel Fedin <[email protected]>
Tested-by: Igor Skalkin <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
8d31d6b65a7448582c7bd320fd1b8cfc6cca2720
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8d31d6b65a7448582c7bd320fd1b8cfc6cca2720
|
2015-11-04 15:56:05+01:00
|
ivshmem: initialize max_peer to -1
There is no peer when device is initialized, do not let doorbell for
inexisting peer 0.
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Claudio Fontana <[email protected]>
|
95e7c8a0f690f9a0c8b70fd1a4de60bd944371b8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/95e7c8a0f690f9a0c8b70fd1a4de60bd944371b8
|
2015-10-24 18:02:48+02:00
|
vhost-user-test: remove useless static check
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Tested-by: Thibaut Collet <[email protected]>
|
82755ff202e96ad9bc74c1268481f96e50907ae1
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/82755ff202e96ad9bc74c1268481f96e50907ae1
|
2015-10-22 14:34:49+03:00
|
pc: memhp: do not emit inserting event for coldplugged DIMMs
currently acpi_memory_plug_cb() sets is_inserting for
cold- and hot-plugged DIMMs as result ASL MHPD.MSCN()
method issues device check even for every coldplugged
DIMM. There isn't much harm in it but if we try to
unplug such DIMM, OSPM will issue device check
intstead of device eject event. So OSPM won't eject
memory module as expected and it will try to eject it
only when another memory device is hot-(un)plugged.
As a fix do not set 'is_inserting' event and do not
issue SCI for cold-plugged DIMMs as they are
enumerated and activated by OSPM during guest's boot.
Signed-off-by: Igor Mammedov <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
4828b10bda6a74a22a7695303e0648157d0e3ea4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4828b10bda6a74a22a7695303e0648157d0e3ea4
|
2015-10-29 11:05:24+02:00
|
configure: probe for memfd
Check if memfd_create() is part of system libc.
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Tested-by: Thibaut Collet <[email protected]>
|
751bcc3981d80594a3943166401af15b76781a5b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/751bcc3981d80594a3943166401af15b76781a5b
|
2015-10-22 14:34:48+03:00
|
hw/arm/virt: don't use a15memmap directly
We should always go through VirtBoardInfo when we need the memmap.
To avoid using a15memmap directly, in this case, we need to defer
the max-cpus check from class init time to instance init time. In
class init we now use MAX_CPUMASK_BITS for max_cpus initialization,
which is the maximum QEMU supports, and also, incidentally, the
maximum KVM/gicv3 currently supports. Also, a nice side-effect of
delaying the max-cpus check is that we now get more appropriate
error messages for gicv2 machines that try to configure more than
123 cpus. Before this patch it would complain that the requested
number of cpus was greater than 123, but for gicv2 configs, it
should complain that the number is greater than 8.
Signed-off-by: Andrew Jones <[email protected]>
Message-id: [email protected]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
4b280b726a329a97db03323d8d03ed554f7872b8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4b280b726a329a97db03323d8d03ed554f7872b8
|
2015-10-27 12:00:50+00:00
|
ui/cocoa.m: eliminate normalWindow warning
Eliminate this warning associated with the setting of the normalWindow's title:
ui/cocoa.m: In function '-[QemuCocoaAppController init]':
ui/cocoa.m:888:9: warning: format not a string literal and no format arguments
[-Wformat-security]
[normalWindow setTitle:[NSString stringWithFormat:@"QEMU"]];
Signed-off-by: John Arbuckle <[email protected]>
Message-id: [email protected]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
a1dbc05a6f73e63ccfdd538c1825d44aa6347d8f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a1dbc05a6f73e63ccfdd538c1825d44aa6347d8f
|
2015-10-13 21:51:18+01:00
|
virtio-ccw: feature bits > 31 handling
We currently switch off the VERSION_1 feature bit if the guest has
not negotiated at least revision 1. As no feature bits beyond 31 are
valid however unless VERSION_1 has been negotiated, make sure that
legacy guests never see a feature bit beyond 31.
Reviewed-by: David Hildenbrand <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
b4f8f9df152fca0e79b7a3ca40a3eea700a40855
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b4f8f9df152fca0e79b7a3ca40a3eea700a40855
|
2015-09-24 13:42:17+03:00
|
target-tilegx: Decode ill pseudo-instructions
Notice raise and bpt, decoding the constants embedded in the
nop addil instruction in the x0 slot.
[rth: Generalize TILEGX_EXCP_OPCODE_ILL to TILEGX_EXCP_SIGNAL.
Drop validation of signal values.]
Signed-off-by: Chen Gang <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
|
dd8070d865ad1b32876931f812a80645f97112ff
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/dd8070d865ad1b32876931f812a80645f97112ff
|
2015-10-07 20:03:15+11:00
|
vfio/pci: Make interrupt bypass runtime configurable
Tracing is more effective when we can completely disable all KVM
bypass paths. Make these runtime rather than build-time configurable.
Signed-off-by: Alex Williamson <[email protected]>
|
46746dbaa8c2c421b9bda78193caad57d7fb1136
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/46746dbaa8c2c421b9bda78193caad57d7fb1136
|
2015-09-23 13:04:44-06:00
|
target-ppc: fix xscmpodp and xscmpudp decoding
The xscmpodp and xscmpudp instructions only have the AX, BX bits in
there encoding, the lowest bit (usually TX) is marked as an invalid
bit. We therefore can't decode them with GEN_XX2FORM, which decodes
the two lowest bit.
Introduce a new form GEN_XX2FORM, which decodes AX and BX and mark
the lowest bit as invalid.
Signed-off-by: Aurelien Jarno <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Tested-by: Richard W.M. Jones <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
|
8f60f8e2e574f341709128ff7637e685fd640254
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8f60f8e2e574f341709128ff7637e685fd640254
|
2015-09-20 22:48:39+02:00
|
vfio/pci: Cleanup ROM blacklist quirk
Create a vendor:device ID helper that we'll also use as we rework the
rest of the quirks. Re-reading the config entries, even if we get
more blacklist entries, is trivial overhead and only incurred during
device setup. There's no need to typedef the blacklist structure,
it's a static private data type used once. The elements get bumped
up to uint32_t to avoid future maintenance issues if PCI_ANY_ID gets
used for a blacklist entry (avoiding an actual hardware match). Our
test loop is also crying out to be simplified as a for loop.
Signed-off-by: Alex Williamson <[email protected]>
|
056dfcb695cde3c62b7dc1d5ed6d2e38b3a73e29
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/056dfcb695cde3c62b7dc1d5ed6d2e38b3a73e29
|
2015-09-23 13:04:45-06:00
|
target-sh4: improve shld instruction
The SH4 shld instruction can shift in both direction, depending on the
sign of the shift. This is currently implemented using branches, which
is not really efficient and prevents the optimizer to do its job. In
practice it is often used with a constant loaded in a register just
before.
Simplify the implementation by computing both the value shifted to the
left and to the right, and then selecting the correct one with a
movcond. As with a negative value the shift amount can go up to 32 which
is undefined, we shift the value in two steps.
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
|
577601616dea10db10a716de1be448f8564076f4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/577601616dea10db10a716de1be448f8564076f4
|
2015-09-13 23:08:51+02:00
|
qapi: Reject -p arguments that break qapi-event.py
qapi-event.py breaks when you ask for a funny prefix like '@'.
Protect it.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
|
1cf47a15f18312436c7fa2d97be5fbe6df0292f5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/1cf47a15f18312436c7fa2d97be5fbe6df0292f5
|
2015-09-04 15:47:13+02:00
|
qapi: Drop one of two "simple union must not have base" checks
The first check ensures the second one can't trigger. Drop the first
one, because the second one is in a more logical place, and emits a
nicer error message.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
|
65fbe125451da9421070ab03944c9600a264eefc
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/65fbe125451da9421070ab03944c9600a264eefc
|
2015-09-04 15:47:16+02:00
|
target-arm/arm-semi.c: Implement A64 specific SyncCacheRange call
The A64 semihosting ABI defines a new call SyncCacheRange
for doing a 'clean D-cache and invalidate I-cache' sequence.
Since QEMU doesn't implement caches, we can implement this as a nop.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Christopher Covington <[email protected]>
Tested-by: Christopher Covington <[email protected]>
Message-id: [email protected]
|
e9ebfbfcf31c11fb3bd2fc436fa17ce45a4e7086
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e9ebfbfcf31c11fb3bd2fc436fa17ce45a4e7086
|
2015-09-07 10:39:28+01:00
|
Makefile.target: include top level build dir in vpath
Using ccache with CCACHE_BASEDIR set to $(SRC_PATH) or a parent will
rewrite all absolute paths to relative paths. This interacts poorly with
QEMU's two-level build directory scheme. For example, lets say
BUILD_DIR=$(SRC_PATH)/build so build/blockdev.d will contain:
blockdev.o: ../blockdev.c ../include/sysemu/block-backend.h \
Now the target build under build/x86_64-softmmu or similar will depend
on ../blockdev.o which in turn will get make to source ../blockdev.d to
check its dependencies. Since make always considers paths relative to
the current working directory rather than the makefile the path appeared
in the relative path to ../blockdev.c is useless.
This change simply adds the top level build directory to vpath so paths
relative to the source directory, top build directory, and target build
directory all work just fine.
Signed-off-by: Michael Marineau <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
12a1ddc160cb6a73e8a6c319f3962a20da2cd22f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/12a1ddc160cb6a73e8a6c319f3962a20da2cd22f
|
2015-09-09 15:34:54+02:00
|
qga: copy argument strings
Following patch will return allocated strings, so we must correctly
initialize alloc & free them. The nice side effect is that we no longer
have to check for "fixed_state_dir" to call ga_install_service() with a
NULL state dir. The default values are set after parsing the command
line options.
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Michael Roth <[email protected]>
Reviewed-by: Denis V. Lunev <[email protected]>
Signed-off-by: Michael Roth <[email protected]>
|
2e38d9903be28493ccd6de4a55e5226e9f07dea9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2e38d9903be28493ccd6de4a55e5226e9f07dea9
|
2015-09-01 11:07:10-05:00
|
pcnet: Drop pcnet_can_receive
pcnet_receive already checks the conditions and drop packets if false.
Due to the new semantics since 6e99c63 ("net/socket: Drop
net_socket_can_send"), having .can_receive returning 0 requires us to
explicitly flush the queued packets when the conditions are becoming
true, but queuing the packets when guest driver is not ready doesn't
make much sense.
Signed-off-by: Fam Zheng <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Jason Wang <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
b0ba0b9b6b402d738f11f27eea6c94d97bf84cbf
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b0ba0b9b6b402d738f11f27eea6c94d97bf84cbf
|
2015-07-27 14:12:18+01:00
|
qemu-char: Fix missed data on unix socket
Commit 812c1057 introduced HUP detection on unix and tcp sockets prior
to a read in tcp_chr_read. This unfortunately broke CloudStack 4.2
which relied on the old behaviour where data on a socket was readable
even if a HUP was present.
A working solution is to properly check the return values from recv,
handling a closed socket once there is no more data to read.
Also enable polling for G_IO_NVAL to ensure the callback is called
for all possible events as these should now be possible to handle
with the improved error detection.
Signed-off-by: Nils Carlson <[email protected]>
Message-Id: <[email protected]>
[Do not handle EINTR; use socket_error(). - Paolo]
Signed-off-by: Paolo Bonzini <[email protected]>
|
4bf1cb03fbc43b0055af60d4ff093d6894aa4338
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4bf1cb03fbc43b0055af60d4ff093d6894aa4338
|
2015-07-23 07:37:38+02:00
|
net: add missing "netmap" to host_net_devices[]
Although hmp-commands.hx lists "netmap" as a valid host_net_add type,
the command rejects it because it's missing from the list.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Message-id: [email protected]
|
027a247bbf703e94258d07e38948946d7b85e91c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/027a247bbf703e94258d07e38948946d7b85e91c
|
2015-06-24 16:29:07+01:00
|
ich9: add TCO interface emulation
This interface provides some registers within a 32-byte range and can be
acessed through PCI-to-LPC bridge interface (PMBASE + 0x60).
It's commonly used as a watchdog timer to detect system lockups through
SMIs that are generated -- if TCO_EN bit is set -- on every timeout. If
NO_REBOOT bit is not set in GCS (General Control and Status register),
the system will be resetted upon second timeout if TCO_RLD register
wasn't previously written to prevent timeout.
This patch adds support to TCO watchdog logic and few other features
like mapping NMIs to SMIs (NMI2SMI_EN bit), system intruder detection,
etc. are not implemented yet.
Signed-off-by: Paulo Alcantara <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
920557971b60e53c2f3f22e5d6c620ab1ed411fd
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/920557971b60e53c2f3f22e5d6c620ab1ed411fd
|
2015-07-07 13:12:22+03:00
|
target-s390x: correctly initialize ext interrupt queue
env->ext_index should be initialized to -1 to mark the external
interrupt queue as emtpy. This should not be done in s390_cpu_initfn
as all the interrupt fields are later reset to 0 by the memset in
s390_cpu_initial_reset or s390_cpu_full_reset. Move the initialization
there.
Signed-off-by: Aurelien Jarno <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
|
7107e5a756317151666d47d1bc1e170293babaff
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7107e5a756317151666d47d1bc1e170293babaff
|
2015-06-17 12:40:50+02:00
|
main-loop: introduce qemu_mutex_iothread_locked
This function will be used to avoid recursive locking of the iothread lock
whenever address_space_rw/ld*/st* are called with the BQL held, which is
almost always the case.
Tracking whether the iothread is owned is very cheap (just use a TLS
variable) but requires some care because now the lock must always be
taken with qemu_mutex_lock_iothread(). Previously this wasn't the case.
Outside TCG mode this is not a problem. In TCG mode, we need to be
careful and avoid the "prod out of compiled code" step if already
in a VCPU thread. This is easily done with a check on current_cpu,
i.e. qemu_in_vcpu_thread().
Hopefully, multithreaded TCG will get rid of the whole logic to kick
VCPUs whenever an I/O event occurs!
Cc: Frederic Konrad <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
afbe70535ff1a8a7a32910cc15ebecc0ba92e7da
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/afbe70535ff1a8a7a32910cc15ebecc0ba92e7da
|
2015-07-01 15:45:50+02:00
|
tcg/optimize: fold temp copies test in tcg_opt_gen_mov
Each call to tcg_opt_gen_mov is preceeded by a test to check if the
source and destination temps are copies. Fold that into the
tcg_opt_gen_mov function.
Cc: Richard Henderson <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
|
5365718a9afeeabde3784d82a542f8ad909b18cf
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5365718a9afeeabde3784d82a542f8ad909b18cf
|
2015-06-09 07:00:56-07:00
|
arm: Add has-mpu property
For processors that support MPUs, add a property to de-feature it. This
is similar to the implementation of the EL3 feature.
The processor definition in init sets ARM_FEATURE_MPU if it can support
an MPU. post_init exposes the property, defaulting to true. If cleared
by the instantiator, ARM_FEATURE_MPU is then removed at realize time.
This is to support R profile processors that may or may-not have an MPU
configured.
Signed-off-by: Peter Crosthwaite <[email protected]>
Message-id: 632918cc48786e868ea18aa6bd12f70597994cad.1434066412.git.peter.crosthwaite@xilinx.com
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
8f325f568fbd0158cd413e7d637573ba90b3eaab
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8f325f568fbd0158cd413e7d637573ba90b3eaab
|
2015-06-15 18:06:10+01:00
|
target-s390x: optimize (negative-) abs computation
Now that movcond exists, it's easy to write (negative-) absolute value
using TCG code instead of an helper.
Signed-off-by: Aurelien Jarno <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
|
d30107814c8d02f1896bd57249aef1b5aaed38c9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d30107814c8d02f1896bd57249aef1b5aaed38c9
|
2015-06-05 01:37:57+02:00
|
exec: only check relevant bitmaps for cleanliness
Most of the time, not all bitmaps have to be marked as dirty;
do not do anything if the interesting ones are already dirty.
Previously, any clean bitmap would have cause all the bitmaps to be
marked dirty.
In fact, unless running TCG most of the time bitmap operations need
not be done at all, because memory_region_is_logging returns zero.
In this case, skip the call to cpu_physical_memory_range_includes_clean
altogether as well.
With this patch, cpu_physical_memory_set_dirty_range is called
unconditionally, so there need not be anymore a separate call to
xen_modified_memory.
Reviewed-by: Fam Zheng <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
e87f7778b64d4a6a78e16c288c7fdc6c15317d5f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e87f7778b64d4a6a78e16c288c7fdc6c15317d5f
|
2015-06-05 17:10:00+02:00
|
virtio-ccw: introduce ccw specific queue limit
Cc: Alexander Graf <[email protected]>
Cc: Cornelia Huck <[email protected]>
Cc: Christian Borntraeger <[email protected]>
Cc: Richard Henderson <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
8dfbaa6ac450c4ec2646b1ca08a4017052a90c1d
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8dfbaa6ac450c4ec2646b1ca08a4017052a90c1d
|
2015-05-31 16:45:38+02:00
|
block/parallels: rename catalog_ names to bat_
BAT means 'block allocation table'. Thus this name is clean and shorter
on writing.
Some obvious formatting fixes in the old code were made to make checkpatch
happy.
Signed-off-by: Denis V. Lunev <[email protected]>
Reviewed-by: Roman Kagan <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Roman Kagan <[email protected]>
Message-id: [email protected]
CC: Kevin Wolf <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
369f7de9d57e4dd2f312255fc12271d5749c0a4e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/369f7de9d57e4dd2f312255fc12271d5749c0a4e
|
2015-05-22 09:37:32+01:00
|
spapr_pci: Make find_phb()/find_dev() public
This makes find_phb()/find_dev() public and changed its names
to spapr_pci_find_phb()/spapr_pci_find_dev() as they are going to
be used from other parts of QEMU such as VFIO DDW (dynamic DMA window)
or VFIO PCI error injection or VFIO EEH handling - in all these
cases there are RTAS calls which are addressed to BUID+config_addr
in IEEE1275 format.
Signed-off-by: Alexey Kardashevskiy <[email protected]>
Reviewed-by: David Gibson <[email protected]>
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
|
46c5874e9cd752ed8ded31af03472edd8fc3efc1
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/46c5874e9cd752ed8ded31af03472edd8fc3efc1
|
2015-06-03 23:56:51+02:00
|
qapi: Check for member name conflicts with a base class
Our type inheritance for both 'struct' and for flat 'union' merges
key/value pairs from the base class with those from the type in
question. Although the C code currently boxes things so that there
is a distinction between which member is referred to, the QMP wire
format does not allow passing a key more than once in a single
object. Besides, if we ever change the generated C code to not be
quite so boxy, we'd want to avoid duplicate member names there,
too.
Fix a testsuite entry added in an earlier patch, as well as adding
a couple more tests to ensure we have appropriate coverage. Ensure
that collisions are detected, regardless of whether there is a
difference in opinion on whether the member name is optional.
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
ff55d72eaf9628e7d58e7b067b361cdbf789c9f4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ff55d72eaf9628e7d58e7b067b361cdbf789c9f4
|
2015-05-05 18:39:02+02:00
|
qapi: Require ASCII in schema
Python 2 and Python 3 have a wild history of whether strings
default to ascii or unicode, where Python 3 requires checking
isinstance(foo, basestr) to cover all strings, but where that
code is not portable to Python 2. It's simpler to just state
that we don't care about Unicode strings, and to just always
use the simpler isinstance(foo, str) everywhere.
I'm no python expert, so I'm basing it on this conversation:
https://lists.gnu.org/archive/html/qemu-devel/2014-09/msg05278.html
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
fe2a9303c9e511462f662a415c2e9d2defe9b7ca
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fe2a9303c9e511462f662a415c2e9d2defe9b7ca
|
2015-05-05 18:39:00+02:00
|
exec: Protect map_client_list with mutex
So that accesses from multiple threads are safe.
Signed-off-by: Fam Zheng <[email protected]>
Message-Id: <[email protected]>
[Remove #if from cpu_exec_init_all. - Paolo]
Signed-off-by: Paolo Bonzini <[email protected]>
|
38e047b50d2bfd1df99fbbca884c9f1db0785ff4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/38e047b50d2bfd1df99fbbca884c9f1db0785ff4
|
2015-04-27 18:24:17+02:00
|
qapi: Segregate anonymous unions into alternates in generator
Special-casing 'discriminator == {}' for handling anonymous unions
is getting awkward; since this particular type is not always a
dictionary on the wire, it is easier to treat it as a completely
different class of type, "alternate", so that if a type is listed
in the union_types array, we know it is not an anonymous union.
This patch just further segregates union handling, to make sure that
anonymous unions are not stored in union_types, and splitting up
check_union() into separate functions. A future patch will change
the qapi grammar, and having the segregation already in place will
make it easier to deal with the distinct meta-type.
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
811d04fd0cff1229480d3f5b2e349f646ab6e3c1
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/811d04fd0cff1229480d3f5b2e349f646ab6e3c1
|
2015-05-05 18:39:00+02:00
|
qapi: Require valid names
Previous commits demonstrated that the generator overlooked various
bad naming situations:
- types, commands, and events need a valid name
- enum members must be valid names, when combined with prefix
- union and alternate branches cannot be marked optional
Valid upstream names match [a-zA-Z][a-zA-Z0-9_-]*; valid downstream
names match __[a-zA-Z][a-zA-Z0-9._-]*. Enumerations match the
weaker [a-zA-Z0-9._-]+ (in part thanks to QKeyCode picking an enum
that starts with a digit, which we can't change now due to
backwards compatibility). Rather than call out three separate
regex, this patch just uses a broader combination that allows both
upstream and downstream names, as well as a small hack that
realizes that any enum name is merely a suffix to an already valid
name prefix (that is, any enum name is valid if prepending _ fits
the normal rules).
We could reject new enumeration names beginning with a digit by
whitelisting existing exceptions. We could also be stricter
about the distinction between upstream names (no leading
underscore, no use of dot) and downstream (mandatory leading
double underscore), but it is probably not worth the bother.
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
c9e0a798691d8c45747b082206e789c8f50523c9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c9e0a798691d8c45747b082206e789c8f50523c9
|
2015-05-05 18:39:01+02:00
|
xen-pt: fix Negative array index read
Coverity spot:
Function xen_pt_bar_offset_to_index() may return a negative
value (-1) which is used as an index to d->io_regions[] down
the line.
Let's pass index directly as an argument to
xen_pt_bar_reg_parse().
Signed-off-by: Gonglei <[email protected]>
Acked-by: Stefano Stabellini <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
d4cd45028898a37afb45fb449954115b4960d4e9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d4cd45028898a37afb45fb449954115b4960d4e9
|
2015-03-10 08:15:33+03:00
|
pc: pcihp: expose MMIO base and len as properties
it will be used later to dynamically reserve MMIO region
instead of manually punching holes in PCI0._CRS
Signed-off-by: Igor Mammedov <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
78c2d8722b9118509e3d4ed8bae67c3e4eaa443e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/78c2d8722b9118509e3d4ed8bae67c3e4eaa443e
|
2015-02-26 13:04:18+01:00
|
target-ppc: force update of msr bits in cpu_post_load
Since env->msr has already been restored by the time cpu_post_load is called,
make sure that ppc_store_msr() is explicitly called with all msr bits except
MSR_TGPR marked as invalid.
This solves the issue where MSR flags aren't set correctly when restoring a VM
snapshot, in particular the internal env->excp_prefix value when MSR_EP has
been altered by a guest.
Signed-off-by: Mark Cave-Ayland <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
|
2360b6e84f78d41fa0f76555a947148b73645259
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2360b6e84f78d41fa0f76555a947148b73645259
|
2015-03-09 15:00:05+01:00
|
target-arm: fix get_phys_addr_v6/SCTLR_AFE access check
Introduce simple_ap_to_rw_prot(), which has the same behavior as
ap_to_rw_prot(), but takes the 2-bit simple AP[2:1] instead of
the 3-bit AP[2:0]. Use this in get_phys_addr_v6 when SCTLR_AFE
is set, as that bit indicates we should be using the simple AP
format.
It's unlikely this path is getting used. I don't see CR_AFE
getting used by Linux, so possibly not. If it had been, then
the check would have been wrong for all but AP[2:1] = 0b11.
Anyway, this should fix it up, in case it ever does get used.
Signed-off-by: Andrew Jones <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
d76951b65dfb1be4e41cfae6abebf8db7a1243a3
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d76951b65dfb1be4e41cfae6abebf8db7a1243a3
|
2015-03-16 12:30:46+00:00
|
virtio: add feature checking helpers
Add a helper function for checking whether a bit is set in the guest
features for a vdev as well as one that works on a feature bit set.
Convert code that open-coded this: It cleans up the code and makes it
easier to extend the guest feature bits.
Signed-off-by: Cornelia Huck <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
ef546f1275f6563e8934dd5e338d29d9f9909ca6
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ef546f1275f6563e8934dd5e338d29d9f9909ca6
|
2015-02-26 13:04:07+01:00
|
acpi-build: fix ACPI RAM management
This fixes multiple issues around ACPI RAM management:
RSDP and linker RAM aren't currently marked dirty
on update, so they won't be migrated correctly.
Let's handle all tables in the same way: set correct size (assert if
too big), update, mark RAM dirty.
This also drops assert checking that table size didn't change: table
size is fundamentally dynamic and depends on hw configuration,
just set the correct size and use that (memory core asserts if size is
too large).
This also means we can drop tracking table size, memory core does this
for us now.
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
42d859001d180ea788aa2d34a7be021ac8c447f2
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/42d859001d180ea788aa2d34a7be021ac8c447f2
|
2015-02-26 12:42:20+01:00
|
virtio: feature bit manipulation helpers
Add virtio_{add,clear}_feature helper functions for manipulating a
feature bits variable. This has some benefits over open coding:
- add check that the bit is in a sane range
- make it obvious at a glance what is going on
- have a central point to change when we want to extend feature bits
Convert existing code manipulating features to use the new helpers.
Signed-off-by: Cornelia Huck <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
0cd09c3a6cc2230ba38c462fc410b4acce59eb6f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0cd09c3a6cc2230ba38c462fc410b4acce59eb6f
|
2015-02-26 13:04:07+01:00
|
vl.c: Remove unnecessary zero-initialization of NUMA globals
There's no need to zero-initialize globals, they are automatically
initialized to zero.
Reviewed-by: Paolo Bonzini <[email protected]>
Acked-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
|
61b388c14c5b042e6a43caaba842e351b2c88edd
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/61b388c14c5b042e6a43caaba842e351b2c88edd
|
2015-02-23 15:39:27-03:00
|
qemu-iotests: add 116 invalid QED input file tests
These tests exercise error code paths in the QED image format. The
tests are very simple, they just prove that the error path exits
cleanly.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Message-id: [email protected]
Reviewed-by: Kevin Wolf <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
319fc53e344d5cead970c74f088ae5c607d426b3
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/319fc53e344d5cead970c74f088ae5c607d426b3
|
2015-02-06 17:24:21+01:00
|
spapr_vio: Pair g_malloc() with g_free(), not free()
Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled
and my "coverity: Model g_free() isn't necessarily free()" model patch
applied.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Gonglei <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
5f1d1fc5928a6f8f63089b3d0768e0dc42c05fbb
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5f1d1fc5928a6f8f63089b3d0768e0dc42c05fbb
|
2015-02-10 09:27:20+03:00
|
apic: do not dereference pointer before it is checked for NULL
Right now you only get to apic_init_reset if you have an APIC
(do_cpu_init is reached only if CPU_INTERRUPT_INIT is set and
that only happens in hw/intc/apic.c). However, this is wrong
because for example a port 92 or keyboard controller reset is
really an INIT, and that can happen also with no APIC. So
keep the check and fix the error that Coverity reported.
Reported-by: Markus Armbruster <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
927411fa42c5fcf16ed0fcc0447d5ee8c83b22ca
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/927411fa42c5fcf16ed0fcc0447d5ee8c83b22ca
|
2015-01-26 12:27:05+01:00
|
s390x/ipl: drop reipl parameters on resets
Whenever a reboot initiated by the guest is done, the reipl parameters should
remain valid. The disk configured by the guest is to be used for
ipl'ing. External reboot/reset request (e.g. via virsh reset guest) should
completely reset the guest to the initial state, and therefore also reset the
reipl parameters, resulting in an ipl behaviour of the initially configured
guest. This could be an external kernel or a disk.
Reviewed-by: Cornelia Huck <[email protected]>
Reviewed-by: David Hildenbrand <[email protected]>
Acked-by: Christian Borntraeger <[email protected]>
Signed-off-by: Jens Freimann <[email protected]>
Signed-off-by: Fan Zhang <[email protected]>
Signed-off-by: Christian Borntraeger <[email protected]>
|
e91e972ccfbaeba1d1416202ad1b667810a33e1f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e91e972ccfbaeba1d1416202ad1b667810a33e1f
|
2015-02-13 16:14:09+01:00
|
iotests: Filter out "I/O thread spun..." warning
Filter out the "main loop: WARNING: I/O thread spun for..." warning from
qemu output (it hardly matters for code specifically testing I/O).
Furthermore, use _filter_qemu in all the custom functions which run
qemu.
Signed-off-by: Max Reitz <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
4dd7b8d30cfa1aebee547958db27efd581a58d9b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4dd7b8d30cfa1aebee547958db27efd581a58d9b
|
2015-01-13 11:47:56+00:00
|
bootdevice: add validate check for qemu_boot_set()
Signed-off-by: Gonglei <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
|
3b08098b409c0fb28f85436ba1adeb1d401ec8f7
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3b08098b409c0fb28f85436ba1adeb1d401ec8f7
|
2014-12-22 14:39:21+08:00
|
exec.c: Drop TARGET_HAS_ICE define and checks
The TARGET_HAS_ICE #define is intended to indicate whether a target-*
guest CPU implementation supports the breakpoint handling. However,
all our guest CPUs have that support (the only two which do not
define TARGET_HAS_ICE are unicore32 and openrisc, and in both those
cases the bp support is present and the lack of the #define is just
a bug). So remove the #define entirely: all new guest CPU support
should include breakpoint handling as part of the basic implementation.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Message-id: [email protected]
|
ec53b45bcd1f74f7a4c31331fa6d50b402cd6d26
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ec53b45bcd1f74f7a4c31331fa6d50b402cd6d26
|
2015-01-20 15:19:32+00:00
|
i386: do not cross the pages boundaries in replay mode
This patch denies crossing the boundary of the pages in the replay mode,
because it can cause an exception. Do it only when boundary is
crossed by the first instruction in the block.
If current instruction already crossed the bound - it's ok,
because an exception hasn't stopped this code.
Signed-off-by: Pavel Dovgalyuk <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
5b9efc39aee90bbd343793e942bf8f582a0c9e4f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5b9efc39aee90bbd343793e942bf8f582a0c9e4f
|
2014-12-15 12:21:02+01:00
|
icount: introduce cpu_get_icount_raw
Separate accessing the instruction counter from the compensation for
speed and halting that are introduced by qemu_icount_bias. This
introduces new infrastructure used by the record/replay patches.
Signed-off-by: Pavel Dovgalyuk <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
2a62914bd8209d97e918f30f0de74bec2bf622c4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2a62914bd8209d97e918f30f0de74bec2bf622c4
|
2014-12-15 12:21:02+01:00
|
valgrind/i386: avoid false positives on KVM_SET_VCPU_EVENTS ioctl
struct kvm_vcpu_events contains reserved fields. Let's use a
designated initializer to avoid false positives in valgrind.
Signed-off-by: Christian Borntraeger <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
076796f8fd27f4d014fe2efb6372f1cdc1df9a41
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/076796f8fd27f4d014fe2efb6372f1cdc1df9a41
|
2014-12-15 12:21:01+01:00
|
valgrind: avoid false positives in KVM_GET_DIRTY_LOG ioctl
struct kvm_dirty_log contains padding fields that trigger false
positives in valgrind. Let's use a designated initializer to avoid
false positives from valgrind/memcheck.
Signed-off-by: Christian Borntraeger <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
d229b985b504261369f2035936cc147c2606fa92
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d229b985b504261369f2035936cc147c2606fa92
|
2014-12-15 12:21:01+01:00
|
target-arm: make IFAR/DFAR banked
When EL3 is running in AArch32 (or ARMv7 with Security Extensions)
IFAR and DFAR have a secure and a non-secure instance.
Signed-off-by: Fabian Aggeler <[email protected]>
Signed-off-by: Greg Bellows <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
b848ce2b9cbd38da3f2530fd93dba76dba0621c0
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b848ce2b9cbd38da3f2530fd93dba76dba0621c0
|
2014-12-11 12:07:51+00:00
|
target-arm: respect SCR.FW, SCR.AW and SCTLR.NMFI
Add checks of SCR AW/FW bits when performing writes of CPSR. These SCR bits
are used to control whether the CPSR masking bits can be adjusted from
non-secure state.
Signed-off-by: Fabian Aggeler <[email protected]>
Signed-off-by: Greg Bellows <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
6e8801f9dea9e10449f4fd7d85dbe8cab708a686
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/6e8801f9dea9e10449f4fd7d85dbe8cab708a686
|
2014-12-11 12:07:50+00:00
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.