commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
exec: use qemu_ram_ptr_length to access guest ram When accessing guest's ram block during DMA operation, use 'qemu_ram_ptr_length' to get ram block pointer. It ensures that DMA operation of given length is possible; And avoids any OOB memory access situations. Reported-by: Alex <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
04bf2526ce87f21b32c9acba1c5518708c243ad0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/04bf2526ce87f21b32c9acba1c5518708c243ad0
2017-07-14 11:04:34+02:00
s390x/kvm: Rework cmma management Let's keep track of cmma enablement and move the mem_path check into the actual enablement. This now also warns users that do not use cpu-models about disabled cmma when using huge pages. Signed-off-by: Janosch Frank <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
03f47ee49e1478b5ffffb3a9b6203c672903196c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/03f47ee49e1478b5ffffb3a9b6203c672903196c
2017-07-14 09:11:12+02:00
pci: Add comment for pci_add_capability2() Comments for pci_add_capability2() to explain the return value. This may help to make a correct return value check for its callers. Cc: [email protected] Cc: [email protected] Cc: [email protected] Signed-off-by: Mao Zhongyi <[email protected]> Reviewed-by: Marcel Apfelbaum <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
eacbc63211c18ad56eb5a3835683663462b131b2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/eacbc63211c18ad56eb5a3835683663462b131b2
2017-07-03 22:29:48+03:00
block: Don't try to set *errp directly Assigning directly to *errp is not valid, as errp may be NULL, &error_fatal, or &error_abort. Use error_propagate() instead. With this, there's no need to check if errp is NULL anymore, as error_propagate() and error_prepend() are able to handle that. Cc: Kevin Wolf <[email protected]> Cc: Max Reitz <[email protected]> Cc: [email protected] Signed-off-by: Eduardo Habkost <[email protected]> Message-Id: <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
57ef3f1278585fbac5f6102362d3c5e066976fdc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/57ef3f1278585fbac5f6102362d3c5e066976fdc
2017-07-13 13:45:53+02:00
char: chardevice hotswap This patch adds a possibility to change a char device without a frontend removal. Ideally, it would have to happen transparently to a frontend, i.e. frontend would continue its regular operation. However, backends are not stateless and are set up by the frontends via qemu_chr_fe_<> functions, and it's not (generally) possible to replay that setup entirely in a backend code, as different chardevs respond to the setup calls differently, so do frontends work differently basing on those setup responses. Moreover, some frontend can generally get and save the backend pointer (qemu_chr_fe_get_driver()), and it will become invalid after backend change. So, a frontend which would like to support chardev hotswap has to register a "backend change" handler, and redo its backend setup there. Signed-off-by: Anton Nefedov <[email protected]> Reviewed-by: Vladimir Sementsov-Ogievskiy <[email protected]> Message-Id: <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
7bb86085e61befc95551055e26645cb23c3f0b86
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7bb86085e61befc95551055e26645cb23c3f0b86
2017-07-14 11:04:33+02:00
spapr: Clean up DRC set_isolation_state() path There are substantial differences in the various paths through set_isolation_state(), both for setting to ISOLATED versus UNISOLATED state and for logical versus physical DRCs. So, split the set_isolation_state() method into isolate() and unisolate() methods, and give it different implementations for the two DRC types. Factor some minimal common checks, including for valid indicator values (which we weren't previously checking) into rtas_set_isolation_state(). Signed-off-by: David Gibson <[email protected]> Reviewed-by: Greg Kurz <[email protected]> Reviewed-by: Michael Roth <[email protected]>
0dfabd39d523fc3f6f0f8c441f41c013cc429b52
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0dfabd39d523fc3f6f0f8c441f41c013cc429b52
2017-06-30 14:03:32+10:00
tests: add more int/number ranges checks Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> [test_visitor_in_uint() tightened slightly] Signed-off-by: Markus Armbruster <[email protected]>
c1214ad3dcf392ca3d9354c8a811c76f0d4c45ce
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c1214ad3dcf392ca3d9354c8a811c76f0d4c45ce
2017-06-19 14:56:29+02:00
migration: Don't try to set *errp directly Assigning directly to *errp is not valid, as errp may be NULL, &error_fatal, or &error_abort. Use error_propagate() instead. Cc: Juan Quintela <[email protected]> Cc: "Dr. David Alan Gilbert" <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
250561e1aebf69e911992da9017322df7aeaa564
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/250561e1aebf69e911992da9017322df7aeaa564
2017-06-13 11:00:44+02:00
virtio: force VIRTIO_F_IOMMU_PLATFORM We allow vhost to clear VIRITO_F_IOMMU_PLATFORM which is wrong since VIRTIO_F_IOMMU_PLATFORM is mandatory for security. Fixing this by enforce it after vdc->get_features(). Signed-off-by: Jason Wang <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
2943b53f682f54548e7ddcf2ebb6c6d12d8dc821
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2943b53f682f54548e7ddcf2ebb6c6d12d8dc821
2017-01-19 23:00:31+02:00
block/rbd: enable filename option and parsing When enabling option parsing and blockdev-add for rbd, we removed the 'filename' option. Unfortunately, this was a bit optimistic, as previous versions of QEMU allowed the use of the option in backing filenames via json. This means that without parsing this option, we cannot open existing images that used to work fine. See bug: https://bugzilla.redhat.com/show_bug.cgi?id=1457088 Tested-by: Richard W.M. Jones <[email protected]> Signed-off-by: Jeff Cody <[email protected]> Message-id: 937dc9fde348d13311eb8e23444df3bc3190b612.1497444637.git.jcody@redhat.com Signed-off-by: Jeff Cody <[email protected]>
91589d9e5ca658abcc915b078aaa66531a112348
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/91589d9e5ca658abcc915b078aaa66531a112348
2017-06-14 17:39:46-04:00
ide-test: check return of fwrite To quiet patchew, add an assert for fwrite's return value. Signed-off-by: John Snow <[email protected]> Reviewed-by: Jeff Cody <[email protected]> Reviewed-by: Laurent Vivier <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
543f8f13e256a081dd820375e9575439b659ccd8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/543f8f13e256a081dd820375e9575439b659ccd8
2017-06-04 18:42:55+03:00
char: make chr_fe_deinit() optionaly delete backend This simplifies removing a backend for a frontend user (no need to retrieve the associated driver and separate delete call etc). NB: many frontends have questionable handling of ending a chardev. They should probably delete the backend to prevent broken reusage. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
1ce2610c106d925387669b3133fc18ea986f0476
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1ce2610c106d925387669b3133fc18ea986f0476
2017-06-02 11:33:53+04:00
blockjob: use deferred_to_main_loop to indicate the coroutine has ended All block jobs are using block_job_defer_to_main_loop as the final step just before the coroutine terminates. At this point, block_job_enter should do nothing, but currently it restarts the freed coroutine. Now, the job->co states should probably be changed to an enum (e.g. BEFORE_START, STARTED, YIELDED, COMPLETED) subsuming block_job_started, job->deferred_to_main_loop and job->busy. For now, this patch eliminates the problematic reenter by removing the reset of job->deferred_to_main_loop (which served no purpose, as far as I could see) and checking the flag in block_job_enter. Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Jeff Cody <[email protected]>
eb05e011e248c6fb6baee295e14fd206e136028c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/eb05e011e248c6fb6baee295e14fd206e136028c
2017-05-24 16:38:51-04:00
migration/i386: Remove support for pre-0.12 formats Remove support for versions of the CPU state prior to 11 which is the version used in qemu 0.12 - you'd be pretty lucky if you got a migration stream to work from anything that old anyway. This doesn't affect the machine type definition in any way. My main reason for doing this is the hack for sysenter_esp/eip that uses .get/.put's in state versions less than 7 (that's prior to somewhere before 0.10). Signed-off-by: Dr. David Alan Gilbert <[email protected]> Message-Id: <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
08b277ac46da8b02e50cec455eca7cb2d12ffcf0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/08b277ac46da8b02e50cec455eca7cb2d12ffcf0
2017-05-11 16:08:51-03:00
shutdown: Preserve shutdown cause through replay With the recent addition of ShutdownCause, we want to be able to pass a cause through any shutdown request, and then faithfully replay that cause when later replaying the same sequence. The easiest way is to expand the reply event mechanism to track a series of values for EVENT_SHUTDOWN, one corresponding to each value of ShutdownCause. We are free to change the replay stream as needed, since there are already no guarantees about being able to use a replay stream by any other version of qemu than the one that generated it. The cause is not actually fed back until the next patch changes the signature for requesting a shutdown; a TODO marks that upcoming change. Yes, this uses the gcc/clang extension of a ranged case label, but this is not the first time we've used non-C99 constructs. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Pavel Dovgalyuk <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
802f045a5f61b781df55e4492d896b4d20503ba7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/802f045a5f61b781df55e4492d896b4d20503ba7
2017-05-23 13:28:17+02:00
i386: rewrite way CPUID index is validated Change the nested if statements into a flat format, to make it clearer what validation / capping is being performed on different CPUID index values. NB this changes behaviour when "index > env->cpuid_xlevel2". This won't have any guest-visible effect because no there is no CPUID[0xC0000001] feature supported by TCG, and KVM code will never call cpu_x86_cpuid() with such an index value. Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
4ed3d478c63dc65a02eba774c35116618ea5ff10
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4ed3d478c63dc65a02eba774c35116618ea5ff10
2017-05-11 10:54:04-03:00
MAINTAINERS: Update paths for main loop Moved by c2b38b2 ("block: move AioContext, QEMUTimer, main-loop to libqemuutil"), let's update MAINTAINERS too. Reported-by: Laurent Vivier <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
3ecb29a3280b706aebfbc353718c8272eb3ea9db
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3ecb29a3280b706aebfbc353718c8272eb3ea9db
2017-05-10 10:19:24+03:00
maintainers: add maintainer for replay* files Updating MAINTAINERS to set Pavel Dovgalyuk as record/replay maintainer and Paolo Bonzini as a reviewer. Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-id: 20170503113304.8704.13997.stgit@PASHA-ISP Signed-off-by: Stefan Hajnoczi <[email protected]>
6225820136f8c745c71290a904da61114d766253
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6225820136f8c745c71290a904da61114d766253
2017-05-08 12:24:15-04:00
qcow2: Make distinction between zero cluster types obvious Treat plain zero clusters differently from allocated ones, so that we can simplify the logic of checking whether an offset is present. Do this by splitting QCOW2_CLUSTER_ZERO into two new enums, QCOW2_CLUSTER_ZERO_PLAIN and QCOW2_CLUSTER_ZERO_ALLOC. I tried to arrange the enum so that we could use 'ret <= QCOW2_CLUSTER_ZERO_PLAIN' for all unallocated types, and 'ret >= QCOW2_CLUSTER_ZERO_ALLOC' for allocated types, although I didn't actually end up taking advantage of the layout. In many cases, this leads to simpler code, by properly combining cases (sometimes, both zero types pair together, other times, plain zero is more like unallocated while allocated zero is more like normal). Signed-off-by: Eric Blake <[email protected]> Message-id: [email protected] Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Max Reitz <[email protected]>
fdfab37dfeffefbd4533b4158055c9b82d7c3e69
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fdfab37dfeffefbd4533b4158055c9b82d7c3e69
2017-05-11 14:28:07+02:00
slirp: VMStatify remaining except for loop This converts the remaining components, except for the top level loop, to VMState. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Samuel Thibault <[email protected]>
eb5d4f5329df83ea15244b47f7fbca21adaae41b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/eb5d4f5329df83ea15244b47f7fbca21adaae41b
2017-04-29 18:44:16+02:00
qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply The QGA schema states: @can-offline: Whether offlining the VCPU is possible. This member is always filled in by the guest agent when the structure is returned, and always ignored on input (hence it can be omitted then). Currently 'can-offline' is missing entirely from the reply. This causes errors in libvirt which is expecting the reply to be compliant with the schema docs. BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=1438735 Signed-off-by: Sameeh Jubran <[email protected]> Reviewed-by: Eric Blake <[email protected]> Cc: [email protected] Signed-off-by: Michael Roth <[email protected]>
54858553def1879a3b0781529fb12a028ba36713
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/54858553def1879a3b0781529fb12a028ba36713
2017-04-26 23:56:47-05:00
ipmi: introduce an ipmi_bmc_sdr_find() API This patch exposes a new IPMI routine to query a sdr entry from the sdr table maintained by the IPMI BMC simulator. The API is very similar to the internal sdr_find_entry() routine and should be used the same way to query one or all sdrs. A typical use would be to loop on the sdrs to build nodes of a device tree. Signed-off-by: Cédric Le Goater <[email protected]> Acked-by: Corey Minyard <[email protected]> Signed-off-by: David Gibson <[email protected]>
7fabcdb942c2eefa3a40f4cc5ebae25cc13f6ddc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7fabcdb942c2eefa3a40f4cc5ebae25cc13f6ddc
2017-04-26 12:41:55+10:00
ppc/pnv: add initial IPMI sensors for the BMC simulator Skiboot, the firmware for the PowerNV platform, expects the BMC to provide some specific IPMI sensors. These sensors are exposed in the device tree and their values are updated by the firmware at boot time. Sensors of interest are : "FW Boot Progress" "Boot Count" As such a device is defined on the command line, we can only detect its presence at reset time. Signed-off-by: Cédric Le Goater <[email protected]> Reviewed-by: David Gibson <[email protected]> Signed-off-by: David Gibson <[email protected]>
aeaef83dabfec1c1666e65a0c5375983c7a23089
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/aeaef83dabfec1c1666e65a0c5375983c7a23089
2017-04-26 12:41:56+10:00
console: add same displaychangelistener registration pre-condition Catch an invalid state. Mainly useful for documentation purposes. Signed-off-by: Marc-André Lureau <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
e0665c3b5f57e0c1d20ec555c925fb84ccc31b29
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e0665c3b5f57e0c1d20ec555c925fb84ccc31b29
2017-04-24 10:12:28+02:00
tcx: switch to load_image_mr() and remove prom_addr hack Previous to the existence of load_image_mr(), the only way to load in the FCode ROM image was to pass in its physical address via qdev properties and use load_image_targphys(). Signed-off-by: Mark Cave-Ayland <[email protected]> Reviewed-by: Gerd Hoffmann <[email protected]>
749763864208b14f100f1f8319aeb931134430fa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/749763864208b14f100f1f8319aeb931134430fa
2017-04-21 09:02:04+01:00
memory: add MemoryRegionIOMMUOps.replay() callback Originally we have one memory_region_iommu_replay() function, which is the default behavior to replay the translations of the whole IOMMU region. However, on some platform like x86, we may want our own replay logic for IOMMU regions. This patch adds one more hook for IOMMUOps for the callback, and it'll override the default if set. Reviewed-by: David Gibson <[email protected]> Reviewed-by: Eric Auger <[email protected]> Reviewed-by: \"Michael S. Tsirkin\" <[email protected]> Signed-off-by: Peter Xu <[email protected]> Message-Id: <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
faa362e3cc94bf739a89b457693e3fbd7a4b95c4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/faa362e3cc94bf739a89b457693e3fbd7a4b95c4
2017-04-20 15:22:41-03:00
target/ppc: Implement ISA V3.00 radix page fault handler ISA V3.00 introduced a new radix mmu model. Implement the page fault handler for this so we can run a tcg guest in radix mode and perform address translation correctly. In real mode (mmu turned off) addresses are masked to remove the top 4 bits and then are subject to partition scoped translation, since we only support pseries at this stage it is only necessary to perform the masking and then we're done. In virtual mode (mmu turned on) address translation if performed as follows: 1. Use the quadrant to determine the fully qualified address. The fully qualified address is defined as the combination of the effective address, the effective logical partition id (LPID) and the effective process id (PID). Based on the quadrant (EA63:62) we set the pid and lpid like so: quadrant 0: lpid = LPIDR, pid = PIDR quadrant 1: HV only (not allowed in pseries) quadrant 2: HV only (not allowed in pseries) quadrant 3: lpid = LPIDR, pid = 0 If we can't get the fully qualified address we raise a segment interrupt. 2. Find the guest radix tree We ask the virtual hypervisor for the partition table which was registered with H_REGISTER_PROC_TBL which points us to the process table in guest memory. We then index this table by pid to get the process table entry which points us to the appropriate radix tree to translate the address. If the process table isn't big enough to contain an entry for the current pid then we raise a storage interrupt. 3. Walk the radix tree Next we walk the radix tree where each level is a table of page directory entries indexed by some number of bits from the effective address, where the number of bits is determined by the table size. We continue to walk the tree (while entries are valid and the table is of minimum size) until we reach a table of page table entries, indicated by having the leaf bit set. The appropriate pte is then checked for sufficient access permissions, the reference and change bits are updated and the real address is calculated from the real page number bits of the pte and the low bits of the effective address. If we can't find an entry or can't access the entry bacause of permissions then we raise a storage interrupt. Signed-off-by: Suraj Jitindar Singh <[email protected]> [dwg: Add missing parentheses to macro] Signed-off-by: David Gibson <[email protected]>
d5fee0bbe68d5e61e2d2beb5ff6de0b9c1cfd182
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d5fee0bbe68d5e61e2d2beb5ff6de0b9c1cfd182
2017-05-11 09:45:15+10:00
intel_iommu: allow dynamic switch of IOMMU region This is preparation work to finally enabled dynamic switching ON/OFF for VT-d protection. The old VT-d codes is using static IOMMU address space, and that won't satisfy vfio-pci device listeners. Let me explain. vfio-pci devices depend on the memory region listener and IOMMU replay mechanism to make sure the device mapping is coherent with the guest even if there are domain switches. And there are two kinds of domain switches: (1) switch from domain A -> B (2) switch from domain A -> no domain (e.g., turn DMAR off) Case (1) is handled by the context entry invalidation handling by the VT-d replay logic. What the replay function should do here is to replay the existing page mappings in domain B. However for case (2), we don't want to replay any domain mappings - we just need the default GPA->HPA mappings (the address_space_memory mapping). And this patch helps on case (2) to build up the mapping automatically by leveraging the vfio-pci memory listeners. Another important thing that this patch does is to seperate IR (Interrupt Remapping) from DMAR (DMA Remapping). IR region should not depend on the DMAR region (like before this patch). It should be a standalone region, and it should be able to be activated without DMAR (which is a common behavior of Linux kernel - by default it enables IR while disabled DMAR). Reviewed-by: Jason Wang <[email protected]> Reviewed-by: David Gibson <[email protected]> Reviewed-by: \"Michael S. Tsirkin\" <[email protected]> Signed-off-by: Peter Xu <[email protected]> Message-Id: <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
558e0024a428a8f21605dc8aa026612ccc0f14cd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/558e0024a428a8f21605dc8aa026612ccc0f14cd
2017-04-20 15:22:41-03:00
qapi2texi: Present the table of members more clearly The table of members follows the main descriptive text immediately. Makes it hard to see what it is about. Start a new paragraph, and lead with a line "Members:" for object and alternate types, "Values:" for enumeration types, and "Arguments:" for commands and events. Example change (qemu-qmp-ref.txt): -- Command: set_link Sets the link status of a virtual network adapter. + + Arguments: 'name' the device name of the virtual network adapter 'up' true to set the link status to be up Returns: Nothing on success If 'name' is not a valid network device, DeviceNotFound Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-Id: <[email protected]>
2a1183ce9399657a896c51f388e6c7ca58f5d56d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2a1183ce9399657a896c51f388e6c7ca58f5d56d
2017-03-16 07:13:03+01:00
vvfat: Implement .bdrv_child_perm() vvfat is the last remaining driver that can have children, but doesn't implement .bdrv_child_perm() yet. The default handlers aren't suitable here, so let's implement a very simple driver-specific one that protects the internal child from being used by other users as good as our permissions permit. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Acked-by: Fam Zheng <[email protected]>
91ef38257ad225f7fa17a6583fb792c0be9e8acf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/91ef38257ad225f7fa17a6583fb792c0be9e8acf
2017-02-28 20:40:36+01:00
migration: use "" as the default for tls-creds/hostname The tls-creds parameter has a default value of NULL indicating that TLS should not be used. Setting it to non-NULL enables use of TLS. Once tls-creds are set to a non-NULL value via the monitor, it isn't possible to set them back to NULL again, due to current implementation limitations. The empty string is not a valid QObject identifier, so this switches to use "" as the default, indicating that TLS will not be used The tls-hostname parameter has a default value of NULL indicating the the hostname from the migrate connection URI should be used. Again, once tls-hostname is set non-NULL, to override the default hostname for x509 cert validation, it isn't possible to reset it back to NULL via the monitor. The empty string is not a valid hostname, so this switches to use "" as the default, indicating that the migrate URI hostname should be used. Using "" as the default for both, also means that the monitor commands "info migrate_parameters" / "query-migrate-parameters" will report existance of tls-creds/tls-parameters even when set to their default values. Signed-off-by: Daniel P. Berrange <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
4af245dc3e6e5c96405b3edb9d75657504256469
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4af245dc3e6e5c96405b3edb9d75657504256469
2017-03-16 08:57:08+01:00
usb: replace handle_destroy with unrealize Curiously, unrealize() is not being used, but it seems more appropriate than handle_destroy() together with realize(). It is more ubiquitous destroy name in qemu code base and may throw errors. Cc: Gerd Hoffmann <[email protected]> Signed-off-by: Marc-André Lureau <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
c4fe9700e6bb769059608f768d2efd3d80a69630
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c4fe9700e6bb769059608f768d2efd3d80a69630
2017-02-23 15:40:19+01:00
block: document fields protected by AioContext lock Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Reviewed-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
91bcea4899017891983b9149bd50cb283e78dfc0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/91bcea4899017891983b9149bd50cb283e78dfc0
2017-02-21 11:39:40+00:00
vmstate registration: check return values Check qdev's call to vmstate_register_with_alias_id; that gets most of the common uses; there's hundreds of calls via vmstate_register which could get fixed over time. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Message-Id: <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
67980031d234aa90524b83bb80bb5d1601d29076
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/67980031d234aa90524b83bb80bb5d1601d29076
2017-02-06 13:36:49+01:00
xen: use qdev_unplug() instead of g_free() in xen_pv_find_xendev() The error exits of xen_pv_find_xendev() free the new xen-device via g_free() which is wrong. As the xen-device has been initialized as qdev it must be removed via qdev_unplug(). This bug has been introduced with commit 3a6c9172ac5951e6dac2b3f6 ("xen: create qdev for each backend device"). Reported-by: Roger Pau Monné <[email protected]> Tested-by: Roger Pau Monné <[email protected]> Signed-off-by: Juergen Gross <[email protected]> Reviewed-by: Stefano Stabellini <[email protected]>
e9dcbc86d614018923e26e31319b0a54c9e5abac
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e9dcbc86d614018923e26e31319b0a54c9e5abac
2017-02-02 10:23:53-08:00
ui: fix reporting of VNC auth in query-vnc-servers Currently the VNC authentication info is emitted at the top level of the query-vnc-servers data. This is wrong because the authentication scheme differs between plain and websockets when TLS is enabled. We should instead report auth against the individual servers. e.g. (QEMU) query-vnc-servers { "return": [ { "clients": [], "id": "default", "auth": "vencrypt", "vencrypt": "x509-vnc", "server": [ { "host": "127.0.0.1" "service": "5901", "websocket": false, "family": "ipv4", "auth": "vencrypt", "vencrypt": "x509-vnc" }, { "host": "127.0.0.1", "service": "5902", "websocket": true, "family": "ipv4", "auth": "vnc" } ] } ] } This also future proofs the QMP schema so that we can cope with multiple VNC server instances, listening on different interfaces or ports, with different auth setup. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
2a7e6857cd3178d705a49c4adde2f3af26ed3ae1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2a7e6857cd3178d705a49c4adde2f3af26ed3ae1
2017-02-08 14:59:37+01:00
ui: refactor code for populating SocketAddress from vnc_display_open The code which interprets the CLI args to populate the SocketAddress objects for plain & websockets VNC is quite complex already and will need further enhancements shortly. Refactor it into separate methods to avoid vnc_display_open getting even larger. As a side effect of the refactoring, it is now possible to specify a listen address for the websocket server explicitly. e.g, -vnc localhost:5900,websockets=0.0.0.0:8080 will listen on localhost for the plain VNC server, but expose the websockets VNC server on the public interface. This refactoring also removes the restriction that prevents enabling websockets when the plain VNC server is listening on a UNIX socket. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]> Message-id: [email protected] [ kraxel: squashed clang build fix ] Signed-off-by: Gerd Hoffmann <[email protected]>
275e0d616bc36f5e0ffa4eb5e28069d66e8e2137
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/275e0d616bc36f5e0ffa4eb5e28069d66e8e2137
2017-02-09 17:28:45+01:00
char-win: do not override chr_free For some unclear reason to me, char-file does not have chr_free on win32. Since we want to switch to instance finalizer instead of class chr_free, we should be able to run the base WinChardev class finalizer in any case. Use a boolean to skip free to ease the transition to instance finalizer. Signed-off-by: Marc-André Lureau <[email protected]> Reviewed-by: Eric Blake <[email protected]>
c266d94e7b271c90bed0be21fc45a8bb57c03313
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c266d94e7b271c90bed0be21fc45a8bb57c03313
2017-01-31 13:01:47+04:00
qemu-img: remove dead check options must be non-NULL here, because it has been checked before. Reported by Coverity. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
ece9086eb5e3f05e6a3ebb2ec3242932c3b37963
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ece9086eb5e3f05e6a3ebb2ec3242932c3b37963
2017-01-24 23:26:53+03:00
replay: save/load initial state This patch implements initial vmstate creation or loading at the start of record/replay. It is needed for rewinding the execution in the replay mode. v4 changes: - snapshots are not created by default anymore v3 changes: - added rrsnapshot option Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <20170124071746.4572.61449.stgit@PASHA-ISP> Signed-off-by: Paolo Bonzini <[email protected]>
9c2037d0a41d3d55b17a68e42e815be45036d8d2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9c2037d0a41d3d55b17a68e42e815be45036d8d2
2017-01-27 18:07:30+01:00
ppc: Prevent inifnite loop in decrementer auto-reload. If the DECAR register is set to 0, QEMU tries to reload the decrementer with zero in an inifinite loop. According to PPC documentation, the decrementer is triggered on 1->0 transition, so avoid reloading the decrementer if if is already zero. The problem does not manifest under Linux, but it is valid to set DECAR to zero (and may make sense as part of decrementer initialization when interrupts are disabled). Signed-off-by: Roman Kapl <[email protected]> [dwg: Fixed style nit] Signed-off-by: David Gibson <[email protected]>
0dfe952dc5c2921488a1172407857d5bb81d17a4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0dfe952dc5c2921488a1172407857d5bb81d17a4
2017-01-31 10:10:14+11:00
target/xtensa: tests: clean up interrupt tests Don't use hardcoded software interrupt masks, use XCHAL macros. Mask off timer interrupt bits that are not checked for. Signed-off-by: Max Filippov <[email protected]>
8b912ff033cbc2e58476dfdc00fa2b8529c9eb96
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8b912ff033cbc2e58476dfdc00fa2b8529c9eb96
2017-01-15 13:36:09-08:00
quorum: Inline quorum_fifo_aio_cb() Inlining the function removes some boilerplace code and replaces recursion by a simple loop, so the code becomes somewhat easier to understand. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Reviewed-by: Eric Blake <[email protected]>
a7e159025ed439011a47d56af5f34729bbb7247c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a7e159025ed439011a47d56af5f34729bbb7247c
2017-01-09 13:30:52+01:00
target-i386: Fix eflags.TF/#DB handling of syscall/sysret insns The syscall and sysret instructions behave a bit differently: TF is checked after the instruction completes. This allows the o/s to disable #DB at a syscall by adding TF to FMASK. And then when the sysret is executed the #DB is taken "as if" the syscall insn just completed. Signed-off-by: Doug Evans <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
c52ab08aee6f7d4717fc6b517174043126bd302f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c52ab08aee6f7d4717fc6b517174043126bd302f
2016-12-22 16:01:04+01:00
rules.mak: speedup save-vars load-vars Unnesting variables spends a lot of time parsing and executing foreach and if functions. Because actually very few variables have to be saved and restored, a good strategy is to remember what has to be done in load-vars, and only iterate the right variables in load-vars. For save-vars, unroll the foreach loop to provide another small improvement. This speeds up a "noop" build from around 15.5 seconds on my laptop to 11.7 (25% roughly). Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
5ffb3505412b08fb6398748de7eb0fb2cfbfe4e7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5ffb3505412b08fb6398748de7eb0fb2cfbfe4e7
2016-12-22 16:00:23+01:00
xen: slightly simplify bufioreq handling There's no point setting fields always receiving the same value on each iteration, as handle_ioreq() doesn't alter them anyway. Set state and count once ahead of the loop, drop the redundant clearing of data_is_ptr, and avoid the meaningless (because count is 1) setting of df altogether. Also avoid doing an unsigned long calculation of size when the field to be initialized is only 32 bits wide (and the shift value in the range 0...3). Signed-off-by: Jan Beulich <[email protected]> Reviewed-by: Paul Durrant <[email protected]> Reviewed-by: Stefano Stabellini <[email protected]> Signed-off-by: Stefano Stabellini <[email protected]>
f37f29d31488fe36354e59b2fdc4fae83b2cf763
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f37f29d31488fe36354e59b2fdc4fae83b2cf763
2016-11-28 11:26:04-08:00
checkpatch: allow spaces before parenthesis for 'coroutine_fn' Signed-off-by: Jeff Cody <[email protected]> Message-Id: <83b0fae0728906e18849c971d22d077d7fc0f179.1478010883.git.jcody@redhat.com> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
000980cb8307afe0578368cee8f31018905bb036
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/000980cb8307afe0578368cee8f31018905bb036
2016-11-02 09:28:56+01:00
main-loop: Suppress I/O thread warning under qtest We do not want to display the "I/O thread spun" warning for test cases that run under qtest. The first attempt for this (commit 01c22f2cdd4fcf02276ea10f48253850a5fd7259) tested whether qtest_enabled() was true. Commit 21a24302e85024dd7b2a151158adbc1f5dc5c4dd correctly recognized that just testing qtest_enabled() is not sufficient since there are some tests that do not use the qtest accelerator but just the qtest character device, and thus replaced qtest_enabled() by qtest_driver(). However, there are also some tests that only use the qtest accelerator and not the qtest chardev; perhaps most notably the bash iotests. Therefore, we have to check both qtest_enabled() and qtest_driver(). Signed-off-by: Max Reitz <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
7d175d29c9430fcba7a98f2c71925137b7870da4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7d175d29c9430fcba7a98f2c71925137b7870da4
2016-11-02 09:28:57+01:00
nvdimm acpi: introduce _FIT _FIT is required for hotplug support, guest will inquire the updated device info from it if a hotplug event is received As FIT buffer is not completely mapped into guest address space, so a new function, Read FIT whose UUID is UUID 648B9CF2-CDA1-4312-8AD9-49C4AF32BD62, handle 0x10000, function index is 0x1, is reserved by QEMU to read the piece of FIT buffer. The buffer is concatenated before _FIT return Refer to docs/specs/acpi-nvdimm.txt for detailed design Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
806864d9a8a6d5c4cee2ca9bd00474346143113b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/806864d9a8a6d5c4cee2ca9bd00474346143113b
2016-11-01 19:21:09+02:00
block: Add QMP support for streaming to an intermediate layer This patch makes the 'device' parameter of the 'block-stream' command accept a node name that is not a root node. The presence of this feature can't be directly tested with introspection; soon we'll introduce a 'base-node' parameter whose presence can be checked for this purpose. In addition to that, operation blockers will be checked in all intermediate nodes between the top and the base node. Signed-off-by: Alberto Garcia <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
554b614765090f47d97a20ca6981e17e96515ec1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/554b614765090f47d97a20ca6981e17e96515ec1
2016-10-31 16:52:38+01:00
qga: drop unnecessary GA_CHANNEL_UNIX_LISTEN checks Throughout the code there are c->listen_channel checks which manage the listen socket file descriptor (waiting for accept(2), closing the file descriptor, etc). These checks are currently preceded by explicit c->method == GA_CHANNEL_UNIX_LISTEN checks. Explicit GA_CHANNEL_UNIX_LISTEN checks are not necessary since serial channel types do not create the listen channel (c->listen_channel). As more listen channel types are added, explicitly checking all of them becomes messy. Rely on c->listen_channel to determine whether or not a listen socket file descriptor is used. Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Michael Roth <[email protected]> Signed-off-by: Michael Roth <[email protected]>
f06b2031a31cdd3acf6f61a977e505b8c6b58f73
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f06b2031a31cdd3acf6f61a977e505b8c6b58f73
2016-10-31 19:21:22-05:00
audio: intel-hda: check stream entry count during transfer Intel HDA emulator uses stream of buffers during DMA data transfers. Each entry has buffer length and buffer pointer position, which are used to derive bytes to 'copy'. If this length and buffer pointer were to be same, 'copy' could be set to zero(0), leading to an infinite loop. Add check to avoid it. Reported-by: Huawei PSIRT <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
0c0fc2b5fd534786051889459848764edd798050
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0c0fc2b5fd534786051889459848764edd798050
2016-10-26 14:51:44+02:00
pc: Require IRQ remapping and EIM if there could be x2APIC CPUs It would prevent starting guest with incorrect configs where interrupts couldn't be delivered to CPUs with APIC IDs > 255. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Radim Krčmář <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
60c5e1040ec2c26e8da4786f7f35fbe2a8b599d1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/60c5e1040ec2c26e8da4786f7f35fbe2a8b599d1
2016-10-24 17:29:15-02:00
exec: split cpu_exec_init() Put in cpu_exec_initfn() what initializes the CPU, and leave in cpu_exec_init() what adds it to the environment. As cpu_exec_initfn() is called by all XX_cpu_initfn(), call it directly in cpu_common_initfn(). cpu_exec_init() is now a realize function, it will be renamed to cpu_exec_realizefn() and moved to the XX_cpu_realizefn() function in a following patch. Signed-off-by: Laurent Vivier <[email protected]> Reviewed-by: David Gibson <[email protected]> Reviewed-by: Igor Mammedov <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
39e329e341da375b8d66444ffe93c79d7a883350
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/39e329e341da375b8d66444ffe93c79d7a883350
2016-10-24 17:29:16-02:00
s390: avoid always-true comparison in s390_pci_generate_fid() Coverity points out that the comparison "fid <= ZPCI_MAX_FID" in s390_pci_generate_fid() is always true (because fid is 32 bits and ZPCI_MAX_FID is 0xffffffff). This isn't a bug because the real loop termination condition is expressed later via an "if (...) break;" inside the loop, but it is a bit odd. Rephrase the loop to avoid the unnecessary duplicate-but-never-true conditional. Signed-off-by: Peter Maydell <[email protected]> Acked-by: Cornelia Huck <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
35b6e94ba50cd92600a85eef444bc31df8999de1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/35b6e94ba50cd92600a85eef444bc31df8999de1
2016-10-28 18:17:23+03:00
block: Hide HBitmap in block dirty bitmap interface HBitmap is an implementation detail of block dirty bitmap that should be hidden from users. Introduce a BdrvDirtyBitmapIter to encapsulate the underlying HBitmapIter. A small difference in the interface is, before, an HBitmapIter is initialized in place, now the new BdrvDirtyBitmapIter must be dynamically allocated because the structure definition is in block/dirty-bitmap.c. Two current users are converted too. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: John Snow <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
dc162c8e4f088b08575460cca35b042d58c141aa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dc162c8e4f088b08575460cca35b042d58c141aa
2016-10-24 17:56:07+02:00
timer: a9gtimer: remove loop to auto-increment comparator ARM A9MP processor has a peripheral timer with an auto-increment register, which holds an increment step value. A user could set this value to zero. When auto-increment control bit is enabled, it leads to an infinite loop in 'a9_gtimer_update' while updating comparator value. Remove this loop incrementing the comparator value. Reported-by: Li Qiang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Message-id: [email protected] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
6be8f5e2626e102433e569d9cece2120baf0c879
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6be8f5e2626e102433e569d9cece2120baf0c879
2016-10-24 16:26:54+01:00
usb: fix serial generator snprintf return value is *not* the number of chars written into the buffer, but the number of chars needed. So in case the buffer is too small you can go alloc a bigger one and try again. But that also means you can't simply use the return value for the next snprintf call without checking beforehand that things did actually fit. Problem is that usb_desc_create_serial didn't perform that check, so a loooong path string (can happen with deep pci-bridge nesting) results in the third snprintf call smashing the stack. Fix this by throwing out all the snpintf calls and use g_strdup_printf instead. https://bugzilla.redhat.com/show_bug.cgi?id=1381630 Reported-by: Thomas Huth <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-id: [email protected]
0136464d10f1fd9393a8125f2c552ef24f3e592c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0136464d10f1fd9393a8125f2c552ef24f3e592c
2016-10-12 14:37:15+02:00
block: Use 'detect-zeroes' option for 'blockdev-change-medium' Instead of modifying the new BDS after it has been opened, use the newly supported 'detect-zeroes' option in bdrv_open_common() so that all requirements are checked (detect-zeroes=unmap requires discard=unmap). Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Max Reitz <[email protected]>
b85114f8cfbede8b153db68875973ef0790bf296
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b85114f8cfbede8b153db68875973ef0790bf296
2016-09-29 14:13:39+02:00
i2c: Fix SMBus read transactions to avoid double events Change 2293c27faddf (i2c: implement broadcast write) added broadcast capability to the I2C bus, but it broke SMBus read transactions. An SMBus read transaction does two i2c_start_transaction() calls without an intervening i2c_end_transfer() call. This will result in i2c_start_transfer() adding the same device to the current_devs list twice, and then the ->event() for the same device gets called twice in the second call to i2c_start_transfer(), resulting in the smbus code getting confused. Note that this happens even with pure I2C devices when simulating SMBus over I2C. This fix only scans the bus if the current set of devices is empty. This means that the current set of devices stays fixed until i2c_end_transfer() is called, which is really what you want. This also deletes the empty check from the top of i2c_end_transfer(). It's unnecessary, and it prevents the broadcast variable from being set to false at the end of the transaction if no devices were on the bus. Cc: KONRAD Frederic <[email protected]> Cc: Alistair Francis <[email protected]> Cc: Peter Crosthwaite <[email protected]> Cc: Kwon <[email protected]> Cc: Peter Maydell <[email protected]> Signed-off-by: Corey Minyard <[email protected]> Reviewed-by: KONRAD Frederic <[email protected]> Tested-by: KONRAD Frederic <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
0fa758c3a069bc59a0d903d69028971c46d1a119
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0fa758c3a069bc59a0d903d69028971c46d1a119
2016-10-24 16:26:55+01:00
replay: vmstate for replay module This patch introduces vmstate for replay data structures. It allows saving and loading vmstate while replaying. Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <20160926080810.6992.68420.stgit@PASHA-ISP> Signed-off-by: Paolo Bonzini <[email protected]>
306e196fa24c46d384577fb9c16e7cdb80f26d17
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/306e196fa24c46d384577fb9c16e7cdb80f26d17
2016-09-27 11:57:30+02:00
cpus-common: simplify locking for start_exclusive/end_exclusive It is not necessary to hold qemu_cpu_list_mutex throughout the exclusive section, because no other exclusive section can run while pending_cpus != 0. exclusive_idle() is called in cpu_exec_start(), and that prevents any CPUs created after start_exclusive() from entering cpu_exec() during an exclusive section. Reviewed-by: Richard Henderson <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
758e1b2b622d7c177dc2d95e887a11aa069b7e68
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/758e1b2b622d7c177dc2d95e887a11aa069b7e68
2016-09-27 11:57:30+02:00
target-i386: Don't try to enable PT State xsave component The code that calculates the set of supported XSAVE components on CPUID looks at ext_save_areas to find out which components should be enabled. However, if there are zeroed entries in the ext_save_areas array, the ((env->features[esa->feature] & esa->bits) == esa->bits) check will always succeed and QEMU will unconditionally try to enable the component. Luckily this never caused any problems because the only missing entry in ext_save_areas is the PT State component (bit 8), and KVM currently doesn't support it (so it was cleared on ena_mask). But the code was still incorrect and would break if KVM starts returning CPUID[EAX=0xD,ECX=0].EAX[bit 8] as supported on GET_SUPPORTED_CPUID. Fix the problem by changing the code to not enable a XSAVE component if ExtSaveArea::bits is zero. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
9646f4927faf68e8690588c2fd6dc9834c440b58
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9646f4927faf68e8690588c2fd6dc9834c440b58
2016-09-27 16:17:17-03:00
mirror: auto complete active commit Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang <[email protected]> Signed-off-by: Changlong Xie <[email protected]> Signed-off-by: Wang WeiWei <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
b49f7ead8d222bcb8df0388f3177002f3e33d046
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b49f7ead8d222bcb8df0388f3177002f3e33d046
2016-09-13 11:00:56+01:00
tcg: Optimize fence instructions This commit optimizes fence instructions. Two optimizations are currently implemented: (1) unnecessary duplicate fence instructions, and (2) merging weaker fences into a stronger fence. [rth: Merge tcg_optimize_mb back into tcg_optimize, so that we only loop over the opcode stream once. Merge "unrelated" weaker barriers into one stronger barrier.] Signed-off-by: Pranith Kumar <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
34f939218ce78163171addd63750e1e0300376ab
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/34f939218ce78163171addd63750e1e0300376ab
2016-09-16 08:12:12-07:00
tcg: Prepare safe tb_jmp_cache lookup out of tb_lock Ensure atomicity of CPU's 'tb_jmp_cache' access for future translation block lookup out of 'tb_lock'. Note that this patch does *not* make CPU's TLB invalidation safe if it is done from some other thread while the CPU is in its execution loop. Signed-off-by: Alex Bennée <[email protected]> Signed-off-by: Sergey Fedorov <[email protected]> Signed-off-by: Sergey Fedorov <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
89a16b1e4294e3664667a151c2f70c84dfac6fd9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/89a16b1e4294e3664667a151c2f70c84dfac6fd9
2016-09-13 19:08:42+02:00
memory: introduce IOMMUNotifier and its caps IOMMU Notifier list is used for notifying IO address mapping changes. Currently VFIO is the only user. However it is possible that future consumer like vhost would like to only listen to part of its notifications (e.g., cache invalidations). This patch introduced IOMMUNotifier and IOMMUNotfierFlag bits for a finer grained control of it. IOMMUNotifier contains a bitfield for the notify consumer describing what kind of notification it is interested in. Currently two kinds of notifications are defined: - IOMMU_NOTIFIER_MAP: for newly mapped entries (additions) - IOMMU_NOTIFIER_UNMAP: for entries to be removed (cache invalidates) When registering the IOMMU notifier, we need to specify one or multiple types of messages to listen to. When notifications are triggered, its type will be checked against the notifier's type bits, and only notifiers with registered bits will be notified. (For any IOMMU implementation, an in-place mapping change should be notified with an UNMAP followed by a MAP.) Signed-off-by: Peter Xu <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
cdb3081269347fd9271fd1b7a9df312e2953bdd9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cdb3081269347fd9271fd1b7a9df312e2953bdd9
2016-09-27 08:59:16+02:00
spapr: remove extra type variable The sPAPR CPU core typename is already available in the upper block. Let's use it and move the check upward also. Signed-off-by: Cédric Le Goater <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Signed-off-by: David Gibson <[email protected]>
caebf37859b991c27ada22d5d7bfd929844bd20f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/caebf37859b991c27ada22d5d7bfd929844bd20f
2016-08-10 13:12:20+10:00
optionrom: add -fno-stack-protector This is required by OpenBSD. Signed-off-by: Paolo Bonzini <[email protected]>
b0e8f5cadcce7c1e2047e1e2c96f827a26171f58
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b0e8f5cadcce7c1e2047e1e2c96f827a26171f58
2016-08-09 22:57:36+02:00
s390x/cpumodel: let the CPU model handle feature checks If we have certain features enabled, we have to migrate additional state (e.g. vector registers or runtime-instrumentation registers). Let the CPU model control that unless we have no "host" CPU model in the KVM case. This will later on be the case for compatibility machines, so migration from QEMU versions without the CPU model will still work. Acked-by: Cornelia Huck <[email protected]> Signed-off-by: David Hildenbrand <[email protected]> Message-Id: <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
7c72ac49ae9f38fa0125296e05988655157decb5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7c72ac49ae9f38fa0125296e05988655157decb5
2016-09-06 17:06:50+02:00
s390x/cpumodel: expose features and feature groups as properties Let's add all features and feature groups as properties to all CPU models. If the "host" CPU model is unknown, we can neither query nor change features. KVM will just continue to work like it did until now. We will not allow to enable features that were not part of the original CPU model, because that could collide with the IBC in KVM. Acked-by: Cornelia Huck <[email protected]> Signed-off-by: David Hildenbrand <[email protected]> Message-Id: <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
0754f6042995c77ef8843d34df873461353febcd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0754f6042995c77ef8843d34df873461353febcd
2016-09-06 17:06:50+02:00
hw/ppc/spapr: Look up CPU alias names instead of hard-coding the aliases Hard-coding the CPU alias names in the spapr_cores[] array has two big disadvantages: 1) We register a real type with the CPU alias name in spapr_cpu_core_register_types() - this prevents us from registering a CPU family name in kvm_ppc_register_host_cpu_type() with the same name (as we do it for the non-hotpluggable CPU types). 2) It's quite cumbersome to maintain the aliases here in sync with the ppc_cpu_aliases list from target-ppc/cpu-models.c. So let's simply add proper alias lookup to the spapr cpu core code, too (by checking whether the given model can be used directly, and if not by trying to look up the given model as an alias name instead). Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: David Gibson <[email protected]>
4babfaf05d020eab7d6469d12ce77cc142d22276
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4babfaf05d020eab7d6469d12ce77cc142d22276
2016-08-10 13:12:20+10:00
virtio: check vring descriptor buffer length virtio back end uses set of buffers to facilitate I/O operations. An infinite loop unfolds in virtqueue_pop() if a buffer was of zero size. Add check to avoid it. Reported-by: Li Qiang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]>
1e7aed70144b4673fc26e73062064b6724795e5f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1e7aed70144b4673fc26e73062064b6724795e5f
2016-07-29 00:07:10+03:00
hw/pxb: declare pxb devices as not hot-pluggable Prevent future issues when hotplug will work for devices attached to pxbs. Suggested-by: Igor Mammedov <[email protected]> Signed-off-by: Marcel Apfelbaum <[email protected]> Tested-by: Laszlo Ersek <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
7b346c742cd95816c1d5badcc88e18bb95ace08c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7b346c742cd95816c1d5badcc88e18bb95ace08c
2016-07-29 00:07:09+03:00
linuxboot_dma: avoid guest ABI breakage on gcc vs. clang compilation Recent GCC compiles linuxboot_dma.c to 921 bytes, while CentOS 6 needs 1029 and clang needs 1527. Because the size of the ROM, rounded to the next 512 bytes, must match, this causes the API to break between a <1K ROM and one that is bigger. We want to make the ROM 1.5 KB in size, but it's better to make clang produce leaner ROMs, because currently it is worryingly close to the limit. To fix this prevent clang's happy inlining (which -Os cannot prevent). This only requires adding a noinline attribute. Second, the patch makes sure that the ROM has enough padding to prevent ABI breakage on different compilers. The size is now hardcoded in the file that is passed to signrom.py, as was the case before commit 6f71b77 ("scripts/signrom.py: Allow option ROM checksum script to write the size header.", 2016-05-23); signrom.py however will still pad the input to the requested size. This ensures that the padding goes beyond the next multiple of 512 if necessary, and also avoids the need for -fno-toplevel-reorder which clang doesn't support. signrom.py can then error out if the requested size is too small for the actual size of the compiled ROM. Signed-off-by: Paolo Bonzini <[email protected]>
7f2569246c81d5f88e74c142b8fbdc0ee601bffe
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7f2569246c81d5f88e74c142b8fbdc0ee601bffe
2016-08-09 22:57:36+02:00
tests/docker/docker.py: check and run .pre script The docker script will now search for an associated $dockerfile.pre script which gets run in the same build context as the dockerfile will be. This is to support pre-seeding the build context before running the docker build. Signed-off-by: Alex Bennée <[email protected]> Message-id: [email protected] Signed-off-by: Fam Zheng <[email protected]>
920776ea5ea3d9f243d266581da5345e5d7b2306
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/920776ea5ea3d9f243d266581da5345e5d7b2306
2016-07-20 19:19:43+08:00
net: Don't use error_is_set() to suppress additional errors Using error_is_set(errp) that way can sweep programming errors under the carpet when we get called incorrectly with an error set. qmp_query_rx_filter() breaks its loop when it detects an error. It needs to set another error when the loop completes normally. Return right away instead of merely breaking the loop. Signed-off-by: Markus Armbruster <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
9083da1d4c9dfff30d411f8c73ea494e9d78de1b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9083da1d4c9dfff30d411f8c73ea494e9d78de1b
2014-04-25 15:58:07+02:00
mirror: double performance of the bulk stage if the disc is full Mirror can do up to 16 in-flight requests, but actually on full copy (the whole source disk is non-zero) in-flight is always 1. This happens as the request is not limited in size: the data occupies maximum available capacity of s->buf. The patch limits the size of the request to some artificial constant (1 Mb here), which is not that big or small. This effectively enables back parallelism in mirror code as it was designed. The result is important: the time to migrate 10 Gb disk is reduced from ~350 sec to 170 sec. Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]> Signed-off-by: Denis V. Lunev <[email protected]> Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Jeff Cody <[email protected]> Message-id: [email protected] CC: Stefan Hajnoczi <[email protected]> CC: Fam Zheng <[email protected]> CC: Kevin Wolf <[email protected]> CC: Max Reitz <[email protected]> CC: Jeff Cody <[email protected]> CC: Eric Blake <[email protected]> Signed-off-by: Jeff Cody <[email protected]>
0965a41e998ab820b5d660c8abfc8c819c97bc1b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0965a41e998ab820b5d660c8abfc8c819c97bc1b
2016-07-26 16:23:36-04:00
main-loop: check return value before using pointer pointer 'qemu_aio_context' should be checked first before it is used. qemu_bh_new() will use it. Signed-off-by: Cao jin <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
28ba61e7ff2a824e79a477192aee8ee20b95f194
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/28ba61e7ff2a824e79a477192aee8ee20b95f194
2016-07-12 18:31:27+02:00
Clean up decorations and whitespace around header guards Cleaned up with scripts/clean-header-guards.pl. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
175de52487ce0b0c78daa4cdf41a5a465a168a25
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/175de52487ce0b0c78daa4cdf41a5a465a168a25
2016-07-12 16:20:46+02:00
target-arm: Use Neon for zero checking Use Neon instructions to perform zero checking of buffer. This is helps in reducing total migration time. Use case: Idle VM live migration with 4 VCPUS and 8GB ram running CentOS 7. Without Neon, the Total migration time is 3.5 Sec Migration status: completed total time: 3560 milliseconds downtime: 33 milliseconds setup: 5 milliseconds transferred ram: 297907 kbytes throughput: 685.76 mbps remaining ram: 0 kbytes total ram: 8519872 kbytes duplicate: 2062760 pages skipped: 0 pages normal: 69808 pages normal bytes: 279232 kbytes dirty sync count: 3 With Neon, the total migration time is 2.9 Sec Migration status: completed total time: 2960 milliseconds downtime: 65 milliseconds setup: 4 milliseconds transferred ram: 299869 kbytes throughput: 830.19 mbps remaining ram: 0 kbytes total ram: 8519872 kbytes duplicate: 2064313 pages skipped: 0 pages normal: 70294 pages normal bytes: 281176 kbytes dirty sync count: 3 Signed-off-by: Vijaya Kumar K <[email protected]> Signed-off-by: Suresh <[email protected]> Acked-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
7069532e3b944c25707d4f69998e68a739eabff9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7069532e3b944c25707d4f69998e68a739eabff9
2016-07-14 16:51:36+01:00
linux-user: Clean up target_structs.h header guards These headers all use TARGET_STRUCTS_H as header guard symbol. Reuse of the same guard symbol in multiple headers is okay as long as they cannot be included together. Since we can avoid guard symbol reuse easily, do so: use guard symbol $target_TARGET_STRUCTS_H for linux-user/$target/target_structs.h. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
35003856977599497f7a873c026c95f2ed3a56e3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/35003856977599497f7a873c026c95f2ed3a56e3
2016-07-12 16:19:16+02:00
msmouse: fix buffer handling The msmouse chardev backend writes data without checking whenever there is enough space. That happens to work with linux guests, probably by pure luck because the linux driver enables the fifo and the serial port emulation accepts more data than announced via qemu_chr_be_can_write() in that case. Handle this properly by adding a buffer to MouseState. Hook up a CharDriverState->accept_input() handler which feeds the buffer to the serial port. msmouse_event() only fills the buffer now, and calls the accept_input handler too to kick off the transmission. Signed-off-by: Gerd Hoffmann <[email protected]> Acked-by: Paolo Bonzini <[email protected]> Message-id: [email protected]
57a4e3b92b6e87158c1e5192fb99a5ac3b82dd5a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/57a4e3b92b6e87158c1e5192fb99a5ac3b82dd5a
2016-07-12 09:24:31+02:00
range: Eliminate direct Range member access Users of struct Range mess liberally with its members, which makes refactoring hard. Create a set of methods, and convert all users to call them instead of accessing members. The methods have carefully worded contracts, and use assertions to check them. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
a0efbf16604770b9d805bcf210ec29942321134f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a0efbf16604770b9d805bcf210ec29942321134f
2016-07-04 16:49:33+03:00
hmp: use snapshot name to determine whether a snapshot is 'fully available' Currently qemu uses snapshot id to determine whether a snapshot is fully available, It causes incorrect output in some scenario. For instance: (qemu) info block drive_image1 (#block113): /opt/vms/SLES12-SP1-JeOS-x86_64-GM/disk0.qcow2 (qcow2) Cache mode: writeback drive_image2 (#block349): /opt/vms/SLES12-SP1-JeOS-x86_64-GM/disk1.qcow2 (qcow2) Cache mode: writeback (qemu) (qemu) info snapshots There is no snapshot available. (qemu) (qemu) snapshot_blkdev_internal drive_image1 snap1 (qemu) (qemu) info snapshots There is no suitable snapshot available (qemu) (qemu) savevm checkpoint-1 (qemu) (qemu) info snapshots ID TAG VM SIZE DATE VM CLOCK 1 snap1 0 2016-05-22 16:57:31 00:01:30.567 (qemu) $ qemu-img snapshot -l disk0.qcow2 Snapshot list: ID TAG VM SIZE DATE VM CLOCK 1 snap1 0 2016-05-22 16:57:31 00:01:30.567 2 checkpoint-1 165M 2016-05-22 16:58:07 00:02:06.813 $ qemu-img snapshot -l disk1.qcow2 Snapshot list: ID TAG VM SIZE DATE VM CLOCK 1 checkpoint-1 0 2016-05-22 16:58:07 00:02:06.813 The patch uses snapshot name instead of snapshot id to determine whether a snapshot is fully available and uses '--' instead of snapshot id in output because the snapshot id is not guaranteed to be the same on all images. For instance: (qemu) info snapshots List of snapshots present on all disks: ID TAG VM SIZE DATE VM CLOCK -- checkpoint-1 165M 2016-05-22 16:58:07 00:02:06.813 Signed-off-by: Lin Ma <[email protected]> Reviewed-by: Max Reitz <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
3a1ee711904f12f601fffca31a1050d39f833487
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3a1ee711904f12f601fffca31a1050d39f833487
2016-07-13 13:41:39+02:00
target-i386: Cleanup 'foo' feature handling Features check, enforce, hv_relaxed and hv_vapic are treated as boolean set to 'on' when passed from command line, so it's not necessary to handle each of them separately. Collapse them to one catch-all branch which will treat any feature in format 'foo' as boolean set to 'on'. Any unknown feature will be rejected by CPU property setter so there is no need to check for unknown feature in cpu_x86_parse_featurestr(), therefore it's replaced by above mentioned catch-all handler. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
258f5abe9a8786c410f98367e9e042ee16c249f2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/258f5abe9a8786c410f98367e9e042ee16c249f2
2013-12-24 13:47:25+01:00
pci-assign: Move "Invalid ROM" error message to pci-assign-load-rom.c In function pci_assign_dev_load_option_rom, For those pci devices don't have 'rom' file under sysfs or if loading ROM from external file, The function returns NULL, and won't set the passed 'size' variable. In these 2 cases, qemu still reports "Invalid ROM" error message, Users may be confused by it. Signed-off-by: Lin Ma <[email protected]> Message-Id: <[email protected]> Cc: [email protected] Signed-off-by: Paolo Bonzini <[email protected]>
be968c721ee9df49708691ab58f0e66b394dea82
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/be968c721ee9df49708691ab58f0e66b394dea82
2016-06-29 14:03:47+02:00
net: mipsnet: check transmit buffer size before sending When processing MIPSnet I/O port write operation, it uses a transmit buffer tx_buffer[MAX_ETH_FRAME_SIZE=1514]. Two indices 's->tx_written' and 's->tx_count' are used to control data written to this buffer. If the two were to be equal before writing, it'd lead to an OOB write access beyond tx_buffer. Add check to avoid it. Reported-by: Li Qiang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Signed-off-by: Jason Wang <[email protected]>
d88d3a093898bd1dc0898c7c87b0d3f555a24a6e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d88d3a093898bd1dc0898c7c87b0d3f555a24a6e
2016-06-28 10:13:57+08:00
migration: refine ram_save_compressed_page Use qemu_put_compression_data to do the compression directly instead of using do_compress_ram_page, avoid some data copy. very small improvement, at the same time, add code to check if the compression is successful. Signed-off-by: Liang Li <[email protected]> Message-Id: <[email protected]> Signed-off-by: Amit Shah <[email protected]>
fc50438ed0b7106542048d70686ee4b1c340ea49
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fc50438ed0b7106542048d70686ee4b1c340ea49
2016-06-17 18:24:21+05:30
pxa2xx: Unconditionally enable USB controller Simplify initialization logic by removing the usb_enabled() check. The USB controller is part of the SoC, so it doesn't make sense to create a system where it is not present. Cc: Peter Maydell <[email protected]> Cc: Andrzej Zaborowski <[email protected]> Cc: [email protected], Signed-off-by: Eduardo Habkost <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
c92cfba822245c42fec611f310ed74c1821be3d2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c92cfba822245c42fec611f310ed74c1821be3d2
2016-06-13 13:24:41+02:00
pc-dimm: introduce realize callback nvdimm needs to check if the backend memory is large enough to contain label data and init its memory region when the device is realized, so introduce realize callback which is called after common dimm has been realize Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]>
9f318f8f7e689b9653b42bac73047f9719a1f34e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9f318f8f7e689b9653b42bac73047f9719a1f34e
2016-06-07 15:39:28+03:00
test: Postcopy This is a postcopy test (x86 only) that actually runs the guest and checks the memory contents. The test runs from an x86 boot block with the hex embedded in the test; the source for this is: ........... .code16 .org 0x7c00 .file "fill.s" .text .globl start .type start, @function start: # at 0x7c00 ? cli lgdt gdtdesc mov $1,%eax mov %eax,%cr0 # Protected mode enable data32 ljmp $8,$0x7c20 .org 0x7c20 .code32 # A20 enable - not sure I actually need this inb $0x92,%al or $2,%al outb %al, $0x92 # set up DS for the whole of RAM (needed on KVM) mov $16,%eax mov %eax,%ds mov $65,%ax mov $0x3f8,%dx outb %al,%dx # bl keeps a counter so we limit the output speed mov $0, %bl mainloop: # Start from 1MB mov $(1024*1024),%eax innerloop: incb (%eax) add $4096,%eax cmp $(100*1024*1024),%eax jl innerloop inc %bl jnz mainloop mov $66,%ax mov $0x3f8,%dx outb %al,%dx jmp mainloop # GDT magic from old (GPLv2) Grub startup.S .p2align 2 /* force 4-byte alignment */ gdt: .word 0, 0 .byte 0, 0, 0, 0 /* -- code segment -- * base = 0x00000000, limit = 0xFFFFF (4 KiB Granularity), present * type = 32bit code execute/read, DPL = 0 */ .word 0xFFFF, 0 .byte 0, 0x9A, 0xCF, 0 /* -- data segment -- * base = 0x00000000, limit 0xFFFFF (4 KiB Granularity), present * type = 32 bit data read/write, DPL = 0 */ .word 0xFFFF, 0 .byte 0, 0x92, 0xCF, 0 gdtdesc: .word 0x27 /* limit */ .long gdt /* addr */ /* I'm a bootable disk */ .org 0x7dfe .byte 0x55 .byte 0xAA ........... and that can be assembled by the following magic: as --32 -march=i486 fill.s -o fill.o objcopy -O binary fill.o fill.boot dd if=fill.boot of=bootsect bs=256 count=2 skip=124 xxd -i bootsect Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Marcel Apfelbaum <[email protected]> Message-id: [email protected] Message-Id: <[email protected]> Signed-off-by: Amit Shah <[email protected]>
ea0c6d62391d269e2d8927a80912d479a0c5cf8a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ea0c6d62391d269e2d8927a80912d479a0c5cf8a
2016-06-16 09:50:07+05:30
usb-host: add special case for bus+addr This patch changes usb-host behavior in case we hostbus= and hostaddr= properties are used to identify the usb device in question. Instead of adding the device to the hotplug watchlist we try to open directly using the given bus number and device address. Putting a device specified by hostaddr to the hotplug watchlist isn't a great idea as the address isn't a fixed property. It changes every time the device is plugged in. So considering this case as "use the device at bus:addr _now_" is more sane. Also usb-host will throw errors in case it can't initialize the host device. Note: For devices on the hotplug watchlist (hostport or vendorid or productid specified) qemu continues to ignore errors and keeps monitoring the usb bus to see if the device eventually shows up. Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected]
e058fa2dd599ccc780d334558be9c1d155222b80
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e058fa2dd599ccc780d334558be9c1d155222b80
2016-06-13 13:17:06+02:00
acpi: do not use TARGET_PAGE_SIZE This is a #define used by the CPU. NVDIMM can just use 4K unconditionally. Signed-off-by: Paolo Bonzini <[email protected]>
35c5a52d1d016c632aed6137549754ca53446c92
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/35c5a52d1d016c632aed6137549754ca53446c92
2016-05-19 16:42:28+02:00
i.MX: Fix FEC code for MDIO operation selection According to the FEC chapter of i.MX25 reference manual When writing the MMFR register, bit 29 and 28 select the requested operation. * 10 means read operation with valid MII mgmt frame * 11 means read operation with non compliant MII mgmt frame * 01 means write operation with valid MII mgmt frame * 00 means write operation with non compliant MII mgmt frame So while bit 28 does change beween read/write for valid MII mgmt frame, the mening is inverted for non compliant MII mgmt frame. Bit 29 on the other hand means read/write whatever the type of mgmt frame involved. So this patch change the operation selection from bit 28 to bit 29 as it is more generic. Signed-off-by: Jean-Christophe Dubois <[email protected]> Signed-off-by: Jason Wang <[email protected]>
4816dc168b5745708eba4c005f5e8771623ee405
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4816dc168b5745708eba4c005f5e8771623ee405
2016-06-02 10:42:46+08:00
target-i386: kvm: Increase MSR_BUF_SIZE We are dangerously close to the array limits in kvm_put_msrs() and kvm_get_msrs(): with the default mcg_cap configuration, we can set up to 148 MSRs in kvm_put_msrs(), and if we allow mcg_cap to be changed, we can write up to 236 MSRs. Use 4096 bytes for the buffer, that can hold 255 kvm_msr_entry structs. Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
d1138251bf712cc076cdbbfd68aae3c8792bfcf9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d1138251bf712cc076cdbbfd68aae3c8792bfcf9
2016-05-23 19:47:37-03:00
block: Invalidate all children Currently we only recurse to bs->file, which will miss the children in quorum and VMDK. Recurse into the whole subtree to avoid that. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
0d1c5c91607d1c55a8f5db39c57c6e5c76e21131
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0d1c5c91607d1c55a8f5db39c57c6e5c76e21131
2016-05-12 15:22:09+02:00
xen-hvm: ignore background I/O sections Since Xen will correctly handle accesses to unimplemented I/O ports (by returning all 1's for reads and ignoring writes) there is no need for QEMU to register backgroud I/O sections. This patch therefore adds checks to xen_io_add/del so that sections with memory-region ops pointing at 'unassigned_io_ops' are ignored. Signed-off-by: Paul Durrant <[email protected]> Cc: Stefano Stabellini <[email protected]> Cc: Anthony Perard <[email protected]> Cc: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Acked-by: Anthony PERARD <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
a8ff4316795c7051b38727ec4a81c65dfcf63dc6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a8ff4316795c7051b38727ec4a81c65dfcf63dc6
2016-05-29 09:11:11+02:00
nbd: Switch to byte-based block access Sector-based blk_read() should die; switch to byte-based blk_pread() instead. Add a constant for our magic number 512, to make it obvious that this size will NOT change even if BDRV_SECTOR_SIZE does, even though the two happen to be the same for now. Split assignments from conditionals to keep checkpatch.pl happy. Signed-off-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
bd31c214c328bc6a2b2f5567623d964b65c8f44c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bd31c214c328bc6a2b2f5567623d964b65c8f44c
2016-05-12 15:22:09+02:00
usb: Support compilation without poll.h This is a hack to support compilation with Mingw-w64 which provides a libusb-1.0 package, but no poll.h. Signed-off-by: Stefan Weil <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
a277c3e094d5e9f653ccc861f59e07c94c7fe6c7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a277c3e094d5e9f653ccc861f59e07c94c7fe6c7
2016-05-11 10:37:39+02:00