commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
vhost-user-test: use tmpfs by default Most people don't run make check by default, so they skip vhost-user unit tests. Solve this by using tmpfs instead, unless hugetlbfs is specified (using an environment variable). Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]>
1b7e1e3b463a6e5c117498b192cb07603c04b668
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1b7e1e3b463a6e5c117498b192cb07603c04b668
2015-10-02 17:04:32+03:00
qapi: Prepare for errors during check() The next few patches will start migrating error checking from ad hoc parse methods into the QAPISchema*.check() methods. But for an error message to display, we first have to fix the overall 'try' to catch those errors. We also want to enable a few more assertions, such as making sure every attempt to raise a semantic error is passed a valid location info, or that various preconditions hold. The general approach for moving error checking will then be to relax an assertion into an if that raises an exception if the condition does not hold, and removing the counterpart ad hoc check done during the parse phase. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
7618b91ff80ec42b84b29be24d8ef53ddb377110
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7618b91ff80ec42b84b29be24d8ef53ddb377110
2015-10-15 08:39:07+02:00
target-arm/translate.c: Handle non-executable page-straddling Thumb insns When the memory we're trying to translate code from is not executable we have to turn this into a guest fault. In order to report the correct PC for this fault, and to make sure it is not reported until after any other possible faults for instructions earlier in execution, we must terminate TBs at the end of a page, in case the next instruction is in a non-executable page. This is simple for T16, A32 and A64 instructions, which are always aligned to their size. However T32 instructions may be 32-bits but only 16-aligned, so they can straddle a page boundary. Correct the condition that checks whether the next instruction will touch the following page, to ensure that if we're 2 bytes before the boundary and this insn is T32 then we end the TB. Reported-by: Pavel Dovgalyuk <[email protected]> Reviewed-by: Laurent Desnogues <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
541ebcd401ee47f3c1a3ce503ef5466b75e9d20a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/541ebcd401ee47f3c1a3ce503ef5466b75e9d20a
2015-10-27 12:00:50+00:00
pc-bios/s390-ccw: avoid floating point operations Some gcc versions (e.g. Fedora 22 gcc 5.1.1) seem to use floating point registers for spilling and filling of general purpose registers. As the BIOS does not activate the AFP register setting of CR0 this can cause data exception program checks. Disallow floating point in the BIOS as a simple solution. Signed-off-by: Christian Borntraeger <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Message-Id: <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
af3c15fee54e841d859d003b90a88042daf6cd7a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/af3c15fee54e841d859d003b90a88042daf6cd7a
2015-10-02 13:31:52+02:00
qapi: Replace dirty is_c_ptr() by method c_null() is_c_ptr() looks whether the end of the C text for the type looks like a pointer. Works, but is fragile. We now have a better tool: use QAPISchemaType method c_null(). The initializers for non-pointers become prettier: 0, false or the enumeration constant with the value 0 instead of {0}. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]>
5710153e7310995b5d4127af267e36d8529b3b30
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5710153e7310995b5d4127af267e36d8529b3b30
2015-09-21 09:56:48+02:00
hw/arm/virt: Add gic-version option to virt machine Add gic_version to VirtMachineState, set it to value of the option and pass it around where necessary. Instantiate devices and fdt nodes according to the choice. max_cpus for virt machine increased to 123 (calculated from redistributor space available in the memory map). GICv2 compatibility check happens inside arm_gic_common_realize(). ITS region is added to the memory map too, however currently it not used, just reserved. Signed-off-by: Pavel Fedin <[email protected]> Tested-by: Ashok kumar <[email protected]> [PMM: Added missing cpu_to_le* calls, thanks to Shannon Zhao] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
b92ad3949bc9cacd1652b4e07e7f6003b9e512af
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b92ad3949bc9cacd1652b4e07e7f6003b9e512af
2015-09-24 01:29:37+01:00
atapi: abort transfers with 0 byte limits We're supposed to abort on transfers like this, unless we fill Word 125 of our IDENTIFY data with a default transfer size, which we don't currently do. This is an ATA error, not a SCSI/ATAPI one. See ATA8-ACS3 sections 7.17.6.49 or 7.21.5. If we don't do this, QEMU will loop forever trying to transfer zero bytes, which isn't particularly useful. Signed-off-by: John Snow <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Message-id: [email protected]
9ef2e93f9b1888c7d0deb4a105149138e6ad2e98
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9ef2e93f9b1888c7d0deb4a105149138e6ad2e98
2015-09-18 10:58:56-04:00
target-mips: fix corner case in TLBWR causing QEMU to hang cpu_mips_get_random() function is used to generate a random index from CP0.Wired to TLBSize-1 range. Current implementation avoids generating the same as before value, hence the while loop. If the guest sets CP0.Wired to TLBSize-1 (which actually does not sound to be very practical) QEMU will get stuck in the loop infinitely as we always generate the same index. Signed-off-by: Leon Alrae <[email protected]> Reviewed-by: Aurelien Jarno <[email protected]>
3adafef2f35d9061b56a09071b2589b9e0b36f76
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3adafef2f35d9061b56a09071b2589b9e0b36f76
2015-09-18 09:20:48+01:00
pc: memhotplug: keep reserved-memory-end broken on 2.4 and earlier machines it will prevent guests on old machines from seeing inconsistent memory mapping in firmware/ACPI views. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]>
2f8b50083b321e470ef8e2502910ade40cbfa020
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2f8b50083b321e470ef8e2502910ade40cbfa020
2015-09-10 12:15:30+03:00
qcow2: Make size_to_clusters() return uint64_t Sadly, some images may have more clusters than what can be represented using a plain int. We should be prepared for that case (in qcow2_check_refcounts() we actually were trying to catch that case, but since size_to_clusters() truncated the returned value, that check never did anything useful). Cc: qemu-stable <[email protected]> Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
b6d36def6d9e9fd187327182d0abafc9b7085d8f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b6d36def6d9e9fd187327182d0abafc9b7085d8f
2015-09-14 16:51:37+02:00
target-arm: Implement AArch64 TLBI operations on IPAs Implement the AArch64 TLBI operations which take an intermediate physical address and invalidate stage 2 translations. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]> Message-id: [email protected]
cea66e91212164e02ad1d245c2371f7e8eb59e7f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cea66e91212164e02ad1d245c2371f7e8eb59e7f
2015-08-25 16:18:33+01:00
dp8393x: Flush packets when link comes up .can_receive callback changes semantics that once return 0, backend will try sending again until explicitly flushed, change the device to meet that. dp8393x_can_receive checks SONIC_CR_RXEN bit in SONIC_CR register and SONIC_ISR_RBE bit in SONIC_ISR register, try flushing the queue when either bit is being updated. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Jason Wang <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
4594f93a732f1f5936c3a5225481586e24bffa9e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4594f93a732f1f5936c3a5225481586e24bffa9e
2015-07-27 14:12:18+01:00
block: keep bitmap if incremental backup job is cancelled Reclaim the dirty bitmap if an incremental backup block job is cancelled. The ret variable may be 0 when the job is cancelled so it's not enough to check ret < 0. Reviewed-by: John Snow <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Signed-off-by: Jeff Cody <[email protected]>
17d9716d7b5381c4b6566bb1a06267d2bfcd1821
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/17d9716d7b5381c4b6566bb1a06267d2bfcd1821
2015-07-14 21:50:13-04:00
usbnet: Drop usbnet_can_receive usbnet_receive already drops packet if rndis_state is not RNDIS_DATA_INITIALIZED, and queues packet if in buffer is not available. The only difference is s->dev.config but that is similar to rndis_state. Drop usbnet_can_receive and move these checks to usbnet_receive, so that we don't need to explicitly flush the queue when s->dev.config changes value. Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Jason Wang <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
913440249ea2e697177e9d43167ac325a8dfe907
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/913440249ea2e697177e9d43167ac325a8dfe907
2015-07-27 14:12:18+01:00
kvm-all: move internal types to kvm_int.h i386 code will have to define a different KVMMemoryListener. Create an internal header so that KVMSlot is not exposed outside. Signed-off-by: Paolo Bonzini <[email protected]>
8571ed35cfa50ed6b2aaee484dfa4f58176ebe00
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8571ed35cfa50ed6b2aaee484dfa4f58176ebe00
2015-07-06 17:59:43+02:00
linux-user: fix the breakpoint inheritance in spawned threads When a thread is spawned, cpu_copy re-initializes the bp & wp lists of current thread, instead of the ones of the new thread. The effect is that breakpoints are no longer hit. Signed-off-by: Thierry Bultel <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
1d085f6cae51b1a0fb92ad03ce8bf038e29c9750
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1d085f6cae51b1a0fb92ad03ce8bf038e29c9750
2015-06-16 08:21:02+03:00
block: Add bdrv_get_block_status_above Like bdrv_is_allocated_above, this function follows the backing chain until seeing BDRV_BLOCK_ALLOCATED. Base is not included. Reimplement bdrv_is_allocated on top. [Initialized bdrv_co_get_block_status_above() ret to 0 to silence mingw64 compiler warning about the unitialized variable. assert(bs != base) prevents that case but I suppose the program could be compiled with -DNDEBUG. --Stefan] Signed-off-by: Fam Zheng <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
ba3f0e2545c365ebe1dbddb0e53058710d41881e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ba3f0e2545c365ebe1dbddb0e53058710d41881e
2015-07-02 10:03:50+01:00
target-mips: remove misleading comments in translate_init.c PABITS are not hardcoded to 36 bits and we do not model 59 PABITS (which is the architectural limit) in QEMU. Signed-off-by: Leon Alrae <[email protected]> Reviewed-by: Aurelien Jarno <[email protected]>
28b027d5b63c7550c7390041d6dd50948c8f55b8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/28b027d5b63c7550c7390041d6dd50948c8f55b8
2015-06-12 09:05:43+01:00
virtio-gpu-pci: add virtio pci support This patch adds virtio-gpu-pci, which is the pci proxy for the virtio gpu device. With this patch in place virtio-gpu is functional. You need a linux guest with a virtio-gpu driver though, and output will appear pretty late in boot, once the kernel initialized drm and fbcon. Written by Dave Airlie and Gerd Hoffmann. Signed-off-by: Dave Airlie <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
9eafb62d47ac1c8c2d431e1b4829445444ccc2ee
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9eafb62d47ac1c8c2d431e1b4829445444ccc2ee
2015-06-12 10:13:23+02:00
softmmu: Add probe_write() Probe for whether the specified guest write access is permitted. If it is not permitted then an exception will be taken in the same way as if this were a real write access (and we will not return). Otherwise the function will return, and there will be a valid entry in the TLB for this access. Signed-off-by: Yongbok Kim <[email protected]> Reviewed-by: Leon Alrae <[email protected]> Signed-off-by: Leon Alrae <[email protected]>
3b4afc9e75ab1a95f33e41f462921093f8a109c4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3b4afc9e75ab1a95f33e41f462921093f8a109c4
2015-06-11 10:13:28+01:00
vl: allow full-blown QemuOpts syntax for -global -global does not work for drivers that have a dot in their name, such as cfi.pflash01. This is just a parsing limitation, because such globals can be declared easily inside a -readconfig file. To allow this usage, support the full QemuOpts key/value syntax for -global too, for example "-global driver=cfi.pflash01,property=secure,value=on". The two formats do not conflict, because the key/value syntax does not have a period before the first equal sign. Signed-off-by: Paolo Bonzini <[email protected]>
3751d7c43f795b45ffdb9429cfb09c6beea55c68
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3751d7c43f795b45ffdb9429cfb09c6beea55c68
2015-06-05 17:36:39+02:00
tpm: Probe for connected TPM 1.2 or TPM 2 In the TPM passthrough backend driver, modify the probing code so that we can check whether a TPM 1.2 or TPM 2 is being used and adapt the behavior of the TPM TIS accordingly. Move the code that tested for a TPM 1.2 into tpm_utils.c and extend it with test for probing for TPM 2. Have the function return the version of TPM found. Signed-off-by: Stefan Berger <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
56a3c24ffc11955ddc7bb21362ca8069a3fc8c55
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/56a3c24ffc11955ddc7bb21362ca8069a3fc8c55
2015-05-31 20:29:02+02:00
target-arm: Correct check for non-EL3 This fixes a compile warning from clang 3.5 (the assertion could never fire). Signed-off-by: Edgar E. Iglesias <[email protected]> Message-id: [email protected] Reviewed-by: Peter Maydell <[email protected]> Reviewed-by: John Snow <[email protected]> [PMM: added note in commit message that this is fixing a build warning] Signed-off-by: Peter Maydell <[email protected]>
3fc827d591679f3e262b9d1f8b34528eabfca8c0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3fc827d591679f3e262b9d1f8b34528eabfca8c0
2015-06-02 13:22:29+01:00
memory: differentiate memory_region_is_logging and memory_region_get_dirty_log_mask For now memory regions only track DIRTY_MEMORY_VGA individually, but this will change soon. To support this, split memory_region_is_logging in two functions: one that returns a given bit from dirty_log_mask, and one that returns the entire mask. memory_region_is_logging gets an extra parameter so that the compiler flags misuse. While VGA-specific users (including the Xen listener!) will want to keep checking that bit, KVM and vhost check for "any bit except migration" (because migration is handled via the global start/stop listener callbacks). Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
2d1a35bef0ed96b3f23535e459c552414ccdbafd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2d1a35bef0ed96b3f23535e459c552414ccdbafd
2015-06-05 17:09:58+02:00
target-arm: Don't halt on WFI unless we don't have any work Just NOP the WFI instruction if we have work to do. This doesn't make much difference currently (though it does avoid jumping out to the top level loop and immediately restarting), but the distinction between "halt" and "don't halt" will become more important when the decision to halt requires us to trap to a higher exception level instead. Suggested-by: Edgar E. Iglesias <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]>
84549b6dcf9147559ec08b066de673587be6b763
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/84549b6dcf9147559ec08b066de673587be6b763
2015-05-29 11:28:53+01:00
qapi: Fix C identifiers generated for names containing '.' c_fun() maps '.' to '_', c_var() doesn't. Nothing prevents '.' in QAPI names that get passed to c_var(). Which QAPI names get passed to c_fun(), to c_var(), or to both is not obvious. Names of command parameters and struct type members get passed to c_var(). c_var() strips a leading '*', but this cannot happen. c_fun() doesn't. Fix c_var() to work exactly like c_fun(). Perhaps they should be replaced by a single mapping function. Signed-off-by: Markus Armbruster <[email protected]> [add 'import string'] Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Alberto Garcia <[email protected]>
47299262de424af0cb69965d082e5e70b2314183
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/47299262de424af0cb69965d082e5e70b2314183
2015-05-14 18:20:29+02:00
qapi: Better error messages for duplicated expressions The previous commit demonstrated that the generator overlooked duplicate expressions: - a complex type or command reusing a built-in type name - redeclaration of a type name, whether by the same or different metatype - redeclaration of a command or event - collision of a type with implicit 'Kind' enum for a union - collision with an implicit MAX enum constant Since the c_type() function in the generator treats all names as being in the same namespace, this patch adds a global array to track all known names and their source, to prevent collisions before it can cause further problems. While valid .json files won't trigger any of these cases, we might as well be nicer to developers that make a typo while trying to add new QAPI code. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
4dc2e6906e1084fdd37bf67385c5dcd2c72ae22b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4dc2e6906e1084fdd37bf67385c5dcd2c72ae22b
2015-05-05 18:39:01+02:00
qapi: Make c_type() consistently convert qapi names Continuing the string of cleanups for supporting downstream names containing '.', this patch focuses on ensuring c_type() can handle a downstream name. This patch alone does not fix the places where generator output should be calling this function but was open-coding things instead, but it gets us a step closer. In particular, the changes to c_list_type() and type_name() mean that type_name(FOO) now handles the case when FOO contains '.', '-', or is a ticklish identifier other than a builtin (builtins are exempted because ['int'] must remain mapped to 'intList' and not 'q_intList'). Meanwhile, ['unix'] now maps to 'q_unixList' rather than 'unixList', to match the fact that 'unix' is ticklish; however, our naming conventions state that complex types should start with a capital, so no type name following conventions will ever have the 'q_' prepended. Likewise, changes to c_type() mean that c_type(FOO) properly handles an enum or complex type FOO with '.' or '-' in the name, or is a ticklish identifier (again, a ticklish identifier as a type name violates conventions). Signed-off-by: Eric Blake <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
c6405b54b7b09a876f2f2fba2aa6f8ac87189cb9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c6405b54b7b09a876f2f2fba2aa6f8ac87189cb9
2015-05-14 18:21:07+02:00
virtio-scsi: Move DEFINE_VIRTIO_SCSI_FEATURES to virtio-scsi So far virtio-scsi-device can't expose host features to guest while using virtio-mmio because it doesn't set DEFINE_VIRTIO_SCSI_FEATURES on backend or transport. The host features belong to the backends while virtio-scsi-pci, virtio-scsi-s390 and virtio-scsi-ccw set the DEFINE_VIRTIO_SCSI_FEATURES on transports. But they already have the ability to forward property accesses to the backend child. So if we move the host features to backends, it doesn't break the backwards compatibility for them and make host features work while using virtio-mmio. Move DEFINE_VIRTIO_SCSI_FEATURES to the backend virtio-scsi. The transports just sync the host features from backends. Signed-off-by: Shannon Zhao <[email protected]> Signed-off-by: Shannon Zhao <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Peter Maydell <[email protected]>
da2f84d1270d203027d82f778d5bcc1f7a49bab0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/da2f84d1270d203027d82f778d5bcc1f7a49bab0
2015-04-28 17:44:40+02:00
block: avoid unnecessary bottom halves bdrv_aio_* APIs can use coroutines to achieve asynchronicity. However, the coroutine may terminate without having yielded back to the caller (for example because of something that invokes a nested event loop, or because the coroutine is doing nothing at all). In this case, the bdrv_aio_* API must delay the completion to the next iteration of the main loop, because bdrv_aio_* will never invoke the callback before returning. This can be done with a bottom half, and indeed bdrv_aio_* is always using one for simplicity. It is possible to gain some performance (~3%) by avoiding this in the common case. A new field in the BlockAIOCBCoroutine struct is set to true until the first time the corotine has yielded to its creator, and completion goes through a new function bdrv_co_complete. If the flag is false, bdrv_co_complete invokes the callback immediately. If it is true, the caller will notice that the coroutine has completed and schedule the bottom half itself. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
0b5a24454fc551f0294fe93821e8c643214a55f5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0b5a24454fc551f0294fe93821e8c643214a55f5
2015-04-28 15:36:09+02:00
gtk: do not call gtk_widget_get_window if drawing area is not initialized This prevents gtk_widget_get_window to return a NULL pointer. Signed-off-by: Hervé Poussineau <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
4cdfc93526364bc9b20a21c9edd802d737cec85f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4cdfc93526364bc9b20a21c9edd802d737cec85f
2015-03-26 17:58:12+01:00
qcow2: Fix header update with overridden backing file In recent qemu versions, it is possible to override the backing file name and format that is stored in the image file with values given at runtime. In such cases, the temporary override could end up in the image header if the qcow2 header was updated, while obviously correct behaviour would be to leave the on-disk backing file path/format unchanged. Fix this and add a test case for it. Reported-by: Michael Tokarev <[email protected]> Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
e4603fe139e2161464d7e75faa3a650e31f057fc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e4603fe139e2161464d7e75faa3a650e31f057fc
2015-04-08 10:29:20+01:00
target-arm: Fix handling of STM (user) with r15 in register list The A32 encoding of LDM distinguishes LDM (user) from LDM (exception return) based on whether r15 is in the register list. However for STM (user) there is no equivalent distinction. We were incorrectly treating "r15 in list" as indicating exception return for both LDM and STM, with the result that an STM (user) involving r15 went into an infinite loop. Fix this; note that the value stored for r15 in this case is the current PC regardless of our current mode. Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected]
da3e53ddcb0ca924da97ca5a35605fc554aa3e05
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/da3e53ddcb0ca924da97ca5a35605fc554aa3e05
2015-03-16 12:30:47+00:00
monitor: Drop dead QMP check from monitor_read_password() Function is only called in HMP context since commit 333a96e "qapi: Convert change". Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
bcf5d19c59a527c91bc29704f3e4956119c050cf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bcf5d19c59a527c91bc29704f3e4956119c050cf
2015-03-17 14:11:43+01:00
qemu-img: Suppress unhelpful extra errors in convert, amend img_convert() and img_amend() use qemu_opts_do_parse(), which reports errors with qerror_report_err(). Its error messages aren't helpful here, the caller reports one that actually makes sense. Reproducer: $ qemu-img convert -o backing_format=raw in.img out.img qemu-img: Invalid parameter 'backing_format' qemu-img: Invalid options for file format 'raw' To fix, propagate errors through qemu_opts_do_parse(). This lifts the error reporting into callers. Drop it from img_convert() and img_amend(), keep it in qemu_chr_parse_compat(), bdrv_img_create(). Since I'm touching qemu_opts_do_parse() anyway, write a function comment for it. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]>
dc523cd348c47372faa7271c9aab2030f94c290d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dc523cd348c47372faa7271c9aab2030f94c290d
2015-02-26 14:51:21+01:00
block/raw-posix: fix compilation warning on OSX block/raw-posix.c:947:19: warning: unused variable 's' [-Wunused-variable] BDRVRawState *s = aiocb->bs->opaque; This variable is used only when on of the following macros are defined CONFIG_XFS, CONFIG_FALLOCATE, CONFIG_FALLOCATE_PUNCH_HOLE or CONFIG_FALLOCATE_ZERO_RANGE. Fortunately, CONFIG_FALLOCATE_PUNCH_HOLE and CONFIG_FALLOCATE_ZERO_RANGE could be defined only along with CONFIG_FALLOCATE. Therefore checking for CONFIG_XFS or CONFIG_FALLOCATE would be enough. Signed-off-by: Denis V. Lunev <[email protected]> CC: Peter Maydell <[email protected]> CC: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
a6dcf097fad2773fdee9ea12f8452dcc259e9ee1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a6dcf097fad2773fdee9ea12f8452dcc259e9ee1
2015-03-09 11:11:59+01:00
aes: remove a dead return statement bits is checked to be 128, 192 or 256 at the beginning of the function. Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
a50c7c869a4fa1c78b4c38d3419566dd25d32e90
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a50c7c869a4fa1c78b4c38d3419566dd25d32e90
2015-02-10 09:27:20+03:00
qemu-option: Pair g_malloc() with g_free(), not free() Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled and my "coverity: Model g_free() isn't necessarily free()" model patch applied. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Gonglei <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
c0462f6d75fa481f7660c15a5ca3a60205aa4eca
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c0462f6d75fa481f7660c15a5ca3a60205aa4eca
2015-02-10 09:27:20+03:00
nbd: Drop BDS backpointer Before this patch, the "opaque" pointer in an NBD BDS points to a BDRVNBDState, which contains an NbdClientSession object, which in turn contains a pointer to the BDS. This pointer may become invalid due to bdrv_swap(), so drop it, and instead pass the BDS directly to the nbd-client.c functions which then retrieve the NbdClientSession object from there. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
f53a829bb9ef14be800556cbc02d8b20fc1050a7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f53a829bb9ef14be800556cbc02d8b20fc1050a7
2015-02-16 14:36:03+00:00
cpu_ldst.h: Allow NB_MMU_MODES to be 7 Support guest CPUs which need 7 MMU index values. Add a comment about what would be required to raise the limit further (trivial for 8, TCG backend rework for 9 or more). Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Greg Bellows <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
8f3ae2ae2d02727f6d56610c09d7535e43650dd4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8f3ae2ae2d02727f6d56610c09d7535e43650dd4
2015-02-05 13:37:23+00:00
block/dmg: improve zeroes handling Disk images may contain large all-zeroes gaps (1.66k sectors or 812 MiB is seen in the real world). These blocks (type 2) do not need to be extracted into a temporary buffer, there is no need to allocate memory for these blocks nor to check its length. (For the test image, the maximum uncompressed size is 1054371 bytes, probably for a bzip2-compressed block.) Signed-off-by: Peter Wu <[email protected]> Reviewed-by: John Snow <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
177b75104da3e3a9af84975c32a44782d903c41f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/177b75104da3e3a9af84975c32a44782d903c41f
2015-02-06 17:24:21+01:00
exec: fix madvise of NULL pointer Coverity flags this as "dereference after null check". Not quite a dereference, since it will just EFAULT, but still nice to fix. Signed-off-by: Paolo Bonzini <[email protected]>
a904c91196a9c5dbd7b9abcd3d40b0824286fb1c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a904c91196a9c5dbd7b9abcd3d40b0824286fb1c
2015-01-26 12:27:05+01:00
target-i386: do not memcpy in and out of xmm_regs After the next patch, we will move the high parts of AVX and AVX512 registers in the same array as the SSE registers. This will make it impossible to memcpy an array of 128-bit values in and out of xmm_regs in one swoop. Use a for loop instead. Similarly, always use XMM_Q in translate.c. This avoids introducing bugs such as the one fixed in the previous patch. Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
bee818872cd9e8c07be529f75da3e48a68bf7a93
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bee818872cd9e8c07be529f75da3e48a68bf7a93
2015-01-14 10:38:57+01:00
Fix FMULX not squashing denormalized inputs when FZ is set. While FMULX returns a 2.0f float when two operators are infinity and zero, those operators should be unpacked from raw inputs first. Inconsistent cases would occur when operators are denormalized floats in flush-to-zero mode. A wrong codepath will be entered and 2.0f will not be returned without this patch. Fix by checking whether inputs need to be flushed before running into different codepaths. Signed-off-by: Xiangyu Hu <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
dabf005808f0830313f313c76a492294ef3bce6a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dabf005808f0830313f313c76a492294ef3bce6a
2015-02-05 13:37:22+00:00
PPC: mpc8554ds: Tell user about exceeding RAM limits The mpc8544ds board only supports up to 3GB of RAM due to its limited address space. When the user requests more, abort and tell him that he should use less. Signed-off-by: Alexander Graf <[email protected]>
44045ce9740945056a58ecb53d2af9ae00083632
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/44045ce9740945056a58ecb53d2af9ae00083632
2015-01-07 16:16:24+01:00
cpu-exec: reset exception_index correctly Exception index is reset at every entry at every entry into cpu_exec() function. This may cause missing the exceptions while replaying them. This patch moves exception_index reset to the locations where they are processed. Signed-off-by: Pavel Dovgalyuk <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
e511b4d783c47a32420da802104cfb0eb974b22f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e511b4d783c47a32420da802104cfb0eb974b22f
2014-12-15 12:21:02+01:00
cpu: initialize cpu->exception_index on reset This unbreaks linux-user (broken by e511b4d, cpu-exec: reset exception_index correctly, 2014-11-26). Reported-by: Eduardo Habkost <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Tested-by: Laurent Desnogues <[email protected]> Tested-by: Eduardo Habkost <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
f9d8f6673591f30028e281e8ff6d5790adc2de83
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f9d8f6673591f30028e281e8ff6d5790adc2de83
2014-12-20 20:38:07+00:00
target-arm: make VBAR banked When EL3 is running in Aarch32 (or ARMv7 with Security Extensions) VBAR has a secure and a non-secure instance, which are mapped to VBAR_EL1 and VBAR_EL3. Signed-off-by: Fabian Aggeler <[email protected]> Signed-off-by: Greg Bellows <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
fb6c91ba2bb0b1c1b8662ceeeeb9474a025f9a6b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fb6c91ba2bb0b1c1b8662ceeeeb9474a025f9a6b
2014-12-11 12:07:52+00:00
block/raw-posix: Fix preallocating write() loop write() may write less bytes than requested; in this case, the number of bytes written is returned. This is the byte count we should be subtracting from the number of bytes still to be written, and not the byte count we requested to write. Reported-by: László Érsek <[email protected]> Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
39411cf3c316de0fe3cbb9585774bacfe3bd8efd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/39411cf3c316de0fe3cbb9585774bacfe3bd8efd
2014-11-18 12:08:59+01:00
scsi: devirtualize unrealize of SCSI devices All implementations are the same. Signed-off-by: Paolo Bonzini <[email protected]>
fb7b5c0df6e3c501973ce4d57eb2b1d4344a519d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fb7b5c0df6e3c501973ce4d57eb2b1d4344a519d
2014-10-31 11:29:02+01:00
linux-user: Fix fault address truncation AArch64 On AArch64 the si_addr field of siginfo_t is truncated to 32 bits because the fault address passes through an uint32_t variable. Follow Peters suggestion and drop the uint32_t variable since its only used once in the Aarch64 loop. Reported-by: Amanieu d'Antras <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
686581adcfead947b4726d82b1eaf7c25fa597e6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/686581adcfead947b4726d82b1eaf7c25fa597e6
2014-11-03 11:03:34+02:00
pc: Fix disabling of vapic for compat PC models We used to be able to address both the QEMU and the KVM APIC via "apic". This doesn't work anymore. So we need to use their parent class to turn off the vapic on machines that should not expose them. Signed-off-by: Jan Kiszka <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
df1fd4b541b3ae0dc44843741363d00080775294
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/df1fd4b541b3ae0dc44843741363d00080775294
2014-11-02 11:52:24+02:00
blockdev: check for BLOCK_OP_TYPE_INTERNAL_SNAPSHOT The BLOCK_OP_TYPE_INTERNAL_SNAPSHOT op blocker exists but was never used! Let's fix that so internal snapshots can be blocked. [Fixed s/external/internal/ typo as pointed out by Paolo Bonzini and Max Reitz. --Stefan] Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Max Reitz <[email protected]> Message-id: [email protected] Signed-off-by: Kevin Wolf <[email protected]>
3dc7ca3c97dff8732e38828b38e0497efba0fedf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3dc7ca3c97dff8732e38828b38e0497efba0fedf
2014-12-10 10:31:13+01:00
tests: virtio-scsi: Check if hot-plug/unplug works Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
ac2c4946ccc62e0c3eabd93206134f9e98db75c9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ac2c4946ccc62e0c3eabd93206134f9e98db75c9
2014-10-15 05:03:12+02:00
hw/arm/virt: mark timer in fdt as v8-compatible check if the first cpu is an armv8 cpu, and if so, put arm,armv8-timer in the compatible string list. Note that due to this check, this patch moves the creation of the timer fdt node to after the cpu creation loop. Signed-off-by: Claudio Fontana <[email protected]> Message-id: [email protected] [PMM: updated to list arm,armv8-timer first] Signed-off-by: Peter Maydell <[email protected]>
b32a950910bc03f2c012794b3215fc2de8f90de3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b32a950910bc03f2c012794b3215fc2de8f90de3
2014-10-24 12:19:11+01:00
qcow2: Use sizeof(**refcount_table) When implementing variable refcounts, we want to be able to easily find all the places in qemu which are tied to a certain refcount order. Replace sizeof(uint16_t) in the check code by sizeof(**refcount_table) so we can later find it more easily. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
78fb328e854542d79bebe54f3a426cba6d46dbf1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/78fb328e854542d79bebe54f3a426cba6d46dbf1
2014-10-23 15:34:01+02:00
qapi: Ignore files created during make check After an in-tree build and run of 'make check-{qapi-schema,unit}', I noticed some leftover files. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Wenchao Xia <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
597db727cc9dfeace19faed49014dbcda8a1a8fd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/597db727cc9dfeace19faed49014dbcda8a1a8fd
2014-09-26 21:18:15+04:00
usb-serial: only check speed once at realize time Whatever the chardev is open or not, we should assure the speed is matched each other. So, call usb_check_attach() check speed. And then pass &error_abort at all calls to usb_device_attach(). Signed-off-by: Gonglei <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
7334d6507a7578152bb7addcef84e4cf634814a4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7334d6507a7578152bb7addcef84e4cf634814a4
2014-09-23 12:51:08+02:00
usb-bus: introduce a wrapper function to check speed In this way, we can check speed directly, don't need call usb_device_attach(), which has other conditions, such as checking the chardev is open. Signed-off-by: Gonglei <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
594a53607e5bd4a2b7555a7a2908d2c406fea9aa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/594a53607e5bd4a2b7555a7a2908d2c406fea9aa
2014-09-23 12:51:08+02:00
docs: add blkdebug block driver documentation The blkdebug block driver is undocumented. Documenting it is worthwhile since it offers powerful error injection features that are used by qemu-iotests test cases. This document will make it easier for people to learn about and use blkdebug. Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
f9d7b4b3b4249336be665180a1aea7ce5497d2ca
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f9d7b4b3b4249336be665180a1aea7ce5497d2ca
2014-09-25 15:24:14+02:00
hw: Convert from BlockDriverState to BlockBackend, mostly Device models should access their block backends only through the block-backend.h API. Convert them, and drop direct includes of inappropriate headers. Just four uses of BlockDriverState are left: * The Xen paravirtual block device backend (xen_disk.c) opens images itself when set up via xenbus, bypassing blockdev.c. I figure it should go through qmp_blockdev_add() instead. * Device model "usb-storage" prompts for keys. No other device model does, and this one probably shouldn't do it, either. * ide_issue_trim_cb() uses bdrv_aio_discard() instead of blk_aio_discard() because it fishes its backend out of a BlockAIOCB, which has only the BlockDriverState. * PC87312State has an unused BlockDriverState[] member. The next two commits take care of the latter two. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
4be746345f13e99e468c60acbd3a355e8183e3ce
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4be746345f13e99e468c60acbd3a355e8183e3ce
2014-10-20 14:02:25+02:00
qcow2: Add overlap-check.template option Being able to set the overlap-check option to a string and then refine it via the overlap-check.* options is a nice idea for the command line but does not work so well for non-flattened dicts. In that case, one can only specify either but not both, so add a field to overlap-check.* which does the same as directly specifying overlap-check but can be used in conjunction with the other fields in non-flattened dicts. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
ee42b5ce0b33986970f5c2fd4b676cddc0d6306c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ee42b5ce0b33986970f5c2fd4b676cddc0d6306c
2014-09-22 11:39:34+01:00
scsi-bus: Convert DeviceClass init to realize Replace "init/destroy" with "realize/unrealize" in SCSIDeviceClass, which has errp as a parameter. So all the implementations now use error_setg instead of error_report for reporting error. Also in scsi_bus_legacy_handle_cmdline, report the error when initializing the if=scsi devices, before returning it, because in the callee, error_report is changed to error_setg. And the callers don't have the right locations (e.g. "-drive if=scsi"). Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
a818a4b69d47ca3826dee36878074395aeac2083
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a818a4b69d47ca3826dee36878074395aeac2083
2014-08-26 13:20:44+02:00
curl: Don't deref NULL pointer in call to aio_poll. In commit 63f0f45f2e89b60ff8245fec81328ddfde42a303 the following mechanical change was made: if (!state) { - qemu_aio_wait(); + aio_poll(state->s->aio_context, true); } The new code now checks if state is NULL and then dereferences it ('state->s') which is obviously incorrect. This commit replaces state->s->aio_context with bdrv_get_aio_context(bs), fixing this problem. The two other hunks are concerned with getting the BlockDriverState pointer bs to where it is needed. The original bug causes a segfault when using libguestfs to access a VMware vCenter Server and doing any kind of complex read-heavy operations. With this commit the segfault goes away. Signed-off-by: Richard W.M. Jones <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Reviewed-by: Benoît Canet <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
a2f468e48f8b6559ec9123e94948bc373b788941
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a2f468e48f8b6559ec9123e94948bc373b788941
2014-08-29 16:19:01+01:00
qemu-img: always goto out in img_snapshot() error paths The out label has the qemu_progress_end() and other cleanup calls. Always goto out in error paths so the cleanup happens. These error paths now return 1 instead of -1. Note that bdrv_unref(NULL) is safe. We just need to initialize bs to NULL at the top of the function. We can now remove the obsolete bs_old_backing = NULL and bs_new_backing = NULL for safe mode. Originally it was necessary in commit 3e85c6fd ("qemu-img rebase") but became useless in commit c2abcce ("qemu-img: avoid calling exit(1) to release resources properly") because the variables are already initialized during declaration. Reported-by: John Snow <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Max Reitz <[email protected]>
40ed35a3c4f7d26247cbbb01a2b3ff544fb50819
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/40ed35a3c4f7d26247cbbb01a2b3ff544fb50819
2014-08-29 10:46:57+01:00
prep: Remove CPU reset entry point hack related to OpenHack'Ware Signed-off-by: Hervé Poussineau <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
56de2e52693aac6ce2cfbf80a8be6ae75660f58c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/56de2e52693aac6ce2cfbf80a8be6ae75660f58c
2014-07-07 16:46:35+02:00
xen: build on ARM Collection of fixes to build QEMU with Xen support on ARM: - use xenstore_read_fe_uint64 to retrieve the page-ref (xenfb); - use xen_pfn_t instead of unsigned long in xenfb; - unsigned long/xenpfn_t in xen_remove_from_physmap; - in xen-mapcache.c use HOST_LONG_BITS to check for QEMU's address space size. Signed-off-by: Stefano Stabellini <[email protected]> Reviewed-by: Peter Maydell <[email protected]>
643f59322432d77165329dfabe2d040d7e30dae8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/643f59322432d77165329dfabe2d040d7e30dae8
2014-07-07 10:37:40+00:00
Enforce stack protector usage If --enable-stack-protector is used is used, configure script try to use --fstack-protector-strong. In case it's not supported, --fstack-protector-all is enabled. If both protectors are not supported, configure does not use any protector at all without any notification. This patch reports error when user requests stack protector to be used and both protector modes are not supported. Behavior is not changed in case user do not use any of --enable-stack-protector/--disable-stack-protector. Signed-off-by: Miroslav Rezanina <[email protected]> [Fix non-POSIX operator in test. - Paolo] Signed-off-by: Paolo Bonzini <[email protected]>
3b463a3fa8f7690ffa3ef273993dff349b3a73d3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3b463a3fa8f7690ffa3ef273993dff349b3a73d3
2014-07-10 17:06:29+02:00
pc-bios/s390-ccw: make checkpatch happy Remove tabs, tweak whitespace and comments. Acked-by: Christian Borntraeger <[email protected]> Signed-off-by: Eugene (jno) Dvurechenski <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
abd696e4f74a9d30801c6ae2693efe4e5979c2f2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/abd696e4f74a9d30801c6ae2693efe4e5979c2f2
2014-06-27 11:57:25+02:00
tests: vmstate static checker: remove Description inside Fields Signed-off-by: Amit Shah <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
b5968f0ab399002cae2fddbc24c6a89cee90ebd3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b5968f0ab399002cae2fddbc24c6a89cee90ebd3
2014-06-23 19:14:52+02:00
ui/cocoa: Add utility method to check if point is within window Add a utility method to check whether a point is within the current window bounds, and use it in the various places in the mouse handling code that were opencoding the check. Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected]
5dd45bee5816ef1e941fdf1122943e4ab345f388
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5dd45bee5816ef1e941fdf1122943e4ab345f388
2014-06-29 22:00:33+01:00
iotests: Simplify qemu-iotests-quick.sh As of the "iotests: Allow out-of-tree run" series, the qemu-iotests may (and should) be run directly in the build tree and will then guess the binary paths themselves. Therefore, qemu-iotests-quick.sh does not need to (and should not) enter the source path anymore; also, it does not need to specify the binaries because "check" will guess them automatically. As a side-effect, tests using qemu may now be added to the quick group. Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
214a081a0dd44e69f7db4a741880a8ae9d174fa2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/214a081a0dd44e69f7db4a741880a8ae9d174fa2
2014-07-01 10:15:33+02:00
tests: vmstate static checker: remove Fields Signed-off-by: Amit Shah <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
083bac3484e335130235ca0369e840a9ee766c4f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/083bac3484e335130235ca0369e840a9ee766c4f
2014-06-23 19:14:52+02:00
target-ppc: Enable DABRX SPR and limit it to <=POWER7 This adds DABRX SPR. As DABR(X) are present in POWER CPUs till POWER7 only and POWER8 does not have them (as it implements more powerful facility instead), this limits DABR/DABRX registration by POWER7 (inclusive). Signed-off-by: Alexey Kardashevskiy <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
cd9adfdd7755f053aea1ffc8e1df7b9b022174ff
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cd9adfdd7755f053aea1ffc8e1df7b9b022174ff
2014-06-16 13:24:45+02:00
QemuOpts: check NULL input for qemu_opts_del To simplify later using of qemu_opts_del, accept NULL input. Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Leandro Dorileo <[email protected]> Signed-off-by: Chunyan Liu <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
4782183da39ec988b8290bbc0289c9f50ba33ea4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4782183da39ec988b8290bbc0289c9f50ba33ea4
2014-06-16 17:23:20+08:00
target-ppc: Introduce DFP Helper Utilities Add a new file (dfp_helper.c) to the PowerPC implementation for Decimal Floating Point (DFP) emulation. This first version of the file declares a structure that will be used by DFP helpers. It also implements utilities that will initialize such a structure for either a long (64 bit) DFP instruction or an extended (128 bit, aka "quad") instruction. Some utility functions are annotated with the unused attribute in order to preserve build bisection. Signed-off-by: Tom Musta <[email protected]> [agraf: Add never reached assert on dfp_prepare_rounding_mode()] Signed-off-by: Alexander Graf <[email protected]>
7b0c0d66e54868087b6db6a302aba030c0c5f2c3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7b0c0d66e54868087b6db6a302aba030c0c5f2c3
2014-06-16 13:24:29+02:00
spapr: Limit threads per core according to current compatibility mode This puts a limit to the number of threads per core based on the current compatibility mode. Although PowerISA specs do not specify the maximum threads per core number, the linux guest still expects that PowerISA2.05-compatible CPU supports only 2 threads per core as this is what POWER6 (2.05 compliant CPU) implements, the same is for POWER7 (2.06, 4 threads) and POWER8 (2.07, 8 threads). This calls spapr_fixup_cpu_smt_dt() with the maximum allowed number of threads which affects ibm,ppc-interrupt-server#s and ibm,ppc-interrupt-gserver#s properties. The number of CPU nodesremains unchanged. Signed-off-by: Alexey Kardashevskiy <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
2a48d99335c572b0d3da59c1387ad131ea6ee590
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2a48d99335c572b0d3da59c1387ad131ea6ee590
2014-06-16 13:24:38+02:00
xhci: child detach fix xhci_child_detach() zaps the wrong slot when unplugging a device connected via usb-hub: Instead of the device's slot the slot of the usb-hub is used. Fix it. https://bugzilla.redhat.com/show_bug.cgi?id=1075846 Signed-off-by: Gerd Hoffmann <[email protected]> Reviewed-by: Gonglei <[email protected]>
463c534db516701ac732ac606c33c7101cf22e56
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/463c534db516701ac732ac606c33c7101cf22e56
2014-05-26 08:41:07+02:00
qemu-img: Report error even with --oformat=json img_check() should report that the format of the given image does not support checks even if JSON output is desired. JSON data is output to stdout, as opposed to error messages, which are (in the case of qemu-img) printed to stderr. Therefore, it is easy to distinguish between the two. Also, img_info() does already use error_report() for human-readable messages even though JSON output is desired (through collect_image_info_list()). Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
55d492d7602c27cabb605f42e72c755de1c186c1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/55d492d7602c27cabb605f42e72c755de1c186c1
2014-06-02 13:58:40+02:00
block: Add backing_blocker in BlockDriverState This makes use of op_blocker and blocks all the operations except for commit target, on each BlockDriverState->backing_hd. The asserts for op_blocker in bdrv_swap are removed because with this change, the target of block commit has at least the backing blocker of its child, so the assertion is not true. Callers should do their check. Signed-off-by: Fam Zheng <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]>
826b6ca0b0c00bf27562a85bc073f800dad1259b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/826b6ca0b0c00bf27562a85bc073f800dad1259b
2014-05-28 14:28:46+02:00
libcacard/vcard_emul_nss: Drop a redundant conditional Bailing out when PK11_FindGenericObjects() returns null ensures the loop that follows it executes at least once. The "loop did not execute" test right after it is useless. Drop it. Spotted by Coverity. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Alon Levy <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
42119fa3568dc7e8c82447c861678a5987d06d91
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/42119fa3568dc7e8c82447c861678a5987d06d91
2014-05-24 00:46:37+04:00
migration: expose xbzrle cache miss rate expose xbzrle cache miss rate Signed-off-by: ChenLiang <[email protected]> Signed-off-by: Gonglei <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
8bc3923343e91902ca541112b3bdb5448f8d288e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8bc3923343e91902ca541112b3bdb5448f8d288e
2014-05-05 22:15:03+02:00
iohandler.c: Properly initialize sigaction struct The code in qemu_init_child_watch() wasn't clearing the 'struct sigaction' before passing it to sigaction(); this meant that we would block a random set of signals while executing the SIGCHLD handler. Initialize properly by using memset() on the struct, as we do in similar cases elsewhere. Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
aef553fdcabbea8760cd4647ab14859095300023
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/aef553fdcabbea8760cd4647ab14859095300023
2014-05-24 00:07:29+04:00
savevm: Remove all the unneeded version_minimum_id_old (usb) After previous Peter patch, they are redundant. This way we don't assign them except when needed. Once there, there were lots of case where the ".fields" indentation was wrong: .fields = (VMStateField []) { and .fields = (VMStateField []) { Change all the combinations to: .fields = (VMStateField[]){ The biggest problem (appart from aesthetics) was that checkpatch complained when we copy&pasted the code from one place to another. Signed-off-by: Juan Quintela <[email protected]> Acked-by: Gerd Hoffmann <[email protected]>
6e3d652ab204c6f8f1846639bca802fb9c8a9a6d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6e3d652ab204c6f8f1846639bca802fb9c8a9a6d
2014-05-14 15:24:51+02:00
tcg-aarch64: Use MOVN in tcg_out_movi When profitable, initialize the register with MOVN instead of MOVZ, before setting the remaining lanes with MOVK. Reviewed-by: Claudio Fontana <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
dfeb5fe7700d5e29a276f571aee7f6fc4267ee96
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dfeb5fe7700d5e29a276f571aee7f6fc4267ee96
2014-04-16 12:12:58-04:00
Fix vga_interface_type for command line argument '-device VGA' Some machine (like pseries) initialization code determines if it has graphics according to vga_interface_type. In the original code, vga_interface_type is evaluated to VGA_NONE even if a VGA is added via '-device VGA'. It causes the machine not aware of the graphics device configured. Add a new VGA device type to indicate that it has a VGA device, which will be initialized in QOM device initialization. Suggested-by: Paolo Bonzini <[email protected]> Signed-off-by: Mark Wu <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
d44229c54f7477035c7e914dd12c84e01bbd4123
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d44229c54f7477035c7e914dd12c84e01bbd4123
2014-03-13 20:53:19+01:00
target-mips: fix MTHC1 and MFHC1 when FPU in FR=0 mode Previous implementation presumed that FPU registers are 64-bit and are working in 64-bit mode. This change first checks MIPS_HFLAG_F64 and if not set, it does load/store from the odd numbered register pair. Patch by Matthew Fortune. Signed-off-by: Matthew Fortune <[email protected]> Signed-off-by: Petar Jovanovic <[email protected]> Signed-off-by: Aurelien Jarno <[email protected]>
7f6613cedc59fa849105668ae971dc31004bca1c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7f6613cedc59fa849105668ae971dc31004bca1c
2014-03-25 23:36:35+01:00
spapr: Fix return value of vga initialization Before spapr_vga_init will returned false if the vga is specified by the command '-device VGA' because vga_interface_type was evaluated to VGA_NONE. With the change in previous patch of this series, spapr_vga_init should return true if it's told that the vga will be initialized in flow of the generic devices initialization. To keep '-nodefaults' have the semantics of bare minimum, it adds a check of 'has_defaults' in usb_enabled() to avoid that a USB controller is added by '-nodefautls, -device VGA' implicitly. This patch also makes two cleanups: 1. skip initialization for VGA_NONE 2. remove the useless 'break' Suggested-by: Paolo Bonzini <[email protected]> Signed-off-by: Mark Wu <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Andreas Färber <[email protected]>
7effdaa32198b7077c51e29621dfca3d1b14e420
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7effdaa32198b7077c51e29621dfca3d1b14e420
2014-03-13 20:53:28+01:00
target-ppc: VSX Stage 4: Add xssqrtsp This patch adds the VSX Scalar Square Root Single Precision (xssqrtsp) instruction. The existing VSX_SQRT() macro is modified to support rounding of the intermediate double-precision result to single-precision. Signed-off-by: Tom Musta <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
cea4e57473efc2fad1d241e87984eba4e5d9690c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cea4e57473efc2fad1d241e87984eba4e5d9690c
2014-03-05 03:06:35+01:00
iothread: add I/O thread object This is a stand-in for Michael Roth's QContext. I expect this to be replaced once QContext is completed. The IOThread object is an AioContext event loop thread. This patch adds the concept of multiple event loop threads, allowing users to define them. When SMP guests run on SMP hosts it makes sense to instantiate multiple IOThreads. This spreads event loop processing across multiple cores. Note that additional patches are required to actually bind a device to an IOThread. [Andreas Färber <[email protected]> pointed out that the embedded parent object instance should be called "parent_obj" and have a newline afterwards. This patch has been changed to reflect this. -- Stefan] Signed-off-by: Stefan Hajnoczi <[email protected]>
be8d8537668c9be7a8dee6aed94b2b3f9fcd4a9f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/be8d8537668c9be7a8dee6aed94b2b3f9fcd4a9f
2014-03-13 14:42:24+01:00
target-ppc: VSX Stage 4: Add Scalar SP Fused Multiply-Adds This patch adds the Single Precision VSX Scalar Fused Multiply-Add instructions: xsmaddasp, xsmaddmsp, xssubasp, xssubmsp, xsnmaddasp, xsnmaddmsp, xsnmsubasp, xsnmsubmsp. The existing VSX_MADD() macro is modified to support rounding of the intermediate double precision result to single precision. Signed-off-by: Tom Musta <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
f53f81e08bd0192121c4e0c3f1fdc53832631b4b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f53f81e08bd0192121c4e0c3f1fdc53832631b4b
2014-03-05 03:06:36+01:00
qapi script: check correctness of union Since line info is remembered as QAPISchema.line now, this patch uses it as additional info for every expr in QAPISchema inside qapi.py, then improves error message with it in checking of exprs. For common union the patch will check whether base is a valid complex type if specified. For flat union it will check whether base presents, whether discriminator is found in base, whether the key of every branch is correct when discriminator is an enum type. Signed-off-by: Wenchao Xia <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
b86b05ed60d8d49c5770851860d4e6b89c133e7e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b86b05ed60d8d49c5770851860d4e6b89c133e7e
2014-03-11 09:07:41-04:00
target-ppc: VSX Stage 4: Add xsaddsp and xssubsp This patch adds the VSX Scalar Add Single-Precision (xsaddsp) and VSX Scalar Subtract Single-Precision (xssubsp) instructions. The existing VSX_ADD_SUB macro is modified to support the rounding of the (intermediate) result to single-precision. Signed-off-by: Tom Musta <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
3fd0aadfc19ba146ed6ced27b4e6ff6afc08473a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3fd0aadfc19ba146ed6ced27b4e6ff6afc08473a
2014-03-05 03:06:34+01:00
Add check for cache size smaller than page size Signed-off-by: Orit Wasserman <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
c91e681a558fc21073ffc491b5a022d5f340fa0b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c91e681a558fc21073ffc491b5a022d5f340fa0b
2014-02-04 16:49:24+01:00
target-arm: A64: Add SIMD across-lanes instructions Add support for the SIMD "across lanes" instruction group (C3.6.4). Signed-off-by: Michael Matz <[email protected]> [PMM: Updated to current codebase, added fp min/max ops, added unallocated encoding checks] Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
4a0ff1ce73a9e06ecb655019820229de74244432
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4a0ff1ce73a9e06ecb655019820229de74244432
2014-01-31 14:47:31+00:00
sheepdog: fix 'qemu-img map' It was muted in the previous commit 4bc74be9. Let's revive it since nothing prevents us to do it. With this patch, following command will work as other formats: $ qemu-img map sheepdog:image Cc: [email protected] Cc: Kevin Wolf <[email protected]> Cc: Stefan Hajnoczi <[email protected]> Signed-off-by: Liu Yuan <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
9cd767376f137918dbe90abb452dfe119ae7d8f3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9cd767376f137918dbe90abb452dfe119ae7d8f3
2014-01-24 14:33:00+01:00
rng: initialize file descriptor to -1 The file descriptor is never initialized to -1, which makes rng-random close stdin if an object is created and immediately destroyed. If we change it to -1, we also need to protect qemu_set_fd_handler from receiving a bogus file descriptor. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Igor Mammedov <[email protected]> Tested-by: Igor Mammedov <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
513b8c74c4c899cd940a79131e76c5568aa11381
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/513b8c74c4c899cd940a79131e76c5568aa11381
2014-01-06 13:45:46-05:00
vfio: Filter out bogus mappings Since 57271d63 we now see spurious mappings with the upper bits set if 64bit PCI BARs are sized while enabled. The guest writes a mask of 0xffffffff to the lower BAR to size it, then restores it, then writes the same mask to the upper BAR resulting in a spurious BAR mapping into the last 4G of the 64bit address space. Most architectures do not support or make use of the full 64bits address space for PCI BARs, so we filter out mappings with the high bit set. Long term, we probably need to think about vfio telling us the address width limitations of the IOMMU. Signed-off-by: Alex Williamson <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]>
d3a2fd9b29e43e202315d5e99399b99622469c4a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d3a2fd9b29e43e202315d5e99399b99622469c4a
2014-01-16 09:22:07-07:00
softfloat: Add float to 16bit integer conversions. ARMv8 requires support for converting 32 and 64bit floating point values to signed and unsigned 16bit integers. Signed-off-by: Will Newton <[email protected]> [PMM: updated not to incorrectly set Inexact for Invalid inputs] Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
f581bf5474d2319ca37484eb63208017ac96ce0a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f581bf5474d2319ca37484eb63208017ac96ce0a
2014-01-08 19:07:22+00:00
ui/cocoa: Redraw at correct size when switching surface If the surface switch involved a resize, we were doing the redraw at the old size rather than the new, because the update of screen.width and screen.height was being done after the setFrame method calls which triggered a redraw. Normally this isn't very noticeable because typically after the guest triggers the window resize it also draws something to it, which will in turn cause us to redraw. However, the combination of a guest which never draws to the display and a command line setting of a screen size larger than the default can reveal odd effects. Move most of the handling of resizes to the top of the method, and guard it with a check that the surface size actually changed, to avoid unnecessary operations (including some user visible ones like "recenter the window on the screen") if the surface is the same size as the old one. Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected]
d3345a04849374af2b21d6624dd206c4444a6ffe
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d3345a04849374af2b21d6624dd206c4444a6ffe
2014-01-12 22:27:10+00:00