commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
target/xtensa: fix ICACHE/DCACHE options detection Configuration overlay does not explicitly say whether there are ICACHE and DCACHE in the core. Current code uses XCHAL_[ID]CACHE_WAYS to detect if corresponding cache option is enabled, but that's not correct: on cores without cache these macros are defined as 1, not as 0. Check XCHAL_[ID]CACHE_SIZE instead. Signed-off-by: Max Filippov <[email protected]>
4b37aaa879d508494df14bdc49830cdf8aa77a57
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4b37aaa879d508494df14bdc49830cdf8aa77a57
2017-01-15 13:01:56-08:00
tcg/i386: Allow bmi2 shiftx to have non-matching operands Previously we could not have different constraints for different ISA levels, which prevented us from eliding the matching constraint for shifts. We do now have to make sure that the operands match for constant shifts. We can also handle some small left shifts via lea. Signed-off-by: Richard Henderson <[email protected]>
6a5aed4bdc7078838a8098336588d56c9ce09d1d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6a5aed4bdc7078838a8098336588d56c9ce09d1d
2017-01-10 08:47:48-08:00
HACKING: document #include order It was not obvious to me why "qemu/osdep.h" must be the first #include. This documents the rationale and the overall #include order. Cc: Fam Zheng <[email protected]> Cc: Markus Armbruster <[email protected]> Cc: Eric Blake <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
0891ee111217101bce683e30ed9f08cf0cfcffd7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0891ee111217101bce683e30ed9f08cf0cfcffd7
2017-01-03 16:38:47+00:00
virtio-net: enable ioeventfd even if vhost=off virtio-net-pci does not enable ioeventfd for historical reasons (and nobody ever checked whether it should be revisited). Note that other backends do enable ioeventfd for virtio-net. However, it has a major effect on performance. On Windows, throughput is _multiplied_ by 2 or 3 on TCP_STREAM (on small packets it is "only" a 30% improvement) and a little less so on TCP_MAERTS albeit still very much statistically significant. Latency also has a single digit improvement. This is not visible when using vhost, which forces ioeventfd=on, but it is substantial without vhost. In addition, also on Windows and with the RHEL 7.3 kernel, APICv seems to slow down virtio-net performance a bit, but the penalty with this patch goes from -25% to -7%. Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
4a3f03ba8dbf53fce36d0c1dd5d0cc0f340fe5f3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4a3f03ba8dbf53fce36d0c1dd5d0cc0f340fe5f3
2017-01-18 22:59:53+02:00
hw/ptimer: Suppress error messages under qtest Under qtest ptimer emits lots of warning messages. The messages are caused by the actual checking of the ptimer error conditions. Suppress those messages, so they do not distract. Signed-off-by: Dmitry Osipenko <[email protected]> Message-id: 44877fff4ff03205590698d3dc189ad6d091472f.1473252818.git.digetx@gmail.com Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
2a8b58703e2144c136f6d26f609c6a338a03a3ca
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2a8b58703e2144c136f6d26f609c6a338a03a3ca
2016-09-22 18:13:07+01:00
megasas: do not call pci_dma_unmap after having freed the frame once Commit 8cc4678 ("megasas: remove useless check for cmd->frame", 2016-07-17) was wrong because I trusted Coverity too much. It turns out that there _is_ a path through which cmd->frame can become NULL. After megasas_handle_frame's switch (md->frame->header.frame_cmd), megasas_init_firmware can be called. From there, megasas_reset_frames will call megasas_unmap_frame which resets cmd->frame = NULL. However, there is another bug to fix in there, because megasas_unmap_frame is called again after setting the command status. In this case QEMU should not do anything, instead it calls pci_dma_unmap again. Harmless, but better fix it. Signed-off-by: Paolo Bonzini <[email protected]>
75f19f8c3006970632303b49043b075dc4fe922e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/75f19f8c3006970632303b49043b075dc4fe922e
2016-11-28 15:11:17+01:00
test-qga: Avoid qobject_from_jsonv("%"PRId64) The qobject_from_jsonv() function implements a pseudo-printf language for creating a QObject; however, it is hard-coded to only parse a subset of formats understood by -Wformat, and is not a straight synonym to bare printf(). In particular, any use of an int64_t integer works only if the system's definition of PRId64 matches what the parser expects; which works on glibc (%lld or %ld depending on 32- vs. 64-bit) and mingw (%I64d), but not on Mac OS (%qd). Rather than enhance the parser, it is just as easy to use normal printf() for this particular conversion, matching what is done elsewhere in this file [1], which is safe in this instance because the format does not contain any of the problematic differences (bare '%' or the '%s' format). The use of PRId64 for a variable named 'pid' is gross, but it is a sad reality of the 64-bit mingw environment, which mistakenly defines pid_t as a 64-bit type even though getpid() returns 'int' on that platform [2]. Our definition of the QGA GuestExec type defines 'pid' as a 64-bit entity, and we can't tighten it to 'int32' unless the mingw header is fixed. Using 'long long' instead of 'int64_t' just so that we can stick with qobject_from_jsonv("%lld") instead of printf() is not any prettier, since we may have later type churn anyways. [1] see 'git grep -A2 strdup_printf tests/test-qga.c' [2] https://bugzilla.redhat.com/show_bug.cgi?id=1397787 Reported by: G 3 <[email protected]> Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
1792d7d0a2dc18496e8fc52906163f9f73f3d931
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1792d7d0a2dc18496e8fc52906163f9f73f3d931
2016-12-05 17:09:34+01:00
nbd: Treat flags vs. command type as separate fields Current upstream NBD documents that requests have a 16-bit flags, followed by a 16-bit type integer; although older versions mentioned only a 32-bit field with masking to find flags. Since the protocol is in network order (big-endian over the wire), the ABI is unchanged; but dealing with the flags as a separate field rather than masking will make it easier to add support for upcoming NBD extensions that increase the number of both flags and commands. Improve some comments in nbd.h based on the current upstream NBD protocol (https://github.com/yoe/nbd/blob/master/doc/proto.md), and touch some nearby code to keep checkpatch.pl happy. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
b626b51a6721e53817155af720243f59072e424f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b626b51a6721e53817155af720243f59072e424f
2016-11-02 09:28:55+01:00
ivshmem: Fix 64 bit memory bar configuration Device ivshmem property use64=0 is designed to make the device expose a 32 bit shared memory BAR instead of 64 bit one. The default is a 64 bit BAR, except pc-1.2 and older retain a 32 bit BAR. A 32 bit BAR can support only up to 1 GiB of shared memory. This worked as designed until commit 5400c02 accidentally flipped its sense: since then, we misinterpret use64=0 as use64=1 and vice versa. Worse, the default got flipped as well. Devices ivshmem-plain and ivshmem-doorbell are not affected. Fix by restoring the test of IVShmemState member not_legacy_32bit that got messed up in commit 5400c02. Also update its initialization for devices ivhsmem-plain and ivshmem-doorbell. Without that, they'd regress to 32 bit BARs. Signed-off-by: Zhuang Yanying <[email protected]> Reviewed-by: Gonglei <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]>
b2b79a696052040389e0f9980801a880ce5a6ae3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b2b79a696052040389e0f9980801a880ce5a6ae3
2016-11-17 18:39:59+04:00
checkpatch: tweak "struct should normally be const" warning Avoid triggering on typedef struct BlockJobDriver BlockJobDriver; or struct BlockJobDriver { Cc: John Snow <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
e20e718cdea2527ce560a03c5d8cd248decb537a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e20e718cdea2527ce560a03c5d8cd248decb537a
2016-11-01 16:06:57+01:00
tests: enable virtio tests on SPAPR but disable MSI-X tests on SPAPR as we can't check the result (the memory region used on PC is not readable on SPAPR). Signed-off-by: Laurent Vivier <[email protected]> Signed-off-by: David Gibson <[email protected]>
30ca440eec9fe1d7eec5a48addac656438778278
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/30ca440eec9fe1d7eec5a48addac656438778278
2016-10-28 09:36:58+11:00
migration: Switch to COLO process after finishing loadvm Switch from normal migration loadvm process into COLO checkpoint process if COLO mode is enabled. We add three new members to struct MigrationIncomingState, 'have_colo_incoming_thread' and 'colo_incoming_thread' record the COLO related thread for secondary VM, 'migration_incoming_co' records the original migration incoming coroutine. Signed-off-by: zhanghailiang <[email protected]> Signed-off-by: Li Zhijian <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Amit Shah <[email protected]> Signed-off-by: Amit Shah <[email protected]>
25d0c16f625feb3b6b9bf8079388cdd314e63916
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/25d0c16f625feb3b6b9bf8079388cdd314e63916
2016-10-30 15:17:39+05:30
char: make some qemu_chr_fe skip if no driver In most cases, front ends do not care about the side effect of CharBackend, so we can simply skip the checks and call the qemu_chr_fe functions even without associated CharDriver. Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
fa394ed625731c18f904578903718bf16617fe92
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fa394ed625731c18f904578903718bf16617fe92
2016-10-24 15:27:21+02:00
fdc: Move qdev properties to FloppyDrive This makes the FloppyDrive qdev object actually useful: Now that it has all properties that don't belong to the controller, you can actually use '-device floppy' and get a working result. Command line semantics is consistent with CD-ROM drives: By default you get a single empty floppy drive. You can override it with -drive and using the same index, but if you use -drive to add a floppy to a different index, you get both of them. However, as soon as you use any '-device floppy', even to a different slot, the default drive is disabled. Using '-device floppy' without specifying the unit will choose the first free slot on the controller. Signed-off-by: Kevin Wolf <[email protected]> Message-id: [email protected] Signed-off-by: John Snow <[email protected]>
a92bd191a41a432ea610d3a03add7474f21fa7d8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a92bd191a41a432ea610d3a03add7474f21fa7d8
2016-10-27 16:29:13-04:00
aspeed: add support for the SMC segment registers The SMC controller on the Aspeed SoC has a set of registers to configure the mapping of each flash module in the SoC address space. Writing to these registers triggers a remap of the memory region and the spec requires a certain number of checks before doing so. Signed-off-by: Cédric Le Goater <[email protected]> Reviewed-by: Andrew Jeffery <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
a03cb1daf1a4e6ccce8632e13373eef8c4f9cba4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a03cb1daf1a4e6ccce8632e13373eef8c4f9cba4
2016-10-17 19:22:17+01:00
qht: simplify qht_reset_size Sometimes gcc doesn't pick up the fact that 'new' is properly set if 'resize == true', which may generate an unnecessary build warning. Fix it by removing 'resize' and directly checking that 'new' is non-NULL. Signed-off-by: Emilio G. Cota <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
f555a9d0b3c785b698f32e6879e97d0a4b387314
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f555a9d0b3c785b698f32e6879e97d0a4b387314
2016-10-06 18:04:13+02:00
ps2: correctly handle 'get/set scancode' command When getting scancode, current scancode must be preceded from reply ack. When setting scancode, we must reject invalid scancodes. Signed-off-by: Hervé Poussineau <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
4df23b64c51cc830d19eb29801070d31aa1e81cd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4df23b64c51cc830d19eb29801070d31aa1e81cd
2016-09-28 14:03:18+02:00
xhci: use linked list for transfers xhci has a fixed number of 24 (TD_QUEUE) XHCITransfer structs per endpoint, which turns out to be a problem for usb3 devices with 32 (or more) bulk streams. xhci re-checks the trb rings on every finished transfer to make sure it'll pick up any pending work. But that scheme breaks in case the first transfer of a ring can't be started because we ran out of XHCITransfer structs already. So remove static XHCITransfer array from XHCIEPContext. Use a linked list instead, and allocate/free XHCITransfer as needed. Add helper functions to allocate & initialize and to cleanup & release XHCITransfer structs. That also simplifies trb management, we never have to realloc XHCITransfer->trbs because we don't reuse XHCITransfer structs any more. New dynamic limit for in-flight xhci transfers per endpoint is number-of-streams + 16. Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected]
94b037f2a451b3dc855f9f2c346e5049a361bd55
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/94b037f2a451b3dc855f9f2c346e5049a361bd55
2016-10-12 12:37:31+02:00
intel_iommu, amd_iommu: allow UNMAP notifiers x86 vIOMMUs still lack of a complete IOMMU notifier mechanism. Before that is achieved, let's open a door for vhost DMAR support, which only requires cache invalidations (UNMAP operations). Meanwhile, convert hw_error() to error_report() and exit(1), to make the error messages cleaner and obvious (no CPU registers will be dumped). Reviewed-by: David Gibson <[email protected]> Signed-off-by: Peter Xu <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
a3276f786c84d3410be5bc3a4b3e5036745e5a90
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a3276f786c84d3410be5bc3a4b3e5036745e5a90
2016-09-27 11:57:28+02:00
tests: add RTAS command in the protocol Add a first test to validate the protocol: - rtas/get-time-of-day compares the time from the guest with the time from the host. Signed-off-by: Laurent Vivier <[email protected]> Reviewed-by: Greg Kurz <[email protected]> Signed-off-by: David Gibson <[email protected]>
eeddd59f59626302cdb7db2602140ac9a076dec9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/eeddd59f59626302cdb7db2602140ac9a076dec9
2016-09-23 10:29:40+10:00
block: Don't queue the same BDS twice in bdrv_reopen_queue_child() bdrv_reopen_queue_child() assumes that a BlockDriverState is never added twice to BlockReopenQueue. That's however not the case: commit_start() adds 'base' (and its children) to a new reopen queue, and then 'overlay_bs' (and its children, which include 'base') to the same queue. The effect of this is that the first set of options is ignored and overriden by the second. We fixed this by swapping the order in which both BDSs were added to the queue in 3db2bd5508c86a1605258bc77c9672d93b5c350e. This patch checks if a BDS is already in the reopen queue and keeps its options. Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
5b7ba05fe7313b03712e129a86fa70c2c215e908
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5b7ba05fe7313b03712e129a86fa70c2c215e908
2016-09-23 13:36:10+02:00
tests: add a test to check invalid args Check that invalid args on commands without arguments returns an error. Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]> Reviewed-by: Markus Armbruster <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
4bdadd86718c901fc1a512a7e3e0cbe7518cf277
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4bdadd86718c901fc1a512a7e3e0cbe7518cf277
2016-09-19 17:32:22+02:00
spapr: Introduce sPAPRCPUCoreClass Each spapr cpu core type defines an instance_init routine which just populates the CPU class name. This can be done in the class_init commonly for all core types which simplifies the registration. This is inspired by how PowerNV core types are registered. Certain types of spapr cpu cores ('host' and generic type based on host CPU) are initialized in target-ppc/kvm.c. To convert these type registrations to use class_init, we need to expose spapr_cpu_core_class_init() outside of spapr_cpu_core.c. Commit d11b268e1765 added a generic sPAPR CPU core family type to support cases like POWER8 CPU type on POWER8E host CPU. Switching to class_init would fix such scenarios to use the right CPU thread type instead of defaulting to host-powerpc64-cpu. In an unrelated cleanup, fix a typo in .get_hotplug_handler routine. Signed-off-by: Bharata B Rao <[email protected]> Signed-off-by: David Gibson <[email protected]>
7ebaf7955603cc50988e0eafd5e6074320fefc70
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7ebaf7955603cc50988e0eafd5e6074320fefc70
2016-09-23 12:39:06+10:00
block: Accept node-name for change-backing-file In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts change-backing-file to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the GenericError error class now instead of DeviceNotFound, because this is what qmp_get_root_bs() returns. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Reviewed-by: Max Reitz <[email protected]>
7b5dca3f0215ec6484473631928a36c3eb8da0ef
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7b5dca3f0215ec6484473631928a36c3eb8da0ef
2016-09-05 19:06:47+02:00
block: Accept node-name for drive-mirror In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts drive-mirror to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the GenericError error class now instead of DeviceNotFound, because this is what qmp_get_root_bs() returns. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Max Reitz <[email protected]>
0524e93a3fd7bff5bb4a584c372f2632ab7c0e0f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0524e93a3fd7bff5bb4a584c372f2632ab7c0e0f
2016-09-05 19:06:47+02:00
drive-backup: added support for data compression The idea is simple - backup is "written-once" data. It is written block by block and it is large enough. It would be nice to save storage space and compress it. The patch adds a flag to the qmp/hmp drive-backup command which enables block compression. Compression should be implemented in the format driver to enable this feature. There are some limitations of the format driver to allow compressed writes. We can write data only once. Though for backup this is perfectly fine. These limitations are maintained by the driver and the error will be reported if we are doing something wrong. Signed-off-by: Pavel Butsykin <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Denis V. Lunev <[email protected]> CC: Jeff Cody <[email protected]> CC: Markus Armbruster <[email protected]> CC: Eric Blake <[email protected]> CC: John Snow <[email protected]> CC: Stefan Hajnoczi <[email protected]> CC: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
13b9414b5798539e2dbb87a570d96184fe21edf4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/13b9414b5798539e2dbb87a570d96184fe21edf4
2016-09-05 19:06:48+02:00
checkpatch: tweak the files in which TABs are checked Include Python and shell scripts, and make an exception for Perl scripts we imported from Linux or elsewhere. Acked-by: Cornelia Huck <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
906fb135e4b875465c424cb9b2b47d90265f7897
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/906fb135e4b875465c424cb9b2b47d90265f7897
2016-08-10 11:09:54+02:00
intel_iommu: add SID validation for IR This patch enables SID validation. Invalid interrupts will be dropped. Signed-off-by: Peter Xu <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
ede9c94acf6cd1968de4188c0228b714ab871a86
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ede9c94acf6cd1968de4188c0228b714ab871a86
2016-07-21 20:44:16+03:00
net: fix incorrect access to pointer This is not dereferencing the pointer, and instead checking only the value of the pointer. Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Jason Wang <[email protected]>
2c5e564f4d8309ee0f47029ab461c4c4459f43c4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2c5e564f4d8309ee0f47029ab461c4c4459f43c4
2016-07-18 16:16:49+08:00
megasas: remove useless check for cmd->frame megasas_enqueue_frame always returns with non-NULL cmd->frame. Remove the "else" part as it is dead code. Signed-off-by: Paolo Bonzini <[email protected]>
8cc46787b5b58f01a11c919c7ff939ed009e27fc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8cc46787b5b58f01a11c919c7ff939ed009e27fc
2016-07-17 09:59:21+02:00
ioapic: register IOMMU IEC notifier for ioapic Let IOAPIC the first consumer of x86 IOMMU IEC invalidation notifiers. This is only used for split irqchip case, when vIOMMU receives IR invalidation requests, IOAPIC will be notified to update kernel irq routes. For simplicity, we just update all IOAPIC routes, even if the invalidated entries are not IOAPIC ones. Since now we are creating IOMMUs using "-device" parameter, IOMMU device will be created after IOAPIC. We need to do the registration after machine done by leveraging machine_done notifier. Signed-off-by: Peter Xu <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
e3d9c92507df61608896a579b5b0d7c218d5353e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e3d9c92507df61608896a579b5b0d7c218d5353e
2016-07-21 20:43:49+03:00
pc: Enforce adding CPUs contiguously and removing them in opposite order It will still allow us to use cpu_index as migration instance_id since when CPUs are added contiguously (from the first to the last) and removed in opposite order, cpu_index stays stable and it's reproducible on destination side. While there is work in progress to support migration when there are holes in cpu_index range resulting from out-of-order plug or unplug, this patch is intended as an interim solution until cpu_index usage is cleaned up. As result of this patch it would be possible to plug/unplug CPUs, but in limited order that doesn't break migration. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
4da7faaeb0c7dd3f7f233165d336c878f78fd1eb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4da7faaeb0c7dd3f7f233165d336c878f78fd1eb
2016-07-20 12:02:19-03:00
checkpatch: consider git extended headers valid patches Renames look like this with git-diff(1) when diff.renames = true is set: diff --git a/a b/b similarity index 100% rename from a rename to b This raises the "Does not appear to be a unified-diff format patch" error because checkpatch.pl only considers a diff valid if it contains at least one "@@" hunk. This patch accepts renames and copies too so that checkpatch.pl exits successfully when a diff only renames/copies files. The git diff extended header format is described on the git-diff(1) man page. Reported-by: Colin Lord <[email protected]> Signed-off-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Eric Blake <[email protected]> Message-id: [email protected] Signed-off-by: Stefan Hajnoczi <[email protected]>
f8dccbb63463d72dcf273b583d41810a01feab26
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f8dccbb63463d72dcf273b583d41810a01feab26
2016-07-18 15:10:52+01:00
vnc: make sure we finish disconnect It may happen that vnc connections linger in disconnecting state forever because VncState happens to be in a state where vnc_update_client() exists early and never reaches the vnc_disconnect_finish() call at the bottom of the function. Fix that by doing an additinal check at the start of the function. https://bugzilla.redhat.com/show_bug.cgi?id=1352799 Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected]
5a8be0f73d6f60ff08746377eb09ca459f39deab
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5a8be0f73d6f60ff08746377eb09ca459f39deab
2016-07-15 12:00:06+02:00
hw/mips/cps: create GIC block inside CPS Add GIC to CPS and expose its interrupt pins instead of CPU's. Signed-off-by: Leon Alrae <[email protected]>
19494f811a43c6bc226aa272d86300d9229224fe
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/19494f811a43c6bc226aa272d86300d9229224fe
2016-07-12 09:10:13+01:00
target-mips: add exception base to MIPS CPU Replace hardcoded 0xbfc00000 with exception_base which is initialized with this default address so there is no functional change here. However, it is now exposed and consequently it will be possible to modify it from outside of the CPU. Signed-off-by: Leon Alrae <[email protected]>
89777fd10fc3dd573c3b4d1b2efdd10af823c001
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/89777fd10fc3dd573c3b4d1b2efdd10af823c001
2016-07-12 09:10:14+01:00
block: Use block_job_get() in find_block_job() find_block_job() looks for a block backend with a specified name, checks whether it has a block job and acquires its AioContext. We want to identify jobs by their ID and not by the block backend they're attached to, so this patch ignores the backends altogether and gets the job directly. Apart from making the code simpler, this will allow us to find block jobs once they start having user-specified IDs. To ensure backward compatibility we keep ERROR_CLASS_DEVICE_NOT_ACTIVE as the error class if the job doesn't exist. In subsequent patches we'll also need to keep the device name as the default job ID if the user doesn't specify a different one. Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
3ddf3efefa364505ee44582873612dd8f6abb838
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3ddf3efefa364505ee44582873612dd8f6abb838
2016-07-13 13:26:02+02:00
input-linux: better capability checks, merge input_linux_event_{mouse, keyboard} Improve capability checks (count keys and buttons), store results. Merge the input_linux_event_mouse and input_linux_event_keyboard functions into one, dispatch into input_linux_handle_mouse and input_linux_handle_keyboard depending on device capabilities. Allow calling both handle functions, so we can handle mice which also send key events, by routing those key events to the keyboard. Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected]
2e6a64cb8d7506ad27d3b6c8000bc8d773936932
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2e6a64cb8d7506ad27d3b6c8000bc8d773936932
2016-07-12 09:25:50+02:00
block/qdev: Fix NULL access when using BB twice BlockBackend has only a single pointer to its guest device, so it makes sure that only a single guest device is attached to it. device-add returns an error if you try to attach a second device to a BB. In order to make the error message nicer, -device that manually connects to a if=none block device get a different message than -drive that implicitly creates a guest device. The if=... option is stored in DriveInfo. However, since blockdev-add exists, not every BlockBackend has a DriveInfo any more. Check that it exists before we dereference it. QMP reproducer resulting in a segfault: {"execute":"blockdev-add","arguments":{"options":{"id":"disk","driver":"file","filename":"/tmp/test.img"}}} {"execute":"device_add","arguments":{"driver":"virtio-blk-pci","drive":"disk"}} {"execute":"device_add","arguments":{"driver":"virtio-blk-pci","drive":"disk"}} Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]>
a9d52a75634ac9aa7d101bf7f63e10bf6655a865
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a9d52a75634ac9aa7d101bf7f63e10bf6655a865
2016-07-05 16:46:26+02:00
block: Give nonzero result to blk_get_max_transfer_length() Making all callers special-case 0 as unlimited is awkward, and we DO have a hard maximum of BDRV_REQUEST_MAX_SECTORS given our current block layer API limits. In the case of scsi, this means that we now always advertise a limit to the guest, even in cases where the underlying layers previously use 0 for no inherent limit beyond the block layer. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
24ce9a20260713e86377cfa78fb8699335759f4f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/24ce9a20260713e86377cfa78fb8699335759f4f
2016-07-05 16:46:25+02:00
target-ppc: ppce500_spin.c uses SPR_PIR, should use SPR_BOOKE_PIR ppce500_spin.c uses SPR_PIR to initialize the spin table, however on Book E processors the correct SPR is SPR_BOOKE_PIR. Signed-off-by: Aaron Larson <[email protected]> Signed-off-by: David Gibson <[email protected]>
6d18a7a1ff9665ad48a68a692fdf0a61edefcae8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6d18a7a1ff9665ad48a68a692fdf0a61edefcae8
2016-06-27 13:12:22+10:00
block: Switch transfer length bounds to byte-based Sector-based limits are awkward to think about; in our on-going quest to move to byte-based interfaces, convert max_transfer_length and opt_transfer_length. Rename them (dropping the _length suffix) so that the compiler will help us catch the change in semantics across any rebased code, and improve the documentation. Use unsigned values, so that we don't have to worry about negative values and so that bit-twiddling is easier; however, we are still constrained by 2^31 of signed int in most APIs. When a value comes from an external source (iscsi and raw-posix), sanitize the results to ensure that opt_transfer is a power of 2. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
5def6b80e1eca696c1fc6099e7f4d36729686402
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5def6b80e1eca696c1fc6099e7f4d36729686402
2016-07-05 16:46:25+02:00
port92: handle A20 IRQ as GPIO The port92 device has outgouing IRQ line A20. Currently the IRQ is referenced by a pointer which normally is set during machine initialization. The pointer is never changed at runtime. Hence, common GPIO model can be applied to A20 IRQ line. Note that checking for IRQ to be connected as in previous version of code is not required qemu_set_irq will do it. Signed-off-by: Efimov Vasily <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
d812b3d68ddf0efe91a088ecc8b177865b0bab8d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d812b3d68ddf0efe91a088ecc8b177865b0bab8d
2016-06-29 14:03:46+02:00
nvdimm: support nvdimm label Introduce a parameter, 'label-size', which is the size of nvdimm label data area which is reserved at the end of backend memory. It is required at least 128k Two callbacks, read_label_data() and write_label_data(), are used to operate the label area Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
d6fb213a628c66b391d0ce704982bab7c14e559b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d6fb213a628c66b391d0ce704982bab7c14e559b
2016-06-24 05:13:57+03:00
piix: Set I440FXState member pci_info.w32 in one place Range pci_info.w32 records the location of the PCI hole. It's initialized to empty when QOM zeroes I440FXState. That's a fine value for a still unknown PCI hole. i440fx_init() sets pci_info.w32.begin = below_4g_mem_size. Changes the PCI hole from empty to [below_4g_mem_size, UINT64_MAX]. That's a bogus value. i440fx_pcihost_initfn() sets pci_info.end = IO_APIC_DEFAULT_ADDRESS. Since i440fx_init() ran already, this changes the PCI hole to [below_4g_mem_size, IO_APIC_DEFAULT_ADDRESS-1]. That's the correct value. Setting the bounds of the PCI hole in two separate places is confusing, and begs the question whether the bogus intermediate value could be used by something, or what would happen if we somehow managed to realize an i440FX device without having run the board init function i440fx_init() first. Avoid the confusion by setting the (constant) upper bound along with the lower bound in i440fx_init(). Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Marcel Apfelbaum <[email protected]>
97a83ec3a9d83f2e86b8b93178d8e8b64ccc7486
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/97a83ec3a9d83f2e86b8b93178d8e8b64ccc7486
2016-07-04 14:50:59+03:00
pc-dimm: introduce get_vmstate_memory_region callback This callback returns the MemoryRegion that is the memory of dimm should be kept during live migration nvdimm device is different with pc-dimm as its memory includes not only the MemoryRegion directly mapping to guest's address space but also the memory used as label data Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
8df1426e44176512be1b6456e90d100d1af907e1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8df1426e44176512be1b6456e90d100d1af907e1
2016-06-24 05:13:57+03:00
os-posix: include sys/mman.h qemu/osdep.h checks whether MAP_ANONYMOUS is defined, but this check is bogus without a previous inclusion of sys/mman.h. Include it in sysemu/os-posix.h and remove it from everywhere else. Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
02d0e095031b7fda77de8b558465a57659ea79cb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/02d0e095031b7fda77de8b558465a57659ea79cb
2016-06-16 18:39:03+02:00
target-arm: Don't permit ARMv8-only Neon insns on ARMv7 The Neon instructions VCVTA, VCVTM, VCVTN, VCVTP, VRINTA, VRINTM, VRINTN, VRINTP, VRINTX, and VRINTZ were only introduced with ARMv8, so they need a guard to make them UNDEF if the CPU only supports ARMv7. (We got this right for all the other new-in-v8 insns, but forgot it for these Neon 2-reg-misc ops.) Reported-by: Christophe Lyon <[email protected]> Tested-by: Christophe Lyon <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected]
fe8fcf3d642b4de1369841bf6acac13e0ec8770d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fe8fcf3d642b4de1369841bf6acac13e0ec8770d
2016-06-14 16:01:03+01:00
block: Allow replacement of a BDS by its overlay change_parent_backing_link() asserts that the BDS to be replaced is not used as a backing file. However, we may want to replace a BDS by its overlay in which case that very link should not be redirected. For instance, when doing a sync=none drive-mirror operation, we may have the following BDS/BB forest before block job completion: target base <- source <- BlockBackend During job completion, we want to establish the source BDS as the target's backing node: target | v base <- source <- BlockBackend This makes the target a valid replacement for the source: target <- BlockBackend | v base <- source Without this modification to change_parent_backing_link() we have to inject the target into the graph before the source is its backing node, thus temporarily creating a wrong graph: target <- BlockBackend base <- source Signed-off-by: Max Reitz <[email protected]> Message-id: [email protected] Reviewed-by: Kevin Wolf <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Max Reitz <[email protected]>
9bd910e2cbe413ab5927068bf189e929cb6790bc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9bd910e2cbe413ab5927068bf189e929cb6790bc
2016-06-16 15:20:37+02:00
thunk: Drop unused NO_THUNK_TYPE_SIZE guards The thunk_type_size_array() and thunk_type_align_array() functions are only provided if NO_THUNK_TYPE_SIZE is not defined. However nothing in the codebase defines that, and so in fact these functions are always present. Drop the unnecessary #ifdefs. (Over a decade ago thunk.h used to be included by some softmmu files, which defined NO_THUNK_TYPE_SIZE, but these includes are long gone; see for instance commit f193c7979c2f7.) Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
7a00217d1a4478f2b8ac63e7fcd5a31af39394ba
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7a00217d1a4478f2b8ac63e7fcd5a31af39394ba
2016-06-07 18:19:24+03:00
vnc: add configurable keyboard delay Limits the rate kbd events from the vnc server are forwarded to the guest, so input devices which are typically low-bandwidth can keep up even on bulky input. v2: update documentation too. v3: spell fixes. Signed-off-by: Gerd Hoffmann <[email protected]> Tested-by: Yang Hongyang <[email protected]> Message-id: [email protected]
c5ce83334465ee5acb6789a2f22d125273761c9e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c5ce83334465ee5acb6789a2f22d125273761c9e
2016-06-03 08:23:26+02:00
audio: pa: Set volume of recording stream instead of recording device Since pulseaudio 1.0 it's possible to set the individual stream volume rather than setting the device volume. With this, setting hardware mixer of a emulated sound card doesn't mess up the volume configuration of the host. A side effect is that this limits compatible pulseaudio version to 1.0 which was released on 2011-09-27. Signed-off-by: Peter Krempa <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]> Message-id: 78853815be2069971b89b3a2e3181837064dd8f3.1462962512.git.pkrempa@redhat.com Signed-off-by: Gerd Hoffmann <[email protected]>
e58ff62d589fe147f4e73ba28a0383fb80600be6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e58ff62d589fe147f4e73ba28a0383fb80600be6
2016-06-03 11:13:38+02:00
scsi: esp: check TI buffer index before read/write The 53C9X Fast SCSI Controller(FSC) comes with internal 16-byte FIFO buffers. One is used to handle commands and other is for information transfer. Three control variables 'ti_rptr', 'ti_wptr' and 'ti_size' are used to control r/w access to the information transfer buffer ti_buf[TI_BUFSZ=16]. In that, 'ti_rptr' is used as read index, where read occurs. 'ti_wptr' is a write index, where write would occur. 'ti_size' indicates total bytes to be read from the buffer. While reading/writing to this buffer, index could exceed its size. Add check to avoid OOB r/w access. Reported-by: Huawei PSIRT <[email protected]> Reported-by: Li Qiang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
ff589551c8e8e9e95e211b9d8daafb4ed39f1aec
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ff589551c8e8e9e95e211b9d8daafb4ed39f1aec
2016-06-06 18:57:15+02:00
vfio: Check that IOMMU MR translates to system address space At the moment IOMMU MR only translate to the system memory. However if some new code changes this, we will need clear indication why it is not working so here is the check. Signed-off-by: Alexey Kardashevskiy <[email protected]> Reviewed-by: David Gibson <[email protected]> Signed-off-by: Alex Williamson <[email protected]>
f1f9365019bb257af087b454972c396bb0d53b26
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f1f9365019bb257af087b454972c396bb0d53b26
2016-05-26 11:12:09-06:00
linux-user: Support for restarting system calls for CRIS targets Update the CRIS main loop and sigreturn code: * on TARGET_ERESTARTSYS, wind guest PC backwards to repeat syscall insn * set all guest CPU state within signal.c code on sigreturn * handle TARGET_QEMU_ESIGRETURN in the main loop as the indication that the main loop should not touch any guest CPU state Signed-off-by: Timothy Edward Baldwin <[email protected]> Message-id: 1441497448-32489-34-git-send-email-T.E.Baldwin99@members.leeds.ac.uk Reviewed-by: Peter Maydell <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]> [PMM: tweak commit message; drop TARGET_USE_ERESTARTSYS define] Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
6205086558955402983f1c2ff9e4c3ebe9f1c678
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6205086558955402983f1c2ff9e4c3ebe9f1c678
2016-05-27 14:49:50+03:00
vfio: Create device specific region info helper Given a device specific region type and sub-type, find it. Also cleanup return point on error in vfio_get_region_info() so that we always return 0 with a valid pointer or -errno and NULL. Signed-off-by: Alex Williamson <[email protected]> Reviewed-by: Gerd Hoffmann <[email protected]> Tested-by: Gerd Hoffmann <[email protected]>
e61a424f0573634a1bc180de965b2cb794c1038e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e61a424f0573634a1bc180de965b2cb794c1038e
2016-05-26 11:04:50-06:00
tb hash: hash phys_pc, pc, and flags with xxhash For some workloads such as arm bootup, tb_phys_hash is performance-critical. The is due to the high frequency of accesses to the hash table, originated by (frequent) TLB flushes that wipe out the cpu-private tb_jmp_cache's. More info: https://lists.nongnu.org/archive/html/qemu-devel/2016-03/msg05098.html To dig further into this I modified an arm image booting debian jessie to immediately shut down after boot. Analysis revealed that quite a bit of time is unnecessarily spent in tb_phys_hash: the cause is poor hashing that results in very uneven loading of chains in the hash table's buckets; the longest observed chain had ~550 elements. The appended addresses this with two changes: 1) Use xxhash as the hash table's hash function. xxhash is a fast, high-quality hashing function. 2) Feed the hashing function with not just tb_phys, but also pc and flags. This improves performance over using just tb_phys for hashing, since that resulted in some hash buckets having many TB's, while others getting very few; with these changes, the longest observed chain on a single hash bucket is brought down from ~550 to ~40. Tests show that the other element checked for in tb_find_physical, cs_base, is always a match when tb_phys+pc+flags are a match, so hashing cs_base is wasteful. It could be that this is an ARM-only thing, though. UPDATE: On Tue, Apr 05, 2016 at 08:41:43 -0700, Richard Henderson wrote: > The cs_base field is only used by i386 (in 16-bit modes), and sparc (for a TB > consisting of only a delay slot). > It may well still turn out to be reasonable to ignore cs_base for hashing. BTW, after this change the hash table should not be called "tb_hash_phys" anymore; this is addressed later in this series. This change gives consistent bootup time improvements. I tested two host machines: - Intel Xeon E5-2690: 11.6% less time - Intel i7-4790K: 19.2% less time Increasing the number of hash buckets yields further improvements. However, using a larger, fixed number of buckets can degrade performance for other workloads that do not translate as many blocks (600K+ for debian-jessie arm bootup). This is dealt with later in this series. Reviewed-by: Sergey Fedorov <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Signed-off-by: Emilio G. Cota <[email protected]> Message-Id: <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
42bd32287f3a18d823f2258b813824a39ed7c6d9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/42bd32287f3a18d823f2258b813824a39ed7c6d9
2016-06-11 23:10:19+00:00
target-i386: Use xsave structs for ext_save_area This doesn't introduce any change in the code, as the offsets and struct sizes match what was present in the table. This can be validated by the QEMU_BUILD_BUG_ON lines on target-i386/cpu.h, which ensures the struct sizes and offsets match the existing values in ext_save_area. Signed-off-by: Eduardo Habkost <[email protected]>
ee1b09f695dcd8532f470e53297473bd3bc88718
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ee1b09f695dcd8532f470e53297473bd3bc88718
2016-05-23 13:19:36-03:00
spice: fix coverity complains Remove the unnecessary NULL check. Signed-off-by: Gonglei <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
28f4a7083dcca084243e313ab18fcdb20d60334e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/28f4a7083dcca084243e313ab18fcdb20d60334e
2016-05-12 16:41:46+02:00
block: Don't check throttled reqs in bdrv_requests_pending() Checking whether there are throttled requests requires going to the associated BlockBackend, which we want to avoid. All users of bdrv_requests_pending() in block/io.c already call bdrv_parent_drained_begin() first, which restarts all throttled requests, so no throttled requests can be left here and this is removal of dead code. The remaining users (assertions during graph manipulation in block.c) don't care about requests that are still queued in the BlockBackend and haven't been issued for a BlockDriverState yet. Signed-off-by: Kevin Wolf <[email protected]> Acked-by: Stefan Hajnoczi <[email protected]>
cbe1beb7a1eaa34e0c24b4897395dac017e5d16f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cbe1beb7a1eaa34e0c24b4897395dac017e5d16f
2016-05-19 16:45:31+02:00
tcg: reorganize tb_find_physical loop Put some comments and improve code structure. This should help reading the code. Signed-off-by: Alex Bennée <[email protected]> [Sergey Fedorov: provide commit message; bring back resetting of tb_invalidated_flag] Signed-off-by: Sergey Fedorov <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
1279f323d67b482f942c411d8a705fa9cf36e372
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1279f323d67b482f942c411d8a705fa9cf36e372
2016-05-12 14:06:42-10:00
qemu-io: Use bool for command line flags We require a C99 compiler; let's use it to express what we really mean. (Yes, we now have an instance of 'if (bool + bool + bool > 1)', which, although semantically valid C, looks ugly; it gets cleaned up later.) Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Max Reitz <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
dc38852aaa4ac187d8b44201f75fc2835241912d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/dc38852aaa4ac187d8b44201f75fc2835241912d
2016-05-12 15:33:24+02:00
vfio/pci: Intel graphics legacy mode assignment Enable quirks to support SandyBridge and newer IGD devices as primary VM graphics. This requires new vfio-pci device specific regions added in kernel v4.6 to expose the IGD OpRegion, the shadow ROM, and config space access to the PCI host bridge and LPC/ISA bridge. VM firmware support, SeaBIOS only so far, is also required for reserving memory regions for IGD specific use. In order to enable this mode, IGD must be assigned to the VM at PCI bus address 00:02.0, it must have a ROM, it must be able to enable VGA, it must have or be able to create on its own an LPC/ISA bridge of the proper type at PCI bus address 00:1f.0 (sorry, not compatible with Q35 yet), and it must have the above noted vfio-pci kernel features and BIOS. The intention is that to enable this mode, a user simply needs to assign 00:02.0 from the host to 00:02.0 in the VM: -device vfio-pci,host=0000:00:02.0,bus=pci.0,addr=02.0 and everything either happens automatically or it doesn't. In the case that it doesn't, we leave error reports, but assume the device will operate in universal passthrough mode (UPT), which doesn't require any of this, but has a much more narrow window of supported devices, supported use cases, and supported guest drivers. When using IGD in this mode, the VM firmware is required to reserve some VM RAM for the OpRegion (on the order or several 4k pages) and stolen memory for the GTT (up to 8MB for the latest GPUs). An additional option, x-igd-gms allows the user to specify some amount of additional memory (value is number of 32MB chunks up to 512MB) that is pre-allocated for graphics use. TBH, I don't know of anything that requires this or makes use of this memory, which is why we don't allocate any by default, but the specification suggests this is not actually a valid combination, so the option exists as a workaround. Please report if it's actually necessary in some environment. See code comments for further discussion about the actual operation of the quirks necessary to assign these devices. Signed-off-by: Alex Williamson <[email protected]> Reviewed-by: Gerd Hoffmann <[email protected]> Tested-by: Gerd Hoffmann <[email protected]>
c4c45e943e519f5ac220f7af1afb2a0025d03c54
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c4c45e943e519f5ac220f7af1afb2a0025d03c54
2016-05-26 11:12:01-06:00
Revert "acpi: mark PMTIMER as unlocked" This reverts commit 7070e085d490c396f9237c8f10bf8b6e69cd0066. Commit message claims locking is not needed, but that appears to not be true, seabios ehci driver runs into timekeeping problems with this, see https://bugzilla.redhat.com/show_bug.cgi?id=1322713 Signed-off-by: Gerd Hoffmann <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
1beb99f787ba110a9de44254e7d62a1cb9117de8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1beb99f787ba110a9de44254e7d62a1cb9117de8
2016-05-02 17:19:13+01:00
block: plug whole tree at once, introduce bdrv_io_unplugged_begin/end Extract the handling of io_plug "depth" from linux-aio.c and let the main bdrv_drain loop do nothing but wait on I/O. Like the two newly introduced functions, bdrv_io_plug and bdrv_io_unplug now operate on all children. The visit order is now symmetrical between plug and unplug, making it possible for formats to implement plug/unplug. Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Acked-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
6b98bd649520d07df4d1b7a0a54ac73bf178519c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6b98bd649520d07df4d1b7a0a54ac73bf178519c
2016-05-12 15:22:07+02:00
qcow2: Prevent backing file names longer than 1023 We reject backing file names with a length of more than 1023 characters when opening a qcow2 file, so we should not produce such files ourselves. Cc: [email protected] Signed-off-by: Max Reitz <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
4e876bcf2bdb3a7353df92d19bfec0afd1650bc4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4e876bcf2bdb3a7353df92d19bfec0afd1650bc4
2016-04-12 18:06:51+02:00
ppc: Fix the range check in the LSWI instruction There are two issues: First, the number of registers that are used has to be calculated with "(nb + 3) / 4" (i.e. round always up, not down). Second, the "start <= ra && (start + nr - 32) > ra" condition for the wrap-around case is wrong: It has to be tested with "||" instead of "&&". Since we can reuse this check later for the LSWX instruction, let's place the fixed code into a helper function, too. Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: David Gibson <[email protected]>
afbee7128c2399b6fca7b744ee560e3a1851118e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/afbee7128c2399b6fca7b744ee560e3a1851118e
2016-04-18 15:14:38+10:00
ivshmem: Inline check_shm_size() into its only caller Improve the error messages while there. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]>
8baeb22bfc3b57a8568c17b34c66ea2ff54df09a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8baeb22bfc3b57a8568c17b34c66ea2ff54df09a
2016-03-21 21:29:02+01:00
ipmi: remove the need of an ending record in the SDR table Currently, the code initializing the sdr table relies on an ending record with a recid of 0xffff. This patch changes the loop to use the sdr size as a breaking condition. Signed-off-by: Cédric Le Goater <[email protected]> Acked-by: Corey Minyard <[email protected]> Reviewed-by: Marcel Apfelbaum <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
52fc01d9739d90086bf81987af5ed414ce89bbc4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/52fc01d9739d90086bf81987af5ed414ce89bbc4
2016-03-11 16:59:13+02:00
dbdma: warn when using unassigned channel With this, it's easier to know if a guest uses an invalid and/or unimplemented DMA channel. Signed-off-by: Hervé Poussineau <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Acked-by: Mark Cave-Ayland <[email protected]> Signed-off-by: David Gibson <[email protected]>
2d7d06d847b78fc1487a1b8908a823089c6a53b6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2d7d06d847b78fc1487a1b8908a823089c6a53b6
2016-02-28 16:19:02+11:00
rng: move request queue cleanup from RngEgd to RngBackend RngBackend is now in charge of cleaning up the linked list on instance finalization. It also exposes a function to finalize individual RngRequest instances, called by its child classes. Signed-off-by: Ladi Prosek <[email protected]> Reviewed-by: Amit Shah <[email protected]> Message-Id: <[email protected]> Signed-off-by: Amit Shah <[email protected]>
9f14b0add1dcdbfa2ee61051d068211fb0a1fcc9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9f14b0add1dcdbfa2ee61051d068211fb0a1fcc9
2016-03-03 17:42:26+05:30
ARM: PL061: Checking register r/w accesses to reserved area pl061.c emulates two GPIO devices, ARM PL061 and TI Stellaris, which share the same read/write functions (pl061_read and pl061_write). However PL061 and Stellaris have different GPIO register definitions and pl061_read()/pl061_write() doesn't check it. This patch enforces checking on offset, preventing R/W into the reserved memory area. Signed-off-by: Wei Huang <[email protected]> Message-id: [email protected] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
09aa3bf382243151e77682b2e89f997349b306d8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/09aa3bf382243151e77682b2e89f997349b306d8
2016-02-26 15:09:42+00:00
qapi: Update docs to match recent generator changes Several commits have been changing the generator, but not updating the docs to match: - The implicit tag member is named "type", not "kind". Screwed up in commit 39a1815. - Commit 9f08c8ec made list types lazy, and thereby dropped UserDefOneList if nothing explicitly uses the list type. - Commit 51e72bc1 switched the parameter order with 'name' occurring earlier. - Commit e65d89bf changed the layout of UserDefOneList. - Prefer the term 'member' over 'field'. - We now expose visit_type_FOO_members() for objects. - etc. Rework the examples to show slightly more output (we don't want to show too much; that's what the testsuite is for), and regenerate the output to match all recent changes. Also, rearrange output to show .h files before .c (understanding the interface first often makes the implementation easier to follow). Reported-by: Marc-André Lureau <[email protected]> Signed-off-by: Eric Blake <[email protected]> Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]>
9ee86b852673fd9ec807b1ff3c3a1337351dac0a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9ee86b852673fd9ec807b1ff3c3a1337351dac0a
2016-03-05 10:41:16+01:00
linux-user: Use restrictive mask when calling cpsr_write() When linux-user code is calling cpsr_write(), use a restrictive mask to ensure we are limiting the set of CPSR bits we update. In particular, don't allow the mode bits to be changed. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Sergey Fedorov <[email protected]> Message-id: [email protected]
ae08792301c182bdec48656dee3dce38b3391a1a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ae08792301c182bdec48656dee3dce38b3391a1a
2016-02-26 15:09:41+00:00
target-arm: Implement MDCR_EL3.TPM and MDCR_EL2.TPM traps Implement the performance monitor register traps controlled by MDCR_EL3.TPM and MDCR_EL2.TPM. Most of the performance registers already have an access function to deal with the user-enable bit, and the TPM checks can be added there. We also need a new access function which only implements the TPM checks for use by the few not-EL0-accessible registers and by PMUSERENR_EL0 (which is always EL0-readable). Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected] Reviewed-by: Sergey Fedorov <[email protected]> Acked-by: Alistair Francis <[email protected]>
1fce1ba985d9c5c96e5b9709e1356d1814b8fa9e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1fce1ba985d9c5c96e5b9709e1356d1814b8fa9e
2016-02-26 15:09:42+00:00
migration/postcopy-ram: Guard use of sys/eventfd.h with CONFIG_EVENTFD sys/eventfd.h was being guarded only by a check for linux but does not exist on older distributions like CentOS 5. Move the include into the code that uses it and add an appropriate guard. Signed-off-by: Matthew Fortune <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Message-Id: <[email protected]> Signed-off-by: Amit Shah <[email protected]>
d8b9d7719cf6fb3186ecc817b3c04005eb1a1f01
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/d8b9d7719cf6fb3186ecc817b3c04005eb1a1f01
2016-02-26 15:05:25+05:30
mips/kvm: Support FPU in MIPS KVM guests Support the new KVM_CAP_MIPS_FPU capability, which allows the host's FPU to be exposed to the KVM guest. The capability is enabled if the guest core has an FPU according to its Config1 register. Various config bits are now writeable so that KVM is aware of the configuration (Config1.FP) and so that QEMU can save/restore the guest modifiable bits (Config5.FRE, Config5.UFR, Config5.UFE). The FCSR/FIR registers and the floating point registers are now saved/restored (depending on the FR mode bit). Signed-off-by: James Hogan <[email protected]> Cc: Paolo Bonzini <[email protected]> Cc: Leon Alrae <[email protected]> Cc: Aurelien Jarno <[email protected]> Signed-off-by: Leon Alrae <[email protected]>
152db36ae63c70adc95afc3228f858ef6369519a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/152db36ae63c70adc95afc3228f858ef6369519a
2016-02-26 08:59:17+00:00
vhost: move virtio 1.0 check to cross-endian helper Indeed vhost doesn't need to ask for vring endian fixing if the device is virtio 1.0, since it is already handled by the in-kernel vhost driver. This patch simply consolidates the logic into the existing helper. Reviewed-by: Cornelia Huck <[email protected]> Signed-off-by: Greg Kurz <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Laurent Vivier <[email protected]>
e58481234ef9c132554cc529d9981ebd78fb6903
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e58481234ef9c132554cc529d9981ebd78fb6903
2016-02-16 12:05:17+02:00
scsi-generic: grab device and port SAS addresses from backend This lets a SAS adapter expose them through its own configuration mechanism. Signed-off-by: Paolo Bonzini <[email protected]>
9fd7e85938e87ca52dcb1aeff34fa1675917831b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9fd7e85938e87ca52dcb1aeff34fa1675917831b
2016-02-09 15:45:26+01:00
ipmi_bmc_sim: Add break to correct watchdog NMI check It was falling through when it should have been a break. Found by Coverity. The logic could be simplified a bit with a fallthrough, probably the original thought, but that would be less clear, I think. Cc: Paolo Bonzini <[email protected]> Cc: Michael S. Tsirkin <[email protected]> Cc: Peter Maydell <[email protected]> Cc: Shannon Zhao <[email protected]> Cc: Xiao Guangrong <[email protected]> Cc: Stefan Hajnoczi <[email protected]> Signed-off-by: Corey Minyard <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
37eebb8693368d890b700cca6e39ec31c7e980e5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/37eebb8693368d890b700cca6e39ec31c7e980e5
2016-02-09 15:46:54+01:00
tcg: Change ts->mem_reg to ts->mem_base Chain the temporaries together via pointers intstead of indices. The mem_reg value is now mem_base->reg. This will be important later. This does require that the frame pointer have a global temporary allocated for it. This is simple bar the existing reserved_regs check. Reviewed-by: Aurelien Jarno <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
b3a62939561e07bc34493444fa926b6137cba4e8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b3a62939561e07bc34493444fa926b6137cba4e8
2016-02-09 10:19:32+11:00
arm: virt-acpi: each MADT.GICC entry as enabled unconditionally in current impl. condition build_madt() { ... if (test_bit(i, cpuinfo->found_cpus)) is always true since loop handles only present CPUs in range [0..smp_cpus). But to fill usless cpuinfo->found_cpus we do unnecessary scan over QOM tree to find the same CPUs. So mark GICC as present always and drop not needed code that fills cpuinfo->found_cpus. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Shannon Zhao <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
6d152ebaf4db6567cefbbd3b2b102c4a50172109
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6d152ebaf4db6567cefbbd3b2b102c4a50172109
2016-02-03 13:46:34+00:00
usb: check page select value while processing iTD While processing isochronous transfer descriptors(iTD), the page select(PG) field value could lead to an OOB read access. Add check to avoid it. Reported-by: Qinghao Tang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
49d925ce50383a286278143c05511d30ec41a36e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/49d925ce50383a286278143c05511d30ec41a36e
2016-02-02 14:11:01+01:00
iotests: 019: Use TEST_IMG override instead of "mv" Signed-off-by: Fam Zheng <[email protected]> Reviewed-by: Max Reitz <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
f2bbcd3f7f03451acea513d01305341233683097
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f2bbcd3f7f03451acea513d01305341233683097
2016-01-07 21:30:17+01:00
block: Add "file" output parameter to block status query functions The added parameter can be used to return the BDS pointer which the valid offset is referring to. Its value should be ignored unless BDRV_BLOCK_OFFSET_VALID in ret is set. Until block drivers fill in the right value, let's clear it explicitly right before calling .bdrv_get_block_status. The "bs->file" condition in bdrv_co_get_block_status is kept now to keep iotest case 102 passing, and will be fixed once all drivers return the right file pointer. Signed-off-by: Fam Zheng <[email protected]> Message-id: [email protected] Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Max Reitz <[email protected]>
67a0fd2a9bca204d2b39f910a97c7137636a0715
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/67a0fd2a9bca204d2b39f910a97c7137636a0715
2016-02-02 17:50:47+01:00
acpi: add aml_derefof Implement DeRefOf term which is used by NVDIMM _DSM method in later patch Reviewed-by: Igor Mammedov <[email protected]> Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
95cb06619092130eb41e68b2541e04aedb48b046
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/95cb06619092130eb41e68b2541e04aedb48b046
2015-12-22 18:39:20+02:00
nvdimm: implement NVDIMM device abstract Introduce "nvdimm" device which is based on pc-dimm device type Currently, nothing is specific for nvdimm but hotplug is disabled Reviewed-by: Stefan Hajnoczi <[email protected]> Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
5c42eef24314fb51600b0e90fb69c60653ea05bb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5c42eef24314fb51600b0e90fb69c60653ea05bb
2015-12-22 18:39:20+02:00
qemu-iotests: Test cache mode option inheritance This is doing a more complete test on setting cache modes both while opening an image (i.e. in a -drive command line) and in reopen situations. It checks that reopen can specify options for child nodes and that cache modes are correctly inherited from parent nodes where they are not specified. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]>
8f7acbe6ea30de29e11f595242de89845f771ea1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8f7acbe6ea30de29e11f595242de89845f771ea1
2015-12-18 14:34:43+01:00
block: reopen: Extract QemuOpts for generic block layer options This patch adds a QemuOpts for generic block layer options to bdrv_reopen_prepare(). The only two options that currently exist (node-name and driver) cannot be changed, so the only thing we do is putting them right back into the QDict so that we check at the end that they are indeed unchanged. We will add new options soon that can actually be changed. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]>
ccf9dc07b5c8f3b927d53e9ef8c712c2973d79c7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ccf9dc07b5c8f3b927d53e9ef8c712c2973d79c7
2015-12-18 14:34:43+01:00
block: Exclude nested options only for children in append_open_options() Some drivers have nested options (e.g. blkdebug rule arrays), which don't belong to a child node and shouldn't be removed. Don't remove all options with "." in their name, but check for the complete prefixes of actually existing child nodes. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]>
260fecf13b0d30621dc88da03dc1b502b7358c6b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/260fecf13b0d30621dc88da03dc1b502b7358c6b
2015-12-18 14:34:42+01:00
block: Fix reopen with semantically overlapping options This fixes bdrv_reopen() calls like the following one: qemu-io -c 'open -o overlap-check.template=all /tmp/test.qcow2' \ -c 'reopen -o overlap-check=none' The approach taken so far would result in an options QDict that has both "overlap-check.template=all" and "overlap-check=none", which obviously conflicts. In this case, the old option should be overridden by the newly specified option. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Alberto Garcia <[email protected]>
cddff5bae1c8e0e21a5e6da04eff1d0a4423e5f3
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cddff5bae1c8e0e21a5e6da04eff1d0a4423e5f3
2015-12-18 14:34:42+01:00
tests/ivshmem-test: Supply missing initializer in get_device() If the device isn't found, the assertion uses dev without initialization. Fix that. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Marc-André Lureau <[email protected]>
1613094766602bdb8cae337ceecd8ab68f956197
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1613094766602bdb8cae337ceecd8ab68f956197
2015-11-25 10:24:04+01:00
qobject: Simplify QObject The QObject hierarchy is small enough, and unlikely to grow further (since we only use it to map to JSON and already cover all JSON types), that we can simplify things by not tracking a separate vtable, but just inline the code element of the vtable QType directly into QObject (renamed to type), and track a separate array of destroy functions. We can drop qnull_destroy_obj() in the process. The remaining QObject subclasses must export their destructor. This also has the nice benefit of moving the typename 'QType' out of the way, so that the next patch can repurpose it for a nicer name for 'qtype_code'. The various objects are still the same size (so no change in cache line pressure), but now have less indirection (although I didn't bother benchmarking to see if there is a noticeable speedup, as we don't have hard evidence that this was in a performance hotspot in the first place). A future patch could drop the refcnt size to 32 bits for a smaller struct on 64-bit architectures, if desired (we have limits on the largest JSON that we are willing to parse, and will probably never need to take full advantage of a 64-bit refcnt). Suggested-by: Markus Armbruster <[email protected]> Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
55e1819c509b3d9c10a54678b9c585bbda13889e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/55e1819c509b3d9c10a54678b9c585bbda13889e
2015-12-17 08:21:28+01:00
iotests: Check for quorum support in test 139 The quorum driver is always built in, but it is disabled during run-time if there's no SHA256 support available (see commit e94867e). This patch skips the quorum test in iotest 139 in that case. Signed-off-by: Alberto Garcia <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
92e68987745b0f89f04d29fe1d0c821010d58ea6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/92e68987745b0f89f04d29fe1d0c821010d58ea6
2015-11-11 16:59:44+01:00
block: test 'blockdev-snapshot' using a file BDS as the overlay This test checks that it is not possible to create a snapshot if the requested overlay node is a BDS which does not support backing images. Signed-off-by: Alberto Garcia <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
3fa123d05964b07f9d4d972f131cce847091926d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3fa123d05964b07f9d4d972f131cce847091926d
2015-11-11 16:25:48+01:00
qapi: Track enum values by QAPISchemaMember, not string Rather than using just an array of strings, make enum.values be an array of the new QAPISchemaMember type, and add a helper member_names() method to get back at the original list of names. Likewise, creating an enum requires wrapping strings, via a new QAPISchema._make_enum_members() method. The benefit of wrapping enum members in a QAPISchemaMember Python object is that we now share the existing code for C name clash detection (although the code is not yet active until a later commit removes the earlier ad hoc parser checks). In a related change, the QAPISchemaMember._pretty_owner() method needs to learn about one more implicit type name: the generated enum associated with a simple union. In the interest of keeping the changes of this patch local to one file, the visitor interface still passes just a list of names rather than the full list of QAPISchemaMember instances. We may want to revisit this in the future, if the consistency with visit_object_type() is worth it. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [Eric's simplifying followup squashed in] Signed-off-by: Markus Armbruster <[email protected]>
93bda4dd461358b4fc05dfd8e2d6419cdd574789
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/93bda4dd461358b4fc05dfd8e2d6419cdd574789
2015-12-17 08:21:29+01:00
input: Document why x-input-send-event is still experimental The x-input-send-event command was introduced in 2.2 with mention that it is experimental, but now that several releases have elapsed without any changes, it would be nice to document why that was done and should still remain experimental in 2.5. Meanwhile, our documentation states that we prefer 'lower-case', rather than 'CamelCase', for qapi enum values. The InputButton and InputAxis enums violate this convention. However, because they are currently used primarily for generating code that is used internally; and their only exposure through QMP is via the experimental 'x-input-send-event' command, we are free to change their spelling. Of course, it would be nicer to delay such a change until the same time we promote the command to non-experimental. Adding documentation will help us remember to do that rename. We have plans to tighten the qapi generator to flag instances of inconsistent use of naming conventions; if that lands first, it will just need to whitelist these exceptions until the time we settle on the final interface. Fix a typo in the docs for InputAxis while at it. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Reviewed-by: Gerd Hoffmann <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
513e7cdbaeec56c77e4cf26f151d7ee79f3a6be9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/513e7cdbaeec56c77e4cf26f151d7ee79f3a6be9
2015-11-17 08:42:07+01:00
virtio-scsi: convert to virtqueue_map Note: virtqueue_map already validates input so virtio-scsi does not have to. Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Igor Mammedov <[email protected]>
4ada5331895551570846e12e7eb00e06616f9152
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4ada5331895551570846e12e7eb00e06616f9152
2015-10-29 11:05:24+02:00
Rework loadvm path for subloops Postcopy needs to have two migration streams loading concurrently; one from memory (with the device state) and the other from the fd with the memory transactions. Split the core of qemu_loadvm_state out so we can use it for both. Allow the inner loadvm loop to quit and cause the parent loops to exit as well. Signed-off-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Juan Quintela <[email protected]> Reviewed-by: Amit Shah <[email protected]> Signed-off-by: Juan Quintela <[email protected]>
7b89bf279f16c093ed46845b8e6e0fb61b7ef639
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7b89bf279f16c093ed46845b8e6e0fb61b7ef639
2015-11-10 15:00:26+01:00
qapi: Invoke exception superclass initializer pylint recommends that every exception class should explicitly invoke the superclass __init__, even though things seem to work fine without it. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
59b00542659c8947f9d4e8c28d2d528ab3ab61a5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/59b00542659c8947f9d4e8c28d2d528ab3ab61a5
2015-10-12 18:44:54+02:00