issue_id
int64 2.03k
426k
| title
stringlengths 9
251
| body
stringlengths 1
32.8k
⌀ | status
stringclasses 6
values | after_fix_sha
stringlengths 7
7
| updated_files
stringlengths 29
34.1k
| project_name
stringclasses 6
values | repo_url
stringclasses 6
values | repo_name
stringclasses 6
values | language
stringclasses 1
value | issue_url
null | before_fix_sha
null | pull_url
null | commit_datetime
unknown | report_datetime
unknown |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
54,800 | Bug 54800 Possible thread/memory leak with use of WebSocketContainer | Whenever WebSocketContainer is used to connect to a server endpoint, the following message appears when Tomcat shuts down: SEVERE: The web application [/websocket-test] appears to have started a thread named [Thread-4] but has failed to stop it. This is very likely to create a memory leak. The message is repeated for 6 different threads. I don't have proof this is caused by the use of WebSocketContainer but the messages don't appear when it isn't used. The Endpoint used to connect is very simple. It sends a message when the session is opened to the EchoEndpoint on the server side, and prints the response and closes when the message is echoed back. | resolved fixed | d2630df | ["java/org/apache/tomcat/websocket/WsWebSocketContainer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-04-23T16:23:20Z" | "2013-04-05T02:46:40Z" |
54,807 | Bug 54807 [jsr356] java.lang.ClassCastException: org.apache.tomcat.websocket.server.WsServerContainer$TemplatePathMatch | Caused by: java.lang.ClassCastException: org.apache.tomcat.websocket.server.WsServerContainer$TemplatePathMatch cannot be cast to java.lang.Comparable at java.util.TreeMap.compare(TreeMap.java:1188) at java.util.TreeMap.put(TreeMap.java:531) at java.util.TreeSet.add(TreeSet.java:255) at org.apache.tomcat.websocket.server.WsServerContainer.addEndpoint(WsServerContainer.java:144) at org.apache.tomcat.websocket.server.WsSci.onStartup(WsSci.java:118) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5195) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) ... 11 more Reproducible when a path is defined as {path}. For example: @Override public Set<ServerEndpointConfig> getEndpointConfigs(Set<Class<? extends Endpoint>> endpointClasses) { logger.debug("{} detected", JSR356ServerEndpointConfig.class.getName()); return new HashSet<ServerEndpointConfig>() {{ add(ServerEndpointConfig.Builder.create(JSR356Endpoint.class, "/{path}").configurator(c).build()); }}; } | resolved fixed | 0339fec | ["java/org/apache/tomcat/websocket/server/WsServerContainer.java", "test/org/apache/tomcat/websocket/server/TestWebSocketServerContainer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-04-19T19:25:49Z" | "2013-04-05T19:26:40Z" |
54,822 | Bug 54822 URL with Query String can't work over SPDY | null | resolved fixed | 3da2133 | ["java/org/apache/coyote/spdy/SpdyProcessor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-04-19T15:20:53Z" | "2013-04-10T10:33:20Z" |
54,851 | Bug 54851 Folder without web-fragment.xml should not impact the status of distributable | null | resolved fixed | e97e158 | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-04-16T13:51:06Z" | "2013-04-16T13:46:40Z" |
54,755 | Bug 54755 Type-based Endpoint's cannot be deployed by instance | For type-based Endpoint's, WsServlet instantiates the Endpoint via reflection instead of using the Configurator as is done in PojoEndpointServer: sec.getConfigurator().getEndpointInstance(sec.getEndpointClass()) | resolved fixed | d025179 | ["java/org/apache/tomcat/websocket/server/WsServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-26T21:19:51Z" | "2013-03-26T17:46:40Z" |
54,748 | Bug 54748 IOException in echo WebSocket example | The IOException "New frame received after a close control frame" is raised after pressing Disconnect. The exception can be detected by adding an onError method to EchoEndpoint. | resolved fixed | cf0c064 | ["java/org/apache/tomcat/websocket/WsFrameBase.java", "java/org/apache/tomcat/websocket/WsFrameClient.java", "java/org/apache/tomcat/websocket/server/WsFrameServer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-25T21:54:33Z" | "2013-03-25T14:00:00Z" |
54,732 | Bug 54732 StatementCache interceptor does not forward calls to Statement.close() which causes memory leaks | null | resolved fixed | 8cf47b4 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCache.java", "modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/pool/interceptor/StatementCounterInterceptor.java", "modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestStatementCache.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-22T13:44:00Z" | "2013-03-20T20:06:40Z" |
54,599 | Bug 54599 DataSource password is exposed to applications via toString method | On the server side, create a DataSource using "org.apache.tomcat.jdbc.pool.DataSourceFactory". Ex: <Resource auth="Container" description="" name="jdbc/testTomcatJdbc" factory="org.apache.tomcat.jdbc.pool.DataSourceFactory" type="javax.sql.DataSource" username="sa" password="super-secret" driverClassName="org.h2.Driver" url="jdbc:h2:mem:test" minIdle="1" initialSize="1" /> In a web application, create a JSP file, add the following: <%@ page import="javax.naming.*" session="false" %> <!DOCTYPE HTML> <html> <head> <title>Display Password!</title> </head> <body> <h1>toString for Tomcat JDBC</h1> <% dataSource = (javax.sql.DataSource) ctx.lookup("java:/comp/env/jdbc/testTomcatJdbc"); out.println("<p>" + dataSource.toString() + "</p>"); %> </body> </html> Access the JSP in your browser. The output from toString on the DataSource will display the password that was configured in the <Resource/> tag. Example Output: toString for Tomcat JDBC org.apache.tomcat.jdbc.pool.DataSource@75cae120{ConnectionPool[defaultAutoCommit=null; defaultReadOnly=null; defaultTransactionIsolation=-1; defaultCatalog=null; driverClassName=org.h2.Driver; maxActive=100; maxIdle=100; minIdle=1; initialSize=1; maxWait=30000; testOnBorrow=false; testOnReturn=false; timeBetweenEvictionRunsMillis=5000; numTestsPerEvictionRun=0; minEvictableIdleTimeMillis=60000; testWhileIdle=false; testOnConnect=false; password=super-secret; url=jdbc:h2:mem:test; username=sa; validationQuery=null; validatorClassName=null; validationInterval=30000; accessToUnderlyingConnectionAllowed=true; removeAbandoned=false; removeAbandonedTimeout=60; logAbandoned=false; connectionProperties=null; initSQL=null; jdbcInterceptors=null; jmxEnabled=true; fairQueue=true; useEquals=true; abandonWhenPercentageFull=0; maxAge=0; useLock=false; dataSource=null; dataSourceJNDI=null; suspectTimeout=0; alternateUsernameAllowed=false; commitOnReturn=false; rollbackOnReturn=false; useDisposableConnectionFacade=true; logValidationErrors=false; propagateInterruptState=false; } | resolved fixed | 8445d9a | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-22T09:16:06Z" | "2013-02-22T21:53:20Z" |
54,724 | Bug 54724 WsSession does not throw IllegalStateException if closed when methods on it are called | Spec JavaDoc says: "Once the session is closed, it is no longer valid for use by applications. Calling any of its methods once the session has been closed will result in an IllegalStateException being thrown. Developers should retrieve any information from the session during the Endpoint.onClose(Session, CloseReason) method." Of course, the rules of Closeable also apply here, and calling Session#close(...) more than once should have no effect subsequent times. There are actually three problems here: 1) None of the methods throw IllegalStateException if the session is closed. Instead, they return things (like the basic remote, for example), and some methods in the endpoint implementation will not notice concurrent exceptions from the socket and then block forever waiting four the Countdown to clear. 2) The Session#state is never actually changed to State.CLOSED unless Session#onClose is called. However, Session#onClose is never actually called that I can find (though I will look harder before I make changes). 3) Even in Session#onClose, the state is incorrectly changed to State.CLOSED BEFORE Endpoint#onClose is called, when it should be changed AFTER. I'm working on a patch for this. | resolved fixed | 12f89ff | ["java/org/apache/tomcat/websocket/WsSession.java", "test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-19T19:49:51Z" | "2013-03-19T16:20:00Z" |
54,721 | Bug 54721 RemoteEndpoint blocks indefinitely if sendObject called with BinaryStream of TextStream encoders | null | resolved fixed | 80ef59a | ["java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-19T14:26:49Z" | "2013-03-19T02:26:40Z" |
54,710 | Bug 54710 Java WebSocket specification says @OnMessage methods can have InputStream/Reader parameters; @OnClose can have CloseReason parameters | null | resolved fixed | 06800eb | ["java/org/apache/tomcat/websocket/pojo/PojoEndpointBase.java", "java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerBase.java", "java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBase.java", "java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialBinary.java", "java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerPartialText.java", "java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBase.java", "java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeBinary.java", "java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholePong.java", "java/org/apache/tomcat/websocket/pojo/PojoMessageHandlerWholeText.java", "java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-18T21:47:02Z" | "2013-03-17T14:20:00Z" |
54,709 | Bug 54709 Official schemes for WebSocket are "ws"/"wss"; WsWebSocketContainer only allows "http"/"https" | null | resolved fixed | ad148dd | ["java/org/apache/tomcat/websocket/WsWebSocketContainer.java", "test/org/apache/tomcat/websocket/TestWsRemoteEndpoint.java", "test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java", "test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java", "test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-17T18:49:45Z" | "2013-03-17T11:33:20Z" |
54,712 | Bug 54712 Prefer Locale.ENGLISH over Locale.US for case conversion | null | resolved fixed | dc16474 | ["java/org/apache/catalina/connector/Connector.java", "java/org/apache/tomcat/util/buf/B2CConverter.java", "java/org/apache/tomcat/util/http/parser/HttpParser.java", "java/org/apache/tomcat/util/http/parser/MediaType.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java", "test/org/apache/catalina/startup/SimpleHttpClient.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-17T14:07:25Z" | "2013-03-17T17:06:40Z" |
54,631 | Bug 54631 @PathParam is not working with @OnMessage | I have defined server end-point as: @ServerEndpoint(value = "/ws/{mid}/{rid}/{uid}") When using @PathParam with @OnMessage, values are null. Other annotations like @OnOpen and @OnClose print values specified in URL. @OnMessage public void onTextMessage(@PathParam("mid") Long mid, @PathParam("rid") Integer rid, @PathParam("uid") Long uid, Session session, String message, boolean pair) { log.debug("[TEXT]" + " : " + mid + " : " + rid + " : " + uid + message + " : " + session.getRequestURI()); } | resolved fixed | 7fd7279 | ["test/org/apache/tomcat/websocket/pojo/TestPojoMethodMapping.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-15T20:41:58Z" | "2013-03-04T09:40:00Z" |
54,702 | Bug 54702 File descriptor leak at web.xml loading | Hello I think I've found a file descriptor leak in file /tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java (method getGlobalWebXmlSource). A stream is from file "web.xml" is not closed. private WebXml getDefaultWebXmlFragment() { ... 1284 InputSource globalWebXml = getGlobalWebXmlSource(); ... 1337 // Parse global web.xml if present 1338 if (globalWebXml == null) { 1339 // This is unusual enough to log 1340 log.info(sm.getString("contextConfig.defaultMissing")); 1341 } else { 1342 parseWebXml(globalWebXml, webXmlDefaultFragment, false); 1343 } Here is the full stack trace [java.io.FileInputStream.<init>(FileInputStream.java:109)] [org.apache.catalina.startup.ContextConfig.getWebXmlSource(ContextConfig.java:1837)] [org.apache.catalina.startup.ContextConfig.getGlobalWebXmlSource(ContextConfig.java:1744)] [org.apache.catalina.startup.ContextConfig.getDefaultWebXmlFragment(ContextConfig.java:1417)] [org.apache.catalina.startup.ContextConfig.webConfig(ContextConfig.java:1253)] [org.apache.catalina.startup.ContextConfig.configureStart(ContextConfig.java:878)] [org.apache.catalina.startup.ContextConfig.lifecycleEvent(ContextConfig.java:369)] [org.apache.catalina.util.LifecycleSupport.fireLifecycleEvent(LifecycleSupport.java:119)] [org.apache.catalina.util.LifecycleBase.fireLifecycleEvent(LifecycleBase.java:90)] [org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5173)] [org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)] [org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901)] [org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877)] [org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633)] [org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:977)] [org.apache.catalina.startup.HostConfig.deployApps(HostConfig.java:542)] [org.apache.catalina.startup.HostConfig.check(HostConfig.java:1462)] [sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)] [sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)] [sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)] [java.lang.reflect.Method.invoke(Method.java:597)] [org.apache.tomcat.util.modeler.BaseModelMBean.invoke(BaseModelMBean.java:301)] [com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.invoke(DefaultMBeanServerInterceptor.java:836)] [com.sun.jmx.mbeanserver.JmxMBeanServer.invoke(JmxMBeanServer.java:761)] [org.apache.catalina.manager.ManagerServlet.check(ManagerServlet.java:1445)] [org.apache.catalina.manager.HTMLManagerServlet.upload(HTMLManagerServlet.java:301)] [org.apache.catalina.manager.HTMLManagerServlet.doPost(HTMLManagerServlet.java:208)] [javax.servlet.http.HttpServlet.service(HttpServlet.java:647)] [javax.servlet.http.HttpServlet.service(HttpServlet.java:728)] [org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305)] [org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)] [org.apache.catalina.filters.CsrfPreventionFilter.doFilter(CsrfPreventionFilter.java:213)] [org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)] [org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)] [org.apache.catalina.filters.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:108)] [org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:243)] [org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210)] [org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222)] [org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123)] [org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:581)] [org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)] [org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99)] [org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:931)] [org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118)] [org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407)] [org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004)] [org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589)] [org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1822)] [java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)] [java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)] [java.lang.Thread.run(Thread.java:662)] | resolved fixed | 7c88af9 | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-15T13:57:19Z" | "2013-03-15T12:20:00Z" |
54,658 | Bug 54658 Implement Part#getSubmittedFileName from SERVLET_SPEC-57 | null | resolved fixed | ca205c1 | ["java/javax/servlet/http/Part.java", "java/org/apache/catalina/connector/Request.java", "java/org/apache/catalina/core/ApplicationPart.java", "java/org/apache/catalina/manager/HTMLManagerServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-14T20:34:32Z" | "2013-03-10T01:46:40Z" |
54,660 | Bug 54660 AccessLogValve fileDateFormat can not be changed through JMX | When an AccessLogValve is added to a catalina host with the JMX addVale() operation on the Host object name, the valve will start with the default fileDateFormat. Changing the attribute on the valve through it's JMX object name has no effect because the valve is already started. Executing a rotate() operation on the valve does also have no effect. Steps to Reproduce: - Start tomcat server - Add Host using JMX - Add valve to Host using JMX - Set valve attribute fileDateFormat to something else than yyyy-MM-dd, for example yy-MM Actual Results: The access log file format will include the default fileDateFormat of yyyy-MM-dd Expected Results: The access log file format with yy-MM, as from the example. | resolved fixed | 2a03ca6 | ["java/org/apache/catalina/valves/AccessLogValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-14T15:47:24Z" | "2013-03-10T10:06:40Z" |
54,690 | Bug 54690 HTTPS BIO/NIO connector does not enable TLS 1.1 and TLS 1.2 by default | null | closed fixed | fedf189 | ["java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-14T14:41:51Z" | "2013-03-13T21:26:40Z" |
54,671 | Bug 54671 Spec says ServerContainerProvider#getServerContainer() should be public, but implemented package-private in Tomcat 8.0 | null | resolved fixed | 28c599f | ["java/javax/websocket/server/ServerContainerProvider.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-11T22:48:07Z" | "2013-03-12T03:46:40Z" |
54,628 | Bug 54628 there is something wrong when send binary data by websocket. | there is something wrong when send binary data by websocket. see org.apache.catalina.websocket.WsOutbound.doWriteBytes(ByteBuffer, boolean) I think // Write the content upgradeOutbound.write(buffer.array(), 0, buffer.limit()); upgradeOutbound.flush(); should change to : // Write the content upgradeOutbound.write(buffer.array(), buffer.arrayOffset(), buffer.limit()); upgradeOutbound.flush(); For example: byte[] bts = new byte[]{1,2,3,4,5} ByteBuffer bf = ByteBuffer.wrap(bts, 2, 2); out.writeBinaryMessage(bf); I mean write [3,4] to the client, but in fact [1,2,3,4] be sent; | resolved fixed | e1d16fd | ["java/org/apache/catalina/websocket/WsOutbound.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-06T20:52:19Z" | "2013-03-02T13:13:20Z" |
54,624 | Bug 54624 Form authenticator hangs on re-authentication of POST request behind mod_proxy_ajp | Setup: Tomcat AJP connector behind mod_proxy_ajp, form-based authentication. When session expires and a POST request is submitted, Tomcat shows login form, user logs in, authenticator tries to restore the original POST request. Doing that, it tries to swallow the AJP message body before replacing the body of the request with the original POST request body. It tries to read the first 4 bytes of the AJP message (the message length) and blocks forever waiting for those 4 bytes. | resolved fixed | c9e056c | ["java/org/apache/catalina/authenticator/FormAuthenticator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-06T20:45:28Z" | "2013-03-01T03:53:20Z" |
54,612 | Bug 54612 Fatal Error when trying to send data to WebSocket with conection closed | null | resolved fixed | 1255d32 | ["java/org/apache/catalina/websocket/WsOutbound.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-06T17:23:57Z" | "2013-02-27T10:13:20Z" |
54,638 | Bug 54638 /manager/status?XML=true | Hi all, in /manager/status?XML=true, informations about memory pools are incorrect. for every row all the values (initial,committed,maximum,used) are the same: Memory Pools Name:Eden Space Type:Heap memory Initial:143130624 Committed:143130624 Maximum:143130624 Used:143130624 Name:Survivor Space Type:Heap memory Initial:17891328 Committed:17891328 Maximum:17891328 Used:17891328 Name:Tenured Gen Type:Heap memory Initial:357957632 Committed:357957632 Maximum:357957632 Used:357957632 Name:Code Cache Type:Non-heap memory Initial:163840 Committed:8421376 Maximum:33554432 Used:163840 Name:Perm Gen Type:Non-heap memory Initial:12582912 Committed:23330816 Maximum:67108864 Used:12582912 Name:Perm Gen [shared-ro] Type:Non-heap memory Initial:10485760 Committed:10485760 Maximum:10485760 Used:10485760 Name:Perm Gen [shared-rw] Type:Non-heap memory Initial:12582912 Committed:12582912 Maximum:12582912 Used:12582912 Instead in the gui page values are correct. | resolved fixed | 78b3c10 | ["java/org/apache/catalina/manager/StatusTransformer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-03-06T00:40:04Z" | "2013-03-05T16:13:20Z" |
54,585 | Bug 54585 WebappLoader doesn't honor delegate attr while constructing jsp_classpath | If custom WebappClassLoader is created with delegate=true then parent-first classloading model is used. Everything works here as expected. However jsp_classpath is always constructed in the following manner: customWebappClassLoader.urls;parent.urls;parent...parent.urls Whereas it is expected to me that if delegate=true then parent's urls should come first. | resolved fixed | 9ad4904 | ["java/org/apache/catalina/loader/WebappLoader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-28T00:36:50Z" | "2013-02-20T03:13:20Z" |
54,602 | Bug 54602 B2CConverter character decode underflow leaves bytes in buffer | If a request contains a uri that ends in a multi byte character which is missing a byte the extra bytes are left in a buffer which is reused by a future request. The problem comes from two different things: 1) If B2CConverter tries to convert a ByteChunk which ends in a character underflow it does not convert that last character and it is left in a buffer in B2CConver. 2) The B2CConverter in org.apache.catalina.connector.Request is not recycled with the rest of the objects. It looks like this is done intentionally based on the comment above it's declaration. The issue with B2CConverter can be demonstrated with the code below, which is a simplification of what is done inside of CoyoteAdapter.convertURI(): <code> B2CConverter conv = new B2CConverter("UTF-8"); ByteChunk bc = new ByteChunk(); CharChunk cc = new CharChunk(); byte[] bytes = { 0x61, 0x62, 0x63, 0x64, -8, -69, -73, -77 }; bc.append(bytes, 0, bytes.length); cc.allocate(bc.getLength(), -1); conv.convert(bc, cc, cc.getBuffer().length - cc.getEnd()); System.out.println(cc); cc.recycle(); bc.recycle(); bc.append(bytes, 0, bytes.length); cc.allocate(bc.getLength(), -1); conv.convert(bc, cc, cc.getBuffer().length - cc.getEnd()); System.out.println(cc); </code> If the B2CConverter was recycled with everything else in Request this would prevent a previous request from corrupting the next request but it doesn't fix the issue that a character is dropped from the initial decode. I tried playing with B2CConverter and the only way I could get the convert to get everything was by ignoring the limit argument and reading to the end of the stream. It looks like tomcat8 is moving in this direction with the move to NIO, however I tried playing with the latest B2CConverter and was still seeing issues with the given byte sequence. | resolved fixed | b2f0e7c | ["java/org/apache/catalina/connector/CoyoteAdapter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-22T21:38:20Z" | "2013-02-23T00:40:00Z" |
54,203 | Bug 54203 Part class missing documentation | null | resolved fixed | 81eaf63 | ["java/javax/servlet/http/Part.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-13T09:50:21Z" | "2012-11-25T13:26:40Z" |
54,552 | Bug 54552 Completed Servlet 3.1 spec for changeSessionId, HttpSessionIdListener | null | resolved fixed | c11952d | ["java/javax/servlet/http/HttpServletRequest.java", "java/javax/servlet/http/HttpServletRequestWrapper.java", "java/javax/servlet/http/HttpSessionIdListener.java", "java/org/apache/catalina/connector/Request.java", "java/org/apache/catalina/connector/RequestFacade.java", "java/org/apache/catalina/core/ApplicationContext.java", "java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/ha/session/DeltaManager.java", "java/org/apache/catalina/session/ManagerBase.java", "java/org/apache/catalina/websocket/WsHttpServletRequestWrapper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-13T09:28:58Z" | "2013-02-12T20:13:20Z" |
54,536 | Bug 54536 ErrorReportValve doesn't respect HttpServletResponse.sendError(int sc, String msg) | null | resolved fixed | ef9ed07 | ["java/org/apache/catalina/valves/ErrorReportValve.java", "test/org/apache/catalina/valves/TestErrorReportValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-12T20:06:11Z" | "2013-02-07T18:00:00Z" |
54,239 | Bug 54239 Extensible EL Interpreter | null | resolved fixed | f8ac6a0 | ["java/org/apache/jasper/compiler/ELInterpreter.java", "java/org/apache/jasper/compiler/ELInterpreterFactory.java", "java/org/apache/jasper/compiler/Generator.java", "test/org/apache/jasper/compiler/TestELInterpreterFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-12T14:50:39Z" | "2012-12-04T11:20:00Z" |
54,456 | Bug 54456 ChunkedInputFilter returning EOF when client closes connection without sending end chunk | null | resolved fixed | cc2f8db | ["java/org/apache/coyote/http11/filters/ChunkedInputFilter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-07T11:55:36Z" | "2013-01-21T20:26:40Z" |
54,521 | Bug 54521 DigestAuthenticator: nonceCountValid() fails in case of simultaneous asynchronous requests of the same client | Concerned components: org.apache.catalina.authenticator.DigestAuthenticator org.apache.catalina.authenticator.DigestAuthenticator.NonceInfo Scenario: A multithreaded client sends two requests within one millisecond. The DigestAuthenticator creates for each request a nonce as well as a NonceInfo instance. The two nonces are equal, as they were created within the same millisecond. When writing data into the cache (method generateNonce()), the second NonceInfo instance overwrites the first one (same key!). Problem: The two client threads then send a second request with a digest authentication header. In both requests, nc (nonce count) is equal 1, as the nonce has been newly created. In the NonceInfo of the first request, array seen is set to true for index ((nonceCount + offset) % seen.length). In the second request the same NonceInfo instance is used, as the instance is retrieved from map nonces using nonce as a key, that is, in both requests the same key is used. Consequently, method nonceCountValid() returns false, as seen[(nonceCount + offset) % seen.length)] has already been set to true. Therefore the authentication fails, although the client has sent a valid digest authentication header. Conclusion: Working with multi-threaded clients with many requests, digest authentication does not function reliably. | resolved fixed | b68bbb8 | ["java/org/apache/catalina/authenticator/DigestAuthenticator.java", "test/org/apache/catalina/authenticator/TestDigestAuthenticator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-07T11:00:57Z" | "2013-02-04T15:00:00Z" |
54,513 | Bug 54513 NullPointerException in AprEndpoint$Poller.run | Trunk at r1441188, running the test suite with APR connector, Native 1.1.26 Windows 32-bit with JDK 7u11. I encountered the following when running org.apache.catalina.loader.TestVirtualContext test On second re-run of the test the same issue happened, so it is as if there is something specific here. I have not encountered the issue with the rest of testsuite yet. [[[ Feb 01, 2013 2:07:26 AM org.apache.tomcat.util.net.AprEndpoint$Poller run WARNING: Unexpected poller error java.lang.NullPointerException at org.apache.tomcat.util.net.AprEndpoint$AprSocketWrapper.access$200(AprEndpoint.java:2198) at org.apache.tomcat.util.net.AprEndpoint$Poller.run(AprEndpoint.java:1632) at java.lang.Thread.run(Thread.java:722) ]]] The code at AprEndpoint$Poller.run(AprEndpoint.java:1632) is 1628 for (int n = 0; n < rv; n++) { 1629 timeouts.remove(desc[n*2+1]); 1630 AprSocketWrapper wrapper = connections.get( 1631 Long.valueOf(desc[n*2+1])); 1632 wrapper.pollerFlags = wrapper.pollerFlags & ~((int) desc[n*2]); I suspect that "wrapper" is null here. The above code is specific to Tomcat trunk and is not present in 7.0.x. When this happened, the test hung for 15 minutes (1000 secs) waiting on a socket read. When time out passed, it continued to run all the other tests. [[[ Testcase: testAdditionalWebInfClassesPaths took 1 006,735 sec Caused an ERROR Read timed out java.net.SocketTimeoutException: Read timed out at java.net.SocketInputStream.socketRead0(Native Method) at java.net.SocketInputStream.read(SocketInputStream.java:150) at java.net.SocketInputStream.read(SocketInputStream.java:121) at java.io.BufferedInputStream.fill(BufferedInputStream.java:235) at java.io.BufferedInputStream.read1(BufferedInputStream.java:275) at java.io.BufferedInputStream.read(BufferedInputStream.java:334) at sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:633) at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:579) at sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1322) at java.net.HttpURLConnection.getResponseCode(HttpURLConnection.java:468) at org.apache.catalina.startup.TomcatBaseTest.methodUrl(TomcatBaseTest.java:247) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:219) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:213) at org.apache.catalina.startup.TomcatBaseTest.getUrl(TomcatBaseTest.java:202) at org.apache.catalina.loader.TestVirtualContext.assertPageContains(TestVirtualContext.java:326) at org.apache.catalina.loader.TestVirtualContext.assertPageContains(TestVirtualContext.java:320) at org.apache.catalina.loader.TestVirtualContext.testAdditionalWebInfClassesPaths(TestVirtualContext.java:311) ]]] | resolved fixed | bbb13f6 | ["java/org/apache/tomcat/util/net/AprEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-02T20:38:29Z" | "2013-02-01T03:40:00Z" |
54,497 | Bug 54497 RuntimeException in WebappClassLoader.checkThreadLocalMapForLeaks() causes LifecycleException | Observed this when testing Tomcat trunk at r1438747, at WinXP 32-bit, JDK 7u11. (running TestWsWebSocketContainer with APR, Tomcat-Native 1.1.26 RC) There occurred an NPE in WebappClassLoader.checkThreadLocalMapForLeaks(). It was uncaught and caused LifecycleException and ultimately a failure to stop Tomcat. =============== In stderr: SEVERE: A child container failed during stop java.util.concurrent.ExecutionException: org.apache.catalina.LifecycleException: Failed to stop component [StandardEngine[Tomcat].StandardHost[localhost].StandardContext[]] at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:252) at java.util.concurrent.FutureTask.get(FutureTask.java:111) at org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:974) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) at org.apache.catalina.core.ContainerBase$StopChild.call(ContainerBase.java:1404) at org.apache.catalina.core.ContainerBase$StopChild.call(ContainerBase.java:1393) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Caused by: org.apache.catalina.LifecycleException: Failed to stop component [StandardEngine[Tomcat].StandardHost[localhost].StandardContext[]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) ... 7 more Caused by: org.apache.catalina.LifecycleException: Failed to stop component [WebappLoader[]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.core.StandardContext.stopInternal(StandardContext.java:5365) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) ... 7 more Caused by: java.lang.NullPointerException at sun.reflect.UnsafeFieldAccessorImpl.ensureObj(UnsafeFieldAccessorImpl.java:54) at sun.reflect.UnsafeObjectFieldAccessorImpl.get(UnsafeObjectFieldAccessorImpl.java:36) at java.lang.reflect.Field.get(Field.java:372) at org.apache.catalina.loader.WebappClassLoader.checkThreadLocalMapForLeaks(WebappClassLoader.java:2247) at org.apache.catalina.loader.WebappClassLoader.checkThreadLocalsForLeaks(WebappClassLoader.java:2188) at org.apache.catalina.loader.WebappClassLoader.clearReferences(WebappClassLoader.java:1731) at org.apache.catalina.loader.WebappClassLoader.stop(WebappClassLoader.java:1641) at org.apache.catalina.loader.WebappLoader.stopInternal(WebappLoader.java:491) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) ... 9 more =============== In testcase: Testcase: testSmallTextBufferClientTextMessage took 2,328 sec Caused an ERROR Failed to stop component [StandardServer[-1]] org.apache.catalina.LifecycleException: Failed to stop component [StandardServer[-1]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.startup.Tomcat.stop(Tomcat.java:336) at org.apache.catalina.startup.TomcatBaseTest.tearDown(TomcatBaseTest.java:163) Caused by: org.apache.catalina.LifecycleException: Failed to stop component [StandardService[Tomcat]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.core.StandardServer.stopInternal(StandardServer.java:766) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) Caused by: org.apache.catalina.LifecycleException: Failed to stop component [StandardEngine[Tomcat]] at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:236) at org.apache.catalina.core.StandardService.stopInternal(StandardService.java:501) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) Caused by: org.apache.catalina.LifecycleException: A child container failed during stop at org.apache.catalina.core.ContainerBase.stopInternal(ContainerBase.java:981) at org.apache.catalina.util.LifecycleBase.stop(LifecycleBase.java:232) =============== Thoughts: 1. We should catch throwables in those checkFor**Leaks methods. It should not cause a "failed to stop component" failure. 2. In that method there are many calls to "table[j]". The array member should be evaluated only once, so that it does not become null unexpectedly. | resolved fixed | ea16bda | ["java/org/apache/catalina/loader/WebappClassLoader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-02-01T12:45:41Z" | "2013-01-26T03:13:20Z" |
54,496 | Bug 54496 ..tribes.membership.MemberImpl.toString() might be better using .getClass().getName() | public String toString() { StringBuilder buf = new StringBuilder("org.apache.catalina.tribes.membership.MemberImpl["); Might be better to use .getClass().getName() to cover StaticMember and any other sub-classes that might arise. | resolved fixed | e1e4e4e | ["java/org/apache/catalina/tribes/membership/MemberImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-28T15:18:04Z" | "2013-01-26T00:26:40Z" |
53,869 | Bug 53869 Performance tuning solution to resolve too many cascaded JspContextWrapper issue | null | resolved fixed | ce55f25 | ["java/org/apache/jasper/runtime/JspContextWrapper.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-25T12:06:04Z" | "2012-09-13T18:13:20Z" |
54,476 | Bug 54476 incorrect param specification in javadoc ...tribes.group.GroupChannel send methods | * @param destination Member[] - destination.length > 1 I believe this should be: * @param destination Member[] - destination.length > 0 | resolved fixed | 6647531 | ["java/org/apache/catalina/tribes/group/GroupChannel.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-24T08:52:26Z" | "2013-01-24T01:13:20Z" |
54,466 | Bug 54466 No file name information in detail error when compiling the java file generated from a tag file | null | resolved fixed | d7f744c | ["java/org/apache/jasper/compiler/DefaultErrorHandler.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-23T19:40:40Z" | "2013-01-22T13:06:40Z" |
54,458 | Bug 54458 DataSourceRealm should provide more info on SQLException | The getPassword() method of the DataSourceRealm does not log enough information when it encounters an SQL error. The catch block is: } catch(SQLException e) { containerLog.error( sm.getString("dataSourceRealm.getPassword.exception", username)); } finally { it would be really helpful to have some details of what the SQLException is. I am getting this intermittently, and have resorted to subclassing getPassword() in an attempt to figure out what is going wrong. | resolved fixed | 07a930d | ["java/org/apache/catalina/realm/DataSourceRealm.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-23T15:55:17Z" | "2013-01-22T02:00:00Z" |
54,450 | Bug 54450 Injection fails when part of the servlet properties uses @Resource and the other uses 'injection-target' | Hi, I have a servlet with: - annotated properties - and injection-target declarations in web.xml When I try to request this servlet I receive: javax.naming.NameNotFoundException: Name [envEntry1] is not bound in this Context. Unable to find [envEntry1]. at org.apache.naming.NamingContext.lookup(NamingContext.java:820) at org.apache.naming.NamingContext.lookup(NamingContext.java:154) at org.apache.naming.NamingContext.lookup(NamingContext.java:831) at org.apache.naming.NamingContext.lookup(NamingContext.java:168) at org.apache.catalina.core.DefaultInstanceManager.lookupMethodResource(DefaultInstanceManager.java:622) at org.apache.catalina.core.DefaultInstanceManager.processAnnotations(DefaultInstanceManager.java:466) at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:157) at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:138) at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1137) at org.apache.catalina.core.StandardWrapper.allocate(StandardWrapper.java:858) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:136) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) The problem is that when the application uses 'injection-target' declarations in org.apache.catalina.core.DefaultInstanceManager.populateAnnotationsCache(Class<?>, Map<String, String>) only the first setter method is evaluated and the rest are skipped. I would like to propose a patch and test case. I'm looking forward to your comments. Regards Violeta | resolved fixed | ac78456 | ["java/org/apache/catalina/core/DefaultInstanceManager.java", "test/org/apache/catalina/startup/TestContextConfig.java", "test/org/apache/catalina/startup/TesterServletWithAnnotations.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-23T10:57:27Z" | "2013-01-18T23:00:00Z" |
54,448 | Bug 54448 Field of primitive type, annotated with @Resource is not recognized as env entry | Hi, I have a servlet with one field of primitive type. The field is annotated with @Resource. public class MyServlet extends HttpServlet { @Resource(mappedName = "1") private int envEntry; protected void doGet(HttpServletRequest req, HttpServletResponse resp) throws ServletException, IOException { ... } } When I request this servlet I receive the following exception: SEVERE: Allocate exception for servlet MyServlet javax.naming.NamingException: Cannot create resource instance at org.apache.naming.factory.ResourceEnvFactory.getObjectInstance(ResourceEnvFactory.java:117) at javax.naming.spi.NamingManager.getObjectInstance(NamingManager.java:304) at org.apache.naming.NamingContext.lookup(NamingContext.java:843) at org.apache.naming.NamingContext.lookup(NamingContext.java:154) at org.apache.naming.NamingContext.lookup(NamingContext.java:831) at org.apache.naming.NamingContext.lookup(NamingContext.java:168) at org.apache.catalina.core.DefaultInstanceManager.lookupFieldResource(DefaultInstanceManager.java:581) at org.apache.catalina.core.DefaultInstanceManager.processAnnotations(DefaultInstanceManager.java:470) at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:157) at org.apache.catalina.core.DefaultInstanceManager.newInstance(DefaultInstanceManager.java:138) at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1137) at org.apache.catalina.core.StandardWrapper.allocate(StandardWrapper.java:858) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:136) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:407) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1004) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:310) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908) at java.lang.Thread.run(Thread.java:680) That's because in the method below the primitive types are not 'converted' to their corresponding wrappers and this field is interpreted not as env entry but as resource env ref. org.apache.catalina.startup.WebAnnotationSet.addResource(Context, Resource, String, String) I'm attaching a patch that solves this issue and a test case. I'm looking forward to your comments. Regards Violeta | resolved fixed | 74f5b3a | ["java/org/apache/catalina/deploy/NamingResources.java", "java/org/apache/catalina/startup/WebAnnotationSet.java", "java/org/apache/catalina/util/Introspection.java", "test/org/apache/catalina/startup/TestContextConfig.java", "test/org/apache/catalina/startup/TesterServletWithAnnotations.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-23T10:09:03Z" | "2013-01-18T03:33:20Z" |
54,324 | Bug 54324 Support is required to disable TLS compression to prevent against CRIME attacks | null | resolved fixed | ab44514 | ["java/org/apache/coyote/http11/Http11AprProtocol.java", "java/org/apache/tomcat/jni/SSL.java", "java/org/apache/tomcat/util/net/AprEndpoint.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-17T20:03:00Z" | "2012-12-19T04:06:40Z" |
54,438 | Bug 54438 Bug fix 52953 introduces NullPointerException in RealmBase.java line 409 when user not found in JDBC | null | resolved fixed | c8d5d88 | ["java/org/apache/catalina/realm/RealmBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-17T14:30:39Z" | "2013-01-17T02:33:20Z" |
54,440 | Bug 54440 TagPluginManager.init() throws NPE when used in Ant <jasper> task | null | resolved fixed | 297b26a | ["java/org/apache/jasper/JspC.java", "java/org/apache/jasper/servlet/JspCServletContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-17T13:17:42Z" | "2013-01-17T08:06:40Z" |
54,406 | Bug 54406 NIO and BIO connectors handle unsupported SSL ciphers and sslEnabledProtocols differently | The NIO and BIO connectors share (most of) a JSSE based SSLImplementation, but differ in their handling of the ciphers and sslEnabledProtocols attributes. The NIO connector sets the configured values for both attributes directly on the SSLEngine, which will fail immediately if any of them are unsupported. This makes creating a portable/superset collection of ciphers impossible - i.e. IBM JDKs do not support many of the cipher suite names used by JSSE and vice versa (usually TLS_ vs SSL_ prefixes differ) and the supported options differ between Java 6/7 etc. The BIO connector attempts to filter the specified values down to those supported by the SSL implementation, but has issues as well: if none of the specified ciphers/protocols are supported it will silently use the defaults of the SSL implementation, which can lead to unexpectedly (and unwittingly) insecure configurations. I propose to: - modify the NIO connector to use the same logic as the BIO connector to filter requested ciphers/protocols to supported values (by placing these operations on the SSLUtil interface). - modify the ciphers/protocols filtering logic to treat an explicit list of unsupported options as setting no supported ciphers/protocols and warn when this is done (it will also fail visibly with errors if SSL connections are attempted). | resolved fixed | 9f657ac | ["java/org/apache/tomcat/util/net/NioEndpoint.java", "java/org/apache/tomcat/util/net/SSLUtil.java", "java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-13T22:04:31Z" | "2013-01-11T02:06:40Z" |
54,387 | Bug 54387 Having servlets with same url should at least cause warning | I've found this interesting "mal functioning" in a application where I just copied the mapping portion of web.xml for a new created servlet, but forgot to change de URI. Tomcat deployed the application without any warning, but when running the application only the last referenced servlet was working (like if the mapping of the first has been overwritten by the last in the XML file). I made additional tests using annotations in servlets, and the behavior of having more than one servlet with same mapping causes random access to one or another (I cannot determine a predictable way). In order to prevent breaking existing applications, I would like to have just a "big warning" in the log at startup and/or deployment of the application that have more than one servlet mapped to same URL. Examples of the problem: Example 1: Web.xml ... <servlet> <servlet-name>PrintDacteServlet</servlet-name> <servlet-class>br.com.simfreteV1.web.PrintDacteServlet</servlet-class> </servlet> <servlet> <servlet-name>CotacaoReportServlet</servlet-name> <servlet-class>br.com.simfreteV1.web.CotacaoReportServlet</servlet-class> </servlet> <servlet-mapping> <servlet-name>PrintDacteServlet</servlet-name> <url-pattern>/secure/relatorios/Action</url-pattern> </servlet-mapping> <servlet-mapping> <servlet-name>CotacaoReportServlet</servlet-name> <url-pattern>/secure/relatorios/Action</url-pattern> </servlet-mapping> ... Example 2: annotations in java servlet files @WebServlet(name = "PdfReportPrint", urlPatterns = {"/secure/relatorios/doReport"}) public class PdfReportPrint extends AbstractBaseServlet { ... @WebServlet(name = "PrintBoletoServlet", urlPatterns = {"/secure/relatorios/doReport"}) public class PrintBoletoServlet extends HttpServlet { ... | resolved fixed | 334c466 | ["java/org/apache/catalina/deploy/WebXml.java", "test/org/apache/catalina/deploy/TestWebXml.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-10T12:06:50Z" | "2013-01-08T18:33:20Z" |
54,379 | Bug 54379 Implement support for post-construct and pre-destroy elements in web.xml | null | resolved fixed | 71d075e | ["java/org/apache/catalina/Context.java", "java/org/apache/catalina/core/DefaultInstanceManager.java", "java/org/apache/catalina/core/StandardContext.java", "java/org/apache/catalina/deploy/WebXml.java", "java/org/apache/catalina/startup/FailedContext.java", "java/org/apache/catalina/startup/WebRuleSet.java", "java/org/apache/catalina/util/Introspection.java", "test/org/apache/catalina/core/TestStandardContext.java", "test/org/apache/catalina/core/TesterContext.java", "test/org/apache/catalina/deploy/TestWebXml.java", "test/org/apache/catalina/startup/TestContextConfig.java", "test/org/apache/catalina/startup/TestWebRuleSet.java", "test/org/apache/catalina/startup/TesterServletWithLifeCycleMethods.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-10T11:39:46Z" | "2013-01-07T09:13:20Z" |
54,382 | Bug 54382 Nullpointer Exception after activating SSI and loading of any html-file with a specific comment | 1. Activate SSI on Tomcat and restart Tomcat 2. create an any html-file with a comment like this "<!--#-->" 3. put this html-file to the webapp folder of tomcat 4. when you now go to the html file via tomcat, you will get an Nullpointer Exception. The SSIServlet.class and other necessary SSI-classes cannot be found | resolved fixed | d83a5e5 | ["java/org/apache/catalina/ssi/SSIProcessor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-08T21:41:44Z" | "2013-01-08T04:40:00Z" |
54,381 | Bug 54381 Websocket StreamInbound never reports receipt of a Pong | The tomcat websocket api now allows the send of a Ping frame by the server (as of 7.0.33), via WsOutbound, but never reports the receipt of a Pong. See StreamInbound in the onData() method... } else if (opCode == Constants.OPCODE_PONG) { // NO-OP } As the intended use of Pings is for heartbeat messages, allowing a Ping without informing the server extension of the returned Pong leaves out half the utility. I would suggest these changes to StreamInbound as a fix... 1) In the onData() method... } else if (opCode == Constants.OPCODE_PONG) { onPong(frame.getPayLoad()); } 2) Add a method onPong (ByteBuffer buffer)... protected void onPong(ByteBuffer buffer) { // NO-OP } ...which implementations may now override to handle Pong receipt and heartbeat logic. This is necessary as onData() is marked final, so there's no alternate workaround. | resolved fixed | 5f7af1b | ["java/org/apache/catalina/websocket/StreamHandler.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-08T20:44:30Z" | "2013-01-08T01:53:20Z" |
54,377 | Bug 54377 RemoteIpFilter does not correctly set request attributes for AccessLog | In RemoteIpFilter class, there is code that publishes the new request attributes to AccessLog (see below). 821 if (requestAttributesEnabled) { 822 request.setAttribute(AccessLog.REMOTE_ADDR_ATTRIBUTE, 823 request.getRemoteAddr()); 824 request.setAttribute(AccessLog.REMOTE_HOST_ATTRIBUTE, 825 request.getRemoteHost()); 826 request.setAttribute(AccessLog.PROTOCOL_ATTRIBUTE, 827 request.getProtocol()); 828 request.setAttribute(AccessLog.SERVER_PORT_ATTRIBUTE, 829 Integer.valueOf(request.getServerPort())); 830 } The problem is that the source values should come from xRequest, e.g. xRequest.getRemoteAddr() and xRequest.getRemoteHost(), etc. As it is written above, RemoteIpFilter simply republishes the current values, and AccessLog therefore does not display the correct values. | resolved fixed | 95e6056 | ["java/org/apache/catalina/filters/RemoteIpFilter.java", "test/org/apache/catalina/filters/TestRemoteIpFilter.java", "test/org/apache/catalina/valves/TestRemoteIpValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-08T20:24:10Z" | "2013-01-06T05:26:40Z" |
54,380 | Bug 54380 In MapperListener.lifecycleEvent(..): check state of parent before calling registerWrapper() | null | resolved fixed | 3a9990b | ["java/org/apache/catalina/mapper/MapperListener.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-08T06:52:50Z" | "2013-01-07T17:33:20Z" |
54,248 | Bug 54248 Retrieving content that contains a BOM via request.getReader() issue | If a request contains Content that includes the BOM - in my case Content-Type: application/xml; charset-utf-16 - and the content has a BOM (FF FE), when fetched utilizing the BufferedReader from getReader() - the first request serviced on the AJP thread works correctly (encoded correctly, only characters fetched), however, any subsequent request on the thread which includes the BOM has the BOM being delivered to the application. It appears via review of the Tomcat code, that the recycle() method in B2CConverter simply ensures the socket's data has been completely flushed and the underlying InputStream doesn't get reset (don't really know if there is a way to do this without re-instantiating it) to ensure subsequent requests BOM is consumed. I proved this as a test by adding a call to reset() within the recycle() method which re-instantiates the underlying InputStreams and the problem resolved itself. I've temporarily resolved the issue in my application code by using request.getInputStream() and using request.getCharacterEncoding() and encoding the content inside my application. | resolved fixed | f7fc27a | ["java/org/apache/tomcat/util/buf/B2CConverter.java", "test/org/apache/tomcat/util/buf/TestB2CConverter.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-07T23:00:47Z" | "2012-12-05T17:53:20Z" |
54,284 | Bug 54284 Util.objectNameValueNeedsQuote throws NPE for anonymous Filters | How to reproduce? From inside the contextInitialized-Method of an ServletContextListener instance, call context.addFilter(null, new ArbitraryFilter(pathPrefix)).addMappingForUrlPatterns(null, false, pathPrefix); What happens? Dec 12, 2012 3:59:03 PM org.apache.catalina.core.StandardContext filterStart SEVERE: Exception starting filter null java.lang.NullPointerException at org.apache.tomcat.util.modeler.Util.objectNameValueNeedsQuote(Util.java:26) at org.apache.catalina.core.ApplicationFilterConfig.registerJMX(ApplicationFilterConfig.java:421) at org.apache.catalina.core.ApplicationFilterConfig.initFilter(ApplicationFilterConfig.java:282) at org.apache.catalina.core.ApplicationFilterConfig.<init>(ApplicationFilterConfig.java:108) at org.apache.catalina.core.StandardContext.filterStart(StandardContext.java:4650) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5306) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:901) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:877) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:633) at org.apache.catalina.startup.HostConfig.deployDescriptor(HostConfig.java:657) at org.apache.catalina.startup.HostConfig$DeployDescriptor.run(HostConfig.java:1637) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Dec 12, 2012 3:59:03 PM org.apache.catalina.core.StandardContext startInternal SEVERE: Error filterStart Dec 12, 2012 3:59:03 PM org.apache.catalina.core.StandardContext startInternal SEVERE: Context [] startup failed due to previous errors What should happen? Either - if null is not an allowed filter name, throw a IllegalArgumentException on context.addFilter(...) Or, if it is an allowed filter name, handle null-values gracefully | resolved fixed | 113c0bd | ["java/org/apache/catalina/core/ApplicationContext.java", "java/org/apache/catalina/deploy/FilterDef.java", "java/org/apache/catalina/deploy/ServletDef.java", "test/org/apache/catalina/core/TestApplicationContext.java", "test/org/apache/catalina/deploy/TestFilterDef.java", "test/org/apache/catalina/deploy/TestServletDef.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-07T19:08:58Z" | "2012-12-12T22:06:40Z" |
54,262 | Bug 54262 An empty <absolute-ordering /> should turn off all web-fragments | The use of an <absolute-ordering> element does disable ServletContainerInitializer classpath scanning as discussed also in issue 53619. However, it does seem to require having at least one web-fragment name to be listed. In other words I would this: <absolute-ordering /> To turn off all web-fragments since none are named. A workaround is to list a web-fragment even if it doesn't exist but that shouldn't be necessary. | resolved fixed | 5418e2b | ["java/org/apache/catalina/deploy/WebXml.java", "java/org/apache/catalina/startup/WebRuleSet.java", "test/org/apache/catalina/startup/TestContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-07T18:44:22Z" | "2012-12-08T04:13:20Z" |
54,370 | Bug 54370 NPE mapping method in EL | null | resolved fixed | 5361e86 | ["java/org/apache/el/util/ReflectionUtil.java", "test/org/apache/el/util/TestReflectionUtil.java", "test/org/apache/el/util/Tester.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-03T15:38:00Z" | "2013-01-03T19:06:40Z" |
54,260 | Bug 54260 JSP unloading - NullPointerException when using ".tag" files | null | resolved fixed | 94da507 | ["java/org/apache/jasper/util/FastRemovalDequeue.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-03T14:18:01Z" | "2012-12-07T22:40:00Z" |
54,256 | Bug 54256 Enhance Exception reporting on JAR file error | (I posted this to the mailing list on Oct 28, 2011, but didn't end up creating a report on it until now. I have the same error with Tomcat 7.) PROBLEM DESCRIPTION: I have an exception (appended below), and I think it would be nice to have more information about what is going on. If I had more context, it would help me find the cause of my problem much more quickly. For example, if the exception indicated what the file/resource that was having the problem was, it would speed up troubleshooting immensely. HOW TO REPRODUCE: In a JAR file contained in WAR file's WEB-INF/lib folder: Change the MANIFEST.MF file in the JAR file. Put in a line with ONLY "Class-Path:". Note there is no space after the period, which is what causes the error. During load of the application, the exception which I have appended at the end of this message will show up. SUGGESTED IMPROVEMENT: My suggestion would be to modify ExtensionValidator.validateApplication(...), around line 195. This is the location that actually knows about what the resource is. It would be nice if the IOException was caught, and information about the Resource was added to the exception, probably by wrapping the exception. Because I have not gone through the overhead of getting a version of Tomcat running from source, these changes have not been compiled and tested, but I think the suggestion is relatively straight-forward. Here are the suggested code changes: First code change - move the definition of "resource" outside of the try/catch: // Locate the Manifests for all bundled JARs Resource resource = null; // ADDED NamingEnumeration<Binding> ne = null; Second code change - make the existing declaration of "resource" just an assignment: resource = (Resource) obj; // MODIFIED inputStream = resource.streamContent(); Manifest jmanifest = getManifest(inputStream); Third code change: add a catch clause and re-throw: } catch (NamingException nex) { // Jump out of the check for this application because it // has no resources } catch (IOException ioex) { // ADDED throw new IOException("validation problem in " + resource.toString(), ioex); // ADDED } finally { The problem is that the resource may not have a proper toString(). I would suggest changing FileDirContext:898 (inner class=FileResource) to have a toString method, something along the lines of: public String toString() { // ADDED return file == null ? "null" : file.toString(); // ADDED } // ADDED Note: about this, in the original email thread, Konstantin Kolinko said: "Not sure about FileResource.toString(), but adding a catch for IOException looks like doable." Finally, here's the exception: 28-Oct-2011 11:03:03 AM org.apache.catalina.core.StandardContext startInternal SEVERE: Error in dependencyCheck java.io.IOException: invalid header field at java.util.jar.Attributes.read(Attributes.java:410) at java.util.jar.Manifest.read(Manifest.java:199) at java.util.jar.JarInputStream.<init>(JarInputStream.java:83) at java.util.jar.JarInputStream.<init>(JarInputStream.java:60) at org.apache.catalina.util.ExtensionValidator.getManifest(ExtensionValidator.java:394) at org.apache.catalina.util.ExtensionValidator.validateApplication(ExtensionValidator.java:195) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5037) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1033) at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:774) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1033) at org.apache.catalina.core.StandardEngine.startInternal(StandardEngine.java:291) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.core.StandardService.startInternal(StandardService.java:443) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.core.StandardServer.startInternal(StandardServer.java:727) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:148) at org.apache.catalina.startup.Catalina.start(Catalina.java:621) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.catalina.startup.Bootstrap.start(Bootstrap.java:322) at org.apache.catalina.startup.Bootstrap.main(Bootstrap.java:450) (And if only java.util.jar.Attributes.read reported WHICH attribute had the problem, we'd really be in business.) | resolved fixed | 0ae2f34 | ["java/org/apache/catalina/util/ExtensionValidator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-02T21:48:09Z" | "2012-12-07T00:26:40Z" |
54,247 | Bug 54247 Exception in JmxRemoteLifecycleListener.destroyServer | null | resolved fixed | 29c4a0e | ["java/org/apache/catalina/startup/Bootstrap.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-02T20:37:16Z" | "2012-12-05T15:06:40Z" |
54,241 | Bug 54241 NPE in BodyContentImpl | null | resolved fixed | ffc4525 | ["java/org/apache/jasper/runtime/JspWriterImpl.java", "test/org/apache/jasper/runtime/TestJspWriterImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2013-01-02T14:47:01Z" | "2012-12-04T14:06:40Z" |
54,194 | Bug 54194 NPE in DataSource.registerJmx() although DataSource is created with setJmxEnabled(false) | null | resolved fixed | 1c61fb1 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSource.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-12-04T06:31:27Z" | "2012-11-23T19:46:40Z" |
54,150 | Bug 54150 SlowQueryReportJmx mbean deregistration failure due to NPE - properties not set during pool close callback | Found while debugging version 7.0.29 I found that our SlowQueryReportJmx mbean was not being deregistered during webapp shutdown. I tracked this down to a NPE. The interceptor properties are not being set (as is done in setupConnection) prior to the pool close callback. ConnectionPool.close(boolean) poolClosed callback produces NPE in SlowQueryReportJmx. {code} PoolProperties.InterceptorDefinition[] proxies = getPoolProperties().getJdbcInterceptorsAsArray(); for (int i=0; i<proxies.length; i++) { try { proxies[i].getInterceptorClass().newInstance().poolClosed(this); }catch (Exception x) { log.debug("Unable to inform interceptor of pool closure.",x); } } ... {code} NPE in SlowQueryReportJmx - null.containsKey {code} public ObjectName getObjectName(Class<?> clazz, String poolName) throws MalformedObjectNameException { ... NPE if (getProperties().containsKey(objectNameAttribute)) { ... {code} Sounds reasonable to set properties any time you need to instantiate interceptors. As is done in ConnectionPool.init(PoolConfiguration) {code} JdbcInterceptor interceptor = proxies[i].getInterceptorClass().newInstance(); interceptor.setProperties(proxies[i].getProperties()); interceptor.poolStarted(this); {code} | resolved fixed | b021a22 | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-12-04T06:03:27Z" | "2012-11-15T22:53:20Z" |
54,220 | Bug 54220 ErrorReportValve invoked on non-error responses too | null | resolved fixed | a2d1441 | ["java/org/apache/catalina/valves/ErrorReportValve.java", "test/org/apache/catalina/valves/TestErrorReportValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-12-03T14:19:39Z" | "2012-11-29T00:46:40Z" |
54,217 | Bug 54217 JDBC connection pool runs out of connections when Context reload=true is enabled in Tomcat | null | resolved fixed | a81538d | ["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-12-03T11:45:47Z" | "2012-11-28T16:26:40Z" |
54,207 | Bug 54207 javaURLContextFactory javadoc refers to defunct package names in initial context properties | Javadoc for org.apache.naming.java.javaURLContextFactory: /** * Context factory for the "java:" namespace. * <p> * <b>Important note</b> : This factory MUST be associated with the "java" URL * prefix, which can be done by either : * <ul> * <li>Adding a * java.naming.factory.url.pkgs=org.apache.catalina.util.naming property * to the JNDI properties file</li> * <li>Setting an environment variable named Context.URL_PKG_PREFIXES with * its value including the org.apache.catalina.util.naming package name. * More detail about this can be found in the JNDI documentation : * {@link javax.naming.spi.NamingManager#getURLContext(java.lang.String, java.util.Hashtable)}.</li> * </ul> * * @author Remy Maucherat * @version $Id$ */ org.apache.catalina.util.naming is a very old package name. The correct name for both TC6 and TC7 is org.apache.naming . | resolved fixed | d6b4740 | ["java/org/apache/naming/java/javaURLContextFactory.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-26T11:29:15Z" | "2012-11-26T06:06:40Z" |
54,198 | Bug 54198 Improve HttpServletResponse#sendError(int) JavaDoc description | This methods calls sendError(int, null) internally. Thus generating a HTML page without a message. This is not mentioned in the docs. One could assume that the response will be empty. One could duplicate the first paragraph of the sendError(int,String) method and alter it to "The server defaults to creating the response to look like an HTML-formatted server error page with any specific message, setting the content type to "text/html",..." further "If an error-page declaration has been made for the web application corresponding to the status code passed in, it will be served back." (Might need improvement in this case, I am not a native speaker). Moreover, I would add "This method is effectively the same as calling sendError(int, null)". Plus add @see #sendError(int,String). Though the JavaDocs seems to be a verbatim copy of Oracle's Servlet API, it does not reveal this information explicitly. Should I provide a patch if that doc is available in svn.apache.org? | resolved fixed | 3c13e90 | ["java/javax/servlet/http/HttpServletResponse.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-26T11:08:02Z" | "2012-11-24T04:06:40Z" |
54,144 | Bug 54144 Processing of java.io.Reader in "Out" tagplugin | null | resolved fixed | 7c4a841 | ["java/org/apache/jasper/tagplugins/jstl/Util.java", "java/org/apache/jasper/tagplugins/jstl/core/Out.java", "test/org/apache/jasper/tagplugins/jstl/core/TestOut.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-16T23:56:12Z" | "2012-11-14T13:33:20Z" |
54,143 | Bug 54143 Add display of PermGen memory pool usage to the Status page of the Manager webapp | null | resolved fixed | 9998c80 | ["java/org/apache/catalina/manager/StatusTransformer.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-13T22:49:52Z" | "2012-11-14T02:26:40Z" |
54,141 | Bug 54141 Configuration does not allow Realms to be nested more than 2 levels deep | null | resolved fixed | 2ed3d7d | ["java/org/apache/catalina/startup/RealmRuleSet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-13T14:17:42Z" | "2012-11-13T07:00:00Z" |
54,087 | Bug 54087 HTTP Connector incorrectly throws Exception on Invalid If-Modified-Since Header | null | resolved fixed | 810732d | ["java/javax/servlet/http/HttpServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-12T11:32:26Z" | "2012-11-01T20:00:00Z" |
54,115 | Bug 54115 Minor enhancements to HttpClient test helper class | null | resolved fixed | 8f53c89 | ["test/org/apache/catalina/startup/SimpleHttpClient.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-11T23:47:34Z" | "2012-11-07T23:13:20Z" |
54,124 | Bug 54124 wrong javax.servlet.async.request_uri information and javax.servlet.async.path_info is missing | As it is clearly shown that org.apache.catalina.core.AsyncContextImpl.dispatch(ServletContext, String) @Override public void dispatch(ServletContext context, String path) { if (log.isDebugEnabled()) { logDebug("dispatch "); } check(); if (request.getAttribute(ASYNC_REQUEST_URI)==null) { request.setAttribute(ASYNC_REQUEST_URI, request.getRequestURI()+"?"+request.getQueryString()); request.setAttribute(ASYNC_CONTEXT_PATH, request.getContextPath()); request.setAttribute(ASYNC_SERVLET_PATH, request.getServletPath()); request.setAttribute(ASYNC_QUERY_STRING, request.getQueryString()); } .... } the value of ASYNC_REQUEST_URI is not the same as request.getRequestURI(). They must be equal to each other as defined by Servlet 3.0, 9.7.2 Dispatched Request Parameters. And ASYNC_PATH_INFO is missing. | resolved fixed | 76f84eb | ["java/org/apache/catalina/core/AsyncContextImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-11T23:43:18Z" | "2012-11-09T16:53:20Z" |
54,123 | Bug 54123 servlet 3.0 spec violation in async timeout processing | null | resolved fixed | 14637ef | ["java/org/apache/catalina/core/AsyncContextImpl.java", "java/org/apache/catalina/core/StandardHostValve.java", "java/org/apache/coyote/AsyncStateMachine.java", "test/org/apache/catalina/core/TestAsyncContextImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-11T23:26:55Z" | "2012-11-09T16:53:20Z" |
54,127 | Bug 54127 WsOutbound is missing a ping method | null | resolved fixed | 8fea85c | ["java/org/apache/catalina/websocket/WsOutbound.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-09T20:32:01Z" | "2012-11-10T01:13:20Z" |
54,096 | Bug 54096 env-entry rejects legal types | In servlet 3.0 the type in an env-entry can be any type which has a public constructor taking a single String (or character) as an argument. Tomcat only accepts a fixed list of types (see NamingContextListener from line 813). This is legal in web.xml but not accepted by tomcat: <env-entry> <env-entry-name>location</env-entry-name> <env-entry-type>java.io.File</env-entry-type> <env-entry-value>/var/lib/tomcat</env-entry-value> </env-entry> | resolved fixed | 48314f9 | ["java/org/apache/catalina/core/NamingContextListener.java", "test/org/apache/catalina/core/TestNamingContextListener.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-09T19:31:07Z" | "2012-11-04T23:00:00Z" |
54,076 | Bug 54076 SPNEGO authenticator's stateless-ness incompatible with stateful clients | null | resolved fixed | 9f65875 | ["java/org/apache/catalina/authenticator/SpnegoAuthenticator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-11-03T22:32:33Z" | "2012-10-30T18:00:00Z" |
54,068 | Bug 54068 Web fragment sorting incorrectly detects circular reference | null | resolved fixed | 07d343a | ["java/org/apache/catalina/deploy/WebXml.java", "test/org/apache/catalina/deploy/TestWebXmlOrdering.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-31T21:57:26Z" | "2012-10-30T09:40:00Z" |
54,067 | Bug 54067 Upgrade Response with Transfer-Encoding: chunked invalid | null | resolved fixed | 9308b3f | ["java/org/apache/coyote/http11/AbstractHttp11Processor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-29T19:47:26Z" | "2012-10-29T22:33:20Z" |
53,867 | Bug 53867 Performance tuning solution for PageContextImpl.XmlEscape | null | resolved fixed | c40ca99 | ["java/org/apache/jasper/runtime/PageContextImpl.java", "test/org/apache/jasper/runtime/TesterPageContextImpl.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-28T21:51:02Z" | "2012-09-13T18:13:20Z" |
54,054 | Bug 54054 2 CGIServlet's with different Parameter passShellEnvironment | null | resolved fixed | 05fe671 | ["java/org/apache/catalina/servlets/CGIServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-26T19:58:57Z" | "2012-10-26T11:13:20Z" |
54,022 | Bug 54022 CometEvent.END event is not sent on a suspended socket disconnect when running with Tomcat Native (tcnative-1.dll) on Windows Vista / Windows Server 2008 or newer. | null | resolved fixed | 874c332 | ["java/org/apache/coyote/AbstractProtocol.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-25T22:12:33Z" | "2012-10-17T21:40:00Z" |
54,017 | Bug 54017 new String instance is generated for constant string in Generator.convertString | If the target class is "Object.class", the generator generates "new String(" + quoted + ")"; as attribute value for Tag Handler. How about using quoted directly same as when the target class is "Object.class"? Creating a String instance will cause some overhead from memory allocation and hash code recaluation when it is used as a key on HashMap. Here is the detail code, /* * @param c The target class to which to coerce the given string @param * s The string value @param attrName The name of the attribute whose * value is being supplied @param propEditorClass The property editor * for the given attribute @param isNamedAttribute true if the given * attribute is a named attribute (that is, specified using the * jsp:attribute standard action), and false otherwise */ private String convertString(Class<?> c, String s, String attrName, Class<?> propEditorClass, boolean isNamedAttribute) { String quoted = s; if (!isNamedAttribute) { quoted = quote(s); } if (propEditorClass != null) { String className = c.getCanonicalName(); return "(" + className + ")org.apache.jasper.runtime.JspRuntimeLibrary.getValueFromBeanInfoPropertyEditor(" + className + ".class, \"" + attrName + "\", " + quoted + ", " + propEditorClass.getCanonicalName() + ".class)"; } else if (c == String.class) { return quoted; } else if (c == boolean.class) { return JspUtil.coerceToPrimitiveBoolean(s, isNamedAttribute); } else if (c == Boolean.class) { return JspUtil.coerceToBoolean(s, isNamedAttribute); } else if (c == byte.class) { return JspUtil.coerceToPrimitiveByte(s, isNamedAttribute); } else if (c == Byte.class) { return JspUtil.coerceToByte(s, isNamedAttribute); } else if (c == char.class) { return JspUtil.coerceToChar(s, isNamedAttribute); } else if (c == Character.class) { return JspUtil.coerceToCharacter(s, isNamedAttribute); } else if (c == double.class) { return JspUtil.coerceToPrimitiveDouble(s, isNamedAttribute); } else if (c == Double.class) { return JspUtil.coerceToDouble(s, isNamedAttribute); } else if (c == float.class) { return JspUtil.coerceToPrimitiveFloat(s, isNamedAttribute); } else if (c == Float.class) { return JspUtil.coerceToFloat(s, isNamedAttribute); } else if (c == int.class) { return JspUtil.coerceToInt(s, isNamedAttribute); } else if (c == Integer.class) { return JspUtil.coerceToInteger(s, isNamedAttribute); } else if (c == short.class) { return JspUtil.coerceToPrimitiveShort(s, isNamedAttribute); } else if (c == Short.class) { return JspUtil.coerceToShort(s, isNamedAttribute); } else if (c == long.class) { return JspUtil.coerceToPrimitiveLong(s, isNamedAttribute); } else if (c == Long.class) { return JspUtil.coerceToLong(s, isNamedAttribute); } else if (c == Object.class) { return "new String(" + quoted + ")"; } else { String className = c.getCanonicalName(); return "(" + className + ")org.apache.jasper.runtime.JspRuntimeLibrary.getValueFromPropertyEditorManager(" + className + ".class, \"" + attrName + "\", " + quoted + ")"; } } | resolved fixed | 095a403 | ["java/org/apache/jasper/compiler/Generator.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-25T12:14:09Z" | "2012-10-17T13:20:00Z" |
54,012 | Bug 54012 No "pageContext" in tag files' generated java code when using code generation by JSTL tagplugin "Set" | null | resolved fixed | a0ff3f9 | ["java/org/apache/jasper/compiler/Compiler.java", "java/org/apache/jasper/compiler/PageInfo.java", "java/org/apache/jasper/compiler/TagPluginManager.java", "java/org/apache/jasper/compiler/tagplugin/TagPluginContext.java", "java/org/apache/jasper/tagplugins/jstl/core/Set.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-25T11:57:13Z" | "2012-10-16T12:20:00Z" |
54,045 | Bug 54045 ReplicatedMap don't like TcpFailureDetector in static configuration | Tribes stack using: * TcpPingInterceptor * TcpFailureDetector * MessageDispatchInterceptor * StaticMembershipInterceptor Do not work well in static cluster. First side (ie one thread): * call to TcpFailureDetector.heartbeat() * call to checkMembers(false) * call to performBasicCheck() in synchronized(membership) * in performBasicCheck, for a missing static node: * add "missing" member to membership with membership.memberAlive(m) * HERE THE SECOND THREAD HAVE SOME TIME TO WORK * check it with memberAlive(m) * remove it since if it doesn't exist Second side (ie another thread): * some call to channel.getMembers() like what the done by AbstractReplicatedMap * this call will call the TcpFailureDetector.getMembers() * this one could return a wrong value since it can contains unavailable nodes Note: * synchronize on membership isn't use by TcpFailureDetector in getMember(), getMembers(), hasMembers(), neither in Membership equivalent method (maybe because it's too heavy to lock every thread while the TcpFailureDetector check if node are alive). It must not be an issue for AbstractReplicatedMap since with or without TcpFailureDetector a node could disapear while replicated map try to use it. But ReplicatedMap use always Channel.SEND_OPTIONS_DEFAULT where the value is Channel.SEND_OPTIONS_USE_ACK. So a message sent to a missing node will fail with an exception. Personnaly I override TcpFailureDetector.heartbeat() to avoid performBasicCheck() if I use a static configuration (TcpPingInterceptor call performForcedCheck()). But this doesn't fix ReplicatedMap issue. Better fix could avoid adding missing member to membership list: * Add a method like memberAlive(MemberImpl) to Membership without side effect (add the member) * in TcpFailureDetector.performBasicCheck(): check this new method before adding the node This doesn't fix the AbstractReplicatedMap issue which work always with acknoledge from other nodes. Same code for Tomcat 6. best regards F.Arnoud | resolved fixed | d2b41b5 | ["java/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-25T11:51:10Z" | "2012-10-23T19:20:00Z" |
54,010 | Bug 54010 Suggestion for code improvement (avoiding potential bug) | In connectors/jk/java/org/apache/jk/common/HandlerRequest.java coyote.Request's schemeMB is assigned in 2 places. 1st place: 400 boolean isSSL = msg.getByte() != 0; 401 if( isSSL ) { 402 // XXX req.setSecure( true ); 403 req.scheme().setString("https"); 404 } 2nd place: 518 case AjpConstants.SC_A_SSL_CERT : 519 req.scheme().setString( "https" ); and similar assignments for SC_A_SSL_CIPHER and SC_A_SSL_SESSION cases below. It seems they do not make sense because the packet's 8-bit field is designated for telling whether it's SSL or not. So the 1st place is enough. Adding the 2nd place may pose potential bug in that a packet with the 8-bit SSL field being 0 and suffixes of SC_A_SSL_* key-value pairs can later incorrect trigger a wrong redirection message pointing to a https location. A simple correction is to honor the 8-bit SSL-field in packet and delete the 3 lines of 2nd place assigning "https". Even though the chances of such spurious packet is low, but it's best we can have threat-free, semantic-correct tomcat code. The same lines of code remain in 6.0 and 7.0. But maybe I misunderstand the code, in which case please kindly point out. Thanks. | resolved fixed | 9f04094 | ["java/org/apache/coyote/ajp/AbstractAjpProcessor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-22T22:48:38Z" | "2012-10-16T06:46:40Z" |
53,993 | Bug 53993 NPE in AccessLogValve | During a load test of tomcat 7.0.30, we occasionally see NPEs from the AccessLogValve. Some of the requests that are being executed as part of the load test call HttpSession.invalidate. I mention this because the code in question appears to be susceptible to multithreaded manipulation of the session. I think the fix should be as simple as a check for null on the return value of request.getSessionInternal. Of course, our access log pattern includes logging the session id. java.lang.NullPointerException org.apache.catalina.valves.AccessLogValve$SessionIdElement.addElement(AccessLogValve.java:1733) org.apache.catalina.valves.AccessLogValve.log(AccessLogValve.java:955) org.apache.catalina.core.AccessLogAdapter.log(AccessLogAdapter.java:51) org.apache.catalina.core.StandardEngine.logAccess(StandardEngine.java:332) org.apache.catalina.core.ContainerBase.logAccess(ContainerBase.java:1270) org.apache.catalina.core.ContainerBase.logAccess(ContainerBase.java:1270) org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:441) org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1002) org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:585) org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312) java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) java.lang.Thread.run(Thread.java:722) existing code for convenience: protected static class SessionIdElement implements AccessLogElement { @Override public void addElement(StringBuilder buf, Date date, Request request, Response response, long time) { if (request != null) { if (request.getSession(false) != null) { buf.append(request.getSessionInternal(false) // LINE 1733 .getIdInternal()); } else { buf.append('-'); } } else { buf.append('-'); } } } possible fix: ... if (request.getSession(false) != null) { Session internalSession = request.getSessionInternal(false); if (internalSession != null) { buf.append(internalSession.getIdInternal()); } else { buf.append('-'); } } else { buf.append('-'); } | resolved fixed | 39c4270 | ["java/org/apache/catalina/valves/AccessLogValve.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-13T15:56:21Z" | "2012-10-12T00:00:00Z" |
53,986 | Bug 53986 Comment end tag preceded directly by a dash causes JSP fail compilation | null | resolved fixed | 88d8dd5 | ["java/org/apache/jasper/compiler/JspReader.java", "test/org/apache/jasper/compiler/TestJspReader.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-10-10T14:19:40Z" | "2012-10-09T22:00:00Z" |
53,854 | Bug 53854 DefaultServlet directory listings for aliased directories do not seem to work | null | resolved fixed | a3e0f09 | ["java/org/apache/naming/resources/BaseDirContext.java", "java/org/apache/naming/resources/FileDirContext.java", "java/org/apache/naming/resources/WARDirContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-09-30T19:45:00Z" | "2012-09-12T00:33:20Z" |
53,863 | Bug 53863 Unable to override default servlet when using Tomcat in embedded mode | An implementation of ServletContainerInitializer can't add a mapping to "/" because the default servlet is loaded first, as first reported in 51278: public final class SampleServletContainerInitializer implements ServletContainerInitializer { public void onStartup(final Set<Class<?>> c, final ServletContext ctx) throws ServletException { final XmlWebApplicationContext appCtx = new XmlWebApplicationContext(); appCtx.setConfigLocation("/WEB-INF/DispatcherServlet-servlet.xml"); final ServletRegistration.Dynamic dispatcher = ctx.addServlet("DispatcherServlet", new DispatcherServlet(appCtx)); dispatcher.setLoadOnStartup(1); final Set<String> conflictSet = dispatcher.addMapping("/"); for (final String conflict : conflictSet) out.println(conflict); // prints "/" } } A test case follows attached. | resolved fixed | 7f6f99e | ["java/org/apache/catalina/startup/Tomcat.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-09-16T18:15:21Z" | "2012-09-13T07:06:40Z" |
52,777 | Bug 52777 Automatically shut down old versions in parallel deployment | Under parallel deployment, when an older version in an application has zero sessions, shut it down automatically to release tomcat and JVM resources. Christopher Schultz suggested these approaches might be possible (on the Tomcat user list): 1. Modify the parallel deployment code to register an MBean NotificationListener that filters for useful events (such as expiring session notifications on the outgoing webapp). 2. When the listener receives a notification, check the current state (e.g. session count=0; or, I suppose you could make this a part of your filter in step #1). If session count = 0, start a new thread that stops the outgoing webapp and de-registers the listener. Or. 1. Install a SessionEventListener that counts-down the sessions (you'll have to get the count from JMX, I suppose) until they equal 0, then starts a new thread that ... etc. Or. 1. Install a Timer thread that polls at intervals (1 minute?) to see if all the sessions are dead and then starts a thread ... etc. The first idea seems the cleanest, though Tomcat might not actually fire MBean events for things like session count changing. | resolved fixed | 97cefcc | ["java/org/apache/catalina/Host.java", "java/org/apache/catalina/core/StandardHost.java", "java/org/apache/catalina/startup/HostConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-09-08T21:00:32Z" | "2012-02-27T08:06:40Z" |
53,713 | Bug 53713 Performance tuning solution for JspReader | null | resolved fixed | 5fccf68 | ["java/org/apache/jasper/compiler/JspReader.java", "java/org/apache/jasper/compiler/Mark.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-09-05T22:06:32Z" | "2012-08-14T10:26:40Z" |
53,828 | Bug 53828 StreamInbound.closeOutboundConnection(WsFrame) closes with an opcode instead of status | 201 private void closeOutboundConnection(WsFrame frame) throws IOException { 202 try { 203 getWsOutbound().close(frame); 204 } finally { 205 doOnClose(Constants.OPCODE_CLOSE); 206 } 207 } Line 205 uses the close opcode instead of a valid status (Constants.STATUS_*). Not sure of the exact context of this called but it seems to only be called when the last frame from the client was a close frame, thus a Constants.STATUS_NORMAL may be in order. If not, the frame's opcode could be inspected and mapped to an appropriate status (normal, shutdown, etc...). Thanks, Michael | resolved fixed | a81d941 | ["java/org/apache/catalina/websocket/StreamInbound.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-09-04T20:03:25Z" | "2012-09-04T20:20:00Z" |
53,801 | Bug 53801 Nondeterministic behaviour of security constraints | null | resolved fixed | 95d7a0f | ["java/org/apache/catalina/realm/RealmBase.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-30T22:55:20Z" | "2012-08-30T12:33:20Z" |
53,800 | Bug 53800 Infinte loop cause by FileDirContext in a CDI/Weld project when using Eclipse's "Server modules without publishing" | null | resolved fixed | 44eabba | ["java/org/apache/naming/resources/FileDirContext.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-30T06:43:52Z" | "2012-08-30T09:46:40Z" |
53,793 | Bug 53793 Change webapp links in Manager to point to /appname/ instead of /appname | The first column of the table that lists Web Applications in Tomcat Manager webapp contains links to those applications, e.g. <a href="/examples">/examples</a> When the link is clicked and browser navigates to "/examples", it results in 302 redirect to "/examples/". It would be better to change that link to point directly to "/examples/". <a href="/examples/">/examples</a> I am changing the link address only, but not the text on it. That is because the "Path" of the web application displayed in that column (and used in Manager commands elsewhere) does not have the additional '/'. | resolved fixed | fcc3d65 | ["java/org/apache/catalina/manager/HTMLManagerServlet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-28T22:03:33Z" | "2012-08-29T03:13:20Z" |
42,181 | Bug 42181 ArrayIndexOutOfBoundsException in parseChunkHeader | Apr 22, 2007 11:53:32 AM org.apache.coyote.http11.Http11Processor process SEVERE: Error finishing request java.lang.ArrayIndexOutOfBoundsException: -28 at org.apache.coyote.http11.filters.ChunkedInputFilter.parseChunkHeader(ChunkedInputFilter.java:256) at org.apache.coyote.http11.filters.ChunkedInputFilter.doRead(ChunkedInputFilter.java:129) at org.apache.coyote.http11.filters.ChunkedInputFilter.end(ChunkedInputFilter.java:179) at org.apache.coyote.http11.InternalInputBuffer.endRequest(InternalInputBuffer.java:368) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:894) at org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:664) at org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:527) at org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:80) at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:684) at java.lang.Thread.run(Thread.java:595) | resolved fixed | cd05aa1 | ["java/org/apache/coyote/http11/filters/ChunkedInputFilter.java", "java/org/apache/tomcat/util/buf/HexUtils.java", "test/org/apache/tomcat/util/buf/TestHexUtils.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-27T23:04:11Z" | "2007-04-22T02:46:40Z" |
53,783 | Bug 53783 Static resources and jsp files under WEB-INF/lib/*.jar!/META-INF/resources are not found | null | resolved fixed | 6b934d8 | ["java/org/apache/catalina/startup/ContextConfig.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-27T18:40:09Z" | "2012-08-27T17:53:20Z" |
53,758 | Bug 53758 Dynamic Filter Registration mapping logic inverted | In the class org.apache.catalina.core.ApplicationFilterRegistration, the methods addMappingForServletNames and addMappingForUrlPatterns have inverted logic on how to register the filter to the context. If the parameter isMatchAfter is passed as true, the filter is placed in the context using the addFilterMapBefore method. if (isMatchAfter) { context.addFilterMapBefore(filterMap); } else { context.addFilterMap(filterMap); } The logic should ultimate be (in both methods): if (!isMatchAfter) { context.addFilterMapBefore(filterMap); } else { context.addFilterMap(filterMap); } or if (isMatchAfter) { context.addFilterMap(filterMap); } else { context.addFilterMapBefore(filterMap); } svn rev on trunk is 1375614 | resolved fixed | 8f169e4 | ["java/org/apache/catalina/core/ApplicationFilterRegistration.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-26T22:29:04Z" | "2012-08-21T23:00:00Z" |
53,725 | Bug 53725 Some GZipped responses result in java.io.IOException: Corrupt GZIP trailer during gunzip. | null | resolved fixed | 3dff241 | ["java/org/apache/coyote/http11/filters/FlushableGZIPOutputStream.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-25T20:06:59Z" | "2012-08-15T22:33:20Z" |
53,714 | Bug 53714 misleading log output when jarsToSkip cointains web-fragments | I have a jar which contains a web-fragment and no TLDs. When starting the server I get the Message: org.apache.jasper.compiler.TldLocationsCache tldScanJar INFO: At least one JAR was scanned for TLDs yet contained no TLDs. Enable debug logging for this logger for a complete list of JARs that were scanned but no TLDs were found in them. Skipping unneeded JARs during scanning can improve startup time and JSP compilation time. so far so good. When adding it to the tomcat.util.scan.DefaultJarScanner.jarsToSkip property the web-fragment won't be scanned either. The log message should only be printed when no TLDs and web-fragments could be found in the jar. | resolved fixed | 15e8d8e | ["java/org/apache/catalina/startup/Constants.java", "java/org/apache/catalina/startup/ContextConfig.java", "java/org/apache/catalina/startup/TldConfig.java", "java/org/apache/jasper/Constants.java", "java/org/apache/jasper/compiler/TldLocationsCache.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-24T20:05:41Z" | "2012-08-14T13:13:20Z" |
53,697 | Bug 53697 java.lang.NullPointerException at org.apache.coyote.http11.Http11AprProcessor.actionInternal(Http11AprProcessor.java:277) | I hit tomcat with ~20 different urls in ~2 seconds, test some functionality, wait ~3 minutes, then do it again and I always get this exception and then I get (intermitent) connection interrupted messages in the browser. Here's the full trace: Aug 10, 2012 6:33:14 PM org.apache.catalina.connector.CoyoteAdapter event SEVERE: null Aug 10, 2012 6:33:14 PM org.apache.catalina.connector.CoyoteAdapter event java.lang.NullPointerException at org.apache.coyote.http11.Http11AprProcessor.actionInternal(Http11AprProcessor.java:277) at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:846) at org.apache.coyote.Response.action(Response.java:172) at org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:229) at org.apache.coyote.http11.Http11AprProcessor.event(Http11AprProcessor.java:133) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:581) at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1770) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Aug 10, 2012 6:33:14 PM org.apache.coyote.http11.Http11AprProcessor event SEVERE: Error processing request java.lang.NullPointerException at org.apache.coyote.http11.Http11AprProcessor.actionInternal(Http11AprProcessor.java:277) at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:846) at org.apache.coyote.Request.action(Request.java:346) at org.apache.catalina.connector.Request.getRemoteAddr(Request.java:1281) at org.apache.catalina.connector.Request.getRemoteHost(Request.java:1296) at org.apache.catalina.valves.AccessLogValve$HostElement.addElement(AccessLogValve.java:1327) at org.apache.catalina.valves.AccessLogValve.log(AccessLogValve.java:953) at org.apache.catalina.core.AccessLogAdapter.log(AccessLogAdapter.java:51) at org.apache.catalina.core.ContainerBase.logAccess(ContainerBase.java:1263) at org.apache.catalina.core.ContainerBase.logAccess(ContainerBase.java:1270) at org.apache.catalina.connector.CoyoteAdapter.event(CoyoteAdapter.java:250) at org.apache.coyote.http11.Http11AprProcessor.event(Http11AprProcessor.java:133) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:581) at org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:1770) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) Additional information: - hp Proliant DL360 with two 3ghz processors - CentOS 6.3 - One app runs websockets under bleading edge Atmosphere and Grails - the 20 urls come from chrome and firefox, simulatneously | resolved fixed | 6c13431 | ["java/org/apache/coyote/http11/AbstractHttp11Processor.java", "java/org/apache/coyote/http11/Http11NioProcessor.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-15T22:45:51Z" | "2012-08-11T13:00:00Z" |
53,702 | Bug 53702 Only the last url-pattern from jsp-property-group is processed | null | resolved fixed | e38a097 | ["java/org/apache/catalina/core/ApplicationJspPropertyGroupDescriptor.java", "java/org/apache/catalina/deploy/JspPropertyGroup.java", "java/org/apache/catalina/deploy/WebXml.java", "java/org/apache/catalina/startup/WebRuleSet.java"] | Tomcat | https://github.com/apache/tomcat | apache/tomcat | java | null | null | null | "2012-08-15T20:32:44Z" | "2012-08-12T19:33:20Z" |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.