issue_id
int64
2.03k
426k
title
stringlengths
9
251
body
stringlengths
1
32.8k
status
stringclasses
6 values
after_fix_sha
stringlengths
7
7
updated_files
stringlengths
29
34.1k
project_name
stringclasses
6 values
repo_url
stringclasses
6 values
repo_name
stringclasses
6 values
language
stringclasses
1 value
issue_url
null
before_fix_sha
null
pull_url
null
commit_datetime
unknown
report_datetime
unknown
55,576
Bug 55576 Order of ServletRequest parameters is not preserved
The ServletRequest interface provides two methods to iterate through request parameters: Enumeration<String> getParameterNames(), and Map<String, String[]> getParameterMap() Unfortunately, the underlying implementation in Tomcat is a HashMap, which fails to preserve the order of parameters as they are specified in the request. An alternate implementation should be used to preserve request order. LinkedHashMap, for example, is capable of preserving insertion order. The Servlet Specification (v3.0) speaks only to the relative ordering of query string data and post body data. However, section 17.13.3 of the HTML specification (v4.01) titled "Processing form data", clearly states that "control names/values are listed in the order they appear in the document." Therefore, I do not see a valid interpretation of either specification to rationalize Tomcat's implementation. To receive a request with an ordered list of parameters and represent them in an implementation that is guaranteed not to preserve this order is difficult to rationalize.
resolved fixed
90556a9
["java/org/apache/catalina/util/ParameterMap.java", "java/org/apache/tomcat/util/http/Parameters.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-23T20:52:58Z"
"2013-09-21T02:20:00Z"
55,582
Bug 55582 Concurrent issue of TagFileProcessor
null
resolved fixed
f627cc8
["java/org/apache/jasper/compiler/TagFileProcessor.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-23T13:54:31Z"
"2013-09-22T14:26:40Z"
55,570
Bug 55570 SpnegoAuthenticator: Resource file is missing placeholders for exceptions.
In java/org/apache/catalina/authenticator/SpnegoAuthenticator.java problems are logged with an exception. The exception does not show up in the logging. The exception only shows up if I hack java/org/apache/catalina/authenticator/LocalStrings.properties in catalina.jar, and add a placeholder. REPRODUCE: - Configure SP-NEGO with Kerberos. - Mess up your principal in com.sun.security.jgss.krb5.accept in jaas.config. - Try to login. - See that you get something like: FINE [org.apache.catalina.authenticator.SpnegoAuthenticator authenticate] Failed to validate client supplied ticket FIX: In java/org/apache/catalina/authenticator/LocalStrings.properties please add [{0}] to the following lines: spnegoAuthenticator.ticketValidateFail=Failed to validate client supplied ticket spnegoAuthenticator.serviceLoginFail=Unable to login as the service principal In SpnegoAuthenticator.java you can verify that exceptions are indeed passed to the log. VALIDATE: - Reproduce again - See that you now get Failed to validate client supplied ticket [GSSException: Failure unspecified at GSS-API level (Mechanism level: Invalid argument (400) - Cannot find key of appropriate type to decrypt AP REP - RC4 with HMAC)] The exception is not super-helpful, but at least it's something.
resolved fixed
910d4d9
["java/org/apache/catalina/authenticator/SpnegoAuthenticator.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-19T14:50:06Z"
"2013-09-19T17:00:00Z"
46,727
Bug 46727 DefaultServlet - serving multiple encodings
null
resolved fixed
f74257e
["java/org/apache/catalina/servlets/DefaultServlet.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-18T13:21:08Z"
"2009-02-17T19:46:40Z"
52,558
Bug 52558 CometConnectionManagerValve is adding non-serializable Request[] to Session
CometConnectionManagerValve is adding HttpServletRequest[] to HttpSession which is preventing the Session being serialized in a Clustered setup. We're resolving this locally using a serializable ConnectionList class with a transient Request[] i.e. public class ConnectionList implements Serializable { transient Request[] connectionList = null; ConnectionList(Request[] connectionList){ this.connectionList = connectionList; } public Request[] get(){ return connectionList; } }
resolved fixed
b284611
["java/org/apache/catalina/valves/CometConnectionManagerValve.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-12T11:16:15Z"
"2012-01-30T16:13:20Z"
55,552
Bug 55552 Potential NullPointerException in compiled JSPs if expected EL result is of primitive type
null
resolved fixed
66932c4
["java/org/apache/jasper/compiler/JspUtil.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-12T10:06:16Z"
"2013-09-12T10:00:00Z"
54,693
Bug 54693 Add a validationQueryTimeout property
null
resolved fixed
b022c57
["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PooledConnection.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java", "modules/jdbc-pool/src/test/java/org/apache/tomcat/jdbc/test/TestValidationQueryTimeout.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-09T10:11:07Z"
"2013-03-14T00:13:20Z"
55,521
Bug 55521 Race Condition in HttpSession#invalidate() / HttpServletRequest#getSession(boolean)
null
resolved fixed
262c069
["java/org/apache/catalina/ha/session/DeltaSession.java", "java/org/apache/catalina/session/StandardSession.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-05T15:42:48Z"
"2013-09-04T13:06:40Z"
55,527
Bug 55527 JSSESocketFactory conditionally converts alias to lower case; condition is unwise
JSSESocketFactory conditionally converts the alias to lower case. The condition is coded as follows: private static final String defaultKeystoreType = "JKS"; ... if (JSSESocketFactory.defaultKeystoreType.equals(keystoreType)) { alias = alias.toLowerCase(Locale.ENGLISH); } If the intention is to downcase only JKS store aliases, then the comparison should be made with "JKS", not a constant that happens to contain "JKS" at present. Using a specific comparator would both clarify the code and protect against a possible change to the default (albeit very unlikely).
resolved fixed
f126b5a
["java/org/apache/tomcat/util/net/jsse/JSSESocketFactory.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-05T10:36:34Z"
"2013-09-05T14:06:40Z"
55,343
Bug 55343 Add flag to ignore exceptions while creating initial pool
I want my initial pool to be of some size i.e. not empty AND start even if it fails to create all or some of connections. If pool fails to create initial connections for some reason it just throws exceptions. To workaround that I have to set initial pool size to 0. It can be handy to add a flag to ignore (just log them) exceptions that occur while creating initial connections.
resolved fixed
4aa42d7
["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceFactory.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/DataSourceProxy.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolConfiguration.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/PoolProperties.java", "modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/jmx/ConnectionPool.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-04T08:56:24Z"
"2013-08-02T10:40:00Z"
55,342
Bug 55342 Lost interruption
org.apache.tomcat.jdbc.pool.ConnectionPool#close should not call Thread.interrupted() because interrupt was already reset by code that thrown InterruptedException. } catch (InterruptedException ex) { if (getPoolProperties().getPropagateInterruptState()) { Thread.currentThread().interrupt(); - } else { - Thread.interrupted(); } }
resolved fixed
41225cd
["modules/jdbc-pool/src/main/java/org/apache/tomcat/jdbc/pool/ConnectionPool.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-04T02:17:25Z"
"2013-08-02T10:40:00Z"
55,500
Bug 55500 AsyncListener.onTimeout is not called via AJP AjpNioProtocol connector
The AsyncListener.onTimeout is not called, when timeout occurs, when traffic routed via AJP connector configured with AjpNioProtocol protocol.
resolved fixed
cf1e104
["java/org/apache/coyote/ajp/AbstractAjpProcessor.java", "java/org/apache/coyote/ajp/AjpAprProcessor.java", "java/org/apache/coyote/ajp/AjpNioProcessor.java", "java/org/apache/coyote/ajp/AjpProcessor.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-09-03T09:24:08Z"
"2013-08-29T15:26:40Z"
55,494
Bug 55494 JNDIRealm throws exception after timeout / Connection reset
null
resolved fixed
7e74aee
["java/org/apache/catalina/realm/JNDIRealm.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-28T14:02:50Z"
"2013-08-28T17:13:20Z"
55,453
Bug 55453 AJP send Body with Status 304
null
resolved fixed
6d99103
["java/org/apache/coyote/ajp/AbstractAjpProcessor.java", "test/org/apache/coyote/ajp/TestAbstractAjpProcessor.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-28T13:01:03Z"
"2013-08-20T09:13:20Z"
51,526
Bug 51526 Process web application context config with embedded Tomcat.addWebApp(...)
It would be nice if org.apache.catalina.startup.Tomcat.addWebApp(...) would process the web application's META-INF/context.xml if found. The current implementation skips META-INF/context.xml loading, and does not appear to offer any hook to enable it--the StandardContext is instantiated and initialized with a null configFile in the single call to addWebApp(...).
resolved fixed
058f044
["java/org/apache/catalina/startup/Tomcat.java", "test/org/apache/catalina/startup/TestTomcat.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-27T19:22:47Z"
"2011-07-19T01:46:40Z"
55,469
Bug 55469 Missing HTML closing tags in Manager application
null
resolved fixed
9a22360
["java/org/apache/catalina/manager/HTMLManagerServlet.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-23T06:34:50Z"
"2013-08-23T01:06:40Z"
55,454
Bug 55454 NullPointerException caused by invalid contentType, e.g. trailing semicolon
possible related to 53353 When having an invalid contenttype like: <jsp:directive.page language="java" contentType="text/html;"/> (note the trailing ";") Tomcat throws a NullPointerException like this: java.lang.NullPointerException org.apache.tomcat.util.http.parser.HttpParser.parseMediaType(HttpParser.java:217) org.apache.tomcat.util.http.parser.MediaTypeCache.parse(MediaTypeCache.java:54) org.apache.catalina.connector.Response.setContentType(Response.java:805) org.apache.catalina.connector.ResponseFacade.setContentType(ResponseFacade.java:245) javax.servlet.ServletResponseWrapper.setContentType(ServletResponseWrapper.java:123) After removing the extra ";" or entering a charset like this: <jsp:directive.page language="java" contentType="text/html; charset=UTF-8"/> it works as expected. My desired behaviour would be: Don't crash with a NPE. Other Tomcat versions seem to handly this different.
resolved fixed
8b03dcf
["java/org/apache/tomcat/util/http/parser/HttpParser.java", "test/org/apache/tomcat/util/http/parser/TestMediaType.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-20T15:02:23Z"
"2013-08-20T14:46:40Z"
55,442
Bug 55442 EL Constructor throws exception
In the EL 3.0 Spec, section 1.22.3 "Constructor Reference" states "A class name reference, followed by arguments in parenthesis, such as "Boolean(true)" denotes the invocation of the constructor of the class with the supplied arguments." This leads me to believe that the following test should work: @Test public void testImport03() { ELProcessor processor = new ELProcessor(); Object result = processor.getValue("Integer('1000')", Integer.class); Assert.assertEquals(Integer.valueOf(1000), result); } Unfortunately, this fails with the following error. javax.el.ELException: Function ':Integer' not found at org.apache.el.parser.AstFunction.getValue(AstFunction.java:136) at org.apache.el.ValueExpressionImpl.getValue(ValueExpressionImpl.java:188) at javax.el.ELProcessor.getValue(ELProcessor.java:45) at org.apache.el.parser.TestAstIdentifier.testImport03(TestAstIdentifier.java:53) ... Thanks
resolved fixed
ab70f07
["java/org/apache/el/parser/AstFunction.java", "test/org/apache/el/parser/TestAstFunction.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-20T08:38:29Z"
"2013-08-17T17:20:00Z"
55,438
Bug 55438 Non Blocking API's onAllDataRead being called twice
null
resolved fixed
7f6ea48
["java/org/apache/catalina/connector/InputBuffer.java", "java/org/apache/catalina/connector/Request.java", "java/org/apache/coyote/Request.java", "test/org/apache/catalina/nonblocking/TestNonBlockingAPI.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-19T14:54:15Z"
"2013-08-16T21:53:20Z"
55,434
Bug 55434 The path /foo/a/a/bar causes IllegalArgumentException when WsServerContainer creates UriTemplate
WsFilter calls WsServerContainer.findMapping("/foo/a/a/bar"), which in turn calls new UriTemplate(path). If the path contains repeated segments, it causes the following code in the UriTemplate constructor to throw an exception: Segment old = this.segments.put(segment, new Segment(index, segment)); if (old != null) { throw new IllegalArgumentException( sm.getString("uriTemplate.duplicateName", segment)); } This would be valid if the duplicates were URI variable names but not when their plain path segments.
resolved fixed
98ee5b4
["java/org/apache/tomcat/websocket/server/UriTemplate.java", "test/org/apache/tomcat/websocket/server/TestUriTemplate.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-18T18:14:36Z"
"2013-08-16T21:53:20Z"
55,354
Bug 55354 JNDIRealm.getPrincipal(context,username,gssCredential) corrupts realm context
The getPrincipal(context,username,gssCredential) method in JNDIRealm is designed to allow delegated credentials to be applied to the directory server connection as part of SPNEGO authentication. This is done by manipulation of a number of the directory context's environment parameters. However, as currently implemented, these environment parameters are forcibly cleared after the getUser() call regardless of whether the values were even changed (i.e. if isUseDelegatedCredential() returned false). If the container realm is defined to use GSSAPI authentication, only the first SPNEGO authentication request will succeed. All subsequent requests will fail with this exception: javax.naming.NamingException: [LDAP: error code 1 - 000004DC: LdapErr: DSID-0C0906DC, comment: In order to perform this operation a successful bind must be completed on the connection., data 0, v1db0 The exception is due to the Context.SECURITY_AUTHENTICATION being cleared by getPrincipal() - resulting in a attempted "simple" bind with no username/password (i.e. anonymous). A workaround is to ensure that the connectionName and connectionPassword parameters are specified in the realm definition - however, if one is using GSSAPI - this shouldn't be necessary and certainly defeats the purpose of using GSSAPI in the first place. The code should preserve pre-existing environment parameters in the context before changing them, then restore those values afterwards - rather than just clearing the settings completely.
resolved fixed
135e2c4
["java/org/apache/catalina/realm/JNDIRealm.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-15T20:31:48Z"
"2013-08-05T08:06:40Z"
55,357
Bug 55357 Cannot deserialize session when it contains Externalizable objects (using PersistentManager)
I'm using PersistentManager with JDBCStore to store sessions in my database. But in my webapplication, there is an object in my session which is an instance of org.apache.el.MethodExpressionImpl. This class implements the Externalizable interface but in this readExternal method it uses org.apache.el.util.ReflectionUtil.forName(String) which use Thread.currentThread().getContextClassLoader() as its ClassLoader. It seems to be incorrect because this method return a StandardClassLoader which cannot find my classes in WEB-INF/lib directory of my webapp. Is it the problem of the MethodExpressionImpl class which use this method or the JDBCStore which does not set the thread contextClassLoader as the WebappClassLoader ? Here is the stacktrace : SEVERE: Error processing request java.lang.IllegalStateException: Erreur lors de la deserialisation de la session 1634C328D27A31CB9FC4D52392FDB05F: {1} at org.apache.catalina.session.PersistentManagerBase.swapIn(PersistentManagerBase.java:713) at org.apache.catalina.session.PersistentManagerBase.findSession(PersistentManagerBase.java:503) at org.apache.catalina.connector.Request.isRequestedSessionIdValid(Request.java:2391) at org.apache.catalina.connector.CoyoteAdapter.parseSessionCookiesId(CoyoteAdapter.java:954) at org.apache.catalina.connector.CoyoteAdapter.postParseRequest(CoyoteAdapter.java:688) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:402) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1002) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:585) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:722) Caused by: java.lang.ClassNotFoundException: javax.faces.event.ActionEvent at java.net.URLClassLoader$1.run(URLClassLoader.java:366) at java.net.URLClassLoader$1.run(URLClassLoader.java:355) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:354) at java.lang.ClassLoader.loadClass(ClassLoader.java:423) at java.lang.ClassLoader.loadClass(ClassLoader.java:356) at java.lang.Class.forName0(Native Method) at java.lang.Class.forName(Class.java:266) at org.apache.el.util.ReflectionUtil.forName(ReflectionUtil.java:62) at org.apache.el.util.ReflectionUtil.toTypeArray(ReflectionUtil.java:88) at org.apache.el.MethodExpressionImpl.readExternal(MethodExpressionImpl.java:290) at java.io.ObjectInputStream.readExternalData(ObjectInputStream.java:1835) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1794) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1348) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:370) at com.sun.facelets.el.TagMethodExpression.readExternal(TagMethodExpression.java:101) at java.io.ObjectInputStream.readExternalData(ObjectInputStream.java:1835) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1794) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1348) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1989) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1913) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1796) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1348) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:370) at java.util.ArrayList.readObject(ArrayList.java:733) at sun.reflect.GeneratedMethodAccessor90.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1004) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1891) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1796) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1348) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.readArray(ObjectInputStream.java:1704) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1342) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1989) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1913) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1796) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1348) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:370) at java.util.HashMap.readObject(HashMap.java:1155) at sun.reflect.GeneratedMethodAccessor89.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1004) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1891) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1796) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1348) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:370) at java.util.HashMap.readObject(HashMap.java:1155) at sun.reflect.GeneratedMethodAccessor89.invoke(Unknown Source) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1004) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1891) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1796) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1348) at java.io.ObjectInputStream.defaultReadFields(ObjectInputStream.java:1989) at java.io.ObjectInputStream.defaultReadObject(ObjectInputStream.java:499) at org.ajax4jsf.application.AjaxStateHolder.readObject(AjaxStateHolder.java:204) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:601) at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1004) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:1891) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1796) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1348) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:370) at org.apache.catalina.session.StandardSession.readObject(StandardSession.java:1595) at org.apache.catalina.session.StandardSession.readObjectData(StandardSession.java:1060) at org.apache.catalina.session.JDBCStore.load(JDBCStore.java:657) at org.apache.catalina.session.PersistentManagerBase.swapIn(PersistentManagerBase.java:707) ... 11 more
resolved fixed
e19e794
["java/org/apache/catalina/session/FileStore.java", "java/org/apache/catalina/session/JDBCStore.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-15T14:06:20Z"
"2013-08-05T19:13:20Z"
55,400
Bug 55400 WsFilter not compatible with async sample applications
null
resolved fixed
3490f73
["java/org/apache/tomcat/websocket/server/WsServerContainer.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-14T12:29:03Z"
"2013-08-11T00:13:20Z"
55,404
Bug 55404 ContextConfig#validateSecurityRoles emits three info log messages which contain a warning
null
resolved fixed
df02b95
["java/org/apache/catalina/startup/ContextConfig.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-12T14:27:33Z"
"2013-08-12T17:53:20Z"
52,092
Bug 52092 Please make AsyncFileHandler and OneLineFormatter the default for logging.properties
Apache Tomcat 7 has created some very important enhancements to logging, and we should exploit them. Please make the org.apache.juli.AsyncFileHandler and org.apache.juli.OneLineFormatter the defaults for shipped conf/logging.properties. These enhancements have been vetted with over 20 releases of Apache Tomcat, let's give them some first class status.
resolved fixed
7d0408e
["java/org/apache/juli/FileHandler.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-07T21:14:55Z"
"2011-10-26T14:40:00Z"
55,345
Bug 55345 Webresources class AbstractResourceSet throws exception upon callong ServletContext.getRealPath("")
As described on user list: Tomcat 8, unlike Tomcat 7.0.42, throws IllegalArgumentException upon calling ServletContext.getRealPath(""). It seems that TC8 expects that argument provided to getRealPath is non-empty string. I believe that ServletContext.getRealPath should allow empty string as argument. -Ognjen Stack trace: [ERROR] java.lang.IllegalArgumentException java.lang.IllegalArgumentException at org.apache.catalina.webresources.AbstractResourceSet.checkPath(AbstractResourceSet.java:39) at org.apache.catalina.webresources.DirResourceSet.getResource(DirResourceSet.java:91) at org.apache.catalina.webresources.StandardRoot.getResourceInternal(StandardRoot.java:176) at org.apache.catalina.webresources.CachedResource.validate(CachedResource.java:62) at org.apache.catalina.webresources.Cache.getResource(Cache.java:78) at org.apache.catalina.webresources.StandardRoot.getResource(StandardRoot.java:163) at org.apache.catalina.core.StandardContext.getRealPath(StandardContext.java:4528) at org.apache.catalina.core.ApplicationContext.getRealPath(ApplicationContext.java:398) at org.apache.catalina.core.ApplicationContextFacade.getRealPath(ApplicationContextFacade.java:335) at org.apache.axis2.deployment.WarBasedAxisConfigurator.<init>(WarBasedAxisConfigurator.java:103) at org.apache.axis2.transport.http.AxisServlet.initConfigContext(AxisServlet.java:584) at org.apache.axis2.transport.http.AxisServlet.init(AxisServlet.java:454) at org.apache.catalina.core.StandardWrapper.initServlet(StandardWrapper.java:1235) at org.apache.catalina.core.StandardWrapper.loadServlet(StandardWrapper.java:1148) at org.apache.catalina.core.StandardWrapper.load(StandardWrapper.java:1044) at org.apache.catalina.core.StandardContext.loadOnStartup(StandardContext.java:5025) at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5322) at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150) at org.apache.catalina.core.ContainerBase.addChildInternal(ContainerBase.java:726) at org.apache.catalina.core.ContainerBase.addChild(ContainerBase.java:702) at org.apache.catalina.core.StandardHost.addChild(StandardHost.java:698) at org.apache.catalina.startup.HostConfig.deployWAR(HostConfig.java:968) at org.apache.catalina.startup.HostConfig$DeployWar.run(HostConfig.java:1742) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:471) at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334) at java.util.concurrent.FutureTask.run(FutureTask.java:166) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724)
closed fixed
aa15bac
["java/org/apache/catalina/core/StandardContext.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-02T20:05:43Z"
"2013-08-02T16:13:20Z"
55,333
Bug 55333 JDBCRealm Digest authentication Flow is not working throws Function sequence error
Issue: Digest authentication flow is not working Error Thrown : Function sequence error PackageName: org.apache.catalina.realm ClassName : JDBCRealm MethodName: String getPassword(String username) Snapshot from above mentioned method =================================== stmt = credentials(dbConnection, username); rs = stmt.executeQuery(); // Due to this connection commit, resultset is nullified dbConnection.commit(); // While executing this statement it throws Function sequence error if (rs.next()) { dbCredentials = rs.getString(1); } =================================== Above explanation has been validate by placing 7.0.41 catalina.jar where the above changes are not there due to fix of 55071 bug Below snapshot is the error observed while trying for Digest authentication ========================================================================== Jul 31, 2013 3:43:40 PM org.apache.catalina.realm.JDBCRealm getPassword SEVERE: Exception performing authentication java.sql.SQLException: [TimesTen][TimesTen 11.2.2.5.0 ODBC Driver]Function sequence error at com.timesten.jdbc.JdbcOdbc.createSQLException(JdbcOdbc.java:3238) at com.timesten.jdbc.JdbcOdbc.standardError(JdbcOdbc.java:3387) at com.timesten.jdbc.JdbcOdbc.SQLFetch(JdbcOdbc.java:921) at com.timesten.jdbc.JdbcOdbcResultSet.next(JdbcOdbcResultSet.java:409) at org.apache.catalina.realm.JDBCRealm.getPassword(JDBCRealm.java:558) at org.apache.catalina.realm.RealmBase.getDigest(RealmBase.java:1189) at org.apache.catalina.realm.RealmBase.authenticate(RealmBase.java:409) at com.kodiak.digest.authentication.KnDigestAuthenticator$KnDigestInfo.authenticate(KnDigestAuthenticator.java:733) at com.kodiak.digest.authentication.KnDigestAuthenticator.authenticate(KnDigestAuthenticator.java:275) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:574) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:953) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1023) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) Jul 31, 2013 3:43:40 PM org.apache.catalina.realm.JDBCRealm getPassword SEVERE: Exception performing authentication java.sql.SQLException: [TimesTen][TimesTen 11.2.2.5.0 ODBC Driver]Function sequence error at com.timesten.jdbc.JdbcOdbc.createSQLException(JdbcOdbc.java:3238) at com.timesten.jdbc.JdbcOdbc.standardError(JdbcOdbc.java:3387) at com.timesten.jdbc.JdbcOdbc.SQLFetch(JdbcOdbc.java:921) at com.timesten.jdbc.JdbcOdbcResultSet.next(JdbcOdbcResultSet.java:409) at org.apache.catalina.realm.JDBCRealm.getPassword(JDBCRealm.java:558) at org.apache.catalina.realm.RealmBase.getDigest(RealmBase.java:1189) at org.apache.catalina.realm.RealmBase.authenticate(RealmBase.java:409) "localhost.2013-07-31.log" 50L, 3800C Cheers, Mahaaboob
resolved fixed
6cd42af
["java/org/apache/catalina/realm/JDBCRealm.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-08-01T10:13:31Z"
"2013-07-31T22:33:20Z"
55,316
Bug 55316 Ugly error log when WS client disconnects unexpectedly
When a WS browser client disconnects unexpectedly (e.g. in the SNake sample if the user just closes the browser or loads another page) you get ugle ERROR logs in the Tomcat server. E.g. 2013-07-27 12:04:34.424 ERROR 31847 --- [nio-8080-exec-7] org.apache.tomcat.websocket.WsSession : Failed to send close message to remote endpoint java.io.IOException: java.util.concurrent.ExecutionException: java.io.EOFException at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.startMessageBlock(WsRemoteEndpointImplBase.java:221) at org.apache.tomcat.websocket.WsSession.sendCloseMessage(WsSession.java:466) at org.apache.tomcat.websocket.WsSession.onClose(WsSession.java:430) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.close(WsHttpUpgradeHandler.java:172) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.access$200(WsHttpUpgradeHandler.java:45) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler$WsReadListener.onDataAvailable(WsHttpUpgradeHandler.java:198) at org.apache.coyote.http11.upgrade.AbstractServletInputStream.onDataAvailable(AbstractServletInputStream.java:169) at org.apache.coyote.http11.upgrade.AbstractProcessor.upgradeDispatch(AbstractProcessor.java:95) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:630) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1585) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1543) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:724) Caused by: java.util.concurrent.ExecutionException: java.io.EOFException at org.apache.tomcat.websocket.WsRemoteEndpointImplBase$FutureToSendHandler.get(WsRemoteEndpointImplBase.java:779) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.startMessageBlock(WsRemoteEndpointImplBase.java:217) ... 14 common frames omitted Caused by: java.io.EOFException: null at org.apache.tomcat.websocket.server.WsRemoteEndpointImplServer.doClose(WsRemoteEndpointImplServer.java:126) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.close(WsRemoteEndpointImplBase.java:531) at org.apache.tomcat.websocket.server.WsRemoteEndpointImplServer.onWritePossible(WsRemoteEndpointImplServer.java:107) at org.apache.tomcat.websocket.server.WsRemoteEndpointImplServer.doWrite(WsRemoteEndpointImplServer.java:71) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.writeMessagePart(WsRemoteEndpointImplBase.java:353) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.startMessage(WsRemoteEndpointImplBase.java:254) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.startMessageBlock(WsRemoteEndpointImplBase.java:211) ... 14 common frames omitted Presumably this is expected to be relatively normal, so I'd expect a lot less noise (and no ERROR) in the log?
resolved fixed
d370084
["java/org/apache/tomcat/websocket/WsSession.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-31T14:41:55Z"
"2013-07-27T15:46:40Z"
55,312
Bug 55312 No SCI scan in embedded Tomcat
I like the fact that SCI scanning is off by default in a Tomcat embedded instance, but I'd lik eto be able to switch it on. It might even be possible already, but the API is non-obvious. Maybe a method in Tomcat or associated friendly helper? Would also be nice in Tomcat 7.
resolved fixed
7540e90
["java/org/apache/tomcat/util/scan/StandardJarScanner.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-31T13:13:10Z"
"2013-07-26T20:20:00Z"
55,309
Bug 55309 Concurrent issue of TagPluginManager
null
resolved fixed
11c05b7
["java/org/apache/jasper/compiler/TagPluginManager.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-29T20:55:45Z"
"2013-07-26T09:13:20Z"
55,287
Bug 55287 ServletContainerInitializer in parent classloader may not be found
To include the JasperInitializer in the test environment I added an entry in testclasses/META-INF/services. This is not picked up when the parent classloader is searched because this path is a directory not a JAR file. It would be picked up if the "scanAllDirectories" extension was enabled but that should not be necessary if the search is to be semantically equivalent to j.u.ServiceLoader (which does locate it).
resolved fixed
6e514c0
["java/org/apache/catalina/startup/ContextConfig.java", "java/org/apache/catalina/startup/WebappServiceLoader.java", "test/org/apache/catalina/startup/TestWebappServiceLoader.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-28T23:01:23Z"
"2013-07-21T23:40:00Z"
55,267
Bug 55267 NIO thread locked
Did some load test and thread got stuck, see dump. Basically I just simulate 100 users that connect and disconnect.
resolved fixed
11bf498
["java/org/apache/coyote/ajp/AjpNioProcessor.java", "java/org/apache/coyote/http11/InternalNioOutputBuffer.java", "java/org/apache/coyote/http11/upgrade/NioServletOutputStream.java", "java/org/apache/tomcat/util/net/NioEndpoint.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-23T14:21:38Z"
"2013-07-15T14:53:20Z"
55,291
Bug 55291 Bug in WsServerContainer leading to NPE
null
resolved fixed
ab6f21d
["java/org/apache/tomcat/websocket/server/WsServerContainer.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-22T14:26:57Z"
"2013-07-22T16:20:00Z"
55,262
Bug 55262 Duplicate preludes and codas in same <jsp-property-group> are ignored
If a <jsp-property-group> contains multiple <include-prelude> elements that happen to refer to the same file only one include is performed. The same applies to codas. This happens because WebXml stores these in a LinkedHashSet rather than a List. When multiple <jsp-property-group>s are combined, JspConfig uses a Vector and so preserves duplicates as required by the JSP spec. I have a test case demonstrating this but before committing a fix I would like confirmation that WebXml's behaviour is incorrect.
resolved fixed
85f611e
["java/org/apache/tomcat/util/descriptor/web/JspPropertyGroup.java", "test/org/apache/jasper/compiler/TestCompiler.java", "test/org/apache/jasper/servlet/TestJspCServletContext.java", "test/org/apache/tomcat/util/descriptor/web/TestJspPropertyGroup.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-20T20:46:58Z"
"2013-07-14T05:33:20Z"
55,259
Bug 55259 Unnecessary work in JspConfig
JspProperty is the same for all url patterns in a group; the current code creates a new one each iteration
resolved fixed
c6a45a6
["java/org/apache/jasper/compiler/JspConfig.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-13T22:07:49Z"
"2013-07-13T07:20:00Z"
55,245
Bug 55245 Add test cases for JspC
The test suite should include tests for the JspC Ant task
resolved fixed
c0c5017
["test/org/apache/jasper/TestJspC.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-12T08:58:10Z"
"2013-07-12T06:20:00Z"
55,250
Bug 55250 JspC does not initialize tldLocationsCache resulting in NPE
Change in how ServletContext was created missed initialization of tldLocationsCache
resolved fixed
186a782
["java/org/apache/jasper/JspC.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-12T08:50:45Z"
"2013-07-12T06:20:00Z"
55,244
Bug 55244 JspC throws ClassNotFoundException from Digester
null
resolved fixed
8d6537d
["java/org/apache/jasper/servlet/JspCServletContext.java", "java/org/apache/tomcat/util/descriptor/web/WebXmlParser.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-12T08:36:14Z"
"2013-07-12T06:20:00Z"
55,240
Bug 55240 [websocket] SOE in NioEndpoint
null
resolved fixed
68f6f6f
["java/org/apache/coyote/http11/upgrade/AbstractProcessor.java", "java/org/apache/coyote/http11/upgrade/AprProcessor.java", "java/org/apache/coyote/http11/upgrade/BioProcessor.java", "java/org/apache/coyote/http11/upgrade/NioProcessor.java", "java/org/apache/tomcat/util/net/NioEndpoint.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-11T18:08:17Z"
"2013-07-11T16:26:40Z"
55,238
Bug 55238 [websocket] NPE in clearHandler(WsRemoteEndpointImplServer.java:156)
null
resolved fixed
4758796
["java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-11T16:14:59Z"
"2013-07-11T10:53:20Z"
55,228
Bug 55228 AbstractHttp11Processor overwrites Date header, even when set by application
null
resolved fixed
95ee699
["java/org/apache/coyote/http11/AbstractHttp11Processor.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-11T15:58:31Z"
"2013-07-10T04:20:00Z"
55,207
Bug 55207 In XML syntax, jsp:text does not error on sub-elements from other namespaces
null
resolved fixed
6c54031
["java/org/apache/jasper/compiler/JspDocumentParser.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-10T19:29:26Z"
"2013-07-07T04:06:40Z"
55,231
Bug 55231 NPE and incorrect version detection in JspC
JspC's JspConfig now reads version and jsp-config information from the ServletContext. It uses getMajorVersion() which returns the maximum version supported by the container. It should use getEffectiveVersion() to use the version of the web application. ServletContext.getJspConfigDescriptor() can return null if there is no <jsp-config> in the web.xml. JspConfig does not allow for this and will throw a NPE e.g. if there is no web.xml in the application.
closed fixed
c8376e8
["java/org/apache/jasper/compiler/JspConfig.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-10T13:40:32Z"
"2013-07-10T07:06:40Z"
55,218
Bug 55218 Upgrade Digester to be based on DefaultHandler2 and use LexicalHandler to detect publicId
Digester uses SAX2 features but is still based the SAX1 DefaultHandler. By upgrading to DefaultHandler2 it would be able to handle baseURIs when resolving entities and would have a default implementation of a LexicalHandler. Using LexicalHandler would allow it to respond directly to the startDTD event that reports the DOCTYPE (if present) so that it would not need to infer that from the first attempt to resolve an entity.
closed fixed
aa7896b
["java/org/apache/catalina/core/StandardContext.java", "java/org/apache/tomcat/util/descriptor/web/WebXml.java", "java/org/apache/tomcat/util/digester/Digester.java", "test/javax/servlet/resources/TestSchemaValidation.java", "test/org/apache/tomcat/util/descriptor/web/TestWebXml.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-09T10:07:23Z"
"2013-07-09T11:40:00Z"
55,217
Bug 55217 Common EntityResolver that can be used by Catalina and Jasper
Duplicate functionality exists in both SchemaResolver and ParserUtils.MyEntityResolver. There's also a basic version in Digester.
closed fixed
5344de0
["java/org/apache/tomcat/util/descriptor/LocalResolver.java", "java/org/apache/tomcat/util/descriptor/XmlIdentifiers.java", "test/org/apache/tomcat/util/descriptor/TestLocalResolver.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-09T08:51:17Z"
"2013-07-09T11:40:00Z"
55,166
Bug 55166 schemaLocation references between servlet and jsp XSDs are invalid
The javax/servlet/resources package does not contain the JSP specification XSDs. These are referenced from the web-app or web-common xsds and define elements like <jsp-config>.
resolved fixed
f554475
["java/org/apache/catalina/startup/Constants.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-08T09:33:59Z"
"2013-07-01T00:53:20Z"
55,210
Bug 55210 SEVERE: The ServletContentInitializer [# Licensed to the Apache Software Foundation (ASF) under one or more] could not be created
null
resolved fixed
b932ace
["java/org/apache/catalina/startup/ContextConfig.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-08T06:53:50Z"
"2013-07-08T02:20:00Z"
55,200
Bug 55200 [websocket] Problem writing many subsequent binary messages
I see sometimes failing connections due to IOException (see below). This happens when trying to send thousands of binary messages (1024 bytes each) without any delay between the subsequent messages. Having look at the code in AsyncChannelWrapperSecure$WriteTask.run(219), I think it is not correct to assume that if not all of the bytes in the buffer are written, this shall produce IOException. I think in this case, there shall be an attempt to write the rest of the bytes in a cycle. Here one exception I got during the test: Exception is :java.io.IOException: java.util.concurrent.ExecutionException: java.io.IOException: Only wrote [460] of [1,098] bytes at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.startMessageBlock(WsRemoteEndpointImplBase.java:204) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.sendBytes(WsRemoteEndpointImplBase.java:113) at org.apache.tomcat.websocket.WsRemoteEndpointBasic.sendBinary(WsRemoteEndpointBasic.java:43) at WebsocketsTestManager$TestThread.run(WebsocketsTestManager.java:271) Caused by: java.util.concurrent.ExecutionException: java.io.IOException: Only wrote [460] of [1,098] bytes at org.apache.tomcat.websocket.WsRemoteEndpointImplBase$FutureToSendHandler.get(WsRemoteEndpointImplBase.java:729) at org.apache.tomcat.websocket.WsRemoteEndpointImplBase.startMessageBlock(WsRemoteEndpointImplBase.java:202) ... 3 more Caused by: java.io.IOException: Only wrote [460] of [1,098] bytes at org.apache.tomcat.websocket.AsyncChannelWrapperSecure$WriteTask.run(AsyncChannelWrapperSecure.java:220) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615) at java.lang.Thread.run(Thread.java:789)
resolved fixed
00e4f3f
["java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-05T17:22:06Z"
"2013-07-05T18:46:40Z"
55,186
Bug 55186 useIPVHosts=true , incorrect to get Request.localName
null
resolved fixed
2eb065f
["java/org/apache/coyote/Request.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-05T13:34:16Z"
"2013-07-03T05:40:00Z"
55,184
Bug 55184 NPE in PojoMethodMapping getMessageHandler
null
resolved fixed
a267dbf
["java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-02T16:45:16Z"
"2013-07-02T18:33:20Z"
55,183
Bug 55183 Missing WS Protocol Header in session negotiatedHeaders
null
resolved fixed
a634d85
["java/org/apache/tomcat/websocket/Constants.java", "java/org/apache/tomcat/websocket/WsWebSocketContainer.java", "test/org/apache/tomcat/websocket/TestWsSubprotocols.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-02T16:13:13Z"
"2013-07-02T15:46:40Z"
55,165
Bug 55165 subprotocols not available with annotated serverendpoint
null
resolved fixed
b069c78
["java/org/apache/tomcat/websocket/server/WsServerContainer.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-02T09:40:26Z"
"2013-07-01T00:53:20Z"
55,181
Bug 55181 Ping and Pong messages should have identical application data
null
resolved fixed
19c0bd3
["java/org/apache/tomcat/websocket/WsPongMessage.java", "test/org/apache/tomcat/websocket/TestWsPingPongMessages.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-02T08:26:28Z"
"2013-07-02T13:00:00Z"
55,180
Bug 55180 connectionTimeout="-1" causes timeout can't be negative
I configured server.xml like this: connectionTimeout="-1" disableUploadTimeout="false" connectionUploadTimeout="200" (maybe it is stupid to configure like this,if connectionTimeout=-1,can i make disableUploadTimeout=false?). It will cause : java.lang.IllegalArgumentException: timeout can't be negative at sun.nio.ch.SocketAdaptor.setSoTimeout(SocketAdaptor.java:361) at org.apache.coyote.http11.Http11NioProcessor.setSocketTimeout(Http11NioProcessor.java:251) ...... because of : if (!disableUploadTimeout) { //endpoint.getSoTimeout()=-1. setSocketTimeout(endpoint.getSoTimeout()); } ~~~~~~~~~~~~~~~~~~~~~~~~~ another thing: if i configure connectionTimeout="0". in NioBlockingSelector.read(ByteBuffer buf, NioChannel socket, long readTimeout),readTimeout = 0, in case socket.read(buf) == 0, it make timeout=true. if (readTimeout >= 0 && (keycount == 0)) timedout = (System.currentTimeMillis() - time) >= readTimeout; then throw the SocketTimeoutException(). thank you.
resolved fixed
4da2de0
["java/org/apache/coyote/http11/AbstractHttp11Processor.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-02T07:15:30Z"
"2013-07-02T04:40:00Z"
55,174
Bug 55174 [jsr 356][websocket] MessageHandler never gets notified again after it throws exception
I have a test which adds a MessageHandler which gets notified on text messages. If its implementation method onMessage(String text) throws some exception (e.g. runtime exception), this MessageHandler will never ever be notified again for any new text messages received by the session. I suppose this happens because the exception actually kills the underlying thread in which the notification has happened. I think the client side implementation shall be more robust and expect and be prepared for exceptions coming from calls to user code.
resolved fixed
ddd73d0
["java/org/apache/tomcat/websocket/WsFrameBase.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-01T22:08:06Z"
"2013-07-01T17:33:20Z"
55,179
Bug 55179 Incorrect Parameter Name in RemoteIpValve Examples
null
resolved fixed
21f0a5c
["java/org/apache/catalina/valves/RemoteIpValve.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-01T21:25:05Z"
"2013-07-02T01:53:20Z"
55,177
Bug 55177 connectionTimeout=-1 causes high CPU
null
resolved fixed
df6cee7
["java/org/apache/coyote/http11/Http11Processor.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-01T20:28:01Z"
"2013-07-01T23:06:40Z"
53,777
Bug 53777 Ability to bundle JAAS Configuration in Webappp
null
resolved fixed
6871d4c
["java/org/apache/catalina/realm/JAASRealm.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-01T14:57:05Z"
"2012-08-24T17:40:00Z"
55,160
Bug 55160 NIO connectionUploadTimeout can't work
when i configure disableUploadTimeout="false" and connectionTimeout="20000" ,connectionUploadTimeout="30000" . I found the connectionUploadTimeout doesn't work, because the code in internalNioInputBuffer.readSocket(): ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ try { NioEndpoint.KeyAttachment att = (NioEndpoint.KeyAttachment)socket.getAttachment(false); if ( att == null ) throw new IOException("Key must be cancelled."); nRead = pool.read(socket.getBufHandler().getReadBuffer(),socket,selector,att.getTimeout()); } catch ( EOFException eof ) { nRead = -1; } finally { if ( selector != null ) pool.put(selector); } ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ att.getTimeout() is the connectionTimeout ,not the connectionUploadTimeout. so , in NioBlockingSelector.read(), the readTimeout is connectionTimeout
resolved fixed
9a01f2d
["java/org/apache/coyote/http11/InternalNioInputBuffer.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-01T14:26:13Z"
"2013-06-30T02:40:00Z"
55,158
Bug 55158 Wasted work in AttributeNamesEnumerator constructor
null
resolved fixed
ca956bd
["java/org/apache/catalina/core/ApplicationHttpRequest.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-01T12:26:02Z"
"2013-06-29T23:53:20Z"
55,159
Bug 55159 Wasted work in ErrorReportValve.getPartialServletStackTrace
null
resolved fixed
b7cad6b
["java/org/apache/catalina/valves/ErrorReportValve.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-01T11:01:38Z"
"2013-06-29T23:53:20Z"
55,017
Bug 55017 Ability to configure RMI bind address
null
resolved fixed
45f59bb
["java/org/apache/catalina/mbeans/JmxRemoteLifecycleListener.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-07-01T09:50:38Z"
"2013-05-24T18:26:40Z"
55,151
Bug 55151 Fix in MsgByte encoder and decoder TestEncodingDecoding websocket test
null
resolved fixed
d71136a
["test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-27T20:10:40Z"
"2013-06-27T21:53:20Z"
55,102
Bug 55102 Add ability to report time taken to prepare response
null
closed fixed
7aea9cb
["java/org/apache/catalina/valves/AccessLogValve.java", "java/org/apache/coyote/Response.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-23T20:22:25Z"
"2013-06-15T21:00:00Z"
55,125
Bug 55125 Tomcat does not shut down if LifecycleListener throws an exception
null
resolved fixed
3a36a8f
["java/org/apache/catalina/core/StandardService.java", "java/org/apache/catalina/startup/Catalina.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-23T19:47:39Z"
"2013-06-21T15:53:20Z"
55,127
Bug 55127 Encoders init and destroy methods are never called
null
resolved fixed
93bcdde
["java/org/apache/tomcat/websocket/WsRemoteEndpointImplBase.java", "java/org/apache/tomcat/websocket/WsRemoteEndpointImplClient.java", "java/org/apache/tomcat/websocket/WsSession.java", "java/org/apache/tomcat/websocket/WsWebSocketContainer.java", "java/org/apache/tomcat/websocket/server/WsHttpUpgradeHandler.java", "java/org/apache/tomcat/websocket/server/WsRemoteEndpointImplServer.java", "test/org/apache/tomcat/websocket/pojo/TestEncodingDecoding.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-22T14:09:34Z"
"2013-06-22T11:20:00Z"
55,126
Bug 55126 IAE is thrown during deployment of ServerEndPoint having multiple text decoders
null
resolved fixed
366ddff
["java/org/apache/tomcat/websocket/pojo/PojoMethodMapping.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-21T21:07:06Z"
"2013-06-21T18:40:00Z"
55,101
Bug 55101 BasicAuthenticator parser and associated unit tests
null
resolved fixed
c4a50f5
["java/org/apache/catalina/authenticator/BasicAuthenticator.java", "test/org/apache/catalina/authenticator/TestBasicAuthParser.java", "test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-20T20:36:08Z"
"2013-06-15T18:13:20Z"
54,745
Bug 54745 Tomcat JarScanning does not work when Tomcat started with Java Web Start
null
resolved fixed
c7c30b6
["java/org/apache/tomcat/util/scan/StandardJarScanner.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-20T15:07:55Z"
"2013-03-23T03:40:00Z"
53,987
Bug 53987 Log uncovered HTTP methods in combined security constraints
It is usually an error (and a security hole) if security constraints are defined for some but not all HTTP methods for a given URL. If such a situation is detected on web application start, log it.
resolved fixed
f78c1a4
["java/org/apache/catalina/core/StandardContext.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-19T21:43:26Z"
"2012-10-09T22:00:00Z"
55,073
Bug 55073 wasted work in ValidateVisitor.isExpression()
null
resolved fixed
3e2ceee
["java/org/apache/jasper/compiler/Validator.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-18T07:57:32Z"
"2013-06-07T18:33:20Z"
55,108
Bug 55108 Wasted work in "AbstractReplicatedMap.excludeFromSet"
null
resolved fixed
4979721
["java/org/apache/catalina/tribes/tipis/AbstractReplicatedMap.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-18T07:32:42Z"
"2013-06-17T23:00:00Z"
55,109
Bug 55109 Wasted work in "WebdavServlet.isLocked"
null
resolved fixed
82bccd2
["java/org/apache/catalina/servlets/WebdavServlet.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-18T07:27:26Z"
"2013-06-17T23:00:00Z"
55,110
Bug 55110 Wasted work in "TestNonLoginAndBasicAuthenticator.doTestBasic"
null
resolved fixed
c48a2ed
["test/org/apache/catalina/authenticator/TestNonLoginAndBasicAuthenticator.java", "test/org/apache/tomcat/websocket/TestWsWebSocketContainer.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-18T07:18:09Z"
"2013-06-17T23:00:00Z"
55,052
Bug 55052 [JULI] Make ClassLoaderLogManager.getProperty() to try unprefixed property if prefixed one does not exist
null
resolved fixed
99562d3
["java/org/apache/juli/ClassLoaderLogManager.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-04T12:19:29Z"
"2013-06-03T17:20:00Z"
55,046
Bug 55046 CORS Filter
null
resolved fixed
72edec7
["java/org/apache/catalina/filters/CorsFilter.java", "test/org/apache/catalina/filters/TestCorsFilter.java", "test/org/apache/catalina/filters/TesterFilterChain.java", "test/org/apache/catalina/filters/TesterFilterConfigs.java", "test/org/apache/catalina/filters/TesterHttpServletRequest.java", "test/org/apache/catalina/filters/TesterHttpServletResponse.java", "test/org/apache/catalina/filters/TesterServletContext.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-04T10:51:31Z"
"2013-06-02T05:13:20Z"
55,035
Bug 55035 Deploy ROOT webapp with version through text manager using Ant
Currently Ant "deploy" task does not support separate parameter "version" and, thanks to URLEncoder, there is no workaround for that. But for apps with not empty context it's possible to define version using ##, like setting path to "/someContext#someVersion". For apps with empty context we receive error: Case #1: <deploy url="{tomcat.manager}/text" username="${username}", password="${password}" path="/ROOT##12345" war="${pathtowar}" /> Result: Failed to deploy application at context path /ROOT##12345 Case #1: <deploy url="{tomcat.manager}/text" username="${username}", password="${password}" path="/##12345" war="${pathtowar}" /> Result: Failed to deploy application at context path /##12345
resolved fixed
712a351
["java/org/apache/catalina/ant/DeployTask.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-06-03T20:58:17Z"
"2013-05-31T19:53:20Z"
54,999
Bug 54999 JSESSIONIDSSO not re-created upon re-authentication on the same request - logout() and login(username,password)
In testing I found that the JSESSIONIDSSO was not re-created upon re-authentication via logout() and login(username,password) in the same request. The problem stemmed from the REQ_SSOID_NOTE that was was not reset upon request.logout(), whereas the documentation indicates that a logout() from any web-app should logout() from all web-apps. When the REQ_SSOID_NOTE is not removed upon logout(), a subsequent login(username,password) on the same request will re-create a JSESSIONID for the current web-app but fails to re-create a JSESSIONIDSSO since the REQ_SSO_ID_NOTE still lingers on the request. AuthenticatorBase.java adjustment for logout(request) that removes the REQ_SSOID_NOTE so that a subsequent login(username,password) will work on the same request: @Override public void logout(Request request) throws ServletException { register(request, request.getResponse(), null, null, null, null); request.removeNote(Constants.REQ_SSOID_NOTE); } I'll upload a diff-patch against the trunk and for 7.0.40.
resolved fixed
6d789fe
["java/org/apache/catalina/authenticator/AuthenticatorBase.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-30T13:49:40Z"
"2013-05-21T23:46:40Z"
54,997
Bug 54997 SSL Handshake implementation in AsycnChannelWrapperSecure does not handle SSLEngineResult.Status.BUFFER_UNDERFLOW and SSLEngineResult.Status.BUFFER_OVERFLOW states
null
resolved fixed
6c6b25c
["java/org/apache/tomcat/websocket/AsyncChannelWrapperSecure.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-29T10:17:20Z"
"2013-05-21T12:40:00Z"
54,971
Bug 54971 javax.servlet.http.Part.write(String fileName) is not properly implemented
1. fileName parameter / relative vs absolute filaName parameter specification in <1><JSR-000315 Java Servlet 3.0 Final Release javadocs> is different from the <2><javax API tomcat refers to>. <1> <JSR-000315 Java Servlet 3.0 Final Release javadocs> Parameters:fileName - the name of the file to which the stream will be written. The file is created relative to the location as specified in the MultipartConfig <2> javax. API tomcat refers to * @param fileName The location into which the uploaded part should be * stored. Relative locations are relative to {@link * javax.servlet.MultipartConfigElement#getLocation()} Tomcat is implemented as specified in <2> so that it can process "absolute path", but it should only accept "relative path" as specified in <1> <JSR-000315 Java Servlet 3.0 Final Release javadocs> 2. If MultiPartConfig.location is not set, write( String relative path ) throws FileNotFound Exception. A default location needs to be set in order to avoid such exception. example) os: windows8 part.write("/test"); java.io.IOException: java.io.FileNotFoundException: \test (Access is denied) at org.apache.catalina.core.ApplicationPart.write(ApplicationPart.java:123) at servlet.multipart.MultipleUploadServlet.doPost(MultipleUploadServlet.java:76) at javax.servlet.http.HttpServlet.service(HttpServlet.java:647) at javax.servlet.http.HttpServlet.service(HttpServlet.java:728) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:305) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:210) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:222) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:123) at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:472) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:99) at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:947) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:118) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408) at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1009) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:589) at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:312) at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918) at java.lang.Thread.run(Thread.java:662)
resolved fixed
cccd0ac
["java/org/apache/catalina/connector/Request.java", "java/org/apache/catalina/core/ApplicationPart.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-28T14:37:50Z"
"2013-05-15T06:40:00Z"
54,964
Bug 54964 Class loading issue of "TagPlugin" in TagPluginManager
null
resolved fixed
65ab66e
["java/org/apache/jasper/compiler/TagPluginManager.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-28T11:54:49Z"
"2013-05-14T11:13:20Z"
54,963
Bug 54963 Concurrent issue of Spdy/NetSupportSocket
null
resolved fixed
6272fca
["java/org/apache/tomcat/spdy/NetSupportSocket.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-28T11:46:56Z"
"2013-05-14T11:13:20Z"
54,961
Bug 54961 Make "compress" configurable in SpdyProxyProtocol
null
resolved fixed
c25112b
["java/org/apache/coyote/spdy/SpdyProxyProtocol.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-28T11:41:57Z"
"2013-05-14T05:40:00Z"
54,947
Bug 54947 Http11NioProtocol generates HTTP 505 responses on valid requests if request is split across multiple packets
If an HTTP request is broken up across multiple packets *and* the first packet contains a GET request up to "\r" AND the "\n" terminating the first line of the request is included in the next packet Tomcat incorrectly throws an HTTP "505 Version Not Supported" response. This is with the Http11NioProtocol connector only - the default HTTP/1.1 connector does not exhibit this problem. An example request: Packet 1: GET / HTTP/1.1\r Packet 2: \nHost: localhost\r\n Packet 3: Connection: Close\r\n\r\n Response: HTTP/1.1 505 HTTP Version Not Supported Server: Apache-Coyote/1.1 Date: Thu, 09 May 2013 20:23:58 GMT Connection: close The following Python program reproduces the problem for me in both Tomcat 6.0.37 and Tomcat 7.0.39: """ #!/usr/bin/python import socket import time s = socket.socket() s.connect(("localhost",8080)) s.sendall("GET / HTTP/1.1\r") time.sleep(1.5) # make sure the above goes out in its own packet s.sendall("\nHost: localhost\r\n") s.sendall("Connection: close\r\n\r\n") print s.makefile().read() """ Moving the "\n" to from the second sendall to the end of the first sendall causes Tomcat to respond correctly.
resolved fixed
f763975
["java/org/apache/coyote/http11/InternalNioInputBuffer.java", "test/org/apache/catalina/startup/SimpleHttpClient.java", "test/org/apache/coyote/http11/TestInternalInputBuffer.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-28T11:26:20Z"
"2013-05-10T01:40:00Z"
54,944
Bug 54944 Enhancements to TestFormAuthenticator
null
resolved fixed
0de078e
["test/org/apache/catalina/authenticator/TestFormAuthenticator.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-28T10:53:41Z"
"2013-05-09T17:20:00Z"
55,019
Bug 55019 <jsp:include page="blabla" flush="true"/> failed to compile under security manager
null
resolved fixed
76a7098
["java/org/apache/coyote/http11/AbstractOutputBuffer.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-27T15:15:32Z"
"2013-05-27T15:53:20Z"
54,984
Bug 54984 multipart/form-data is not always read with correct encoding
The bug occurs when form data is posted as multipart/form-data and using Servlet 3 API to get posted files. In a servlet, if we set the encoding: request.setCharacterEncoding("UTF-8"); Then invoke: request.getParts() And then invoke: String text = request.getParameter("sometextfield"); UTF-8 characters in the text have been garbled. Order of method calls are significant, if a getParameter is called before getParts, the correct encoding will be used. However, the order which you invoke the methods should not matter.
resolved fixed
7558546
["java/org/apache/catalina/connector/Request.java", "test/org/apache/catalina/connector/TestRequest.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-24T17:46:27Z"
"2013-05-16T16:00:00Z"
54,928
Bug 54928 IllegalStateException: Calling [asyncError()] is not valid for a request with Async state [COMPLETING]
In an async scenario (request.startAsync), when the client goes away, trying to write to the response raises an IOException. If I then call asyncContext.complete() in order to finalize and clean up the request, soon after the following exception occurs: java.lang.IllegalStateException: Calling [asyncError()] is not valid for a request with Async state [COMPLETING] at org.apache.coyote.AsyncStateMachine.asyncError(AsyncStateMachine.java:304) at org.apache.coyote.http11.AbstractHttp11Processor.action(AbstractHttp11Processor.java:793) at org.apache.coyote.Request.action(Request.java:373) at org.apache.catalina.core.AsyncContextImpl.setErrorState(AsyncContextImpl.java:441) at org.apache.catalina.connector.CoyoteAdapter.asyncDispatch(CoyoteAdapter.java:312) at org.apache.coyote.http11.AbstractHttp11Processor.asyncDispatch(AbstractHttp11Processor.java:1509) at org.apache.coyote.http11.Http11NioProcessor.asyncDispatch(Http11NioProcessor.java:221) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:619) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1581) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1540) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722) It looks like an attempt to maybe to send an error event to AsyncListener's but asyncContext.complete has already been called. Is calling asyncContext.complete() a reasonable way to handle an IOException from the response in order to finalize the request and release any resorces associated with it?
resolved fixed
3960b22
["test/org/apache/catalina/connector/TestCoyoteAdapter.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-24T14:09:55Z"
"2013-05-04T17:53:20Z"
54,955
Bug 54955 Mapping to application context root returns 404 after reload
null
resolved fixed
cdbf6b0
["java/org/apache/catalina/mapper/Mapper.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-20T20:51:02Z"
"2013-05-13T07:26:40Z"
54,981
Bug 54981 ServletContext.getJspConfigDescriptor() should return null when there is no jsp configuration
According to Servlet 3.0 javadoc ServletContext.getJspConfigDescriptor() must return NULL when there is no jsp configuration: " Returns: the <jsp-config> related configuration that was aggregated from the web.xml and web-fragment.xml descriptor files of the web application represented by this ServletContext, or null if no such configuration exists "
resolved fixed
aabef09
["java/org/apache/catalina/core/ApplicationContext.java", "test/org/apache/catalina/core/TestApplicationContext.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-16T08:07:24Z"
"2013-05-16T13:13:20Z"
54,974
Bug 54974 SessionCookieConfig.setXXX methods must throw IllegalStateException when invoked after initialization phase
According to Servlet 3.0 javadoc javax.servlet.SessionCookieConfig setter methods must throw IllegalStateException when invoked after initialization phase setComment(String) setDomain(String) setHttpOnly(boolean) setMaxAge(int) setName(String) setPath(String) setSecure(boolean) " Throws: java.lang.IllegalStateException - if the ServletContext from which this SessionCookieConfig was acquired has already been initialized "
resolved fixed
41462ca
["java/org/apache/catalina/core/ApplicationContext.java", "java/org/apache/catalina/core/ApplicationSessionCookieConfig.java", "test/org/apache/catalina/core/TestApplicationSessionCookieConfig.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-15T08:31:32Z"
"2013-05-15T12:13:20Z"
54,703
Bug 54703 Nullpointer exception in HttpParser.parseMediaType
input for parseMediaType() is ---------- multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="----=_Part_121_929034657.1363355797756" ---------- exception trace java.lang.NullPointerException at org.apache.tomcat.util.http.parser.HttpParser.parseMediaType(HttpParser.java:215) at org.apache.tomcat.util.http.parser.MediaTypeCache.parse(MediaTypeCache.java:54) at org.apache.catalina.connector.Response.setContentType(Response.java:806) at org.apache.catalina.connector.Response.checkSpecialHeader(Response.java:1119) at org.apache.catalina.connector.Response.setHeader(Response.java:1446) at org.apache.catalina.connector.ResponseFacade.setHeader(ResponseFacade.java:535)
resolved fixed
7aeab0e
["java/org/apache/tomcat/util/http/parser/HttpParser.java", "test/org/apache/tomcat/util/http/parser/TestMediaType.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-07T15:51:22Z"
"2013-03-15T17:53:20Z"
54,906
Bug 54906 WebappClassLoader.loadedByThisOrChild can throw ConcurrentModificationException
null
resolved fixed
c06707c
["java/org/apache/catalina/loader/WebappClassLoader.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-04T20:59:07Z"
"2013-04-30T00:00:00Z"
54,926
Bug 54926 WsFilter performs handshake validation even if it doesn't have a mapped endpoint
WsFilter performs several validations on WebSocket requests before checking if there is a registered Endpoint. I think the check for registered Endponts (and delegation to the next Filter) should take place first and the filter should do no further processing if there is mapped Endpoint for that URL. For example a SockJS protocol test send a POST request with a connection and upgrade headers but no ws version header and expects back a 405 (invalid HTTP method) where WsFilter sends 426 even though it has no Endpoint mapped at that URL.
resolved fixed
2df191f
["java/org/apache/tomcat/websocket/server/WsFilter.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-05-04T09:09:39Z"
"2013-05-04T06:46:40Z"
54,888
Bug 54888 TagPlugin "ForEach" doesn't support CSV items
null
resolved fixed
d440ae2
["java/org/apache/jasper/tagplugins/jstl/core/ForEach.java", "test/org/apache/jasper/tagplugins/jstl/core/TestForEach.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-04-29T13:24:36Z"
"2013-04-24T21:46:40Z"
54,801
Bug 54801 EL-like expressions in jsp:scriptlet break compilation of JSP XML documents
null
resolved fixed
1631be1
["java/org/apache/jasper/compiler/JspDocumentParser.java", "test/org/apache/jasper/compiler/TestJspDocumentParser.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-04-25T13:16:45Z"
"2013-04-05T02:46:40Z"
54,178
Bug 54178 [CVE-2013-2071] runtime exception in onComplete of AsyncListener, will make org.apache.catalina.connector.Request not recycled (orginally reported MESSAGE POST to tomcat, but it called doGet)
one HTTP request use POST method, but in tomcat it calls doGet() what is really strage. as I only tested in 7.0.23, and 7.0.32. in 7.0.32, 7.0.32 is more reproduceable than 7.0.23. I know it must be a very strange issue, as tomcat has so many release. I can't believe it if I didn't see it with my own eyes. so I attache the image.
resolved fixed
4171baf
["java/org/apache/catalina/core/AsyncContextImpl.java", "test/org/apache/catalina/core/TestAsyncContextImpl.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-04-24T11:27:11Z"
"2012-11-21T12:13:20Z"
54,708
Bug 54708 Use base file name ("ROOT") as the work directory for the default webapp instead of "_"
null
resolved fixed
59a0676
["java/org/apache/catalina/core/StandardContext.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-04-23T20:06:02Z"
"2013-03-16T02:13:20Z"
54,781
Bug 54781 NPE in WsServerContainer if there is no matching path
null
resolved fixed
67ed3e7
["java/org/apache/tomcat/websocket/server/WsFilter.java", "java/org/apache/tomcat/websocket/server/WsServerContainer.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-04-23T19:58:34Z"
"2013-04-01T23:46:40Z"
54,792
Bug 54792 IllegalStateException with chat sample
This looks related to 54659 and 54724 but possibly a new issue. To reproduce, open the chat sample page, send a message or two, and then close the browser tab. The following exception appears in the log and it doesn't seem to step from anything done in the application: java.lang.IllegalStateException: The WebSocket session has been closed and no method (apart from close()) may be called on a closed session at org.apache.tomcat.websocket.WsSession.checkState(WsSession.java:516) at org.apache.tomcat.websocket.WsSession.getMessageHandlers(WsSession.java:191) at org.apache.tomcat.websocket.pojo.PojoEndpointBase.onClose(PojoEndpointBase.java:113) at org.apache.tomcat.websocket.WsSession.fireEndpointOnClose(WsSession.java:392) at org.apache.tomcat.websocket.WsSession.onClose(WsSession.java:370) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.close(WsHttpUpgradeHandler.java:166) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler.access$200(WsHttpUpgradeHandler.java:44) at org.apache.tomcat.websocket.server.WsHttpUpgradeHandler$WsReadListener.onDataAvailable(WsHttpUpgradeHandler.java:192) at org.apache.coyote.http11.upgrade.AbstractServletInputStream.onDataAvailable(AbstractServletInputStream.java:169) at org.apache.coyote.http11.upgrade.AbstractProcessor.upgradeDispatch(AbstractProcessor.java:94) at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:618) at org.apache.coyote.http11.Http11NioProtocol$Http11ConnectionHandler.process(Http11NioProtocol.java:223) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1581) at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1537) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1110) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:603) at java.lang.Thread.run(Thread.java:722)
resolved fixed
e26d61d
["webapps/examples/WEB-INF/classes/websocket/chat/ChatAnnotation.java"]
Tomcat
https://github.com/apache/tomcat
apache/tomcat
java
null
null
null
"2013-04-23T16:34:04Z"
"2013-04-03T00:46:40Z"