Update app.py

app.py

@@ -127,21 +127,60 @@ def save_qa_history(history_entry):
         
         # Initialize or load existing history
         if history_file.exists():
-            with open(history_file, "r", encoding="utf-8") as f:
-                try:
-                    history_data = json.load(f)
-                except json.JSONDecodeError:
-                    st.error("Error parsing existing JSON file")
+            try:
+                with open(history_file, "r", encoding="utf-8") as f:
+                    file_content = f.read()
+                    
+                # Debug: Log file content
+                st.info(f"File content (first 500 chars): {file_content[:500]}")
+                
+                if not file_content.strip():
+                    st.warning("JSON file is empty, initializing new history")
                     history_data = []
+                else:
+                    try:
+                        history_data = json.loads(file_content)
+                        if not isinstance(history_data, list):
+                            st.error("JSON file does not contain a list, resetting history")
+                            history_data = []
+                    except json.JSONDecodeError as json_err:
+                        st.error(f"JSON parsing error: {str(json_err)}")
+                        # Try to salvage valid JSON if possible
+                        try:
+                            # Remove any trailing commas
+                            file_content = file_content.replace(",]", "]").replace(",}", "}")
+                            history_data = json.loads(file_content)
+                        except:
+                            st.error("Could not salvage JSON, initializing new history")
+                            history_data = []
+            except Exception as file_err:
+                st.error(f"File reading error: {str(file_err)}")
+                history_data = []
         else:
+            st.info("No existing history file found, creating new one")
             history_data = []
         
         # Append new entry
         history_data.append(history_entry)
         
+        # Validate history data before saving
+        if not isinstance(history_data, list):
+            st.error("Invalid history data format, must be a list")
+            history_data = []
+            
+        # Remove any None or invalid entries
+        history_data = [entry for entry in history_data if isinstance(entry, dict) and 
+                       all(key in entry for key in ["timestamp", "query", "answer"])]
+            
         # Save updated history locally
-        with open("qa_history.json", "w", encoding="utf-8") as f:
-            json.dump(history_data, f, ensure_ascii=False, indent=2)
+        try:
+            json_content = json.dumps(history_data, ensure_ascii=False, indent=2)
+            with open("qa_history.json", "w", encoding="utf-8") as f:
+                f.write(json_content)
+            st.success("Successfully saved history locally")
+        except Exception as save_err:
+            st.error(f"Error saving history locally: {str(save_err)}")
+            return
         
         # Push to GitHub with error logging
         github_token = os.getenv('GITHUB_TOKEN') or st.secrets.get('GITHUB_TOKEN')