Update app.py

app.py

@@ -143,55 +143,82 @@ def save_qa_history(history_entry):
         with open("qa_history.json", "w", encoding="utf-8") as f:
             json.dump(history_data, f, ensure_ascii=False, indent=2)
         
-        # st.info("Saved locally, attempting GitHub upload...")
-
-        # Push to GitHub
-        github_token = os.getenv('GITHUB_TOKEN') or st.secrets['GITHUB_TOKEN']
+        # Push to GitHub with error logging
+        github_token = os.getenv('GITHUB_TOKEN') or st.secrets.get('GITHUB_TOKEN')
         if not github_token:
-            st.error("GitHub token not found!")
+            st.error("GitHub token not found in environment or secrets!")
             return
             
-        from github import Github
-        g = Github(github_token)
-        
-        # Replace with your repository name
-        repo = g.get_repo("jirasaksaimekJijo/swu-chat-bot-project")
-        
         try:
-            # Try to get the file first
-            contents = repo.get_contents("qa_history.json")
-            response = repo.update_file(
-                path="qa_history.json",
-                message="Update QA history",
-                content=json.dumps(history_data, ensure_ascii=False, indent=2),
-                sha=contents.sha
-            )
-            # st.success(f"Successfully updated file on GitHub: {response.commit.html_url}")
-        except Exception as e:
-            # st.info(f"File doesn't exist yet, creating new one... Error was: {str(e)}")
-            # File doesn't exist, create it
-            response = repo.create_file(
-                path="qa_history.json",
-                message="Create QA history",
-                content=json.dumps(history_data, ensure_ascii=False, indent=2)
-            )
-            # st.success(f"Successfully created file on GitHub: {response['commit'].html_url}")
+            from github import Github
+            g = Github(github_token)
+            
+            # Add debug logging
+            st.info("Attempting to connect to GitHub repository...")
+            
+            repo = g.get_repo("jirasaksaimekJijo/swu-chat-bot-project")
+            
+            try:
+                # Try to get the file first
+                contents = repo.get_contents("qa_history.json")
+                st.info("Existing qa_history.json found, updating...")
+                
+                # Ensure content is properly encoded
+                content = json.dumps(history_data, ensure_ascii=False, indent=2)
+                
+                response = repo.update_file(
+                    path="qa_history.json",
+                    message="Update QA history",
+                    content=content,
+                    sha=contents.sha,
+                    branch="main"  # Explicitly specify branch
+                )
+                st.success("Successfully updated qa_history.json on GitHub")
+                
+            except Exception as file_error:
+                st.info("File not found, creating new qa_history.json...")
+                # File doesn't exist, create it
+                content = json.dumps(history_data, ensure_ascii=False, indent=2)
+                response = repo.create_file(
+                    path="qa_history.json",
+                    message="Create QA history",
+                    content=content,
+                    branch="main"  # Explicitly specify branch
+                )
+                st.success("Successfully created qa_history.json on GitHub")
+                
+        except Exception as github_error:
+            st.error(f"GitHub API error: {str(github_error)}")
+            import traceback
+            st.error(f"Full GitHub error trace: {traceback.format_exc()}")
             
     except Exception as e:
-        # st.error(f"Error saving QA history: {str(e)}")
+        st.error(f"General error in save_qa_history: {str(e)}")
         import traceback
-        # st.error(f"Full error: {traceback.format_exc()}")
-
+        st.error(f"Full error trace: {traceback.format_exc()}")
+        
 def add_to_qa_history(query: str, answer: str):
-    """Add new QA pair to history"""
-    history_entry = {
-        "timestamp": (datetime.now() + timedelta(hours=5)).isoformat(),
-        "query": query,
-        "answer": answer
-    }
-    
-    save_qa_history(history_entry)
-    return history_entry
+    """Add new QA pair to history with validation"""
+    try:
+        # Validate inputs
+        if not query or not answer:
+            st.warning("Empty query or answer detected, skipping history update")
+            return None
+            
+        # Create history entry with proper timestamp
+        history_entry = {
+            "timestamp": (datetime.now() + timedelta(hours=5)).strftime("%Y-%m-%dT%H:%M:%S"),
+            "query": query,
+            "answer": answer
+        }
+        
+        # Save entry
+        save_qa_history(history_entry)
+        return history_entry
+        
+    except Exception as e:
+        st.error(f"Error in add_to_qa_history: {str(e)}")
+        return None
         
 def add_to_history(role: str, message: str):
     """Add message to chat history and save if it's a complete QA pair"""