id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
231,004,523
pytorch
[Feature request] In-place 'max' method for Tensor
This functionality is useful for multiple cases, e.g. to efficiently implement optimizer's parameters update.
todo,feature,triaged
low
Major
231,036,773
TypeScript
Typescript Watch - Cleaning Target Files on Source Deletion
Can we[ add a compiler option](https://stackoverflow.com/questions/44159501/typescript-watch-removing-deleted-target-js-files) to also glob-delete a target file when the source file is removed? We run into this constantly and have to gulp clean frequently - it makes the usage of `tsc -watch` pointless as we have to constantly purge the output directory.
Bug
high
Critical
231,048,143
pytorch
feature request: On-the-fly Operation Batching in Dynamic Computation Graphs
[https://arxiv.org/abs/1705.07860](https://arxiv.org/abs/1705.07860) I would LOVE to see this in PyTorch.
feature,triaged
low
Major
231,099,513
angular
Binding to the src of an iframe causes the iframe to flicker
Binding to the `src` property of an iframe causes the iframe to reload every time change detection is run, even when the `src` value has not changed. Reproduction: https://plnkr.co/edit/CgLHkprl4jYndqEiY7mX?p=preview (enter `X1RVYt2QKQE` as an example videoId, then type into the unrelated input) Happens with all Angular versions <= 4.1 (current version at time of this writing) Note from @tbosch: > So the problem is that `this.domSanitizer.bypassSecurityTrustResourceUrl` returns a new object every time it is invoked. > If the result is cached, the flickering is gone, see https://plnkr.co/edit/W0gJKmRsGUpzb1QNZqf5?p=preview > > Eventually, we could change our behavior in that `bypassSecurityTrustResourceUrl` would use an internal cache already.
type: bug/fix,freq1: low,area: security,hotlist: google,state: confirmed,core: change detection,P3
medium
Major
231,117,879
create-react-app
Runtime environment variables
Regarding this [pull request](https://github.com/facebookincubator/create-react-app/pull/1344#issuecomment-302887448) around the improvements to environment variables, based on @gaearon's suggestion, I wanted to start a discussion on how to handle a docker-centric, 12 factor app-based workflow where environment variables are provided externally at runtime rather than at build time so that the exact same assets can be run in multiple environments. Constraints / design goals mentioned is: > It's important though to note that CRA always produces static bundles, and they are expected to work in any environment regardless of server, container, etc. In the past, I have implemented the following two solutions: 1) render environment variables into the HTML and then hoist them into an application at initialization 2) fetch environment variables from a server (for example, before creating the store and rendering the app with some static content during the initial fetch) The first solution's benefit is that there is no delay before initial render, but with create react app dynamically modifying the html file, it becomes a little more tricky to implement since you would need to parse or search / replace within the rendered html before serving the file. I'm just wondering if there is a better / best way to provide runtime environment variables to CRA applications and if we can get agreement on an approach, if it can be integrated into the CRA pipeline. Thank you for all the great work and hoping for something awesome here! :pray:
issue: proposal
high
Major
231,176,558
go
compress: unify Huffman logic in flate and bzip2
The Huffman encoding in both `flate` and `bzip2` is identical except for some minor differences: * `bzip2` treats the leading bits in a bitstream as the MSB of a byte, while `flate` treats the leading bits as the LSB of a byte. * `bzip2` allows Huffman codes to be up to 20-bits long, while `flate` allows codes up to 15-bits long. Currently, the implementation of Huffman encoding in `flate` is superior (and faster) to the one in `bzip2`. The differences are very minor and it should be able to unify the two without any performance hit. We should extract the common logic as `compress/internal/huffman`.
Performance
low
Major
231,177,476
go
cmd/compile: init code or linker should verify package "fingerprint"
Given a file lib.go: ``` package lib func F() int { return 42 } ``` and main.go: ``` package main import "./lib" func main() { println(lib.F()) } ``` The following command sequence prints 42 as expected: ``` $ go tool compile lib.go $ go tool compile main.go $ go tool link main.o $ a.out 42 ``` If one now changes 42 to 43 in lib.go, the following command sequence still prints 42: ``` $ go tool compile lib.go $ go tool link main.o $ a.out 42 ``` rather than 43. The issue is (presumably) that lib.F() got inlined and there's (apparently) no check in the linker that lib.go changed. While not surprising to an initiated user, this is surprising to an unsuspecting user. Ideally the linker, or then the initialization code should check that a compiler package we link again (or that we initialize) is the same that we compiled against. This could be done with some fingerprint of sorts, perhaps computed on the export data only. I suspect scenarios can be created where the linker succeeds and the program crashes (because a data type changed in lib.go and main.go wasn't recompiled). This behavior is no different from C/C++ where we have "independent" compilation: as long as the linker finds the matching symbols, it doesn't care whether they are referring to the same entities that were implied in the source code - hence the independence. Go should properly implement "separate" compilation: packages can be compiled separately, but correspondence to source code should be enforced.
help wanted,NeedsFix,compiler/runtime
low
Critical
231,187,596
go
cmd/compile: include certain NOP instructions when compiler optimizations are disabled
This is a follow up of the discussion here: https://github.com/derekparker/delve/issues/840 ### What version of Go are you using (`go version`)? go version go1.8.3 windows/amd64 ### What did you do? I've tried to debug the following app: https://play.golang.org/p/74ZR5IYhjn I've set a breakpoint on line ``` a := TableModel{} // b demo.go:17 ``` ### What did you expect to see? I was expecting to get the debugger to stop there. ### What did you see instead? The debugger did not stopped there. From the discussion I understand the reason on why the debugger doesn't stop as expected but as I've mentioned there, I think that's a problem of expectations. From a user's point of view, the debugger should stop there, it's a variable declaration and initialization. There shouldn't be any reason for it not to stop. As such, I've decided to open this issue to have a discussion and see if this could make its way in 1.10 and help manage the expectations of the users better. Thank you.
NeedsFix,FeatureRequest,Debugging,compiler/runtime
low
Critical
231,191,820
flutter
Add a diagram to explain Canvas.drawImageNine
Currently, the first paragraph reads: > Draws the given Image into the canvas using the given Paint. It should state that it *draws a scaled rendition(?) of the given 9-patch image* or something like that.
engine,d: api docs,P3,team-engine,triaged-engine
low
Minor
231,203,071
go
x/net/nettest: TestTestConn runs out of memory on Plan 9
CL [37404](https://golang.org/cl/37404) added TestTestConn, which is running out of memory on Plan 9. ``` runtime: out of memory: cannot allocate 323485696-byte block (1029013504 in use) fatal error: out of memory runtime stack: runtime.throw(0x11b06c, 0xd) /tmp/workdir/go/src/runtime/panic.go:596 +0x7b runtime.largeAlloc(0x13478000, 0x100, 0x3) /tmp/workdir/go/src/runtime/malloc.go:816 +0xdf runtime.mallocgc.func1() /tmp/workdir/go/src/runtime/malloc.go:709 +0x38 runtime.systemstack(0x103ee000) /tmp/workdir/go/src/runtime/asm_386.s:393 +0x5c runtime.mstart() /tmp/workdir/go/src/runtime/proc.go:1116 goroutine 30390 [running]: runtime.systemstack_switch() /tmp/workdir/go/src/runtime/asm_386.s:347 fp=0x103f4ddc sp=0x103f4dd8 runtime.mallocgc(0x13478000, 0x0, 0x0, 0xb) /tmp/workdir/go/src/runtime/malloc.go:708 +0x670 fp=0x103f4e30 sp=0x103f4ddc runtime.growslice(0xfe140, 0x50b02000, 0xf6c6000, 0xf6c6000, 0xf6c6060, 0x212ac000, 0x4d, 0x50) /tmp/workdir/go/src/runtime/slice.go:140 +0x1bb fp=0x103f4e70 sp=0x103f4e30 testing.(*common).log(0x1044e240, 0x17d9e0a0, 0x4d) /tmp/workdir/go/src/testing/testing.go:551 +0x11f fp=0x103f4ea8 sp=0x103f4e70 testing.(*common).Errorf(0x1044e240, 0x11d4e9, 0x19, 0x103f4f18, 0x1, 0x1) /tmp/workdir/go/src/testing/testing.go:575 +0x5c fp=0x103f4ec8 sp=0x103f4ea8 vendor/golang_org/x/net/nettest.resyncConn(0x1044e240, 0x1a93a0, 0x107da4f8) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest.go:435 +0x158 fp=0x103f4f24 sp=0x103f4ec8 vendor/golang_org/x/net/nettest.testConcurrentMethods(0x1044e240, 0x1a93a0, 0x107da4f8, 0x1a93a0, 0x107da520) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest.go:382 +0x245 fp=0x103f4f58 sp=0x103f4f24 vendor/golang_org/x/net/nettest.timeoutWrapper(0x1044e240, 0x103ea328, 0x121b70) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest.go:56 +0x1ab fp=0x103f4fac sp=0x103f4f58 vendor/golang_org/x/net/nettest.testConn.func11(0x1044e240) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest_go17.go:23 +0x31 fp=0x103f4fbc sp=0x103f4fac testing.tRunner(0x1044e240, 0x107da450) /tmp/workdir/go/src/testing/testing.go:747 +0xa5 fp=0x103f4fe8 sp=0x103f4fbc runtime.goexit() /tmp/workdir/go/src/runtime/asm_386.s:1635 +0x1 fp=0x103f4fec sp=0x103f4fe8 created by testing.(*T).Run /tmp/workdir/go/src/testing/testing.go:789 +0x250 goroutine 1 [chan receive]: testing.(*T).Run(0x1044e000, 0x11acd8, 0xc, 0x121b2c, 0x998d1) /tmp/workdir/go/src/testing/testing.go:790 +0x267 testing.runTests.func1(0x1044e000) /tmp/workdir/go/src/testing/testing.go:1004 +0x50 testing.tRunner(0x1044e000, 0x10411eec) /tmp/workdir/go/src/testing/testing.go:747 +0xa5 testing.runTests(0x103e8070, 0x1b8120, 0x1, 0x1, 0x0) /tmp/workdir/go/src/testing/testing.go:1002 +0x23f testing.(*M).Run(0x1045bf98, 0x10414070) /tmp/workdir/go/src/testing/testing.go:921 +0xcc main.main() vendor/golang_org/x/net/nettest/_test/_testmain.go:44 +0xc5 goroutine 6 [chan receive]: testing.(*T).Run(0x1044e090, 0x1197f1, 0x3, 0x103ea308, 0x5134be) /tmp/workdir/go/src/testing/testing.go:790 +0x267 vendor/golang_org/x/net/nettest.TestTestConn(0x1044e090) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest_test.go:76 +0xef testing.tRunner(0x1044e090, 0x121b2c) /tmp/workdir/go/src/testing/testing.go:747 +0xa5 created by testing.(*T).Run /tmp/workdir/go/src/testing/testing.go:789 +0x250 goroutine 7 [chan receive]: testing.(*T).Run(0x1044e1b0, 0x11b943, 0x11, 0x107da450, 0x303da101) /tmp/workdir/go/src/testing/testing.go:790 +0x267 vendor/golang_org/x/net/nettest.testConn(0x1044e1b0, 0x103ea328) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest_go17.go:23 +0x3c6 vendor/golang_org/x/net/nettest.TestConn(0x1044e1b0, 0x103ea328) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest.go:37 +0x28 vendor/golang_org/x/net/nettest.TestTestConn.func1(0x1044e1b0) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest_test.go:123 +0x82 testing.tRunner(0x1044e1b0, 0x103ea308) /tmp/workdir/go/src/testing/testing.go:747 +0xa5 created by testing.(*T).Run /tmp/workdir/go/src/testing/testing.go:789 +0x250 goroutine 30393 [chan receive]: internal/poll.(*asyncIO).Wait(...) /tmp/workdir/go/src/internal/poll/fd_io_plan9.go:84 internal/poll.(*FD).Read(0x10430460, 0x107db210, 0x10607c00, 0x400, 0x400, 0x0, 0x0, 0x0) /tmp/workdir/go/src/internal/poll/fd_plan9.go:73 +0x106 net.(*netFD).Read(0x10430460, 0x10607c00, 0x400, 0x400, 0x400, 0x0, 0x0) /tmp/workdir/go/src/net/fd_plan9.go:85 +0xb2 net.(*conn).Read(0x107da520, 0x10607c00, 0x400, 0x400, 0x0, 0x0, 0x0) /tmp/workdir/go/src/net/net.go:176 +0x55 go.(*struct { io.Reader }).Read(0x107da558, 0x10607c00, 0x400, 0x400, 0x400, 0x0, 0x0) <autogenerated>:1 +0x44 io.copyBuffer(0x1a7aa0, 0x107da550, 0x1a7a80, 0x107da558, 0x10607c00, 0x400, 0x400, 0x109affc4, 0x107da558, 0x107da558, ...) /tmp/workdir/go/src/io/io.go:390 +0xd8 io.CopyBuffer(0x1a7aa0, 0x107da550, 0x1a7a80, 0x107da558, 0x10607c00, 0x400, 0x400, 0x0, 0x103d4c40, 0x103d4c40, ...) /tmp/workdir/go/src/io/io.go:371 +0x5c vendor/golang_org/x/net/nettest.chunkedCopy(0x1a7880, 0x107da520, 0x3043e0f0, 0x107da520, 0x103f4f60, 0x8) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest.go:449 +0xe6 created by vendor/golang_org/x/net/nettest.testConcurrentMethods /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest.go:344 +0x9a goroutine 31115 [syscall, locked to thread]: syscall.Syscall6(0x8, 0x10607c00, 0x400, 0xffffffff, 0xffffffff, 0x0, 0x0, 0x1, 0x1, 0x0, ...) /tmp/workdir/go/src/syscall/asm_plan9_386.s:54 +0x5 syscall.Pread(0x8, 0x10607c00, 0x400, 0x400, 0xffffffff, 0xffffffff, 0x103ee000, 0x55239, 0x549d8) /tmp/workdir/go/src/syscall/zsyscall_plan9_386.go:218 +0x5c syscall.Read(0x8, 0x10607c00, 0x400, 0x400, 0x0, 0x0, 0x0) /tmp/workdir/go/src/syscall/syscall_plan9.go:124 +0x48 os.fixCount(...) /tmp/workdir/go/src/os/file_plan9.go:249 os.(*File).read(0x107da508, 0x10607c00, 0x400, 0x400, 0x0, 0x14c3, 0x0) /tmp/workdir/go/src/os/file_plan9.go:249 +0x3c os.(*File).Read(0x107da508, 0x10607c00, 0x400, 0x400, 0xffffffff, 0x0, 0x0) /tmp/workdir/go/src/os/file.go:103 +0x5d os.(*File).Read-fm(0x10607c00, 0x400, 0x400, 0x400, 0x0, 0x0) /tmp/workdir/go/src/net/fd_plan9.go:85 +0x37 internal/poll.newAsyncIO.func1(0x107de3e0, 0x107db210, 0x10607c00, 0x400, 0x400) /tmp/workdir/go/src/internal/poll/fd_io_plan9.go:54 +0xc0 created by internal/poll.newAsyncIO /tmp/workdir/go/src/internal/poll/fd_io_plan9.go:43 +0xaf goroutine 31112 [chan send]: vendor/golang_org/x/net/nettest.resyncConn.func1(0x1a93a0, 0x107da4f8, 0x107e0880) /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest.go:426 +0x79 created by vendor/golang_org/x/net/nettest.resyncConn /tmp/workdir/go/src/vendor/golang_org/x/net/nettest/conntest.go:424 +0x8f FAIL vendor/golang_org/x/net/nettest 25.967s ``` See https://build.golang.org/log/91d479d449f2d4e18ff585e87fcf0867a4fd2ea7
help wanted,OS-Plan9,NeedsFix
low
Critical
231,204,487
go
sync: add example for Cond
The sync.Cond should have an example demonstrating its use in a somewhat realistic use. What would be a good example? It's hardly used at all in standard library. What are typical uses? Continuation from #20471.
Documentation,NeedsInvestigation,compiler/runtime
medium
Critical
231,207,676
go
cmd/link: may need a command line option to set section split size
On ppc64x in external link mode the linker splits the text section into separate sections of size up to 0x1c00000 bytes. This gives the C linker space to insert stubs for out-of-range bl instructions. The C linker works in terms of a stub group size: it adds sections to a stub group until it reaches the group size, and then creates a new stub group. The default stub group size is, not coincidentally, 0x1c00000. However, 1) it is possible for the linker to fail to insert a stub if there are too many stubs, in which case it can retry with a smaller stub group size; 2) the linker has a command line option to set the stub group size, and it may be set to be smaller. Either way, when the Go linker produces a section that is larger than the stub group size, the linker emits a warning (at least, the gold linker does), and in some cases the link may conceivably fail. In order to accommodate these cases I think that either we need to have a command line option to set the size at which we split the text section, or we need to simply reduce the size to something more likely to work. CC @laboger
help wanted,NeedsInvestigation,compiler/runtime
medium
Major
231,237,225
angular
*Blocking Issue*: Change detection after error creating infinite loop
**I'm submitting a ...** (check one with "x") ``` [X] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question ``` **Current behavior** Possibly relates to #9531 and #16426. Since the change to continue change detection after an error (4.1.1), I'm getting an infinite loop of errors if there's a problem with template parsing (such as a bound variable doesn't exist). It causes the browser to completely hang, and the browser process must be manually killed. The console shows the infinite errors like this: ![change detection error loop](https://cloud.githubusercontent.com/assets/140338/26435569/2cca83a0-40de-11e7-9c9b-558a927b4fc8.png) If I add a breakpoint in my error `handleError()` method, I can get a stack trace which may help with diagnosis. Since it is long, I'll attach it rather than embed. [angular error loop stacktrace.txt](https://github.com/angular/angular/files/1027943/angular.error.loop.stacktrace.txt) The issue is not my error handler triggering some sort of change detection, because I can completely remove the custom error handler class and the issue still manifests. If you look through the stack trace, you can see that everything going on is internal to Angular, SystemJS (maybe it keeps trying to make XHR calls to load files, which triggers change detection?), and/or Zone. I'm not sure yet if it has to do with the fact that this is happening during bootstrap, or possibly something related to Zone.js, or something related to SystemJS. **Expected behavior** The browser should not completely hang due to something as basic as a template compilation error or binding error. **Minimal reproduction of the problem with instructions** I'm trying to create a Plunkr, but there are a number of pieces to put in place to mimic what's going on, and it is slow going. I'll keep trying. **Please tell us about your environment:** Windows 2010 x64 * **Angular version:** Angular 2.1.3, Zone 0.8.10, System 0.19.41. * **Browser:** all * **Language:** TypeScript 2.3.2
type: bug/fix,freq2: medium,area: core,core: change detection,core: error handling,P4
high
Critical
231,273,382
opencv
Stitching module is not compatible with CUDA8 due to GraphCut has been removed in CUDA8
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> ##### System information (version) <!-- Example - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2015 --> - OpenCV => 3.2 - Operating System / Platform => Win10 64bit - Compiler => Visual Studio 2010/Visual Studio 2015 ##### Detailed description <!-- your description --> When I want to use GPU to accelerate the stitching procedure with OpenCV3.2 & CUDA8. I get this error: `Opencv Error: The function/feature is not implemented ( The called functionality is disabled for current build or platform )` In the source code `seam_finders.cpp` line 1445: `cuda::graphcut(terminals_d, leftT_d, rightT_d, top_d, bottom_d, labels_d, buf_d);` So the problem is the function `graphcut` which `stitching` bases on is removed in CUDA8 but not updated in the OpenCV source code. According to this issue #6510 In the ` graphcuts.cpp` line 45-50: ``` // GraphCut has been removed in NPP 8.0 #if !defined (HAVE_CUDA) || defined (CUDA_DISABLER) || (CUDART_VERSION >= 8000) void cv::cuda::graphcut(GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, Stream&) { throw_no_cuda(); } void cv::cuda::graphcut(GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, GpuMat&, Stream&) { throw_no_cuda(); } ``` So we just simply deprecated the function without looking relevance. ##### Steps to reproduce Compile Opencv3.2 with CUDA8 then use stitching: ``` Stitcher::Mode mode = Stitcher::PANORAMA; Ptr<Stitcher> stitcher = Stitcher::create(mode, try_use_gpu=1); Stitcher::Status status = stitcher->stitch(input_images, pano); ``` then we will meet the error. ##### My solution: Since it is hard for me to modify the original source code, so I use the CPU version of `GraphCut` in the stitching procedure. It'll lose some speed but the rest part of the stitching procedure is working which would save a lot of time compared to the totally CPU version code. `stitcher->setSeamFinder(makePtr<detail::GraphCutSeamFinder>(detail::GraphCutSeamFinderBase::COST_COLOR));` Please consider updating the `GraphCut` code to compatible with CUDA8 to fundamentally fix the problem. Related link: https://devtalk.nvidia.com/default/topic/973151/no-nppgrabcut-on-cuda-8-0/
bug,priority: low,category: gpu/cuda (contrib),category: stitching
low
Critical
231,300,497
opencv
HOG human detection causes process exit without any error stack message after changing padding from (16,16) to (8,8)
My configuration: Ubuntu 16.04 64bit desktop Opencv 3.2.0-dev compiled by 5.4.0 20160609 (Ubuntu 5.4.0-6ubuntu1~16.04.4) Python 2.7.12 and I am trying to detect human from a video,and detection will exit when comes to this frame, Problem frame ![problemframe](https://cloud.githubusercontent.com/assets/303353/26446573/372f6bea-410a-11e7-9ad8-d23386e2420f.png) detection code is: ``` import cv2 image = cv2.imread('problemFrame.png') cv2.imshow('Problem frame', image) cv2.waitKey(30) hog = cv2.HOGDescriptor() hog.setSVMDetector(cv2.HOGDescriptor_getDefaultPeopleDetector()) founds, weights = hog.detectMultiScale(image, winStride=(4, 4), padding=(8, 8), scale=1.05, useMeanshiftGrouping=True) print founds, weights ``` and if changing padding from (8,8) to (16,16),detection works,and I have checked api doc: padding – Mock parameter to keep the CPU interface compatibility. It must be (0,0). but don't know what it mean,why must be (0,0),and this link gives more detailed description: http://www.pyimagesearch.com/2015/11/16/hog-detectmultiscale-parameters-explained/ padding (optional) The padding parameter is a tuple which indicates the number of pixels in both the x and y direction in which the sliding window ROI is “padded” prior to HOG feature extraction. As suggested by Dalal and Triggs in their 2005 CVPR paper, Histogram of Oriented Gradients for Human Detection, adding a bit of padding surrounding the image ROI prior to HOG feature extraction and classification can actually increase the accuracy of your detector. Typical values for padding include (8, 8), (16, 16), (24, 24), and (32, 32). and still can't figure out why,would you please help solve this problem?Thanks in advance.
bug,category: objdetect
low
Critical
231,383,816
vscode
Match whole word doesn't work in search for non-latin characters
#3623 https://github.com/Microsoft/vscode/commit/f151b3ef1fff3f25b02b4f3416888a4fdb5a3011
help wanted,feature-request,search,search-api
low
Major
231,413,874
rust
Redundancy in `trace_macro` output
(filed per https://github.com/rust-lang/rust/pull/42103#issuecomment-303183649 ) `trace_macro` output now contains both "before" and "after" text. But often a macro-call expands to another macro-call. In that case, we get redundant lines from `trace_macro`: ```console note: trace_macro --> trace-macro.rs:14:5 | 14 | println!("Hello, World!"); | ^^^^^^^^^^^^^^^^^^^^^^^^^^ | | = note: expanding `println! { "Hello, World!" }` = note: to `print ! ( concat ! ( "Hello, World!" , "\n" ) )` = note: expanding `print! { concat ! ( "Hello, World!" , "\n" ) }` = note: to `$crate :: io :: _print ( format_args ! ( concat ! ( "Hello, World!" , "\n" ) ) )` ``` The second "`expanding`" note is basically the same as the previous line. We could eliminate that. Note that it's also common for a macro-call to expand to code that merely *contains* another macro-call somewhere, and in that case we probably shouldn't elide anything.
C-enhancement,A-macros,T-compiler,S-has-mcve,-Ztrace-macros
low
Minor
231,413,877
vscode
Explorer / Opened Editors Sorting
Numerous issues have been filed on this topic, merging them into one. **Done** * [x] Option for sorting files by type in Explorer #5222 * [x] Give an option to show files before directories in file explorer #22529 * [x] Make listing directories first an option #29329 * [x] Add option to sort files in Explorer side-bar by date modified #11823 * [x] Add sorting to Open Editors list #12453 **Open** * [ ] Align explorer sorting with platform sorting #27759 * [ ] Feature Request: api to custom files sort order at the sidebar #12345 * [ ] Choose a sort order of directories and files according to the settings pattern #23231 * [ ] Feature to assign a particular file name to appear first in a directory listing #25724 * [ ] Explorer order files names with underline #40679
feature-request,file-explorer
high
Critical
231,440,413
You-Dont-Know-JS
Ch 7 - ES6 and Beyond, typo.
The contribution guidelines says not to worry about typo(s), but I'm not sure I can let a mis-spelled method name slide (: In the proxies section, right after the first code example, where various traps are listed, the explanation for `ownKeys` trap says, that it's invoked for `Object.getOwnSymbolProperties`, but there's no such method. You probably meant `Object.getOwnPropertySymbols` Cheers.
for second edition
medium
Minor
231,497,015
rust
Make the ast representation of qualified self paths more syntactic
The current representation is fine for the HIR, I assume it is optimised for compiler internal stuff. But in the AST, it would be better to be closer to the surface syntax (since that should make parsing, pretty printing, rustdoc, etc. a bit easier). IOW, it is a fine semantic definition, but not a great syntactic definition.
C-enhancement,A-parser,T-compiler
low
Minor
231,540,330
vscode
Improve ranking of elements in quick open
**Numerous** issues have been filed on this topic, merging them into one: **File Picker** * [ ] Allow to paste a file path with symbol to go to symbol in file [#123809](https://github.com/microsoft/vscode/issues/123809) * [ ] Allow to paste a file path with line number to go to line in file [#123810](https://github.com/microsoft/vscode/issues/123810) * [ ] vscode ctrl+p show matched string: shows files but not able to see matched strings when file paths are long [#123383](https://github.com/microsoft/vscode/issues/123383) * [ ] search files by name imperfect tokenization [#116021](https://github.com/microsoft/vscode/issues/116021) * [ ] Keep order stable independent for how search is formed [#123382](https://github.com/microsoft/vscode/issues/123382) * [ ] Opening files via relative paths containing parent directory, ".." [#113322](https://github.com/microsoft/vscode/issues/113322) * [ ] Incorrect prioritization of filename suggestions in quick open dialog (Ctrl+P) [#170353](https://github.com/microsoft/vscode/issues/170353) * [ ] Improve sorting of files in quick open [#27028](https://github.com/microsoft/vscode/issues/27028) * [ ] Improved search in "Go to file" panel [#25925](https://github.com/microsoft/vscode/issues/25925) * [ ] Quick open file order does not make sense as designed [#92282](https://github.com/microsoft/vscode/issues/92282) * [ ] Prioritize filetypes containing code in Quick open / Go to file [#49853](https://github.com/microsoft/vscode/issues/49853) * [ ] Quick Open strange highlighting [#56667](https://github.com/microsoft/vscode/issues/56667) * [ ] Provide an option to disable fuzzy matching in file picker [#2705](https://github.com/microsoft/vscode/issues/2705) * [ ] Add a setting to disable fuzzy matching in quick open [#99171](https://github.com/microsoft/vscode/issues/99171) * [ ] Search for files should prefer findings in one piece [#69648](https://github.com/microsoft/vscode/issues/69648) * [ ] index.js index.ts file should show at top of file picker when searching for the name of the directory [#72514](https://github.com/microsoft/vscode/issues/72514) * [ ] Unexpected order of fuzzy find results with many consecutive matches [#103889](https://github.com/microsoft/vscode/issues/103889) * [ ] Restrict quick open file to project files [#19762](https://github.com/microsoft/vscode/issues/19762) * [ ] Bump quickOpen suggestions from current workspace to the top [#38128](https://github.com/microsoft/vscode/issues/38128) * [ ] Sort workspace results over out of workspace results [#116551](https://github.com/microsoft/vscode/issues/116551) * [ ] Sort results in "Go to file" by how close they are to the working file (usability) [#5806](https://github.com/microsoft/vscode/issues/5806) * [ ] Rank exact match over history matches [#106786](https://github.com/microsoft/vscode/issues/106786) * [ ] Allow to sort files alphabetical if score is identical [#149780](https://github.com/microsoft/vscode/issues/149780) * [x] Allow additional fuzzy search within files found via CTRL+P [#39542](https://github.com/microsoft/vscode/issues/39542) * [x] Go to file: prefix with / to prefer results in root [#81250](https://github.com/microsoft/vscode/issues/81250) * [x] Allow quick open to filter on folder names by typing folder name after the file [#30404](https://github.com/microsoft/vscode/issues/30404) * [x] Scorer is not very good for matching on filenames [#12095](https://github.com/microsoft/vscode/issues/12095) * [x] Sort order for file quickopen should prefer shorter paths [#17443](https://github.com/microsoft/vscode/issues/17443) * [x] Quick open highlight should match consecutive characters better [#21019](https://github.com/microsoft/vscode/issues/21019) * [x] Improve quick find algorithm to prioritize exact matches better [#26649](https://github.com/microsoft/vscode/issues/26649) * [x] QuickOpen (Ctrl+P) search matching logic needs to be improved [#33247](https://github.com/microsoft/vscode/issues/33247) * [x] How to locate one of several files of the same name [#32918](https://github.com/microsoft/vscode/issues/32918) * [x] File list order not correct in go to file [#34210](https://github.com/microsoft/vscode/issues/34210) * [x] fuzzy searching problem [#36119](https://github.com/microsoft/vscode/issues/36119) * [x] Fuzzy search results are not prioritized well. [#36166](https://github.com/microsoft/vscode/issues/36166) **Command Palette** * [ ] Unable to search the command palette with special characters [#118469](https://github.com/microsoft/vscode/issues/118469) * [ ] Command Palette - Match Commands by ID [#113165](https://github.com/microsoft/vscode/issues/113165) * [ ] Command palette should rank results with closer search terms higher [#14727](https://github.com/microsoft/vscode/issues/14727) * [ ] Add fuzzy search to commands in palette [#1964](https://github.com/microsoft/vscode/issues/1964) * [ ] Adaptive abbreviation search for quick open commands [#17697](https://github.com/microsoft/vscode/issues/17697) * [ ] Command Palette should be filterable/customized by user-settings [#38841](https://github.com/microsoft/vscode/issues/38841) * [ ] Adjacent characters are given a lower rank in command palette than distant [#40044](https://github.com/microsoft/vscode/issues/40044) * [ ] Improve Command Palette search experience for word permutations [#99685](https://github.com/microsoft/vscode/issues/99685) * [ ] Favorite Commands [#101616](https://github.com/microsoft/vscode/issues/101616) * [x] Command Palette search with + character (like "C++") doesn't behave as expected [#123915](https://github.com/microsoft/vscode/issues/123915) * [x] Quick commands fuzzy search doesn't work for text in brackets [#27636](https://github.com/microsoft/vscode/issues/27636) **Picker (extensions)** * [ ] Support custom QuickPick filter logic [#90521](https://github.com/microsoft/vscode/issues/90521) * [ ] Ability to apply a final sort to QuickPick results [#63050](https://github.com/microsoft/vscode/issues/63050) * [ ] Enable fuzzy matching for picker [#34088](https://github.com/microsoft/vscode/issues/34088) * [ ] Broken fuzzy search highlighting/ranking for trimable strings [#62918](https://github.com/microsoft/vscode/issues/62918) **Editor History** * [ ] Allow for camel case matches in editor history [#108446](https://github.com/microsoft/vscode/issues/108446) * [ ] Fuzzy search also in editor history [#100590](https://github.com/microsoft/vscode/issues/100590) * [x] Sort recently opened files by recency after I start typing [#35610](https://github.com/microsoft/vscode/issues/35610) * [x] Allow disable of recent history in "go to file" command [#30770](https://github.com/microsoft/vscode/issues/30770) * [x] Quick open changes order for matching elements [#10690](https://github.com/microsoft/vscode/issues/10690) * [x] Unintuitive result scoring with Ctrl-P in recent history [#20546](https://github.com/microsoft/vscode/issues/20546) * [x] Recently opened files is just a bucket and not sorted by recency [#31591](https://github.com/microsoft/vscode/issues/31591) **Symbols** * [ ] Allow extensions to fully control workspace symbol search (matching and highlights) [#98125](https://github.com/microsoft/vscode/issues/98125) * [ ] Allow fzf style query in workspaceSymbols [#106788](https://github.com/microsoft/vscode/issues/106788) * [x] Add fuzzy search to search by symbol [#33746](https://github.com/microsoft/vscode/issues/33746) * [x] Lift the 60 chars limit on the camel case matcher [#43338](https://github.com/microsoft/vscode/issues/43338) * [x] Allow fuzzy result on searching symbol in file [#62435](https://github.com/microsoft/vscode/issues/62435) * [x] Allow to configure that "Go to symbols" sorts symbols by fuzzy match [#69062](https://github.com/microsoft/vscode/issues/69062) * [x] Improve ordering of "Go to symbol in workspace" results [#71951](https://github.com/microsoft/vscode/issues/71951)
feature-request,quick-open
high
Critical
231,662,293
flutter
Annotate widgets with a category and subcategory to autogenerate widget catalog
If our widget classes had annotations for category and subcategory, we could: * extract a widget catalog, and allow our users to slice and dice based on what they are looking for * explore organization options for docs.flutter.io Ideally, these annotations are extractable by a tool. For example, dart annotations or very-easy-to-extract doc comments.
team,framework,d: api docs,P2,team-framework,triaged-framework
low
Major
231,676,442
flutter
onPanEnd, onVerticalDragEnd, onHorizontalEnd have no velocity on fuchsia
```dart import 'package:flutter/widgets.dart'; main() async { runApp( new GestureDetector( //onPanStart: (_) => print('p start: $_'), //onPanUpdate: (_) => print('p mupdate: $_'), //onPanEnd: (_) => print('p end: $_'), onVerticalDragStart: (_) => print('v start: $_'), onVerticalDragUpdate: (_) => print('v update: $_'), onVerticalDragEnd: (_) => print('v end: $_'), onHorizontalDragStart: (_) => print('h start: $_'), onHorizontalDragUpdate: (_) => print('h update: $_'), onHorizontalDragEnd: (_) => print('h end: $_'), child: new Container( color: new Color(0xFFFFFFFF), ), ), ); } ```
customer: fuchsia,framework,platform-fuchsia,f: gestures,P2,team-framework,triaged-framework
low
Minor
231,686,500
go
proposal: x/crypto/ed25519: add montgomery/edwards key conversion
I would like to start building an [XEd25519] implementation. XEd25519 is a signature algorithm that is fully compatible with Ed25519. It gives you the ability to use the same key for signing and ECDH. I'd like to start by implementing the conversion between points on the equivalent Montgomery and Edwards curves in the [`golang.org/x/crypto/ed25519`] package: ```go // FromMontgomery converts a montgomery private key to a twisted edwards keypair. func FromMontgomery(mont []byte) (publicKey PublicKey, privateKey PrivateKey) {} // ToMontgomery converts a privatekey to its montgomery form. func (privateKey PrivateKey) ToMontgomery() (mont []byte) {} // PublicFromMontgomery converts a montgomery public key to an edwards public key. func PublicFromMontgomery(u []byte) PublicKey {} func (publicKey PublicKey) ToMontgomery() {} ``` It is currently difficult to do this outside of the x/crypto codebase because the [`edwards25519`] package is internal (and this is where all the subtle math that I don't want to reimplement lives). If it is not desirable to have this conversion be in the x/crypto package, an alternative might be moving the `edwards25519` package up a level to make it public (and adding a comment that indiciates that the API is not stable, and maybe never will be; this feels poor though). ## Open Questions - If accepted, maybe this should live in its own `xeddsa` package in case `curve448` support is implemented later and we want to generalize the implementation over both curves? Or maybe this should only be for if a full xeddsa implementation (not just key conversion) is ever implemented. - Maybe add `PublicKey` and `PrivateKey` types to the [`curve25519`] package and assume these are always in montgomery format? It would add a dependency loop that would have to be resolved, but might make the API nicer. - There is some ambiguity about the sign bit when doing the montgomery to edwards conversion; XEdDSA solves this by always setting it to zero [[Jivsov](https://tools.ietf.org/html/draft-jivsov-ecc-compact-05)], but some other scheme might do this differently; maybe we need a generic way in the API to pick the value of the sign bit. There's also a mechanism for cramming it into the signature, but I haven't thought that far ahead yet; it might be worth considering for the API implications though. [XEd25519]: https://whispersystems.org/docs/specifications/xeddsa [`golang.org/x/crypto/ed25519`]: https://godoc.org/golang.org/x/crypto/ed25519 [`edwards25519`]: https://godoc.org/golang.org/x/crypto/ed25519/internal/edwards25519 [`curve25519`]: https://godoc.org/golang.org/x/crypto/curve25519 /cc @agl
NeedsFix,Proposal-Crypto
medium
Critical
231,694,663
opencv
Drawing functions distorted in OpenCV 3.2.0 when reading buffer in 32BGRA pixel format
When I am trying to draw a circle in iOS using this code Mat mat = Mat((int)height,(int)width,CV_8UC4,data); circle(mat, cv::Point(100,100),20.f,cv::Scalar(255,0,0,255), -1); I get a distorted circle as show in the screenshot. Its almost as if it is drawing in a different space. The pixel format of the camera feed from iOS is 32BGRA. ![screenshot](https://cloud.githubusercontent.com/assets/1677755/26506481/71bebcdc-426a-11e7-84c3-832737b8bda3.jpg)
platform: ios/osx,incomplete
low
Minor
231,705,203
youtube-dl
Request for new site mivo(dot)com
Hello Admin, I need to record live tv streaming from my country. I found out that youtube-dl can fullfill my need but unfortunately when i've tried it . the result it is said the site not support. Here is the example: C:\apk decompile>youtube-dl -u myusername -p mypassword -g https://www.mivo.com/#!/live/metrotv WARNING: Falling back on generic information extractor. ERROR: Unsupported URL: https://www.mivo.com/#!/live/metrotv This site is using account credential..You could signup for free. Please admin if you have time could you make it work.. Please Thank You So Much.
site-support-request,account-needed
low
Critical
231,708,651
flutter
Flutter doctor is happy with just JRE, but builds fail without JDK
While trying to fix an issue with flutter (`Could not reserve enough space for 1572864KB object heap`) I uninstalled 32bit java and installed 64bit. I picked the JRE isntead of JDK and `flutter doctor` was happy; but builds failed claiming I needed the JDK: ![JDK error](https://cloud.githubusercontent.com/assets/1078012/26508609/4ecc6052-424d-11e7-807a-6200c7a7819e.png) Installing the JDK fixed the issue. It would be good if `flutter doctor` could check this.
tool,t: flutter doctor,P2,team-tool,triaged-tool
low
Critical
231,735,794
create-react-app
Only show lint warnings from most recently edited file in browser console
This came up in discussion in https://github.com/facebookincubator/create-react-app/issues/2070#issuecomment-304388814. Seems like a sensible thing to do, although I'm not sure how hard it would be. Tagging as good first bug but I don't have any ideas on how to do it.
tag: enhancement,difficulty: medium,contributions: claimed
low
Critical
231,803,657
flutter
Add the Android applicationId and iOS bundle id to the creation output
I'd like to suggest adding the Android application and iOS bundle id to the generation console output. I think this would help identify the generated when `--org tld.domain` is used and how that affects the naming of the ids. I'm trying to setup the bundle id on the apple developer site after I created the app. For now I'll build and open xcode and go find it in the target runner settings. So there is a way to do this already. I thought this might be handy. ## Steps to Reproduce 1. use `flutter create --org tld.domain myproject` 2. try to figure out how to setup the app on the apple developer site. ## Logs ``` Brandons-MacBook-Pro:workspace-idea branflake2267$ flutter create --plugin --org com.gawkat mytestplugin Creating project mytestplugin... Running "flutter packages get" in mytestplugin... 2.9s Wrote 70 files. Running "flutter packages get" in example... 2.6s [✓] Flutter is fully installed. (on Mac OS X 10.12.5 16F73, locale en-US, channel master) [✓] Android toolchain - develop for Android devices is fully installed. (Android SDK 25.0.3) [✓] iOS toolchain - develop for iOS devices is fully installed. (Xcode 8.3.2) [✓] Android Studio is fully installed. (version 2.3) [✓] IntelliJ IDEA Ultimate Edition is fully installed. (version 2017.1.3) [✓] Connected devices is fully installed. All done! In order to run your application, type: $ cd mytestplugin/example $ flutter run Your main program file is lib/main.dart in the mytestplugin/example directory. ``` ``` Brandons-MacBook-Pro:example branflake2267$ flutter doctor [✓] Flutter (on Mac OS X 10.12.5 16F73, locale en-US, channel master) • Flutter at /Users/branflake2267/git/flutter • Framework revision 767ab66c25 (6 hours ago), 2017-05-27 00:45:25 -0700 • Engine revision 75c74dc463 • Tools Dart version 1.24.0-dev.3.0 [✓] Android toolchain - develop for Android devices (Android SDK 25.0.3) • Android SDK at /Users/branflake2267/Library/Android/sdk • Platform android-25, build-tools 25.0.3 • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06) [✓] iOS toolchain - develop for iOS devices (Xcode 8.3.2) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 8.3.2, Build version 8E2002 • ios-deploy 1.9.1 • CocoaPods version 1.2.1 [✓] Android Studio (version 2.3) • Android Studio at /Applications/Android Studio.app/Contents • Gradle version 3.2 • Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06) [✓] IntelliJ IDEA Ultimate Edition (version 2017.1.3) • Dart plugin version 171.4424.63 • Flutter plugin version 14.0 [✓] Connected devices • None ```
c: new feature,tool,P2,team-tool,triaged-tool
low
Minor
231,806,885
bitcoin
listreceivedbyaddress incorrectly shows watchonly addresses as empty
The arguments are minconf, include_empty, and include_watchonly. If include_empty is true then watchonly addresses are returned as having a 0 balance even if they have a positive balance. Only when include_watchonly is also true do watchonly addresses with a balance return with their correct balance. When include_empty is true and include_watchonly is false then the watchonly addresses should not be returned at all. Example: $ ./bitcoin-cli listreceivedbyaddress 1 true [ { "address": "watch only", "account": "", "amount": 0.00000000, "confirmations": 0, "label": "", "txids": [ ] }, { "address": "address with privkey", "account": "", "amount": 0.00000000, "confirmations": 0, "label": "", "txids": [ ] } ] $ ./bitcoin-cli listreceivedbyaddress 1 true true [ { "address": "address with privkey", "account": "", "amount": 0.00000000, "confirmations": 0, "label": "", "txids": [ ] }, { "address": "watch only", "account": "", "amount": 1.0000000, "confirmations": 1234, "txids": [ ... ] } ]
RPC/REST/ZMQ
low
Minor
231,827,395
vscode
Feature Request: Zero-latency Typing
Following articles goes into length describing the issue in general. - https://pavelfatin.com/typing-with-pleasure/ - https://blog.jetbrains.com/idea/2015/08/experimental-zero-latency-typing-in-intellij-idea-15-eap/ - https://news.ycombinator.com/item?id=10787812 The subtle typing lag is observed in VS Code in same machine in which the typing is lag free with sublime text and even eclipse. This feature request is to look into the issue and address it if feasible.
feature-request,editor-core
high
Critical
231,841,800
vscode
Add option to use windows keymap on MacOS
- VSCode Version: 1.12.2 - OS Version: macOS Sierra We can write `keybindings` in `package.json` (Extension Manifest File). ```json "keybindings": [ { "win": "ctrl+y", "mac": "cmd+backspace", "linux": "ctrl+y", "command": "editor.action.deleteLines", "when": "editorTextFocus && !editorReadonly" } ] ``` I got a request from some developers that they are using macOS but they want to use Windows keybindings. See [Add option to use windows keymap on MacOS](https://github.com/k--kato/vscode-intellij-idea-keybindings/issues/67). So, I'd like to switch `mac` and `win` in `settings.json` or something. Can I do this?
feature-request,keybindings
high
Critical
231,876,684
flutter
Text fields should automatically support previous and next buttons in iOS keyboard to tab between fields.
## Steps to Reproduce 1. Run the Flutter Gallery application on an iPhone. 2. Select the "Text fields" demo. 3. Click on any text field. 4. Notice the keyboard does not show previous and next arrows to tab between field. ## Logs N/A ## Flutter Doctor ``` [✓] Flutter (on Mac OS X 10.12.4 16E195, locale en-US, channel master) • Flutter at /Users/?/Development/flutter • Framework revision 767ab66c25 (32 hours ago), 2017-05-27 00:45:25 -0700 • Engine revision 75c74dc463 • Tools Dart version 1.24.0-dev.3.0 [✓] Android toolchain - develop for Android devices (Android SDK 25.0.3) • Android SDK at /Users/?/Library/Android/sdk • Platform android-25, build-tools 25.0.3 • ANDROID_HOME = /Users/?/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06) [✓] iOS toolchain - develop for iOS devices (Xcode 8.3.2) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 8.3.2, Build version 8E2002 • ios-deploy 1.9.1 • CocoaPods version 1.2.1 [✓] Android Studio (version 2.3) • Android Studio at /Applications/Android Studio.app/Contents • Gradle version 3.2 • Java version: OpenJDK Runtime Environment (build 1.8.0_112-release-b06) [✓] IntelliJ IDEA Community Edition (version 2017.1.3) • Dart plugin version 171.4424.63 • Flutter plugin version 13.1 ```
a: text input,platform-ios,framework,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-ios,triaged-ios,fyi-text-input
low
Major
231,906,640
opencv
Improper or bad rotation estimation with solvePnP in some cases
##### System information (version) - OpenCV => master (ee257ff) - Operating System / Platform => Ubuntu 16.04 / 64 bits - Compiler => gcc ##### Detailed description In some cases, the pose estimated with `solvePnP()` give a rotation matrix that looks correct (`det(R)=1`, `R.R^t=Identity`) but will project the z-axis of the object frame in the opposite direction. More information here: [ArUco marker z-axis mirrored](http://answers.opencv.org/question/145829/aruco-marker-z-axis-mirrored/). Example image from the linked question: ![14939088089358535](https://cloud.githubusercontent.com/assets/8229425/26532830/0abab6e6-440c-11e7-9252-bb3e241f7104.png) My example (less obvious, with `aruco::CORNER_REFINE_NONE`): ![bad_rotation_108](https://cloud.githubusercontent.com/assets/8229425/26533432/35c1958c-4419-11e7-910a-6c42a51b8edb.jpg) ![bad_rotation2_108](https://cloud.githubusercontent.com/assets/8229425/26533434/3ff4914e-4419-11e7-9158-da317dcd0ce8.jpg) The issue can appear on one frame and disappear in the next frame. ##### Steps to reproduce To get a complete reproducible example with Aruco detection see [here](http://answers.opencv.org/question/145829/aruco-marker-z-axis-mirrored/). <details> <summary>A minimal reproducible code with some optional debug code/display</summary> ``` #include "opencv2/opencv.hpp" #include "opencv2/aruco.hpp" int main(int argc, char *argv[]) { cv::Mat frame = cv::imread(argc > 1 ? argv[1] : "img_fail.png"); // Intrinsic camera parameters. cv::Mat camMatrix = cv::Mat::eye(3, 3, CV_64F); cv::Mat distortionCoeffs = cv::Mat::zeros(8, 1, CV_64F); camMatrix.at<double>(0, 0) = 2.3396381685789738e+03; camMatrix.at<double>(0, 2) = 960.; camMatrix.at<double>(1, 1) = 2.3396381685789738e+03; camMatrix.at<double>(1, 2) = 540.; std::cout << "camMatrix:\n" << camMatrix << std::endl; // distortionCoeffs.at<double>(0, 0) = -1.0982746232841779e-01; // distortionCoeffs.at<double>(1, 0) = 2.2689585715220828e-01; // distortionCoeffs.at<double>(2, 0) = 0.; // distortionCoeffs.at<double>(3, 0) = 0.; // distortionCoeffs.at<double>(4, 0) = -2.2112148171171589e-01; std::cout << "distortionCoeffs: " << distortionCoeffs.t() << std::endl; std::vector<cv::Point3d> objectPoints; objectPoints.push_back( cv::Point3d(-2.5, 2.5, 0.0) ); objectPoints.push_back( cv::Point3d(2.5, 2.5, 0.0) ); objectPoints.push_back( cv::Point3d(2.5, -2.5, 0.0) ); objectPoints.push_back( cv::Point3d(-2.5, -2.5, 0.0) ); std::vector<cv::Point2d> imagePoints; imagePoints.push_back( cv::Point2d(988, 512) ); imagePoints.push_back( cv::Point2d(945, 575) ); imagePoints.push_back( cv::Point2d(849, 544) ); imagePoints.push_back( cv::Point2d(893, 480) ); std::vector<int> solvePnP_methods; solvePnP_methods.push_back(cv::SOLVEPNP_ITERATIVE); solvePnP_methods.push_back(cv::SOLVEPNP_EPNP); solvePnP_methods.push_back(cv::SOLVEPNP_P3P); solvePnP_methods.push_back(cv::SOLVEPNP_AP3P); std::map<int, std::string> solvePnP_method_names; solvePnP_method_names[cv::SOLVEPNP_ITERATIVE] = "cv::SOLVEPNP_ITERATIVE"; solvePnP_method_names[cv::SOLVEPNP_EPNP] = "cv::SOLVEPNP_EPNP"; solvePnP_method_names[cv::SOLVEPNP_P3P] = "cv::SOLVEPNP_P3P"; solvePnP_method_names[cv::SOLVEPNP_AP3P] = "cv::SOLVEPNP_AP3P"; for (size_t idx = 0; idx < solvePnP_methods.size(); idx++) { cv::Mat debugFrame = frame.clone(); cv::putText(debugFrame, solvePnP_method_names[solvePnP_methods[idx]], cv::Point(20,20), cv::FONT_HERSHEY_SIMPLEX , 0.5, cv::Scalar(0,0,255)); cv::line(debugFrame, imagePoints[0], imagePoints[1], cv::Scalar(0,0,255), 2); cv::line(debugFrame, imagePoints[1], imagePoints[2], cv::Scalar(0,255,0), 2); cv::line(debugFrame, imagePoints[2], imagePoints[3], cv::Scalar(255,0,0), 2); cv::Mat rvec, tvec; cv::solvePnP(objectPoints, imagePoints, camMatrix, distortionCoeffs, rvec, tvec, false, solvePnP_methods[idx]); cv::Mat rotation_matrix; cv::Rodrigues(rvec, rotation_matrix); std::cout << "\nrotation_matrix:\n" << rotation_matrix << std::endl; std::cout << "R.R^t=" << rotation_matrix*rotation_matrix.t() << std::endl; std::cout << "det(R)=" << cv::determinant(rotation_matrix) << std::endl << std::endl; cv::aruco::drawAxis(debugFrame, camMatrix, distortionCoeffs, rvec, tvec, 5.0); std::vector<cv::Point3d> axis_vec; axis_vec.push_back( cv::Point3d(0, 0, 0) ); axis_vec.push_back( cv::Point3d(1, 0, 0) ); axis_vec.push_back( cv::Point3d(0, 1, 0) ); axis_vec.push_back( cv::Point3d(0, 0, 1) ); std::vector<cv::Point2d> axis_vec_proj; cv::projectPoints(axis_vec, rvec, tvec, camMatrix, distortionCoeffs, axis_vec_proj); for (size_t i = 0; i < axis_vec_proj.size(); i++) { std::cout << "axis_vec_proj[" << i << "]=" << axis_vec_proj[i].x << " ; " << axis_vec_proj[i].y << std::endl; } // Project cube. float length = 20.0f; std::vector<cv::Point3f> testObj3d; testObj3d.push_back(cv::Point3f(0, 0, 0)); testObj3d.push_back(cv::Point3f(length, 0, 0)); testObj3d.push_back(cv::Point3f(0, length, 0)); testObj3d.push_back(cv::Point3f(length, length, 0)); testObj3d.push_back(cv::Point3f(0, 0, length)); testObj3d.push_back(cv::Point3f(length, 0, length)); testObj3d.push_back(cv::Point3f(0, length, length)); testObj3d.push_back(cv::Point3f(length, length, length)); std::vector<cv::Point2f> testObj2d; cv::projectPoints(testObj3d, rvec, tvec, camMatrix, distortionCoeffs, testObj2d); cv::line(debugFrame, testObj2d[0], testObj2d[1], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[0], testObj2d[2], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[1], testObj2d[3], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[2], testObj2d[3], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[0], testObj2d[4], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[1], testObj2d[5], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[2], testObj2d[6], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[3], testObj2d[7], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[4], testObj2d[5], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[4], testObj2d[6], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[5], testObj2d[7], cv::Scalar(0,0,0), 1); cv::line(debugFrame, testObj2d[6], testObj2d[7], cv::Scalar(0,0,0), 1); cv::imshow("debug", debugFrame); cv::waitKey(0); } } ``` </details> The image from which the corners have been extracted [here](https://cloud.githubusercontent.com/assets/8229425/26532920/8042b722-440e-11e7-82ad-79f8295644a8.png). --- Note: - `cv::aruco::drawAxis()` should be ok as with manual matrix multiplications lead to same result - I don't think the issue comes from `cv::Rodrigues()` as I get more or less (I suppose the correct rotation matrix should have a different sign somewhere, which is not the case?) the same rotation matrix in solvePnP function (just before the call to `cv::Rodrigues()`, as solvePnP returns a rvec and do internally the conversion rotation matrix -> rotation vector) - `cv::SOLVEPNP_ITERATIVE`, `cv::SOLVEPNP_EPNP`, `cv::SOLVEPNP_P3P` and `cv::SOLVEPNP_AP3P` all seem to fail, the estimated rotation is not the same for some methods - using `cv::aruco::CORNER_REFINE_SUBPIX` can solve the issue in the original question (in my case, as the markers are much smaller the refinement is not always correct and the issue remains) - while I can understand that some numerical imprecision in the corner locations can lead to a pose badly estimated, I cannot understand why in this case the translation is ok and the rotation is almost ok except a flipped z-axis (or why a left-handed rotation matrix seems to be returned)
category: calib3d
medium
Critical
231,983,362
opencv
Parallelization: convert to grey leads to 100% processor load
##### System information (version) ``` General configuration for OpenCV 3.2.0-dev ===================================== Version control: 3.0.0-4749-gdcd8589 Extra modules: Location (extra): C:/Program Files (x86)/Jenkins/jobs/OpenCV/workspace/contrib/modules Version control (extra): 3.0.0-beta-1572-g560e782 Platform: Timestamp: 2017-05-11T14:41:49Z Host: Windows 6.3.9600 AMD64 CMake: 3.5.1 CMake generator: Visual Studio 12 2013 Win64 CMake build tool: C:/Program Files (x86)/MSBuild/12.0/bin/MSBuild.exe MSVC: 1800 CPU/HW features: Baseline: SSE SSE2 SSE3 SSSE3 requested: SSSE3 Dispatched code generation: SSE4_1 FP16 AVX AVX2 requested: SSE4_1 AVX FP16 AVX2 SSE4_1 (0 files): + SSE4_1 FP16 (0 files): + SSE4_1 POPCNT SSE4_2 FP16 AVX AVX (1 files): + SSE4_1 POPCNT SSE4_2 AVX AVX2 (1 files): + SSE4_1 POPCNT SSE4_2 FP16 FMA3 AVX AVX2 C/C++: Built as dynamic libs?: YES C++ Compiler: C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/bin/x86_amd64/cl.exe (ver 18.0.40629.0) C++ flags (Release): /DWIN32 /D_WINDOWS /W4 /GR /EHa /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _SCL_SECURE_NO_WARNINGS /Gy /bigobj /Oi /wd4127 /wd4251 /wd4324 /wd4275 /wd4589 /MP12 /openmp /MD /O2 /Ob2 /D NDEBUG /Zi C++ flags (Debug): /DWIN32 /D_WINDOWS /W4 /GR /EHa /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _SCL_SECURE_NO_WARNINGS /Gy /bigobj /Oi /wd4127 /wd4251 /wd4324 /wd4275 /wd4589 /MP12 /openmp /D_DEBUG /MDd /Zi /Ob0 /Od /RTC1 C Compiler: C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/bin/x86_amd64/cl.exe C flags (Release): /DWIN32 /D_WINDOWS /W3 /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _SCL_SECURE_NO_WARNINGS /Gy /bigobj /Oi /MP12 /openmp /MD /O2 /Ob2 /D NDEBUG /Zi C flags (Debug): /DWIN32 /D_WINDOWS /W3 /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _SCL_SECURE_NO_WARNINGS /Gy /bigobj /Oi /MP12 /openmp /D_DEBUG /MDd /Zi /Ob0 /Od /RTC1 Linker flags (Release): /machine:x64 /INCREMENTAL:NO /debug Linker flags (Debug): /machine:x64 /debug /INCREMENTAL ccache: NO Precompiled headers: YES Extra dependencies: comctl32 gdi32 ole32 setupapi ws2_32 vfw32 vtkRenderingOpenGL2 vtkCommonCore vtksys vtkCommonDataModel vtkCommonMath vtkCommonMisc vtkCommonSystem vtkCommonTransforms vtkCommonExecutionModel vtkIOImage vtkDICOMParser vtkmetaio vtkzlib vtkjpeg vtkpng vtktiff vtkImagingCore vtkRenderingCore vtkCommonColor vtkCommonComputationalGeometry vtkFiltersCore vtkFiltersGeneral vtkFiltersGeometry vtkFiltersSources vtkglew vtkInteractionStyle vtkFiltersExtraction vtkFiltersStatistics vtkImagingFourier vtkalglib vtkRenderingLOD vtkFiltersModeling vtkIOPLY vtkIOCore vtkFiltersTexture vtkRenderingFreeType vtkfreetype vtkIOExport vtkRenderingGL2PSOpenGL2 vtkgl2ps vtkIOGeometry vtkIOLegacy glu32 opengl32 cudart nppc nppi npps cufft -LIBPATH:C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v8.0/lib/x64 3rdparty dependencies: OpenCV modules: To be built: cudev core cudaarithm flann imgproc ml objdetect phase_unwrapping plot reg surface_matching video viz xphoto bgsegm cudabgsegm cudafilters cudaimgproc cudawarping dnn face fuzzy imgcodecs photo shape videoio xobjdetect cudacodec highgui bioinspired dpm features2d line_descriptor saliency text calib3d ccalib cudafeatures2d cudalegacy cudaobjdetect cudaoptflow cudastereo datasets rgbd stereo structured_light superres tracking videostab xfeatures2d ximgproc aruco optflow sfm stitching Disabled: world contrib_world Disabled by dependency: - Unavailable: java python2 python3 ts cnn_3dobj cvv dnn_modern freetype hdf matlab Windows RT support: NO GUI: QT: NO Win32 UI: YES OpenGL support: YES (glu32 opengl32) VTK support: YES (ver 7.1.1) Media I/O: ZLib: build (ver 1.2.8) JPEG: build (ver 90) WEBP: build (ver encoder: 0x020e) PNG: build (ver 1.6.24) TIFF: build (ver 42 - 4.0.2) JPEG 2000: build (ver 1.900.1) OpenEXR: build (ver 1.7.1) GDAL: NO GDCM: NO Video I/O: Video for Windows: YES DC1394 1.x: NO DC1394 2.x: NO FFMPEG: YES (prebuilt binaries) avcodec: YES (ver ) avformat: YES (ver ) avutil: YES (ver ) swscale: YES (ver ) avresample: YES (ver ) GStreamer: NO OpenNI: NO OpenNI PrimeSensor Modules: NO OpenNI2: NO PvAPI: NO GigEVisionSDK: NO DirectShow: YES Media Foundation: NO XIMEA: NO Intel PerC: NO Parallel framework: OpenMP Other third-party libraries: Use Intel IPP: 2017.0.2 [2017.0.2] at: C:/Program Files (x86)/Jenkins/jobs/OpenCV/workspace/build/3rdparty/ippicv/ippicv_win Use Intel IPP IW: prebuilt binaries (2017.0.2) Use Intel IPP Async: NO Use Lapack: NO Use Eigen: YES (ver 3.3.2) Use Cuda: YES (ver 8.0) Use OpenCL: YES Use OpenVX: NO Use custom HAL: NO NVIDIA CUDA Use CUFFT: YES Use CUBLAS: NO USE NVCUVID: NO NVIDIA GPU arch: 30 35 37 50 52 60 61 NVIDIA PTX archs: Use fast math: NO OpenCL: <Dynamic loading of OpenCL library> Include path: C:/Program Files (x86)/Jenkins/jobs/OpenCV/workspace/3rdparty/include/opencl/1.2 Use AMDFFT: NO Use AMDBLAS: NO Python 2: Interpreter: NO Python 3: Interpreter: C:/Program Files (x86)/Python3.4.3/python.exe (ver 3.4.3) Python (for build): C:/Program Files (x86)/Python3.4.3/python.exe Java: ant: NO JNI: C:/Program Files/Java/jdk1.8.0_40/include C:/Program Files/Java/jdk1.8.0_40/include/win32 C:/Program Files/Java/jdk1.8.0_40/include Java wrappers: NO Java tests: NO Matlab: Matlab not found or implicitly disabled Tests and samples: Tests: NO Performance tests: NO C/C++ Examples: NO Install path: C:/DEVELOPMENT/opencv.install cvconfig.h is in: C:/Program Files (x86)/Jenkins/jobs/OpenCV/workspace/build ----------------------------------------------------------------- ``` ##### Detailed description Ever since I upgraded from OpenCV 3.1. (I built commit 49b4af1e5c675ea8152c7413e7a7ca0def41c7e8 ) to OpenCV 3.2+X (I built commit dcd8589b678824beeba4f5741c975ec78f943c8a) my OpenCV pipeline leads to 100% processor load on my eight core system on occasions where it previously was around 25%. This makes my pipeline unusable. I managed to write a minimal example for this unusual high processor load which you see below: ##### Steps to reproduce ``` #include <iostream> #include <opencv/highgui.h> #include <opencv2/videoio.hpp> #include <opencv2/imgproc.hpp> #include <opencv2/highgui.hpp> int main() { //cv::setNumThreads(0); std::cout << cv::getBuildInformation() << std::endl; while (true) { cv::Mat img(1000, 1000, CV_8UC3); cv::Mat grey; cv::cvtColor(img, grey, img.channels() == 4 ? cv::COLOR_BGRA2GRAY : cv::COLOR_BGR2GRAY); cv::imshow("Grey", grey); std::cerr << "."; if (cv::waitKey(100) == 'q') { break; } } } ``` Leads to a 100% processor load on my 8 core system - even though I have a very long waiting period of 100 ms. If I uncomment the first line ``//cv::setNumThreads(0);``, the load reported by the Windows Taskmanager for my process is basically zero while the console prints the dots in roughly the same frequency (poor man's profiling :-) ). I can also reduce ``cv::waitKey(1)`` so it runs as fast as possible while still having near-zero load. ### Comparison with old OpenCV version ("old" means 49b4af1e5c675ea8152c7413e7a7ca0def41c7e8 and "new" means dcd8589b678824beeba4f5741c975ec78f943c8a) If I run above example with my old OpenCV build, the load is basically zero no matter if i set the num threads or not. When looking at the build information for the old build (see below) I noticed that the ``Parallel framework: Concurrency`` in the old build changed to ``Parallel framework: OpenMP`` and also in the old build the OpenMP Cpp flags where missing while in the new build they are here. Stepping trough the calls the old version indeed executes [Concurrency::parallel_for](https://github.com/opencv/opencv/blob/649bb7ac04bf54ffce2cdecb42a64b3c019fbe94/modules/core/src/parallel.cpp#L363) in the old build but [omp parallel for](https://github.com/opencv/opencv/blob/649bb7ac04bf54ffce2cdecb42a64b3c019fbe94/modules/core/src/parallel.cpp#L353) in the new build **Bug1:** Why is the load so tremendously high with OpenMP? How can I go back to the Concurrency framework? **Bug2:** In both builds I explicitly enabled ``WITH_OPENMP`` in cmake. Was it not used in the old build and shouldn't it have been? ``` General configuration for OpenCV 3.1.0-dev ===================================== Version control: unknown Extra modules: Location (extra): C:/Program Files (x86)/Jenkins/jobs/OpenCV/workspace/contrib/modules Version control (extra): unknown Platform: Timestamp: 2016-04-25T10:00:36Z Host: Windows 6.3.9600 AMD64 CMake: 3.5.1 CMake generator: Visual Studio 12 Win64 CMake build tool: C:/Program Files (x86)/MSBuild/12.0/bin/MSBuild.exe MSVC: 1800 C/C++: Built as dynamic libs?: YES C++ Compiler: C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/bin/x86_amd64/cl.exe (ver 18.0.40629.0) C++ flags (Release): /DWIN32 /D_WINDOWS /W4 /GR /EHa /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _SCL_SECURE_NO_WARNINGS /Gy /bigobj /Oi /wd4251 /wd4324 /wd4275 /wd4589 /MP8 /MD /O2 /Ob2 /D NDEBUG /Zi C++ flags (Debug): /DWIN32 /D_WINDOWS /W4 /GR /EHa /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _SCL_SECURE_NO_WARNINGS /Gy /bigobj /Oi /wd4251 /wd4324 /wd4275 /wd4589 /MP8 /D_DEBUG /MDd /Zi /Ob0 /Od /RTC1 C Compiler: C:/Program Files (x86)/Microsoft Visual Studio 12.0/VC/bin/x86_amd64/cl.exe C flags (Release): /DWIN32 /D_WINDOWS /W3 /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _SCL_SECURE_NO_WARNINGS /Gy /bigobj /Oi /MP8 /MD /O2 /Ob2 /D NDEBUG /Zi C flags (Debug): /DWIN32 /D_WINDOWS /W3 /D _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE /D _SCL_SECURE_NO_WARNINGS /Gy /bigobj /Oi /MP8 /D_DEBUG /MDd /Zi /Ob0 /Od /RTC1 Linker flags (Release): /machine:x64 /INCREMENTAL:NO /debug Linker flags (Debug): /machine:x64 /debug /INCREMENTAL Precompiled headers: YES Extra dependencies: comctl32 gdi32 ole32 setupapi ws2_32 vfw32 cudart nppc nppi npps cufft -LC:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v7.0/lib/x64 3rdparty dependencies: zlib libjpeg libwebp libpng libtiff libjasper IlmImf libprotobuf OpenCV modules: To be built: cudev core cudaarithm flann imgproc ml reg surface_matching video cudabgsegm cudafilters cudaimgproc cudawarping dnn fuzzy imgcodecs photo shape videoio cudacodec highgui objdetect plot ts xobjdetect xphoto bgsegm bioinspired dpm face features2d line_descriptor saliency text calib3d ccalib cudafeatures2d cudalegacy cudaobjdetect cudaoptflow cudastereo datasets rgbd stereo structured_light superres tracking videostab xfeatures2d ximgproc aruco optflow stitching Disabled: world contrib_world Disabled by dependency: - Unavailable: java python2 python3 viz cvv hdf matlab sfm Windows RT support: NO GUI: QT: NO Win32 UI: YES OpenGL support: NO VTK support: NO Media I/O: ZLib: build (ver 1.2.8) JPEG: build (ver 90) WEBP: build (ver 0.3.1) PNG: build (ver 1.6.19) TIFF: build (ver 42 - 4.0.2) JPEG 2000: build (ver 1.900.1) OpenEXR: build (ver 1.7.1) GDAL: NO Video I/O: Video for Windows: YES DC1394 1.x: NO DC1394 2.x: NO FFMPEG: YES (prebuilt binaries) codec: YES (ver 56.41.100) format: YES (ver 56.36.101) util: YES (ver 54.27.100) swscale: YES (ver 3.1.101) resample: NO gentoo-style: YES GStreamer: NO OpenNI: NO OpenNI PrimeSensor Modules: NO OpenNI2: NO PvAPI: NO GigEVisionSDK: NO DirectShow: YES Media Foundation: NO XIMEA: NO Intel PerC: NO Parallel framework: Concurrency Other third-party libraries: Use IPP: 9.0.1 [9.0.1] at: C:/Program Files (x86)/Jenkins/jobs/OpenCV/workspace/3rdparty/ippicv/unpack/ippicv_win Use IPP Async: NO Use Eigen: YES (ver 3.1.0) Use Cuda: YES (ver 7.0) Use OpenCL: YES Use custom HAL: NO NVIDIA CUDA Use CUFFT: YES Use CUBLAS: NO USE NVCUVID: NO NVIDIA GPU arch: 20 21 30 35 50 52 NVIDIA PTX archs: 30 Use fast math: NO OpenCL: <Dynamic loading of OpenCL library> Include path: C:/Program Files (x86)/Jenkins/jobs/OpenCV/workspace/3rdparty/include/opencl/1.2 Use AMDFFT: NO Use AMDBLAS: NO Python 2: Interpreter: C:/Users/MyUser/AppData/Local/Programs/Python/Python35/python.exe (ver 3.5.1) Python 3: Interpreter: C:/Users/MyUser/AppData/Local/Programs/Python/Python35/python.exe (ver 3.5.1) Python (for build): C:/Users/MyUser/AppData/Local/Programs/Python/Python35/python.exe Java: ant: NO JNI: C:/Program Files/Java/jdk1.8.0_40/include C:/Program Files/Java/jdk1.8.0_40/include/win32 C:/Program Files/Java/jdk1.8.0_40/include Java wrappers: NO Java tests: NO Matlab: Matlab not found or implicitly disabled Documentation: Doxygen: NO PlantUML: NO Tests and samples: Tests: YES Performance tests: YES C/C++ Examples: NO Install path: C:/Program Files (x86)/Jenkins/jobs/OpenCV/workspace/build/install cvconfig.h is in: C:/Program Files (x86)/Jenkins/jobs/OpenCV/workspace/build ----------------------------------------------------------------- ```
category: core,category: 3rdparty
low
Critical
232,087,989
rust
Provide a way to interpolate crate version in html_root_url
In Serde we work around this by having a reminder in Cargo.toml to update the html_root_url when releasing a new version. https://github.com/serde-rs/serde/commit/dc7ab2696a14fe5ca219ac09f8496bdc613ff602 ```toml [package] version = "1.0.8" # remember to update html_root_url ``` ```rust #![doc(html_root_url = "https://docs.rs/serde/1.0.8")] ``` This is annoying and easily falls out of sync. For example mio 0.6.8 docs point to version 0.6.1: https://github.com/carllerche/mio/issues/613. There should be a way to keep these synchronized automatically.
T-rustdoc,C-feature-request
low
Minor
232,089,751
rust
Link no-deps documentation with no html_root_url to docs.rs by default
As of Rust 1.19.0-nightly, documenting a crate with `cargo doc --no-deps` will link to the html_root_url of any dependencies that have one set, and other dependencies will not be linked. ![selection_056](https://cloud.githubusercontent.com/assets/1940490/26560902/bd1da5f2-446e-11e7-9eff-87dd4ae555fa.png) In the screenshot, the crate providing `HasHtmlRootUrl` has an html_root_url so the type is linked. The crate providing `NoHtmlRootUrl` does not have an html_root_url so the type is not linked. Linking `NoHtmlRootUrl` to docs.rs would be a reasonable fallback.
T-rustdoc,C-feature-request
low
Major
232,159,801
TypeScript
No object literal completions for type parameter constrained to mapped type
Isolated from [this StackOverflow issue](https://stackoverflow.com/questions/44252421/how-to-extend-list-all-typescript-class-properties-and-methods-in-constructor) ```ts interface Foo { foo(): void; } declare function f<T extends Partial<Foo>>(x: T): T; f({ /*$*/ }) ``` Request completions at the cursor in the above sample. **Expected:** `foo` is a completion. **Actual:** No completions.
Suggestion,Domain: Completion Lists,Experience Enhancement
low
Minor
232,225,940
go
net/http: connection reuse does not work happily with normal use of json package
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? go 1.8.1 ### What operating system and processor architecture are you using (`go env`)? ``` GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" ``` ### What did you do? Used `json.NewDecoder(resp.Body)` to read the body of an http response. The http request was using TLS. This is a [playground app](https://play.golang.org/p/p7edRynwDJ) demonstrating the issue ### What did you expect to see? I expected the tls connection reused on subsequent requests ### What did you see instead? The tls connection is discarded and a new connection is opened for every request I also started [a thread](https://groups.google.com/d/msg/golang-nuts/m4wtJLnLFTE/pmOXglyvBgAJ) on the mailing list
NeedsFix
medium
Major
232,317,648
TypeScript
Affine types / ownership system
<!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md --> It would be amazing if typescript could gain types with an ownership semantics as it could provide a very powerful tool against bugs caused by mutations. Idea is inspired by [Rust's owneship system](https://doc.rust-lang.org/book/ownership.html) and adapted to match ts / js language. Idea is to provide built-in types for which move semantics would be tracked. In the example below I'll refer to that type as `Own<t>` Ensures that there is exactly one binding to any given `Own<t>`, if it is assigned to another binding type of the former binding should become `Moved<t>` and type of the new binding should be `Own<t>`. ```ts const array:Own<number[]> = [1, 2, 3] const array2 = array // => <Own<number[]>> [1, 2, 3] const first = array[0] <- [TS]: `Moved<number[]>` has no index signature. ``` A similar thing should happens if function is passed `Own<t>`, binding in the caller scope will get type `Moved<t>`: ```ts function take(array: Own<number[]>) { // What happens here isn’t important. } let array:Own<number[]> = [1, 2, 3]; take(array); array[0] // <- [TS]: `Moved<number[]>` has no index signature. ``` Rust also has also [borrowing semantics](https://doc.rust-lang.org/book/references-and-borrowing.html#borrowing) which may be also worse pursuing. But for now I'm going to leave it out until I get some initial feedback. ### Why Typescript already provides tools to deal with the same class of issues using `readonly` feature, which is nice but mostly useful with immutable data structures that do impose an overhead. With an ownership system it would be possible to author performance critical code without an overhead while still maintaining safety guarantees from the type system.
Suggestion,Awaiting More Feedback
medium
Critical
232,357,558
go
cmd/compile: improve escape analysis of make([]T, n) where n is non-constant
``` $ cat a.go package p var n = 3 func f() { slice := make([]*int, n) var i int slice[0] = &i } $ go tool compile -m a.go a.go:5:6: can inline f a.go:6:15: make([]*int, n) escapes to heap a.go:8:13: &i escapes to heap a.go:7:6: moved to heap: i ``` In this program, the compiler's escape analysis judges that the array allocated by `make` escapes to the heap, when in fact it does not, presumably because its size is non-constant and thus it cannot be allocated on the stack (without `alloca`). The lack of this optimization makes it hard to write a good bytecode interpreter in Go because the interpreter's operand stack has a non-constant size, and is thus heap-allocated, even though it is guaranteed by construction not to escape. Consequently, the interpreter incurs a heap allocation at the start of each function, and then a GC write barrier each time it stores an operand to the stack, which is a common operation. Perhaps the notions of "escapes to heap" and "requires a write barrier" could be decoupled so that a non-constant-sized non-escaping heap variable could avoid write barriers. Or perhaps the compiler could use `alloca` to allocate non-constant-size non-escaping variables on the stack.
Performance,compiler/runtime
medium
Major
232,397,132
pytorch
Feature Request: load_state_dict should take filenames
In high memory pressure situations, the following is a common occurrence: 1. create model 2. read state_dict from checkpoint file (loads on GPU) 3. model.load_state_dict(s) Because of memory pressure, a common workaround is to first do: ``` s = torch.load('my_file.pt', map_location=lambda storage, loc: storage) ``` And then load `s` into `model`. This is a very common scenario that we should be able to avoid, and this scenario might have some pitfalls: what happens on part-GPU part-CPU models, what happens on multi-GPU models... if load_state_dict took a filename directly, it can delete it's existing parameter storages and set them to the new one on the fly, thereby requiring no extra memory.
feature,module: nn,triaged
low
Minor
232,439,113
TypeScript
Improve Javascript intellisense type inference for cases where Object.assign(this, ...) is used with an object with known type information
_From @jj101k on May 28, 2017 10:16_ - VSCode Version: 1.12.2 (19222cdc84ce72202478ba1cec5cb557b71163de) - OS Version: macOS Sierra 10.12.5 (16F73) Given the Javascript code: ```js class Foo { constructor() { Object.assign( this, { bar: "abc", } ); this.foo = "def"; } } var f = new Foo(); console.log(f.foo); console.log(f.bar); ``` If you hover over `f.foo`, it will tell you that it's a string. If you hover over `f.bar`, it will say it's "any". They should both say "string". Object.assign is a fairly common way of setting several properties with a bit less copy/paste. In cases where an object without known type information is used as the last argument it isn't possible to statically infer appropriate types for the modified object ("this", here) and equivalently the object that Object.assign returns. Where type information of the last argument _is_ known, it is safe and appropriate to import all of that into the type information for the object, as if a series of direct assignments had been done. Caveats: In Javascript (perhaps not Typescript) it's possible that further unknown properties are present on any given object, so it would be appropriate to void all inferred type information which is not between Object.assign and the end of the constructor. If Object.assign is used outside a constructor (on a named object) it should void all inferred types entirely, because the type information could be entirely different before and after. The same should be true if Object.assign is conditionally called in the constructor. The only exception should be when all arguments after the first have known final type information, eg. an immediate object. For practical purposes, `Object.assign(foo, bar, {baz: 1})` should be considered equivalent to `for(name in bar) if(bar.hasOwnProperty(name)) foo[name] = bar[name]; foo.baz=1;`. _Copied from original issue: Microsoft/vscode#27397_
Suggestion,Awaiting More Feedback,VS Code Tracked,Domain: JavaScript
medium
Major
232,447,679
rust
In rustdoc, omit trait impls that a user cannot call
```rust pub struct Public; struct Private; impl From<Private> for Public { fn from(_: Private) -> Self { unimplemented!() } } ``` The rustdoc of `Public` displays a `From` impl that cannot be invoked by users of the crate. ![selection_057](https://cloud.githubusercontent.com/assets/1940490/26615406/77d6e194-457b-11e7-919c-29d309f8813d.png) I'm sure there are lots of edge cases to consider, but this is a common pattern especially for error types for use with `?`. It would be nice to hide such impls from rustdoc without requiring the crate author to tag them with `#[doc(hidden)]`. This came up during the libz blitz evaluation of the reqwest crate. https://github.com/seanmonstar/reqwest/issues/106
T-rustdoc,A-visibility,C-feature-request
low
Critical
232,543,412
TypeScript
Feature Request: Make "loaders" a first class citizen of the language
This follows some thoughts I had with _["The Maybe Future of Frontend Tooling"](https://medium.com/@pipopeperoni/the-maybe-future-of-frontend-tooling-80e6d96f8125)_ and picks up some use cases which aren't covered by the current (_awesome_!) [language server plugin support](https://github.com/RyanCavanaugh/sample-ts-plugin) as far as I know. I also created https://github.com/Microsoft/TypeScript/issues/15589 which refers to _linter rules_. This issue is about _loaders_ - in the sense how they were [introduced by webpack](https://webpack.js.org/concepts/loaders/). In general both issues - this one and https://github.com/Microsoft/TypeScript/issues/15589 - remind me of Cheng Lous talks about [_"Taming the Meta Language"_](https://www.youtube.com/watch?v=_0T5OSSzxms) and [_"What's in a language?"_](https://www.youtube.com/watch?v=24S5u_4gx7w). Linters and loader are not a part of the current language in a strict sense, but part of our meta language and it is good to formalize more of them so they become a language construct. (Part of Cheng Lous talks is about why reason for example doesn't have a separate linter.) **Current state** - Loaders like they are used by webpack allows us to require non JavaScript files (or non TypeScript files) and transform them into a JavaScript/TypeScript "file" _or_ require JavaScript/TypeScript files and transform them so they'll have a different interface. - TypeScript supports loaders in two ways: - Either write an interface for them directly (e.g. `declare module 'foo-loader?param=bar!../test';`). - Or use a wild card (e.g. `declare module 'foo-loader?*`). - This is either cumbersome/error prone and/or limited, because they interfaces can't be typed in a very dynamic way. - Two use cases which we currently have, which I'd like to point out: **Use case 1** We have translations in a file called `en.properties` (and other files for other languages) which could look like this: ``` say-something={gender, select, f {She} m {He}} is great. ``` I'd like to import this file as `import { saySomething } from '../i18n/en.properties';` which would have an interface like this: ``` declare module '../i18n/en.properties' { /** * `en`: {gender, select, f {She} m {He}} is great. * `de`: {gender, select, f {Sie} m {Er}} ist toll. */ export function saySomething(data: { gender: 'f' | 'm' }): string; } ``` [We currently need to pre-compile our translations](https://github.com/Mercateo/ws/blob/master/src/lib/i18n/compile.ts#L154) and emit a `.d.ts` and a `.js`, so we import the `.js` instead of the `.proprties`. Only then we get this complex interface. **Use case 2** We add new exported functions to existing modules [so we can mock them easily](https://github.com/Mercateo/import-inject-loader). _What_ will be added depends on the query parameters of the loader. It could look like this: `'import-inject-loader?fetch!../src/get-users'`. E.g. using `import-inject-loader?fetch` will add two new exported functions to `../src/get-users`: `ilOverwriteFetch` and `ilResetAll`. Currently we need declare every module which uses `import-inject-loader` as `any` ([`declare module 'import-inject-loader?*';`](https://github.com/Mercateo/frontend-unit-tests-examples/blob/master/typings/custom.d.ts#L7)). Everything else would be too hard to maintain. **What I'd like to see** * I would like to get proper typings for imported files where the content changes the interface (= use case 1) without precompiling, but with importing the file directly. * I would like to get proper typings for files with existing interfaces, but which are transformed (in the easiest case just extended) into a different interface without loosing the original interface (= use case 2). * I would like to get proper typings for imported modules, when the interface changes, because of loader options (= use case 2). * I would like to get assistance when configuring loaders through query parameters (= use case 2, e.g. show an error, when I write `'import-inject-loader?fetch!../src/get-users'`, if there is no `fetch` used inside `../src/get-users`). --- If something like that isn't in the scope of a TypeScript core team, I could think of giving a new "TypeScript tooling team" this scope which develops closely together with the TypeScript core team in a similar fashion like the VS code team. I think it is important to address these meta language issues _somehow_ in an official way to get a nice TypeScript ecosystem.
Needs Investigation
low
Critical
232,623,143
neovim
Timer behavior is inconsistent with Vim
This was noticed while merging Vim's timer tests, since the timing windows that are expected differ between Vim and Neovim. I figured we should discuss the differences and decide whether it's something that should be addressed or just accepted/documented as being different. ## Timer period Since Neovim uses libuv, the timer is constantly running. The callback gets queued when the timer fires as long as the event loop isn't busy. Since Vim manually manages the timer, the timer is rescheduled after a callback finishes executing. Similarly, a paused timer in Vim that exceeds its timer will execute the callback "immediately" where as in Neovim it can be delayed for close to a full timer period since the callback needs to get queued again. To make this concrete, pretend there's a 10 ms timer with a callback that takes 5 ms. ### Timing of repeated callbacks #### 1a. Vim ``` Timer: ---------| ---------| ---------| Callback: ----| ----| ``` #### 1b. Neovim ``` Timer: ---------|---------|---------| Callback: ----| ----| ``` On the other hand, if the timer is short but the execution is long it looks like this: #### 2a. Vim ``` Timer: ----| ----| ----| Callback: ---------| ---------| ``` #### 2b. Neovim ``` Timer: ----|----|----|----|----|----|----| Callback: ---------| ---------| ``` ### Timing of repeated callbacks in the presence of pauses Same timer and callback, but with a 3 ms pause injected with 6 ms between each pause. #### 3a. Vim ``` Timer: ----------| ----------| Pause: xxx xxx xxx xxx Callback: -----| -----| ``` #### 3b. Neovim ``` Timer: ----------|----------|----------|----------|----------| Pause: xxx xxx xxx xxx xxx xxx xxx Callback: -----| ----| ``` On the other hand, if the timer is short but the execution is long it looks like this: #### 4a. Vim ``` Timer: ----| ----| ----| Pause: xxx xxx xxx xxx xxx Callback: ---------| ---------| ---------| ``` #### 4b. Neovim ``` Timer: ----|----|----|----|----|----|----|----|----| Pause: xxx xxx xxx xxx xxx xxx Callback: ---------|---------|---------| ---------| ```
needs:decision,compatibility,needs:design,event-loop
low
Major
232,631,241
vscode
Align explorer sorting with platform sorting
It looks like our file sorting in the explorer does not match platform beahviour in some cases. **Windows:** * a file `foo.ts` is sorted before `foo_test.ts` but we sort it the other way around **Linux:** * a file `foo.ts` is sorted before `foo_test.ts` but we sort it the other way around * a lowercase file seems to be sorted before an upper case file but we seem to mix the sorting independent of the casing (e.g. folders `[out, outb, outd, Outa, Outc]` are showing up as `[out, OutA, outb, Outc, outd]` **macOS:** * seems to be OK We use a JavaScript [`Collator`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Collator) for the comparing [here](https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/comparers.ts#L19). Unfortunately I am not able to tweak the Collator options to bring me the desired result...
feature-request,file-explorer
high
Critical
232,650,476
electron
Virtual File Drag & Drop Events
Many drag and drop operations contain virtual file data. Chrome currently only accepts files on disk. This means that you can't drag images directly from a browser into an Electron app. The same is true for e-mails in Outlook/Mail.app, entries in Calendar apps, etc. * Electron version: All * Operating system: macOS, Windows, Linux ### Expected behavior When a virtual file is dropped on an Electron app, the developer should have some means of retrieving the data. ### Actual behavior Chrome only handles `CF_HDROP` data (and it seems like that won't change anytime soon), so we might have to help ourselves here. The drop event is received, but all data fields are empty. ### How to reproduce Load http://html5demos.com/file-api in an electron app. Try to drag an image from Chrome into the upload area. The cursor will change, the image will be "dragged", but no data will be received.
enhancement :sparkles:,component/drag-and-drop
low
Major
232,662,541
neovim
RPC commands always defined using f-args
(Subverting issue template as it doesn't seem to apply) Currently, all commands defined via the RPC interface have to use f-args as the input method for the arguments, see https://github.com/neovim/neovim/blob/fcc9d999670c6fb29ac01e9c8d0a7e787ccfabea/runtime/autoload/remote/define.vim#L58 It could be useful to use the others, e.g. `<args>`, `<q-args>` etc. It could be made part of the api, and then exposed by the RPC clients for command definition.
enhancement,plugin,channels-rpc
low
Minor
232,704,689
rust
[RFC] Refactor types to be a `(TypeCore, Substs)` pair
Currently, [the `Ty<'tcx>` type][ty] is a reference to [a struct (`&TyS`)][tys] that packages up [a big ol' enum `TypeVariants`][tv]. As part of [chalkification](https://github.com/rust-lang/rust-roadmap/issues/8), we would like to be able to write more efficient "decision tree" like procedures that branch on this type. This would be made nicer by factoring out the type into two parts, a "core" and a "substs". This core would be roughly equivalent to the existing `TypeVariants`, but without the recursive references to other types, which would be uniformly packaged up in the `substs`. [ty]: https://github.com/rust-lang/rust/blob/171d2857560a3c109d59d946bf3ff74a42d0ab33/src/librustc/ty/mod.rs#L538 [tys]: https://github.com/rust-lang/rust/blob/171d2857560a3c109d59d946bf3ff74a42d0ab33/src/librustc/ty/mod.rs#L498-L504 [tv]: https://github.com/rust-lang/rust/blob/171d2857560a3c109d59d946bf3ff74a42d0ab33/src/librustc/ty/sty.rs#L95-L184 Thus I imagine that the `TyS` struct would change to something like this: ```rust pub struct TyS<'tcx> { pub sty: TypeVariants<'tcx>, // this is the "core" part pub substs: &'tcx Substs<'tcx>, // this is the "substs" part, extracted from `TypeVariants` pub flags: TypeFlags, // the maximal depth of any bound regions appearing in this type. region_depth: u32, } ``` (Incidentally, this new notion of `TypeVariants` could maybe subsume the existing [`SimplifiedType`](https://github.com/rust-lang/rust/blob/171d2857560a3c109d59d946bf3ff74a42d0ab33/src/librustc/ty/fast_reject.rs#L19-L36), though that's not super important.) ### Steps This transition is best made in steps: - [x] #42171: refactor ProjectionTy to store def-id of associated item + substs - PR: #42297 - [x] [transition `TyTuple` to use a substs](https://github.com/rust-lang/rust/blob/171d2857560a3c109d59d946bf3ff74a42d0ab33/src/librustc/ty/sty.rs#L163) - This would make things more regular, but we "lose" the fact that tuples are always composed of types at the moment. Probably not important in practice. - [x] [remove the `ClosureSubsts` type used in `TyClosure` and make it into a normal substs](https://github.com/rust-lang/rust/blob/171d2857560a3c109d59d946bf3ff74a42d0ab33/src/librustc/ty/sty.rs#L153) - [x] [do the same for `GeneratorSubsts`] ### Unknowns It's not 100% clear that this is a good plan, though the individual refactorings above all seem like good steps regardless. Some complicating factors: - `TyFnPtr` embodies a `PolyFnSig`, which carries a binder. - Existential types carry where-clauses (eventually, function pointers may do the same, to address https://github.com/rust-lang/rust/issues/25860) cc @eddyb, who first suggested this to me cc @tschottdorf, who implemented #42297, a step along this path (and an important step for ATC regardless)
C-cleanup,T-compiler
low
Major
232,710,616
electron
Add support for SVG nativeImage
<!-- Thanks for opening an issue! A few things to keep in mind: - The issue tracker is only for bugs and feature requests. - Before reporting a bug, please try reproducing your issue against the latest version of Electron. - If you need general advice, join our Slack: http://atom-slack.herokuapp.com --> * Electron version: 1.6.10 * Operating system: elementary OS 0.4.1 Loki ### Expected behavior It should be possible to set a tray image in SVG format. This would allow tray icons to adapt to the current theme (ie. appear white on black, or black on white). ### Actual behavior The image must be supplied as a PNG or a JPG and therefore does not adapt to the platform's theme. ### How to reproduce ``` new Tray('/path/to/image.png'); ```
enhancement :sparkles:,component/tray,platform/all
medium
Critical
232,718,652
rust
introduce region-clauses into the `ParamEnv`, use to replace the `body_id`
When we are in a closure body, we often gain additional implied "outlives" relation based on the types of the closure arguments. Consider this: ```rust foo(|x: &T| ...) ``` Here, the type of `x` will be `&'0 T` for some anonymous region `'0`. Within the function body, then, we can conclude that `T: '0`. We currently handle this through a variety of messy schemes. As part of [chalkificaton](https://github.com/rust-lang/rust-roadmap/issues/8), I would like to consolidate this into a cleaner, more uniform handling of environments and universes. This issue lays out an "evolving" plan for doing that. ### Current handling Currently, for every trait obligation that we have to prove (e.g., `T: Debug`), we have an `ObligationCause` -- this is *primarily* used for debugging, in that it specifies *why* we have to prove this thing. However, this type also carries a `body_id` identifying the closure it came from. When we wind up having to prove an outlives relationship like `Foo: 'a`, we record this in the fulfillment context (a kind of record of things we have yet to prove), and we track the `body_id` where the obligation was incurred. Then, after type-checking, in the region-checking phase, we walk down the AST and figure out -- for each closure body -- what outlives facts we know at that point in time. We then pull out the list of outlives obligations from the fulfillment cx for a given body-id and try to prove them, using those facts. This whole process is complex and fragile. ### Roughly how I want it to work We now have the ability to have every obligation have its own, distinct environment (we used to have just one ambient environment). This means that instead of having this ad-hoc `body_id` field, we can just extend the environment when we enter into a closure body. So, for example, when type-checking the body of the closure in the beginning, our environment would be extended with a `T: 'a` outlives clause. We can do this right away, just as soon as we start type-checking the closure. This environment is automatically propagated to sub-goals, so when we wind up with some outlives obligations that we have to prove, they will have `T: 'a` in their list of clauses (i.e., the facts that they can draw upon). This means that regionck doesn't have to do anything "special" -- rather, the input to regionck will change from being a flat list of obligations, to obligations that can carry more environmental information. There is one complication here: - when we first start type-checking closures, we often have not yet inferred the types of the arguments yet. This is partly why the current scheme defers everything until regionck. But this is ok, we can still insert "outlives" obligations that contain inference variables. We'll give them their final values before we go and solve things. ### Actual steps OK, I ran out of time for this part. =)
C-cleanup,A-trait-system,T-compiler
low
Critical
232,820,582
kubernetes
Consolidate pod-nannies
Follow-up of https://github.com/kubernetes/kubernetes/pull/46700#discussion_r119539877 There are a lot of pod-nannies in the cluster already, each of them consuming non-zero amount of resources (90+MB of memory, 50+m cpu). It would be much more preferable to have only one nanny which can be configured to scale multiple pods. Maybe this should be a separate controller? With an API representation? /cc @piosz @wojtek-t
kind/cleanup,sig/scalability,sig/autoscaling,sig/instrumentation,priority/important-longterm,lifecycle/frozen
low
Major
232,831,773
create-react-app
Move more things to react-dev-utils
I want to make react-scripts easier to fork/extend. I think the way to do that is to move as much as possible into react-dev-utils so that react-scripts can be a smaller package that changes less frequently. Then you can always just update the react-dev-utils to get most new features in react-scripts. This should also make ejecting much less painful, as ejected projects still depend on react-dev-utils My proposal is to move: 1. config/webpackDevServer.config.js - This can just take `publicPath` and `appPublic` as additional options 2. config/polyfills.js - this can just be moved as is - do we want to include it in what gets ejected still, or just reference it from react-dev-utils? I feel like just referencing it probably makes the most sense. 3. config/env.js - This will need to take `dotenvPath` as an argument, and `delete require.cache[require.resolve('./paths')];` will have to be done elsewhere. 4. each of the three jest transforms - these can just be moved as is, and then they won't need to be ejected either. 5. scripts/utils/createJestConfig.js - this will just need to take `paths.testsSetup` and `paths.appPackageJson` as arguments. I then think we should add a `pathUtils` module in react-dev-utils, containing `resolveApp`, `getPublicUrl`, `getServedPath` and `resolveOwn`. This should simplify `config/paths.js` quite a bit. At this point, I think we should re-evaluate what else needs moving. If nobody objects, I'll start submitting pull requests for these changes.
issue: proposal
low
Major
232,923,628
vue
Transition group classes not being properly deleted when using v-show
### Version 2.3.3 ### Reproduction link [https://jsfiddle.net/ma7moudat/u82ugj8z/1/](https://jsfiddle.net/ma7moudat/u82ugj8z/1/) ### Steps to reproduce Set up a transition group that automatically rotates through a list of items and shows one item at a time (a slider if you will). ### What is expected? The last item disappears and the new item appears at the specified intervals. ### What is actually happening? Everything seems to be running perfectly fine, but if you leave the window for a minute or so (go to a new tab or another window) and then come back, the transition group becomes a mess, because the transition classes get added over and over without being removed from the items. So you would get something like this! ```<div class="item crossfade-enter-to crossfade-enter-to crossfade-leave-to crossfade-enter-to crossfade-leave-to crossfade-enter-to crossfade-leave-to crossfade-enter-to crossfade-leave-to crossfade-enter-to crossfade-leave-to crossfade-enter-to crossfade-leave-to crossfade-enter-to crossfade-leave-to crossfade-enter-to crossfade-leave-to .........">``` <!-- generated by vue-issues. DO NOT REMOVE -->
improvement,has PR,transition
low
Major
232,946,287
rust
Wishlist: compiler should give hint when trying to use Box<Trait> as Trait
If I have a function: ``` fn foo<F: Foo>(f: F) { ... } ``` and I pass it `Box<Foo>`, this fails because `Box<Foo>` doesn't actually implement the `Foo` trait. Ideally it should, but as a stop-gap the compiler should hint at that problem, because it wasn't obvious to me that a boxed trait object doesn't implement that trait.
A-type-system,C-enhancement,A-diagnostics,A-trait-system,T-compiler,T-types
low
Minor
232,984,564
flutter
Do plugins need to know about hot reload and hot restart?
I think it would be an OK design choice if they didn't. But it's probably better if they do. If we need to add new API to teach plugins about hot-reload or hot-restart we might need to do that sooner rather than later. FYI @mravn-google
engine,P2,a: plugins,team-engine,triaged-engine
low
Critical
233,005,707
react
Error when `__source` is provided to production build
Currently if the `__source` transform is enabled together with the production build there are no indicators of a poorly performant configuration. https://facebook.github.io/react/ even has it. We already check for the [existence of a `__source` field](https://github.com/facebook/react/blob/master/src/isomorphic/classic/element/ReactElement.js#L203). So we can just reuse the same check to issue something in prod mode if it exists. The problem is that we don't have any warning module in prod and it is unclear if it would get attention or even considered to spammy in prod. We could throw but that might be too extreme since a misconfiguration would kill the site. We could also use this to set a flag on the `__REACT_DEVTOOLS_GLOBAL_HOOK__` object. The icon in the devtools extension could use this to indicate a misconfigured build.
Type: Enhancement,Component: Developer Tools,React Core Team
medium
Critical
233,049,992
go
x/build: restore performance benchmarking dashboard
In a trybot run in https://storage.googleapis.com/go-build-log/dd2f2f0c/linux-amd64_19b3a9d1.log , after the build and the tests are complete, I see this: ##### iteration: 0 start-time: 2017-06-02T00:53:45Z building testgo failed: exit status 1 can't load package: package .: no buildable Go source files in /tmp/workdir/go-parent Error: tests failed: dist test failed: bench:bench-cmd-go.exe -test.bench . -test.benchmem -test.run ^$ -test.benchtime 100ms: exit status 2
Builders,NeedsFix
low
Critical
233,063,853
kubernetes
Make "--feature-gates" flag component-related
<!-- Thanks for filing an issue! Before hitting the button, please answer these questions.--> **Is this a request for help?** (If yes, you should use our troubleshooting guide and community support channels, see https://kubernetes.io/docs/tasks/debug-application-cluster/troubleshooting/.): **Note:** Please file issues for subcomponents under the appropriate repo | Component | Repo | | --------- | ------------------------------------------------------------------ | | kubectl | [kubernetes/kubectl](https://github.com/kubernetes/kubectl/issues/new) | | kubeadm | [kubernetes/kubeadm](https://github.com/kubernetes/kubeadm/issues/new) | **What keywords did you search in Kubernetes issues before filing this one?** (If you have found any duplicates, you should instead reply there.): --- **Is this a BUG REPORT or FEATURE REQUEST?** (choose one): Enhancement. <!-- If this is a BUG REPORT, please: - Fill in as much of the template below as you can. If you leave out information, we can't help you as well. If this is a FEATURE REQUEST, please: - Describe *in detail* the feature/behavior/change you'd like to see. In both cases, be ready for followup questions, and please respond in a timely manner. If we can't reproduce a bug or think a feature already exists, we might close your issue. If we're wrong, PLEASE feel free to reopen it and explain why. --> **Kubernetes version** (use `kubectl version`): HEAD **Environment**: - **Cloud provider or hardware configuration**: - **OS** (e.g. from /etc/os-release): - **Kernel** (e.g. `uname -a`): - **Install tools**: - **Others**: **What happened**: We have `--feature-gates` flag in help info of every main components. And all of them have the same options listed. ``` Accelerators=true|false (ALPHA - default=false) AdvancedAuditing=true|false (ALPHA - default=false) AffinityInAnnotations=true|false (ALPHA - default=false) AllAlpha=true|false (ALPHA - default=false) AllowExtTrafficLocalEndpoints=true|false (default=true) AppArmor=true|false (BETA - default=true) DynamicKubeletConfig=true|false (ALPHA - default=false) DynamicVolumeProvisioning=true|false (ALPHA - default=true) ExperimentalCriticalPodAnnotation=true|false (ALPHA - default=false) ExperimentalHostUserNamespaceDefaulting=true|false (BETA - default=false) PersistentLocalVolumes=true|false (ALPHA - default=false) StreamingProxyRedirects=true|false (BETA - default=true) TaintBasedEvictions=true|false (ALPHA - default=false) ``` When users want to switch a feature gate on, it's hard to know which components need to enable the flag. Take `AffinityInAnnotations` for example, users might know they should enable this flag for apiserver and scheduler. But how about controller-manager and kubelet? They might need or not. For kube-proxy, it obviously doesn't need to enable this flag. **What you expected to happen**: Only show the options for components which need them. It would be good to have a documentation to guide users. **How to reproduce it** (as minimally and precisely as possible): **Anything else we need to know**: /sig api-machinery
kind/documentation,kind/feature,lifecycle/frozen,wg/component-standard
medium
Critical
233,138,744
vscode
Have ctrl+click work the same way as in Visual Studio
we use dblclick LBtn to select a word, but using ctrl +LBtn is a good way, in vs studio we could do the following: 1. basic: press ctrl and click a word, the word is selected. 2. advanced: when a word is selected , press ctrl+shift and select another word, so we could select from the start of the first word to the end of the last word 3.advanced: with ctrl down, we clicked a word, don't release the LBtn, move the mouse to some where in the middle of the next word , the whole next word will be selected. this is the same effect as the "ctrl + right"
feature-request,editor-core
medium
Major
233,209,590
go
x/net/bpf: bpf VM only supports running programs with big endian
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? go version go1.7.4 linux/amd64 ### What operating system and processor architecture are you using (`go env`)? GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/home/egon/devel/go" GORACE="" GOROOT="/usr/lib/go-1.7" GOTOOLDIR="/usr/lib/go-1.7/pkg/tool/linux_amd64" CC="gcc" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build717134135=/tmp/go-build -gno-record-gcc-switches" CXX="g++" CGO_ENABLED="1" ### What did you do? I am using x/net/bpf so that I can simulate a bunch of bpf programs generated by libseccomp-golang in the net/bpf VM to validate a small txt->bpf compiler. I ran into the problem that the x/net/bpf VM assumes BigEndian byte order. However libseccomp-golang generates code in host byteorder (which happens to be little endian on my machine) so the simulation is not working as expected. ### What did you expect to see? I was hoping the VM would let me control the endianness. Please consider the following diff, it is fully backwards compatible but it will let me run libseccomp generated bpf programs inside the VM. <pre> diff --git a/bpf/vm_instructions.go b/bpf/vm_instructions.go index 516f946..2263c3f 100644 --- a/bpf/vm_instructions.go +++ b/bpf/vm_instructions.go @@ -134,6 +134,10 @@ func inBounds(inLen int, offset int, size int) bool { return offset+size <= inLen } +// VmEndianness controlls what byte order the bpf.VM is using. +// The default is binary.BigEndian +var VmEndianness binary.ByteOrder = binary.BigEndian + func loadCommon(in []byte, offset int, size int) (uint32, bool) { if !inBounds(len(in), offset, size) { return 0, false @@ -143,9 +147,9 @@ func loadCommon(in []byte, offset int, size int) (uint32, bool) { case 1: return uint32(in[offset]), true case 2: - return uint32(binary.BigEndian.Uint16(in[offset : offset+size])), true + return uint32(VmEndianness.Uint16(in[offset : offset+size])), true case 4: - return uint32(binary.BigEndian.Uint32(in[offset : offset+size])), true + return uint32(VmEndianness.Uint32(in[offset : offset+size])), true default: panic(fmt.Sprintf("invalid load size: %d", size)) } </pre>
NeedsInvestigation
low
Critical
233,264,153
youtube-dl
Downloading from Ooyala - Flograpping
Hi I am trying to download the video from this page: http://www.flograppling.com/video/1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#.WTGnl8aTSUk It is my understanding that the youtube-dl supports Ooyala and looking at the source code the video is run by Ooyala. I ran the following commands but had no luck: youtube-dl.exe -v "http://www.flograppling.com/video/1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#.WTGnl8aTSUk" The output: ```[debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['-v', 'http://www.flograppling.com/video/1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#.WTGnl8aTSUk'] [debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252 [debug] youtube-dl version 2017.05.29 [debug] Python version 3.4.4 - Windows-10-10.0.14393 [debug] exe versions: none [debug] Proxy map: {} [generic] 1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#: Requesting header WARNING: Falling back on generic information extractor. [generic] 1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#: Downloading webpage [generic] 1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#: Extracting information ERROR: Unsupported URL: http://www.flograppling.com/video/1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#.WTGnl8aTSUk Traceback (most recent call last): File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpf1wnshrp\build\youtube_dl\YoutubeDL.py", line 760, in extract_info File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpf1wnshrp\build\youtube_dl\extractor\common.py", line 433, in extract File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpf1wnshrp\build\youtube_dl\extractor\generic.py", line 2795, in _real_extract youtube_dl.utils.UnsupportedError: Unsupported URL: http://www.flograppling.com/video/1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#.WTGnl8aTSUk ``` youtube-dl -v -o "/media/%(title)s.mp4" http://www.flograppling.com/video/1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#.WTGnl8aTSUk The output: ```[debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['-v', '-o', '/media/%(title)s.mp4', 'http://www.flograppling.com/video/1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#.WTGnl8aTSUk'] [debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252 [debug] youtube-dl version 2017.05.29 [debug] Python version 3.4.4 - Windows-10-10.0.14393 [debug] exe versions: none [debug] Proxy map: {} [generic] 1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#: Requesting header WARNING: Falling back on generic information extractor. [generic] 1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#: Downloading webpage [generic] 1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#: Extracting information ERROR: Unsupported URL: http://www.flograppling.com/video/1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#.WTGnl8aTSUk Traceback (most recent call last): File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpf1wnshrp\build\youtube_dl\YoutubeDL.py", line 760, in extract_info File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpf1wnshrp\build\youtube_dl\extractor\common.py", line 433, in extract File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmpf1wnshrp\build\youtube_dl\extractor\generic.py", line 2795, in _real_extract youtube_dl.utils.UnsupportedError: Unsupported URL: http://www.flograppling.com/video/1209962-andre-galvao-works-out-one-week-before-ibjjf-worlds#.WTGnl8aTSUk ``` FYI, I am running the latest version. I am not sure I would class this as an issue because I am a noob and I am sure I am doing something wrong, so your help would be greatly appreciated.
site-support-request
low
Critical
233,289,439
rust
Add span to E0271 errors pointing at the "found" associated type bound
This code produce next error: ```rust fn foo<F, R>(f: F) where F: FnOnce() -> R, R: IntoItem<Item=()> { } trait IntoItem { type Item; } struct S; impl IntoItem for S { type Item = u32; } fn main() { foo(|| S); } ``` error: ``` 35 | foo(|| S); | ^^^ expected u32, found () | = note: expected type `u32` found type `()` = note: required by `foo` ``` This is not correct, because expected type of foo is () (see functon signature). I'm ask to swap "expected" and "found" notes, because is very confused. For rust beginners this is embarassing (e.g., an error often occurs when works with `tokio` crate). It's also incorrect because underlining is on "foo" keyword, but should to argument. This error might look like this: ``` 35 | foo(|| S); | ^^^^ expected (), found u32 | = note: expected type `()` found type `u32` = note: required by `foo` ``` I suggest making a conclusion about this error easier, such as this: ```rust fn foo(v:u8){ } fn main(){ foo(25u16); //expected u8, found u16 <-- this is correct } ```
C-enhancement,A-diagnostics,T-compiler,D-papercut
low
Critical
233,291,738
rust
Could we clarify type error messages that involve traits + closures?
After a typo, I recently received the following error message: ``` error[E0277]: the trait bound `bintree::simple::BuilderError: std::convert::From<[closure@src/bintree/simple.rs:244:24: 244:51]>` is not satisfied --> src/bintree/simple.rs:243:24 | 243 | let kind = node.kind() | ________________________^ 244 | | .ok_or(|| BuilderError::MissingTag)?; | |____________________________________________________^ the trait `std::convert::From<[closure@src/bintree/simple.rs:244:24: 244:51]>` is not implemented for `bintree::simple::BuilderError` | = note: required by `std::convert::From::from` ``` The problem was that I used `ok_or` instead of `ok_or_else`. What I'd like to have seen (and what would have saved me a few minutes) is an additional line suggesting something like: « This operation does not work with a closure. » Could we perhaps detect that the scope contains no implementation of `From<T>` where `T` is a closure? This could, of course, be extended to other traits, but I suspect that it is worse for `Result<>`, since the call to `from` is not visible in the syntax.
C-enhancement,A-diagnostics,A-trait-system,A-closures,T-compiler
low
Critical
233,334,363
kubernetes
406 unacceptable error for POSTing without a content type to the LIST endpoint is wrong
When you POST to /resources, if you don't specify ContentType you get an error message that is incorrect (only suggests stream types).
sig/api-machinery,lifecycle/frozen
low
Critical
233,336,435
go
cmd/gofmt: puts `else if` comments in wrong place
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? play.golang.org ### What operating system and processor architecture are you using (`go env`)? play.golang.org ### What did you do? Ran this: https://play.golang.org/p/xJ0-Cq8ZYi and clicked `format` If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. here it is: https://play.golang.org/p/xJ0-Cq8ZYi ### What did you expect to see? I expected the B and C branch comments to be aligned the same way the A branch comment is.. ### What did you see instead? Instead they were indented as if they were part of the previous block. I get how this is a tricky issue, but if there is a blank line and the comment is right before the next block, I think it should be indented for that block. Thanks!
NeedsDecision
low
Critical
233,377,215
youtube-dl
vrv.co extractor not working
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x]) - Use *Preview* tab to see how your issue will actually look like --- ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.05.29*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.05.29** ### Before submitting an *issue* make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your *issue*? - [x] Bug report (encountered problems with youtube-dl) - [ ] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue* --- ### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` $ youtube-dl -v <your command line> [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2017.05.29 [debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2 [debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4 [debug] Proxy map: {} ... <end of log> ``` --- ### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://www.youtube.com/watch?v=BaW_jenozKc - Single video: https://youtu.be/BaW_jenozKc - Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights. --- ### Description of your *issue*, suggested solution and other information Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible. If work on your *issue* requires account credentials please provide them or explain how one can obtain them. The following command `youtube-dl -v https://vrv.co/watch/G65VE5K06/Bee-and-PuppyCat:Bee-and-PuppyCat-Pilot` fails with this error: ``` [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['-v', 'https://vrv.co/watch/G649DW70Y/Yu-Gi-Oh-VRAINS:First-Contact'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2017.05.29 [debug] Python version 3.6.1 - Linux-4.11.3-1-ARCH-x86_64-with-arch [debug] exe versions: ffmpeg 3.3.1, ffprobe 3.3.1, rtmpdump 2.4 [debug] Proxy map: {} [vrv] G649DW70Y: Downloading webpage [vrv] G649DW70Y: Downloading resource path JSON metadata [vrv] G649DW70Y: Downloading CMS Signing JSON metadata [vrv] G649DW70Y: Downloading video JSON metadata [vrv] G649DW70Y: Downloading streams JSON metadata [vrv] G649DW70Y: Downloading ja-JP MPD information Traceback (most recent call last): File "/usr/bin/youtube-dl", line 11, in <module> load_entry_point('youtube-dl==2017.5.29', 'console_scripts', 'youtube-dl')() File "/usr/lib/python3.6/site-packages/youtube_dl/__init__.py", line 465, in main _real_main(argv) File "/usr/lib/python3.6/site-packages/youtube_dl/__init__.py", line 455, in _real_main retcode = ydl.download(all_urls) File "/usr/lib/python3.6/site-packages/youtube_dl/YoutubeDL.py", line 1896, in download url, force_generic_extractor=self.params.get('force_generic_extractor', False)) File "/usr/lib/python3.6/site-packages/youtube_dl/YoutubeDL.py", line 760, in extract_info ie_result = ie.extract(url) File "/usr/lib/python3.6/site-packages/youtube_dl/extractor/common.py", line 433, in extract ie_result = self._real_extract(url) File "/usr/lib/python3.6/site-packages/youtube_dl/extractor/vrv.py", line 132, in _real_extract fatal=False) File "/usr/lib/python3.6/site-packages/youtube_dl/extractor/common.py", line 1736, in _extract_mpd_formats compat_etree_fromstring(mpd.encode('utf-8')), mpd_id, mpd_base_url, File "/usr/lib/python3.6/site-packages/youtube_dl/compat.py", line 2497, in compat_etree_fromstring return etree.XML(text, parser=etree.XMLParser(target=_TreeBuilder())) File "/usr/lib/python3.6/xml/etree/ElementTree.py", line 1314, in XML parser.feed(text) xml.etree.ElementTree.ParseError: not well-formed (invalid token): line 19, column 325 ```
geo-restricted,cant-reproduce
low
Critical
233,378,131
youtube-dl
Add Support for weyyak.z5.com
Hello I need to add support for this new website to download form it http://weyyak.z5.com/player/1349010,episode Because when I try to download from it I see this error http://s9.postimg.org/xp6tx73jz/screenshot_27.png Thanks.
site-support-request
low
Critical
233,394,362
go
cmd/link: debugging fails with -linkmode external on macOS
lldb HEAD works with linkmode internal on macOS Sierra: ``` $ go build -gcflags "-N -l" -x test.go WORK=/var/folders/ry/v14gg02d0y9cb2w9809hf6ch0000gn/T/go-build450234285 mkdir -p $WORK/command-line-arguments/_obj/ mkdir -p $WORK/command-line-arguments/_obj/exe/ cd /Users/filippo/code/misc/rustgo /usr/local/Cellar/go/1.8.1_1/libexec/pkg/tool/darwin_amd64/compile -o $WORK/command-line-arguments.a -trimpath $WORK -N -l -p main -complete -buildid 671e0e95e61f5bf7c157a090a3801fe9766c1a0a -D _/Users/filippo/code/misc/rustgo -I $WORK -pack ./test.go cd . /usr/local/Cellar/go/1.8.1_1/libexec/pkg/tool/darwin_amd64/link -o $WORK/command-line-arguments/_obj/exe/a.out -L $WORK -extld=clang -buildmode=exe -buildid=671e0e95e61f5bf7c157a090a3801fe9766c1a0a $WORK/command-line-arguments.a mv $WORK/command-line-arguments/_obj/exe/a.out test $ sudo /usr/local/opt/llvm/bin/lldb test (lldb) target create "test" Current executable set to 'test' (x86_64). (lldb) b main.main Breakpoint 1: where = test`main.main at test.go:5, address = 0x000000000104bf20 (lldb) run Process 5724 launched: '/Users/filippo/code/misc/rustgo/test' (x86_64) Process 5724 stopped * thread #6, stop reason = breakpoint 1.1 frame #0: 0x000000000104bf20 test`main.main at test.go:5 2 3 package main 4 -> 5 func main() { 6 println("foo") 7 } ``` But fails with linkmode external: ``` $ go build -gcflags "-N -l" -ldflags "-linkmode external" -x test.go WORK=/var/folders/ry/v14gg02d0y9cb2w9809hf6ch0000gn/T/go-build843720462 mkdir -p $WORK/command-line-arguments/_obj/ mkdir -p $WORK/command-line-arguments/_obj/exe/ cd /Users/filippo/code/misc/rustgo /usr/local/Cellar/go/1.8.1_1/libexec/pkg/tool/darwin_amd64/compile -o $WORK/command-line-arguments.a -trimpath $WORK -N -l -p main -complete -buildid 09e299344f906f0b167907ec8bcdd857d3794aa0 -D _/Users/filippo/code/misc/rustgo -I $WORK -pack ./test.go cd . /usr/local/Cellar/go/1.8.1_1/libexec/pkg/tool/darwin_amd64/link -o $WORK/command-line-arguments/_obj/exe/a.out -L $WORK -extld=clang -buildmode=exe -buildid=09e299344f906f0b167907ec8bcdd857d3794aa0 -linkmode external $WORK/command-line-arguments.a mv $WORK/command-line-arguments/_obj/exe/a.out test $ sudo /usr/local/opt/llvm/bin/lldb test (lldb) target create "test" Current executable set to 'test' (x86_64). (lldb) b main.main Breakpoint 1: where = test`main.main, address = 0x000000000404d060 (lldb) run Process 5854 launched: '/Users/filippo/code/misc/rustgo/test' (x86_64) foo Process 5854 exited with status = 0 (0x00000000) ``` This appears to be a regression to #8973
help wanted,OS-Darwin,NeedsInvestigation,Debugging,compiler/runtime
low
Critical
233,399,933
neovim
Error detected while processing function <SNR>107_PollServerReady[
nvim version: ``` NVIM v0.2.0 Build type: Release Compilation: /usr/bin/cc -march=x86-64 -mtune=generic -O2 -pipe -fstack-protector-strong -Wconversion -DNVIM_MSGPACK_HAS_FLOAT32 -O2 -DNDEBUG -DDISABLE_LOG -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wvla -fstack-protector-strong -fdiagnostics-color=auto -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -I/build/neovim/src/build/config -I/build/neovim/src/neovim-0.2.0/src -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/usr/include -I/build/neovim/src/build/src/nvim/auto -I/build/neovim/src/build/include ``` Vim (version: ) behaves differently? I don't use Vim. Operating system/version: Arch Linux Terminal name/version: xterm-256color When I am editing bash scripts and exits the script, the following error occurs: ``` Error detected while processing function <SNR>107_PollServerReady[1]..<SNR>107_Pyeval[2]..provider#python3#Call: line 18: Invalid channel: 1 Error detected while processing function <SNR>107_PollFileParseResponse[1]..<SNR>107_Pyeval[2]..provider#python3#Call: line 18: Invalid channel: 1 ``` List of plugins: ``` Finished. 0 error(s). [===================] - phpcomplete.vim: OK - vim_pygments_colorscheme: OK - YouCompleteMe: OK - vim-snippets: OK - Zenburn: OK - github-theme: OK - vim-aldmeris: OK - vim-phpfmt: OK - pw: OK - nerdtree: OK - vim-colors-codeschool: OK - vim-bufkill: OK - ultisnips: OK - supertab: OK - tcomment_vim: OK - vim-go: OK - syntastic: OK - vim-signature: OK - vim-airline: OK ```
provider,channels-rpc
low
Critical
233,414,252
youtube-dl
Site support: Blender Cloud
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.05.29*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.05.29** ### Before submitting an *issue* make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your *issue*? - [x] Site support request (request for adding support for a new site) --- ### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` > youtube-dl -v https://cloud.blender.org/p/game-asset-creation/ [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['-v', 'https://cloud.blender.org/p/game-asset-creation/'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2017.05.29 [debug] Python version 3.5.3 - Linux-4.10.0-21-generic-x86_64-with-Ubuntu-17.04-zesty [debug] exe versions: none [debug] Proxy map: {} [generic] game-asset-creation: Requesting header WARNING: Falling back on generic information extractor. [generic] game-asset-creation: Downloading webpage [generic] game-asset-creation: Extracting information [download] Downloading playlist: None [generic] playlist None: Collected 1 video ids (downloading 1 of them) [download] Downloading video 1 of 1 [debug] Invoking downloader on 'https://storage.googleapis.com/56041550044a2a00d0d7e063/_/f53b6d69cc675ef97ab96fab6fefa357da130fea.mp4?GoogleAccessId=956532172770-27ie9eb8e4u326l89p7b113gcb04cdgd@developer.gserviceaccount.com&Expires=1496618989&Signature=sXGE22BsVMaGJEYH4M15yzXS5LhpzCvCnIMpuqSTPztd7lpFLgBJ/AaJ94vv2xVPAugsGGIwSD25hJyq5kOsnmRVFh4QuYjT26eohlxIdaiAtlKi6grbCBESxK48us6o8WgvyG6VP5iAZfdcmlaj0hapKbnJMfbJqT+douqjPry/2AYmsi+VOICkA9jyxqOEXnTkzZqCA+WDYarq5OZdwz0xNCdSWZPMGktb/7mrtZL/7Y+dGPIj2l8xjDiqbhBWVW5sXAix+SgOucODWscRoDHQZDz3qoSmHKA+BQwGsZc/Z7Wqlau0IhKxX63rWpBEi/da/Bqw0ZxGSYF6gRcJ7Q==' ERROR: unable to download video data: HTTP Error 403: Forbidden Traceback (most recent call last): File "/home/user/.local/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 1803, in process_info success = dl(filename, info_dict) File "/home/user/.local/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 1745, in dl return fd.download(name, info) File "/home/user/.local/lib/python3.5/site-packages/youtube_dl/downloader/common.py", line 360, in download return self.real_download(filename, info_dict) File "/home/user/.local/lib/python3.5/site-packages/youtube_dl/downloader/http.py", line 61, in real_download data = self.ydl.urlopen(request) File "/home/user/.local/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 2106, in urlopen return self._opener.open(req, timeout=self._socket_timeout) File "/usr/lib/python3.5/urllib/request.py", line 472, in open response = meth(req, response) File "/usr/lib/python3.5/urllib/request.py", line 582, in http_response 'http', request, response, code, msg, hdrs) File "/usr/lib/python3.5/urllib/request.py", line 510, in error return self._call_chain(*args) File "/usr/lib/python3.5/urllib/request.py", line 444, in _call_chain result = func(*args) File "/usr/lib/python3.5/urllib/request.py", line 590, in http_error_default raise HTTPError(req.full_url, code, msg, hdrs, fp) urllib.error.HTTPError: HTTP Error 403: Forbidden ``` ``` > youtube-dl -v https://cloud.blender.org/p/game-asset-creation/56041550044a2a00d0d7e068 [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['-v', 'https://cloud.blender.org/p/game-asset-creation/56041550044a2a00d0d7e068'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2017.05.29 [debug] Python version 3.5.3 - Linux-4.10.0-21-generic-x86_64-with-Ubuntu-17.04-zesty [debug] exe versions: none [debug] Proxy map: {} [generic] 56041550044a2a00d0d7e068: Requesting header WARNING: Falling back on generic information extractor. [generic] 56041550044a2a00d0d7e068: Downloading webpage [generic] 56041550044a2a00d0d7e068: Extracting information ERROR: Unsupported URL: https://cloud.blender.org/p/game-asset-creation/56041550044a2a00d0d7e068 Traceback (most recent call last): File "/home/user/.local/lib/python3.5/site-packages/youtube_dl/YoutubeDL.py", line 760, in extract_info ie_result = ie.extract(url) File "/home/user/.local/lib/python3.5/site-packages/youtube_dl/extractor/common.py", line 433, in extract ie_result = self._real_extract(url) File "/home/user/.local/lib/python3.5/site-packages/youtube_dl/extractor/generic.py", line 2795, in _real_extract raise UnsupportedError(url) youtube_dl.utils.UnsupportedError: Unsupported URL: https://cloud.blender.org/p/game-asset-creation/56041550044a2a00d0d7e068 ``` --- ### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single video: https://cloud.blender.org/p/game-asset-creation/56041550044a2a00d0d7e068 - Single video: https://cloud.blender.org/p/game-asset-creation/56041550044a2a00d0d7e06a - Playlist: https://cloud.blender.org/p/game-asset-creation/ - Playlist (subsection): https://cloud.blender.org/p/game-asset-creation/56041550044a2a00d0d7e069 --- ### Description of your *issue*, suggested solution and other information Some playlists and some videos in public playlists would require signing in with a BlenderID, see https://store.blender.org/product/membership/ for details.
site-support-request,account-needed
low
Critical
233,427,403
neovim
Use language daemons for language providers
It is not unknown that `:python` and other languages startup is being slow now due to having to check and start external programs. E.g. with `init.vim` as simple as ```VimL " let g:powerline_old_vim = 1 set laststatus=2 python import vim python from powerline.vim import setup as powerline_setup python powerline_setup(gvars=globals()) python del powerline_setup set guicursor= ``` (using `editors-refactor` branch of powerline, powerline/powerline#1507) Vim takes 54 ms to source that, Neovim takes 325 ms, all with system FS caches up, worse without. The problem is that each Neovim has to start Python by itself. I have a suggestion thus: instead of having architecture with which one Neovim has one Python which it directly communicates with add a “language daemon”. The idea is that “language daemon” starts once and creates a socket in a set location used to communicate with Neovim, when Neovim needs `:python` it starts a daemon if it was not already started (decreased performance, but only at startup, and “starting a daemon” may be a per-user systemd service), then on `:python` it just tells daemon that Neovim client with ID X (Neovim socket, but generally just any unique ID) needs to run `:python` command Y. If such ID is unknown to a language server then it spawns a new Python child process and relay requested command there, if it is known it either relays requested command or gives some details regarding the fate of the child (better error reporting if Python crashed). Additionally if relaying does not work well in term of performance it should be possible to use language server to communicate direct interaction, then in “channel is broken” cases it should also be possible to get some details from the language server. The main ideas here are 1. `fork()` is much cheaper then `fork()+exec()`. 2. Need not run checks regarding the availability and version of `neovim` packages more then once. Main problems: 1. To update `neovim` package one will need to restart daemon. 2. Handling virtualenvs is going to be complicated. 3. Actually Neovim can’t just “request daemon to run command Y”, need to transfer environment variables at first command. Both problems may be solved by another complication: make daemon a daemon manager: daemon manager is communicating with Neovim like daemon in the suggestion, but instead it spawns daemons (key used to determine whether new daemon is needed: periodically checked `neovim` package version plus significant environment variables like where virtualenv is defined, or path to Python executable (`$PATH`, but only if it really changes executable file location), or Python package location (`$PYTHONPATH`); insignificant may just be changed on language process startup) using `fork()+exec()` (i.e. `subprocess`), daemons themselves only `fork()` to provide language processes. Note that while my suggestion may bring down startup times significantly and provide better error reporting, this complicates code a lot and there are different solutions possible for error reporting in case of crashed language process.
needs:design
low
Critical
233,435,155
godot
[TRACKER] Making terrains
I found a number of issues about making terrains in Godot, be it heightmap, voxels, an engine module or a plugin, so I thought I would make a tracker to list them all: Engine limitations: (some might be "closed as fixed" but are still actually open in a different issue, or have been closed in favor of another issue that doesnt exactly match the problem; need to take the time to update this list) - [x] #9544 : need to be able to set custom bounding box per mesh instances, to unlock the ability to do shader-displaced heightmaps and reuse mesh configurations ; the lack of this feature produces culling glitches - [x] #9571 : need to be able to update a texture partially. Editing huge textures on the CPU makes terrain editing unbearable on huge sizes (although GPU painting can be investigated to some extent). - [ ] #7786 : needs ability to do custom LoD that works in multiple viewports (currently limited to _process on a single viewport), so that the renderer doesn't chugs on culling and drawing the whole landscape, especially on split-screen games. Custom, because LOD on a terrain is often different from LOD on a single model, mainly due to the constraint of keeping the terrain watertight with seams, and that quadtrees may be used instead of chunks of the same size. - [x] #8994, #5624 : scenes and resources saved even without changes, with a terrain it can freeze the editor for seconds and become very annoying. I disabled Ctrl+S saving the scene for that reason. - [x] #6869 : LoD must update differently in editor because camera is not easily available. Current workaround is to use the camera provided in `_forward_spatial_input`. #6869 was mentionned to solve this but it actually doesn't change the situation, so I'm still using the same workaround to make it work. - [x] HeightmapShape would be nice for efficient collisions, because mesh colliders are resource-hungry (althought they work decently if limited to a small region) --> would be solved by the HeightmapShape coming in the Bullet PR #10013 - [ ] needs custom streamed resource so that a terrain doesn't have to be fully loaded in memory (only required lods around player), speeding loading times (the engine probably supports it already though, for sound). Custom loaders or custom resources will help to solve this. - [ ] [tbd] : Editor: add an undo history memory limit, or use file caching, because terrain edition generates a lot of undo memory in general. It can be worked around by storing "handle objects" or IDs in the undo methods instead of the data directly, which map to data inside temporary archive files, effectively storing the action's data on disk rather than memory. But it has to be implemented for every feature. - [x] #9008 : needs texture arrays / 3D texture support in shaders, for efficient texture painting / terrain shaders. @karroffel worked on that for 3.1. - [x] #10255 : need 2D blending mode(s) that treat alpha like a regular channel, so it can be used for more general purpose, such as GPU painting of splatmaps or other 4-channel data maps terrains can use. (which is way faster than doing it in C++ on the CPU) - [ ] tbd: need more control over offscreen rendering, mainly custom image formats when making viewports and ability to make them render on demand (#16828), so they can be used more efficiently for GPU-accelerated terrain edition (example: erosion needs to use directional blur over multiple passes, for which you currently have to wait for every frame instead of telling the renderer to do them all at once). Using current viewport forces usage of nodes, waiting frames, and using RGBA16, which eats a lot of memory and bandwidth in some cases, or terribly lack of precision in other cases. Using texture channels differently is an alternative, however it complexifies code a bit, and forces copying the entire shaders just to change a few lines of lookup because Godot doesn't have #17303 - [ ] #17683 : improve resource usage when drawing big textures for the first time, as saving a terrain writes them all to the project, which causes re-import AND reconversion on draw, which can cause computer to freeze. - [ ] tbd: integrate with navmesh generation. Currently navmeshes are generated using meshes, but a heightmap using a quad tree or streaming for LOD will never have them all present at full precision. My plugin recently made its generated collider available in the editor, but the navmesh generator is not using it, and probably can't because it's still a grid instead of a mesh. - [ ] tbd: integrate with lightmap baking. Currently Godot only takes static meshes into account but a large heightmap using a quad tree or streaming for LOD will never have them all present at full precision, and they are displaced in shaders anyways. This one could be very hard to solve without either deeply integrate the terrain, rewriting a plugin lightmap baker from scratch, or change the baker so that it uses a GPU technique taking unshaded rendering result into account (but streaming would still come in the way). User requests: - #3616, #8124, #8254, #4304 In several occurences my GDScript plugin was mentionned. I once switched it to C++, then back to GDScript because it seemed to work well enough and it allowed people to use it more easily. Unfortunately it still is a bit slow in some areas, and mostly suffers from not being easy to integrate with the engine. A 3D terrain is quite a beast to have in game engines because very often (if not always), other components of the engine might need to interact with the terrain in many different ways. Issue tracker on my terrain plugin: https://github.com/Zylann/godot_heightmap_native_plugin/issues Won't do for now **but to consider for Vulkan**: - ~~#9134 : needs 2 additional Vector4 vertex attributes for texturing (weights and indices), in order to exploit texture arrays. The current workaround is to use UV2, COLOR or BONE WEIGHT attributes, but it limits available attributes a lot.~~ - ~~[tbd] : indirect drawing of meshes (glDrawIndirect on renderer side, also supported in GLES3) to draw multiple subsets of mesh arrays so that we can swap LoDs really fast and reduce the amount of draw calls for all chunks of the terrain. _This also gives the opportunity to bake chunks for good, to a point they don't need any remeshing as lods update_ (current method has an exploding number of remeshing)~~ (not in GLES3 core... https://www.khronos.org/registry/OpenGL-Refpages/gl4/html/glDrawElementsIndirect.xhtml) - #10817 Tessellation shaders, so that we reduce mesh data while being able to dynamically increase resolution to smooth near ground
bug,enhancement,topic:editor,topic:plugin,tracker,topic:3d
high
Major
233,440,684
rust
Cannot infer type even if specified.
So, I got the `type annotations needed` error. I tried *everything*. It refuses to work. ```Rust let tmp: Result<NamedTempFile, ()> = NamedTempFile::new().map_err::<(), _>(|_: std::io::Error| ()); let mut tmp: NamedTempFile = tmp?; ``` Error ![image](https://cloud.githubusercontent.com/assets/12830969/26763008/c0fe1b0c-494b-11e7-83ab-9060e032f8f6.png) (please don't tell me the code is stupid. I have a valid reason to ignore the error) If this is my fault, and not an issue with Rust, apologies for spamming you with yet another false issue :( I feel horrible
C-enhancement,A-diagnostics,T-compiler,A-inference,A-suggestion-diagnostics,requires-nightly,F-try_blocks
low
Critical
233,457,843
youtube-dl
Problem on download from Shahid Plus because of captcha
Hello Shahid.net site changed the way on login they add captcha code to login screen so when I use the script to download any movie with plus account and provide my login data I see this error message http://s9.postimg.org/ocy9mwp1b/screenshot_30.png in English its mean The code you entered did not match the verification code. Please try again and this is login screen http://s9.postimg.org/3u3dhub3z/screenshot_31.png please dose there any way to solve this problem???
account-needed
low
Critical
233,483,299
go
x/net/http2/hpack: Write customer-header into HPACK byName Map rather than byNameValue
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? go1.8 ### What operating system and processor architecture are you using (`go env`)? ``` GOARCH="amd64" GOBIN="" GOEXE="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Applications/workspace/code/MWCS" GORACE="" GOROOT="/usr/local/go" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GCCGO="gccgo" CC="clang" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/8r/y0x9w5g51k91thk9tk0xzgsc0000gn/T/go-build587864376=/tmp/go-build -gno-record-gcc-switches -fno-common" CXX="clang++" CGO_ENABLED="1" PKG_CONFIG="pkg-config" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" ``` ### What did you do? we use http2 as gateway platform protocol and extension header like `mw-xxx` to do some gateway sub-protocl as request and response. as some resposne header, "mw-server-time" or "mw-rt", which has static name and dynamic value per request ,accordding to HPACK,these entry will add dynamic table like below ``` t.byName[f.Name] = id t.byNameValue[pairNameValue{f.Name, f.Value}] = id ``` and which take 23% alloc_objects and much map hash grow in pprof ### What did you expect to see? we want only use byName map to index name rather than indexing name-value and never indexing seperate addEntry such as blew ``` func (t *headerFieldTable) addEntryByName(f HeaderField) { id := uint64(t.len()) + t.evictCount + 1 t.byName[f.Name] = id t.ents = append(t.ents, f) } func (t *headerFieldTable) addEntryByNameVlaue(f HeaderField) { id := uint64(t.len()) + t.evictCount + 1 t.byNameValue[pairNameValue{f.Name, f.Value}] = id t.ents = append(t.ents, f) } ``` and also `table.search`
NeedsInvestigation,FeatureRequest
low
Critical
233,663,203
TypeScript
Incorrect indent with template literal
_From @unional on June 4, 2017 8:51_ - VSCode Version: 1.12.2 - OS Version: OSX ```ts test(` `, _t => { console.log('wrong indent') }) // should be test(` `, _t => { console.log('wrong indent') }) ``` ![image](https://cloud.githubusercontent.com/assets/3254987/26760236/18fe1426-48c8-11e7-95e9-b3cef892851e.png) _Copied from original issue: Microsoft/vscode#27998_
Bug,Help Wanted,Domain: Formatter,VS Code Tracked
low
Minor
233,714,406
youtube-dl
support for jukedeck.com
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x]) - Use *Preview* tab to see how your issue will actually look like --- ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.06.05*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x] I've **verified** and **I assure** that I'm running youtube-dl **2017.06.05** ### Before submitting an *issue* make sure you have: - [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your *issue*? - [ ] Bug report (encountered problems with youtube-dl) - [x] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- ### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue* --- ### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows: Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```): ``` [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['https://www.jukedeck.com/share/d1a8cffe47b081ff2b2a 1e673fc1e4b45879ef9275c9725c6a3f935e7e768749', '-v'] [debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252 [debug] youtube-dl version 2017.06.05 [debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1 [debug] exe versions: ffmpeg N-62645-ge79b15f, ffprobe N-62645-ge79b15f [debug] Proxy map: {} [generic] d1a8cffe47b081ff2b2a1e673fc1e4b45879ef9275c9725c6a3f935e7e768749: Requ esting header WARNING: Falling back on generic information extractor. [generic] d1a8cffe47b081ff2b2a1e673fc1e4b45879ef9275c9725c6a3f935e7e768749: Down loading webpage [generic] d1a8cffe47b081ff2b2a1e673fc1e4b45879ef9275c9725c6a3f935e7e768749: Extr acting information ERROR: Unsupported URL: https://www.jukedeck.com/share/d1a8cffe47b081ff2b2a1e673 fc1e4b45879ef9275c9725c6a3f935e7e768749 Traceback (most recent call last): File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp6q2mjw76\bu ild\youtube_dl\YoutubeDL.py", line 761, in extract_info File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp6q2mjw76\bu ild\youtube_dl\extractor\common.py", line 433, in extract File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\rg3\tmp6q2mjw76\bu ild\youtube_dl\extractor\generic.py", line 2795, in _real_extract youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.jukedeck.com/sha re/d1a8cffe47b081ff2b2a1e673fc1e4b45879ef9275c9725c6a3f935e7e768749 ... <end of log> ``` --- ### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**): - Single audio: https://www.jukedeck.com/make/tracks/share/590dda2ccb12b11068759696 - Single video: https://www.jukedeck.com/make/library/track-info/590dda2ccb12b11068759696 Note that **youtube-dl does not support sites dedicated to [copyright infringement](https://github.com/rg3/youtube-dl#can-you-add-support-for-this-anime-video-site-or-site-which-shows-current-movies-for-free)**. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
site-support-request
low
Critical
233,719,666
three.js
Raycaster: Floating point tolerance
##### Description of the problem When casting a ray with Raycaster, it happens under some conditions in my test example that the caster fails to detect the object on top of it. In the test example, when casting UP from one (or multiple) vertices of the rectangular block top, it does not detect the sphere above. When varying the "influence" parameter, one can see the points that failed to being detected, as they are not morphed to match the sphere shape. The error can be reproduced if the sphere is 70 unit of radius. However, if the radius is set to 100 units, then there are no errors. ```js var sphereGeo = new THREE.SphereGeometry(70); // if 100, no issue ``` Also, if the tessalation of the block is changed, by dividing the edges by 10 points per edge instead of 15, then the issue appears twice! ```js var geometry = new THREE.BoxGeometry(200, 100, 200, 15, 1, 15); // Change to 10, 1, 10 for double trouble! ``` ##### Three.js version - [x] r85 ##### Browser - [x] Chrome ##### OS - [x] Windows 10 ##### Hardware Requirements (graphics card, VR Device, ...) None observed. [CODE] <body> <div id="container"></div> <div id="info"> <a href="http://threejs.org" target="_blank">three.js</a> - Morph by Raycasting </div> <script src="three.js"></script> <script src="OrbitControls.js"></script> <script src="Detector.js"></script> <script src="dat.gui.min.js"></script> <script> if (!Detector.webgl) Detector.addGetWebGLMessage(); var container; var camera, scene, renderer; var mesh; var morphMesh; var sphere; init(); animate(); function init() { container = document.getElementById('container'); camera = new THREE.PerspectiveCamera(45, window.innerWidth / window.innerHeight, 1, 15000); camera.position.z = 500; scene = new THREE.Scene(); var light = new THREE.PointLight(0xff2200); light.position.set(100, 100, 100); scene.add(light); var light = new THREE.AmbientLight(0x111111); scene.add(light); // var geometry = new THREE.BoxGeometry(200, 100, 200, 15, 1, 15); var material = new THREE.MeshLambertMaterial({ color: 0xffffff, morphTargets: true , wireframe: true}); var sphereGeo = new THREE.SphereGeometry(70); var sphereMat = new THREE.MeshPhongMaterial({ color: 0xff00ff, morphTargets: false }); var morphGeo = geometry.clone(); var morphMat = new THREE.MeshLambertMaterial({ color: 0xff00ff, morphTargets: false}); { var vertices = []; for (var v = 0; v < morphGeo.vertices.length; v++) { vertices.push(morphGeo.vertices[v]); } geometry.morphTargets.push({ name: "sphere", vertices: vertices }); } mesh = new THREE.Mesh(geometry, material); morphMesh = new THREE.Mesh(morphGeo, morphMat); sphere = new THREE.Mesh(sphereGeo, sphereMat); sphere.geometry.translate(0, 200, 0); mesh.geometry.morphTargets.push({name: "morphed", vertices: morphMesh.geometry.vertices}); scene.add(mesh); scene.add(sphere); // findIntersection(mesh.geometry, sphere); // var params = { influence1: 0, }; var gui = new dat.GUI(); var folder = gui.addFolder('Morph Targets'); folder.add(params, 'influence1', 0, 1).step(0.01).onChange(function (value) { mesh.morphTargetInfluences[0] = value; }); folder.open(); // renderer = new THREE.WebGLRenderer(); renderer.setClearColor(0x222222); renderer.setPixelRatio(window.devicePixelRatio); renderer.setSize(window.innerWidth, window.innerHeight); renderer.sortObjects = false; container.appendChild(renderer.domElement); // controls = new THREE.OrbitControls(camera, renderer.domElement); // window.addEventListener('resize', onWindowResize, false); } function findIntersection(baseGeo, targetMesh) { var rayCaster = new THREE.Raycaster(); var UP = new THREE.Vector3(0, 1, 0); var counter = 0; for (var v = 0; v < baseGeo.vertices.length; v++) { var vertex = baseGeo.vertices[v]; // Reduce computation by only looking for top vertices if (vertex.y > 0) { rayCaster.set(vertex, UP); var intersects = rayCaster.intersectObject(targetMesh); if (intersects.length > 0) { // Distance is hardcoded, but delta could be calculated // relative to a target bounding box var delta = 150 - intersects[0].distance; morphMesh.geometry.vertices[v].y -= delta; } } } } function onWindowResize() { camera.aspect = window.innerWidth / window.innerHeight; camera.updateProjectionMatrix(); renderer.setSize(window.innerWidth, window.innerHeight); } function animate() { requestAnimationFrame(animate); render(); } function render() { renderer.render(scene, camera); } </script> </body> </html>
Bug
low
Critical
233,767,612
vscode
[decorations] Support hover decorations over the line numbers (i.e. gutter)
- VSCode Version: Code - Insiders 1.13.0-insider (9a107453944f25e6019b08615e20d63545584855, 2017-06-05T18:21:57.187Z) - OS Version: Windows_NT ia32 10.0.16199 --- It would be great to be able to provide hover decorations to just the gutter -- this is something I would jump on immediately for GitLens :)
feature-request,api
medium
Critical
233,781,637
youtube-dl
Problems with Disney: Fails to get series info (1 of 2)
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x]) - Use *Preview* tab to see how your issue will actually look like --- ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.06.05*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [x ] I've **verified** and **I assure** that I'm running youtube-dl **2017.06.05** ### Before submitting an *issue* make sure you have: - [ x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [ x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your *issue*? - x ] Bug report (encountered problems with youtube-dl) - [ x] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- Trying to fetch episodes from Disney XD works just fine; passing http://watchdisneyxd.go.com/star-vs-the-forces-of-evil results in identifying the individual episodes, and correctly identifies series, season, and episode. But trying to fetch from Disney Channel fails. Giving a specific episode does not retrieve series, season, or episode number ``` keybounceMBP:Disney michael$ keybounceMBP:Disney michael$ ./yt-dl -v --get-filename http://video.disney.com/watch/disneychannel-what-the-ha ir-54c786cedea9193243001d54 [debug] System config: [] [debug] User config: ['-k', '-o', '%(title)s-%(timestamp)6i.%(ext)s', '-f', '\nbest[ext=mp4][height>431][height<=576]/\nbestvideo[ext=mp4][height=480]+bestaudio[ext=m4a]/\nbest[ext=mp4][height>340][height<=431]/\nbestvideo[ext=mp4][height>360][height<=576]+bestaudio/\nbest[height>340][height<=576]/\nbestvideo[height>360][height<=576]+bestaudio/\nbestvideo[height=360]+bestaudio/\nbest[ext=mp4][height>=280][height<=360]/\nbest[height<=576]/\nworst', '--ap-mso', 'Dish', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--write-sub', '--write-auto-sub', '--sub-lang', 'en,enUS,en-us', '--sub-format', 'ass/srt/best', '--convert-subs', 'ass', '--embed-subs', '--recode-video', 'mp4', '--mark-watched', '--download-archive', 'downloaded-videos.txt'] [debug] Custom config: [] [debug] Command-line args: ['-o', '%(series)s/s%(season_number)02d-e%(episode_number)02d-%(title)s.%(ext)s', '-v', '--get-filename', 'http://video.disney.com/watch/disneychannel-what-the-hair-54c786cedea9193243001d54'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2017.06.05 [debug] Python version 3.6.1 - Darwin-13.4.0-x86_64-i386-64bit [debug] exe versions: ffmpeg 3.2.4, ffprobe 3.2.4, rtmpdump 2.4 [debug] Proxy map: {} WARNING: enUS subtitles not available for 54c786cedea9193243001d54 WARNING: en-us subtitles not available for 54c786cedea9193243001d54 NA/sNA-eNA-What the Hair!.mp4 keybounceMBP:Disney michael$ ```
geo-restricted,tv-provider-account-needed
low
Critical
233,781,883
youtube-dl
Problems with Disney: Fails to handle playlists (2 of 2)
## Please follow the guide below - You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly - Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x]) - Use *Preview* tab to see how your issue will actually look like --- ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2017.06.05*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected. - [ x] I've **verified** and **I assure** that I'm running youtube-dl **2017.06.05** ### Before submitting an *issue* make sure you have: - [ x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections - [ x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones ### What is the purpose of your *issue*? - [x ] Bug report (encountered problems with youtube-dl) - [ x] Site support request (request for adding support for a new site) - [ ] Feature request (request for a new functionality) - [ ] Question - [ ] Other --- Fetching a series from Disney XD works. Fetching a series from Disney channel does not. ``` keybounceMBP:Disney michael$ ./yt-dl -v --get-filename http://disneychannel.disney.com/tangled [debug] System config: [] [debug] User config: ['-k', '-o', '%(title)s-%(timestamp)6i.%(ext)s', '-f', '\nbest[ext=mp4][height>431][height<=576]/\nbestvideo[ext=mp4][height=480]+bestaudio[ext=m4a]/\nbest[ext=mp4][height>340][height<=431]/\nbestvideo[ext=mp4][height>360][height<=576]+bestaudio/\nbest[height>340][height<=576]/\nbestvideo[height>360][height<=576]+bestaudio/\nbestvideo[height=360]+bestaudio/\nbest[ext=mp4][height>=280][height<=360]/\nbest[height<=576]/\nworst', '--ap-mso', 'Dish', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '--write-sub', '--write-auto-sub', '--sub-lang', 'en,enUS,en-us', '--sub-format', 'ass/srt/best', '--convert-subs', 'ass', '--embed-subs', '--recode-video', 'mp4', '--mark-watched', '--download-archive', 'downloaded-videos.txt'] [debug] Custom config: [] [debug] Command-line args: ['-o', '%(series)s/s%(season_number)02d-e%(episode_number)02d-%(title)s.%(ext)s', '-v', '--get-filename', 'http://disneychannel.disney.com/tangled'] [debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2017.06.05 [debug] Python version 3.6.1 - Darwin-13.4.0-x86_64-i386-64bit [debug] exe versions: ffmpeg 3.2.4, ffprobe 3.2.4, rtmpdump 2.4 [debug] Proxy map: {} ERROR: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. Traceback (most recent call last): File "/Users/michael/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 761, in extract_info ie_result = ie.extract(url) File "/Users/michael/bin/youtube-dl/youtube_dl/extractor/common.py", line 433, in extract ie_result = self._real_extract(url) File "/Users/michael/bin/youtube-dl/youtube_dl/extractor/disney.py", line 135, in _real_extract self._sort_formats(formats) File "/Users/michael/bin/youtube-dl/youtube_dl/extractor/common.py", line 1056, in _sort_formats raise ExtractorError('No video formats found') youtube_dl.utils.ExtractorError: No video formats found; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output. ```
geo-restricted
low
Critical
233,808,048
rust
Strange lifetime error when using borrow_mut
```rust use std::borrow::BorrowMut; trait A {} struct B; impl A for B {} fn func(a: &mut A) {} fn main() { let t: Box<A> = Box::new(B); { let b = t.borrow_mut(); func(b); } } ``` When compiling above code, it fails with: ``` error: `t` does not live long enough --> <anon>:17:1 | 14 | let b = t.borrow_mut(); | - borrow occurs here ... 17 | } | ^ `t` dropped here while still borrowed | = note: values in a scope are dropped in the opposite order they are created ``` I think the borrow state should end at L16.
A-lifetimes,T-lang,C-bug
low
Critical
233,836,344
go
runtime: program with deadlock doesn't fail if use -race flag
Go version: 1.8.3 OS: Mac Program: ```go package main func main() { ch1 := make(chan int) <-ch1 } ``` if run with `go run deadlock.go` see: `fatal error: all goroutines are asleep - deadlock!` if run with `go run -race deadlock.go` program never finish Is it expected behavior? Does it make sense to improve deadlock detector to be aware about race detector?
RaceDetector,NeedsInvestigation,compiler/runtime
low
Critical
233,851,320
pytorch
Expose optimizer options as attributes when there's a single param group
For example, I hope I can accesses its `lr`! But I read the source code, it just process the `default`, it does not assign them to the opposite data members. cc @vincentqb
module: bootcamp,module: optimizer,triaged,enhancement
low
Minor
233,856,060
rust
1.17.0 powerpc64le: "LLVM ERROR: Undefined temporary symbol" after disabling optimisation
Build log: https://buildd.debian.org/status/fetch.php?pkg=rustc&arch=ppc64el&ver=1.17.0%2Bdfsg2-1&stamp=1495038619&raw=0 - but it also happens when I try to cross-compile from amd64 to ppc64el. ~~~~ Compiling rustc v0.0.0 (file:///<<BUILDDIR>>/rustc-1.17.0+dfsg2/src/librustc) Running `/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/bootstrap/debug/rustc --crate-name rustc src/librustc/lib.rs --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C debug-assertions=off -C metadata=2dbabbd65e8c1fb6 -C extra-filename=-2dbabbd65e8c1fb6 --out-dir '/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps' --target powerpc64le-unknown-linux-gnu -L 'dependency=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps' -L 'dependency=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/debug/deps' --extern 'fmt_macros=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libfmt_macros-0ae3a1110c5d6a59.so' --extern 'graphviz=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libgraphviz-69f251278e17c653.so' --extern 'log=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/liblog-2d7ede29ab054d41.so' --extern 'log=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/liblog-2d7ede29ab054d41.rlib' --extern 'syntax=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libsyntax-ee039db76fa2c9bd.so' --extern 'rustc_back=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_back-d3da270de1cf5da2.so' --extern 'rustc_data_structures=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_data_structures-e81620800e45ed83.so' --extern 'syntax_pos=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libsyntax_pos-64299e60f35ddd83.so' --extern 'rustc_errors=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_errors-6033144335693d9c.so' --extern 'arena=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libarena-b26c5a582e48af8e.so' --extern 'serialize=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libserialize-2a05f301b8174a1d.so' --extern 'serialize=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libserialize-2a05f301b8174a1d.rlib' --extern 'rustc_llvm=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_llvm-ad254c719b9de2ea.so' --extern 'rustc_const_math=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_const_math-3ce64b122f5b797c.so' --extern 'rustc_bitflags=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_bitflags-af221885a3a0a71c.rlib' -C link-args=-Wl,-z,relro -L 'native=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/build/rustc_llvm-345e2146446b30f9/out' -L native=/usr/lib/llvm-3.9/lib` LLVM ERROR: Undefined temporary symbol error: Could not compile `rustc`. Caused by: process didn't exit successfully: `/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/bootstrap/debug/rustc --crate-name rustc src/librustc/lib.rs --crate-type dylib --emit=dep-info,link -C prefer-dynamic -C debug-assertions=off -C metadata=2dbabbd65e8c1fb6 -C extra-filename=-2dbabbd65e8c1fb6 --out-dir /<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps --target powerpc64le-unknown-linux-gnu -L dependency=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps -L dependency=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/debug/deps --extern fmt_macros=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libfmt_macros-0ae3a1110c5d6a59.so --extern graphviz=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libgraphviz-69f251278e17c653.so --extern log=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/liblog-2d7ede29ab054d41.so --extern log=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/liblog-2d7ede29ab054d41.rlib --extern syntax=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libsyntax-ee039db76fa2c9bd.so --extern rustc_back=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_back-d3da270de1cf5da2.so --extern rustc_data_structures=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_data_structures-e81620800e45ed83.so --extern syntax_pos=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libsyntax_pos-64299e60f35ddd83.so --extern rustc_errors=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_errors-6033144335693d9c.so --extern arena=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libarena-b26c5a582e48af8e.so --extern serialize=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libserialize-2a05f301b8174a1d.so --extern serialize=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/libserialize-2a05f301b8174a1d.rlib --extern rustc_llvm=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_llvm-ad254c719b9de2ea.so --extern rustc_const_math=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_const_math-3ce64b122f5b797c.so --extern rustc_bitflags=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/deps/librustc_bitflags-af221885a3a0a71c.rlib -C link-args=-Wl,-z,relro -L native=/<<BUILDDIR>>/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0-rustc/powerpc64le-unknown-linux-gnu/debug/build/rustc_llvm-345e2146446b30f9/out -L native=/usr/lib/llvm-3.9/lib` (exit code: 1) command did not execute successfully: "/usr/bin/cargo" "build" "-j" "4" "--target" "powerpc64le-unknown-linux-gnu" "-v" "--frozen" "--features" " jemalloc" "--manifest-path" "/<<BUILDDIR>>/rustc-1.17.0+dfsg2/src/rustc/Cargo.toml" expected success, got: exit code: 101 Build completed unsuccessfully in 0:53:22 ~~~~ The differences between Debian and Rust LLVM are [here](https://gist.github.com/infinity0/873566481db105fea47630da88e1b632) but I couldn't see anything relevant to powerpc64le.
A-LLVM,T-compiler,O-PowerPC,C-bug
low
Critical
233,886,572
flutter
Respect OS's power save mode
Flutter should respect the OS's power save mode. Ideas: - Skip animations - ???
framework,engine,a: animation,c: performance,c: proposal,P2,team-engine,triaged-engine
low
Major
233,902,375
TypeScript
Offers quick suggestion to ignore parse error; but parse error can't be ignored
**TypeScript Version:** nightly (2.4.0-dev.20170606) This is in a JavaScript file with `// @ts-check`. **Code** ![shot](https://cloud.githubusercontent.com/assets/19274678/26832914/c6b438c0-4a85-11e7-9c60-a5ff6e12c932.jpg) **Expected behavior:** Doesn't offer to ignore parse errors. **Actual behavior:** When I'm typing something, there will usually a parse error until I'm done typing it. This means that the lightbulb is flashing on every keypress offering to ignore parse errors. That doesn't work anyway.
Bug,Domain: Quick Fixes
low
Critical
233,957,491
vscode
Activate extension with workspaceContains when a matching file is added to the workspace
If I have `"workspaceContains:**/*.md"` as an activationEvent, it would be useful for it to fire when a matching file is added to the workspace, not just when a workspace with matching file is opened. https://github.com/Microsoft/vscode/issues/27665#issuecomment-306394054
feature-request,api
low
Major
234,051,446
go
mobile/app/shiny.go: Mouse events not being delivered to application
Please answer these questions before submitting your issue. Thanks! ### What version of Go are you using (`go version`)? go1.8.3 windows/amd64 ### What operating system and processor architecture are you using (`go env`)? set GOARCH=amd64 set GOBIN= set GOEXE=.exe set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOOS=windows set GOPATH=C:\Users\user\Dropbox\goProjects;C:\Users\user\Dropbox\golibs set GORACE= set GOROOT=C:\Go set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64 set GCCGO=gccgo set CC=gcc set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\user\AppData\Local\Temp\go-build310428203=/tmp/go-build -gno-record-gcc-switches set CXX=g++ set CGO_ENABLED=1 set PKG_CONFIG=pkg-config set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 ### What did you do? Attempted to write graphics program using mobile/app. Noticed no mouse events were delivered to application, due to code in mobile/app/shiny.go (convertEvent) that creates touch events based on mouse events, and then DISCARDS the mouse events. No mouse events will ever reach the user code, meaning that events like WheelUp and WheelDown are completely unavailable to the application (all the application gets is a generic "touchstart" and "touchend", all the buttons are grouped together) ### What did you expect to see? Mouse events ### What did you see instead? No mouse events, at all ### Fixed code In order to cause minimum disruption to existing code, this following patch passes mouse events to the user, while also keeping the current behaviour of creating touch events. Note that only one line is changed, the rest of the function is just context. mobile/app/shiny.go ``` func convertEvent(e interface{}) interface{} { switch e := e.(type) { case lifecycle.Event: if theApp.glctx == nil { theApp.glctx = e.DrawContext.(gl.Context) } case mouse.Event: te := touch.Event{ X: e.X, Y: e.Y, } switch e.Direction { case mouse.DirNone: te.Type = touch.TypeMove case mouse.DirPress: te.Type = touch.TypeBegin case mouse.DirRelease: te.Type = touch.TypeEnd } theApp.Send(te) } return e } ```
mobile
low
Critical
234,053,140
TypeScript
Use ReadonlyArray<T> in type declarations
We can't really use `ReadonlyArray` anywhere else until we fix the type declarations. This is technically a breaking change, but people shouldn't have been modifying arrays after creation anyway.
Infrastructure
low
Minor
234,083,443
vue
Provided props are not injected into functional components
### Version 2.3.3 ### Reproduction link http://jsfiddle.net/p861bj9y/ ### Steps to reproduce I created a minimal reproduction of the behavior I am trying to test, the example just needs JSX to work. ### What is expected? The properties passed down from parent should show up in `ctx.injections`. ### What is actually happening? `Ctx.injections` exists but remains empty. The properties are not being passed down to the functional component context. <!-- generated by vue-issues. DO NOT REMOVE -->
bug
medium
Major
234,100,247
TypeScript
[Suggestion] Compiler Flag to treat types as immutable
<!-- BUGS: Please use this template. --> <!-- QUESTIONS: This is not a general support forum! Ask Qs at http://stackoverflow.com/questions/tagged/typescript --> <!-- SUGGESTIONS: See https://github.com/Microsoft/TypeScript-wiki/blob/master/Writing-Good-Design-Proposals.md --> **TypeScript Version:** 2.3.4 **Code** I'm aware of #10725, but I want to take it one step further and add a compiler flag (e.g. `--immutable`) that will cause the compiler to infer `Readonly`, `ReadonlyArray`, `ReadonlyMap`, and `ReadonlySet` (and any other data structures I've missed) everywhere. The flag will also force you to use `const`. Thus eliminating mutability from the language. ```json // tsconfig.json { "compilerOptions": { "immutable": true } } ``` ```ts // demo.ts // band is automatically inferred as: // Readonly<{ // name: string; // members: ReadonlyArray<{ // name: string; // instruments: ReadonlyArray<string>; // }>; // }> const band = { name: 'U2', members: [ { name: 'Bono', instruments: ['vocals', 'rhythm guitar', 'harmonic'] }, { name: 'The Edge', instruments: ['lead guitar', 'keyboards', 'backing vocals'] }, // ... ] }; // The following will cause compiler errors: // band.name = 'Green Day'; // band.members.push({ name: 'Billie Joe Armstrong', instruments: ['lead vocals', 'guitar'] }); // ---------------------------------------------------------------------- // numberMap is automatically inferred to be ReadonlyMap<number, string> const numberMap = new Map<number, string>([ [1, 'one'], [2, 'two'] ]); // Compiler error: // numberMap.set(3, 'three'); // letterSet is is automatically inferred to be ReadonlySet<string> const letterSet = new Set<string>(['A', 'B', 'C', 'D']); // Compiler error: // letterSet.add('E'); ```
Suggestion,Needs Proposal,Add a Flag
low
Critical
234,128,709
rust
Suggest converting a type to trait object when it's possible and the method expects one
If the method explicitly expects a trait object, such as `&postgres::types::ToSql`, (`ToSql` is a trait), and the user is trying to pass it a type that implements the trait, such as `String`, it's likely that the user either doesn't understand the distinction between trait object and trait bounds in generics, or has accidentally missed that the function isn't expecting a generic type but a trait object. In this case, it would be helpful to show a more specific error message than the standard "type mismatch". The standard error message is like this: ``` error[E0308]: mismatched types --> src/main.rs:75:39 | 75 | for row in &conn.query(get_table, schemas.as_slice()).unwrap() { | ^^^^^^^^^^^^^^^^^^ expected trait postgres::types::ToSql, found struct `std::string::String` | = note: expected type `&[&postgres::types::ToSql]` found type `&[&std::string::String]` ``` First of all, "expected trait" is downright misleading, I think it should be "expected trait object". Secondly, it would be helpful to show a hint that says that: 1) `String` implements trait `ToSql`, but this method is expecting a trait object, not any type that implements the trait. 2) You can create a trait object from a value of type `&String` with `value as &postgres::types::ToSql`.
C-enhancement,A-diagnostics,T-compiler,A-coercions,A-suggestion-diagnostics,A-trait-objects
low
Critical
234,163,782
rust
Include debuginfo in release builds of LLVM by default
This would be useful to help debug things like #42476. At the moment I can only debug it using Debian's rustc as stage0 - its LLVM is built separately and dynamically linked into librustc_llvm, so debugging symbols work there. However with rust's own 1.16 stage0 I get this instead: ~~~~ (gdb) bt #0 0x00003fffb5e6180c in (anonymous namespace)::ELFObjectWriter::computeSymbolTable(llvm::MCAssembler&, llvm::MCAsmLayout const&, llvm::DenseMap<llvm::MCSectionELF const*, unsigned int, llvm::DenseMapInfo<llvm::MCSectionELF const*>, llvm::detail::DenseMapPair<llvm::MCSectionELF const*, unsigned int> > const&, llvm::DenseMap<llvm::MCSymbol const*, unsigned int, llvm::DenseMapInfo<llvm::MCSymbol const*>, llvm::detail::DenseMapPair<llvm::MCSymbol const*, unsigned int> > const&, std::map<llvm::MCSectionELF const*, std::pair<unsigned long, unsigned long>, std::less<llvm::MCSectionELF const*>, std::allocator<std::pair<llvm::MCSectionELF const* const, std::pair<unsigned long, unsigned long> > > >&) [clone .constprop.338] () from /home/infinity0/build2/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0/bin/../lib/../lib/librustc_llvm-1b4bf1d78c7d2bcc.so [..] (sid_ppc64el-dchroot)infinity0@plummer:~/rustc-1.17.0+dfsg2$ sha256sum /home/infinity0/build2/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0/bin/../lib/../lib/librustc_llvm-1b4bf1d78c7d2bcc.so d3090a547a2a8189cb116cc726965e4af0695cd4ae48ae41f05224a3d429534b /home/infinity0/build2/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0/bin/../lib/../lib/librustc_llvm-1b4bf1d78c7d2bcc.so ^^^^ matches the one from rustc-1.16.0-powerpc64le-unknown-linux-gnu.tar.gz (sid_ppc64el-dchroot)infinity0@plummer:~/rustc-1.17.0+dfsg2$ objdump --debugging /home/infinity0/build2/rustc-1.17.0+dfsg2/build/powerpc64le-unknown-linux-gnu/stage0/bin/../lib/../lib/librustc_llvm-1b4bf1d78c7d2bcc.so | wc -l 80819 ~~~~ < eddyb> infinity0: you have to build LLVM in a special way to get DWARF for it < eddyb> and if you don't do it right you can easily run out of memory < eddyb> I'm not even sure we support that mode < eddyb> ah https://github.com/rust-lang/rust/blob/master/src/bootstrap/config.toml.example#L21 < eddyb> see https://github.com/rust-lang/rust/blob/master/src/bootstrap/config.toml.example#L56-L59 < eddyb> might have to be set to 1 /cc @eddyb I don't think we in Debian are doing anything particularly special, FWIW: https://sources.debian.net/src/llvm-toolchain-3.9/1:3.9.1-9/debian/rules/#L250 (@sylvestre is the maintainer).
A-LLVM,C-enhancement,T-bootstrap
low
Critical
234,209,629
go
proposal: spec: init-only package level variables
Mutable state held in package-level variables can be problematic for a few reasons, e.g. concurrency [edited to remove erroneous mention of multiple imports] It would be useful to be able to declare a form of "assign-once" variable that can only have its value set via an initializer in the declaration or in a subsequent init function. Once all init functions have completed the value of the variable cannot be changed. Some other languages use a special keyword to indicate this type of variable (e.g. pony uses let for assign-once variables and var for others)
LanguageChange,Proposal,LanguageChangeReview
low
Major
234,220,831
pytorch
In-place bernoulli_ has more functionality than torch.bernoulli with output parameter
``` x = torch.IntTensor(10) y = torch.Tensor(10).uniform_() x.bernoulli_(y) # ok! torch.bernoulli(y, out=x) TypeError: torch.bernoulli received an invalid combination of arguments - got (torch.FloatTensor, out=torch.IntTensor), but expected one of: * (torch.FloatTensor source, *, torch.FloatTensor out) didn't match because some of the arguments have invalid types: (torch.FloatTensor, out=torch.IntTensor) ``` cc @vincentqb @fritzo @neerajprad @alicanb @vishwakftw @nikitaved
module: distributions,triaged
low
Critical
234,226,683
angular
Parents of NgModel are not reset when using custom value accessors
<!-- IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING --> **I'm submitting a ...** (check one with "x") ``` [x] bug report => search github for a similar issue or PR before submitting [ ] feature request [ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question ``` **Current behavior** Take following multiple nested reusable components `custom-cmp` and `nested-cmp`: ``` <custom-cmp [(ngModel)]="bob"> <nested-cmp [(ngModel)]="bob" *ngIf="something"> <input [(ngModel)]="bob" /> </nested-cmp> .... further cmps .... </custom-cmp> ``` Each reusable component has a custom value accessor defined to pass the `[(ngModel)]` down to the `input` element. When the input element is changed, through `keystroke` for example... all components: `custom-cmp`, `nested-cmp` and `input` receive the correct `ng-dirty` flags. The `NgModel` at all three levels are also `dirty: true`. When `reset()` is called on the `input` or `nested-cmp` model (DI: `NgModel` or via the `@ViewChild(NgModel)` decorator) for example, none of the parents are notified and reset, as the `parent` property of the model in question is suddenly `undefined`. For example `nested-cmp` component class: ``` @ViewChild(NgModel) myInputModel: NgModel // this is the ngModel of the 'input' element (a child of nested-cmp) doReset(): void { this.myInputModel.reset(...original value...); } ``` In the above example: `doReset()` - only the `input element ngModel` is reset... i.e the input is set back to `ng-pristine`. The host, `nested-cmp` and it's parent `custom-cmp` remains dirty (`ng-dirty`). **Expected behavior** That all parent components on which `ngModel.reset()` is called are restored to their `pristine` states. **Minimal reproduction of the problem with instructions** Full reproduction: http://plnkr.co/edit/TTPfmhRj1LN2ZXjz4JXo?p=preview Further comments in same thread: https://github.com/angular/angular/issues/16772#issuecomment-306779757 https://github.com/angular/angular/issues/16772#issuecomment-306784580 https://github.com/angular/angular/issues/16772#issuecomment-306784810 **What is the motivation / use case for changing the behavior?** Creating custom components and taking advantage of two-way-binding without forms **Please tell us about your environment:** * **Angular version:** 2.4.9 * **Browser:** Chrome 58 * **Language:** TypeScript 2.2.2
freq2: medium,area: forms,type: use-case,forms: ngModel,P4
low
Critical
234,232,600
rust
region inference sometimes fails to recognize implied bound in closure
Following a bug sample from @jdm, I encountered this bug. [The compiler errors out in this code](https://is.gd/xTZO0h): ```rust struct Parser<'i: 't, 't> { data: &'t mut Vec<&'i String> } fn callback1<'i, 't, F>(parser: &mut Parser<'i, 't>, f: F) where F: for<'tt1> FnMut(&mut Parser<'i, 'tt1>) { panic!() } fn callback2<'i, 't, F>(parser: &mut Parser<'i, 't>, mut f: F) where F: for<'tt2> FnMut(&mut Parser<'i, 'tt2>) { callback1(parser, |input| { f(input) }); } fn main() { } ``` specifically it reports a "cannot infer" lifetime error, complaining about how the lifetime `'tt2` in the call `f(input)` must be some lifetime `'x` where `'i: 'x` and `'x: 'tt1` (where `'tt1` is the lifetime that appears in the type of `input` in the closure). The compiler is upset because it does not know that `'i: 'tt1`. Those constraints are correct, but in fact the compiler should be able to deduce that `'i: 'tt1` based on the type of `input`, which is is `&mut Parser<'i, 'tt1>`. The implied bounds for this type suggest that `'i: 'tt1`. But we fail to see it. The problem is an interaction with inference. When we call `callback1()` here, we do not specify the lifetime, and so we create a variable `'x` -- that is, the actual type of `input` is `&mut Parser<'x, 'tt2>`, where `'x` is the inference variable. We then recognize that this means `'x: 'tt2`, and we add a "given", which is this hacky bit of code in region inference. Then we infer that `'x` must be `'i`. But when we go to check that `'x: 'tt2`, we substitute `'x` to `'i`, and then report an error, because we never added anything that tells us that `'i: 'tt2`. [If you specify `callback::<'i>` manually, it will work fine.](https://is.gd/QxHOqn) The most straightforward fix is to use the given logic here too. The better fix is to retool this part of region inference to be more robust, which I am in the process of trying to plan out right now for other reasons anyhow.
T-compiler,A-inference,C-bug
low
Critical