id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
186,307,843 | go | fmt: support bounded buffers (Snprint, Snprintf, etc.) | Right now, printing large compound objects with %v or %#v can be very expensive, in terms of both CPU and RAM. It would be great to have a way for callers to tell formatting code to stop after N runes have been output. The current alternative is formatting everything anyway, only to discard most of the work after the call returns. | NeedsFix,FeatureRequest | low | Major |
186,369,400 | go | time: time.Sleep and time.NewTimer: Fix duration parameter error | ### What version of Go are you using (`go version`)?
go version go1.7.3 windows/amd64
### What operating system and processor architecture are you using (`go env`)?
set GOARCH=amd64
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
### What did you do?
I wrote a test which is basically a loop consisting of two things: Some busy work for about 500us and a call to time.Sleep(1 * time.Millisecond).
Here's a link to the test program: https://play.golang.org/p/VYGvIbTPo3
It can't run on the playground, so you will have to grab it and run it yourself.
### What did you expect to see?
```
work(~500us) + time.Sleep(1ms): 1.500000ms ... or slightly more
work(~500us) + time.After(1ms): 1.500000ms ... or slightly more
```
### What did you see instead?
```
work(~500us) + time.Sleep(1ms): 1.030103ms
work(~500us) + time.After(1ms): 1.110111ms
```
### Discussion
I believe that there are errors in the doc's for time.Sleep and time.NewTimer. They both make similar statements regarding the duration.
`Sleep pauses the current goroutine for at least the duration d.`
`NewTimer creates a new Timer that will send the current time on its channel after at least duration d.`
If these are correct, then the test loops should take ~1.5ms or longer per pass. But they don't.
I believe that `at least the duration d` was an attempt to convey that overhead might result in a longer duration than requested. But there are two other factors which might result in a shortened duration, sometime **MUCH** shorter. These factors are the resolution and phase of the time source used for these functions.
In Windows, the resolution is normally 1ms for Go programs. I'll refer to this value as r, short for resolution. I'm not sure what it is on other platforms. If you run the test program it will measure and display it. Please let me know what you find.
I believe that in general the duration can be as short as d-r (rather than d). How short simply depends on what the phase of the time source when you use it. Thus if you ask for a 100ms delay you will end up with something between 99 and 100 (plus overhead). Thus as you use smaller values of d (approaching r) the problem gets worse. By itself, this isn't too bad. But now the other shoe drops.
In the specific case that you ask for a delay of r (or anything between 1 and r), then the delay can be anything between 0 and r. Actually, for a reason I don't quite understand, the lowest delay I've actually seen is about 50us, not 0. Even so, that is 20 times less than the 1ms requested. This was drastic enough to break some of my code. I changed d from 1ms to 2ms. The resulting delay is between 1 and 2ms (plus overhead).
Can this cause a problem? Generally, in a loop only the first pass is affected, because the loop gets in phase with the timing source. So this might or might not be bad for you. If it is, put a sleep 1ms call just before the loop.
But imagine that you are using time.After to set up a timeout, but it occurs too quickly. Perhaps 20 times too quickly. This can cause intermittent, non-deterministic, bogus timeouts, even on a single-threaded program. Ouch! This is what bit me.
Another gotcha: Using d of 10ms now, but Go Windows switches r from 1ms to 15.6ms. Instead of a delay of 9 - 10ms you now get 0 - 15.6ms.
### Possible Solutions
The really bad case when d is between 1 and r could be detected causing d to be changed to r+1. Tacky, in my opinion. Alternatively, vet could look for this case.
Most programming languages I've worked in allow this to happen, but they don't document it incorrectly. This seems like the best solution to me. Simply fix the doc's to reflect reality.
Perhaps a paragraph at the top describing what the "resolution of the time source" means, what it is for some typical platforms, and an example of a simple routine to determine what yours is. Maybe even a system call to retrieve it.
Then, change the current time.Sleep description from
`
Sleep pauses the current goroutine for at least the duration d. A negative or zero duration causes Sleep to return immediately.
`
to something like
`
Sleep pauses the current goroutine for at least the duration d - 1. A duration less than or equal to the time source resolution can cause Sleep to return quickly. A negative or zero duration causes Sleep to return immediately.
`
And similar for time.NewTimer's description.
| OS-Windows,NeedsInvestigation | high | Critical |
186,400,688 | TypeScript | Dynamic Super Types | Now, that #11929 is PR landed. I would really love to have some syntax to specify an arbitrary `super type of T`. This can be especially helpful in creating strongly typed ORM database frameworks.
## Proposal
If `K` is constrained to be a key of `T` i.e `K extends keyof T`. Then the syntax:
```
{ ...K: ...T[K] }
```
Means spread the keys `K` and values of `T` in `{}`.
## Example
Here is an example usage of an envisioned ORM framework:
```ts
interface IUser {
id: string;
name: string;
email: string;
createdAt: string;
updatedAt: string;
password: string;
// ...
}
interface Options<T, K extends keyof T> {
attributes: T[K][];
}
interface Model<IInstance> {
findOne<K extends keyof IInstance>(options: Options<IInstance, K>): { ...K: ...IInstance[K] };
}
declare namespace DbContext {
define<T>(): Model<T>;
}
const Users = DbContext.define<IUser>({
id: { type: DbContext.STRING(50), allowNull: false },
// ...
});
const user = Users.findOne({
attributes: ['id', 'email', 'name'],
where: {
id: 1,
}
});
user.id // no error
user.email // no error
user.name // no error
user.password // error
user.createdAt // error
user.updatedAt // error
```
| Suggestion,Awaiting More Feedback | low | Critical |
186,400,756 | rust | debuginfo: How to (ideally) represent reference and pointer types in DWARF | Currently, we represent thin references and pointers with `DW_TAG_pointer_type` DIEs and fat pointers (slices and trait objects) as `DW_TAG_struct` DIEs with fields representing payload and metadata pointers. This is not ideal and with debuggers knowing about Rust, we can do better. The question is, what exactly do we want the representation for these kinds of types to look like.
Some things seem pretty straightforward to me:
- Rust references should be `DW_TAG_reference_type` DIEs.
- Rust raw pointers should be `DW_TAG_pointer_type` DIEs.
But beyond that, there are some decisions to be made:
### (1) How do we represent mutability?
The C++ version of DWARF represents a const pointer like `const char *` with three separate type entries:
```
0:
DW_TAG_base_type
DW_AT_name "char"
...
1:
DW_TAG_const_type
DW_AT_type: ref to <0>
2:
DW_TAG_pointer_type
DW_AT_type: ref to <1>
```
I think this is a bit verbose and I'm not sure it is entirely appropriate for Rust. Do we really have `const` and `mut` *types*? That is, does Rust have the concept of a `mut i32` at the type level, for example? I mean there are mutable and immutable *slots*/memory locations and we have "mutable" and "shared" references, but those two things seem kind of different to me.
As an alternative to using `DW_TAG_const_type` for representing mutability, we could re-use the `DW_AT_mutable` attribute that is already defined in DWARF. In C++ DWARF it is used for `mutable` fields. We could use it for reference type and local variable DIEs:
```
0: // char
DW_TAG_base_type
DW_AT_name "char"
...
1: // &mut char
DW_TAG_reference_type
DW_AT_type: ref to <0>
DW_AT_mutable: true
2: // &char
DW_TAG_reference_type
DW_AT_type: ref to <0>
DW_AT_mutable: false // or just leave it off
3:
DW_TAG_variable
DW_AT_name: "foo"
DW_AT_type: ref to <0>
DW_AT_mutable: true
...
```
### (2) How to represent fat pointers?
The pointer types in C/C++ DWARF don't have `DW_TAG_member` sub-DIEs, since they are always just values. Fat pointers in Rust are different: they have one field that is a pointer to the data, and another field that holds additional information, either the size of a slice or the pointer to a vtable. These need to be described somehow.
I see a few options:
1. A fat-pointer type is described by a `DW_TAG_pointer_type` or `DW_TAG_reference_type` DIE with two fields that are described by `DW_TAG_member` sub-DIEs, both having the `DW_AT_artificial` attribute. @tromey once suggested for slices that the field entries have no name and the debugger determines which is which by the type (the size is always an integer type, the data is always a pointer type). This could also be extended for trait objects, since the data pointer will always be a pointer to a trait and the vtable-pointer will always be something else.
2. Treat trait objects and slices differently. Have a new `DW_TAG_slice_type` DIE that follows the encoding above and borrow some other attributes for trait objects: a `DW_AT_vtable_elem_location` attribute holds the offset of the vtable field within the fat-pointer value, and a `DW_AT_object_pointer` attribute does the same for the data pointer. This is distinctly not how these attributes are used in a C++ context but it would be a nice fit, I think.
3. Mix of the above with `DW_AT_object_pointer` indicating data pointer field
Another questions is: Should fat-pointers (and thin pointers too, maybe) have a `DW_AT_byte_size` attribute that specifies their size explicitly?
cc @tromey, @Manishearth
See also https://github.com/rust-lang/rust/issues/33073 | A-debuginfo,T-compiler | medium | Critical |
186,431,662 | go | runtime: preemption takes longer on OpenBSD | TestGCFairness2 (0.12s)
proc_test.go:351: want OK
, got goroutine 1 did not run
https://storage.googleapis.com/go-build-log/bc7889a5/openbsd-amd64-gce58_a614fab1.log
/cc @aclements @RLH
I don't see any evidence that this is a known flake in the issue tracker, so filing a bug and tagging Go1.8Maybe in case it's of interest. | OS-OpenBSD,NeedsInvestigation,compiler/runtime | medium | Critical |
186,435,783 | flutter | Hot reload should be even less verbose | This should be collapsed into one line when you hit "r":
```
Syncing files to device... 96ms
Performing hot reload... 1793ms
Reloaded 260 of 439 libraries.
``` | tool,t: hot reload,from: study,P3,team-tool,triaged-tool | low | Major |
186,453,070 | rust | Program cross compiled for mips-unknown-linux-musl crashes with SIGILL | cc @Bigomby @alexcrichton
Originally reported as japaric/rust-cross#27
Original report below:
---
Hi, I'm trying to cross compile a Rust app for LEDE (fork of OpenWRT) but I'm stuck.
The application is just an `hello_world` example:
```rust
fn main() {
println!("Hello, world");
}
```
These are the steps I performed:
1. In first place I downloaded the LEDE SDK and compiled successfully the image and the toolchain for my device (`mips-openwrt-linux-musl-gcc`).
2. Install the Rust std using `rustup add mips-unknown-linux-musl`.
3. Create a `.cargo/config` file in my project with the following content:
```
[target.mips-unknown-linux-musl]
linker = "mips-openwrt-linux-musl-gcc"
```
4. Build the app using `cargo build --release --target=mips-unknown-linux-musl`.
5. Deploy the executable to the device using `scp`.
6. Got `Illegal instruction`
**On target**
```bash
$ ldd hello_world
/lib/ld-musl-mips-sf.so.1 (0x558c2000)
libgcc_s.so.1 => /lib/libgcc_s.so.1 (0x77cc4000)
libc.so => /lib/ld-musl-mips-sf.so.1 (0x558c2000)
$ ldd --version
musl libc (mips-sf)
Version 1.1.15
Dynamic Program Loader
Usage: ldd [options] [--] pathname
```
**On host**
```bash
$ mips-openwrt-linux-musl-gcc -v
Reading specs from /opt/lede/staging_dir/toolchain-mips_mips32_gcc-5.4.0_musl-1.1.15/bin/../lib/gcc/mips-openwrt-linux-musl/5.4.0/specs
COLLECT_GCC=mips-openwrt-linux-musl-gcc
COLLECT_LTO_WRAPPER=/opt/lede/staging_dir/toolchain-mips_mips32_gcc-5.4.0_musl-1.1.15/bin/../libexec/gcc/mips-openwrt-linux-musl/5.4.0/lto-wrapper
Target: mips-openwrt-linux-musl
Configured with: /home/diego/source/build_dir/toolchain-mips_mips32_gcc-5.4.0_musl-1.1.15/gcc-5.4.0/configure --with-bugurl=http://www.lede-project.org/bugs/ --with-pkgversion='LEDE GCC 5.4.0 r2032' --prefix=/home/diego/source/staging_dir/toolchain-mips_mips32_gcc-5.4.0_musl-1.1.15 --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=mips-openwrt-linux-musl --with-gnu-ld --enable-target-optspace --disable-libgomp --disable-libmudflap --disable-multilib --disable-libmpx --disable-nls --without-isl --without-cloog --with-host-libstdcxx=-lstdc++ --with-float=soft --with-gmp=/home/diego/source/staging_dir/host --with-mpfr=/home/diego/source/staging_dir/host --with-mpc=/home/diego/source/staging_dir/host --disable-decimal-float --with-mips-plt --with-diagnostics-color=auto-if-env --disable-libssp --enable-__cxa_atexit --with-headers=/home/diego/source/staging_dir/toolchain-mips_mips32_gcc-5.4.0_musl-1.1.15/include --disable-libsanitizer --enable-languages=c,c++ --enable-shared --enable-threads --with-slibdir=/home/diego/source/staging_dir/toolchain-mips_mips32_gcc-5.4.0_musl-1.1.15/lib --enable-lto --with-libelf=/home/diego/source/staging_dir/host
Thread model: posix
gcc version 5.4.0 (LEDE GCC 5.4.0 r2032)
```
## Disabling jemalloc
If I use rust nightly and disable jemalloc as following:
```rust
#![feature(alloc_system)]
extern crate alloc_system;
fn main() {
println!("Hello, world");
}
```
Then it works! But as I keep adding code the application eventually crashes with another `Illegal instruction`. For example:
**Works**
```rust
TcpStream::connect("130.206.193.115:80").unwrap();
```
**Does not work**
```rust
TcpStream::connect("google.com:80").unwrap();'
```
I don't know what I'm doing wrong. Any help will be appreciated. | O-MIPS,C-bug | low | Critical |
186,505,187 | youtube-dl | Please add feature for video.yaplakal.com | Good times,
Please add feature for video.yaplakal.com
Example link:
http://www.yaplakal.com/forum28/topic1481239.html
Kind regards,
Timur | site-support-request | low | Minor |
186,543,797 | rust | Consider storing auto-generated error message strings in separate object file | Some kinds of expression can generate a runtime panic with a compiler generated error message containing the source location of that expression. Examples are arithmetic expressions that can cause integer overflow or division by zero, and expressions that result in array bounds checks.
So far we are allocating string constants in the same codegen unit as the expression, which has two disadvantages:
* Because we do not check whether there is already a constant for that source location, we will have copies of the same data for each monomorphized instance of a function. (Or does LLVM merge equal constants if there address is never taken?)
* Since the source location is contained in machine code, the whole object file often has to be re-compiled during incremental compilation even if just formatting has changed or comments have been added.
This could be solved by interning all those constants into a separate object file with a (semi-)stable symbol name (e.g. symbol_name = function_symbol_name + index within function). That way, only the error-message-object-file has to be regenerated when nothing but formatting has changed. | I-slow,C-enhancement,A-codegen,I-compiletime,T-compiler,A-incr-comp | low | Critical |
186,602,124 | youtube-dl | no or wrong video for CBC Murdoch Mysteries or Nature of Things | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.10.31*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x ] I've **verified** and **I assure** that I'm running youtube-dl **2016.10.31**
### Before submitting an *issue* make sure you have:
- [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ x] Bug report (encountered problems with youtube-dl)
---
For some time now I have been unable to rip from CBC. Some problem URL-s:
1) http://www.cbc.ca/murdochmysteries/episodes/season-10/concocting-a-killer
Produces:
```
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', '-F', '--yes-playlist', '-v', 'http://www.cbc.ca/murdochmysteries/episodes/season-10/concocting-a-killer']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2016.10.31
[debug] Python version 3.4.4 - Windows-10-10.0.14393
[debug] exe versions: ffmpeg N-79791-g03fceb7, ffprobe N-79791-g03fceb7, rtmpdump 2.4
[debug] Proxy map: {}
[cbc.ca] concocting-a-killer: Downloading webpage
[download] Downloading playlist: None
[cbc.ca] playlist None: Collected 0 video ids (downloading 0 of them)
[download] Finished downloading playlist: None
```
2) http://www.cbc.ca/natureofthings/episodes/running-on-empty
This retrieves video ids, but only for a short excerpt that is also available from the page:
```
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['--verbose', '--no-part', '-f', 'http-2628', '--yes-playlist', '-v', 'http://www.cbc.ca/natureofthings/episodes/running-on-empty']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2016.10.31
[debug] Python version 3.4.4 - Windows-10-10.0.14393
[debug] exe versions: ffmpeg N-79791-g03fceb7, ffprobe N-79791-g03fceb7, rtmpdump 2.4
[debug] Proxy map: {}
[cbc.ca] running-on-empty: Downloading webpage
[download] Downloading playlist: None
[cbc.ca] playlist None: Collected 1 video ids (downloading 1 of them)
[download] Downloading video 1 of 1
[ThePlatform] 714330179872: Downloading SMIL data
[ThePlatform] 714330179872: Checking video URL
[ThePlatform] 714330179872: Checking video URL
[ThePlatform] 714330179872: Checking video URL
[ThePlatform] 714330179872: Checking video URL
[ThePlatform] 714330179872: Checking video URL
[ThePlatform] 714330179872: Checking video URL
[ThePlatform] 714330179872: Downloading JSON metadata
[debug] Invoking downloader on 'http://progressive.cbc.ca/prodVideo/documentaries/CBC_Documentaries_VMS/279/355/ROE_-_Sinking_2500kbps.mp4?hdnea=st=1478022035~exp=1478022425~acl=/prodVideo/documentaries/CBC_Documentaries_VMS/279/355/ROE_-_Sinking_*~hmac=935865707347d034cc7c29b32234a53fbe58e798e19f43e71cbc74c7b385ea28'
[download] Destination: Running on Empty – Sinking Land-714330179872.mp4
[download] 100% of 20.34MiB in 00:06
[download] Finished downloading playlist: None
```
UPDATE:
I found a work around that I thought I should pass on for anyone else having this problem.
Using the "HLS Stream Detector" add-on for Firefox will allow you to determine the URL for the m3u8 file, for example:
http://v.watch.cbc.ca/p//38e815a-00b14d50494//CBC_NATURE_THINGS_SEASON_56_S56E04-v2-10837286/CBC_NATURE_THINGS_SEASON_56_S56E04-v2-10837286__desktop.m3u8?cbcott=st=1478208977~exp=1478295377~acl=/*~hmac=7740937cd92501a3f683655eb51a3e0a0dd98de86057b6519d249fbab2e423de
You can use that with youtube-dl to do the download.
| geo-restricted | low | Critical |
186,607,773 | rust | Command::spawn has weird rules for finding binaries on Windows | The offending code is [here](https://github.com/rust-lang/rust/blob/ac968c466451cb9aafd9e8598ddb396ed0e6fe31/src/libstd/sys/windows/process.rs#L130-L149) which is apparently to have it search the child's `%Path%` for the binary to fix #15149. It has a few issues though.
1. It is only triggered when the child's environment has been customised. This means `Command::new("foo.exe").spawn()` and `Command::new("foo.exe").env("Thing", "").spawn()` uses different rules for finding the binary which seems unexpected.
2. It will replace any extension on the program name with `.exe`. This means `Command::new("foo.bar").env("Thing", "").spawn()` attempts to launch `foo.exe` first. `Command::new("foo.bar").spawn()` correctly tries to launch `foo.bar` as [`CreateProcess`](https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx) will not replace the extension.
3. If the program name is an absolute path then this is still triggered but will just try that path for every item in the child's `%Path%`. For example `Command::new(r"C:\foo.bar").env("Thing", "").spawn()` looks for `C:\foo.exe` several times.
4. The use of `.to_str().unwrap()` means it `panic!`s if the program name is not valid Unicode.
5. Prehaps the biggest issue, but maybe it's itentional, is that none of the logic for finding binaries seems to be documented ([`std::process::Command`](https://doc.rust-lang.org/nightly/std/process/struct.Command.html)).
An easy way to fix this is to just remove the hack so we just rely on the behaviour of [`CreateProcess`](https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx) on Windows which is a least documented. The behaviour is already very different between Windows and Linux and we should probably just accept that in order to get reliable results cross-platform it's best to use absolute paths. | O-windows,C-feature-request,T-libs,A-process | medium | Major |
186,619,241 | go | runtime, cmd/compile: remove all pointers from type information | For Go 1.7 I started replacing the pointers in Go's run time type information with offsets from the beginning of the type section. (The motivation was significantly reduced binary size, as 8-bytes for the pointer + 32-bytes for the dynamic relocation is significantly more than a 4-byte offset multiplied through by several pointers in each type and thousands of types.)
This work is not yet complete, and in its partial state it leads to subtle bugs like #17709. When using a binary built with -buildmode=shared or -buildmode=plugin, there are multiple type information sections, one for each module. An offset into this region (represented by either a ```typeOff``` or a ```nameOff```) needs to be resolved against the correct type region. But when you follow one of the old pointers in a type, it is entirely possible the dynamic relocation processed by ld.so will jump you to the types section of a different module.
This can lead to an offset from one module being resolved against the wrong type region, meaning garbage data is used for the type. This will manifest as subtle bugs: types incorrectly mapping (or not) onto interfaces, the reflect package returning wrong results, or bad garbage collection.
The likelihood of misplacing an offset decreases significantly if we remove the pointers, as we will not have to consider the interaction of two separate relocation systems. Let's do that. | compiler/runtime | low | Critical |
186,641,351 | TypeScript | module_resolution=none or =explicit | Discussed in-person with @DanielRosenwasser
In google we have performance issues with tsc and with editor plugins. We have tracked this down to the node moduleResolutionKind looking in many locations on a network-mounted disk.
We don't actually want the node moduleResolution, we only want the baseUrl/paths/rootDirs feature known as "path mapping". Put another way, we explicitly list locations for all inputs, and we never want the compiler to stat a file outside of the explicit input locations.
For tsc, we provide a custom CompilerHost that avoids touching the disk, we implement fileExists and directoryExists purely by consulting our file manifest. However, we can't do this trick for editors, which are becoming increasingly unusable.
As an example, we provide interop with Closure Compiler code that declares `goog.module`, by naming these `goog:some.module`. This results in the language services looking for a file like `goog:some.module.d.ts` all over the network-mounted filesystem, even though a later sourceFile in the program has `declare module 'goog:some.module'`
cc @vikerman @rkirov | Suggestion,Needs More Info,VS Code Tracked | low | Major |
186,673,471 | go | cmd/compile: merge order/walk/instrument into buildssa | Currently the compiler backend performs several stages of Node AST rewrites before generating SSA. We should investigate generating SSA directly from the AST produced by the frontend. Rationale:
1. order.go exists as a separate pass primarily to simplify maintaining order-of-evaluation in walk.go, but we can probably just as easily handle this when directly producing SSA.
2. order.go and walk.go iterate across the entire function AST a couple times, reading and writing to every pointer slot. Usually the values written are also identical to the values already in memory too.
3. AST rewrites requires the intermediary format to be representable in the AST too, which may complicate transitioning to package syntax. There are currently several gc.Ops generated and used only within the backend (e.g., OSQRT, OINDREGSP, OEFACE, ...).
4. The AST invariants between these phases are poorly documented or at least poorly understood.
/cc @randall77 @josharian | ToolSpeed,compiler/runtime | low | Major |
186,678,502 | flutter | Hide complexity of dropdown testing | Internal: b/153422899
This is the code required to properly switch from value A to value B in a widget tester:
```Dart
changeDropDown(
WidgetTester tester,
String currentValue,
String newValue,
) async {
await tester.tap(find.text(currentValue).last);
await tester.pump();
await tester.pump(const Duration(seconds: 1)); // finish the menu animation
await tester.tap(find.text(newValue).last);
await tester.pump();
await tester.pump(const Duration(seconds: 1)); // finish the menu animation
}
```
This logic should be hidden from app tests as it looks fragile and should be maintained by framework instead. | a: tests,c: new feature,framework,customer: money (g3),P3,team-framework,triaged-framework | low | Minor |
186,721,208 | vscode | Add "find all occurences" in the current file feature |
Using Search sidebar to find all items in current file requires too much clicks.
VS has a find all option
- VSCode Version: 1.6.1
- OS Version: Windows Server 2008
Steps to Reproduce:
1. Ctrl + F
2. Type search test
## Expected
option to see all occurrences
## Actual
No such option
## Visual Studio
## VS Code
| feature-request,search,editor-find | high | Critical |
186,880,544 | go | proposal: cmd/vet: check for missing Err calls for bufio.Scanner and sql.Rows | Please answer these questions before submitting your issue. Thanks!
### What version of Go are you using (`go version`)?
```
go version go1.7.3 linux/amd64
```
### What operating system and processor architecture are you using (`go env`)?
```
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/matt"
GORACE=""
GOROOT="/home/matt/.gvm/gos/go1.7.3"
GOTOOLDIR="/home/matt/.gvm/gos/go1.7.3/pkg/tool/linux_amd64"
CC="gcc"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build698545690=/tmp/go-build -gno-record-gcc-switches"
CXX="g++"
CGO_ENABLED="1"
```
### What did you do?
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
https://play.golang.org/p/zvrWRVgw4M
Used a `bufio.Scanner` without checking `bufio.Scanner.Err()` for error. The same mistake occurs frequently with `sql.Rows.Err()`.
### What did you expect to see?
`go vet` should warn that `s.Err()` was not called, and that it should be checked to determine if an error occurred while scanning.
This frequently occurs in our internal codebase at work. Arguably, `go vet` could check if any type has a method `Err() error` and report if the error is not checked or returned, instead of just checking the special cases with `bufio.Scanner` and `sql.Rows`. There may also be more types that use this pattern in the standard library.
### What did you see instead?
No warnings from `go vet`. | Proposal,Proposal-FinalCommentPeriod,Analysis | medium | Critical |
186,916,071 | youtube-dl | "--hls-use-mpegts --no-part" should create files with ".ts" extension | OS: Windows Vista SP2 x86, latest OS updates from Microsoft.
Using the latest standalone "youtube-dl.exe" downloaded from Github.
`youtube-dl --version => 2016.11.02`
Also using FFmpeg.exe 3.0 (x86) downloaded from the Zeranoe repo.
The first channel of the Greek National TV broadcaster uses Youtube to host its live stream;
[ERT1 LIVE](http://webtv.ert.gr/ert1/) => [https://www.youtube.com/watch?v=gnnO4TeJG-4](https://www.youtube.com/watch?v=gnnO4TeJG-4)
The actual youtube URL changes frequently...
`--hls-prefer-native` doesn't seem to be able to handle this stream,
so ffmpeg MUST be used. When issuing:
`youtube-dl -f 94 --no-part "https://www.youtube.com/watch?v=gnnO4TeJG-4"`
the stream download is delegated to FFmpeg and (correctly) youtube-dl creates
a file with the ".mp4" extension. When I `CTRL+C`, the end file is correctly
identified by MediaInfo to be an MP4 file.
On the contrary, when I issue:
`youtube-dl -f 94 --hls-use-mpegts --no-part "https://www.youtube.com/watch?v=gnnO4TeJG-4"`
youtube-dl (again) generates a file with file extension ".mp4", but
the `--hls-use-mpegts` switch creates an MPEG-TS container which has
(by default) a ".ts" file extension (... at least on Windows)!
`CTRL+C`ing results in an end file which is, in essence, a ".ts" file,
as reported by MediaInfo, but with an erroneous ".mp4" extension.
I have to manually rename the file back to the correct ".ts" extension.
I am of the opinion this is a bugged behaviour on the part of the
application and that youtube-dl should be smart enough to attribute
the correct file extention (.ts) when `--hls-use-mpegts` is employed...
Many thanks to all the devs' team for their on-going efforts!
| request | low | Critical |
186,917,352 | go | x/crypto/acme/autocert: lock usage around certState is bogus and error prone | The use of locks around certState is pretty confusing. The certState method returns the state value either locked or not, which means the call site has no idea about what it got. Then, there's a `locked` boolean field which is used to decide whether to lock it again or release the existing lock. That's both error prone and wrong from a concurrent memory access perspective. | NeedsInvestigation | low | Critical |
186,920,248 | opencv | opencv does not build on Mac OS X 10.10 with Xcode 7 | ##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => master
- Operating System / Platform => Mac OS X 10.10
- Compiler => Xcode 7 (clang)
##### Detailed description
opencv fails to build, because the `CoreImage` framework can not be found. That is strange, because I can actually see it in the SDK at `/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk/System/Library/Frameworks/CoreImage.framework`.
However, as opencv links agains `QuartzCore.framework`, which already includes `CoreImage`, we do not actually need to link against `CoreImage`. Removing `CoreImage` leads to a successfull build.
##### Steps to reproduce
```
mkdir build
cd build
cmake -D CMAKE_BUILD_TYPE=RELEASE -D CMAKE_INSTALL_PREFIX=/tmp/opencv -D INSTALL_C_EXAMPLES=YES -D INSTALL_PYTHON_EXAMPLES=YES -D OPENCV_EXTRA_MODULES_PATH=`pwd`/../../opencv_contrib/modules -D BUILD_EXAMPLES=ON ..
make
```
will fail with
```
ld: framework not found CoreImage
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [lib/libopencv_videoio.3.1.0.dylib] Error 1
``` | bug,priority: low,category: build/install,platform: ios/osx | low | Critical |
186,928,034 | go | build: all.bash fails to saturate 6 cores | `go version devel +eed2bb7 Wed Nov 2 19:21:16 2016 +0000 linux/amd64`
### What did you do?
```
./clean.bash
time ./all.bash
```
### What did you expect to see?
I do my development on a virtualized 6-core Xeon running Ubuntu. (`runtime.NumCPU()` returns `6`.)
Per @rsc's comments on #10571, I expected "Both the build half and the test half of all.bash should consume nearly all the CPUs for most of the time."
### What did you see instead?
all.bash seems to saturate at ~2 CPU cores for a significant fraction of the run. It consumes less than twice as much `user` time than `real`. Oddly, `sys` usage is even higher than `user`; I'm not sure what to make of that.
```
real 8m55.199s
user 14m13.511s
sys 8m51.402s
```
Here's a chart of [CPU saturation over time](https://github.com/golang/go/issues/17751#issuecomment-258011982) as measured by `mpstat`. You can see that there are a couple bursts of parallelism with mostly poor saturation in between. The machine doesn't appear to be hitting swap during the build.
| help wanted,ToolSpeed,NeedsInvestigation | high | Critical |
186,945,272 | rust | Consider using incremental linking with msvc | Incremental linking will allow for significantly faster link times, at the cost of binary size.
1. Don't delete the output artifacts. The `.ilk` and `.exe` or `.dll` must remain from the previous run.
2. Don't pass `/OPT` to the linker or any other flag that is mutually exclusive with incremental linking.
3. Pass `/INCREMENTAL` to the linker.
4. The set of files passed to the linker **must** remain the same. If the codegen unit object files change names, then it will do a full link.
https://msdn.microsoft.com/en-us/library/4khtbfyf.aspx
Alternatively, provide LLD as a stable alternative to link.exe so users can benefit from faster links when they don't need any special features of link.exe. | A-linkage,C-enhancement,I-compiletime,T-compiler,O-windows-msvc | medium | Critical |
187,015,980 | opencv | Incorrect upper bound for the number of components in ConnectedComponents algorithms | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => master
- Operating System / Platform => OSX 10.12.1
- Compiler => Apple LLVM version 8.0.0 (clang-800.0.42.1)
##### Detailed description
New implemented algorithm LablelingGrana has incorrect upper bound for the number of components. And now it's default algorithm for this common case of usage:
```.cpp
cv::connectedComponents(image, labels);
```
This cause an BAD_ACCESS issue.
##### Steps to reproduce
Here is an example code that may reproduce an issue.
Here number of components is ROWS * COLS / 3,
But in [implementation](https://github.com/sokian/opencv/blob/master/modules/imgproc/src/connectedcomponents.cpp#L351-L353) it's ROWS * COLS / 4.
```.cpp
#include <iostream>
#include <opencv2/imgproc.hpp>
const int ROWS = 1;
const int COLS = 500;
int sum = 0;
void testConnectedComponents() {
cv::Mat img(cv::Size(COLS, ROWS), CV_8U);
for (int i = 0; i < COLS * ROWS; i += 3) {
img.data[i] = 1;
}
cv::Mat lab;
sum += cv::connectedComponents(img, lab);
}
int main() {
int t = 1000000;
for (int i = 0; i < t; ++i) {
testConnectedComponents();
}
std::cerr << "Sum: " << sum << std::endl;
return 0;
}
```
##### Solution (Updated)
After @kinchungwong comment, issue changed. Upper bounds for both LabelingGrana and LabelingWu was incorrect.
Correct formulas for both cases are:
4-connectivity: `floor((rows * cols + 1) / 2) + 1`
8-connectivity: `floor((rows + 1) / 2) * floor((cols + 1) / 2) + 1`
| bug,category: imgproc | low | Critical |
187,138,961 | go | x/net/http2: expose CloseIfIdle and ClientConnPoolIdleCloser | The http2 `Transport` exposes a `CloseIdleConnections` method that will call the method of the same name on the `ClientConnPool` if it implements the private `clientConnPoolIdleCloser` interface. The `ClientConnPool` implementation calls the private method `closeIfIdle` on each pooled `ClientConn`.
If one want to create a custom `ClientConnPool`, there is no way to make this custom pool support this feature without exposing `CloseIfIdle` method and `ClientConnPoolIdleCloser` interface. | NeedsInvestigation | low | Major |
187,140,184 | go | x/net/http2: add a MarkComplete method to ClientConnPool | This method can be useful in the context of a custom connection pool, to implement lower max concurrent streams per connection than advertised by the server for example. | NeedsInvestigation,FeatureRequest | medium | Critical |
187,215,967 | rust | Tracking issue for TrustedLen (`trusted_len`) | Implemented in #37306
Open Questions:
- - [ ] Naming: something with Iterator in the name?
- - [ ] Naming: size vs len
- - [ ] Does TrustedLen pose any requirements on the ExactSizeIterator impl if one exists for the same type?
- - [ ] Does TrustedLen pose any requirements on the Clone impl if one exists for the same type?
- - [ ] Check all the specific impls, including complicated ones like Flatten on arrays or FlatMap that returns arrays. | T-libs-api,B-unstable,C-tracking-issue,A-iterators,Libs-Tracked | medium | Critical |
187,444,373 | rust | Inherent static methods on traits do not play well with associated types | It's a nice trick that you can provide static methods on bare traits, but sadly this doesn't quite work with associated types:
```rust
trait Assoc {
type Ty;
}
impl<T> Assoc<Ty = T> {
fn non_method() {}
}
fn main() {
Assoc::non_method()
}
```
Error:
```
error[E0191]: the value of the associated type `Ty` (from the trait `Assoc`) must be specified
--> <anon>:10:5
|
10 | Assoc::non_method()
| ^^^^^^^^^^^^^^^^^ missing associated type `Ty` value
error: no associated item named `non_method` found for type `Assoc` in the current scope
--> <anon>:10:5
|
10 | Assoc::non_method()
| ^^^^^^^^^^^^^^^^^
``` | A-trait-system,T-compiler,C-bug | medium | Critical |
187,455,224 | go | runtime: nice -20 causes thread exhaustion on ARM | ### What version of Go are you using (`go version`)?
go version go1.7.1 linux/arm
### What operating system and processor architecture are you using (`go env`)?
Linux/ARM (RPi 2/3)
### What did you do?
sudo nice -n -20 program
### What did you expect to see?
Program works correctly
### What did you see instead?
Number of threads increase randomly until program crashes with following error "runtime/cgo: pthread_create failed: Resource temporarily unavailable"
gdb reports large number of stalled threads
33 Thread 0x671ff460 (LWP 7863) "printer" 0x000a7aa8 in runtime.futex ()
32 Thread 0x669ff460 (LWP 7864) "printer" 0x000a7aa8 in runtime.futex ()
31 Thread 0x679ff460 (LWP 7821) "printer" 0x000a7aa8 in runtime.futex ()
30 Thread 0x681ff460 (LWP 7820) "printer" 0x000a7aa8 in runtime.futex ()
29 Thread 0x689ff460 (LWP 7811) "printer" 0x000a7aa8 in runtime.futex ()
28 Thread 0x691ff460 (LWP 7810) "printer" 0x000a7aa8 in runtime.futex ()
27 Thread 0x6a1ff460 (LWP 7806) "printer" 0x000a7aa8 in runtime.futex ()
26 Thread 0x699ff460 (LWP 7807) "printer" 0x000a7aa8 in runtime.futex ()
25 Thread 0x6a9ff460 (LWP 7804) "printer" 0x000a7aa8 in runtime.futex ()
24 Thread 0x6b1ff460 (LWP 7802) "printer" 0x000a7aa8 in runtime.futex ()
23 Thread 0x6b9ff460 (LWP 7801) "printer" 0x000a7aa8 in runtime.futex ()
22 Thread 0x6c1ff460 (LWP 7775) "printer" 0x000a7aa8 in runtime.futex ()
21 Thread 0x6c9ff460 (LWP 7774) "printer" 0x000a7aa8 in runtime.futex ()
20 Thread 0x6d1ff460 (LWP 7771) "printer" 0x000a7aa8 in runtime.futex ()
19 Thread 0x6d9ff460 (LWP 7770) "printer" 0x000a7aa8 in runtime.futex ()
Before crashes usually load where around 7~10. RPi's normal load should be less than 0.2.
I have find out time.Sleep() is the part of the issue specially inside tight loops. Longer delays cause issue appear much less frequently. It gets better or worst depend on structure of code. I could not reproduce it on amd64.
Removing "nice" make the issue goes away completely.
Unfortunately I could not prepare small program to reproduce the issue.
| NeedsInvestigation | medium | Critical |
187,458,769 | flutter | Date picker should have an unlimited range mode | c: new feature,framework,f: material design,f: date/time picker,c: proposal,P3,team-design,triaged-design | low | Minor |
|
187,458,831 | flutter | Date picker should validate the input arguments | In particular if lastDate < firstDate, for example.
Right now we eventually crash when you click the year in the year picker, or something. | framework,f: material design,f: date/time picker,c: proposal,P3,team-design,triaged-design | low | Critical |
187,482,044 | go | x/mobile: ndk-build finds wrong library path for dlopen | Hi,
Based on the Android NDK samples (https://github.com/googlesamples/android-ndk/tree/master) and mainly the hello-libs, I'm trying to call a prebuilt library.
In fact, it is pretty simple for a C-based library (using the examples), but when my .so is built using Go, the ndk-build linker seems to go crazy and uses an intermediate path to reference the .so library which causes the app crash.
### Go versions
go version go1.7.1 darwin/amd64
gomobile version +6ecf8ee Sun Oct 16 10:25:40 2016
### Go env
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/me/dev/go/"
GORACE=""
GOROOT="/usr/local/go"
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/b_/y2nd3vgn4m1929dg56thjdn40000gn/T/go-build047047925=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
### Steps
On the gomobile example directory, create an Android binding library :
cd $GOPATH/src/golang.org/x/mobile/example/bind/hello
gomobile bind -target android
extract the so library from the resulting aar.
create a simple .h header to reference the symbol (Java_go_hello_Hello_Greetings)
add the result to the sample project (the same thing as gperf)
without even referencing the function on the main cpp, build the project (gradle build) --> build successful
install the resulting apk
### What did you expect to see?
a working app
### What did you see instead?
java.lang.UnsatisfiedLinkError: dlopen failed: library "/Users/me/Desktop/vm-win/ndk-build-golang/hello-libs-2/app/src/main/cpp/../../../../distribution/libgo/lib/arm64-v8a/libgojni.so" not found
after decomposing the code and focusing only on the library build (basic ndk project) I still get the same thing :
java.lang.UnsatisfiedLinkError: dlopen failed: library "/Users/me/dev/android-ndk/hello-libs/app/build/intermediates/ndkBuild/debug/obj/local/arm64-v8a/libgojni.so" not found
When I check the symbols on the intermediate library (libhello-libs.so) I see that the libgojni.so is referenced with a full path instead of just the filename (which is the case of a C-based library)
(both libraries are at the same level when I extract the apk)
Thanks,
### additional info
A C-based library is working but not the Go-based one. Maybe the latter is missing something ?
I've uploaded a buildable project to https://github.com/ab-smith/ndk-build-golang
I can make it work by patching the libhello-libs.so and fixing the path binary, but this is not a solution.
| NeedsInvestigation,mobile | low | Critical |
187,484,616 | godot | Memory leak with circular reference in GDscript | Hi,
Godot reference counting mechanism doesn't support circular references. This is fine for simple construction (e.g. loading References) but given GDscript is build on this, you can write leaking program pretty easily:
```gdscript
func _ready():
set_process(true)
class Leaker:
var stuff = null
var other = null
func _init():
# Dummy data to make the leak more visible
self.stuff = []
for x in range(1000):
self.stuff.append(x)
func connect(other):
self.other = other
func _process(delta):
var a = Leaker.new()
var first = a
for i in range(100):
var b = Leaker.new()
a.connect(b)
a = b
a.connect(first) # Comment this line to remove the leak !
```
This is not a trouble for me (beside a circular dependency checker is complex to code and slow to run) but I think it's something users should be aware of.
I couldn't see any information about this behavior in the documentation so I think there should be a warning about this in [GDscript more efficiently](http://docs.godotengine.org/en/stable/reference/gdscript_more_efficiently.html#pointers-referencing)
| enhancement,discussion,topic:core,topic:gdscript | medium | Major |
187,488,988 | youtube-dl | Optional parse parameters | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.04*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.04**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### What i want to achieve:
For example, if i want to download all Songs from this youtube channel: [EMH Music](https://www.youtube.com/user/EMHmusicPromo/videos)
There are songs that have the following titles:
1. [Joachim Pastor - Laos ](https://www.youtube.com/watch?v=uA0PL49i5Zo)
2. [Erland - Liquid (Chiaro Remix)](https://www.youtube.com/watch?v=hRN66d7mDBI)
3. [[Electro House] Blaynoise - Devil's Dance](https://www.youtube.com/watch?v=FpTRMz_WhpM)
4. [[Dark Electro] Owl Vision - Oblique (Mathematic Remix) ](https://www.youtube.com/watch?v=Wq5Wbg0FtX8)
As you can see there ist different metadata in the title, like the artist, track, genre, alt_title.
I would like to read all of this metadata in a single run.
### How it works (doesn't work) at the moment:
If i define a parse string like
`--metadata-from-title "[%(genre)s] %(artist)s - %(title)s (%(alt_title)s)"`
the parsing only works on the Song 4 and fails on 1, 2 and 3.
### Possible solutions:
**Add a optional flag**
There could be a character in the parse string that flags some part as optional.
For example: `"?[%(genre)s] ?%(artist)s - %(title)s? (%(alt_title)s)?"`
This string would still get the artist and title if the genre or alt_title is missing.
**Allow multiple parse strings:**
There could me multiple parse strings. If the first fails, the second one is parsed and so on. If it doesn't fail it doesn't parse the other strings.
For example:
`--metadata-from-title "[%(genre)s] %(artist)s - %(title)s (%(alt_title)s)"`
`--metadata-from-title "%(artist)s - %(title)s (%(alt_title)s)"`
`--metadata-from-title "[%(genre)s] %(artist)s - %(title)s"`
`--metadata-from-title "%(artist)s - %(title)s"` | request | low | Critical |
187,548,410 | rust | Using pattern match directly on LockResult causes deadlock | Came across this as I was playing around with implementing memoisation via double-checked-locking with `sync::RWLock`:
The following, which puts the `.read()` result into a temporary binding works fine:
```rust
// ...
{
let lock_result = self.cache.read(); // <-- temporary binding
match lock_result {
Ok(ref data) if data.len() > to => Some(data[to].clone()),
_ => None,
}
}
.unwrap_or_else(|| {
// We need to write now, so get a write lock
let mut data = self.cache.write().unwrap();
// ...
```
The following, which directly matches on the result of `.read()`, dies in a deadlock:
```rust
// ...
{
match self.cache.read() { // <-- direct pattern matching
Ok(ref data) if data.len() > to => Some(data[to].clone()),
_ => None,
}
}
.unwrap_or_else(|| {
// We need to write now, so get a write lock
let mut data = self.cache.write().unwrap();
// ...
```
I'm guessing the direct pattern match is compiled/desugared in a way that the `RwLockReadGuard` never goes out of scope and thus the read lock is never released, but I'm not sure if this is the expected behaviour. It certainly surprised me, especially since the entire "read" block is scoped by its own set of braces.
For extra context, here is the relevant part in [my scratchpad project](https://github.com/lloydmeta/fib-rust/blob/master/src/maths/fib.rs#L80-L107). I have a [concurrency test](https://github.com/lloydmeta/fib-rust/blob/master/tests/maths_tests/fib_tests.rs#L41-L62) for it that fails to finish if the pattern matching section is changed to match the latter case.
| A-lifetimes,A-destructors,T-lang,C-bug | medium | Major |
187,555,073 | youtube-dl | sucksex.com site support | ---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.04*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.04**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Site support request (request for adding support for a new site)
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'https://www.sucksex.com/big-boobs/nri-couple-fucking-on-cam/']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.11.04
[debug] Python version 2.7.12 - Linux-4.4.0-45-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: ffmpeg 2.8.8-0ubuntu0.16.04.1, ffprobe 2.8.8-0ubuntu0.16.04.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] nri-couple-fucking-on-cam: Requesting header
WARNING: Falling back on generic information extractor.
[generic] nri-couple-fucking-on-cam: Downloading webpage
[generic] nri-couple-fucking-on-cam: Extracting information
[redirect] Following redirect to http://www.sucksex.com/big-boobs/nri-couple-fucking-on-cam/?PageSpeed=noscript
[generic] ?PageSpeed=noscript: Requesting header
[redirect] Following redirect to https://www.sucksex.com/big-boobs/nri-couple-fucking-on-cam/?PageSpeed=noscript
[generic] ?PageSpeed=noscript: Requesting header
WARNING: Falling back on generic information extractor.
[generic] ?PageSpeed=noscript: Downloading webpage
[generic] ?PageSpeed=noscript: Extracting information
ERROR: Unsupported URL: https://www.sucksex.com/big-boobs/nri-couple-fucking-on-cam/?PageSpeed=noscript
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 1634, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 2525, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 2514, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1653, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1517, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 2, column 11
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 694, in extract_info
ie_result = ie.extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 357, in extract
return self._real_extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 2421, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: https://www.sucksex.com/big-boobs/nri-couple-fucking-on-cam/?PageSpeed=noscript
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.sucksex.com/big-boobs/nri-couple-fucking-on-cam/
- Single video: https://www.sucksex.com/big-ass/13753/
--- | site-support-request,nsfw | low | Critical |
187,573,448 | youtube-dl | [svt] Add support for playlists | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.04*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x ] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.04**
### Before submitting an *issue* make sure you have:
- [x ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.11.04
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
| request | low | Critical |
187,575,946 | vscode | Triggering actions.find causes active match to lose its highlight. | - VSCode Version: Code 1.7.1 (02611b40b24c9df2726ad8b33f5ef5f67ac30b44, 2016-11-03T13:53:14.822Z)
- OS Version: Windows_NT ia32 10.0.14393
Steps to Reproduce:
1. In any file, highlight the text to find.
2. Trigger the `actions.find` command with the keyboard (`Ctrl+F`).
3. Observe that the originally highlighted text is not highlighted in any way that distinguishes it as the active match or target for replacement.
Alternate Steps to Reproduce:
1. In any file, highlight the text to find.
2. Trigger the `editor.action.startFindReplaceAction` command with the keyboard (`Ctrl+H`).
3. Observe that the originally highlighted text is not highlighted in any way that distinguishes it as the active match or target for replacement.
Example of both Steps and Alternate Steps shown in the following gif. In the gif, you can see that whenever the Find/Find+Replace box is shown, the originally highlighted text is no longer marked as the active match, even though it is the active match.
This is a major problem because there is no way to confirm what the very first replacement will be.
| bug,ux,editor-find | low | Minor |
187,643,167 | nvm | npm is only available in interactive shell | It seems that nvm modifies `~/.bashrc` to load npm and node. This means that non interactive shells that don't run `bashrc` won't have it. For instance I was running a script that calls npm from cron and it was failing because npm was unknown. | installing nvm: profile detection | medium | Critical |
187,730,690 | rust | misleading error message for trait usage from external scope | Trying to implement a trait for a type and then running a unit test produces the following misleading error message.
I tried this code:
```rust
use std::vec::Vec;
mod rlinq {
trait RLINQ {
fn is_where(&self);
}
impl RLINQ for Vec<String> {
fn is_where(&self) {
println!("{:?}", "Vec now implements where");
}
}
}
#[cfg(test)]
mod tests {
use rlinq::RLINQ;
#[test]
fn is_where_test() {
let x: Vec<String> = Vec::new();
x.is_where();
}
}
```
I expected to see this happen: Error letting me know trait was private and unable to be used in current scope
Instead, this happened:
```
help: items from traits can only be used if the trait is in scope; the following trait is implemented but not in scope, perhaps add a `use` for it:
= help: candidate #1: `use rlinq::RLINQ`
```
## Meta
`rustc --version --verbose`:
```
rustc 1.14.0-nightly (7c69b0d5a 2016-11-01)
binary: rustc
commit-hash: 7c69b0d5ae8c404c4847fa214126ebd7c0246277
commit-date: 2016-11-01
host: x86_64-unknown-linux-gnu
release: 1.14.0-nightly
LLVM version: 3.9
```
Backtrace: N/A | C-enhancement,A-diagnostics,T-compiler | low | Critical |
187,740,562 | vscode | Option to render proper scrollbar | The current VS Code scrollbars (both vertical and horizontal) are OK, but I would prefer:
- The scrollbars not to disappear when the mouse stops moving
- The scrollbars to be a bit thicker, thus easier to click
- An up and a down arrow at the top and bottom (or left and right of the horizontal one) to scroll one line per click
- The scrollbar to jump "towards" where you click on empty space either side of the scroll handle, instead of the handle immediately jumping to where the mouse cursor is
In short, they should be like the Visual Studio 2015 scrollbars. Maybe a setting could be introduced to render this more "traditional" type of scrollbar. | feature-request,ux | medium | Critical |
187,756,824 | TypeScript | Code Format with object spread in JavaScript files breaks | _From @oshalygin on November 4, 2016 17:20_
- VSCode Version:
*1.7.1*
- OS Version:
*OSX 10.12.1
Steps to Reproduce:
_userReducer.spec.js_
```javascript
import {
expect
} from "chai";
import * as actionTypes from "../actions/actionTypes";
import reducer from "./userReducer";
describe("Reducer::User", () => {
const getInitialState = () => {
return {};
};
const retrievedResponse = {
data: {
username: "testUser",
firstName: "Foo",
lastName: "Bar",
customData: {
permissions: {
inventory: true
}
}
}
};
it("should retrieve the initial state if the action type is not registered with the reducer", () => {
const action = {
type: "UNKNOWN"
};
const expected = getInitialState();
const actual = reducer(undefined, action); //eslint-disable-line no-undefined
expect(actual).to.deep.equal(expected);
});
it("should retrieve the customData and persist it to the user object", () => {
const action = {
type: actionTypes.USER_SET,
options: retrievedResponse
};
const user = reducer(undefined, action); //eslint-disable-line no-undefined
const actual = user.permissions;
expect(actual).to.exist; //eslint-disable-line no-unused-expressions
});
it("should replace the current state of the user object when USER_SET is dispatched", () => {
const previousState = {
permissions: {
inventory: false
}
};
const futureUserState = {...retrievedResponse,
permissions: { inventory: true } };
const action = {
type: actionTypes.USER_SET,
options: futureUserState
};
const expected = futureUserState.permissions.inventory;
const user = reducer(previousState, action);
const actual = user.permissions.inventory;
expect(actual).to.equal(expected);
});
it("should return an empty user object if the data is null", () => {
const futureUserState = {
data: null
};
const action = {
type: actionTypes.USER_SET,
options: futureUserState
};
const expected = getInitialState();
const actual = reducer(undefined, action); //eslint-disable-line no-undefined
expect(actual).to.deep.equal(expected);
});
});
```
Thats what it looks like unformatted. If I hit the auto format the code will look like this:
```javascript
import {
expect
} from "chai";
import * as actionTypes from "../actions/actionTypes";
import reducer from "./userReducer";
describe("Reducer::User", () => {
const getInitialState = () => {
return {};
};
const retrievedResponse = {
data: {
username: "testUser",
firstName: "Foo",
lastName: "Bar",
customData: {
permissions: {
inventory: true
}
}
}
};
it("should retrieve the initial state if the action type is not registered with the reducer", () => {
const action = {
type: "UNKNOWN"
};
const expected = getInitialState();
const actual = reducer(undefined, action); //eslint-disable-line no-undefined
expect(actual).to.deep.equal(expected);
});
it("should retrieve the customData and persist it to the user object", () => {
const action = {
type: actionTypes.USER_SET,
options: retrievedResponse
};
const user = reducer(undefined, action); //eslint-disable-line no-undefined
const actual = user.permissions;
expect(actual).to.exist; //eslint-disable-line no-unused-expressions
});
it("should replace the current state of the user object when USER_SET is dispatched", () => {
const previousState = {
permissions: {
inventory: false
}
};
const futureUserState = {...retrievedResponse,
permissions: { inventory: true } };
const action = {
type: actionTypes.USER_SET,
options: futureUserState
};
const expected = futureUserState.permissions.inventory;
const user = reducer(previousState, action);
const actual = user.permissions.inventory;
expect(actual).to.equal(expected);
});
it("should return an empty user object if the data is null", () => {
const futureUserState = {
data: null
};
const action = {
type: actionTypes.USER_SET,
options: futureUserState
};
const expected = getInitialState();
const actual = reducer(undefined, action); //eslint-disable-line no-undefined
expect(actual).to.deep.equal(expected);
});
});
```
Notice that after the object spread is used, everything goes sideways
```javascript
const futureUserState = {...retrievedResponse,
permissions: { inventory: true } };
```
TS Version
**2.1.0-dev.20161103**
Trace:
```
[Trace - 10:17:56 AM] Sending request: format (1249). Response expected: yes. Current queue length: 0
Arguments: {
"file": "/Users/admin/dev/myProject/client/reducers/userReducer.spec.js",
"line": 1,
"offset": 1,
"endLine": 91,
"endOffset": 8
}
[Trace - 10:17:56 AM] Response received: format (1249). Request took 5 ms. Success: true
Result: [
{
"start": {
"line": 60,
"offset": 1
},
"end": {
"line": 60,
"offset": 9
},
"newText": ""
},
{
"start": {
"line": 61,
"offset": 1
},
"end": {
"line": 61,
"offset": 13
},
"newText": " "
},
{
"start": {
"line": 62,
"offset": 1
},
"end": {
"line": 62,
"offset": 13
},
"newText": " "
},
{
"start": {
"line": 63,
"offset": 1
},
"end": {
"line": 63,
"offset": 9
},
"newText": ""
},
{
"start": {
"line": 65,
"offset": 1
},
"end": {
"line": 65,
"offset": 9
},
"newText": ""
},
{
"start": {
"line": 67,
"offset": 1
},
"end": {
"line": 67,
"offset": 9
},
"newText": ""
},
{
"start": {
"line": 68,
"offset": 1
},
"end": {
"line": 68,
"offset": 9
},
"newText": ""
},
{
"start": {
"line": 70,
"offset": 1
},
"end": {
"line": 70,
"offset": 9
},
"newText": ""
},
{
"start": {
"line": 74,
"offset": 1
},
"end": {
"line": 74,
"offset": 9
},
"newText": ""
},
{
"start": {
"line": 76,
"offset": 1
},
"end": {
"line": 76,
"offset": 13
},
"newText": " "
},
{
"start": {
"line": 77,
"offset": 1
},
"end": {
"line": 77,
"offset": 17
},
"newText": " "
},
{
"start": {
"line": 78,
"offset": 1
},
"end": {
"line": 78,
"offset": 13
},
"newText": " "
},
{
"start": {
"line": 80,
"offset": 1
},
"end": {
"line": 80,
"offset": 13
},
"newText": " "
},
{
"start": {
"line": 81,
"offset": 1
},
"end": {
"line": 81,
"offset": 17
},
"newText": " "
},
{
"start": {
"line": 82,
"offset": 1
},
"end": {
"line": 82,
"offset": 17
},
"newText": " "
},
{
"start": {
"line": 83,
"offset": 1
},
"end": {
"line": 83,
"offset": 13
},
"newText": " "
},
{
"start": {
"line": 84,
"offset": 1
},
"end": {
"line": 84,
"offset": 13
},
"newText": " "
},
{
"start": {
"line": 85,
"offset": 1
},
"end": {
"line": 85,
"offset": 13
},
"newText": " "
},
{
"start": {
"line": 87,
"offset": 1
},
"end": {
"line": 87,
"offset": 13
},
"newText": " "
},
{
"start": {
"line": 89,
"offset": 1
},
"end": {
"line": 89,
"offset": 9
},
"newText": ""
}
]
[Trace - 10:17:56 AM] Sending request: change (1250). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/admin/dev/myproject/client/reducers/userReducer.spec.js",
"line": 89,
"offset": 1,
"endLine": 89,
"endOffset": 9,
"insertString": ""
}
[Trace - 10:17:56 AM] Sending request: change (1251). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/admin/dev/myproject/client/reducers/userReducer.spec.js",
"line": 87,
"offset": 5,
"endLine": 87,
"endOffset": 13,
"insertString": ""
}
[Trace - 10:17:56 AM] Sending request: change (1252). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/admin/dev/myproject/client/reducers/userReducer.spec.js",
"line": 85,
"offset": 5,
"endLine": 85,
"endOffset": 13,
"insertString": ""
}
[Trace - 10:17:56 AM] Sending request: change (1253). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/admin/dev/myproject/client/reducers/userReducer.spec.js",
"line": 84,
"offset": 5,
"endLine": 84,
"endOffset": 13,
"insertString": ""
}
[Trace - 10:17:56 AM] Sending request: change (1254). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/admin/dev/myproject/client/reducers/userReducer.spec.js",
"line": 83,
"offset": 5,
"endLine": 83,
"endOffset": 13,
"insertString": ""
}
[Trace - 10:17:56 AM] Sending request: change (1255). Response expected: no. Current queue length: 0
Arguments: {
"file": "/Users/admin/dev/myproject/client/reducers/userReducer.spec.js",
"line": 82,
"offset": 9,
"endLine": 82,
"endOffset": 17,
"insertString": ""
}
```
_Copied from original issue: Microsoft/vscode#15006_ | Bug,VS Code Tracked | low | Minor |
187,822,066 | flutter | Document how to do animations at the render object layer | (From Mikkel:)
> It may be helpful to document the preferred approach to animations [at the RenderObject/RenderBox layer].
>
> My current understanding is that when animations (i.e. the lerp values) can be described adequately at the Widget level, that's where animation should be implemented, by arranging for setState on some StatefulWidget to be called at each animation tick.
>
> But sometimes you seem to need to transform between the layouts calculated for your start and end widgets instead. The two cases we have seen involve size-dependent layouts containing animation-relevant information not present at the widget level. That moves animation code into the rendering layer, and it would be nice to have a standard way of accomplishing that. | framework,a: animation,d: api docs,c: proposal,P3,team-framework,triaged-framework | low | Major |
187,822,608 | go | cmd/link: generate manifest in EXE files | On Windows 10 and later, apps can opt into long path support by embedding an XML manifest:
https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx
We should automatically embed this manifest when linking EXE files. For prior art, see this third-party tool for generating a .syso file containing a manifest:
https://github.com/josephspurrier/goversioninfo/commit/f8c5d36fe414d924ff060440f22bf7103278b8b0#diff-88fef3681df95cd75f2ac89251404081
| OS-Windows,NeedsFix,early-in-cycle | medium | Major |
187,849,090 | vscode | Remember undo history on hot-exit | This will make restarts/crashes more and more seamless. | feature-request,workbench-hot-exit,undo-redo | medium | Critical |
187,876,208 | youtube-dl | [edge-apps.net] Site support request (used in ameracatv and TN.com.ar) | There some tv channels like this http://prepublish.f.qaotic.net/epa/ngrp:americatvlive-100056_all/chunklist_b596000.m3u8 , youtube dl send this messege: HTTP error 403 acces denied.Please find some way to download.Thanks | site-support-request | low | Critical |
187,877,841 | go | cmd/compile: implement duffcopy on ppc64x | implement duffcopy on ppc64x.
See TODO in code and stale pending CL https://go-review.googlesource.com/c/9684/ which could be resurrected.
/cc @minux @laboger | Performance,NeedsDecision,compiler/runtime | low | Minor |
187,883,756 | flutter | When InkWell has a GlobalKey and changes position, splash should not stop | null | framework,a: quality,f: gestures,P2,has partial patch,team-design,triaged-design | low | Major |
187,902,934 | rust | demangled characters like { make debugging annoying | (in gdb at least)
I think I complained to @tromey about this already and he proposed a solution, but I'm finding this more and more annoying when debugging that the '{' was chosen demangle to, for closures and impls, e.g.:
`_ZN4clap4args3arg3Arg5short28_$u7b$$u7b$closure$u7d$$u7d$17h7c4595ce99cae01bE`
demangles to:
`clap::args::arg::Arg::short::{{closure}}::h7c4595ce99cae01b`
as it breaks gdb's symbol auto-complete, it's hard to set a breakpoint, print the type, etc.
As I mentioned, I think @tromey suggested how to fix this with certain gdb expressions, or some work around, but I've already forgotten and maybe we should just make it demangle to something different ? :angel: | A-debuginfo,C-enhancement,T-compiler | low | Critical |
187,992,791 | angular | Touch and change event is not propagated to ngModelGroup and ngForm if using separate component | <!--
IF YOU DON'T FILL OUT THE FOLLOWING INFORMATION WE MIGHT CLOSE YOUR ISSUE WITHOUT INVESTIGATING
-->
**I'm submitting a ...** (check one with "x")
```
[x] bug report => search github for a similar issue or PR before submitting
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question
```
**Current behavior**
Only form control is marked as touched and changed
**Expected behavior**
The complete hierarchy should be informed
**Minimal reproduction of the problem with instructions**
http://plnkr.co/edit/2Bj5M2zwOG3vXTauZ9GP?p=preview
**What is the motivation / use case for changing the behavior?**
<!-- Describe the motivation or the concrete use case -->
**Please tell us about your environment:**
<!-- Operating system, IDE, package manager, HTTP server, ... -->
* **Angular version:** 2.1.2
* **Browser:** Chrome 53
* **Language:** TypeScript 2 | workaround1: obvious,freq1: low,area: forms,type: use-case,P4 | low | Critical |
188,098,975 | rust | support `default impl` for specialization | rust-lang/rfcs#1210 included support for `default impl`, which declared a set of defaults that other impls can inherit (if they correspond to a subset of the default impl's types). This was intended as a replacement/improvement of the existing default methods that appear in trait bodies (it was also originally called `partial impl`). Unfortunately, this feature is not yet implemented!
Some things to be sure of:
- [ ] a `default impl` need not include all items from the trait
- [ ] a `default impl` alone does not mean that a type implements the trait
- [x] all items in a `default impl` are (implicitly) `default` and hence specializable
cc https://github.com/rust-lang/rust/issues/31844 | C-enhancement,A-trait-system,T-compiler,A-specialization,E-medium,F-specialization | medium | Critical |
188,123,055 | go | time: optimize time.Time.Sub and time.Since | According to a profiling data from a large number of servers at Google, `time.Time.Sub` is within the top 150 functions by CPU time. The current implementation of `Sub` is not inlineable. The logic for [`Sub` is not particularly complicated](https://github.com/golang/go/blob/2c5bce1cfa242f27ffece3d30e8b851e3e923be2/src/time/time.go#L631-L642) and I believe it can be made to be inlined with some love. | Performance,help wanted | low | Major |
188,127,559 | go | net/url: optimize unescape and escape | According to a profiling data from a large number of servers at Google, URL related functions are among the top 150 functions by CPU time. The simplest optimizations I see are around using LUTs in `shouldEscape`, `isHex`, and `unHex`. | Performance,help wanted | medium | Major |
188,136,195 | go | x/review/git-codereview: handle many-parent merges in hooks | When running the git-codereview hooks on a commit that is (soon to be a child of) a merge of three branches, I get:
```bash
$ git commit
git branch -a --contains 3c49c114ba9e7292b342230a0b238d4684157d2b fce0592992d48cbd5e7ca44724f3f14ee25c0f05
error: malformed object name 3c49c114ba9e7292b342230a0b238d4684157d2b fce0592992d48cbd5e7ca44724f3f14ee25c0f05
...
git-codereview: exit status 129
```
Low priority to fix, but an annoyance.
| NeedsInvestigation | low | Critical |
188,142,629 | go | cmd/compile: elide branches that must be taken | Consider the following two benchmarks:
```go
var sink int
var A, B, C = 1, 2, 3
func BenchmarkA(b *testing.B) {
for i := 0; i < b.N; i++ {
var m int
if A != 0 && B+1 <= C {
m = 0
} else {
panic("never called")
}
sink = m
}
}
func BenchmarkB(b *testing.B) {
for i := 0; i < b.N; i++ {
var m int
if A != 0 && B+1 <= C {
m = 0
} else {
m = -1
}
if m == -1 {
panic("never called")
}
sink = m
}
}
```
On Go 1.8, version A is 25% ~~slower~~ faster than version B. The reason for this is because the compiler actually sets `m = -1` and then does the subsequent conditional check `m == -1`. The compiler should be able to prove that this unnecessary.
Code that looks like this commonly occurs when a smaller inlineable helper is used for a quick path and then a conditional is used to check for a fallback. For example:
```go
m := tryMethod()
if m != -1 {
m = slowMethod()
}
```
This came up in http://golang.org/cl/32921.
/cc @bradfitz @randall77 | Performance,compiler/runtime | low | Major |
188,194,819 | TypeScript | [tsserver] CompileOnSaveEmitFile should returns emited files (js, map, d.ts) path | I'm consumming "CompileOnSaveEmitFile " with tsserver inside Eclipse. It works great and improve a lot of performance (before I called tsc when for each save of file and performance was not very good).
In Eclipse, when a file is created outside Eclipse (like tsserver generates js, map files), the files doesn't appear in the Navigator files of the Eclipse. We must do a refresh at hand.
It should be very cool if CompileOnSaveEmitFile could returns the file path for each generated files. With this feature I could refresh those files inside Eclipse.
| Suggestion,API,Awaiting More Feedback | low | Major |
188,258,515 | youtube-dl | Mashable support | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.08.1*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.08.1**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Site support request (request for adding support for a new site)
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
youtube-dl -v http://mashable.com/2016/11/03/portable-projector-monitor-smartphone/#V23YOtG9ykqi
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://mashable.com/2016/11/03/portable-projector-monitor-smartphone/#V23YOtG9ykqi']
[debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.11.08.1
[debug] Python version 2.7.12 - Linux-4.4.0-45-generic-x86_64-with-Ubuntu-16.04-xenial
[debug] exe versions: ffmpeg 2.8.8-0ubuntu0.16.04.1, ffprobe 2.8.8-0ubuntu0.16.04.1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] #V23YOtG9ykqi: Requesting header
WARNING: Falling back on generic information extractor.
[generic] #V23YOtG9ykqi: Downloading webpage
[generic] #V23YOtG9ykqi: Extracting information
ERROR: Unsupported URL: http://mashable.com/2016/11/03/portable-projector-monitor-smartphone/#V23YOtG9ykqi
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 1636, in _real_extract
doc = compat_etree_fromstring(webpage.encode('utf-8'))
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 2525, in compat_etree_fromstring
doc = _XML(text, parser=etree.XMLParser(target=_TreeBuilder(element_factory=_element_factory)))
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/compat.py", line 2514, in _XML
parser.feed(text)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1653, in feed
self._raiseerror(v)
File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1517, in _raiseerror
raise err
ParseError: not well-formed (invalid token): line 18, column 96
Traceback (most recent call last):
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/YoutubeDL.py", line 694, in extract_info
ie_result = ie.extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/common.py", line 357, in extract
return self._real_extract(url)
File "/usr/local/lib/python2.7/dist-packages/youtube_dl/extractor/generic.py", line 2433, in _real_extract
raise UnsupportedError(url)
UnsupportedError: Unsupported URL: http://mashable.com/2016/11/03/portable-projector-monitor-smartphone/#V23YOtG9ykqi
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: http://mashable.com/2016/05/10/amazon-smart-home-universe/?utm_cid=mash-prod-nav-sub-st
- Single video: http://mashable.com/2016/11/03/portable-projector-monitor-smartphone/#V23YOtG9ykqi
---
| site-support-request | low | Critical |
188,284,305 | go | hash/adler32: optimize on 64-bit architectures | ### What version of Go are you using (`go version`)?
go version go1.7 darwin/amd64
### What operating system and processor architecture are you using (`go env`)?
GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/dev/gocode"
GORACE=""
GOROOT="/opt/local/lib/go"
GOTOOLDIR="/opt/local/lib/go/pkg/tool/darwin_amd64"
CC="/usr/bin/clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
### What did you do?
$ cd /opt/local/lib/go/src/hash/adler32
$ go test -bench .
BenchmarkAdler32KB-8 3000000 519 ns/op 1971.24 MB/s
PASS
### What did you expect to see?
64bit version written in C easily delivers >4GB/s on this machine
### Solution
Use 64bit arithmetics via unsafe.Pointer casting.
NOTE: usage of C style indexing instead of slices in the inner loop also gives a small ~5-10% boost.
### Result
~1.8x improvement if implemented with 64bit arithmetics.
$ go test -bench .
BenchmarkAdler32KB-8 5000000 289 ns/op 3531.85 MB/s
PASS
| Performance,NeedsFix | low | Major |
188,324,586 | youtube-dl | please support NSFW site stream-mydirtyhobby.biz | ```
> youtube-dl http://stream-mydirtyhobby.biz/view/destroyed89-riskantes-pinkeln/i7l7T
[generic] i7l7T: Requesting header
WARNING: Falling back on generic information extractor.
[generic] i7l7T: Downloading webpage
[generic] i7l7T: Extracting information
ERROR: Unsupported URL: http://stream-mydirtyhobby.biz/view/destroyed89-riskantes-pinkeln/i7l7T
```
example URL http://stream-mydirtyhobby.biz/view/destroyed89-riskantes-pinkeln/i7l7T
thanks | site-support-request,nsfw | low | Critical |
188,401,006 | youtube-dl | Unable to download orlandosentinel.com's embedded Flash brightcove videos. | Example:
$ youtube-dl -v http://www.orlandosentinel.com/features/kayla-obrien/91839398-132.html
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.orlandosentinel.com/features/kayla-obrien/91839398-132.html']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.11.08.1
[debug] Python version 3.4.2 - Linux-3.16.0-4-amd64-x86_64-with-debian-8.6
[debug] exe versions: ffmpeg 3.1.4-1, ffprobe 3.1.4-1, rtmpdump 2.4
[debug] Proxy map: {}
[generic] 91839398-132: Requesting header
WARNING: Falling back on generic information extractor.
[generic] 91839398-132: Downloading webpage
[generic] 91839398-132: Extracting information
ERROR: Unsupported URL: http://www.orlandosentinel.com/features/kayla-obrien/91839398-132.html
Traceback (most recent call last):
File "/home/ant/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 694, in extract_info
ie_result = ie.extract(url)
File "/home/ant/bin/youtube-dl/youtube_dl/extractor/common.py", line 357, in extract
return self._real_extract(url)
File "/home/ant/bin/youtube-dl/youtube_dl/extractor/generic.py", line 2433, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: http://www.orlandosentinel.com/features/kayla-obrien/91839398-132.html
Thank you in advance. :) | site-support-request | low | Critical |
188,429,779 | flutter | Having to manage both ends of an AnimationController -> CurvedAnimation chain is a pain | Maybe we should have an object that wraps the two so you can add/remove listeners, forward/reverse, set value, and dispose all at the same time with one object. | framework,a: animation,a: quality,c: proposal,P3,team-framework,triaged-framework | low | Major |
188,825,857 | opencv | Different outcomes when using StereoBM and cuda::StereoBM with same parameters. | ##### System information (version)
- OpenCV => 3.1 (head)
- Windows 10 32+64 Bit
- Compiler => Visual Studio 2013
##### Detailed description
Im currently testing various stereo reconstruction implementations of OpenCV and i get different results for when using the OpenCL version of StereoBM and the cuda version StereoBM. Both should implement the same algorithm, right? Shouldnt they then output the same results given the same input parameters?
For instance when setting the textureThreshold, both implementations seem to use it differently.
The documentation of StereoMatching algorithms totally lack in any information about the parameters and their intended function. In Version 2.4 those parameters are described better.
##### Steps to reproduce
int numberOfDisparities = 256;
int textureThreshold = 10;
int blockSize = 21;
cv::Ptr<cv::StereoBM> bm = cv::StereoBM::create();
bm->setNumDisparities(256);
bm->setTextureThreshold(textureThreshold);
bm->setBlockSize(blockSize);
cv::Ptr<cv::cuda::StereoBM> bmCUDA = cv::cuda::createStereoBM(numberOfDisparities, blockSize);
bmCUDA->setTextureThreshold(textureThreshold);
| bug,category: calib3d,category: gpu/cuda (contrib) | low | Minor |
188,875,173 | You-Dont-Know-JS | You Don't Know JS: Async & Performance Chapter 4: Generators Thunks | It's slightly off topic, but, when discussing 'Thunks' as a concept, and speaking about 'thunkory' functions might it be useful to note that this is essentially the same concept as partial function application?
Not like, a paragraph or anything, but just a short blurb to point out that these terms are more or less the same thing.
It might help folks connect the dots in the future when researching other topics, and it's a pretty useful concept for organizing all kinds of code, not just for organizing asynchronous code. | for second edition | medium | Major |
188,929,095 | TypeScript | Suggestion: Allow Types in JS Files | I have a large Angular2 project written in JavaScript, in which we use [transform-flow-strip-types](https://babeljs.io/docs/plugins/transform-flow-strip-types/) in order to allow Angular2 dependency injection to work from JavaScript.
This is currently an error in a JavaScript file compiled with `tsc`:
```
class MyClass {
prop:string; //err: 'types' can only be used in a .ts file
constructor(x: string) { //err: 'types' can only be used in a .ts file
}
someMethod():string { //err: 'types' can only be used in a .ts file
}
}
```
I would like an `allowTypesInJsFiles` compiler option which would allow us to compile JavaScript files which contain types. All of the above errors would be valid if the flag is set. This would allow us to use Angular2 DI from JavaScript files.
I have a [branch](https://github.com/Microsoft/TypeScript/commit/57a69d880251088d550500dcb018fc4e53895916) with a simple implementation which I have verified to work.
Is this a change which could be accepted? If so I will add tests and sign the CLA.
I think it would be very useful for people migrating large JavaScript projects to TypeScript.
| Suggestion,Awaiting More Feedback | medium | Critical |
188,941,125 | youtube-dl | Use OAuth tokens instead of .netrc where possible | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.08.1*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I’ve **verified** and **I assure** that I'm running youtube-dl **2016.11.08.1**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
---
Currently, the only method to automatically authenticate youtube-dl requests is with a cleartext .netrc file. This is obviously extremely insecure, and I think it would be much better if youtube-dl requested OAuth tokens from supported sites instead.
Alternatively, allow a command to be run before and after accessing .netrc, which would allow the user to encrypt and decrypt the file as they see fit. | request | low | Critical |
188,945,970 | youtube-dl | [CBS.com] Older video wont download | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.08.1*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.08.1**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [x] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
youtube-dl -v http://www.cbs.com/shows/big_bang_theory/video/794877409/the-big-bang-theory-sheldon-s-little-idea/
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.cbs.com/shows/big_bang_theory/video/794877409/the-big-bang-theory-sheldon-s-little-idea/']
[debug] Encodings: locale cp1252, fs mbcs, out cp850, pref cp1252
[debug] youtube-dl version 2016.11.08.1
[debug] Python version 3.4.4 - Windows-7-6.1.7601-SP1
[debug] exe versions: rtmpdump 2.4
[debug] Proxy map: {}
[CBS] 794877409: Downloading XML
[CBS] 794877409: Downloading RTMP SMIL data
[CBS] 794877409: Downloading JSON metadata
[debug] Invoking downloader on 'rtmp://cp48590.edgefcs.net/ondemand/?auth=daEarb
_b9cGapdMbMd7cdaQcybbc.csaxcM-byj8o2-h0-LazNdWld&aifp=v001&slist=video/temp_hd_g
allery_video/CBS_Production/'
[download] Destination: The Big Bang Theory - Sheldon's Little Idea-794877409.fl
v
[debug] rtmpdump command line: rtmpdump --verbose -r 'rtmp://cp48590.edgefcs.net
/ondemand/?auth=daEarb_b9cGapdMbMd7cdaQcybbc.csaxcM-byj8o2-h0-LazNdWld&aifp=v001
&slist=video/temp_hd_gallery_video/CBS_Production/' -o 'The Big Bang Theory - Sh
eldon'"'"'s Little Idea-794877409.flv.part' --playpath mp4:video/temp_hd_gallery
_video/CBS_Production/CBS_BIGBANG_108_CLIP2.flv --resume --skip 1
[rtmpdump] RTMPDump v2.4 GIT-2013-12-05 (Compiled by KSV)
[rtmpdump] (c) 2010 Andrej Stepanchuk, Howard Chu, The Flvstreamer Team; license
: GPL
[rtmpdump] DEBUG: Parsing...
[rtmpdump] DEBUG: Parsed protocol: 0
[rtmpdump] DEBUG: Parsed host : cp48590.edgefcs.net
[rtmpdump] DEBUG: Parsed app : ondemand/?auth=daEarb_b9cGapdMbMd7cdaQcybbc.c
saxcM-byj8o2-h0-LazNdWld&aifp=v001&slist=video/temp_hd_gallery_video/CBS_Product
ion/
[rtmpdump] DEBUG: Number of skipped key frames for resume: 1
[rtmpdump] DEBUG: Protocol : RTMP
[rtmpdump] DEBUG: Hostname : cp48590.edgefcs.net
[rtmpdump] DEBUG: Port : 1935
[rtmpdump] DEBUG: Playpath : mp4:video/temp_hd_gallery_video/CBS_Production/CBS_
BIGBANG_108_CLIP2.flv
[rtmpdump] DEBUG: tcUrl : rtmp://cp48590.edgefcs.net:1935/ondemand/?auth=daEa
rb_b9cGapdMbMd7cdaQcybbc.csaxcM-byj8o2-h0-LazNdWld&aifp=v001&slist=video/temp_hd
_gallery_video/CBS_Production/
[rtmpdump] DEBUG: app : ondemand/?auth=daEarb_b9cGapdMbMd7cdaQcybbc.csaxcM-
byj8o2-h0-LazNdWld&aifp=v001&slist=video/temp_hd_gallery_video/CBS_Production/
[rtmpdump] DEBUG: live : no
[rtmpdump] DEBUG: timeout : 30 sec
[rtmpdump] DEBUG: Setting buffer time to: 36000000ms
[rtmpdump] Connecting ...
[rtmpdump] DEBUG: RTMP_Connect1, ... connected, handshaking
[rtmpdump] DEBUG: HandShake: Type Answer : 03
[rtmpdump] DEBUG: HandShake: Server Uptime : 930983608
[rtmpdump] DEBUG: HandShake: FMS Version : 5.0.7.1
[rtmpdump] DEBUG: HandShake: Handshaking finished....
[rtmpdump] DEBUG: RTMP_Connect1, handshaked
[rtmpdump] DEBUG: Invoking connect
[rtmpdump] INFO: Connected...
[rtmpdump] DEBUG: HandleServerBW: server BW = 1250000
[rtmpdump] DEBUG: HandleClientBW: client BW = 1250000 2
[rtmpdump] DEBUG: HandleChangeChunkSize, received: chunk size change to 4096
[rtmpdump] DEBUG: RTMP_ClientPacket, received: invoke 242 bytes
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: no-name, STRING: _result>
[rtmpdump] DEBUG: Property: <Name: no-name, NUMBER: 1.00>
[rtmpdump] DEBUG: Property: <Name: no-name, OBJECT>
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: fmsVer, STRING: FMS/5,0,7,7054>
[rtmpdump] DEBUG: Property: <Name: capabilities, NUMBER: 127.00>
[rtmpdump] DEBUG: Property: <Name: mode, NUMBER: 1.00>
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: Property: <Name: no-name, OBJECT>
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: level, STRING: status>
[rtmpdump] DEBUG: Property: <Name: code, STRING: NetConnection.Co
nnect.Success>
[rtmpdump] DEBUG: Property: <Name: description, STRING: Connection succe
eded.>
[rtmpdump] DEBUG: Property: <Name: objectEncoding, NUMBER: 3.00>
[rtmpdump] DEBUG: Property: <Name: data, ECMA_ARRAY>
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: version, STRING: 5,0,7,7054>
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: HandleInvoke, server invoking <_result>
[rtmpdump] DEBUG: HandleInvoke, received result for method call <connect>
[rtmpdump] DEBUG: sending ctrl, type: 0x0003
[rtmpdump] DEBUG: Invoking createStream
[rtmpdump] DEBUG: RTMP_ClientPacket, received: invoke 21 bytes
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: no-name, STRING: onBWDone>
[rtmpdump] DEBUG: Property: <Name: no-name, NUMBER: 0.00>
[rtmpdump] DEBUG: Property: NULL
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: HandleInvoke, server invoking <onBWDone>
[rtmpdump] DEBUG: Invoking checkBandwidth
[rtmpdump] DEBUG: RTMP_ClientPacket, received: invoke 29 bytes
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: no-name, STRING: _result>
[rtmpdump] DEBUG: Property: <Name: no-name, NUMBER: 2.00>
[rtmpdump] DEBUG: Property: NULL
[rtmpdump] DEBUG: Property: <Name: no-name, NUMBER: 1.00>
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: HandleInvoke, server invoking <_result>
[rtmpdump] DEBUG: HandleInvoke, received result for method call <createStream>
[rtmpdump] DEBUG: SendPlay, seekTime=0, stopTime=0, sending play: mp4:video/temp
_hd_gallery_video/CBS_Production/CBS_BIGBANG_108_CLIP2.flv
[rtmpdump] DEBUG: Invoking play
[rtmpdump] DEBUG: sending ctrl, type: 0x0003
[rtmpdump] DEBUG: RTMP_ClientPacket, flex message, size 10266 bytes, not fully s
upported
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: no-name, STRING: onBWCheck>
[rtmpdump] DEBUG: Property: <Name: no-name, NUMBER: 2148785893.00>
[rtmpdump] DEBUG: Property: NULL
[rtmpdump] DEBUG: Property: <Name: no-name, STRING: ! v 1 < m N % h
9 n G t % J M p 1 f # t % ^ u ( I ^ ) < 5 : ? @ a V O < S n [ * y N y T e * 3 P
1 F ! 6 # + ( w > W \ - : = ` _ 6 q $ - 0 e x G . ' 4 [ * / 0 / & _ l ] @ k 8
) > i | + & C " ! 6 / D 5 r ; X 9 . g 4 % 6 - 0 Q & a L c b U X i " 7 >
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: HandleInvoke, server invoking <onBWCheck>
[rtmpdump] DEBUG: HandleChangeChunkSize, received: chunk size change to 4096
[rtmpdump] DEBUG: HandleCtrl, received ctrl, type: 0, len: 6
[rtmpdump] DEBUG: HandleCtrl, Stream Begin 1
[rtmpdump] DEBUG: RTMP_ClientPacket, received: invoke 278 bytes
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: no-name, STRING: onStatus>
[rtmpdump] DEBUG: Property: <Name: no-name, NUMBER: 0.00>
[rtmpdump] DEBUG: Property: NULL
[rtmpdump] DEBUG: Property: <Name: no-name, OBJECT>
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: level, STRING: status>
[rtmpdump] DEBUG: Property: <Name: code, STRING: NetStream.Play.R
eset>
[rtmpdump] DEBUG: Property: <Name: description, STRING: Playing and rese
tting video/temp_hd_gallery_video/CBS_Production/CBS_BIGBANG_108_CLIP2.flv.>
[rtmpdump] DEBUG: Property: <Name: details, STRING: video/temp_hd_ga
llery_video/CBS_Production/CBS_BIGBANG_108_CLIP2.flv>
[rtmpdump] DEBUG: Property: <Name: clientid, STRING: rAAnQygA>
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: HandleInvoke, server invoking <onStatus>
[rtmpdump] DEBUG: HandleInvoke, onStatus: NetStream.Play.Reset
[rtmpdump] DEBUG: RTMP_ClientPacket, received: invoke 272 bytes
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: no-name, STRING: onStatus>
[rtmpdump] DEBUG: Property: <Name: no-name, NUMBER: 0.00>
[rtmpdump] DEBUG: Property: NULL
[rtmpdump] DEBUG: Property: <Name: no-name, OBJECT>
[rtmpdump] DEBUG: (object begin)
[rtmpdump] DEBUG: Property: <Name: level, STRING: status>
[rtmpdump] DEBUG: Property: <Name: code, STRING: NetStream.Play.S
tart>
[rtmpdump] DEBUG: Property: <Name: description, STRING: Started playing
video/temp_hd_gallery_video/CBS_Production/CBS_BIGBANG_108_CLIP2.flv.>
[rtmpdump] DEBUG: Property: <Name: details, STRING: video/temp_hd_ga
llery_video/CBS_Production/CBS_BIGBANG_108_CLIP2.flv>
[rtmpdump] DEBUG: Property: <Name: clientid, STRING: rAAnQygA>
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: (object end)
[rtmpdump] DEBUG: HandleInvoke, server invoking <onStatus>
[rtmpdump] DEBUG: HandleInvoke, onStatus: NetStream.Play.Start
[rtmpdump] Starting download at: 0.000 kB
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
---
### Description of your *issue*, suggested solution and other information
So in this issue https://github.com/rg3/youtube-dl/issues/10728 the video wasn't even EXTRACTED properly Now the issue is a but different. It won't DOWNLOAD. The RealTimeMediaProtocol just won't be saved, it gets stuck at connecting. Does somebody know a solution or can somebody fix it?
| geo-restricted | low | Critical |
188,959,200 | rust | Overflow for trait implemented recursively on references | Consider this snippet [[playpen](https://play.rust-lang.org/?gist=6c8dc5378a2b2c3401061024e8937b3f&version=nightly&backtrace=0)]:
```rust
trait Foo {}
impl<'a> Foo for &'a usize {}
// Ok when this impl is commented-out.
impl<'a, T> Foo for &'a Vec<T> where &'a T: Foo {}
fn foo<T>(_: T) where for<'a> &'a T: Foo {}
fn main() {
foo(0);
}
```
```
error[E0275]: overflow evaluating the requirement `_: std::marker::Sized`
--> <anon>:11:5
|
11 | foo(0);
| ^^^
|
= note: consider adding a `#![recursion_limit="128"]` attribute to your crate
= note: required because of the requirements on the impl of `for<'a> Foo` for `&'a std::vec::Vec<_>`
= note: required because of the requirements on the impl of `for<'a> Foo` for `&'a std::vec::Vec<std::vec::Vec<_>>`
= note: required because of the requirements on the impl of `for<'a> Foo` for `&'a std::vec::Vec<std::vec::Vec<std::vec::Vec<_>>>`
[ and so on... ]
= note: required by `foo`
```
There is no issue when trait implementation for `&'a Vec<T>` is commented-out, even though `Vec` isn't actually used anywhere when calling `foo` method. | A-type-system,T-lang,T-compiler,C-bug,T-types | low | Critical |
188,959,746 | youtube-dl | [SoundCloud] Option to limit number of track pages to download | ### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
I could not find any option to limit the amount of track pages to download when requesting a user page on SoundCloud, and of course this gets rather slow when an account has a massive amount of tracks.
as an example
```python
from __future__ import unicode_literals;
import youtube_dl;
ydl_opts = {
"playlistend": 2,
"dateafter": "2016/11/1"
};
with youtube_dl.YoutubeDL(ydl_opts) as ydl:
results = ydl.extract_info(
"http://soundcloud.com/anjunabeats",
download=False
);
print(results);
```
```
[soundcloud:user] anjunabeats: Downloading user info
[soundcloud:user] anjunabeats: Downloading track page 1
[soundcloud:user] anjunabeats: Downloading track page 2
[soundcloud:user] anjunabeats: Downloading track page 3
[soundcloud:user] anjunabeats: Downloading track page 4
[soundcloud:user] anjunabeats: Downloading track page 5
[soundcloud:user] anjunabeats: Downloading track page 6
[soundcloud:user] anjunabeats: Downloading track page 7
[soundcloud:user] anjunabeats: Downloading track page 8
[soundcloud:user] anjunabeats: Downloading track page 9
[soundcloud:user] anjunabeats: Downloading track page 10
[soundcloud:user] anjunabeats: Downloading track page 11
[soundcloud:user] anjunabeats: Downloading track page 12
[soundcloud:user] anjunabeats: Downloading track page 13
[soundcloud:user] anjunabeats: Downloading track page 14
[soundcloud:user] anjunabeats: Downloading track page 15
[soundcloud:user] anjunabeats: Downloading track page 16
[soundcloud:user] anjunabeats: Downloading track page 17
[soundcloud:user] anjunabeats: Downloading track page 18
[soundcloud:user] anjunabeats: Downloading track page 19
[soundcloud:user] anjunabeats: Downloading track page 20
[soundcloud:user] anjunabeats: Downloading track page 21
[soundcloud:user] anjunabeats: Downloading track page 22
```
etc., etc.
I just want some way to limit this to 1 page, as an example, also only looking to extract data. | request | low | Critical |
188,962,074 | vue | Recusive Local Components - Uncaught RangeError: Maximum call stack size exceeded | <!--
中文用户请注意：
1. issue 只接受带重现的 bug 报告，请不要用来提问题！不符合要求的 issue 会被直接关闭。
2. 请尽量用英文描述你的 issue，这样能够让尽可能多的人帮到你。
Got a question?
===============
The issue list of this repo is **exclusively** for bug reports and feature requests. For simple questions, please use the following resources:
- Read the docs: https://vuejs.org/guide/
- Watch video tutorials: https://laracasts.com/series/learning-vue-step-by-step
- Ask in the Gitter chat room: https://gitter.im/vuejs/vue
- Ask on the forums: http://forum.vuejs.org/
- Look for/ask questions on stack overflow: https://stackoverflow.com/questions/ask?tags=vue.js
Reporting a bug?
================
- Try to search for your issue, it may have already been answered or even fixed in the development branch.
- Check if the issue is reproducible with the latest stable version of Vue. If you are using a pre-release, please indicate the specific version you are using.
- It is **required** that you clearly describe the steps necessary to reproduce the issue you are running into. Issues with no clear repro steps will not be triaged. If an issue labeled "need repro" receives no further input from the issue author for more than 5 days, it will be closed.
- It is recommended that you make a JSFiddle/JSBin/Codepen to demonstrate your issue. You could start with [this template](http://jsfiddle.net/5sH6A/) that already includes the latest version of Vue.
- For bugs that involves build setups, you can create a reproduction repository with steps in the README.
- If your issue is resolved but still open, don’t hesitate to close it. In case you found a solution by yourself, it could be helpful to explain how you fixed it.
Have a feature request?
=======================
Remove the template from below and provide thoughtful commentary *and code samples* on what this feature means for your product. What will it allow you to do that you can't do today? How will it make current work-arounds straightforward? What potential bugs and edge cases does it help to avoid? etc. Please keep it product-centric.
-->
<!-- BUG REPORT TEMPLATE -->
### Vue.js version
1.0.28
### Reproduction Link
<!-- A minimal JSBin, JSFiddle, Codepen, or a GitHub repository that can reproduce the bug. -->
<!-- You could start with this template: http://jsfiddle.net/df4Lnuw6/ -->
https://jsfiddle.net/25fdgLgr/3/
### Steps to reproduce
Just run new Vue() or let app demo app load
### What is Expected?
App loads as expected. (btw this does work in vue 2.0, but we are not quite ready to migrate the rest of our app.
### What is actually happening?
JS Error
vue.js:10148 Uncaught RangeError: Maximum call stack size exceeded
at new Function (<anonymous>)
at createClass (https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.28/vue.js:10148:12)
at Function.Vue.extend (https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.28/vue.js:10113:15)
at guardComponents (https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.28/vue.js:1927:31)
at mergeOptions (https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.28/vue.js:2004:3)
at Function.Vue.extend (https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.28/vue.js:10117:19)
at guardComponents (https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.28/vue.js:1927:31)
at mergeOptions (https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.28/vue.js:2004:3)
at Function.Vue.extend (https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.28/vue.js:10117:19)
at guardComponents (https://cdnjs.cloudflare.com/ajax/libs/vue/1.0.28/vue.js:1927:31) | 1.x | low | Critical |
188,963,164 | nvm | Add the ability to use nvm with 32bit releases as well as 64bit | It would be really useful if we could use nvm to install 32bit versions of node so that we could make testing quicker.
Perhaps we could pass in a flag to the end like `nvm install 6 -a x86` or something like that? | installing node,feature requests | medium | Major |
188,988,976 | TypeScript | Allow pass through of class-properties | **TypeScript Version:**
* 2.2.0-dev.20161113 (Not version specific)
* target = esnext, jsx = preserve
**Description**
I expect Typescript to more or less only strip types but preserve the rest - based on the `target` compilerOption. Especially when using a target like `es2017` or even `esnext`.
Class-properties are always moved into the constructor. This prevents hot-reloading of class-property functions when using [react-hot-loader 3](https://github.com/gaearon/react-hot-loader/tree/next).
Using them is a common pattern for binding event-handler functions to `this` without having to do this for every method in the constructor.
**Code**
```tsx
class MyClass {
prop1: number = 123;
handleClick = () => {
console.log('Click handled');
}
render() {
return <button onClick={this.handleClick}>Click me</button>;
}
}
```
**Expected emit:**
```jsx
class MyClass {
prop1 = 123;
handleClick = () => {
console.log('Click handled');
}
render() {
return <button onClick={this.handleClick}>Click me</button>;
}
}
```
**Actual emit:**
```jsx
class MyClass {
constructor() {
super(...arguments);
this.prop1 = 123;
this.handleClick = () => {
console.log('Click handled');
};
}
render() {
return <button onClick={this.handleClick}>Click me</button>;
}
}
```
| Bug,Help Wanted,ES Next | low | Major |
188,996,210 | go | net: implement closeRead and closeWrite on Plan 9 | We should implement closeRead and closeWrite on Plan 9, so the following tests could be enabled:
- TestCloseRead
- TestCloseWrite
- TestClientWriteShutdown (net/http package, see #7237) | OS-Plan9,NeedsInvestigation | low | Major |
189,150,999 | rust | E0495 Does not mention the conflicting requirements | E0495 returns "cannot infer an appropriate lifetime for autoref due to conflicting requirements" and suggest a way to fix this "help: consider using an explicit lifetime parameter..." but it does not say what the conflicting requirements are. This means that if the suggested way to fix it does not work, the user is stuck.
| C-enhancement,A-diagnostics,T-compiler | medium | Major |
189,222,874 | kubernetes | hack/update-all takes forever | There are about 23 update scripts and it is not obvious which ones have to be run for a given PR. These update scripts take anywhere between 20 - 30 minutes on a beefed up machine. I can't imagine running them on a laptop.
We need to either
1. Make the script `hack/update-all.sh` be smart and run only the scripts necessary based on the dirty files in a branch, or
2. Optimize the update-* scripts to run faster.
cc @kubernetes/contributor-experience @thockin @mikedanese @madhusudancs | priority/important-soon,area/build-release,sig/contributor-experience,lifecycle/frozen | medium | Major |
189,226,298 | youtube-dl | vimeo video embedded in iframe on wix site | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.14.1*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.14.1**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ youtube-dl -v http://www.blackandwhiteandsex.com/
[debug] System config: []
[debug] User config: []
[debug] Command-line args: ['-v', 'http://www.blackandwhiteandsex.com/']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2016.11.14.1
[debug] Git HEAD: 6b4dfa2819
[debug] Python version 3.5.2 - Darwin-15.6.0-x86_64-i386-64bit
[debug] exe versions: none
[debug] Proxy map: {}
[generic] www.blackandwhiteandsex: Requesting header
WARNING: Falling back on generic information extractor.
[generic] www.blackandwhiteandsex: Downloading webpage
[generic] www.blackandwhiteandsex: Extracting information
ERROR: Unsupported URL: http://www.blackandwhiteandsex.com/
Traceback (most recent call last):
File "/Users/nlevitt/workspace/youtube-dl/youtube_dl/YoutubeDL.py", line 694, in extract_info
ie_result = ie.extract(url)
File "/Users/nlevitt/workspace/youtube-dl/youtube_dl/extractor/common.py", line 357, in extract
return self._real_extract(url)
File "/Users/nlevitt/workspace/youtube-dl/youtube_dl/extractor/generic.py", line 2433, in _real_extract
raise UnsupportedError(url)
youtube_dl.utils.UnsupportedError: Unsupported URL: http://www.blackandwhiteandsex.com/
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
Just one url:
http://www.blackandwhiteandsex.com/
Single plage site with more than one tab with embedded vimeo videos.
---
### Description of your *issue*, suggested solution and other information
http://www.blackandwhiteandsex.com/
is a single-page wix.com site with vimeo videos embedded in iframes, under the "trailer" table and "the angies" tab. The iframe is inserted by some javascript. The videos are specified in json files like this:
https://static.wixstatic.com/sites/dbdeea_51ac6c3b06f8f100f3ba997173abde97_166.json.z?v=3
```
"videoId":"183444182","videoType":"VIMEO"
```
I don't know for sure if this is a generic wix.com thing but I suspect it is. I am curious if you guys will deem this feasible for youtube-dl to support. | site-support-request | low | Critical |
189,360,421 | go | cmd/compile: insertVarPhis is very slow | go version devel +b687d6a Tue Nov 15 05:35:54 2016 +0000 linux/amd64
My real package takes 30+ seconds to compile.
Using program generator below:
With 500 iterations:
compilation time 0.79s
phiState.insertVarPhis takes 8.27%
With 1000 iterations:
compilation time 1.54s
phiState.insertVarPhis takes 11.84%
With 2000 iterations:
compilation time 3.65s
phiState.insertVarPhis takes 15.75%
With 4000 iterations:
compilation time 10.63s
phiState.insertVarPhis takes 20.94%
With 8000 iterations:
compilation time 26.03s
phiState.insertVarPhis takes 32.16%
With 16000 iterations:
compilation time 101.91s
phiState.insertVarPhis takes 53.08%
```go
package main
func main() {
println(`package a
type T struct {
a []*Y
}
type Y struct {
name string
i *T
}
var m = make(map[string]*T)
func a() {`)
for i := 0; i < 16000; i++ {
println("{ s := m[\"foo\"]")
println("s.a = append(s.a, &Y{name: \"foo\", i: m[\"foo\"]})")
println("}")
}
println("}")
}
```
insertVarPhis executes inner loop millions of times without doing anything (variable is dead)
compile also consumes 5GB of memory (150KB per statement), which causes compilation on weak VM to never succeed due to OOM kills
Please make it faster and consume less memory. | ToolSpeed,compiler/runtime | low | Major |
189,415,646 | youtube-dl | Function to limit duration and/or size (for livestreams) | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.14.1*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.14.1**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [x] Feature request (request for a new functionality)
- [x] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
As said in the title youtube-dl is missing any function/parameter to limit the duration and/or the size.
I tried livestreamer before but it did not work at all with the livestream I was recording so I switched to youtube-dl (sorry for that much offtopic). That stream is running 24/7 without any break or so. But they change the title if another content/show starts (e.g. 10min 'news' then 30min 'talk' just a general example). Unfortunately there is also no way to only get audio for a livestream tho I think it should be at least possible to save only audio directly (but still receiving video+audio just drop the video and save only audio). I know there is '-x' but only for postprocessing that means I need to finish a download which will never happen with a 24/7 livestream. It would be nice to have an option to set a limit on the duration but more preferable at least the size.
Let's say we have an option like '--maxdl-filesize SIZE' -> '--maxdl-filesize 10.0m'
this will save the output so far into a file (it's best to use template then to get timecode/length).
I cannot say how difficulty it would be to make a prototype for that (I would do that on my own but I am also in lack of time). The best thing I thought about would be using a script that collects the information about the length of the shows then let it send ctrl-c to stop the download but before that already start a new youtube-dl process since it takes a little time for a new process to start the download. This would not be a perfect solution but a quick'n'dirty one. I haven't tested yet to continuously download the stream and directly use it while downloading in e.g. ffmpeg to split it into parts and as audio only (I am relating to this option --hls-use-mpegts).
Edit: Youtube is using Fragments. Maybe it's possible to start off with those at least. | request | low | Critical |
189,441,276 | opencv | Check for existence of CUDA driver before calling cuda functions | After fighting for a while with the well-known CUDA error message `CUDA driver version is insufficient for CUDA runtime version`, today I learned that this message will be returned by Nvidia even when there is no driver installed at all, which is totally misleading.
Consider this code
```c++
#include <cuda_runtime.h>
...
int driverVersion = 0;
int runtimeVersion = 0;
cudaError_t error_id;
error_id = cudaDriverGetVersion(&driverVersion);
if (error_id != cudaSuccess)
{
printf("cudaDriverGetVersion returned %d\n-> %s\n", (int)error_id, cudaGetErrorString(error_id));
printf("Result = FAIL\n");
exit(EXIT_FAILURE);
}
std::cout << "CUDA driver version: " << driverVersion << std::endl;
error_id = cudaRuntimeGetVersion(&runtimeVersion);
if (error_id != cudaSuccess)
{
printf("cudaRuntimeGetVersion returned %d\n-> %s\n", (int)error_id, cudaGetErrorString(error_id));
printf("Result = FAIL\n");
exit(EXIT_FAILURE);
}
std::cout << "CUDA runtime version: " << runtimeVersion << std::endl;
```
When no driver can be found, this code will print:
```
CUDA driver version: 0
cudaRuntimeGetVersion returned 35
-> CUDA driver version is insufficient for CUDA runtime version
Result = FAIL
```
This agrees with the [docs](http://docs.nvidia.com/cuda/cuda-runtime-api/group__CUDART____VERSION.html#group__CUDART____VERSION_1g8a06ee14a0551606b7c780084d5564ab):
> If no driver is installed, then 0 is returned as the driver version
--
I propose that all OpenCV Cuda functions (or error handlers) use `cudaDriverGetVersion` to check whether a driver is installed _at all_, and if not, say so, to compensate for the very misleading error message Nvidia is giving us in this case, making you play around with driver versions when in fact any driver you install can't be found at all.
This should save a lot of github issues and stackoverflow questions :) | feature,priority: low,category: gpu/cuda (contrib) | low | Critical |
189,737,461 | opencv | Second interface function for findCirclesGrid | The opencv function findCirclesGrid expects an image as input parameter. The first processing step within the function is to extract a list of points via blobDetector and afterwards the function uses only this list of points.
For various purposes like searching for the pattern only in part of the image or for iterative refinement it would be very useful to have a second findCirclesGrid function which accents an InputArray containing such list of points instead of an image.
My suggestion is to put the code starting at https://github.com/opencv/opencv/blob/73e1d64ae07be010a2c64e6906d0e938846c6bef/modules/calib3d/src/calibinit.cpp#L2115 in a second function e.g. findCirclesGridPointList(InputArray _pointList, Size patternSize, OutputArray _centers, int flags)
and let the current findCirclesGrid call this function. The only additional code required is code which converts from the InputArray _pointList to std::vector<Point2f>.
With this splitting one gains a lot of flexibility for a tiny bit of processing overhead. | feature,category: calib3d | low | Minor |
189,901,409 | vscode | Simple way to temporarily turn off exclusions for QuickOpen files | Using a transpiled language I sometimes find the need to look at the transpiled code which typically is excluded from QuickOpen. Having a simple way to turn exclusions off would simplify this. Some options come to mind:
- Have a 'Turn Off Exclusions' entry at the end of the results list.
- Have an additional QuickOpen prefix that runs QuickOpen with exclusions turned off.
- Have an option toggle next to the QuickOpen entry field to turn exclusions off.
| help wanted,feature-request,search,quick-open | high | Critical |
190,029,765 | opencv | Build fails WITH_OPENVX=YES if precompiled headers are enabled that is by default | ##### System information (version)
- OpenCV => master, 3.1.0-1694-ga19cb20
- Operating System / Platform => Linux-x64, Ubuntu 16.04
- Compiler => gcc-5.4.0 20160609
##### Detailed description
OpenCV build fails if configured to use OpenVX with precompiled headers enabled (that is default).
##### Steps to reproduce
```bash
$ cmake -DOPENVX_ROOT=/home/andreypa/Dev/OpenVX/vx++/_build/install/OpenVX-Linux -DWITH_OPENVX=YES ../opencv
$ make
...
Scanning dependencies of target openvx_hal
[ 25%] Building CXX object 3rdparty/openvx/CMakeFiles/openvx_hal.dir/src/openvx_hal.cpp.o
[ 26%] Linking CXX static library ../lib/libopenvx_hal.a
[ 26%] Built target openvx_hal
Scanning dependencies of target opencv_core_pch_dephelp
[ 26%] Building CXX object modules/core/CMakeFiles/opencv_core_pch_dephelp.dir/opencv_core_pch_dephelp.cxx.o
In file included from /home/andreypa/Dev/OpenCV/opencv-build2/custom_hal.hpp:5:0,
from /home/andreypa/Dev/OpenCV/opencv/modules/core/src/hal_replacement.hpp:725,
from /home/andreypa/Dev/OpenCV/opencv/modules/core/src/precomp.hpp:89,
from /home/andreypa/Dev/OpenCV/opencv-build2/modules/core/opencv_core_pch_dephelp.cxx:1:
/home/andreypa/Dev/OpenCV/opencv/3rdparty/openvx/include/openvx_hal.hpp:5:43: fatal error: opencv2/imgproc/hal/interface.h: No such file or directory
compilation terminated.
```
This can be workarounded by adding `-DENABLE_PRECOMPILED_HEADERS=NO` option to `cmake` though. | bug,category: build/install,affected: 3.4 | low | Critical |
190,031,474 | opencv | Inconsistent convention for cmake option specifying OpenVX location | ##### System information (version)
- OpenCV => 3.1.0-1694-ga19cb20
- Operating System / Platform => any
- Compiler => any
##### Detailed description
Currently to specify OpenVX location for cmake the following options are required:
`-DOPENVX_ROOT=/path/to/prebuilt/openvx -DWITH_OPENVX=YES`,
while the more common variable name would be `-DOpenVX_DIR=/path/to/prebuilt/openvx`.
I suggest changing this until people get used to the bad name.
| feature,priority: low,category: build/install,affected: 3.4 | low | Minor |
190,179,388 | go | runtime: aggressive GC completion is disruptive to co-tenants | ### What version of Go are you using (`go version`)?
go version `devel +1e3c57c Wed Nov 16 20:31:40 2016 +0000` with CL 33093 PS 4 cherry-picked on top, with GOEXPERIMENT=preemptibleloops
### What operating system and processor architecture are you using (`go env`)?
linux/amd64
### What did you do?
I have a program that reads ~1MB records from stdin, decodes the records, and sends UDP datagrams. The program runs with around 20 goroutines. Around 40 copies of the program run on an 8-core host.
### What did you expect to see?
I expected the 95th percentile of mark termination and sweep termination pauses to be 100µs or less.
### What did you see instead?
The program's 95th percentile sweep termination time is around 60ms, and 95th percentile mark termination time is around 30ms. Here's an example gctrace line:
```
gc 11249 @74577.976s 0%: 11+185+35 ms clock, 90+143/358/582+280 ms cpu, 112->114->56 MB, 115 MB goal, 8 P
```
The mark termination pauses are very easy to identify in the execution trace—if this bug needs to be about either sweep term pauses or mark term pauses, let's use it for mark term.
Sweep termination pause distribution:
```
N 10000 sum 115454 mean 11.5454 gmean 0.602555 std dev 22.7221 variance 516.294
min 0.011
1%ile 0.014
5%ile 0.016
25%ile 0.023
median 0.34
75%ile 12
95%ile 59
99%ile 107
max 199
⠀⠀⠀⠀⠀⠀⠰⡄⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⡖ 0.274
⠀⠀⠀⠀⠀⠀⡂⠄⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⡇
⠠⠤⠤⠤⠤⠤⠄⠰⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠄⠧ 0.000
⠈⠉⠉⠉⠉⠉⠙⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠙⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠙⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠁
0 50 100
```
Mark termination pause distribution:
```
N 10000 sum 61391.3 mean 6.13913 gmean 0.93492 std dev 12.9254 variance 167.066
min 0.04
1%ile 0.053
5%ile 0.064
25%ile 0.1
median 0.82
75%ile 6.6
95%ile 29
99%ile 64
max 209
⠀⠀⠀⠀⠀⠀⠰⡀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⡖ 0.447
⠀⠀⠀⠀⠀⠀⡁⠄⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⡇
⠠⠤⠤⠤⠤⠤⠄⠑⠒⠦⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠤⠄⠧ 0.000
⠈⠉⠉⠉⠉⠉⠙⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠋⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠉⠁
0 50
```
And here's the execution trace of a slow mark termination pause, taking over 16ms. Proc 6 organizes the mark termination phase. Procs 1, 2, 3, 4, and 5 execute it quickly at around t=1007ms. Proc 0 does mark termination around t=1014ms, and Proc 7 delays until t=1024ms at which point the global pause concludes.
<img width="1651" alt="screen shot 2016-11-17 at 1 58 11 pm" src="https://cloud.githubusercontent.com/assets/230685/20410040/14b8049c-acd0-11e6-856c-40548a9ca0be.png">
| Performance,NeedsInvestigation,early-in-cycle | medium | Critical |
190,183,211 | javascript | Add high-level theory/guiding principles | Most people don't have the time or energy to read through the entire style guide and internalize it. Additionally, there are always going to be gaps that we haven't explicitly handled.
For both of these cases, I think it would be nice to add a few concise guiding principles to the document. This would allow people to essentially "memorize these 6 ideas and you will know what to do 99% of the time."
I don't know what these principles are or should be, but I figured I would get the discussion started here. | question,editorial | low | Minor |
190,192,567 | gin | Provide guideline on how to write good middleware | There have been at least a couple of discussions in the past about good error handling strategies in middleware (see #665 and #274). It would be great if the outcome of those discussions would be summarized in the documentation...perhaps under **Custom Middleware** in the README file?
| document | low | Critical |
190,206,474 | go | sync: RWMutex scales poorly with CPU count | On a machine with many cores, the performance of `sync.RWMutex.R{Lock,Unlock}` degrades dramatically as `GOMAXPROCS` increases.
This test program:
```go
package benchmarks_test
import (
"fmt"
"sync"
"testing"
)
func BenchmarkRWMutex(b *testing.B) {
for ng := 1; ng <= 256; ng <<= 2 {
b.Run(fmt.Sprint(ng), func(b *testing.B) {
var mu sync.RWMutex
mu.Lock()
var wg sync.WaitGroup
wg.Add(ng)
n := b.N
quota := n / ng
for g := ng; g > 0; g-- {
if g == 1 {
quota = n
}
go func(quota int) {
for i := 0; i < quota; i++ {
mu.RLock()
mu.RUnlock()
}
wg.Done()
}(quota)
n -= quota
}
if n != 0 {
b.Fatalf("Incorrect quota assignments: %v remaining", n)
}
b.StartTimer()
mu.Unlock()
wg.Wait()
b.StopTimer()
})
}
}
```
degrades by a factor of 8x as it saturates threads and cores, presumably due to cache contention on &rw.readerCount:
```
# ./benchmarks.test -test.bench . -test.cpu 1,4,16,64
testing: warning: no tests to run
BenchmarkRWMutex/1 20000000 72.6 ns/op
BenchmarkRWMutex/1-4 20000000 72.4 ns/op
BenchmarkRWMutex/1-16 20000000 72.8 ns/op
BenchmarkRWMutex/1-64 20000000 72.5 ns/op
BenchmarkRWMutex/4 20000000 72.6 ns/op
BenchmarkRWMutex/4-4 20000000 105 ns/op
BenchmarkRWMutex/4-16 10000000 130 ns/op
BenchmarkRWMutex/4-64 20000000 160 ns/op
BenchmarkRWMutex/16 20000000 72.4 ns/op
BenchmarkRWMutex/16-4 10000000 125 ns/op
BenchmarkRWMutex/16-16 10000000 263 ns/op
BenchmarkRWMutex/16-64 5000000 287 ns/op
BenchmarkRWMutex/64 20000000 72.6 ns/op
BenchmarkRWMutex/64-4 10000000 137 ns/op
BenchmarkRWMutex/64-16 5000000 306 ns/op
BenchmarkRWMutex/64-64 3000000 517 ns/op
BenchmarkRWMutex/256 20000000 72.4 ns/op
BenchmarkRWMutex/256-4 20000000 137 ns/op
BenchmarkRWMutex/256-16 5000000 280 ns/op
BenchmarkRWMutex/256-64 3000000 602 ns/op
PASS
```
A "control" test, calling a no-op function instead of `RWMutex` methods, displays no such degradation: the problem does not appear to be due to runtime scheduling overhead. | Performance,NeedsFix,compiler/runtime | high | Major |
190,210,993 | angular | Allow disabling NgControlStatus | **I'm submitting a ...**
```
[ ] bug report
[x] feature request
[ ] support request
```
**Current behavior**
`NgControlStatus` is applied automatically to any form control/group.
**Expected behavior**
Should be able to opt out of this directive. Maybe as simple as adding a `:not([ngNoControlStatus])` to the selector?
**Minimal reproduction of the problem with instructions**
**What is the motivation / use case for changing the behavior?**
We don't use the default `.ng-xxxxx` status classes, so it'd be nice to disable them (and the associated pointless DOM changes they bring).
**Please tell us about your environment:**
* **Angular version:** 2.1.1 but pretty sure this is the current behavior too.
* **Browser:** all
* **Language:** n/a
* **Node (for AoT issues):** n/a
| feature,area: forms,feature: under consideration | low | Critical |
190,301,896 | youtube-dl | add youtube_dl wiki | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.18*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [ x] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.18**
### Before submitting an *issue* make sure you have:
- [ x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [ ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [ ] Site support request (request for adding support for a new site)
- [ x] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
$ youtube-dl -v <your command line>
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2016.11.18
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
...
<end of log>
```
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
---
### Description of your *issue*, suggested solution and other information
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
I would request @rg3 or the developers to enable the wikis part , so that the maintainers/developers/others/me could add wiki based on this project or similar projects using youtube_dl as an sub fork on their project .
This is as I am going to release the next version (v0.0.2) https://github.com/siddht1/youtube_dl_java/tree/master/0.0.2 which uses this project as a sub fork . https://github.com/rg3/youtube-dl/issues/10975 | documentation | low | Critical |
190,422,623 | youtube-dl | Chew.TV site request | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.18*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [X] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.18**
### Before submitting an *issue* make sure you have:
- [X ] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [X ] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [X ] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### The following sections concretize particular purposed issues, you can erase any section (the contents between triple ---) not applicable to your *issue*
---
### If the purpose of this *issue* is a *bug report*, *site support request* or you are not completely sure provide the full verbose output as follows:
Add `-v` flag to **your command line** you run youtube-dl with, copy the **whole** output and insert it here. It should look similar to one below (replace it with **your** log inserted between triple ```):
```
Can't see output because of both
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included (replace following example URLs by **yours**):
- Single video: https://www.youtube.com/watch?v=BaW_jenozKc
- Single video: https://youtu.be/BaW_jenozKc
- Playlist: https://www.youtube.com/playlist?list=PL4lCao7KL_QFVb7Iudeipvc2BCavECqzc
So I am trying to use the player to play Chew.TV streams. And it seems to work for some and not all. For instance, If I use https://chew.tv/echobreaker/spin-chill Works fine. But, if I use https://chew.tv/millar/practice, the player freaks out, and refers it to a completely unrelated youtube link. If it could work with all Chew streams, that would be awesome.
---
### Description of your *issue*, suggested solution and other information
So I am trying to use the player to play Chew.TV streams. And it seems to work for some and not all. For instance, If I use https://chew.tv/echobreaker/spin-chill Works fine. But, if I use https://chew.tv/millar/practice, the player freaks out, and refers it to a completely unrelated youtube link. If it could work with all Chew streams, that would be awesome.
Explanation of your *issue* in arbitrary form goes here. Please make sure the [description is worded well enough to be understood](https://github.com/rg3/youtube-dl#is-the-description-of-the-issue-itself-sufficient). Provide as much context and examples as possible.
If work on your *issue* requires account credentials please provide them or explain how one can obtain them.
| site-support-request | low | Critical |
190,438,054 | vscode | Allow code to open directories in nautilus file manager | - VSCode Version: 1.7.1
- OS Version: Ubuntu 16.04
The nautilus file manager in Ubuntu and other GNOME-based Linux distros has a right click "Open with" option available for opening files and or directories. Currently, vscode supports open with for text files but not directories. Since I often open code repositories with vscode, it would be nice to be able to right click and select "open with ... " and then chose "code" to open a new instance of vscode using the directory.
Steps to Reproduce:
1. In nautilus, choose a folder. Right click and select "open with" submenu
2. Visual Studio Code is not listed in submenu.
If you repeat above with a plain text file, it works.
Nautilus uses the MimeType defined in the *.desktop file for associating applications with a particular file type. For directories, the desired mime-type is inode/directory. Simply changing the following line in code.desktop from
`MimeType=text/plain;`
to
`MimeType=text/plain;inode/directory;`
should suffice (though it may be necessary to log in/log out to have change take effect ... alternatively running update-desktop-database and restarting nautilus may work.
| linux,under-discussion,workbench-os-integration | low | Major |
190,438,168 | rust | std::process::Command's current_dir behaves differently on Unix and Windows, with respect to relative exe paths | On Unix, relative paths to the exe are interpreted after cd'ing to the `current_dir`, but on Windows they're interpreted before. Here's an example test (1 test file, and 1 little binary that the test needs to build) that demonstrates this if you run `cargo test` on the two different platforms:
#### src/lib.rs
```rust
#[test]
fn execute_binary_from_another_dir() {
// Run `cargo build` to make sure the associated `foo` binary gets built.
std::process::Command::new("cargo").arg("build").status().unwrap();
// Shell out to `foo`, just to confirm that this works fine.
std::process::Command::new("target/debug/foo")
.status()
.unwrap();
// Now try to shell out to `foo` again while also setting the current_dir.
// This fails on Unix, because the path to the binary is resolved *after*
// changing directories, but it works on Windows.
std::process::Command::new("target/debug/foo")
.current_dir("..")
.status()
.unwrap();
}
```
#### src/bin/foo.rs
```rust
fn main() {
println!("foo!");
}
```
I ran into a similar difference when I tried this with Python's `subprocess.run(..., cwd=...)`. It looks like it's an artifact of Windows supporting [an `lpCurrentDirectory` arg](https://msdn.microsoft.com/en-us/library/windows/desktop/ms682425(v=vs.85).aspx) natively, while Unix has to `fork` and then `chdir` in the child before it calls `exec`. I prefer the semantics that we're getting on Windows right now\*, but this issue is mainly that they're not the same.
\* My main reason for preferring the current-Windows-style "`current_dir` does not affect the exe location" semantics: Emulating the current-Unix-style only requires a `Path::join`, which always works. But going the other way requires a `Path::canonicalize`, which can fail. | T-libs-api,C-feature-request,A-process | low | Critical |
190,498,121 | youtube-dl | SoundCloud Charts | ### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.18*.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.18**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
---
### If the purpose of this *issue* is a *site support request* please provide all kinds of example URLs support for which should be included:
- Playlist: https://soundcloud.com/charts
- Playlist: https://soundcloud.com/charts/top
- Playlist: https://soundcloud.com/charts/new
- Playlist: https://soundcloud.com/charts/top?genre=trap
- Playlist: https://soundcloud.com/charts/new?genre=trap
---
### Description of your *issue*, suggested solution and other information
Can you please add support for downloading [SoundCloud Charts](https://soundcloud.com/charts)? | request | low | Critical |
190,515,226 | youtube-dl | People.com PEN Site Request | ## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like that [x])
- Use *Preview* tab to see how your issue will actually look like
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2016.11.18*. If it's not read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues with outdated version will be rejected.
- [x] I've **verified** and **I assure** that I'm running youtube-dl **2016.11.18**
### Before submitting an *issue* make sure you have:
- [x] At least skimmed through [README](https://github.com/rg3/youtube-dl/blob/master/README.md) and **most notably** [FAQ](https://github.com/rg3/youtube-dl#faq) and [BUGS](https://github.com/rg3/youtube-dl#bugs) sections
- [x] [Searched](https://github.com/rg3/youtube-dl/search?type=Issues) the bugtracker for similar issues including closed ones
### What is the purpose of your *issue*?
- [ ] Bug report (encountered problems with youtube-dl)
- [x] Site support request (request for adding support for a new site)
- [ ] Feature request (request for a new functionality)
- [ ] Question
- [ ] Other
Would love to be able to download video from http://people.com/pen-shows/
Example: http://people.com/pen/00000156-7b90-d970-ad76-7bd0a6cf0000/ | site-support-request | low | Critical |
190,550,434 | rust | Using `type` with local type parameters has confusing error | Using `type` with local type parameters or `Self` should have a clearer error.
Reproduce with: [(playpen link)](https://play.rust-lang.org/?gist=a93fa3b44bc0c638b06f3d6975e57c36&version=nightly&backtrace=0)
```rust
struct Foo;
impl Foo {
fn method<T>(&self) {
type X = (Self, T);
}
}
```
Current errors have a suggestion ("try..") that doesn't apply.
```rust
error[E0401]: can't use type parameters from outer function; try using a local type parameter instead
--> <anon>:6:19
|
6 | type X = (Self, T);
| ^^^^ use of type variable from outer function
error[E0401]: can't use type parameters from outer function; try using a local type parameter instead
--> <anon>:6:25
|
6 | type X = (Self, T);
| ^ use of type variable from outer function
```
| C-enhancement,A-diagnostics,A-associated-items,T-compiler,D-papercut | low | Critical |
190,569,873 | youtube-dl | Fix dts in f4m | If I record BBC1 live with
```
youtube-dl 'http://a.files.bbci.co.uk/media/live/manifesto/audio_video/simulcast/hds/uk/pc/llnw/bbc_one_hd.f4m'
```
and play the result with mpv, ~I get quite a few dropped frames (with vaapi playback)~ (it seems the display driver was to blame here). The reason seems to be problems with the dts. I get a lot of those in the log:
```
[ffmpeg/demuxer] mpegts: Invalid timestamps stream=1, pts=325395000, dts=325396800, size=4790
[ffmpeg/demuxer] mpegts: Invalid timestamps stream=1, pts=325398600, dts=325400400, size=5048
```
I understand that fixing those on the fly is not easy, but probably better than to rely on the decoder to cope with "interesting" input (~vaapi decoding is not the only one~, streamcopy to mkv with ffmpeg doesn't work at all). | geo-restricted | low | Minor |
190,584,172 | rust | Expand macro parameters in the comments. | ```rust
macro_rules! test {
(name:ident) => {
/// A struct named $name.
struct $name;
}
}
``` | A-macros,C-feature-request | low | Major |
190,589,610 | create-react-app | Provide a watching build mode that writes to the disk in development | See https://github.com/facebookincubator/create-react-app/issues/1018#issuecomment-261792488 for a discussion which leads to the creation of this issue.
I propose adding a new command (working name `build-dev`) which watches for changes and rebuild the bundle (effectively, given the current CRA implementation, it should execute `webpack --watch`), then writes it onto filesystem.
The main motivation is an easier integration path with non-Node.js dev servers: such servers could just serve continuously updating bundle from the filesystem.
The only desired configuration options is an `--output`, which could probably be specified via a command line argument:
```
% npm run build-dev -- --output ../static/www
```
Alternative command name suggestions:
* `watch`
* `build-watch` | issue: proposal | high | Critical |
190,628,657 | TypeScript | Treating `undefined` parameters as optional | tsc: 2.2.0-dev.20161116
Discover this behavior from https://github.com/acdlite/flux-standard-action/pull/45/commits/78a9065914b2ca4848dfba8fc0b47c54e2d0e319
This is the original code:
```ts
export interface FSA<Payload, Meta> {
...
payload?: Payload;
...
}
```
However, this does not work well with type guard:
```ts
function isSomeAction(action: any): action is FSA<{ message: string }, void> {
return true;
}
let action = {...};
if (isSomeAction(action)) {
// `action.payload` may be undefined.
console.log(action.payload.message);
}
```
Since generic type can be anything, including `undefined`, I'm considering to remove the optional designation:
```ts
export interface FSA<Payload, Meta> {
...
payload: Payload;
...
}
// now type guard works
let action = {...};
if (isSomeAction(action)) {
console.log(action.payload.message);
}
```
However, now the creation code fail:
```ts
function createSomeAction(): FSA<undefined, undefined> {
// error: `payload` and `meta` are required
return { type: 'SOME_ACTION' };
}
```
The workaround is to depends on infer type:
```ts
function createSomeAction() {
return { type: 'SOME_ACTION' };
}
```
or specify it:
```ts
function createSomeAction(): FSA<undefined, undefined> {
return {
type: 'SOME_ACTION',
payload: undefined,
meta: undefined
};
}
```
Is there a better solution? 🌷 | Suggestion,Help Wanted,Committed | high | Critical |
190,647,465 | awesome-mac | 推荐自己开发的几个 macOS 小工具 | 以下几个都是自己开发的小工具，对需要的用户来说，还比较受欢迎（Mac App Store 4~5 星），所以有点底气来自荐。
中文描述：
- [iPic](http://toolinbox.net/iPic/) - 图床神器：快速上传图片；支持 Markdown；支持七牛、又拍、阿里云等图床
- 注：已经被收录， 请帮忙更新下描述
- [iPaste](http://toolinbox.net/iPaste) - 简洁高效的剪切板神器
- [iHosts](http://toolinbox.net/iHosts) - 唯一上架 Mac App Store 的 /etc/hosts 编辑神器
- 注：曾被 Mac App Store 中国区编辑推荐，最高排名开发者分类第 2 名
- [iTimer](http://toolinbox.net/iTimer) - 简洁的番茄工作法计时器
英文描述：
- [iPic](http://toolinbox.net/en/iPic/) - Easily Upload Images With Markdown Supported
- 注：目前收录的描述说没有英文介绍，其实是有英文描述的
- [iPaste](http://toolinbox.net/en/iPaste) - Lightweight and Efficient Clipboard Tool
- [iHosts](http://toolinbox.net/en/iHosts) - The only /etc/hosts editor on Mac App Store
- [iTimer](http://toolinbox.net/en/iTimer) - Lightweight Pomodoro Timer
| vote | low | Major |
190,674,801 | TypeScript | error TS5053: Option 'declarationDir' cannot be specified with option 'outFile'. | Attempting to change the declaration file output directory, I get the following error:
> error TS5053: Option 'declarationDir' cannot be specified with option 'outFile'.
`tsconfig.json` looks like this:
```
{
"$schema": "http://json.schemastore.org/tsconfig",
"compilerOptions": {
"module": "amd",
"target": "es6",
"outFile": "../assets/js/main.js",
"sourceMap": true,
"declaration": true,
"declarationDir": "../"
}
}
```
I want my `.d.ts` file emitted somewhere else, since that's not a public asset.
Why is this not permitted?
I'm forced to create two (near-identical) `tsconfig` files and run the compiler twice to get the declaration file and output file. What for?
| Suggestion,Help Wanted | low | Critical |
190,717,498 | opencv | Documentation for fish-eye camera model is inconsistent with the code | The documentation for fish-eye camera model gives the following formulas for pixel projections (modules/calib3d/include/opencv2/calib3d.hpp:215):
```
\f[x' = (\theta_d / r) a \\ y' = (\theta_d / r) b \f]
\f[u = f_x (x' + \alpha y') + c_x \\
v = f_y y' + c_y\f]
```
However initUndistortRectifyMap() function (modules/calib3d/src/fisheye.cpp:471) has code which is inconsistent with the documentation (see u-coordinate calculation):
```
double x = _x/_w, y = _y/_w;
double r = sqrt(x*x + y*y);
double theta = atan(r);
double theta2 = theta*theta, theta4 = theta2*theta2, theta6 = theta4*theta2, theta8 = theta4*theta4;
double theta_d = theta * (1 + k[0]*theta2 + k[1]*theta4 + k[2]*theta6 + k[3]*theta8);
double scale = (r == 0) ? 1.0 : theta_d / r;
double u = f[0]*x*scale + c[0];
double v = f[1]*y*scale + c[1];
```
Recently (since 3.1) there already was some mess with this place and v-coordinate formula was corrected. Perhaps u-coordinate also should be corrected (or at least clarified what is "alpha", there is no such symbol defined in the formulas above that place).
3.1 generated docs [here](http://docs.opencv.org/3.1.0/db/d58/group__calib3d__fisheye.html) | bug,category: documentation,category: calib3d | low | Minor |
Subsets and Splits
No saved queries yet
Save your SQL queries to embed, download, and access them later. Queries will appear here once saved.