id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
βŒ€
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
554,631,774
go
os: document the Process.Pid field
As discussed in https://groups.google.com/forum/#!topic/golang-nuts/ievQGPz1R7k, https://golang.org/cl/4029053 dropped the documentation for the `Pid` field. I also propose to extend the documentation with something like: ``` The value of Pid after the process has been waited/released is not specified. ``` The reason is that on *UNIX* systems, `Release` set `Pid` to -1, but not on *Windows*. This means that a program can not check if `Pid` == -1 to determine if the process has been released. The alternative is to change the *Windows* implementation.
Documentation,help wanted,NeedsFix
low
Minor
554,635,242
flutter
Why the best preview's resolution is high?
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> I have a problem with quality of preview on Android devices, it's worse than pre-installed Camera app. In the file https://github.com/flutter/plugins/blob/master/packages/camera/android/src/main/java/io/flutter/plugins/camera/CameraUtils.java: ```Java static Size computeBestPreviewSize(String cameraName, ResolutionPreset preset) { if (preset.ordinal() > ResolutionPreset.high.ordinal()) { preset = ResolutionPreset.high; } CamcorderProfile profile = getBestAvailableCamcorderProfileForResolutionPreset(cameraName, preset); return new Size(profile.videoFrameWidth, profile.videoFrameHeight); } ``` If I delete the row `preset = ResolutionPreset.high;`, then preview's quality seems good, but on some devices it affects to aspect ratio and preview is wrong scaled. <details> <summary>Logs</summary> <!-- Finally, paste the output of running `flutter doctor -v` here. --> ``` [βœ“] Flutter (Channel unknown, v1.13.6, on Mac OS X 10.15.2 19C57, locale en-RU) β€’ Flutter version 1.13.6 at /Users/askarsyzdykov/Development/flutter β€’ Framework revision 659dc8129d (4 weeks ago), 2019-12-30 09:24:47 -0800 β€’ Engine revision bdc9708d23 β€’ Dart version 2.8.0 (build 2.8.0-dev.0.0 c547f5d933) [βœ“] Android toolchain - develop for Android devices (Android SDK version 29.0.1) β€’ Android SDK at /Users/askarsyzdykov/Library/Android/sdk β€’ Android NDK location not configured (optional; useful for native profiling support) β€’ Platform android-29, build-tools 29.0.1 β€’ Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) β€’ All Android licenses accepted. [βœ“] Xcode - develop for iOS and macOS (Xcode 11.3.1) β€’ Xcode at /Applications/Xcode.app/Contents/Developer β€’ Xcode 11.3.1, Build version 11C504 β€’ CocoaPods version 1.8.4 [βœ“] Android Studio (version 3.5) β€’ Android Studio at /Applications/Android Studio.app/Contents β€’ Flutter plugin version 42.1.1 β€’ Dart plugin version 191.8593 β€’ Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) [!] IntelliJ IDEA Community Edition (version 2018.3.5) β€’ IntelliJ at /Applications/IntelliJ IDEA CE.app βœ— Flutter plugin not installed; this adds Flutter specific functionality. βœ— Dart plugin not installed; this adds Dart specific functionality. β€’ For information about installing plugins, see https://flutter.dev/intellij-setup/#installing-the-plugins [βœ“] VS Code (version 1.39.2) β€’ VS Code at /Applications/Visual Studio Code.app/Contents β€’ Flutter extension version 3.6.0 [βœ“] Connected device (1 available) β€’ SM A500F β€’ 80ba9ad6 β€’ android-arm β€’ Android 6.0.1 (API 23) ! Doctor found issues in 1 category. ``` </details>
p: camera,package,team-ecosystem,P3,triaged-ecosystem
low
Critical
554,642,477
pytorch
Interrupting a DDP worker while using the CUDA MPS server causes CUDA to hang until reboot
## πŸ› Bug When using the CUDA MPS server, having a DataDistributedParallel worker fail can cause CUDA to hang permanently on the machine until it's rebooted. I think this is more an NVIDIA bug than a PyTorch bug and I've submitted it to them, but it's something that other PyTorch users are likely to run in to too, so I'm reporting it here. ## To Reproduce I have a minimal example [here](https://gist.github.com/andyljones/8886f903d9ae82b108992dc47978ef20). ## Expected behavior The expected behaviour is that future CUDA launches in separate processes should not hang. ## Environment ``` PyTorch version: 1.4.0 Is debug build: No CUDA used to build PyTorch: 10.1 OS: Ubuntu 18.04.3 LTS GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0 CMake version: Could not collect Python version: 3.7 Is CUDA available: Yes CUDA runtime version: 10.1.243 GPU models and configuration: GPU 0: GeForce RTX 2080 Ti GPU 1: GeForce RTX 2080 Ti Nvidia driver version: 440.26 cuDNN version: Could not collect Versions of relevant libraries: [pip] numpy==1.18.1 [pip] torch==1.4.0 [pip] torchfile==0.1.0 [pip] torchvision==0.5.0 [conda] blas 1.0 mkl [conda] mkl 2019.4 243 [conda] mkl-service 2.3.0 py37he904b0f_0 [conda] mkl_fft 1.0.15 py37ha843d7b_0 [conda] mkl_random 1.1.0 py37hd6b4f25_0 [conda] pytorch 1.4.0 py3.7_cuda10.1.243_cudnn7.6.3_0 pytorch [conda] torchfile 0.1.0 pypi_0 pypi [conda] torchvision 0.5.0 py37_cu101 pytorch ``` ## Additional context The bug ID on NVIDIA's side is `2750018`. cc @ngimel @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @osalpekar
oncall: distributed,module: cuda,triaged
low
Critical
554,644,166
svelte
CSS isolation bug when components styles is equals and have not used css rule
I think it is optimization side effect. Likely it can be reproduced only if you have at least one not used css rule. [See this repl](https://svelte.dev/repl/ddc97886a98741dbbb40e58607aaa265?version=3.17.3) **See these components:** Component1.svelte ```svelte <div class="red"> Red </div> <style> .red { background: red; } .yellow { background: yellow; } </style> ``` Component2.svelte ```svelte <div class="red"> Red </div> <div class="yellow"> Yellow </div> <style> .red { background: red; } .yellow { background: yellow; } </style> ``` **1.** For these components svelte generates different CSS with same css class suffixes Component1.css ```css .red.svelte-1q75qj7{ background:red } ``` Component2.css ```css .red.svelte-1q75qj7 { background:red } .red.svelte-1q75qj7{ background:red } .yellow.svelte-1q75qj7{ background:yellow } ``` **2.** Depending on which component loads first, only one of these styles will be loaded. You can see in the repl that Yellow div is not yellow. Switch the tabIndex default value to 2, and this div will be yellow. App.svelte ```svelte <script> import Component1 from './Component1.svelte' import Component2 from './Component2.svelte' let tabIndex = 1 </script> <button on:click={() => tabIndex = 1}>Tab 1</button> <button on:click={() => tabIndex = 2}>Tab 2</button> {#if tabIndex === 1} <Component1 /> {:else} <Component2 /> {/if} ``` **3.** Even if both styles will be loaded, their loading order will affect the style of the component. Thus, the styles of some components will affect others.
bug,temp-stale
low
Critical
554,644,769
rust
Exponential Type Blowup when wrapping function
I am implementing a service architecture, where each service can be thought of as middleware. It makes sense to define complex services which need to manage their own complex state as their own structs and implement my `Service` trait for each one. However, for simple operations, e.g. logging or manipulating some argument in place, it makes more sense to have a wrapper service which receives the previous service's "request", does whatever it needs to do, and passes it on. The wrapper service also implements the `Service` trait. The problem here is that there is an exponential type length complexity blowup when passing in the function. Probably related: https://github.com/rust-lang/rust/issues/54540, note how there's no closure in my example MVCE below: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=17d88bb1e552b2cc285ced44777e726b (complex services: BaseService / MyService, stateless services: logger, doubler) ```rust // The objective is to be able to wrap existing services with simple functions, without // having to define a new service each time we want to perform a very minimal action // on the data flow. We could define a LoggerService and a DoublingService, but that // is _a lot_ of boilerplate. fn main() { let s = BaseService; // We can create as many new services as we want, // the type length increases linearly, as expected let s = MyService::new(s); let s = MyService::new(s); // The type length of `s` doubles let s = WrappedService::new(s, stateless_log); // if you try to wrap a few times, your code hits the type length limit let s = WrappedService::new(s, stateless_double); let s = WrappedService::new(s, stateless_double); let s = WrappedService::new(s, stateless_double); let s = WrappedService::new(s, stateless_double); let s = WrappedService::new(s, stateless_double); let s = WrappedService::new(s, stateless_double); let s = WrappedService::new(s, stateless_double); let s = WrappedService::new(s, stateless_double); let s = WrappedService::new(s, stateless_double) } type Request = u64; type MyResult = Result<(), ()>; pub trait Service { fn handle(&mut self, request: Request) -> MyResult; } // A simple service which we we use as our base #[derive(Clone)] pub struct BaseService; impl Service for BaseService { fn handle(&mut self, _request: Request) -> MyResult { Ok(()) } } // A service that takes another service (and could have more state) #[derive(Clone)] pub struct MyService<O> { next: O, } impl<O> MyService<O> where O: Service + Clone + Send, { pub fn new(next: O) -> Self { MyService { next } } } impl<O> Service for MyService<O> where O: Service + Clone + Send, { fn handle(&mut self, request: Request) -> MyResult { self.next.handle(request) } } /// =========== Stateless Services ========= use std::sync::Arc; // We have to store the service onion so far, and the function we want to inject #[derive(Clone)] pub struct WrappedService<F, I> { f: F, inner: Arc<I>, } impl<F, S> WrappedService<F, S> where F: Fn(S, Request) -> MyResult, S: Service + Clone, { pub fn new(inner: S, f: F) -> Self { WrappedService { f, inner: Arc::new(inner), } } } impl<F, S> Service for WrappedService<F, S> where F: Fn(S, Request) -> MyResult, S: Service + Clone, { fn handle(&mut self, request: Request) -> MyResult { (self.f)((*self.inner).clone(), request) } } // Is there a way to convert these to a service, without having to go through a lot of boilerplate? pub fn stateless_log<O: Service + Clone>(mut next: O, request: Request) -> MyResult { println!("sending request"); let result = next.handle(request); println!("got result"); result } pub fn stateless_double<O: Service + Clone>(mut next: O, request: Request) -> MyResult { let request = 2 * request; let result = next.handle(request); result } ``` ([Playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=17d88bb1e552b2cc285ced44777e726b))
I-compiletime,T-compiler
low
Critical
554,664,526
opencv
OPENCV-DNN Using new cfg from Darknet repository causes error
OpenCV 4.2.0 New models from Alexey Darknet repository CFG: https://raw.githubusercontent.com/AlexeyAB/darknet/master/cfg/csresnext50-panet-spp-original-optimal.cfg WEIGHTS: https://drive.google.com/open?id=1_NnfVgj0EDtb_WLNoXV8Mo7WKgwdYZCc Testing with the new OPENCV-dnn with cuda support I achieve better performance than using Darknet library (even 2x FPS on a 1060 GTX), but the problem is that this model (which is quite better than the standard yolov3.cfg) causes this error. **opencv/modules/dnn/src/dnn.cpp:1428: error: (-204:Requested object was not found) Layer with requested id=-1 not found in function 'getLayerData'**
feature,category: dnn
medium
Critical
554,685,155
pytorch
Document different gradient wrt to jax when nesting
## πŸ› Bug The following code results in `0` when the expected answer is `-1`: ```python def f1(x): def f2(y): return y*(x-y) return torch.autograd.grad(f2(x), x, create_graph=True)[0] x = torch.tensor(1.0, requires_grad=True) torch.autograd.grad(f1(x), x)[0] ``` ## To Reproduce Run the code above. ## Expected behavior The code should result in `tensor(-1.)` rather than `tensor(0.)`. ## Environment ``` PyTorch version: 1.4.0 Is debug build: No CUDA used to build PyTorch: None OS: Mac OSX 10.15.1 GCC version: Could not collect CMake version: version 3.15.5 Python version: 3.7 Is CUDA available: No CUDA runtime version: No CUDA GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA Versions of relevant libraries: [pip3] numpy==1.16.3 [pip3] torch==1.4.0 [pip3] torchvision==0.5.0 [conda] blas 1.0 mkl [conda] mkl 2019.3 199 [conda] mkl_fft 1.0.12 py37h5e564d8_0 [conda] mkl_random 1.0.2 py37h27c97d8_0 [conda] pytorch 1.4.0 py3.7_0 pytorch [conda] torchvision 0.5.0 py37_cpu pytorch ``` ## Additional context The following code in JAX produces the expected behaviour, for comparison: ```python def f1(x): def f2(y): return y*(x-y) return jax.jvp(f2, (x,), (1.0,))[1] jax.jvp(f1, (1.0,), (1.0,))[1] # => DeviceArray(-1., dtype=float32) ``` cc @ezyang @SsnL @albanD @zou3519 @gqchen
module: docs,module: autograd,triaged
low
Critical
554,689,018
go
x/mobile/cmd/gomobile : Can't generate library for android for the following go package https://github.com/ethereum/go-ethereum/whisper/whisperv6
<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.6 windows/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> ``` $ go env set GO111MODULE= set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\rohan\AppData\Local\go-build set GOENV=C:\Users\rohan\AppData\Roaming\go\env set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GONOPROXY= set GONOSUMDB= set GOOS=windows set GOPATH=C:\Users\rohan\go set GOPRIVATE= set GOPROXY=https://proxy.golang.org,direct set GOROOT=c:\go set GOSUMDB=sum.golang.org set GOTMPDIR= set GOTOOLDIR=c:\go\pkg\tool\windows_amd64 set GCCGO=gccgo set AR=ar set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD=C:\BE Project\go-ethereum-master\go.mod set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\rohan\AppData\Local\Temp\go-build766559602=/tmp/go-build -gno-record-gcc-switches ``` </pre></details> ### What did you do? ``` gomobile bind -v -target android github.com/ethereum/go-ethereum/whisper/whisperv6 ``` <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> ### What did you expect to see? I want to generate android library from the go library ### What did you see instead? ``` write C:\Users\rohan\AppData\Local\Temp\gomobile-work-644583759\src\go.mod go: downloading golang.org/x/mobile v0.0.0-20200123024942-82c397c4c527 go: extracting golang.org/x/mobile v0.0.0-20200123024942-82c397c4c527 go: downloading golang.org/x/sync v0.0.0-20190423024810-112230192c58 go: downloading github.com/syndtr/goleveldb v1.0.1-0.20190923125748-758128399b1d go: downloading golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550 go: downloading github.com/golang/snappy v0.0.1 go: downloading github.com/rs/cors v0.0.0-20160617231935-a62a804a8a00 go: downloading github.com/huin/goupnp v0.0.0-20161224104101-679507af18f3 go: extracting golang.org/x/sync v0.0.0-20190423024810-112230192c58 go: extracting github.com/syndtr/goleveldb v1.0.1-0.20190923125748-758128399b1d go: extracting github.com/rs/cors v0.0.0-20160617231935-a62a804a8a00 go: extracting github.com/golang/snappy v0.0.1 go: downloading github.com/go-stack/stack v1.8.0 go: downloading github.com/aristanetworks/goarista v0.0.0-20170210015632-ea17b1a17847 go: downloading github.com/rs/xhandler v0.0.0-20160618193221-ed27b6fd6521 go: downloading golang.org/x/net v0.0.0-20190628185345-da137c7871d7 go: downloading github.com/elastic/gosigar v0.8.1-0.20180330100440-37f05ff46ffa go: extracting github.com/go-stack/stack v1.8.0 go: extracting github.com/huin/goupnp v0.0.0-20161224104101-679507af18f3 go: downloading github.com/gorilla/websocket v1.4.1-0.20190629185528-ae1634f6a989 go: downloading github.com/deckarep/golang-set v0.0.0-20180603214616-504e848d77ea go: downloading github.com/jackpal/go-nat-pmp v1.0.2-0.20160603034137-1fa385a6f458 go: extracting github.com/rs/xhandler v0.0.0-20160618193221-ed27b6fd6521 go: extracting github.com/elastic/gosigar v0.8.1-0.20180330100440-37f05ff46ffa go: downloading golang.org/x/sys v0.0.0-20190712062909-fae7ac547cb7 go: extracting github.com/jackpal/go-nat-pmp v1.0.2-0.20160603034137-1fa385a6f458 go: extracting github.com/deckarep/golang-set v0.0.0-20180603214616-504e848d77ea go: extracting github.com/gorilla/websocket v1.4.1-0.20190629185528-ae1634f6a989 go: extracting golang.org/x/net v0.0.0-20190628185345-da137c7871d7 go: downloading golang.org/x/text v0.3.2 go: extracting github.com/aristanetworks/goarista v0.0.0-20170210015632-ea17b1a17847 go: extracting golang.org/x/sys v0.0.0-20190712062909-fae7ac547cb7 go: extracting golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550 go: extracting golang.org/x/text v0.3.2 go: finding golang.org/x/mobile v0.0.0-20200123024942-82c397c4c527 go: finding github.com/deckarep/golang-set v0.0.0-20180603214616-504e848d77ea go: finding github.com/syndtr/goleveldb v1.0.1-0.20190923125748-758128399b1d go: finding golang.org/x/crypto v0.0.0-20191011191535-87dc89f01550 go: finding golang.org/x/sync v0.0.0-20190423024810-112230192c58 go: finding github.com/go-stack/stack v1.8.0 go: finding github.com/aristanetworks/goarista v0.0.0-20170210015632-ea17b1a17847 go: finding github.com/gorilla/websocket v1.4.1-0.20190629185528-ae1634f6a989 go: finding github.com/rs/cors v0.0.0-20160617231935-a62a804a8a00 go: finding github.com/elastic/gosigar v0.8.1-0.20180330100440-37f05ff46ffa go: finding github.com/golang/snappy v0.0.1 go: finding github.com/huin/goupnp v0.0.0-20161224104101-679507af18f3 go: finding github.com/jackpal/go-nat-pmp v1.0.2-0.20160603034137-1fa385a6f458 go: finding github.com/rs/xhandler v0.0.0-20160618193221-ed27b6fd6521 go: finding golang.org/x/net v0.0.0-20190628185345-da137c7871d7 go: finding golang.org/x/sys v0.0.0-20190712062909-fae7ac547cb7 go: finding golang.org/x/text v0.3.2 golang.org/x/net/html/atom golang.org/x/text/encoding/internal/identifier golang.org/x/text/internal/utf8internal golang.org/x/sync/syncmap golang.org/x/text/internal/tag runtime/cgo github.com/syndtr/goleveldb/leveldb/comparer golang.org/x/crypto/sha3 github.com/aristanetworks/goarista/monotime golang.org/x/sys/unix github.com/deckarep/golang-set github.com/go-stack/stack github.com/syndtr/goleveldb/leveldb/util github.com/syndtr/goleveldb/leveldb/storage github.com/ethereum/go-ethereum/common github.com/syndtr/goleveldb/leveldb/cache github.com/golang/snappy github.com/ethereum/go-ethereum/common/mclock github.com/syndtr/goleveldb/leveldb/errors github.com/syndtr/goleveldb/leveldb/filter github.com/elastic/gosigar github.com/huin/goupnp/scpd golang.org/x/net/html github.com/ethereum/go-ethereum/event github.com/syndtr/goleveldb/leveldb/iterator github.com/syndtr/goleveldb/leveldb/journal github.com/syndtr/goleveldb/leveldb/opt golang.org/x/text/transform golang.org/x/text/internal/language golang.org/x/net/context github.com/syndtr/goleveldb/leveldb/memdb golang.org/x/crypto/pbkdf2 github.com/syndtr/goleveldb/leveldb/table golang.org/x/text/encoding golang.org/x/text/runes golang.org/x/text/encoding/internal golang.org/x/text/internal/language/compact github.com/syndtr/goleveldb/leveldb golang.org/x/text/encoding/charmap golang.org/x/text/encoding/japanese golang.org/x/text/encoding/traditionalchinese golang.org/x/text/encoding/korean golang.org/x/text/encoding/simplifiedchinese golang.org/x/text/encoding/unicode golang.org/x/text/language golang.org/x/text/encoding/htmlindex golang.org/x/net/html/charset golang.org/x/mobile/internal/mobileinit github.com/ethereum/go-ethereum/crypto/secp256k1 net ``` ``` # golang.org/x/mobile/internal/mobileinit C:\Users\rohan\AppData\Local\Android\Sdk\ndk-bundle\toolchains\llvm\prebuilt\windows-x86_64\bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin\ld: fatal error: $WORK\b191\_cgo_.o: open: Invalid argument clang: error: linker command failed with exit code 1 (use -v to see invocation) # net C:\Users\rohan\AppData\Local\Android\Sdk\ndk-bundle\toolchains\llvm\prebuilt\windows-x86_64\bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin\ld: fatal error: $WORK\b078\_cgo_.o: open: Invalid argument clang: error: linker command failed with exit code 1 (use -v to see invocation) # github.com/ethereum/go-ethereum/crypto/secp256k1 C:\Users\rohan\AppData\Local\Android\Sdk\ndk-bundle\toolchains\llvm\prebuilt\windows-x86_64\bin/../lib/gcc/arm-linux-androideabi/4.9.x/../../../../arm-linux-androideabi/bin\ld: fatal error: $WORK\b069\_cgo_.o: open: Invalid argument clang: error: linker command failed with exit code 1 (use -v to see invocation) go: failed to remove work dir: CreateFile C:\Users\rohan\AppData\Local\Temp\go-build488709430\b086\symabis: Access is denied. gomobile: go build -v -buildmode=c-shared -o=C:\Users\rohan\AppData\Local\Temp\gomobile-work-644583759\android\src\main\jniLibs\armeabi-v7a\libgojni.so ./gobind failed: exit status 2 ```
NeedsInvestigation,mobile
medium
Critical
554,710,579
flutter
Test if a new iOS build exists before uninstalling the old version
## Use case I recently tried to reinstall a Flutter app to an iOS device that I hadn't redeployed to in a few weeks. ``` $ flutter install Installing come.example.my_app to My iPad... Uninstalling old version... Could not find application bundle at build/ios/iphoneos/Runner.app; have you run "flutter build ios"? Install failed ``` At this point, I've received good guidance on what to do next, and when I attempted to do so, I had another failure which took me a little longer to resolve - I had an expired signing certificate, so it took me a few minutes to figure that out and resolve. However I've already uninstalled the old version from the iPad, and lost the ability to use the older version - which might have been a more extensive fix, but I was lucky here. ## Proposal I propose to perform the test to see if there's a new bundle before removing the existing one. This test could be moved to be performed before removing the existing version: https://github.com/flutter/flutter/blob/92cbaa3efe985cc8370d0d70fef5058c971b2eee/packages/flutter_tools/lib/src/ios/devices.dart#L225-L229 I'm not sure to where or how, but maybe some test in this function would be the right place? https://github.com/flutter/flutter/blob/ec2d58335a1b4273ddc0f855bd3666d8bc0b09b6/packages/flutter_tools/lib/src/commands/install.dart#L57-L58 I might be way off - it's entirely possible there was an existing build in the build/ directory, and the error message was incorrect - but since I don't have the prior state of an expired provisioning certificate, I'm going of what I saw in the CLI response.
platform-ios,tool,c: proposal,P3,team-ios,triaged-ios
low
Critical
554,738,009
godot
RigidBody2D rotates on collision in 3.2, works fine in 3.1
**Godot version:** 3.1.2 **OS/device including version:** Windows 7 **Issue description:** When opening a 3.1.2 project on any of the version of godot 3.2 it rotates when collison happens. In 3.1.2 it doesn't rotates only moves. **Steps to reproduce:** Just make any project where rigidbody collides with something in 3.1.2 and then open it in 3.2. **Minimal reproduction project:**
discussion,topic:physics
low
Major
554,746,600
tensorflow
AttributeError: 'Tensor' object has no attribute 'log_prob'
**System information** - Have I written custom code (as opposed to using a stock example script provided in TensorFlow): Yes - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Mac OS Catalina (Version: 10.15.2 (19C57)) - TensorFlow installed from (source or binary): binary - TensorFlow version (use command below): 2.1 - Python version: 3.7.5 - GPU model and memory: Intel Iris Pro 1536 MB **Describe the current behavior** I get the error > AttributeError: 'Tensor' object has no attribute 'log_prob' with TensorFlow Probability 0.9 (and TF 2.1). **Describe the expected behavior** No error. **Code to reproduce the issue** The following code ``` import tensorflow as tf import tensorflow_probability as tfp from tensorflow_probability import distributions as tfd def get_mnist_data(normalize=True): img_rows, img_cols = 28, 28 (x_train, y_train), (x_test, y_test) = tf.keras.datasets.mnist.load_data() if tf.keras.backend.image_data_format() == 'channels_first': x_train = x_train.reshape(x_train.shape[0], 1, img_rows, img_cols) x_test = x_test.reshape(x_test.shape[0], 1, img_rows, img_cols) input_shape = (1, img_rows, img_cols) else: x_train = x_train.reshape(x_train.shape[0], img_rows, img_cols, 1) x_test = x_test.reshape(x_test.shape[0], img_rows, img_cols, 1) input_shape = (img_rows, img_cols, 1) x_train = x_train.astype('float32') x_test = x_test.astype('float32') if normalize: x_train /= 255 x_test /= 255 return x_train, y_train, x_test, y_test, input_shape def get_bayesian_cnn(input_shape, num_classes=10): model_input = tf.keras.layers.Input(shape=input_shape) # kernel_divergence_fn=None to solve a symbolic exception. x = tfp.layers.Convolution2DFlipout(6, kernel_size=(5, 5), padding="SAME", activation=tf.nn.relu, kernel_divergence_fn=None)(model_input) x = tf.keras.layers.Flatten()(x) x = tfp.layers.DenseFlipout(84, activation=tf.nn.relu)(x) x = tfp.layers.DenseFlipout(num_classes)(x) model_output = tfp.layers.DistributionLambda(lambda t: tfd.Categorical(logits=t, validate_args=True))(x) model = tf.keras.Model(model_input, model_output) return model def neg_log_likelihood(y_true, y_pred): return -tf.reduce_mean(y_pred.log_prob(tf.cast(tf.argmax(y_true, axis=-1), tf.int32))) def train(): x_train, y_train, x_test, y_test, input_shape = get_mnist_data() model = get_bayesian_cnn(input_shape=input_shape) model.compile(optimizer=tf.keras.optimizers.Adam(), loss=neg_log_likelihood, metrics=[neg_log_likelihood]) model.fit(x_train, y_train, batch_size=128, epochs=1, verbose=1) if __name__ == "__main__": train() ``` **Comments** This error seems to be due to the fact that `y_pred` is a tensor when the loss is called, while it should be a distribution. Meanwhile, I found a [question on Stack Overflow related to the third issue I mentioned above](https://stackoverflow.com/q/59743872/3924118). (_This is a duplicate issue of https://github.com/tensorflow/probability/issues/742, but, for completeness, I decided to open it here too._)
stat:awaiting tensorflower,type:bug,comp:ops,TF 2.11
medium
Critical
554,818,698
go
cmd/go: test Documentation: Package List Parallelisation
<!-- Please answer these questions before submitting your issue. Thanks! For questions please use one of our forums: https://github.com/golang/go/wiki/Questions --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.1 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/ross/.cache/go-build" GOENV="/home/ross/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/home/ross/go" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build910819809=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? ran `go help test` which displays the [go test documentation](https://golang.org/pkg/cmd/go/internal/test/) ### What did you expect to see? While running `go test ./...` in a project with many subpackages, I noticed that integration tests in each subpackage were failing (randomly) when accessing a shared resource (such as a database). But if I ran the same code with `go test ./... -p 1` I see that my packages run in sequential order and the failures do not occur. I am happy with this outcome and I understand why parallelization is the default when running in this mode, but I feel that this behaviour could be explicitly highlighted in the documentation to avoid confusion. Right now the existing documentation comes close to covering this, but does not: ``` The second, called package list mode, occurs when go test is invoked with explicit package arguments (for example 'go test math', 'go test ./...', and even 'go test .'). In this mode, go test compiles and tests each of the packages listed on the command line. If a package test passes, go test prints only the final 'ok' summary line. If a package test fails, go test prints the full test output. If invoked with the -bench or -v flag, go test prints the full output even for passing package tests, in order to display the requested benchmark results or verbose logging. After the package tests for all of the listed packages finish, and their output is printed, go test prints a final 'FAIL' status if any package test has failed. ``` ### What did you see instead? The documentation doesn't cover the topic that I want to understand. Let me know if an example project is necessary to illustrate this concept better, or if I can provide any further detail in writing. I didn't want to post an issue straight away for this, but the issues channel in golang slack that I checked hasn't seen any activity since last year, which indicates that it's not very well used.
Documentation,NeedsInvestigation
low
Critical
554,820,444
go
x/tools: various test failures in TryBot run
### What version of Go are you using (`go version`)? https://golang.org/cl/216158 <pre> $ go tip </pre> ### Does this issue reproduce with the latest release? Doesn't seem to reproduce consistently, possibly flaky tests ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env </pre></details> ### What did you do? Ran trybots: https://storage.googleapis.com/go-build-log/2c418b7c/linux-amd64_209916fd.log ### What did you expect to see? Success ### What did you see instead? ``` 2020/01/24 15:23:15 no dep handle: no metadata for nosuchpkg package = nosuchpkg 2020/01/24 15:23:15 no dep handle: no metadata for golang.org/x/tools/internal/lsp/protocol package = golang.org/x/tools/internal/lsp/protocol 2020/01/24 15:23:15 no dep handle: no metadata for golang.org/x/xerrors package = golang.org/x/xerrors 2020/01/24 15:23:20 no dep handle: no metadata for nosuchpkg package = nosuchpkg 2020/01/24 15:23:20 no dep handle: no metadata for golang.org/x/tools/internal/lsp/protocol package = golang.org/x/tools/internal/lsp/protocol 2020/01/24 15:23:20 no dep handle: no metadata for golang.org/x/xerrors package = golang.org/x/xerrors --- FAIL: TestModfileSuggestedFixes (0.48s) --- FAIL: TestModfileSuggestedFixes/indirect (0.35s) lsp_test.go:977: err: exit status 2: stderr: flag provided but not defined: -modfile usage: go mod tidy [-v] Run 'go help mod tidy' for details. --- FAIL: TestModfileSuggestedFixes/unused (0.14s) lsp_test.go:977: err: exit status 2: stderr: flag provided but not defined: -modfile usage: go mod tidy [-v] Run 'go help mod tidy' for details. FAIL FAIL golang.org/x/tools/internal/lsp 9.074s ``` ``` --- FAIL: TestDiagnostics (1.71s) --- FAIL: TestDiagnostics/indirect (0.40s) mod_test.go:155: err: exit status 2: stderr: flag provided but not defined: -modfile usage: go mod tidy [-v] Run 'go help mod tidy' for details. --- FAIL: TestDiagnostics/unused (0.29s) mod_test.go:155: err: exit status 2: stderr: flag provided but not defined: -modfile usage: go mod tidy [-v] Run 'go help mod tidy' for details. --- FAIL: TestDiagnostics/invalidrequire (0.42s) mod_test.go:155: err: exit status 2: stderr: flag provided but not defined: -modfile usage: go mod tidy [-v] Run 'go help mod tidy' for details. --- FAIL: TestDiagnostics/invalidgo (0.36s) mod_test.go:155: err: exit status 2: stderr: flag provided but not defined: -modfile usage: go mod tidy [-v] Run 'go help mod tidy' for details. --- FAIL: TestDiagnostics/unknowndirective (0.23s) mod_test.go:155: err: exit status 2: stderr: flag provided but not defined: -modfile usage: go mod tidy [-v] Run 'go help mod tidy' for details. FAIL FAIL golang.org/x/tools/internal/lsp/mod 1.996s ``` ``` --- FAIL: TestInvalidFilesInOverlay (7.21s) --- FAIL: TestInvalidFilesInOverlay/GOPATH (2.88s) --- FAIL: TestInvalidFilesInOverlay/GOPATH/test_variant (2.80s) packages114_test.go:71: 0. d.D: got unknown, want "GET_test" --- FAIL: TestInvalidFilesInOverlay/GOPATH/second_file (0.07s) packages114_test.go:71: 1. d.D: got unknown, want "GET_util" --- FAIL: TestInvalidFilesInOverlay/Modules (4.33s) --- FAIL: TestInvalidFilesInOverlay/Modules/test_variant (4.13s) packages114_test.go:71: 0. d.D: got unknown, want "GET_test" --- FAIL: TestInvalidFilesInOverlay/Modules/second_file (0.18s) packages114_test.go:71: 1. d.D: got unknown, want "GET_util" FAIL FAIL golang.org/x/tools/go/packages 67.514s ``` Are these flaky? /cc @stamblerre
NeedsInvestigation,Tools
low
Critical
554,836,638
TypeScript
Type cast should try to remove readonly modifier
The compiler should try to use mutable versions of readonly tuples when couldn't cast readonly tuples to mutable arrays mainly for usability of `as const`. The performance impact of this would be a little because the condition when this check runs is limited. <!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** 3.7.x-dev.20200123 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** **Code** ```ts ([0] as [0]) as number[]; ([0] as [0]) as readonly number[]; // As the expansion of [0] as const ([0] as readonly [0]) as number[]; // error ([0] as readonly [0]) as readonly number[]; ``` **Expected behavior:** pass **Actual behavior:** ``` Conversion of type 'readonly [0]' to type 'number[]' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first. The type 'readonly [0]' is 'readonly' and cannot be assigned to the mutable type 'number[]'.(2352) ``` **Playground Link:** http://www.typescriptlang.org/play/index.html?target=99&ts=3.8.0-dev.20200123&ssl=1&ssc=1&pln=6&pc=1#code/BQbQDAugBAhgzlcECUsEDsCuBbARgUwCcQIBuAKFEjUUlXikPxgBMB7dAGwE8os8iJCgHphUAIIIALgAt8UfAA8ADjHRwAlhyhsAZrWgMAxhzhTKSGk1YceB+hhwFiZKKIWFCbQheoNr7Fy8SA6MzIF2-M5C5EA **Related Issues:** <!-- Did you find other bugs that looked similar? -->
Suggestion,Awaiting More Feedback
low
Critical
554,843,567
pytorch
SGD optimizer with deprecation warning
## πŸ› Bug <!-- A clear and concise description of what the bug is. --> When using SGD optimizer, I got the deprecation warning. The reason behind this is related to `add_` function in SGD. Should be an easy fix. ## To Reproduce Steps to reproduce the behavior: 1. Use the following code snippet ``` import torch model = torch.nn.Linear(2, 3) optimizer = torch.optim.SGD(model.parameters(), lr=5) t1 = torch.Tensor([[1.0, 2.0], [3.0, 4.0]]) output_t = model(t1) criterion = torch.nn.CrossEntropyLoss() loss = criterion(output_t, torch.Tensor([1, 2]).long()) loss.backward() optimizer.step() ``` ## Expected behavior ``` ../torch/csrc/autograd/generated/python_variable_methods.cpp:1334: UserWarning: This overload of add_ is deprecated: add_(Number alpha, Tensor other) Consider using one of the following signatures instead: add_(Tensor other, Number alpha) ``` ## Environment PyTorch version: 1.5.0a0+a5161c7 Is debug build: No CUDA used to build PyTorch: 9.2 OS: Ubuntu 18.04.3 LTS GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0 CMake version: version 3.14.0 Python version: 3.7 Is CUDA available: Yes CUDA runtime version: 9.2.88 GPU models and configuration: GPU 0: Quadro GP100 GPU 1: Quadro GP100 Nvidia driver version: 418.116.00 cuDNN version: Could not collect Versions of relevant libraries: [pip] numpy==1.16.4 [pip] numpydoc==0.9.1 [pip] torch==1.5.0a0+a5161c7 [pip] torchtext==0.5.0 [conda] Could not collect <!-- Add any other context about the problem here. --> @albanD @vincentqb cc @vincentqb
module: optimizer,triaged,module: deprecation
low
Critical
554,846,654
TypeScript
Proposal: Make base class expressions able to access class type parameters
<!-- 🚨 STOP 🚨 𝗦𝗧𝗒𝗣 🚨 𝑺𝑻𝑢𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ --> ## Search Terms Base class expressions cannot reference class type parameters ## Suggestion Right now it is possible in Ts to generate base classes dynamically (via a function): ```ts function prop<T>(): T { // implementation detail doesn't matter return null as any; } function createDynamicClass<T>(_props: T): { new(): T} { // implementation detail doesn't matter return null as any; } // without generics on the main class all is fine class C2 extends createDynamicClass({x: prop<number>()}) { setX(x: number) { this.x = x } } const c2 = new C2() c2.x = 20 c2.setX(30) ``` And it is also possible to reuse a generic when the base class is a "pure" class with a generic type: ```ts class Base<T> { x: number } class Child<T> extends Base<T> {} ``` However, currently it is impossible for a function that generates a dynamic class to re-use the type from the child class: ```ts // error: Base class expressions cannot reference class type parameters class C3<T> extends createDynamicClass({x: prop<T>()}) { setX(x: T) { this.x = x } } const c3 = new C3<number>() c3.x = 20 c3.setX(30) ``` There's a (somehow ugly) workaround, which is encapsulating the generation of the child class in a function and use its result: ```ts function generateC4<T>() { return class extends createDynamicClass({ x: prop<T>() }) { setX(x: T) { this.x = x } } } const C4 = generateC4<number>() const c4 = new C4() c4.x = 20 c4.setX(30) ``` But it is quite ugly, and results in a new class being generated for each generic when it is not actually needed (just for the typings). The proposal is basically to lift this constraint and allow it to be used (like it can be easily used for pure classes). ## Use Cases Right now in mobx-keystone it uses such a pattern (a function that generates a dynamic base class) to generate models: ```ts class Point extends Model({ x: prop<number>(), y: prop<number>(), }) { @modelAction setXY(x: number y: number) { this.x = x this.y = y } } const numberPoint = new Point({x: 10, y: 20}) ``` but in order to support generics, rather than just doing this: ```ts class Point<T> extends Model({ x: prop<T>(), y: prop<T>(), }) { @modelAction setXY(x: T, y: T) { this.x = x this.y = y } } const numberPoint = new Point<number>({x: 10, y: 20}) ``` users have to resort to a factory pattern like this: ```ts function createPointClass<T>() { class Point extends Model({ x: prop<T>(), y: prop<T>(), }) { @modelAction setXY(x: T, y: T) { this.x = x this.y = y } } return Point } const NumberPoint = createPointClass<number>() const numberPoint = new NumberPoint({x: 10, y: 20}) ``` which is far from ideal (and this is just to get typings right). ## Examples See above ## Checklist My suggestion meets these guidelines: * [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code It wouldn't since it is lifting a constraint that currently is just not allowed, so no current code can be using it. * [X] This wouldn't change the runtime behavior of existing JavaScript code The runtime behaviour would be exactly the same, it just addresses a typings problem. * [X] This could be implemented without emitting different JS based on the types of the expressions * [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Critical
554,854,314
pytorch
Segmentation Fault (core dumped) with 1.4.0
## πŸ› Bug Running a model training in the rapids docker container with 1.4.0 is throwing segmentation fault error while calling `.backward()` function whereas it is working as expected with 1.3.1. please find the below logs. ## Unexpected behavior ``` (rapids) root@dgx:/rapids/my_data/git_repo/clx# nvidia-smi Fri Jan 24 08:48:15 2020 +-----------------------------------------------------------------------------+ | NVIDIA-SMI 418.87.00 Driver Version: 418.87.00 CUDA Version: 10.1 | |-------------------------------+----------------------+----------------------+ | GPU Name Persistence-M| Bus-Id Disp.A | Volatile Uncorr. ECC | | Fan Temp Perf Pwr:Usage/Cap| Memory-Usage | GPU-Util Compute M. | |===============================+======================+======================| | 0 Tesla V100-SXM2... On | 00000000:06:00.0 Off | 0 | | N/A 31C P0 42W / 300W | 0MiB / 32480MiB | 0% Default | +-------------------------------+----------------------+----------------------+ | 1 Tesla V100-SXM2... On | 00000000:07:00.0 Off | 0 | | N/A 34C P0 43W / 300W | 0MiB / 32480MiB | 0% Default | +-------------------------------+----------------------+----------------------+ | 2 Tesla V100-SXM2... On | 00000000:0A:00.0 Off | 0 | | N/A 33C P0 42W / 300W | 0MiB / 32480MiB | 0% Default | +-------------------------------+----------------------+----------------------+ +-----------------------------------------------------------------------------+ | Processes: GPU Memory | | GPU PID Type Process name Usage | |=============================================================================| | No running processes found | +-----------------------------------------------------------------------------+ (rapids) root@dgx:/rapids/my_data/git_repo/clx# conda list | grep torch torch 1.4.0 pypi_0 pypi (rapids) root@dgx:/rapids/my_data/git_repo/clx# python examples/train_dga_detector.py --help usage: train_dga_detector.py [-h] train_file_path test_file_path output_dir batch_size epoch Model training runner positional arguments: train_file_path Input dataset for model training test_file_path Input dataset for model testing output_dir Output directory to store trained model batch_size Dividing dataset into number of batches or sets or parts epoch One epoch is when an entire dataset is passed forward and backward through the neural network only once optional arguments: -h, --help show this help message and exit (rapids) root@dgx:/rapids/my_data/git_repo/clx# python examples/train_dga_detector.py /rapids/my_data/dga/data/train2.csv /rapids/my_data/dga/data/test.csv /rapids/my_data/test_dga/ 10000 3 INFO:train_file_path : /rapids/my_data/dga/data/train2.csv INFO:test_file_path : /rapids/my_data/dga/data/test.csv INFO:Verify if output directory `/rapids/my_data/test_dga/` is already exists. INFO:Output directory `/rapids/my_data/test_dga/` does not exists. INFO:Creating directory `/rapids/my_data/test_dga/` to store trained models. INFO:********** INFO:Epoch: 1 INFO:********** /opt/conda/envs/rapids/lib/python3.7/site-packages/cudf/io/dlpack.py:82: UserWarning: WARNING: cuDF to_dlpack() produces column-major (Fortran order) output. If the output tensor needs to be row major, transpose the output of this function. return cpp_dlpack.to_dlpack(gdf_cols) [100000/1468974 (7%)] Loss: 5368.84 [200000/1468974 (14%)] Loss: 5238.29 [300000/1468974 (20%)] Loss: 5266.80 [400000/1468974 (27%)] Loss: 5503.81 [500000/1468974 (34%)] Loss: 5675.76 [600000/1468974 (41%)] Loss: 5730.03 [700000/1468974 (48%)] Loss: 5778.36 [800000/1468974 (54%)] Loss: 5797.21 [900000/1468974 (61%)] Loss: 5762.53 [1000000/1468974 (68%)] Loss: 5736.77 [1100000/1468974 (75%)] Loss: 5621.45 [1200000/1468974 (82%)] Loss: 5489.19 Segmentation fault (core dumped) ``` ## Expected behavior ``` (rapids) root@dgx:/rapids/my_data/git_repo/clx# pip install torch==1.3.1 Collecting torch==1.3.1 Downloading https://files.pythonhosted.org/packages/f9/34/2107f342d4493b7107a600ee16005b2870b5a0a5a165bdf5c5e7168a16a6/torch-1.3.1-cp37-cp37m-manylinux1_x86_64.whl (734.6MB) |β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆ| 734.6MB 23kB/s Requirement already satisfied: numpy in /opt/conda/envs/rapids/lib/python3.7/site-packages (from torch==1.3.1) (1.17.3) Installing collected packages: torch Found existing installation: torch 1.4.0 Uninstalling torch-1.4.0: Successfully uninstalled torch-1.4.0 Successfully installed torch-1.3.1 (rapids) root@dgx:/rapids/my_data/git_repo/clx# python examples/train_dga_detector.py /rapids/my_data/dga/data/train2.csv /rapids/my_data/dga/data/test.csv /rapids/my_data/test_dga/ 10000 3 INFO:train_file_path : /rapids/my_data/dga/data/train2.csv INFO:test_file_path : /rapids/my_data/dga/data/test.csv INFO:Verify if output directory `/rapids/my_data/test_dga/` is already exists. INFO:********** INFO:Epoch: 1 INFO:********** /opt/conda/envs/rapids/lib/python3.7/site-packages/cudf/io/dlpack.py:82: UserWarning: WARNING: cuDF to_dlpack() produces column-major (Fortran order) output. If the output tensor needs to be row major, transpose the output of this function. return cpp_dlpack.to_dlpack(gdf_cols) [100000/1468974 (7%)] Loss: 4696.43 [200000/1468974 (14%)] Loss: 5147.29 [300000/1468974 (20%)] Loss: 4525.80 [400000/1468974 (27%)] Loss: 4116.06 [500000/1468974 (34%)] Loss: 3795.70 [600000/1468974 (41%)] Loss: 3486.26 [700000/1468974 (48%)] Loss: 3230.03 [800000/1468974 (54%)] Loss: 2969.96 [900000/1468974 (61%)] Loss: 2875.38 [1000000/1468974 (68%)] Loss: 2768.05 [1100000/1468974 (75%)] Loss: 2662.28 [1200000/1468974 (82%)] Loss: 2584.43 [1300000/1468974 (88%)] Loss: 2544.63 [1400000/1468974 (95%)] Loss: 2469.58 Test set: Accuracy: 224095/367244 (0.6102073825576456) /opt/conda/envs/rapids/lib/python3.7/site-packages/torch/serialization.py:292: UserWarning: Couldn't retrieve source code for container of type DataParallel. It won't be checked for correctness upon loading. "type " + obj.__name__ + ". It won't be checked " /opt/conda/envs/rapids/lib/python3.7/site-packages/torch/serialization.py:292: UserWarning: Couldn't retrieve source code for container of type RNNClassifier. It won't be checked for correctness upon loading. "type " + obj.__name__ + ". It won't be checked " /opt/conda/envs/rapids/lib/python3.7/site-packages/torch/serialization.py:292: UserWarning: Couldn't retrieve source code for container of type Embedding. It won't be checked for correctness upon loading. "type " + obj.__name__ + ". It won't be checked " /opt/conda/envs/rapids/lib/python3.7/site-packages/torch/serialization.py:292: UserWarning: Couldn't retrieve source code for container of type GRU. It won't be checked for correctness upon loading. "type " + obj.__name__ + ". It won't be checked " /opt/conda/envs/rapids/lib/python3.7/site-packages/torch/serialization.py:292: UserWarning: Couldn't retrieve source code for container of type Linear. It won't be checked for correctness upon loading. "type " + obj.__name__ + ". It won't be checked " INFO:********** INFO:Epoch: 2 INFO:********** [100000/1468974 (7%)] Loss: 4053.78 [200000/1468974 (14%)] Loss: 3097.61 [300000/1468974 (20%)] Loss: 2553.45 [400000/1468974 (27%)] Loss: 2228.93 [500000/1468974 (34%)] Loss: 1973.65 [600000/1468974 (41%)] Loss: 1785.76 [700000/1468974 (48%)] Loss: 1629.33 [800000/1468974 (54%)] Loss: 1527.37 [900000/1468974 (61%)] Loss: 1532.07 [1000000/1468974 (68%)] Loss: 1489.94 [1100000/1468974 (75%)] Loss: 1473.13 [1200000/1468974 (82%)] Loss: 1464.33 [1300000/1468974 (88%)] Loss: 1478.28 [1400000/1468974 (95%)] Loss: 1464.06 Test set: Accuracy: 278392/367244 (0.7580573133938199) INFO:********** INFO:Epoch: 3 INFO:********** [100000/1468974 (7%)] Loss: 1578.96 [200000/1468974 (14%)] Loss: 1876.74 [300000/1468974 (20%)] Loss: 1545.72 [400000/1468974 (27%)] Loss: 1357.28 [500000/1468974 (34%)] Loss: 1219.40 [600000/1468974 (41%)] Loss: 1118.28 [700000/1468974 (48%)] Loss: 1040.39 [800000/1468974 (54%)] Loss: 996.32 [900000/1468974 (61%)] Loss: 971.37 [1000000/1468974 (68%)] Loss: 956.18 [1100000/1468974 (75%)] Loss: 968.09 [1200000/1468974 (82%)] Loss: 1007.30 [1300000/1468974 (88%)] Loss: 1039.72 [1400000/1468974 (95%)] Loss: 1047.50 Test set: Accuracy: 329641/367244 (0.8976075851477492) INFO:Model with highest accuracy (0.8976075851477492) is stored to location /rapids/my_data/test_dga//rnn_classifier_2020-01-24_08_52_23.pth INFO:Time taken for training a model : 51.769317388534546 (rapids) root@dgx:/rapids/my_data/git_repo/clx# conda list| grep torch torch 1.3.1 pypi_0 pypi ``` ## Environment ``` (rapids) root@dgx03:/rapids/my_data/git_repo# python collect_env.py Collecting environment information... PyTorch version: 1.3.1 Is debug build: No CUDA used to build PyTorch: 10.1.243 OS: NVIDIA DGX Server GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0 CMake version: version 3.14.5 Python version: 3.7 Is CUDA available: Yes CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: Tesla V100-SXM2-32GB GPU 1: Tesla V100-SXM2-32GB GPU 2: Tesla V100-SXM2-32GB Nvidia driver version: 418.87.00 cuDNN version: Could not collect Versions of relevant libraries: [pip] numpy==1.17.3 [pip] numpydoc==0.9.2 [pip] torch==1.3.1 [conda] torch 1.3.1 pypi_0 pypi ```
needs reproduction,triaged
low
Critical
554,856,335
TypeScript
Handle inlined sources in d.ts maps to support goto definition and other such functionalities
Found as part of #35014
Needs Investigation
low
Minor
554,861,543
flutter
Issues with properties in ThemeData and component properties they affect
**What do each of the properties in ThemeData affect? If I want to change something, say the text style of a particular widget, how do I know which text style to change in ThemeData?** Take this example: I wanted to have a specific text style for my AppBar (top app bar). I'm not sure if I'm not going about this correctly, but it took me a while to realize that it is `textTheme.title`, a property of `AppBarTheme()` that changes the app bar text style. I learned this by digging around the source for `textTheme()`. Also, for buttons, for the `textTheme`, I could put `ButtonTextTheme.primary`, or `ButtonTextTheme.secondary`. What exactly are the differences in these? Same issue with colors. Is there a list of what each property (primary, accent, focus, indicator, highlight color) affect in your UI? I know I could dig into the source code of each widget and check for myself, but I feel that **there should be a list**. I made an issue about this, it seems that some progress is being made (#36624) Relevant documentation: https://api.flutter.dev/flutter/material/ThemeData-class.html
framework,f: material design,d: api docs,P2,team-design,triaged-design
low
Minor
554,863,315
vscode
Expose a dropdown on the sidebar for extensions
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> Expose a dropdown on the side bar (see screenshot) to extensions to allow users switch between views within a view container. This can allow an extension to scale as the number of views increases, without having the need for an extension to have multiple icons in the activity bar. It also keeps the number of icons in the activity bar manageable for the users. ![image](https://user-images.githubusercontent.com/4393177/73089497-35127600-3e8b-11ea-811c-4f82640df074.png) @misolori
feature-request,api,ux,tree-views
medium
Major
554,866,313
flutter
Android versionCode calculation conflicts with iOS versioning
I'm currently rolling our recently released Flutter application from `v1.0.0+109` to `v1.0.1+1`. This is expected of an iOS application, as this is now the 1st build of the new version of our application. However, in `gradle_utils:updateLocalProperties`, Flutter uses the build number to calculate the `versionCode`, which is expected to monotonically increase. One alternative is to call the new version `v1.0.1+110`, which would preserve the given `versonCode` "calculation" by Flutter, while breaking the convention on iOS, as the builds would start with 110. Another pair of alternatives involves changing Flutter: - Flutter could use a separate field in `pubspec.yaml` or similar to allow application developers to provide their own, manually created `versionCode`. - Flutter could calculate the `versionCode` from the otherwise-SemVer-honoring `version` field in `pubspec.yaml`. This would place restrictions on, say, the number of each kind of version a team could produce (to 10^3, 10^4, or similar) to make the math work, but would provide an internally consistent set of expectations across Flutter/Dart, iOS, and Android.
tool,framework,t: gradle,t: xcode,c: proposal,P2,team-framework,triaged-framework
low
Major
554,892,975
PowerToys
Horizontal scroll
# Summary of the new feature/enhancement Hi, everybody. Is it possible to give us a key modifier for mouse horizontal scroll? Something like to hold ALT key and use the scroll button. Thank you!
Idea-New PowerToy
low
Major
554,898,989
rust
Closure capturing itself results in unclear "mismatched types" error
Code: ```rust fn main() { let mut r = None; let c = move || { let _r = r; }; r = Some(c); } ``` Results in this error: ``` error[E0308]: mismatched types --> src/main.rs:4:13 | 4 | let c = move || { | _____________^ 5 | | let _r = r; 6 | | }; | |_____^ cyclic type of infinite size ``` This seems a bit unclear to me. What types don't match here? There is special code in the compiler that is supposed to give a better error message, but for some reason it's not happening in this case: https://github.com/rust-lang/rust/blob/73f76b74efcaf21bd5424d87c66cd6ed7fe5c7de/src/librustc/infer/error_reporting/mod.rs#L2003-L2006
A-diagnostics,A-closures,T-compiler,C-bug
low
Critical
554,904,142
pytorch
User-friendly handling of types and devices
Some changes would make small-scale prototyping more user-friendly in PyTorch: - Python types are automatically converted to PyTorch types - integer types are treated numerically equivalent to their floating point version - device mismatches are handled automatically The last one is probably the most controversial. Implicit movement between devices causes hard-to-debug performance problems in large models. However, this problem could be solved with better tooling. Forgetting to add `.cuda()` will always trip people up An example of workflow I just went through to check if my result is close to 1 ``` torch.allclose(tensor.mean(), 1) # allclose(): argument 'other' (position 2) must be Tensor, not int torch.allclose(tensor.mean(), torch.Tensor(1)) # output with device cuda:0 doesn't match the desired device cpu torch.allclose(tensor.mean(), torch.Tensor(1).cuda()) # False....huh?...oh, need tensor, not Tensor... torch.allclose(tensor.mean(), torch.tensor(1).cuda()) # Float did not match Long torch.allclose(tensor.mean(), torch.tensor(1.).cuda()) # Success! ``` cc @mruberry @rgommers @heitorschueroff
triaged,module: numpy,module: ux
low
Critical
554,910,503
TypeScript
cmd+click function name goes to type definition file instead of source
duplicate of microsoft/vscode#68782 but that was closed without fix. <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: 1.41.1 - OS Version: macOS 10.14.6 Steps to Reproduce: 1. Create a project folder with 2 files: lib.js ```js export const testMethod = (name, params) => { params && params.age ? `hello ${name} with age: ${params.age}` : `hello ${name}`; }; ``` test.js ```js import { testMethod } from "./lib"; testMethod("foo", { age: 3 }); ``` cmd+click works and jumps to definition. ![no-type](https://user-images.githubusercontent.com/10415101/73053819-a3304c00-3e3d-11ea-9d43-3a7bade993ea.gif) now add a type definition file lib.d.ts ```ts declare namespace MyModule { interface IParams { age: number; } function testMethod(name: string, params: IParams): string; } export = MyModule; ``` cmd+click jumps to type definition instead of source definition. ![with-type-file](https://user-images.githubusercontent.com/10415101/73053828-aa575a00-3e3d-11ea-8e22-bd2b3a458c4f.gif) I do not think this should be the default behavior. I would expect cmd+click to bring me to the function definition.
Suggestion,Awaiting More Feedback
low
Major
554,910,558
rust
"expected bound lifetime parameter, found concrete lifetime" when passing a 'static reference to a closure that returns a future
```rust use std::future::Future; fn main() { let _ = wrapper(hello); } static GLOBAL: i32 = 42; async fn wrapper<F, FutResp>(f: F) where F: Fn(&i32) -> FutResp, FutResp: Future<Output = ()>, { f(&GLOBAL).await } async fn hello(_: &i32) { println!("Hello"); } ``` ([Playground](https://play.integer32.com/?version=stable&mode=debug&edition=2018&gist=27552741e074086dcc84a6734fe862cc)) Errors: ``` error[E0271]: type mismatch resolving `for<'r> <for<'_> fn(&i32) -> impl std::future::Future {hello} as std::ops::FnOnce<(&'r i32,)>>::Output == _` --> src/main.rs:4:13 | 4 | let _ = wrapper(hello); | ^^^^^^^ expected bound lifetime parameter, found concrete lifetime ... 9 | async fn wrapper<F, FutResp>(f: F) | ------- 10 | where 11 | F: Fn(&i32) -> FutResp, | ------- required by this bound in `wrapper` ``` I can make the code work by restricting the closure to only accept `'static` references: ```rust async fn wrapper<F, FutResp>(f: F) where F: Fn(&'static i32) -> FutResp, // ^^^^^^^ FutResp: Future<Output = ()>, ``` I did try to add `'static` bounds to the response future (and the closure, for good measure), but this did not help: ```rust async fn wrapper<F, FutResp>(f: F) where F: Fn(&i32) -> FutResp + 'static, FutResp: Future<Output = ()> + 'static, ``` The equivalent(?) synchronous code works as I'd expect: ```rust fn main() { let _ = wrapper(hello); } static GLOBAL: i32 = 42; fn wrapper<F>(f: F) where F: Fn(&i32) -> (), { f(&GLOBAL) } fn hello(_: &i32) { println!("Hello"); } ```
A-diagnostics,A-lifetimes,P-medium,A-closures,T-compiler,C-bug,A-async-await,AsyncAwait-Triaged
low
Critical
554,910,999
flutter
[fuchsia] Use FIDL types dart:fuchsia as opposed to Handle
We currently expose every exported object in [fuchsia.dart](https://github.com/flutter/engine/blob/master/shell/platform/fuchsia/dart-pkg/fuchsia/lib/fuchsia.dart) as a raw `Handle` type. We can use the FIDL types instead.
team,engine,platform-fuchsia,P2,team-engine,triaged-engine
low
Minor
554,928,110
go
go/parser: bad error message for a badly formed func literal
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version devel +8e0be05ec7 Sun Jan 19 14:04:09 2020 +0000 linux/amd64 $ go list -m golang.org/x/tools golang.org/x/tools v0.0.0-20200121200311-d456b1cd8c86 $ go list -m golang.org/x/tools/gopls golang.org/x/tools/gopls v0.1.8-0.20200121200311-d456b1cd8c86 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/home/myitcv/.cache/go-build" GOENV="/home/myitcv/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/myitcv/gostuff" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/myitcv/gos" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/myitcv/gos/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/home/myitcv/.vim/plugged/govim/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build878422207=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? The diagnostic for the following file is misleading: ``` package main func main() { _ = func(format string, args ...interface) error { return nil } } ``` We get: ``` PublishDiagnostics callback: &protocol.PublishDiagnosticsParams{ URI: "file:///home/myitcv/gostuff/src/github.com/myitcv/playground/main.go", Version: 36, Diagnostics: { { Range: protocol.Range{ Start: protocol.Position{Line:3, Character:5}, End: protocol.Position{Line:3, Character:5}, }, Severity: 1, Code: nil, Source: "syntax", Message: "expected expression", Tags: nil, RelatedInformation: nil, }, }, } ``` Contrast what we get from the compiler: ``` ./main.go:4:43: syntax error: unexpected ), expecting { ./main.go:5:3: syntax error: unexpected return, expecting comma or ) ./main.go:7:1: syntax error: non-declaration statement outside function body ``` ### What did you expect to see? A better diagnostic. ### What did you see instead? Per above Marking as `gopls/v1.0.0` because this isn't critical for `v0.3.0`. --- cc @stamblerre FYI @leitzler
NeedsFix
low
Critical
554,929,072
pytorch
[FYI] MultiheadAttention / Transformer
### This issue is created to track the progress to refine `nn.MultiheadAttention` and `nn.Transformer`. Since the release of both modules in PyTorch v1.2.0, we have received a lot of feedback from users, including feature requests, bug fixes and doc improvement. Here is a quick summary of the work items. Feel free to comment if you have any suggestions. #### NOTE: Help wanted: Please create an issue and wait on feedback before working on them. This way you won't create a PR we can't accept for some fundamental reasons. #### Working items - [ ] Decompose `multi_head_attention_forward` functional in `torch.nn.functional`. For example, an individual operator for the standard scaled dot product function, in/out projection operator, self-attention module https://github.com/pytorch/text/pull/720 - [ ] Add quantization support. #32764 Currently, it is blocked by the indexing function [here](https://github.com/pytorch/pytorch/blob/ef5637f85e43dff55b03276176ba2949bd83a085/torch/nn/functional.py#L3272-L3350) - [ ] The `multi_head_attention_forward` functional is too long to understand. It's also too difficult to modify some parts in the function. The function maintains too many branches. https://github.com/pytorch/text/pull/720 - [ ] Fix the dimension convention for masks in Transformer (Propose to use (N, S, E), instead of (S, N, E). Requested by https://github.com/pytorch/pytorch/issues/25132, https://github.com/pytorch/pytorch/issues/25100. PR https://github.com/pytorch/pytorch/pull/37597 #### Resolved issues - [x] Support ByteTensor for `key_padding_mask` and `attn_mask` in `nn.MultiheadAttention`. Requested by Fairseq - [x] 3D attention mask in `nn.MultiheadAttention`. Requested by https://github.com/pytorch/pytorch/pull/25359, https://github.com/pytorch/pytorch/issues/29520, https://github.com/pytorch/pytorch/issues/30678, https://github.com/pytorch/pytorch/issues/24461. Merged in https://github.com/pytorch/pytorch/pull/31996 - [x] Add TorchScript support for `nn.MultiheadAttention` and `nn.Transformer`. In the master branch now. Will be released in v1.5.0 - [x] Add gelu activation func to Transformer for BERT model. Merged in https://github.com/pytorch/pytorch/pull/24181 - [x] MultiheadAttention's compatibility with DDP. Merged in https://github.com/pytorch/pytorch/issues/26698 - [x] `float` and `double` precision in MultiheadAttention module https://github.com/pytorch/pytorch/issues/34060, https://github.com/pytorch/pytorch/issues/33841 #### Open issues - [ ] Flexibility to change the norm func in TransformerEncoderLayer and TransformerDecoderLayer https://github.com/pytorch/pytorch/issues/26342. The order of layer normalization in Transformer https://github.com/pytorch/pytorch/issues/21876, https://github.com/pytorch/pytorch/issues/24930. Users has the flexibility to pass custom encoder/decoder layers to the transformer modules. Update the doc to explain it https://github.com/pytorch/pytorch/pull/32373 - [ ] Fix the constraint that embed_dim should be equal to the dimension of key and value. Explore adding new arguments in `multi_head_attention_forward` functional - requested by Fairseq - [ ] Move the func `generate_square_subsequent_mask ` out of the transformer module https://github.com/pytorch/pytorch/pull/25538 - [ ] Doc update https://github.com/pytorch/pytorch/issues/28719, https://github.com/pytorch/pytorch/issues/28657 - [ ] Additional attention layers (e.g. AugmentedConv, StandAloneAttention) - need research https://github.com/pytorch/pytorch/issues/32529 - [ ] Add embedding layer and positional encoding layer in Transformer https://github.com/pytorch/pytorch/issues/24826
proposal accepted,module: nn,triaged
medium
Critical
554,931,444
youtube-dl
HiDive - fails to download correct subtitle file or detect multiple subtitle files
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.01.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that all URLs and arguments with special characters are properly quoted or escaped as explained in http://yt-dl.org/escape. - Search the bugtracker for similar issues: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a broken site support - [x] I've verified that I'm running youtube-dl version **2020.01.24** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that all URLs and arguments with special characters are properly quoted or escaped - [x] I've searched the bugtracker for similar issues including closed ones ## Verbose log <!-- Provide the complete verbose output of youtube-dl that clearly demonstrates the problem. Add the `-v` flag to your command line you run youtube-dl with (`youtube-dl -v <your command line>`), copy the WHOLE output and insert it below. It should look similar to this: [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2020.01.24 [debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2 [debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4 [debug] Proxy map: {} <more lines> --> ``` $ youtube-dl -v --write-sub --all-subs -f worst "https://www.hidive.com/stream/food-wars/s01e001" [debug] System config: [] [debug] User config: [u'--no-call-home'] [debug] Custom config: [] [debug] Command-line args: [u'-v', u'--write-sub', u'--all-subs', u'-f', u'worst', u'https://www.hidive.com/stream/food-wars/s01e001'] [debug] Encodings: locale UTF-8, fs UTF-8, out UTF-8, pref UTF-8 [debug] youtube-dl version 2020.01.24 [debug] Python version 2.7.17 (CPython) - Linux-4.15.0-74-generic-x86_64-with-Ubuntu-18.04-bionic [debug] exe versions: ffmpeg 3.4.6, ffprobe 3.4.6, phantomjs 2.1.1, rtmpdump 2.4 [debug] Proxy map: {} [HiDive] food-wars/s01e001: Downloading JSON metadata [HiDive] food-wars/s01e001: Downloading m3u8 information [HiDive] food-wars/s01e001: Downloading m3u8 information [HiDive] food-wars/s01e001: Downloading m3u8 information [info] Writing video subtitles to: food-wars_s01e001-food-wars_s01e001.en.vtt [debug] Invoking downloader on u'https://www.hidive.com/manifest/child/44e859ea5112f40a78407113c08a1dd9a0fd6096/FDW_s01e001_tv_or_na_ja_xx_HLS360p_16x9_00_v.m3u8' [hlsnative] Downloading m3u8 manifest [hlsnative] Total fragments: 151 [download] Destination: food-wars_s01e001-food-wars_s01e001.mp4 [download] 100% of 145.63MiB in 03:31 [debug] ffmpeg command line: ffprobe -show_streams 'file:food-wars_s01e001-food-wars_s01e001.mp4' [ffmpeg] Fixing malformed AAC bitstream in "food-wars_s01e001-food-wars_s01e001.mp4" [debug] ffmpeg command line: ffmpeg -y -loglevel 'repeat+info' -i 'file:food-wars_s01e001-food-wars_s01e001.mp4' -c copy -f mp4 '-bsf:a' aac_adtstoasc 'file:food-wars_s01e001-food-wars_s01e001.temp.mp4' ``` ## Description <!-- Provide an explanation of your issue in an arbitrary form. Provide any additional information, suggested solution and as much context and examples as possible. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> I'm trying to download a video from HiDive with the Japanese audio and English subtitles. However, it only downloads a limited subtitle file intended to accompany the English dub audio. This .vtt file contains Caption lines (for translating on-screen text and song lyrics) but not Subtitle lines (for translating spoken text). Even using --all-subs, it only detects and downloads this Captions subtitle file. The full Subtitle file definitely exists, and appears in the browser requests. For comparison, it can be found at <https://www.hidive.com/caption/vtt/d40c35ce045ef78d47fe727b3690ad27b4d1f8a9/FDW_s01e001_tv_hv_or_ja_en_v02.vtt>. The output of --list-subs only shows one entry for English. If you look at the example URL, there are not only multiple English subtitles but other foreign-language versions which the youtube-dl extractor doesn't detect. Example: ``` $ youtube-dl --list-subs "https://www.hidive.com/stream/food-wars/s01e001" [HiDive] food-wars/s01e001: Downloading JSON metadata [HiDive] food-wars/s01e001: Downloading m3u8 information [HiDive] food-wars/s01e001: Downloading m3u8 information [HiDive] food-wars/s01e001: Downloading m3u8 information Available subtitles for food-wars/s01e001: Language formats en vtt, vtt, vtt ``` My guess is that "vtt, vtt, vtt" means it's interpreting three separate English-language .vtt subtitle files as if they were separate formats of the same file (a problem, since you can't select between them using --sub-lang), and it's failing to detect the Portuguese and Spanish subs entirely.
geo-restricted
low
Critical
554,953,562
flutter
Unreadable error message, red font in powershell
## Steps to Reproduce <!-- You must include full steps to reproduce so that we can reproduce the problem. --> 1. Run ``` flutter create bug cd bug flutter run -d chrome ``` 2. Update the files as follows: Add `var c = 1 + 'a';` in a widget build. 3. Press R in powershell **Expected results:** readable font colors in errors **Actual results:** unreadable font colors in errors Here is a screenshot, ![Capture](https://user-images.githubusercontent.com/6107051/73103924-19d85280-3eed-11ea-8de3-0ecf3129a740.PNG)
tool,platform-windows,a: quality,has reproducible steps,P3,found in release: 3.0,found in release: 3.1,team-tool,triaged-tool
low
Critical
554,962,876
flutter
URL provided to report issue should not have a dot at the end
You can see below that an url to https://github.com/flutter/flutter/issues have been provided. However, it has a dot at the end and so when clicking on it, the browser gave me a 404. > :\repos\hotcheapdeal>flutter generate > generating build script... 37.6s > starting build daemon... 0.2s > > Sending crash report to Google. > Crash report sent (report ID: 8e59f442adf107b6) > Oops; flutter has exited unexpectedly. > > Crash report written to C:\repos\hotcheapdeal\flutter_01.log; > please let us know at https://github.com/flutter/flutter/issues.
tool,framework,c: proposal,a: error message,a: triage improvements,P3,team-framework,triaged-framework
low
Critical
554,967,473
flutter
[fuchsia] Write a test for exposed handles in dart:fuchsia
There are a few handles exposed in`fuchsia.dart` in `dart:fuchsia`. To write tests for these, it would be useful to have the ability to invoke dart fixtures. This will be enabled by the work that @gw280 is doing on shell_unittests on Fuchsia. The intent of this issue is to track the writing of these tests.
engine,platform-fuchsia,P2,team-engine,triaged-engine
low
Minor
554,974,823
go
x/build: get more coverage with the ssacheck builder
The ssacheck builder currently builds only amd64, and with a fixed random seed. We should improve on both dimensions. * CL 216418 lets us provide a random seed. We could generate the random seed and print it to stdout before using it, so that any failure will be reproducible from the log. * We should either run on all architectures, or pick one at random each time from `go tool dist list` (and log it, for reproducibility). I suspect that doing both of these things is pretty easy, and it'd get us extra test coverage, so it'd be nice to do soon. This would have caught both https://github.com/golang/go/issues/36723 and https://github.com/golang/go/issues/36755. cc @cherrymui @randall77 @dmitshur @bradfitz
Builders,NeedsInvestigation
low
Critical
554,993,002
godot
parsing a json will pass the json non fatal parse error in the debug
as of #33201 i think json parse errors are returned to the dialogue window, however they are not filtered, making non fatal errors appear there, that actually are a bit misleading to read and do not cause any issue in the paring result dictionary sometimes when loading _settings from file (attempting to parse an empty line) ``` E 0:00:03.694 GDScriptFunctions::call: Error parsing JSON at line 0: <C++ Source> modules\gdscript\gdscript_functions.cpp:1263 @ GDScriptFunctions::call() ``` when calling parse on a http response: `var jsonresult = JSON.parse(body.get_string_from_utf8())` (attempting to parse an OK response before the json text) ``` E 0:00:06.298 parse: Error parsing JSON at line 0: Expected 'true','false' or 'null', got 'OK'. <C++ Source> core/bind/core_bind.cpp:3220 @ parse() <Stack Trace> HTTPOnlineRecords.gd:65 @ _on_HTTPOnlineRecords_request_completed() ```
bug,topic:core
low
Critical
554,993,294
opencv
videoio tests causing out of memory error on x86 - Alpine Linux
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). Please: * Read the documentation to test with the latest developer build. * Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue. * Try to be as detailed as possible in your report. * Report only one problem per created issue. This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> ##### System information (version) <!-- Example - OpenCV => 3.1 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2015 --> - OpenCV => 4.2.0 - Operating System / Platform => x86 32b, Alpine Linux ``` >>> Host system information (arch: x86, release: edge) <<< - Number of Cores: 48 - Memory: 62.6387 Gb - Free space: 57.4G ``` - Compiler => GCC 9.2.0 ##### Detailed description This is appearing in the test log: ``` 10: [----------] 11 tests from videoio/videoio_ffmpeg 10: [ RUN ] videoio/videoio_ffmpeg.write_big/0, where GetParam() = ("", "avi", 4096x4096) 10: [ OK ] videoio/videoio_ffmpeg.write_big/0 (2013 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/1, where GetParam() = ("DX50", "avi", 4096x4096) 10: [ OK ] videoio/videoio_ffmpeg.write_big/1 (4965 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/2, where GetParam() = ("FLV1", "avi", 4096x4096) 10: [ OK ] videoio/videoio_ffmpeg.write_big/2 (4956 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/3, where GetParam() = ("H261", "avi", 352x288) 10: [ OK ] videoio/videoio_ffmpeg.write_big/3 (31 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/4, where GetParam() = ("H263", "avi", 704x576) 10: [ OK ] videoio/videoio_ffmpeg.write_big/4 (124 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/5, where GetParam() = ("I420", "avi", 4096x4096) 10: [ OK ] videoio/videoio_ffmpeg.write_big/5 (3060 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/6, where GetParam() = ("MJPG", "avi", 4096x4096) 10: [ OK ] videoio/videoio_ffmpeg.write_big/6 (14058 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/7, where GetParam() = ("mp4v", "avi", 4096x4096) 10: [ OK ] videoio/videoio_ffmpeg.write_big/7 (4945 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/8, where GetParam() = ("MPEG", "avi", 720x576) 10: [ OK ] videoio/videoio_ffmpeg.write_big/8 (202 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/9, where GetParam() = ("XVID", "avi", 4096x4096) 10: [ OK ] videoio/videoio_ffmpeg.write_big/9 (4946 ms) 10: [ RUN ] videoio/videoio_ffmpeg.write_big/10, where GetParam() = ("H264", "mp4", 4096x2160) 10: OpenCV: FFMPEG: tag 0x34363248/'H264' is not supported with codec id 27 and format 'mp4 / MP4 (MPEG-4 Part 14)' 10: OpenCV: FFMPEG: fallback to use tag 0x31637661/'avc1' 10: x264 [error]: malloc of size 22996992 failed 10: Could not open codec 'libx264': Unspecified error 10: [ SKIP ] H264/mp4 codec is not supported - SKIP 10: [ OK ] videoio/videoio_ffmpeg.write_big/10 (270 ms) 10: [----------] 11 tests from videoio/videoio_ffmpeg (39570 ms total) 10: 10: [----------] 3 tests from videoio_container 10: [ RUN ] videoio_container.read/0, where GetParam() = (FFMPEG, "video/big_buck_bunny", "h264", "h264", "h264", "I420") 10: Checking extracted video stream: /tmp/__opencv_temp.bDNmnD.test_container_stream.h264 (size: 459111 bytes) 10: [h264 @ 0x5945a7f0] get_buffer() failed 10: [h264 @ 0x5945a7f0] thread_get_buffer() failed 10: [h264 @ 0x5945a7f0] decode_slice_header error 10: [h264 @ 0x5945a7f0] no frame! 10: [h264 @ 0x59472810] Error splitting the input into NAL units. 10: [h264 @ 0x5948a830] Error splitting the input into NAL units. 10: [h264 @ 0x594a2850] Error splitting the input into NAL units. 10: [h264 @ 0x594ba870] Error splitting the input into NAL units. 10: [h264 @ 0x594d2890] Error splitting the input into NAL units. 10: [h264 @ 0x594ea8b0] Error splitting the input into NAL units. 10: [h264 @ 0x595028d0] Error splitting the input into NAL units. 10: [h264 @ 0x5951a8f0] Error splitting the input into NAL units. 10: [h264 @ 0x59532910] Error splitting the input into NAL units. 10: [h264 @ 0x5954a930] Error splitting the input into NAL units. 10: [h264 @ 0x59562950] Error splitting the input into NAL units. 10: [h264 @ 0x5957a970] Error splitting the input into NAL units. 10: [h264 @ 0x59592990] Error splitting the input into NAL units. 10: [h264 @ 0x595aa9b0] Error splitting the input into NAL units. 10: [h264 @ 0x595c29d0] Error splitting the input into NAL units. 10: [h264 @ 0x595da9f0] Error splitting the input into NAL units. 10: [h264 @ 0x595f2a10] Error splitting the input into NAL units. 10: [h264 @ 0x5960aa30] Error splitting the input into NAL units. 10: [h264 @ 0x59622a50] Error splitting the input into NAL units. 10: [h264 @ 0x5963aa70] Error splitting the input into NAL units. 10: [h264 @ 0x59652a90] Error splitting the input into NAL units. 10: [h264 @ 0x5966aab0] Error splitting the input into NAL units. 10: [h264 @ 0x59682ad0] Error splitting the input into NAL units. 10: [h264 @ 0x5969aaf0] Error splitting the input into NAL units. 10: [h264 @ 0x596b2b10] Error splitting the input into NAL units. 10: [h264 @ 0x596cab30] Error splitting the input into NAL units. 10: [h264 @ 0x596e2b50] Error splitting the input into NAL units. 10: [h264 @ 0x596fab70] Error splitting the input into NAL units. 10: [h264 @ 0x59712b90] Error splitting the input into NAL units. 10: [h264 @ 0x5972abb0] Error splitting the input into NAL units. 10: [h264 @ 0x59742bd0] Error splitting the input into NAL units. 10: [h264 @ 0x5975abf0] Error splitting the input into NAL units. 10: [h264 @ 0x59772c10] Error splitting the input into NAL units. 10: [h264 @ 0x5978ac30] Error splitting the input into NAL units. 10: [h264 @ 0x597a2c50] Error splitting the input into NAL units. 10: [h264 @ 0x597bac70] Error splitting the input into NAL units. 10: [h264 @ 0x597d2c90] Error splitting the input into NAL units. 10: [h264 @ 0x597eacb0] Error splitting the input into NAL units. 10: [h264 @ 0x59802cd0] Error splitting the input into NAL units. 10: [h264 @ 0x5981acf0] Error splitting the input into NAL units. 10: [h264 @ 0x59832d10] Error splitting the input into NAL units. 10: [h264 @ 0x5984ad30] Error splitting the input into NAL units. 10: [h264 @ 0x59366570] get_buffer() failed 10: [h264 @ 0x59366570] thread_get_buffer() failed 10: [h264 @ 0x59366570] decode_slice_header error 10: [h264 @ 0x59366570] no frame! 10: [h264 @ 0x58ece440] get_buffer() failed 10: [h264 @ 0x58ece440] thread_get_buffer() failed 10: [h264 @ 0x58ece440] decode_slice_header error 10: [h264 @ 0x58ece440] no frame! 10: ../modules/videoio/test/test_ffmpeg.cpp:161: Failure 10: Value of: capActual.read(actual) 10: Actual: false 10: Expected: true 10: 1 10: [ FAILED ] videoio_container.read/0, where GetParam() = (FFMPEG, "video/big_buck_bunny", "h264", "h264", "h264", "I420") (106 ms) 10: [ RUN ] videoio_container.read/1, where GetParam() = (FFMPEG, "video/big_buck_bunny", "h265", "h265", "hevc", "I420") 10: Checking extracted video stream: /tmp/__opencv_temp.cFAIbJ.test_container_stream.h265 (size: 183260 bytes) 10: ../modules/videoio/test/test_ffmpeg.cpp:161: Failure 10: Value of: capActual.read(actual) 10: Actual: false 10: Expected: true 10: 1 10: [ FAILED ] videoio_container.read/1, where GetParam() = (FFMPEG, "video/big_buck_bunny", "h265", "h265", "hevc", "I420") (152 ms) 10: [ RUN ] videoio_container.read/2, where GetParam() = (FFMPEG, "video/big_buck_bunny", "mjpg.avi", "mjpg", "MJPG", "I420") 10: Checking extracted video stream: /tmp/__opencv_temp.OHEiiK.test_container_stream.mjpg (size: 1757521 bytes) 10: [ OK ] videoio_container.read/2 (813 ms) 10: [----------] 3 tests from videoio_container (1071 ms total) 10: 10: [----------] 11 tests from videoio/videoio_gstreamer 10: [ RUN ] videoio/videoio_gstreamer.read_write/0, where GetParam() = ("video/x-raw, format=BGR", 640x480, 640x480, 4) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/0, where GetParam() = ("video/x-raw, format=BGR", 640x480, 640x480, 4) (21 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/1, where GetParam() = ("video/x-raw, format=GRAY8", 640x480, 640x480, 8) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/1, where GetParam() = ("video/x-raw, format=GRAY8", 640x480, 640x480, 8) (18 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/2, where GetParam() = ("video/x-raw, format=UYVY", 640x480, 640x480, 107) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/2, where GetParam() = ("video/x-raw, format=UYVY", 640x480, 640x480, 107) (18 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/3, where GetParam() = ("video/x-raw, format=YUY2", 640x480, 640x480, 115) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/3, where GetParam() = ("video/x-raw, format=YUY2", 640x480, 640x480, 115) (17 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/4, where GetParam() = ("video/x-raw, format=YVYU", 640x480, 640x480, 117) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/4, where GetParam() = ("video/x-raw, format=YVYU", 640x480, 640x480, 117) (23 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/5, where GetParam() = ("video/x-raw, format=NV12", 640x480, 640x720, 90) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/5, where GetParam() = ("video/x-raw, format=NV12", 640x480, 640x720, 90) (17 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/6, where GetParam() = ("video/x-raw, format=NV21", 640x480, 640x720, 92) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/6, where GetParam() = ("video/x-raw, format=NV21", 640x480, 640x720, 92) (17 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/7, where GetParam() = ("video/x-raw, format=YV12", 640x480, 640x720, 98) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/7, where GetParam() = ("video/x-raw, format=YV12", 640x480, 640x720, 98) (18 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/8, where GetParam() = ("video/x-raw, format=I420", 640x480, 640x720, 100) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/8, where GetParam() = ("video/x-raw, format=I420", 640x480, 640x720, 100) (18 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/9, where GetParam() = ("video/x-bayer", 640x480, 640x480, 48) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10: unknown file: Failure 10: C++ exception with description "OpenCV(4.2.0) ../modules/core/src/alloc.cpp:73: error: (-4:Insufficient memory) Failed to allocate 1237776 bytes in function 'OutOfMemoryError' 10: " thrown in the test body. 10: [ FAILED ] videoio/videoio_gstreamer.read_write/9, where GetParam() = ("video/x-bayer", 640x480, 640x480, 48) (16 ms) 10: [ RUN ] videoio/videoio_gstreamer.read_write/10, where GetParam() = ("jpegenc ! image/jpeg", 640x480, 640x480, 4) 10: [ WARN:0] global ../modules/videoio/src/cap_gstreamer.cpp (935) open OpenCV | GStreamer warning: Cannot query video position: status=1, value=0, duration=-1 10/15 Test #10: opencv_test_videoio ..............***Exception: SegFault 62.85 sec ``` Could it be that the ffmpeg test `videoio/videoio_ffmpeg.write_big` is hitting an error and then not freeing its memory, causing the rest of the test to hit out of memory errors? Full build log, as always: [job3.log](https://github.com/opencv/opencv/files/4111102/job3.log) Should the write big test perhaps be skipped on 32b architecture? ##### Steps to reproduce Compile with tests, ffmpeg and gstreamer on 32b x86 Alpine Linux machine. (I only have access to CI build infrastructure)
priority: low,category: videoio
low
Critical
554,998,657
godot
Reading pixels of an image from two threads causes errors
Godot 3.2 rc3 Windows 10 64 bits I need to read pixels of an image from multiple threads at once. Since it internally uses a `Write` lock, my expectation was that `lock()` would trigger copy-on-write if it's already locked by another thread. But instead, it produces errors: ``` ERROR: Image must be locked with 'lock()' before using get_pixel(). At: core/image.cpp:2389 ``` I am calling `lock()` and `unlock()` properly so it must be something else (unless I misunderstand how to use `Image`?). I originally had this issue in C++ while developping a module in a much more heavy reading routine, which resulted in huge error spam and eventual crash, here `alloc` is null: ![image](https://user-images.githubusercontent.com/1311555/73110943-316d0680-3f00-11ea-9e73-a08cf2253e67.png) I had a peek at the state of the Write struct when `get_pixel` is called: the pointer to pixels became null. Reproduction project: [ImageReadInTwoThreads.zip](https://github.com/godotengine/godot/files/4111164/ImageReadInTwoThreads.zip)
enhancement
low
Critical
555,006,502
rust
Add note for to clarify trait restriction for function if we get (in my example "borrow as mutable" error)
Code example https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=63c770ffce3c7420dd845653f7250b9f We can try brute force all implementation, dropping trait restriction: for generic type for concrete type If we find some implementation which allow you to get rid of this error (or maybe from all errors). We can provide note with candidates and fix for restriction
C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics,D-papercut
low
Critical
555,008,423
vscode
Settings can not show up in search when they are not included in settingsLayout.ts
- Add a setting, excluded from settingsLayout.ts, e.g. `timeline.showView` - It shows up when I search `time` but not `timel` - Make sure that there is no bad underlying bug...
bug,debt,settings-editor
low
Critical
555,013,189
excalidraw
suggestion: moving to a border of the viewport while resizing/selecting triggers scrolling
enhancement
low
Minor
555,013,501
create-react-app
Allow `devDependencies` in template.json
### Is your proposal related to a problem? N/A <!-- Provide a clear and concise description of what the problem is. For example, "I'm always frustrated when..." --> ### Describe the solution you'd like Allow a user to state deveDependencies for a template by setting devDependencies in the template.json <!-- Provide a clear and concise description of what you want to happen. --> ### Describe alternatives you've considered <!-- Let us know about other solutions you've tried or researched. --> ### Additional context <!-- Is there anything else you can add about the proposal? You might want to link to related issues here, if you haven't already. -->
issue: proposal,needs triage
low
Major
555,027,229
TypeScript
Revaluate default props behavior in JSX functional components
Regarding the recognition of default initializers as part of type checking on functional components, I believe issues #32402 and #31247 should be reevaluated in the light of #34547 and the potential deprecation of defaultProps, and also on the own merits of both issues. **TypeScript Version:** 3.7.5 **Search Terms:** defaulProps, FunctionalComponent, JSX, React **Code** View issues #32402 and #31247 **Expected behavior:** View issues #32402 and #31247 **Actual behavior:** View issues #32402 and #31247 **Playground Link:** View issues #32402 and #31247 **Related Issues:** Issues #32402 and #31247 =D
Suggestion,Needs Proposal
low
Minor
555,036,619
godot
[GDNative] Misleading godot_x_new_copy/operator_equal functions for array/dictionary/pool arrays
I order to copy an array (same thing for a dictionary and pool array) you should use `godot_array_new_copy` array... but if you want to *copy* the array you should use `godot_array_duplicate` ! :trollface: The difference comes from the fact godot_array is a cheap structure pointing on a ref counted vector. Using `godot_array_new_copy` only copy the cheap structure where `godot_array_duplicate` also copy the vector. In the first case we end up with a single array referenced by two godot_array variables, in the second we have two totally different arrays each referenced by their own godot_array variable. This is even worst for pool arrays given they don't provide duplicate function, so user reading the api is really enclined to think `godot_pool_x_array_new_copy` *is* the way to do a duplication ! I personally got bitten by this multiple times, so I guess we should try to clarify a bit the naming here. I guess renaming `godot_x_new_copy` into `godot_x_new_reference` would be enough, what do you think ?
bug,topic:gdextension
low
Minor
555,052,266
opencv
OpenCV java vm crashes should be avoided
##### System information (version) - OpenCV 3.4.8 - Operating System / Platform => MacOS HighSierra 10.13.6 - Compiler => Oracle Java 1.8.0_152 ##### Detailed description At http://wiki.bitplan.com/index.php/OpenCV#Issues you'll find two issues that crash the Java VM when a problem occurs in the OpenCV dynamically linked library. The expected behavior would be not to crash the VM but throw a normal java runtime exception. ##### Steps to reproduce The second example seems to be simpler to reproduce. Try opening a video-image connection to a server refusing it. E.g. an mjpegstreamer device.
bug,category: java bindings,incomplete,needs reproducer
low
Critical
555,056,079
godot
Child in ScrollContainer can be moved when its size is not bigger than the ScrollContainer's size
**Godot version:** 3.2 rc 2 **OS/device including version:** **Issue description:** **Steps to reproduce:** 1 add a scrollcontainer, set the rect_size to 1080 X 1080 2 add a colorrect as a child of scrollcontainer, and set the size to 1080 X 1080 3 the colorrect can be dragged around a very large distance Even when the child's size is less than the scrollcontainer's, it still can be dragged. In 3.1, when the size is the same, the movement is very tiny, it's acceptable if take the size of bar int consideration . **Minimal reproduction project:**
bug,topic:gui
low
Minor
555,058,185
pytorch
Logical AND and OR for Tensors in C++ API.
## πŸš€ Feature The `at::Tensor` datatype does not have `&` overloaded the way it is in the python API, thus not allowing for boolean element-wise operations between tensors. ## Motivation I want to call the `at::where()` function with a boolean tensor that is the outcome of the AND of two conditions. ## Pitch Something like this should be possible: ``` c++ auto output = at::where((target > -EPSILON) & (target < EPSILON), all_zeros, whatever_values); ``` ## Alternatives This is ugly and tedious IMO: ``` c++ auto output = at::where(target > -EPSILON, output_pos, zeros); output = at::where(output < EPSILON, zeros, output_pos); ``` cc @yf225 @glaringlee
module: cpp,triaged,function request
low
Minor
555,064,603
go
net/http: http.Client.Do() sometimes throws INTERNAL_ERROR when using high number of parallel HTTP/2 requests (regression between 1.12 and 1.13.4)
### What version of Go are you using (`go version`)? ``` go version go1.13.4 darwin/amd64 ``` (also reproduced with 1.13.6) ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? ``` GO111MODULE="off" GOARCH="amd64" GOBIN="" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/Cellar/go/1.13.4/libexec" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/Cellar/go/1.13.4/libexec/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/k7/jx2bs5q170z4lvdzbsdt426r0000gn/T/go-build634112063=/tmp/go-build -gno-record-gcc-switches -fno-common" ``` ### What did you do? Create several http.Clients, and call a high number of simultaneous multipart byterange requests on each of them. Make sure the server supports HTTP/2. ### What did you expect to see? No errors being thrown. Which is the case on Go 1.12 ### What did you see instead? On Go 1.13.4 and 1.13.6, http.Do() sometimes returns an error of the form `stream error: stream ID 523; INTERNAL_ERROR`. It does seem to happen more often when there is some network congestion, but I've also observed it on very good networks. Typically, I'd say it happens once every 200 requests or so.
NeedsInvestigation
low
Critical
555,071,305
go
archive/zip: FileHeader struct lacks Unicode Path Extra Field (0x7075)
### What version of Go are you using (`go version`)? <pre> $ go version go1.13.6 windows/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> set GO111MODULE= set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\npanin\AppData\Local\go-build set GOENV=C:\Users\npanin\AppData\Roaming\go\env set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GONOPROXY= set GONOSUMDB= set GOOS=windows set GOPATH=C:\GoProjects set GOPRIVATE= set GOPROXY=https://proxy.golang.org,direct set GOROOT=C:\Go set GOSUMDB=sum.golang.org set GOTMPDIR= set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64 set GCCGO=gccgo set AR=ar set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD= set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0 -fdebug-prefix-map=C:\Users\npanin\AppData\Local\Temp\go-build726899154=/tmp/go-build -gno-record-gcc-switches </pre></details> ### What did you do? Tried to read ZIP file with unicode filename using archive/zip package ### What did you expect to see? FileHeader struct field to store Unicode Path Extra Field as described in 4.6.9 of https://pkware.cachefly.net/webdocs/casestudies/APPNOTE.TXT ### What did you see instead? No way to retrieve Unicode Path Extra Field except for manually parsing it from FileHeader.Extra field
NeedsInvestigation
low
Critical
555,086,027
go
crypto/ed25519: doc of Sign should warn not to prehash messages
Typically, digital signature schemas require the user to first hash the payload and then sign it. Correct me if I am wrong, but this should be true for RSA, DSA and ECDSA. If my understanding is right, ED25519 seems to be different: it already hashes the message in a way that the collision resistant property is guaranteed even when it becomes feasible to find a collision for SHA512. Thus, prehashing the input messages basically nullifies this collision resistant property of ED25519 itself. In fact, if a possible attacker can efficiently find a collision for the prehashed message, they would be able to carry out a forgery attack. Also, according to [RFC8032 section 8.7](https://tools.ietf.org/html/rfc8032#section-8.7) , it would be better to mention to avoid signing large messages. /cc @FiloSottile @katiehockman
Documentation,help wanted,NeedsFix
low
Minor
555,090,001
flutter
Finished with error: Failed to establish connection with the application instance in Chrome.
I am getting this error when running my project on flutter web: Launching lib\main.dart on Chrome in debug mode... Building application for the web... Attempting to connect to browser instance.. Finished with error: Failed to establish connection with the application instance in Chrome. This can happen if the websocket connection used by the web tooling is unabled to correctly establish a connection, for example due to a firewall.
tool,dependency: dart,customer: crowd,platform-web,P2,team-web,triaged-web
low
Critical
555,091,323
go
gccgo: crash on loop alias reference
### What version of Go are you using (`go version`)? <pre> $ gccgo --version gccgo (Ubuntu 8.3.0-6) 8.3.0 </pre> ### Does this issue reproduce with the latest release? True ### What did you do? ``` type A = *struct { A } ``` ### What did you expect to see? Fails to compile for `invalid recursive type alias`. ### What did you see instead? Crashes.
NeedsInvestigation
low
Critical
555,105,151
puppeteer
Error: Protocol error (Page.captureScreenshot): Unable to capture screenshot when taking screenshot of a large viewport
### Steps to reproduce **Tell us about your environment:** * Puppeteer version: 2.0.0 * Platform / OS version: Windows 10 1903 x64 * Node.js version: 10.17 **What steps will reproduce the problem?** _Please include code that reproduces the issue._ Here is a code snippet that sets large viewport and is trying to take screenshot of that ``` // test.js const puppeteer = require('puppeteer'); class Server { async setup() { if (!this.browser) { this.browser = await puppeteer.launch(); } } async export() { try { await this.setup(); const me = this; const page = await this.browser.newPage(); page.on('error', e => { throw e; }); await page.setContent('<html><head></head><body><h1>test</h1></body></html>'); await page.setViewport({ width : 10000, height : 50000 }); await page.emulateMedia('print'); await page.screenshot({ deviceScaleFactor : 4 }); await this.browser.close(); console.log('browser closed'); } catch (e) { await this.browser.close(); throw e; } } } const srv = new Server(); srv.export() .then(() => process.exit()) .catch(e => { process.exit(1); }); ``` **What is the expected result?** Screenshot taken **What happens instead?** Exception thrown ``` Error: Protocol error (Page.captureScreenshot): Unable to capture screenshot at Promise (...server\node_modules\puppeteer\lib\Connection.js:183:56) at new Promise (<anonymous>) at CDPSession.send (...server\node_modules\puppeteer\lib\Connection.js:182:12) at Page._screenshotTask (...server\node_modules\puppeteer\lib\Page.js:951:39) at process._tickCallback (internal/process/next_tick.js:68:7) -- ASYNC -- at Page.<anonymous> (...server\node_modules\puppeteer\lib\helper.js:111:15) at Server.export (...server\src\utils\screenshot.js:34:24) at process._tickCallback (internal/process/next_tick.js:68:7) ``` Initially I got that exception from a puppeteer which was launched from node express request handler. It failed to take a screenshot of size 700x25000 with same exception. So I tried to figure what's going on and wrote this test script, which worked just fine with same html and same size of the viewport. Then I tried to increase viewport to some ridiculous number and reproduced the problem. So screenshot fails inside node express request handler on a viewport 700x25000 and fails outside of the node express but at much higher viewport size, like 10000x50000 So questions are: 1. Is there a limit to screenshot size which can be taken? 2. If so, how can I calculate that limit? 3. Is there a safe value for viewport? 4. Can you suggest a way to take screenshots of large pages? What comes to my mind is to play with `trasnform: scale()` to fit content into some reasonable viewport, e.g. UHD
bug,upstream,confirmed,P3
high
Critical
555,106,596
svelte
Cannot use yielded value in bind:this inside #each
**Describe the bug** The title is a bit of a mouthful so I think a simple example explains it better: https://svelte.dev/repl/2dc797d2d76b4663987a165f898fdd92?version=3.17.3 ``` <script> let name = 'world'; function* foo() { yield {name: "h", value: 123} yield {name: 'x', value: 333} } let things = {} </script> <h1>Things! {new Date()}</h1> {#each [...foo()] as f,i} <!-- This will crash because of f.name: --> <input bind:this={things[f.name]} value={f.value}> {/each} <pre> This was bound: {JSON.stringify(things, undefined, 2)} </pre> ``` **Logs** No logs, it just hangs **To Reproduce** Run the REPL, the bad code is commented out so it wont crash your browser: https://svelte.dev/repl/2dc797d2d76b4663987a165f898fdd92?version=3.17.3 **Expected behavior** I would be expected to be able to bind:this using a yielded value A strange thing is if I store the list in a new variable which I then use in `#each` it works as expected: ``` const fooList = [...foo()] ... {#each fooList as f,i} ```
bug,awaiting submitter,temp-stale
low
Critical
555,108,082
opencv
GpuMat as input/output to cv::dnn::Net
### System information (version) - OpenCV => 4.2.0 ##### APIs that need changes Suitable APIs for `GpuMat` input: 1. `void setInput(InputArray blob, const String& name = "", double scalefactor = 1.0, const Scalar& mean = Scalar());` Suitable APIs for `GpuMat` output: 1. `void forward(OutputArrayOfArrays outputBlobs, const String& outputName = String());` 2. `void forward(OutputArrayOfArrays outputBlobs, const std::vector<String>& outBlobNames);` Modifications to support `GpuMat`: 1. `void blobFromImage(InputArray image, OutputArray blob, double scalefactor=1.0, const Size& size = Size(), const Scalar& mean = Scalar(), bool swapRB=false, bool crop=false, int ddepth=CV_32F);` Might also require a new API that would allow a stream to be specified (required if `blobFromImage` needs to be performed asynchronously). The CUDA backend uses fully packed tensors everywhere and expects a fully packed tensor as input. `GpuMat` given as input might be using a 2D memory layout which may not be contiguous. `blobFromImage` must return a contiguous copy of the input. The outputs of the CUDA backend are also in fully packed tensors. Hence, for further optimal use of the output (in the case it's an image) would require a transformation to 2D memory layout. ##### Problems: 1. `GpuMat` cannot store an arbitrary number of dimensions. How can the batch of images be passed?
feature,category: gpu/cuda (contrib),RFC,future,category: dnn,effort: few weeks
medium
Critical
555,117,221
flutter
[Cocoon] do not show buttons that the user can't access
If the user is not logged in, don't show the rerun or log button that won't work for them. The behavior today is that the buttons are shown and that clicking them does nothing. I've had it happen where I was logged out and wondering why nothing was happening when I click rerun. /cc @CaseyHillers
c: new feature,team,team-infra,P2,triaged-infra
low
Minor
555,117,489
godot
Update Snapcraft.io version
**Godot version:** 3.1 **OS/device including version:** Ubuntu/KDE Neon and every platform that supports Snaps **Issue description:** When searching for "Godot" on https://snapcraft.io/store this version pops up: https://snapcraft.io/godot-3-1 which looks like a test version and is old. But if you open https://snapcraft.io/godot directly the proper version pops up, which is also outdated, but not listed when you search for it
discussion,platform:linuxbsd,topic:porting
medium
Major
555,127,198
TypeScript
Function declarations inside function expressions should inherit control flow narrowings of the parent function expression
I am trying to avoid typing null checks for properties that are formerly optional on the outer interface, but are then assigned with default values for the whole context of the function body. I used a type guard for it, the problem is that the guarded type is lost in a function, but not lost in an arrow function, even though it can't be hoisted before the type guard. I don't want to introduce new variables for every function parameter in a similar manner and I don't want to call other functions with casting as `printMenu(options as DefinedOptions)`. <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.7.3, 3.8.0-beta <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** typescript type guard function arrow function **Code** ```ts export interface Options { header?: string border?: boolean pageSize?: number helpMessage?: string showKeypress?: boolean } interface DefinedOptions extends Options { pageSize: number helpMessage: string } const isType = <T>(arg: any): arg is T => true export default async function menu(options: Options) { options // Options options.pageSize = options.pageSize ?? 0 options.helpMessage = options.helpMessage ?? 'Default message' if (!isType<DefinedOptions>(options)) return null options // DefinedOptions return new Promise((resolve, reject) => { function handleMenuKeypress(key: any) { options // Options - should be DefinedOptions printMenu(options) // error } const candleMenuKeypress = (key: any) => { options // DefinedOptions printMenu(options) // no error } }) } function printMenu(options: DefinedOptions) { } ``` [Playground Link](http://www.typescriptlang.org/play/?ts=3.8.0-dev.20200124&ssl=1&ssc=1&pln=48&pc=2#code/FAUwHgDg9gTgLgAgJYDs4hgMwIYGMQIDyEcSUKAzggN7AIIAWI2AJhgPwBcCFcMqAczoIARrDYwuoqFAA2zFMIjYBIAMpIAXiCkoArgFsRGYU1kQAsiAoUVO7r34oh9CgygB3ANIgAnhBhrCikxOQVgAF9gYFR0LDwCABEQTFQQFmJScipwdBQWKkyySholOw1tbn0jE3ozSyC7Bz5BSOjcbMQkCgAVfwIAXgQAHh6APgAKbBgBbmwUXwBKOZnkKh6EAbGEPj0QaNBIWEQ2HD1ZRGwKXxRcBEw9W6yUBAMQfQmoEmKKbiLsxalYRfZ5UAD0YKI32y0XoIJ+ADplKoKoMEPDskjyloCOx2AgAAzA6GUBH1Kw2OybdEkihkkDmCm2VQIPEIADkyTOF1ejVU7OESEwCAmAEJun0ICBhly0hlaZMMZRFoDAnA9DAXvpZLIDnDaQgIQhZSh0v9KHqEGqNVqQB4EAAFGBQAzdEATCaBChyABuIAANFaQAArEC4OCArZA+j0B5PYqMeYseRWfQ+fxeigTADWfjmC0BtBjMaV4Mh5qoCAAtK53OcWKIkik5RXYcWEAFYqm9J9aYCjRhnTBhPQoiOEB1KIhcEmU+89OmAkFqTm8wh5ktNtsi+3S4bISazbS28XO2hu73Qf3ISgoAhB7Bx1FR4s2sA4+GE2e4BfS9xD-KV5AhEQA) **Expected behavior:** Type should be `DefinedOptions` in both. **Actual behavior:** Type is `Options` in function but `DefinedOptions` in arrow function. **Related:** #10927
Bug
low
Critical
555,135,193
flutter
Ability to hide a widget subtree in driver tests
Some advanced users of Flutter would like the ability to mask screenshot goldens so that parts of the screenshot are not used when diffing. There's a very tedious way of doing this in g3 infrastructure so customer:dream was wondering if it is possible to add this type of API to driver: ```dart flutter_driver.maskWidget(findByKey('dynamicContent')); ``` which would effectively mark the found widget as "invisible" (but have it still participate in layout).
c: new feature,framework,t: flutter driver,customer: dream (g3),P3,team-framework,triaged-framework
low
Minor
555,138,429
godot
call_deferred does not take a reference to self causing occasional SEGFAULT in release
calling a deferred method of an object which inherits Reference which emits a signal can cause the game to crash because the deferred function gets called after the reference has been freed. See attached example where pressing first button will never call the deferred function and emit a signal. In this simple example it never calls the deferred method, but it's possible to get into that situation. In this case the engine crashes at this line: https://github.com/godotengine/godot/blob/3.1/core/object.cpp#L1528 during emit_signal ( https://github.com/godotengine/godot/blob/3.1/core/object.cpp#L1262 ) [call-deferred-ref.zip](https://github.com/godotengine/godot/files/4112766/call-deferred-ref.zip) I'll try to upload an example later where it does call the deferred method after the object is freed and causes a segfault (in this case the signal_map hashmap can have `elements: 0` but also `hash_table: [random memory]` which causes the engine to crash when it dereferences `hash_table[0]` IMO calling `call_deferred` on an object that inherits `Reference` should hold a reference until the deferred method has been called. (similar to the way `DeferredSignalRefWorkaround` works in the example)
bug,topic:core,crash
low
Critical
555,146,992
material-ui
Feature request: navigation rail
New material component, the navigation rail. - good for 3 to 7 destinations - part of the navigation design spec... see the responsive design section to see how this mixes in with other navigation components https://m3.material.io/components/navigation-rail/overview ## Benchmarks -
new feature,design: material,package: material-ui
medium
Critical
555,147,195
godot
Debugger: variables monitor sections size
**Godot version:** 3.2 rc3 **OS/device including version:** Win 10 **Issue description:** Once upon a time we had tiny displays, when I start working as an IT, I had a 13" inch one, it was cool, lacks of space to show things made all the debugging work funny and really crowded... Now we use to work on 24" and bigger displays, at home we have even 34" widescreen displays... and we still have all crowded because the Debugger Variables Monitor puts a lot of effort in wasting free space for variable "names" section instead of making "value" section bigger and helping coders debugging long-value strings with easer! πŸ˜„ πŸ˜„ πŸ˜„ πŸ˜„ πŸ˜„ πŸ˜„ πŸ˜„ πŸ˜„ Just kidding, but for real, we have big monitors, correct column size please: smaller "variable name" column and wider "variable value" column ![immagine](https://user-images.githubusercontent.com/47447512/73127905-b40cc900-3fc7-11ea-9484-28865734a8b9.png)
enhancement,topic:editor,usability
low
Critical
555,153,282
go
x/tools/gopls: go/packages work-around not activated with empty module cache
This error occurs when querying for references on a type with gopls@8fe064f8 <pre> [Trace - 00:19:52.525 AM] Sending request 'textDocument/references - (15)'. Params: {"textDocument":{"uri":"file:///some/package/file.go"},"position":{"line":59,"character":26},"context":{"includeDeclaration":true}} [Error - 00:19:52.525 AM] Received #15 go [-e -json -compiled=true -test=true -export=false -deps=true -find=false -- ./... builtin]: exit status 2: # pkg-config --cflags -- vips vips vips vips Package vips was not found in the pkg-config search path. Perhaps you should add the directory containing `vips.pc' to the PKG_CONFIG_PATH environment variable Package 'vips', required by 'virtual:world', not found Package 'vips', required by 'virtual:world', not found Package 'vips', required by 'virtual:world', not found Package 'vips', required by 'virtual:world', not found pkg-config: exit status 1 [Trace - 00:20:03.050 AM] Sending request 'shutdown - (16)'. Params: {} [Trace - 00:20:03.051 AM] Received response 'shutdown - (16)' in 0ms. Result: {} [Trace - 00:20:03.051 AM] Sending notification 'exit'. Params: null </pre> As a result of this, no references are being displayed. Whereas the preferred solution would be to ignore the problematic dependency and search for references in the valid ones. It is also possible that other commands fail because of the same error as well.
NeedsDecision,gopls,Tools
medium
Critical
555,188,764
TypeScript
Allow C++-style visibility sections in class bodies
## Search Terms public, shorthand, private ## Suggestion <img width="991" alt="Screen Shot 2020-01-26 at 2 22 29 PM" src="https://user-images.githubusercontent.com/9585787/73132010-78b1df00-4047-11ea-9af7-5c828253287c.png"> See image. Would reduce a lot of clutter for public/private to be consolidated into a group like above. My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Minor
555,191,588
flutter
fast-start breaks common workflows and may be slower in some cases
I have two devices, a Pixel 3 XL and a Lenovo TB 8504F. I run my app with `flutter run -d all`. Here are the timings after several back-to-back runs with no changes: 00:00 `flutter run -d all` 00:04 My app's splash screen shows on the Pixel 3 XL 00:05 Pixel 3 XL shows a message that implies I'm not running under the Flutter debugger. 00:10 My app's splash screen shows on the Lenovo TB 8504F 00:12 Lenovo TB 8504F shows a message that implies I'm not running under the Flutter debugger. 00:23 Pixel 3 XL shows my app. <-- THIS IS WHERE I CAN START TESTING MY APP 00:27 Lenovo TB 8504F shows my app. 00:29 The flutter run help message shows up. Now I run my app with `flutter run -d all -no-fast-start`. Same setup, back-to-back run with no changes: 00:00 `flutter run -d all --no-fast-start` 00:04 My app's splash screen shows on the Pixel 3 XL 00:06 Pixel 3 XL shows my app. <-- THIS IS WHERE I CAN START TESTING MY APP 00:10 My app's splash screen shows on the Lenovo TB 8504F 00:15 Lenovo TB 8504F shows my app. 00:20 The flutter run help message shows up. I see six problems with the new default: 1. It's significantly slower to hit the point I care about (what used to take six seconds now takes 23 seconds). This is true even with just one device (the Pixel 3 XL); a warm-start with fast-start takes about 12 seconds, it takes about 8 seconds with --no-fast-start. Cold start with that one device is also slower; after flutter clean, it takes about 29 seconds with fast-start and about 25 seconds with --no-fast-start. 2. It's significantly slower in general (what used to take 20 seconds now takes 29 seconds). 3. There's a confusing screen that shows up between my app's splash screen and my app running. 4. ...which is especially bad if what I'm testing is my splash screen behaviour (which was the case tonight, as it happens), since it doesn't reflect the actual app's behaviour. 5. (not shown in the timings above) If I then quit the app on the phone and restart it, it just says I'm not running it under a debugger. This is especially problematic if I'm demoing the app, testing start behaviour, or testing background execution behaviour (all things I do regularly). 6. (not shown in the timings above) I see the following error messages in my logs when running with --fast-start: ``` E/flutter (12086): [ERROR:flutter/shell/common/shell.cc(202)] Dart Error: Dart_LookupLibrary: library 'package:android_alarm_manager/android_alarm_manager.dart' not found. E/flutter (12086): [ERROR:flutter/runtime/dart_isolate.cc(466)] Could not resolve main entrypoint function. E/flutter (12086): [ERROR:flutter/shell/common/engine.cc(214)] Could not run the isolate. E/flutter (12086): [ERROR:flutter/shell/common/engine.cc(139)] Engine not prepare and launch isolate. E/flutter (12086): [ERROR:flutter/shell/common/shell.cc(464)] Could not launch engine with configuration. ``` cc @zanderso @jonahwilliams
tool,t: hot reload,a: first hour,P2,team-tool,triaged-tool
low
Critical
555,203,999
godot
Switching scripts with PgUp/PgDn does not work
**Godot version:** 3.2-master **OS/device including version:** Debian buster amd64 **Issue description:** I use Ctrl+PgUp/PgDn to switch between scene tabs. (It's a pretty common shortcut from back in Gnome 2, used in gnome-terminal, firefox, and other programs.) I also want to use it to switch between scripts in the script editor, so I've assigned the same keys to "Previous script" and "Next script" as well. If I press Ctrl+PgUp/PgDn in the script editor: - It does not switch scripts as expected. (And it IS expected, because I'm not in the scene editor!) - It does not switch scene tabs either. - Instead, it behaves exactly the same as PgUp/PgDn without "Ctrl" - meaning, apparently the shortcut is not caught at all. (Or rather, intercepted by the text editor, which doesn't even have any useful actions bound to them!) - However, if I click into the script list, then it works - Ctrl+PgUp/PgDn switches scripts as intended. - If I use another combination of keys for this action, it works. This suggests that this particular shortcut is indeed intercepted by the text editor, for some reason, even if it does not do anything useful. - "Meta+PgUp/PgDn" does not work either. Neither do "Meta+Up/Down". However, "Ctrl+Alt+Up/Down" works! Does the text editor have issues with "Ctrl" and "Meta", or with "PgUp/PgDn"?.. In the "Shortcuts", "Next script"/"Previous script" are listed for "Script Editor" and not "Script Text Editor". However, "Save" is also listed there, and it works even if I'm in the text editor. **Steps to reproduce:** - Assign "Ctrl+PgUp" for "Previous script" and "Ctrl+PgDn" for "Next script" - Open several scripts, put the cursor in the text editor - Try pressing Ctrl+PgUp/PgDn Expected result: switching between open scripts Actual result: the cursor jumping one page up or down in the text editor
bug,topic:editor,confirmed,usability
low
Minor
555,208,459
vscode
Improve discoverability of Compact Folders option
When somebody wants to disable compact folders people rarely search for terms like "compact folders", but rather for "empty folders", "flattened folders" Discoverability of this feature could be improved if - The Settings Search would return Compact Folders for keywords like "empty folders" and "flattened folders" - Or it could ask on the first start
bug,settings-editor,settings-search
low
Major
555,220,943
TypeScript
TypeScript support for .mdx file extensions
# Search Terms - .mdx - mdx - mdx support ## Suggestion Could or would it be on the road map to allow type checking in non .ts files. In my case i'm specifically wondering if TypeScript can type check React components in .mdx files ## Use Cases I've written a gatsby plugin [gatsby-mdx-embed](https://github.com/PaulieScanlon/gatsby-mdx-embed) that allows users to embed media content from YouTube, Twitter, Instagram etc in their .mdx files. The plugin is written in TypeScript and all of the components have props. It would be sweet if when these components are used in .mdx files a user could either see the prop types by hovering over the component or more importantly would get a type error (squiggly line) in their code editor if the prop name is incorrect or of incorrect type. ## Examples Here's an [example](https://github.com/PaulieScanlon/gatsby-mdx-embed/blob/master/demo/src/components/gist.mdx) .mdx file You can below there the Gist component accepts a `gistLink` prop of type string. ``` <Playground> <Gist gistLink="PaulieScanlon/ca0cc9239176066492cb2aba435edbf7" /> </Playground> ``` If a user misspelled `gistLink` or provided a number / array or object etc the editor would alert them there's been an error in the prop type used.
Suggestion,Awaiting More Feedback
high
Critical
555,228,888
godot
Different TextEdit preview on HiDPI display
**Godot version:** 3.2 RC3 **OS/device including version:** macOS 10.15.2 **Issue description:** On a HiDPI display, the TextEdit preview in the editor is inconsistent with the actual one: <img width="331" alt="screenshot" src="https://user-images.githubusercontent.com/372476/73135842-ff83ad80-4081-11ea-9581-7e7c258b362d.png"> As in the screenshot: 1. Only three lines are displayed, while it's all four lines when running 2. The display area (highlighted) shown in the minimap only covers two lines, but it's actually three lines shown in the preview, and four when running **Steps to reproduce:** 1. Open Godot on a HiDPI display, or set the Display Scale to 200% 2. Create a new scene, and add a TextEdit 3. Make four lines of text, and set the size to 120x75, you can also turn on the minimap **Minimal reproduction project:** [TextEditTest.zip](https://github.com/godotengine/godot/files/4113492/TextEditTest.zip)
bug,topic:editor,confirmed,topic:gui
low
Minor
555,239,367
terminal
CreatePseudoConsole doesn't handle sockets correctly
The documentation of `CreatePseudoConsole` explicitly documents that `CreatePseudoConsole` can be used with sockets: https://docs.microsoft.com/en-us/windows/console/creating-a-pseudoconsole-session#preparing-the-communication-channels If we look at the implementation of `CreatePseudoConsole`, we can see it calls `DuplicateHandle` on the handles passed to it: https://github.com/microsoft/terminal/blob/2712e41cad2abcfe627934e41e713ea132a659de/src/winconpty/winconpty.cpp#L348-L349 However, the documentation of `DuplicateHandle` explicitly mentions that `DuplicateHandle` should not be used to duplicate socket handles: https://docs.microsoft.com/en-us/windows/win32/api/handleapi/nf-handleapi-duplicatehandle#remarks Doesn't this make the `CreatePseudoConsole` implementation incorrect when using sockets? I haven't actually confirmed whether sockets work or not, I'm currently trying to get `CreatePseudoConsole` to work with sockets but it's returning `Access is Denied`. While looking at the source code to figure out why it's returning `Access is Denied`, I stumbled upon this possible issue. EDIT: Nvm the `Access is Denied` issue, I incorrectly assumed `CreatePseudoConsole` would return 0 on failure. The `DuplicateHandle` issue still stands however. EDIT2: Removed edit because it was a programming error by me.
Help Wanted,Product-Conpty,Issue-Bug,Priority-1,Area-Quality
low
Critical
555,266,463
flutter
Show contextual selection menu in Flutter Webview
Internal: b/147976818 As done in Google Docs for Android, we'd like to show a custom action on text highlight in our webview. Here is a screenshot to make it more clear: ![image](https://user-images.githubusercontent.com/6687929/73139652-0203ea00-4025-11ea-975e-533c5fd02d20.png) We'd like for example to add an action Edit Link when the user has the cursor positioned inside a </a> element, quite similar to what's done in GDocs on Android. So, as a result, some Dart code should be executed.
c: new feature,p: webview,customer: google,package,c: proposal,team-ecosystem,P2,triaged-ecosystem
low
Major
555,275,119
TypeScript
Unneeded temporary introduced for named class expression with static property initializer
## Search Terms classes, static properties, temporary variable ## Suggestion When a class expression is returned from a function, it gets assigned to a temporary variable that is not needed there. ## Use Cases Less verbose and more clear JavaScript output. ## Examples Input: ```ts const f = () => class { static x = 1; }; const g = () => class _ { static x = 1; }; const h = () => { class _ { static x = 1; } return _; }; ``` Current output (3.7.2) (formatted a little differently): ```js const f = () => { var _a; return _a = class { }, _a.x = 1, _a; }; const g = () => { var _a; return _a = class _ { }, _a.x = 1, _a; }; const h = () => { class _ { }; _.x = 1; return _; }; ``` Desired output: ```js const f = () => { var _a = class { }; _a.x = 1; return _a; }; const g = () => { class _ { } _.x = 1; return _; }; const h = () => { class _ { } _.x = 1; return _; }; ``` ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Bug
low
Minor
555,281,645
go
x/pkgsite: API for pkg.go.dev
Prior to [pkg.go.dev](https://pkg.go.dev), [godoc.org](https://godoc.org) has had a JSON API that can be used to, among other things, discover importers of a given package. Example: https://api.godoc.org/importers/golang.org/x/net/html Given that [pkg.go.dev](https://pkg.go.dev) does a much better job at tracking importers thanks to Go Modules and the Module Proxy, it would be nice if the community could get access to a public API similar to that of [godoc.org](https://godoc.org).
NeedsInvestigation,FeatureRequest,pkgsite
high
Critical
555,288,274
godot
Exporting to android now fails with error code 20
**Godot version:** 72c44bafac6e280b5e1e99b417588624bfb5ecc6 **OS/device including version:** MacOS 10.15.12 **Issue description:** When compiling from 72c44bafac6e280b5e1e99b417588624bfb5ecc6 my android export is now broken where it was successful before. when using a custom build I get this: ``` arguments 0: ./editor/godot.osx.opt.tools.64 1: --path 2: project 3: --export 4: android 5: ../export/android/GameOne.apk Current path: /Users/mattiasmyhrman/Repositories/gameone Godot Engine v3.2.rc.custom_build.7617336d7 - https://godotengine.org OpenGL ES 3.0 Renderer: NVIDIA GeForce GTX 775M OpenGL Engine Registered camera FaceTime HD Camera (Built-in) with id 1 position 0 at index 0 export: begin: Exporting for Android steps: 105 export: end ERROR: _fs_changed: Project export failed with error code 20 for preset 'android'. At: editor/editor_node.cpp:634. ``` When not using a custom build it exports successfully however when pushing to device I get ``` adb: failed to install export/android/GameOne.apk: Failure [INSTALL_FAILED_VERSION_DOWNGRADE] Starting: Intent { act=android.intent.action.MAIN cmp=org.godotengine.gameone/com.godot.game.GodotApp } Error type 3 Error: Activity class {org.godotengine.gameone/com.godot.game.GodotApp} does not exist. ``` Both of these were working in rc1 IIRC so something seems to have happened with the manifest regeneration(?)
enhancement,platform:android,topic:porting,usability
medium
Critical
555,294,038
storybook
Addon-docs: Make syntax-highlighter theme configurable
**Is your feature request related to a problem? Please describe.** React-Syntaxt-Highlighter support a lot of [Prism themes](https://github.com/conorhastings/react-syntax-highlighter/tree/master/src/styles/prism). It would be nice if Storybook provide a way for the user to pick the theme of is choice. **Describe the solution you'd like** One solution would be to make it configurable through SB theme system. Something like: ``` // my-custom-sb-theme.js import { create } from '@storybook/theming/create'; import { darcula } from 'react-syntax-highlighter/dist/esm/styles/prism'; export default create({ base: 'light', .... prismTheme: darcula }); ``` ``` import { addons } from '@storybook/addons'; import myCustomTheme from './my-custom-sb-theme'; addons.setConfig({ theme: myCustomTheme }); ``` **Additional context** https://github.com/storybookjs/storybook/issues/9640 could be tackled with this story
feature request,addon: docs
medium
Major
555,300,596
rust
BufReader::seek -- should this discard the buffer when pos is SeekFrom::Current(0)?
It looks like the stream_position() convenience function is implemented with `stream.seek(SeekFrom::Current(0))`; when called on a BufReader this causes it to discard the inner buffer. Is this expected? Is it possible to have the BufReader in the case of the position being SeekFrom::Current(0) not discard?
T-libs-api,A-io,C-discussion
low
Minor
555,314,104
pytorch
TORCH_CUDA_API export failure on torch::cuda::nccl::detail::throw_nccl_error(ncclResult_t)
## πŸ› Bug When compiling from source `pytorch 1.4.0` the resulting library `libtorch_python.so` is left with an undefined symbol for `torch::cuda::nccl::detail::throw_nccl_error(ncclResult_t)` (`ImportError: /usr/lib/python3.8/site-packages/torch/lib/libtorch_python.so: undefined symbol: _ZN5torch4cuda4nccl6detail16throw_nccl_errorE12ncclResult_t`) ## To Reproduce Steps to reproduce the behavior: 1. compile pytorch from source with CUDA and NCCL 2. try to import torch in python 3. get following error ```python import torch Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python3.8/site-packages/torch/__init__.py", line 81, in <module> from torch._C import * ImportError: /usr/lib/python3.8/site-packages/torch/lib/libtorch_python.so: undefined symbol: _ZN5torch4cuda4nccl6detail16throw_nccl_errorE12ncclResult_t ``` <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior symbol should not be missing from shared library and python should be able to `import torch` successfully ## Environment - PyTorch Version (e.g., 1.0): 1.4.0 - OS (e.g., Linux): ArchLinux x86_64 - How you installed PyTorch (`conda`, `pip`, source): source - Build command you used (if compiling from source): ```bash git submodule update --init --recursive export VERBOSE=1 export PYTORCH_BUILD_VERSION=1.4.0 export PYTORCH_BUILD_NUMBER=1 export USE_MKLDNN=OFF export USE_FFMPEG=ON export USE_GFLAGS=ON export USE_GLOG=ON export BUILD_BINARY=ON export USE_OPENCV=ON export USE_SYSTEM_NCCL=ON export NCCL_ROOT=/usr export NCCL_LIB_DIR=/usr/lib export NCCL_INCLUDE_DIR=/usr/include export NCCL_VERSION=$(pkg-config nccl --modversion) export NCCL_VER_CODE=$(sed -n 's/^#define NCCL_VERSION_CODE\s*\(.*\).*/\1/p' /usr/include/nccl.h) export CUDAHOSTCXX=g++-8 export CUDA_HOME=/opt/cuda export CUDNN_LIB_DIR=/usr/lib export CUDNN_INCLUDE_DIR=/usr/include export TORCH_NVCC_FLAGS="-Xfatbin -compress-all" export TORCH_CUDA_ARCH_LIST="3.2;3.5;3.7;5.0;5.2;5.3;6.0;6.0+PTX;6.1;6.1+PTX;6.2;6.2+PTX;7.0;7.0+PTX;7.2;7.2+PTX;7.5;7.5+PTX" echo "Building with cuda and with non-x86-64 optimizations" export USE_CUDA=1 export USE_CUDNN=1 echo "add_definitions(-march=haswell)" >> cmake/MiscCheck.cmake python setup.py build ``` - Python version: 3.8.1 - CUDA/cuDNN version: 10.2.89 / 7.6.5.32 - GPU models and configuration: NVIDIA GTX 980 - Any other relevant information: ## Additional context ```bash $ LD_PRELOAD=/usr/lib/libnccl.so.2.5.7:/usr/lib/libpython3.8.so.1.0 ldd -d /usr/lib/python3.8/site-packages/torch/lib/libtorch_python.so linux-vdso.so.1 (0x00007ffc73fac000) /usr/lib/libnccl.so.2.5.7 (0x00007f808dd5c000) /usr/lib/libpython3.8.so.1.0 (0x00007f808d99d000) libshm.so => /usr/lib/python3.8/site-packages/torch/lib/libshm.so (0x00007f808d993000) libnvToolsExt.so.1 => /opt/cuda/lib/libnvToolsExt.so.1 (0x00007f808d78a000) libtorch.so => /usr/lib/python3.8/site-packages/torch/lib/libtorch.so (0x00007f80485c2000) libc10_cuda.so => /usr/lib/python3.8/site-packages/torch/lib/libc10_cuda.so (0x00007f8048599000) libc10.so => /usr/lib/python3.8/site-packages/torch/lib/libc10.so (0x00007f8048561000) libglog.so.0 => /usr/lib/libglog.so.0 (0x00007f8048500000) libpthread.so.0 => /usr/lib/libpthread.so.0 (0x00007f80484de000) libcudart.so.10.2 => /opt/cuda/lib/libcudart.so.10.2 (0x00007f8048260000) libstdc++.so.6 => /usr/lib/libstdc++.so.6 (0x00007f8048076000) libm.so.6 => /usr/lib/libm.so.6 (0x00007f8047f30000) libgcc_s.so.1 => /usr/lib/libgcc_s.so.1 (0x00007f8047f14000) libc.so.6 => /usr/lib/libc.so.6 (0x00007f8047d4d000) /usr/lib64/ld-linux-x86-64.so.2 (0x00007f80980f0000) librt.so.1 => /usr/lib/librt.so.1 (0x00007f8047d42000) libdl.so.2 => /usr/lib/libdl.so.2 (0x00007f8047d3d000) libutil.so.1 => /usr/lib/libutil.so.1 (0x00007f8047d38000) libgflags.so.2.2 => /usr/lib/libgflags.so.2.2 (0x00007f8047d11000) libcufft.so.10 => /opt/cuda/lib/libcufft.so.10 (0x00007f803e86f000) libcurand.so.10 => /opt/cuda/lib/libcurand.so.10 (0x00007f803a7cc000) libcublas.so.10 => /opt/cuda/lib/libcublas.so.10 (0x00007f8036516000) libcudnn.so.7 => /usr/lib/libcudnn.so.7 (0x00007f801c9a9000) libgomp.so.1 => /usr/lib/libgomp.so.1 (0x00007f801c970000) libopencv_highgui.so.4.2 => /usr/lib/libopencv_highgui.so.4.2 (0x00007f801c926000) libopencv_optflow.so.4.2 => /usr/lib/libopencv_optflow.so.4.2 (0x00007f801c8a3000) libopencv_videoio.so.4.2 => /usr/lib/libopencv_videoio.so.4.2 (0x00007f801c820000) libavcodec.so.58 => /usr/lib/libavcodec.so.58 (0x00007f801b2b9000) libavformat.so.58 => /usr/lib/libavformat.so.58 (0x00007f801b055000) libavutil.so.56 => /usr/lib/libavutil.so.56 (0x00007f801af37000) libswscale.so.5 => /usr/lib/libswscale.so.5 (0x00007f801aeaa000) libblas.so.3 => /usr/lib/libblas.so.3 (0x00007f801ae51000) liblapack.so.3 => /usr/lib/liblapack.so.3 (0x00007f801a763000) libcusparse.so.10 => /opt/cuda/lib64/libcusparse.so.10 (0x00007f8012afd000) libmagma.so => /usr/lib/libmagma.so (0x00007f7ffd2c0000) libopencv_ximgproc.so.4.2 => /usr/lib/libopencv_ximgproc.so.4.2 (0x00007f7ffd052000) libopencv_imgcodecs.so.4.2 => /usr/lib/libopencv_imgcodecs.so.4.2 (0x00007f7ffcac1000) libopencv_video.so.4.2 => /usr/lib/libopencv_video.so.4.2 (0x00007f7ffca44000) libopencv_calib3d.so.4.2 => /usr/lib/libopencv_calib3d.so.4.2 (0x00007f7ffc86d000) libopencv_features2d.so.4.2 => /usr/lib/libopencv_features2d.so.4.2 (0x00007f7ffc26a000) libopencv_imgproc.so.4.2 => /usr/lib/libopencv_imgproc.so.4.2 (0x00007f7ffab64000) libopencv_flann.so.4.2 => /usr/lib/libopencv_flann.so.4.2 (0x00007f7ffaaf7000) libopencv_core.so.4.2 => /usr/lib/libopencv_core.so.4.2 (0x00007f7ff99f4000) libcublasLt.so.10 => /opt/cuda/lib/libcublasLt.so.10 (0x00007f7ff7b5f000) libGL.so.1 => /usr/lib/libGL.so.1 (0x00007f7ff7ad9000) libQt5Test.so.5 => /usr/lib/libQt5Test.so.5 (0x00007f7ff7a84000) libQt5OpenGL.so.5 => /usr/lib/libQt5OpenGL.so.5 (0x00007f7ff7a2c000) libQt5Widgets.so.5 => /usr/lib/libQt5Widgets.so.5 (0x00007f7ff738a000) libQt5Gui.so.5 => /usr/lib/libQt5Gui.so.5 (0x00007f7ff6ce2000) libQt5Core.so.5 => /usr/lib/libQt5Core.so.5 (0x00007f7ff67aa000) libdc1394.so.25 => /usr/lib/libdc1394.so.25 (0x00007f7ff6731000) libgstreamer-1.0.so.0 => /usr/lib/libgstreamer-1.0.so.0 (0x00007f7ff6623000) libgobject-2.0.so.0 => /usr/lib/libgobject-2.0.so.0 (0x00007f7ff65c7000) libglib-2.0.so.0 => /usr/lib/libglib-2.0.so.0 (0x00007f7ff64a0000) libgstapp-1.0.so.0 => /usr/lib/libgstapp-1.0.so.0 (0x00007f7ff6490000) libgstriff-1.0.so.0 => /usr/lib/libgstriff-1.0.so.0 (0x00007f7ff6480000) libgstpbutils-1.0.so.0 => /usr/lib/libgstpbutils-1.0.so.0 (0x00007f7ff644a000) libswresample.so.3 => /usr/lib/libswresample.so.3 (0x00007f7ff642a000) libvpx.so.6 => /usr/lib/libvpx.so.6 (0x00007f7ff6108000) libwebpmux.so.3 => /usr/lib/libwebpmux.so.3 (0x00007f7ff60fa000) libwebp.so.7 => /usr/lib/libwebp.so.7 (0x00007f7ff608a000) liblzma.so.5 => /usr/lib/liblzma.so.5 (0x00007f7ff6062000) libdav1d.so.3 => /usr/lib/libdav1d.so.3 (0x00007f7ff5f42000) libopencore-amrwb.so.0 => /usr/lib/libopencore-amrwb.so.0 (0x00007f7ff5f2c000) libz.so.1 => /usr/lib/libz.so.1 (0x00007f7ff5f12000) libaom.so.0 => /usr/lib/libaom.so.0 (0x00007f7ff5abb000) libgsm.so.1 => /usr/lib/libgsm.so.1 (0x00007f7ff58af000) libmp3lame.so.0 => /usr/lib/libmp3lame.so.0 (0x00007f7ff5636000) libopencore-amrnb.so.0 => /usr/lib/libopencore-amrnb.so.0 (0x00007f7ff560b000) libopenjp2.so.7 => /usr/lib/libopenjp2.so.7 (0x00007f7ff55ae000) libopus.so.0 => /usr/lib/libopus.so.0 (0x00007f7ff5550000) libspeex.so.1 => /usr/lib/libspeex.so.1 (0x00007f7ff5533000) libtheoraenc.so.1 => /usr/lib/libtheoraenc.so.1 (0x00007f7ff52f4000) libtheoradec.so.1 => /usr/lib/libtheoradec.so.1 (0x00007f7ff50da000) libvorbis.so.0 => /usr/lib/libvorbis.so.0 (0x00007f7ff4eae000) libvorbisenc.so.2 => /usr/lib/libvorbisenc.so.2 (0x00007f7ff4c05000) libx264.so.159 => /usr/lib/libx264.so.159 (0x00007f7ff4949000) libx265.so.179 => /usr/lib/libx265.so.179 (0x00007f7ff36be000) libxvidcore.so.4 => /usr/lib/libxvidcore.so.4 (0x00007f7ff35ab000) libva.so.2 => /usr/lib/libva.so.2 (0x00007f7ff3586000) libmfx.so.1 => /usr/lib/libmfx.so.1 (0x00007f7ff3578000) libxml2.so.2 => /usr/lib/libxml2.so.2 (0x00007f7ff3412000) libbz2.so.1.0 => /usr/lib/libbz2.so.1.0 (0x00007f7ff33ff000) libmodplug.so.1 => /usr/lib/libmodplug.so.1 (0x00007f7ff3272000) libbluray.so.2 => /usr/lib/libbluray.so.2 (0x00007f7ff3222000) libgmp.so.10 => /usr/lib/libgmp.so.10 (0x00007f7ff318f000) libgnutls.so.30 => /usr/lib/libgnutls.so.30 (0x00007f7ff2fc5000) libssh.so.4 => /usr/lib/libssh.so.4 (0x00007f7ff2f5b000) libva-drm.so.2 => /usr/lib/libva-drm.so.2 (0x00007f7ff2f56000) libva-x11.so.2 => /usr/lib/libva-x11.so.2 (0x00007f7ff2f4c000) libvdpau.so.1 => /usr/lib/libvdpau.so.1 (0x00007f7ff2f47000) libX11.so.6 => /usr/lib/libX11.so.6 (0x00007f7ff2e07000) libdrm.so.2 => /usr/lib/libdrm.so.2 (0x00007f7ff2df2000) libgfortran.so.5 => /usr/lib/libgfortran.so.5 (0x00007f7ff2b52000) libjpeg.so.8 => /usr/lib/libjpeg.so.8 (0x00007f7ff2ab9000) libpng16.so.16 => /usr/lib/libpng16.so.16 (0x00007f7ff2a81000) libtiff.so.5 => /usr/lib/libtiff.so.5 (0x00007f7ff29f2000) libjasper.so.4 => /usr/lib/libjasper.so.4 (0x00007f7ff2980000) libIlmImf-2_4.so.24 => /usr/lib/libIlmImf-2_4.so.24 (0x00007f7ff268f000) libtbb.so.2 => /usr/lib/libtbb.so.2 (0x00007f7ff2647000) libcblas.so.3 => /usr/lib/libcblas.so.3 (0x00007f7ff262b000) libGLdispatch.so.0 => /usr/lib/libGLdispatch.so.0 (0x00007f7ff2574000) libGLX.so.0 => /usr/lib/libGLX.so.0 (0x00007f7ff2541000) libmd4c.so.0 => /usr/lib/libmd4c.so.0 (0x00007f7ff252b000) libharfbuzz.so.0 => /usr/lib/libharfbuzz.so.0 (0x00007f7ff2425000) libsystemd.so.0 => /usr/lib/libsystemd.so.0 (0x00007f7ff237e000) libdouble-conversion.so.3 => /usr/lib/libdouble-conversion.so.3 (0x00007f7ff2367000) libicui18n.so.65 => /usr/lib/libicui18n.so.65 (0x00007f7ff2073000) libicuuc.so.65 => /usr/lib/libicuuc.so.65 (0x00007f7ff1e91000) libpcre2-16.so.0 => /usr/lib/libpcre2-16.so.0 (0x00007f7ff1e0d000) libzstd.so.1 => /usr/lib/libzstd.so.1 (0x00007f7ff1d61000) libraw1394.so.11 => /usr/lib/libraw1394.so.11 (0x00007f7ff1d4f000) libusb-1.0.so.0 => /usr/lib/libusb-1.0.so.0 (0x00007f7ff1d33000) libgmodule-2.0.so.0 => /usr/lib/libgmodule-2.0.so.0 (0x00007f7ff1d2e000) libunwind.so.8 => /usr/lib/libunwind.so.8 (0x00007f7ff1d14000) libdw.so.1 => /usr/lib/libdw.so.1 (0x00007f7ff1cc0000) libffi.so.6 => /usr/lib/libffi.so.6 (0x00007f7ff1cb3000) libpcre.so.1 => /usr/lib/libpcre.so.1 (0x00007f7ff1c40000) libgstbase-1.0.so.0 => /usr/lib/libgstbase-1.0.so.0 (0x00007f7ff1bd0000) libgstaudio-1.0.so.0 => /usr/lib/libgstaudio-1.0.so.0 (0x00007f7ff1b5e000) libgsttag-1.0.so.0 => /usr/lib/libgsttag-1.0.so.0 (0x00007f7ff1b24000) libgstvideo-1.0.so.0 => /usr/lib/libgstvideo-1.0.so.0 (0x00007f7ff1a83000) libsoxr.so.0 => /usr/lib/libsoxr.so.0 (0x00007f7ff180d000) libogg.so.0 => /usr/lib/libogg.so.0 (0x00007f7ff1802000) libmvec.so.1 => /usr/lib/libmvec.so.1 (0x00007f7ff17d6000) libfontconfig.so.1 => /usr/lib/libfontconfig.so.1 (0x00007f7ff178e000) libfreetype.so.6 => /usr/lib/libfreetype.so.6 (0x00007f7ff16be000) libp11-kit.so.0 => /usr/lib/libp11-kit.so.0 (0x00007f7ff1595000) libidn2.so.0 => /usr/lib/libidn2.so.0 (0x00007f7ff1574000) libunistring.so.2 => /usr/lib/libunistring.so.2 (0x00007f7ff13f2000) libtasn1.so.6 => /usr/lib/libtasn1.so.6 (0x00007f7ff13dc000) libnettle.so.7 => /usr/lib/libnettle.so.7 (0x00007f7ff13a2000) libhogweed.so.5 => /usr/lib/libhogweed.so.5 (0x00007f7ff1367000) libcrypto.so.1.1 => /usr/lib/libcrypto.so.1.1 (0x00007f7ff1096000) libXext.so.6 => /usr/lib/libXext.so.6 (0x00007f7ff1081000) libXfixes.so.3 => /usr/lib/libXfixes.so.3 (0x00007f7ff1078000) libxcb.so.1 => /usr/lib/libxcb.so.1 (0x00007f7ff104e000) libquadmath.so.0 => /usr/lib/../lib/libquadmath.so.0 (0x00007f7ff1001000) libImath-2_4.so.24 => /usr/lib/libImath-2_4.so.24 (0x00007f7ff0fe8000) libIlmThread-2_4.so.24 => /usr/lib/libIlmThread-2_4.so.24 (0x00007f7ff0fde000) libHalf-2_4.so.24 => /usr/lib/libHalf-2_4.so.24 (0x00007f7ff0f99000) libIex-2_4.so.24 => /usr/lib/libIex-2_4.so.24 (0x00007f7ff0f44000) libgraphite2.so.3 => /usr/lib/libgraphite2.so.3 (0x00007f7ff0f1d000) liblz4.so.1 => /usr/lib/liblz4.so.1 (0x00007f7ff0efb000) libgcrypt.so.20 => /usr/lib/libgcrypt.so.20 (0x00007f7ff0ddd000) libicudata.so.65 => /usr/lib/libicudata.so.65 (0x00007f7fef32c000) libudev.so.1 => /usr/lib/libudev.so.1 (0x00007f7fef301000) libelf.so.1 => /usr/lib/libelf.so.1 (0x00007f7fef2e5000) liborc-0.4.so.0 => /usr/lib/liborc-0.4.so.0 (0x00007f7fef263000) libexpat.so.1 => /usr/lib/libexpat.so.1 (0x00007f7fef233000) libXau.so.6 => /usr/lib/libXau.so.6 (0x00007f7fef22e000) libXdmcp.so.6 => /usr/lib/libXdmcp.so.6 (0x00007f7fef226000) libgpg-error.so.0 => /usr/lib/libgpg-error.so.0 (0x00007f7fef201000) undefined symbol: _ZN5torch4cuda4nccl6detail16throw_nccl_errorE12ncclResult_t (/usr/lib/python3.8/site-packages/torch/lib/libtorch_python.so) ``` ```bash $ nm -gDC /usr/lib/python3.8/site-packages/torch/lib/libtorch_python.so | grep -i torch::cuda::nccl::detail::throw U torch::cuda::nccl::detail::throw_nccl_error(ncclResult_t) ``` cc @ezyang @gchanan @zou3519 @seemethere @ngimel
high priority,module: binaries,oncall: releng,triaged,module: nccl,quansight-nack
low
Critical
555,346,868
godot
[GDNative] Crash when method returns reference objects
Unlike other Godot objects, Reference objects (like all the `Resource` for instance) are refcounted. Hence they are not passed as a simple `Object *` but as a `RefPtr`. This is a trouble for GDNative given it doesn't provide any binding to this `RefPtr` structure (nor any information about how to handle this). For instance the `RefPtr Object::get_script() const` is defined in `api.json` as: ```json { "name": "get_script", "return_type": "Reference", "is_editor": false, "is_noscript": false, "is_const": true, "is_reverse": false, "is_virtual": false, "has_varargs": false, "is_from_script": false, "arguments": [ ] }, ``` From those information you would expect to write like this: ```c godot_object *get_script(godot_object p_obj) { static godot_method_bind *__methbind__Object__get_script = gdapi10->godot_method_bind_get_method("Object", "get_script"); godot_object *ret; gdapi10->godot_method_bind_ptrcall( __methbind__Object__get_script, p_myobj, NULL, &ret ); return ret; } ``` However this cause segfault when `godot_method_bind_ptrcall` tries to store the returned `RefPtr` into the `godot_object *ret` :'( BTW, there is a `is_reference` flag in the class definition, but `Reference` is not marked as `is_reference` (only it children are), though I'm not sure what's the reason, I would guess it's an implementation error from: https://github.com/godotengine/godot/blob/9daaa12bae0cd3637da8f401333b3bc522aee66e/modules/gdnative/nativescript/api_generator.cpp#L221-L224 To solve this issue, Godot-CPP provide it own custom Ref class: https://github.com/GodotNativeTools/godot-cpp/blob/81783c6045ac5e3638846f791c7c7841db38aa7e/include/core/Ref.hpp This solution works because Godot-CPP is in C++ and can then reproduce the layout of the internal Godot RefPtr (though I'm not really sure this is 100% safe if Godot is compiled with a different compiler than the GDNative plugin using Godot-CPP... @karroffel can you enlighten me on this ? ^^ ) Anyway, I guess we should provide a binding to the `RefPtr` in GDNative and fix the `is_reference` flag (maybe even provide this `is_reference` in the method's flags ?), what do you think ?
bug,topic:gdextension
low
Critical
555,349,422
godot
Mono: Can't attach C# script to SceneTree
**Godot version:** 3.2 Mono RC3 **OS/device including version:** MXLinux19 64bits **Issue description:** After attaching a C# script to the SceneTree I get this error: IntPtr Godot.Object.GetPtr(Godot.Object ): System.ObjectDisposedException: Cannot access a disposed object. I can attach a gdscript script to it just fine . **Steps to reproduce:** Call SetScript on the tree and pass a C# script to it.
bug,topic:core,confirmed,topic:dotnet
low
Critical
555,355,092
pytorch
changed format of trace graph in torch 1.4.0
## ❓ Questions For the following example code, the printed graph in torch 1.4.0 is very different from that in torch 1.3.1. I am wondering is this expected? because many useful fields are removed in torch 1.4.0. ``` import torch import torch.nn as nn class Net(nn.Module): def __init__(self): super(Net, self).__init__() self.conv = nn.Conv2d(1, 1, 3) def forward(self, x): return self.conv(x) if __name__ == '__main__': n = Net() example_weight = torch.rand(1, 1, 3, 3) example_forward_input = torch.rand(1, 1, 3, 3) # Trace a specific method and construct `ScriptModule` with # a single `forward` method module = torch.jit.trace(n.forward, example_forward_input) # Trace a module (implicitly traces `forward`) and construct a # `ScriptModule` with a single `forward` method module = torch.jit.trace(n, example_forward_input) print(module.graph) ``` output in torch 1.3.1: ``` graph(%self : ClassType<Net>, %input : Float(1, 1, 3, 3)): %1 : ClassType<Conv2d> = prim::GetAttr[name="conv"](%self) %weight : Tensor = prim::GetAttr[name="weight"](%1) %3 : Tensor = prim::GetAttr[name="bias"](%1) %5 : int = prim::Constant[value=1](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %6 : int = prim::Constant[value=1](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %7 : int[] = prim::ListConstruct(%5, %6), scope: Net/Conv2d[conv] %8 : int = prim::Constant[value=0](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %9 : int = prim::Constant[value=0](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %10 : int[] = prim::ListConstruct(%8, %9), scope: Net/Conv2d[conv] %11 : int = prim::Constant[value=1](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %12 : int = prim::Constant[value=1](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %13 : int[] = prim::ListConstruct(%11, %12), scope: Net/Conv2d[conv] %14 : bool = prim::Constant[value=0](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %15 : int = prim::Constant[value=0](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %16 : int = prim::Constant[value=0](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %17 : int[] = prim::ListConstruct(%15, %16), scope: Net/Conv2d[conv] %18 : int = prim::Constant[value=1](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %19 : bool = prim::Constant[value=0](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %20 : bool = prim::Constant[value=0](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %21 : bool = prim::Constant[value=1](), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 %22 : Float(1, 1, 1, 1) = aten::_convolution(%input, %weight, %3, %7, %10, %13, %14, %17, %18, %19, %20, %21), scope: Net/Conv2d[conv] # /home/xxx/.local/lib/python3.5/site-packages/torch/nn/modules/conv.py:342:0 return (%22) ``` output in torch 1.4.0: ``` graph(%self.1 : __torch__.torch.nn.modules.module.___torch_mangle_4.Module, %input : Float(1, 1, 3, 3)): %28 : __torch__.torch.nn.modules.module.___torch_mangle_3.Module = prim::GetAttr[name="conv"](%self.1) %30 : Tensor = prim::CallMethod[name="forward"](%28, %input) return (%30) ``` cc @suo
oncall: jit,triaged
medium
Major
555,382,197
rust
specialization: default impl is used, ignoring the vtable of original value
When I cast a variable to `dyn Trait`, original vtable is ignored, and default implementation is called even if the casted variable has its own implementation. <del> https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=c184c5f2df18c01d91357da3a0053e4a </del> I minimized it. https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=c2f4879c62e70f03732a365321e67e79 Casting as a dyn trait like the code below ignores vtable of the original value. ```rust <Self as FoldWith<&mut dyn Fold<Self>>>::fold_with(self, &mut (_f as _)) ``` I expected a test to pass.
T-compiler,A-specialization,C-bug,requires-nightly,F-specialization
low
Critical
555,476,663
flutter
Camera live filter for photo and video
I'm wondering if there are any plans to support live filters on videos and photos by the official [camera plugin](https://pub.dev/packages/camera). It would be definitely great! Librarys such as [photofilters](https://github.com/skkallayath/photofilters) could be supported to apply live filters directly on the camera like apps such as snapchat, etc. are doing. Or are there any possibilities to it right now somehow?
c: new feature,p: camera,package,team-ecosystem,P3,triaged-ecosystem
medium
Critical
555,503,354
TypeScript
Template decorators.
<!-- 🚨 STOP 🚨 𝗦𝗧𝗒𝗣 🚨 𝑺𝑻𝑢𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with the latest published version. It may have already been fixed. For npm: `typescript@next` This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly --> **TypeScript Version:** 3.7.5 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** Decorators, Templates I know decorators a experimental feature, so this issue is just to push it closer to production ready status. Notice, I tried typescript version 3.8 beta in the playground. For local check with tsc only two following flags are essential: "--experimentalDecorators --strict". It seems like typescript cant pass complex props type. Instead of passing `A | B`, it just pass `A`. Using a more simple type `A` will not produce any errors. **Code** ```ts import { Component, ComponentClass } from "react" const components = new Set<ComponentClass<any, any>>() function dec<P, S>(component: ComponentClass<P, S>) { components.add(component) } type Props = { x: number } & ( { y: number } | { z: number } ) @dec class C extends Component<Props> { } ``` **Expected behavior:** Everything works. **Actual behavior:** Following error: ``` Argument of type 'typeof C' is not assignable to parameter of type 'ComponentClass<{ x: number; } & { y: number; }, {}>'. Construct signature return types 'C' and 'Component<{ x: number; } & { y: number; }, {}, any>' are incompatible. The types of 'props' are incompatible between these types. Type '(Readonly<{ x: number; } & { y: number; }> & Readonly<{ children?: ReactNode; }>) | (Readonly<{ x: number; } & { z: number; }> & Readonly<{ children?: ReactNode; }>)' is not assignable to type 'Readonly<{ x: number; } & { y: number; }> & Readonly<{ children?: ReactNode; }>'. Type 'Readonly<{ x: number; } & { z: number; }> & Readonly<{ children?: ReactNode; }>' is not assignable to type 'Readonly<{ x: number; } & { y: number; }> & Readonly<{ children?: ReactNode; }>'. Property 'y' is missing in type 'Readonly<{ x: number; } & { z: number; }> & Readonly<{ children?: ReactNode; }>' but required in type 'Readonly<{ x: number; } & { y: number; }>'.(2345) ``` **Playground Link:** http://www.typescriptlang.org/play/?experimentalDecorators=true&ts=3.8-Beta#code/JYWwDg9gTgLgBAbzgYQuCA7AphmAaFNSbXZAGwEMBnKuAXzgDMo04AiKLCgYxjYCh+3TFXjD0JGLQC8cbAHc4AZSwwAPKgk4Y5alTUUMATwKGjAPnMAKAJSDGAVwy9gmOABMs3NQAUCS63FibQAuQi1SShpff3M7BH44JLggzG0qADoKd3crVMk7OkEYIzAsOB8WMBlEOAAPMIwHEAAjLCh6OAAyOCtao0bmto6GAB9agC9B1vbOu34AAU9uISjaZDgsOpgcd3WiNNxfKqpzfgT+OiA **Related Issues:** <!-- Did you find other bugs that looked similar? -->
Needs Investigation
low
Critical
555,527,387
go
cmd/go: go list -m reports command-line-arguments when called outside a module
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.14beta1 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Yes. ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="on" GOARCH="amd64" GOBIN="/home/manlio/.local/bin" GOCACHE="/home/manlio/.cache/go-build" GOENV="/home/manlio/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOINSECURE="" GONOPROXY="github.com/perillo" GONOSUMDB="github.com/perillo" GOOS="linux" GOPATH="/home/manlio/.local/lib/go:/home/manlio/src/go" GOPRIVATE="github.com/perillo" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/manlio/sdk/go1.14beta1" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/manlio/sdk/go1.14beta1/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/dev/null" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build475655411=/tmp/go-build -gno-record-gcc-switches" GOROOT/bin/go version: go version go1.14beta1 linux/amd64 GOROOT/bin/go tool compile -V: compile version go1.14beta1 uname -sr: Linux 5.4.15-arch1-1 /usr/lib/libc.so.6: GNU C Library (GNU libc) stable release version 2.30. gdb --version: GNU gdb (GDB) 8.3.1 </pre></details> ### What did you do? In a directory with no reachable `go.mod`: ``` go list -m -json ``` ### What did you expect to see? `go list` should report an error, since there is no module. ### What did you see instead? ``` { "Path": "command-line-arguments", "Main": true } ``` This really feels wrong for me.
NeedsInvestigation,modules
low
Critical
555,530,229
flutter
An infinite loop using PageView
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Use case Currently in `PageView` there is no way using infinite loop. For example, my PageView has 3 pages, after swiping to the page 3 I would be able to swipe again in the same direction to get to page 1. And if I'm on the page 1, I would be able to get to the page 3 by swiping to the left. ## Proposal Add a new bool property that could turn on the mode ``` /// set to true to enable infinite loop loop: false ```
c: new feature,framework,f: scrolling,would be a good package,P3,team-framework,triaged-framework
medium
Critical
555,537,345
youtube-dl
Google account challenge authentication fails with 'Unable to log in: HTTP Error 400: Bad Request'
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.01.24. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that all URLs and arguments with special characters are properly quoted or escaped as explained in http://yt-dl.org/escape. - Search the bugtracker for similar issues: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a broken site support - [x] I've verified that I'm running youtube-dl version **2020.01.24** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that all URLs and arguments with special characters are properly quoted or escaped - [x] I've searched the bugtracker for similar issues including closed ones ## Verbose log <!-- Provide the complete verbose output of youtube-dl that clearly demonstrates the problem. Add the `-v` flag to your command line you run youtube-dl with (`youtube-dl -v <your command line>`), copy the WHOLE output and insert it below. It should look similar to this: [debug] System config: [] [debug] User config: [] [debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj'] [debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251 [debug] youtube-dl version 2020.01.24 [debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2 [debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4 [debug] Proxy map: {} <more lines> --> ``` Β» youtube-dl "https://www.youtube.com/playlist?list=WL" -u [email protected] -v [debug] System config: [] [debug] User config: [] [debug] Custom config: [] [debug] Command-line args: ['https://www.youtube.com/playlist?list=WL', '-u', 'PRIVATE', '-v'] Type account password and press [Return]: [debug] Encodings: locale UTF-8, fs utf-8, out utf-8, pref UTF-8 [debug] youtube-dl version 2020.01.24 [debug] Python version 3.8.1 (CPython) - Linux-5.4.14-arch1-1-x86_64-with-glibc2.2.5 [debug] exe versions: ffmpeg 4.2.2, ffprobe 4.2.2 [debug] Proxy map: {} [youtube:watchlater] Downloading login page [youtube:watchlater] Looking up account info [youtube:watchlater] Logging in WARNING: Unable to log in: HTTP Error 400: Bad Request [youtube:watchlater] WL: Downloading webpage ERROR: This playlist does not exist. Traceback (most recent call last): File "/usr/lib/python3.8/site-packages/youtube_dl/YoutubeDL.py", line 796, in extract_info ie_result = ie.extract(url) File "/usr/lib/python3.8/site-packages/youtube_dl/extractor/common.py", line 530, in extract ie_result = self._real_extract(url) File "/usr/lib/python3.8/site-packages/youtube_dl/extractor/youtube.py", line 3238, in _real_extract _, playlist = self._extract_playlist('WL') File "/usr/lib/python3.8/site-packages/youtube_dl/extractor/youtube.py", line 2738, in _extract_playlist raise ExtractorError(message, expected=True) youtube_dl.utils.ExtractorError: This playlist does not exist. ``` ## Description <!-- Provide an explanation of your issue in an arbitrary form. Provide any additional information, suggested solution and as much context and examples as possible. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> When I was looking into an issue with Google account login with [invidious](https://github.com/omarroth/invidious/issues/754), I tried to see if `youtube-dl` also had the same login issue, and it turns out it does. When trying to log in with a Google email and password, regardless of 2FA being enabled or not, the login will always fail with the message `Unable to log in: HTTP Error 400: Bad Request`. I looked into the specific requests that are being made by the auth handler. The authentication is successfully passing the lookup stage where it makes a request to `https://accounts.google.com/_/signin/sl/lookup`, but gets back a 400 response when making a challenge request to `/_/signin/sl/challenge`. What seems to have happened is Google changed something internally on this endpoint that breaks the existing authentication. If this is a duplicate issue, the issue it is a duplicate of is not clear to me at all. In #23832 there are four separate issues that are linked to as justification that this specific issue is a duplicate of one of the others. However, the error output of each issue differs subtly from this one. #15184: It reaches the 2FA prompt (`Type 2-step verification code and press [Return]:`), so the `challenge` request must have succeeded at that point. #15423: The author mentions supplying an authentication code from Google Authenticator after giving a password, so this is after the `challenge` step. #15926: The specific error is different (`WARNING: Unable to login: Invalid password`/`Unable to download webpage: HTTP Error 404: Not Found`) #17216: The specific error is different (`WARNING: Unable to login: Invalid password`) None of these issues contain a `Unable to log in: HTTP Error 400: Bad Request` error. The newest one is from August 2018 and the oldest is January 2018. On the other hand there are numerous issues all created after April 2019 which were marked as "duplicate" with similar circumstances as this issue with little or no followup: #23856 #23813 #23769 #23449 #22925 #22725 #21691 #21677 #21313 #21285 #21065 #21054 #20814 #20755 I do not believe this issue is a duplicate of #11270 as stated in [this issue](https://github.com/ytdl-org/youtube-dl/issues/20755#issuecomment-489716927). That issue is from November 2016 and appears to be separate: the original author appeared to write about an issue related to a DNS configuration at first, but several people followed up on the issue years later around May 2019 on this seemingly unrelated issue that just happened to share the same error message. I would find it suspicious if the number of independent reports of this issue suddenly increased after April 2019 (the earliest mention of this bug) after no other similar issues since the one in 2016. Even so the commit which closed issue #11270 (baf67a6) has not fixed this bug. I tested the same code change independently by making the requests to Google's challenge endpoint in a different language and still got a 400 response. See [here](https://gist.github.com/Ruin0x11/a32c4ba33d386b51797a3719ad2c14e4) for the code. Someone mentioned that it could be solved by [adding cookies to the request](https://github.com/ytdl-org/youtube-dl/issues/21313#issuecomment-499496235) but I haven't verified this. And after looking through the entire list of issues I cannot find one which is currently open that has the same reproduction of the log output. It might just be that I can't locate it myself so I would appreciate being able to know which one it is the duplicate of if there actually is one. In reproducing this bug my account had 2FA enabled, but even after disabling it the same 400 response was returned. Thus, I do not believe this issue has anything to do with 2FA, so the PR at #18521 would probably not fix it (the PR adds code that runs after the `challenge` request succeeds, but in this case the `challenge` request is not succeeding so it will never reach the 2FA stage). I'm not sure what's going on if so many other people are running across this issue but the issues they open are being closed with no explanation or even a cursory mention of what issue this is a duplicate of. *Would it be possible to receive some kind of an explanation of what is happening with this bug?* It seems that some people have been unable to download private playlists like Watch Later for almost a year due to this issue. And if you choose to close this issue as another duplicate, would it be possible to at least indicate which issue it is a duplicate of?
duplicate
medium
Critical
555,551,003
node
Ability to synchronously drain a thread safe function
**Is your feature request related to a problem? Please describe.** Since TSFN provides a queue to caching up calls to the creating thread, we don't have the ability to drain the queue if we think it's time to complete the job. **Describe the solution you'd like** Add a drain method to synchronously drain the threadsafe function (maybe mark it as closed too). **Describe alternatives you've considered** Release the tsfn with `napi_release_threadsafe_function(tsfn, napi_tsfn_release)` and wait the finalizer to be called asynchronously.
node-api
low
Minor
555,601,280
flutter
flutter version code is different from version code in google play console
When uploading app to playstore I understand that we need our app to have a unique version code for each build and in flutter the version code is said to be what follows + in pubspec.yaml. e.g ```version: 1.0.0+3``` has a version code of 3 but when I upload my split apk's built using ```flutter build apk --split-per-abi``` to google play console has version code as 4003,2003&1003 ![image](https://user-images.githubusercontent.com/31410839/73180519-7761de80-413b-11ea-8faa-63837af1e1c0.png) The problem is the version codes get huge when using split apks and it doesn't seem to respect the version number specified in `pubspec.yaml`. https://github.com/fastlane/fastlane/issues/15936#issue-555375814
platform-android,tool,t: gradle,c: proposal,a: release,P3,team-android,triaged-android
medium
Major
555,655,256
pytorch
[Tensorboard] Problem with subfolders from SummaryWriter
## Bug Using the `add_scalars` or the `add_hparams` methods from the `SummaryWriter` in `torch.utils.tensorboard` results in a folder structure with subfolders that each contain further "tfevents" files. As a result, Tensorboard loads them as separate runs which very quickly leads to chaos when trying to distinguish different training sessions: ![Tensorboard](https://user-images.githubusercontent.com/16224924/73186483-17aa0a00-4120-11ea-924c-0335d914f87f.png) ## To Reproduce The following code creates the problematic folder structure: `from torch.utils.tensorboard import SummaryWriter` `writer = SummaryWriter('runs/experiment1')` `writer.add_hparams({"lr": 0.001, "batch": 10}, {"metric/distance": 0.5})` `writer.add_scalar("training/loss", 0.783, 1)` `writer.add_scalar("training/loss", 0.837, 2)` `writer.add_scalar("training/loss", 0.642, 3)` `writer.add_scalars("training/accuracy", {"A":0.1, "B":0.2, "C":0.3}, 1)` `writer.add_scalars("training/accuracy", {"A":0.2, "B":0.3, "C":0.4}, 2)` `writer.add_scalars("training/accuracy", {"A":0.3, "B":0.4, "C":0.5}, 3)` `writer.close()` The resulting files and folders are: runs/experiment1/1580137040.107033/events.out.tfevents.1580137040.cube1.26313.1 runs/experiment1/training_accuracy_A/events.out.tfevents.1580137040.cube1.26313.2 runs/experiment1/training_accuracy_B/events.out.tfevents.1580137040.cube1.26313.3 runs/experiment1/training_accuracy_C/events.out.tfevents.1580137040.cube1.26313.4 runs/experiment1/events.out.tfevents.1580137040.cube1.26313.0 ## Expected behavior Tensorboard should only show one run containing all data provided to a single `SummaryWriter`. This could be done by always writing to the same "tfevents" file or maybe there is a workaround to prevent tensorboard from recursively searching the runs folder? ## Environment PyTorch version: 1.3.1 Is debug build: No CUDA used to build PyTorch: 9.2.148 OS: Ubuntu 16.04.5 LTS GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.11) 5.4.0 20160609 CMake version: version 3.5.1 Python version: 3.7 Is CUDA available: Yes CUDA runtime version: 9.0.176 GPU models and configuration: GPU 0: GeForce GTX 1080 Ti Nvidia driver version: 410.79 cuDNN version: Probably one of the following: /usr/lib/x86_64-linux-gnu/libcudnn.so.5.1.10 /usr/local/cuda-9.0/targets/x86_64-linux/lib/libcudnn.so.7 Versions of relevant libraries: [pip] numpy==1.15.4 [pip] torch==1.3.1 [pip] torchvision==0.4.2 [conda] _tflow_select 2.3.0 mkl [conda] blas 1.0 mkl [conda] cuda90 1.0 h6433d27_0 pytorch [conda] mkl 2018.0.3 1 [conda] mkl_fft 1.0.6 py37h7dd41cf_0 [conda] mkl_random 1.0.1 py37h4414c95_1 [conda] pytorch 1.3.1 py3.7_cuda9.2.148_cudnn7.6.3_0 pytorch [conda] tensorflow 1.14.0 mkl_py37h45c423b_0 [conda] tensorflow-base 1.14.0 mkl_py37h7ce6ba3_0 [conda] torchvision 0.4.2 py37_cu92 pytorch
triaged,module: tensorboard
medium
Critical
555,666,715
material-ui
[Modal] Wrong display of a modal that contain an autofocus input on iPad
- [x] The issue is present in the latest release. - [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate. ## Current Behavior 😯 When opening a modal that contain an input with autofocus on an iPad, the keyboard is display in front of the modal most of the time ![72251C7D-FE3F-4936-87B7-D27E35D3D00D](https://user-images.githubusercontent.com/7248734/73187212-5d1b0700-4121-11ea-8c15-349d75d41701.png) <!-- Describe what happens instead of the expected behavior. --> ## Expected Behavior πŸ€” The modal is suppose to be above the keyboard like this. ![B4C2EB12-D9FF-43E2-8C91-282BA1B365F7](https://user-images.githubusercontent.com/7248734/73187964-77091980-4122-11ea-9097-7930075715dc.png) <!-- Describe what should happen. --> ## Steps to Reproduce πŸ•Ή <!-- Provide a link to a live example (you can use codesandbox.io) and an unambiguous set of steps to reproduce this bug. Include code to reproduce, if relevant (which it most likely is). This codesandbox.io template _may_ be a good starting point: https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/create-react-app If you're using typescript a better starting point would be https://codesandbox.io/s/github/mui-org/material-ui/tree/master/examples/create-react-app-with-typescript If YOU DO NOT take time to provide a codesandbox.io reproduction, should the COMMUNITY take time to help you? --> Steps: Links : https://codesandbox.io/s/modal-focus-issue-vo53i 1. Open the link with an iPad 2. Try to open the modal 3. See that the keyboard is display over the modal 4. Sometimes it work properly so try to open/close the modal more than once if needed ## Context πŸ”¦ <!-- What are you trying to accomplish? How has this issue affected you? Providing context helps us come up with a solution that is most useful in the real world. --> I'm currently using modal to rename, comment and create elements and I want to make it work for iPad as well. ## Your Environment 🌎 <!-- Include as many relevant details about the environment with which you experienced the bug. If you encounter issues with typescript please include version and tsconfig. --> | Tech | Version | | ----------- | ------- | | Material-UI | v4.9.0 | | React | V16.12.0 | | Browser | Safari/605.1.15 |
component: dialog,component: modal
low
Critical
555,679,562
godot
Problem in iOS+Android workflow
**Godot version:** 3.2 **OS/device including version:** MacOS **Issue description:** The workflow in https://docs.godotengine.org/en/3.1/getting_started/workflow/export/exporting_for_ios.html#steps-to-link-a-godot-project-folder-to-xcode for iOS is great. However when adding android exporting to the same project, the android folder is referenced through the "blue folder" in the Xcode project creating massive unnecessary size increase and slowdown in the workflow. Currently 536 MB is added. I have tried adding the "Exclude Source FIle Names" build options in the XCode project but it doesnt seem possible to exclude referenced subfolders. Only the main reference folder or direct paths are possible to exclude. Currently I have to move the android folder out of project folder when testing locally on ios and the move it back when testing on android which is not great.
discussion,platform:ios,platform:android,topic:porting
low
Major
555,691,412
neovim
complete_check() does not return TRUE for mapped input
<!-- Before reporting: search existing issues and check the FAQ. --> - `nvim --version`: v0.4.3 - `vim -u DEFAULTS` (version: ) behaves differently? NO - Operating system/version: linux - Terminal name/version: doesn't matter - `$TERM`: doesn't matter ### Steps to reproduce using `nvim -u init.vim` ```vim " Some complete function that may take a long time (taken from |E840|) fun! CompleteMonths(findstart, base) if a:findstart " locate the start of the word let line = getline('.') let start = col('.') - 1 while start > 0 && line[start - 1] =~ '\a' let start -= 1 endwhile return start else " find months matching with "a:base" for m in split("Jan Feb Mar Apr May Jun Jul Aug Sep Oct Nov Dec") if m =~ '^' . a:base call complete_add(m) endif sleep 300m " simulate searching for next match if complete_check() echom 'complete check 1' break endif endfor return [] endif endfun set completefunc=CompleteMonths set completeopt+=menuone,noselect inoremap <SPACE> <SPACE><SPACE> ``` ``` nvim -u init.vim F<C-x><C-u><SPACE> ``` ### Actual behaviour `complete_check()` does not return TRUE. The complete function takes 3+ seconds to return. ### Expected behaviour `complete_check()` return TRUE. The complete function takes 300ms to return.
bug-vim,needs:vim-patch
low
Minor
555,707,707
go
x/review/git-codereview: skip tests that require "gofmt" binary when it's not available
https://build.golang.org/log/36fc6a856500bd206f0f994b1565fb6badbe7034 ``` aix-ppc64 at 6fbdfe48041c883a9f6d8c981a7205b7c327862a building review at f51a73253c4da005cfdf18a036e11185c04c8ce3 … --- FAIL: TestGofmt (0.55s) gofmt_test.go:46: git-codereview gofmt -l util_test.go:323: died stdout: stderr: git-codereview: invoking gofmt: exec: "gofmt": executable file not found in $PATH … ``` I'm not sure whether this should be resolved by adding `gofmt` to the builder's `PATH`, by updating the `git-codereview` tool to invoke `go fmt` instead, by updating the test to install that tool if not present, or by updating the test to skip those cases if the `gofmt` binary is not found. This is technically a release-blocker via #11811, but seems pretty minor. (CC @dmitshur @cagedmantis @toothrot @trex58)
Testing,help wanted,NeedsFix
low
Minor
555,728,304
TypeScript
Make it possible to infer superclass type parameters / constructor overload from the `super` call
## Search Terms superclass base class generic type infer contextual infer parent generic super constructor ## Suggestion Make it possible to infer superclass type parameters / constructor overload from the `super` call ## Use Cases I'm working on an intermediate library with typings for a legacy codebase. That intermediate library is used in third party to use the functionality from the main codebase (called adapters). There are several supported ways to access this functionality: 1. `const foo1 = Adapter(options);` 2. `const foo2 = new Adapter(options);` 3. `class Foo3 extends Adapter { ... }` - The constructor must call the superclass constructor with the options. Now the problem is that the `Adapter` "class" (actually an ES5-style "function" class) has some properties that only exist if specific options are passed to its constructor. I'm able to model this behavior for case 1 and 2, but not 3 - at least not without manually specifying the type. Here's what I have so far. The code is split into three parts: main codebase, intermediate library, 3rd party / user code. ([Playground link](https://www.typescriptlang.org/play/?ts=3.8.0-dev.20200125&ssl=84&ssc=2&pln=79&pc=1#code/PTAEBsFMHMEMGMCep4HsAmkA0LYDs9UAXFAC32kgC4BYAKE3nFgCdIVmBnT0ASTyKQWeWOACC6WAAdBLUAG96oZaBCgERAK6jwyfKACiAZQCsAWk5FEUDrG6gAZprzwiAS1R4c8fQCN2PuBQ6KAA7m5EpOp4IeGRqJokeJChAIRKKpyoALaQAAosqFIAjFTRiADcGcpZuQVFAExl+JX01apgvGH4JESooKgAbkIsbpigkW48VlKQ7T7wpJAA8r4AVmUASpBoLOgAPJajeNA4LQB8oAA+oM6YDm7J6FV0AL5tdGoAvD+-f-8A34fNQAWWQaEw3n0iwo1Hoj1kDgQ7Ak0lkyxkHjwPEUdBUoBEuTKR0e0Be+IWSwA-GUiCxNJAXu86PQZijJDIhPxLPh4JB9gAVUCQAAeghiPFRnJYGPcnk4ly+oCFovF6Bx9AAkJTqBN6Yz6MzNVTQMtshF9vxZCJxBzZDgAEQ61ZrB2XABkCi1mu1CCWLrKBhFTE0mEtAiENqlsgA2k6-St1g6ALo4O6QB5Pc4vTXKI1lM0Wq2R0TRoSO51J7MfBFCJF80BllgAYXldM0rlQclxmuSoVAAApYHahAA5WBE0Akk4ASjKTe5RF5-PkhN10+gr2rdF7KVAguFYsgEsbI5lmPl5yHZ9lWM4ZQFc9PaK52KXLn5Au3+K115fLHHScNyfBc32XfZVwndc6VJLccwPVVj3VZ9pVvS8-1Qi9sQfECz0XcCvyZD5GGYNgUDbFDZHnM9WzfelOxYF56G+QFWNY4EwAAVU4IRyMhKdSAScAQn8dQeE4NxsikGw7FAKRUG4NxfCgeg0DfAkoNAJUHQcVBUF8VgHReNTLAGLCeCVeQNNyUBXiYugTN6SBLGKLTKKEAc1xnF5BBcgA6Ss1gqDpQHQVBnIJYhDymIgcFFWZXEgdAPkciZnKIBo3L7dyWE8qDvNZdKGgChMXWCtQwoiwgSFFGK4pFBLBGSlkHIo3yiAAZjcpsByKOVsQKuh2o6krFkTIKQsqnhquiyx6sapKUra9KABYsr3Hq+rvQb2pW0b-XWcqwCmyKapFOrDwW5rVOWywTHW-seqsvyXq2+UoTG2l9Vsnb0pMfbxqO2aiE4eadialKuB4AV0oANkPNVJTPfYmzQ7FLlxCk23ovpcre7CcrRzgZy9PF8UyTRZjx8zBvJlRJk4AGysm8Lpqi2q5su8HFrJvNDUhuxofSgB2BGkKR-8UZvcyMfmbGO1x3rzOo-8iZJzG6anSmPOe17zI+pYvoZH7yU1hmmcOlmqvZ87OeceLuea-FmWZVSoeVdKAA4xZPJspdV8zQE9eQdSNyAt1JrG6IVrslf6+9CZpyPNc4bXct1vz8dB3BPr1Y3Xlps3SCmC2JrUDmQZwXxEj4UByGGCZ+nQSnwDcHxBAmJYJkQWZ2hdgX7BhywAE4feQptVAAKm72Z1BYaBNFyARQEeBwRiSxvQFE1HA+D0O8-D0BJ7ADXlEcnHY6zlXMPj9X2nxVOqYHDOs4N3V23YAvTbp83AqBzhBKaGEsDPuhogA)) ```ts // legacy code, cannot change: declare class InternalAdapter { // actually an ES5-style class function, can be called with and without new! someProp1: any; someProp2: any; // I want to override this type cacheObj: Record<string, any> | undefined; } // ======================== // My code, can change: interface AdapterOptions { name: string; cache?: boolean; } type AdapterInstance<T extends AdapterOptions> = T extends { cache: true; } ? Omit<InternalAdapter, "cacheObj"> & { cacheObj: Exclude<InternalAdapter["cacheObj"], undefined>; } : Omit<InternalAdapter, "cacheObj">; interface AdapterConstructor { new (adapterName: string): AdapterInstance<{name: string}>; new <T extends AdapterOptions>(adapterOptions: T): AdapterInstance<T>; (adapterName: string): AdapterInstance<{name: string}>; <T extends AdapterOptions>(adapterOptions: T): AdapterInstance<T>; } declare const Adapter: AdapterConstructor; // ======================== // User code, should be as simple as possible const name = "foobar"; const options = { name }; const test1 = Adapter(name); test1.cacheObj; // does not exist, expected const test2 = new Adapter(name); test2.cacheObj; // does not exist, expected const test3 = Adapter(options); test3.cacheObj; // does not exist, expected const test4 = new Adapter(options); test4.cacheObj; // does not exist, expected const test5 = new Adapter({ ...options, cache: true }); test5.cacheObj; // exists, expected // Here, the problems start: class Test6 extends Adapter<AdapterOptions> { constructor(options: AdapterOptions) { super(options); this.cacheObj; // does not exist, expected } } class Test7 extends Adapter<AdapterOptions> { constructor(options: AdapterOptions) { super({ ...options, cache: true }); this.cacheObj; // does not exist, unexpected } } class Test8 extends Adapter<AdapterOptions & {cache: true}> { constructor(options: AdapterOptions) { super({ ...options, cache: true }); this.cacheObj; // exists, but I have to duplicate the type } } ``` Notice how the class definitions are all awkward. In `Test6` I have to duplicate the generic type `AdapterOptions` or the super call will default to the string constructor. In `Test7` this is actually wrong, because the generic type overrides the conditional behavior for the `cacheObj`. This can be fixed like in `Test8`, but that is really ugly. IMO, TypeScript should be able to infer the type arguments from a constructor call if that type argument matches the class' type argument ## Examples Show how this would be used and what the behavior would be - Ideally it should be like this: ```ts class Test9 extends Adapter { constructor(options: AdapterOptions) { super({ ...options, cache: true }); this.cacheObj; // should exist } } ``` The `super` call would be used to infer that the 2nd constructor overload is the correct one: ```ts new <T extends AdapterOptions>(adapterOptions: T): AdapterInstance<T>; ``` and therefore the instance type would be `AdapterInstance<AdapterOptions & {cache: true}>`. ## Checklist My suggestion meets these guidelines: * [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code **(not sure actually. I'd guess not?)** * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
medium
Critical
555,772,015
go
x/pkgsite: partial search doesn't return (any) matches which are "close" or latest
### What is the URL of the page with the issue? * https://pkg.go.dev/search?q=goproxytes * https://pkg.go.dev/search?q=sh ### What is your user agent? <pre> Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/80.0.3987.66 Safari/537.36 </pre> ### Screenshot For https://pkg.go.dev/search?q=goproxytes: <img width="735" alt="Screen Shot 2020-01-27 at 18 59 27" src="https://user-images.githubusercontent.com/3374574/73204610-2a7c0900-4137-11ea-803a-da081fd17bdc.png"> For https://pkg.go.dev/search?q=sh: <img width="786" alt="Screen Shot 2020-01-27 at 19 00 04" src="https://user-images.githubusercontent.com/3374574/73204667-41226000-4137-11ea-9567-dcb7a2be1f7f.png"> ### What did you do? Visited either of the search results pages above. ### What did you expect to see? For https://pkg.go.dev/search?q=goproxytes I would expect to see https://pkg.go.dev/github.com/rogpeppe/go-internal/goproxytest?tab=doc in the results. For https://pkg.go.dev/search?q=sh I would expect to see: * https://pkg.go.dev/mvdan.cc/sh/v3/syntax?tab=doc fairly near the top of results * the modules `mvdan.cc/sh`, `mvdan.cc/sh/v2` and `mvdan.cc/sh/v3` listed as module search results, along with packages that are "close" matches ### What did you see instead? For https://pkg.go.dev/search?q=goproxytes, zero results. For https://pkg.go.dev/search?q=sh a number of results which I would consider "further away" than https://pkg.go.dev/mvdan.cc/sh/v3/syntax?tab=doc FYI @mvdan
NeedsInvestigation,pkgsite,pkgsite/search
low
Major
555,799,909
pytorch
Second-order gradient cause segfault over time
## πŸ› Bug Hello, I’m running a GAN model with some second-order regularization. The training went well at the beginning and the loss decreased. However, after a random period of time, ranging from 3000-8000 updates, the segfault occurs and the training was terminated automatically. ## To Reproduce run the following script and wait, the error will finally occur. In my case it took 2 days to occur (total number fo iteration = 443298). ``` import torch from torch.utils.data import Dataset, DataLoader import torchvision.models as models import torch.nn as nn import torch.autograd as autograd import torch.nn.functional as F class data_gpu_prefetcher(): def __init__(self, loader, stop=False): self.original_loader = loader self.loader = iter(loader) self.stream = torch.cuda.Stream() self.stop = stop self._count = 0 self.preload() def preload(self): self.next_input = next(self.loader, None) if self.next_input is None and not self.stop: self.loader = iter(self.original_loader) self.next_input = next(self.loader) with torch.cuda.stream(self.stream): if isinstance(self.next_input, list): self.next_input = [item.cuda(non_blocking=True) for item in self.next_input] elif self.next_input is not None: self.next_input = self.next_input.cuda(non_blocking=True) def next(self): self._count += 1 torch.cuda.current_stream().wait_stream(self.stream) input = self.next_input self.preload() return input def reset_count(self): self._count = 0 def get_count(self): return self._count class RandomDataset(Dataset): def __init__(self, size, length): self.len = length self.data = torch.randn(length, 3, size, size) self.label = torch.randint(0, 10, (length,)) def __getitem__(self, index): return self.data[index], self.label[index] def __len__(self): return self.len class resnet_cls(nn.Module): def __init__(self): super(resnet_cls, self).__init__() self.model = models.resnet50() self.cls = nn.Linear(1000, 10) self._count = 0 def forward(self, im, label, r1_reg=False): im.requires_grad_(r1_reg) score = self.model(im) loss = F.nll_loss(F.log_softmax(self.cls(score), dim=1), target=label, reduction='none') if r1_reg: gradients = autograd.grad( outputs=score.sum(), inputs=im, grad_outputs=None, create_graph=True, retain_graph=True, only_inputs=True, )[0] gradients = gradients.view(gradients.size(0), -1) gradient_norms = gradients.pow(2).sum(1) loss += gradient_norms * 1 return loss rand_loader = DataLoader(dataset=RandomDataset(224, 1000), batch_size=32, shuffle=True) train_loader_iterator = data_gpu_prefetcher(rand_loader, stop=False) model = resnet_cls() model.cuda() model_para = nn.DataParallel(model) opt = torch.optim.Adam(model.parameters(), lr=0.001, betas=(0., 0.99)) count = 0 while True: r1_reg = count % 2 == 0 print(r1_reg) count += 1 imgs, labels = train_loader_iterator.next() loss = model_para(imgs, labels, r1_reg).mean() opt.zero_grad() loss.backward() opt.step() print(loss.item(), flush=True) ``` <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ## Expected behavior After some random number of updates, in my case 443298 iterations, the problem occurs and training was terminated. In PyTorch 1.3 it shows: > Segmentation fault (core dumped) It prints "True" for the value of "r1_reg" for this iteration, but the loss for the forward pass didn't print out. No other information is shown. <!-- A clear and concise description of what you expected to happen. --> ## Environment I'm using the official PyTorch Docker image to run my training. I used the official image 1.3-cuda10.1-cudnn7-devel. I’m using 4 Titan x (pascal) for data-parallel training. ## Additional context <!-- Add any other context about the problem here. -->
needs reproduction,triaged
low
Critical
555,835,887
go
cmd/go: list and download may read go.mod unnecessarily
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.14beta1 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/Users/jayconrod/Library/Caches/go-build" GOENV="/Users/jayconrod/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOINSECURE="" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/jayconrod/Code/repro/gopath" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/opt/go/installed" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/opt/go/installed/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="/Users/jayconrod/Code/test/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/rq/x0692kqj6ml8cvrhcqh5bswc008xj1/T/go-build200463196=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? Run `go list -m` or `go mod download` in a directory with a malformed `go.mod` file. The commands are run with arguments that should not require information about the main module or the build list, so it shouldn't actually be necessary to read `go.mod`. ``` go list -m -versions golang.org/x/mod go mod download golang.org/x/[email protected] -- go.mod -- Κ•β—”Ο–β—”Κ” ``` ### What did you expect to see? Both commands should succeed. ### What did you see instead? Both commands fail with an error like the one below: ``` go: errors parsing go.mod: /Users/jayconrod/Code/test/go.mod:1: unknown directive: Κ•β—”Ο–β—”Κ” ```
NeedsFix,modules
low
Critical
555,859,465
TypeScript
Case Sensitivity while importing in TypeScript
*TS Template added by @mjbvz* **TypeScript Version**: 3.8.0-dev.20200108 **Search Terms** - windows - case sensitivity --- Issue Type: <b>Bug</b> 1) Create a file in the tree using right click -> New File 2) Name the file "A-file.ts" 3) Rename the file using right click -> Rename to "a-file.ts" 4) Auto-import any exported method from "a-file.ts". It will show as: ```js import { xyz } from "A-file" ``` However, it should be: ```js import { xyz } from "a-file" ``` Probably related to NTFS not renaming a file when just the case of a letter is changed? VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:35:18.241Z) OS version: Windows_NT x64 10.0.18362 <!-- generated by issue reporter -->
Bug
low
Critical
555,861,144
flutter
v2 embedding docs don't explain background plugin cases
This was raised by @ryanheise in [flutter/flutter/issues/47153#issuecomment-578418750](https://github.com/flutter/flutter/issues/47153#issuecomment-578418750): > The critical thing I was looking for in this project [the android_alarm_manager plugin] was how to initialise the background isolate. > > There are various comments in `FlutterBackgroundExecutor` which touch on things that I would love to see fully explained in the guide and API documentation: > > ```java > // We need to create an instance of `FlutterEngine` before looking up the > // callback. If we don't, the callback cache won't be initialized and the > // lookup will fail. > FlutterCallbackInformation flutterCallback = > FlutterCallbackInformation.lookupCallbackInformation(callbackHandle); > ``` > > This isn't mentioned in the migration guide and is also not mentioned in the javadoc for `FlutterCallbackInformation`. > > Also: > > ```java > // The pluginRegistrantCallback should only be set in the V1 embedding as > // plugin registration is done via reflection in the V2 embedding. > if (pluginRegistrantCallback != null) { > pluginRegistrantCallback.registerWith(new ShimPluginRegistry(backgroundFlutterEngine)); > } > ``` > > The migration guide does not explain how this reflection approach works. > > Assuming that for each `FlutterEngine` instance, the `GeneratedPluginRegistrant` is automatically called and a new instance of the plugin class is created and attached to the engine resulting in a 1-to-1 mapping between engines and plugins, how does a plugin instance detect whether it is running in a flutter engine that is associated with the activity/ui vs the headless engine? I used to be able to test whether `registrar.activity()` returned null, but now I assume I have to override `onAttachedToEngine` and figure this out from the `FlutterPluginBinding` parameter. > > The `androidalarmmanager` plugin overrides this and uses `getFlutterEngine` which looks almost promising except that this is a deprecated API: > > ```java > @Override > public void onAttachedToEngine(FlutterPluginBinding binding) { > onAttachedToEngine( > binding.getApplicationContext(), binding.getFlutterEngine().getDartExecutor()); > } > ``` > > And even if it were fine for me to call the deprecated `getFlutterEngime` method, I do not see any way from there to get the `RenderSurface` and test whether it's null. > I can now see that `ServiceAware` might be the way to do it, but this API doesn't seem to work, and none of the official plugins demonstrate how to use it. I made my plugin implement both `ActivityAware` and `ServiceAware` but only the lifecycle methods of the former were actually called. I also passed in my `Service` instance as the constructor argument when creating the background `FlutterEngine` but this itself didn't cause the `ServiceAware` callbacks to be called. > > In any event, I got my plugin working with v2 using a different approach. > > As some constructive feedback, I do appreciate all the hard work the Flutter team is doing, BUT I also hope that this migration experience is not something I will ever have to go through again. My suggestion is that a comprehensive migration guide should be in place before the release is rolled out, and should be prominently linked to from the release notes. /cc @xster @matthew-carroll
platform-android,engine,d: api docs,a: existing-apps,P2,a: plugins,team-android,triaged-android
low
Major
555,864,420
godot
ShaderMaterial doesn't save with sensible defaults
**Godot version:** 3.2 rc3 **OS/device including version:** ArcoLinux **Issue description:** When creating a ShaderMaterial and assigning it a shader, Godot will not supply the shader params with sensible defaults, but instead assign null to anything which wasn't set manually. ``` uniform vec4 base_color : hint_color; uniform vec4 pattern_color : hint_color = vec4(1); uniform sampler2D pattern_texture : hint_albedo; uniform vec2 pattern_size = vec2(1); uniform vec2 pattern_offset; uniform vec4 black : hint_color = vec4(.06, .09, .16, 1); uniform vec4 white : hint_color = vec4(1., .91, .83, 1); uniform bool shadeless; uniform bool specular; uniform float spec_softness : hint_range(0, 1) = 0.01; uniform float spec_size : hint_range(0, 1) = 0.01; uniform float threshold : hint_range(0, 1) = 0.; uniform float softness : hint_range(0, 1) = 0.2; ``` ``` [gd_resource type="ShaderMaterial" load_steps=2 format=2] [ext_resource path="res://Source/Shaders/DaisyShader2.shader" type="Shader" id=1] [resource] shader = ExtResource( 1 ) shader_param/base_color = null shader_param/pattern_color = Color( 1, 1, 1, 1 ) shader_param/pattern_size = Vector2( 1, 1 ) shader_param/pattern_offset = null shader_param/black = Color( 0.06, 0.09, 0.16, 1 ) shader_param/white = Color( 1, 0.91, 0.83, 1 ) shader_param/shadeless = null shader_param/specular = null shader_param/spec_softness = 0.01 shader_param/spec_size = 0.01 shader_param/threshold = 0.0 shader_param/softness = 0.2 ``` As seen above, many params are saved as null, when they should be colors, vectors or booleans. In the editor, these always default to, e.g. black, Vector2(0, 0), and false. This works up until the point where you attempt to access this param in code later in, e.g. `(bool)shaderMat.GetShaderParam("specular")`, in which case you get a game crash and a confusing error about something somewhere being null; your first thought is to wonder if the shader material itself is null, but it doesn't seem to be, and you would hardly guess it's due to a value type being null. In an ideal Godot, ShaderMaterial resources would be saved with sensible defaults for its value types; it makes sense for a sampler2d to be possibly null, but checking for a null bool is not intuitive, and checking every param you access for null is tedious.
enhancement,discussion,topic:shaders
low
Critical
555,889,926
rust
Tracking issue for future-incompatibility lint `conflicting_repr_hints`
This is the **summary issue** for a bug fix related to `repr(...)` hints. The goal of this page is describe why this change was made and how you can fix code that is affected by it. It also provides a place to ask questions or register a complaint if you feel the change should not be made. For more information on the policy around future-compatibility warnings, see our [breaking change policy guidelines][guidelines]. [guidelines]: https://forge.rust-lang.org/rustc-bug-fix-procedure.html ### What is the warning for? The compiler incorrectly accepts `#[repr(...)]` hints on data types where the hints are incompatible and have conflicts. Examples of this includes: ```rust // from `src/test/ui/conflicting-repr-hints.rs #[repr(u32, u64)] //~ ERROR conflicting representation hints enum D { D, } ``` We are presently issuing a deny-by-default lint when conflicting representation hints are used together but we expect to transition the lint to hard **errors** in the future. ### How can you fix your code? Generally speaking, the conflict should be fixed by more clearly expressing your intent so that the conflict is resolved.
A-attributes,A-lints,T-compiler,C-future-incompatibility,C-tracking-issue
low
Critical