id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
544,397,660 | flutter | PageController should be ValueListenable<double> | PageController used in PageView widget, should implement ValueListenable, so it could be used in concert with ValueListenableBuilder to synchronize page switching with other "animations" on the screen.
Workaround is straightforward, but it shouldn't be necessary at all.
```
class ListenableController extends ValueListenable<double> {
final PageController pageController;
ListenableController(this.pageController);
@override
void addListener(listener) {
pageController.addListener(listener);
}
@override
void removeListener(listener) {
pageController.removeListener(listener);
}
@override
get value => pageController.page;
}
```
Now I can slide to the next page while building the content of that next page with some cool animation using ValueListenableBuilder. | c: new feature,framework,f: scrolling,c: proposal,P3,team-framework,triaged-framework | low | Major |
544,403,532 | rust | Macro expansion of rental! macro using --pretty=expanded generates uncompilable code | I filed a `cbindgen` bug on this issue [here](https://github.com/eqrion/cbindgen/issues/444), but I believe this is an underlying rustc issue with macro expansion.
What appears to be happening is that the `rental!` macro is generating a number of type bounds via `quote_spanned!` that successfully compile, but cannot be expanded to compilable code.
Attached is a minimal repro for this bug and a playground link containing the expanded macro output. Notice this oddly generated code which seems to come from `rental` here: https://github.com/jpernst/rental/blob/master/rental-impl/src/lib.rs#L423
``` #[doc =
r" The closure may return any value not bounded by one of the special rental lifetimes of the struct."]
pub fn rent<__F, __R>(&self, f: __F) -> __R where
__F: for<'t, 'm> __rental_prelude::FnOnce(&'t (Foo<'m, i32>)) -> __R,
__R {
f(&self.t)
}
```
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=ac7e0dde8adb6601a553502c6d6caf6f
Minimal repro: [repro.zip](https://github.com/eqrion/cbindgen/files/4013627/repro.zip)
| A-pretty,C-bug | low | Critical |
544,408,158 | flutter | flutter_driver - Capture Native UI Elements in Screenshots | ## Use case
I am using the `screenshots` library which uses the `flutter_driver`'s screenshot method to capture screenshots which will be used on the app stores. On iOS, when the on-screen keyboard is displayed on the device and a screenshot is captured, the area where the keyboard appears displays as a black box (e.g. missing from the screenshot). The same appears for the top status bar with the network & battery indicators.
Having the ability to capture exactly what's on the device would be helpful in creating quality release screenshots.
## Proposal
Update `flutter_driver`'s screenshot functionality to capture the entire screen, versus what is rendered by flutter.
Screenshot showing a comparison between the iOS Simulator screenshot & flutter_driver screenshot:
| c: new feature,framework,t: flutter driver,c: proposal,P3,team-framework,triaged-framework | low | Major |
544,408,505 | flutter | Expose ImplicitlyAnimatedWidget's onEnd callback on Material | **Use case**: Responding to Material's implicit animations as in `AnimatedContainer`, etc
**Proposal**: `Material` wraps `_MaterialInterior` which `extends ImplicitlyAnimatedWidget`, so I believe all we need to do is add the `VoidCallback onEnd` argument to `Material` and pass it through | framework,a: animation,f: material design,c: proposal,team-design,triaged-design | low | Major |
544,410,363 | go | proposal: encoding/gob: allow override type marshaling | This is the equivalent change to `encoding/gob` as what's proposed in #5901 for `encoding/json`.
I propose adding the following methods:
```go
// RegisterFunc registers a custom encoder to use for specialized types.
// The input f must be a function of the type func(T) ([]byte, error).
//
// When marshaling a value of type R, the function f is called
// if R is identical to T for concrete types or
// if R implements T for interface types.
// Precedence is given to registered encoders that operate on concrete types,
// then registered encoders that operate on interface types
// in the order that they are registered, then the specialized marshal methods
// (i.e., GobEncode or MarshalBinary), and lastly the default behavior of Encode.
//
// It panics if T is already registered or if interface{} is assignable to T.
func (e *Encoder) RegisterFunc(f interface{})
// RegisterFunc registers a custom decoder to use for specialized types.
// The input f must be a function of the type func([]byte, T) error.
//
// When unmarshaling a value of type R, the function f is called
// if R is identical to T for concrete types or
// if R implements T for interface types.
// Precedence is given to registered decoders that operate on concrete types,
// then registered decoders that operate on interface types
// in the order that they are registered, then the specialized unmarshal methods
// (i.e., GobDecode or UnmarshalBinary), and lastly the default behavior of Decode.
//
// It panics if T is already registered or if interface{} is assignable to T.
func (d *Decoder) RegisterFunc(f interface{})
```
One such use case for this is to make `encoding/gob` compatible with higher-order Go types containing protobuf messages.
```go
enc := gob.NewEncoder(w)
enc.RegisterFunc(proto.Marshal)
enc.Encode(v)
dec := gob.NewDecoder(r)
dec.RegisterFunc(proto.Unmarshal)
dec.Decode(v)
``` | Proposal | low | Critical |
544,416,304 | rust | Tracking issue for RFC 2632, `impl const Trait for Ty` and `~const` (tilde const) syntax (`const_trait_impl`) | **NOTE: See #110395, which tracks a planned rewrite of this feature's implementation**
This is the primary tracking issue for rust-lang/rfcs#2632.
The current RFC text can be found at https://internals.rust-lang.org/t/pre-rfc-revamped-const-trait-impl-aka-rfc-2632/15192
This RFC has not yet been accepted. It is being implemented on a provisional basis to [evaluate the potential fallout](https://github.com/rust-lang/rfcs/pull/2632#issuecomment-567699174).
cc https://github.com/rust-lang/rust/issues/57563
The feature gate is `const_trait_impl`.
### Components
* `#[const_trait]` attribute
* `impl const Trait`
* `T: ~const Trait`
* `append_const_msg` on `rustc_on_unimplemented`
* `#[derive_const]`
* `trait Destruct`
### Open issues
* [x] #88155
* [x] [this test](https://github.com/rust-lang/rust/blob/cb406848eccc3665dfadb241d94fe27137bd0dcb/src/test/ui/rfc-2632-const-trait-impl/call-generic-method-nonconst.rs) shows we can currently still call a `const fn` with a `Trait` bound even if the concrete type does not implement `const Trait`, but just `Trait`. This will fail later during evaluation. Some related discussion can be found in https://github.com/rust-lang/rust/pull/79287#discussion_r528341238
* [x] There are no tests for *using* a `const impl` without *defining* one without the feature gate enabled. This should be added before any `impl const` is added to the standard library.
* [x] We need some tests and probably code around `#[rustc_const_stable]` and `#[rustc_const_unstable]` so we can properly stabilize (or not) the constness of impls in the standard library
* [x] #79450 shows that with default function bodies in the trait declaration, we can cause non-const functions to exist in `impl const Trait` impls by leaving out these default functions
* [ ] We need to determine the final syntax for `~const`. (In the interim, we may want to switch this to use a `k#provisional_keyword` or similar.)
* [ ] If we need `#[default_method_body_is_const]`, determine the syntax for it instead of existing as an attribute
* [ ] `#[derive_const]` for custom derives (proc macros) #118304
* [ ] grep for `110395` and figure out what to do everywhere that issue is mentioned (this is old stuff left over from when the previous const trait impl was removed)
**When stabilizing: compiler changes are required**:
* [ ] Error against putting `rustc_const_unstable` attribute on `const` `impl`s as they are now insta-stable.
* [ ] Treat `default_method_body_is_const` bodies and `const` `impl` bodies as `stable` `const fn` bodies. We need to prevent accidentally stabilizing an implementation that uses unstable lang/lib `const fn` features.
* [ ] Change Rustdoc to display `~const` bounds or what syntax we decided it to be. | A-trait-system,T-lang,C-tracking-issue,A-const-eval,F-const_trait_impl,S-tracking-perma-unstable | high | Critical |
544,421,218 | electron | Open On Correct Display (X11, Multiple logins, different X servers) or Always respect $DISPLAY |
### Preflight Checklist
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
On Linux, Atom, and VSCode both demonstrate this issue, while I don't think that eletrcon itself does, I need at least affirmation that it is a application implenetation issue and not a core electron issue.
I have this new system that I have setup the lastest Arch version, and am up to date as of today with all current versions; the behavior still exists.
- Use a linux system which uses wayland, with X11 module support, for example `weston -xwayland`. (I don't think this is a wayland issue, but that is specifically what I am using).
- Login into the same linux system using a SSH client with X11 forwarding enabled, and the same user account.
- start `atom` or `code` in either session.
- start `atom` or `code` in the other session, the new session will open on the first instances' display.
Some other notes; `DISPLAY=:0` on the wayland/native X server on the system; the local host one. `DISPLAY=:10.0` on the SSH X forwarded login. Although I expect this would also happen if multiple systems used the same login with X forwarding to each, since they should have a different `DISPLAY` environment setting indicating their own display.
I reported this issue https://github.com/microsoft/vscode/issues/87498 But have not approached that atom, but I got '@d3x0r does that happen with any other electron app?' as the first response... so, it happens to be 'yes'. Does this mean that electron isn't working by design and it's something that Atom is doing that VSCode inherited?
### Proposed Solution
### Alternatives Considered
### Additional Information
I recently bought this system; it's a AMD 1605B fanless box with 4 HDMI outputs. I intend to do signage with such a system. But during deveopment, I have a 4k Projector (AAXA 4K1) connected to it, and meanwhile I have a windows system that's my main operating terminal. So, I have SSH connection to it for editing my code on the box natively, but then I can also recline in the comfy chairs and also do coding (the projector is native 4k, and although black on white gets lost, white on black text is entirely readable at 4K Linux default console font size. I started 'code .' and the display didn't show up... I went to another place and started another one... eventually I got back to my windows terminal, and found that there were 3 more editors open on that system, and none on the system I launched them on. It appears that there's a shared memory region that's (user?group?system?) shared that overrides whatever the current DISPLAY environment variable is.
I haven't tested if I launch.... (revise). I did `xhost +` and was able to test if root on the same local display launches, the application shows up on the correct 'local' display. So it's at least isolated by user; I was tempted to post this as a security issue....
| enhancement :sparkles:,x11 | low | Major |
544,427,622 | flutter | CompositedTransformFollower expands infinitely in some cases | `CompositedTransformFollower` does not respect the box constraints of it's children.
Other users seemto have encountered this as well, but haven't raised issues -
[this medium post](https://medium.com/saugo360/https-medium-com-saugo360-flutter-using-overlay-to-display-floating-widgets-2e6d0e8decb9) notes that "`follower` tends to extend infinitely if not bounded."
## Steps to Reproduce
Pass `Overlay.of(context).insert` something like
```dart
OverlayEntry(
builder: (context) {
return CompositedTransformFollower(
link: this._layerLink,
child: Container(color: Colors.pink, width: 50, height: 50),
),
);
},
);
```
The container should expand without bounds.
I [worked around this issue](https://gist.github.com/micimize/7579a66861cf56ba241b224a64566d51) by throwing a bunch of fitted boxes into the layout:
```dart
FittedBox(
fit: BoxFit.cover,
child: CompositedTransformFollower(
link: this._layerLink,
child: FittedBox(
fit: BoxFit.none,
child: widget.overlay,
),
),
);
``` | framework,d: api docs,has reproducible steps,P2,found in release: 3.3,found in release: 3.5,team-framework,triaged-framework | low | Major |
544,429,208 | godot | Transform notifications (NOTIFICATION_TRANSFORM_CHANGED) are no longer received once a Tween has been used | **Godot version:**
3.1.2 (Mono)
**OS/device including version:**
Windows 10
**Issue description:**
If a Tween is used to translate a node (or a parent of that node), then notifications of type `NOTIFICATION_TRANSFORM_CHANGED` stop being sent for that node.
I am unsure if other notifications are also interfered with.
**Steps to reproduce:**
1. Listen for transformation changes on a node by calling `set_notify_transform(true)`.
2. Scale the node with the 'scale' property, and notice a transformation notification is received (via the `func _notification(what):` callback).
3. Use a tween to adjust the `scale` property on the same node . Notice no transformation notification is received.
4. (Optional) Scale the node again directly with `scale` property. Notice no transformation notification is received.
**Minimal reproduction project:**
[Testing-TweenNotification.zip](https://github.com/godotengine/godot/files/4014799/Testing-TweenNotification.zip)
Object listening for notifications is in `ListeningNode.gd`. Tween via code in `Scene.gd`.
| bug,confirmed,documentation,topic:2d | low | Major |
544,459,003 | react-native | [Android] skew transform not working | ## Steps To Reproduce
1. Try to set `skewX` for View component: `transforms: [{ skewX: '45deg' }}`
3. Doesn't change the skew of View on Android (works on iOS)
### Describe what you expected to happen:
Basically `skewX` doesn't apply any skew on the view on Android.
Here is comparison between iOS/Android:
> also `skewY` doesn't render same as on iOS (which looks more correct)
<img width="779" alt="Screenshot 2020-01-02 at 2 13 00 PM" src="https://user-images.githubusercontent.com/5339061/71653948-044a8f80-2d6a-11ea-852c-c6814d8dc84a.png">
### React Native version:
```
System:
OS: macOS Mojave 10.14.6
CPU: (12) x64 Intel(R) Core(TM) i7-9750H CPU @ 2.60GHz
Memory: 1.50 GB / 16.00 GB
Shell: 5.3 - /bin/zsh
Binaries:
Node: 12.13.0 - ~/.nvm/versions/node/v12.13.0/bin/node
Yarn: 1.19.1 - ~/.yarn/bin/yarn
npm: 6.12.0 - ~/.nvm/versions/node/v12.13.0/bin/npm
SDKs:
iOS SDK:
Platforms: iOS 13.2, DriverKit 19.0, macOS 10.15, tvOS 13.2, watchOS 6.1
Android SDK:
API Levels: 25, 28, 29
Build Tools: 28.0.3, 29.0.2
System Images: android-28 | Google Play Intel x86 Atom, android-29 | Google APIs Intel x86 Atom
IDEs:
Android Studio: 3.5 AI-191.8026.42.35.5977832
Xcode: 11.3/11C29 - /usr/bin/xcodebuild
npmPackages:
react: 16.9.0 => 16.9.0
react-native: 0.61.5 => 0.61.5
```
### Related issues
- [x] https://github.com/facebook/react-native/issues/12212
### Snack demo
https://snack.expo.io/@usrbowe2/e9b920
### Resources
In case anyone interested, here is the source code for skew code:
1. This is called for SkewX: `MatrixMathHelper.applySkewX(helperMatrix, convertToRadians(transform, transformType));` in file: `Libraries/StyleSheet/processTransform.js`
2. Which laters uses this matrix helper to apply transformation:
https://github.com/facebook/react-native/blob/master/ReactAndroid/src/main/java/com/facebook/react/uimanager/MatrixMathHelper.java
| Platform: Android,Bug | high | Critical |
544,490,959 | rust | Add a rustdoc flag to show the source code externally | One of the features of docs.rs is [to show the source code in its UI](https://docs.rs/crate/lazy_static/1.4.0/source/src/lib.rs), but rustdoc [provides its own view of the source](https://docs.rs/lazy_static/1.4.0/src/lazy_static/lib.rs.html) as well. This duplication is both confusing for the user, but also duplicates the amount of storage docs.rs uses to store source code.
It'd be nice to have a rustdoc flag (unstable is fine) like `--source-code-base`, that prevents rustdoc from emitting the source pages on its own and replaces the `[src]` links with links to the source code base. For example, with `--source-code-base ../../crate/lazy_static/1.4.0/source`, the `[src]` for `lib.rs` would be `../../crate/lazy_static/1.4.0/source/src/lib.rs`, and rustdoc's own src page would be missing.
cc @GuillaumeGomez @jyn514 | T-rustdoc,C-feature-request | medium | Major |
544,515,004 | youtube-dl | https://coursehunter.net/ | - [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.01.01**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video:https://coursehunter.net/course/udemy-vuejs-2
- Single video:https://coursehunter.net/course/udemy-vuejs-2
- Playlist: https://coursehunter.net/course/udemy-vuejs-2
## Description
<!--
there is required credentials
-->
WRITE DESCRIPTION HERE
| site-support-request | low | Critical |
544,519,911 | vue | Should `fill` and `copyWithIn` methods be intercepted (observed) now ? | ### What problem does this feature solve?
`fill` and `copyWithIn` methods are also mutating methods and has Standard status currently [ECMAScript 2015 Language Specification – ECMA-262 6th Edition - copywithin](https://www.ecma-international.org/ecma-262/6.0/#sec-array.prototype.copywithin) , but they aren't being intercepted in https://github.com/vuejs/vue/blob/237294d88f65d65dcb790246394f1d37d64856a0/src/core/observer/array.js#L11-L19. Should they join now ?
### What does the proposed API look like?
null
<!-- generated by vue-issues. DO NOT REMOVE --> | feature request,discussion | low | Minor |
544,527,453 | neovim | Opening more than one file of an sshfs mount fails on windows | I mounted a remote directory via SSHFS-Win (V2.7.17334) and WinFsp (2019.2).
Now when i open the first file in the mounted directory everything i tried worked as expected. Opening, writing, ... all work fine.
The problem arises when I try to open a second file on the same sshfs mount. On `:edit second-file` neovim if the file exist simply does nothing as far as i can see.
Opening and writing Files in other directories work fine, so does creating an empty buffer on the sshfs mount and writing it.
I also tried `:cd`-ing into the mount vs opening files with an absolute path to no avail.
I tried this with neovim 0.4.2 and the current nightly build 0.5.0-283-ga251b588a | bug,platform:windows,filesystem,network | low | Major |
544,555,173 | TypeScript | Extend createMethodSignature and updateMethodSignature with 'modifiers' argument | ## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
updateMethodSignature, createMethodSignature
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
It should be possible to provide an array of Modifiers (or `undefined`) to the `createMethodSignature` and `updateMethodSignature` functions.
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
When using the TypeScript compiler APIs, TypeScript provides numerous `create` and `update` functions that can be used to generate an AST, for example from Custom Transformers. However, for `MethodSignature`s, which may have modifiers such as the `static` keyword, there's no option to create or update their modifiers. This breaks [one of my libraries](https://github.com/wessberg/ts-clone-node) which sole purpose is to simply deep-clone a TypeScript node. A workaround is to manually patch the modifiers, however I hope this can be part of the function (as it is for others, like `createPropertySignature` and `updatePropertySignature`).
## Examples
<!-- Show how this would be used and what the behavior would be -->
```typescript
import {createMethodSignature, createNodeArray, createModifier, SyntaxKind} from "typescript";
createMethodSignature(
createNodeArray([
createModifier(SyntaxKind.StaticKeyword)
]),
node.typeParameters,
node.parameters,
node.type,
node.name,
node.questionToken
);
```
However, the above example would be a breaking change since the first parameter expects a NodeArray of type parameters, so an alternative solution would be to accept it as the last argument.
## Checklist
My suggestion meets these guidelines:
* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,In Discussion,API | low | Minor |
544,583,335 | godot | Crash when connecting or disconnecting a signal from multiple threads | **Godot version:**
v3.2.beta.custom_build. 318c69351
**OS/device including version:**
Arch Linux, 64 bit, updated around mid-December.
**Issue description:**
When connecting to an object from multiple threads, its `slot_map` can get corrupted, leading to missing entries or crashes. I feel something similar might be possible with the `connections` list
Issue was observed by Discord user Sungray while creating multiple sprite nodes with the same texture from different threads. (Which leads to those sprites connecting to the texture's changed signal.)
**Steps to reproduce:**
Put this script on any node:
```gdscript
extends Node
signal dummy_signal()
class DummyObject extends Object:
func dummy_method():
pass
func _ready():
var threads = []
for i in range(2):
var thread = Thread.new()
thread.start(self, "_thread", null)
threads.push_back(thread)
func _thread(_x):
while true:
var object = DummyObject.new()
connect("dummy_signal", object, "dummy_method") # dummy method
object.call_deferred("free") # Run the free on the main thread, locks up
#object.free() # Run the free on the non-main thread, crashes
```
Run, should crash or enter an infinite loop on the main thread relatively fast.
When the project freezes, it should spam a errors looking like:
```
ERROR: _disconnect: Disconnecting nonexistent signal 'dummy_signal', slot: 1224:dummy_method.
At: core/object.cpp:1526.
```
When crashing, it can generate a wide array of backtraces. Some of them are related to `malloc` or `free`, surprisingly.
<details>
<summary>No backtrace crashes (likely malloc-related) </summary>
```
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
malloc(): invalid next->prev_inuse (unsorted)
```
```
realloc(): invalid next size
```
```
double free or corruption (!prev)
```
```
free(): corrupted unsorted chunks
```
</details>
<details>
<summary>One or more backtrace crashes</summary>
```
handle_crash: Program crashed with signal 4
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
handle_crash: Program crashed with signal 11
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x3bfb0) [0x7fa7a7b21fb0] (??:0)
[1] /usr/lib/libc.so.6(+0x3bfb0) [0x7fa7a7b21fb0] (??:0)
[1] /usr/lib/libc.so.6(+0x3bfb0) [0x7fa7a7b21fb0] (??:0)
[2] Object::Signal::Target::operator<(Object::Signal::Target const&) const (/home/bobo/Projects/godot/godot/./core/object.h:449)
[2] StringName::unref() (/home/bobo/Projects/godot/godot/./core/safe_refcount.h:118)
[2] CowData<VMap<Object::Signal::Target, Object::Signal::Slot>::Pair>::get_m(int) (/home/bobo/Projects/godot/godot/./core/cowdata.h:145)
[3] StringName::~StringName() (/home/bobo/Projects/godot/godot/core/string_name.cpp:422)
[3] VMap<Object::Signal::Target, Object::Signal::Slot>::_find_exact(Object::Signal::Target const&) const (/home/bobo/Projects/godot/godot/./core/vmap.h:104)
[3] VMap<Object::Signal::Target, Object::Signal::Slot>::operator[](Object::Signal::Target const&) (/home/bobo/Projects/godot/godot/./core/vmap.h:202)
[4] Object::Connection::~Connection() (/home/bobo/Projects/godot/godot/./core/object.h:412)
[4] VMap<Object::Signal::Target, Object::Signal::Slot>::has(Object::Signal::Target const&) const (/home/bobo/Projects/godot/godot/./core/vmap.h:131)
[4] Object::connect(StringName const&, Object*, StringName const&, Vector<Variant> const&, unsigned int) (/home/bobo/Projects/godot/godot/core/object.cpp:1485)
[5] Object::Signal::Slot::~Slot() (/home/bobo/Projects/godot/godot/./core/object.h:458)
[5] MethodBind5R<Object, Error, StringName const&, Object*, StringName const&, Vector<Variant> const&, unsigned int>::call(Object*, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/method_bind.gen.inc:4285)
[5] Object::_disconnect(StringName const&, Object*, StringName const&, bool) (/home/bobo/Projects/godot/godot/core/object.cpp:1526)
[6] VMap<Object::Signal::Target, Object::Signal::Slot>::Pair::~Pair() (/home/bobo/Projects/godot/godot/./core/vmap.h:40)
[6] Object::~Object() (/home/bobo/Projects/godot/godot/core/object.cpp:1974)
[6] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/object.cpp:921)
[7] void memdelete<Object>(Object*) (/home/bobo/Projects/godot/godot/./core/os/memory.h:117)
[7] CowData<VMap<Object::Signal::Target, Object::Signal::Slot>::Pair>::resize(int) (/home/bobo/Projects/godot/godot/./core/cowdata.h:304)
[7] Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/variant_call.cpp:1112)
[8] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/object.cpp:893)
[8] CowData<VMap<Object::Signal::Target, Object::Signal::Slot>::Pair>::insert(int, VMap<Object::Signal::Target, Object::Signal::Slot>::Pair const&) (/home/bobo/Projects/godot/godot/./core/cowdata.h:175)
[8] GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) (/home/bobo/Projects/godot/godot/modules/gdscript/gdscript_function.cpp:1081)
[9] GDScriptInstance::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/modules/gdscript/gdscript.cpp:1173)
[9] MessageQueue::_call_function(Object*, StringName const&, Variant const*, int, bool) (/home/bobo/Projects/godot/godot/core/message_queue.cpp:250)
[9] VMap<Object::Signal::Target, Object::Signal::Slot>::insert(Object::Signal::Target const&, Object::Signal::Slot const&) (/home/bobo/Projects/godot/godot/./core/vmap.h:125)
[10] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/object.cpp:900)
[10] MessageQueue::flush() (/home/bobo/Projects/godot/godot/core/message_queue.cpp:299)
[10] VMap<Object::Signal::Target, Object::Signal::Slot>::operator[](Object::Signal::Target const&) (/home/bobo/Projects/godot/godot/./core/vmap.h:199)
[11] SceneTree::iteration(float) (/home/bobo/Projects/godot/godot/scene/main/scene_tree.cpp:485)
[11] _Thread::_start_func(void*) (/home/bobo/Projects/godot/godot/core/bind/core_bind.cpp:2660)
[11] Object::connect(StringName const&, Object*, StringName const&, Vector<Variant> const&, unsigned int) (/home/bobo/Projects/godot/godot/core/object.cpp:1485)
[12] Main::iteration() (/home/bobo/Projects/godot/godot/main/main.cpp:1987)
[13] OS_X11::run() (/home/bobo/Projects/godot/godot/platform/x11/os_x11.cpp:3255)
[12] ThreadPosix::thread_callback(void*) (/home/bobo/Projects/godot/godot/drivers/unix/thread_posix.cpp:76)
[14] godot3.dbg(main+0x1a3) [0x178b5f3] (/home/bobo/Projects/godot/godot/platform/x11/godot_x11.cpp:56)
[13] /usr/lib/libpthread.so.0(+0x94cf) [0x7fa7a80074cf] (??:0)
[15] /usr/lib/libc.so.6(__libc_start_main+0xf3) [0x7fa7a7b0d153] (??:0)
[14] /usr/lib/libc.so.6(clone+0x43) [0x7fa7a7be52d3] (??:0)
-- END OF BACKTRACE --
```
```
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[2] CowData<VMap<Object::Signal::Target, Object::Signal::Slot>::Pair>::get_m(int) (/home/bobo/Projects/godot/godot/./core/cowdata.h:145)
[1] /usr/lib/libc.so.6(+0x3bfb0) [0x7f2df29e5fb0] (??:0)
Failed method: Object:free target ID: 44863
Object was deleted while awaiting a callback # Repeated many times
## This one is fishy -- probably one of the threads crashed, while the other continued working and spamming the message queue.
```
Without deferring `free`:
```
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x3bfb0) [0x7f523442dfb0] (??:0)
[2] Object::Signal::Target::operator<(Object::Signal::Target const&) const (/home/bobo/Projects/godot/godot/./core/object.h:449)
[3] VMap<Object::Signal::Target, Object::Signal::Slot>::_find_exact(Object::Signal::Target const&) const (/home/bobo/Projects/godot/godot/./core/vmap.h:104)
[4] VMap<Object::Signal::Target, Object::Signal::Slot>::has(Object::Signal::Target const&) const (/home/bobo/Projects/godot/godot/./core/vmap.h:131)
[5] Object::_disconnect(StringName const&, Object*, StringName const&, bool) (/home/bobo/Projects/godot/godot/core/object.cpp:1526)
[6] Object::~Object() (/home/bobo/Projects/godot/godot/core/object.cpp:1974)
[7] void memdelete<Object>(Object*) (/home/bobo/Projects/godot/godot/./core/os/memory.h:117)
[8] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/object.cpp:893)
[9] Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/variant_call.cpp:1112)
[10] GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) (/home/bobo/Projects/godot/godot/modules/gdscript/gdscript_function.cpp:1081)
[11] GDScriptInstance::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/modules/gdscript/gdscript.cpp:1173)
[12] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/object.cpp:900)
[13] _Thread::_start_func(void*) (/home/bobo/Projects/godot/godot/core/bind/core_bind.cpp:2660)
[14] ThreadPosix::thread_callback(void*) (/home/bobo/Projects/godot/godot/drivers/unix/thread_posix.cpp:76)
[15] /usr/lib/libpthread.so.0(+0x94cf) [0x7f52349134cf] (??:0)
[16] /usr/lib/libc.so.6(clone+0x43) [0x7f52344f12d3] (??:0)
-- END OF BACKTRACE --
```
```
ERROR: _find: low > high, this may be a bug
At: ./core/vmap.h:70.
handle_crash: Program crashed with signal 11
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /usr/lib/libc.so.6(+0x3bfb0) [0x7f9a19eadfb0] (??:0)
[2] StringName::operator=(StringName const&) (/home/bobo/Projects/godot/godot/./core/safe_refcount.h:107)
[3] Object::Connection::operator=(Object::Connection const&) (/home/bobo/Projects/godot/godot/./core/object.h:412)
[4] Object::Signal::Slot::operator=(Object::Signal::Slot const&) (/home/bobo/Projects/godot/godot/./core/object.h:458)
[5] VMap<Object::Signal::Target, Object::Signal::Slot>::Pair::operator=(VMap<Object::Signal::Target, Object::Signal::Slot>::Pair const&) (/home/bobo/Projects/godot/godot/./core/vmap.h:40)
[6] CowData<VMap<Object::Signal::Target, Object::Signal::Slot>::Pair>::remove(int) (/home/bobo/Projects/godot/godot/./core/cowdata.h:164)
[7] VMap<Object::Signal::Target, Object::Signal::Slot>::erase(Object::Signal::Target const&) (/home/bobo/Projects/godot/godot/./core/vmap.h:140)
[8] Object::_disconnect(StringName const&, Object*, StringName const&, bool) (/home/bobo/Projects/godot/godot/core/object.cpp:1538)
[9] Object::~Object() (/home/bobo/Projects/godot/godot/core/object.cpp:1974)
[10] void memdelete<Object>(Object*) (/home/bobo/Projects/godot/godot/./core/os/memory.h:117)
[11] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/object.cpp:893)
[12] Variant::call_ptr(StringName const&, Variant const**, int, Variant*, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/variant_call.cpp:1112)
[13] GDScriptFunction::call(GDScriptInstance*, Variant const**, int, Variant::CallError&, GDScriptFunction::CallState*) (/home/bobo/Projects/godot/godot/modules/gdscript/gdscript_function.cpp:1081)
[14] GDScriptInstance::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/modules/gdscript/gdscript.cpp:1173)
[15] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/bobo/Projects/godot/godot/core/object.cpp:900)
[16] _Thread::_start_func(void*) (/home/bobo/Projects/godot/godot/core/bind/core_bind.cpp:2660)
[17] ThreadPosix::thread_callback(void*) (/home/bobo/Projects/godot/godot/drivers/unix/thread_posix.cpp:76)
[18] /usr/lib/libpthread.so.0(+0x94cf) [0x7f9a1a3934cf] (??:0)
[19] /usr/lib/libc.so.6(clone+0x43) [0x7f9a19f712d3] (??:0)
-- END OF BACKTRACE --
```
```
(gdb) bt
#0 0x00000000046840c8 in atomic_conditional_increment<unsigned int> (pw=0x20051) at ./core/safe_refcount.h:107
#1 SafeRefCount::ref (this=0x20051) at ./core/safe_refcount.h:182
#2 StringName::StringName (this=0x7fffcc001158, p_name=...) at core/string_name.cpp:173
#3 0x0000000002d71d6b in Object::Connection::Connection (this=0x7fffcc001140) at ./core/object.h:412
#4 0x000000000462541d in Object::Signal::Slot::Slot (this=0x7fffcc001138) at ./core/object.h:458
#5 0x000000000462536f in VMap<Object::Signal::Target, Object::Signal::Slot>::Pair::Pair (this=0x7fffcc001128) at ./core/vmap.h:40
#6 0x0000000004625279 in CowData<VMap<Object::Signal::Target, Object::Signal::Slot>::Pair>::_copy_on_write (this=0x7fffcc000f60)
at ./core/cowdata.h:241
#7 0x00000000046261de in CowData<VMap<Object::Signal::Target, Object::Signal::Slot>::Pair>::set (this=0x7fffcc000f60, p_index=1,
p_elem=...) at ./core/cowdata.h:139
#8 0x0000000004625bb5 in CowData<VMap<Object::Signal::Target, Object::Signal::Slot>::Pair>::insert (this=0x7fffcc000f60, p_pos=1,
p_val=...) at ./core/cowdata.h:178
#9 0x000000000462585d in VMap<Object::Signal::Target, Object::Signal::Slot>::insert (this=0x7fffcc000f60, p_key=..., p_val=...)
at ./core/vmap.h:125
#10 0x00000000046220e6 in VMap<Object::Signal::Target, Object::Signal::Slot>::operator[] (this=0x7fffcc000f60, p_key=...)
at ./core/vmap.h:199
#11 0x000000000461a406 in Object::connect (this=0x6f9f170, p_signal=..., p_to_object=0x7fffcc000b90, p_to_method=..., p_binds=...,
p_flags=0) at core/object.cpp:1485
#12 0x0000000004630e8f in MethodBind5R<Object, Error, StringName const&, Object*, StringName const&, Vector<Variant> const&, unsigned int>::call (this=0x6409750, p_object=0x6f9f170, p_args=0x7fffd7eb8ef0, p_arg_count=3, r_error=...) at core/method_bind.gen.inc:4285
#13 0x00000000046157f9 in Object::call (this=0x6f9f170, p_method=..., p_args=0x7fffd7eb8ef0, p_argcount=3, r_error=...)
at core/object.cpp:921
#14 0x00000000046d28f5 in Variant::call_ptr (this=0x7fffd7ebaa60, p_method=..., p_args=0x7fffd7eb8ef0, p_argcount=3, r_ret=0x0,
r_error=...) at core/variant_call.cpp:1112
#15 0x00000000018ea067 in GDScriptFunction::call (this=0x67f0d70, p_instance=0x7260fa0, p_args=0x7fffd7ebad60, p_argcount=1,
r_err=..., p_state=0x0) at modules/gdscript/gdscript_function.cpp:1081
#16 0x0000000001883b04 in GDScriptInstance::call (this=0x7260fa0, p_method=..., p_args=0x7fffd7ebad60, p_argcount=1, r_error=...)
at modules/gdscript/gdscript.cpp:1173
#17 0x000000000461563f in Object::call (this=0x6f9f170, p_method=..., p_args=0x7fffd7ebad60, p_argcount=1, r_error=...)
at core/object.cpp:900
#18 0x000000000492bc25 in _Thread::_start_func (ud=0x70e3f00) at core/bind/core_bind.cpp:2660
#19 0x000000000242b95c in ThreadPosix::thread_callback (userdata=0x725f4f0) at drivers/unix/thread_posix.cpp:74
#20 0x00007ffff7a164cf in start_thread () from /usr/lib/libpthread.so.0
#21 0x00007ffff75f42d3 in clone () from /usr/lib/libc.so.6
```
```
(gdb) bt
#0 0x000000000462513a in CowData<VMap<Object::Signal::Target, Object::Signal::Slot>::Pair>::get_m (this=0x7fffcc000f60, p_index=1)
at ./core/cowdata.h:145
#1 0x0000000004622129 in VMap<Object::Signal::Target, Object::Signal::Slot>::operator[] (this=0x7fffcc000f60, p_key=...)
at ./core/vmap.h:202
#2 0x000000000461a406 in Object::connect (this=0x6f9e950, p_signal=..., p_to_object=0x7fffcc000b90, p_to_method=..., p_binds=...,
p_flags=0) at core/object.cpp:1485
#3 0x0000000004630e8f in MethodBind5R<Object, Error, StringName const&, Object*, StringName const&, Vector<Variant> const&, unsigned int>::call (this=0x6409750, p_object=0x6f9e950, p_args=0x7fffd7eb8ef0, p_arg_count=3, r_error=...) at core/method_bind.gen.inc:4285
#4 0x00000000046157f9 in Object::call (this=0x6f9e950, p_method=..., p_args=0x7fffd7eb8ef0, p_argcount=3, r_error=...)
at core/object.cpp:921
#5 0x00000000046d28f5 in Variant::call_ptr (this=0x7fffd7ebaa60, p_method=..., p_args=0x7fffd7eb8ef0, p_argcount=3, r_ret=0x0,
r_error=...) at core/variant_call.cpp:1112
#6 0x00000000018ea067 in GDScriptFunction::call (this=0x67f0560, p_instance=0x7260480, p_args=0x7fffd7ebad60, p_argcount=1,
r_err=..., p_state=0x0) at modules/gdscript/gdscript_function.cpp:1081
#7 0x0000000001883b04 in GDScriptInstance::call (this=0x7260480, p_method=..., p_args=0x7fffd7ebad60, p_argcount=1, r_error=...)
at modules/gdscript/gdscript.cpp:1173
#8 0x000000000461563f in Object::call (this=0x6f9e950, p_method=..., p_args=0x7fffd7ebad60, p_argcount=1, r_error=...)
at core/object.cpp:900
#9 0x000000000492bc25 in _Thread::_start_func (ud=0x70e3610) at core/bind/core_bind.cpp:2660
#10 0x000000000242b95c in ThreadPosix::thread_callback (userdata=0x725e9d0) at drivers/unix/thread_posix.cpp:74
#11 0x00007ffff7a164cf in start_thread () from /usr/lib/libpthread.so.0
#12 0x00007ffff75f42d3 in clone () from /usr/lib/libc.so.6
```
</details>
**Minimal reproduction project:**
| bug,topic:core,confirmed,crash | medium | Critical |
544,596,525 | pytorch | Support Python builtins on iterators in JIT | ## 🚀 Feature
The exact example I stumbled upon, but there must be others:
```py
x: List[Tensor]
xrev = list(reversed(x)) # Fails because `reversed` expects only a Tensor in TorchScript
```
## Motivation
Lists of Tensors are somewhat supported in TorchScript and they do have their uses. But some builtins currently do not work with them, like `reversed`.
Plain Tensors cannot replace lists in every way (for example, what if I really don't want to allocate just to get all the elements in a list in one Tensor? What if the elements don't even fit by dimensionality?) so this's missing functionality.
## Pitch
For supported bulitins that support iterators, support List and Tuple values just as Tensors are supported.
## Alternatives
Not sure.
## Additional context
#18627
cc @suo | oncall: jit,triaged | low | Minor |
544,624,529 | angular | incorrect component passed to canDeactivate guard | <!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🐞 bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- ✍️edit: --> The issue is caused by package @angular/router
### Description
For some reason CanDeactivate guard gets called with an incorrect component instance.
In this case it should get called with a component that is mounted in a named outlet, but gets called with one from primary outlet. See example in stackblitz.
I'd expect that with configuration like below:
The guard should only be called when `AdminHeaderComponent` is being deactivated and only with this component instance.
One notable thing is that the `currentRoute` param is correct!
EDIT: found a workaround:
```
canDeactivate(component: HasComponentPendingChanges, currentRoute: ActivatedRouteSnapshot, currentState: RouterStateSnapshot) {
if (currentRoute.outlet === OVERLAY_OUTLET && this.router['rootContexts'] && this.router['rootContexts'].getContext) {
const context: OutletContext = this.router['rootContexts'].getContext(OVERLAY_OUTLET);
if (context && context.outlet && context.outlet.isActivated && context.outlet['activated'].instance) {
component = context.outlet['activated'].instance;
}
}
```
## 🔬 Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2
-->
https://stackblitz.com/edit/angular-named-outlet-yfgsip?file=app%2Fadmin%2Fadmin.module.ts
- Open the link
- Open the console
- Click on `admin` link
- Click on `create user` link
- Observe that following message is printed:
```
deactivating UsersListComponent {}
```
- Now click on `hide navbar` link
- Observe that following messages are printed:
```
deactivating CreateUserComponent {}
deactivating AdminHeaderComponent {}
```
^ all good
- Now the fun begins, click on `admin` and `create user` links again
- Click on `Component 2`
- Observe that following messages are printed:
```
deactivating UsersListComponent {}
deactivating CreateUserComponent {}
deactivating CreateUserComponent {}
```
I'd argue that the last message should state `AdminHeaderComponent`
## 🌍 Your Environment
**Angular Version:**
<pre><code>
8.2.14
</code></pre>
| type: bug/fix,freq1: low,area: router,state: confirmed,router: guards/resolvers,P3 | low | Critical |
544,624,933 | opencv | TypeError: Not a cmessage converting tensorflow model from .pb to .pbtxt | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
- OpenCV => 4.2.0
- Operating System / Platform => Ubuntu 18.04 64 bits
- Compiler => cmake
##### Detailed description
I am trying to generate a .pbtxt from a tensorflow frozen_inference_graph.pb file. I'm using a custom model based on ssd_resnet_50_fpn_coco tensorflow model.
When I run the [text_graph_ssd.py](https://github.com/opencv/opencv/blob/master/samples/dnn/tf_text_graph_ssd.py) on a ssd_inception_v2_coco custom model it generates the .pbtxt file without issues.
However when tried on the resnet model, at first got the output mentioned in #11560, then aplied the fix mentioned there.
Now, I have a new error:
```
Traceback (most recent call last):
File "tf_text_graph_ssd.py", line 377, in <module>
createSSDGraph(args.input, args.config, args.output)
File "tf_text_graph_ssd.py", line 261, in createSSDGraph
addConstNode('concat/axis_flatten', [-1], graph_def)
File "/home/blue/tensorflow/scripts/postprocessing/tf_text_graph_common.py", line 114, in addConstNode
graph_def.node.extend([node])
TypeError: Not a cmessage
```
I tried with the fix mentioned in #15176, but it didn't work.
##### Steps to reproduce
1. Download my .pb file from [here](https://gofile.io/?c=ymew4E)
2. Download the text_graph_ssd.py that I'm using [here](https://pastebin.com/FHmicfk3) and run the script. (Be sure to have the text_graph_common.py in the same directory).
| category: dnn | low | Critical |
544,630,008 | rust | UdpSocket is missing the dissolve method | According to [connect](http://man7.org/linux/man-pages/man2/connect.2.html)
> `UdpSocket` can dissolve the association by connecting to an address with the `sa_family` member of `sockaddr` set to `AF_UNSPEC` (supported on Linux since kernel 2.2).
`FreeBSD` supports as well.
> Datagram sockets may dissolve the association by connecting to an invalid address, such as a null address. | T-libs-api,C-feature-request | low | Minor |
544,646,993 | pytorch | Documentation for `scatter` incorrectly states that index values must be unique | ## 📚 Documentation
Documentation for `scatter_` and `scatter_add_` incorrectly states that "Moreover, as for gather(), the values of index must be between 0 and self.size(dim) - 1 inclusive, and all values in a row along the specified dimension dim must be unique."
https://pytorch.org/docs/stable/tensors.html?highlight=scatter_add#torch.Tensor.scatter_
There is no requirement for elements to be unique in either of 3 functions (`scatter_`, `scatter_add_`, `gather`), and `gather` documentation correctly does not mention that requirement.
In case of `scatter_`, there is no guarantees of which value from the source with the same indices ends up being written to `self`, in case of `scatter_add_` values from the source with the same indices are accumulated.
There is a broader issue aside from the documentation here, because depending on whether indices are unique or repeating, parallel implementation for `scatter_add_` can be different (`scatter` is fine although can be non-deterministic). Maybe we should allow users to indicate if their indices are unique, so that we can choose more efficient implementation. The implementation variants are
1) indices are guaranteed to be unique - any naive implementation writing values from src to self will work, parallelization is easy
2) non-unique indices, but we are fine with non-deterministic behavior - we can use atomic accumulation in this case, and still do efficient parallelization
3) non-unique indices, and we want deterministic results - some more sophisticated algorithms required, handling accumulation for repeating indices (e.g. pre-sorting indices)
Currently we have 2) for cuda implementation and no parallelization for CPU, afaikt.
Setting "triage review" label to discuss desired behavior.
cc @jlin27 @mruberry @ezyang @gchanan @SsnL @nikitaved
| module: bc-breaking,module: docs,triaged,module: scatter & gather ops | low | Major |
544,654,773 | create-react-app | Extracting "scripts/test.js" so it's usable by other non-react projects | ### Is your proposal related to a problem?
<!--
Provide a clear and concise description of what the problem is.
For example, "I'm always frustrated when..."
-->
I'm always frustrated when I have to configure Jest for projects that do not use CRA (Babel, TS, CSS/images imports, ...) as the CRA setup is really nice and works perfectly with pretty much all projects.
### Describe the solution you'd like
<!--
Provide a clear and concise description of what you want to happen.
-->
Could we export the "/scripts/test.js" into a different package that CRA would just be using?
### Describe alternatives you've considered
<!--
Let us know about other solutions you've tried or researched.
-->
I tried keeping one npm package myself: https://www.npmjs.com/package/jest-run
But it's hard to keep it up to date and as it's pretty much dupplicated code from CRA, it would make more sense to use the same resource
### Additional context
<!--
Is there anything else you can add about the proposal?
You might want to link to related issues here, if you haven't already.
-->
Nothing | issue: proposal,needs triage | low | Minor |
544,670,351 | pytorch | torch.poisson returns floating point tensor | ## 🐛 Bug
The Poisson distribution is a discrete distribution. As is the case with all other discrete distributions: `bernoulli` and `multinomial`, `torch.poisson` should also return a tensor with dtype `long` instead of `float`.
## To Reproduce
```python
import torch
torch.poisson(torch.rand(10)) # returns a float tensor
```
## Expected behavior
```python
import torch
torch.poisson(torch.rand(10)) # returns a long tensor
```
cc @vincentqb @fritzo @neerajprad @alicanb @vishwakftw | module: distributions,triaged | low | Critical |
544,713,288 | TypeScript | No error for undeclared #private property in `.js` files | ```js
class Thing {
/**
* @param prop {string}
*/
constructor(prop) {
this.#prop = prop;
}
}
```
This class assigns to `#prop`, but it's an error to use `#prop` without declaring it.
This is reported as a `SyntaxError`, so this should report an error even outside of `checkJs`. | Bug,Help Wanted,Effort: Moderate,Domain: JavaScript | low | Critical |
544,720,781 | go | flag: improve clarity of "flag provided but not defined" error message | Version: go1.13.5
I have a code snippet with a series of flags:
```
var (
flag1 string
flag2 string
)
func init() {
flag.StringVar(&flag1, "flag1", "", "value for flag 1")
flag.StringVar(&flag2, "flag2", "", "value for flag 2")
}
func main () {
...
}
```
After building, if this is executed in a bash shell:
`
./script "-flag1 value1" "-flag2 value2"
`
the output I see is this:
```
flag provided but not defined: -flag1 value1
Usage of ./script:
-flag1 string
value for flag1
-flag2 string
value for flag2
```
Now, this code doesn't work because of the quotes in the bash command and removing the quotes makes this work exactly as expected. This took me a while to debug as I wasn't able to initially interpret from `flag provided but not defined: -flag1 value1` that the program was interpreting `-flag1 value1` as the literal flag, as opposed to the flag and the value.
I might suggest one of two fixes:
1. Slightly modify the error message from
`flag provided but not defined: FLAG`
to
`flag "FLAG" provided but not defined`
2. Add logic to detect common potential mistakes such as:
```
flag provided but not defined: FLAG
Did you mean to include <detected mistake such as space / equals sign etc>?
```
| NeedsInvestigation | medium | Critical |
544,722,663 | TypeScript | Array rest of readonly tuple type incorrectly preserves readonly modifier | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.0-dev.20200101
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** readonly tuple rest
**Code**
```ts
declare const tuple: readonly [number, ...number[]];
const [a, ...rest] = tuple;
rest[0] = 1;
rest.push(2);
```
**Expected behavior:**
`rest: number[]`
I should be able to modify the resulting array.
**Actual behavior:**
`rest: readonly number[]`
Not able to modify the array (even though it is a mutable clone at runtime).
**Playground Link:** https://www.typescriptlang.org/play/?ts=3.8.0-dev.20200101&ssl=1&ssc=1&pln=5&pc=14#code/CYUwxgNghgTiAEYD2A7AzgF3hgrgBwhAC544phUIBPeAbRRwFsAjEGAGngDoeGW3aAXUEBuAFBjk6LLSiceXOJkHwAvNnyFxSjLQAMK9QEZtITFzw40ACwAUAJgCUIoA
| Suggestion,In Discussion | low | Critical |
544,724,261 | go | runtime: clean up async preemption loose ends | Go 1.14 introduces asynchronous preemption so that tight loops can be preempted (#10958). However, there are still several loose ends to tie up. This is a general bug to keep track of remaining work:
- [ ] Support on all possible platforms (js/wasm is not currently possible)
- [x] windows/arm ([CL 207961](https://golang.org/cl/207961))
- [x] windows/arm64
- [ ] ~darwin/arm~ (no longer supported)
- [ ] plan9/* ([CL 228893](https://golang.org/cl/228893))
- [x] Redo unsafe-point representation so we can eliminate register maps ([CL 230544](https://golang.org/cl/230544))
- [x] Remove register maps and extra stack maps (after redesigning debug call injection) ([CL 230544](https://golang.org/cl/230544))
- [x] Possibly incorporate @cherrymui's sequence restarting ([CL 208126](https://golang.org/cl/208126))
- [ ] Attach unsafety/restartability to Progs and generate the stream post-assembly like spadj ([comment](https://go-review.googlesource.com/c/go/+/208126/4/src/cmd/internal/obj/plist.go#281))
- [ ] Make large pointer-free memmoves/memclrs preemptible (#31222)
- [ ] Make large pointer-full memmoves/memclrs preemptible (this is a little harder)
- [x] Make large allocations preemptible (closely related to the above two, [partly done](https://golang.org/cl/270943))
- [ ] Fix various annoying spins in the scheduler
- [ ] Make more of the runtime preemptible | NeedsFix,compiler/runtime | medium | Critical |
544,750,119 | electron | Feature request: safe-area-inset-* variables | ### Problem Description
<!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. -->
Sometimes webapp needs to have an extra padding on the sides of the screen. For example, when using `titleBarStyle=hiddenInset` on Mac OS: the window control buttons will overlap the app content unless you add a padding to the top.
### Proposed Solution
<!-- Describe the solution you'd like in a clear and concise manner -->
Define css env`safe-area-inset-*` variables in renderer to make life easier.
### Additional Information
- [About env() and safe-area-inset](https://developer.mozilla.org/en-US/docs/Web/CSS/env) | enhancement :sparkles: | low | Minor |
544,763,454 | flutter | All Gradle tests should also run the AAR build mode | The AAR build mode may behave differently than the regular Android build mode.
We've been burned by this in #46898 where newly introduced build logic did not apply to the AAR build workflow.
We should have all relevant tests in dev/devicelab/bin/tasks/gradle_* run both the regular build mode and the aar build mode.
@blasten | a: tests,team,platform-android,tool,t: gradle,P2,team-android,triaged-android | low | Minor |
544,764,145 | godot | Mono - Cannot instance script because the project assembly is not loaded (When using --path) | **Godot version:**
3.2 beta 4 Mono
**OS/device including version:**
Windows 10
**Issue description:**
When the project is run directly using `--path` It cannot load any c# scripts
**Steps to reproduce:**
Run the project using a command like
`.\GodotMono.exe --path C:\Users\You\Documents\Test\ -v`
Log:
```
Godot Engine v3.2.beta4.mono.official - https://godotengine.org
Using GLES3 video driver
OpenGL ES 3.0 Renderer: AMD Radeon R7 200 Series
WASAPI: wFormatTag = 65534
WASAPI: nChannels = 2
WASAPI: nSamplesPerSec = 48000
WASAPI: nAvgBytesPerSec = 384000
WASAPI: nBlockAlign = 8
WASAPI: wBitsPerSample = 32
WASAPI: cbSize = 22
WASAPI: detected 2 channels
WASAPI: audio buffer frames: 1962 calculated latency: 44ms
Mono: Initializing module...
Mono JIT compiler version 6.6.0 (explicit/bef1e633581)
Mono: Logfile is: C:\Users\Franke\AppData\Roaming/Godot/mono/mono_logs/2020_01_02 13.52.39 (9868).txt
Mono: Runtime initialized
Mono: Loading assembly mscorlib...
Mono: Assembly mscorlib loaded from path: C:\Program Files\Godot/GodotSharp/Mono/lib/mono/4.5/mscorlib.dll
Mono: Loading scripts domain...
Mono: Creating domain 'GodotEngine.Domain.Scripts'...
Mono: Debugger wait timeout
Mono: INITIALIZED
Mono: Loading assembly GodotSharp...
Mono: Assembly GodotSharp loaded from path: res://.mono/assemblies/Debug/GodotSharp.dll
Mono: Loading assembly GodotSharpEditor...
Mono: Assembly GodotSharpEditor loaded from path: res://.mono/assemblies/Debug/GodotSharpEditor.dll
Mono: Loading assembly GodotTools...
Mono: Assembly GodotTools loaded from path: C:\Program Files\Godot/GodotSharp/Tools/GodotTools.dll
Mono: Loading assembly GodotTools.ProjectEditor...
Mono: Assembly GodotTools.ProjectEditor loaded from path: C:\Program Files\Godot/GodotSharp/Tools/GodotTools.ProjectEditor.dll
Mono: Loading assembly Test...
Mono: Failed to load project assembly
CORE API HASH: 1133556406507282606
EDITOR API HASH: 9577969821152247287
Loading resource: res://default_env.tres
Loaded builtin certs
Loading resource: res://Space.tscn
Loading resource: res://Star.tscn
Loading resource: res://Star.gd
Loading resource: res://CelestialBody.gd
Loading resource: res://Spaceyy.cs
ERROR: Cannot instance script because the project assembly is not loaded. Script: 'res://Spaceyy.cs'.
At: modules/mono/csharp_script.cpp:2774
Mono: Unloading scripts domain...
Mono: Runtime cleanup...
debugger-agent: Unable to listen on 5900
Mono: Finalized
```
**Minimal reproduction project:**
[Test.zip](https://github.com/godotengine/godot/files/4017485/Test.zip)
| bug,topic:dotnet | low | Critical |
544,774,840 | pytorch | Inaccurate ValueError reporting in nn/functional.py | ## 🐛 Bug
Lines 1854-1855 in functional.py report the wrong tensor sizes when raising a ValueError. The target size is reported as the output size, and the output size is reported as the target size.
## Environment
Collecting environment information...
PyTorch version: 1.3.1
Is debug build: No
CUDA used to build PyTorch: None
OS: Microsoft Windows 10 Enterprise
GCC version: Could not collect
CMake version: Could not collect
Python version: 3.6
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Versions of relevant libraries:
[pip] numpy==1.17.3
[pip] torch==1.3.1
[pip] torchvision==0.4.2
[conda] Could not collect
| module: nn,triaged | low | Critical |
544,777,009 | flutter | Add functions for showing alerts with less ceremony | Other platforms make showing a dialog that just shows a text string much easier. We could do the same by having functions such as the following in our framework:
```dart
Future<void> showMessage(BuildContext context, String message) {
return showDialog(
context: context,
builder: (BuildContext context) => AlertDialog(
content: Text(message),
),
);
}
``` | c: new feature,framework,f: material design,would be a good package,P3,team-design,triaged-design | low | Major |
544,783,025 | godot | Textures missing on iOS in HTML5 export | **Godot version:** 3.1.2.stable on macOS 14.6
**OS/device including version:** iOS 13.3 (iPhone XR, iPad 2018). Also reported on Android, but I have no details there.
**Issue description:** A MeshInstance with a SpatialMaterial and an albedo texture renders fine in desktop browsers, but with a missing texture on iOS Safari.
**Steps to reproduce:** Create a MeshInstance with a texture, add a light and a camera. Export as HTML5. Test on iOS. Or look at the demo: https://combatwombat.github.io/godot-texture-test/
**Minimal reproduction project:** https://github.com/combatwombat/godot-texture-test
| bug,platform:web,platform:ios,topic:rendering,confirmed | medium | Major |
544,814,922 | pytorch | ImportError: /home/xx/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch_python.so: undefined symbol: _ZNK5torch3jit5Graph8toStringE | Hi,I am newer to pytorch, i faced such problem when i import torch after i have installed the pytorch1.3.1 by pip.My environment is ubuntu16.04 pytorch1.3.1 cuda10.1 python3.7.3.Does anyone can help me?tkx.
cc @suo | oncall: jit,triaged | low | Critical |
544,839,639 | pytorch | How to distinguish different layers in hook？ | ## 🚀 Feature
<!-- A clear and concise description of the feature proposal -->
A way to distinguish different layers in each module itself
## Motivation
<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
I'd like to store some intermedia data such as output data of all conv layers, and I want to use hook. It is easy to judge which class the module is in hook function like " if isinstance(module, nn.Conv2d):", but if I want to store the data, I need a name which can be got in hook function to be the file name so that data from different layers will be saved in different files. e.g. "save(filename, output)" How can I get this name?
Even if I collect all output data in a list and save it outside the hook function, I still don't know to which layer each data belongs.
## Pitch
<!-- A clear and concise description of what you want to happen. -->
There is no way to identify each layer now, a unique name or id.
```
def hook(moudle, input, output):
name = get_unique_name(module)
save(name+'.h5', output)
for n,m in model.named_module():
m.register_forward_hook(hook)
```
## Alternatives
<!-- A clear and concise description of any alternative solutions or features you've considered if any. -->
Because we can only get names from parent modules using"named_module", it will also work if I can pass arguments to hook function.
```
def hook(moudle, input, output, n):
save(n+'.h5', output)
for n,m in model.named_module():
m.register_forward_hook(hook, n)
```
## Additional context
<!-- Add any other context or screenshots about the feature request here. -->
| module: nn,triaged | low | Minor |
544,850,126 | rust | rust compiler bug on borrow/ownership? | ```rust
struct Node {
child: [Option<Box<Node>>; 3]
}
fn main() {
let mut root: [Option<Box<Node>>; 3] = Default::default();
let mut tree = &mut root;
for _ in 0..3 {
let opt = &mut tree[0]; // line 9
match opt {
None => {
//break; // ok if uncomment this line of code
// if true { break; } // even error with code like this
}
Some(b) => {
tree = &mut b.as_mut().child;
}
}
}
}
```
```
error[E0499]: cannot borrow `tree[_]` as mutable more than once at a time
--> t.rs:9:19
|
9 | let opt = &mut tree[0];
| ^^^^^^^^^^^^ mutable borrow starts here in previous iteration of loop
```
however, compile ok if add a break statement in the None block | T-compiler,A-NLL,C-bug,NLL-complete,NLL-polonius | low | Critical |
544,856,684 | go | cmd/go: dependencies in go.mod of older versions of modules in require cycles affect the current version's build | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.5 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes. 1.13.5 is the latest release at this date.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOOS="linux"
</pre></details>
### What did you do?
I have three modules, a, b and c. All use go modules. a/go.mod requires b and c, and (due to history) b/go.mod requires a. One (or both) of those cyclic requires refers to an older version than the newest, but it's new enough for both a and b to build.
Now I wanted to downgrade module c to an older version. So I edited a/go.mod, and rebuild a. The c line in a/go.mod was edited to the newer version of c, which I had been using before, and which I did not want to use anymore.
Investigating with go mod graph showed that the newer c was required by an older a, which was required by the current b, which was required by the current a. In other words
a@now -> b@now -> a@older -> c@newer
### What did you expect to see?
I did not expect the a@older/go.mod to be of any consequence to the go modules choice of version of c, since in the end it was going to use a@now to build, not a@older.
### What did you see instead?
go mod graph showed that because of the cycling in the module dependency graph, a@older/go.mod was consulted, as if a@older wasn't an older version of a module already in the graph, but rather some other independent module.
As a consequence a@older's dependencies changed a@now's build.
| NeedsInvestigation,GoCommand,modules | low | Major |
544,875,037 | youtube-dl | HUYA SUPPORT | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.01.01. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [X] I've verified that I'm running youtube-dl version **2020.01.01**
- [X] I've checked that all provided URLs are alive and playable in a browser
- [X] I've checked that none of provided URLs violate any copyrights
- [X] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://v.huya.com/play/247298790.html
- Single video: https://v.huya.com/play/242184662.html
- Playlist: http://v.huya.com/u/2487318471
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
WRITE DESCRIPTION HERE
| site-support-request | low | Critical |
544,879,147 | godot | "visible_characters" property of Label and RichTextLabel behave differently; discrepancy between whether they acknowledge spaces or not. | **Godot version:**
3.1.1
**OS/device including version:**
Ubuntu 16.04 LTS ...I've been too lazy to upgrade :flushed:
**Issue description:**
The visible_characters property in the node type Label ignores spaces, though the same property on the node type RichTextLabel acknowledges spaces as characters. This is a discrepancy in behavior that can be frustrating.
**Steps to reproduce:**
Just play with the aforementioned properties. See attached example project.
**Minimal reproduction project:**
[visible-characters-bug.zip](https://github.com/godotengine/godot/files/4018364/visible-characters-bug.zip) | enhancement,confirmed,topic:gui | low | Critical |
544,899,973 | flutter | [web] Error loading fonts icons are not shown | When I run the flutter run -d web-server there is a font loading error, icons are not visible after this.
Launching lib\main.dart on Web Server in profile mode...
Error: unable to locate asset entry in pubspec.yaml: "packages/flutter_gallery_assets/fonts/raleway/Raleway-Regular.ttf".
Error: unable to locate asset entry in pubspec.yaml: "packages/flutter_gallery_assets/fonts/raleway/Raleway-Regular.ttf".
Building application for the web... 176.3s
lib\main.dart is being served at http://localhost:8080/
Warning: Flutter's support for web development is not stable yet and hasn't
been thoroughly tested in production environments.
For more information see https://flutter.dev/web
🔥 To hot restart changes while running, press "r". To hot restart (and refresh the browser), press "R".
For a more detailed help message, press "h". To quit, press "q".
Note: tested on Chrome on Windows | tool,platform-web,P2,team-web,triaged-web | low | Critical |
544,904,869 | pytorch | Libtorch's files conflict with glog's file? | Hi,guys, i am use libtorch and glog in the same codes in c++,but there are indices some files conflict between each other. The libtorch's logging_is_not_google_glog.h(#define LOG(n)) is conflict with glog's logging.h(#define LOG(severity) COMPACT_GOOGLE_LOG_ ## severity.stream()).The details problem is:
In file included from libtorch/include/c10/util/Logging.h:28:0,
from /libtorch/include/c10/core/TensorImpl.h:17,
from /libtorch/include/ATen/core/TensorBody.h:11,
from /libtorch/include/ATen/Tensor.h:11,
from //libtorch/include/ATen/Context.h:4,
from /libtorch/include/ATen/ATen.h:5,
from /libtorch/include/torch/csrc/api/include/torch/types.h:3,
from /libtorch/include/torch/script.h:3,
/libtorch/include/c10/util/logging_is_not_google_glog.h:96:0: warning: "LOG" redefined
#define LOG(n) \
^
In file included from /glog/linux/include/glog/logging.h:483:0: note: this is the location of the previous definition
#define LOG(severity) COMPACT_GOOGLE_LOG_ ## severity.stream()
^
In file included from /libtorch/include/c10/util/Logging.h:28:0,
from /libtorch/include/c10/core/TensorImpl.h:17,
from /libtorch/include/ATen/core/TensorBody.h:11,
from /libtorch/include/ATen/Tensor.h:11,
from /libtorch/include/ATen/Context.h:4,
from /libtorch/include/ATen/ATen.h:5,
from /libtorch/include/torch/csrc/api/include/torch/types.h:3,
from /libtorch/include/torch/script.h:3,
/libtorch/include/c10/util/logging_is_not_google_glog.h:99:0: warning: "VLOG" redefined
#define VLOG(n) LOG((-n))
^
In file included from /glog/linux/include/glog/logging.h:1068:0: note: this is the location of the previous definition
#define VLOG(verboselevel) LOG_IF(INFO, VLOG_IS_ON(verboselevel))
Does anyone can tell me how to deal with it?My environment is ubuntu16.04 pytorch1.3 libtorch libtorch-cxx11-abi-shared-with-deps-1.3.1.zip,qt5.5. tkx.
| module: build,triaged | low | Minor |
545,004,190 | excalidraw | Investigate Cypress for UI tests | Preliminary tests show promise. I'll try to write a few tests and make a PR if it feels good. | test | low | Major |
545,039,813 | go | x/tools/gopls: respect staticcheck config file | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
govim is using commit `f13409bb`, which is pretty new, and it reproduces
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN="/Users/llimllib/go/bin"
GOCACHE="/Users/llimllib/Library/Caches/go-build"
GOENV="/Users/llimllib/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/llimllib/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/llimllib/code/tools-golang/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/r4/mc760j7j6xjdgr5p5hxk_xrw0000gq/T/go-build877572449=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
I don't know how to use `gopls` directly, so here's how to reproduce through `govim`
1. Create a directory
2. Create a `staticcheck.conf` file with these contents:
```toml
checks = ["all", "-ST1005"]
```
3. Create a main.go file:
```go
package main
import "fmt"
func main() error {
return fmt.Errorf("This capitalized error should be ignored but isn't")
}
```
4. Note that running `staticcheck .` or `staticcheck main.go` do not raise any errors
5. Turn on vim, with govim installed and staticcheck enabled via `call govim#config#Set("Staticcheck", 1)`
6. Note that govim flags error `ST1005` on line 6
Reading the gopls logs from govim shows:
```
[Trace - 10:10:46.572 AM] Received notification 'textDocument/publishDiagnostics'.
Params: {"uri":"file:///private/tmp/govim-bug/main.go","version":1,"diagnostics":[{"range":{"start":{"line":5,"character":18},"end":{"line":5,"character":18}},"severity":2,"source":"ST1005","message":"error strings should not be capitalized","tags":[1]}]}
```
As you can see from the config, `ST1005` ought to be ignored for this file.
(I feel pretty certain that `govim` isn't doing anything wrong in how it launches or communicates with `gopls`? But if I've got this error filed on the wrong side of that divide, I apologize)
### What did you expect to see?
No ST1005 errors flagged on main.go
### What did you see instead?
An ST1005 error flagged on main.go | FeatureRequest,gopls,Tools | medium | Critical |
545,073,764 | godot | Image texture is not displayed in exported project untile window is resized | **Godot version:** 3.1.2
**OS/device including version:** Linux
**Issue description:**
I am working with color splatter effect in godot and found some wierd bug. It works fine while game is launched from IDE but in exported project it doest show the overlay image untile window is resized. See gif
It might be a project releated bug but I didnt find any workaround so I am posting it here.
**Steps to reproduce:**
1. Download the exported project (linux) [color-splatter-effect.zip](https://github.com/godotengine/godot/files/4020013/color-splatter-effect.zip)
**Minimal reproduction project:**
https://github.com/Janglee123/godot-color-splatter-effect | bug,topic:rendering | low | Critical |
545,102,873 | TypeScript | Mapped types shouldn't transform any type | @ahejlsberg Can you remember #29793 and this?
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.x-dev.20200101
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
**Code**
```ts
type M<T> = { [P in keyof T]: T[P] };
type a = M<any>;
```
**Expected behavior:**
Type a is `any`.
**Actual behavior:**
Type a is `{ [x: string]: any; }`.
**Playground Link:** https://www.typescriptlang.org/play/index.html?ts=3.8.0-dev.20200101&ssl=1&ssc=1&pln=30&pc=1#code/C4TwDgpgBAsgPAFQHxQLxQN5QNoAUoCWAdlANYQgD2AZlAgLoBcde9UAvgNwBQokUAQzSw4AoiCScgA
**Related Issues:** #29793
| Suggestion,In Discussion | low | Minor |
545,134,206 | pytorch | logsumexp: two little-impact perf suggestions | https://github.com/pytorch/pytorch/blob/master/aten/src/ATen/native/ReduceOps.cpp#L372
1. Could probably do exp in-place?
2. Hopefully `torch.isinf` could be made to not allocate a full copy with abs call (currently [same](https://github.com/pytorch/pytorch/blob/bcb0bb7e0e03b386ad837015faba6b4b16e3bfb9/torch/functional.py#L284) happens in Python impl of `torch.isinf`)
cc @VitalyFedyunin @ngimel @mruberry | module: performance,module: cpu,triaged,module: reductions | low | Major |
545,144,139 | pytorch | Support rpc/remote torch script call with script class/module name and class/module method name | Current rpc torch script call only supports annotated global torch script function defined by users, ideally we should support torch script call with script class/module name and class/module method name as well. This is follow up on PR #30063
cc @suo @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 @jjlilley | oncall: jit,triaged,module: rpc | low | Minor |
545,163,998 | TypeScript | Allow accessors to support inline generics for this | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
getter, accessor, this, generic
## Suggestion
Currently accessor declarations do not support generics at the declaration site. The error returned is `An accessor cannot have type parameters.ts(1094)`. Currently the accessor can implement generic declaration via the enclosing class. The goal would be to allow for the accessor to support a generic `this` at the declaration site.
## Use Cases
The use case is to allow for more expressive setter/getter declarations, in line with how method declarations currently work.
## Examples
### Suggested Pattern
Below is an example of defining the constraints of `this` at the accessor site, to determine if an inherited accessor method is valid by the shape of the subclass.
```typescript
class Base {
get left<T extends { _left: string}>(this: T) {
return this._left;
}
get right<T extends { _right: string}>(this: T) {
return this._right;
}
}
...
class Left extends Base {
_left: string = '';
}
new Left().left; // OK
new Left().right; // Errors
...
class Right extends Base {
_right: string = '';
}
new Right().right; // OK
new Right().left; // Errors
...
class Both extends Base {
_right: string = '';
_left: string = '';
}
new Both().right; // OK
new Both().left; // OK
```
This pattern can currently be emulated by converting the accessors into standard methods
```typescript
class Base {
getLeft<T extends { _left: string}>(this: T) {
return this._left;
}
getRight<T extends { _right: string}>(this: T) {
return this._right;
}
}
...
class Left extends Base {
_left: string = '';
}
new Left().getLeft(); // OK
new Left().getRight(); // Errors
...
class Right extends Base {
_right: string = '';
}
new Right().getRight(); // OK
new Right().getLeft(); // Errors
...
class Both extends Base {
_right: string = '';
_left: string = '';
}
new Both().getRight(); // OK
new Both().getLeft(); // OK
```
## Checklist
My suggestion meets these guidelines:
* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | medium | Critical |
545,198,100 | TypeScript | Insert semicolon on typing fails after typing function block | <!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.0-20200.103
Observed in Visual Studio and VSCode
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
semicolon
After typing out a function block, semicolon insertion on new line stops working inside of and before the function block, but not after. Explicitly formatting by sending the format command *does* insert the semicolons as expected.
**Code**
Typed in alphabetical order:
**Expected behavior:**
```ts
var a;
var d;
function b(){
var c;
}
var e;
```
**Actual behavior:**
```ts
var a;
var d
function b(){
var c
}
var e;
```
| Bug | low | Minor |
545,205,863 | rust | const simd_extract/insert are no longer usable in latest nightly (2020-01-02) | A few months ago #64738 introduced `const` `simd_insert`/`simd_extract`, which I then integrated into my application via a fork of `packed_simd`.
However, upon upgrading to the latest nightly (`rustc 1.42.0-nightly (0a58f5864 2020-01-02)`), it was suddenly non-const.
Furthermore, It seems the ability to make it `const` via `rustc_const_unstable` is not possible in user applications, making the `const` versions of this effectively rustc internal-only now, breaking my fork of `packed_simd` and my application. | T-compiler,B-unstable,A-SIMD,A-const-eval,requires-nightly | low | Minor |
545,214,592 | TypeScript | Updating Windows contributor requirements to run Windows 10 | We recently ran into a situation where git errored during a `checkout` due to a file path that was too long.
https://github.com/microsoft/TypeScript/pull/35711#issuecomment-570730960
To get around this, we can run
```
git config core.longpaths true
```
However, it seems that this option requires Windows users to run Windows 10. It doesn't affect other users.
Everyone on the core team who's on Windows is basically on the latest version, and we don't have reason to believe at the moment that this affects many external contributors. As a result, we will likely turn on the flag and adjust appropriately if this becomes an issue. | Discussion,Infrastructure | low | Critical |
545,234,126 | flutter | Allow Embedder API to pass ICU data as buffer | As an embedder of the flutter engine it seems to be a recurring error to crash because of missing ICU data. Typically this is the embedder's own fault, maybe the path was wrong, or maybe s/he passed the wrong version of it.
There is however another way to pass this data to the engine, embedded in an object file. This approach seems better, eliminating the need to pass around files and getting their paths correct. This approach is now used for the Android target.
There is however a drawback: it seems there is no platform independent way to embed the data into an object file.
**The proposal is therefore to allow the embedder an alternative way of passing the data, via a buffer and a size.**
More concretely, add:
```
struct FlutterProjectArgs
{
...
/// ICU data to use. Allows the embedder to provide ICU data anyway they seem fit.
const uint8_t* icu_data;
/// The size of the ICU data buffer. 0 if not used.
size_t icu_data_size;
...
}
```
Internally, this data can be wrapped in `settings.icu_mapper`- the code is already in place.
This is analog to how a number of user provided binaries are passed to the engine, such as dart vm blobs/snapshots.
| engine,e: embedder,c: proposal,P2,team-engine,triaged-engine | low | Critical |
545,238,825 | rust | rustdoc: provide more context for parse errors in code blocks | Split from #67563.
Currently, the bad_codeblock_syntax_pass in rustdoc provides error messages like the following:
```
warning: could not parse code block as Rust code
--> $DIR/invalid-syntax.rs:3:5
|
LL | /// ```
| _____^
LL | | /// \__________pkt->size___________/ \_result->size_/ \__pkt->size__/
LL | | /// ```
| |_______^
|
= note: error from rustc: unknown start of token: \
= note: error from rustc: unknown start of token: \
= note: error from rustc: unknown start of token: \
```
Ideally, we could display the error spans inline (but downgrade them to warnings). | T-rustdoc,C-enhancement,A-diagnostics,A-parser | low | Critical |
545,243,084 | godot | Text exceeds item boundary with custom font | **Godot version:** v3.2.beta.custom_build.34c71157f
**OS/device including version:** macOS Catalina 10.15.2 / MacBook Pro (Retina, 13-inch, Early 2015)
**Issue description:**
When using [NotoSansCJKsc-Regular.otf](https://noto-website-2.storage.googleapis.com/pkgs/NotoSansCJKsc-hinted.zip) ([Site](https://www.google.com/get/noto/help/cjk/)) as the main editor font, a long filename in the Open Scene dialog exceeds the item (cell) boundary.
The complete filename is quite long: new-years-eve-2019-4659144240922624-l.png
I can confirm that this behavior starts from 3.2 alpha0, and using the default font do not have this issue.
**Steps to reproduce:**
1. Download the NotoSansCJKsc-Regular.otf mentioned above
2. Open the Editor menu and choose Editor Settings
3. For the Interface / Editor / Main Font property, choose the font file
4. Prepare a long named file in your project directory
5. Find the file in the Open Scene dialog | bug,topic:editor,confirmed,topic:gui | low | Major |
545,280,060 | godot | Selecting and edit tilemap issues | **Godot version:**
3.2 beta 5
**OS/device including version:**
windows 10, 64
**Issue description:**
Issues when selecting a tilemap:
- mode is always changed to "Select Mode"
- right click to delete tile triggers panning instead
| bug,topic:editor,topic:2d | low | Minor |
545,302,712 | pytorch | Fix softplus clampling issues using logsigmoid | Softplus (torch.nn.functional.softplus) requires a threshold for numerical reasons. However this threshold can be removed by using the Logsigmoid (torch.nn.functional.logsigmoid) implementation.
Softplus is a non-linear activation function, with parameter beta, defined by
`softplus(x) = (1/beta) log(1+exp(beta * x))`
Some mathematical manipulations let you rewrite this as the Logsigmoid function
`softplus(x)`
`= (1/beta) log(1 + exp(beta * x))`
`= - (1/beta) log(1 / (1 + exp(beta * x)))`
`= - (1/beta) log(1 / (1 + exp( -(-beta * x))))`
`= - (1/beta) logsigmoid(-beta * x)`
Implementing this should be fairly easy, and solves any issues arising from clamping/numerical stability. | module: nn,triaged | low | Minor |
545,307,317 | go | spec: don't say that 0123i == 123i is for backward-compatibility | The Go Language Specification in https://golang.org/ref/spec#Imaginary_literals has the example
```
0123i // == 123i for backward-compatibility
```
With the new number literal proposal implemented in `Go 1.13`, I think the comment should be changed, since now it is `0123 == 0o123` that should be considered to be for backward-compatibility.
Probably the examples in https://golang.org/ref/spec#Integer_literals
```
0600
0_600
```
should have a comment `// == 0o600 for backward-compatibility`. | NeedsDecision | low | Major |
545,317,342 | react | SuspenseList tail property not working on re-renders | <!--
Note: if the issue is about documentation or the website, please file it at:
https://github.com/reactjs/reactjs.org/issues/new
-->
**Do you want to request a *feature* or report a *bug*?**
I am reporting a possible bug or otherwise requesting clarification.
**What is the current behavior?**
When a component with a SuspenseList re-renders (such as when it is is passed a new resource), the SuspenseList component still respects the revealOrder="forwards" or revealOrder="backwards" prop but does not respect the tail="collapsed" or tail="hidden" prop.
**If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:**
https://codesandbox.io/s/exciting-cherry-g9uc9
In order to see bug:
1) Refresh the Code Sandbox browser and see that "Loading profile..." displays and "Loading posts..." does not due to the tail being collapsed. This is the expected behavior.
2) Press the "Next" button. Both "Loading Profile..." and "Loading posts..." display. The tail is no longer collapsed.
**What is the expected behavior?**
The expected behavior would be for the tail to be collapsed when pressing the "Next" button. "Loading profile..." should be displayed, but not "Loading posts..."
**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**
This affects only the experimental Concurrent Mode build of React.
| Type: Discussion,Component: Suspense,Component: Concurrent Features | low | Critical |
545,327,695 | TypeScript | this type in conditional type false clause is incorrectly typed | **TypeScript Version:** 3.7.3
**Search Terms:**
generic type this widening incorrect
**Code**
```ts
type Option1 = { run(this: { b: 1 }): void }
function f1(options: Option1) { return options }
// `this` is correctly typed as `{ b: 1 }`
f1({ run() { this.b } })
type Option2<Config> = Config extends Record<string, any> ? {
config: Config,
run(this: Config): void
} : {
run(arg: { b: 1 }): void
}
function f2<Config>(options: Option2<Config>) { return options }
// `this` is correctly typed as `{ a: number }`
f2({ config: { a: 1 }, run() { this.a } })
// `arg` is correctly typed as `{ b: 1 }`
f2({ run(arg) { arg.b } })
type Option3<Config> = Config extends Record<string, any> ? {
config: Config,
run(this: Config): void
} : {
run(this: { b: 1 }): void
}
function f3<Config>(options: Option3<Config>) { return options }
// `this` is correctly typed as `{ a: number }`
f3({ config: { a: 1 }, run() { this.a } })
// `this` is widen to what `Config` extends to. In this case `Record<string, any>`
f3({ run() { this.b } })
```
**Expected behavior:**
`this` in `f3({ run() { this.b } })` should be typed as in `this` in `f1()` and `arg` in `f2()`
**Actual behavior:**
`this` in `f3({ run() { this.b } })` is typed as the base type of `Config` (`Record<string,any>` in the example above)
**Playground Link:**
[Playground Link](https://www.typescriptlang.org/play/?ssl=1&ssc=1&pln=37&pc=1#code/C4TwDgpgBA8mwEsD2A7AjFAvFA3lATgK4oAUwAFggM4BcuUARnRgL4CUdAbkggCZQsAsACgRAM2IBjRKihi0JJPGQpasZajRt6+CMEL4UUJTNUCRIgPSWoAAwrVbUalElJ8u6QBsQUUJH4AQyo7PCYoVltxBTwiUm08ByoAOgYBATYLYX9oOFMAJgAeAGFUMQQAcwA+LChSlHKKqAgAD2AIFF4QgCUIN3xeQqpgfAQUCoAaKECUEBqAflwRKFcyyrp6xonlgmIySjVNyo4obj4RFig6HB24kkD8CuvGZgyuHl4LrIkUaRU5IpHaqKDSqOh5FSAtbVBIEPQGIwmFQhISiYTWOxJJwufqeYA+PzgCBBEK2PCBOgoQgAWwYEHwAiiwjE+RIeDcDXW9ApEQEUzusKSyUC6XYWQxtgeFWxIRyJNCL15LCZLLZu1IUthUtSosyaJy6lMAGYStCatggc02h0ulBev1BsNRuMpjM5lBFjdhCsOY0NtDtt71ftqP7ORUTmdPsJLtdbnsks9wqxIx8vmifn9ZGITUCqiDTGoIahc2bYbp9IZjKCUeKbPYDjLVh4+vjfHLpqTyZSaXSGcrxEa1b6ud2lfy9oKDsLdXXMY3nCEAO58Dp+JBQJfkQLAOxApytdqdWVIZJQACSRiSrmC0Fs9vcjpGY0m01mVRVQ9ik-oQrSlzFYQgA)
**Related Issues:**
Some maybe related issues:
https://github.com/microsoft/TypeScript/issues/32990
https://github.com/microsoft/TypeScript/issues/30152
https://github.com/microsoft/TypeScript/issues/13995
I also recall there were some discussion about `type` and `Record<>`, but that is in the gitter channel and I can't find relevant issue or doc about it.
I think this is different than the related issues above because this does not involve union type.
This is about the `false` condition of the conditional type `Config extends Record<string, any> ? ... : ...` do not use the generic type `Config` and should not be affected by it.
| Bug | low | Minor |
545,332,640 | youtube-dl | How can I download UHD content from iPlayer | I'm trying to download Dracula from iPlayer, but the highest resolution youtube-dl is showing me is 720p. Sorry if it's something that should be easy to do, I'm new to this and have previously used get_iplayer for iPlayer downloads, but the forum there said to use youtube-dl.
Here's what I got for episode 1.
youtube-dl --list-formats https://www.bbc.co.uk/iplayer/isode/m000ctc3
[bbc.co.uk] m000ctc3: Downloading video page
[bbc.co.uk] m000ctc3: Downloading playlist JSON
[bbc.co.uk] m000ctc1: Downloading media selection XML
[bbc.co.uk] m000ctc1: Downloading m3u8 information
[bbc.co.uk] m000ctc1: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] m000ctc1: Downloading MPD manifest
[bbc.co.uk] m000ctc1: Downloading MPD manifest
[bbc.co.uk] m000ctc1: Downloading m3u8 information
[bbc.co.uk] m000ctc1: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] m000ctc1: Downloading m3u8 information
[bbc.co.uk] m000ctc1: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] m000ctc1: Downloading m3u8 information
[bbc.co.uk] m000ctc1: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] m000ctc1: Downloading MPD manifest
[bbc.co.uk] m000ctc1: Downloading MPD manifest
[bbc.co.uk] m000ctc1: Downloading m3u8 information
[bbc.co.uk] m000ctc1: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[bbc.co.uk] m000ctc1: Downloading m3u8 information
[bbc.co.uk] m000ctc1: Downloading m3u8 information
WARNING: Failed to download m3u8 information: HTTP Error 403: Forbidden
[info] Available formats for m000ctc1:
format code extension resolution note
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash-audio_eng_1=128000 m4a audio only [en] DASH audio 128k , m4a_dash container, mp4a.40.2 (48000Hz)
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash_https-audio_eng_1=128000 m4a audio only [en] DASH audio 128k , m4a_dash container, mp4a.40.2 (48000Hz)
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash-audio_eng_1=128000 m4a audio only [en] DASH audio 128k , m4a_dash container, mp4a.40.2 (48000Hz)
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash_https-audio_eng_1=128000 m4a audio only [en] DASH audio 128k , m4a_dash container, mp4a.40.2 (48000Hz)
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash-video=827000 mp4 704x396 DASH video 827k , mp4_dash container, avc3.4D401E, 25fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash_https-video=827000 mp4 704x396 DASH video 827k , mp4_dash container, avc3.4D401E, 25fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash-video=827000 mp4 704x396 DASH video 827k , mp4_dash container, avc3.4D401E, 25fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash_https-video=827000 mp4 704x396 DASH video 827k , mp4_dash container, avc3.4D401E, 25fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash-video=1570000 mp4 704x396 DASH video 1570k , mp4_dash container, avc3.64001F, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash_https-video=1570000 mp4 704x396 DASH video 1570k , mp4_dash container, avc3.64001F, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash-video=1570000 mp4 704x396 DASH video 1570k , mp4_dash container, avc3.64001F, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash_https-video=1570000 mp4 704x396 DASH video 1570k , mp4_dash container, avc3.64001F, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash-video=2812000 mp4 960x540 DASH video 2812k , mp4_dash container, avc3.64001F, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash_https-video=2812000 mp4 960x540 DASH video 2812k , mp4_dash container, avc3.64001F, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash-video=2812000 mp4 960x540 DASH video 2812k , mp4_dash container, avc3.64001F, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash_https-video=2812000 mp4 960x540 DASH video 2812k , mp4_dash container, avc3.64001F, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash-video=5070000 mp4 1280x720 DASH video 5070k , mp4_dash container, avc3.640020, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_dash_https-video=5070000 mp4 1280x720 DASH video 5070k , mp4_dash container, avc3.640020, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash-video=5070000 mp4 1280x720 DASH video 5070k , mp4_dash container, avc3.640020, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_dash_https-video=5070000 mp4 1280x720 DASH video 5070k , mp4_dash container, avc3.640020, 50fps, video only
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_hls-1013 mp4 704x396 1013k , avc1.4D401E@ 827k, 25.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_hls_https-1013 mp4 704x396 1013k , avc1.4D401E@ 827k, 25.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_bidi_uk_hls-1013 mp4 704x396 1013k , avc1.4D401E@ 827k, 25.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_bidi_uk_hls_https-1013 mp4 704x396 1013k , avc1.4D401E@ 827k, 25.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_hls-1013 mp4 704x396 1013k , avc1.4D401E@ 827k, 25.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_hls_https-1013 mp4 704x396 1013k , avc1.4D401E@ 827k, 25.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_hls-1800 mp4 704x396 1800k , avc1.64001F@1570k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_hls_https-1800 mp4 704x396 1800k , avc1.64001F@1570k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_bidi_uk_hls-1800 mp4 704x396 1800k , avc1.64001F@1570k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_bidi_uk_hls_https-1800 mp4 704x396 1800k , avc1.64001F@1570k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_hls-1800 mp4 704x396 1800k , avc1.64001F@1570k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_hls_https-1800 mp4 704x396 1800k , avc1.64001F@1570k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_hls-3117 mp4 960x540 3117k , avc1.64001F@2812k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_hls_https-3117 mp4 960x540 3117k , avc1.64001F@2812k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_bidi_uk_hls-3117 mp4 960x540 3117k , avc1.64001F@2812k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_bidi_uk_hls_https-3117 mp4 960x540 3117k , avc1.64001F@2812k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_hls-3117 mp4 960x540 3117k , avc1.64001F@2812k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_hls_https-3117 mp4 960x540 3117k , avc1.64001F@2812k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_hls-5510 mp4 1280x720 5510k , avc1.640020@5070k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_akamai_uk_hls_https-5510 mp4 1280x720 5510k , avc1.640020@5070k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_bidi_uk_hls-5510 mp4 1280x720 5510k , avc1.640020@5070k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_bidi_uk_hls_https-5510 mp4 1280x720 5510k , avc1.640020@5070k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_hls-5510 mp4 1280x720 5510k , avc1.640020@5070k, 50.0fps, mp4a.40.2@128k
stream-uk-iptv_streaming_concrete_combined_hd_mf_limelight_uk_hls_https-5510 mp4 1280x720 5510k , avc1.640020@5070k, 50.0fps, mp4a.40.2@128k (best)
| question | low | Critical |
545,342,480 | go | proposal: spec: exhaustive switching for enum type-safety | - **Would you consider yourself a novice, intermediate, or experienced Go programmer?**
Intermediate, multiple projects, plenty of learning
- **What other languages do you have experience with?**
JS/TS, Swift, Python, C#, C++
- **Has this idea, or one like it, been proposed before?**
Yes, the enums are a popular under proposal subject matter.
- **If so, how does this proposal differ?**
It doubles down on the status quo (aka historically idiomatic) solution for enums in Go. All current Go enum declarations will remain valid. Instead of introducing new keywords or interfering with existing patterns (such as the Stringer interface) it adds tools for enforcement and runtime-safety of enumeration usage. It does so by employing existing type assertion and type casting idioms, and the `const` keyword idiomatic to Go enum declarations.
- **Who does this proposal help, and why?**
For those adopting enums in Go, it is important to limit their use to the values known at compile time, or explicitly opt-in to the type-casting and therefore verifying the primitive values. The new syntax will not eliminate the need for authors of packages exposing an enumeration type to create checks on enum usage. Rather, this proposal will clarify the party **responsible** for enum value validation and provide tools that will make that validation idiomatic, clearly identifiable and easy to implement.
- **Is this change backward compatible?**
Yes.
- **Show example code before and after the change.**
_I used http package as an example but I do not advocate redeclaring standard library constants as enums._
Before
```go
const (
MethodGet = "GET"
// ...
)
func NewRequest(method, url string, body io.Reader) (*Request, error) {
switch method {
case MethodGet:
// ...
default:
return nil, ErrUnknownMethod
}
}
```
After (please see [comment below](https://github.com/golang/go/issues/36387#issuecomment-583637427) for an evolved, but still work in progress update to the proposed changes)
```go
type Method string
const (
MethodGet Method = "GET"
// ...
)
// NewRequest with original signature allows for freeform string method
func NewRequest(method, url string, body io.Reader) (*Request, error) {
// method, ok := method.(const) // ERR: can't check untyped string value against known constants
// but if the user provides a set of constants to check, we can use a switch:
switch method.(const) {
case MethodGet:
// ...
default:
// The default case in a .(const) switch is a requirement
return nil, ErrUnknownMethod
}
// Or we can cast to a named type, effectively switching over cases for each of enum's constant values
method, ok := Method(method).(const)
if (!ok) {
return nil, ErrUnknownMethod
}
// Now that method is a known constant, the .(const) switch may drop its default clause
// ...
}
// NewRequestEnum requires enum type but has no opinion on its source
// For the caller, it makes it clear the first argument is unlike the second.
func NewRequestEnum(m Method, url string, body io.Reader) (*Request, error) {
// ...
}
// NewRequestConst is not callable from if using Method cast from a primitive type without performing .(const) check.
// For the caller, it makes it clear there is a set of values of named type already provided.
func NewRequestConst(m const Method, url string, body io.Reader) (*Request, error) {
// This is a "MAYBE??": addition to the syntax, borrowing from "chan type",
// "const type" requires caller to use a pre-defined constant value
// or use switch.(const) and .(const) type-cast to fulfill that obligation
// when sourcing from a primitive type.
// See comment below for me pulling back from this.
}
```
- **What is the cost of this proposal? (Every language change has a cost).**
The new syntax clashes with `.(type)` and the `const` addition to function signature argument is opening a can of worms.
- **How many tools (such as vet, gopls, gofmt, goimports, etc.) would be affected?**
New syntax would depend on linting and formatting to ensure ease of adoption.
- **What is the compile time cost?**
Compiler would need to identify all references to a named `const` type and ensure the binary has type-specific facilities for executing `.(const)` checks. Additionally, when a function signature (or perhaps even a struct field) requires `const` argument, it must identify the call site and ensure the `.(const)` conversion takes place prior to call.
- **What is the run time cost?**
During program execution the new `.(const)` checks are done against switch cases or statically instanced collections of pre-defined values. If the type casting for enum values is present in the binary, and the new syntax is employed unsafely (e.g. the `.(const)` casting omits `ok` variable), the `panic` messaging must clearly identify the mismatch between available pre-defined enum constants and the result of the runtime-cast of from a primitive type.
- **Can you describe a possible implementation?**
No. I don't have a familiarity with the Go source code. Point me in the right direction and I would love to contribute.
- **Do you have a prototype? (This is not required.)**
No, but willing to collaborate.
- **How would the language spec change?**
I don't have an off-hand grasp of EBNF notation, but in layman's terms the spec will extend type assertion, type switch, and function parameter usage to make possible the new syntax.
- **Orthogonality: how does this change interact or overlap with existing features?**
It makes use of type assertion and type casting syntax as the basis.
- **Is the goal of this change a performance improvement?**
No.
- **Does this affect error handling?**
Yes, the advancement of enum support in Go through this or another proposal must ensure more elaborate analysis at exception site. In case of this proposal, it is now possible to identify
- **If so, how does this differ from previous error handling proposals?**
I don't know.
- **Is this about generics?**
No.
<details><summary>Original ideas and research</summary>
### Prior Art
In no specific order:
- #32176 has shown there is some confusion behind the sense of enum not being a native? type (sugar), but an engineering pattern/trick.
- There are plenty of examples of this pattern being _baked_ into the language, some outlined in #28987. (As well as clear argumentation of what needs to improve.)
- In fact `case` keyword has already been appropriated for enum declarations in #28438 leading to defacto parity with language like Swift.
- While others, e.g. #28438 need enums to be akin structs with dot-notation hierarchy access as if it's a graph.
- Lacking _Range type_ sugar is another source of confusion (#30428 and).
- Some _range_ issues are really about constraining the enumeration — #29649
- Aliasing possibility (#17784) for a short time further confused the enum declarations.
- Apparently, clarity of Go int enumeration being an ordered list of things is a _feature_, and #13403 seems like it would be an unnecessary change to the `gofmt` status quo.
- There is enum chatter which is _really_ about getting Strings out of the enum values (#32176, #13744).
- Interestingly enough the _immutability_ question, which underlies the enumeration pattern, has been discussed in #27975. @beoran cites people saying "go doesn't have enums", when they mean "go doesn't implement conveniences based on enum keyword"
- `iota` usage extension has been mentioned in #21473 and I take it as a sign `iota` will not be going away...
- The root #19814 is again about keyword introduction to purge the unexpected conditions in a "enum" value switch. The earlier questions #17205, #9481 outline the core needs — how do we ensure only known values are accepted?
- Ultimately, #5469 decided not to touch the enum switching, but Go 2 seems like a great time to revisit.
- Very early on (#359) the _type-safety_ was the only omission from the const-enum.
### Thoughts
1. `enum` *is indeed* new type, which is what `type State string` does, there is no idiomatic need to introduce a new keyword. Go isn't about saving space in your source code, it is about readability, clarity of purpose.
2. Lack of type safety, confusing the new `string`- or `int`-based types for actual strings/ints is the key hurdle. All enum clauses are declared as `const`, which creates a set of known values compiler can check against.
3. `Stringer` interface is the idiom for representing any type as human-readable text. Without customization, `type ContextKey string` enums this is the string value, and for `iota`-generated enums it's the integer, much like [XHR ReadyState codes](https://developer.mozilla.org/en-US/docs/Web/API/XMLHttpRequest/readyState) (0 - unsent, 4 - done) in JavaScript.
**Rather,** the problem lies with the fallibility of custom `func (k ContextKey) String() string` implementation, which is usually done using a switch that must contain every known enum clause constant.
4. In a language like Swift, there is a notion of _an exhaustive switch_. This is a good approach for both the type checking against a set of `const`s and building an idiomatic way to invoke that check. The `String()` function, being a common necessity, is a great case for implementation.
### Proposal
```go
package main
import (
"context"
"strconv"
"fmt"
"os"
)
// State is an enum of known system states.
type DeepThoughtState int
// One of known system states.
const (
Unknown DeepThoughtState = iota
Init
Working
Paused
ShutDown
)
// String returns a human-readable description of the State.
//
// It switches over const State values and if called on
// variable of type State it will fall through to a default
// system representation of State as a string (string of integer
// will be just digits).
func (s DeepThoughtState) String() string {
// NEW: Switch only over const values for State
switch s.(const) {
case Unknown:
return fmt.Printf("%d - the state of the system is not yet known", Unknown)
case Init:
return fmt.Printf("%d - the system is initializing", Init)
} // ERR: const switch must be exhaustive; add all cases or `default` clause
// ERR: no return at the end of the function (switch is not exhaustive)
}
// RegisterState allows changing the state
func RegisterState(ctx context.Context, state string) (interface{}, error) {
next, err := strconv.ParseInt(state, 10, 32)
if err != nil {
return nil, err
}
nextState := DeepThoughtState(next)
fmt.Printf("RegisterState=%s\n", nextState) // naive logging
// NEW: Check dynamically if variable is a known constant
if st, ok := nextState.(const); ok {
// TODO: Persist new state
return st, nil
} else {
return nil, fmt.Errorf("unknown state %d, new state must be one of known integers", nextState)
}
}
func main() {
_, err := RegisterState(context.Background(), "42")
if err != nil {
fmt.Println("error", err)
os.Exit(1)
}
os.Exit(0)
return
}
```
P.S. Associated values in Swift enums are one of my favorite gimmicks. In Go there is no place for them. If you want to have a value next to your enum data — use a strongly typed `struct` wrapping the two.
</details>
_Originally posted by @ermik in https://github.com/golang/go/issues/19814#issuecomment-551095842_ | LanguageChange,Proposal,LanguageChangeReview | high | Critical |
545,362,708 | flutter | ThemeData.from ignore colorPrimary when brightness is dark | ## Steps to Reproduce
1. create a colorscheme:
```dart
const ColorScheme.dark(
primary: Color(0xFFf8fa93),
primaryVariant: Color(0xFFc4c763),
onPrimary: Color(0x8C000000),
secondary: Color(0xFF9593fa),
secondaryVariant: Color(0xFF6265c6),
onSecondary: Color(0xA8000000),
);
```
2. create a theme data using the ThemeData.from:
```dart
ThemeData.from(
colorScheme: defaultDarkColorScheme,
textTheme: Typography.englishLike2018,
);
```
3. override the primary text theme with text color matching eligible [text color](https://material.io/resources/color/#!/?view.left=1&view.right=1&primary.color=F8FA93&secondary.color=9593fa):
```dart
defaultDarkTheme.copyWith(
primaryTextTheme: defaultDarkTheme.primaryTextTheme.apply(
displayColor: Color(0x6B000000),
bodyColor: Color(0x8C000000),
),
accentTextTheme: defaultDarkTheme.accentTextTheme.apply(
displayColor: Color(0x7D000000),
bodyColor: Color(0xA8000000),
),
);
```
4. pass the theme to the material app theme or dark theme property.
Result:
the app bar color does not match the primary color so then the text appbar is not visible.
Here's a dart pad example showing the issue https://dartpad.dev/b6409e10de32b280b8938aa75364fa7b
**Target Platform:**
Any
**Target OS version/browser:**
Any
**Devices:**
Any | framework,f: material design,a: quality,has reproducible steps,found in release: 3.3,found in release: 3.7,team-design,triaged-design | medium | Minor |
545,365,029 | pytorch | Negative indices in chunk could cause Out of Range access on loss.backward in JIT | ## 🐛 Bug
This's the error message:
```
File "~/exp/foo/train.py", line 114, in train
loss_.backward()
File "~/.local/lib/python3.6/site-packages/torch/tensor.py", line 166, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph)
File "~/.local/lib/python3.6/site-packages/torch/autograd/__init__.py", line 99, in backward
allow_unreachable=True) # allow_unreachable flag
RuntimeError: vector::_M_range_check: __n (which is 18446744073709551615) >= this->size() (which is 2)
The above operation failed in interpreter, with the following stack trace:
```
It doesn't happen given `env PYTORCH_JIT=0`.
It doesn't mention anything about where the error could actually be... So I went hunting in recent commits and:
## To Reproduce
I'm still trying to write a minimal example, but haven't been able to yet.
It's a custom RNN. The _only_ difference between the code that works with the JIT and that which doesn't is one place with the following change:
```py
out = self.input_kernel(xto).chunk(4, 1)
# had been changed into:
out = self.input_kernel(xto).chunk(4, -1)
```
`xto` is _always_ a 2D tensor where dim1 is divisible by 4. The error also mentions it's of `this->size() == 2`. Unless I'm misunderstanding that.
Factoring out that expression into a method and decorating it `jit.ignore` solves the issue. Meaning the model runs and trains. But there's this break in the JIT chain.
## Expected behavior
Negative indices work as expected.
## Environment
```
PyTorch version: 1.3.1
Is debug build: No
CUDA used to build PyTorch: 10.1.243
Python version: 3.6
Is CUDA available: Yes
Versions of relevant libraries:
[pip3] numpy==1.18.0
[pip3] pytorch-transformers==1.1.0
[pip3] torch==1.3.1
[pip3] torchfile==0.1.0
[pip3] torchnet==0.0.4
[pip3] torchsummary==1.5.1
[pip3] torchvision==0.4.0
[pip3] torchviz==0.0.1
```
## Additional context
None.
cc @suo | oncall: jit,triaged | low | Critical |
545,373,860 | pytorch | The model training time is increasing between runs if the same DataLoader reused to train multiple models. | [torch-dataloader-issues.ipynb.zip](https://github.com/pytorch/pytorch/files/4022924/torch-dataloader-issues.ipynb.zip)
## 🐛 Bug
The model training time is increasing between runs if the same `DataLoader` reused to train multiple models. This problem was initially observed when we benchmarked fast.ai model, so we tried plain torch and it seems the problem persists.
The problem is not as severe if `num_workers=0` used. And it seems the source is somewhere in this call
Training time for 500 runs with the same DataLoader:
**Before**
```
ncalls tottime percall cumtime percall filename:lineno(function)
151 0.009 0.000 0.261 0.002 /home/user/anaconda3/envs/py36mkl/lib/python3.6/site-packages/torch/utils/data/dataloader.py:344(__next__)
```
**After**
```
ncalls tottime percall cumtime percall filename:lineno(function)
151 0.010 0.000 0.277 0.002 /home/user/anaconda3/envs/py36mkl/lib/python3.6/site-packages/torch/utils/data/dataloader.py:344(__next__)
```
## To Reproduce
See attached jupyter notebook in zip.
## Expected behavior
No training time growth if the same data loader reused to train same model.
## Environment
```
Collecting environment information...
PyTorch version: 1.3.1
Is debug build: No
CUDA used to build PyTorch: 10.1.243
OS: Ubuntu 18.04.3 LTS
GCC version: (Ubuntu 7.4.0-1ubuntu1~18.04.1) 7.4.0
CMake version: version 3.10.2
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: TITAN RTX
Nvidia driver version: 440.33.01
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.5
Versions of relevant libraries:
[pip] numpy==1.17.4
[pip] torch==1.3.1
[pip] torchvision==0.4.2
[conda] mkl 2019.5 intel_281 intel
[conda] mkl-service 2.3.0 py36_0 intel
[conda] mkl_fft 1.0.14 py36ha68da19_1 intel
[conda] mkl_random 1.0.4 py36ha68da19_2 intel
[conda] mxnet-mkl 1.5.1.post0 pypi_0 pypi
[conda] pytorch 1.3.1 py3.6_cuda10.1.243_cudnn7.6.3_0 pytorch
[conda] torch 1.2.0 pypi_0 pypi
[conda] torchvision 0.4.2 pypi_0 pypi
```
## Additional context
See attached jupyter notebook for more details.
cc @SsnL | module: dataloader,triaged | low | Critical |
545,389,598 | rust | Compile code is very slow in debug mode | Compile code is very slow in My hardware configuration.
```
CPU : Core i7 8700 3.2GHz(6 core)
MEM: 16GB
Samsung SSD 500GB solid state drive
```
Compilation is very slow.
every time Compilation use more than 10 second
Can the new version speed up compilation? Because the compilation is slow and the coding efficiency is also slow。 | I-compiletime,T-compiler,A-incr-comp | low | Critical |
545,395,467 | flutter | Add screen shot capabilities to webview | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
## Proposal
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
Could you please add a function in webview plugin which can take a shortcut in webview? Thanks so much | c: new feature,p: webview,package,team-ecosystem,P3,triaged-ecosystem | low | Critical |
545,395,687 | storybook | Create an official template for CRA | **Is your feature request related to a problem? Please describe.**
Since CRA now supports [custom template](https://create-react-app.dev/docs/custom-templates), I think it makes sense for us to create official template for CRA. It would make new comers easier to get started with storybook and CRA.
**Describe the solution you'd like**
We can create a new package `cra-template-storybook` and maintain it in this mono. We just have to follow the guide [here](https://create-react-app.dev/docs/custom-templates#building-a-template), and the official template in [`cra-template`](https://github.com/facebook/create-react-app/tree/master/packages/cra-template) and [`cra-template-typescript`](https://github.com/facebook/create-react-app/tree/master/packages/cra-template-typescript).
**Describe alternatives you've considered**
`npx -p @storybook/cli sb init` works just fine, and we can continue support that for existing projects and for non-CRA projects. For new projects though, we can recommend users to just use `cra-template-storybook` to get started.
**Are you able to assist bring the feature to reality?**
Absolutely! I think it's fairly straight-forward. There are only some minor issues, like where should we put this project? A new directory `templates`? Inside `examples` (but it's not an example)? Or maybe just in `lib`?
Also since we can control the template now, we could create example component directly inside the template rather than using `@storybook/react/demo`. Would love to hear some ideas about this 🙂.
**Additional context**
In short for what it would look like when landed. Users can simply run this command and get an CRA with storybook.
```sh
npx create-react-app --template storybook
```
| feature request,cli,cra | medium | Minor |
545,399,358 | ant-design | Timeline组件能否支持水平（horizontal）和竖直（vertical）两种方向 | - [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### What problem does this feature solve?
很多数据可视化需要一种水平显示，比如一种重复的周期性的日期
### What does the proposed API look like?
就像Steps组件一样 提供direction参数就行
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive | low | Major |
545,402,375 | rust | Type inference can't resolve through Result::map_err | I would expect all 4 of these functions to compile, but the second one apparently doesn't have enough type information, despite it looking logically equivalent to the first (to me anyways).
https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=1d3fa8810715f720dd3f6c09e8db534f | C-enhancement,T-lang,T-compiler,A-inference | low | Critical |
545,425,044 | flutter | path_provider plugin's getExternalStorageDirectory() method | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!--
Please tell us exactly how to reproduce the problem you are running into.
Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.
If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.
-->
getExternalStorageDirectory() returns /storage/emulated/0/Android/data/com.example.shop/files
instead of /storage/emulated/0
Because of this I'm not able to get the image in my gallery. Although if I add the path manually I'm able to store the image.
<!--
Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?
-->
**Target Platform:**Andriod Pie
**Devices:** Both physical and emulator
## Code
<b>qr.dart</b>
```dart
import 'package:flutter/material.dart';
import 'package:qr_flutter/qr_flutter.dart';
import 'package:flutter/services.dart';
import 'dart:async';
import 'dart:typed_data';
import 'dart:ui' as ui;
import 'dart:io';
import 'package:flutter/rendering.dart';
import 'package:path_provider/path_provider.dart';
import 'package:fluttertoast/fluttertoast.dart';
import 'package:image_gallery_saver/image_gallery_saver.dart';
import 'package:permission_handler/permission_handler.dart';
import 'package:http/http.dart' as http;
class DisplayQR extends StatelessWidget {
List<String> shopDataObj = List<String>();
DisplayQR(this.shopDataObj);
GlobalKey globalKey = new GlobalKey();
var bgColor = Colors.red;
String formattedDate() {
DateTime dateTime = DateTime.now();
String dateTimeString = 'SaloonQR_' +
dateTime.year.toString() +
dateTime.month.toString() +
dateTime.day.toString() +
dateTime.hour.toString() +
':' +
dateTime.minute.toString() +
':' +
dateTime.second.toString() +
':' +
dateTime.millisecond.toString() +
':' +
dateTime.microsecond.toString();
return dateTimeString;
}
requestPermission() async {
Map<PermissionGroup, PermissionStatus> permissions =
await PermissionHandler().requestPermissions([PermissionGroup.storage]);
// print(permissions);
return permissions;
}
checkPermission() async {
PermissionStatus permission = await PermissionHandler()
.checkPermissionStatus(PermissionGroup.storage);
return permission;
}
Future<void> _captureAndSavePng() async {
// print("clicked");
try {
RenderRepaintBoundary boundary =
globalKey.currentContext.findRenderObject();
ui.Image image = await boundary.toImage(pixelRatio: 5.0);
// print(image.height);
ByteData byteData =
await image.toByteData(format: ui.ImageByteFormat.png);
// if (!(await checkPermission())) await requestPermission();
PermissionStatus req = await checkPermission();
if (req != PermissionStatus.granted) print(requestPermission());
Uint8List pngBytes = byteData.buffer.asUint8List();
Directory directory = await getExternalStorageDirectory();
// String path = directory.path;
String path = '/storage/emulated/0';
print(path);
await Directory('$path/SaloonQr').create(recursive: true);
File('$path/SaloonQr/${formattedDate()}.png')
.writeAsBytesSync(pngBytes.buffer.asInt8List());
} catch (e) {
print("Error:" + e.toString());
}
}
Future<void> _captureAndSharePng() async {
// print("clicked" + bgColor);
try {
RenderRepaintBoundary boundary =
globalKey.currentContext.findRenderObject();
ui.Image image = await boundary.toImage(pixelRatio: 5.0);
// print(image.height);
ByteData byteData =
await image.toByteData(format: ui.ImageByteFormat.png);
Uint8List pngBytes = byteData.buffer.asUint8List();
// print(pngBytes);
final tempDir = await getTemporaryDirectory();
final file = await new File('${tempDir.path}/image.png').create();
await file.writeAsBytes(pngBytes);
final channel = const MethodChannel('channel:me.shopqr.share/share');
channel.invokeMethod('shareFile', 'image.png');
} catch (e) {
print(e.toString());
}
}
@override
Widget build(BuildContext context) {
bgColor = Theme.of(context).scaffoldBackgroundColor;
return Container(
// color: const Color(0xFFFFFFFF),
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
RepaintBoundary(
key: globalKey,
child: Container(
color: bgColor,
child: Column(
children: <Widget>[
QrImage(
backgroundColor: bgColor,
data: shopDataObj.elementAt(1),
version: QrVersions.auto,
size: 250.0,
),
Text(
shopDataObj.elementAt(0),
style: TextStyle(
fontSize: 25,
),
),
],
),
),
),
Row(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
IconButton(
icon: Icon(Icons.save_alt),
onPressed: () => {
_captureAndSavePng(),
Fluttertoast.showToast(
msg: "Image Saved",
gravity: ToastGravity.BOTTOM,
timeInSecForIos: 3,
backgroundColor: Colors.black12,
textColor: Colors.black,
fontSize: 16.0),
},
),
IconButton(
icon: Icon(Icons.share),
onPressed: () => {
_captureAndSharePng(),
},
),
],
),
],
),
);
}
}
``` | platform-android,p: path_provider,package,P2,team-android,triaged-android | low | Critical |
545,430,996 | flutter | Support named routes redirects | ## Use case
For Flutter web, the page URL shown on the browser's address bar corresponds to the named routes. However, there is very little control as to what URL to show to the user. And there is no way to define a route redirect in the `routes` (which takes a `WidgetBuilder`).
For example, we can do the following to map multiple named routes to the same widget, but on the web version the page URL will show up differently.
```dart
routes: <String, WidgetBuilder>{
'/first': (context) => FirstScreen(),
'/firstAlias': (context) => FirstScreen(),
'/second': (context) => SecondScreen(),
)
```
If we don't want the page URL to show up as `'/firstAlias'` and we want to simply redirect the route to `'/first'`, this currently is very hard to implement because `NavigatorState` doesn't expose an API for getting the path of the current route, and `Route` doesn't expose an API for determining a route's path either. So there is no simple way to determine in `FirstScreen`'s `initState` which route it is and thus cannot easily push routes to redirect accordingly.
The use case, is for web apps, for example, it is common to have the same content with multiple URLs, while having a unique canonical URL for them all. And we want to redirect all other URLs to its canonical URL that is exposed to the user on the browser's address bar.
## Proposal
I'd like to propose a `RouteRedirect` widget that could handle the route redirects:
```dart
routes: <String, WidgetBuilder>{
'/first': (context) => FirstScreen(),
'/firstAlias': (context) => RouteRedirect.to('/first'),
'/second': (context) => SecondScreen(),
)
```
The difference here in using `RouteRedirect.to(String routeName)` is that it will redirect the named route, so it can expose the desired on the URL on the browser's address bar. In this case, the URL will show up as `'/first'` even when `'/firstAlias'` is pushed, or if the user attempts to visit `'/firstAlias'` through the address bar.
### Things that Route Redirects might affect
- How `NavigatorObserver` should behave with route redirects
The `NavigatorObserver.didPush` should be triggered twice -- once for the route redirect (`'/firstAlias'`) and another for the target route (`'/firstAlias'` -> `'/first'`)
- How cross-route animations (e.g. `Hero` animations`) should behave with route redirects
Any cross-route animations should not be affected by route redirects. | c: new feature,framework,f: routes,platform-web,c: proposal,P3,team-web,triaged-web | low | Major |
545,432,002 | TypeScript | Include new features in handbook instead of referencing "What's new". | While reading through the handbook I find something like this:
"From TypeScript 3.7 and onwards, you can use optional chaining to simplify working with nullable types." Where "optional chaining" links to the "What's new" page for version 3.7.
Why not include this in the handbook but put references - in the handbook - to other pages explaining "What's new"?
Please include all features of the language in the handbook. Actually I'd suggest to always update the handbook and only put references in the "What's new" page with a link to the relevant pages in the handbook. | Docs | low | Minor |
545,433,063 | create-react-app | Allow independent versioning for custom react-scripts forks | ### Is your proposal related to a problem?
Yes.
I'm currently working on a custom version of react-scripts for my company to use so that we can build new react-apps with our own webpack configs & pre-installed dependencies. However, the problem is that in `createReactApp.js` line 436, `const templatesVersionMinimum = '3.3.0';` it makes it so that in order for CRA to actually build the src files properly I have to specify a minimum package version of `3.3.0` I get the motivation for that code. However, if I'm working on a new customized version of a package, I don't really want to start at version 3.3.0, I want to start at 0.0.1 or at least 1.0.0.
### Describe the solution you'd like
I think the `templatesVersionMinimum` constant being set to `3.3.0` should really only be applied if you intend to use the default package of react-scripts that CRA uses. Otherwise it really shouldn't have that limit in place, because other people might not want to begin their package versioning at 3.3.0. Of course, people using custom-react scripts intending to use templates would need to be sure their customizations don't break the template support introduced in 3.3.0 so I guess the scope expands a bit further than simply setting a conditional wherein that `templatesVersionMinimum` isn't set at all when a non-default react-scripts is specified.
### Describe alternatives you've considered
1. Setting my package version to `3.3.0`
--This works, but I mean it's pretty gross.
2. Leaving modern society and living in a cave eating berries
--This doesn't _fix_ the problem per se. But it does remove it from a being a problem I need to deal with. Not an ideal solution either. | issue: proposal,needs triage | low | Minor |
545,439,441 | scrcpy | Long press action for BACK, HOME, APP_SWITCH | Android (9 Pie) allow you to define "long press" and "double tap" actions for BACK, HOME, APP_SWITCH (in Settings/Buttons/Buttons).
"Long press" is not working.
For example "long press Middle-Click" is NOT working like "long press HOME" on device. And "long press Right-Click" is NOT working like "long press BACK" on device.
(It is the same about long press Ctrl+B, Ctrl+H, Ctrl+S).
Thanks! | feature request | low | Major |
545,443,604 | TypeScript | Property '[Symbol.iterator]' is missing in type 'PartialTuple<ConstructorParams<T>> | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.1 -> 3.7
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
tuple, mapped tuple
**Code**
```ts
type Constructor = new (...args: any[]) => any;
type ConstructorParams<T extends Constructor> = T extends new (...args: infer P) => any ? P : never;
type PartialTuple<T extends any[]> = {[I in keyof T]: T[I] | undefined}
type ConstructorReturnType<T extends Constructor> =
T extends new (...args: any[]) => infer R ? R : never;
function getClassFactory<T extends Constructor>(type: T) {
type OptionalParams = PartialTuple<ConstructorParams<T>>;
return getFunctionWithOptionalTypes<OptionalParams, ConstructorReturnType<T>>();
}
```
**Expected behavior:**
should compile correctly
**Actual behavior:**
shows error:
>Type 'PartialTuple<ConstructorParams<T>>' does not satisfy the constraint 'any[]'.
> Property '[Symbol.iterator]' is missing in type 'PartialTuple<ConstructorParams<T>>'.
**Playground Link:**
[playground](https://www.typescriptlang.org/play/?ts=3.1.6&ssl=15&ssc=2&pln=6&pc=1#code/LAKAxgNghgzjAEBZAngYWnA3qev5gHsA7GAFwCcBXMUg8gCgAdyDGB5IgUwC54zyAlkQDmAGnjNWAFQDuBXkUoBbAEady4yYykALcpx7wVBAhE5QiASkwBfUHZChSyRp3ipi-arXLwAvPBcMvD0AHThUOTCMLwWyADaALqW-gB88HEA3E4ubh4kFN50AAqRUEowADxS8JwAHqScRAAmCPleNHTpATX1jS0IQSHhoZHRvEIAZurwxSl+6XHwAPyz8AqcAG7q2SDOrrORpAJQEFKUjGbVtQ1NrRlECYnd8JjxAJLwQvAA1pzIBEm8CkiV4Ug+iXgAB94JQWpxJkJOM0HPs8p5Cp1yAAlTikSjkIhSXLXPp3NoYqhY7o4PC9W4DQKcYJhCJRGIPJ7zdJTGbYlbwfkbbbkXagSZwmgCYjwYR49CwGAAMSgWOQpIZ93amJ8qXoaLBKWwIDw8DR8DYjGOxFOpXI5QQATtx1O50unEq2qpPjtDuqqVSu1N+nxhNleKVkutRAA6gJSDpLdHXbkqknpURbWUKuIvUUcXiCUSSVIA-RLLsHOKoxnw6RI0QpcQ4wn0zazqnqr6Kjd+vc4klxFJcaGiHrLLxWaN2WDuzBucCR0XjcHC2HbBkEHF7KBQIQCvAJY3oy3E1aM1n7T2AnLSAq4Cq1fQUPf57sgA)
I have to use 2 functions as I get `A rest parameter must be of an array type.` if I try to do it one function:
```
function getClassFactory<T extends Constructor>(type: T): new (...args: PartialTuple<ConstructorParams<T>>) => ConstructorReturnType<T> {
return {} as any;
}
```
[playground](https://www.typescriptlang.org/play/?ssl=14&ssc=2&pln=12&pc=1#code/LAKAxgNghgzjAEBZAngYWnA3qev5gHsA7GAFwCcBXMUg8gCgAdyDGB5IgUwC54zyAlkQDmAGnjNWAFQDuBXkUoBbAEady4yYykALcpx7wVBAhE5QiASkwBfUHZChSyRp3ipi-arXLwAvPBcMvD0AHThUOTCMLwWyADaALqW-gB88HEA3E4ubh4kFN50AAqRUEowADxS8JwAHqScRAAmCPleNHTpATX1jS0IQSHhoZHRvEIAZurwxSl+6XHwAPyz8AqcAG7q2SDOrrORpAJQEFKUjGbVtQ1NrRlECYnd8JjxAJLwQvAA1pzIBEm8CkiV4Ug+iXgAB94JQWpxJkJOM0HPs8p5Cp1yAAlTikSjkIhSXLXPp3NoYqhY7o4PC9W4DQKcYJhCJRGIPJ7zdJTGbYlbwfkbbbkXagSZwmgCYjwYR49CwGAAMSgWOQpIZ93amJ8qXoaLBlg2LJGYw5pXIx1O50unEq2qpPgt5SqUlSqW57kpRRxeIJRJJbtetNw+nxhNeNgyCCy9lA8fAGPgEqIUuIAHUBKQdGxGMdiKdnRV-LL5RhlaqfMh6CgFXBLLsgA)
I am trying to create a type that returns a function with parameters equal to that of a class constructor but where each parameter is `T[P] | undefined`.
I've done similar to this before
| Needs Investigation | low | Critical |
545,453,092 | godot | Inspector unresponsive when expanding array with a dictionary value while game running | **Godot version:**
v3.2.beta5
**OS/device including version:**
Windows 10
**Issue description:**
If you place dictionaries into an array, then it can be unresponsive to open and close the dictionary in the inspector while the game is running.
https://gyazo.com/939fb3800e04dafccdfbea764dfc31cc
**Steps to reproduce:**
Create an array with a dictionary in it
Run game
Select Remote scene tree
Navigate to array in inspector
Click to expand the dictionary value
**Minimal reproduction project:**
[dict-array-bug.zip](https://github.com/godotengine/godot/files/4023792/dict-array-bug.zip)
| bug,topic:editor | low | Critical |
545,459,000 | flutter | Animate changes to IndexedStack | Hi.
## Use case
This is about two very useful widgets:
* [`AnimatedSwitcher`](https://api.flutter.dev/flutter/widgets/AnimatedSwitcher-class.html)
* [`IndexedStack`](https://api.flutter.dev/flutter/widgets/IndexedStack-class.html)
Intuitively, it seems they could be combined in order to preserve the state between two widgets while animating the transition from one to the other. However, the following code will not work as expected:
```dart
AnimatedSwitcher(
transitionBuilder: AnimatedSwitcher.defaultTransitionBuilder,
duration: const Duration(milliseconds: 500),
child: IndexedStack(
index: condition ? 1 : 0,
children: [
WidgetOne(),
WidgetTwo(),
],
),
)
```
This does not work for obvious reason (assuming `AnimatedSwitcher` is rebuilt with a new `condition` value): the `IndexedStack` widget itself did not change, so there is no animation (while widgets are correctly replaced).
## Proposal
I would like to suggest the addition of a new parameter or some kind of workaround to facilitate the use of `AnimatedSwitcher` with `IndexedStack`. Unfortunately, I don't know what this workaround should look like.
This is related to this issue: https://github.com/flutter/flutter/issues/39398. It was closed for the reason that it is "related to organising of widgets". I would like to re-open it as a "feature request".
A [Stackoverflow question](https://stackoverflow.com/questions/57694249/animatedswitcher-with-indexedstack) has been open consequently. As a Flutter beginner, I'm not comfortable with the proposed answers as they require to completely re-implement `IndexedStack` and / or `Animation` which I find prone-to-error compared to simply combine `AnimatedSwitcher` with `IndexedStack` (that seemed so much more convenient!).
Is there a possibility to make these two widgets more "user-friendly" when they are used together? | c: new feature,framework,a: animation,P3,team-framework,triaged-framework | medium | Critical |
545,480,237 | rust | Please add `try_lock` to `Stdin`, `Stdout`, and `Stderror` | Currently, you can `lock` the three handles but you cannot `try_lock` them. It would be better if users had the option of using `try_lock`. | T-libs-api,C-feature-request | low | Critical |
545,506,556 | flutter | add darkMode as named constructor argument to CupertinoApp | ## Use case
as developer developing for iOS and Android, I want to be able to set a dark theme, which will, like MaterialApp already supports, automatically apply the dark theme.
Good example for what I want to do can be seen with the darkTheme argument when using MaterialApp
## Proposal
I have a code example of what I need for the CupertinoApp:
<img width="568" alt="Bildschirmfoto 2020-01-06 um 03 17 32" src="https://user-images.githubusercontent.com/55476303/71790939-507c2500-3033-11ea-9329-cd46b62a463d.png">
| c: new feature,framework,f: cupertino,P2,team-design,triaged-design | low | Major |
545,507,961 | TypeScript | Refactor option: Convert Object <-> Map | ## Search Terms
Refactor Maps to Objects
Refactor Objects to Maps
Convert objects convert maps
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
I would like to see the ability to right click on a map or object and be able to quickly and easily change the format between an object literal and a Map definition. Would help a lot when prototyping new code.
```ts
const o = {
a: 1,
b: 2,
};
```
```ts
const o = new Map([
["a", 1],
["b", 2],
]);
```
<!-- A summary of what you'd like to see added or changed -->
## Use Cases
This is great when quickly prototyping new code and quickly typing the kind of object you want. If you decide a Map would be better suited for this use case after typing out an object, then you can easily just right click + refactor to `isObject ? "Map" : "Object"`. At the moment, the easiest way to do this in VSCode that I'm aware of is to multi-cursor all the lines and try to modify the format on each line simultaneously, then edit the first and last lines to start with `new Map([` and end with `[)`
It doesn't need to be SUPER sophisticated. The developer can easily change the Map type parameters, for example. It would just be nice to have a way to quickly convert between the two formats.
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
<!-- Show how this would be used and what the behavior would be -->
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Minor |
545,517,154 | pytorch | [Feature Request] reduce CUDA runtime size by selectively compiling PyTorch GPU kernels | ## 🚀 Feature
<!-- .-->
pytorch massive initial memory overhead GPU,we need a way to control the memory and gpu memory during pytorch to cuda() function initialization.
## Motivation
<!-- -->
According to this [discussion](https://github.com/pytorch/pytorch/issues/12873),we kown that there is a way to [reduce pytorch's kernels memory and gpu memory will also be reduced.](https://github.com/pytorch/pytorch/issues/12873#issuecomment-482916237).massive initial memory overhead GPU preventing us from happily using pytorch on devices with small memory like Jetson Nano.
## Pitch
control the memory and gpu memory during pytorch to cuda() function initialization.
<!-- -->
cc @ezyang @gchanan @zou3519 @bdhirsh @jbschlosser @anjali411 @Varal7 @seemethere @malfet @walterddr @ngimel | high priority,module: binaries,module: build,module: cuda,triaged | medium | Major |
545,529,262 | youtube-dl | "The Roku Channel" site support request | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2020.01.01. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2020.01.01**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://therokuchannel.roku.com/watch/a1006dbbe7b15aacb2793a6148021475
- Single video: https://therokuchannel.roku.com/watch/fdfc814018d257bbae57882731ca911c
- Playlist: https://therokuchannel.roku.com/details/9d4a17177b2e5ac7a6c3174f005b9446/suddenly-susan/season-1
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
The ROKU Channel allows for watching streamed media directly from the website. The current implementation requires an account. I'm using the --cookies feature to address authentication and it dose work except with the error: "ERROR: Unsupported URL: ..." I'm using the single video URL for my purposes but a playlist URL is possible if parsing a TV Season page. | site-support-request,geo-restricted,account-needed | low | Critical |
545,561,742 | pytorch | Example cmakelists for custom cuda operator? | I follow the tutorial to extend torchscript with a custom c++ operator.
https://pytorch.org/tutorials/advanced/torch_script_custom_ops.html
But in our project, we have a custom cuda operator defined in a .cc, .cu, .cuh file.
The kernel function is defined in the .cu and .cuh file.
We call the kernel function and register custom torch operator in the .cc file.
Could anyone provide a sample cmakelists file to build a shared library for this cuda operator?
cc @suo | oncall: jit,triaged | low | Minor |
545,571,659 | rust | Specialization works only if type annotation is provided | Playground link: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=a26a9e2af3acda5b9911458a6f54a72d
This trait implementation
```rust
impl<T, V, O, E> Validate<[T]> for V
where
Self: Validate<T, Output = Result<O, E>>,
{
type Output = Result<Vec<O>, E>;
fn validate(&mut self, nodes: &[T]) -> Self::Output {
nodes.iter().map(|node| self.validate(node)).collect()
}
}
```
does not like a method defined as
```rust
impl Analyzer {
/// Validates and store errors if required.
pub fn check<T, O>(&mut self, node: &T) -> Option<O>
where
Self: Validate<T, Output = Result<O, Error>>,
{
let res: Result<O, _> = self.validate(node);
match res {
Ok(v) => Some(v),
Err(..) => {
// handle error
None
}
}
}
}
```
However, it works if type annotation is provided
```rust
fn main() {
let mut a = Analyzer;
let expr = Expr;
// Uncomment this to see impl for [T] explodes
// a.check(&expr);
// This works without error
a.check::<Expr, ()>(&expr);
}
```
| F-specialization | low | Critical |
545,571,695 | flutter | flutter analyze a specific file throws `not a directory` error | I want to analyze a specific file
`flutter analyze ./lib/main.dart`
but I got a error
`/lib/main.dart' is not a directory`
how can I analyze a specific file? | tool,a: quality,has reproducible steps,P3,found in release: 2.3,team-tool,triaged-tool | low | Critical |
545,579,477 | go | gccgo: implement plugin package | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.2 gccgo (Debian 9.2.1-21) 9.2.1 20191130 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/zhsj/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/zhsj/go"
GOPROXY="https://proxy.golang.org"
GORACE=""
GOROOT="/usr"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/gcc/x86_64-linux-gnu/9"
GCCGO="/usr/bin/x86_64-linux-gnu-gccgo-9"
CC="x86_64-linux-gnu-gcc-9"
CXX="x86_64-linux-gnu-g++-9"
CGO_ENABLED="1"
GOMOD="/home/zhsj/go/src/github.com/containerd/containerd/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build814416476=/tmp/go-build -gno-record-gcc-switches -funwind-tables"
</pre></details>
### What did you do?
build containerd with gccgo
```
go-9 build -tags "no_btrfs no_cri" -v ./cmd/containerd
plugin/plugin_go18.go:24:2: cannot find package "plugin" in any of:
/home/zhsj/go/src/github.com/containerd/containerd/vendor/plugin (vendor tree)
/usr/src/plugin (from $GOROOT)
/home/zhsj/go/src/plugin (from $GOPATH)
```
I'm not sure if it's distribution issue or upstream issue. I didn't see `plugin` in `/usr/lib/x86_64-linux-gnu/go/9/x86_64-linux-gnu/`. But I see `plugin` in https://github.com/golang/gofrontend/tree/master/libgo/go/plugin
Is `https://github.com/golang/gofrontend/blob/master/libgo/libgo-packages.txt` responsible for it? I didn't see `plugin` in it too.
### What did you expect to see?
### What did you see instead?
| NeedsFix,FeatureRequest | low | Critical |
545,608,080 | flutter | Reactivate a timer after navigator.push and navigator.pop | I have a timer that updates a counter when a widget is visible. I want to cancel the timer with a navigator.push.
init state is only called at startup. As espected.
deactivate is called on navigator.push (this is where I can cancel my timer)
dispose is never called
How can reactivate after a navigate.pop. because there is no `activate` method in the State widget. only a deactivate. This is very strange for my.
This is my current sollution
```
import 'dart:async';
import 'package:flutter/material.dart';
class Test extends StatefulWidget {
@override
_TestState createState() => _TestState();
}
class _TestState extends State<Test> {
var counter = 0;
Timer _timer;
@override
void initState() {
super.initState();
_setTimer();
}
@override
void deactivate() {
print('DEACTIVATE');
if (_timer.isActive) {
_timer.cancel();
} else {
_setTimer();
}
super.deactivate();
}
@override
Widget build(BuildContext context) {
return Text(counter.toString());
}
void _setTimer() {
_timer = Timer.periodic(const Duration(seconds: 1), (timer) {
setState(() {
counter++;
});
});
}
}
```
This is what I want
```
import 'dart:async';
import 'package:flutter/material.dart';
class Test extends StatefulWidget {
@override
_TestState createState() => _TestState();
}
class _TestState extends State<Test> {
var counter = 0;
Timer _timer;
@override
void initState() {
super.initState();
_setTimer();
}
@override
void activate() {
_setTimer();
}
@override
void deactivate() {
print('DEACTIVATE');
_timer.cancel();
super.deactivate();
}
@override
Widget build(BuildContext context) {
return Text(counter.toString());
}
void _setTimer() {
_timer = Timer.periodic(const Duration(seconds: 1), (timer) {
setState(() {
counter++;
});
});
}
}
```
**Target Platform:** IOS/ANDROID
**Target OS version/browser:** Any
**Devices:** Simulator/Device
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
[✓] Flutter (Channel unknown, v1.12.13+hotfix.5, on Mac OS X 10.15.1 19B88, locale en-BE)
• Flutter version 1.12.13+hotfix.5 at /Users/vanlooverenkoen/flutter
• Framework revision 27321ebbad (4 weeks ago), 2019-12-10 18:15:01 -0800
• Engine revision 2994f7e1e6
• Dart version 2.7.0
[✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
• Android SDK at /Users/vanlooverenkoen/Library/Android/sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-29, build-tools 29.0.2
• Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
• All Android licenses accepted.
[✓] Xcode - develop for iOS and macOS (Xcode 11.3)
• Xcode at /Applications/Xcode.app/Contents/Developer
• Xcode 11.3, Build version 11C29
• CocoaPods version 1.7.5
[✓] Chrome - develop for the web
• Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[✓] Android Studio (version 3.5)
• Android Studio at /Applications/Android Studio.app/Contents
• Flutter plugin version 42.1.1
• Dart plugin version 191.8593
• Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[!] VS Code (version 1.41.1)
• VS Code at /Applications/Visual Studio Code.app/Contents
✗ Flutter extension not installed; install from
https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter
[✓] Connected device (4 available)
• iPhone 11 Pro Max • F2704E51-185C-4E5F-BC54-8FB1BA3C43BE • ios • com.apple.CoreSimulator.SimRuntime.iOS-13-3 (simulator)
• macOS • macOS • darwin-x64 • Mac OS X 10.15.1 19B88
• Chrome • chrome • web-javascript • Google Chrome 78.0.3904.108
• Web Server • web-server • web-javascript • Flutter Tools
! Doctor found issues in 1 category.
```
| framework,dependency: dart,c: proposal,P3,team-framework,triaged-framework | low | Major |
545,622,054 | flutter | Build APK with local engine using multiple architectures | I tried to build an APK with multiple architectures but failed. The --local-engine does not accept multiple values.
My scenario:
There's a crash issue https://github.com/flutter/flutter/issues/47804 that could be resolved by reverting a commit in the flutter engine, it's not fixed yet, so I have to use a local engine to build APKs.
The APK should support arm, arm64, and x86_64. But currently the --local-engine only accepts one of them.
I think it should be possible to use all the local engines for building an APK. They are in the same parent folder.
But it's out of my knowledge.
As an alternative, if there's a way to replace the engine for my local flutter, it's good with me. | c: new feature,tool,engine,P3,team-engine,triaged-engine | low | Critical |
545,623,223 | godot | Godot create tilemap fill preview only when moving mouse | **Godot version:**
3.2 beta 5
**OS/device including version:**
Ubuntu 19.10
**Issue description:**
Godot create fill preview of big tilemap with parts, but only when mouse is moving.
**Steps to reproduce:**
**Minimal reproduction project:**
[GGG.zip](https://github.com/godotengine/godot/files/4025371/GGG.zip)
| discussion,topic:editor,usability | low | Minor |
545,661,409 | godot | [Bullet] Wrong physics when accelerating and braking using VehicleWheel | The spring physics of the vehicle wheel or body is wrong. When accelerating and braking, the vehicle tilts forward or backward. However this is done in the opposite direction from what is natural.
Using a simple setup with a vehicle body and 4 wheels and a static ground plane.
- When applying an engine force to the vehicle, the vehicle tilts forward. In real life the vehicle would tilt backwards.
- When braking the vehicle tilts backwards. In real life the vehicle would tilt forward.
Here is an example of a vehicle braking
| bug,confirmed,topic:physics,topic:3d | low | Major |
545,705,775 | scrcpy | Feature request: APP_SWITCH with middle-click | I think, "APP_SWITCH" is more important than "HOME".
For example, if I want to drink beer and work with one hand, I need APP_SWITCH much more than HOME.
I would like to suggest a command line parameter for "APP_SWITCH with middle-click". (And keyboard for "HOME").
Currently I found one good (not bad) workaround for "APP_SWITCH using mouse".
From android settings I assigned "Recents" (APP_SWITCH) action to "double tap home". This way I have APP_SWITCH with "double middle-click".
I find it is a bit hard to do quick "double middle-click". Double left/right click is more easy. It depends of the mouse also. And android do not have setting to increase "double tap delay".
(It could be useful if I can slowly "double middle-click" BUT it is sent faster/shorter to device.)
Thanks! | feature request | low | Major |
545,717,932 | pytorch | The dependency target "nccl_external" of target "gloo_cuda" does not exist. | ## 🐛 Bug
Found this in my cmake log.
Is it expected?
```
#7 581.0 -- Configuring done
#7 581.8 CMake Warning (dev) at cmake/Dependencies.cmake:1068 (add_dependencies):
#7 581.8 Policy CMP0046 is not set: Error on non-existent dependency in
#7 581.8 add_dependencies. Run "cmake --help-policy CMP0046" for policy details.
#7 581.8 Use the cmake_policy command to set the policy and suppress this warning.
#7 581.8
#7 581.8 The dependency target "nccl_external" of target "gloo_cuda" does not exist.
#7 581.8 Call Stack (most recent call first):
#7 581.8 CMakeLists.txt:390 (include)
#7 581.8 This warning is for project developers. Use -Wno-dev to suppress it.
#7 581.8
```
## Environment
- PyTorch Version (e.g., 1.0): master
- OS (e.g., Linux): CentOS 7
- How you installed PyTorch (`conda`, `pip`, source): source
- Build command you used (if compiling from source): cmake+ninja+gcc-8
- Python version: 3.6
- CUDA/cuDNN version: 10.2
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 | oncall: distributed,module: build,triaged | low | Critical |
545,778,477 | opencv | Any intention to add interoperability with DLPACK or mpi4py? | Given OpenCV's amazing toolkit for image processing, its ability to run on the GPU, and the growing use of image processing for Deep Learning, I'm curious whether anyone has the intention of adding interoperability with [DLPACK](https://github.com/dmlc/dlpack) or [mpi4py ](https://mpi4py.readthedocs.io/en/latest/) so we can pass arrays directly on the GPU? | feature,RFC | low | Minor |
545,785,142 | TypeScript | Allow creating contantly typed Map which has immutable defined set of keys | ## Search Terms
map, const, es6
## Suggestion
Currently you can create objects and arrays with the `as const` assertion, which tells the compiler to, for example, type `["apple", "banana", "pear"]` as `["apple", "banana", "pear"]` rather than as `string[]`. This is useful for instances where the array is constant and you know you can rely on that.
Typing objects `as const` is useful for constant maps/dictionaries, however the better type to use in TypeScript for maps is, of course, `Map`. However, you can't type `Map as const`, which means you can never have a constant `Map` that disallows `set` and `delete` and also knows whether the result of `get` is undefined or not, rather than always making it return the type `x | undefined`.
*Note*: I know I can just use an object for this instead of a `Map`. But `Map` offers many benefits, such as speed and iterability, that objects don't. Also, `Map` is more explicit about what it is doing.
## Examples
Without this feature, I have to do one of the following:
```ts
const optionA: Map<string, string> = new Map([
["date", "YYYY-MM-DD"],
["datetime", "YYYY-MM-DD[T]HH:mm"],
["datetime-local", "YYYY-MM-DD[T]HH:mm"],
["month", "YYYY-MM"],
["time", "HH:mm"],
["week", "YYYY-[W]WW"]
]);
const weekFormat = optionA.get("week") as string; // Forced to use assertion and we still lose data
```
or
```ts
const optionB = {
date: "YYYY-MM-DD",
datetime: "YYYY-MM-DD[T]HH:mm",
"datetime-local": "YYYY-MM-DD[T]HH:mm",
month: "YYYY-MM",
time: "HH:mm",
week: "YYYY-[W]WW]
} as const; // Have to use object
const weekFormat = optionA.week;
```
With this feature, I could do:
```ts
const optionA = new Map([
["date", "YYYY-MM-DD"],
["datetime", "YYYY-MM-DD[T]HH:mm"],
["datetime-local", "YYYY-MM-DD[T]HH:mm"],
["month", "YYYY-MM"],
["time", "HH:mm"],
["week", "YYYY-[W]WW"]
]) as const;
const weekFormat = optionA.get("week"); // type: "YYYY-[W]WW"
optionA.delete("time"); // error
optionA.set("time", "hh:mm"); // error
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
545,798,582 | rust | thread_id_value tracking issue | This is the tracking issue for the `ThreadId::as_u64` method, which casts a thread ID to the underlying `u64`.
There are currently no known blockers to stabilization beyond making sure that the API indeed works for intended use cases.
Implemented originally in https://github.com/rust-lang/rust/pull/67566. | A-concurrency,T-libs-api,B-unstable,C-tracking-issue,Libs-Tracked,Libs-Small | high | Critical |
545,814,515 | PowerToys | Grep for Windows | It would be great if PowerToys can include a tool to grep files such as [GrepWin](https://tools.stefankueng.com/grepWin.html) having a context menu option to Grep files in the selected folders.
| Idea-New PowerToy | medium | Major |
545,825,372 | flutter | [webview_flutter] Provide callback/error for unsupported content types (e.g., PDF) | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!--
Please tell us exactly how to reproduce the problem you are running into.
Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.
If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.
-->
on iphones it works fine, but the pdf is not shown up on android emulator or physical android phone.
I guess the reason is android webview doesn't support pdf?
Is there a way we can add this feature?
```
import 'package:flutter/material.dart';
import 'package:webview_flutter/webview_flutter.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
// This widget is the root of your application.
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
appBar: AppBar(),
body: WebView(
initialUrl:
'https://www.wmata.com/schedules/maps/upload/2019-System-Map.pdf',
),
),
);
}
}
```
<!--
Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?
-->
**Target Platform:**android
**Target OS version/browser:**
**Devices:**
## Logs
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
```
```
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
```
| c: new feature,platform-android,customer: crowd,p: webview,package,has reproducible steps,P2,found in release: 2.2,found in release: 2.5,team-android,triaged-android | low | Critical |
545,836,478 | node | tap2junit/build/python nightly failed with unicode problem | ```
00:21:52 File "/usr/local/lib/python2.7/site-packages/yaml/reader.py", line 144, in check_printable
00:21:52 'unicode', "special characters are not allowed")
00:21:52 yaml.reader.ReaderError: unacceptable character #x001b: special characters are not allowed
```
Nightly build from 2 days ago:
- https://ci.nodejs.org/view/Node.js%20Daily/job/node-daily-master/1795/
OS failure:
- https://ci.nodejs.org/job/node-test-commit-osx/31139/nodes=osx1011/console
```
00:21:51 + tap2junit -i test.tap -o test.xml
00:21:52 Traceback (most recent call last):
00:21:52 File "/usr/local/bin/tap2junit", line 10, in <module>
00:21:52 sys.exit(main())
00:21:52 File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 51, in main
00:21:52 convert(args.input, args.output)
00:21:52 File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 42, in convert
00:21:52 result = parse(input_file, data)
00:21:52 File "/usr/local/lib/python2.7/site-packages/tap2junit/__main__.py", line 34, in parse
00:21:52 tap_parser.parse(data)
00:21:52 File "/usr/local/lib/python2.7/site-packages/tap2junit/tap13.py", line 147, in parse
00:21:52 self._parse(StringIO.StringIO(source))
00:21:52 File "/usr/local/lib/python2.7/site-packages/tap2junit/tap13.py", line 78, in _parse
00:21:52 self.tests[-1].yaml = yamlish.load(self.tests[-1].yaml_buffer)
00:21:52 File "/usr/local/lib/python2.7/site-packages/yamlish.py", line 222, in load
00:21:52 out = load('\n'.join(inobj), ignore_wrong_characters)
00:21:52 File "/usr/local/lib/python2.7/site-packages/yamlish.py", line 203, in load
00:21:52 out = yaml.load(source, Loader=_YamlishLoader)
00:21:52 File "/usr/local/lib/python2.7/site-packages/yaml/__init__.py", line 69, in load
00:21:52 loader = Loader(stream)
00:21:52 File "/usr/local/lib/python2.7/site-packages/yamlish.py", line 145, in __init__
00:21:52 yaml.loader.SafeLoader.__init__(self, stream)
00:21:52 File "/usr/local/lib/python2.7/site-packages/yaml/loader.py", line 24, in __init__
00:21:52 Reader.__init__(self, stream)
00:21:52 File "/usr/local/lib/python2.7/site-packages/yaml/reader.py", line 74, in __init__
00:21:52 self.check_printable(stream)
00:21:52 File "/usr/local/lib/python2.7/site-packages/yaml/reader.py", line 144, in check_printable
00:21:52 'unicode', "special characters are not allowed")
00:21:52 yaml.reader.ReaderError: unacceptable character #x001b: special characters are not allowed
00:21:52 in "<unicode string>", position 114
```
| build,test,python | low | Critical |
545,847,084 | opencv | Feature request: eigenNonSymmetric() with complex eigenvalues | Current `eigenNonSymmetric()` function does not seem to support real square matrix with complex eigenvalues.
Checking that a real matrix has complex eigenvalues seems to be not trivial, [see](https://math.stackexchange.com/questions/1195350/is-there-any-way-we-can-check-if-a-real-matrix-has-complex-eigenvalues).
Example in Numpy/Scipy (from [Matlab doc](https://www.mathworks.com/help/matlab/ref/eig.html)):
```
from __future__ import print_function
import numpy as np
from scipy.linalg import eig
A = np.matrix([[1, 2, 3],
[3, 1, 2],
[2, 3, 1]])
w, v = eig(A)
print('A:\n', A)
print('v:', v)
print('w:', w)
```
gives:
```
A:
[[1 2 3]
[3 1 2]
[2 3 1]]
v: [[-0.57735027+0.j 0.28867513-0.5j 0.28867513+0.5j]
[-0.57735027+0.j -0.57735027+0.j -0.57735027-0.j ]
[-0.57735027+0.j 0.28867513+0.5j 0.28867513-0.5j]]
w: [ 6.0+0.j -1.5+0.8660254j -1.5-0.8660254j]
```
In OpenCV:
```
Matx33d m(
1, 2, 3,
3, 1, 2,
2, 3, 1);
Mat eigenvalues, eigenvectors;
try
{
cv::eigenNonSymmetric(m, eigenvalues, eigenvectors);
std::cout << "m:\n" << m << std::endl;
std::cout << "eigenvalues:\n" << Mat(eigenvalues.t()) << std::endl;
std::cout << "eigenvectors:\n" << eigenvectors << std::endl;
}
catch (const cv::Exception& e)
{
std::cerr << "eigenNonSymmetric no conv: " << e.what() << std::endl;
}
catch (...)
{
std::cerr << "Unknown exception has been raised" << std::endl;
}
```
gives:
```
m:
[1, 2, 3;
3, 1, 2;
2, 3, 1]
eigenvectors:
[0.577350269189626, 0.5773502691896255, 0.577350269189626;
0.7316804540966678, -0.6796598963166424, -0.05202055778002566;
0.3623677410581142, 0.4524699901711914, -0.8148377312293055]
eigenvalues:
[6.000000000000004, -1.5, -1.5]
```
---
Possible feature implementation would be to use `?GEEV` LAPACK routine to compute the eigenvalues and eigenvectors of a general square matrix. So a fallback would be needed when OpenCV is not built with LAPACK support, something like a reference LAPACK implementation?
Output would be something like `CV_64FC2` to handle complex values? Or `CV_64FC2` only when values are complex to keep the previous behavior?
See [`DGEEV`](http://www.netlib.org/lapack/explore-html/d9/d8e/group__double_g_eeigen_ga66e19253344358f5dee1e60502b9e96f.html) doc.
See [`numpy.linalg.eig`](https://docs.scipy.org/doc/numpy/reference/generated/numpy.linalg.eig.html) doc and corresponding [source code](https://github.com/numpy/numpy/blob/v1.17.0/numpy/linalg/linalg.py#L1182-L1321). | feature,RFC | low | Major |
545,848,334 | material-ui | [Drawer] nested menu in minified form | - [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Summary 💡
I have not found such design on [material design](https://material.io/) but I think it would be nice to be able to use the [mini variant drawer](https://material-ui.com/components/drawers/#mini-variant-drawer) even the menu is nested.
## Examples 🌈
GitLab menu provides a good example of such a menu
Discoverable menu on hover in minified form (not doable with current material ui)
Full menu in expanded form (doable with current material ui)
## Motivation 🔦
It is rare not to have a nested menu. It would be interesting to be able to navigate an app with a collapsed menu in its mini variant form | new feature,component: drawer | low | Major |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.