id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
โ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
528,834,757 | go | runtime: being unable to allocate across scavenged and unscavenged memory leads to fragmentation blow-up in some cases | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.13 darwin/amd64
go version go1.13.4 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes. Tested on
<pre>go version go1.4-bootstrap-20170531 darwin/amd64</pre>
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/qwe/Library/Caches/go-build"
GOENV="/Users/qwe/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY="none"
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/qwe/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/qv/37vc1dv526n0drc9jljj4v240000gp/T/go-build366955304=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Original issue description is posted at gonum library repo https://github.com/gonum/gonum/issues/1174
In a few words: we have a huge graph in memory and we need to update it periodically.
After a new graph initialization, we switch pointer to the new graph and wait for GC to free unused memory.
But it never reuses all the HeapIdle and asks OS for new pages increasing HeapSys infinitely.
Base self-contained demo: https://github.com/savalin/example/blob/master/main.go.
It's simplified code but even this one shows some memory management strangeness.
### What did you expect to see?
HeapIdle re-usage instead of asking OS for new memory.
### What did you see instead?
HeapIdle/HeapSys grow infinitely (until OMM-killer wake up and kill the app)
Currently, we downgraded golang to v1.11.13 as a workaround, but we hope to be able to use new golang releases | NeedsInvestigation | low | Critical |
528,839,499 | go | cmd/go: support "-x" in most of go mod commands | https://golang.org/cl/208558 surfaces "-x" flag support in `go mod download`.
We think "-x" may make sense for most of other `go mod` commands that involve non-trivial commands execution underneath.
@jayconrod @bcmills | help wanted,NeedsInvestigation,GoCommand,modules | low | Major |
528,847,561 | youtube-dl | Add option for merging opus audio into mp4 containers | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.11.22. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a feature request
- [x] I've verified that I'm running youtube-dl version **2019.11.22**
- [x] I've searched the bugtracker for similar feature requests including closed ones
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->
Chrome and Firefox has supported mp4 containers with opus audio since version 70 and 63 respectively. The videos play natively in the browser.
The support for mp4+opus in chrome is detailed here: https://www.chromestatus.com/feature/5100845653819392
For ffmpeg to merge opus in mp4 containers the `-strict -2` option needs to be used in ffmpeg
I've testing thse videos in Firefox, Chrome, mpv, VLC, & Totem and all play correctly
| request | low | Critical |
528,860,657 | rust | Documentation for Implemented Traits Confusing for Beginners | [I posted in Reddit](https://www.reddit.com/r/rust/comments/e1zoja/documentation_seems_to_be_missing_methods/) about a method that seemed to be missing in the [Range documentation](https://doc.rust-lang.org/std/ops/struct.Range.html), and it was explained to me that this method (`map`) came from a different trait called `Iterator`.
Most people seemed to know this, but when asked how I would find this information if I didn't know every method on every trait that Range implemented, no one seemed to have a good answer.
The first way was to expand all the information about all the traits. Only the "expand all" button doesn't really expand everything, but just what someone seems to have determined is important, which did not include the `map` method.
So, then the next step, which was to manually expand every single method of every single trait that was implemented for `Range`.
This brings us to my first point. The `expand everything` button should actually expand everything.
There should also be a search box that allows you to search for the methods the trait implements. You could practically get this for free, as the info seems to already be downloaded to the page. I can see no reason why a search feature would not be implemented, especially in light of the fact that you can't do a search on the page with Ctrl+F due to everything being hidden and no easy way to expand everything.
The second point is that there should only be methods that are actually implemented for the actual struct of the page I am on. If a struct doesn't implement a method of a trait that it implements, there is not reason for it to be on that page other than to confuse people.
I get the feeling that people have worked with Rust for so long that they know all this stuff by heart, but for a beginner, this is very confusing, and it also doesn't scale once people start implementing their own structs that people won't have memorized.
To be honest, this is *almost* enough to make me leave the language. I will probably just wait to learn it until proper documentation is implemented though. If I can't deterministically tell what method will do what, how am I supposed to use this language to code?
But think about how awesome it would be if you could just go a struct's documentation page and just scroll through and see every method implemented for the struct and only methods actually implemented? | T-rustdoc,C-enhancement,A-trait-system,A-docs | low | Major |
528,861,394 | go | runtime: always set up TLS on all G-register architectures? | Currently, on G-register architectures (i.e. all non-x86), we set up TLS only when cgo is used, by libc. The reason is probably that the G register is reserved in Go code and so it should always be valid. However, there are more and more cases where we call external functions even in a non-cgo program, for example, VDSO, and libc calls on darwin. These external functions could potentially clobbers the G register temporarily. If a signal is received during the execution of an external function, we cannot directly use the G register's content as the G. This has caused a number of problems. Currently we play various tricks and workarounds. See e.g. #32912, #34391, #35800.
Maybe we should consider initializing TLS ourselves in non-cgo programs, and always save/restore G in TLS across external calls? This way, we unify the cgo and non-cgo code paths, and can remove various workarounds and maybe potential problems.
| NeedsDecision,compiler/runtime | low | Minor |
528,897,078 | pytorch | Add single input/output tensor scatter/gather to ProcessGroup base class | ## ๐ Feature
Additional collectives that operate on a single input and single output tensor.
## Motivation
The collectives defined in `ProcessGroup.hpp` today may take multiple input tensors and write to multiple output tensors.
If a single process uses multiple model replicas located on multiple GPUs, it still needs to be able to compute a global reduction. For this, the reduction operations take a single input and a single output tensor per device. If we have 2 processes each working on 4 GPUs, this means both processes call the reduction with 4 input/output tensors, as if there are 4 virtual ranks located within each process. For the scatter/gather operations, this is the case as well, although the number of outputs is multiplied by the world size. In the same scenario with 2 processes working on 4 GPUs each, performing an allgather of multiple inputs would mean 4 input tensors, and 4x a list of 8 output tensors. This works equally well in case of a single GPU per process.
That said, for scatter/gather collectives, having N outputs per call on the API side means having to allocate a new contiguous output and scattering that output into the user-provided output tensors upon completion. We should address this with a more basic version of these collectives that doesn't force the user to provide N output tensors where a single contiguous version will do.
Then, on top of this, we can easily build coalesced versions of these collectives, that batch the operation for multiple tensors into a single collective call.
## Pitch
We currently define the following collectives:
* `broadcast(vector<Tensor>& tensors)`
* `allreduce(vector<Tensor>& tensors)`
* `reduce(vector<Tensor>& tensors)`
* `allgather(vector<vector<Tensor>>& outputs, vector<Tensor>& inputs)`
* `gather(vector<vector<Tensor>>& outputs, vector<Tensor>& inputs)`
* `scatter(vector<Tensor>& outputs, vector<vector<Tensor>>& inputs)`
* `reduce_scatter(vector<Tensor>& outputs, vector<vector<Tensor>>& inputs)`
We propose to define alternate versions for all that are related to scatter/gather:
* `allgather(Tensor input, optional<Tensor> output)`
* `gather(Tensor input, optional<Tensor> output)`
* `scatter(optional<Tensor> input, Tensor output)`
* `reduce_scatter(Tensor input, optional<Tensor> output)`
For allgather, gather, and reduce/scatter, we can derive the dimensionality of the output from the input, so we don't need an output tensor to be provided by the user. It can be allocated as needed and returned as part of the work object. For scatter, only the root provides an input, and we need all processes to provide the output tensor. Here the input tensor is optional, not the output tensor.
## Additional context
The options structs that determine the root rank of the operation or the type of reduction are omitted for brevity, but still apply for these new prototypes.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 @zappa- | oncall: distributed,triaged,enhancement | low | Minor |
528,900,131 | terminal | Add option for more subtle pane focus border | # Description of the new feature/enhancement
I feel like the images in #3060 are quit misleading. While the accent border isn't distracting in these images because of the bright colors set for the terminal, using normal terminal settings, the accent border is screaming for attention.
# Proposed technical implementation details (optional)
I like the idea of using the accent color, but putting a border all the way around the terminal is a no-go. Perhaps a look should be taken to Windows 8's active app indication?
This should be an obvious indication, but it should not be distracting. | Area-UserInterface,Product-Terminal,Issue-Task | low | Major |
528,906,941 | TypeScript | Triple slash type reference doesn't use baseUrl/typeRoots | In a directory named `test`:
```ts
// @Filename: tsconfig.json
{
"compilerOptions": {
"baseUrl": "../",
"typeRoots": [ "../" ],
"types": [],
"moduleResolution": "node",
"module": "commonjs"
},
"files": [
"welove.ts",
]
}
// @Filename: ex.d.ts
interface F {
(): void
}
// @Filename: welove.ts
/// <reference types="test/ex" />
declare var f: F
f()
```
Expected: No errors; reference to `F` is fine in `welove.ts`.
Actual: "Cannot find type definition file for 'test/ex'.
Related things that work: `"../test/ex", "./ex"`.
Also, `import { A } from "test/foo"` works -- imports use baseUrl/typeRoots correctly.
| Bug | low | Critical |
528,913,105 | flutter | Allow PageView to set a cacheExtent | b/260361075
It would be nice to have a `PageView` that has a `cacheExtent` specified, so that pages could be pre-built.
This is currently blocked because the iOS accessibility bridge does not look for an `allowImplicitScrolling` flag on the parent scrollable - it only looks to see if there are additional scroll children in the tree. Setting a cache extent would then automatically enable implicit scrolling for PageViews in Voiceover mode, which we do not want. If we can figure out a good way to address the iOS bridge issue, it should be fairly trivial to expose a cacheExtent parameter on the PageView.
/cc @lukepighetti who has done some work on this on the framework side.
Unfortunately, the iOS bug is not trivial to fix. | framework,c: proposal,customer: money (g3),P2,team-framework,triaged-framework | low | Critical |
528,917,333 | kubernetes | Migrate kube-controller-manager flags to kube-controller-manager.config.k8s.io | This is part of migrating the Kube-controller-manager command-line to a Kubernetes-style API as part of [componet working group](https://github.com/kubernetes/community/blob/master/wg-component-standard/README.md)
**What would you like to be added**:
Following flags should be migrated to to Kubernetes-style versioned configuration files.
However we have an existing issue to fix before this can happen https://github.com/kubernetes/enhancements/issues/786
- [ ] --cloud-config string
* Help text: The path to the cloud provider configuration file. Empty string for no configuration file.
- [ ] --controller-start-interval duration
* Help text: Interval between starting controller managers
- [ ] --cloud-provider string
* The provider for cloud services. Empty string for no provider.
- [ ] --controller-start-interval duration
* Interval between starting controller managers.
- [ ] --controllers strings
* A list of controllers to enable. '*' enables all on-by-default controllers, 'foo' enables the controller named 'foo', '-foo' disables the controller named 'foo'.
**[Work In Progress] I am in the process of going through all the flags and updating this issue**
**Why is this needed**:
Refer the email for details: https://groups.google.com/forum/#!topic/kubernetes-wg-component-standard/W_5obNYw5DU | kind/feature,lifecycle/frozen,wg/component-standard | low | Major |
528,921,700 | go | x/tools/gopls: improve command-line help output | I installed `golang.org/x/tools/gopls@latest` and tried to look at its command-line tool options (rename, etc).
First I tried `-h`, since this is a typical way to make Go tools show usage:
```
$ gopls -h
Usage of gopls:
-debug string
Serve debug information on the supplied address
-listen string
address on which to listen for remote connections
-logfile string
filename to log to. if value is "auto", then logging to a default output file is enabled
-mode string
no effect
-ocagent string
The address of the ocagent, or off (default "off")
-port int
port on which to run gopls for debugging purposes
-profile.cpu string
write CPU profile to this file
-profile.mem string
write memory profile to this file
-profile.trace string
write trace log to this file
-remote string
*EXPERIMENTAL* - forward all commands to a remote lsp
-rpc.trace
Print the full rpc trace in lsp inspector format
-v Verbose output
```
So this shows the flags (for which command?), but not the actual commands. Next I tried `gopls help`:
```
$ gopls help
gopls: Unknown command help
The Go Language source tools.
Usage: gopls [flags] <command> [command-flags] [command-args]
Available commands are:
serve : run a server for Go code using the Language Server Protocol
bug : report a bug in gopls
check : show diagnostic results for the specified file
format : format the code according to the go standard
links : list links in a file
imports : updates import statements
query : answer queries about go source code
references : display selected identifier's references
rename : rename selected identifier
signature : display selected identifier's signature
fix : apply suggested fixes
symbols : display selected file's symbols
version : print the gopls version information
gopls flags are:
```
That works, but only accidentally ("Unknown command help"). Also note the trailing "gopls flags are:" followed by no flags.
Finally, I tried running `gopls rename -h` to see how one uses this tool:
```
$ gopls rename -h
Usage of rename:
-d display diffs instead of rewriting files
-w write result to (source) file instead of stdout
```
This does not provide enough information to actually use `gopls rename`.
We should improve this situation:
* `gopls -h` should print out the possible commands.
* After printing the commands, it should print the common flags (as well as some text explaining that these are flags that apply across all commands), and perhaps some text suggesting the user can run `gopls <command> -h` to find the flags for a particular command.
* Each command's `-h` output could say what the command actually does and how to use it, not just list the flags.
For bonus points:
* `gopls help` could be a synonym for `gopls -h/-help`, since that's a common paradigm for "sub-command"-style tools (see `go help` for example).
* The [command-line flags markdown page](https://github.com/golang/tools/blob/master/gopls/doc/command-line.md), linked from [the gopls user guide](https://github.com/golang/tools/blob/master/gopls/doc/user.md), could be fleshed out with a description of how to use the command-line interface. (Compare with the [guru user manual](http://golang.org/s/using-guru).) | gopls,Tools | low | Critical |
528,962,043 | opencv | DNN Torch import is missing several layers | ##### System information (version)
- OpenCV => master (4.2.x)
- Operating System / Platform => Linux 64 Bit
- Compiler => gcc9
##### Detailed description
I try to import a dnn model from torch, and several layers cannot be created.
The model is for deblurring images:
https://arxiv.org/abs/1612.02177
This is the code:
https://github.com/SeungjunNah/DeepDeblur_release
with links to the model-files:
https://drive.google.com/file/d/1Z8dV6KuubfOKj4ganEjxymhyMoXoydfo/view?usp=sharing
The missing torch layers are:
- PixelShuffle
- Copy
- AddConstant
- ParallelTable
- FlattenTable
- NarrowTable
- SelectTable
I think I got Copy and AddConstant simply implemented via custom layer (remap to opencv layers). I also tried PixelShuffle, I am not sure, if I got it right. But the table layers seem to be difficult with custom layers in opencv?
| feature,category: dnn | low | Major |
528,997,013 | terminal | Support resetting the colors via OSC 104, 110, 111... | <!--
๐จ๐จ๐จ๐จ๐จ๐จ๐จ๐จ๐จ๐จ
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
These are the counterparts of OSC 4, 10, 11 to reset the default color. (And continue the line with 117, 119 if [17, 19](https://github.com/microsoft/terminal/issues/3580#issuecomment-553975138) get implemented, etc.)
# Proposed technical implementation details (optional)
In VTE + GNOME Terminal we figured out the best is if the OSC 4, 10, 11 sequences have precedence over the UI / config file settings. That is, for each color slot, if its value is defined via OSC 4, 10, 11 then that one is used and the one in the settings is ignored. If a value hasn't been defined via OSC 4, 10, 11, or has been reset via OSC 104, 110, 111 then the value specified in the terminal emulator's settings is used. This way re-applying the same settings is an idempotent operation. (Previously the two sources were fighting with each other, both overwriting the value in the same slot. That way re-applying the user config (e.g. "altering" a color to the same value) would invalidate a previous OSC, which was bad.)
| Product-Conhost,Help Wanted,Area-VT,Issue-Task | low | Critical |
529,009,093 | go | x/net/http2: cannot create 'MaxConcurrentStreams' streams with a single ClientConn | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.3 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/wit/Library/Caches/go-build"
GOENV="/Users/wit/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/wit/gocode"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.3/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.3/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/mq/qzdh1j2n5fg3kylx9v7n79p40000gn/T/go-build653171154=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Attempt to create max concurrent streams with one client connection.
```go
package main
import (
"crypto/tls"
"fmt"
"net"
"net/http"
"net/http/httptest"
"strings"
"sync"
"time"
"golang.org/x/net/http2"
"golang.org/x/net/http2/h2c"
)
const maxConcurrentStreams = 10
func handlerFunc(delayChan chan struct{}) http.HandlerFunc {
return func(rw http.ResponseWriter, req *http.Request) {
defer req.Body.Close()
if delayChan != nil {
<-delayChan
}
rw.WriteHeader(204)
rw.Write([]byte("ok"))
}
}
func main() {
delayChan := make(chan struct{})
h2cServer := httptest.NewServer(
h2c.NewHandler(http.HandlerFunc(handlerFunc(delayChan)),
&http2.Server{
MaxConcurrentStreams: maxConcurrentStreams,
},
),
)
defer h2cServer.Close()
req, err := http.NewRequest("GET", "http://"+h2cServer.Listener.Addr().String(), strings.NewReader(""))
if err != nil {
panic(err)
}
h2Transport := &http2.Transport{
AllowHTTP: true,
DialTLS: func(netw, addr string, cfg *tls.Config) (net.Conn, error) {
return net.Dial(netw, addr)
},
}
conn, err := net.Dial("tcp", h2cServer.Listener.Addr().String())
if err != nil {
panic(err)
}
cc, err := h2Transport.NewClientConn(conn)
if err != nil {
panic(err)
}
var wg sync.WaitGroup
wg.Add(1)
go func() {
defer wg.Done()
wg.Add(maxConcurrentStreams-1)
for i := 0; i < maxConcurrentStreams-1; i++ {
go func(i int) {
defer wg.Done()
resp, err := cc.RoundTrip(req)
fmt.Println("request:", i, resp, err)
}(i)
}
}()
time.Sleep(50 * time.Millisecond)
wg.Add(1)
go func() {
defer wg.Done()
resp, err := cc.RoundTrip(req)
fmt.Println("max streams request:", resp, err)
}()
close(delayChan)
wg.Wait()
}
```
### What did you expect to see?
Expected to see the last `RoundTrip` request succeed.
### What did you see instead?
```
$ go run go_http2_max_streams.go
max streams request: <nil> http2: client conn not usable
request: 6 &{204 No Content 204 HTTP/2.0 2 0 map[Date:[Wed, 27 Nov 2019 00:08:17 GMT]] {0xc00008ef30} 0 [] false false map[] 0xc0000da000 <nil>} <nil>
request: 8 &{204 No Content 204 HTTP/2.0 2 0 map[Date:[Wed, 27 Nov 2019 00:08:17 GMT]] {0xc00008ef30} 0 [] false false map[] 0xc0000da000 <nil>} <nil>
request: 1 &{204 No Content 204 HTTP/2.0 2 0 map[Date:[Wed, 27 Nov 2019 00:08:17 GMT]] {0xc00008ef30} 0 [] false false map[] 0xc0000da000 <nil>} <nil>
request: 5 &{204 No Content 204 HTTP/2.0 2 0 map[Date:[Wed, 27 Nov 2019 00:08:17 GMT]] {0xc00008ef30} 0 [] false false map[] 0xc0000da000 <nil>} <nil>
request: 7 &{204 No Content 204 HTTP/2.0 2 0 map[Date:[Wed, 27 Nov 2019 00:08:17 GMT]] {0xc00008ef30} 0 [] false false map[] 0xc0000da000 <nil>} <nil>
request: 4 &{204 No Content 204 HTTP/2.0 2 0 map[Date:[Wed, 27 Nov 2019 00:08:17 GMT]] {0xc00008ef30} 0 [] false false map[] 0xc0000da000 <nil>} <nil>
request: 2 &{204 No Content 204 HTTP/2.0 2 0 map[Date:[Wed, 27 Nov 2019 00:08:17 GMT]] {0xc00008ef30} 0 [] false false map[] 0xc0000da000 <nil>} <nil>
request: 0 &{204 No Content 204 HTTP/2.0 2 0 map[Date:[Wed, 27 Nov 2019 00:08:17 GMT]] {0xc00008ef30} 0 [] false false map[] 0xc0000da000 <nil>} <nil>
request: 3 &{204 No Content 204 HTTP/2.0 2 0 map[Date:[Wed, 27 Nov 2019 00:08:17 GMT]] {0xc00008ef30} 0 [] false false map[] 0xc0000da000 <nil>} <nil>
```
The issue appears to be at https://github.com/golang/net/blob/master/http2/transport.go#L735:
```go
maxConcurrentOkay = int64(len(cc.streams)+1) < int64(cc.maxConcurrentStreams)
```
where the test is to see whether an additional stream can be handled, but the condition should be `<=` instead of `<`. | NeedsInvestigation | low | Critical |
529,012,058 | pytorch | Torchscript Precision Issue with PyTorch/vision pretrained model inception v3 | ## ๐ Bug
This bug was referenced here https://github.com/pytorch/pytorch/issues/12719 but it doesn't seem fully resolved. For example, if you set the batch size >= 12, trace gives a tracer warning indicating precision issues.
## To Reproduce
Steps to reproduce the behavior:
```python
import torch
import torchvision.models as models
dummy_input = torch.Tensor(torch.randn((12, 3, 299, 299))).cuda()
inception_model = models.inception_v3(pretrained=True).cuda()
inception_model = inception_model.eval()
torch.jit.trace(inception_model, dummy_input)
```
```
/usr/local/lib/python3.6/dist-packages/torch/jit/__init__.py:1007: TracerWarning: Output nr 1. of the traced function does not match the corresponding output of the Python function. Detailed error:
Not within tolerance rtol=1e-05 atol=1e-05 at input[8, 146] (2.730384349822998 vs. 2.7308413982391357) and 8991 other locations (74.00%)
check_tolerance, _force_outplace, True, _module_class)
````
## Expected behavior
Matching numbers within reasonable precision.
## Environment
- PyTorch Version: 1.3.1
- OS: Ubuntu 18.04.3 LTS
- How you installed PyTorch : pip
- Build command you used (if compiling from source):
- Python version: 3.6
- CUDA/cuDNN version: CUDA 10.0.130, cuDNN /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.3
- GPU models and configuration: GPU 0: GeForce GTX 1080 Ti
Versions of relevant libraries:
[pip3] efficientnet-pytorch==0.4.0
[pip3] numpy==1.13.3
[pip3] torch==1.3.1
[pip3] torchfile==0.1.0
[pip3] torchnet==0.0.4
[pip3] torchvision==0.4.2
[conda] Could not collect
cc @suo | oncall: jit,triaged | low | Critical |
529,013,752 | TypeScript | bug `createTemplateMiddle()` and `createTemplateTail()` do not work with escaped chars | See https://github.com/microsoft/TypeScript/commit/a74f109f95a43c70311ee551dd1c4a9b42fbd4f5#r36149273
When creating tagged template literals programmatically one can pass in cooked and raw text.
The raw text is then checked by rescanning it and checking it is the same as the cooked text.
There is a bug in this check. After an expression the next part will start with a closing brace `}`, which triggers the scanner to then search to the next `${` or to the end of the the backticked string. But the current code is looking for a `]` rather than a `}`.
**Search Terms:**
rawText, tagged template literals, createTemplateMiddle, getCookedText
**Code**
```ts
const ts = require('typescript');
ts.createTemplateMiddle('a\nb', 'a\\nb');
```
**Expected behavior:**
Should not throw
**Actual behavior:**
```
Thrown:
Error: Debug Failure. Invalid raw text
at createTemplateLiteralLikeNode (/Users/pete/dev/angular/angular/node_modules/typescript/lib/typescript.js:64078:33)
at Object.createTemplateMiddle (/Users/pete/dev/angular/angular/node_modules/typescript/lib/typescript.js:64092:20)
```
| Bug | low | Critical |
529,020,464 | go | cmd/go/internal/modload: refactor error handling | A number of exported functions in `modload` call `base.Errorf` and `base.Fatalf`. Instead of printing to stderr and exiting, functions in this package should return errors (ideally structured errors). This will make commands with non-standard error handling like `go list -e`, `go build -n`, and `go mod download -json` easier to implement. | NeedsFix,GoCommand,modules | low | Critical |
529,045,645 | godot | Input system breaks if the game window loses focus when there's a mouse button down | Hello. I've already had this happening when I was using 3.1 mono on Windows 7 x64, I've tried 3.1.1 and 3.2 beta2 and it's still happening.
I'll copy/paste the details from a post I made on Reddit to ask if anyone else was experiencing this.
It does happen even with an empty project, so it shouldn't be my code. Also, when I go back to the game, the window's bar doesn't work anymore, can't drag it and its buttons don't work. They start working again if I click somewhere else (outside of the game window). Then they stop working again if I click anything within the game window, and notifications like mouse_entered and mouse_exited don't work anymore if I press a mouse button and release it after moving it.
It only happens with Godot, other programs work fine, and I've tried it on different PCs and it does that on all them. There's a few issues on GitHub about input actions not being released when the window loses focus, and the workaround for that is to check for them and release them via code. But even doing that doesn't fix this problem, the only fix for it is to restart the game.
To reproduce: run any project, even a new empty one, hold mouse button down anywhere on the game window, alt-tab, go back to the game window either by alt-tabbing or by clicking on it. Click anywhere and the window's bar will stop working, if there's any control node in the project they won't be working anymore. | bug,platform:windows,topic:core,confirmed,topic:input | medium | Major |
529,056,152 | youtube-dl | Be able to download metadata from DRM protected video | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.11.22. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a feature request
- [x] I've verified that I'm running youtube-dl version **2019.11.22**
- [x] I've searched the bugtracker for similar feature requests including closed ones
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->
Currently when downloading metadata of a DRM protected video with options like '--write-thumbnail', '--write-info-json' and '--write-description', youtube-dl will show the error 'ERROR: This video is DRM protected' and exit. Even when using the option '--skip-download'.
However, in some situations it would be useful to be able to download video metadata even though the video is protected by DRM.
Here's an example of the current situation:
```
$ youtube-dl --skip-download --write-thumbnail --write-description "https://www.npostart.nl/binnenstebuiten/20-11-2019/KN_1710420"
[npo] KN_1710420: Downloading token
[npo] KN_1710420: Downloading player JSON
[npo] KN_1710420: Downloading hls profile JSON
[npo] KN_1710420: Downloading dash-widevine profile JSON
[npo] KN_1710420: Downloading dash-playready profile JSON
[npo] KN_1710420: Downloading smooth profile JSON
ERROR: This video is DRM protected.
```
### Relevant options
Using the following options with a DRM protected video will produce the same output as the example above:
- --write-description
- --write-info-json
- --write-annotations
- --write-thumbnail
- --write-all-thumbnails
- --get-url
- --get-title
- --get-id
- --get-thumbnail
- --get-description
- --get-duration
- --get-filename
- --get-format
- --dump-json
- --dump-single-json
- --print-json
- --list-formats
- --write-sub
- --all-subs
- --list-subs
### Solution
There are two cases when downloading metadata from a DRM protected video:
- not using the option '--skip-download'
In this case the error about not being able to download the video due to DRM could be downgraded to a warning, with youtube-dl proceeding to download metadata. However, it may be a good idea to keep the current situation to make it very clear that the video cannot be downloaded.
- using the option '--skip-download'
In this case the error about not being able to download the video due to DRM should not stop the metadata from being downloaded. The error may be downgraded to a warning or not shown at all. | request | low | Critical |
529,064,241 | kubernetes | PV controller races with itself when you prebind a PVC | <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
Offshoot of https://github.com/kubernetes/kubernetes/issues/85320#issuecomment-558784705. The impact is that a prebound PVC could take up to 30 seconds to bind.
**What you expected to happen**:
Ideally, the PV controller shouldn't intentionally race with itself.
**How to reproduce it (as minimally and precisely as possible)**:
Create a PVC that is prebound to a PV. Sometimes it will take a long time to finally bind. The VolumeBinding integration test was often flaking due to this.
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`):
- Cloud provider or hardware configuration:
- OS (e.g: `cat /etc/os-release`):
- Kernel (e.g. `uname -a`):
- Install tools:
- Network plugin and version (if this is a network-related bug):
- Others:
| kind/bug,sig/storage,lifecycle/frozen | low | Critical |
529,065,891 | kubernetes | Do we still need PV controller resync? | <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
Semi related to https://github.com/kubernetes/kubernetes/issues/85659. The PV controller resync of 15 seconds ends up hiding problems in the PV controller. The resync also causes a lot of churn, which can be problematic if you have a lot of PVs in your cluster.
**What you expected to happen**:
Is it worth trying out some experiments/tests to get rid of the frequent resyncs and fix the resulting bugs that come out of it?
**How to reproduce it (as minimally and precisely as possible)**:
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`):
- Cloud provider or hardware configuration:
- OS (e.g: `cat /etc/os-release`):
- Kernel (e.g. `uname -a`):
- Install tools:
- Network plugin and version (if this is a network-related bug):
- Others:
| kind/bug,sig/storage,lifecycle/frozen | low | Critical |
529,092,591 | flutter | [camera] Allow custom resolution and aspect ratio | there are only 5 enum selections.and we can not customize the size of picture which i take.
i want to get a pic with low's 320*240 (4:3) and high quality.but i can not make it. Why the resolution and aspect ratio should be bound together, how to set them separately and take photos of various quality with specific aspect ratio
| c: new feature,customer: crowd,p: camera,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | medium | Critical |
529,106,605 | go | x/arch/x86/x86asm: missing Control-flow Enforcement instructions; e.g. ENDBR64 | As a follow-up of #18665, instructions related to *Control-flow Enforcement* are currently not recognized by the `x/arch/x86` disassembler.
Example link at play.golang.org: https://play.golang.org/p/xz6V8cSREWF
```go
package main
import (
"fmt"
"golang.org/x/arch/x86/x86asm"
)
func main() {
// ref: Section 7.1: ENDBR64 of "Control-flow Enforcement Technology Specification"
//
// https://software.intel.com/sites/default/files/managed/4d/2a/control-flow-enforcement-technology-preview.pdf
text := []byte{0xF3, 0x0F, 0x1E, 0xFA} // endbr64
inst, err := x86asm.Decode(text[:], 64)
if err != nil {
panic(err)
}
fmt.Println("inst:", inst)
// Expected: ENDBR64
// Got: REP Op(0)
}
```
At rev golang/arch@368ea8f32ffff9e0bf2bf9b8c7f6dc5c2f5f6cfd, the `ENDBR64` instruction is incorrectly recognized as `REP Op(0)` without reporting any error from decode. The `ENDBR64` instruction has the byte sequence `0xF3, 0x0F, 0x1E, 0xFA` and was introduced as part of the *Control-flow Enforcement Technology Specification*: https://software.intel.com/sites/default/files/managed/4d/2a/control-flow-enforcement-technology-preview.pdf
/cc: @rsc @minux | NeedsInvestigation | low | Critical |
529,130,737 | go | path/filepath: Walk walks through the same dir over and over again on build with gomobile iOS | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/macuser/Library/Caches/go-build"
GOENV="/Users/macuser/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/macuser/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Library/Golang/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Library/Golang/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/macuser/0chain/zboxcli/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/5v/kc5tdz2506gf8tgp_kyk2kx00000gp/T/go-build973215397=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
Created a go library that uses filepath.Walk(). Works as expected with go application build using this library. The same library created using "gomobile bind -target=ios", with a Mac app, walks through the same dir over and over again and application crashes due to too much heap usage.
### What did you expect to see?
Mac app hould work similar to go application.
### What did you see instead?
Recursive call and application crash. I works well with gomobile 1.12.7
| NeedsInvestigation,mobile | medium | Critical |
529,133,152 | go | x/build/cmd/gerritbot: sometimes fails to close PR after its imported CL is submitted | We should investigate why gerritbot didn't close a PR that was imported into Gerrit as a CL and submitted.
- PR #35751
- imported as [CL 208318](https://golang.org/cl/208318)
See https://github.com/golang/go/pull/35751#issuecomment-558859722 for more details.
Thanks @odeke-em for noticing and reporting. | help wanted,Builders,NeedsFix | low | Minor |
529,159,572 | youtube-dl | Site Request: EPTV www.europarl.europa.eu/ep-live/ | ## Checklist
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version 2019.11.22
- [ ] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
- Single video: https://www.europarl.europa.eu/ep-live/en/plenary/video?debate=1574790135809
## Description
Those are live transmissions/recordings of european union parliament plenary sessions, so I guess it would be great to have, especially since it has links to specific discussions.
Plugin description and page source mentions QuickTime and Windows Media Player plugin.
https://web.archive.org/web/20170210185817/https://www.europarl.europa.eu/ep-live/en/help | site-support-request | low | Critical |
529,181,238 | flutter | Build aar fails if one plugin depends on another plugin in gradle. | I have a project structured like this:
project
| - pluginA
| - some directory
| - pluginB
pluginA depends on pluginB.
When run flutter build aar in project directory, I got this:
<details>
<summary>error</summary>
```
[ +13 ms] Gradle task assembleAarDebug failed with exit code 1
[ +58 ms] FAILURE: Build failed with an exception.
[ ] * Where:
[ ] Script 'flutter/packages/flutter_tools/gradle/flutter.gradle' line: 929
[ ] * What went wrong:
[ ] Execution failed for task ':flutter:buildPluginDebugMethodChannel'.
[ ] > Process 'command 'flutter/bin/flutter'' finished with non-zero exit value 1
[ ] * Try:
[ ] Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log
output. Run with --scan to get full insights.
[ ] * Get more help at https://help.gradle.org
[ +1 ms] Deprecated Gradle features were used in this build, making it incompatible with Gradle 5.0.
[ ] See https://docs.gradle.org/4.6/userguide/command_line_interface.html#sec:command_line_warnings
[ ] BUILD FAILED in 24s
[ +397 ms] Running Gradle task 'assembleAarDebug'... (completed in 25.2s)
[ +3 ms] "flutter aar" took 28,766ms.
Gradle task assembleAarDebug failed with exit code 1
#0 throwToolExit (package:flutter_tools/src/base/common.dart:28:3)
#1 buildGradleAar (package:flutter_tools/src/android/gradle.dart:577:5)
<asynchronous suspension>
#2 AarBuilderImpl.build (package:flutter_tools/src/android/aar.dart:54:11)
<asynchronous suspension>
#3 BuildAarCommand.runCommand (package:flutter_tools/src/commands/build_aar.dart:77:22)
<asynchronous suspension>
#4 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:490:18)
<asynchronous suspension>
#5 FlutterCommand.run.<anonymous closure> (package:flutter_tools/src/runner/flutter_command.dart:407:33)
<asynchronous suspension>
#6 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:29)
<asynchronous suspension>
#7 _rootRun (dart:async/zone.dart:1124:13)
#8 _CustomZone.run (dart:async/zone.dart:1021:19)
#9 _runZoned (dart:async/zone.dart:1516:10)
#10 runZoned (dart:async/zone.dart:1463:12)
#11 AppContext.run (package:flutter_tools/src/base/context.dart:153:18)
<asynchronous suspension>
#12 FlutterCommand.run (package:flutter_tools/src/runner/flutter_command.dart:397:20)
#13 CommandRunner.runCommand (package:args/command_runner.dart:197:27)
<asynchronous suspension>
#14 FlutterCommandRunner.runCommand.<anonymous closure>
(package:flutter_tools/src/runner/flutter_command_runner.dart:402:21)
<asynchronous suspension>
#15 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:29)
<asynchronous suspension>
#16 _rootRun (dart:async/zone.dart:1124:13)
#17 _CustomZone.run (dart:async/zone.dart:1021:19)
#18 _runZoned (dart:async/zone.dart:1516:10)
#19 runZoned (dart:async/zone.dart:1463:12)
#20 AppContext.run (package:flutter_tools/src/base/context.dart:153:18)
<asynchronous suspension>
#21 FlutterCommandRunner.runCommand (package:flutter_tools/src/runner/flutter_command_runner.dart:356:19)
<asynchronous suspension>
#22 CommandRunner.run.<anonymous closure> (package:args/command_runner.dart:112:25)
#23 new Future.sync (dart:async/future.dart:224:31)
#24 CommandRunner.run (package:args/command_runner.dart:112:14)
#25 FlutterCommandRunner.run (package:flutter_tools/src/runner/flutter_command_runner.dart:242:18)
#26 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:63:22)
<asynchronous suspension>
#27 _rootRun (dart:async/zone.dart:1124:13)
#28 _CustomZone.run (dart:async/zone.dart:1021:19)
#29 _runZoned (dart:async/zone.dart:1516:10)
#30 runZoned (dart:async/zone.dart:1500:12)
#31 run.<anonymous closure> (package:flutter_tools/runner.dart:61:18)
<asynchronous suspension>
#32 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:29)
<asynchronous suspension>
#33 _rootRun (dart:async/zone.dart:1124:13)
#34 _CustomZone.run (dart:async/zone.dart:1021:19)
#35 _runZoned (dart:async/zone.dart:1516:10)
#36 runZoned (dart:async/zone.dart:1463:12)
#37 AppContext.run (package:flutter_tools/src/base/context.dart:153:18)
<asynchronous suspension>
#38 runInContext (package:flutter_tools/src/context_runner.dart:59:24)
<asynchronous suspension>
#39 run (package:flutter_tools/runner.dart:50:10)
#40 main (package:flutter_tools/executable.dart:65:9)
<asynchronous suspension>
#41 main (file:///Users/gt/tools/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3)
#42 _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:303:32)
#43 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
```
</details>
After doing some research, I found out the following informations:
- the project causing build failure is pluginA
- flutter build aar is recursively executed under every plugin project
- every plugin project seems to be treated as a root project
- real error is Project with path ':pluginB' could not be found in root project 'pluginA'
flutter doctor -v
```
[โ] Flutter (Channel unknown, v1.9.1+hotfix.6, on Mac OS X 10.14.6 18G1012, locale zh-Hans-CN)
โข Flutter version 1.9.1+hotfix.6 at /Users/gt/tools/flutter
โข Framework revision 68587a0916 (2 months ago), 2019-09-13 19:46:58 -0700
โข Engine revision b863200c37
โข Dart version 2.5.0
[โ] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
โข Android SDK at /Users/gt/Library/Android/sdk
โข Android NDK location not configured (optional; useful for native profiling support)
โข Platform android-28, build-tools 28.0.3
โข ANDROID_HOME = /Users/gt/Library/Android/sdk
โข Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
โข Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
โข All Android licenses accepted.
[โ] Xcode - develop for iOS and macOS
โ Xcode installation is incomplete; a full installation is necessary for iOS development.
Download at: https://developer.apple.com/xcode/download/
Or install Xcode via the App Store.
Once installed, run:
sudo xcode-select --switch /Applications/Xcode.app/Contents/Developer
โ CocoaPods not installed.
CocoaPods is used to retrieve the iOS and macOS platform side's plugin code that responds to your plugin
usage on the Dart side.
Without CocoaPods, plugins will not work on iOS or macOS.
For more info, see https://flutter.dev/platform-plugins
To install:
sudo gem install cocoapods
[โ] Android Studio (version 3.5)
โข Android Studio at /Applications/Android Studio.app/Contents
โข Flutter plugin version 40.0.2
โข Dart plugin version 191.8423
โข Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[โ] VS Code (version 1.40.2)
โข VS Code at /Applications/Visual Studio Code.app/Contents
โข Flutter extension version 3.6.0
[โ] Connected device (1 available)
โข MIX 2 โข 6ba49c5b โข android-arm64 โข Android 8.0.0 (API 26)
! Doctor found issues in 1 category.
``` | c: crash,platform-android,tool,t: gradle,P2,team-android,triaged-android | low | Critical |
529,182,953 | pytorch | Adding a function to change the process_group in DistributedDataParallel | ## ๐ Feature
Adding a function to change the `process_group `in `DistributedDataParallel`
## Motivation
In current Pytorch, once `DistributedDataParallel `is initialized, `process_group ` will be fixed if I understand correctly. But sometimes different `process_groups ` might be in need for different iterations.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 | oncall: distributed,triaged | low | Minor |
529,191,810 | terminal | Hebrew char taf ืช (accessible by comma key on hebrew keyboard) appears in settings | # A quick note:
First off, loving v. 0.7. Secondly, this is a ridiculously minor bug that I haven't been able to even reproduce on my own machine. Don't really bother fixing it, I guess. But it's still undefined behavior, and I thought you might want to know that something like this can happen.
# Environment
```none
Windows: Microsoft Windows [Version 10.0.18362.476]
Windows Terminal version (if applicable): 0.7.3291.0
Any other software?
```
# Steps to reproduce
Not sure, haven't been able to reproduce it myself.
# Expected behavior
Should be Ctrl+comma displayed, IIRC.
# Actual behavior
A quick note: the character here, the hebrew letter taf - ืช, is comma on the hebrew keyboard
| Help Wanted,Issue-Bug,Area-UserInterface,Product-Terminal,Priority-3 | low | Critical |
529,208,261 | kubernetes | Refactor kubelet with node status plugin and registry | <!-- Please only use this template for submitting enhancement requests -->
**What would you like to be added**:
Part of https://github.com/kubernetes/kubernetes/issues/84681
Add node status `Plugin` and `Registry` for node status functions registration.
```go
// Plugin is the node status plugin which update the node's
// status.
type Plugin interface {
// Name is the name of the plugin.
Name() string
// Update updates the status of the node.
Update(node *v1.Node) error
}
```
Plugin registry is responsible for storing plugins and preserving the executing order.
```go
var (
pluginsOrdering = []string{"NodeAddress"}
)
// Registry preserves the invoking order of node status plugin.
type Registry struct {
plugins map[string]Plugin
}
// NewRegistry returns a node status plugin registry.
func NewRegistry() *Registry {
return &Registry{
plugins: map[string]Plugin{},
}
}
// Register appends a plugin to the registry.
func (r *Registry) Register(plugin Plugin) {
r.plugins[plugin.Name()] = plugin
}
// UpdateNode updates node.
func (r *Registry) UpdateNode(node *v1.Node) {
for _, pluginName := range pluginsOrdering {
plugin, ok := r.plugins[pluginName]
if !ok {
continue
}
klog.V(5).Infof("Setting node status with plugin %s", pluginName)
if err := plugin.Update(node); err != nil {
klog.Errorf("Failed to set some node status fields: %s", err.Error())
}
}
}
```
**Why is this needed**:
Some components of the kubelet depend on the `GetNode` function of kubelet, and `GetNode` function has a complicated process which finally depends on the components of kubelet and causes circular dependency.
With the node status plugin and registry, we could create the node status registry before the creation of the kubelet and register plugins after the initialization.
After we create the node status registry and convert all the node status functions to plugins, we could make a new struct to provide the `GetNode` function and start to break the dependency here
https://github.com/kubernetes/kubernetes/blob/ee81b306815268cfbc01501f9dae12ce38974405/pkg/kubelet/kubelet.go#L559-L562
The process of migration wouldn't break the code or any unit tests and could be done by trunks.
**TODOs**:
+ [ ] Initialize the node status plugin interface https://github.com/kubernetes/kubernetes/pull/85665
/sig node | sig/node,kind/feature,lifecycle/frozen | low | Critical |
529,213,260 | pytorch | LibTorch, Error in 'xxx': free(): invalid pointer | ## ๐ Bug
Hi, maybe I found a bug in LibTorch while run codes in CentOS, the codes are very simplify. I have try it in 2 CentOS Machines and 1 Ubuntu Machine, Ubuntu Machine can run it normally, but all of the CentOS Machines run it like follow outputs.
## To Reproduce
Steps to reproduce the behavior:
1. download libtorch and unzip
2. compile the cpp file
3. run
Here are the codes:
```c++
#include<iostream>
#include<torch/torch.h>
#include <torch/script.h>
int main() {
torch::Tensor a = torch::ones({2,4});
std::cout << a << std::endl;
return 0;
}
```
Here is the CMakeList:
```cmake
cmake_minimum_required(VERSION 3.0 FATAL_ERROR)
project(tr)
find_package(Torch REQUIRED)
aux_source_directory(. SRC_LIST)
add_executable(test ${SRC_LIST})
set(CMAKE_CXX_STANDARD 11)
target_link_libraries(test "${TORCH_LIBRARIES}")
set_property(TARGET test PROPERTY CXX_STANDARD 11)
```
Here is the output:
```
1 1 1 1
1 1 1 1
[ Variable[CPUFloatType]{2,4} ]
*** Error in `./test': free(): invalid pointer: 0x00007f040f871090 ***
======= Backtrace: =========
/lib64/libc.so.6(+0x81679)[0x7f04022b3679]
./test(_ZN9__gnu_cxx13new_allocatorIPNSt8__detail15_Hash_node_baseEE10deallocateEPS3_m+0x20)[0x41fd0e]
./test(_ZNSt10_HashtableISsSt4pairIKSsSsESaIS2_ENSt8__detail10_Select1stESt8equal_toISsESt4hashISsENS4_18_Mod_range_hashingENS4_20_Default_ranged_hashENS4_20_Prime_rehash_policyENS4_17_Hashtable_traitsILb1ELb0ELb1EEEE21_M_deallocate_bucketsEPPNS4_15_Hash_node_baseEm+0x49)[0x41f20f]
./test(_ZNSt10_HashtableISsSt4pairIKSsSsESaIS2_ENSt8__detail10_Select1stESt8equal_toISsESt4hashISsENS4_18_Mod_range_hashingENS4_20_Default_ranged_hashENS4_20_Prime_rehash_policyENS4_17_Hashtable_traitsILb1ELb0ELb1EEEED1Ev+0x36)[0x41df10]
/lib64/libc.so.6(__cxa_finalize+0x9a)[0x7f040226c00a]
/home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libtorch.so(+0x9fa9d3)[0x7f040367e9d3]
======= Memory map: ========
00400000-00429000 r-xp 00000000 fd:02 186000054 /home/yyuser/nlp/codes/bd-nlp/tr/alg-service/build/test
00628000-00629000 r--p 00028000 fd:02 186000054 /home/yyuser/nlp/codes/bd-nlp/tr/alg-service/build/test
00629000-0062a000 rw-p 00029000 fd:02 186000054 /home/yyuser/nlp/codes/bd-nlp/tr/alg-service/build/test
021b1000-02aee000 rw-p 00000000 00:00 0 [heap]
7f03fc000000-7f03fc021000 rw-p 00000000 00:00 0
7f03fc021000-7f0400000000 ---p 00000000 00:00 0
7f04018fa000-7f04019fb000 r-xp 00000000 fd:02 1548 /usr/lib64/libm-2.17.so
7f04019fb000-7f0401bfa000 ---p 00101000 fd:02 1548 /usr/lib64/libm-2.17.so
7f0401bfa000-7f0401bfb000 r--p 00100000 fd:02 1548 /usr/lib64/libm-2.17.so
7f0401bfb000-7f0401bfc000 rw-p 00101000 fd:02 1548 /usr/lib64/libm-2.17.so
7f0401bfc000-7f0401bfe000 r-xp 00000000 fd:02 1546 /usr/lib64/libdl-2.17.so
7f0401bfe000-7f0401dfe000 ---p 00002000 fd:02 1546 /usr/lib64/libdl-2.17.so
7f0401dfe000-7f0401dff000 r--p 00002000 fd:02 1546 /usr/lib64/libdl-2.17.so
7f0401dff000-7f0401e00000 rw-p 00003000 fd:02 1546 /usr/lib64/libdl-2.17.so
7f0401e00000-7f0401e07000 r-xp 00000000 fd:02 1570 /usr/lib64/librt-2.17.so
7f0401e07000-7f0402006000 ---p 00007000 fd:02 1570 /usr/lib64/librt-2.17.so
7f0402006000-7f0402007000 r--p 00006000 fd:02 1570 /usr/lib64/librt-2.17.so
7f0402007000-7f0402008000 rw-p 00007000 fd:02 1570 /usr/lib64/librt-2.17.so
7f0402008000-7f040202d000 r-xp 00000000 fd:02 352611484 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libgomp-7c85b1e2.so.1
7f040202d000-7f040222c000 ---p 00025000 fd:02 352611484 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libgomp-7c85b1e2.so.1
7f040222c000-7f040222d000 r--p 00024000 fd:02 352611484 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libgomp-7c85b1e2.so.1
7f040222d000-7f0402232000 rw-p 00025000 fd:02 352611484 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libgomp-7c85b1e2.so.1
7f0402232000-7f04023f5000 r-xp 00000000 fd:02 1540 /usr/lib64/libc-2.17.so
7f04023f5000-7f04025f5000 ---p 001c3000 fd:02 1540 /usr/lib64/libc-2.17.so
7f04025f5000-7f04025f9000 r--p 001c3000 fd:02 1540 /usr/lib64/libc-2.17.so
7f04025f9000-7f04025fb000 rw-p 001c7000 fd:02 1540 /usr/lib64/libc-2.17.so
7f04025fb000-7f0402600000 rw-p 00000000 00:00 0
7f0402600000-7f0402615000 r-xp 00000000 fd:02 1311741 /usr/lib64/libgcc_s-4.8.5-20150702.so.1
7f0402615000-7f0402814000 ---p 00015000 fd:02 1311741 /usr/lib64/libgcc_s-4.8.5-20150702.so.1
7f0402814000-7f0402815000 r--p 00014000 fd:02 1311741 /usr/lib64/libgcc_s-4.8.5-20150702.so.1
7f0402815000-7f0402816000 rw-p 00015000 fd:02 1311741 /usr/lib64/libgcc_s-4.8.5-20150702.so.1
7f0402816000-7f040282d000 r-xp 00000000 fd:02 1566 /usr/lib64/libpthread-2.17.so
7f040282d000-7f0402a2c000 ---p 00017000 fd:02 1566 /usr/lib64/libpthread-2.17.so
7f0402a2c000-7f0402a2d000 r--p 00016000 fd:02 1566 /usr/lib64/libpthread-2.17.so
7f0402a2d000-7f0402a2e000 rw-p 00017000 fd:02 1566 /usr/lib64/libpthread-2.17.so
7f0402a2e000-7f0402a32000 rw-p 00000000 00:00 0
7f0402a32000-7f0402a77000 r-xp 00000000 fd:02 352611503 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libc10.so
7f0402a77000-7f0402c77000 ---p 00045000 fd:02 352611503 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libc10.so
7f0402c77000-7f0402c78000 r--p 00045000 fd:02 352611503 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libc10.so
7f0402c78000-7f0402c79000 rw-p 00046000 fd:02 352611503 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libc10.so
7f0402c79000-7f0402c7a000 rw-p 00000000 00:00 0
7f0402c7a000-7f0402c84000 rw-p 0005f000 fd:02 352611503 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libc10.so
7f0402c84000-7f040f47f000 r-xp 00000000 fd:02 352611487 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libtorch.so
7f040f47f000-7f040f67f000 ---p 0c7fb000 fd:02 352611487 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libtorch.so
7f040f67f000-7f040f75d000 r--p 0c7fb000 fd:02 352611487 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libtorch.so
7f040f75d000-7f040f854000 rw-p 0c8d9000 fd:02 352611487 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libtorch.so
7f040f854000-7f040f8a6000 rw-p 00000000 00:00 0
7f040f8a6000-7f040fb5e000 rw-p 0db6f000 fd:02 352611487 /home/yyuser/nlp/codes/bd-nlp/libtorch/lib/libtorch.so
7f040fb5e000-7f040fb80000 r-xp 00000000 fd:02 1533 /usr/lib64/ld-2.17.so
7f040fbe9000-7f040fbff000 rw-p 00000000 00:00 0
7f040fbff000-7f040fca1000 r--p 00000000 fd:02 9122949 /usr/lib/libstdc++.so.6.0.26
7f040fca1000-7f040fd20000 r-xp 000a2000 fd:02 9122949 /usr/lib/libstdc++.so.6.0.26
7f040fd20000-7f040fd61000 r--p 00121000 fd:02 9122949 /usr/lib/libstdc++.so.6.0.26[1] 14117 abort ./test
```
## Environment
- PyTorch Version (e.g., 1.0): 1.3
- OS (e.g., Linux): CentOS Linux release 7.7.1908 (Core) and CentOS Linux release 7.6.1810 (Core)
- How you installed PyTorch (`conda`, `pip`, source): LibTorch(Pre-cxx11 ABI)
- CUDA/cuDNN version: no GPU
- LibTorch download url: [https://download.pytorch.org/libtorch/cpu/libtorch-shared-with-deps-1.3.1%2Bcpu.zip](https://download.pytorch.org/libtorch/cpu/libtorch-shared-with-deps-1.3.1%2Bcpu.zip)
cc @ezyang @gchanan @zou3519 @jerryzh168 @yf225 | needs reproduction,module: cpp,triaged | low | Critical |
529,215,642 | go | cmd/cover: support -mod and other build flags | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes, it does
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/dionysius/.cache/go-build"
GOENV="/home/dionysius/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/dionysius/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/lib/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build322712138=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
GO_PATH/~/go/pkg/mod/ dir is empty
<pre>
$go tool cover -html=../coverage.cov -o ../coverage.html
</pre>
### What did you expect to see?
After running the cover command GO_PATH/~/go/pkg/mod/ dir is still empty
### What did you see instead?
After running the cover command GO_PATH/~/go/pkg/mod/ dir is not empty
| NeedsFix,modules | low | Critical |
529,216,985 | terminal | Pane split vertically is different on non-English keyboard layouts | I'm using an English/US Windows 10 Pro 18362 with Danish keyboard layout. And the short cut for pane split vertically is Alt + Shift + "+"
| Issue-Docs,Needs-Tag-Fix | low | Minor |
529,254,174 | rust | thread 'rustc' panicked at 'called `Result::unwrap()` on an `Err` value: DistinctSources(DistinctSources | Compiler panics. Debugging info attached. I would expect the compiler not to crash and print an error.
[out.txt](https://github.com/rust-lang/rust/files/3896340/out.txt)
| I-ICE,E-needs-test,T-compiler,C-bug | medium | Critical |
529,258,308 | bitcoin | rfc: store PSBTs in wallet | Now that #16944 has landed the GUI can create a PSBT and put it on the clipboard. The user can then use this with e.g. [HWI](https://github.com/bitcoin-core/HWI):
```
hwi --fingerprint=00000000 signtx
```
But if something goes wrong and clipboard loses the PSBT, they have to start over.
#17509 adds support saving the PSBT to disk. Currently it only uses binary format, but it's easy to add base64 too, as @gwillen did in #16954. Problem then is: if the user chooses the wrong format, they have to create the transaction all over again.
I propose that we store PSBTs in the wallet. They would show up in the transaction tab with some icon to indicate that they're incomplete. The user can copy them to clipboard or save to disk whenever they like. It should also be possible to delete them.
When a user loads a PSBT (e.g. via #17509) we should match it against what's in the wallet, and automagically join it. When a PSBT is complete it can be broadcast, deleted from the wallet, replaced by the regular transaction. All these steps should probably prompt for permission.
Slightly more advanced: PSBTs could keep coins locked by default (which incidentally creates a convenient way to persist locked coins, though there's other was to do that).
This is probably most useful for the GUI, but we could also support this with a few new RPC methods like `listwalletpsbts` (bash autocompletion ftw #17289). This also saves applications like [Specter](https://github.com/cryptoadvance/specter-desktop) (@stepansnigirev) and [Junction](https://github.com/justinmoon/junction) (@justinmoon) from having to build their own pseudo-wallet, when dealing with air gapped wallets. | Feature,Brainstorming,Wallet | low | Minor |
529,275,219 | godot | Incorrect GridMap cursor offset in 3D Half Resolution view | **Godot version:**
3.2 beta 2 official
**OS/device including version:**
macOS Catalina 10.15.1
**Issue description:**
When "Half Resolution" option is enabled in the 3D view settings, the GridMap offsets the cursor by 2x from the top-left of viewport.
**Steps to reproduce:**
1. Add a GridMap
2. Enable "Half Resolution" in 3D view settings
3. Try to paint on the GridMap
| bug,topic:editor,confirmed,topic:3d | low | Minor |
529,290,586 | vscode | Api for editor insets | This issue track the API proposal for editor insets. The current proposal is this
https://github.com/microsoft/vscode/blob/ffe3749d5afb046f289d04f915d8d4ade47c028e/src/vs/vscode.proposed.d.ts#L135-L147 | feature-request,api-proposal,editor-insets | high | Critical |
529,309,712 | electron | Publish a list of Electron dependencies | <!-- As an open source project with a dedicated but small maintainer team, it can sometimes take a long time for issues to be addressed so please be patient and we will get back to you as soon as we can.
-->
### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [X] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [X] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [X] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
<!-- Is your feature request related to a problem? Please add a clear and concise description of what the problem is. -->
I am not able to find a list of Electron dependencies for Linux. Can it be gathered and published? There is a speculation that the list consists of:
```
"gconf2", "gconf-service", "libnotify4", "libappindicator1", "libxtst6", "libnss3"
```
However, I don't think this list has been revised in a long time.
### Proposed Solution
<!-- Describe the solution you'd like in a clear and concise manner -->
Publish the official list of dependencies
### Alternatives Considered
<!-- A clear and concise description of any alternative solutions or features you've considered. -->
### Additional Information
<!-- Add any other context about the problem here. -->
| enhancement :sparkles:,documentation :notebook: | low | Major |
529,329,928 | rust | Print address on SIGSEGV | It can be useful while debugging to find out if it is a null pointer / `NonNull::dangling()` pointer, or if it points just enough past the stack guard to not be detected as stack overflow.
It would also be useful to print if the access was a read, write or execution. | A-runtime,E-hard,T-libs-api,C-feature-request | low | Critical |
529,352,910 | angular | Vague error when a comment is inside interpolated expression | <!--๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
Oh hi there! ๐
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
-->
# ๐ bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- โ๏ธedit: --> The exception is inside @angular/compiler
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
Untested
### Description
Using comments inside an interpolated expression (like {{ //TODO }}) creates no build errors but generates the below exception. While it's fine that angular doesn't support such expressions, the exception gives no clue as to what went wrong.
## ๐ฌ Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2
-->
<!-- โ๏ธ-->
[https://stackblitz.com/edit/angular-issue-repro2-h5bf6a](https://stackblitz.com/edit/angular-issue-repro2-h5bf6a)
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## ๐ฅ Exception or Error
<pre><code>
Uncaught TypeError: Cannot read property 'visit' of undefined
at convertPropertyBinding (compiler.js:7099)
at compiler.js:22052
at Array.map (<anonymous>)
at createUpdateStatements (compiler.js:22049)
at compiler.js:22031
at Array.map (<anonymous>)
at ViewBuilder$1._createNodeExpressions (compiler.js:22028)
at ViewBuilder$1.build (compiler.js:21509)
at ViewCompiler.compileComponent (compiler.js:21434)
at JitCompiler._compileTemplate (compiler.js:25710)
</code></pre>
## ๐ Your Environment
**Angular Version:**
<pre><code>
@angular-devkit/architect 0.801.3
@angular-devkit/build-angular 0.801.3
@angular-devkit/build-optimizer 0.801.3
@angular-devkit/build-webpack 0.801.3
@angular-devkit/core 8.1.3
@angular-devkit/schematics 8.3.19
@angular/animations 8.1.3
@angular/cli 8.3.19
@angular/common 8.1.3
@angular/compiler 8.1.3
@angular/compiler-cli 8.1.3
@angular/forms 8.1.3
@angular/language-service 8.1.3
@angular/platform-browser 8.1.3
@angular/platform-browser-dynamic 8.1.3
@angular/router 8.1.3
@ngtools/webpack 8.1.3
@schematics/angular 8.3.19
@schematics/update 0.803.19
rxjs 6.5.3
typescript 3.4.5
webpack 4.35.2
</code></pre> | type: bug/fix,hotlist: error messages,freq1: low,area: compiler,state: confirmed,P4,compiler: parser | low | Critical |
529,367,121 | godot | Connections to Method doesn't update | **Godot version:**
3.2.beta2
**OS/device including version:**
Solus 4 Gnome
**Issue description:**
When disconnecting signals from a method using the editor interface they still show up in the **signals connected to method** interface. Even after saving the scene. They only update after reopening the scene.
**Steps to reproduce:**
- Create a new scene
- Add some Nodes (2+)
- Attrach a script to one of them
- Connect the signal from the other Node to the Node with a script
- Check the **Connections to Method** interface
- Disconnect the signal
- Save
- Check the **Connections to Method** interface again
| bug,topic:editor,confirmed | low | Major |
529,390,544 | go | x/tools/go/packages: needs more explanations and examples | Edit: It looks I used this package wrongly. On the other hand, I think the docs of this package is lack of detailed explanations and examples. I converted this issue to a document enrichment request. For examples, what are "the package as compiled for the test" and "the test binary". And some command line argument examples may be helpful.
And is the paragraph problematic?
> As noted earlier, the Config.Mode controls the amount of detail reported about the loaded packages, with each mode returning all the data of the previous mode with some extra added. See the documentation for type LoadMode for details.
Is it intended to explain the deprecated LoadFiles<LoadImports<LoadTypes<LoadSyntax<LoadAllSyntax preset modes?
(The following is the old content)
-----
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What did you do?
```golang
package main
import (
"fmt"
"time"
"go/ast"
"go/parser"
"go/token"
"golang.org/x/tools/go/packages"
)
func main() {
pkgs, err := packages.Load(nil, "std")
if err != nil {
panic(err)
}
var configForParsing = &packages.Config{
Mode: packages.NeedName | packages.NeedImports | packages.NeedTypes |
packages.NeedDeps | packages.NeedExportsFile | packages.NeedFiles |
packages.NeedCompiledGoFiles | packages.NeedTypesSizes |
packages.NeedSyntax | packages.NeedTypesInfo,
Tests: false,
ParseFile: func(fset *token.FileSet, parseFilename string, _ []byte) (*ast.File, error) {
var src interface{}
mode := parser.ParseComments // | parser.AllErrors
file, err := parser.ParseFile(fset, parseFilename, src, mode)
if file == nil {
return nil, err
}
for _, decl := range file.Decls {
if fd, ok := decl.(*ast.FuncDecl); ok {
fd.Body = nil
}
}
return file, nil
},
}
parsedPkgs := make([]*packages.Package, 0, 1000)
for _, pkg := range pkgs {
fmt.Println(pkg.PkgPath)
pkgs, err := packages.Load(configForParsing, pkg.PkgPath)
if err != nil {
fmt.Println("packages.Load error:", err)
}
parsedPkgs = append(parsedPkgs, pkgs...)
}
fmt.Println("[done]")
for {
time.Sleep(time.Hour)
}
fmt.Println(parsedPkgs)
}
```
### What did you expect to see?
<1G memory is consumed.
### What did you see instead?
7G memory is consumed.
Initially I posted this result here: https://groups.google.com/forum/#!topic/golang-tools/cLIwae8rx1g
Alan Donovan said this is not normal and Josh Bleecher Snyder suggested me post an issue here, so I do.
| Documentation,NeedsInvestigation,Tools | low | Critical |
529,396,468 | vscode | Debug: call stack commands arguments | We need to do a couple of things:
1. Currently for commands which are contributed for threads we pass the `threadId` as a `number` argument. However this is not enough when you are debugging multiple sessions. Since the `threadId` does not uniquly identify the thread across sessions. Due to that we should send a structured object which contains the sessionId and the threadId
2. For `stackFrame` we pass the source uri string. Which is also not enough to identify the stackFrame. It should laso include the threadId and the sessionId
3. We need to add documention which explains what contexts we pass for contributed call stack commands
We will probably try not to break the current behavior, but add additional arugments after the current argument.
@testforstephen is Java contributing call stack commands for threads?
@roblourens @connor4312 fyi since the node debugging contribues Skip File commands
@weinand fyi | debug,debt | low | Critical |
529,404,625 | TypeScript | Allow using type parameters and return types with overloaded class constructors | <!-- ๐จ STOP ๐จ ๐ฆ๐ง๐ข๐ฃ ๐จ ๐บ๐ป๐ถ๐ท ๐จ
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
Generic Class Constructor Declaration Overloads Type Parameters
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
This is partially a request to revisit some of the discussion from here:
https://github.com/microsoft/TypeScript/issues/10860
But it's also to provide some examples of cases that are difficult/impossible to type using classes today.
A class may frequently assign different types to its properties depending on how it was instantiated. While we can type those properties as unions of all their possible types (or even use completely separate classes), it would be amazing if we could "narrow" a class's type based on how it was instantiated.
We CAN handle this type of complexity with regular function overloads, because the relevant call signature is narrowed by both function parameters and type parameters. Class constructors, however, only pay attention to the parameters being passed and can't have type parameters.
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
```ts
// Using type parameters with overloaded generic function
function func(): void;
function func<T extends string>(requiredThing: T): void
function func(requiredThing?: string) { }
func() // Ok
func<'hello'>() // Expects 1 argument, as expected
// Attempting to use type parameters with overloaded class constructor
class Example<T> {
constructor()
constructor(blah: T) // How do we connect this to the presence of T?
constructor(blah?: T) {}
}
new Example() // Ok
new Example<'hello'>() // We want this to expect 1 argument somehow
```
As was also discussed in https://github.com/microsoft/TypeScript/issues/10860, return types on a constructor could theoretically represent narrowed versions of the instance type. Currently there's not an easy way to narrow a property's type based on how the class was instantiated:
```ts
class Example {
prop?: string | number
constructor() // When this is used, prop should be string | number | undefined
constructor(prop: string) // When this is used, prop should be string
constructor(prop: number) // When this is used, prop should be number
constructor(prop?: string | number) {
// implementation
}
}
```
## Examples
<!-- Show how this would be used and what the behavior would be -->
Ideally, maybe something like this for narrowing by type parameters:
```ts
class Example {
constructor()
constructor<T extends string>(blah: T)
constructor(blah?: string) {}
}
new Example() // Ok
new Example<'hello'>() // Would expect 1 argument
```
And maybe something like this for return types:
```ts
interface IExampleString extends Example {
prop: string
}
interface IExampleNumber extends Example {
prop: number
}
class Example {
prop?: string | number
constructor() // When this is used, prop should be string | number | undefined
constructor(prop: string): IExampleString // When this is used, prop should be string
constructor(prop: number): IExampleNumber // When this is used, prop should be number
constructor(prop?: string | number) {
// implementation
}
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | medium | Critical |
529,407,055 | node | buffer: implement pooling mechanism for Buffer.allocUnsafe | ### The problem
At the moment `Buffer.allocUnsafe` uses a pre-allocated internal `Buffer` which is then sliced for newly allocated buffers, when possible. The size of the pool may be configured by setting `Buffer.poolSize` property (8KB by default). Once the current internal buffer fills up, a new one is allocated by the pool.
Here is the related fragment of the official documentation:
> The Buffer module pre-allocates an internal Buffer instance of size Buffer.poolSize that is used as a pool for the fast allocation of new Buffer instances created using Buffer.allocUnsafe() and the deprecated new Buffer(size) constructor only when size is less than or equal to Buffer.poolSize >> 1 (floor of Buffer.poolSize divided by two).
While this mechanism certainly improves performance, it doesn't implement actual pooling, i.e. reclamation and reuse of buffers. Thus it doesn't decrease allocation rate in scenarios when `Buffer.allocUnsafe` is on the hot path (this is a common situation for network client libraries, e.g. DB drivers).
This issue is aimed to discuss the value of such pooling mechanism and provide a good starting point for initial design feedback.
There are two main options for pooling in Node.js:
1. Provide an API for manual reference counting. This approach is unsafe and requires a lot of discipline from uses, so it doesn't sound like a good candidate.
2. Integrate with GC for buffer reclamation. This one is more complicated and requires integration with GC.
It appears that option 2 is feasible with experimental APIs (FinalizationGroup and, maybe, WeakRefs).
### The solution
The implementation idea was described by @addaleax (see https://github.com/nodejs/node/issues/30611#issuecomment-557841480)
`FinalizationGroup` API could be enough to implement a pool that would reuse internal buffers once all slices pointing at them were GCed. When the pool uses an active internal buffer (let's call it a source buffer) to create slices, it could register those slices (as "the object whose lifetime we're concerned with") with their source buffer (as "holdings") in a `FinalizationGroup`. Once a finalizer function is called and it reports that all slices were GCed (it could be based on a simple counter), the pool could reclaim the corresponding source buffer and reuse it.
There are some concerns with this approach.
First, this pooling mechanism may potentially lead to performance degradation under certain conditions. For large source buffers the cost of bookkeeping of all slices in the `FinalizationGroup` may be too high. For small source buffers (especially with 8KB source buffers which is the default in the standard API's global pool) it's probably not worth it at all. This could be mitigated by using a hybrid approach: use current mechanism in case for small buffer allocation as the fallback. So, some PoC experiments and benchmarking have to be done.
Another concern is that it's an experimental API, so I'm not sure if `FinalizationGroup`s are available internally without `--harmony-weak-refs` flag (or planned to become available), like it's done for internal `WeakReference` API.
Proposed plan:
1. Gather initial feedback
2. Implement a PoC and benchmark it
3. Discuss next steps (potentially, support in node core)
### Alternatives
Such pool could be certainly implemented as an npm module. However, support in node core could bring performance improvements to a much broader audience. | buffer | medium | Major |
529,437,363 | go | os/exec: add example of handling exec.Error and exec.ExitError | https://golang.org/pkg/os/exec provides `exec.Error` and `exec.ExitError` error types and doesn't document how to check and distinguish between them.
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 linux/amd64
</pre>
### What did you do?
I am using https://golang.org/pkg/os/exec/#Cmd.Output to capture the output of `dnf` command and check its return code. The doc says `Any returned error will usually be of type *ExitError`. However, trying to detect error with `errors.Is(err, exec.ExitError)` (as mentioned in https://golang.org/pkg/errors/) fails with `./prog.go:20:15: type exec.ExitError is not an expression`.
https://play.golang.org/p/7hjN2PCyBgB
### What did you expect to see?
Expect to separate error when command not found (seems to be `*exec.Error`) and when command run successfully with return code (`*exec.ExitError`). Expect to read exit code from `dnf` somehow which is part of its API.
Expect to see the example of distinguishing between these two errors and reading the exit code in Output example.
### What did you see instead?
```go
./prog.go:20:15: type exec.ExitError is not an expression
Go build failed.
```
| Documentation,help wanted,NeedsFix | low | Critical |
529,482,167 | storybook | In the Docs addon, import description from a Readme file | **Is your feature request related to a problem? Please describe.**
The docs addon default functionality is awesome, except that the description field is populated from JSDocs within the component file.
**Describe the solution you'd like**
An parameter for the docs addon to use a .mdx file for the description that retains all the other default docs functionality.
**Describe alternatives you've considered**
The readme addon sort of works, but it also adds the readme to the canvas, and adds a mandatory sidebar. Seems maybe I can I do this with a slot function, but I can't find any example code.
**Are you able to assist bring the feature to reality?**
no
| feature request,addon: docs | low | Minor |
529,514,659 | godot | Pixel offset when resizing or zooming | **Godot version:** 3.1.2 RC1 Mono and 3.1.1 Mono
**OS/device including version:** Windows 10
**Issue description:**
I have two textures aligned next to each other. Both are at integer positions and scale. Problem is that they drift apart, or get inside of each other when zooming or resizing the window, even in the editor.
[^Zooming in the editor^]
[^Resizing the game window (uses "2d" display mode and "keep")^]
**Minimal reproduction project:**
[Test.zip](https://github.com/godotengine/godot/files/3898342/Test.zip)
Just open the speechbubble scene and scroll in and out to observe the effect | bug,confirmed,topic:gui | low | Critical |
529,526,120 | pytorch | [Tensorboard] nothing appears in the projector tab | ## ๐ Bug
When running the add_embedding example provided in the official [documentation](https://pytorch.org/docs/stable/tensorboard.html#torch.utils.tensorboard.writer.SummaryWriter.add_embedding), I am unable to visualize the output in Tensorboard. When loading the projector page, it's blank. Yet the image and graph tab both works fine.
## Script To Reproduce
```
import keyword
import torch
import torch
import torchvision
from torch.utils.tensorboard import SummaryWriter
from torchvision import datasets, transforms
# Writer will output to ./runs/ directory by default
writer = SummaryWriter()
transform = transforms.Compose([transforms.ToTensor(), transforms.Normalize((0.5,), (0.5,))])
trainset = datasets.MNIST('mnist_train', train=True, download=True, transform=transform)
trainloader = torch.utils.data.DataLoader(trainset, batch_size=64, shuffle=True)
model = torchvision.models.resnet50(False)
# Have ResNet model take in grayscale rather than RGB
model.conv1 = torch.nn.Conv2d(1, 64, kernel_size=7, stride=2, padding=3, bias=False)
images, labels = next(iter(trainloader))
grid = torchvision.utils.make_grid(images)
writer.add_image('images', grid, 0)
writer.add_graph(model, images)
meta = []
while len(meta)<100:
meta = meta+keyword.kwlist # get some strings
meta = meta[:100]
for i, v in enumerate(meta):
meta[i] = v+str(i)
label_img = torch.rand(100, 3, 10, 32)
for i in range(100):
label_img[i]*=i/100.0
writer.add_embedding(torch.randn(100, 5), metadata=meta, label_img=label_img)
writer.add_embedding(torch.randn(100, 5), label_img=label_img)
writer.add_embedding(torch.randn(100, 5), metadata=meta)
writer.close()
```
## Environment
pytorch: 1.3.0
torchvision: 0.5.0a0+9cdc814
tensorboard: 2.0.0
tensorflow not installed.
cc @ezyang @gchanan @zou3519 @jerryzh168 | needs reproduction,module: tensorboard,oncall: visualization | low | Critical |
529,528,848 | flutter | Don't include dev_dependencies in native build scripts | ## Use case
I'm maintaining a package providing bindings to sqlite via `dart:ffi`. For Android apps, we need to compile sqlite3 as a dynamic library that gets put into the apk. For iOS and non-Flutter Dart apps, we use the sqlite3 library from the system, if available.
Since `dart:ffi` is still in an early stage, many users want to use native bindings for tests only, and use another package like `sqflite` for production. Unit tests are run on a desktop machine, so we don't compile any native libraries and instead use the one from the system. Unfortunately, the Flutter tool will include the native build script even if the package is just a `dev_dependency`. This means that native libraries are added into the built apk for no reason, but are still increasing app size.
## Proposal
The `dev_dependecies` section of a pubspec indicates that a package is only used for development. So, I believe that the Flutter tool should not view packages in `dev_dependencies` as a native package and not run their native buildscripts when using `flutter run` or `flutter build`. | c: new feature,tool,P3,team-tool,triaged-tool | low | Major |
529,532,373 | pytorch | Warn about driver CUDA mismatch in torch.cuda.is_available() | ## ๐ Enhancement
The `torch.cuda.is_available()` should print a warning if the GPU driver is too old to support the CUDA version installed with PyTorch. If the system does not have a GPU or PyTorch was built without CUDA support, the function should return False but remain silent to avoid spamming less useful messages.
We already print such a warning about driver mismatch when initializing CUDA. However, I've seen a number of shared PyTorch scripts that don't even get to initializing CUDA because its gated on a `torch.cuda.is_available()` call. People are usually a little lost at that point, because they don't know **why** `torch.cuda.is_available()` returned `False`.
cc @ngimel | module: cuda,triaged,enhancement | low | Minor |
529,560,342 | pytorch | Version 1.3 no longer supporting Tesla K40m? | ## ๐ Bug
I am using a Tesla K40m, installed pytorch 1.3 with conda, using CUDA 10.1
## To Reproduce
Steps to reproduce the behavior:
1. Have a box with a Tesla K40m
1. `conda install pytorch cudatoolkit -c pytorch`
1. show cuda is available
```
python -c 'import torch; print(torch.cuda.is_available());'
>>> True
```
1. Instantiate a model and call `.forward()`
```
Traceback (most recent call last):
File "./baselines/get_results.py", line 395, in <module>
main(args)
File "./baselines/get_results.py", line 325, in main
log_info = eval_main(eval_args)
File "/mnt/cdtds_cluster_home/s0816700/git/midi_degradation_toolkit/baselines/eval_task.py", line 165, in main
log_info = trainer.test(0, evaluate=True)
File "/mnt/cdtds_cluster_home/s0816700/git/midi_degradation_toolkit/mdtk/pytorch_trainers.py", line 110, in test
evaluate=evaluate)
File "/mnt/cdtds_cluster_home/s0816700/git/midi_degradation_toolkit/mdtk/pytorch_trainers.py", line 220, in iteration
model_output = self.model.forward(input_data, input_lengths)
File "/mnt/cdtds_cluster_home/s0816700/git/midi_degradation_toolkit/mdtk/pytorch_models.py", line 49, in forward
self.hidden = self.init_hidden(batch_size, device=device)
File "/mnt/cdtds_cluster_home/s0816700/git/midi_degradation_toolkit/mdtk/pytorch_models.py", line 40, in init_hidden
return (torch.randn(1, batch_size, self.hidden_dim, device=device),
RuntimeError: CUDA error: no kernel image is available for execution on the device
```
First tried downgrading to cudatoolkit=10.0, that exhibited same issue.
The code will run fine if you repeat steps above but instead `conda install pytorch=1.2 cudatoolkit=10.0 -c pytorch`.
## Expected behavior
If no longer supporting a specific GPU, please bomb out upon load with useful error message.
## Environment
Unfort ran your script after I 'fixed' so pytorch version will be 1.2 here - issue encountered with version 1.3.
```
Collecting environment information...
PyTorch version: 1.2.0
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Scientific Linux release 7.6 (Nitrogen)
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
CMake version: version 2.8.12.2
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: Tesla K40m
Nvidia driver version: 430.50
cuDNN version: /usr/lib64/libcudnn.so.6.5.18
Versions of relevant libraries:
[pip3] numpy==1.16.3
[pip3] numpydoc==0.8.0
[conda] blas 1.0 mkl
[conda] mkl 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.15 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] pytorch 1.2.0 py3.7_cuda10.0.130_cudnn7.6.2_0 pytorch
[conda] torchvision 0.4.0 py37_cu100 pytorch
```
cc @ezyang @gchanan @zou3519 @jerryzh168 @ngimel | module: binaries,module: docs,module: cuda,triaged | high | Critical |
529,560,985 | flutter | A way to observe child size changes | There are use cases for observing a child's layout parameters whenever they change.
`Customer: dream` were recently asking for an easy way to observe a subtree's size.
To unblock `customer: dream` they are using this snippet: https://github.com/amirh/size_observer/blob/master/lib/size_observer.dart#L12
I'm filing the issue to discuss whether we want to include an equivalent widget in the framework. If there's already an equivalent in the framework I'm not aware of please let me know ๐ .
The closest thing I'm aware of in the framework is [SizeChangeLayoutNotifier](https://github.com/flutter/flutter/blob/37f9c541165c3516f727cd36bd502d411fdad3b8/packages/flutter/lib/src/widgets/size_changed_layout_notifier.dart#L52) which sends a notification when the size has changed. Relevant properties of the current implementation for SizeChangeLayoutNotifier:
1. It does not notify on the initial size.
2. It does not include the size with the notification (can be worked around by a closure with access to BuildContext as a post frame callback when a notification arrives).
3. The notification is not tied to a specific widget, e.g a NotificationListener with more than one SizeChangeLayoutNotifier in its subtree cannot tell which of them sent the notification.
While we can adjust `SizeChangeLayoutNotifier` to meet the same requirements by:
1. Add an optional `notifyOnInitialSize` bool parameter to `SizeChangeLayoutNotifier` (defaults to false for backwards compatibility).
2. Include the new layout size as part of [SizeChangedLayoutNotification](https://master-api.flutter.dev/flutter/widgets/SizeChangedLayoutNotification-class.html).
3. Add some identifying property to `SizeChangedLayoutNotification`.
I feel like the ergonomics of the adjusted `SizeChangeLayoutNotifier` won't be so nice (especially due to `#3`). So I think it may sense to add something like [SizeObserver](https://github.com/amirh/size_observer/blob/master/lib/size_observer.dart#L12) to the framework.
@HansMuller I wonder if you have any thoughts. | c: new feature,framework,customer: dream (g3),P3,team-framework,triaged-framework | low | Major |
529,564,487 | pytorch | Document memory characteristics of in-place ops | ## ๐ Documentation
Users typically expect in-place operations to save memory over out of place variants. There are some cases, e.g. when mixed-type operations will perform the op into a different tensor of a common dtype, or when (after https://github.com/pytorch/pytorch/pull/30429), performing certain operations on uncoalesced sparse tensors. The memory characteristics should be explained somewhere in the docs.
cc @vincentqb | module: sparse,module: docs,triaged,enhancement,module: type promotion | low | Minor |
529,579,445 | godot | AutoLoads can be named "_" | **Godot version:** 3.2 beta 2
**OS/device including version:** Pop OS 19.04
**Issue description:**
The singleton name-check allows to call singletons "_", "__", etc.
You **cannot** do `_.some_thing`
You **can** do `__.some_thing`
**Steps to reproduce:**
Make an autoload scene/script and name it "_".
**Minimal reproduction project:**
| enhancement,topic:editor,usability | low | Minor |
529,581,186 | pytorch | [FR] nn.init.* accept None as input tensor | ## ๐ Feature
It would be great if `nn.init.*` methods accept `None` as the input (and do noop in that case).
## Motivation
Greatly simplifies the common pattern:
```py
def init(m):
if isinstance(m, (nn.Linear, nn.Conv2d)):
nn.init.normal_(m.weight, 0, 0.02)
if getattr(m, 'bias', None) is not None:
nn.init.zeros_(m.bias)
elif isinstance(m, nn.BatchNorm2d):
if getattr(m, 'weight', None) is not None:
nn.init.ones_(m.weight)
if getattr(m, 'bias', None) is not None:
nn.init.zeros_(m.bias)
```
| module: nn,triaged,enhancement | low | Minor |
529,587,744 | youtube-dl | Pony.fm | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.11.22. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.11.22**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs && Description
Free Audio tracks from pony.fm
- Overview page which should be detected: https://pony.fm/tracks/43462-summer-wind-fallout-equestria-skybolt
- that's `https://pony.fm/tracks/<track-id>-<text>`
- On there is a <kbd>Downloads</kbd> button with different formats
- [ ] OGG Vorbis (download see below)
- [ ] ALAC (download see below)
- [ ] AAC (download see below)
- [ ] MP3: https://pony.fm/t43462/dl.mp3
- that's `https://pony.fm/t<track-id>/dl.mp3`
- [ ] FLAC: https://pony.fm/t43462/dl.flac
- that's `https://pony.fm/t<track-id>/dl.flac`
- For OGG Vorbis, AAC, ALAC the download requires calling a REST endpoint first:
- `GET https://pony.fm/api/web/tracks/cached/<track-id>/ALAC` or `/AAC` or `/OGG%20Vorbis`
- returns a json `{"url": null}`
- redo that request until it contains an url
- e.g. `{"url":"https:\/\/pony.fm\/t43462\/dl.m4a"}`
- [ ] There also is a lyrics section
- [ ] Cover image can be loaded from https://pony.fm/i10167/normal.png, `https://pony.fm/i<track-id>/normal.png` | site-support-request | low | Critical |
529,589,106 | go | cmd/go: error isn't properly reported when running go list on cgo package with missing pkg-config | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.3 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/muir/Library/Caches/go-build"
GOENV="/Users/muir/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/muir/projects/<project>/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/_q/1xpb0k992ll803xsldpx0qyr0000gn/T/go-build252385107=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
I opened a non-cgo package in our project. The package does not transitively depend on any cgo packages.
### What did you expect to see?
I expected gopls to load the package with no issue.
### What did you see instead?
gopls failed to create the view due to a `go list` "missing pkg-config" error.
```
LSP :: Error loading workspace folders (expected 1, got 0)
failed to load view for file:///Users/muir/projects/<project>/go/src: error loading packages: go [list -e -json -compiled=true -test=true -export=false -deps=true -find=false -- ./...]: exit status 2: # pkg-config --cflags -- <bunch of libraries>
pkg-config: exec: "pkg-config": executable file not found in $PATH
```
Elsewhere, our project has a cgo package that uses the cgo pkg-config directive (e.g. `// #cgo pkg-config: some-library`). My laptop doesn't currently have pkg-config installed.
I assume the error comes from the `go list ./...` we do now when creating a view. | NeedsFix,GoCommand | medium | Critical |
529,605,014 | flutter | Expose more APIs to interact with app in driver API | Internal: b/140894344
Customer dream ran into some limitations of our driver API. It seems like we could make things better by some minor changes:
- In addition to `tap`, expose `tapAt` (taking a DriverOffset).
- In addition to `scroll`, expose `scrollFrom` (taking a DriverOffset) (and maybe rename it `drag`/`dragFrom`).
- Expose new APIs TestPointer and TestGesture in the driver API, equivalent to the homonymous classes in flutter_test. | c: new feature,framework,t: flutter driver,P3,team-framework,triaged-framework | low | Minor |
529,615,801 | TypeScript | type destructuring | ## Search Terms
type destructuring
## Suggestion
Allow destructuring syntax when assigning `type`
## Use Cases
Dynamically assign a type as the type of an other type's property.
## Examples
Where `AutocompleteService` is a class, `PlacesServiceStatus` is an enum, and `AutocompletePrediction` is an interface.
What I'm doing currently:
```ts
const { AutocompleteService, PlacesServiceStatus } = google.maps.places;
type AutocompletePrediction = google.maps.places.AutocompletePrediction;
```
What I'd like to be able to do:
```ts
const { AutocompleteService, PlacesServiceStatus } = google.maps.places;
type { AutocompletePrediction } = google.maps.places;
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Minor |
529,620,919 | flutter | Expand output paths for `flutter build ios-framework`, allow ~ | ## Steps to Reproduce
```
flutter build ios-framework --output=~/Desktop/FlutterFrameworks/
```
Creates a `~` directory in the working directory instead of expanding ~ | c: new feature,platform-ios,tool,dependency: dart,a: existing-apps,P3,team-ios,triaged-ios | low | Major |
529,645,259 | TypeScript | Smarter errors around `Function.length` | I don't know how often other people have encountered this, but here goes: In the same vein as our uncalled function checks, most usages of `Function.length` are _probably_ an error. Here's a toy example that just bit me:
```ts
declare function getResult(): string[];
for (let i = 0; i< getResult.length; i++) {
getResult().slice(0, i).map(x => console.log(x));
}
```
Minimally, I think we could suggest that if a function returns something with a `length` property, and the function's `length` property is inspected instead, we could probably mark it as suspect. | Domain: Error Messages | low | Critical |
529,703,988 | go | proposal: crypto/x509: reloading certificates from disk | [From][1] #24254:
> I wonder if there is any real use case for reloading the system cert pool.
One use case is long-running processes that now have to jump through hoops to update their view of the system cert pool (e.g. openshift/cloud-credential-operator#113). On Unix, [the loading logic][2] is expensive, traversing multiple directories. But for processes who know they can load certs from a single file, it would be nice to have a way to reload if the backing file had changed but not otherwise. For example, something like:
```go
// NewCertPoolsFromFile parses a series of PEM encoded certificates from the file at the
// given path and records the Stat ModTime of the loaded file. When the pool is used to
// verify a certificate, it has been more than a minute since the last Stat, and a fresh
// Stat gives a ModTime newer than the cached value, the file is reloaded before being
// used to perform the verification.
func NewCertPoolFromFile(path string) *CertPool
```
Obviously the "don't bother `Stat`ing again" time could be configurable if that seemed important. Or maybe checking the current time is about as expensive as running the `Stat`, so we should just call `Stat` on every `contains`. Or maybe there would be no auto-refresh in `contains`, but `CertPool` would become an `interface`:
```go
type CertPool interface {
BySubjectKeyID(key string) []*Certificate
ByName(name string) []*Certificate
}
```
In which case there could be a from-file `CertPool` implementation with a `Refresh` method to trigger the `Stat` check and possible reload. Or something ;). But having something in the stdlib that could be dropped into [`tls.Config.RootCAs`][3] to get efficient reloads without the caller having to babysit the `CertPool` would be great. Thoughts?
[1]: https://github.com/golang/go/issues/24540#issuecomment-376227784
[2]: https://github.com/golang/go/blob/8a5af7910a9b157c02736c3e0998a587bb8511c1/src/crypto/x509/root_unix.go#L39-L89
[3]: https://golang.org/pkg/crypto/tls/#Config | Proposal,Proposal-Crypto | low | Major |
529,729,984 | PowerToys | [FancyZones] add support for afwn [a few windows niceties] store app window layout and positioning keyboard shortcuts | # Summary of the new feature/enhancement
<!--
A clear and concise description of what the problem is that the new feature would solve.
Describe why and how a user would use this new functionality (if applicable).
-->
Add support for afwn [ a few windows niceties ] store app [ [https://microsoft.com/en-us/p/a-few-windows-niceties/9mtw4cj7s276](https://microsoft.com/en-us/p/a-few-windows-niceties/9mtw4cj7s276) ] window layout and positioning keyboard shortcuts.
Specifically the alt+c[enter 60% of screen width], alt+p[hone 80% of screen height with 9:16 aspect ratio] and alt+t[ablet 80% of screen height with 16:9 aspect ratio]. All three with alt+shift modifier variants that reduce the % of width and height used and in case of latter two change the aspect ratio to 3:4 and 4:3 respectively.
Also consider enabling the alt+b[utton swap on mouse] and alt+z[leep computer] options.
For more details on these keyboard shortcuts see app's [help screen screenshot](https://github.com/myusrn/uwpSystrayExtension/blob/master/Package/Images/Screenshot%20combined.png).
# Proposed technical implementation details (optional)
<!--
A clear and concise description of what you want to happen.
-->
| Idea-Enhancement,Product-FancyZones | low | Minor |
529,734,823 | node | Migration of core modules to primordials | This is a tracking issue for the migration of core modules to use builtins from the `primordials` object.
At the moment, for performance-sensitive code, only static methods and global functions should be migrated. V8 8.0 might have the optimization that we need to migrate prototype methods. | meta | high | Major |
529,770,157 | TypeScript | Go to definition for class members hidden with Symbols takes to symbol itself | As a developer working with Custom Elements classes that have their class members available in runtime, I would like to use `Symbol` to [hide internal methods and properties](https://component.kitchen/blog/posts/hiding-internal-framework-methods-and-properties-from-web-component-apis) from the public API.
The drawback of this approach is that "go to definition" currently does not recognise the case when `Symbol` is used for a method, and jumps to the place where the Symbol itself is defined.
I'm not sure whether this is a bug or feature.
**TypeScript Version:** 3.8.0-dev.20191126
**Search Terms:** Go to definition, ECMAScript Symbols, Symbol
**Code**
```ts
const method = Symbol('method');
class Parent {
protected [method]() {
return 'parent';
}
}
class Child extends Parent {
protected [method]() {
return super[method]() + ' child';
}
}
```
**Expected behavior:**
When clicking on `super[method]`, it should be possible to go to the line 4.
**Actual behavior:**
When clicking on `super[method]`, go to definition moves to the line 1.
**Playground Link:** https://www.typescriptlang.org/play/?ts=3.8.0-dev.20191126&ssl=1&ssc=1&pln=38&pc=2#code/MYewdgzgLgBAtgUygCxAExgXhgZQJ5wBGIANgBQDkiK6FAlANwBQTwJAhhBDAArsBOCMLADeTGBJgAHfiCgJg8jAG1qqNAF0ydGGMn6YgqAFd+YGBSkChUCs30BfJk9YcuMAMLIAliQwIAD3kwNG4+QWFdcUkZOQUlGFUkdS0dPQMJI1NzCGMpBH4kmk1tGABqCxhgHz87aIknJyA
**Related Issues:**
I didn't found any related issue but the approach with using ES2015 Symbols was suggested to be used as a workaround for `protected` methods in mixins at https://github.com/microsoft/TypeScript/issues/17744#issuecomment-431534647 | Suggestion,Experience Enhancement | low | Critical |
529,806,176 | angular | dev-infra / perf: clan-up existing benchpress benchmarks | Benchpress benchmarks in the https://github.com/angular/angular/tree/master/modules/benchmarks could use some cleanup as they accumulated a bit of technical debt through incremental changes over time.
Cleanups to consider are listed below.
### Remove "unused" benchmarks
As a rule of thumb we should only have / maintain benchmarks that are run on LL. If we don't track given benchmark's numbers and use those numbers to drive improvements, we should delete such benchmarks.
There are several categories of benchmarks that are not run / tracked on LL and could be considered for deletion:
* ["old" benchmarks](https://github.com/angular/angular/tree/master/modules/benchmarks/src/old) - it doesn't seem like we use them at all so probably only a liability at this point?
* experiments / hand-written code (either failed or ones that were translated into the production code) - those should be deleted:
* early iv experiments - not needed as iv impl was incomplete and ngIvy impl is quite different
* [largetable](https://github.com/angular/angular/tree/master/modules/benchmarks/src/largetable/iv)
* [tree](https://github.com/angular/angular/tree/master/modules/benchmarks/src/tree/iv)
* VE experiments ([hand-written VE code](https://github.com/angular/angular/tree/master/modules/benchmarks/src/tree/ng2_next)) we are removing VE and we don't want to maintain hand-written code;
* render3 experimental APIs
* https://github.com/angular/angular/tree/master/modules/benchmarks/src/tree/render3
* https://github.com/angular/angular/tree/master/modules/benchmarks/src/tree/render3_function
* https://github.com/angular/angular/tree/master/modules/benchmarks/src/largetable/render3
* ["external" benchmarks](https://github.com/angular/angular/tree/master/modules/benchmarks_external) - for frameworks other than Angular - here we should decide if we want to keep such benchmarks. My understanding is that we are not actively tracking Angular performance over other benchmarks so we should either start tracking or delete: my vote would go to deleting as we haven't updated / used those benchmarks in years...
* AngularJS benchmarks - given that AngularJS is no longer maintained, I guess we don't need to keep its benchmarks?
* [benchmarks that would be better off written as a micro-benchmark](https://github.com/angular/angular/tree/master/modules/benchmarks/src/views)
* benchmarks that are _not_ tracked on LL - either start tracking or delete:
* https://github.com/angular/angular/tree/master/modules/benchmarks/src/class_bindings
* https://github.com/angular/angular/tree/master/modules/benchmarks/src/largeform
### Re-consider folders structure
Different benchmarks have different folder structure and we need to unify it. Most notable items:
* `ng2` folder in each benchmark should be re-named to `ng` or just `angular`
### Consistent files structure for each and every benchmark
Files structure within a given benchmark is hard to follow, see: https://github.com/angular/angular/pull/34034#discussion_r351546032
### Documentation updates
Documentation in https://github.com/angular/angular/blob/master/modules/benchmarks/README.md should be updated to reflect all the above changes. | area: performance,refactoring,P3 | low | Critical |
529,841,148 | create-react-app | Support setupProxy.mjs | ### Is your proposal related to a problem?
Now as Node.JS 13.2 [un-prefixed ES 6 Modules](https://nodejs.org/en/blog/release/v13.2.0/), I'd like to use ES 6 imports in my setupProxy.mjs, but CRA forces me to use `setupProxy.js`.
### Describe the solution you'd like
Next to `setupProxy.js`, allow to use `setupProxy.mjs` (or `setupProxy.cjs`).
See also https://nodejs.org/api/esm.html#esm_enabling. | issue: proposal,needs triage | low | Major |
529,857,362 | godot | Release templates handle command line debugging arguments | **Godot version:**
3.1.1.stable.official - linux_x11_64_release
**OS/device including version:**
Linux
**Issue description:**
I donโt know how critical this is, but I noticed that release builds handle command line arguments almost as well as debug builds. Examples:
```
$ ./your_game.x86_64 --help
$ ./your_game.x86_64 scenes/world2.tscn
$ ./your_game.x86_64 --resolution 2000x2000
$ ./your_game.x86_64 -d --time-scale 0.25
```
That is, there is a theoretical possibility to skip any scene, change the timescale, expand the window even if it was locked.
I understand that, most likely, there is nothing to be done, cheaters and speedraners cannot be stopped, I just inform other developers about this feature. See also #24716. | discussion,topic:core | low | Critical |
529,861,061 | godot | CPUParticles in Gles2 do not render through Viewport when billboard is setted to enabled or paricle_billboard. | **Godot version:**
3.1.1 Stable
3.1.2-rc1
3.2-beta2
**OS/device including version:**
Windows 10 64bit
NVidia gtx 1060
Drivers 436.30
**Issue description:**
CPUParticles in GLES2 do not render through Viewport when billboard is setted to enabled or paricle_billboard.
**Steps to reproduce:**
See minimal project.
**Minimal reproduction project:**
[bug.zip](https://github.com/godotengine/godot/files/3901426/bug.zip)
| bug,topic:rendering,confirmed,topic:particles | low | Critical |
529,876,610 | go | runtime: HeapSys increases until OOM termination | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 darwin/amd64
</pre>
### What operating system and processor architecture are you using?
Host machine - mac, Catalina 10.15.1, core i7, 2.5Ggz, 16Gb RAM
In docker (19.03.5) - ubuntu:latest, 10Gb mem limit, swap off
I build the app for Linux architecture using flags GOOS/GOARCH
### What did you do?
I've prepared an extended example based on #35848, but this one has one important difference: we have 'current' pointer to data and also we have an 'old' pointer that is removed (old=nil) right after new data generation.
https://github.com/savalin/example/tree/extendend_dockerized_oom_example
**branch: _extendend_dockerized_oom_example_** (master is for #35858)
It demonstrates the problem we faced on production servers (kubernetes). In this example, we use one dataset and load it in a loop. OOM killer terminates it after ~10 iteration.
<details><summary><code>make build && make run</code>Output</summary><br><pre>
go version go1.13.4 darwin/amd64
CGOENABLED=0 GOOS=linux GOARCH=amd64 go build ./main.go
docker build --memory 10Gb --memory-swap 0 -t mem_leak_issue_example .
Sending build context to Docker daemon 53.38MB
Step 1/4 : FROM ubuntu:latest
---> 775349758637
Step 2/4 : COPY ./main .
---> f2df7c102986
Step 3/4 : COPY ./edges.json .
---> d21215b8d8de
Step 4/4 : CMD ["/main"]
---> Running in a1765ec8a72c
Removing intermediate container a1765ec8a72c
---> 550ae674af6d
Successfully built 550ae674af6d
Successfully tagged mem_leak_issue_example:latest
$ make run
docker run -i -t --rm --name="mem_leak_issue_example" mem_leak_issue_example
=> JSON parsed! 13695 edges found (data size: 1 Mb)
---
Alloc = 4 MiB TotalAlloc = 5 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 68 MiB
HeapInuse = 4 MiB HeapSys = 63 MiB HeapIdle = 59 MiB HeapReleased = 59 MiB NumGC = 1
---
=> loading graph: 1 time
=> main dijkstra graph created!
=> all shortest created!
---
Alloc = 4778 MiB TotalAlloc = 4784 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 4999 MiB
HeapInuse = 4780 MiB HeapSys = 4799 MiB HeapIdle = 19 MiB HeapReleased = 19 MiB NumGC = 5
---
=> time spent for #1 iteration: 43.563816952s
=> loading graph: 2 time
=> main dijkstra graph created!
=> all shortest created!
---
Alloc = 7958 MiB TotalAlloc = 9564 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 8327 MiB
HeapInuse = 7960 MiB HeapSys = 7999 MiB HeapIdle = 39 MiB HeapReleased = 39 MiB NumGC = 6
---
=> time spent for #2 iteration: 50.665379005s
=> loading graph: 3 time
=> main dijkstra graph created!
=> all shortest created!
---
Alloc = 7198 MiB TotalAlloc = 14344 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 12463 MiB
HeapInuse = 7200 MiB HeapSys = 11967 MiB HeapIdle = 4766 MiB HeapReleased = 58 MiB NumGC = 7
---
=> time spent for #3 iteration: 1m13.81873211s
=> loading graph: 4 time
=> main dijkstra graph created!
=> all shortest created!
---
Alloc = 11978 MiB TotalAlloc = 19124 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 14859 MiB
HeapInuse = 11981 MiB HeapSys = 14271 MiB HeapIdle = 2290 MiB HeapReleased = 927 MiB NumGC = 8
---
=> time spent for #4 iteration: 1m52.920715546s
=> loading graph: 5 time
=> main dijkstra graph created!
=> all shortest created!
---
Alloc = 11236 MiB TotalAlloc = 23903 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 15664 MiB
HeapInuse = 11238 MiB HeapSys = 15039 MiB HeapIdle = 3800 MiB HeapReleased = 1672 MiB NumGC = 8
---
=> time spent for #5 iteration: 1m34.722615361s
=> loading graph: 6 time
=> main dijkstra graph created!
=> all shortest created!
---
Alloc = 7957 MiB TotalAlloc = 28683 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 18043 MiB
HeapInuse = 7962 MiB HeapSys = 17343 MiB HeapIdle = 9381 MiB HeapReleased = 3340 MiB NumGC = 9
---
=> time spent for #6 iteration: 1m25.087806114s
=> loading graph: 7 time
=> main dijkstra graph created!
=> all shortest created!
---
Alloc = 7480 MiB TotalAlloc = 33462 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 18043 MiB
HeapInuse = 7484 MiB HeapSys = 17343 MiB HeapIdle = 9859 MiB HeapReleased = 3635 MiB NumGC = 10
---
=> time spent for #7 iteration: 1m15.462949042s
=> loading graph: 8 time
=> main dijkstra graph created!
=> all shortest created!
---
Alloc = 12259 MiB TotalAlloc = 38242 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 20424 MiB
HeapInuse = 12263 MiB HeapSys = 19647 MiB HeapIdle = 7384 MiB HeapReleased = 5758 MiB NumGC = 11
---
=> time spent for #8 iteration: 2m7.055378632s
=> loading graph: 9 time
=> main dijkstra graph created!
=> all shortest created!
---
Alloc = 11368 MiB TotalAlloc = 43022 MiB StackInuse = 0 MiB StackSys = 0 MiB Sys = 20426 MiB
HeapInuse = 11371 MiB HeapSys = 19647 MiB HeapIdle = 8276 MiB HeapReleased = 5914 MiB NumGC = 11
---
=> time spent for #9 iteration: 1m33.04776087s
=> loading graph: 10 time
=> main dijkstra graph created!
make: *** [run] Error 137
</pre></details>
### What did you expect to see?
I expect the app consuming a constant amount of memory instead of increasing its consumption iteration by iteration.
### What did you see instead?
When HeapSys reaches ~20Gb container terminates by OOM killer.
Sometimes it requires more time to reproduce the issue, but on my laptop, it fails approximately at 10th iteration (see output above). | NeedsInvestigation,compiler/runtime | low | Critical |
529,895,736 | go | net/http/httputil: ReverseProxy doesn't support TCP half-close when HTTP is upgraded | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/scko/.cache/go-build"
GOENV="/home/scko/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/scko/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build357268893=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
I made the simple program to show the problem that I have.
This program has three servers: a frontend, a reverse proxy, and a backend.
After the frontend's HTTP upgrade request is accepted, the backend immediately closes the output stream. But the backend can't read the input stream because of the socket is closed by the reverse proxy.
I think `httputil.ReverseProxy` doesn't support TCP half-close.
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
``` go
package main
import (
"bufio"
"fmt"
"io"
"io/ioutil"
"log"
"net/http"
"net/http/httptest"
"net/http/httputil"
"net/url"
"strings"
"golang.org/x/net/http/httpguts"
)
func upgradeType(h http.Header) string {
if !httpguts.HeaderValuesContainsToken(h["Connection"], "Upgrade") {
return ""
}
return strings.ToLower(h.Get("Upgrade"))
}
func main() {
reqDone := make(chan struct{})
backendServer := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
defer close(reqDone)
if upgradeType(r.Header) != "websocket" {
http.Error(w, "unexpected request", 400)
return
}
c, _, err := w.(http.Hijacker).Hijack()
if err != nil {
http.Error(w, fmt.Sprintf("%v", err), 500)
return
}
io.WriteString(c, "HTTP/1.1 101 Switching Protocols\r\nConnection: upgrade\r\nUpgrade: WebSocket\r\n\r\n")
if tcpc, ok := c.(interface {
CloseWrite() error
}); ok {
tcpc.CloseWrite()
} else if closer, ok := c.(io.Closer); ok {
closer.Close()
return
}
bs := bufio.NewScanner(c)
if !bs.Scan() {
fmt.Printf("backend failed to read line from client: %v", bs.Err())
return
}
got := bs.Text()
want := "Hello"
if got != want {
panic(fmt.Sprintf("got %#q, want %#q", got, want))
}
fmt.Println("backend got", got)
}))
defer backendServer.Close()
backURL, _ := url.Parse(backendServer.URL)
rproxy := httputil.NewSingleHostReverseProxy(backURL)
rproxy.ErrorLog = log.New(ioutil.Discard, "", 0) // quiet for tests
frontendProxy := httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, req *http.Request) {
rproxy.ServeHTTP(rw, req)
}))
defer frontendProxy.Close()
req, _ := http.NewRequest("GET", frontendProxy.URL, nil)
req.Header.Set("Connection", "Upgrade")
req.Header.Set("Upgrade", "websocket")
c := frontendProxy.Client()
res, err := c.Do(req)
if err != nil {
panic(err)
}
if res.StatusCode != 101 {
panic(fmt.Sprintf("status = %v; want 101", res.Status))
}
if upgradeType(res.Header) != "websocket" {
panic(fmt.Sprintf("not websocket upgrade; got %#v", res.Header))
}
rwc, ok := res.Body.(io.ReadWriteCloser)
if !ok {
panic(fmt.Sprintf("response body is of type %T; does not implement ReadWriteCloser", res.Body))
}
defer rwc.Close()
ioutil.ReadAll(rwc)
io.WriteString(rwc, "Hello\n")
<-reqDone
}
```
### What did you expect to see?
The backend can read the input stream even though the output stream is closed.
```console
backend got Hello
```
### What did you see instead?
But the input stream was closed as well.
```console
backend failed to read line from client: <nil>
``` | NeedsFix | low | Critical |
529,923,729 | node | child_process: ERR_INVALID_ARG_TYPE on .kill() | * **Version**: Electron v4.2.12 - Node v10.11.0
* **Platform**: Windows 10 64-bit
* **Subsystem**: child_process
We are getting the following stack trace when killing a child_process:
```
root ERROR TypeError [ERR_INVALID_ARG_TYPE]: The "err" argument must be of type number. Received type undefined
at validateNumber (internal/validators.js:130:11)
at Object.getSystemErrorName (util.js:1435:3)
at errnoException (internal/errors.js:303:21)
at ChildProcess.kill (internal/child_process.js:430:26)
```
From what I can make of it, it seems to be caused by the following code:
<https://github.com/nodejs/node/blob/v10.x/lib/internal/child_process.js#L425-L439>
```js
var err = this._handle.kill(signal);
if (err === 0) {
/* Success. */
this.killed = true;
return true;
}
if (err === UV_ESRCH) {
/* Already dead. */
} else if (err === UV_EINVAL || err === UV_ENOSYS) {
/* The underlying platform doesn't support this signal. */
throw errnoException(err, 'kill');
} else {
/* Other error, almost certainly EPERM. */
this.emit('error', errnoException(err, 'kill'));
}
```
Somehow, `err` seems to be undefined, making us land in the last `else` branch, but then `errnoException` doesn't know what to make out of it and throws the error that we see.
The issue only happens in Electron, so it might not be entirely related to Node, but I was wondering if this `err` value is expected to be undefined in some circumstance? | child_process | low | Critical |
529,987,408 | vscode | Can `editorBracketMatch.foreground` theme colour be added please? | The following bracket match theme colours are available to be customised.
* `editorBracketMatch.background`: Background color behind matching brackets.
* `editorBracketMatch.border`: Color for matching brackets boxes.
Can a further one be added: `editorBracketMatch.foreground` to theme the actual text of the bracket being matched. Thanks. | help wanted,feature-request,editor-bracket-matching | medium | Critical |
530,014,845 | rust | Rustdoc: description at reexports | One line description (is there official name of this?) is not displayed at reexports in generated html.
I want one line description of reexported items to be displayed at reexports. | T-rustdoc,C-feature-request | low | Minor |
530,025,323 | scrcpy | Need shortcut keys on main build for screen density,screen orientation and app specific touches. I made it to work but its not optimized | Well here is a gist of what this is about. I am on ubuntu and run scrcpy on different workspace like this:
I am a newbie on c programming but i found a way to make shortcut key work for changing screen density and screen orientation. But, the code is not optimized to set it up on pull request.
Here is the code that make it work for shortcut keys:
Ctrl+q = Change screen density to 200
Ctrl+w = Reset screen density
Ctrl+e = landscape mode
Ctrl+r = portrait mode
Here the code:
https://files.catbox.moe/c8lz87.c
Place input_manager.c inside project-> app--src folder and build it using
ninja -Cx
./run x
Can someone work on this for making touches specific to apps(the issue is its tapping for every app):
Example in input_manager.c :
```c
case SDLK_a:
// capture ctrl+a and then see if playstore is opened so input is only triggered for that key
const char *const adb_cmdp[] = {
"shell", "input", "pidof", "com.google.playstore"
};//"com.google.playstore" is an example dont want it for playstore but other app
process_t play_store = adb_execute(NULL, adb_cmdp, ARRAY_LEN(adb_cmdp));
if(play_store){
LOGI("Play store is opened")
if (control && cmd && !shift && down) {
LOGI("Touching screeny");
const char *const adb_cmd[] = {
"shell", "input", "tap", "200", "1000"
};
adb_execute(NULL, adb_cmd, ARRAY_LEN(adb_cmd));
}
}
return;
``` | feature request | low | Minor |
530,026,572 | vscode | Extension tests improperly activate instance from dist folder | <!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
I have come across an issue with an extension I am working on where the extension tests seem to be launching my webpacked extension from `dist` which causes intermittent failures due to commands being registered twice in classes that are supposed to be singletons among other things.
This has started happening after changing activation events to the following:
` "activationEvents": [
"*"
]`
(e.g., activating my extension on startup of VSCode).
If the `dist` folder **does not** exist, then my tests work as expected but produce a stacktrace similar to:
```
Activating extension `vscode-samples.webpack-sample` failed: Cannot find module '/Users/minardi/vscode-extension-samples/webpack-sample/dist/extension'
Require stack:
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-fork.js
Here is the error stack: Error: Cannot find module '/Users/minardi/vscode-extension-samples/webpack-sample/dist/extension'
Require stack:
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-amd.js
- /Applications/Visual Studio Code.app/Contents/Resources/app/out/bootstrap-fork.js
at Function._resolveFilename (internal/modules/cjs/loader.js:627:15)
at Function.<anonymous> (internal/modules/cjs/loader.js:531:27)
at Function.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:796:852)
at Function.<anonymous> (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:765:302)
at Function._load (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:761:870)
at Module.require (internal/modules/cjs/loader.js:685:19)
at require (internal/modules/cjs/helpers.js:16:16)
at Function.s [as __$__nodeRequire] (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/loader.js:32:963)
at d._loadCommonJSModule (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:766:484)
at d._doActivateExtension (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:677:300)
at d._activateExtension (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:676:360)
at Object.actualActivateExtension (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:674:296)
at Object._activateExtension (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:506:21)
at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:505:632
at Array.map (<anonymous>)
at Object._activateExtensions (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:505:620)
at Object.activateByEvent (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:503:413)
at d._activateByEvent (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:675:24)
at d._handleEagerExtensions (/Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:678:800)
at /Applications/Visual Studio Code.app/Contents/Resources/app/out/vs/workbench/services/extensions/node/extensionHostProcess.js:682:215
Dummy Suite
โ Dummy Test
1 passing (26ms)
```
which again seems to imply that the extension from `dist` is being loaded at some point. I also added `--disable-extensions` to the launch.json as a sanity measure and that seems to have no effect.
I would expect that the extension from the `dist` folder is not activated in this way and that the source from `out/test/` is used instead.
I have forked the webpack example extension and added logic which will demonstrate this behaviour (at https://github.com/mpminardi/vscode-extension-samples/tree/activation-bug)
<!-- Use Help > Report Issue to prefill these. -->
**Version Information:**
- VSCode Version: Version: 1.40.2 Commit: f359dd69833dd8800b54d458f6d37ab7c78df520
- OS Version: Mac OS X 10.14.6
**Steps to Reproduce:**
1. Clone and checkout https://github.com/mpminardi/vscode-extension-samples/tree/activation-bug
2. Run extension tests through the IDE without a `dist` folder
3. Observe the stack trace which shows that VSCode is attempting to activate the extension from `dist`
| under-discussion,extensions-development | low | Critical |
530,038,782 | vscode | JavaScript: Improve indentation on insert with trailing newline | Let's say I have the following JS snippet:
```JS
() => {
a
}
() => {
b
}
```
Now select the entire 'a' part, from the start of line 1 to the start of line 4, i.e. including a trailing newline, and insert it at the start of the line now containing 'b'. The result is this:
```JS
() => {
a
}
() => {
() => {
a
}
b
}
```
The 'b' is now over-indented because that line received additional indentation at insert. Expected behavior: the 'b' should remain at its original indentation level. I can confirm this behavior at least for JS and JSON files.
---
The reason I care is that selecting whole lines with the keyboard is the easiest from start to start, so this kind of pasting is very common in my workflow. I often do `Ctrl+C`, `Ctrl+V`, `Ctrl+V` to duplicate lines; with this bug, this will add two additional indentations to the next line, which is potentially unrelated to the copied lines. | help wanted,typescript,javascript,editor-autoindent,under-discussion,on-unit-test | low | Critical |
530,048,161 | rust | Both the name of and the docs for `MaybeUninit::uninit_array()` make what it actually does somewhat unclear | Basically, based on the name of the function, and also the part of the docs for it that says:
`Create a new array of MaybeUninit<T> items, in an uninitialized state.`
I initially had the impression that it internally amounted to:
`MaybeUninit::<[MaybeUninit<T>; LEN]>::uninit()`
and returned an uninitialized array of uninitialized MaybeUninits.
However, after looking at the source, I realized it actually amounts to:
`MaybeUninit::<[MaybeUninit<T>; LEN]>::uninit().assume_init()`
and returns an initialized array of uninitialized MaybeUninits (which is what I actually needed, so that's good at least!) | C-enhancement,T-libs-api,A-docs,A-array | low | Minor |
530,051,066 | vscode | [folding] add command unfold block comments | On key bindings, the Fold Level 2 for me works great but it folds methods AND block comments.
As there's an option to "Fold all block comments" I think it would be useful to exist also an option for the unfolding of block comments. | help wanted,feature-request,editor-folding | low | Major |
530,100,926 | TypeScript | maintain certain class property characteristics in mapped types, like protected/private visibility, and instance property vs instance function | ## Search Terms
mapped types with protected private members
## Suggestion
Feature request:
Allow types/interfaces to contain member visibility as well as property type ("instance member function" vs "instance member property") and perhaps other intrinsics.
Or at least keep these characteristics intact in mapped types where the mapped type is generated from class types.
## Use Cases
I've made a function called `multiple` that allows me to do multiple inheritance. In plain JavaScript, it works fine, like this:
```js
class One {one() {}}
class Two {two() {}}
class Three {three() {}}
class Four extends multiple(One, Two, Three) {
test() {
this.one() // OK
this.two() // OK
this.three() // OK
}
}
```
So far, after making type definitions for `multiple()`, the above works fine in TypeScript. [playground example](http://www.typescriptlang.org/play/#code/PQ18ZXTt3BYAUCABAWQK4BsAuBLAB2wFNV8A7ACxICd9cBDCgYzPwFtiSOSKmCAewoAaVLgCehEgGdUw7BNQAzQbVQAjWiQBuDCQC5U8RCmCoAKjRU5s5LqV79GQiqgDuDKuQoN8jOxkSXHllcVlcOXw5F1QqXFxCGQMQAHMvTA0AOhZBDmBcWkwZAGtC4GxBdxZsRhkZZGQAExIaxm0bVldUDhwCbgAeC1QSAA9cPia5AGFhGULMFlw1AG0AXQA+AAos3bb62SMLAEojWY4NShIm6dqDmSGNxqRKCdplRjZUWYp5oqW1EMRuNJjEKEoALyoADeAF8NjDkABICgkdw7XbtVLJVDMCTrU6WZEURi8Ix-SipZCw56SaSoADKVHwylwQLGEwoU1x4PWCKhWwxWSxOJOqAhCLxx2BnO5WwA+kY8WJdsLaNijJRlHRUAAlaUSnlKAD8etQRlROjoyDpZHQ+FG1wAgrRaIwJOyQVyZnMFgDaAM8Rs+eLUPL7Y6mi63R6LGI4U8kLawxHna73Z7ZT7fn7lgGg+sxABVfmIpBIgAMFrRqC2BoRReRAEYjOGHWmYwNkUimSy2RYNiJu9Du0iVgBpHyoEokCSCMIASRzzDYFikJCGKwrm1QAB9p7P56gi2sjJOOaCD3OwkXUKaixO1ubUEv5iuSGvpJvt8Hx2tuzS5aJrCKwWCsADkpAUKkuBUOBT4Xt6qAVneyHPk2-5IDa67fHklyojcdxBA8A6hsMiHcusyKmraR4APIaAAVq0uDIkcMqXiseKYUippgdubGWBxSE-H8ix5lR5amqmUbprGiZIkYmBciQyhXE0zwmFp2k6bpMDIGgYyktwxh6WZ5m6cg+xyHRqIwsIJB1jCsKAdZljuIIMK4B5Tlwq5RGWFQ2hkNCsHBb5LlWQFABigiYOoFFyL0eBEKQWy2SQYgWB5WVBSQJDSiOSCoOE8y+cgJUlbB0RZA5TloHR44VZV1UyFk3mCPV5iNc1VXMm1YX5V1qA9cVqCAbCQA).
However when making properties protected or private, those properties are lost from the mapped type returned from `multiple()`, and therefore inheritance of protected (or denial of accessing private) members doesn't work:
```ts
class One {protected one() {}}
class Two {protected two() {}}
class Three {private three() {}}
class Four extends multiple(One, Two, Three) {
test() {
this.one() // ERROR, Property 'one' does not exist on type 'Four'. Expected no error.
this.two() // ERROR, Property 'two' does not exist on type 'Four'. Expected no error.
this.three() // ERROR, Property 'three' does not exist on type 'Four'. Expected an error relating to private access.
}
}
```
Here's the [playground example](http://www.typescriptlang.org/play/#code/PQ18ZXTt3BYAUCABAWQK4BsAuBLAB2wFNV8A7ACxICd9cBDCgYzPwFtiSOSKmCAewoAaVLgCehEgGdUw7BNQAzQbVQAjWiQBuDCQC5U8RCmCoAKjRU5s5LqV79GQiqgDuDKuQoN8jOxkSXHllcVlcOXw5F1QqXFxCGQMQAHMvTA0AOhZBDmBcWkwZAGtC4GxBdxZsRhkZZGQAExIaxm0bVldUDhwCbgAeC1QSAA9cPia5AGFhGULMFlw1AG0AXQA+AAos3bb62SMLAEojWY4NShIm6dqDmSGNxqRKCdplRjZUWYp5oqW1EMRuNJjEKEoALyoADeAF8NjDkABICgkdw7XbtVLJVDMCTrU6WZEURi8Ix-SipZCw56SaSoADKVHwylwQLGEwoU1x4PWCKhWwxWSxOJOqAhCLxx2BnO5WwA+kY8WJdsLaNijJRlHRUAAlaUSnlKAD8etQRlROjoyDpZHQ+FG1wAgrRaIwJOyQVyZnMFgDaAM8Rs+eLUPL7Y6mi63R6LGI4U8kLawxHna73Z7ZT7fn7lgGg+sxABVfmIpBIgAMFrRqC2BoRReRAEYjOGHWmYwNkUimSy2RYNiJu9Du0iVgBpHyoEokCSCMIASRzzDYFikJCGKwrm1QAB9p7P56gi2sjJOOaCD3OwkXUKaixO1ubUEv5iuSGvpJvt8Hx2tuzS5aJrCKwWCsADkpAUKkuBUOBT4Xt6qAVneyHPk2-5IDa67fHklyojcdxBA8A6hsMiHcusyKmraR4APIaAAVq0uDIkcMqXiseKYUippgdubGWBxSE-H8ix5lR5amqmUbprGiZIkYmBciQyhXE0zwmFp2k6bpMDIGgYyktwxh6WZ5m6c8+xyHRqIwoQtCCBMSzXPIqJ1jCsKAdZljuII9mOc5ExNOIfkeXC3lEZYVDaGQ0IOfgOguGQsGxeFXnID5ABigiYOoFFyL0eBEKQWy2SQYgWH5lUxSQJDSiOSCoOE8zhcgzXNbB0RZMIJAeWgACiuq6nRupiAACo50i0JIqDgb14GoE0giyKgFBOcC0QhMI4g4eBOV5eBWSoANozSC5IXrSMrpqFk7UdV1MhZLgYXSoNw2jRNU10LN4EvYIi3Lat60hGMW1ubt9L7bltBHSdZ0sa5V10I5tB3U1D3Mk9qV1f15hDSNY2oJNgjTb9OMkIDK1yCDm3zBDybQ4dx2nedwU8tdqOoNotQENB4j+QlSUTLiLBsPU6PNYBsJAA).
Because the `private` properties are deleted from the mapped type (just like the `protected` ones are), it becomes possible to inadvertently use `private` properties because the type system says they don't exist:
```ts
class One { private foo = 1 }
class Two { }
class Three extends multiple(One, Two) {
foo = false
test() {
this.foo = true // Uh oh! There's no error using the private property!
}
}
```
Here's the [playground example](http://www.typescriptlang.org/play/?ssl=64&ssc=2&pln=43&pc=1#code/PQ18ZXTt3BYAUCABAWQK4BsAuBLAB2wFNV8A7ACxICd9cBDCgYzPwFtiSOSKmCAewoAaVLgCehEgGdUw7BNQAzQbVQAjWiQBuDCQC5U8RCmCoAKjRU5s5LqV79GQiqgDuDKuQoN8jOxkSXHllcVlcOXw5F1QqXFxCGQMQAHMvTA0AOhZBDmBcWkwZAGtC4GxBdxZsRhkZZGQAExIaxm0bVldUDhwCbgAeC1QSAA9cPia5AGFhGULMFlw1AG0AXQA+AAos3bb62SMLAEojWY4NShIm6dqDmSGNxqRKCdplRjZUWYp5oqW1EMRuNJjEKEoALyoADeAF8NjDkABICgkdw7XbtVLJVDMCTrU6WZEURi8Ix-SipZCw56SaSoADKVHwylwQLGEwoU1x4PWCKhWwxWSxOJOqAhCLxx2BnO5WwA+kY8WJdsLaNijJRlHRUAAlaUSnlKAD8etQRlROjoyDpZHQ+FG1wAgrRaIwJOyQVyZnMFgDaAM8Rs+eLUPL7Y6mi63R6LGI4U8kLawxHna73Z7ZT7fn7lgGg+sxABVfmIpBIgAMFrRqC2BoRReRAEYjOGHWmYwNkUimSy2RYNiJu9Du0iVgBpHyoEokCSCMIASRzzDYFikJCGKwrm1QAB9p7P56gi2sjJOOaCD3OwkXUKaixO1ubUEv5iuSGvpJvt8Hx2tuzS5aJrCKwWCsADkpAUKkuBUOBT4Xt6qAVneyHPk2-5IDa67fHklyojcdxBA8A6hsMiHcusyKmraR4APIaAAVq0uDIkcMqXiseKYUippgdubGWBxSE-H8ix5lR5amqmUbprGiZIkYmBciQyhXE0zwmFp2k6bpMDIGgYyktwxh6WZ5m6c8+xyHRqIwqghD0DoLhkKogihk2qCAdZljuO50JecgPlWNoZAUXIvR4EQpBbLZJBiBYfnSiO5ZuaGHzYEEyITPMdZlkiSKwdEWRpVCCxkGgRbeIIVAAISWDQ2jgXIFDuXQtBqKgxSUuI1iOfgzkTA5HXSLQki1cigGAQZ5hWGQjAaIIVqoDIVCCDgTSaCQVCMMt2D4DOvXRAYyApUiPlxfZ-WDa5gjuVCnmAedRENaFwncpdZ1IqVKgBFl5aFREeVfYVzIyCVd2huVpnHtVVBiEVciret2Cba1IQaPN2CVO41xZABk3Upp5idfth2IydSBnRddkBddLkqJDD2BeWwVUG94WoJ9MMAKK6rqdG6mIqR3U0E0Az9TbdjluDA6OiMQ-d4hFBV5h8wLQuoCLghiwT5ZTUAA).
Another problem is methods of the classes passed into `multiple()` are converted from `instance member function` to `instance member property`, and this happens:
```ts
class One {one() {}}
class Two {two() {}}
class Three {three() {}}
class Four extends multiple(One, Two, Three) {
one() {} // ERROR, Class '{ three: () => void; two: () => void; one: () => void; }' defines instance member property 'one', but extended class 'Four' defines it as instance member function.(2425)
}
```
Here's the [playground example](http://www.typescriptlang.org/play/#code/PQ18ZXTt3BYAUCABAWQK4BsAuBLAB2wFNV8A7ACxICd9cBDCgYzPwFtiSOSKmCAewoAaVLgCehEgGdUw7BNQAzQbVQAjWiQBuDCQC5U8RCmCoAKjRU5s5LqV79GQiqgDuDKuQoN8jOxkSXHllcVlcOXw5F1QqXFxCGQMQAHMvTA0AOhZBDmBcWkwZAGtC4GxBdxZsRhkZZGQAExIaxm0bVldUDhwCbgAeC1QSAA9cPia5AGFhGULMFlw1AG0AXQA+AAos3bb62SMLAEojWY4NShIm6dqDmSGNxqRKCdplRjZUWYp5oqW1EMRuNJjEKEoALyoADeAF8NjDkABICgkdw7XbtVLJVDMCTrU6WZEURi8Ix-SipZCw56SaSoADKVHwylwQLGEwoU1x4PWCKhWwxWSxOJOqAhCLxx2BnO5WwA+kY8WJdsLaNijJRlHRUAAlaUSnlKAD8etQRlROjoyDpZHQ+FG1wAgrRaIwJOyQVyZnMFgDaAM8Rs+eLUPL7Y6mi63R6LGI4U8kLawxHna73Z7ZT7fn7lgGg+sxABVfmIpBIgAMFrRqC2BoRReRAEYjOGHWmYwNkUimSy2RYNiJu9Du0iVgBpHyoEokCSCMIASRzzDYFikJCGKwrm1QAB9p7P56gi2sjJOOaCD3OwkXUKaixO1ubUEv5iuSGvpJvt8Hx2tuzS5aJrCKwWCsADkpAUKkuBUOBT4Xt6qAVneyHPk2-5IDa67fHklyojcdxBA8A6hsMiHcusyKmraR4APIaAAVq0uDIkcMqXiseKYUippgdubGWBxSE-H8ix5lR5amqmUbprGiZIkYmBciQyhXE0zwmFp2k6bpMDIGgYyktwxh6WZ5m6c8+xyHRqIwsIJB1jCsKAdZljuIIMK4B5Tlwq5RGWFQ2hkNCsHBb5LnIG5ABigiYOoFFyL0eBEKQWy2SQYgWB5WVBSQJDSiO5YORFpmoAAorqup0bqYi3HUcjgdC4h5SQRhOYaOiCPgTQANziB57X1qgXU9f1DlDeKCKjX1qCwuBqAtGpqJRMurBkLwFw6oQtCCNItCSKg4EOeBYgaJgIQUdcqBueBsXxQtS1XFEIR1D4b7rT0PAaDqyjKUs+DCFkWwAEwACwgwArMc1JAA).
## Related
- https://github.com/microsoft/TypeScript/issues/26760
- https://github.com/microsoft/TypeScript/issues/7124
- https://github.com/microsoft/TypeScript/issues/3854
## Checklist
My suggestion meets these guidelines:
* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code **I'm not sure**
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | medium | Critical |
530,125,450 | pytorch | [ONNX] Support affine_grid_generator | ```python
import torch
import torch.nn as nn
class Model(nn.Module):
def __init__(self):
super(Model, self).__init__()
def forward(self, theta, size):
return torch.nn.functional.affine_grid(theta, size, align_corners=None)
model = Model()
theta = torch.ones((1, 2, 3))
size = torch.Size((1,3,24,24))
torch.onnx.export(model, (theta, size), 'test.onnx', verbose=True)
```
Result:
`RuntimeError: Exporting the operator affine_grid_generator to ONNX opset version 9 is not supported.` | module: onnx,triaged,enhancement,onnx-triaged | medium | Critical |
530,127,801 | flutter | Ensure Android embedding works with Navigation component | Jetpack has introduced a Navigation component:
https://developer.android.com/guide/navigation/navigation-getting-started
This ticket is to ensure that `FlutterFragment` can work with the Navigation component, and to produce any relevant docs/guides for add-to-app developers to do so. | platform-android,engine,a: existing-apps,P2,team-android,triaged-android | low | Major |
530,153,273 | vscode | Incorrect keyboard shortcut shown in menu. | <!-- Please search existing issues to avoid creating duplicates. -->
<!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.40.2 (also happens in 1.41.0-insider)
- OS Version: Pop!_OS 19.10 64-bit (which is very much like Ubuntu 19.10 Eoan Ermine)
Steps to Reproduce:
1. Press Ctrl+K, Ctrl+S to open the keyboard shortcut editor;
2. Find the entry for toggling the Activity Bar (`workbench.action.toggleActivityBarVisibility`)
3. Set its keybinding to "Ctrl + Super + A", which shouldn't be used by anything else by default; "Super" is the "Windows" key on PC keyboards, also known as the meta key in Linux.
4. Close the keyboard shortcut editor;
5. Open the "View" menu --> "Appearance"
6. See that the keyboard shortcut displayed next to "Show Activity Bar" is "Ctrl+A" instead of "Ctrl+Super+A"
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
| bug,help wanted,upstream,linux,menus,confirmed,chromium | low | Major |
530,201,131 | pytorch | `F.interpolate` returns unexpected result when dealing with output size `1` | ## ๐ Bug
Generally, when shrinking a image to half of its height/weight, `F.interpolate` with `mode='bilinear'` and `align_corners=False` should be equivalent to `F.avg_pool2d(2)`, and I use this fact to try out things like "will using better interpolation rather than pooling get better result" and etc.
But I found my model will fail to optimize if I change `F.interpolate` to `F.avg_pool2d` (e.g. having 10% accuracy where there are 10 classes). After a lot of separation of modules, I finally found the problem above.
It seems that `F.interpolate(a, 1, ...)` with `2x2 a` actually returns `a[...,:1,:1]` currently. I believe this should be a bug.
## To Reproduce
Steps to reproduce the behavior:
```python
import torch
import torch.nn.functional as F
a = torch.rand(1, 1, 2, 2)
b = F.interpolate(a, 1, mode='bilinear', align_corners=False)
b==a, b==a.mean((2,3),True)
```
outputs
```python
(tensor([[[[ True, False],
[False, False]]]]), tensor([[[[False]]]]))
```
## Expected behavior
A `[[False, False], [False, False]]` Tensor (generally) and a `True` tensor
## Environment
```
PyTorch version: 1.2.0
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Ubuntu 19.10
GCC version: (Ubuntu 9.2.1-9ubuntu2) 9.2.1 20191008
CMake version: Could not collect
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: GeForce GTX 1080
Nvidia driver version: 440.26
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] numpy==1.17.2
[pip] torch==1.2.0
[pip] torchvision==0.4.0a0
[conda] _pytorch_select 0.2 gpu_0 defaults
[conda] blas 1.0 mkl defaults
[conda] mkl 2019.4 243 defaults
[conda] mkl-service 2.3.0 py37he904b0f_0 defaults
[conda] mkl_fft 1.0.15 py37ha843d7b_0 defaults
[conda] mkl_random 1.1.0 py37hd6b4f25_0 defaults
[conda] pytorch 1.2.0 cuda100py37h938c94c_0 defaults
[conda] torchvision 0.4.0 cuda100py37hecfc37a_0 defaults
```
cc @albanD @mruberry @fmassa @vfdev-5 @ezyang @SsnL @zou3519 @gqchen | module: nn,triaged,module: vision,module: interpolation | low | Critical |
530,213,187 | flutter | [TextEditingController] listeners are triggered inconsistently | - at andriod
1. type 1
2.delete it
console shows:
1
(space)
- at ios
1. type 1
2. delete it
console shows:
1
1
(space)
Maybe I am not understood, so you can see this simple demo about that problem
[demo](https://github.com/sweatfryash/TextField_Demo)
<details>
<summary>sample</summary>
```
import 'package:flutter/material.dart';
class MyHomePage extends StatefulWidget{
@override
State<StatefulWidget> createState() {
return MyHomePageState();
}
}
class MyHomePageState extends State<MyHomePage>{
//create a controller for TextField
TextEditingController _controller = TextEditingController();
@override
void initState() {
super.initState();
//add a listener
_controller.addListener((){
if(_controller.text.isEmpty){
print('++++++++ now ๏ผ_controller.text.isEmpty๏ผ is TRUE ++++++++');
print(_controller.text);
print(_controller.text.runtimeType);
}else{
print('-------- now ๏ผ_controller.text.isEmpty๏ผ is FALSE ---------');
print(_controller.text);
print(_controller.text.runtimeType);
}
setState(() {});
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: (Text('Demo')),
),
body: Center(
child: TextField(
controller: _controller,
decoration: InputDecoration(
hintText: 'type and delete and look the console'
),
),
),
);
}
}
```
</details> | a: text input,platform-ios,framework,P2,found in release: 2.2,team-ios,triaged-ios | low | Major |
530,250,508 | ant-design | The Select component with showAction focus and click is closed immediately when the previously selected component has a blur action with an expensive function | - [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate.
### Reproduction link
[](https://codesandbox.io/s/antd-input-select-bug-moend)
### Steps to reproduce
When you click on the input and then click on the select, the options will be show and hidden immediately.
### What is expected?
The select options are shown and don't hide when the focus event arrives.
### What is actually happening?
The select options are hidden immediately when the focus event arrives.
| Environment | Info |
|---|---|
| antd | 3.25.3 |
| React | latest (16.12.0) |
| System | macOS Catalina 10.15 |
| Browser | Chrome/78.0.3904.108 |
---
This only passes when the previously selected component has a blur action with an expensive function.
**Refs:**
https://github.com/ant-design/ant-design/issues/14296
https://github.com/ant-design/ant-design/issues/6873
<!-- generated by ant-design-issue-helper. DO NOT REMOVE --> | Inactive | low | Critical |
530,351,188 | vscode | [css] Support for SVG 2 CSS Properties | SVG 2 introduces the possibility of setting SVG properties in CSS (see [CSS Tricks' post](https://css-tricks.com/svg-properties-and-css/) under "Element-specific properties -> "Positioning SVG elements"). This means this example should be valid:
```css
circle {
r: 2;
cx: 10;
cy: 100;
}
path {
d: 'L0 100';
}
```
However, these properties trigger the `s?css(unknownProperties)` warning:
I'm not too familiar with VS Code's insides and what program checks for valid properties. If this belongs somewhere else, I'd be happy to re-issue there.
Thanks! โจ | help wanted,feature-request,css-less-scss | medium | Critical |
530,359,727 | PowerToys | Uniform error handling & reporting | # Summary of the new feature/enhancement
Currently there's no established flow for reporting errors to the user, e.g. when some of the saved settings are missing/malformed or some system API call failed.
Also there're multiple places in the code where all exceptions are silently swallowed.
I suggest establishing error handling practice and reporting via e.g. floating tray notifications or logging, depending if whether an error is recoverable or not.
To sum up:
- handle exceptions/error codes instead of silently ignoring/crashing with them
- introduce some uniform mechanism for reporting recoverable errors to user
Sub task: log is saved to `AppData\Local\Microsoft\PowerToys\`
- [ ] Color Picker
- [ ] FancyZones
- [ ] File Explorer add-ons
- [ ] Image Resizer
- [ ] Keyboard Manager
- [ ] PowerRename
- [ ] PowerToys Run
- [ ] Shortcut Guide
- [ ] Settings
- [ ] Runner
Sub task: log is included in the Bug Report
- [ ] Color Picker
- [ ] FancyZones
- [ ] File Explorer add-ons
- [ ] Image Resizer
- [ ] Keyboard Manager
- [ ] PowerRename
- [ ] PowerToys Run
- [ ] Shortcut Guide
- [ ] Settings
- [ ] Runner
Sub task: all catch exceptions are properly handled or logged
- [ ] Color Picker
- [ ] FancyZones
- [ ] File Explorer add-ons
- [ ] Image Resizer
- [ ] Keyboard Manager
- [ ] PowerRename
- [ ] PowerToys Run
- [ ] Shortcut Guide
- [ ] Settings
- [ ] Runner
While investigating this, also update https://github.com/microsoft/PowerToys/issues/8419 | Area-Runner,Area-Quality,Priority-1,Area-Logging | low | Critical |
530,365,732 | pytorch | Assertion `index >= -sizes[i] && index < sizes[i] && "index out of bounds"` failed. | ## ๐ Bug
lambda [](int)->auto::operator()(int)->auto: block: [0,0,0], thread: [3,0,0] Assertion `index >= -sizes[i] && index < sizes[i] && "index out of bounds"` failed.
lambda [](int)->auto::operator()(int)->auto: block: [0,0,0], thread: [6,0,0] Assertion `index >= -sizes[i] && index < sizes[i] && "index out of bounds"` failed.
lambda [](int)->auto::operator()(int)->auto: block: [0,0,0], thread: [7,0,0] Assertion `index >= -sizes[i] && index < sizes[i] && "index out of bounds"` failed.
lambda [](int)->auto::operator()(int)->auto: block: [0,0,0], thread: [8,0,0] Assertion `index >= -sizes[i] && index < sizes[i] && "index out of bounds"` failed.
lambda [](int)->auto::operator()(int)->auto: block: [0,0,0], thread: [9,0,0] Assertion `index >= -sizes[i] && index < sizes[i] && "index out of bounds"` failed.
## To Reproduce
Steps to reproduce the behavior:
1. a = torch.randperm(10).cuda()
1. b = torch.randn(5).cuda()
1. b = b[a]
## Expected behavior
IndexError: index 6 is out of bounds for dimension 0 with size 5
## Environment
Collecting environment information...
PyTorch version: 1.4.0a0+dd52f50
Is debug build: No
CUDA used to build PyTorch: 9.0
OS: Ubuntu 16.04.6 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.12) 5.4.0 20160609
CMake version: version 3.15.3
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration: GPU 0: GeForce GTX 1080
Nvidia driver version: 384.130
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.6.0.21
/usr/lib/x86_64-linux-gnu/libcudnn.so.7.1.2
Versions of relevant libraries:
[pip3] numpy==1.17.4
[pip3] torch==1.4.0a0+dd52f50
[conda] Could not collect
## Additional context
<!-- Add any other context about the problem here. -->
cc @ngimel | module: cuda,module: error checking,triaged | low | Critical |
530,380,531 | godot | Procedural Generation for Android app | @#**Godot version:**
3.1.1
**OS/device including version:**
Linx Mint 19.2
**Issue description:**
Collision mesh crashes the app on GLES2
**Steps to reproduce:**
click the buttons in the minimal reporduction project.
**Minimal reproduction project:**
https://we.tl/t-zesbP4RB7P
Hello,
I have an issue with exporting my game to android.
I create a procedural map with a noise texture and there is no issue on pc and android (GLES3), but if I change Godot to GLES2, my game crashes due to the collision mesh generation.
I made an minimal reproduction project, where I tried to recreate the problem for one quadratic tile. ou can click the buttons above to see the problem.
I also tried to create it with an CSGMesh, which wasnt successfull either.
Unfortunatly, the app crashes before an debug output, so I am not sure what exactly crashes.
Thanks for your help.
| bug,platform:android,topic:porting,topic:physics | low | Critical |
530,431,708 | rust | Printing of closure types and MIR closure constructors | Quoting @eddyb in https://github.com/rust-lang/rust/pull/66850#issuecomment-559599865
> I'm not that happy with `[closure@PATH::{{closure}}#n ...]`, but it's consistent with what we have so far, if we want to go further I'd prefer something like this:
> ```rust
> foo<T>::{closure#0} { q:&i32, t:&T }
> ```
> (yes, `{{closure}}#n` -> `{closure#n}` is a change we should do eventually, IMO)
> and without `-Z span_free_formats` we could perhaps go for:
> ```rust
> closure(src/main.rs:10:13) { q:&i32, t:&T }
> ```
> (and we need to remember to fix generators as well)
>
> Oh and we could also change `fn` definition types from:
> ```rust
> fn(bool) -> bool {std::convert::identity::<bool>}
> ```
> to:
> ```rust
> fn std::convert::identity::<bool>(bool) -> bool
> ``` | A-pretty,C-enhancement,A-closures,T-compiler,A-MIR | low | Minor |
530,446,705 | fastapi | First-class session support in FastAPI | ### Is your feature request related to a problem
All of the security schemas currently supported by FastAPI rely on some sort of "client-server synergy" , where, for instance, the client is expected to know and remember an OAuth token or the user credentials to be sent via headers. This works fairly well for single-page applications, but if you need to integrate authentication to an app that uses templates, keeping track of that authentication data becomes a challenge. Most applications would use server-side sessions to deal with this, but FastAPI doesn't really have a system to deal with sessions right now.
### Describe alternatives you've considered
#### Using Starlette's SessionMiddleware
While Starlette's `SessionMiddleware` is mentionned a number of times in the FastAPI documentation, it does not integrate very well with the framework itself . What it does is that it adds a `request.session` dict on the `Request` object that lets the backend store and retreive information from it, and just before the response get sent, [that dict is serialized, combined to a timestamp, signed, converted into base 64 and appended as a cookie](https://github.com/encode/starlette/blob/b8bd1696492e501bd617bd151278999c68b30e2b/starlette/middleware/sessions.py#L52-L63). The client is then expected to send theat cookie back so that the server so that information can be decoded and used. This is what the Django doc describes as [the cookie-based approach](https://docs.djangoproject.com/en/2.2/topics/http/sessions/).
The problem with all this is that the entire process happens outside of what FastAPI can handle, and therefore does not appear in the generated OpenAPI documentation as an authentication schema.
Having read the source for that middleware and the documentation for itsdangerous, I also understand that this kind of "session blob" authentication method isn't really supported by OpenAPI, since all supported auth methods are expected to use constants to handle authentication.
### The solution you would like
Ideally, I would like to see FastAPI adding some kind of `SessionCookie[T]` class to `fastapi.security`, that would register a cookie-based API key authentication method (which is [what Swagger reccomands](https://swagger.io/docs/specification/authentication/cookie-authentication/), since sessions are out of scope for the OpenAPI spec). Those "API keys" would be session tokens, much like the It should also register that routes that depend on that security schema may reply with a `Set-Cookie` header.
The question of how that data would be persisted afterwards is an open one. Having a one-size-fits-all implementation as the only one available could be constraining, so there's always the option of a `fastapi.security.sessions` namespace containing things like `MemorySessionStorage`, `DatabaseSessionStorage`, `FileSessionStorage` and so on.
### Additional context
Maybe something like this?
```py
from fastapi import Depends, FastAPI
from fastapi.security.sessions import SessionCookie, MemorySessionStorage
from pydantic import BaseModel
from datetime import timedelta
app = FastAPI()
class SessData(BaseModel):
# BaseModel so it can be serialized and stored properly
uname: str
security = SessionCookie[SessData](
name='fastapi_sess',
expires=timedelta(hours=1).
backend=MemorySessionStorage(),
auto_error=False
)
@app.get('/secure/rm_rf/{path:path}')
def secure_thing(path: str, session: Optional[SessData] = Depends(security)):
if session is not None and session.uname == 'root':
# ...
```
| feature,reviewed | high | Critical |
530,463,224 | create-react-app | Improve comments for file-loader | ### Is your proposal related to a problem?
Right now, `file-loader` is setup to "catch" all files that were not handled by other loaders.
But for some reason we *exclude* only some extensions and not the others.
There is a comment that tries to explain this: https://github.com/facebook/create-react-app/blob/29c5e55adef2ce11e69b8d9584a664e94e6d9151/packages/react-scripts/config/webpack.config.js#L564-L568
I'm really thankful that there is a comment that tries to clear up what's going on, but I think it failed here. I read it several times and I have no idea why we exclude script files and not css files.
### Describe the solution you'd like
If someone could explain it a little bit better here I'd love to help improve this part of the file.
| issue: proposal,needs triage | low | Critical |
530,478,972 | opencv | Feature request: support batch resize | ##### System information (version)
- OpenCV => 4.1.2
- Operating System / Platform => Ubuntu 18.04
- Compiler => gcc 8.3
##### Detailed description
We already have resize functionality [link](https://docs.opencv.org/4.1.2/da/d54/group__imgproc__transform.html#ga47a974309e9102f5f08231edc7e7529d) (cuda version [link](https://docs.opencv.org/4.1.2/db/d29/group__cudawarping.html#ga4f5fa0770d1c9efbadb9be1b92a6452a) ) but some libraries that opencv work with e.g. CUDA, support batch resize [link](https://docs.nvidia.com/cuda/npp/group__image__resize__batch.html)
Would it be possible to make that available as well?
| feature,priority: low,category: gpu/cuda (contrib) | low | Minor |
530,480,090 | go | gollvm: runc runtime error, broken pipe | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13 gollvm LLVM 10.0.0svn linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<pre>
Ubuntu 18.04.3 LTS, x86_64
</pre>
### What did you do?
[helloworld_rootfs.tar.gz](https://github.com/golang/go/files/3906297/helloworld_rootfs.tar.gz)
<pre>
$ cd <workdir>
$ git clone https://github.com/opencontainers/runc.git
$ cd runc
$ mkdir -p .gopath/src/github.com/opencontainers/
$ ln -sf `pwd` `pwd`/.gopath/src/github.com/opencontainers/runc
$ export GOPATH=`pwd`/.gopath
$ cd .gopath/src/github.com/opencontainers/runc/
$ go build -tags "seccomp" -o runc .
$ cd <workdir>
$ mkdir mycontainer
$ cp helloworld_rootfs.tar.gz mycontainer
$ cd mycontainer
$ tar -xf helloworld_rootfs.tar.gz
$ ../runc/runc spec --rootless
$ sed -i 's;"sh";"/hello";' config.json
$ ../runc/runc run mycontainer
</pre>
### What did you expect to see?
<pre>
Hello from Docker!
This message shows that your installation appears to be working correctly.
...
</pre>
### What did you see instead?
<pre>
$ ../runc/runc run mycontainer
WARN[0000] exit status 127
ERRO[0000] container_linux.go:346: starting container process caused "process_linux.go:315: copying bootstrap data to pipe caused \"write init-p: broken pipe\""
container_linux.go:346: starting container process caused "process_linux.go:315: copying bootstrap data to pipe caused \"write init-p: broken pipe\""
$ gdb --args ../runc/runc run mycontainer
...
Thread 6 "runc" received signal SIGPIPE, Broken pipe.
[Switching to Thread 0x7fffe97f8700 (LWP 17662)]
0x00007ffff59ed187 in __GI___libc_write (fd=7, buf=0xc000236100, nbytes=64) at ../sysdeps/unix/sysv/linux/write.c:27
27 ../sysdeps/unix/sysv/linux/write.c: No such file or directory.
(gdb) bt
#0 0x00007ffff59ed187 in __GI___libc_write (fd=7, buf=0xc000236100, nbytes=64) at ../sysdeps/unix/sysv/linux/write.c:27
#1 0x00007ffff717a768 in syscall.write (fd=7, p=...) at build.rel/tools/gollvm/libgo/libcalls.go:2654
#2 syscall.Write (fd=7, p=...) at llvm/tools/gollvm/gofrontend/libgo/go/syscall/syscall_unix.go:168
#3 0x00007ffff6f6eb23 in internal..z2fpoll.FD.Write (fd=0xc0000ec1e0, p=...)
at llvm/tools/gollvm/gofrontend/libgo/go/internal/poll/fd_unix.go:268
#4 0x00007ffff70a1a62 in os.File.write (f=0xc0000f6040, b=...)
at llvm/tools/gollvm/gofrontend/libgo/go/os/file_unix.go:290
#5 0x00007ffff70a0f4e in os.File.Write (f=0xc0000f6040, b=...)
at llvm/tools/gollvm/gofrontend/libgo/go/os/file.go:153
#6 0x00007ffff6d10674 in bytes.Reader.WriteTo (r=0xc0000f2270, w=...)
at llvm/tools/gollvm/gofrontend/libgo/go/bytes/reader.go:144
#7 0x00007ffff6f8ef33 in io.copyBuffer (dst=..., src=..., buf=...)
at llvm/tools/gollvm/gofrontend/libgo/go/io/io.go:384
#8 0x00007ffff6f8ecfd in io.Copy (dst=..., src=...) at llvm/tools/gollvm/gofrontend/libgo/go/io/io.go:364
#9 0x0000000000621d87 in github.x2ecom..z2fopencontainers..z2frunc..z2flibcontainer.initProcess.start (p=0xffffffffffffffe0)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/libcontainer/process_linux.go:314
#10 0x0000000000624f33 in github.x2ecom..z2fopencontainers..z2frunc..z2flibcontainer.linuxContainer.start (c=0xc0000bc2d0,
process=0xc0000a2780)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/libcontainer/container_linux.go:341
#11 0x00000000006193a3 in github.x2ecom..z2fopencontainers..z2frunc..z2flibcontainer.linuxContainer.Start (c=0xc0000bc2d0,
process=0xc0000a2780)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/libcontainer/container_linux.go:241
#12 0x0000000000618e2a in github.x2ecom..z2fopencontainers..z2frunc..z2flibcontainer.linuxContainer.Run (c=0xc0000bc2d0,
process=0xc0000a2780)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/libcontainer/container_linux.go:251
#13 0x0000000000608235 in main.runner.run (r=0xffffffffffffffe0, config=0xc00010c0e0)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/utils_linux.go:324
#14 0x0000000000603093 in main.startContainer (context=<optimized out>, spec=0xffffffffffffffe0, action=2 '\002', criuOpts=<optimized out>)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/utils_linux.go:452
#15 0x000000000060cf9f in main.func13 (context=0xc0000ac840)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/run.go:76
#16 0x000000000066eeec in github.x2ecom..z2fopencontainers..z2frunc..z2fvendor..z2fgithub.x2ecom..z2furfave..z2fcli.HandleAction (
action=..., context=0xc0000ac840)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:495
#17 0x0000000000669e6e in github.x2ecom..z2fopencontainers..z2frunc..z2fvendor..z2fgithub.x2ecom..z2furfave..z2fcli.Command.Run (
pointer=<optimized out>, ctx=0xc0000ac6e0)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/command.go:210
#18 0x000000000066bc19 in github.x2ecom..z2fopencontainers..z2frunc..z2fvendor..z2fgithub.x2ecom..z2furfave..z2fcli.App.Run (
---Type <return> to continue, or q <return> to quit---
a=<optimized out>, arguments=...)
at github_issue/runc/.gopath/src/github.com/opencontainers/runc/vendor/github.com/urfave/cli/app.go:255
#19 0x000000000060b0f1 in main.main () at github_issue/runc/.gopath/src/github.com/opencontainers/runc/main.go:145
</pre>
### Comments
This is a runtime issue of runc built with gollvm. It doesn't reproduce for gccgo and golang 1.10.
I am sorry, I didn't know how to make a short example.
helloworld_rootfs.tar.gz contains hello-world container example created using runc manpages:
[https://github.com/opencontainers/runc/blob/master/man/runc-spec.8.md](url)
<pre>
$ docker pull hello-world
$ docker export $(docker create hello-world) > hello-world.tar
$ mkdir rootfs
$ tar -C rootfs -xf hello-world.tar
</pre> | NeedsInvestigation | low | Critical |
530,492,263 | storybook | Addon-docs: Markdown summary / details blocks should have sbdocs escape hatches | **Describe the bug**
Markdown support collapsable blocks by default with the following syntax:
```
<details><summary>Here's a quick reminder about moment</summary>
bla bla
</details>
```
MDX support this fine but the escape hatches are missing.
**Expected behavior**
The following should be rendered
```
<details class="sbdocs sbdocs-details">
<summary class="sbdocs sbdocs-summary">blabla></summary>
<details>
``` | bug,addon: docs,mdx | low | Critical |
530,497,671 | pytorch | `index_select` with multidimensional `index` | ## ๐ Feature
Let [`index_select`](https://pytorch.org/docs/stable/torch.html#torch.index_select) work with a multidimensional `index`.
## Motivation
Index the input tensor along a given dimension using the entries in a multidimensional array of indices. For example,
```
a = b.index_select(-1, c)
```
should mean
```
a[i, j, k] = b[i, j, k, c[i, j, k]]
```
## Alternatives
**Option 1:**
```
a = b.gather(-1, c[..., None])[..., 0]
```
**Option 2:** Create a meshgrid with the indices `i,j,k,...`. Then create an empty array `a` of the appropriate size. Then assign to `a` as follows:
```
a[i, j, k] = b[i, j, k, c[i, j, k]]
``` | feature,triaged,module: advanced indexing | medium | Major |
530,502,624 | godot | 2D View Helpers are only displayed in the Select Mode | **Godot version:**
3.2.beta
**OS/device including version:**
Solus 4 Gnome
**Issue description:**
Helpers currently are not shown in other 2D View modes, like the Move Mode, they only show in the Select Mode, which is not very helpful. It would be great if they also show at least in the Move Mode, they are very helpful for designing, but designing with the Select Mode is a nightmare because you keep selecting things you didn't want.
**Steps to reproduce:**
1. Create a scene with a Control root
2. Add some control children (labels, buttons and stuff)
3. Go to View -> Show Helpers and enable it
4. Use the Move mode to design your interface
5. Now use the Select mode
| enhancement,topic:editor | low | Minor |
530,505,461 | godot | Unable to access iOS Photo Library |
**Godot version:**
3.2 Beta 2
**OS/device including version:**
Pop OS 19.1
**Issue description:**
Unable to access iOS Photo Library
**Steps to reproduce:**
in iOS export settings, add a PhotoLibrary usage description
OS.request_permissions()
OS.get_system_dir(6) for user photos directory (same code works with android and desktop)
I have also tried using
'/private/var/mobile/Media/DCIM'
When I open a file dialog with that path, I get this path instead:
'/private/var/mobile/Containers/Data/Application/.......'
**Minimal reproduction project:**
| bug,platform:ios,topic:porting | low | Major |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.