id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
β | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
517,762,992 | flutter | App which loading large json files crushes when using flutter drive | I'm writing an app, that supports multiple languages. All translation strings are stored in locale folder in json files (one for each language). This files are loaded as the app starts.
To load data, I use loadString method from AssetBundle class, from flutter/services package. It works fine when I run the app but when I want to test the app with flutter drive, I encounter an issue. If the translation file is 10240 bytes or bigger, the app crashes on test start.
I found, that when the file is 10240 bytes or larger, the loadString method uses different way to load file content, for the performance purposes. I did a workaround by using a step-back load method while testing and then getting string on my own regardless of the size.
To reproduce this, I made a small app from flutter demo app. The main file stays almost the same, with exception of creating MaterialApp object, where I add a translation delegate. The translation is handled by translation.dart file. For the reproducing the issue, there is also needed a json file in locale directory, named "i18n_en_US.json" and with size larger than 10239 bytes.
The issue only occurs while using flutter drive test so there is also a test_driver directory, which contains the app.dart file and app_count_test.dart file. This test is to run the app and tap on Increment button one time. To run test I use "flutter drive --target=test_driver/app.dart --driver=test_driver/app_count_test.dart" command.
```
import 'package:flutter/material.dart';
import 'package:json_test/translations.dart';
void main() => runApp(MyApp());
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
localizationsDelegates: [TranslationsDelegate()],
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
MyHomePage({Key key, this.title}) : super(key: key);
final String title;
@override
_MyHomePageState createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
int _counter = 0;
void _incrementCounter() {
setState(() {
_counter++;
});
}
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title),
),
body: Center(
child: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text(
'You have pushed the button this many times:',
),
Text(
'$_counter',
style: Theme.of(context).textTheme.display1,
),
],
),
),
floatingActionButton: FloatingActionButton(
key: Key('increment_key'),
onPressed: _incrementCounter,
tooltip: 'Increment',
child: Icon(Icons.add),
),
);
}
}
```
```
import 'dart:async';
import 'dart:convert';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart' show ByteData, rootBundle;
class Translations {
Translations(this.locale) {
_localizedValues = null;
}
Locale locale;
static Map<dynamic, dynamic> _localizedValues;
static Translations of(BuildContext context) {
return Localizations.of<Translations>(context, Translations);
}
String text(String key) {
return _localizedValues[key] ?? '** $key not found';
}
static Future<Translations> load(Locale locale) async {
Map<dynamic, dynamic> packageLocalizeValues;
packageLocalizeValues = await _getPackageLocaleJson();
Translations translations = Translations(locale);
_localizedValues ??= {};
_localizedValues.addAll(packageLocalizeValues);
return translations;
}
static Future<Map<dynamic, dynamic>> _getPackageLocaleJson() async {
Map<dynamic, dynamic> packageLocalizeValues = {};
try {
// workaround
// final ByteData data = await rootBundle.load("locale/i18n_en_US.json");
// String localeJson = utf8.decode(data.buffer.asUint8List());
String localeJson = await rootBundle.loadString("locale/i18n_en_US.json");
try {
packageLocalizeValues = json.decode(localeJson);
} catch (e) {
print("Invaid locale json");
return null;
}
} catch (ex) {
print('Could not find assets.');
return null;
}
print('All success!');
return packageLocalizeValues;
}
String get currentLanguage => locale.languageCode;
}
class TranslationsDelegate extends LocalizationsDelegate<Translations> {
TranslationsDelegate();
@override
bool isSupported(Locale locale) => true;
@override
Future<Translations> load(Locale locale) {
return Translations.load(locale);
}
@override
bool shouldReload(TranslationsDelegate old) => false;
}
```
```
import 'package:flutter_driver/driver_extension.dart';
import 'package:json_test/main.dart' as app;
void main() {
enableFlutterDriverExtension();
app.main();
}
```
```
import 'package:flutter_driver/flutter_driver.dart';
import 'package:test/test.dart';
void main() {
FlutterDriver driver;
Future<void> tapAndPrint(String finder) async {
await driver.tap(find.byValueKey(finder));
print('Performed action on $finder');
}
setUpAll(() async {
driver = await FlutterDriver.connect();
print('Driver started');
});
test('Check flutter driver health', () async {
Health health = await driver.checkHealth();
print(health.status);
});
test('Increment', () async {
await tapAndPrint('increment_key');
});
}
``` | framework,t: flutter driver,a: assets,P2,team-framework,triaged-framework | low | Critical |
517,790,226 | flutter | [web] Virtual Keyboard on Raspberry Pi | I am still struggling with this issue. I saw this issue that seemed somewhat related:
https://github.com/flutter/flutter/issues/32763
So if flutter web is used on an iphone, the virtual keyboard sounds like it will come up? I'm wondering then how does flutter know when you're in an environment with or without a physical keyboard? If I'm running in a web browser for example on a raspberry pi, and there is no keyboard plugged in (I haven't gotten hardware to try this yet...) then does the virtual keyboard come up?
Is there a way to force flutter to think I do NOT have a physical keyboard? If I test this on my laptop, the flutter web app works great with my physical keyboard, but I'd like to test with virtual and ultimately I want to us it on a pi with a touch screen so that may already work?
| a: text input,e: device-specific,d: stackoverflow,customer: crowd,platform-web,P3,team-web,triaged-web | medium | Major |
517,795,472 | kubernetes | apiserver http healthcheck | <!-- Please only use this template for submitting enhancement requests -->
**What would you like to be added**:
Apiserver endpoint serving `/healthz` over HTTP, no TLS.
**Why is this needed**:
Coming out of this issue: https://github.com/kubernetes/kubernetes/issues/43784
Running our own, self-signed PKI - we can only use TCP healthchecks for GCP LoadBalancer. It would be great to be able to point the LB healthcheck at a http port exposing the healthcheck.
/sig api-machinery | sig/api-machinery,kind/feature,lifecycle/frozen | low | Major |
517,806,143 | TypeScript | Automatic type package resolving doesnβt respect paths defined | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.8.0-dev.20191105
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
mangled scope package resovle
**Code**
Consider a project layout as follow:
```
$ tree -L 2
.
βββ test.ts
βββ third_party
βΒ Β βββ node_modules
βΒ Β βββ package.json
βΒ Β βββ yarn.lock
βββ tsconfig.json
```
test.ts
```ts
import * as babel from '@babel/core';
```
tsconfig.json
```json
{
"compilerOptions": {
"baseUrl": "./",
"moduleResolution": "node",
"outDir": "tsc-out",
"paths": {
"*": [
"*",
"third_party/node_modules/*",
],
},
"rootDir": "./",
"strict": true,
"traceResolution": true,
},
"include": [
"*.ts",
],
}
```
package.json
```
{
"devDependencies": {
"@babel/core": "^7.7.0",
"@types/babel__core": "^7.1.3",
"typescript": "^3.8.0-dev.20191105"
}
}
```
**Expected behavior:**
Code compiles without an error.
**Actual behavior:**
Code failed to compile.
```
$ ./third_party/node_modules/typescript/bin/tsc -p .
======== Resolving module '@babel/core' from '/Users/xiaoyi/Projects/tsc-mangle-resolve/test.ts'. ========
Explicitly specified module resolution kind: 'NodeJs'.
'baseUrl' option is set to '/Users/xiaoyi/Projects/tsc-mangle-resolve', using this value to resolve non-relative module name '@babel/core'.
'paths' option is specified, looking for a pattern to match module name '@babel/core'.
Module name '@babel/core', matched pattern '*'.
Trying substitution '*', candidate module location: '@babel/core'.
Loading module as file / folder, candidate module location '/Users/xiaoyi/Projects/tsc-mangle-resolve/@babel/core', target file type 'TypeScript'.
Trying substitution 'third_party/node_modules/*', candidate module location: 'third_party/node_modules/@babel/core'.
Loading module as file / folder, candidate module location '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core', target file type 'TypeScript'.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core.ts' does not exist.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core.tsx' does not exist.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core.d.ts' does not exist.
Found 'package.json' at '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/package.json'.
'package.json' does not have a 'typesVersions' field.
'package.json' does not have a 'typings' field.
'package.json' does not have a 'types' field.
'package.json' has 'main' field 'lib/index.js' that references '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js'.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js' exist - use it as a name resolution result.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js' has an unsupported extension, so skipping it.
Loading module as file / folder, candidate module location '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js', target file type 'TypeScript'.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js.ts' does not exist.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js.tsx' does not exist.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js.d.ts' does not exist.
File name '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js' has a '.js' extension - stripping it.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.ts' does not exist.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.tsx' does not exist.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.d.ts' does not exist.
Directory '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js' does not exist, skipping all lookups in it.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/index.ts' does not exist.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/index.tsx' does not exist.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/index.d.ts' does not exist.
Loading module '@babel/core' from 'node_modules' folder, target file type 'TypeScript'.
Directory '/Users/xiaoyi/Projects/tsc-mangle-resolve/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'babel__core'
Directory '/Users/xiaoyi/Projects/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'babel__core'
Directory '/Users/xiaoyi/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'babel__core'
Directory '/Users/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'babel__core'
Directory '/node_modules' does not exist, skipping all lookups in it.
Scoped package detected, looking in 'babel__core'
'baseUrl' option is set to '/Users/xiaoyi/Projects/tsc-mangle-resolve', using this value to resolve non-relative module name '@babel/core'.
'paths' option is specified, looking for a pattern to match module name '@babel/core'.
Module name '@babel/core', matched pattern '*'.
Trying substitution '*', candidate module location: '@babel/core'.
Loading module as file / folder, candidate module location '/Users/xiaoyi/Projects/tsc-mangle-resolve/@babel/core', target file type 'JavaScript'.
Trying substitution 'third_party/node_modules/*', candidate module location: 'third_party/node_modules/@babel/core'.
Loading module as file / folder, candidate module location '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core', target file type 'JavaScript'.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core.js' does not exist.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core.jsx' does not exist.
Found 'package.json' at '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/package.json'.
'package.json' does not have a 'typesVersions' field.
'package.json' has 'main' field 'lib/index.js' that references '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js'.
File '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js' exist - use it as a name resolution result.
======== Module name '@babel/core' was successfully resolved to '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js' with Package ID '@babel/core/lib/[email protected]'. ========
test.ts:1:24 - error TS7016: Could not find a declaration file for module '@babel/core'. '/Users/xiaoyi/Projects/tsc-mangle-resolve/third_party/node_modules/@babel/core/lib/index.js' implicitly has an 'any' type.
Try `npm install @types/babel__core` if it exists or add a new declaration (.d.ts) file containing `declare module '@babel/core';`
1 import * as babel from '@babel/core';
~~~~~~~~~~~~~
Found 1 error.
```
`@babel/core` doesn't ship with typedefs, so `tsc` tries to find the typedef in `@types`. After trying `@types/@babel/core`, `tsc` decides to try the mangled scope package name `@types/babel__core`. However, the second attempt no longer follows the `paths` defined in `tsconfig.json`.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
N/A
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
#19104, similar, but adding `node_modules/@types/*` won't work for mangled scope package name case. | Needs Investigation | low | Critical |
517,810,310 | pytorch | RuntimeError: CUDA out of memory with available GPU memory | I'm running Pytorch bert with adam optimizer. I get a CUDA OOM:
`RuntimeError: CUDA out of memory. Tried to allocate 352.00 MiB (GPU 0; 7.92 GiB total capacity; 1.67 GiB already allocated; 156.00 MiB free; 124.28 MiB cached)`
but I actually I have some GiG available:
```
Traceback (most recent call last):
File "train.py", line 156, in <module>
train(model, train_iter, optimizer, criterion)
File "train.py", line 29, in train
optimizer.step()
File "/usr/local/lib/python3.6/dist-packages/torch/optim/adam.py", line 77, in step
state['exp_avg_sq'] = torch.zeros_like(p.data)
RuntimeError: CUDA out of memory. Tried to allocate 352.00 MiB (GPU 0; 7.92 GiB total capacity; 1.67 GiB already allocated; 156.00 MiB free; 124.28 MiB cached)
```
where when the error came out I had
```
+-----------------------------------------------------------------------------+
| NVIDIA-SMI 418.87.01 Driver Version: 418.87.01 CUDA Version: 10.1 |
|-------------------------------+----------------------+----------------------+
| GPU Name Persistence-M| Bus-Id Disp.A | Volatile Uncorr. ECC |
| Fan Temp Perf Pwr:Usage/Cap| Memory-Usage | GPU-Util Compute M. |
|===============================+======================+======================|
| 0 GeForce GTX 1080 On | 00000000:01:00.0 Off | N/A |
| 73% 82C P2 138W / 200W | 5560MiB / 8111MiB | 94% Default |
+-------------------------------+----------------------+----------------------+
| 1 GeForce GTX 1080 On | 00000000:03:00.0 Off | N/A |
| 66% 68C P2 108W / 210W | 5261MiB / 8119MiB | 95% Default |
+-------------------------------+----------------------+----------------------+
+-----------------------------------------------------------------------------+
| Processes: GPU Memory |
| GPU PID Type Process name Usage |
|=============================================================================|
| 0 1264 G /usr/lib/xorg/Xorg 39MiB |
| 0 1461 G /usr/bin/gnome-shell 11MiB |
| 0 29120 C python 5497MiB |
| 1 29607 C python 5249MiB |
+-----------------------------------------------------------------------------+
``` | module: cuda,module: memory usage,triaged | low | Critical |
517,839,917 | bitcoin | Doc: Consolidate documentation of functional test parameters. | **Context:**
The `BitcoinTestFramework` test parameters are set in `set_test_params()`, but there are additional test [run-time settings](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/test_framework.py#L134) which can be passed in through the command-line. The latter are documented with the command-line help strings. Note that there are command-line arguments which differ in naming compared to the class member where they are set:
- `--tracerpc` vs `BitcoinTestFramework.options.trace_rpc`
- `--portseed` vs `BitcoinTestFramework.options.port_seed`
The `TestShell` is a `BitcoinTestFramework` child class, and allows all test parameters to be passed in `setup(**test_args)`. The keys for `test_args` are identical to the respective parent class members to simplify argument forwarding.
- `TestShell.setup(trace_rpc= β¦)` vs. `BitcoinTestFramework.options.trace_rpc`
- `TestShell.setup(port_seed= β¦)` vs. `BitcoinTestFramework.options.port_seed`
However, by extension, `test_args` are now inconsistent with the command-line args of its parent class.
**Issue:**
The TestShell [documentation](https://github.com/bitcoin/bitcoin/blob/master/test/functional/test_framework/test_framework.py#L134) currently covers TestShell-specific argument keys, which donβt entirely translate to the BitcoinTestFramework documentation as mentioned above. It would be nice to find a way to neatly consolidate both in one place.
| Feature,Docs,Tests | low | Major |
517,846,362 | vscode | SCM - enable extensions to provide timeline information | Right now each SCM extension is responsible to provide own file history, e.g. gitlens has https://github.com/eamodio/vscode-gitlens#file-history-view-. But others, like for Mercurial don't have it. Even if it would have it won't provide coherent UX. Would it be possible to have built-in file history view which can be enhanced by scm extensions? | feature-request,scm | low | Minor |
517,862,871 | pytorch | Add instructions for building torch.distributed on macOS | ## π Bug
These instructions are missing and we should add them.
Basically:
* Install pkg-config
* Install libuv
* Compile with `USE_LIBUV=ON`
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 | oncall: distributed,module: docs,triaged | low | Critical |
517,892,120 | go | go/types: investigate commit bdd0ff08 effect on type-checking outcome | Follow-up on #33279. Investigate impact of commit bdd0ff08 on this piece of code:
```Go
package pkg
func fn() {
func(arg int) []int {
_ = arg
return nil
}(0)[0]++
}
```
| NeedsInvestigation | low | Minor |
517,896,965 | flutter | Consider listing only missing VS components | Currently when VS is missing any components needed for targeting Windows, we list all of them. This makes it harder for people to understand what exactly they are missing, especially given that there are so many cases where components differ only by version numbers. (See #44184 for an example, but it's happened a number of times.)
We should consider, for doctor output specifically, having a method that finds just the missing components. Unfortunately I'm not sure there's a good way to do that other than running the query once for each component separately, since the tool that lists all installed components isn't installed by default. We could look into potentially bundling/downloading that told though. | tool,platform-windows,a: desktop,a: build,P3,team-windows,triaged-windows | low | Minor |
517,913,841 | godot | TileSet methods `tile_get_texture(id).get_size()` and `tile_get_texture(id).get_data()` return wrong data | **Godot version:**
v3.2.beta1
**OS/device including version:**
Mac OS X Mojave
**Issue description:**
TileSet methods `tile_get_texture ( id ).get_size() `and `tile_get_texture ( id ).get_data()` return the complete TileSet size and texture, instead of the individual tile size and texture as specified by `id`.
**Steps to reproduce:**
Create a Node2d scene and add a TileMap node. Add the tileset sheet (see below) to the tilemap and edit, slicing out a couple of individual tiles. Add the script below to the TileMap node.
```python
extends TileMap
func _ready() -> void:
var ts: TileSet=$".".tile_set
var ids=ts.get_tiles_ids ( )
var img: Image
var texture: Texture
for id in ids:
print("id=",id,
", Name=",ts.tile_get_name ( id ),
", Tile Region=",ts.tile_get_region ( id ),
", Tile Size=",ts.tile_get_texture ( id ).get_size())
img=ts.tile_get_texture ( id ).get_data()
img.save_png("user://"+ts.tile_get_name ( id )+".png")
pass # Replace with function body.
```
**I have selected three tiles from tilesheet below and I get this output:**
id=0, Name=tilesheet1.png 0, Tile Region=(0, 0, 64, 64), Tile Size=(1408, 768)
id=1, Name=tilesheet1.png 1, Tile Region=(64, 0, 64, 64), Tile Size=(1408, 768)
id=2, Name=tilesheet1.png 2, Tile Region=(128, 0, 64, 64), Tile Size=(1408, 768)
And each one of the saved png files is the complete tilesheet map instead of the individual tiles.
**Tilesheet Sample**
| bug,topic:core,confirmed,topic:2d | low | Major |
517,943,511 | flutter | [web] Make `felt` rebuilds interruptible | When a file or multiple files change, the `felt build --watch` command automatically rebuilds the web engine sources. If during the rebuild, another file changes, that change will be queued and wait for the previous rebuild to complete before a new rebuild can start.
This issue is suggesting that we add support for interrupting a rebuild to start a new one immediately. | engine,a: quality,platform-web,c: proposal,P3,team-web,triaged-web,e: engine-tool | low | Minor |
517,944,985 | go | runtime: should checkptrArithmetic accept a uintptr instead of unsafe.Pointer? | Two instances of
```
runtime: bad pointer in frame runtime_test.testSetPanicOnFault at 0xc000206de0: 0x1
fatal error: invalid pointer found on stack
```
darwin-amd64-race: https://build.golang.org/log/05f53140b89337ef848d51e83ffb8e19aabd27e0
linux-amd64-race (trybot): https://storage.googleapis.com/go-build-log/7828558a/linux-amd64-race_de2789c5.log | NeedsInvestigation | medium | Critical |
517,953,102 | flutter | "flutter logs" do not show logs on iOS 13+ physical device | ## Steps to Reproduce
1. Attach iOS 13+ device
2. `flutter logs`
No logs are printed.
See https://github.com/flutter/flutter/issues/41133 | c: regression,platform-ios,tool,P3,team-ios,triaged-ios | low | Major |
518,000,730 | pytorch | Redo our library structure | Design goals:
* Each individual dynamic library must not be too large, or we will hit linking limits per #27215
* Our plan for addressing the above problem is to split `libtorch.so` into `libtorch_cpu.so` and `libtorch_cuda.so` libraries
* It should be obvious which `*_API` macro one should use to annotate a function as public in any given file
* `libtorch_cpu.so` should be the same regardless of if you do a `USE_CUDA` build or not. (But some code has `USE_CUDA` macros; in that case, we cannot achieve this design goal. Goal is to NOT shave this yak before we make an improvement)
* `libtorch.so` is the single dynamic library all end users have to link against; no understanding of the internal library structure should be necessary
* Try not to merge conflict with lots of people when fixing these problems (no unnecessary moves)
Why the current state of affairs violate these design goals:
* We link everything into a single libtorch library which is too big for #27215
* The distinction between torch (C++ only) and Python libraries is extremely unclear, making it hard to tell what the correct `_API` macro usage is: compare the list of files in https://github.com/pytorch/pytorch/blob/9492994feb06dd815753c1d18da490aef88102f6/tools/build_variables.py for `libtorch_sources` versus `libtorch_python_sources`; also compare `libtorch_cuda_sources` versus `libtorch_sources`
* We currently broadly use `TORCH_API` to mark functions exported from `libtorch.so`, but many of these functions would move to `libtorch_cpu.so`, thus making the API annotation inconsistent
As far as I can see, there are a set of orthogonal issues we need to address:
* We need some sort of file organization that makes it easy to tell which library a file lives in. However, the tension here is that if we move everything around, we will merge conflict with every in progress pull request
* We need a logical `_API` naming scheme, tied to the file organization, resulting in an easy to apply rule for which `_API` macro to apply at a point in time
* We need to split the library into two or more parts, to ensure we don't OOM when linking Window
# Proposed new library organization
We follow the internal, fbcode structure (which has more libraries), but condense libraries into:
* libtorch_cuda (corresponding to torch-cuda)
* libtorch_cpu (corresponding to torch-cpu AND torch-cpp); to do this, we must make torch-cpp have no uses of `USE_CUDA` macro
* _C (corresponding to torch-python)
# Proposed new file organization
The new file organization is basically the same as Caffe2's old naming scheme for cuda kernels, but also extended to apply for python.
Files that constitute torch-python:
* In `torch/csrc`, every file that is named `python_*`
* Rename any file `foo.cpp` which is obviously Python related to `python_foo.cpp` (example: rename `init.cpp` to `python_init.cpp`)
* However, do NOT rename files which seem Python agnostic; they are probably classified in the wrong library at the moment and we should move them eventually. Add headers to the top of the file indicating their status. Example: `torch/csrc/jit/passes/onnx/cast_all_constant_to_floating.cpp`
* Move all Python files in top level directory (e.g., `torch/csrc/Dtype.cpp`) to `torch/csrc/python`. Once we do this, only dl.c, stub.cpp and WindowsTorchApiMacro.h will remain in top level.
Files that constitute torch-cuda (anything not already matched by torch-python):
* In `torch/csc`, every file that is named `*cuda*`
* Existing ATen rules
Files that constitute torch-cpu: anything not already matched by any of the filters above.
Alternatives:
* Do nothing (but this means it continues to be hard to tell what files belong where)
* Do something more radical, like have a separate folder for each file (but this will result in a lot of merge conflicts)
# Proposed new API macros
* `TORCH_API` for files in `torch-cpu`
* `TORCH_CUDA_API` for files in `torch-cuda`
* `TORCH_PYTHON_API` for files in `torch-python` (previously this is called `THP_API`; this name is OK too)
Alternatives:
* `TORCH_CPU_API` for files in `torch-cpu` (but then we have to do a bunch of renaming = more merge conflicts) | module: build,triaged | low | Major |
518,001,617 | react | react-refresh: Dependent functions/data don't trigger refresh | **Do you want to request a *feature* or report a *bug*?**
Both/neither?
**What is the current behavior?**
Currently, react-refresh marks each component whose `type` and/or `signature` has changed as "dirty" and will either re-render or re-mount those components selectively.
The problem occurs when the dev tooling (webpack, parcel, etc.) loads a module that exports functions or data that are used inside of components, but aren't registered components themselves. For example, a utility function that concatenates a string:
```js
export greet(name) {
return `Hello, ${name}!`;
}
```
Changing the returned string to `Yo, ${name}!` would trigger this module to reload in the browser, but because components which depended on it don't reload, the old greeting will persist
until the next render of each dependent component.
(BTW in actuality, some tooling will reload immediate dependents of modules that are reloaded in order to get around similar problems. You can extend the dependency chain from two to three modules, where `a.js` depends on `b.js` depends on `c.js`, and you will get the same result when editing `c.js`)
What this forces tooling to do is apply a heuristic to try and guess whether a given module should be refreshed, vs. completely restart the app in order to cause all components to re-mount and pick up any changes that wouldn't be picked up by react-refresh.
The problems with the heuristic approach is:
- each dev tool needs to implement this logic, leading to more potential for bugs
- it leads to a degradation of hot reloading capabilities based on what your module exports. not obvious at all on it's face and will lead people to twisting their code base to route around this
- It's very unfriendly to compile-to-JS languages like ReasonML, ClojureScript, etc. which might have different default semantics for what is public / private, different conventions for naming components, etc. which make it difficult to detect whether a module is "safe" to refresh
**What is the expected behavior?**
That components depended on newly loaded code will pick up those changes correctly, without losing state.
A potential (maybe naive?) solution to this in react-refresh is, instead of only re-rendering the components marked as dirty (due to a different `type` being registered), to _re-render from the root_ while maintaining hooks state. If components' signatures have changed, then re-mount.
I've read through and kind of grok most of the code in react-refresh, but I'm not sure how this would impact the way that the reconciler currently handles the HMR stuff. This is as much of a question, as it is a request: could this be a viable solution?
I appreciate your time and energy in reading through this. I'm very excited about having first-class support for hot reloading in React, as it's been something that I've loved ever since seeing the first demo of it. I hope that this issue can help create a way to provide a consistently excellent dev experience across tools/platforms/languages!
**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**
React 16.11 | Type: Discussion | low | Critical |
518,002,128 | rust | Warn that `*const T as *mut T` is Undefined Behavior | Casting a `*const T` to `*mut T` may lead to memory corruption since it allows mutation of shared state. Even if the `*const T` happened to be unique, it is still undefined behavior and the optimizer may break such code in interesting ways. In a nutshell, this is as bad as transmuting a `&` into `&mut`. The compiler should warn against doing this.
*Update: as [pointed out below](https://github.com/rust-lang/rust/issues/66136#issuecomment-550003651), there are cases when that does not immediately trigger UB, but in those cases there is no reason to do this in the first place.*
This often occurs when people try to consume a data structure and create a new one from it, e.g.
```rust
let new_slice = core::slice::from_raw_parts_mut(old_slice.as_ptr() as *mut B, len)
```
in which case the proper solution is to rewrite it as
```rust
let new_slice = core::slice::from_raw_parts_mut(old_slice.as_mut_ptr(), len)
```
This also may happen when people try to mutate shared state through a `&`, in which case they need a `Cell`, `RefCell` or an `UnsafeCell` instead.
Playground with a real-world snippet that fails MIRI: https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=b28a15e3d99616b03caafdd794550946
This pattern seems to be quite widespread - quoting @RalfJung on Zulip:
> I have seen at least 2 or 3 cases over the last few weeks for a const-to-mut raw ptr cast being the give-away for mutation of shared data
I have already requested [a Clippy lint](https://github.com/rust-lang/rust-clippy/issues/4774) for this, but this looks important enough to warn against by default, without relying on optional tooling to catch this. | A-lints,T-lang,C-feature-request | medium | Critical |
518,020,343 | go | cmd/go: document that go mod download -json uses exit code 1 when at least one JSON entry contains non-zero Error | [`go mod download -json`](https://golang.org/cmd/go/#hdr-Download_modules_to_local_cache) documentation says:
> [...] The -json flag causes download to print a sequence of JSON objects to standard output, describing each downloaded module (or failure), corresponding to this Go struct:
>
> ```Go
> type Module struct {
> ...
> Error string // error loading module
> ...
> }
> ```
### What did you do?
I tried to execute `go mod download -json` and interpret its results programmatically.
### What did you expect to see?
I expected non-zero exit code to mean a fatal problem occurred and that I should not expect valid JSON output.
### What did you see instead?
There are 3 possible scenarios:
1. When there are no errors, `go mod download -json` emits exit code 0 and prints JSON.
2. When there are errors downloading some modules, `go mod download -json` emits exit code 1 and prints JSON that has some entries with non-empty Error fields.
<details><summary>Example</summary><br>
An example of such an error is when GOPROXY is set to off; it results in "module lookup disabled by GOPROXY=off" errors:
```
$ cat go.mod
module example.com/m
require golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a
$ echo $GOPROXY
off
$ go mod download -json
{
"Path": "golang.org/x/sys",
"Version": "v0.0.0-20190215142949-d0b11bdaac8a",
"Error": "module lookup disabled by GOPROXY=off"
}
$ echo $?
1
```
</details>
3. When there are some other type of errors, `go mod download -json` emits exit code 1 and does not print JSON.
<details><summary>Example</summary><br>
Examples of other errors include a syntax error in the current go.mod file, or a replace directive pointing to a directory without a go.mod file.
```
$ cat go.mod
bad
$ go mod download -json
go: errors parsing go.mod:
/tmp/issue35380/go.mod:1: unknown directive: bad
$ echo $?
1
```
</details>
In two of the scenarios the exit code is 1. One of them emits JSON. That is challenging for a tool that needs to parse the output; it's hard to be sure it's safe to expect/parse JSON on stdout when exit code is non-zero.
/cc @jayconrod @bcmills @marwan-at-work | Documentation,NeedsInvestigation,GoCommand | low | Critical |
518,031,365 | flutter | Retain cache when switching Flutter channels |
## Use case
Sometimes I may need to switch from master to stable, which, in this case is unchanged, to test something out. In cases where I have no internet connection or slow or metered internet, this is either inconvenient or impossible. Further, it leaves flutter in an unusable state, since it seems that the previous data is erased. So now I'm stuck.
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
## Proposal
Can we have a flag to keep the latest versions of the SDK and binaries and only have them removed if upgrading and only after the upgrade has successfully replaced the old one?
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
| c: new feature,tool,P3,team-tool,triaged-tool | medium | Critical |
518,036,173 | go | crypto/cipher: optimize safeXORBytes | The discussion at https://github.com/golang/go/issues/31586 includes several techniques for optimizing xor of byte slices, including using encoding/binary (with native endianness) and loop unrolling. It'd be nice to apply them to `safeXORBytes`, which is used on many non-amd64 platforms. An optimized `safeXORBytes` might even be fast enough that we could delete `fastXORBytes`.
Somewhat related: #30553
cc @nhooyr
| Suggested,Performance,help wanted,NeedsInvestigation | low | Major |
518,055,576 | kubernetes | Remove handling of legacy firewall rule names in GCE ILB code | PR https://github.com/kubernetes/kubernetes/pull/84622 adds code to rename ILB rules using the right format. There is code to handle legacy firewall rules and rename/delete them. This needs to be removed after k8s 1.19 once all firewall rules have been created with the new name.
/area platform/gce
/assign
| kind/bug,sig/network,area/platform/gce,area/provider/gcp,lifecycle/frozen | low | Major |
518,125,877 | create-react-app | Add support for webpackPrefetch | ### Is your proposal related to a problem?
I would like to use `webpackPrefetch`:
import(/* webpackPrefetch: true */ 'LoginModal');
### Additional context
https://github.com/facebook/create-react-app/issues/5925 | issue: proposal,needs triage | low | Major |
518,141,824 | TypeScript | βType instantiation is excessively deep and possibly infiniteβ but only in a large codebase | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.7.2, 3.8.0-dev.20191102 (worked in 3.6)
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- Type instantiation is excessively deep and possibly infinite.ts(2589)
- Mapped types
- Generics
- Conditional types
**Code**
Note: **this issue manifests itself only in our codebase**. When you run the same code in TypeScript Playground, it seems to be working fine.
The snippet is hardly minimal, but I reduced it as much as I could. I recorded [a video](https://streamable.com/pjkrk) where exactly the same code yields an error different than the one in TypeScript Playground. I tried with two versions of TypeScript: `3.7.2` and `3.8.0-dev.20191102`. It worked correctly with `3.6`.
Since @sheetalkamat and @DanielRosenwasser have access to our repository, you're welcome to have a look at [this PR](https://github.com/unsplash/unsplash-web/pull/4243). Copy-paste the code below anywhere in the project to see the error.
The versions of types used:
- `@types/[email protected]`
- `@types/[email protected]`
- `@types/[email protected]`
- `@types/[email protected]`
**Note**: Interestingly enough, if you change:
```diff
- declare const Button: React.FunctionComponent<Omit<Props, never>>;
+ declare const Button: React.FunctionComponent<Props>;
```
it works again despite the fact `Omit<Props, never>` should be the same as just `Props`.
<details>
<summary>Source code</summary>
```ts
import { History } from 'history'; // "4.7.3"
import * as React from 'react'; // "16.9.11"
import { LinkProps, RouteComponentProps, withRouter } from 'react-router-dom'; // "5.1.0"
import { getDisplayName } from 'recompose'; // "0.30.7"
declare function isDefined<T>(candidate: T | null | undefined): candidate is T;
declare function isString(value?: any): value is string;
type ObjectOmit<T extends K, K> = Omit<T, keyof K>;
type OnClick = NonNullable<React.ComponentProps<'button'>['onClick']>;
type OnClickProp = {
/** If there is a custom click handler, we must preserve it. */
onClick?: OnClick;
};
type ProvidedProps = OnClickProp;
type InputProps = OnClickProp & {
/** Note: we want this helper to work with all sorts of modals, not just those backed by query
* parameters (e.g. `/photo/:id/info`), which is why this must accept a full location instead of a
* `Modal` type.
* */
to: Exclude<LinkProps['to'], Function>;
};
const buildClickHandler = ({
to,
onClick,
history,
}: InputProps & {
history: History;
}): OnClick => {
const navigate = () => {
// https://github.com/Microsoft/TypeScript/issues/14107
isString(to) ? history.push(to) : history.push(to);
};
return event => {
[onClick, navigate].filter(isDefined).forEach(callback => callback(event));
};
};
/** See the test for an example of usage. */
export const enhance = <ComposedProps extends ProvidedProps>(
ComposedComponent: React.ComponentType<ComposedProps>,
) => {
type PassThroughComposedProps = ObjectOmit<ComposedProps, ProvidedProps>;
type OwnProps = InputProps & RouteComponentProps<never> & PassThroughComposedProps;
type Props = OwnProps;
const displayName = `CreateModalLink(${getDisplayName(ComposedComponent)})`;
const ModalLink: React.FunctionComponent<Props> = ({
to,
onClick,
history,
// We specify these just to omit them from rest props below
location,
match,
staticContext,
...passThroughComposedProps
}) => {
const clickHandler = buildClickHandler({ to, onClick, history });
const composedProps: ComposedProps = {
// Note: this is technically unsafe, since the composed component may have props
// with names matching the ones we're omitting.
// https://github.com/microsoft/TypeScript/issues/28884#issuecomment-503540848
...((passThroughComposedProps as unknown) as PassThroughComposedProps),
onClick: clickHandler,
} as ComposedProps;
return <ComposedComponent {...composedProps} />;
};
ModalLink.displayName = displayName;
return withRouter(ModalLink);
};
type Props = React.ComponentPropsWithoutRef<'button'> &
Required<Pick<React.ComponentPropsWithoutRef<'button'>, 'type'>>;
/**
* This one errors.
*/
declare const Button: React.FunctionComponent<Omit<Props, never>>;
/**
* This one works.
*/
// declare const Button: React.FunctionComponent<Props>;
const EnhancedButton = enhance(Button);
/**
* Type instantiation is excessively deep and possibly infinite.ts(2589).
*/
() => <EnhancedButton></EnhancedButton>;
```
</details>
**Expected behavior:**
I should get a proper error about missing properties (not the one about type instantiation):
```
Type '{}' is missing the following properties from type 'Readonly<Pick<OwnProps, "form" | "style" | "title" | "onClick" | "to" | "key" | "autoFocus" | "disabled" | "formAction" | "formEncType" | "formMethod" | "formNoValidate" | "formTarget" | ... 252 more ... | "onTransitionEndCapture">>': to, type(2739)
```
**Actual behavior:**
I'm getting this:
```
Type instantiation is excessively deep and possibly infinite.ts(2589).
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
[Playground Link](https://www.typescriptlang.org/play/?jsx=2#code/JYWwDg9gTgLgBAbzgCWAZxtAnnAvnAMyghDgHIALdTKLMgbgChRJY4AqOAQzTgCUAplwDG8IiXJQhohs3DR4SADLAAdgGsACsTBoANPwgBXGAIDCJSKoGqY2iLoMB3YDAp9jpqHkLFSZKREYAFpiEwEoYIATElkWBUQ4AHMBGAARdDAAGy4sADkuEAEfcX8pYUsINAFZRiiBYRypQiNVUWAIVTh0NIECNQEogB4AFQA+AAphLlUo4CiuUwAuOBG4AB84VSMsrI24Vvr+6yiAShXp2fnF4vRVpnrGrmaCVvbO7rQAZRgoNSSJgA3LhZIwCAD8KxmWHOcGBoNuvAwf1USSYjBgWDAxQA8gAjABWDRgOJArlGcAEAA9TLNeABpAz0sZwAC8cFJ5JGBnUAiwEAIcGZ6Mx2I5qjMWWAwnUbLgeU6eR2OTxWQEQ0EQQAdBZ5NZbPZdEMyHiTJhVGQxgBtMidSXS9RkAC6YxFWNxEqlMsNcoQjDgcAA9OxOABJQVuCKI7hwYRGDASRoOuAUGZRNVQZzFEDx+BgKTVKCA24wLUcQP+uB2r3qSHi+0ypi4N1i+yA+aDQ28dk4z0Ow0t4qh1RgExduW9htaHRwABkiErwc4CuWcCcxScM3gbjuFAEWWx3kwa+gspcbm4uzgaAUvAFcBAEAWWX0Wwg8AJubgbiqxTxIl5KI4DxHAAEcwVoSsODgMBnkKVIIl4CYBC1JIywAA0DMAKHfCBAyWeZAzUAgIHQ05nCoYQKE+NcKBwHdeBzDBuGEYQBDAeAuBaK8sggaYYA6Lo1AwIQgPvLgoM4dCAFknxBdDv3dLVJPLStMBWABRKlGiMeohhUDQuxtTBnQMAAxN4BM6V1GGbRhGAqVRmNNYAsiiKdkDTDM5QmP0A0wPRK2rB1AoDKgE1oQLcBWYdRzsHReHnPyU2obAVlQCKsCbWFJxrNkWWSxzmNULh2ySG4fNOfKFwDANA0DFMYBgXQlnqpJXAoIw8S1CoQEDaTpWIG8CBgQMRndL5hD+DiiLQNAwTQQMAEYABYloABgAdigz4fhRAFMCq8EUsyrVRzQCgJkOuAVnCmgsDO+NLsOpgAzsyspBgIwoC6ARi1sarkoDK1gplAwSrKm4nS1fosi8CYej6AYzhh6ANJES7pl2f8ZWqrGshx9RkP+mBTlOV68CbdElzgL4BGKSNvwEZiSO8GZKSpQpsmKe94y4FIy3YCtqVYeAivgGxUzaYp2SGXVIGqKJx2pWkol4NsOyVhLJkreXf3cyp9RgFZNVEHVDZsGBxuxOXKkVrsxkCqrWQKtT3TgTQeDQEYKDCJIKD1+2EonQliU5GBbfkIOHFfDX6i1mObP892cScVRx3ZWKx2D+cPHCPWja7IZrGLKAWXnT25p9v2A7tzsEop0Vigzjk067dEA3FuA5jQbJcgKIo5XQsxAlMWTnwMomABIEBSdJMhyfJ4ImQPBgLy3TlwU50I72NOmY8eQUnk3pFLCy2isiULdsIYHZ8oHvwgULatB9RAp2u7sGfuqGoAdWKXuDRgAEHonuaocBPzMWPCQVw349ykFKHAAseZg54n3BAJwO1eL8UEt-B8iwqJ4IwIsaUFhbAq3frVOAWoaGwSrr7Yw-tV4J10JWLegMdpdyTDKTysxvLshcm5DyXkIi+UfgYV+BhP60DwOTeyVCuF1xYWgFYzCW4Px-vKd8AgVgMRoqYKiqhpQgiyDgVoaAuAEAEAYNAag2JwOKL1BWgw956ktvgnAqZiwwQSjtTR55qIlSKIxAhVBUQOKrNYXg64Ag8zJE1f4ykqGaIoE1FqbUOpdR6iQQMZIppVAFKNa2AhJrTVGugeazNAwACYAAc9SVoAGIKlgl6kUWwwQACs60ADMnSVrrVqStWpfjqE0ImBMOh3sGFGCYUo8cPADgaFUBg1QVVFmV2mTXNRCVyKjNfhcGsvD0wRDwfgRZOyY67wDJ9b6XRI7OINm4gGCAaHZKjvXGO+BAxJ0pvIuAh8siTy1D3PuS9B7slBYvAeAhd63J+muDqed4aAsnnI96TcPbB3ZKbUs68DQJV-h1TwggCDGlNE1Tolo5yVkEOBYAUhhiaAdBqU+5tnnxRjkSn8JhSXkrNFSx25Am6WhsowJc-pOA+zuJ0YoERiBQDQEkoWdQGhNEcfveAAAhAVqgT7anPu8K+HKhjh1vglcGf0IhjDFRK6C0q7zWBPFAdQSrJUVnqt3NVzwNVOW1bq-VZtDWX3xRHB26Iu4aVUFLNiUQdWUq6OySWMw2ITHjeaOR4qQyStWO7YSMAtzABIR8O41I2JzWAMWUxXr2LcFmDBKotjVQ4GImoVwKEYBoAmNUzptSACcpxlUVgmM7FkQwo0xsGOm6yQxAwTpTVO3VYqgA)
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
- #32735
- #34850 | Bug,Fix Available,Domain: Big Unions,Rescheduled | high | Critical |
518,157,686 | pytorch | Add support for ivalue float scalars | ## π Feature
Currently ivalue only supports for double scalars, but we would like to use float scalars,
## Motivation
As our original data is in floats, so incurring conversion can cause tricky-to-debug issues and performance problems
## Pitch
Add float (32 bit) constructor to ivalue, toFloatValue() etc.
## Alternatives
N/A
## Additional context
N/A
cc @suo | oncall: jit,triaged | low | Critical |
518,180,353 | TypeScript | Suggestion: warn on always-false typeguards | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
type guard always-false warning
## Suggestion
When a typeguard is always false, the guarded variable is type `never` within the body. While you can't actually look up any properties on `never`, you can pass it anywhere or assign it to anything and there's absolutely no warnings. Calling a typeguard function with an argument that has no overlap with the guard should produce a warning.
## Use Cases
My immediate motivation is https://github.com/microsoft/TypeScript/pull/24436#issuecomment-392997204, where if `Number.isFinite` could be written as a typeguard (this would also need a narrower `number` subtype, see e.g. #32188) then it could easily be allowed to be called with a `number|string`, but no additional gymnastics would be required to warn if calling with a guaranteed non-`number`.
In general there's not a good reason to call an always-false typeguard. This is quite different from the always-true case where defensive coding comes into play.
## Examples
[Example](https://www.typescriptlang.org/play/index.html?ts=3.7-Beta#code/MYGwhgzhAEAKBOBLAbmALgU2gbwFDQOgAclVNoAzRDEAEwEIAuaAOw2Q3gG59CSV0WYAHsWENPACuwNMPgAKAJQ4AvrjW5aGUGHhYKkljMSjoiCADlJAWwBGneQA9mhgNYthAdxaLmjszAsNvbcmtrgepSGxqaSEBgIAphOzIlkGL7QyMKItDxaOpEiYmjQztDiSCwA5jy4iBTQ8uZWdg6Oisp4hNBxCaSCToo8akA):
```ts
declare const x: string;
if (isNumber(x)) { // Should warn: "condition is always false"
usePrivate(x);
}
```
If `usePrivate` requires a private type that this scope doesn't have access to construct, then it would be nice if this code warned _somewhere_. Instead, it currently just narrows `x` to `never` and allows doing whatever you want with it.
## Checklist
My suggestion meets these guidelines:
* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* I don't have a good sense of how much this would break, but I expect any breakages would be exposing legitimate errors.
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
518,205,037 | go | encoding/xml: decoding XML with entities not supported | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.3 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
darwin/amd64
</pre></details>
### What did you do?
I parsed the XML with the entity, but the part with the entity was not parsed (the entity value is in the DTD).
I checked the documentation and set `xml.Decoder.Strict` to false. What appears is the entity itself, not the value of the entity.
This is my programοΌ
https://play.golang.org/p/pxIrus-iW8b
### What did you expect to see?
> 127.0.0.1
> hello
### What did you see instead?
When d.Strict = true, there is nothing.
When d.Strict = false, output:
> 127.0.0.1
> &n;
| ExpertNeeded,help wanted,NeedsInvestigation | low | Minor |
518,215,493 | godot | An abnormal increase in scene size | **Godot version:** 3.2 alpha 3
**Issue description:** I use a blender 2.8 and a standard exporter of gltf.
At the output, the scene.glb size is 1.6 mb. But while maintaining the scene.tscn, the same scene weighs 20 mb!
**Steps to reproduce:** Open scene.glb and save scene.tscn
**Minimal reproduction project:**
[Example.zip](https://github.com/godotengine/godot/files/3812374/Example.zip)
| discussion,confirmed,topic:import | low | Major |
518,307,074 | rust | Tracking issue for future-incompatibility lint `array_into_iter` | ### What is this lint about?
*Method resolution* is responsible for finding a fitting method for a method call expression `receiver.name(args)`. The expression `array.into_iter()` (where `array` has an array type `[T; N]`) currently resolves to either `<&[T; N] as IntoIterator>::into_iter` (for arrays smaller than 33) or `<&[T] as IntoIterator>::into_iter` (for larger arrays). In either way, an iterator over *references to the array's elements* is returned.
In the future, we might want to [add `impl IntoIterator for [T; N]` (for arrays by value)](https://github.com/rust-lang/rust/pull/65819). In that case, method resolution would prioritize `<[T;N] as IntoIterator>::into_iter` as that method call would not require an autoref-coercion. In other words: the receiver expression (left of the dot in the method call) fits the receiver type of the method perfectly, so that method is preferred. In the `&[T; N]` or `&[T]` case, coercions are necessary to make the method call work.
Since the new method is prioritized over the old ones, some code can break. Usually that code looks somewhat like this:
```rust
[1, 2, 3].into_iter().for_each(|n| { *n; });
```
Currently this works, as `into_iter` returns an iterator over references to the array's values, meaning that `n` is indeed `&{integer}` and can be dereferenced. With the new impl, that code would stop compiling. The lint has been put in place to warn of this potentially upcoming breaking change.
### How to fix this warning/error
**Replace `.into_iter()` with `.iter()`**. The latter is guaranteed to always resolve to an iterator over references to the elements.
<br>
---
### Current status
- [x] Lint merged as warn by default in 1.41 (stable on 2020-01-31): #66017
- [x] Lint also lints boxed arrays starting from 1.42 (stable on 2020-03-13): #67524 | A-lints,T-compiler,C-future-incompatibility,C-tracking-issue,A-array | low | Critical |
518,403,369 | angular | Add will-change property to elements that are animated | <!--π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
Oh hi there! π
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
π
-->
# π bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- βοΈedit: --> The issue is caused by package @angular/animations
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
<!-- βοΈ--> No
### Description
When element is animated, the additional styles are removed after the animation ends.
This might cause issues because some of the properties might change behavior of inner elements.
For example, animating using `transform` might cause to make the element a containing block, which might affect how position fixed elements inside are displayed.
Then, when the animation is not in progress, the elements stops being a containing block.
This can affect libraries like popper.js which uses position fixed to display tooltips (see example below).
I think Angular should add will-change properties to element when animation is not in progress. a) it will hint the browser that the element will change and b) it will solve the problem with transform and position fixed, as will-change: transform will also create containing block.
## π¬ Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/edit/angular-issue-repro2-kdbpfx
-->
https://stackblitz.com/edit/angular-issue-repro2-kdbpfx
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## π₯ Exception or Error
<pre><code>
<!-- If the issue is accompanied by an exception or an error, please share it below: -->
<!-- βοΈ-->
</code></pre>
## π Your Environment
**Angular Version:**
<pre><code>
ngular CLI: 8.3.8
Node: 10.9.0
OS: win32 x64
Angular: 8.2.9
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Package Version
------------------------------------------------------------
@angular-devkit/architect 0.803.8
@angular-devkit/build-angular 0.803.8
@angular-devkit/build-ng-packagr 0.803.8
@angular-devkit/build-optimizer 0.803.8
@angular-devkit/build-webpack 0.803.8
@angular-devkit/core 8.3.8
@angular-devkit/schematics 8.3.8
@angular/cli 8.3.8
@ngtools/webpack 8.3.8
@schematics/angular 8.3.8
@schematics/update 0.803.8
ng-packagr 5.5.1
rxjs 6.5.3
typescript 3.5.3
webpack 4.39.2
</code></pre>
**Anything else relevant?**
<!-- βοΈIs this a browser specific issue? If so, please specify the browser and version. -->
<!-- βοΈDo any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
| type: bug/fix,area: animations,freq2: medium,P4 | low | Critical |
518,486,661 | TypeScript | Union properties like `0 | number` or `"" | string` should be discriminants in truthiness checks | **TypeScript Version:** 3.7.2
**Code**
```ts
type A = { readonly [0]: 0 }
type B = { [0]: number }
declare var x: A | B;
if (x[0]) x[0] = 2;
```
**Expected behavior:**
No error will be reported
**Actual behavior:**
error TS2540: Cannot assign to '[0]' because it is a read-only property.
4 if (x[0]) x[0] = 2;
~ | Bug | low | Critical |
518,488,636 | terminal | Add an optional status bar to the bottom | As seen in the original mockups:
<img src="https://user-images.githubusercontent.com/18356694/68302817-5754de80-0068-11ea-9703-3916c28233e3.png" width=640> </img>
<!--  -->
We've apparently discussed this in a ton of threads but never had an issue for it. So this is that issue.
Things to consider:
* [ ] It must be optional. Many users _won't_ want a status bar.
* [ ] How does it play with tabs on the bottom? See #835
* [ ] What info would a user want there?
- Username, machine name, date/time are all ~easy~ kinda **H**ard, because of SSH.
- Keep in mind that many things from the shell (child process) we won't be able to access. Things like _current path_, git branch, active codepage.
- Working path might be possible with OSC 7 (in #3158), though, it'll only work for shells that set it (which _won't_ include `cmd.exe`).
* [ ] How does the user specify the contents of the statusbar? Alignment of pieces of info?
* [ ] Should the user be able to add buttons to the status bar that perform actions? E.g. a "gear" button to quickly open the settings?
These are all things that should be enumerated in a spec before we review a PR. | Issue-Feature,Area-UserInterface,Area-Extensibility,Product-Terminal | high | Critical |
518,513,487 | opencv | imgproc: missing check for odd kernel size in getGaussianKernel() | [Documentation](https://docs.opencv.org/3.4.8/d4/d86/group__imgproc__filter.html#gac05a120c1ae92a6060dd0db190a61afa) declares support for odd values.
Adding check breaks [SURF implementation](https://github.com/opencv/opencv_contrib/blame/3.4.8/modules/xfeatures2d/src/surf.cpp#L560) from opencv_contrib.
It requests filter kernel with ksize = 20 (`PATCH_SZ`). | bug,category: imgproc,RFC | low | Minor |
518,538,170 | youtube-dl | How can I download a youtube playlist with youtube-dl and make it a mp3-playlist? | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- Look through the README (http://yt-dl.org/readme) and FAQ (http://yt-dl.org/faq) for similar questions
- Search the bugtracker for similar questions: http://yt-dl.org/search-issues
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm asking a question
- [ ] I've searched the bugtracker for similar questions including closed ones
- [ ] I've looked through the README and FAQ for similar questions
## Question
<!--
Ask your question in an arbitrary form. Please make sure it's worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient.
-->
I want to download this playlist but when I download it like youtube-dl -i PLSzf4L_DltPLtcOJuLM-eSV5AzBQQIrPc it doesn't write any playlist info in metadata. But most of the music players need playlists info to categorizing music files. Like cmus(I coudn't categorize my musics because lack of metadata). How can I do that?
Youtube-dl version: 2019.10.29
| question | low | Critical |
518,559,599 | go | x/build: filter Dashboard to subsets of ports | <!-- Please answer these questions before submitting your issue. Thanks! -->
This issue is with [the Go Build Dashboard](https://build.golang.org/?page=0&branch=master#),
thus environment and go version info is irrelevant.
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
When looking at the Go Build Dashboard (the solaris-amd64 builder in my case), it's quite difficult
to associate a build (especially a failing one) with the corresponding commit: due to the large
number of builders now running, the page is so wide not to fit on a single screen.
### What did you expect to see?
It would be very helpful to be able to select either a specific subset of builders or even a single
one, just like buildbot based dashboards allow. This would avoid the problem above and make
the display way more useful.
### What did you see instead?
An extremely wide display of builders, many of which I don't know or care about: pure information
overflow, making my work unnecessarily difficult. | Builders,NeedsInvestigation,FeatureRequest | low | Critical |
518,618,378 | kubernetes | scheduler being topology-unaware can cause runaway pod creation | **What happened**:
With "--topology-manager-policy=single-numa-node" enabled on kubelet, creating a ReplicaSet (or other entity which automatically creates pods) resulted in hundreds of pods with a status of "Topology Affinity Error".
controller-0:~$ kubectl get pod
NAME READY STATUS RESTARTS AGE
exclusive-replicaset-27dzq 0/1 Topology Affinity Error 0 19s
exclusive-replicaset-2f4mz 0/1 Topology Affinity Error 0 11s
exclusive-replicaset-57sk2 0/1 Topology Affinity Error 0 7s
exclusive-replicaset-5qvnt 0/1 Topology Affinity Error 0 6s
exclusive-replicaset-67z22 0/1 Topology Affinity Error 0 19s
exclusive-replicaset-6zlcj 0/1 Topology Affinity Error 0 19s
exclusive-replicaset-7nn5k 0/1 Topology Affinity Error 0 17s
exclusive-replicaset-7q7w2 0/1 Topology Affinity Error 0 11s
exclusive-replicaset-8npgb 0/1 Topology Affinity Error 0 17s
exclusive-replicaset-8ts7f 0/1 Topology Affinity Error 0 1s
exclusive-replicaset-8zcng 0/1 Topology Affinity Error 0 8s
exclusive-replicaset-959m7 0/1 Topology Affinity Error 0 5s
exclusive-replicaset-9q4rn 0/1 Topology Affinity Error 0 6s
exclusive-replicaset-bnzxl 0/1 Topology Affinity Error 0 1s
exclusive-replicaset-bvrvb 0/1 Topology Affinity Error 0 17s
exclusive-replicaset-dcbjg 0/1 Topology Affinity Error 0 2s
exclusive-replicaset-dq84c 0/1 Topology Affinity Error 0 7s
**What you expected to happen**:
Ideally the scheduler shouldn't try to place a pod onto a node where it cannot possibly run due to topology policy. This requires making the schedule topology-aware. Until then, rather than going to the error state perhaps the pod should be sent back to the scheduler for re-scheduling to another node (possibly with a delay to ensure we don't waste CPU time constantly rescheduling a pod which can't fit anywhere in the whole cluster).
**How to reproduce it (as minimally and precisely as possible)**:
On a multi-numa-node host, run kubelet with "--cpu-manager-policy=static --topology-manager-policy=single-numa-node". Attempt to create a ReplicaSet with a "Guaranteed" QoS pod having a container that requests more CPUs than are available on a single NUMA node, but less than are available on the whole host.
The scheduler will send the pod to the node (because it's not topology-aware), but kubelet will determine it cannot fit the pod on a single NUMA node and put the pod into status "Topology Affinity Error". The ReplicaSet sees that the pod failed, creates another pod, and the same thing happens again...and again...and again.
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`): v1.16.2
- Cloud provider or hardware configuration: multi-numa-node
- OS (e.g: `cat /etc/os-release`): centos 7
- Kernel (e.g. `uname -a`): Linux controller-0 3.10.0-957.21.3.rt56.935.el7.tis.2.x86_64 #1 SMP PREEMPT RT Thu Oct 24 16:34:45 EDT 2019 x86_64 x86_64 x86_64 GNU/Linux
| kind/bug,priority/backlog,sig/scheduling,sig/node,triage/accepted | medium | Critical |
518,623,357 | flutter | kernel_compiler.snapshot should be bundled the same was as front_end_server | When we generate the `frontend_server.dart.snapshot` for example, we copy over the version in `out/host_debug/gen/frontend_server.dart.snapshot`, this ensure that we produce the `application_snapshot` in the `app-jit` as its optimized.
For `kernel_compiler.snapshot` we currently copy over the version that is specific to each build variant, so for `target_arch`s that do not match `host_arch` and `runtime_mode`: release, we end up generating the snapshots in `kernel` mode and also use dart `product` mode which results in snapshots that are jit optimized without chunks of dart code. We want to avoid that. | customer: fuchsia,engine,P2,team-engine,triaged-engine | low | Critical |
518,643,820 | go | proposal: cmd/go: add .proxy endpoint to the module proxy spec | Users would benefit from more transparency around whether or not a specific module version is being temporarily *cached* in a proxy or whether it is being permanently *mirrored*. There are a number of reasons why a proxy may choose not to mirror something forever: licensing is one notable example.
The proposal would be to add an additional *optional* endpoint to the proxy spec (ie. `go help goproxy`), which proxies could implement if they choose to, which would give this information. For example:
https://proxy.golang.org/golang.org/x/text/@v/v0.3.2/mirrored
would return "true" or "false" as plaintext.
This is something we could pair with a utility in [x/mod](https://godoc.org/golang.org/x/mod) which would accept a go.sum file and indicate which versions aren't being permanently mirrored by any of the proxies listed in `GOPROXY`. That might help you decide to use a different version of the module, vendor that dependency, or encourage you to file an issue against the module if you see that a suitable license is missing, for example.
/cc @jayconrod @bcmills @heschik @hyangah @rsc | Proposal,Proposal-Hold,modules | medium | Major |
518,645,442 | flutter | [google_maps_flutter] Zoom animations are extremely fast on iOS | It would be great to be able to control the speed when animating the camera in Google Maps (just like we can control zoom, bearing and tilt). This would especially be helpful for iOS builds as the animations are much, much faster for some reason as compared to Android. | c: new feature,platform-ios,a: fidelity,p: maps,package,c: proposal,P3,team-ios,triaged-ios | medium | Major |
518,673,782 | vscode | Allow viewing and editing commands with 'args' in the keybindings editor | **Scenario**
We support creating keybindings to trigger specific types of code actions or refactorings like so:
```json
{
"key": "shift+ctrl+e",
"command": "editor.action.codeAction",
"args": {
"kind": "refactor.extract",
"preferred": true
}
}
```
#84033 added IntelliSense for creating keybindings like this in the json based keybindings editor. However at the moment, there is no way to properly view or create or edit keybindings that use `args` in the keybindings editor.
This is important because we are trying to make code actions (specifically refactorings) more discoverable. I believe that making it easier to setup keybindings for code actions would help with discoverability and also help push refactorings as a bigger part of user's workflows
**Feature Request**
* Show the `args` somewhere in the keybindings editor
* Let users edit the `args` in some way (possibly with a UX similar to the settings editor)
* Let users create new keybindings with `args`
/cc @misolori Since this would likely require some UX work
/cc @kieferrm For general refactoring discoverability | feature-request,keybindings-editor | low | Major |
518,702,377 | go | x/mobile: tests for android application fail | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13.4 darwin/amd64
</pre>
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/juancivile/Library/Caches/go-build"
GOENV="/Users/juancivile/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/juancivile/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/Cellar/go/1.13.4/libexec"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/Cellar/go/1.13.4/libexec/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/t8/b_612wks48sc7dht74z1y8_m0000gn/T/go-build413151292=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
Built an `aar` using `GO111MODULE=off gomobile bind -target=android -o libs/libwallet.aar github.com/muun/libwallet`. I then included the aar in an android gradle project. Running the app and triggering the gomobile code works perfectly. However, running the tests fails with the following stacktrace:
```
java.lang.UnsatisfiedLinkError: no gojni in java.library.path
at java.lang.ClassLoader.loadLibrary(ClassLoader.java:1867)
at java.lang.Runtime.loadLibrary0(Runtime.java:870)
at java.lang.System.loadLibrary(System.java:1122)
at go.Seq.<clinit>(Seq.java:37)
at libwallet.Libwallet.<clinit>(Libwallet.java:12)
at libwallet.HDPublicKey.<clinit>(HDPublicKey.java:14)
at io.muun.apollo.domain.LibwalletBridge.createAddressV3(LibwalletBridge.java:87)
at io.muun.apollo.domain.action.AddressActions.getExternalMuunAddress(AddressActions.java:97)
at io.muun.apollo.domain.action.AddressActions.getExternalAddress(AddressActions.java:55)
at io.muun.apollo.domain.action.AddressActionsTest.getExternalAddress(AddressActionsTest.java:66)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
at org.mockito.internal.runners.DefaultInternalRunner$1.run(DefaultInternalRunner.java:79)
at org.mockito.internal.runners.DefaultInternalRunner.run(DefaultInternalRunner.java:85)
at org.mockito.internal.runners.StrictRunner.run(StrictRunner.java:39)
at org.mockito.junit.MockitoJUnitRunner.run(MockitoJUnitRunner.java:163)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
at org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
at org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
at org.gradle.api.internal.tasks.testing.worker.TestWorker.processTestClass(TestWorker.java:118)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:412)
at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
at java.lang.Thread.run(Thread.java:745)
```
After some research, I believe that the problem is gomobile produces libraries for android targets but it doesn't produce one for OS X. Since tests run in a regular java process, it fails to find a compatible shared library in the aar.
The aar is included in the gradle file like this:
```diff
--- a/android/apollo/build.gradle
+++ b/android/apollo/build.gradle
@@ -1,6 +1,9 @@
repositories {
google()
maven { url 'https://maven.fabric.io/public' } // Needed for crashlytics dependency
+ flatDir {
+ dirs "${project.projectDir}/libs"
+ }
}
apply plugin: 'com.android.library'
@@ -92,6 +95,7 @@ preBuild.dependsOn "libwallet"
dependencies {
api project(':common')
+ implementation files('libs/libwallet.aar')
+ testImplementation files('libs/libwallet.aar')
// Android support:
api 'androidx.appcompat:appcompat:1.0.2'
```
### What did you expect to see?
Green tests
### What did you see instead?
Stacktrace above
| help wanted,NeedsInvestigation,mobile | low | Critical |
518,741,437 | rust | async fn unmet lifetime constraints produce confusing diagnostics | ```rust
use std::future::Future;
struct Foo<'a> {
pub value: &'a str
}
fn mode_1(_b: Foo<'_>) -> impl Future<Output=()> {
async {}
}
async fn mode_2(_b: Foo<'_>) {
}
fn test<F, Fut>(_f: F )
where
Fut: Future<Output=()>,
F: FnOnce(Foo<'_>) -> Fut,
{
}
fn main() {
// here can compiled
test(mode_1);
// here can't compiled
test(mode_2);
}
```
```
Compiling playground v0.0.1 (/playground)
error[E0271]: type mismatch resolving `for<'r> <for<'_> fn(Foo<'_>) -> impl std::future::Future {mode_2} as std::ops::FnOnce<(Foo<'r>,)>>::Output == _`
--> src/main.rs:29:5
|
14 | fn test<F, Fut>(_f: F )
| ----
...
17 | F: FnOnce(Foo<'_>) -> Fut,
| --- required by this bound in `test`
...
29 | test(mode_2);
| ^^^^ expected bound lifetime parameter, found concrete lifetime
error: aborting due to previous error
For more information about this error, try `rustc --explain E0271`.
```
[rust playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=3e4f61a8ae74a892b82bceade1532b90) | C-enhancement,A-diagnostics,A-lifetimes,T-compiler,A-async-await,A-suggestion-diagnostics,AsyncAwait-Triaged,D-confusing,D-newcomer-roadblock | low | Critical |
518,742,709 | TypeScript | Why doesn't awaiting a Promise<never> change reachability? | **TypeScript Version:** 3.7.2
**Search Terms:**
- "Promise<never>"
- `await`
- reachability analysis
- control flow analysis
- definite assignment analysis
**Code**
```ts
(async () => {
let b: string;
let a1 = await Promise.reject(); // returns Promise<never>
b = ""; // Not unreachable?
b.toUpperCase(); // Not unreachable?
})();
```
**Expected behavior:**
As `a1` is inferred to be `never` (e.g. behaves like in the non-promised version), I expected the rest of the code to be marked as unreachable aswell:
```ts
function returnNever(): never { throw new Error(); }
(async () => {
let b: string;
let a0 = returnNever(); // a0 is never
b = ""; // Unreachable
b.toUpperCase(); // Unreachable
})();
```
**Actual behavior:**
The code after the never-returning promise is marked as reachable.
**Related Question on StackOverflow**: Has more code: https://stackoverflow.com/questions/58732814
**Related Issue**: https://github.com/microsoft/TypeScript/issues/10973 (although marked as "Working as intended", it was changed later. 3.7.2 behaves like the issue opener expected).
If this is not a bug, what is the background for this behavior? | Bug,Domain: Control Flow | medium | Critical |
518,888,482 | go | net: mass connection spike leads to unpredictable amount of memory usage | A spike in TCP connections can lead to spike in memory usage in TCP handlers (for example http.ServeHTTP), which leads to unpredictable memory usage. The same happens for UDP servers.
Example projects, that have this behavior:
- [skipper](https://github.com/zalando/skipper) fix in [v0.11.7](https://github.com/zalando/skipper/releases/tag/v0.11.7)
- [traefik](https://traefik.io/)
- [coredns](https://coredns.io/) based with [issue](https://github.com/coredns/coredns/issues/2593), that is likely caused by [udp](https://github.com/miekg/dns/blob/master/server.go#L479) [tcp](https://github.com/miekg/dns/blob/master/server.go#L434), fix possible to configure since https://github.com/coredns/coredns/releases/tag/v1.6.9
- [etcd](https://github.com/etcd-io/etcd/blob/master/etcdmain/etcd.go#L532-L547)
Known cases when this can happen:
- specific DoS attack
- reconects from a fleet of API clients
While investigating a problem with connection spikes, that caused an oom kill of our http proxy skipper, I tried to understand the underlying issue.
The problem is caused by unbounded goroutines in the Accept() loop, see last line of the function https://golang.org/src/net/http/server.go#L2895 in line 2927 you create the goroutine.
I could reproduce a DoS kind of situation with minimal Go code running in docker containers.
In production memory spikes up to more than 2Gi. Normal memory usage in the same production setup is less than 100Mi.
Below I will show how to create spikes that are not manageable with unbounded number of goroutines.
### What version of Go are you using (`go version`)?
<pre>
$ go version
go1.13.3
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN="/home/sszuecs/go/bin"
GOCACHE="/home/sszuecs/.cache/go-build"
GOENV="/home/sszuecs/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/sszuecs/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/share/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/share/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build878802156=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
To show the impact I create a test setup: `[attack client] -> [backend]`
backend:
```go
package main
import (
"fmt"
"log"
"net/http"
"time"
)
type proxy struct{}
func (*proxy) ServeHTTP(w http.ResponseWriter, r *http.Request) {
time.Sleep(10 * time.Millisecond)
fmt.Fprintf(w, r.URL.String()) // important is to use the request!
}
func main() {
proxy := &proxy{}
srv := &http.Server{
Addr: ":9002",
Handler: proxy,
}
log.Fatalf("%v", srv.ListenAndServe())
}
```
Create a docker container:
```docker
FROM alpine
RUN mkdir -p /usr/bin
ADD main /usr/bin/
ENV PATH $PATH:/usr/bin
CMD ["/usr/bin/main"]
```
build:
```bash
% docker build .
Sending build context to Docker daemon 7.392MB
Step 1/5 : FROM alpine
---> 11cd0b38bc3c
Step 2/5 : RUN mkdir -p /usr/bin
---> Running in 8a0f489fd22c
Removing intermediate container 8a0f489fd22c
---> c0b549e856b9
Step 3/5 : ADD main /usr/bin/
---> 292e9a346dde
Step 4/5 : ENV PATH $PATH:/usr/bin
---> Running in de5e1c78ab94
Removing intermediate container de5e1c78ab94
---> 66832a5b3f90
Step 5/5 : CMD ["/usr/bin/main"]
---> Running in 83892cb8a768
Removing intermediate container 83892cb8a768
---> 5c11f1edbcd6
Successfully built 5c11f1edbcd6
```
Start the minimal go backend
```bash
docker run --rm --memory 100m -hostnetwork -p9002:9002 -it 5c11f1edbcd6 /usr/bin/main
```
Create attack client, that does the connection spike
```go
package main
import (
"fmt"
"log"
"net"
"sync"
)
func main() {
addr := "127.0.0.1:9002"
numConns := 20000 // increase if you don't get the expected result
req := "GET / HTTP/1.1\r\nHost: localhost\r\n\r\n"
raddr, err := net.ResolveTCPAddr("tcp", addr)
if err != nil {
log.Fatalf("Failed to resolve %s: %v", addr, err)
}
var wg, ready sync.WaitGroup
wg.Add(numConns)
ready.Add(numConns)
for i := 0; i < numConns; i++ {
go func() {
defer wg.Done()
ready.Done()
ready.Wait() // all goroutines at the ~same time
conn, err := net.DialTCP("tcp", nil, raddr)
if err != nil {
log.Printf("Failed to dial: %v", err)
return
}
fmt.Fprintf(conn, req)
}()
}
wg.Wait()
}
```
```bash
go run attackclient.go
2019/11/06 23:17:36 Failed to dial: dial tcp 127.0.0.1:9002: connect: connection refused
2019/11/06 23:17:36 Failed to dial: dial tcp 127.0.0.1:9002: connect: connection refused
2019/11/06 23:17:36 Failed to dial: dial tcp 127.0.0.1:9002: connect: connection refused
```
When the connection refused starts, the backends shows:
```
% docker run --rm --memory 100m -hostnetwork -p9002:9002 -it a87c13d25e37 /usr/bin/main
zsh: exit 137 docker run --rm --memory 100m -hostnetwork -p9002:9002 -it a87c13d25e37
```
Exit code 137 is oom kill.
### What did you expect to see?
no oom kill, but http 5xx or connection refused or similar errors
### What did you see instead?
oom kill
### Possible solution
`http.Serve{}` could have a MaxConcurrency option that would limit the number of goroutines that are created. An impementation could be done with a semaphore. it is possible to implement a fix without a breaking change, such that unbounded number of goroutines is the 0 value for the mentioned new option. Another idea would be to set this value automatically via finding the cgroup memory limit for the current process, because the relation should be:
```
memory consumption ~= (sizeof(http.Request) + sizeof(goroutine)) * number(connections)
``` | Performance,NeedsInvestigation | medium | Critical |
518,955,871 | flutter | Gradients with the default stops have a hard stop at the top of the gradient | From left to right
1. Gradient with no custom stops
2. Gradient with custom stops
3. Vertical gaussian blur-based gradient
The gradient without custom stops has a very visible line at the very top. This could be improved to look more like Chrome's implementation of the same.
| framework,a: quality,P2,team-framework,triaged-framework | low | Minor |
518,971,722 | PowerToys | Enhanced Clipboard history with visualization | it would be fantastic if we could have an enhanced version of clipboard history.
A future item here could be making it modular as well for additional ways to visualize / extend the clipboard items based on the file type.
@xyzzer has a good base. | Idea-New PowerToy | low | Major |
518,973,836 | vue | Computed Setter Does Not Work In Scoped Slot | ### Version
2.6.10
### Reproduction link
[https://codepen.io/jameswee/pen/BaaxLmE](https://codepen.io/jameswee/pen/BaaxLmE)
### Steps to reproduce
1. Create computed setter in parent and pass it into scoped slot
2. Attach computed setter via scoped slot into child's v-model
3. Test
A working example is available if you comment out line 2 and uncomment line 3.
### What is expected?
Editing the input box should trigger the alert function
### What is actually happening?
Editing input box isn't triggering the computed setter.
<!-- generated by vue-issues. DO NOT REMOVE --> | discussion | medium | Minor |
519,003,173 | scrcpy | Allow to disable video streaming on Server level | It might be helpful to increase performance if the app is used as Controller only (e.g. key-to-touch mapping). Related issues: #912 #712 | feature request | low | Major |
519,012,383 | create-react-app | Open browser after devserver compilation | ### Is your proposal related to a problem?
When running `npm run start`, the browser opens almost immediately leaving a blank page for a good few seconds before the code is actually compiled.
### Describe the solution you'd like
It would be better if the browser only gets invoked after compilation has passed.
### Additional context
This can be achieved easily with WebpackDevServer hooks as with the following snippet:
```js
let compiledOnce = false;
// After WebpackDevServer compiles the bundle, open it in the browser.
compiler.hooks.afterCompile.tap(appName, () => {
if (!compiledOnce) {
openBrowser(urls.localUrlForBrowser);
}
compiledOnce = true;
});
```
(Maybe someone can help me with that ugly boolean variable that is required to prevent new tabs when hot reloading)
| issue: proposal,needs triage | low | Minor |
519,035,298 | vscode | Distinguish types of calls for call hierarchy? | For the call hierarchy, @rbuckton brought up that JavaScript and TypeScript has many different ways of actually invoking a function:
- New `new Foo()`
- Tagged templates: foo\`bar\`
- Decorators `@foo`
- Property/Element access to accessors `obj.foo`
My proposal is that TS should return call hierarchy items for all of these cases, but I wanted to check this with you @jrieken. Does that make sense? Should we consider having a way to distinguish different call types? | feature-request,api,callhierarchy | low | Major |
519,037,730 | angular | renderModuleFactory does not reject when error is thrown in application | # π bug report
### Affected Package
`@angular/platform-server`
### Is this a regression?
No, I tested a v4 and v6 and the behavior is consistent
### Description
`renderModuleFactory` does not reject for errors thrown during rendering.
Examples:
* `@Component` `ngOnInit`
* Router `resolve`
* Probably more
## π¬ Minimal Reproduction
https://github.com/FrozenPandaz/angular-bugs/tree/render-module-factory
```bash
npm i && npm run prerender
```
## π₯ Exception or Error
<pre><code> jason@pop-os ξ° ~/projects/temp/temp/angular-bugs ξ° ξ render-module-factory ξ° npm run prerender
> [email protected] prerender /home/jason/projects/temp/temp/angular-bugs
> ng build && ng run ng8-app:server && node ./main.js
Generating ES5 bundles for differential loading...
ES5 bundle generation complete.
chunk {runtime} runtime-es2015.js, runtime-es2015.js.map (runtime) 6.16 kB [entry] [rendered]
chunk {runtime} runtime-es5.js, runtime-es5.js.map (runtime) 6.16 kB [entry] [rendered]
chunk {styles} styles-es2015.js, styles-es2015.js.map (styles) 10.1 kB [initial] [rendered]
chunk {styles} styles-es5.js, styles-es5.js.map (styles) 14.2 kB [initial] [rendered]
chunk {main} main-es2015.js, main-es2015.js.map (main) 48.2 kB [initial] [rendered]
chunk {main} main-es5.js, main-es5.js.map (main) 55.3 kB [initial] [rendered]
chunk {polyfills-es5} polyfills-es5.js, polyfills-es5.js.map (polyfills-es5) 789 kB [initial] [rendered]
chunk {vendor} vendor-es2015.js, vendor-es2015.js.map (vendor) 3.75 MB [initial] [rendered]
chunk {vendor} vendor-es5.js, vendor-es5.js.map (vendor) 5.21 MB [initial] [rendered]
chunk {polyfills} polyfills-es2015.js, polyfills-es2015.js.map (polyfills) 264 kB [initial] [rendered]
Date: 2019-11-07T04:43:04.373Z - Hash: c69b66b49129c074781b - Time: 13236ms
Hash: 2a979d82dfc31ad8eb0a
Time: 2896ms
Built at: 11/06/2019 11:43:08 PM
Asset Size Chunks Chunk Names
main.js 65 KiB main [emitted] main
main.js.map 36.2 KiB main [emitted] main
Entrypoint main = main.js main.js.map
chunk {main} main.js, main.js.map (main) 54.8 KiB [entry] [rendered]
ERROR Error: hi
at AppComponent.ngOnInit (/home/jason/projects/temp/temp/angular-bugs/dist/ng8-app-server/main.js:233:15)
at checkAndUpdateDirectiveInline (/home/jason/projects/temp/temp/angular-bugs/node_modules/@angular/core/bundles/core.umd.js:21240:23)
at checkAndUpdateNodeInline (/home/jason/projects/temp/temp/angular-bugs/node_modules/@angular/core/bundles/core.umd.js:29610:24)
at checkAndUpdateNode (/home/jason/projects/temp/temp/angular-bugs/node_modules/@angular/core/bundles/core.umd.js:29572:20)
at prodCheckAndUpdateNode (/home/jason/projects/temp/temp/angular-bugs/node_modules/@angular/core/bundles/core.umd.js:30113:9)
at Object.updateDirectives (/home/jason/projects/temp/temp/angular-bugs/dist/ng8-app-server/main.js:187:264)
at Object.updateDirectives (/home/jason/projects/temp/temp/angular-bugs/node_modules/@angular/core/bundles/core.umd.js:29901:76)
at Object.checkAndUpdateView (/home/jason/projects/temp/temp/angular-bugs/node_modules/@angular/core/bundles/core.umd.js:29554:18)
at ViewRef_.detectChanges (/home/jason/projects/temp/temp/angular-bugs/node_modules/@angular/core/bundles/core.umd.js:20829:26)
at ApplicationRef.tick (/home/jason/projects/temp/temp/angular-bugs/node_modules/@angular/core/bundles/core.umd.js:27224:30)
promise resolved
jason@pop-os ξ° ~/projects/temp/temp/angular-bugs ξ° ξ render-module-factory ξ°
</code></pre>
## π Your Environment
**Angular Version:**
<pre><code>
β jason@pop-os ξ° ~/projects/temp/fs-datatable ξ° ξ master ξ° ng v
_ _ ____ _ ___
/ \ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|
/ β³ \ | '_ \ / _` | | | | |/ _` | '__| | | | | | |
/ ___ \| | | | (_| | |_| | | (_| | | | |___| |___ | |
/_/ \_\_| |_|\__, |\__,_|_|\__,_|_| \____|_____|___|
|___/
Angular CLI: 7.3.1
Node: 10.16.3
OS: linux x64
Angular: 7.2.15
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.13.9
@angular-devkit/build-angular 0.13.9
@angular-devkit/build-optimizer 0.13.9
@angular-devkit/build-webpack 0.13.9
@angular-devkit/core 7.3.9
@angular-devkit/schematics 7.3.1
@angular/cdk 7.3.7
@angular/cli 7.3.1
@angular/material 7.3.7
@ngtools/webpack 7.3.9
@schematics/angular 7.3.1
@schematics/update 0.13.1
rxjs 6.3.3
typescript 3.2.2
webpack 4.29.0
</code></pre> | type: bug/fix,effort2: days,freq2: medium,area: server,P2 | low | Critical |
519,047,645 | react | Hotkey for "Select an element in the page to inspect it" in Chrome extension | Reopening https://github.com/facebook/react-devtools/issues/966 as I feel it'd still be a great feature to have.
To reiterate, it'd be great to have a hotkey to trigger the "Select an element in the page to inspect it" functionality, similar to how `Ctrl` + `Shift` + `C` triggers Chrome's element inspector mode. | Type: Feature Request,Component: Developer Tools | medium | Major |
519,062,051 | go | build: arm64 machine building with 32-bit arm GOROOT_BOOTSTRAP fails | This is super low priority, but filing it because I hit it while experimenting.
ARM64 machines can run ARM code.
On an ARM64 machine I can build Go with make.bash and get ARM64 binaries, of course.
And I can run make.bash with GOARCH=arm, GOHOSTARCH=arm, CC_FOR_TARGET=arm-linux-gnueabihf-gcc, and get ARM binaries.
But if I set GOROOT_BOOTSTRAP to a 32-bit ARM GOROOT (from golang.org/dl), I can't build GOARCH=arm64, regardless of GOHOSTARCH or CC_FOR_TARGET settings.
I get either:
```
# runtime/cgo
gcc: error: unrecognized command line option '-marm'; did you mean '-fasm'?
go tool dist: FAILED: /home/ubuntu/gotip/pkg/tool/linux_arm/go_bootstrap install -gcflags=all= -ldflags=all= std cmd: exit status 2
```
or e.g.
```
$ GOROOT_BOOTSTRAP=$HOME/arm/go GOARCH=arm64 GOHOSTARCH=arm64 time ./make.bash
Building Go cmd/dist using /home/ubuntu/arm/go. (go1.13.4 linux/arm)
Building Go toolchain1 using /home/ubuntu/arm/go.
Building Go bootstrap cmd/go (go_bootstrap) using Go toolchain1.
Building Go toolchain2 using go_bootstrap and Go toolchain1.
Building Go toolchain3 using go_bootstrap and Go toolchain2.
HASH[build runtime/internal/sys]
HASH[build runtime/internal/sys]: "devel +198f0452b0 Thu Nov 7 02:33:31 2019 +0000"
HASH[build runtime/internal/sys]: "compile\n"
HASH[build runtime/internal/sys]: "goos linux goarch arm64\n"
HASH[build runtime/internal/sys]: "import \"runtime/internal/sys\"\n"
HASH[build runtime/internal/sys]: "omitdebug false standard true local false prefix \"\"\n"
HASH[build runtime/internal/sys]: "modinfo \"\"\n"
HASH[build runtime/internal/sys]: "compile NrSOTEoiK7YosNNhxRnR [] []\n"
HASH[build runtime/internal/sys]: "=\n"
HASH /home/ubuntu/gotip/src/runtime/internal/sys/arch.go: d9b0b7e72538d421b2607acaba60ca49f20ef584b3d1d191c6729e35fbb8101d
HASH[build runtime/internal/sys]: "file arch.go 2bC35yU41CGyYHrKumDK\n"
HASH /home/ubuntu/gotip/src/runtime/internal/sys/arch_arm64.go: 2fe66f385ea5a1e9da31d7674ec907c441ba78c4ea17aaec217330fcb0105474
HASH[build runtime/internal/sys]: "file arch_arm64.go L-ZvOF6loenaMddnTskH\n"
HASH /home/ubuntu/gotip/src/runtime/internal/sys/intrinsics.go: 8b469a461e1d983706e0b3635715ce70691adc5db7c4e067b88cc59f40cd66f4
HASH[build runtime/internal/sys]: "file intrinsics.go i0aaRh4dmDcG4LNjVxXO\n"
HASH /home/ubuntu/gotip/src/runtime/internal/sys/stubs.go: 23b3e5c631b086fe7a2dec4bf044600e034bf6a8eeb25e0a19efc4ce6311423d
HASH[build runtime/internal/sys]: "file stubs.go I7PlxjGwhv56LexL8ERg\n"
HASH /home/ubuntu/gotip/src/runtime/internal/sys/sys.go: 55e021891200a7e6a5c371c8a1ab71b6c15aeb16ea6c1b192185d17df8c8b18f
HASH[build runtime/internal/sys]: "file sys.go VeAhiRIAp-alw3HIoatx\n"
HASH /home/ubuntu/gotip/src/runtime/internal/sys/zgoarch_arm64.go: 4902d69a4a20421a799ba2e2c07d8b279aeb73993cbdcb9358c703809446e436
HASH[build runtime/internal/sys]: "file zgoarch_arm64.go SQLWmkogQhp5m6LiwH2L\n"
HASH /home/ubuntu/gotip/src/runtime/internal/sys/zgoos_linux.go: 806c088d7491b4560a28a5af86a52b459ebbf155ea455af873baa0bf697355e4
HASH[build runtime/internal/sys]: "file zgoos_linux.go gGwIjXSRtFYKKKWvhqUr\n"
HASH /home/ubuntu/gotip/src/runtime/internal/sys/zversion.go: bf440002e6d73c527f836969303ab545ace7032498d0fa287bd8ba5e335d06cf
HASH[build runtime/internal/sys]: "file zversion.go v0QAAubXPFJ_g2lpMDq1\n"
HASH[build runtime/internal/sys]: 112806be5693d6fbb50a08689c94b2089080eac354c33437afda01d394b49e79
runtime/internal/sys true
go tool dist: unexpected stale targets reported by /home/ubuntu/gotip/pkg/tool/linux_arm64/go_bootstrap list -gcflags="" -ldflags="" for [cmd/asm cmd/cgo cmd/compile cmd/link runtime/internal/sys]:
STALE cmd/asm: stale dependency: internal/cpu
STALE cmd/cgo: stale dependency: internal/cpu
STALE cmd/compile: stale dependency: internal/cpu
STALE cmd/link: stale dependency: internal/cpu
STALE runtime/internal/sys: build ID mismatch
Command exited with non-zero status 2
```
This is obviously somewhat contrived, using a 32-bit Go toolchain on a 64-bit host for bootstrapping a 64-bit build.... but I also think it should work and don't see what I'm missing.
/cc @ianlancetaylor | NeedsInvestigation | low | Critical |
519,083,386 | TypeScript | Mapped type over string enum keys should have quick info showing computed enum members as keys, not identifiers/strings | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!--
Please try to reproduce the issue with the latest published version. It may have already been fixed.
For npm: `typescript@next`
This is also the 'Nightly' version in the playground: http://www.typescriptlang.org/play/?ts=Nightly
-->
**TypeScript Version:** 3.5.3 - 3.7.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** enum, Record, Pick
**Code**
```ts
enum MyTypes {
a = 'a',
b = 'b',
}
type TypeMap = Record<MyTypes, string>;
// the language server tells us that this type is actually the same as the following annotationed type
// but, if I use the following type instead, then no error will occur
// type TypeMap = {
// a: string;
// b: string;
// };
const map: TypeMap = {
a: 'text a',
b: 'text b',
}
// error TS2344: Type '"a"' does not satisfy the constraint 'MyTypes'.
type NewTypeMap = Pick<TypeMap, 'a'>;
const newMap: NewTypeMap = {
a: 'abc',
}
```
**Expected behavior:**
Type inference works as expected, no error occurred.
**Actual behavior:**
```bash
error TS2344: Type '"a"' does not satisfy the constraint 'MyTypes'.
```
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
<https://www.typescriptlang.org/play/?ssl=21&ssc=2&pln=1&pc=1#code/KYOwrgtgBAsgngFTgB2AZygbwFBSgQygF4oByfUgGlygCNizarsBfbbAFxWCiVRnzIGAJWABjAPYAnACYAeeH3SUoaDlICWIAOYA+ANzYA9EahdUvbgKEkcJvAQBcq9Vu2H7eWs7WadH0xZDbEkQNSgIQWclawYcPHxnUg5gAA8OAmYvJJT0umY2Tm4oADlgAHcYwQYABQ0xAGs5KuQVclIDdlDwkArrZzLKq2rbGkSyfFoxAqA>
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Bug,Domain: Quick Info | low | Critical |
519,094,221 | create-react-app | .gitignore file | When executing npx create-react-app command .gitignore file is created after node_modules download, thus slowing down git checks, could it be created first?
| issue: proposal | low | Major |
519,144,307 | TypeScript | need "libRoots" in tsconfig.json for private node-runtime type definition | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
can i write my own lib.*.d.ts for my node-runtime ?
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
add "libRoots" to tsconfig.json for personal runtime configuration (like "typeRoots")
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
for private node runtime ts type definition
## Examples
<!-- Show how this would be used and what the behavior would be -->
``` json
{
"compilerOptions": {
"libRoot": ["./node_modules/@eczn/my-node-runtime"],
// or ...
"lib": [
"es2017",
"@eczn/my-node-runtime"
]
}
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
519,149,714 | react | react-test-renderer: the findByType method doesn't work with memo components | <!--
Note: if the issue is about documentation or the website, please file it at:
https://github.com/reactjs/reactjs.org/issues/new
-->
**Do you want to request a *feature* or report a *bug*?**
Feature
**What is the current behavior?**
Whenever I try something like:
```
ReactTestRenderer.create(<SomeComponent />).root.findByType(SomeMemoComponent);
```
I get the following error: `No instances found with node type: "undefined"`. The only way I found for this to work was to reference the `type` property of memo components like this:
```
ReactTestRenderer.create(<SomeComponent />).root.findByType(SomeMemoComponent.type);
```
I am fine with this solution but then flow complains that `type` doesn't exist so I find myself fixing this with `$FlowFixMe` all over the place.
**What is the expected behavior?**
I would expect that passing a memo component to `findByType` would work. Or that flow would recognize the `type` property of memo components. I think both should work, specially the first option.
**Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?**
No, it never worked as far as I know.
| Type: Bug,Component: Test Renderer | low | Critical |
519,223,343 | pytorch | nn.Conv(n)d constructor doesn't check for the number of kernel dimensions | ## π Bug
Convolution module constructors do not check for input argument kernel_size length, neither does forward method check for number of kernel dimensions, which makes it possible to use Conv1d as Conv2d vice versa and so on, which in turn may lead to confusion in new users.
## To Reproduce
```python
import torch
a = torch.nn.Conv1d(24, 42, (3, 3))
b = torch.nn.Conv2d(24, 42, (3, 3))
a.weight.shape == b.weight.shape
Out[5]: True
a.bias.shape == b.bias.shape
Out[6]: True
a.weight = b.weight
a.bias = b.bias
t = torch.randn(1, 24, 12, 12)
(a(t) == b(t)).all()
Out[10]: tensor(True)
```
## Expected behavior
An exception should be raised if kernel, padding, or stride number of dimensions doesn't match number of convolution dimensions.
## Environment
PyTorch version: 1.2.0
Is debug build: No
CUDA used to build PyTorch: 10.0.130
OS: Ubuntu 19.04
GCC version: (Ubuntu 6.5.0-2ubuntu1) 6.5.0 20181026
CMake version: version 3.13.4
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: 10.1.243
GPU models and configuration:
GPU 0: GeForce GTX 1080 Ti
GPU 1: GeForce GTX 1080 Ti
GPU 2: GeForce GTX 1080 Ti
Nvidia driver version: 418.87.00
cuDNN version: 7.6.3
Versions of relevant libraries:
[pip3] numpy==1.17.2
[pip3] torch==1.2.0
[pip3] torchvision==0.4.0
[conda] _pytorch_select 0.2 gpu_0
[conda] blas 1.0 mkl
[conda] mkl 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.14 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] pytorch 1.3.0 py3.7_cuda10.1.243_cudnn7.6.3_0 pytorch-nightly
[conda] pytorch-lamb 1.0.0 pypi_0 pypi
[conda] torch-cluster 1.4.5 pypi_0 pypi
[conda] torch-dct 0.1.5 pypi_0 pypi
[conda] torch-geometric 1.3.2 pypi_0 pypi
[conda] torch-scatter 1.3.2 pypi_0 pypi
[conda] torch-sparse 0.4.3 pypi_0 pypi
[conda] torch-spline-conv 1.1.1 pypi_0 pypi
[conda] torchdiffeq 0.0.1 pypi_0 pypi
[conda] torchfile 0.1.0 pypi_0 pypi
[conda] torchvision 0.4.1 py37_cu101 pytorch-nightly
| module: nn,module: convolution,triaged | low | Critical |
519,279,448 | pytorch | torch.std() returns nan for single item tensors. | ## π Bug
np.std(4) returns 0 whereas torch.std(torch.tensor(4)) returns NaN. This causes numerical instabilities in certain situations.
## To Reproduce
import numpy as np
np.std(4) # returns 0
import torch
torch.std(torch.tensor(4.)) # returns NaN
## Expected behavior
It should also return 0 to be consistent.
## Environment
PyTorch 1.3
cc @ezyang @gchanan @zou3519 @jerryzh168 | triaged,module: numpy,small | low | Critical |
519,293,411 | storybook | [RFC] A storyoutput addon, for storybook/html | **Is your feature request related to a problem? Please describe.**
With storybook/html, we document CSS only components.
So for each story of a component, we just need the right markup using the right CSS classes.
I don't want to duplicate in each story the markup, so I use JS by using a `render` function that takes some params.
There is the storysource addon, but if I use it to show the code, it will show me the JS code, the `render` function call, while in a storybook/html context, I care only about the output, the markup that is rendered in the canvas.
**Describe the solution you'd like**
A storyoutput addon, that will render the story output markup.
**Describe alternatives you've considered**
Using the storysource addon with story functions being just HTML rendering, but this will duplicate the HTML markup, while I'd prefer it to be centralized in a JS function (BTW, that function can be used in other component stories, for compound components).
**Are you able to assist bring the feature to reality?**
no, I feel that such addon is too advanced for my JS skills (I'm PHP developer)
**Additional context**
I thought about this idea in the context of storybook/html only, but maybe it can useful for others
| feature request,addon: storysource | low | Minor |
519,306,381 | vscode | The horizontal wheel of mouse is invalid | Issue Type: <b>Bug</b>
mouse: logi m590
The horizontal wheel of mouse does not work in VS code.
VS Code version: Code 1.39.2 (6ab598523be7a800d7f3eb4d92d7ab9a66069390, 2019-10-15T15:35:18.241Z)
OS version: Windows_NT x64 10.0.18362
<!-- generated by issue reporter --> | bug,upstream,trackpad/scroll,chromium | high | Critical |
519,381,288 | rust | MSVC rustc is unnaturally slower than Linux rustc | While it's generally assumed that build systems on Windows are slower than build systems on Linux, I'm seeing a discrepancy of up to nearly 2x differences in compile times *per crate* on a Windows machine vs a Linux machine. These are personal machines I work on and they're not exactly equivalent machines, but I'm pretty surprised about the 2x differences I'm seeing here and wanted to open an issue to see if we can investigate to get to the bottom of what's going on.
The specifications of the machines I have are:
* Linux - Intel(R) Core(TM) i9-7940X CPU @ 3.10GHz, 14-core/28-thread, 64GB ram
* Windows - Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz, 4-core/8-thread, 32GB ram
I don't really know a ton about Intel CPUs, so I'm not actually sure if these are expected where the i9 is 2x faster than the i7. I wanted to write down some details though to see if others have thoughts. All Cargo commands were executed with `-j4` to ensure that neither machine had an unfair parallelism advantage, and also to ideally isolate the effect of hyperthreads.
I started out by building https://github.com/cranestation/wasmtime/tree/ab3cd945bc2f4626a2fae8eabf6c7108973ce1a5, and the full `-Ztimings` graph I got was:
* [Linux](https://gistpreview.github.io/?fc260cc6a40bc83729d7262b8b2eb873)
* [Windows](https://gistpreview.github.io/?69ab4ee6d88fec5f267bcce571651ce4)
For the same project and the same compiler commit the Windows build is nearly 70% slower! I don't *think* that my CPUs have a 70% performance difference between them, and I don't have a perfect test environment for this, but 70% feels like a huge performance discrepancy between Linux and Windows.
Glancing at the slow building crates (use the "min unit time" slider to see them more easily) I'm seeing that almost all crates are 2x slower on Windows than on Linux. This doesn't look like a "chalk it up to windows being slow" issue, but this is where I started thinking that this was more likely to be a bug somewhere in rustc and/or LLVM.
Next up I wanted to try out `-Z self-profile` on a particular crate. One I wrote recently was the `wast` crate, which took 13.76s on Linux and 23.05s on Windows. I dug in a bit more building just that crate at https://github.com/alexcrichton/wat/tree/2288911124001d30de0a68e284db9ab010495536/crates/wast.
Here sure enough, the command `cargo +nightly build --release -p wast -j4` has a huge discrepancy:
* Linux - 5.18s
* Windows - 8.58s
Next up I tried `-Z self-profile` and using `measurme` I ran `summarize diff` and got [this output](https://gist.github.com/alexcrichton/03306558740b8f4363a18482e0653cc5), notably:
```
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
| Item | Self Time | Item count | Cache hits | Blocked time | Incremental load time |
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
| LLVM_thin_lto_optimize | +3.86042516s | +0 | +0 | +0ns | +0ns |
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
| LLVM_module_optimize_module_passes | +3.152410865s | +0 | +0 | +0ns | +0ns |
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
| LLVM_module_codegen_emit_obj | +1.783877999s | +0 | +0 | +0ns | +0ns |
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
| codegen_crate | +1.021669947s | +0 | +0 | +0ns | +0ns |
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
| LLVM_thin_lto_import | +245.950489ms | +0 | +0 | +0ns | +0ns |
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
| codegen_module | +220.253166ms | +0 | +0 | +0ns | +0ns |
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
| LLVM_module_optimize_function_passes | +134.256719ms | +0 | +0 | +0ns | +0ns |
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
| LLVM_module_codegen_make_bitcode | +111.530996ms | +0 | +0 | +0ns | +0ns |
+---------------------------------------------+---------------+------------+------------+--------------+-----------------------+
```
For whatever reason, it appears that LLVM is *massively* slower on Windows than it is on Linux.
It was at this point that I decided to write up the issue here and get this all down in a report. I suspect that this is either a build system problem with Windows or it's a compiler problem. We're using Clang on Linux but we're not using Clang on Windows yet, so it may be time to make the transition! | I-compiletime,T-compiler,O-windows-msvc,T-infra,C-bug | low | Critical |
519,392,443 | pytorch | [jit] Saving a `ScriptFunction` to a buffer doesn't work | ```python
@torch.jit.script
def fn(x):
return x
# Works fine
torch.jit.save(fn, io.BytesIO())
# Doesn't work
fn.save(io.BytesIO())
```
cc @suo | oncall: jit,triaged | low | Minor |
519,392,835 | TypeScript | Mixin expected argument type resolves to never when constrained to constructor of type whose property is typed via a type parameter | **TypeScript Version:** 3.8.0-dev.20191105
**Search Terms:** mixin 3.7 type
**Code**
```ts
import * as ts from "typescript";
type Constructor<T> = new (...args: any[]) => T;
export class Node<NodeType extends ts.Node = ts.Node> {
compilerNode!: NodeType;
}
// BindingNamedNode
export interface BindingNamedNode {
getName(): string;
}
export function BindingNamedNode<
TCompilerNode extends ts.Node & { name: ts.BindingName; },
TBase extends Constructor<Node<TCompilerNode>>
>(
Base: TBase
): Constructor<BindingNamedNode> & TBase {
return {} as any;
}
// InitializerableNode
export interface InitializerableNode {
removeInitializer(): this;
}
export function InitializerableNode<
TCompilerNode extends ts.Node & { initializer?: ts.Expression; },
TBase extends Constructor<Node<TCompilerNode>>
>(
Base: TBase
): Constructor<InitializerableNode> & TBase {
return {} as any;
}
// BindingElement
export class BindingElement extends InitializerableNode(BindingNamedNode(Node))<ts.BindingElement> {
}
```
**Other Code**
Or my original code... I think it's more correct to do the above, but should either of these error?
```ts
import * as ts from "typescript";
type Constructor<T> = new (...args: any[]) => T;
export class Node<NodeType extends ts.Node = ts.Node> {
compilerNode!: NodeType;
}
// BindingNamedNode
export type BindingNamedNodeExtensionType = Node<ts.Node & { name: ts.BindingName; }>;
export interface BindingNamedNode {
getName(): string;
}
export function BindingNamedNode<T extends Constructor<BindingNamedNodeExtensionType>>(
Base: T
): Constructor<BindingNamedNode> & T {
return {} as any;
}
// InitializerableNode
export type InitializerableNodeExtensionType = Node<ts.Node & { initializer?: ts.Expression; }>;
export interface InitializerableNode {
removeInitializer(): this;
}
export function InitializerableNode<T extends Constructor<InitializerableNodeExtensionType>>(
Base: T
): Constructor<InitializerableNode> & T {
return {} as any;
}
// BindingElement
export class BindingElement extends InitializerableNode(BindingNamedNode(Node))<ts.BindingElement> {
}
```
**Expected behavior:** No errors, as in TS < 3.7
[TS 3.6.3 Playground](https://www.typescriptlang.org/play/?ts=3.6.3#code/JYWwDg9gTgLgBAKjgQwM5xugZlCI4BEMAnmAKaoDGUwYMBA3ALABQrJ5cAwhAHaowoAV0oxoAHgAqAPjgBeOLzIB3OAAoAdFuRQA5qgBcKXsQDaAXQCU82ZOZsWZAB6RYcSgBs06AHIQAJmTifoGSpGRwzjBkvP7omBohEQoJSbIA3qxw2e54YMAeZFBJAIRGSWHk9gC+rKwA9PVwAELAsW26PsggZP5JrM6u8G3RUFjIlBGt7byd3b1JcJksOXC6ZDBdPWqWRgI0szV1ji7Q8FhCvKLAfC1t-h1bCwFBWTmSPOAFRYtRMXEYVCJF5wABkS0U8yMCWmD1mTwYcGqABo3tlJM00BE-rF0Dx+IIRGIoMEXlJPvlCsUXtJpKxpGo0S0sUYMVjWLtuHx9kSJLDHvM+jSwXA2agIstVlANkIoLwltUUOhkCYjg5GnAAJK8YAwYDIDzAABeRWQACNCv0TkM4CMiuNJlqdXqDcbTRayItJTlpSAIAA3Mja3X6w0mqA7aEAC2AqDVA1ObguVz1t2DLrD7stZKZHzy32pgUiTmiuMBwKL4PStudobdUAA-NCgQBRFzS1CoG68REo3OY8XF0sA-E80QSJLk-NUtJ0lgMpkDsispccoyjwnjknpuvh83ZwKycFiiVM6UwWXy9KKtDGYjxlga-mzFuFHq8GAJm2ebx3Ga6V8yHfeAcQBHdXT3D0kjUZ85h6IVAjUJJLEscQYXuDpAOAjJWGqIA)
**Actual behavior:**
```
TS2345: Argument of type 'typeof Node' is not assignable to parameter of type 'never'.
export class BindingElement extends InitializerableNode(BindingNamedNode(Node))<ts.BindingElement> {
~~~~
}
```
**Playground Link:** [TS 3.8.0-dev.20191105 Playground](https://www.typescriptlang.org/play/?ts=Nightly#code/JYWwDg9gTgLgBAKjgQwM5xugZlCI4BEMAnmAKaoDGUwYMBA3ALABQrJ5cAwhAHaowoAV0oxoAHgAqAPjgBeOLzIB3OAAoAdFuRQA5qgBcKXsQDaAXQCU82ZOZsWZAB6RYcSgBs06AHIQAJmTifoGSpGRwzjBkvP7omBohEQoJSbIA3qxw2e54YMAeZFBJAIRGSWHk9gC+rKwA9PVwAELAsW26PsggZP5JrM6u8G3RUFjIlBGt7byd3b1JcJksOXC6ZDBdPWqWRgI0szV1ji7Q8FhCvKLAfC1t-h1bCwFBWTmSPOAFRYtRMXEYVCJF5wABkS0U8yMCWmD1mTwYcGqABo3tlJM00BE-rF0Dx+IIRGIoMEXlJPvlCsUXtJpKxpGo0S0sUYMVjWLtuHx9kSJLDHvM+jSwXA2agIstVlANkIoLwltUUOhkCYjg5GnAAJK8YAwYDIDzAABeRWQACNCv0TkM4CMiuNJlqdXqDcbTRayItJTlpSAIAA3Mja3X6w0mqA7aEAC2AqDVA1ObguVz1t2DLrD7stZKZHzy32pgUiTmiuMBwKL4PStudobdUAA-NCgQBRFzS1CoG68REo3OY8XF0sA-E80QSJLk-NUtJ0lgMpkDsispccoyjwnjknpuvh83ZwKycFiiVM6UwWXy9KKtDGYjxlga-mzFuFHq8GAJm2ebx3Ga6V8yHfeAcQBHdXT3D0kjUZ85h6IVAjUJJLEscQYXuDpAOAjJWGqIA)
**Other Comments**
The issue does not occur when the type parameter is inlined ([Playground](https://www.typescriptlang.org/play/?ts=3.8.0-dev.20191105&ssl=1&ssc=1&pln=39&pc=2#code/JYWwDg9gTgLgBAKjgQwM5xugZlCI4BEMAnmAKaoDGUwYMBA3ALABQrJ5cAwhAHaowoAV0oxoAHgAqAPjgBeOLzIB3OAAoAdFuRQA5qgBcKXsQDaAXQCU82ZOZsWZAB6RYcSgBs06AHIQAJmRwAN6scOHueGDAHmRQfoEAhEahLBHpcMC8wDDAyB7AAF5xRpgaAKIuUBSowHz2GRG8yCBkpagaAEJZ-lm65bGtvDANEQC+9mOsrAD0M3DdvL28uj4tZP4JZKzOrvBZMHFYyJRBi8ur65sBQanpumQwa61qlkYCNCuT044u0PBYIS8UR1XgLHp9Z4bLbiMIRSSdNBBZyHJboHj8QQiMRQcRbaSsaRqOHhRGoNpwBFI1hvbh8D7YiTnSFXfFwABklLJtxJcGqMCEUDBwTGKHQyBM3wcczgAElsrl8kU4sgAEaxLY7P5uA5HE5BeU5PIFYpQNUam4hXnVEAQABuZENipNcVepQAFsBUFKtXs4IDgbk+HKFcblWb1WQYbyqeS4CiyGi6ZjhKIJPjCcS0hFuUZY9sWLSMQy07inWHTeaozdZJz81bs+F+YLhaK0MZiD6WDLmSsBmQhjBff93F5UOhe-1Bon4Amk+WlZXI1s1JOoddAmotpZrKkxkA)).
Also, I wouldn't be surprised if I was doing something wrong here, but this has worked in the past.
**Workaround**
Pass the class constructor into a function typed like so and the compile error goes away ([Playground](https://www.typescriptlang.org/play/?ts=3.8.0-dev.20191105&ssl=39&ssc=2&pln=38&pc=1#code/JYWwDg9gTgLgBAKjgQwM5xugZlCI4BEMAnmAKaoDGUwYMBA3ALABQrJ5cAwhAHaowoAV0oxoAHgAqAPjgBeOLzIB3OAAoAdFuRQA5qgBcKXsQDaAXQCU82ZOZsWZAB6RYcSgBs06AHIQAJmTifoGSpGRwzjBkvP7omBohEQoJSbIA3qxw2e54YMAeZFBJAIRGSWHk9gC+rKwA9PVwAELAsW26PsggZP5JrM6u8G3RUFjIlBGt7byd3b1JcJksOXC6ZDBdPWqWRgI0szV1ji7Q8FhCvKLAfC1t-h1bCwFBWTmSPOAFRYtRMXEYVCJF5wABkS0U8yMCWmD1mTwYcGqABo3tlJM00BE-rF0Dx+IIRGIoMEXlJPvlCsUXtJpKxpGo0S0sUYMVjWLtuHx9kSJLDHvM+jSwXA2agIstVlANkIoLwltUUOhkCYjg5GnAAJK8YAwYDIDzAABeRWQACNCv0TkM4CMiuNJlqdXqDcbTRayItJTlpSAIAA3Mja3X6w0mqA7aEAC2AqDVA1ObguVz1t2DLrD7stZKZHzy32pgUiTmiuMBwKL4PStudobdUAA-NCgQBRFzS1CoG68REo3OY8XF0sA-E80QSJLk-NUtJ0lgMpkDsispccoyjwnjknpuvh83ZwKycFiiVM6UwWXy9KKtDGYjxlga-mzFuFHq8GCsSjc+DUMjIaIl3kOApCHf54nCCAsDgNI1C3VlrDkWQd1dPcPSSNRnzmHohUCODiUsSx7EGM53C8Ts7hmXRXzId94BxAE-wAsglzUJJLHEGF7g6Gi6IyVhqiAA)):
```ts
const createBase = <T extends typeof Node>(ctor: T) => InitializerableNode(BindingNamedNode(ctor));
export class BindingElement extends createBase(Node)<ts.BindingElement> {
}
``` | Needs Investigation | low | Critical |
519,394,143 | pytorch | Support out= parameters with autograd | ## π Feature
Being able to specify where the result of an op should be written to, rather than having ops allocating their own buffers.
## Motivation
I'm working with context blocks, as defined in https://arxiv.org/pdf/1511.07122.pdf
```python
class MultiConvolution(torch.nn.modules.Module):
def __init__(self, inputChannels, outputChannels, stride, padding = 'zeros'):
super(MultiConvolution, self).__init__()
self.padding = padding
self.a = torch.nn.Conv2d(inputChannels, outputChannels // 2, 3, stride=stride, padding=0, dilation=1)
self.b = torch.nn.Conv2d(inputChannels, outputChannels // 4, 3, stride=stride, padding=0, dilation=2)
self.c = torch.nn.Conv2d(inputChannels, outputChannels // 8, 3, stride=stride, padding=0, dilation=4)
self.d = torch.nn.Conv2d(inputChannels, outputChannels // 8, 3, stride=stride, padding=0, dilation=8)
def pad(self, x, p):
if self.padding == 'circular':
return padding.circular_pad(x, p)
return padding.reflection_pad(x, p)
def forward(self, x):
a = self.a(self.pad(x, 1*2))
b = self.b(self.pad(x, 2*2))
c = self.c(self.pad(x, 4*2))
d = self.d(self.pad(x, 8*2))
return torch.cat([a, b, c, d], 1)
```
In this situation, it seems that PyTorch allocate four buffers for the output of a, b, c, and d.
And then a fifth one for the result of the concatenation.
## Pitch
I'd like a bit more control, with the option of manually specifying where an op writes it's output.
Something like :
```python
class MultiConvolution(torch.nn.modules.Module):
def __init__(self, inputChannels, outputChannels, stride, padding = 'zeros'):
super(MultiConvolution, self).__init__()
self.outputChannels = outputChannels
self.padding = padding
self.a = torch.nn.Conv2d(inputChannels, outputChannels // 2, 3, stride=stride, padding=0, dilation=1)
self.b = torch.nn.Conv2d(inputChannels, outputChannels // 4, 3, stride=stride, padding=0, dilation=2)
self.c = torch.nn.Conv2d(inputChannels, outputChannels // 8, 3, stride=stride, padding=0, dilation=4)
self.d = torch.nn.Conv2d(inputChannels, outputChannels // 8, 3, stride=stride, padding=0, dilation=8)
def pad(self, x, p):
if self.padding == 'circular':
return padding.circular_pad(x, p)
return padding.reflection_pad(x, p)
def forward(self, x):
ret = torch.Tensor(x.shape[0], self.outputChannels, x.shape[2], x.shape[3]) # One large memory allocation here
a = self.a(self.pad(x, 1*2), outputBuffer=ret[:,0:outputChannels // 2]) # No need for alloc
b = self.b(self.pad(x, 2*2), outputBuffer=ret[:,outputChannels // 2:outputChannels // 4 * 3]) # No need for alloc
c = self.c(self.pad(x, 4*2), outputBuffer=ret[:,outputChannels // 4 * 3:outputChannels // 8 * 7]) # No need for alloc
d = self.d(self.pad(x, 8*2), outputBuffer=ret[:,outputChannels // 8 * 7:]) # No need for alloc
return ret
```
## Alternatives
See pitch
## Additional context
See linked paper
cc @ezyang @albanD @zou3519 @gqchen @pearu @nikitaved @soulitzer @mruberry @jbschlosser @gchanan @jerryzh168 | feature,module: autograd,module: nn,triaged | medium | Major |
519,434,253 | rust | Can't use DoubleEndedIterator for inclusive ranges | Code:
```rust
fn main() {
let size = 10;
let h = size / 2;
let _iter = (-h..=h).step_by(size as usize).rev();
}
```
Error:
```
error[E0277]: the trait bound `std::ops::RangeInclusive<i32>: std::iter::ExactSizeIterator` is not satisfied
--> src/main.rs:4:48
|
4 | let iter = (-h..=h).step_by(size as usize).rev();
| ^^^ the trait `std::iter::ExactSizeIterator` is not implemented for `std::ops::RangeInclusive<i32>`
|
= help: the following implementations were found:
<std::ops::RangeInclusive<i16> as std::iter::ExactSizeIterator>
<std::ops::RangeInclusive<i8> as std::iter::ExactSizeIterator>
<std::ops::RangeInclusive<u16> as std::iter::ExactSizeIterator>
<std::ops::RangeInclusive<u8> as std::iter::ExactSizeIterator>
= note: required because of the requirements on the impl of `std::iter::DoubleEndedIterator` for `std::iter::StepBy<std::ops::RangeInclusive<i32>>`
```
I think Rust is not getting safer without ExactSizeIterator implementation for RangeInclusive. The behavior like the one above is not obvious for average Rust coder. Moreover, the workaround exists:
```rust
fn main() {
let size = 10;
let h = size / 2;
let _iter = (-h..h+1).step_by(size as usize).rev();
}
```
related: #36386 | C-enhancement,T-libs-api,A-iterators | low | Critical |
519,452,784 | pytorch | [feature request] torch.kthvalue to support a new argument largest | Sometimes we want the second largest element/indices. torch.topk can be used as workaround, but it would be nice if `kthvalue` directly supported a new `largest=True` argument. | triaged,module: sorting and selection | low | Minor |
519,456,427 | three.js | CameraHelper needs 2 frames to update itself | https://jsfiddle.net/et67ogua/ comment line 49 (requestAnimationFrame). the result:
the expected look is still this:
| Bug | low | Minor |
519,472,491 | pytorch | [RFC] RPC timeout | # Issue
Now we have an arumgnet called `rpc_timeout` in the `def init_model_parallel` function.
The name feels like it's a client-perspective, round-trip RPC timeout.
While, looking at it's [implementation](https://github.com/pytorch/pytorch/blob/26f57cbe5eef74949dbd37193e297b18d33092df/torch/csrc/distributed/rpc/process_group_agent.cpp#L371-L392), it's actually the server-side processing timeout. Client side takes no action at the moment.
That means, if the server-side failed to send the response, the user side future would wait forever.
# API
I suggest that we provide an `rpc_timeout` arg on the 2 RPC entries,
- `rpc.rpc_async(func, args, kwargs, to, timeout: Optional[timedelta] = None) -> Any`
- `rpc.rpc_sync(func, args, kwargs, to, Optional[timeout] = None) -> FutureMessage`.
If `timeout` is not provided (passed as `None`), server side uses the global timeout set in `def init_model_parallel`.
If `timeout` is provided, it means a per-RPC timeout is specified.
- For `rpc.rpc_async`, the `future_message` returned to the client should automatically cancle on timeout, and if users call `future_message.wait()`, it should raises a `TimeoutError`. For `rpc.rpc_sync`, it should block untill timeout and raise a `TimeoutError`.
- The `Message` being passed from client to server should also contains this per-RPC timeout. On the server side, the timeout caontained in the message should be treated as `per_rpc_server_proessing_timeout`, thus overwriting the server-side global processing timeout.
Since the `rpc_timeout` passed to `def init_model_parallel` could be overwritten by per-RPC call, it should be renamed to `global_rpc_server_processing_timeout`.
Implied by the above, for supporting client-side timeout, the generic Future (#28923) needs to support timeout. A reference implementation is [`folly::Future::within(..)`](https://github.com/facebook/folly/blob/master/folly/futures/Future.h#L853).
# Policy
> For user RPCs, we always fill that in with the default rpc timeout.
> For system RPCs, it'll default to 0 (which would be infinite) unless the system RPC sets it.
See https://github.com/pytorch/pytorch/issues/29018
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @gqchen @aazzolini @rohan-varma @xush6528 | triaged,module: rpc | low | Critical |
519,474,817 | flutter | Long tap on Scaffold Edge should start Drawer dragging behavior | ## Use case
Right now, the two ways to open a drawer are either by having it to open by a button (in an `AppBar`, for example), or by swipping from the sides.
Since Android Q (10), if an user enables the Gesture Navigation, it can no longer open the Drawer menu by swipping from the edges, since that is the gesture for "Back". Flutter should provide a third Drawer opening method, by letting users tap and hold in the edges of a scaffold, and start the drag behavior of the scaffold's `Drawer`.
## Proposal
Enable the drawer to be open from a `onLongPress` in the Edges of a `Scaffold`.
This behavior can be observed in some Google apps, like the Gmail App:
 | c: new feature,framework,a: animation,f: material design,f: gestures,P3,team-design,triaged-design | low | Major |
519,481,219 | TypeScript | Suggestion: flip the assignment direction of generated enums to save some bits | <!-- π¨ STOP π¨ π¦π§π’π£ π¨ πΊπ»πΆπ· π¨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
enum assignment
## Suggestion
Flip the assignment order
## Use Cases
enums
## Examples
```ts
enum Action {
foo
bar
baz
thequickbrownfoxjumpsoverthelazydog
}
```
currently generates:
```ts
"use strict";
var Action;
(function (Action) {
Action[Action["foo"] = 0] = "foo";
Action[Action["bar"] = 1] = "bar";
Action[Action["baz"] = 2] = "baz";
Action[Action["thequickbrownfoxjumpsoverthelazydog"] = 3] = "thequickbrownfoxjumpsoverthelazydog";
})(Action || (Action = {}));
```
Suggesting instead:
```ts
"use strict";
var Action;
(function (Action) {
Action[Action[0] = "foo"] = 0;
Action[Action[1] = "bar"] = 1;
Action[Action[2] = "baz"] = 2;
Action[Action[3] = "thequickbrownfoxjumpsoverthelazydog"] = 3;
})(Action || (Action = {}));
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
519,499,021 | TypeScript | Generator functions which have a return type of a union of Iterator/AsyncIterator have a yield type of never | **TypeScript Version:** 3.7.2
**Search terms:** generator iterator asynciterator type union never
**Code**
example.ts
```ts
type NumberIterator = Iterator<number> | AsyncIterator<number>;
type NumberGenerator = Generator<number> | AsyncGenerator<number>;
function *numbers(): NumberIterator {
yield 1;
}
```
A type alias which is a union of `Iterator` and `AsyncIterator` is used as the return type of a synchronous generator.
**Expected behavior:**
Code compiles.
**Actual behavior:**
```
example.ts(5,11): error TS2322: Type '1' is not assignable to type 'never'.
```
If you replace `NumberIterator` with `NumberGenerator` as the return type the function above, the code correctly type-checks. Something is wrong here.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/play/index.html?target=99&ssl=5&ssc=2&pln=1&pc=1#code/C4TwDgpgBAcgrgWwEYQE4ElhoIbAPapQC8UmO+qAPAHaIqoB8UAPlAIIDOI1AxmargI06aBgG4AUBIBmcXsACWealABUtZGg4AKAJQAuWCIxYBFKAG8JUG1BAKIAGwAmUAIySAvkA
The playground link wonβt work because the playground doesnβt support async iterators yet (https://github.com/microsoft/TypeScript-Website/issues/15).
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
#30790 Strongly-typed iterator PR | Needs Investigation | low | Critical |
519,508,915 | flutter | NetworkImage does not throw NetworkImageLoadException in widget tests on chrome platform | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Steps to Reproduce
<!--
Please tell us exactly how to reproduce the problem you are running into.
Please attach a small application (ideally just one main.dart file) that
reproduces the problem. You could use https://gist.github.com/ for this.
If the problem is with your application's rendering, then please attach
a screenshot and explain what the problem is.
-->
1. Pump a NetworkImage widget in a widget test
```
await tester.pumpWidget(NetworkImage(/* an image url */);
```
2. An `NetworkImageLoadException` should be thrown (in the default test platform), but on the Chrome platform no exception is thrown.
<!--
Please tell us which target platform(s) the problem occurs (Android / iOS / Web / macOS / Linux / Windows)
Which target OS version, for Web, browser, is the test system running?
Does the problem occur on emulator/simulator as well as on physical devices?
-->
**Target Platform:** Web
**Target OS version/browser:** Chrome
**Devices:**
## Logs
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
Analyzing app_flutter...
info β’ Unused import: 'dart:ui' β’ lib/generated_plugin_registrant.dart:4:8 β’ unused_import
1 issue found. (ran in 2.0s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
[β] Flutter (Channel master, v1.10.15-pre.378, on Linux, locale en_US.UTF-8)
β’ Flutter version 1.10.15-pre.378 at /usr/local/google/home/chillers/flutter
β’ Framework revision bf45897f13 (6 days ago), 2019-11-01 11:30:58 -0700
β’ Engine revision 8ea19b1c76
β’ Dart version 2.6.0 (build 2.6.0-dev.8.2 bbe2ac28c9)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
β’ Android SDK at /usr/local/google/home/chillers/Android/Sdk
β’ Android NDK location not configured (optional; useful for native profiling support)
β’ Platform android-stable, build-tools 29.0.2
β’ Java binary at: /opt/android-studio-with-blaze-3.4/jre/bin/java
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b16-5323222)
β’ All Android licenses accepted.
[β] Chrome - develop for the web
β’ Chrome at google-chrome
[!] Android Studio (version 3.4)
β’ Android Studio at /opt/android-studio-with-blaze-3.4
β Flutter plugin not installed; this adds Flutter specific functionality.
β Dart plugin not installed; this adds Dart specific functionality.
β’ Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b16-5323222)
[β] IntelliJ IDEA Ultimate Edition (version 2019.1)
β’ IntelliJ at /opt/intellij-ue-2019.1
β’ Flutter plugin version 39.0.2
β’ Dart plugin version 191.8423
[β] VS Code (version 1.39.2)
β’ VS Code at /usr/share/code
β’ Flutter extension version 3.6.0
[β] Connected device (2 available)
β’ Chrome β’ chrome β’ web-javascript β’ Google Chrome 78.0.3904.97
β’ Web Server β’ web-server β’ web-javascript β’ Flutter Tools
! Doctor found issues in 1 category.
```
| a: tests,engine,platform-web,a: error message,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-web,triaged-web | low | Critical |
519,541,935 | rust | Should std::future::Future be marked #[fundamental] | `Fn` is marked `#[fundamental]` which makes it possible to do
```rust
trait Test {
}
impl Test for bool { }
impl<F, T> Test for F: where F: Fn() -> T { }
```
but since `std::future::Future` is not marked as `#[fundamental]` it is not possible to do the same with futures.
Marking things as `#[fundamental]` should be done with care but at least the superficial simlarity with ``Fn` seems to indicate that `Future` would also be a candidate for the attribute? | T-lang,C-feature-request,T-types | low | Minor |
519,548,015 | flutter | Fonts do not load when specifying current project as package | Currently the way that Images and Fonts handle the package parameter is inconsistent.
When using images, you can define the image like so:
assets:
- packages/demo1/images/logo.png
Then, the image will load fine with the: Image.asset("images/logo.png", package: "demo1"). This works when the image is in a standalone project, and also when it is imported as a package into another project.
However, fonts works differently. If I define a font as
asset: packages/demo1/fonts/Poppins-Bold.ttf
And use: TextStyle(fontFamily: "Poppins", package: "demo1")
The font does not render correctly in the root project ("demo1"). If I reference this package from another package, then the font **will** load correctly.
So, to recap:
* Images w/ package specifier work in their own package, and as dependancies.
* Fonts w/ package specifier, do not work in their own package, but do work as dependancies
| c: new feature,framework,a: assets,a: typography,c: proposal,P3,team-framework,triaged-framework | low | Minor |
519,570,678 | pytorch | IValue can't be constructed from one of `int`, `long`, or `long long`. | ## π Bug
IValue can't be constructed from one of `int`, `long`, or `long long`.
## To Reproduce
Attempt to compile this:
```cpp
#include <vector>
#include <torch/script.h>
void func() {
std::vector<torch::jit::IValue> inputs;
inputs.push_back((int)0);
inputs.push_back((long)0);
inputs.push_back((long long)0);
}
```
```
/home/dreiss/work/demo-libtorch/example-app.cpp:8:32: error: conversion from βlong long intβ to βstd::vector<c10::IValue, std::allocator<c10::IValue> >::value_typeβ {aka βc10::IValueβ} is ambiguous
8 | inputs.push_back((long long)0);
| ^
/home/dreiss/opt/libtorch/include/ATen/core/ivalue.h:251:3: note: candidate: βc10::IValue::IValue(const char*)β
251 | IValue(const char* v): IValue(std::string(v)) {}
| ^~~~~~
/home/dreiss/opt/libtorch/include/ATen/core/ivalue.h:226:3: note: candidate: βc10::IValue::IValue(bool)β
226 | IValue(bool b)
| ^~~~~~
/home/dreiss/opt/libtorch/include/ATen/core/ivalue.h:215:3: note: candidate: βc10::IValue::IValue(int32_t)β
215 | IValue(int32_t i)
| ^~~~~~
/home/dreiss/opt/libtorch/include/ATen/core/ivalue.h:209:3: note: candidate: βc10::IValue::IValue(int64_t)β
209 | IValue(int64_t i)
| ^~~~~~
/home/dreiss/opt/libtorch/include/ATen/core/ivalue.h:192:3: note: candidate: βc10::IValue::IValue(double)β
192 | IValue(double d)
| ^~~~~~
```
## Expected behavior
Should construct an IValue?
## Environment
```
OS: Fedora release 30 (Thirty)
GCC version: (GCC) 9.1.1 20190503 (Red Hat 9.1.1-1)
CMake version: version 3.14.4
cat ~/opt/libtorch/build-version
1.4.0.dev20191107+cpu
```
## Additional context
The issue here is that IValue has constructors for `int32_t` and `int64_t`, which (on my machine) are `int` and `long`. So the constructor for `long long` is ambiguous. On another machine, `int64_t` might be `long long`, so trying to construct with `long` will be ambiguous.
My proposal is to replace the IValue constructors for `int32_t` and `int64_t` with constructors for `int`, `long`, and `long long`. I can put up a PR for this if the plan is acceptable.
cc @suo | oncall: jit,triaged | low | Critical |
519,601,058 | pytorch | NLLLoss reduce=True returning nan in float16 | ## π Bug
**Version**
torch 1.3.1
torchvision 0.4.1
**Notes**
NLLLoss reduce=True doesn't seem to work in float16.
Also, training a model with loss1 in float16 doesn't seem to decrease the loss. (The model trains fine with loss1 in float32)
Possible related to #14878
**Code to reproduce**
```
#Input
input = torch.rand(32,11,256,256).cuda().half()
target =torch.LongTensor(32,256,256).random_(0, 10).cuda()
loss1 = nn.NLLLoss(reduce=False).cuda().half()
loss2 = nn.NLLLoss(reduce=True, reduction='mean').cuda().half()
print(torch.mean(loss1(input,target)) )
print(loss2(input,target))
```
```
#Output
tensor(-0.4995, device='cuda:0', dtype=torch.float16)
tensor(nan, device='cuda:0', dtype=torch.float16)
```
| module: nn,triaged | low | Critical |
519,623,976 | opencv | /usr/local/lib/libopencv_imgcodecs.so.3.4:undefined symbol: _ZN2cv6detail17check_failed_autoEmmRKNS0_12CheckContextE. | ##### System information (version)
- OpenCV => 3.4.7
- Operating System / Platform => Ubuntu16.04.6
- Compiler => gcc5.5
##### Detailed description
After making matcaffe (caffe with matlab) successfully, when I make mattest (a test), I met the follow problem:
Invalid MEX-file '/home/caffe/matlab/+caffe/private/caffe_.mexa64':/usr/local/lib/libopencv_imgcodecs.so.3.4:undefined symbol: _ZN2cv6detail17check_failed_autoEmmRKNS0_12CheckContextE.
Error in caffe.set_mode_cpu (line 5)
caffe_('set_mode_cpu');
Error in caffe.run_tests (line 6)
caffe.set_mode_cpu();
I don't know how to solve it, and there seems be the same problem in #13811.
| priority: low,category: build/install,incomplete | low | Critical |
519,633,111 | flutter | CupertinoDateTime Picker not changing format when language is changed | the date format in ios 13 look like
"Wed 6 Nov"
but when we apply widgets it's different
"Wed Nov 6"
My flutter doctor output:
Doctor summary (to see all details, run flutter doctor -v):
[β] Flutter (Channel stable, v1.9.1+hotfix.6, on Mac OS X 10.13.6 17G65, locale
en-IN)
[β] Android toolchain - develop for Android devices (Android SDK version 29.0.1)
[β] Xcode - develop for iOS and macOS (Xcode 10.1)
[β] Android Studio (version 3.5)
[β] VS Code (version 1.39.2)
[β] Connected device (1 available)
β’ No issues found!
| framework,a: internationalization,f: cupertino,P2,team-design,triaged-design | low | Minor |
519,903,073 | flutter | Webview_flutter: Proposal to intercept requests apart from navigational | I render custom html where there are images, which have to be loaded with an auth token in header. There 2 ways:
1) Stick the token into cookies
2) Intercept every webview request
I wasn't able to do either of the options with the current flutter webview's functionality.
Is there a way to do that or maybe there are other options?
Currently I have to cut out all the links from <img> and load them separately and replace them with base64 data | c: new feature,p: webview,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | low | Major |
519,999,871 | storybook | Ability to use start-storybook from global install | **Is your feature request related to a problem? Please describe.**
Installing over 100MB of node_modules (over 1k packages) just for storybook to work... for **each** of the components I work on is a pain... Installing it once, globally should be enough
**Describe the solution you'd like**
I would like to be able to install storybook globally, like `npm i -g @storybook/html @babel/core babel-loader`
**Describe alternatives you've considered**
Can't think of anything else that would be reliable and easy to follow for less advanced users.
**Are you able to assist bring the feature to reality?**
Yes I can!
**Additional context**
Currently it is impossible to use storybook globally. It throws an error about not finding babel-loader though it's installed globally. Once installed babel-loader locally, it tries to find core-js locally. If this is installed manually as well, it cries about not being able to resolve @storybook/html (this is the one I was using).
I am aware that it's always safer to keep packages local and especially locking versions up, but downloading 100MB per smallest tiniest component is sometimes an overkill. I can help with developing that if I get a green light and some brief intro where to find the code and if it's something that needs to be done per client (html/react/angular/vue etc) or is it a shared functionality.
| feature request,cli,performance issue | low | Critical |
520,071,738 | go | runtime: "unexpected signal during runtime execution" during bgscavenge on plan9 | ```
#!watchflakes
post <- goos == "plan9" && log ~ `unexpected signal during runtime execution` && log ~ `runtime\.bgscavenge`
```
From `plan9-386-0intro` (https://build.golang.org/log/a94f5d80b1a5d38ecdf8b02bed7bfb305f569118), a `cmd/vet` test failure that appears to have nothing to do with `cmd/vet`:
```
--- FAIL: TestVet (1.94s)
--- FAIL: TestVet/assign (0.43s)
vet_test.go:162: error check failed:
assign.go:18: missing error "self-assignment of x to x"
assign.go:20: missing error "self-assignment of s.x to s.x"
assign.go:22: missing error "self-assignment of s.l.0. to s.l.0."
Unmatched Errors:
fatal error: unexpected signal during runtime execution
[signal sys: trap: fault write code=0x0 addr=0x0 pc=0xa960]
goroutine 4 [running]:
runtime.throw(0x96394d, 0x2a)
/tmp/workdir-gnot/go/src/runtime/panic.go:1106 +0x63 fp=0x11429f44 sp=0x11429f30 pc=0x2e783
runtime.sigpanic()
/tmp/workdir-gnot/go/src/runtime/os_plan9.go:79 +0x333 fp=0x11429f78 sp=0x11429f44 pc=0x2b033
runtime.newobject(0x92d1a0, 0x0)
/tmp/workdir-gnot/go/src/runtime/malloc.go:1153 fp=0x11429f7c sp=0x11429f78 pc=0xa960
runtime.bgscavenge(0x1143c000)
/tmp/workdir-gnot/go/src/runtime/mgcscavenge.go:211 +0x5b fp=0x11429fe8 sp=0x11429f7c pc=0x1d83b
runtime.goexit()
/tmp/workdir-gnot/go/src/runtime/asm_386.s:1337 +0x1 fp=0x11429fec sp=0x11429fe8 pc=0x573f1
created by runtime.gcenable
/tmp/workdir-gnot/go/src/runtime/mgc.go:215 +0x6a
goroutine 1 [chan receive, locked to thread]:
runtime.gopark(0x96ee48, 0x1143c030, 0x1143170e, 0x2)
/tmp/workdir-gnot/go/src/runtime/proc.go:304 +0xd8
runtime.chanrecv(0x1143c000, 0x0, 0x11400001, 0x1515a)
/tmp/workdir-gnot/go/src/runtime/chan.go:563 +0x275
runtime.chanrecv1(0x1143c000, 0x0)
/tmp/workdir-gnot/go/src/runtime/chan.go:433 +0x1c
runtime.gcenable()
/tmp/workdir-gnot/go/src/runtime/mgc.go:216 +0x7e
runtime.main()
/tmp/workdir-gnot/go/src/runtime/proc.go:166 +0x183
runtime.goexit()
/tmp/workdir-gnot/go/src/runtime/asm_386.s:1337 +0x1
FAIL
FAIL cmd/vet 34.760s
```
CC @aclements @mknyszek @0intro @fhs | help wanted,OS-Plan9,NeedsInvestigation,compiler/runtime | high | Critical |
520,151,960 | vscode | API support for Timeline view | # Goals
Add support for a unified file-based timeline view to be added to the Explorer sidebar which will track the active document (similar to the Outline view). This new view can be contributed by multiple sources, e.g. save/undo points, source control commits, test runs/failures, etc. Events from all sources will be aggregated into a single chronologically-ordered view.
# Proposal
```ts
export class TimelineItem {
/**
* A date for when the timeline item occurred
*/
date: Date;
/**
* A human-readable string describing the source of the timeline item. This can be used for filtering by sources so keep it consistent across timeline item types.
*/
source: string;
/**
* Optional method to get the children of the timeline item (if any).
*
* @return Children of the timeline item (if any).
*/
getChildren?(): ProviderResult<TreeItem[]>;
/**
* A human-readable string describing the timeline item. When `falsy`, it is derived from [resourceUri](#TreeItem.resourceUri).
*/
label: string;
/**
* Optional id for the timeline item. See [TreeItem.id](#TreeItem.id) for more details.
*/
id?: string;
/**
* The icon path or [ThemeIcon](#ThemeIcon) for the timeline item. See [TreeItem.iconPath](#TreeItem.iconPath) for more details.
*/
iconPath?: string | Uri | { light: string | Uri; dark: string | Uri } | ThemeIcon;
/**
* A human readable string describing less prominent details of the timeline item. See [TreeItem.description](#TreeItem.description) for more details.
*/
description?: string | boolean;
/**
* The [uri](#Uri) of the resource representing the timeline item (if any). See [TreeItem.resourceUri](#TreeItem.resourceUri) for more details.
*/
resourceUri?: Uri;
/**
* The tooltip text when you hover over the timeline item.
*/
tooltip?: string | undefined;
/**
* The [command](#Command) that should be executed when the timeline item is selected.
*/
command?: Command;
/**
* [TreeItemCollapsibleState](#TreeItemCollapsibleState) of the timeline item.
*/
collapsibleState?: TreeItemCollapsibleState;
/**
* Context value of the timeline item. See [TreeItem.contextValue](#TreeItem.contextValue) for more details.
*/
contextValue?: string;
/**
* @param label A human-readable string describing the timeline item
* @param date A date for when the timeline item occurred
* @param source A human-readable string describing the source of the timeline item
* @param collapsibleState [TreeItemCollapsibleState](#TreeItemCollapsibleState) of the timeline item. Default is [TreeItemCollapsibleState.None](#TreeItemCollapsibleState.None)
*/
constructor(label: string, date: Date, source: string, collapsibleState?: TreeItemCollapsibleState);
}
export interface TimelimeAddEvent {
/**
* An array of timeline items which have been added.
*/
readonly items: readonly TimelineItem[];
/**
* The uri of the file to which the timeline items belong.
*/
readonly uri: Uri;
}
export interface TimelimeChangeEvent {
/**
* The date after which the timeline has changed. If `undefined` the entire timeline will be reset.
*/
readonly since?: Date;
/**
* The uri of the file to which the timeline changed.
*/
readonly uri: Uri;
}
export interface TimelineProvider {
onDidAdd?: Event<TimelimeAddEvent>;
onDidChange?: Event<TimelimeChangeEvent>;
/**
* Provide [timeline items](#TimelineItem) for a [Uri](#Uri) after a particular date.
*
* @param uri The uri of the file to provide the timeline for.
* @param since A date after which timeline items should be provided.
* @param token A cancellation token.
* @return An array of timeline items or a thenable that resolves to such. The lack of a result
* can be signaled by returning `undefined`, `null`, or an empty array.
*/
provideTimeline(uri: Uri, since: Date, token: CancellationToken): ProviderResult<TimelineItem[]>;
}
export namespace workspace {
/**
* Register a timeline provider.
*
* Multiple providers can be registered. In that case, providers are asked in
* parallel and the results are merged. A failing provider (rejected promise or exception) will
* not cause a failure of the whole operation.
*
* @param selector A selector that defines the documents this provider is applicable to.
* @param provider A timeline provider.
* @return A [disposable](#Disposable) that unregisters this provider when being disposed.
*/
export function registerTimelineProvider(selector: DocumentSelector, provider: TimelineProvider): Disposable;
}
```
A timeline source (e.g. an extension) registers a `TimelineProvider` for a set of documents. VS Code will then call the all the registered `TimelineProvider.provideTimeline` callbacks (in parallel) when the active editor changes and matches those registrations. The results will be merged into a unified set ordered by the `TimelineItem.date` and displayed in a new _File Timeline_ view in the Explorer sidebar.
A timeline provider can signal that new events have occurred via the `onDidAdd` event, providing the set of additional timeline items. A provider can also signal a refresh of its timeline items via the `onDidChange` event.
# Questions & Challenges
### API
- Should we provides a model/signal that a timeline provider should not be cached or more accurately flushed when the file is no longer the active editor? Basically an alternative to sending events, just call `provideTimeline` again
- Caching will be a bit challenging
- How much do we keep around? And for how long?
- Should the `TimelimeChangeEvent` event provide a way to signal that an individual item(s) should be updated?
- Do we need a throttle on `onDidAdd`?
- Need to be careful with `id`s for the tree items, since they can come from multiple extensions. Probably should ensure a prefix or something per provider for any provided `id`s (or not give control over the `id`s at all)
### Behavior
- Should tracking the active document be a toggle (like in GitLens where you can turn on/off tracking in the file history view on demand).
- Should there be a way to trigger a specific file/folder/uri timelime to be shown (which would also turn off active file tracking) -- again similar to GitLens
- Should the view support a refresh action that will drop timeline caches and re-request the timeline from all providers? (Hopefully we don't really need this)
- Should we support filtering based on the `source` of the timeline items?
/cc @jrieken
Refs: https://github.com/microsoft/vscode/issues/83995 | feature-request,api,tree-views,scm,api-proposal,timeline | high | Critical |
520,177,023 | scrcpy | Thank you! | Just discovered scrcpy today thanks to a Reddit post and what a f*$%n amazing project! Can't believe I've been stuck using Samsung's terrible SideSync for so long only for them to abruptly replace it with the less functional "Flow" app. scrcpy is so much faster, more reliable and promisingly functional. I will be a heavy user of scrcpy and will be providing feedback as I go. Thanks once more and please keep up the good work! | wontfix | low | Major |
520,197,836 | terminal | [Megathread] Fullscreen & Focus Mode follow-up work | Taken from https://github.com/microsoft/terminal/issues/531#issuecomment-531046569
> I'd suggest that this is broken into 3 implementation steps:
> 1. Support fullscreen mode, with always hidden tabs
> 2. Add a setting to have tabs _always_ visible in fullscreen mode
> 3. Enable "revealing" tabs on mouse hover near the top
>
> Step 3 has some implementation details that are missing, like: on tabs reveal, should the tabs:
> * cover the terminal content, obscuring the top rows, but leaving the rest of the window unchanged
> * cause the terminal to resize
> * shift the terminal content down, obscuring the bottom rows of the terminal, but not forcing a resize?
Now that #3408 is merged (closing #531), we need some place to track the follow-up tasks I had outlined before:
Focus mode and Fullscreen share a lot of commonalities, so I'm grouping them into one thread for easy of x-linking.
## Fullscreen
* [x] Support fullscreen mode, with always hidden tabs
* [ ] #11130 - Add a setting to have tabs _always_ visible in fullscreen mode
- `"showTabsInFullscreen": true|"always"`
* [ ] #5677 - Enable "revealing" tabs on mouse hover near the top
- `"showTabsInFullscreen": "hover"`
* [ ] If a launch full screen option is there, when the full screened app launches, I think the TabView should be visible for a few seconds before sliding out of view. (from @mdtuak in https://github.com/microsoft/terminal/issues/288#issuecomment-551950312)
- this is dependent upon adding `fullscreen` to `launchMode`, tracked in #288
* [x] #4000 It would be nice to have a kind of popup with a tab name when you switch tabs with CTRL+TAB in fullscreen mode.
- Let's add a setting for this as well, this sounds like a not so terrible idea.
- This is the "advanced tab switcher"
## Focus Mode
* [ ] #539
- Not _necessarily_ Focus Mode related, but certainly relevant
* [x] #10730
* [ ] #7210
* [ ] #12959 | Area-UserInterface,Product-Terminal,Issue-Scenario | medium | Critical |
520,229,348 | youtube-dl | Add support for "game" & "title" to Twitch livestreams | ## Checklist
- [x] I'm reporting a feature request
- [x] I've verified that I'm running youtube-dl version **2019.11.05**
- [x] I've searched the bugtracker for similar feature requests including closed ones
## Description
Having support for retrieving the game category and stream title for twitch streams would be a very nice addition.
I know #22501 asked for almost the same thing but was closed under the assumption that twitch has no support for this in their API, which is wrong.
[You can find more info on their API here](https://dev.twitch.tv/docs/v5/reference/streams#get-live-streams)
| request | low | Critical |
520,256,392 | vue | vue-template-compiler module types do not express the correct optional properties | ### Version
2.6.10
### Reproduction link
[https://codesandbox.io/s/vue-template-compiler-module-type-bug-wl0wn](https://codesandbox.io/s/vue-template-compiler-module-type-bug-wl0wn)
### Steps to reproduce
Issue is surfaced by CodeSandbox' typescript linter - just load the sandbox.
### What is expected?
vue-template-compiler should accept modules with **0 or more** of the following properties:
- `preTransformNode`
- `transformNode`
- `postTransformNode`
- `genData`
### What is actually happening?
vue-template-compiler _requires_ modules to have all `transform` functions and `genData` defined.
---
Ran into this while developing a custom template compiler module. It doesn't effect output or compiler functionality in any way, but it does impact developer experience.
Fixed by #10743
<!-- generated by vue-issues. DO NOT REMOVE --> | typescript | medium | Critical |
520,282,357 | TypeScript | SupportΒ ES `exportΒ <default>Β from`Β form | +++ This issue was initially created as a clone of #4813 +++
#4813 (and #34903) are only implementing the `exportΒ *Β asΒ nsΒ from` feature.
This tracks implementation of the [`exportΒ defaultΒ from`](https://github.com/tc39/proposal-export-default-from) proposal. | Suggestion,Waiting for TC39 | low | Major |
520,283,297 | flutter | Asset Image should be brightness-aware | ## Use case
This [documentation](https://flutter.dev/docs/development/ui/assets-and-images) makes people assume that dark mode was already supported. While in reality the only supported variant currently is for scale (device pixel ratio).
When I add **dark** folder as a "variant" it just works for dark theme since the current implementation just pick the "nearest" according to the scale implementation, which also adding **darkx**, **darkwhatever** also just works **BUT** won't work when setting the ThemeData brightness to light since it will pick the "nearest" as I just mentioned before so it will pick whichever variant available there instead of the main image.
Thus "created" a bug, which shouldn't be if the documentation was properly written that this feature was currently not supported yet.
## Proposal
Since I assume that choosing the right variant implementation was based on the information from ImageConfiguration, then ImageConfiguration should also support brightness. And the variant implementation should support choosing the right image for light & dark mode based on the configuration. | c: new feature,framework,d: api docs,a: assets,a: images,c: proposal,P3,team-framework,triaged-framework | medium | Critical |
520,291,673 | flutter | _describeRelevantUserCode crash | ```dart
testWidgets('Does Text', (WidgetTester tester) async {
await tester.pumpWidget(const Text('tight'));
await tester.pumpWidget(const SizedBox(child: Text('loose')));
});
```
I expected three exceptions, one from each pump, plus a third saying that I hadn't caught the first exception (you're supposed to call takeException after pump if pump throws).
However, one of those exceptions triggered a cascade of other exceptions because of some problem in _describeRelevantUserCode:
```
βββ‘ EXCEPTION CAUGHT BY WIDGETS LIBRARY ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
The following assertion was thrown attaching to the render tree:
Looking up a deactivated widget's ancestor is unsafe.
At this point the state of the widget's element tree is no longer stable.
To safely refer to a widget's ancestor in its dispose() method, save a reference to the ancestor by
calling inheritFromWidgetOfExactType() in the widget's didChangeDependencies() method.
When the exception was thrown, this was the stack:
#0 Element._debugCheckStateIsActiveForAncestorLookup.<anonymous closure> (package:flutter/src/widgets/framework.dart:3423:9)
#1 Element._debugCheckStateIsActiveForAncestorLookup (package:flutter/src/widgets/framework.dart:3437:6)
#2 Element.visitAncestorElements (package:flutter/src/widgets/framework.dart:3524:12)
#3 _describeRelevantUserCode (package:flutter/src/widgets/widget_inspector.dart:2827:13)
#4 _parseDiagnosticsNode (package:flutter/src/widgets/widget_inspector.dart:2794:10)
#5 transformDebugCreator (package:flutter/src/widgets/widget_inspector.dart:2774:14)
#6 _SyncIterator.moveNext (dart:core-patch/core_patch.dart:144:12)
#7 new List.from (dart:core-patch/array_patch.dart:45:19)
#8 Iterable.toList (dart:core/iterable.dart:398:5)
#9 _FlutterErrorDetailsNode.builder (package:flutter/src/foundation/assertions.dart:840:66)
#10 DiagnosticableNode.getProperties (package:flutter/src/foundation/diagnostics.dart:2914:87)
#11 TextTreeRenderer.render (package:flutter/src/foundation/diagnostics.dart:1225:63)
#12 FlutterError.dumpErrorToConsole (package:flutter/src/foundation/assertions.dart:647:11)
#13 TestWidgetsFlutterBinding._runTest.<anonymous closure> (package:flutter_test/src/binding.dart:577:24)
#14 FlutterError.reportError (package:flutter/src/foundation/assertions.dart:736:14)
#15 _debugReportException (package:flutter/src/widgets/framework.dart:5314:16)
#16 ComponentElement.performRebuild (package:flutter/src/widgets/framework.dart:3982:9)
#17 Element.rebuild (package:flutter/src/widgets/framework.dart:3755:5)
#18 ComponentElement._firstBuild (package:flutter/src/widgets/framework.dart:3941:5)
#19 ComponentElement.mount (package:flutter/src/widgets/framework.dart:3936:5)
#20 Element.inflateWidget (package:flutter/src/widgets/framework.dart:3109:14)
#21 Element.updateChild (package:flutter/src/widgets/framework.dart:2903:12)
#22 SingleChildRenderObjectElement.mount (package:flutter/src/widgets/framework.dart:5165:14)
#23 Element.inflateWidget (package:flutter/src/widgets/framework.dart:3109:14)
#24 Element.updateChild (package:flutter/src/widgets/framework.dart:2903:12)
#25 RenderObjectToWidgetElement._rebuild (package:flutter/src/widgets/binding.dart:1028:16)
#26 RenderObjectToWidgetElement.update (package:flutter/src/widgets/binding.dart:1006:5)
#27 RenderObjectToWidgetElement.performRebuild (package:flutter/src/widgets/binding.dart:1020:7)
#28 Element.rebuild (package:flutter/src/widgets/framework.dart:3755:5)
#29 BuildOwner.buildScope (package:flutter/src/widgets/framework.dart:2347:33)
#30 AutomatedTestWidgetsFlutterBinding.drawFrame (package:flutter_test/src/binding.dart:975:18)
#31 RendererBinding._handlePersistentFrameCallback (package:flutter/src/rendering/binding.dart:283:5)
#32 SchedulerBinding._invokeFrameCallback (package:flutter/src/scheduler/binding.dart:1097:15)
#33 SchedulerBinding.handleDrawFrame (package:flutter/src/scheduler/binding.dart:1036:9)
#34 AutomatedTestWidgetsFlutterBinding.pump.<anonymous closure> (package:flutter_test/src/binding.dart:873:9)
#37 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:69:41)
#38 AutomatedTestWidgetsFlutterBinding.pump (package:flutter_test/src/binding.dart:860:27)
#39 WidgetTester.pumpWidget.<anonymous closure> (package:flutter_test/src/widget_tester.dart:320:22)
#42 TestAsyncUtils.guard (package:flutter_test/src/test_async_utils.dart:69:41)
#43 WidgetTester.pumpWidget (package:flutter_test/src/widget_tester.dart:317:27)
#44 main.<anonymous closure> (/usr/local/google/home/ianh/dev/flutter/packages/flutter/test/rendering/repaint_boundary_2_test.dart:12:18)
<asynchronous suspension>
#45 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:121:25)
<asynchronous suspension>
#46 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:695:19)
<asynchronous suspension>
#49 TestWidgetsFlutterBinding._runTest (package:flutter_test/src/binding.dart:678:14)
#50 AutomatedTestWidgetsFlutterBinding.runTest.<anonymous closure> (package:flutter_test/src/binding.dart:1051:24)
#56 AutomatedTestWidgetsFlutterBinding.runTest (package:flutter_test/src/binding.dart:1048:15)
#57 testWidgets.<anonymous closure> (package:flutter_test/src/widget_tester.dart:118:22)
#58 Declarer.test.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:168:27)
<asynchronous suspension>
#59 Invoker.waitForOutstandingCallbacks.<anonymous closure> (package:test_api/src/backend/invoker.dart:250:15)
<asynchronous suspension>
#64 Invoker.waitForOutstandingCallbacks (package:test_api/src/backend/invoker.dart:247:5)
#65 Declarer.test.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/declarer.dart:166:33)
#70 Declarer.test.<anonymous closure> (package:test_api/src/backend/declarer.dart:165:13)
<asynchronous suspension>
#71 Invoker._onRun.<anonymous closure>.<anonymous closure>.<anonymous closure>.<anonymous closure> (package:test_api/src/backend/invoker.dart:400:25)
<asynchronous suspension>
#85 _Timer._runTimers (dart:isolate-patch/timer_impl.dart:382:19)
#86 _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
#87 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
(elided 32 frames from class _FakeAsync, package dart:async, package dart:async-patch, and package stack_trace)
ββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββββ
...
```
cc @chunhtai @goderbauer @jacob314 | c: regression,c: crash,framework,f: inspector,P2,team-framework,triaged-framework | low | Critical |
520,292,483 | rust | Optimize out nop-matches | The `?` operator is not zero cost right now, because the matches generated by it don't get optimized as well as they could.
Looking at https://play.rust-lang.org/?version=stable&mode=release&edition=2018&gist=627df52e7c476667ecf9a9831eecf829
I see
```rust
_3 = ((_1 as Ok).0: u32);
_4 = _3;
((_0 as Ok).0: u32) = move _4;
discriminant(_0) = 0;
```
and
```rust
_5 = ((_1 as Err).0: i32);
_6 = _5;
((_0 as Err).0: i32) = move _6;
discriminant(_0) = 1;
```
Which we could reasonably write a peephole optimization for getting transformed to
```rust
_0 = _1
```
each
Then a second optimization could find `switchInt` terminators where all basic blocks are the same and eliminate the `switchInt` by replacing it to a goto to the first basic block being switched to.
This will even benefit matches where only one arm is a nop, because that arm will just become a memcopy | I-slow,C-enhancement,A-codegen,T-compiler,A-MIR,A-mir-opt,A-mir-opt-inlining,C-optimization | low | Major |
520,309,473 | flutter | Make TextField grow horizontally first and then vertically | ## Use case
I am trying to make a TextField that has the following behaviors:
1. Wraps the text content (both vertically and horizontally).
2. Prioritize growing horizontally until it occupies the maximum width possible.
3. Start growing vertically when there's no room to grow horizontally.
I have an existing implementation that has a behavior that is close to that, but not quite the same:
1. Wraps the text content (both vertically and horizontally).
2. Starts growing vertically when the current width is reached, but when `space` is added, it shrinks vertically and grows back horizontally if it has enough space horizontally.
(This is probably hard to comprehend, will update this bug with screen recordings when I have the time)
The following is my implementation:
```
IntrinsicWidth(
child: ConstrainedBox(
constraints: BoxConstraints(
minWidth: someWidth,
),
child: TextField(
minLines: 1,
maxLines: 3,
),
),
),
```
Seems like there's no way to implement the exact behavior that I want (and my implementation is the closest I can get). I wonder if it's possible to build this behavior into the framework?
## Proposal
To build this behavior into the framework.
| a: text input,c: new feature,framework,f: material design,c: proposal,P3,team-text-input,triaged-text-input | low | Critical |
520,311,716 | pytorch | "malloc(): memory corruption (fast)", action=3) at malloc.c | Training crashes after a number of iterations randomly. I don't know where it happens in my python code. When I run 'py-bt', it says 'unable to locate python frame'.
## Environment
PyTorch version: 1.3.1
Is debug build: No
CUDA used to build PyTorch: 10.1.243
OS: Ubuntu 16.04.4 LTS
GCC version: (Ubuntu 5.4.0-6ubuntu1~16.04.10) 5.4.0 20160609
CMake version: version 3.5.1
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: GeForce RTX 2080 Ti
GPU 1: GeForce RTX 2080 Ti
GPU 2: GeForce RTX 2080 Ti
GPU 3: GeForce RTX 2080 Ti
GPU 4: GeForce RTX 2080 Ti
GPU 5: GeForce RTX 2080 Ti
GPU 6: GeForce RTX 2080 Ti
GPU 7: GeForce RTX 2080 Ti
GPU 8: GeForce RTX 2080 Ti
GPU 9: GeForce RTX 2080 Ti
Nvidia driver version: 418.74
cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.1.4
Versions of relevant libraries:
[conda] blas 1.0 mkl
[conda] mkl 2019.4 243
[conda] mkl-service 2.3.0 py37he904b0f_0
[conda] mkl_fft 1.0.15 py37ha843d7b_0
[conda] mkl_random 1.1.0 py37hd6b4f25_0
[conda] pytorch 1.3.1 py3.7_cuda10.1.243_cudnn7.6.3_0 pytorch
[conda] torchvision 0.4.2 py37_cu101 pytorch
## Error Message
> Program terminated with signal SIGABRT, Aborted.
#0 0x00007fe80848f428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
54 ../sysdeps/unix/sysv/linux/raise.c: No such file or directory.
[Current thread is 1 (Thread 0x7fe740ff9700 (LWP 407289))]
(gdb) bt
#0 0x00007fe80848f428 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:54
#1 0x00007fe80849102a in __GI_abort () at abort.c:89
#2 0x00007fe8084d17ea in __libc_message (do_abort=do_abort@entry=2,
fmt=fmt@entry=0x7fe8085eaed8 "*** Error in `%s': %s: 0x%s ***\n") at ../sysdeps/posix/libc_fatal.c:175
#3 0x00007fe8084dc651 in malloc_printerr (ar_ptr=0x7fe740ff70d0, ptr=0x7ffc4aa30138,
str=0x7fe8085eb2e0 "malloc(): memory corruption (fast)", action=3) at malloc.c:5006
#4 _int_malloc (av=av@entry=0x7fe5f0000020, bytes=bytes@entry=16) at malloc.c:3386
#5 0x00007fe8084de184 in __GI___libc_malloc (bytes=bytes@entry=16) at malloc.c:2913
#6 0x00007fe7f85004e5 in operator new (sz=16)
at /home/nwani/m3/conda-bld/compilers_linux-64_1560109574129/work/.build/x86_64-conda_cos6-linux-gnu/src/gcc/libstdc++-v3/libsupc++/new_op.cc:50
#7 0x00007fe7f8abfc96 in void std::vector<at::Tensor, std::allocator<at::Tensor> >::_M_realloc_insert<at::Tensor>(__gnu_cxx::__normal_iterator<at::Tensor*, std::vector<at::Tensor, std::allocator<at::Tensor> > >, at::Tensor&&) ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch_python.so
#8 0x00007fe7cb1bf9ea in at::compute_common_type_(c10::ArrayRef<at::OperandInfo>) ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#9 0x00007fe7cb1c084b in at::TensorIterator::compute_types() ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#10 0x00007fe7cb1c1d6c in at::TensorIterator::build() () from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#11 0x00007fe7cb1c24b5 in at::TensorIterator::binary_op(at::Tensor&, at::Tensor const&, at::Tensor const&, bool) ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#12 0x00007fe7caf42665 in at::native::add_out(at::Tensor&, at::Tensor const&, at::Tensor const&, c10::Scalar) ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#13 0x00007fe7cd7a6ccd in at::CUDAType::(anonymous namespace)::add_(at::Tensor&, at::Tensor const&, c10::Scalar) ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#14 0x00007fe7cd0c5736 in torch::autograd::VariableType::(anonymous namespace)::add_(at::Tensor&, at::Tensor const&, c10::Scalar)
() from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#15 0x00007fe7cafc78ff in at::Tensor::add_(at::Tensor const&, c10::Scalar) const ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#16 0x00007fe7cd34edda in torch::autograd::AccumulateGrad::apply(std::vector<torch::autograd::Variable, std::allocator<torch::autograd::Variable> >&&) () from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#17 0x00007fe7cd34a3f6 in torch::autograd::Node::operator()(std::vector<torch::autograd::Variable, std::allocator<torch::autograd::Variable> >&&) () from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#18 0x00007fe7cd343a07 in torch::autograd::Engine::evaluate_function(torch::autograd::NodeTask&) ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#19 0x00007fe7cd345a14 in torch::autograd::Engine::thread_main(torch::autograd::GraphTask*) ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch.so
#20 0x00007fe7f8a5a5ca in torch::autograd::python::PythonEngine::thread_init(int) ()
from /root/anaconda3/lib/python3.7/site-packages/torch/lib/libtorch_python.so
#21 0x00007fe7f851c19d in std::execute_native_thread_routine (__p=0x559f1840b6c0)
at /home/nwani/m3/conda-bld/compilers_linux-64_1560109574129/work/.build/x86_64-conda_cos6-linux-gnu/src/gcc/libstdc++-v3/src/c++11/thread.cc:80
#22 0x00007fe80882b6ba in start_thread (arg=0x7fe740ff9700) at pthread_create.c:333
#23 0x00007fe80856141d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
cc @ezyang @gchanan @zou3519 @jerryzh168 | needs reproduction,module: crash,triaged | low | Critical |
520,322,549 | flutter | In/out of list announcements only happen if the list extends beyond the screen. | If you create a `ListView` that only has a few items which all fit on the screen, you get no in/out of list announcements. But if the list-view then grows to have enough items to extend beyond the screen, it will announce. This can be very confusing if the list happens to grow because of some user action in the list, such as a button in the list that dynamically adds more items while navigating the list.
/cc @darrenaustin
See also https://github.com/flutter/flutter/issues/22876 | platform-android,framework,engine,a: accessibility,f: scrolling,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-android,triaged-android | low | Minor |
520,343,178 | godot | Step Over in Debug is hard to click due to inspector resizing on every step | **3.2.alpha.calinou.af4fd9de9**
Here is a video of what happens when you try to step through code while debugging. The inspector panel annoyingly resizes in between each click. This doubles the time it takes to step through the code.
Also, as you can see, if you are clicking fast the buttons move so you click "Step In" instead of "Step Over"
[StepGlitch.zip](https://github.com/godotengine/godot/files/3826981/StepGlitch.zip)
| bug,topic:editor,usability | low | Critical |
520,345,967 | godot | Parameter 'playing' in Animated Sprite create useless diffs in git | **Godot version:**
Godot 3.2 Beta 1
**OS/device including version:**
Ubuntu 19.10
**Issue description:**
Godot save number of current frame, when playing option is set, which create useless diffs in git
Example - https://github.com/qarmin/The-worst-Godot-test-project/commit/c34af4da5f5c907135059bb834c5d17f2dca9777#diff-6c71e0a1f3cace35c52e76f1d8d806e5L150-L152
**Steps to reproduce:**
1. Created minimal project with more than 1 frame
2. Click at playing
3. Save scene
4. Add scene to git staging area
5. Open editor with saved scene
6. Close editor
7. Look at git diff
**Minimal reproduction project:**
https://github.com/qarmin/The-worst-Godot-test-project/archive/c34af4da5f5c907135059bb834c5d17f2dca9777.zip
You must open 2DALL scene to show this | bug,discussion,topic:core | low | Minor |
520,367,904 | godot | High CPU usage on HTTPClient with threads (on slow server response) | **Godot version:**
https://github.com/godotengine/godot/commit/0ab0d11c17dd58ac35335cabd032409c42a41a94
**OS/device including version:**
Tested on Windows 10 and x11(Mint)
**Issue description:**
Maybe related to https://github.com/godotengine/godot/issues/32807
Using Theads to run HTTPClient Requests in the background is using 13-40% CPU (Reason is probably a while/requesting data from socket all the time instead of blocking until data is actually available)
I added a variable which reduces the CPU to ~ 0 - 5%
Currently it is always false.
https://github.com/godotengine/godot/blob/dcf0a60a52124b06b161cdaba7bce845b1f43f90/core/io/stream_peer_tcp.cpp#L310
**Steps to reproduce:**
Run example project
Check Taskmanager CPU usage or listen to your CPU fan :D
**Minimal reproduction project:**
[http-bug.zip](https://github.com/godotengine/godot/files/3827103/http-bug.zip)
Let me know if you think it is a bug I will open a PR with my solution.
This line should block until data comes in.
https://github.com/godotengine/godot/blob/24e1039eb6fe32115e8d1a62a84965e9be19a2ed/core/io/http_client.cpp#L694
Solution:
`err = connection->get_partial_data(p_buffer + r_received, left, read, true);` | bug,confirmed,topic:network | low | Critical |
520,381,261 | create-react-app | Add environment variables to manifest.json files | ### Is your proposal related to a problem?
<!--
Provide a clear and concise description of what the problem is.
For example, "I'm always frustrated when..."
-->
In the application, we have several places where we put the values that are in the manifest file, like the theme color, the app name, etc. Unfortunately, if we need to change them one day, we would need to do it everywhere we use them.
### Describe the solution you'd like
<!--
Provide a clear and concise description of what you want to happen.
-->
It would be of very good use if we were able to insert those names in an environment variable file, such as `.env`, and use it in the `manifest.json` as well, just like we do in the `index.html` file.
```json
{
"short_name": "%REACT_APP_SHORT_NAME%",
"name": "%REACT_APP_NAME%"
}
```
### Describe alternatives you've considered
<!--
Let us know about other solutions you've tried or researched.
-->
The only solution to have it automatic would be to or eject the configuration and apply the JSON files to the compilation files, or to add another compilation script that would run during the build process.
| issue: proposal,needs triage | high | Critical |
520,408,631 | flutter | Define global shape in MaterialTheme | ## Use case
There are many Material widgets and it's annoying to customize the themeData of every widget just to add your custom shape to all of them.
## Proposal
The ThemeData class should have a property called:
`
ShapeBorder shape
`
which all Material widgets will default to.
| c: new feature,framework,f: material design,c: proposal,P3,team-design,triaged-design | low | Minor |
520,427,424 | flutter | SnackBarBehavior.floating should be the default | ## Use case
Just like on Material Components Android the floating behavior should be the default one.
There is no reason to keep the old, fixed one the default as the floating behavior fits the material design guidelines better and there also aren't any drawbacks in using the floating style.
## Proposal
Just replace the default value of the "behavior" property with SnackBarBehavior.floating.
| framework,f: material design,c: API break,c: proposal,P3,team-design,triaged-design | low | Minor |
520,474,830 | rust | Integrate mdbook into rustdoc | It doesn't seem to be possible to include external markdown files without using `include_file!`. By this I mean your file would have to be included in your code hierarchy and it's not possible to have it as a separate hierarchy.
This could be useful for getting-started (even though usually included in the README), debugging-tips, or various tutorials.
A few ideas where this could be used:
- Be able to point rustdoc to some folder with markdown files, and it would render them all for the user to use freely in the code as normal links
- Added as an entry in the left column alongside Module, Structs, Enums, etc. Either a single entry to an index that the user would have to create, or a custom hierarchy that the user would define. | T-rustdoc,E-hard,C-feature-request | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.