id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
499,554,222
opencv
improc drawing: undocumented behavior, unpredictable line thickness, etc...
I see issues with cv::line and possibly other drawing primitives, which may be related. firstly, the expected output (thickness, lineType) isn't documented all that precisely. it may be implementation-defined (depends on operating system or 3rd party graphics library?), but then that should be stated in the docs. secondly, what it currently does (v4.1.1 on Win10, also 3.4.4 on a raspbian) is unexpected and follows no discernible pattern. Progressions of line thickness cause monotonously widening lines (at least!), but in uneven steps, and don't interpret thickness as either radius or diameter. Following are a few reproducible examples with halfway visible pixels you can look at. Questions: * how much of a concern is this? * what *should* be the intended behavior? *(Note: I previously used LINE_4 connectivity here, which was rightfully criticized. The section is fixed now.)* Here's a link to a notebook with better visualization. For posterity, equivalent code below. ```py # LINE_8, thickness 3 # thickness=3 actually means radius=3? or what does it mean? img = np.zeros((16,16), np.uint8) img = cv.line(img, (4,8), (12,8), color=255, thickness=3, lineType=cv.LINE_8) ``` ![image](https://github.com/opencv/opencv/assets/7065108/8efcf3e5-041e-435a-84da-168074d716a9) ```py array([[ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 255, 255, 255, 255, 255, 255, 255, 255, 255, 0, 0, 0], [ 0, 0, 0, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 0, 0], [ 0, 0, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 0], [ 0, 0, 0, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 0, 0], [ 0, 0, 0, 0, 255, 255, 255, 255, 255, 255, 255, 255, 255, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]], dtype=uint8) ``` ```py # straight line, thickness=1 with LINE_AA # doesn't even produce a line of thickness 1, and the ridge isn't getting full intensity values either img = np.zeros((16,16), np.uint8) img = cv.line(img, (4,8), (12,8), color=255, thickness=1, lineType=cv.LINE_AA) ``` ![image](https://github.com/opencv/opencv/assets/7065108/e4d5b36b-121d-4af7-9e34-949db67c5943) ```py array([[ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 25, 51, 53, 53, 53, 53, 53, 53, 27, 0, 0, 0], [ 0, 0, 0, 0, 143, 230, 232, 232, 232, 232, 232, 232, 151, 2, 0, 0], [ 0, 0, 0, 0, 29, 58, 58, 58, 58, 58, 58, 58, 31, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]], dtype=uint8) ``` ```py # LINE_AA with thickness=3 # makes it even worse img = np.zeros((16,16), np.uint8) img = cv.line(img, (4,8), (12,8), color=255, thickness=3, lineType=cv.LINE_AA) ``` ![image](https://github.com/opencv/opencv/assets/7065108/18127bca-23cb-46bd-9a9f-ef084aefca58) ```py array([[ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 25, 51, 53, 53, 53, 53, 53, 53, 27, 0, 0, 0], [ 0, 0, 0, 87, 255, 255, 255, 255, 255, 255, 255, 255, 255, 91, 0, 0], [ 0, 0, 0, 194, 255, 255, 255, 255, 255, 255, 255, 255, 255, 196, 0, 0], [ 0, 0, 195, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 255, 198, 4], [ 0, 2, 8, 204, 255, 255, 255, 255, 255, 255, 255, 255, 255, 206, 10, 2], [ 0, 0, 0, 97, 255, 255, 255, 255, 255, 255, 255, 255, 255, 100, 0, 0], [ 0, 0, 0, 0, 31, 58, 58, 58, 58, 58, 58, 58, 33, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], [ 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]], dtype=uint8) ```
category: imgproc,priority: low,RFC
low
Minor
499,569,599
flutter
e2e test for WebView keyboard on Android
Internal: b/292548234 As we're working around some Android VD/IME limitations, we need an e2e test for the keyboard that we can run on a broad range of Android devices.
a: tests,platform-android,p: webview,package,customer: quill (g3),P2,team-android,triaged-android
low
Minor
499,582,838
create-react-app
Scaffold in Current Folder
### Is your proposal related to a problem? I am always frustrated when I want my react project files to be in the root directory of my project, but I need to scaffold them in a sub-folder. (If this feature exists already, I am frustrated that it is not documented clearly in the README). ### Describe the solution you'd like Add a flag that scaffolds files in current directory instead of creating one. ### Describe alternatives you've considered ? ### Additional context I think that describes it pretty well... Thanks!
issue: proposal,needs triage
low
Minor
499,585,839
flutter
Flutter tool should throwToolExit() when HOME/USERPROFILE is expected to be defined but isn't.
For example the Android Studio validator is not robust against this situation: ## command ``` flutter doctor ``` ## exception ``` ArgumentError: Invalid argument(s): join(null, "Applications"): part 0 was null, but part 1 was not. ``` ``` #0 _validateArgList (package:path/src/context.dart:1087:5) #1 Context.join (package:path/src/context.dart:231:5) #2 AndroidStudio._allMacOS (package:flutter_tools/src/android/android_studio.dart:198:29) #3 AndroidStudio.allInstalled (package:flutter_tools/src/android/android_studio.dart:170:26) #4 AndroidStudioValidator.allValidators (package:flutter_tools/src/android/android_studio_validator.dart:20:55) #5 _DefaultDoctorValidatorsProvider.validators (package:flutter_tools/src/doctor.dart:63:35) #6 Doctor.validators (package:flutter_tools/src/doctor.dart:132:46) #7 Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:139:39) #8 Doctor.diagnose (package:flutter_tools/src/doctor.dart:211:41) <asynchronous suspension> #9 DoctorCommand.runCommand (package:flutter_tools/src/commands/doctor.dart:59:39) <asynchronous suspension> #10 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:490:18) #11 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #12 _rootRunUnary (dart:async/zone.dart:1132:38) #13 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #14 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #15 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #16 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #17 Future._completeWithValue (dart:async/future_impl.dart:522:5) #18 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:552:7) #19 _rootRun (dart:async/zone.dart:1124:13) #20 _CustomZone.run (dart:async/zone.dart:1021:19) #21 _CustomZone.runGuarded (dart:async/zone.dart:923:7) #22 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23) #23 _microtaskLoop (dart:async/schedule_microtask.dart:41:21) #24 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) #25 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:116:13) #26 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:173:5) ``` ## flutter doctor ``` encountered exception: Invalid argument(s): join(null, "Applications"): part 0 was null, but part 1 was not. #0 _validateArgList (package:path/src/context.dart:1087:5) #1 Context.join (package:path/src/context.dart:231:5) #2 AndroidStudio._allMacOS (package:flutter_tools/src/android/android_studio.dart:198:29) #3 AndroidStudio.allInstalled (package:flutter_tools/src/android/android_studio.dart:170:26) #4 AndroidStudioValidator.allValidators (package:flutter_tools/src/android/android_studio_validator.dart:20:55) #5 _DefaultDoctorValidatorsProvider.validators (package:flutter_tools/src/doctor.dart:63:35) #6 Doctor.validators (package:flutter_tools/src/doctor.dart:132:46) #7 Doctor.startValidatorTasks (package:flutter_tools/src/doctor.dart:139:39) #8 Doctor.diagnose (package:flutter_tools/src/doctor.dart:211:41) <asynchronous suspension> #9 _doctorText.<anonymous closure> (package:flutter_tools/runner.dart:202:26) #10 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:29) <asynchronous suspension> #11 _rootRun (dart:async/zone.dart:1124:13) #12 _CustomZone.run (dart:async/zone.dart:1021:19) #13 _runZoned (dart:async/zone.dart:1516:10) #14 runZoned (dart:async/zone.dart:1463:12) #15 AppContext.run (package:flutter_tools/src/base/context.dart:153:18) <asynchronous suspension> #16 _doctorText (package:flutter_tools/runner.dart:201:19) <asynchronous suspension> #17 _createLocalCrashReport (package:flutter_tools/runner.dart:179:32) <asynchronous suspension> #18 _handleToolError (package:flutter_tools/runner.dart:134:33) <asynchronous suspension> #19 run.<anonymous closure>.<anonymous closure> (package:flutter_tools/runner.dart:68:22) <asynchronous suspension> #20 _rootRun (dart:async/zone.dart:1124:13) #21 _CustomZone.run (dart:async/zone.dart:1021:19) #22 _runZoned (dart:async/zone.dart:1516:10) #23 runZoned (dart:async/zone.dart:1500:12) #24 run.<anonymous closure> (package:flutter_tools/runner.dart:61:18) <asynchronous suspension> #25 AppContext.run.<anonymous closure> (package:flutter_tools/src/base/context.dart:154:29) <asynchronous suspension> #26 _rootRun (dart:async/zone.dart:1124:13) #27 _CustomZone.run (dart:async/zone.dart:1021:19) #28 _runZoned (dart:async/zone.dart:1516:10) #29 runZoned (dart:async/zone.dart:1463:12) #30 AppContext.run (package:flutter_tools/src/base/context.dart:153:18) <asynchronous suspension> #31 runInContext (package:flutter_tools/src/context_runner.dart:58:24) <asynchronous suspension> #32 run (package:flutter_tools/runner.dart:50:10) #33 main (package:flutter_tools/executable.dart:65:9) <asynchronous suspension> #34 main (file:///Users/ktoley/flutter/packages/flutter_tools/bin/flutter_tools.dart:8:3) #35 _startIsolate.<anonymous closure> (dart:isolate-patch/isolate_patch.dart:303:32) #36 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12) ```
c: crash,tool,t: flutter doctor,P2,team-tool,triaged-tool
low
Critical
499,617,769
terminal
Re-enable C26814 for constexpr locals
This showed up in a recent compiler edition and we aren't ready for all the build breaks it is causing. Many of the issues look fixable, but some of them look upstream in wil (though I suspect it when it says that an HR can be figured out at compile time...)
Help Wanted,Product-Meta,Issue-Task,Area-CodeHealth
low
Minor
499,620,521
flutter
Create unit tests for flutter_runner's component.cc
Right now we don't have unit test coverage for flutter_runner. Dan's PR at https://github.com/flutter/engine/pull/12380 adds a bunch of additional tests for a11y and I want to build upon that to add coverage for at least component.cc which is required by https://github.com/flutter/engine/pull/12428 Spawning this off into a separate issue as https://github.com/flutter/engine/pull/12428 is a pain point for Fuchsia and I'll work on this issue as soon as that's merged.
a: tests,team,framework,engine,P2,team-engine,triaged-engine
low
Minor
499,622,561
flutter
CupertinoTextSelection color fidelity over dark background colors
iOS contextual menus seem to have a special `BlendMode`, where the result color becomes darker when the destination color is brighter. ![image](https://user-images.githubusercontent.com/31859944/65797702-bf88da00-e124-11e9-9273-f26cf82f7ef6.png) ![image](https://user-images.githubusercontent.com/31859944/65797729-cfa0b980-e124-11e9-910b-43bd4799183d.png)
framework,a: fidelity,f: cupertino,P2,team-design,triaged-design
low
Minor
499,638,599
pytorch
torch.quantized.modules.floatFunctional -- add a little color commentary to the doc
Raghu and I were talking and it would be good to add some color commentary to the torch.quantized.modules.floatFunctional entry explaining why this exits (rather than adding an add in the nn module). This came up in some of the developer feedback on the API. Knowing the design considerations might help people understand why they have to take this step.
module: docs,triaged,quantization_release_1.3
low
Minor
499,672,672
go
cmd/gofmt: slice of structs not consistently formatted
See https://play.golang.org/p/uwG_GFPiU13. I expected the literal to be reformatted like this: ``` package main func main() { _ = []struct{ a int }{ { a: 1, }, { a: 2, }, { a: 3, }, } } ``` instead, it preserves the previous formatting. ``` package main func main() { _ = []struct{ a int }{ { a: 1, }, { a: 2, }, { a: 3, }, } } ``` Is this intentional? Or does it make sense to keep the formatting of structs in the slice the same?
NeedsInvestigation
low
Major
499,675,954
TypeScript
Middle operand in comma operator list not properly checked for side-effect-freeness
**TypeScript Version:** master at `f304b81fa54285f` **Search Terms:** comma side effects **Code** ```ts declare const obj: any; console.log(`${JSON.stringify(obj), undefined, 2}`); ``` **Expected behavior:** error TS2695: Left side of comma operator is unused and has no side effects. **Actual behavior:** No errors **Playground Link:** http://www.typescriptlang.org/play/#code/CYUwxgNghgTiAEYD2A7AzgF3kgRgKwC54oUBPAbgChl0kIQA6CJAcwAoADAEgG8ApAMoB5AHINMMAJYoWkgGak2uPAEoANPACuKUHOkhgGgEwBfDiqpA **Related Issues:** <!-- Did you find other bugs that looked similar? --> #10814
Bug,Help Wanted
low
Critical
499,678,888
pytorch
[JIT] Script doesn't preserve builtin torch named tuples upon python return
## 🐛 Bug Torch returns a named tuple for any builtin operator with named returns: `print(torch.randn(20).topk(1))` > torch.return_types.topk( values=tensor([1.0051]), indices=tensor([3])) Script preserves this information within script, but loses it when the object is converted back to python. ``` def top_k(): tensor = torch.randn(20) out = tensor.topk(5) if False: print(out.indices) return out script_top_k = torch.jit.script(top_k) print(script_top_k().indices) ``` > AttributeError: 'tuple' object has no attribute 'indices' cc @suo
oncall: jit,triaged,jit-backlog
low
Critical
499,686,657
flutter
Cannot override Gradle repositories in transitive plugin dependencies
So bit of an issue I've been having getting dependencies on Flutter. I work at a bank, and our network blocks the public maven repositories (jcenter(), google(), etc). Instead we have our own hosted proxy endpoint that routes to maven that we can access from within our network. Typically as an Android developer all I'd need to do to get this working is to override the build.gradle's repositories block with our own URLs, and everything is good to go. Flutter has been more difficult however. Overriding the android portions build.gradle file is not enough on it's own, I also need to override the flutter installations flutter.gradle file to match (though this change gets wiped out when I update the flutter version). Something like the following: ``` repositories { maven { url 'internalUrl/content/repositories/android-maven/' } maven { url 'internalUrl/content/groups/public/' } maven { url internalUrl/content/repositories/gradle-plugins/' } } ``` This ends up working for any project level dependencies I have though, but the real issue happens when I try to pull in additional Flutter plugin dependencies. I suspect that the flutter plugins themselves have their own build.gradle repositories defined that I cannot change. This results in the Android side of the dependencies failing due to network certificate issues, such as the following when I try to use the shared_preferences plugin: ``` FAILURE: Build failed with an exception. * What went wrong: A problem occurred configuring project ':shared_preferences'. > Could not resolve all artifacts for configuration ':shared_preferences:classpath'. > Could not resolve com.android.tools.build:gradle:3.4.0. Required by: project :shared_preferences > Could not resolve com.android.tools.build:gradle:3.4.0. > Could not get resource 'https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > Could not HEAD 'https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target > Could not resolve com.android.tools.build:gradle:3.4.0. > Could not get resource 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > Could not HEAD 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target ``` Now, I have a work around for this in that I can run a seperate Android project, and define those transitive dependencies there, just so I can download them into my local gradle cache folder, but that's a pretty large inconvenience especially when working with larger teams. Ideally is there any way that flutter dependencies could look to the project level repositories before their own? Similar to how they would first look to the gradle cache? ## Logs ``` [ +29 ms] executing: [/Users/molnat2/flutter/] git log -n 1 --pretty=format:%H [ +63 ms] Exit code 0 from: git log -n 1 --pretty=format:%H [ ] 2d2a1ffec95cc70a3218872a2cd3f8de4933c42f [ ] executing: [/Users/molnat2/flutter/] git describe --match v*.*.* --first-parent --long --tags [ +29 ms] Exit code 0 from: git describe --match v*.*.* --first-parent --long --tags [ ] v1.9.1+hotfix.2-0-g2d2a1ffec [ +10 ms] executing: [/Users/molnat2/flutter/] git rev-parse --abbrev-ref --symbolic @{u} [ +20 ms] Exit code 0 from: git rev-parse --abbrev-ref --symbolic @{u} [ ] origin/stable [ ] executing: [/Users/molnat2/flutter/] git ls-remote --get-url origin [ +20 ms] Exit code 0 from: git ls-remote --get-url origin [ ] https://github.com/flutter/flutter.git [ +78 ms] executing: [/Users/molnat2/flutter/] git rev-parse --abbrev-ref HEAD [ +23 ms] Exit code 0 from: git rev-parse --abbrev-ref HEAD [ ] stable [ +326 ms] executing: /Users/molnat2/Library/Android/sdk/platform-tools/adb devices -l [ +21 ms] Exit code 0 from: /Users/molnat2/Library/Android/sdk/platform-tools/adb devices -l [ ] List of devices attached emulator-5554 device product:sdk_gphone_x86 model:Android_SDK_built_for_x86 device:generic_x86 transport_id:6 [ +24 ms] executing: /Users/molnat2/flutter/bin/cache/artifacts/libimobiledevice/idevice_id -h [ +73 ms] /usr/bin/xcrun simctl list --json devices [ +156 ms] /Users/molnat2/Library/Android/sdk/platform-tools/adb -s emulator-5554 shell getprop [ +69 ms] Artifact Instance of 'FlutterWebSdk' is not required, skipping update. [ +4 ms] Artifact Instance of 'WindowsEngineArtifacts' is not required, skipping update. [ +1 ms] Artifact Instance of 'MacOSEngineArtifacts' is not required, skipping update. [ +1 ms] Artifact Instance of 'LinuxEngineArtifacts' is not required, skipping update. [ ] Artifact Instance of 'LinuxFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'MacOSFuchsiaSDKArtifacts' is not required, skipping update. [ ] Artifact Instance of 'FlutterRunnerSDKArtifacts' is not required, skipping update. [ +54 ms] Found plugin shared_preferences at /Users/molnat2/flutter/.pub-cache/hosted/pub.dartlang.org/shared_preferences-0.5.3+4/ [ +15 ms] Found plugin url_launcher at /Users/molnat2/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher-3.0.3/ [ +45 ms] Found plugin shared_preferences at /Users/molnat2/flutter/.pub-cache/hosted/pub.dartlang.org/shared_preferences-0.5.3+4/ [ +11 ms] Found plugin url_launcher at /Users/molnat2/flutter/.pub-cache/hosted/pub.dartlang.org/url_launcher-3.0.3/ [ +38 ms] ro.hardware = ranchu [ +12 ms] executing: [/Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios/Runner.xcodeproj/] /usr/bin/xcodebuild -project /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios/Runner.xcodeproj -target Runner -showBuildSettings [+2512 ms] Exit code 0 from: /usr/bin/xcodebuild -project /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios/Runner.xcodeproj -target Runner -showBuildSettings [ ] Build settings for action build and target Runner: ACTION = build AD_HOC_CODE_SIGNING_ALLOWED = NO ALTERNATE_GROUP = staff ALTERNATE_MODE = u+w,go-w,a+rX ALTERNATE_OWNER = molnat2 ALWAYS_EMBED_SWIFT_STANDARD_LIBRARIES = YES ALWAYS_SEARCH_USER_PATHS = NO ALWAYS_USE_SEPARATE_HEADERMAPS = NO APPLE_INTERNAL_DEVELOPER_DIR = /AppleInternal/Developer APPLE_INTERNAL_DIR = /AppleInternal APPLE_INTERNAL_DOCUMENTATION_DIR = /AppleInternal/Documentation APPLE_INTERNAL_LIBRARY_DIR = /AppleInternal/Library APPLE_INTERNAL_TOOLS = /AppleInternal/Developer/Tools APPLICATION_EXTENSION_API_ONLY = NO APPLY_RULES_IN_COPY_FILES = NO ARCHS = armv7 arm64 ARCHS_STANDARD = armv7 arm64 ARCHS_STANDARD_32_64_BIT = armv7 arm64 ARCHS_STANDARD_32_BIT = armv7 ARCHS_STANDARD_64_BIT = arm64 ARCHS_STANDARD_INCLUDING_64_BIT = armv7 arm64 ARCHS_UNIVERSAL_IPHONE_OS = armv7 arm64 ASSETCATALOG_COMPILER_APPICON_NAME = AppIcon AVAILABLE_PLATFORMS = appletvos appletvsimulator iphoneos iphonesimulator macosx watchos watchsimulator BITCODE_GENERATION_MODE = marker BUILD_ACTIVE_RESOURCES_ONLY = NO BUILD_COMPONENTS = headers build BUILD_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products BUILD_ROOT = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products BUILD_STYLE = BUILD_VARIANTS = normal BUILT_PRODUCTS_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos CACHE_ROOT = /var/folders/5q/90lp2jw57g5gx7hc09_5z5z80000gp/C/com.apple.DeveloperTools/9.2-9C40b/Xcode CCHROOT = /var/folders/5q/90lp2jw57g5gx7hc09_5z5z80000gp/C/com.apple.DeveloperTools/9.2-9C40b/Xcode CHMOD = /bin/chmod CHOWN = /usr/sbin/chown CLANG_ANALYZER_NONNULL = YES CLANG_CXX_LANGUAGE_STANDARD = gnu++0x CLANG_CXX_LIBRARY = libc++ CLANG_ENABLE_MODULES = YES CLANG_ENABLE_OBJC_ARC = YES CLANG_WARN_BLOCK_CAPTURE_AUTORELEASING = YES CLANG_WARN_BOOL_CONVERSION = YES CLANG_WARN_COMMA = YES CLANG_WARN_CONSTANT_CONVERSION = YES CLANG_WARN_DIRECT_OBJC_ISA_USAGE = YES_ERROR CLANG_WARN_EMPTY_BODY = YES CLANG_WARN_ENUM_CONVERSION = YES CLANG_WARN_INFINITE_RECURSION = YES CLANG_WARN_INT_CONVERSION = YES CLANG_WARN_NON_LITERAL_NULL_CONVERSION = YES CLANG_WARN_OBJC_LITERAL_CONVERSION = YES CLANG_WARN_OBJC_ROOT_CLASS = YES_ERROR CLANG_WARN_RANGE_LOOP_ANALYSIS = YES CLANG_WARN_STRICT_PROTOTYPES = YES CLANG_WARN_SUSPICIOUS_MOVE = YES CLANG_WARN_UNREACHABLE_CODE = YES CLANG_WARN__DUPLICATE_METHOD_MATCH = YES CLASS_FILE_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/JavaClasses CLEAN_PRECOMPS = YES CLONE_HEADERS = NO CODESIGNING_FOLDER_PATH = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos/Runner.app CODE_SIGNING_ALLOWED = YES CODE_SIGNING_REQUIRED = YES CODE_SIGN_CONTEXT_CLASS = XCiPhoneOSCodeSignContext CODE_SIGN_IDENTITY = iPhone Developer COLOR_DIAGNOSTICS = NO COMBINE_HIDPI_IMAGES = NO COMPILER_INDEX_STORE_ENABLE = Default COMPOSITE_SDK_DIRS = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/CompositeSDKs COMPRESS_PNG_FILES = YES CONFIGURATION = Release CONFIGURATION_BUILD_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos CONFIGURATION_TEMP_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos CONTENTS_FOLDER_PATH = Runner.app COPYING_PRESERVES_HFS_DATA = NO COPY_HEADERS_RUN_UNIFDEF = NO COPY_PHASE_STRIP = NO COPY_RESOURCES_FROM_STATIC_FRAMEWORKS = YES CORRESPONDING_SIMULATOR_PLATFORM_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform CORRESPONDING_SIMULATOR_PLATFORM_NAME = iphonesimulator CORRESPONDING_SIMULATOR_SDK_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneSimulator.platform/Developer/SDKs/iPhoneSimulator11.2.sdk CORRESPONDING_SIMULATOR_SDK_NAME = iphonesimulator11.2 CP = /bin/cp CREATE_INFOPLIST_SECTION_IN_BINARY = NO CURRENT_ARCH = arm64 CURRENT_VARIANT = normal DEAD_CODE_STRIPPING = YES DEBUGGING_SYMBOLS = YES DEBUG_INFORMATION_FORMAT = dwarf-with-dsym DEFAULT_COMPILER = com.apple.compilers.llvm.clang.1_0 DEFAULT_KEXT_INSTALL_PATH = /System/Library/Extensions DEFINES_MODULE = NO DEPLOYMENT_LOCATION = NO DEPLOYMENT_POSTPROCESSING = NO DEPLOYMENT_TARGET_CLANG_ENV_NAME = IPHONEOS_DEPLOYMENT_TARGET DEPLOYMENT_TARGET_CLANG_FLAG_NAME = miphoneos-version-min DEPLOYMENT_TARGET_CLANG_FLAG_PREFIX = -miphoneos-version-min= DEPLOYMENT_TARGET_SETTING_NAME = IPHONEOS_DEPLOYMENT_TARGET DEPLOYMENT_TARGET_SUGGESTED_VALUES = 8.0 8.1 8.2 8.3 8.4 9.0 9.1 9.2 9.3 10.0 10.1 10.2 10.3 11.0 11.1 11.2 DERIVED_FILES_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/DerivedSources DERIVED_FILE_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/DerivedSources DERIVED_SOURCES_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/DerivedSources DEVELOPER_APPLICATIONS_DIR = /Applications/Xcode.app/Contents/Developer/Applications DEVELOPER_BIN_DIR = /Applications/Xcode.app/Contents/Developer/usr/bin DEVELOPER_DIR = /Applications/Xcode.app/Contents/Developer DEVELOPER_FRAMEWORKS_DIR = /Applications/Xcode.app/Contents/Developer/Library/Frameworks DEVELOPER_FRAMEWORKS_DIR_QUOTED = /Applications/Xcode.app/Contents/Developer/Library/Frameworks DEVELOPER_LIBRARY_DIR = /Applications/Xcode.app/Contents/Developer/Library DEVELOPER_SDK_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs DEVELOPER_TOOLS_DIR = /Applications/Xcode.app/Contents/Developer/Tools DEVELOPER_USR_DIR = /Applications/Xcode.app/Contents/Developer/usr DEVELOPMENT_LANGUAGE = English DEVELOPMENT_TEAM = NCM3L4QUDC DOCUMENTATION_FOLDER_PATH = Runner.app/English.lproj/Documentation DO_HEADER_SCANNING_IN_JAM = NO DSTROOT = /tmp/Runner.dst DT_TOOLCHAIN_DIR = /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain DWARF_DSYM_FILE_NAME = Runner.app.dSYM DWARF_DSYM_FILE_SHOULD_ACCOMPANY_PRODUCT = NO DWARF_DSYM_FOLDER_PATH = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos EFFECTIVE_PLATFORM_NAME = -iphoneos EMBEDDED_CONTENT_CONTAINS_SWIFT = NO EMBEDDED_PROFILE_NAME = embedded.mobileprovision EMBED_ASSET_PACKS_IN_PRODUCT_BUNDLE = NO ENABLE_BITCODE = NO ENABLE_DEFAULT_HEADER_SEARCH_PATHS = YES ENABLE_HEADER_DEPENDENCIES = YES ENABLE_NS_ASSERTIONS = NO ENABLE_ON_DEMAND_RESOURCES = YES ENABLE_STRICT_OBJC_MSGSEND = YES ENABLE_TESTABILITY = NO ENTITLEMENTS_ALLOWED = YES ENTITLEMENTS_REQUIRED = YES EXCLUDED_INSTALLSRC_SUBDIRECTORY_PATTERNS = .DS_Store .svn .git .hg CVS EXCLUDED_RECURSIVE_SEARCH_PATH_SUBDIRECTORIES = *.nib *.lproj *.framework *.gch *.xcode* *.xcassets (*) .DS_Store CVS .svn .git .hg *.pbproj *.pbxproj EXECUTABLES_FOLDER_PATH = Runner.app/Executables EXECUTABLE_FOLDER_PATH = Runner.app EXECUTABLE_NAME = Runner EXECUTABLE_PATH = Runner.app/Runner EXPANDED_CODE_SIGN_IDENTITY = EXPANDED_CODE_SIGN_IDENTITY_NAME = EXPANDED_PROVISIONING_PROFILE = FILE_LIST = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/Objects/LinkFileList FIXED_FILES_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/FixedFiles FLUTTER_ROOT = /Users/majees3/Software Packages/flutter FRAMEWORKS_FOLDER_PATH = Runner.app/Frameworks FRAMEWORK_FLAG_PREFIX = -framework FRAMEWORK_SEARCH_PATHS = "/Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos/IQKeyboardManagerSwift" "/Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos/IQKeyboardManagerSwift" /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios/Flutter FRAMEWORK_VERSION = A FULL_PRODUCT_NAME = Runner.app GCC3_VERSION = 3.3 GCC_C_LANGUAGE_STANDARD = gnu99 GCC_INLINES_ARE_PRIVATE_EXTERN = YES GCC_NO_COMMON_BLOCKS = YES GCC_PFE_FILE_C_DIALECTS = c objective-c c++ objective-c++ GCC_PREPROCESSOR_DEFINITIONS = COCOAPODS=1 COCOAPODS=1 GCC_SYMBOLS_PRIVATE_EXTERN = YES GCC_THUMB_SUPPORT = YES GCC_TREAT_WARNINGS_AS_ERRORS = NO GCC_VERSION = com.apple.compilers.llvm.clang.1_0 GCC_VERSION_IDENTIFIER = com_apple_compilers_llvm_clang_1_0 GCC_WARN_64_TO_32_BIT_CONVERSION = YES GCC_WARN_ABOUT_RETURN_TYPE = YES_ERROR GCC_WARN_UNDECLARED_SELECTOR = YES GCC_WARN_UNINITIALIZED_AUTOS = YES_AGGRESSIVE GCC_WARN_UNUSED_FUNCTION = YES GCC_WARN_UNUSED_VARIABLE = YES GENERATE_MASTER_OBJECT_FILE = NO GENERATE_PKGINFO_FILE = YES GENERATE_PROFILING_CODE = NO GENERATE_TEXT_BASED_STUBS = NO GID = 20 GROUP = staff HEADERMAP_INCLUDES_FLAT_ENTRIES_FOR_TARGET_BEING_BUILT = YES HEADERMAP_INCLUDES_FRAMEWORK_ENTRIES_FOR_ALL_PRODUCT_TYPES = YES HEADERMAP_INCLUDES_NONPUBLIC_NONPRIVATE_HEADERS = YES HEADERMAP_INCLUDES_PROJECT_HEADERS = YES HEADERMAP_USES_FRAMEWORK_PREFIX_ENTRIES = YES HEADERMAP_USES_VFS = NO HEADER_SEARCH_PATHS = "/Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos/IQKeyboardManagerSwift/IQKeyboardManagerSwift.framework/Headers" "/Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos/IQKeyboardManagerSwift/IQKeyboardManagerSwift.framework/Headers" HIDE_BITCODE_SYMBOLS = YES HOME = /Users/molnat2 ICONV = /usr/bin/iconv INFOPLIST_EXPAND_BUILD_SETTINGS = YES INFOPLIST_FILE = Runner/Info.plist INFOPLIST_OUTPUT_FORMAT = binary INFOPLIST_PATH = Runner.app/Info.plist INFOPLIST_PREPROCESS = NO INFOSTRINGS_PATH = Runner.app/English.lproj/InfoPlist.strings INLINE_PRIVATE_FRAMEWORKS = NO INSTALLHDRS_COPY_PHASE = NO INSTALLHDRS_SCRIPT_PHASE = NO INSTALL_DIR = /tmp/Runner.dst/Applications INSTALL_GROUP = staff INSTALL_MODE_FLAG = u+w,go-w,a+rX INSTALL_OWNER = molnat2 INSTALL_PATH = /Applications INSTALL_ROOT = /tmp/Runner.dst IPHONEOS_DEPLOYMENT_TARGET = 10.0 JAVAC_DEFAULT_FLAGS = -J-Xms64m -J-XX:NewSize=4M -J-Dfile.encoding=UTF8 JAVA_APP_STUB = /System/Library/Frameworks/JavaVM.framework/Resources/MacOS/JavaApplicationStub JAVA_ARCHIVE_CLASSES = YES JAVA_ARCHIVE_TYPE = JAR JAVA_COMPILER = /usr/bin/javac JAVA_FOLDER_PATH = Runner.app/Java JAVA_FRAMEWORK_RESOURCES_DIRS = Resources JAVA_JAR_FLAGS = cv JAVA_SOURCE_SUBDIR = . JAVA_USE_DEPENDENCIES = YES JAVA_ZIP_FLAGS = -urg JIKES_DEFAULT_FLAGS = +E +OLDCSO KASAN_DEFAULT_CFLAGS = -DKASAN=1 -fsanitize=address -mllvm -asan-globals-live-support -mllvm -asan-force-dynamic-shadow KEEP_PRIVATE_EXTERNS = NO LD_DEPENDENCY_INFO_FILE = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/Objects-normal/arm64/Runner_dependency_info.dat LD_GENERATE_MAP_FILE = NO LD_MAP_FILE_PATH = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/Runner-LinkMap-normal-arm64.txt LD_NO_PIE = NO LD_QUOTE_LINKER_ARGUMENTS_FOR_COMPILER_DRIVER = YES LD_RUNPATH_SEARCH_PATHS = '@executable_path/Frameworks' '@loader_path/Frameworks' '@executable_path/Frameworks' '@loader_path/Frameworks' @executable_path/Frameworks LEGACY_DEVELOPER_DIR = /Applications/Xcode.app/Contents/PlugIns/Xcode3Core.ideplugin/Contents/SharedSupport/Developer LEX = lex LIBRARY_FLAG_NOSPACE = YES LIBRARY_FLAG_PREFIX = -l LIBRARY_KEXT_INSTALL_PATH = /Library/Extensions LIBRARY_SEARCH_PATHS = /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios/Flutter LINKER_DISPLAYS_MANGLED_NAMES = NO LINK_FILE_LIST_normal_arm64 = LINK_FILE_LIST_normal_armv7 = LINK_WITH_STANDARD_LIBRARIES = YES LOCALIZABLE_CONTENT_DIR = LOCALIZED_RESOURCES_FOLDER_PATH = Runner.app/English.lproj LOCAL_ADMIN_APPS_DIR = /Applications/Utilities LOCAL_APPS_DIR = /Applications LOCAL_DEVELOPER_DIR = /Library/Developer LOCAL_LIBRARY_DIR = /Library LOCROOT = LOCSYMROOT = MACH_O_TYPE = mh_execute MAC_OS_X_PRODUCT_BUILD_VERSION = 18G95 MAC_OS_X_VERSION_ACTUAL = 101406 MAC_OS_X_VERSION_MAJOR = 101400 MAC_OS_X_VERSION_MINOR = 1406 METAL_LIBRARY_FILE_BASE = default METAL_LIBRARY_OUTPUT_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos/Runner.app MODULE_CACHE_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/ModuleCache MTL_ENABLE_DEBUG_INFO = NO NATIVE_ARCH = armv7 NATIVE_ARCH_32_BIT = i386 NATIVE_ARCH_64_BIT = x86_64 NATIVE_ARCH_ACTUAL = x86_64 NO_COMMON = YES OBJECT_FILE_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/Objects OBJECT_FILE_DIR_normal = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/Objects-normal OBJROOT = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex ONLY_ACTIVE_ARCH = NO OS = MACOS OSAC = /usr/bin/osacompile OTHER_LDFLAGS = -framework "CoreGraphics" -framework "Foundation" -framework "IQKeyboardManagerSwift" -framework "QuartzCore" -framework "UIKit" -framework "CoreGraphics" -framework "Foundation" -framework "IQKeyboardManagerSwift" -framework "QuartzCore" -framework "UIKit" OTHER_SWIFT_FLAGS = -D COCOAPODS -D COCOAPODS PACKAGE_TYPE = com.apple.package-type.wrapper.application PASCAL_STRINGS = YES PATH = /Applications/Xcode.app/Contents/Developer/usr/bin:/Users/molnat2/flutter/bin:/Users/molnat2/Library/Android/sdk/tools:/Users/molnat2/Library/Android/sdk/platform-tools:/usr/local/opt/openssl/bin:/Users/molnat2/Libra ry/Android/Sdk/platform-tools:/usr/local/bin:/usr/bin:/bin:/usr/sbin:/sbin PATH_PREFIXES_EXCLUDED_FROM_HEADER_DEPENDENCIES = /usr/include /usr/local/include /System/Library/Frameworks /System/Library/PrivateFrameworks /Applications/Xcode.app/Contents/Developer/Headers /Applications/Xcode.app/Contents/Developer/SDKs /Applications/Xcode.app/Contents/Developer/Platforms PBDEVELOPMENTPLIST_PATH = Runner.app/pbdevelopment.plist PFE_FILE_C_DIALECTS = objective-c PKGINFO_FILE_PATH = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/PkgInfo PKGINFO_PATH = Runner.app/PkgInfo PLATFORM_DEVELOPER_APPLICATIONS_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Applications PLATFORM_DEVELOPER_BIN_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr/bin PLATFORM_DEVELOPER_LIBRARY_DIR = /Applications/Xcode.app/Contents/PlugIns/Xcode3Core.ideplugin/Contents/SharedSupport/Developer/Library PLATFORM_DEVELOPER_SDK_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs PLATFORM_DEVELOPER_TOOLS_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/Tools PLATFORM_DEVELOPER_USR_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/usr PLATFORM_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform PLATFORM_DISPLAY_NAME = iOS PLATFORM_NAME = iphoneos PLATFORM_PREFERRED_ARCH = arm64 PLATFORM_PRODUCT_BUILD_VERSION = 15C107 PLIST_FILE_OUTPUT_FORMAT = binary PLUGINS_FOLDER_PATH = Runner.app/PlugIns PODS_BUILD_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products PODS_CONFIGURATION_BUILD_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos PODS_PODFILE_DIR_PATH = /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios/. PODS_ROOT = /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios/Pods PRECOMPS_INCLUDE_HEADERS_FROM_BUILT_PRODUCTS_DIR = YES PRECOMP_DESTINATION_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/PrefixHeaders PRESERVE_DEAD_CODE_INITS_AND_TERMS = NO PRIVATE_HEADERS_FOLDER_PATH = Runner.app/PrivateHeaders PRODUCT_BUNDLE_IDENTIFIER = tdi.td.com.tdi PRODUCT_MODULE_NAME = Runner PRODUCT_NAME = Runner PRODUCT_SETTINGS_PATH = /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios/Runner/Info.plist PRODUCT_TYPE = com.apple.product-type.application PROFILING_CODE = NO PROJECT = Runner PROJECT_DERIVED_FILE_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/DerivedSources PROJECT_DIR = /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios PROJECT_FILE_PATH = /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios/Runner.xcodeproj PROJECT_NAME = Runner PROJECT_TEMP_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build PROJECT_TEMP_ROOT = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex PROVISIONING_PROFILE_REQUIRED = YES PUBLIC_HEADERS_FOLDER_PATH = Runner.app/Headers RECURSIVE_SEARCH_PATHS_FOLLOW_SYMLINKS = YES REMOVE_CVS_FROM_RESOURCES = YES REMOVE_GIT_FROM_RESOURCES = YES REMOVE_HEADERS_FROM_EMBEDDED_BUNDLES = YES REMOVE_HG_FROM_RESOURCES = YES REMOVE_SVN_FROM_RESOURCES = YES RESOURCE_RULES_REQUIRED = YES REZ_COLLECTOR_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/ResourceManagerResources REZ_OBJECTS_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build/ResourceManagerResources/Objects SCAN_ALL_SOURCE_FILES_FOR_INCLUDES = NO SCRIPTS_FOLDER_PATH = Runner.app/Scripts SDKROOT = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk SDK_DIR = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk SDK_DIR_iphoneos11_2 = /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS11.2.sdk SDK_NAME = iphoneos11.2 SDK_NAMES = iphoneos11.2 SDK_PRODUCT_BUILD_VERSION = 15C107 SDK_VERSION = 11.2 SDK_VERSION_ACTUAL = 110200 SDK_VERSION_MAJOR = 110000 SDK_VERSION_MINOR = 200 SED = /usr/bin/sed SEPARATE_STRIP = NO SEPARATE_SYMBOL_EDIT = NO SET_DIR_MODE_OWNER_GROUP = YES SET_FILE_MODE_OWNER_GROUP = NO SHALLOW_BUNDLE = YES SHARED_DERIVED_FILE_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos/DerivedSources SHARED_FRAMEWORKS_FOLDER_PATH = Runner.app/SharedFrameworks SHARED_PRECOMPS_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/PrecompiledHeaders SHARED_SUPPORT_FOLDER_PATH = Runner.app/SharedSupport SKIP_INSTALL = NO SOURCE_ROOT = /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios SRCROOT = /Users/molnat2/workspace/td-ca-flutter-poc-tdi/ios STRINGS_FILE_OUTPUT_ENCODING = binary STRIP_BITCODE_FROM_COPIED_FILES = YES STRIP_INSTALLED_PRODUCT = YES STRIP_STYLE = all STRIP_SWIFT_SYMBOLS = YES SUPPORTED_DEVICE_FAMILIES = 1,2 SUPPORTED_PLATFORMS = iphonesimulator iphoneos SUPPORTS_TEXT_BASED_API = NO SWIFT_OBJC_BRIDGING_HEADER = Runner/Runner-Bridging-Header.h SWIFT_OPTIMIZATION_LEVEL = -Owholemodule SWIFT_PLATFORM_TARGET_PREFIX = ios SWIFT_SWIFT3_OBJC_INFERENCE = Off SWIFT_VERSION = 4.0 SYMROOT = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products SYSTEM_ADMIN_APPS_DIR = /Applications/Utilities SYSTEM_APPS_DIR = /Applications SYSTEM_CORE_SERVICES_DIR = /System/Library/CoreServices SYSTEM_DEMOS_DIR = /Applications/Extras SYSTEM_DEVELOPER_APPS_DIR = /Applications/Xcode.app/Contents/Developer/Applications SYSTEM_DEVELOPER_BIN_DIR = /Applications/Xcode.app/Contents/Developer/usr/bin SYSTEM_DEVELOPER_DEMOS_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Utilities/Built Examples SYSTEM_DEVELOPER_DIR = /Applications/Xcode.app/Contents/Developer SYSTEM_DEVELOPER_DOC_DIR = /Applications/Xcode.app/Contents/Developer/ADC Reference Library SYSTEM_DEVELOPER_GRAPHICS_TOOLS_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Graphics Tools SYSTEM_DEVELOPER_JAVA_TOOLS_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Java Tools SYSTEM_DEVELOPER_PERFORMANCE_TOOLS_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Performance Tools SYSTEM_DEVELOPER_RELEASENOTES_DIR = /Applications/Xcode.app/Contents/Developer/ADC Reference Library/releasenotes SYSTEM_DEVELOPER_TOOLS = /Applications/Xcode.app/Contents/Developer/Tools SYSTEM_DEVELOPER_TOOLS_DOC_DIR = /Applications/Xcode.app/Contents/Developer/ADC Reference Library/documentation/DeveloperTools SYSTEM_DEVELOPER_TOOLS_RELEASENOTES_DIR = /Applications/Xcode.app/Contents/Developer/ADC Reference Library/releasenotes/DeveloperTools SYSTEM_DEVELOPER_USR_DIR = /Applications/Xcode.app/Contents/Developer/usr SYSTEM_DEVELOPER_UTILITIES_DIR = /Applications/Xcode.app/Contents/Developer/Applications/Utilities SYSTEM_DOCUMENTATION_DIR = /Library/Documentation SYSTEM_KEXT_INSTALL_PATH = /System/Library/Extensions SYSTEM_LIBRARY_DIR = /System/Library TAPI_VERIFY_MODE = ErrorsOnly TARGETED_DEVICE_FAMILY = 1,2 TARGETNAME = Runner TARGET_BUILD_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Products/Release-iphoneos TARGET_NAME = Runner TARGET_TEMP_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build TEMP_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build TEMP_FILES_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build TEMP_FILE_DIR = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex/Runner.build/Release-iphoneos/Runner.build TEMP_ROOT = /Users/molnat2/Library/Developer/Xcode/DerivedData/Runner-cugnadsmvkykitckhqhrgxbamnea/Build/Intermediates.noindex TOOLCHAIN_DIR = /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain TREAT_MISSING_BASELINES_AS_TEST_FAILURES = NO UID = 502 UNLOCALIZED_RESOURCES_FOLDER_PATH = Runner.app UNSTRIPPED_PRODUCT = NO USER = molnat2 USER_APPS_DIR = /Users/molnat2/Applications USER_LIBRARY_DIR = /Users/molnat2/Library USE_DYNAMIC_NO_PIC = YES USE_HEADERMAP = YES USE_HEADER_SYMLINKS = NO VALIDATE_PRODUCT = YES VALID_ARCHS = arm64 armv7 armv7s VERBOSE_PBXCP = NO VERSIONING_SYSTEM = apple-generic VERSIONPLIST_PATH = Runner.app/version.plist VERSION_INFO_BUILDER = molnat2 VERSION_INFO_FILE = Runner_vers.c VERSION_INFO_STRING = "@(#)PROGRAM:Runner PROJECT:Runner-" WRAPPER_EXTENSION = app WRAPPER_NAME = Runner.app WRAPPER_SUFFIX = .app WRAP_ASSET_PACKS_IN_SEPARATE_DIRECTORIES = NO XCODE_APP_SUPPORT_DIR = /Applications/Xcode.app/Contents/Developer/Library/Xcode XCODE_PRODUCT_BUILD_VERSION = 9C40b XCODE_VERSION_ACTUAL = 0920 XCODE_VERSION_MAJOR = 0900 XCODE_VERSION_MINOR = 0920 XPCSERVICES_FOLDER_PATH = Runner.app/XPCServices YACC = yacc arch = arm64 variant = normal [ +67 ms] Using hardware rendering with device Android SDK built for x86. If you get graphics artifacts, consider enabling software rendering with "--enable-software-rendering". [ +19 ms] Launching lib/main.dart on Android SDK built for x86 in debug mode... [ +19 ms] Initializing gradle... [ +10 ms] Using gradle from /Users/molnat2/workspace/td-ca-flutter-poc-tdi/android/gradlew. [ +234 ms] executing: /usr/bin/plutil -convert json -o - /Applications/Android Studio.app/Contents/Info.plist [ +13 ms] Exit code 0 from: /usr/bin/plutil -convert json -o - /Applications/Android Studio.app/Contents/Info.plist [ ] {"CFBundleName":"Android Studio","JVMOptions":{"MainClass":"com.intellij.idea.Main","ClassPath":"$APP_PACKAGE\/Contents\/lib\/bootstrap.jar:$APP_PACKAGE\/Contents\/lib\/extensions.jar:$APP_PACKAGE\/Contents\/lib\/util.jar:$APP_PACKAGE\/Contents\/lib\/jdom. jar:$APP_PACKAGE\/Contents\/lib\/log4j.jar:$APP_PACKAGE\/Contents\/lib\/trove4j.jar:$APP_PACKAGE\/Contents\/lib\/jna.jar","JVMVersion":"1.8*,1.8+","Properties":{"idea.home.path":"$APP_PACKAGE\/Contents","idea.executable":"studio"," idea.platform.prefix":"AndroidStudio","idea.paths.selector":"AndroidStudio3.5"},"WorkingDirectory":"$APP_PACKAGE\/Contents\/bin"},"LSArchitecturePriority":["x86_64"],"CFBundleVersion":"AI-191.8026.42.35.5791312","CFBundleDevelopmen tRegion":"English","CFBundleDocumentTypes":[{"CFBundleTypeExtensions":["ipr"],"CFBundleTypeName":"Android Studio Project File","CFBundleTypeIconFile":"studio.icns","CFBundleTypeRole":"Editor"},{"CFBundleTypeExtensions":["*"],"CFBundleTypeOSTypes":["****"],"LSTypeIsPackage":false,"CFBundleTypeName":"All documents","CFBundleTypeRole":"Editor"}],"NSSupportsAutomaticGraphicsSwitching":true,"CFBundlePackageType":"APPL","CFBundleIconFile":"studio.icns","NSHighResolutionCapable":true,"CFBundleShortVersionString":"3.5","CFBundleInfoDicti onaryVersion":"6.0","CFBundleExecutable":"studio","LSRequiresNativeExecution":"YES","CFBundleURLTypes":[{"CFBundleURLName":"Stacktrace","CFBundleURLSchemes":["idea"],"CFBundleTypeRole":"Editor"}],"CFBundleIdentifier":"com.google.an droid.studio","LSApplicationCategoryType":"public.app-category.developer-tools","CFBundleSignature":"????","LSMinimumSystemVersion":"10.8","CFBundleGetInfoString":"Android Studio 3.5, build AI-191.8026.42.35.5791312. Copyright JetBrains s.r.o., (c) 2000-2019"} [ +126 ms] executing: /Users/molnat2/workspace/td-ca-flutter-poc-tdi/android/gradlew -v [ +785 ms] ------------------------------------------------------------ Gradle 4.10.2 ------------------------------------------------------------ Build time: 2018-09-19 18:10:15 UTC Revision: b4d8d5d170bb4ba516e88d7fe5647e2323d791dd Kotlin DSL: 1.0-rc-6 Kotlin: 1.2.61 Groovy: 2.4.15 Ant: Apache Ant(TM) version 1.9.11 compiled on March 23 2018 JVM: 1.8.0_202-release (JetBrains s.r.o 25.202-b49-5587405) OS: Mac OS X 10.14.6 x86_64 [ +14 ms] Initializing gradle... (completed in 1.2s) [ +1 ms] Resolving dependencies... [ ] executing: [/Users/molnat2/workspace/td-ca-flutter-poc-tdi/android/] /Users/molnat2/workspace/td-ca-flutter-poc-tdi/android/gradlew app:properties [+4932 ms] > Configure project :shared_preferences Project evaluation failed including an error in afterEvaluate {}. Run with --stacktrace for details of the afterEvaluate {} error. FAILURE: Build failed with an exception. * What went wrong: A problem occurred configuring project ':shared_preferences'. > Could not resolve all artifacts for configuration ':shared_preferences:classpath'. > Could not resolve com.android.tools.build:gradle:3.4.0. Required by: project :shared_preferences > Could not resolve com.android.tools.build:gradle:3.4.0. > Could not get resource 'https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > Could not HEAD 'https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target > Could not resolve com.android.tools.build:gradle:3.4.0. > Could not get resource 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > Could not HEAD 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 4s [ +13 ms] Resolving dependencies... (completed in 4.9s) [ +3 ms] * Error running Gradle: ProcessException: Process "/Users/molnat2/workspace/td-ca-flutter-poc-tdi/android/gradlew" exited abnormally: > Configure project :shared_preferences Project evaluation failed including an error in afterEvaluate {}. Run with --stacktrace for details of the afterEvaluate {} error. FAILURE: Build failed with an exception. * What went wrong: A problem occurred configuring project ':shared_preferences'. > Could not resolve all artifacts for configuration ':shared_preferences:classpath'. > Could not resolve com.android.tools.build:gradle:3.4.0. Required by: project :shared_preferences > Could not resolve com.android.tools.build:gradle:3.4.0. > Could not get resource 'https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > Could not HEAD 'https://dl.google.com/dl/android/maven2/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target > Could not resolve com.android.tools.build:gradle:3.4.0. > Could not get resource 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > Could not HEAD 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.4.0/gradle-3.4.0.pom'. > sun.security.validator.ValidatorException: PKIX path building failed: sun.security.provider.certpath.SunCertPathBuilderException: unable to find valid certification path to requested target * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org BUILD FAILED in 4s Command: /Users/molnat2/workspace/td-ca-flutter-poc-tdi/android/gradlew app:properties [ +4 ms] "flutter run" took 9,651ms. Please review your Gradle project setup in the android/ folder. #0 throwToolExit (package:flutter_tools/src/base/common.dart:28:3) #1 _readGradleProject (package:flutter_tools/src/android/gradle.dart:233:7) <asynchronous suspension> #2 _gradleAppProject (package:flutter_tools/src/android/gradle.dart:112:37) <asynchronous suspension> #3 getGradleAppOut (package:flutter_tools/src/android/gradle.dart:106:29) <asynchronous suspension> #4 AndroidApk.fromAndroidProject (package:flutter_tools/src/application_package.dart:164:23) <asynchronous suspension> #5 ApplicationPackageFactory.getPackageForPlatform (package:flutter_tools/src/application_package.dart:46:32) <asynchronous suspension> #6 FlutterDevice.runHot (package:flutter_tools/src/resident_runner.dart:359:56) <asynchronous suspension> #7 HotRunner.run (package:flutter_tools/src/run_hot.dart:254:39) <asynchronous suspension> #8 RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:472:37) <asynchronous suspension> #9 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:490:18) #10 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #11 _rootRunUnary (dart:async/zone.dart:1132:38) #12 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #13 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #14 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #15 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #16 Future._completeWithValue (dart:async/future_impl.dart:522:5) #17 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15) #18 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13) #19 RunCommand.usageValues (package:flutter_tools/src/commands/run.dart) #20 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #21 _rootRunUnary (dart:async/zone.dart:1132:38) #22 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #23 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #24 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #25 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #26 Future._completeWithValue (dart:async/future_impl.dart:522:5) #27 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15) #28 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13) #29 AndroidDevice.isLocalEmulator (package:flutter_tools/src/android/android_device.dart) #30 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #31 _rootRunUnary (dart:async/zone.dart:1132:38) #32 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #33 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #34 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #35 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #36 Future._completeWithValue (dart:async/future_impl.dart:522:5) #37 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:552:7) #38 _rootRun (dart:async/zone.dart:1124:13) #39 _CustomZone.run (dart:async/zone.dart:1021:19) #40 _CustomZone.runGuarded (dart:async/zone.dart:923:7) #41 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23) #42 _microtaskLoop (dart:async/schedule_microtask.dart:41:21) #43 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) #44 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:116:13) #45 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:173:5) ``` ``` Analyzing android... (This is taking an unexpectedly long time.) ``` ``` [✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Mac OS X 10.14.6 18G95, locale en-CA) • Flutter version 1.9.1+hotfix.2 at /Users/molnat2/flutter • Framework revision 2d2a1ffec9 (3 weeks ago), 2019-09-06 18:39:49 -0700 • Engine revision b863200c37 • Dart version 2.5.0 [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) • Android SDK at /Users/molnat2/Library/Android/sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-28, build-tools 28.0.3 • ANDROID_HOME = /Users/molnat2/Library/Android/sdk • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 9.2) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 9.2, Build version 9C40b • CocoaPods version 1.6.0 [✓] Android Studio (version 3.5) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 39.0.3 • Dart plugin version 191.8423 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) [!] IntelliJ IDEA Community Edition (version 2018.2.5) • IntelliJ at /Applications/IntelliJ IDEA CE.app ✗ Flutter plugin not installed; this adds Flutter specific functionality. ✗ Dart plugin not installed; this adds Dart specific functionality. • For information about installing plugins, see https://flutter.dev/intellij-setup/#installing-the-plugins [✓] Connected device (1 available) • Android SDK built for x86 • emulator-5554 • android-x86 • Android 10 (API 29) (emulator) ! Doctor found issues in 1 category. ``` // please disregard the intelij portion of the flutter doctor output, I just use Android Studio for Flutter
tool,t: gradle,P2,team-tool,triaged-tool
low
Critical
499,704,843
opencv
calibrateCamera with CALIB_FIX_ASPECT_RATIO + CALIB_RATIONAL_MODEL yields zero distortion coefficients
##### System information (version) - Python => 3.6.8 - OpenCV => 4.0.1 (Anaconda package build version: py36hce2de41_201) - Operating System / Platform => Windows and Linux (RHEL) 64 Bit - Compiler => Visual Studio 2015 and g++ 8.2.0 ##### Detailed description When I call function `calibrateCamera` with the `flags` argument equal to `cv2.CALIB_FIX_ASPECT_RATIO + cv2.CALIB_RATIONAL_MODEL`, I get all distortion coefficients equal to zero. When calling the function, I pass an array of shape (8, 1) full of zeros. I also noticed that the following cases do *not* yield distortion coefficients equal to zero after the optimization finishes (properly sized arrays are passed in each): - `flags = cv2.CALIB_FIX_ASPECT_RATIO + cv2.CALIB_RATIONAL_MODEL + cv2.CALIB_THIN_PRISM_MODEL` - `flags = cv2.CALIB_FIX_ASPECT_RATIO + cv2.CALIB_RATIONAL_MODEL + cv2.CALIB_THIN_PRISM_MODEL + cv2.CALIB_TILTED_MODEL` ##### Steps to reproduce Unfortunately, I cannot share the data or the code. But I'm wondering if others also experience this issue. I also initialize the camera matrix elements [0, 0] and [1, 1] to the value 1. All other arguments take on their default values.
category: calib3d,incomplete,needs reproducer
low
Minor
499,707,682
godot
Server binary max fps steady at 144
**Godot version:** 3.1.1 April 27, 2019 **OS/device including version:** Linux vps227684 4.9.0-9-amd64 #1 SMP Debian 4.9.168-1 (2019-04-12) x86_64 GNU/Linux Its a [OVH VPS Cloud 1](https://www.ovh.com/world/en/vps/vps-cloud.xml) with a 3GHz vCore **Issue description:** I got a project that is a `Node` with a `Node2D` as a child, both empty. A singleton that pools a `NetworkedMultiplayerEnet` on `_process()`. I uploaded the project to the VPS and ran it. Out of curiosity went to check the FPS using `print(Engine.get_frames_per_second())` every 1 sec using a `Timer` and just got a steady 123 FPS. Now, if I run the project on my very old and crappy laptop (Celeron 847 @ 1.10GHz) the project runs at ~200 and even spiking to 300 FPS. Tried setting the project to run at fullscreen and also disabling vsync. Also wrote this as to try to force all of it but still doesnt work: ``` OS.low_processor_usage_mode = false OS.set_use_vsync(false) ProjectSettings.set_setting("display/window/vsync/use_vsync", false) ``` So I'm thinking it has something to do with the server binary. I'm sorry I'm not of more use.
enhancement,topic:core,topic:porting,confirmed
medium
Major
499,708,106
youtube-dl
borderreport.com
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.09.28. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2019.09.28** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single video: https://www.borderreport.com/top-stories/border-ranchers-say-barbed-wire-fence-helps-separate-their-property-from-mexico-but-at-a-cost/ - Single video: https://www.borderreport.com/border-report-tour/nogales-residents-empathize-with-migrants-but-favor-legal-entry/ - Playlist: https://www.borderreport.com/hot-topics/the-border-wall/ ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> Website contains news videos covering present day American-Mexican border issues. youtube-dl reports "ERROR: Unsupported URL"
site-support-request
low
Critical
499,742,358
pytorch
Missing bin and include when building with torchvision on CentOS
## Bug When I build wheel for pytorch+torchvision on CentOS 7, I got 2 errors: 1. Cannot find `#include <torch/all.h>`. 2. Cannot find `/usr/local/lib64/python3.6/site-packages/torch/bin/torch_shm_manager`. Based on the command line args printed out in the pip message, it's has `-I/usr/local/lib64/python3.6/site-packages/torch/include`. However the entire dir `.../torch/include/torch` is missing, and I only found a `.../torch/include/pybind` there. Similarly the `.../torch/bin` is also missing. The temporarily workaround for me is to copy over `/usr/local/include/torch` and `/usr/local/bin/torch_shm_manager` which were created by a standalone cmake installation. I also tried the same setup on Ubuntu 18.04. Both `include` and `bin` are created correctly there. These error seem to be a join issue between both pytorch&vision repos so I simply post it here. ## Environment - PyTorch Version (e.g., 1.0): master - OS (e.g., Linux): CentOS 7.7 / Ubuntu 18.04 - How you installed PyTorch (`conda`, `pip`, source): source - Build command you used (if compiling from source): cmake+ninja => pip install from local git. - Python version: 3.6 cc @yf225
module: build,module: cpp,triaged,module: vision
low
Critical
499,779,130
TypeScript
Intersection type with discriminated union type that includes all possible enum values cannot accept enum type
In TypeScript you can create a union type discriminated by an `enum`. If the union includes all possible `enum` values, you can create it with a value that is typed to the `enum` (not one of its values). Given my example below, this is valid: `const p: Payload = { type, value }` When you create a new type by intersecting the discriminated union type with another type definition, for example to add another field, this no longer works. It is now no longer possible to assign a value that is typed to the `enum` to the new type. So this is invalid: `const p: { id: string } & Payload = { id, type, value }` The workaround I can think of is the following, but it's pretty tedious: ```typescript type Identify<P> = P extends { type: infer T; value: infer V } ? { id: string; type: T; value: V } : never; type IdentifiedPayload = Identify<Payload>; ``` **TypeScript Version:** 3.6.3 **Search Terms:** intersection discriminated union enum **Code** ```ts enum Type { Join = "join", Leave = "leave", Message = "message", Welcome = "welcome" } type Payload = | { type: Type.Join; value: { nickname: string } } | { type: Type.Leave; value: {} } | { type: Type.Message; value: { message: string } } | { type: Type.Welcome; value: { others: { id: string; nickname: string }[] }; }; type IdentifiedPayload = { id: string } & Payload; function parse(data: string): IdentifiedPayload { const [id, type, json] = data.split(" ", 3); if (typeof json !== "string") throw Error("received invalid data"); if (!isType(type)) throw Error("invalid type " + type); const value = JSON.parse(json); // This line errors: return { id, type, value }; // Note that TypeScript considers this valid: // const p: Payload = { type, value }; } function isType(type: string): type is Type { return Object.values(Type).includes(type); } ``` **Expected behavior:** Works **Actual behavior:** `Type '{ id: string; type: Type; value: any; }' is not assignable to type 'IdentifiedPayload'.` **Playground Link:** https://www.typescriptlang.org/play/index.html#code/KYOwrgtgBAKgngB2FA3gKClAUgewJYhQC8UARAFb4ikA0GUAMsAIYBuyJpANi+7fQFlgAZ2HMA5hzIQRYyf0wB1YFwDGOGcTIB3Fepmk0AXzRoALomQAFZnC45mAE2L0APqigWkALliWAdLgEANxQrMxcYMC+KFAgeKoA1iDMMr7CZgBOBOJQRnluHl7Rfkj+TGzAoeGRJSj5JpjuscW+8GVCohJVYRFRMVAyXZLpWTl5BU2o9JiYraXA-spqGlUzszX9HjhmABbAmcIDeI6j2SDiofFJKWlQGee5RgDaALp5wetGn+aWUACSjlAZjwADM8MBHDY7A5nCRYiczuN8gAyKDQ+xOH6gsAgVQgnCEBDMQ7AAAUjmYZmYSIuAEpfIDgWCIVDbJjnOhMOoQBkoM8TjRPJYheRhIT3iRKdT-MIEFw8GYyaQyEKAMx0z6YMFQMnFHCgqBiwlQACERE4DxypDpnl2mRw2igAFFMg7MsrMsBVMA8OxnAQaicoNLmDatVAdWTTXhhO1ycU6ba9g6na73crAxFg8UyFAANTCpCa+g8vmbKRYADKAHkAHL+YmksnGkAlzBesxgTKEBGOIXFIUVj7GUw4vEEwix+N6yy08QMovIWMLaYd4BdntQGsAI3I3rM-grwjJ8bp-gIqkiQJPic+JiAA **Related Issues:** <!-- Did you find other bugs that looked similar? -->
Bug,Help Wanted
low
Critical
499,782,015
terminal
Wrong colors using emacs-nox in WT-Ubuntu
By default I use MSYS2 MinTTY and by means of `wslbridge` I use also this MinTTY for WSL Ubuntu. With both these apps I use a color scheme which I added to the `profile.json`: ``` { "name" : "base16-default-mod-lighten", "foreground" : "#D0D0D0", "background" : "#151515", "black" : "#151515", "red" : "#AC4142", "green" : "#90A959", "yellow" : "#F4BF75", "blue" : "#6A9FB5", "purple" : "#AA759F", "cyan" : "#75B5AA", "white" : "#D0D0D0", "brightBlack" : "#505050", "brightRed" : "#C25E5E", "brightGreen" : "#A6BB7B", "brightYellow" : "#F8D5A5", "brightBlue" : "#8CB5C6", "brightPurple" : "#BE95B5", "brightCyan" : "#97C7BE", "brightWhite" : "#F5F5F5" } ``` In the same `profile.json` I added the profiles for MSYS2 bash. I use the same above color scheme for MSYS2 bash and Ubuntu in WT. In this attachment [emacs-nox-sshots.tar.gz](https://github.com/microsoft/terminal/files/3665611/emacs-nox-sshots.tar.gz) there are a few screenshots of emacs-nox running on various systems. As you can see I have the same good result in MinTTY (emacs-nox-mintty.png), Ubuntu in MinTTY (emacs-nox-mintty-Ubuntu.png) and in MSYS2 bash in WT (emacs-nox-WT-msys2.png). Instead in WT Ubuntu I get what I call _bad_ result (emacs-nox-WT-Ubuntu.png).
Area-VT,Issue-Bug,Needs-Attention,Product-Terminal
medium
Major
499,800,496
PowerToys
Add option to remove windows task-bar
# Summary of the new feature/enhancement I believe windows 10 does not have a way to completely remove the task-bar or only make it show when you explicitly ask it to. * Hovering your mouse over it should not open the task-bar anymore * Removing the small line that is drawn when the task-bar is closed would also be nice # Proposed technical implementation details (optional) Add an option that would remove the task-bar, clicking the start button should open the task bar with the start menu open. A separate key-bind that only opens the task-bar might be useful.
Idea-New PowerToy,Product-Tweak UI Design
low
Minor
499,816,255
flutter
Gradle failure on Windows with & in project path
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Steps to Reproduce <!-- Please tell us exactly how to reproduce the problem you are running into. --> When i Run app i get this error ProcessException: ProcessException: Process "E:\Flutter&Dart\projects\start_app\android\gradlew.bat" exited abnormally: 'E:\Flutter' is not recognized as an internal or external command, operable program or batch file. I tried to update my gradle or download it offline and still i have same problem. ## Logs <!-- Include the full logs of the commands you are running between the lines with the backticks below. If you are running any "flutter" commands, please include the output of running them with "--verbose"; for example, the output of running "flutter --verbose create foo". --> Flutter crash report; please file at https://github.com/flutter/flutter/issues. ## command flutter run ## exception ``` ProcessException: ProcessException: Process "E:\Flutter&Dart\projects\start_app\android\gradlew.bat" exited abnormally: 'E:\Flutter' is not recognized as an internal or external command, operable program or batch file. The system cannot find the path specified. Command: E:\Flutter&Dart\projects\start_app\android\gradlew.bat -v #0 runCheckedAsync (package:flutter_tools/src/base/process.dart:259:7) <asynchronous suspension> #1 _initializeGradle (package:flutter_tools/src/android/gradle.dart:300:9) <asynchronous suspension> #2 _ensureGradle (package:flutter_tools/src/android/gradle.dart:281:37) <asynchronous suspension> #3 _readGradleProject (package:flutter_tools/src/android/gradle.dart:192:31) <asynchronous suspension> #4 _gradleAppProject (package:flutter_tools/src/android/gradle.dart:112:37) <asynchronous suspension> #5 getGradleAppOut (package:flutter_tools/src/android/gradle.dart:106:29) <asynchronous suspension> #6 AndroidApk.fromAndroidProject (package:flutter_tools/src/application_package.dart:164:23) <asynchronous suspension> #7 ApplicationPackageFactory.getPackageForPlatform (package:flutter_tools/src/application_package.dart:46:32) <asynchronous suspension> #8 FlutterDevice.runHot (package:flutter_tools/src/resident_runner.dart:359:56) <asynchronous suspension> #9 HotRunner.run (package:flutter_tools/src/run_hot.dart:254:39) <asynchronous suspension> #10 RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:472:37) <asynchronous suspension> #11 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:490:18) #12 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #13 _rootRunUnary (dart:async/zone.dart:1132:38) #14 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #15 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #16 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #17 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #18 Future._completeWithValue (dart:async/future_impl.dart:522:5) #19 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15) #20 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13) #21 RunCommand.usageValues (package:flutter_tools/src/commands/run.dart) #22 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #23 _rootRunUnary (dart:async/zone.dart:1132:38) #24 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #25 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #26 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #27 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #28 Future._completeWithValue (dart:async/future_impl.dart:522:5) #29 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15) #30 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13) #31 AndroidDevice.isLocalEmulator (package:flutter_tools/src/android/android_device.dart) #32 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #33 _rootRunUnary (dart:async/zone.dart:1132:38) #34 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #35 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #36 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #37 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #38 Future._completeWithValue (dart:async/future_impl.dart:522:5) #39 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:552:7) #40 _rootRun (dart:async/zone.dart:1124:13) #41 _CustomZone.run (dart:async/zone.dart:1021:19) #42 _CustomZone.runGuarded (dart:async/zone.dart:923:7) #43 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23) #44 _microtaskLoop (dart:async/schedule_microtask.dart:41:21) #45 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) #46 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:116:13) #47 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:173:5) ``` ## flutter doctor ``` [✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Microsoft Windows [Version 10.0.17763.737], locale en-US) • Flutter version 1.9.1+hotfix.2 at C:\src\flutter • Framework revision 2d2a1ffec9 (3 weeks ago), 2019-09-06 18:39:49 -0700 • Engine revision b863200c37 • Dart version 2.5.0 [✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2) • Android SDK at G:\Android\sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-29, build-tools 29.0.2 • ANDROID_HOME = G:\Android\sdk • Java binary at: G:\Android\Android Studio\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) • All Android licenses accepted. [✓] Android Studio (version 3.5) • Android Studio at G:\Android\Android Studio • Flutter plugin version 39.0.3 • Dart plugin version 191.8423 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) [✓] VS Code (version 1.38.1) • VS Code at C:\Users\Magician\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.4.1 [✓] Connected device (1 available) • CPH1901 • 4b2650d4 • android-arm64 • Android 8.1.0 (API 27) • No issues found! ``` <!-- If possible, paste the output of running `flutter doctor -v` here. --> E:\Flutter&Dart\projects\start_app>flutter doctor -v [√] Flutter (Channel stable, v1.9.1+hotfix.2, on Microsoft Windows [Version 10.0.17763.737], locale en-US) • Flutter version 1.9.1+hotfix.2 at C:\src\flutter • Framework revision 2d2a1ffec9 (3 weeks ago), 2019-09-06 18:39:49 -0700 • Engine revision b863200c37 • Dart version 2.5.0 [√] Android toolchain - develop for Android devices (Android SDK version 29.0.2) • Android SDK at G:\Android\sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-29, build-tools 29.0.2 • ANDROID_HOME = G:\Android\sdk • Java binary at: G:\Android\Android Studio\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) • All Android licenses accepted. [√] Android Studio (version 3.5) • Android Studio at G:\Android\Android Studio • Flutter plugin version 39.0.3 • Dart plugin version 191.8423 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) [√] VS Code (version 1.38.1) • VS Code at C:\Users\Magician\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.4.1 [√] Connected device (1 available) • CPH1901 • 4b2650d4 • android-arm64 • Android 8.1.0 (API 27) • No issues found!
c: crash,tool,platform-windows,t: gradle,P2,team-tool,triaged-tool
low
Critical
499,824,983
pytorch
Cmake warnings during build
I'm receiving a lot of warnings like this. Is it okay? (I do have cuda installed and discoverable fine) ``` CMake Warning at modules/module_test/CMakeLists.txt:10 (add_library): Cannot generate a safe runtime search path for target caffe2_module_test_dynamic because there is a cycle in the constraint graph: dir 0 is [/miniconda/lib] dir 2 must precede it due to runtime library [libcudart.so.10.0] dir 1 is [/deepspeech.pytorch/pytorch/build/lib] dir 2 is [/usr/local/cuda/lib64] dir 0 must precede it due to runtime library [libnvToolsExt.so.1] Some of these libraries may not be found correctly. ```
triaged,module: build warnings
low
Minor
499,828,614
angular
Support finishCallback and rootZoneStable in async test
<!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅 Oh hi there! 😄 To expedite issue processing please search open and closed issues before submitting a new one. Existing issues often contain information about workarounds, resolution, or progress updates. 🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅--> # 🚀 feature request ### Relevant Package <!-- Can you pin-point one or more @angular/* packages the are relevant for this feature request? --> <!-- ✍️edit: --> This feature request is for zone.js ### Description <!-- ✍️--> A clear and concise description of the problem or missing capability... the cases is from `angular components`, the following test are from @mmalerba. ``` fdescribe('repro', () => { beforeEach(async () => { await TestBed.configureTestingModule({ declarations: [OutsideNgZoneTest] }).compileComponents(); }); # Passes it('done should not wait for task outside of zone', done => { const fixture = TestBed.createComponent(OutsideNgZoneTest); const el = fixture.debugElement.nativeElement; fixture.detectChanges(); fixture.whenStable().then(() => { expect(el.classList.contains('timeout-done')).toBe(false); done(); }); }); # Passes it('fakeAsync should wait for task outside of zone', fakeAsync(() => { const fixture = TestBed.createComponent(OutsideNgZoneTest); const el = fixture.debugElement.nativeElement; fixture.detectChanges(); flush(); expect(el.classList.contains('timeout-done')).toBe(true); })); # Fails it('async should wait for task outside of zone', async(() => { const fixture = TestBed.createComponent(OutsideNgZoneTest); const el = fixture.debugElement.nativeElement; fixture.detectChanges(); fixture.whenStable().then(() => { expect(el.classList.contains('timeout-done')).toBe(true); }); })); }); @Component({template: ''}) export class OutsideNgZoneTest { constructor(el: ElementRef, ngZone: NgZone) { ngZone.runOutsideAngular(() => setTimeout(() => el.nativeElement.classList.add('timeout-done'))); } } ``` For the `1st and 3rd` cases, we want some mechanism to let user to easily test the async cases. ### Describe the solution you'd like <!-- ✍️--> If you have a solution in mind, please describe it. - For the `1st case` we may need some thing like `rootZoneWhenStable().then()` or `asyncStable().then()` to monitor not only `ngZone` but also the `async tasks` outside of `ngZone`. - For the `3rd case`, we need to add an option to `async` zone spec, to let user monitor when all async are done. ### Describe alternatives you've considered <!-- ✍️--> Have you considered any alternative solutions or workarounds? No very easy workarounds for now.
feature,area: zones,feature: insufficient votes,feature: votes required
low
Critical
499,832,749
neovim
hook/event for normal, Ex commands
### Steps to reproduce using `nvim -u NORC` Any `formatprg` or `equalprg` with an argument that gives an error in shellcode. Ex. use prettier in a one-line javascript object parameter. ### Actual behaviour `formatprg` and `equalprg` replace stdin with stderr on shell error ### Expected behaviour Some sort of error handling like doing nothins, dumping stderr in a quickfix, or even better stderr in a floating window. ### Reference https://github.com/prettier/prettier/issues/743 https://stackoverflow.com/questions/13658696/vim-how-to-redirect-formatprg-errors-to-echoerr https://stackoverflow.com/questions/9466795/vim-using-an-external-command-and-handling-errors https://groups.google.com/forum/#!topic/vim_dev/SGcwy7GViNs
enhancement,core,events
low
Critical
499,844,944
pytorch
Is it an incompleted dst tensor synchronization in CUDA device to device copy ?
## 🐛 Bug When we perform a CUDA copy from device to device, I find PyTorch only block current stream on dst device before copy execution. Why don't we wait for all streams on dst device to ensure no one touches the dst tensor? The dst tensor might be written or read on other streams not current stream on dst device, when copy execution? ## To Reproduce Here is a pseudo in my mind. `auto src_device = src_tensor.device();` `auto dst_device = dst_tensor.device();` `// initialize two streams for dst_device` `// stm1: the current stream when performing the copy.` `// stm2: perform a workload which touches dst_tensor's memory.` `CUDAGuard device_guard(dst_device); {` ` at::cuda::CUDAStream s0 = at::cuda::getStreamFromPool();` ` at::cuda::CUDAStream s1 = at::cuda::getStreamFromPool();` ` setCurrentCUDAStream(s1);` ` // submit a asynchronized kernel on s1 and the kernel will touch dst_tensor.` ` workload_on_s1(dst_tensor.device(), s1);` ` // current stream on dst_device is s0.` ` setCurrentCUDAStream(s0);` ` // perform copy` ` // 1. record event of dst_device current stream, s0 in the case.` ` CUDAEvent dst_ready;` ` device_guard.set_device(dst_device);` ` dst_ready.record(getCurrentCUDAStream(dst_device.index()));` ` // *******` ` // s0 is completed, but s1 might be still WIP on dst_device.` ` // *******` ` // 2. current stream of src_device block for the event.` ` device_guard.set_device(src_device);` ` dst_ready.block(getCurrentCUDAStream(src_device.index()));` ` // 3. copy ...` ` // 4. block src_stream/copy_stream to complete copy` `}` The exception could be implemented by Python user interface either. Thanks.
module: cuda,triaged
low
Critical
499,853,268
terminal
Eventually register a terminfo with ncurses upstream
Thomas Dickey, the maintainer of the ncurses project, also maintains the terminfo-db distributed with most Linux distributions. At the moment, the main TERM environment variable is `xterm-256color`, but not all xterm features are supported or even planned. When 1.0 releases, it would be good to leave xterm-256color as the default TERM environment, but also to maintain a separate terminfo with the ncurses project upstream. This means that as the changes in ncurses propagate down to the distros, the team can make a switchover and report the TERM as `ms-terminal`. This will give the team the freedom in the long-term to add new features not implemented in xterm (for example, to support 32-bit color (i.e. an alpha channel)) or any other cool features they might dream up. Some projects like `libvte` and `kitty` have or previously had a bad relationship with the ncurses maintainer because they refused to submit their own accurate TERMINFO to the database.
Issue-Docs,Area-VT,Product-Meta
medium
Major
499,864,377
rust
Tracking issue for `report-time`
Tracks stabilization for the `report-time` and `ensure-test-time` `libtest` options.
T-libs-api,B-unstable,A-libtest,C-tracking-issue,Libs-Tracked
low
Major
499,870,378
pytorch
Tensorboard logging image WITH LABEL
## 🚀 Feature We need a function that - When log image to tensorboard, put text/label beside/over the image. - When saving image, put text/label beside/over the image. ## Motivation Now, we can use tensorboard to log images in PyTorch. However, there are just images when we logging images. It's better for visual debugging that we can know the label/prediction directly with the images. For example, just put the label over the image. In TensorFlow, there is a function `tf_put_text` to do this thing, as described [HERE](https://stackoverflow.com/questions/36015170/how-can-i-add-labels-to-tensorboard-images). Can you copy it to PyTorch? I think it is a really useful tool. ## Pitch For example: ``` |--------------------| | Class:42 | | | | The image | | | | | |--------------------| ``` AND ``` |--------------------| | | | | | The image | | | | | |--------------------| Class: 42 ``` ## Alternatives Refer: `tf_put_text` function in TensorFlow ## Additional context - https://discuss.pytorch.org/t/add-a-title-or-text-to-torch-make-grid/13501
triaged,module: tensorboard
low
Critical
499,878,989
PowerToys
Quick action buttons with on/off status
# Summary of the new feature/enhancement i regularly need to perform certain windows actions like : - change network parameters to a certain setting (when i swap from using my computer from personal to professional use for example) - turn on/off the power save detection (when i launch a long task and i dont what it to be interrupted) - change multi screen parameter (from clone to extension for exemple) And that is only a sample of the actions... For each of theses actions, i need to go through a serie of windows configuration menus every time... back and forth... I'd really like to have shortcuts to configuration actions. in the form of simple buttons with a simple on/off status accessed in one click (or double click) from a shortcut on the desktop of from the taskbar. Thanks! # Proposed technical implementation details (optional) <!-- A clear and concise description of what you want to happen. -->
Idea-New PowerToy
low
Minor
499,899,118
terminal
Profiles Schema: Invalid command chords validate
First of all, I'm very happy to see that parts of the schema that I suggested in #1003 made it into a release, but in the review process I think that an important feature of the (allegedly, very long) regular expression to validate the `keys` strings was lost: It will now incorrectly validates key chords that won't parse properly. This is because the strings recognized in [KeyChordSerialization.cpp](https://github.com/microsoft/terminal/blob/master/src/cascadia/TerminalApp/KeyChordSerialization.cpp) are not spelled out explicitly. May I suggest that the expression is changed to (the `<key>` group is new, and the last `+` in `<modifier>` is required): ```regexp ^(?<modifier>(ctrl|alt|shift)(?:\+(ctrl|alt|shift)(?<!\2))?(?:\+(ctrl|alt|shift)(?<!\2|\3))?\+)?(?<key>[^\s+]|backspace|tab|enter|esc|space|pgup|pgdn|end|home|left|up|right|down|insert|delete|numpad_(?:[0-9]|multiply|plus|minus|period|divide)|f[1-9]|f1[0-9]|f2[0-4]|plus)$ ``` Note that the problem with my original expression is fixed - it now allows single ` |}` etc. keys, as it should. However, it will *not* validate `ctrl++` or `ctrlplus`, which should be `ctrl+plus` instead. Also, modifiers without keys will not validate (e.g. `ctrl`). Another improvement would be to list out the allowed words in the description, of course. This is a tricky value to get right without documentation as a crutch, but at least proper validation can help you catch errors early. Maybe @oising, who improved on the original regexp, would like to comment? Edit: [Link to example at Regex101](https://regex101.com/r/6FEcX6/1)
Help Wanted,Issue-Docs,Area-Settings,Product-Terminal
low
Critical
499,907,302
flutter
[WEB] Need more PageTransitionTheme for web transition
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Use case <!-- Please tell us the problem you are running into that led to you wanting a new feature. Is your feature request related to a problem? Please give a clear and concise description of what the problem is. Describe alternative solutions you've considered. Is there a package on pub.dev/flutter that already solves this? --> ## Proposal <!-- Briefly but precisely describe what you would like Flutter to be able to do. Consider attaching images showing what you are imagining. Does this have to be provided by Flutter directly, or can it be provided by a package on pub.dev/flutter? If so, maybe consider implementing and publishing such a package rather than filing a bug. --> pageTransitionsTheme: PageTransitionsTheme(builders: { TargetPlatform.iOS: CupertinoPageTransitionsBuilder(), TargetPlatform.android: OpenUpwardsPageTransitionsBuilder(), }), Web transition doesn't need those of -FadeUpwardsPageTransitionsBuilder -OpenUpwardsPageTransitionsBuilder -CupertinoPageTransitionsBuilder I think TranisitionBuilder for web should be supported, such as NoAnimationTransitionBuilder..
c: new feature,framework,c: proposal,P3,team-framework,triaged-framework
low
Critical
499,915,683
pytorch
RuntimeError:[enforce fail at context.h:48] option.device_type() ==PROTO_CPU. 1vs0
Traceback (most recent call last): File "/usr/VMZ-master-1/tools/train_net.py", line 586, in main() File "/usr/VMZ-master-1/tools/train_net.py", line 581, in main Train(args) File "/usr/VMZ-master-1/tools/train_net.py", line 404, in Train workspace.CreateNet(test_model.net) File "/root/pytorch/build/caffe2/python/workspace.py", line 181, in CreateNet StringifyProto(net), overwrite, File "/root/pytorch/build/caffe2/python/workspace.py", line 215, in CallWithExceptionIntercept return func(args, kwargs) RuntimeError: [enforce fail at context.h:48] option.device_type() == PROTO_CPU. 1 vs 0 frame #0: c10::ThrowEnforceNotMet(char const, int, char const, std::__cxx11::basic_string<char, std::char_traits, std::allocator > const&, void const) + 0x78 (0x7fed19c32178 in /usr/local/lib/libc10.so) frame #1: + 0x2686d70 (0x7fecdcf03d70 in /usr/local/lib/libtorch.so) frame #2: + 0x2723fec (0x7fecdcfa0fec in /usr/local/lib/libtorch.so) frame #3: + 0x3aff5ee (0x7fecde37c5ee in /usr/local/lib/libtorch.so) frame #4: std::_Function_handler<std::unique_ptr<caffe2::OperatorBase, std::default_deletecaffe2::OperatorBase > (caffe2::OperatorDef const&, caffe2::Workspace*), std::unique_ptr<caffe2::OperatorBase, std::default_deletecaffe2::OperatorBase > ()(caffe2::OperatorDef const&, caffe2::Workspace)>::_M_invoke(std::_Any_data const&, caffe2::OperatorDef const&, caffe2::Workspace*&&) + 0x23 (0x7fed1a4b5433 in /root/pytorch/build/caffe2/python/caffe2_pybind11_state_gpu.so) frame #5: + 0x236c25c (0x7fecdcbe925c in /usr/local/lib/libtorch.so) frame #6: caffe2::CreateOperator(caffe2::OperatorDef const&, caffe2::Workspace*, int) + 0x328 (0x7fecdcbea528 in /usr/local/lib/libtorch.so) frame #7: caffe2::dag_utils::prepareOperatorNodes(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*) + 0x2ad (0x7fecdcbda06d in /usr/local/lib/libtorch.so) frame #8: caffe2::AsyncNetBase::AsyncNetBase(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*) + 0x24d (0x7fecdcbb670d in /usr/local/lib/libtorch.so) frame #9: caffe2::AsyncSchedulingNet::AsyncSchedulingNet(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*) + 0x9 (0x7fecdcbbb5b9 in /usr/local/lib/libtorch.so) frame #10: + 0x23410ae (0x7fecdcbbe0ae in /usr/local/lib/libtorch.so) frame #11: std::_Function_handler<std::unique_ptr<caffe2::NetBase, std::default_deletecaffe2::NetBase > (std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*), std::unique_ptr<caffe2::NetBase, std::default_deletecaffe2::NetBase > ()(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace)>::_M_invoke(std::_Any_data const&, std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*&&) + 0x23 (0x7fecdcbbdf83 in /usr/local/lib/libtorch.so) frame #12: caffe2::CreateNet(std::shared_ptr<caffe2::NetDef const> const&, caffe2::Workspace*) + 0x4a5 (0x7fecdcbb0495 in /usr/local/lib/libtorch.so) frame #13: caffe2::Workspace::CreateNet(std::shared_ptr<caffe2::NetDef const> const&, bool) + 0x103 (0x7fecdcc2fe23 in /usr/local/lib/libtorch.so) frame #14: caffe2::Workspace::CreateNet(caffe2::NetDef const&, bool) + 0x91 (0x7fecdcc30d61 in /usr/local/lib/libtorch.so) frame #15: + 0x57906 (0x7fed1a4ad906 in /root/pytorch/build/caffe2/python/caffe2_pybind11_state_gpu.so) frame #16: + 0x57bd2 (0x7fed1a4adbd2 in /root/pytorch/build/caffe2/python/caffe2_pybind11_state_gpu.so) frame #17: + 0x99e3d (0x7fed1a4efe3d in /root/pytorch/build/caffe2/python/caffe2_pybind11_state_gpu.so) frame #33: __libc_start_main + 0xe7 (0x7fed1e897b97 in /lib/x86_64-linux-gnu/libc.so.6)
caffe2,triaged
low
Critical
499,923,885
TypeScript
From debian : please support multiple system dir
Under debian and other distrib we want to load systemdir from a search path. for instance we want first to look up from lib/x86_64-linux-gnu/nodejs then share/nodejs then lib/nodejs' I tried a local patch but I do not suceed. Could you help us ? [email protected]
Suggestion,Needs Proposal
low
Major
499,955,124
terminal
Feature Request: Customize confirmation prompt before exit.
Feature request: A confirmation prompt before terminal app exit. For example, if there are multiple tabs open, upon initiation of exit a prompt to confirm or cancel exit. Particularly with the case when multiple tabs open, prompting the user to think before closing multiple tabs may prevent a accidental loss of work/processing in tabs that are not in the foreground. Perhaps make the prompt configurable in settings with the options: - disabled (no prompt before exit) - multiple (prompt if multiple tabs open) - always (prompt always before exit - for a check before closing even a single open tab) * [ ] #6641 add a "remember" checkbox
Help Wanted,Area-UserInterface,Product-Terminal,Issue-Task
medium
Critical
499,964,728
vscode
Better Touch using
Issue Type: <b>Feature Request</b> Hello, I realised it is not easy to select text on a touch screen. This is, because all touch gestures are interpreted as scrolling and not as selecting. I looked what Notepad++ does. This is very interesting. Notepad++ works differently depending on what direction the touch swiping starts. If it starts vertically (up/down) then ist is scrolling and if it starte horizontally (left/right) it is selecting. - It should be noted, that even if you start moving the finger up or down for scrolling, if the scrolling has started you still can scroll left or right. If you are in selection mode (left/right movement) you can also select up and down. So the application looks how the movement started. This is a really cool and accassible way of using touch in this program. Visual Studio code should work in a similar way. (PS: This whole way of using with touch reminds me of the clever way Tiles worked Windows 8. Unfortunately Microsoft forgot about that, when they switched scrolling direction of Tiles in Windows 10.) VS Code version: Code 1.38.1 (b37e54c98e1a74ba89e03073e5a3761284e3ffb0, 2019-09-11T13:35:15.005Z) OS version: Windows_NT x64 10.0.18362 <!-- generated by issue reporter -->
feature-request,editor-core
low
Minor
499,977,303
go
proposal: doc: document api compatibility
### Background Currently there are four official definitions for api compatibility<sup>[0](https://golang.org/doc/go1compat)[1](https://blog.golang.org/publishing-go-modules#TOC_3.)[2](https://go.googlesource.com/exp/+/master/apidiff/README.md)[3](https://golang.org/ref/spec)</sup>, as well as others offered by the community<sup>[4](https://github.com/bradleyfalzon/apicompat)</sup>. It should be noted that some of these definitions target package compatibility, where other target module compatibility, and some are experimental, while others have been constant since go1. Unfortunately, they each disagree on at least a few minor points in their definitions of compatibility. This lack of an official stance and single vision for compatibility has led to confusion and uncertainty among the community. ### Proposal In some official capacity, publish documentation both package and module compatibility guarantees. This should involve a package level definition, such as the `apidiff` definition<sup>[2](https://go.googlesource.com/exp/+/master/apidiff/README.md)</sup>, and module definition, which can borrow heavily from the former. ### Footnotes 0] https://golang.org/doc/go1compat 1] https://blog.golang.org/publishing-go-modules#TOC_3. 2] https://go.googlesource.com/exp/+/master/apidiff/README.md 3] https://golang.org/ref/spec 4] https://github.com/bradleyfalzon/apicompat
Documentation,Proposal
low
Minor
500,001,558
terminal
Cannot override Cascadia Code
# Environment Win32NT 10.0.18362.0 Windows Terminal version: 0.5.2681.0 # Steps to reproduce Download the latest install of Windows Terminal from the Microsoft Store. Install a new version of Cascadia Code (attached) via the font menu. Open Windows Terminal. Set Font Family in Preferences to “Cascadia Code”. Observe that glyphs present in the older version appear (it appears that the newer font is used as a fallback for the previously-missing glyphs). # Expected behavior Windows Terminal should use a normal process to install Cascadia Code so that it can be uninstalled or replaced as new versions of Cascadia Code are released. # Actual behavior <img width="581" alt="WindowsTerminal" src="https://user-images.githubusercontent.com/8460297/65842898-8a76b600-e2e3-11e9-9142-92263f48e853.png"> Note here that the older version of the font is being used for glyphs present in the older version, but the newer font is being used for glyphs only present in the newer version. Windows Terminal appears to have a ‘back-end’ way of installing the font file that is inaccessible and cannot be overriden even when installing through the Font Menu, or a Font manager (such as FEX). In VS Code, the newer version of the font is ignore entirely in favor of the older version installed by Windows Terminal. [CascadiaCode.ttf.zip](https://github.com/microsoft/terminal/files/3668355/CascadiaCode.ttf.zip)
Area-Fonts,Issue-Bug,Product-Terminal
low
Major
500,036,782
pytorch
The Gather problem in DataParallel: dimension are not matched.
## 🚀 Feature Enabling User to control which inputs should be scattered to different GPUs. ## Motivation torch.nn.DataParrallel is a very useful tool for multi-GPU application with pytorch. However, during my application, a strange bug is that my model works well with single GPU but fails in multi-GPUs by: **RuntimeError: Gather got an input of invalid size: got [24, 10, 448,448], but expected [24, 11, 448,448] (gather at /pytorch/torch/csrc/cuda/comm.cpp:239** My input size is [48,3,448,448], and two GPUs are used. Thus, it is ok to split 24 images into each gpu, but it is strange why exists 10 and 11 channels? After debug, the problem is found out: ![image](https://user-images.githubusercontent.com/37262007/65848474-d293e800-e378-11e9-94a6-6d19a924a09f.png) The self.embed_arr is an input semantic labels, whose size is [21,300]. self.embed_arr will affect the image feature channels. Under single GPU setting, each image will meet a same self.embed_arr, thereby having the same image channels. However, under multi-GPUs settings, self.embed_arr will be split into multi-parts, e.g., [10,30] and [11,30], thereby leading to different image channels and a bug during feature gathering. ( If self.embed_arr has a size of [20,300], this problem will not appear, and I may think that the bad performance is attributed to my algorithm, which is terrible!) ## Solution An alternative solution is to duplicate the input so that the scattered inputs in each GPU is the same: ![image](https://user-images.githubusercontent.com/37262007/65848944-e04a6d00-e37a-11e9-86ed-13ff8d081891.png) ## Suggest So, I suggest pytorch to add a function that can ontrol which inputs should be scattered to different GPUs.
triaged,module: data parallel
low
Critical
500,046,178
TypeScript
Conditional types fail to distribute in properties of mapped types
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.7.0-dev.20190928 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** conditional mapped property union **Code** ```ts type NullifyStrings<T> = T extends string ? null : T type NullifyStringsInPropsWorking<T> = { [K in keyof T]: NullifyStrings<T[K]> } type NullifyStringsInPropsBroken<T> = { [K in keyof T]: T[K] extends string ? null : T[K] } type TestType = { a: number | string } // { a: number | null } type WorkingReplaceProps = NullifyStringsInPropsWorking<TestType> // { a: string | number } type BrokenReplaceProps = NullifyStringsInPropsBroken<TestType> ``` **Expected behavior:** `NullifyStringsInPropsWorking` and `NullifyStringsInPropsBroken` should be functionally identical - expanding the `NullifyStrings` type alias in `NullifyStringsInPropsWorking` results in the same definition as `NullifyStringsInPropsBroken`. **Actual behavior:** `NullifyStringsInPropsWorking` and `NullifyStringsInPropsBroken` have different behaviour - `BrokenReplaceProps` has type `{ a: string | number }` instead of the expected `{ a: number | null }`. **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> [Link](https://www.typescriptlang.org/play/?ts=Nightly#code/C4TwDgpgBAcgrgGwQSwGYgMrAE7IHYDmAzgDwAqAfFALxRlQQAewEeAJkVETvgVAPxQ8iBFABcdALAAoUJFgi0mHoSIBJPAAVsAezBEA6juwBrXuSq0A3lADaAaSj4oJiCB2o6AXQnwkSrFxVcgcvKgBfGTloPxR0QN51LV19ACFdVzwLGigbByc8FzcPbwkyUIZmVg4uFT5BYSRxOgrI6SjwaDIIbjJOnJsAQwlhAFsAIwhsKAAfWqC+NoB6JdyoYaE4CanZzaa26KgjU14AJQgwBEGAYwhtPU5aWIC6pPv9Y7NCch7gPsgKDIVmsNtwFrsxpNpgd+ukdJlzpcbncUo8FP54q8NO8iHDMj9ep0KEA) **Related Issues:** <!-- Did you find other bugs that looked similar? --> #28339, but seems to be different. #22945 mentions > Since type aliases are equivalent to writing the expansion inline [...] but that is not the case here.
Docs
low
Critical
500,055,803
PowerToys
[FZ Editor] allow manual coordinates (absolute and relative)
# Summary of the new feature/enhancement Sizing of custom zones in editor by dragging mouse is a little bit coarse (hit and miss) in terms of getting close to edges of screen symmetrically and allowing window edges of multiple zones to line up neatly. Some possible solutions are suggested for consideration. # Proposed technical implementation details (optional) 1. Perhaps have an option for the editor to snap to a grid of user specified n pixels. 2. Perhaps have optional ability to input window dimension and position directly in both absolute terms (n x n pixels) and in terms of percentage of screen width and height.
Idea-Enhancement,FancyZones-Editor,FancyZones-Layouts,Product-FancyZones,Priority-3
high
Critical
500,110,583
rust
Less codegen parallelism than expected with `-C codegen-units=16`
This is the output of `cargo build -Z timings` for Servo, on a 14 cores / 28 threads machine, filtered with "Min unit time" at 10 seconds. **Edit:** with Rust `nightly-2019-09-28` ![a4fd0099519ccbda2e31718d46f1ff0e546886d6](https://user-images.githubusercontent.com/291359/65858292-dcf8b680-e365-11e9-8689-80c52a34fbcc.png) For most of codegen for the `script` crate only 3 to 4 threads seem to be CPU-bound, leaving other cores idle, despite [`codegen-units=16` being the default](https://github.com/rust-lang/rust/blob/134004f74db3b4626bde37cc068d9ae6dedd2d38/src/librustc/session/mod.rs#L971). (Results are similar if I specify it explicitly.) Shouldn’t CPU usage be much closer to `min(ncpu, codegen-units)`?
A-codegen,I-compiletime,T-compiler
medium
Major
500,122,143
pytorch
torch::NoGradGuard no_grad get wrong when I use batchsize!=1
## ❓ Questions and Help ### Please note that this issue tracker is not a help form and this issue will be closed. We have a set of [listed resources available on the website](https://pytorch.org/resources). Our primary means of support is our discussion forum: - [Discussion Forum](https://discuss.pytorch.org/) I used jit to convert the model,and then I use C++ to predict. But I found that when I use torch::NoGradGuard no_grad; batch_size!=1. will get wrong like this: ![image](https://user-images.githubusercontent.com/29307135/65860800-945cef80-e39d-11e9-8f47-dc1acff81599.png) cc @yf225
module: cpp,triaged
low
Minor
500,163,549
go
runtime: read scheduled on a different thread than a locked and associated with network namespace
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? Tested on 3 versions: <pre> $ go version go version go1.11.13 linux/amd64 </pre> <pre> $ go version go version go1.12.9 linux/amd64 </pre> <pre> $ go version go version go1.13 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Not tested with 1.13.1 ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/root/.cache/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/root/go" GOPROXY="" GORACE="" GOROOT="/root/golang/1.12.9" GOTMPDIR="" GOTOOLDIR="/root/golang/1.12.9/pkg/tool/linux_amd64" GCCGO="gccgo" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/mnt/git/github/netns-go-proof/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build717114236=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? While working on a tool that resolves socket IDs of processes running inside Docker container I've found that reading data from procfs when a locked thread is associated with process network namespace is not deterministic. Sometimes it was reading correct data but quite ofter it was reading data from host namespace. With following code I was able to reproduce this issue on RHEL 7.2 - 7.6: https://github.com/difrost/netns-go-proof Steps to reproduce using proof code: * Find a container with a process that opens a bunch of network connections: ````bash $ docker ps --format "{{.ID}} {{.Ports}} {{.Names}}" 96cc2a87e368 0.0.0.0:1358->1358/tcp cranky_sutherland b78274b8892f 0.0.0.0:80->80/tcp, 0.0.0.0:443->443/tcp rancher ```` * Get the processes running in b78274b8892f: ````bash $ docker top b78274b8892f -o pid,cmd PID CMD 29724 tini -- rancher --http-listen-port=80 --https-listen-port=443 --audit-log-path=/var/log/auditlog/rancher-api-audit.log --audit-level=0 --audit-log-maxage=10 --audit-log-maxbackup=10 --audit-log-maxsize=100 29763 rancher --http-listen-port=80 --https-listen-port=443 --audit-log-path=/var/log/auditlog/rancher-api-audit.log --audit-level=0 --audit-log-maxage=10 --audit-log-maxbackup=10 --audit-log-maxsize=100 ```` * Use [nsenter](http://man7.org/linux/man-pages/man1/nsenter.1.html) from util-linux package to count lines in /proc/net/tcp: ````bash $ sudo nsenter -n -t 29763 cat /proc/net/tcp |wc -l 797 ```` * Run proof code on 29763: ````bash $ sudo ./NetNSBug -pid 29763 INFO[0000] Analysing 29763 in TID: 28877 PID: 28877 INFO[0000] We are in TID: 28877 INFO[0000] Got data for 29763: INFO[0000] Got 0 lines loaded for UDP6 INFO[0000] Got 796 lines loaded for TCP INFO[0000] Got 0 lines loaded for UDP INFO[0000] Got 30 lines loaded for TCP6 INFO[0000] Namespace for 29763: net:[4026532507] INFO[0000] Namespace for tid 28877: net:[4026532507] ```` * For reference host namespace TCP: ````bash $ cat /proc/net/tcp | wc -l 5 ```` * Run proof code again but this time force execution on a thread other than main one. This is done by calling [dummy goroutine](https://github.com/difrost/netns-go-proof/blob/f34ba2ab404381d4c748d08e620eb53c0763538b/main.go#L64) and granting it a bit of juice with [runtime.Gosched](https://golang.org/pkg/runtime/#Gosched). ````bash $ sudo ./NetNSBug -pid 29763 -f INFO[0000] Analysing 29763 in TID: 29224 PID: 29224 INFO[0000] Forcing schedule on a proper thread. INFO[0000] We are in TID: 29226 INFO[0000] Got data for 29763: INFO[0000] Got 6 lines loaded for UDP6 INFO[0000] Got 4 lines loaded for TCP INFO[0000] Got 4 lines loaded for UDP INFO[0000] Got 4 lines loaded for TCP6 INFO[0000] Namespace for 29763: net:[4026532507] INFO[0000] Namespace for tid 29226: net:[4026532507] ```` ### What did you expect to see? Correct data read from procfs while associated with a network namespace. ### What did you see instead? Data from host namespace.
NeedsInvestigation,compiler/runtime
low
Critical
500,177,839
terminal
Propagate palette changes on the legacy console through ConPTY w/ OSC 4
<!-- 🚨🚨🚨🚨🚨🚨🚨🚨🚨🚨 I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING: 1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement. 2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement. 3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number). 4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement. 5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement. All good? Then proceed! --> <!-- This bug tracker is monitored by Windows Terminal development team and other technical folks. **Important: When reporting BSODs or security issues, DO NOT attach memory dumps, logs, or traces to Github issues**. Instead, send dumps/traces to [email protected], referencing this GitHub issue. If this is an application crash, please also provide a Feedback Hub submission link so we can find your diagnostic data on the backend. Use the category "Apps > Windows Terminal (Preview)" and choose "Share My Feedback" after submission to get the link. Please use this form and describe your issue, concisely but precisely, with as much detail as possible. --> # Environment ```Windows 10 latest build Windows build number: Microsoft Windows [Versione 10.0.18362.356] Windows Terminal version (if applicable): 0.5.2681.0 Any other software? FiveM CitizenFX collective GTA Modification server Build ``` # Steps to reproduce using the library Colorful.Console in a c# project the output color in console is different from the color requested and in the original CMD color is correctly interpreted # Expected behavior i expect colors to be shown correctly # Actual behavior Colors are not correctly shown ![image](https://user-images.githubusercontent.com/4005518/65869243-5ac6bd00-e37a-11e9-937c-a7c0b6b3d1b4.png) ![image](https://user-images.githubusercontent.com/4005518/65869414-b3965580-e37a-11e9-8f89-cfb0c62bd299.png)
Help Wanted,Product-Conpty,Area-VT,Issue-Task
low
Critical
500,178,373
go
net/http: TimeoutHandler hides panic after timeout
If `TimeoutHandler`'s inner handler panics after the timeout, the panic is discarded: https://play.golang.org/p/GT7lVCBu163 This happens because [after the timeout](https://github.com/golang/go/blob/4faf8a8dc44555c4fdbe4fb108f42144e58ae6b1/src/net/http/server.go#L3254), `TimeoutHandler.ServeHTTP` doesn't wait for the inner handler to complete, and anything on `panicChan` is lost. I understand that waiting for the inner handler would partly defeat the purpose of `TimeoutHandler`. If waiting is not acceptable, perhaps the docs should warn about dropped panics. Also, `timeoutWriter.Push` panics if called after the timeout: https://play.golang.org/p/-AZj5t-ViyJ (Not sure if this should be a separate issue.) This happens because `timeoutWriter.Push` may call the underlying `Push` after or concurrently with the completion of `TimeoutHandler.ServeHTTP` (after which `http2responseWriter.rws` is set to nil). Of course the panic is not logged for the reason already mentioned.
NeedsInvestigation
low
Minor
500,182,700
vue-element-admin
Lots of deprecated packages
input ```sh $ git clone https://github.com/PanJiaChen/vue-element-admin.git $ cd vue-element-admin $ npm install ``` output ``` npm WARN deprecated [email protected]: This project has been renamed to 'tasksfile'. Install using 'npm install tasksfile' instead. npm WARN deprecated [email protected]: This project has been renamed to @pawelgalazka/cli . Install using @pawelgalazka/cli instead npm WARN deprecated [email protected]: Package no longer supported. Contact [email protected] for more info. npm WARN deprecated [email protected]: This project has been renamed to @pawelgalazka/cli-args. Install using @pawelgalazka/cli-args instead npm WARN deprecated [email protected]: Please upgrade to kleur@3 or migrate to 'ansi-colors' if you prefer the old syntax. Visit <https://github.com/lukeed/kleur/releases/tag/v3.0.0\> for migration path(s). npm WARN deprecated [email protected]: CircularJSON is in maintenance only, flatted is its successor. npm WARN deprecated [email protected]: use String.prototype.padStart() ```
enhancement :star:
low
Minor
500,185,666
material-ui
[Popover] On mobile Chrome while zoomed, opening popover causes page to jump
- [x] The issue is present in the latest release. - [x] * I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate. \* There's an open issue related to [IconMenu for iOS devices](https://github.com/mui-org/material-ui/issues/9802), but this is not the same component, and also no longer exclusive to iOS devices but happens on Android also. ## Current Behavior 😯 On mobile Chrome, while the page is slightly zoomed, opening the popover will cause it to open but will also cause the page to scroll itself up into a position in which the popover can no longer be visible. Also, while being in that position, the scrolling/zooming of the page is disabled and the only interaction allowed is to tap the invisible backdrop in order for the popover to close. The issue does not happen on the root component (Modal) which leads us to believe that this may be an issue with the calculation of the anchor position, but we're not 100% sure. We have also tested all the combinations of disableAutoFocus, disableEnforceFocus and disableRestoreFocus for the root modal props, but to no effect. The issue only happens on the actual mobile device, using the desktop Chrome Devtools to emulate the issue was unsuccessful. ## Expected Behavior 🤔 Expected the popover to open and for the page to stay in the same scroll position regardless of the current zoom level in order for the popover content to be visible, also expected to be able to at least drag the viewport in order to reach the relevant popover after the jump (solved it by overriding the `touch-action: none` css for the backdrop, but was confused by its default value) ## Steps to Reproduce 🕹 The issue can be reproduced on the material-ui popover component demo website: https://material-ui.com/components/popover/ Including video of the interaction described in the steps below: https://drive.google.com/file/d/12MLICM7nngPuthRaVhXurLLkKq1212PK/view Steps: 1. Browse on mobile Chrome to https://material-ui.com/components/popover/ ![popover1](https://user-images.githubusercontent.com/18516271/65868518-18ed4500-e381-11e9-959f-09634f78f5c7.jpg) 2. Detect the "Simple Popover" demo section, slightly zoom in (device pinch) so that the "Open Popover" button is still visible. ![popover2](https://user-images.githubusercontent.com/18516271/65868525-1db1f900-e381-11e9-9ba0-714b34e0a365.jpg) 3. Click the "Open Popover" button ![popover3](https://user-images.githubusercontent.com/18516271/65868538-230f4380-e381-11e9-93d7-79e5a00755b1.jpg) 4. At this point, the popover is open but the page already scrolled itself up ## Context 🔦 We've been using material-ui for our project for quite some time and are very pleased by it. Due to the nature of our project, mobile support has been minimal but users that wished to browse through mobile generally had no difficulties to pan/zoom in order to move around the page. We made heavy usage of modals, popovers and dialogs, but the current issue prevents users from completing simple actions. We believe that the issue is quite new and that the new Chrome mobile version might also have something to do with it. ## Your Environment 🌎 Our local environment is a bit outdated (React v16.7 & material-ui v3.7.0) but the issue occurs even on the demo website, which leads us to believe that the issue is consistent even on the latest version. | Tech | Version | | ----------- | ------- | | Material-UI | v4.4.3 (latest) | | React | v16.8.0+ (latest) | | Browser | Google Chrome (mobile) 77.0.3865.92 | | Device | OnePlus 6 (ONEPLUS A6003), but happens on all of the Android and iOS devices we had a chance to test |
bug 🐛,component: Popover,priority: important
medium
Major
500,186,978
flutter
SSL configuration
Please add **SSL** configuration like in **npm** _ssl-strict_. i can't access https://pub.dartlang.org/api/packages/cupertino_icons or any other package while running command **flutter packages get** in project directory. but when i access via browser it's letting me smoothly.
c: new feature,tool,a: first hour,P2,team-tool,triaged-tool
low
Major
500,203,017
rust
Two recursive trait strategies. Only one compiles.
## Overview I made an example to define a list in type level, and wrote two ways to recursively insert a new typed key into the list. The complete example is in the gist link. https://gist.github.com/jerry73204/364c4b61d884c1150807cdcc9357890d In brief, the first way is to define a vanilla recursive trait like this. Then, impl cases on _found the key_ termination step and _not the key_ non-terminating step. It compiles and works. ```rust pub trait Insert<NewKey, Target, Cnt> where Cnt: Counter, Self: TList, Self::Output: TList, { type Output; } impl<...> Insert<NewKey, Target, Current> for Cons<Target, Tail> ... {...} impl<...> Insert<NewKey, Target, Next<Index>> for Cons<NonTarget, Tail> ... {...} ``` The second strategy is less straightforward. It defines a `Functor` trait such that any types with this trait works as type operator, which output is `<SomeType<Args> as Functor<Input>>::Output`. Similarly, we define termination and non-terminating steps. However, it ends in `overflow evaluating` error. ```rust pub struct InsertFunctor<NewKey, Target, Index> where Index: Counter, { _phantom: PhantomData<(NewKey, Target, Index)>, } impl<...> Functor<Cons<Target, Tail>> for InsertFunctor<NewKey, Target, Current> ... {...} impl<...> Functor<Cons<NonTarget, Tail>> for InsertFunctor<NewKey, Target, Next<Index>> ... {...} ``` ## Thoughts In my naive observation, both ways have identical signatures in impl blocks. I would expect both compile or fail with same error. So I'm wondering what leads to the error, and the logic behind it. If you're asking why functor indirection, I'm working on type level DSTs in a [little project](https://github.com/jerry73204/rust-type-freak), which allows users to wrap their own functor to apply on lists. Edit: Setup: - rustc: 1.40.0-nightly - cargo: 1.39.0-nightly - OS: Arch Linux
A-type-system,A-trait-system,A-associated-items,T-compiler,T-types
low
Critical
500,203,827
godot
Multi-threading debugger errors when using large loops
**Godot version:** 3.11 **OS/device including version:** Intel Core i7-4790K CPU 16GB ram Windows 8.1 64bit **Steps to reproduce:** Main scene: ``` extends Spatial var threadScene = load("res://Thread.tscn") func _ready(): print("ESC to cancel test. Check debugger for errors.") func _input(event): if Input.is_action_pressed('exit'): get_tree().quit() func _process(delta): var newThread = threadScene.instance() add_child(newThread) newThread.begin() ``` Thread scene: ``` extends Node var thread = Thread.new() func begin(): thread.start(self, "_thread_function") func _thread_function(userdata): var threadData = [] for i in 100000: threadData.append(0) call_deferred("waitForCompletion") return threadData func waitForCompletion(): var data = thread.wait_to_finish() queue_free() ``` **Minimal reproduction project:** [Isolate Bug.zip](https://github.com/godotengine/godot/files/3670516/Isolate.Bug.zip) **Issue description:** If you let this run for a while (can take anywhere from 0-30 seconds) the debugger will fill with errors and lock up the game. The time it takes to generate the errors is inconsistent and so is the amount of errors. With this code I couldn't get the errors to appear at 50000 loops but it does appear at 100000 loops. To produce these errors I was originally using Vector3s in dictionaries (for terrain gen) but it looks like arrays have the same issue. In my game I get the errors using as little as 15000 loops but there's a lot more other stuff going on so I think it's about the intensity of the process. This is the usual error: ``` E 0:00:02:0793 Condition ' len < 4 ' is true. returned: ERR_INVALID_DATA <C Source> core/io/marshalls.cpp:108 @ decode_variant() E 0:00:02:0793 Condition ' err != OK ' is true. Continuing..: <C Source> core/script_debugger_remote.cpp:692 @ _poll_events() ``` But I've also seen this on occasion: ``` E 0:00:12:0153 Condition ' (type & 0xFF) >= Variant::VARIANT_MAX ' is true. returned: ERR_INVALID_DATA <C Source> core/io/marshalls.cpp:113 @ decode_variant() E 0:00:12:0154 Condition ' err ' is true. returned: err <C Source> core/io/marshalls.cpp:487 @ decode_variant() E 0:00:12:0155 Condition ' err ' is true. returned: err <C Source> core/io/marshalls.cpp:531 @ decode_variant() E 0:00:12:0155 Condition ' err != OK ' is true. Continuing..: <C Source> core/script_debugger_remote.cpp:692 @ _poll_events() E 0:00:12:0307 Condition ' var.get_type() != Variant::ARRAY ' is true. Continuing..: <C Source> core/script_debugger_remote.cpp:693 @ _poll_events() ``` I don't know what any of this means. I am unable to use multi-threading as it currently is (the errors are freezing my game). Your help is appreciated.
discussion,topic:core
low
Critical
500,206,671
react
Design decision: why do we need the stale closure problem in the first place?
Hi, I initially asked this on Twitter and @gaearon suggested me to open an issue instead. The original thread is here: https://twitter.com/sebastienlorber/status/1178328607376232449?s=19 More easy to read here: https://threadreaderapp.com/thread/1178328607376232449.html But will try to make this issue more clear and structured about my args and questions. Don't get me wrong, I really like hooks, but wonder if we can't have smarter abstractions and official patterns that make dealing with them more easy for authors and consumers. -------------------------------------- ## Workaround for the stale closure After using hooks for a while, and being familiar with the stale closure problem, I don't really understand why we need to handle closure dependencies, instead of just doing something like the following code, which always executes latest provided closure (capturing fresh variables) ![image](https://user-images.githubusercontent.com/749374/65869094-f7d52600-e379-11e9-9634-1ab06b41e3ca.png) Coupling the dependencies of the closure and the conditions to trigger effect re-execution does not make much sense to me. For me it's perfectly valid to want to capture some variables in the closure, yet when those variables change we don't necessarily want to re-execute. There are many cases where people are using refs to "stabilize" some value that should not trigger re-execution, or to access fresh values in closures. Examples in major libs includes: - Formik (code is pretty similar to my "useSafeEffect" above): https://github.com/jaredpalmer/formik/blob/master/src/Formik.tsx#L975 - React-redux, which uses refs to access fresh props: https://github.com/reduxjs/react-redux/blob/b6b47995acfb8c1ff5d04a31c14aa75f112a47ab/src/components/connectAdvanced.js#L286 Also @Andarist (who maintains a few important React libs for a while): ![image](https://user-images.githubusercontent.com/749374/65872332-9d8b9380-e380-11e9-90b3-bf294991bb82.png) We often find in such codebase the "useIsomorphicLayoutEffect" hook which permits to ensure that the ref is set the earliest, and try to avoid the useLayoutEffect warning (see https://gist.github.com/gaearon/e7d97cdf38a2907924ea12e4ebdf3c85). What we are doing here seems unrelated to layout and makes me a bit uncomfortable btw. ## Do we need an ESLint rule? The ESLint rule looks to me only useful to avoid the stale closure problem. Without the stale closure problem (which the trick above solves), you can just focus on crafting the array/conditions for effect re-execution and don't need ESLint for that. Also this would make it easier to wrap useEffect in userland without the fear to exposing users to stale closure problem, because eslint plugin won't notice missing dependencies for custom hooks. Here's some code for react-navigation (alpha/v5). To me this is weird to have to ask the user to "useCallback" just to stabilize the closure of useFocusEffect, just to ensure the effect only runs on messageId change. ![image](https://user-images.githubusercontent.com/749374/65869719-3d462300-e37b-11e9-94d2-5200481588bc.png) Not sure to understand why we can't simply use the following instead. For which I don't see the point of using any ESLint rule. I just want the effect to run on messageId change, this is explicit enough for me and there's no "trap" ![image](https://user-images.githubusercontent.com/749374/65869777-564ed400-e37b-11e9-8570-12534e5f2a53.png) I've heard that the [React team recommends rather the later](https://twitter.com/satya164/status/1178571088172896256), asking the user to useCallback, instead of building custom hooks taking a dependency array, why exactly? Also heard that the ESLint plugin now was able to detect missing deps in a custom hook, if you add the [hook name to ESLint conf](https://twitter.com/n1rual/status/1178568248062877701). Not, sure what to think we are supposed to do in the end. ## Are we safe using workarounds? It's still a bit hard for me to be sure which kind of code is "safe" regarding React's upcoming features, particularly Concurrent Mode. If I use the `useEffectSafe` above or something equivalent relying on refs, I am safe and future proof? If this is safe, and makes my life easier, why do I have to build this abstraction myself? Wouldn't it make sense to make this kind of pattern more "official" / documented? I keep adding this kind of code to every project I work with: ```tsx const useGetter = <S>(value: S): (() => S) => { const ref = useRef(value); useIsomorphicLayoutEffect(() => { ref.current = value; }); return useCallback(() => ref.current, [ref]); }; ``` (including important community projects like [react-navigation-hooks](https://github.com/react-navigation/hooks/blob/master/src/Hooks.ts#L46)) ## Is it a strategy to teach users? Is it a choice of the React team to not ship safer abstractions officially and make sure the users hit the closure problem early and get familiar with it? Because anyway, even when using getters, we still can't prevent the user to capture some value. This has been documented by @sebmarkbage [here](https://gist.github.com/sebmarkbage/a5ef436427437a98408672108df01919) with async code, even with a getter, we can't prevent the user to do things like: ```tsx onMount(async () => { let isEligible = getIsEligible(); let data = await fetch(...); // at this point, isEligible might has changed: we should rather use `getIsEligible()` again instead of storing a boolean in the closure (might depend on the usecase though, but maybe we can imagine isEligible => isMounted) if (isEligible) { doStuff(data); } }); ``` As far as I understand, this might be the case: > So you can easily get into the same situation even with a mutable source value. React just makes you always deal with it so that you don't get too far down the road before you have to refactor you code to deal with these cases anyway. I'm really glad how well the React community has dealt with this since the release of hooks because it really sets us up to predictably deal with more complex scenario and for doing more things in the future. ## A concrete problem A react-navigation-hooks user reported that his effect run too much, using the following code: ![image](https://user-images.githubusercontent.com/749374/65870979-bf374b80-e37d-11e9-8a6c-1f7df8503c18.png) In practice, this is because react-navigation core does not provide stable `navigate` function, and thus the hooks too. The core does not necessarily want to "stabilize" the navigate function and guarantee that contract in its API. It's not clear to me what should I do, between officially stabilizing the `navigate` function in the hooks project (relying on core, so core can still return distinct navigate functions), or if I should ask the user to stabilize the function himself in userland, leading to pain and boilerplate for many users trying to use the API. I don't understand why you can't simply dissociate the closure dependencies to the effect's triggering, and simply omitting the `navigate` function here: ![image](https://user-images.githubusercontent.com/749374/65871264-51d7ea80-e37e-11e9-837d-291775853b2e.png) What bothers me is that somehow as hooks lib authors we now have to think about whether what we return to the user is stable or not, ie safe to use in an effect dependency array without unwanted effect re-executions. Returning a stable value in v1 and unstable in v2 is a breaking change that might break users apps in nasty ways, and we have to document this too in our api doc, or ask the user to not trust us, and do the memoization work themselves, which is quite error prone and verbose. Now as lib authors we have to think not only about the inputs/outputs, but also about preserving identities or not (it's probably not a new problem, because we already need to in userland for optimisations anyway). Asking users to do this memoization themselves is error prone and verbose. And intuitively some people will maybe want to `useMemo` (just because of the naming) which actually can tricks them by not offering the same guarantees than `useCallback`. ## A tradeoff between different usecases in the name of a consistent API? @satya164 also mentionned that there are also usecases where the [ESLint plugin saved him](https://twitter.com/satya164/status/1178395620236759043) more than once because he forgot some dependency, and for him, it's more easy to fix an effect re-executing too much than to find out about some cached value not updating. I see how the ESLint plugin is really handy for usecases such as building a stable object to optimize renders or provide a stable context value. But for useEffect, when capturing functions, sometimes executing 2 functions with distinct identities actually lead to the same result. Having to add those functions to dependencies is quite annoying in such case. But I totally understand we want to guarantee some kind of consistency across all hooks API. ## Conclusion I try to understand some of the tradeoffs being made in the API. Not sure to understand yet the whole picture, and I'm probably not alone. @gaearon said to open an issue with a comment: `It's more nuanced`. I'm here to discuss all the nuances if possible :) What particularly bothers me currently is not necessarily the existing API. It's rather: - the dogmatism of absolutely wanting to conform the ESLint rules (for which I don't agree with for all usecases). Currently I think users are really afraid to not follow the rules. - the lack of official patterns on how we are supposed to handle some specific hooks cases. And I think the "getter" pattern should be a thing that every hooks users know about and learn very early. Eventually adding such pattern in core would make it even more visible. Currently it's more lib authors and tech leads that all find out about this pattern in userland with small implementation variations. Those are the solutions that I think of. As I said I may miss something important and may change my opinions according to the answers. As an author of a few React libs, I feel a bit frustrated to not be 100% sure what kind of API contract I should offer to my lib's users. I'm also not sure about the hooks patterns I can recommend or not. I plan to open-source something soon but don't even know if that's a good idea, and if it goes in the direction the React team want to go with hooks. Thanks
Type: Discussion
high
Critical
500,288,252
kubernetes
Scheduler does not prioritize volume sizes
**What happened**: With `volumeBindingMode: WaitForFirstConsumer`, scheduler does not take PV sizes into account when scheduling a Pod that can run anywhere and PVC that can find several available pre-provisioned PVs with various sizes. **What you expected to happen**: Scheduler tries to find as small PV as possible. **How to reproduce it (as minimally and precisely as possible)**: Let's have these PVs (each on a different node): ``` kind: PersistentVolume apiVersion: v1 metadata: name: vol1 spec: accessModes: - ReadWriteOnce capacity: storage: 10Gi hostPath: path: /srv/vol1 persistentVolumeReclaimPolicy: Retain storageClassName: local nodeAffinity: required: nodeSelectorTerms: - matchExpressions: - key: kubernetes.io/hostname operator: In values: - ip-10-0-134-206 --- kind: PersistentVolume apiVersion: v1 metadata: name: vol2 spec: accessModes: - ReadWriteOnce capacity: storage: 2Gi hostPath: path: /srv/vol2 persistentVolumeReclaimPolicy: Retain storageClassName: local nodeAffinity: required: nodeSelectorTerms: - matchExpressions: - key: kubernetes.io/hostname operator: In values: - ip-10-0-169-29 ``` A PVC asking for 1GiB is randomly bound to `vol1` or `vol2`. It should prefer `vol2`. **Anything else we need to know?**: [Volume topology scheduling design](https://github.com/kubernetes/community/blob/master/contributors/design-proposals/storage/volume-topology-scheduling.md) mentions `PrioritizeVolumes` priority function, it seems it has never been implemented. **Environment**: - Kubernetes version (use `kubectl version`): 1.16.1
kind/bug,sig/scheduling,sig/storage,lifecycle/frozen
medium
Major
500,333,886
create-react-app
Global .scss declarations (variables etc...) without ejecting
### Is your proposal related to a problem? Yes, currentlly it isn't possible to globally load `.scss` files without needing them to be imported in _every_ `.scss` files. This issue is merely a duplicate of #5920 and the corresponding comment https://github.com/facebook/create-react-app/issues/1619#issuecomment-438755957. ### Describe the solution you'd like Vue solves it by allowing the user to intercept the config-chain and prepending sass content into every .scss file like that (Snipped from `vue.config.js`): ```js css: { loaderOptions: { sass: { // Global scss prependData: '@import "@/scss/_main.scss";' } } }, ... more config stuff ``` It's now possible to use the [prependData](https://github.com/webpack-contrib/sass-loader#prependdata) option for `css-loader` to allow this (I guess this wasn't possible back then - but now it is). Though I'm not sure how to realize that via `create-react-app-2` (I'm new to react) ### Describe alternatives you've considered The only alternative is to import your "global" `.scss` file every time.
issue: proposal,needs triage
medium
Major
500,341,433
go
x/crypto/ssh/terminal: terminal.ReadPassword doesn't work when using Bash for Windows (from Git installation)
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.12.5 windows/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env set GOARCH=amd64 set GOBIN= set GOCACHE=C:\Users\mrausc\AppData\Local\go-build set GOEXE=.exe set GOFLAGS= set GOHOSTARCH=amd64 set GOHOSTOS=windows set GOOS=windows set GOPATH=C:\Users\mrausc\go set GOPROXY= set GORACE= set GOROOT=C:\MyProgs\Go set GOTMPDIR= set GOTOOLDIR=C:\MyProgs\Go\pkg\tool\windows_amd64 set GCCGO=gccgo set CC=gcc set CXX=g++ set CGO_ENABLED=1 set GOMOD=X:\swda\play\go.mod set CGO_CFLAGS=-g -O2 set CGO_CPPFLAGS= set CGO_CXXFLAGS=-g -O2 set CGO_FFLAGS=-g -O2 set CGO_LDFLAGS=-g -O2 set PKG_CONFIG=pkg-config set GOGCCFLAGS=-m64 -mthreads -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=C:\Users\mrausc\AppData\Local\Temp\go-build325358090=/tmp/go-build -gno-record-gcc-switches </pre></details> ### What did you do? <pre> func main() { _, err := terminal.ReadPassword(int(os.Stdin.Fd())) fmt.Println(err) } </pre> ### What did you expect to see? no echo of password ### What did you see instead? "The handle is invalid."
help wanted,OS-Windows,NeedsInvestigation
low
Critical
500,399,902
rust
1.38 regression ? proc-macro derive panicked if there is r# in front of the attribute name
I have a macro and it defines an attribute called "async". When I use it, I add r# in front of it. I have this : ``` #[cowrpc(r#async)] struct Handshake { ... } ``` Since 1.38.0, it fails with ``` error: proc-macro derive panicked --> src/cow/den_server_iface.rs:3:10 | 3 | #[derive(CowRpcIface)] | ^^^^^^^^^^^ | = help: message: "r#async" is not a valid ident error: proc-macro derive panicked ``` It was building without any error before. What is different with 1.38?
A-attributes,P-medium,A-macros,T-compiler,regression-from-stable-to-stable
low
Critical
500,422,110
go
gccgo: oddity with export data and init functions
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? gccgo tip <pre> $ go version go version go1.13 gccgo (GCC) 10.0.0 20190916 (experimental) linux/amd64 </pre> ### Does this issue reproduce with the latest release? yes ### What operating system and processor architecture are you using (`go env`)? linux/amd64 ### What did you do? Compile this package with gccgo: <pre> package c import "sort" func init() { sort.Sort(byMaskLength(xpolicyTable)) } type byMaskLength []policyTableEntry func (s byMaskLength) Len() int { return len(s) } func (s byMaskLength) Swap(i, j int) { s[i], s[j] = s[j], s[i] } func (s byMaskLength) Less(i, j int) bool { return s[i].Label < s[j].Label } type policyTableEntry struct { Label int } type policyTable []policyTableEntry var xpolicyTable = policyTable{} //go:noinline func F() int { return xpolicyTable[0].Label } </pre> ### What did you expect to see? Expected a single entry func F () <type -11> in the export data for the package, since that is the only exported identifier. ## What did you see instead? Export data includes the 'byMaskLength' type and its associated methods, which was a surprise. I poked around at this and discovered that the lowering phase is running inlinabliity analysis on init functions, and it decides as part of this that the init() function is inlinable. This means that we include the types reachable from it in the export data (even though the init function itself is not emitted as an inline candidate.
NeedsInvestigation
low
Minor
500,434,950
kubernetes
Kubernetes API server stuck on metrics server API service discovery check failure
**What happened**: Occasionally, the metrics server API service `v1beta1.metrics.k8s.io` fails discovery after cluster creation. The discovery checks often continue failing until the API service is deleted and recreated. Sometimes, discovery will eventually succeed without intervention but this could take 30 or more minutes. This problem primarily impacts Kubernetes v1.15, but has been seen at least once on Kubernetes v1.16. In addition to recreating the API service to resolve the problem, adding a liveness and readiness probe to https://github.com/kubernetes/kubernetes/blob/master/cluster/addons/metrics-server/metrics-server-deployment.yaml usually prevents the discovery failure loop. Example `v1beta1.metrics.k8s.io` API service status: ``` status: conditions: - lastTransitionTime: "2019-09-28T20:11:14Z" message: 'failing or missing response from https://172.21.13.79:443/apis/metrics.k8s.io/v1beta1: Get https://172.21.13.79:443/apis/metrics.k8s.io/v1beta1: net/http: request canceled (Client.Timeout exceeded while awaiting headers)' reason: FailedDiscoveryCheck status: "False" type: Available ``` See comments for example Kubernetes API server and metric server pod log error messages during discovery failure loop. **What you expected to happen**: Metrics server API service `v1beta1.metrics.k8s.io` discovery succeeds after cluster creation. **How to reproduce it (as minimally and precisely as possible)**: Reproducing the problem is not easy since it appears to be timing related with respect to API server discovery of metrics server API service. **Anything else we need to know?**: No. **Environment**: - Kubernetes version (use `kubectl version`): Primarily v1.15.x, although seen once on v1.16.0 - Cloud provider or hardware configuration: IBM Cloud Kubernetes Service - OS (e.g: `cat /etc/os-release`): Ubuntu 18.04.3 LTS - Kernel (e.g. `uname -a`): 4.15.0-64-generic - Install tools: Cloud provider managed service install tools - Network plugin and version (if this is a network-related bug): Calico v3.8.2 - Others: None.
kind/bug,sig/api-machinery,sig/instrumentation,lifecycle/frozen,triage/accepted
high
Critical
500,473,496
flutter
[web] Support scrolling inside the text field
There are 2 situations where the text field can scroll: 1. Very long text in a single-line text field (horizontal scrolling). 2. Many lines of text in a multi-line text field (vertical scrolling). Currently, the scrolling works fine but the issue is that Flutter's field and the browser's field get out of sync, and they are scrolled to different positions.
a: text input,framework,f: scrolling,platform-web,P2,team-web,triaged-web
low
Major
500,504,940
flutter
[web] Support line height + word spacing in text fields
TextInput.setStyle method call informs the engine about the styling info of an editable text. This method does not support line height and word spacing.
a: text input,c: new feature,framework,platform-web,P3,team-web,triaged-web
low
Minor
500,508,512
pytorch
[jit] Document what types can be traced
Our `torch.jit.trace` docs don't mention that `Dict[str, Tensor]` can be traced, nor that NamedTuples cannot be traced cc @suo
oncall: jit,triaged,jit-backlog
low
Minor
500,511,067
TypeScript
Allow circular references of project references
## Search Terms circular reference project references graph ## Suggestion Currently, project reference graphs are required to be acyclical because * Project references *imply* a `.d.ts` file is loaded, and `.d.ts` files can't exist before the build occurs * Only acyclic graphs can be topologically sorted Both of these problems are solvable without too much work. With the work done in #32028, we can effectively toggle the redirecting behavior, fixing the first issue. This would be done during the *initial* build phase only when an upstream project dependency isn't built yet. The other problem is that project build order might not be predictable if we arbitrarily pick some starting point in the unsortable graph. This is fixable if we force solution authors to indicate which edges in the graph should be treated as ignored for the purposes of the topological sort: ``` "references": [ { "path": "../a" }, { "path": "../b", "circular": true }, ^^^^^^^^^^^^^^^^ { "path": "../c" } ], ``` The benefits of this are: * In case of suboptimal `.d.ts` generation or memory pressure, developers can control where the "weak" link occurs in the build process * The build ordering is fully deterministic regardless of starting point * Graphs can't become "accidentally" circular - this is a clear opt-in ## Use Cases `npm` and other package managers *do* allow circularities in dependency graphs, so this is apparently a thing. We've also gotten feedback from some industry partners that they want to move to project references, but their dependency graph is circular in a way that would require a lot of work to "fix". ## Examples Given the graph: ``` A -> B -> C -(circular)-> A ``` The build order is deterministically `C`, `B`, `A`. During `C`'s compilation, source file redirects from `C` to `A` are not active. ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
high
Critical
500,527,262
pytorch
[c10] c10 dispatch doesn't support tracing of scalars
Example: ``` import torch def foo(x): return torch.ops.quantized.add_scalar(x, 3) x = torch.quantize_per_tensor(torch.rand(3, 4), 0.01, 0, torch.qint8) torch.jit.trace(foo, (x,)) ``` Results in the following error ``` RuntimeError: unsupported input type: Scalar ``` That traces back to this line: https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/register_c10_ops.cpp#L175 However, normal ATen ops support this functionality. Take `__ilshift__` as an example: ``` import torch def foo(x): return x << 3 #x = torch.quantize_per_tensor(torch.rand(3, 4), 0.01, 0, torch.qint8) x = torch.rand(3, 4) traced = torch.jit.trace(foo, (x,)) print(traced.graph) ``` Which works and prints the following graph: ``` graph(%x : Float(3, 4)): %1 : int = prim::Constant[value=3]() # trace_sa2.py:4:0 %2 : Float(3, 4) = aten::__lshift__(%x, %1) # trace_sa2.py:4:0 return (%2) ``` We should have this functionality in tracing c10 ops cc @ezyang @gchanan @zou3519 @jerryzh168 @jianyuh @dzhulgakov @raghuramank100
module: internals,triaged,module: dispatch
medium
Critical
500,528,339
flutter
[Semantics] tester.getSemantics(...) returning unexpected merged semantics node.
I have a custom class that wraps a `FloatingActionButton`. I have a widget test for this class, and I check the semantics of my custom button using `tester.getSemantics(find.byType(MyButton))`. The `SemanticsNode` returned by this method is not the one I would expect to be returned. Here is an example of a test I would expect to pass: ```dart import 'package:flutter/material.dart'; import 'package:flutter_test/flutter_test.dart'; void main() { testWidgets('MyButton has correct semantics', (WidgetTester tester) async { await tester.pumpWidget( MaterialApp( home: Scaffold( body: Center( child: MyButton(), ), ), ), ); expect( tester.getSemantics(find.byType(MyButton)), matchesSemantics( isButton: true, isEnabled: true, isImage: false, hasEnabledState: true, hasTapAction: true, label: 'foo', ), ); }); } class MyButton extends StatelessWidget { @override Widget build(BuildContext context) { return Padding( padding: const EdgeInsets.all(8), child: FloatingActionButton( tooltip: 'foo', onPressed: () {}, ), ); } } ``` But when I replace the line ```dart tester.getSemantics(find.byType(MyButton)), ``` With: ```dart tester.getSemantics( find.descendant( of: find.byType(MyButton), matching: find.byType(Semantics), ).first, ), ``` The test passes. ### Flutter Doctor Output ``` [✓] Flutter (Channel fix-textFieldRipple, v1.10.2-pre.165, on Mac OS X 10.14.6 18G87, locale en-US) • Flutter version 1.10.2-pre.165 at /Users/<my username>/mdc/flutter • Framework revision 8912259b0a (3 days ago), 2019-09-27 15:03:48 -0400 • Engine revision 18bc0b2596 • Dart version 2.6.0 (build 2.6.0-dev.0.0 403c4af720) [✓] Android toolchain - develop for Android devices (Android SDK version 29.0.2) • Android SDK at /Users/<my username>/Library/Android/sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-29, build-tools 29.0.2 • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 10.3) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 10.3, Build version 10G8 • CocoaPods version 1.7.5 [✓] Chrome - develop for the web • Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [✓] Android Studio (version 3.5) • Android Studio at /Applications/Android Studio with Blaze.app/Contents • Flutter plugin version 38.2.3 • Dart plugin version 191.8423 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) [✓] Android Studio (version 3.5) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 39.0.3 • Dart plugin version 191.8423 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405) [✓] Connected device (4 available) ... • No issues found! ``` cc @jonahwilliams
a: tests,framework,f: material design,a: accessibility,has reproducible steps,P3,found in release: 1.22,found in release: 2.2,found in release: 2.3,team-design,triaged-design
low
Major
500,531,637
pytorch
Support implicit RRef type conversion
Currently, `dist.rpc` and `dist.remote` only matches arguments with exact types. We should support implicit RRef type conversion as described in #23110 (i.e. `T->RRef[T]` and `RRef[T] -> T`). cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini
triaged,module: rpc
low
Minor
500,570,869
react
Devtools Inspect Button Doesn't Work with Repeat Selections
Maybe we can detect this case by checking $0 and if not we can temporarily select null before reselecting. (?)
Component: Developer Tools,React Core Team
medium
Minor
500,593,380
godot
GLES2 MSAA implementation relies on platform-defines instead of feature-based ones
**Godot version:** master **Issue description:** in https://github.com/godotengine/godot/blob/bd74084e2fb431e8ef0ea3150ca82a4499f54bfb/drivers/gles2/rasterizer_storage_gles2.cpp#L4687 , there's a bunch of platform specific blocks to implement MSAA differently depending on the platform. We need to change it to be platform independent, by naming the features and not the platforms. For example: ``` #ifdef MSAA_FEATURE_1 // do msaa using feature 1 #elif MSAA_FEATURE_2 // do msaa using feature 2 #endif ``` Then in platform_config.h for each platform, we enable the right define to get the desired code for the platform. This allows new platforms to be implemented without having to touch this code, which should be platform-independent. I'm opening an issue instead of a pull request because I don't know the specifics of what's being used there, I'll talk to @clayjohn and @Faless about it
bug,enhancement,discussion,topic:rendering,topic:porting,confirmed
low
Minor
500,627,056
go
cmd/go: error for unset $GOPATH when GOROOT is $HOME/go is unhelpful
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.13.1 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="on" GOARCH="amd64" GOBIN="/home/user/bin" GOCACHE="/home/user/.cache/go-build" GOENV="/home/user/.config/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GONOPROXY="" GONOSUMDB="" GOOS="linux" GOPATH="/home/user" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/home/user/go" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/home/user/go/pkg/tool/linux_amd64" GCCGO="gccgo" AR="ar" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="/dev/null" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build291059786=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> Unset GOPATH and have the go source tree located at $HOME/go. Then run the go tool to do something, e.g. `go env`. ### What did you expect to see? An informative error message. ### What did you see instead? "missing $GOPATH" ### Additional information See https://groups.google.com/d/topic/golang-nuts/D7wk6Mb6bZI/discussion Note that while this is superficially similar to #29341, the fix at https://golang.org/cl/158257 will not fix this.
NeedsInvestigation,GoCommand
low
Critical
500,756,975
TypeScript
Allowing subsequent property declarations of compatible types
## Search Terms TS2717, subsequent property declarations ## Suggestion Let's assume following code: Library typings: ```typescript interface Dictionary<T> { [key: string]: T; } interface Foo { methods: Dictionary<Function>; } ``` User extension: ```typescript declare module "@awesome/library" { interface BagOfFunctions extends Dictionary<Function> { wellKnownFunction(foo: number): number; } interface Foo { methods: BagOfFunctions; } } ```` Currently, it results in TS2717. After this change, such code will be allowed. ## Use Cases Use case: Hapi allow user to define global functions with shared cache ([`server.method`](https://hapi.dev/api/?v=18.4.0#-servermethodname-method-options)). Unfortunely, `server.methods` is currently defined as `Dictionary<ServerMethod>` and end users aren't able to get type safety when calling them. ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Needs Proposal
low
Major
500,764,573
scrcpy
MediaCodec$CodecException: Error 0xfffffff4
Hi, I am facing the following error on a custom ROM ... and i am connected over wifi adb ``` $ scrcpy INFO: scrcpy 1.10 <https://github.com/Genymobile/scrcpy> /usr/local/share/scrcpy/scrcpy-server.jar: 1 file pushed. 0.1 MB/s (22546 bytes in 0.146s) adb: error: more than one device/emulator ERROR: "adb reverse" returned with value 1 WARN: 'adb reverse' failed, fallback to 'adb forward' 27183 INFO: Initial texture: 1536x2048 [server] ERROR: Exception on thread Thread[main,5,main] android.media.MediaCodec$CodecException: Error 0xfffffff4 at android.media.MediaCodec.native_configure(Native Method) ```
codec
medium
Critical
500,770,426
TypeScript
Array.isArray refinement loses the array's type
I realize there are a number of related issues. However, some where about ReadonlyArray, some didn't see directly related at all even though it was pointed there. Also, this is a much smaller example, just a single line of code really: [Playground link](http://www.typescriptlang.org/play/index.html#code/GYVwdgxgLglg9mABAEwKYFs4AoZQFyICSUqATgIYBGANqgDxgjqVkB8AlAY82QNoC6iAN4AoROMQQEAZyiJypCgE9EAXkQBBReSUA6GNK3KcUdogD8iXIgK9d93PwDcIsRID07xABFU1GCwUJFy6tGAA5lAAFlbS8oiypDARiOio0XDIADSIlCByYHCIZKRwpLmoEOQg0qiIcMCIUEoADnUARORgSu2IwGWIYG7ipOkgpEgKyrro5C1YSKqsg6GoEdHsLgC+IkA) I know people will point to this ir that implementation or design decision detail — honestly guys, you got it REVERSED. The tool should serve the purpose, not the other way around! That the array loses all it's type information in such a simple example is A BUG. And it is possible to do much better: See here! I'm only pointing this out because at times the responses sound like "We tried everything but it is just not possible" when the competition shows that it is actually quite possible. Related(?): #17002
Suggestion,Needs Proposal,Fix Available
low
Critical
500,786,536
flutter
Debugger disconnects
## Steps to Reproduce At some random point this happens and debugger exists. ## Logs ``` Unhandled exception: Unimplemented clone for Kernel expression: SpreadElement #0 CloneVisitor.defaultExpression (package:kernel/clone.dart:567:5) #1 ControlFlowElement.accept (package:front_end/src/fasta/kernel/collections.dart:53:44) #2 CloneVisitor.clone (package:kernel/clone.dart:73:34) #3 MappedListIterable.elementAt (dart:_internal/iterable.dart:415:29) #4 ListIterable.toList (dart:_internal/iterable.dart:219:19) #5 CloneVisitor.visitListLiteral (package:kernel/clone.dart:255:56) #6 ListLiteral.accept (package:kernel/ast.dart:3811:36) #7 CloneVisitor.cloneOptional (package:kernel/clone.dart:83:29) #8 CloneVisitor.visitReturnStatement (package:kernel/clone.dart:400:32) #9 ReturnStatement.accept (package:kernel/ast.dart:4577:35) #10 CloneVisitor.cloneOptional (package:kernel/clone.dart:83:29) #11 CloneVisitor.cloneFunctionNodeBody (package:kernel/clone.dart:530:14) #12 CloneVisitor.visitFunctionNode (package:kernel/clone.dart:540:29) #13 FunctionNode.accept (package:kernel/ast.dart:2322:30) #14 CloneVisitor.clone (package:kernel/clone.dart:73:34) #15 CloneVisitor.visitProcedure (package:kernel/clone.dart:457:48) #16 Procedure.accept (package:kernel/ast.dart:1984:32) #17 createExpressionEvaluationComponent (package:front_end/src/fasta/kernel/utils.dart:112:27) #18 FrontendCompiler.compileExpression (package:vm/frontend_server.dart:582:29) <asynchronous suspension> #19 _FlutterFrontendCompiler.compileExpression (package:frontend_server/server.dart:60:22) #20 listenAndCompile.<anonymous closure> (package:vm/frontend_server.dart:866:20) <asynchronous suspension> #21 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10) #22 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11) #23 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7) #24 _SinkTransformerStreamSubscription._add (dart:async/stream_transformers.dart:68:11) #25 _EventSinkWrapper.add (dart:async/stream_transformers.dart:15:11) #26 _StringAdapterSink.add (dart:convert/string_conversion.dart:236:11) #27 _LineSplitterSink._addLines (dart:convert/line_splitter.dart:150:13) #28 _LineSplitterSink.addSlice (dart:convert/line_splitter.dart:125:5) #29 StringConversionSinkMixin.add (dart:convert/string_conversion.dart:163:5) #30 _SinkTransformerStreamSubscription._handleData (dart:async/stream_transformers.dart:120:24) #31 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10) #32 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11) #33 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7) #34 _SinkTransformerStreamSubscription._add (dart:async/stream_transformers.dart:68:11) #35 _EventSinkWrapper.add (dart:async/stream_transformers.dart:15:11) #36 _StringAdapterSink.add (dart:convert/string_conversion.dart:236:11) #37 _StringAdapterSink.addSlice (dart:convert/string_conversion.dart:241:7) #38 _Utf8ConversionSink.addSlice (dart:convert/string_conversion.dart:312:20) #39 _Utf8ConversionSink.add (dart:convert/string_conversion.dart:305:5) #40 _ConverterStreamEventSink.add (dart:convert/chunked_conversion.dart:72:18) #41 _SinkTransformerStreamSubscription._handleData (dart:async/stream_transformers.dart:120:24) #42 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10) #43 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11) #44 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7) #45 _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:764:19) #46 _StreamController._add (dart:async/stream_controller.dart:640:7) #47 _StreamController.add (dart:async/stream_controller.dart:586:5) #48 _Socket._onData (dart:io-patch/socket_patch.dart:1791:41) #49 _RootZone.runUnaryGuarded (dart:async/zone.dart:1314:10) #50 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:336:11) #51 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:263:7) #52 _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:764:19) #53 _StreamController._add (dart:async/stream_controller.dart:640:7) #54 _StreamController.add (dart:async/stream_controller.dart:586:5) #55 new _RawSocket.<anonymous closure> (dart:io-patch/socket_patch.dart:1339:33) #56 _NativeSocket.issueReadEvent.issue (dart:io-patch/socket_patch.dart:860:14) #57 _microtaskLoop (dart:async/schedule_microtask.dart:41:21) #58 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) #59 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:116:13) #60 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:173:5) the Dart compiler exited unexpectedly. the Dart compiler exited unexpectedly. ``` <!-- Finally, paste the output of running `flutter doctor -v` here. --> ``` [✓] Flutter (Channel beta, v1.9.1+hotfix.4, on Mac OS X 10.14.6 18G87, locale en-US) [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) [✓] Xcode - develop for iOS and macOS (Xcode 11.0) [✓] Android Studio (version 3.5) [!] IntelliJ IDEA Ultimate Edition (version 2018.1.2) ✗ Flutter plugin not installed; this adds Flutter specific functionality. ✗ Dart plugin not installed; this adds Dart specific functionality. [✓] Connected device (2 available) ! Doctor found issues in 1 category. ```
tool,a: quality,a: debugging,a: annoyance,P2,team-tool,triaged-tool
low
Critical
500,931,341
go
proxy.golang.org: improve the last FAQ entry about module retention
The last entry currently states that > **Why did a previously available module become unavailable in the mirror?** > proxy.golang.org does not save all modules forever. There are a number of reasons for this, but one reason is if proxy.golang.org is not able to detect a suitable license. In this case, only a temporarily cached copy of the module will be made available, and may become unavailable if it is removed from the original source and becomes outdated. > - Clarify what "suitable" licenses are and how license detection works. - Provide a way to easily check whether the mirrored copy is available or not. - Link to other potential solutions for module versions proxy.golang.org cannot retain forever. @myitcv @katiehockman @heschik
NeedsFix,proxy.golang.org
low
Major
500,940,511
vscode
API to toggle between flat tree (list) and tree for custom view
Context: https://github.com/microsoft/vscode-references-view/pull/54
feature-request,api,tree-views
low
Minor
500,949,774
godot
Multi-threading related crash during play in Label::regenerate_word_cache
**Godot version:** 3.1.1 Mono **OS/device including version:** Windows 10 64bit **Issue description:** I am using Mono in a project right now. It worked fine until lately. The player is now randomly crashing without any of my C# code running. The player just crashes after a few seconds - minutes. Its unpredictable when it happens and it gives no real error message, just the standard socket exception: ``` drivers/unix/net_socket_posix.cpp:190 - Socket error: 10054 ** Debug Process Stopped ** ``` The latest things I added to the project before it happened: - A few more multitasking with Tasks - but unrelated as it can happen before it gets there - New sound playback system Things I changed on my system: - Installed new version of RivaTuner - Tested without it running -> still crashing - Disabled GSync - That shouldn't affect it - Automated cleaning of standby RAM every 5 minutes - Happens more often than that Verbose logging of the player is activated, but that does not indicate any error mono logs often have a `GC_MAJOR_CONCURRENT_START: (LOS overflow) (in domain Mono, info)` at the end whenever a crash happend though It seems to happen more often when you resize the window. It also seems like to happen more often when you change the size of GUI elements, like a box container or a label. **Steps to reproduce:** - unknown - **Minimal reproduction project:** - unknown - There is only my current project which has the error
bug,topic:core,confirmed,crash,topic:gui
medium
Critical
500,986,433
pytorch
CUDAPytorchToCaffe2.MutualResizes is flaky
``` Oct 01 01:05:15 [ OK ] CUDAPytorchToCaffe2.SharedStorageWrite (0 ms) Oct 01 01:05:15 [ RUN ] CUDAPytorchToCaffe2.MutualResizes Oct 01 01:05:15 /var/lib/jenkins/workspace/aten/src/ATen/test/cuda_tensor_interop_test.cpp:151: Failure Oct 01 01:05:15 Expected equality of these values: Oct 01 01:05:15 at_tensor[0][2].item().to<float>() Oct 01 01:05:15 Which is: 1 Oct 01 01:05:15 345 Oct 01 01:05:15 [ FAILED ] CUDAPytorchToCaffe2.MutualResizes (0 ms) Oct 01 01:05:15 [----------] 3 tests from CUDAPytorchToCaffe2 (2 ms total) Oct 01 01:05:15 ``` https://app.circleci.com/jobs/github/pytorch/pytorch/3014740
caffe2-op,module: cuda,module: tests,triaged,module: flaky-tests
low
Critical
501,030,629
flutter
"flutter run" crashes on Android
Steps to Reproduce <!-- Please tell us exactly how to reproduce the problem you are running into. --> 1. flutter run ## Logs ``` Flutter crash report; please file at https://github.com/flutter/flutter/issues. ## command flutter run ## exception ProcessException: ProcessException: Process "C:\Users\Ranjan Binwani\Desktop\hello_rectangle\hello_rectangle\android\gradlew.bat" exited abnormally: ------------------------------------------------------------ Gradle 4.10.2 ------------------------------------------------------------ Build time: 2018-09-19 18:10:15 UTC Revision: b4d8d5d170bb4ba516e88d7fe5647e2323d791dd Kotlin DSL: 1.0-rc-6 Kotlin: 1.2.61 Groovy: 2.4.15 Ant: Apache Ant(TM) version 1.9.11 compiled on March 23 2018 JVM: 1.8.0_202-release (JetBrains s.r.o 25.202-b03) OS: Windows 10 10.0 amd64 The system cannot find the path specified. Command: C:\Users\Ranjan Binwani\Desktop\hello_rectangle\hello_rectangle\android\gradlew.bat -v ``` ``` #0 runCheckedAsync (package:flutter_tools/src/base/process.dart:259:7) <asynchronous suspension> #1 _initializeGradle (package:flutter_tools/src/android/gradle.dart:300:9) <asynchronous suspension> #2 _ensureGradle (package:flutter_tools/src/android/gradle.dart:281:37) <asynchronous suspension> #3 _readGradleProject (package:flutter_tools/src/android/gradle.dart:192:31) <asynchronous suspension> #4 _gradleAppProject (package:flutter_tools/src/android/gradle.dart:112:37) <asynchronous suspension> #5 getGradleAppOut (package:flutter_tools/src/android/gradle.dart:106:29) <asynchronous suspension> #6 AndroidApk.fromAndroidProject (package:flutter_tools/src/application_package.dart:164:23) <asynchronous suspension> #7 ApplicationPackageFactory.getPackageForPlatform (package:flutter_tools/src/application_package.dart:46:32) <asynchronous suspension> #8 FlutterDevice.runHot (package:flutter_tools/src/resident_runner.dart:359:56) <asynchronous suspension> #9 HotRunner.run (package:flutter_tools/src/run_hot.dart:254:39) <asynchronous suspension> #10 RunCommand.runCommand (package:flutter_tools/src/commands/run.dart:472:37) <asynchronous suspension> #11 FlutterCommand.verifyThenRunCommand (package:flutter_tools/src/runner/flutter_command.dart:490:18) #12 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #13 _rootRunUnary (dart:async/zone.dart:1132:38) #14 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #15 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #16 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #17 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #18 Future._completeWithValue (dart:async/future_impl.dart:522:5) #19 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15) #20 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13) #21 RunCommand.usageValues (package:flutter_tools/src/commands/run.dart) #22 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #23 _rootRunUnary (dart:async/zone.dart:1132:38) #24 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #25 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #26 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #27 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #28 Future._completeWithValue (dart:async/future_impl.dart:522:5) #29 _AsyncAwaitCompleter.complete (dart:async-patch/async_patch.dart:30:15) #30 _completeOnAsyncReturn (dart:async-patch/async_patch.dart:288:13) #31 AndroidDevice.isLocalEmulator (package:flutter_tools/src/android/android_device.dart) #32 _asyncThenWrapperHelper.<anonymous closure> (dart:async-patch/async_patch.dart:71:64) #33 _rootRunUnary (dart:async/zone.dart:1132:38) #34 _CustomZone.runUnary (dart:async/zone.dart:1029:19) #35 _FutureListener.handleValue (dart:async/future_impl.dart:137:18) #36 Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:678:45) #37 Future._propagateToListeners (dart:async/future_impl.dart:707:32) #38 Future._completeWithValue (dart:async/future_impl.dart:522:5) #39 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:552:7) #40 _rootRun (dart:async/zone.dart:1124:13) #41 _CustomZone.run (dart:async/zone.dart:1021:19) #42 _CustomZone.runGuarded (dart:async/zone.dart:923:7) #43 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23) #44 _microtaskLoop (dart:async/schedule_microtask.dart:41:21) #45 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5) #46 _runPendingImmediateCallback (dart:isolate-patch/isolate_patch.dart:116:13) #47 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:173:5) ``` ## flutter doctor ``` [✓] Flutter (Channel stable, v1.9.1+hotfix.2, on Windows, locale en-US) • Flutter version 1.9.1+hotfix.2 at C:\src\flutter • Framework revision 2d2a1ffec9 (4 weeks ago), 2019-09-06 18:39:49 -0700 • Engine revision b863200c37 • Dart version 2.5.0 [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) • Android SDK at C:\Users\Ranjan Binwani\AppData\Local\Android\Sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-28, build-tools 28.0.3 • ANDROID_HOME = C:\Users\Ranjan Binwani\AppData\Local\Android\Sdk • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) • All Android licenses accepted. [✓] Android Studio (version 3.5) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin version 39.0.3 • Dart plugin version 191.8423 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) [✓] VS Code (version 1.38.1) • VS Code at C:\Users\Ranjan Binwani\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.4.1 [✓] Connected device (1 available) • SM A505F • R58M45A393B • android-arm64 • Android 9 (API 28) • No issues found! ``` ``` [√] Flutter (Channel stable, v1.9.1+hotfix.2, on Windows, locale en-US) • Flutter version 1.9.1+hotfix.2 at C:\src\flutter • Framework revision 2d2a1ffec9 (4 weeks ago), 2019-09-06 18:39:49 -0700 • Engine revision b863200c37 • Dart version 2.5.0 [√] Android toolchain - develop for Android devices (Android SDK version 28.0.3) • Android SDK at C:\Users\Ranjan Binwani\AppData\Local\Android\Sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-28, build-tools 28.0.3 • ANDROID_HOME = C:\Users\Ranjan Binwani\AppData\Local\Android\Sdk • Java binary at: C:\Program Files\Android\Android Studio\jre\bin\java • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) • All Android licenses accepted. [√] Android Studio (version 3.5) • Android Studio at C:\Program Files\Android\Android Studio • Flutter plugin version 39.0.3 • Dart plugin version 191.8423 • Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b03) [√] VS Code (version 1.38.1) • VS Code at C:\Users\Ranjan Binwani\AppData\Local\Programs\Microsoft VS Code • Flutter extension version 3.4.1 [√] Connected device (1 available) • SM A505F • R58M45A393B • android-arm64 • Android 9 (API 28) • No issues found! ```
c: crash,platform-android,tool,t: gradle,a: build,P2,team-android,triaged-android
low
Critical
501,033,397
flutter
Text layout without blocking the UI
There are a number of bugs that I've seen that boil down to this: if you have a large chunk of text, laying it out may be expensive enough where it blocks the UI for an unacceptable amount of time. One work around for this is to try to break up your text into smaller chunks, which works if you already have natural breaks (e.g. many small paragraphs laid out individually instead of all at once), but doesn't work as well if you just have a really long paragraph you want to layout and you don't know where the line breaks will fall. This may be a problem for, e.g. a reader for an academic journal that just has long paragraphs, or perhaps in some other languages where longer paragraphs may be more common. It is not currently possible to layout text in a separate isolate, as all dart:ui methods must run in the main isolate. We should explore either making it possible to run in another isolate, or creating some async text layout methods. Here are some example issues: #23718 #30604 #41536 (not as strongly related but may be helped by such an API) /cc @GaryQian @jason-simmons
framework,engine,c: performance,dependency: skia,a: typography,perf: speed,P2,team-engine,triaged-engine
low
Critical
501,033,898
flutter
[camera] Add macOS support
Since laptops commonly have cameras built in, this would be potentially useful. ~Blocked on #30717~
c: new feature,platform-mac,p: camera,package,a: desktop,P3,team-macos,triaged-macos
medium
Critical
501,033,937
flutter
[camera] Add Linux support
Since laptops commonly have cameras built in, this would be potentially useful. ~Blocked on https://github.com/flutter/flutter/issues/64188~
c: new feature,platform-linux,p: camera,package,a: desktop,P3,team-linux,triaged-linux
high
Critical
501,036,138
pytorch
torch::jit::script::Module has no zero_grad()
## 🐛 Bug I'm writing a C++ program that loads a module from disk and tries to work with it. Unlike `nn::Module`, it appears that `torch::jit::script::Module` has no `zero_grad()` method. This makes it impossible to do optimization. ## Environment - PyTorch Version (e.g., 1.0): Nightly build downloaded Sept. 29, 2019 - OS (e.g., Linux): Linux - How you installed PyTorch (`conda`, `pip`, source): Downloaded from https://download.pytorch.org/libtorch/nightly/cu101/libtorch-cxx11-abi-shared-with-deps-latest.zip - Build command you used (if compiling from source): n/a - Python version: n/a - CUDA/cuDNN version: n/a - GPU models and configuration: n/a - Any other relevant information: cc @suo
oncall: jit,triaged,jit-backlog
low
Critical
501,040,508
vscode
[json] allow $ref in confiuguration schemas
Issue Type: <b>Bug</b> Steps to Reproduce: 1. Create a ["definitions"](https://json-schema.org/understanding-json-schema/structuring.html) member for a JSON schema, and put a subschema there. 2. Attempt to refer to this subschema in `settings.json`. *** I'm in a folder called "json" with a subfolder called "schemas" with the schemas, and a subfolder called ".vscode" for the `settings.json`. Here is the definitions schema I am using: ``` { "$schema": "https://json-schema.org/draft/2019-09/schema", "type": "object", "definitions": { "items": { "type": "array", "items": { "$ref": "items.json#" }, "minItems": 1 } } } ``` If I just make `items.json` into an array and use `"url": "./schemas/items.json"` works fine, but that isn't very conducive to my current work case. &nbsp; So I tried using this: ``` "schema": { "type": "array", "items": { "$ref": "./schemas/items.json" } } ``` Got this error: "Problems loading reference 'vscode://schemas/custom/schemas/items.json': Request vscode/content failed with message: cannot open vscode://schemas/custom/schemas/items.json. Detail: resource is not available". &nbsp; Tried using this: `"url": "file:///C:/Users/BLATANT-DOXX-RISK/Source/Repos/json/schemas/types.json#/definitions/items"` And it just used `types.json`, ignored the definitions part, and looked for nothing but a blank object. &nbsp; Finally, I tried using this: `"url": "./schemas/types.json#/definitions/items"`. Got this error: "File not found (c:\Users\BLATANT-DOXX-RISK\Source\Repos\json\schemas\types.json#\definitions\items))". &nbsp; @aeschli came up a *lot* when looking through Github issues. *** VS Code version: Code 1.38.1 (b37e54c98e1a74ba89e03073e5a3761284e3ffb0, 2019-09-11T13:35:15.005Z) OS version: Windows_NT x64 10.0.18362 <details> <summary>System Info</summary> |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2592)| |GPU Status|2d_canvas: enabled<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: disabled_software<br>oop_rasterization: disabled_off<br>protected_video_decode: unavailable_off<br>rasterization: enabled<br>skia_deferred_display_list: disabled_off<br>skia_renderer: disabled_off<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>viz_display_compositor: disabled_off<br>webgl: enabled<br>webgl2: enabled| |Load (avg)|undefined| |Memory (System)|15.80GB (7.40GB free)| |Process Argv|C:\Users\ZACH-GAMING\Source\Repos\Cataclysm-DDA-Testing\data\json| |Screen Reader|no| |VM|0%| </details>Extensions: none
feature-request,json
low
Critical
501,053,406
flutter
Implement PlatformView support on macOS
We'll want to support embedding native views in a Flutter view, as is currently supported on mobile. Remaining tasks: * [X] Gesture support * [ ] Focus traversal * [ ] Accessibility tree merging
c: new feature,platform-mac,a: platform-views,a: desktop,P2,team-macos,triaged-macos
low
Critical
501,053,445
flutter
Implement PlatformView support on Linux
We'll want to support embedding native views in a Flutter view, as is currently supported on mobile. ~This is of course blocked on #30729 since until we have a view-based toolkit implementation for Linux, there's no concept of a "view" to embed.~
c: new feature,customer: crowd,platform-linux,a: desktop,P2,team-linux,triaged-linux
low
Critical
501,053,602
pytorch
Stop binding in-place methods to `torch.*`
## 🐛 Bug `torch.abs_` should not exist, but it does: ``` In [1]: import torch In [2]: torch.abs_ Out[2]: <function _VariableFunctions.abs_> ```
triaged,module: ux
low
Critical
501,055,120
flutter
[webview_flutter] Add Linux support
Once we definitively pick a toolkit, we'll need to evaluate web view options for that toolkit. Blocked on #41724
c: new feature,p: webview,platform-linux,package,a: desktop,P2,team-linux,triaged-linux
low
Critical
501,072,107
flutter
[google_maps_flutter] Performance drop when loading markers from bytes
Hi there, I'm building a map application in which I have A LOT of different marker designs to display (depending on the kind of POI). As I have to constantly renderer different marker on the map, I decided to optimize performance by loading all the marker design from assets file (using `BitmapDescriptor.fromImageAsset()` function) at the beginning and storing that in a ```dart Map<int, BitmapDescriptor> ``` It worked great, the performance was good. I then decided to generate my markers with code instead of loading them from image assets using the following code: ```dart Future<BitmapDescriptor> generatePostClusterMarker( String text, double sizeFactor, double pixelRatio) async { print(pixelRatio); Function wRatio = (input) => input * pixelRatio; final stopwatch = Stopwatch()..start(); final ui.PictureRecorder recorder = ui.PictureRecorder(); final Canvas canvas = Canvas(recorder); final TextSpan textSpan = TextSpan( style: TextStyle( color: Colors.pink, fontSize: wRatio(13 * sizeFactor), fontWeight: FontWeight.w900), text: text, ); final TextPainter textPainter = TextPainter( text: textSpan, textDirection: TextDirection.ltr, textAlign: TextAlign.center); textPainter.layout(); double diameter = 100 * sizeFactor; double blurSigma = wRatio(5); Size boxSize = Size(diameter, diameter); Size outputSize = Size(boxSize.width + 2 * blurSigma, boxSize.height + 2 * blurSigma); // paint shadow canvas.drawCircle( Offset(outputSize.width / 2, outputSize.height / 2), diameter / 2, Paint() ..color = Colors.black.withAlpha(50) ..maskFilter = MaskFilter.blur(BlurStyle.normal, blurSigma / 2)); // paint rounded box canvas.drawCircle( Offset(outputSize.width / 2, outputSize.height / 2), diameter / 2, Paint() ..color = Colors.white ..isAntiAlias = true ..style = PaintingStyle.fill ..filterQuality = FilterQuality.high); // paint text textPainter.paint( canvas, Offset((outputSize.width / 2) - (textPainter.size.width / 2), (outputSize.height / 2) - (textPainter.size.height / 2))); final ui.Picture picture = recorder.endRecording(); final ByteData pngBytes = await picture .toImage(outputSize.width.toInt(), outputSize.height.toInt()) .then((image) => image.toByteData(format: ui.ImageByteFormat.png)); print( 'Marker $text [${outputSize.width}x${outputSize.height}] generated in ${stopwatch.elapsed.inMilliseconds}'); picture.dispose(); return BitmapDescriptor.fromBytes(pngBytes.buffer.asUint8List()); } ``` again loading them all at the beginning and storing all the resulting `BitmapDescriptor` in a Map. But after doing that, the performance took a big hit, markers now take longer to render on the map and the whole thing is not fluid as it used to be when they were loaded from image assets. What I don't understand is that after the initial loading, the generated `Map<int, BitmapDescriptor>` should contain exactly the same thing (as the generated markers are exported with the same image size as the image assets), so why is performance worst? What really is the difference between this: ![Screen Shot 2019-10-01 at 8 13 47 pm](https://user-images.githubusercontent.com/14275989/65989694-7325fd00-e48a-11e9-9f90-317b8c7c82d5.png) and this: ![Screen Shot 2019-10-01 at 8 12 11 pm](https://user-images.githubusercontent.com/14275989/65989731-82a54600-e48a-11e9-8862-83d9851eed62.png) Am I missing something here? What else can I do to improve marker loading performance? Cheers! Theo
c: performance,p: maps,a: images,package,team-ecosystem,has reproducible steps,P2,found in release: 2.2,found in release: 2.4,triaged-ecosystem
low
Major
501,097,311
terminal
Alt-Gr issue (global one also affecting conhost, not just Windows Terminal)
# Environment `Windows 10 Education, Build 18362.19h1_release_svc_19h2_rel.190621-1123` Windows Terminal version (if applicable): Latest build from revision 0ce08aff , i.e. after commit 33361698 (but it didn't work either before). Any other software? -> Testing Mathematica 11.3 kernel, but also reproducible using Wolfram Engine (free DL at official website https://www.wolfram.com/engine/ ) # Steps to reproduce Just open `math` (or `wolframscript` when using Wolfram Engine) command and try to enter square brackets or other symbols that require **pressing either AltGr or Ctrl-Alt on french keyboard layout**. # Expected behavior The square brackets should appear.... # Actual behavior ... but they do not. See the screen-capture. The problem happens when using standard Conhost and also the OpenConsole.exe version. **On the contrary**, the square brackets are correctly transmitted to the `math` (or `wolframscript`) program **when using MinTTY from Git4Windows**. ![image](https://user-images.githubusercontent.com/1969829/65993323-44f7eb80-e491-11e9-8b16-4f419fa6406d.png)
Product-Conhost,Help Wanted,Area-Input,Issue-Bug
low
Minor
501,099,082
TypeScript
Remove useless `@‍typedef` comments in `declaration`
JS input ```js // @ts-check /** * @typedef {number} Foo * Docs for `Foo`. */ export class Bar { } ``` ```sh tsc --declaration --allowJs --emitDeclarationOnly foo.js ``` # Current Behavior ```ts /** * @typedef {number} Foo * Docs for `Foo`. */ export class Bar { } /** * Docs for `Foo`. */ export type Foo = number; ``` # Proposed Behavior ```ts export class Bar { } /** * Docs for `Foo`. */ export type Foo = number; ```
Bug,Effort: Difficult,Domain: Comment Emit,Domain: Declaration Emit
medium
Minor
501,134,718
flutter
FLUTTER_BUILD_MODE isn't compatible with plugins on macOS
Using FLUTTER_BUILD_MODE to override the framework type on macOS works with a trivial project, but the Podfile uses FLUTTER_FRAMEWORK_DIR which isn't affected by it. That means that if any plugins are added, the Podfile logic will add a reference into the build that points unconditionally to the "real" build mode, and once Xcode knows about two different copies of the framework (the Podfile-generated symlink and the copy in Flutter/ephemeral/) it may bundle either one. There's a note in the xcconfig-generation code about not adding FLUTTER_FRAMEWORK_DIR to module projects, which may be related to this happening on iOS. Assuming we want to support FLUTTER_BUILD_MODE for non-module projects though, this would likely affect iOS as well. STR: - Find/create a macOS project - Add a plugin to it that supports macOS - Open the project and add `FLUTTER_BUILD_MODE=debug` as a custom project setting - `flutter build macos && flutter build macos --debug` - Run `ls -l `find . -name FlutterMacOS` The expected behavior is that they are all the same, but in practice the version in .../Build/.../Release/ is often actually the release framework. If that happens, the app won't launch because it'll try to load a debug VM snapshot with a release-mode FlutterMacOS.framework, which doesn't support JIT.
tool,platform-mac,a: desktop,P3,team-macos,triaged-macos
low
Critical
501,138,583
TypeScript
Language service fails to provide type info
Looks like recursive type breaks type info on Win10. Ubuntu works fine. cc @ahejlsberg Language service outputs no info. See #33631. <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.4.0-dev.20191001 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** **Code** 1. use Win10. 1. clone https://github.com/falsandtru/securemark 1. run `npm i` 1. open src/util/toc.ts 1. wait for the language service to be ready 1. look at type info as follows ![image](https://user-images.githubusercontent.com/3143368/65999409-50223a00-e4d8-11e9-9352-eeaa2a3369fa.png) **Expected behavior:** Show correct info. **Actual behavior:** Show wrong info. **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> **Related Issues:**
Bug,Needs Investigation
low
Minor
501,144,765
go
x/tools/go/analysis/passes/atomicalign: panic when running against k8s.io/apiserver/pkg/server with GOOS/GOARCH linux/arm
### What version of Go are you using (`go version`)? <pre> $ go version 1.13 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GO111MODULE="" GOARCH="amd64" GOBIN="" GOCACHE="/Users/james/Library/Caches/go-build" GOENV="/Users/james/Library/Application Support/go/env" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GONOPROXY="" GONOSUMDB="" GOOS="darwin" GOPATH="/Users/james/go" GOPRIVATE="" GOPROXY="https://proxy.golang.org,direct" GOROOT="/usr/local/Cellar/go/1.13/libexec" GOSUMDB="sum.golang.org" GOTMPDIR="" GOTOOLDIR="/usr/local/Cellar/go/1.13/libexec/pkg/tool/darwin_amd64" GCCGO="gccgo" AR="ar" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="/Users/james/go/src/k8s.io/apiserver/go.mod" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/l9/dkb2dtzj0cj6my4hm0t1hf6m0000gn/T/go-build247262007=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? Attempting to run the `atomicalign` go vet plugin with `GOOS=linux` and `GOARCH=arm` against `k8s.io/apiserver/pkg/server` at ref bfa5e2e684ad413c22fd0dab55b2592af1ead049 causes a panic. This panic does not occur on `linux/amd64`, `darwin/amd64` or `linux/arm64`. Script to reproduce: ```bash #!/usr/bin/env bash tmp=$(mktemp -d) cd "$tmp" mkdir atomicalign cd atomicalign go mod init atomicalign cat <<EOF > main.go // The atomicalign command runs the atomicalign analyzer. package main import ( "golang.org/x/tools/go/analysis/passes/atomicalign" "golang.org/x/tools/go/analysis/multichecker" ) func main() { multichecker.Main(atomicalign.Analyzer) } EOF # Build atomicalign entrypoint binary go build . cd ../ git clone https://github.com/kubernetes/apiserver.git cd apiserver git checkout bfa5e2e684ad413c22fd0dab55b2592af1ead049 ## This command should pass # GOOS=linux GOARCH=arm64 ../atomicalign/atomicalign ./pkg/server ## This command fails GOOS=linux GOARCH=arm ../atomicalign/atomicalign ./pkg/server ``` ### What did you expect to see? The govet check pass consistently on all platforms ### What did you see instead? ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x1196742] goroutine 5848 [running]: go/types.(*Selection).Obj(...) /usr/local/Cellar/go/1.13/libexec/src/go/types/selection.go:56 golang.org/x/tools/go/analysis/passes/atomicalign.check64BitAlignment(0xc001825540, 0xc00029a5a6, 0x9, 0x13f20e0, 0xc000aa9f80) /Users/james/go/pkg/mod/golang.org/x/[email protected]/go/analysis/passes/atomicalign/atomicalign.go:87 +0xb2 golang.org/x/tools/go/analysis/passes/atomicalign.run.func1(0x13ed420, 0xc0001ecac0) /Users/james/go/pkg/mod/golang.org/x/[email protected]/go/analysis/passes/atomicalign/atomicalign.go:65 +0x172 golang.org/x/tools/go/ast/inspector.(*Inspector).Preorder(0xc001b9f0a0, 0xc000032ce8, 0x1, 0x1, 0xc0004becd8) /Users/james/go/pkg/mod/golang.org/x/[email protected]/go/ast/inspector/inspector.go:77 +0x9f golang.org/x/tools/go/analysis/passes/atomicalign.run(0xc001825540, 0xc001c3da90, 0x15ebac0, 0xc001b96ad8, 0x203000) /Users/james/go/pkg/mod/golang.org/x/[email protected]/go/analysis/passes/atomicalign/atomicalign.go:42 +0x158 golang.org/x/tools/go/analysis/internal/checker.(*action).execOnce(0xc00183d040) /Users/james/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:646 +0x6fa sync.(*Once).doSlow(0xc00183d040, 0xc000032f90) /usr/local/Cellar/go/1.13/libexec/src/sync/once.go:66 +0xe3 sync.(*Once).Do(...) /usr/local/Cellar/go/1.13/libexec/src/sync/once.go:57 golang.org/x/tools/go/analysis/internal/checker.(*action).exec(0xc00183d040) /Users/james/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:565 +0x60 golang.org/x/tools/go/analysis/internal/checker.execAll.func1(0xc00183d040) /Users/james/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:553 +0x34 created by golang.org/x/tools/go/analysis/internal/checker.execAll /Users/james/go/pkg/mod/golang.org/x/[email protected]/go/analysis/internal/checker/checker.go:559 +0x119 ``` cc @matloob @jayconrod
NeedsInvestigation,Tools,Analysis
low
Critical
501,167,155
storybook
Deprecation warnings in docs
I'm interested in marking components as deprecated to indicate that they should no longer be used, but the `jsdoc` attribute `@deprecated` is not being shown in the docs output in a way that is pronounced enough for readers. **Describe the solution you'd like** It would be awesome to have a subset of docs for styling and laying out potential `jsdoc` info **Describe alternatives you've considered** I've considered using the subtitle for this purpose, but it's preferable to keep these things in source/`jsdoc` **Are you able to assist bring the feature to reality?** Unsure, would need some pointers
feature request,addon: docs
low
Major
501,167,168
pytorch
Easier way to create tensors with names
## 🚀 Feature Right now, to create a tensor with names, we do ``` x = torch.randn(3, 3, 3, 3, names=('N', 'C', 'H', 'W')) ``` Typing the ' a lot is an inconvenience. It would be nice to explore one of the following APIs: 1. `x = torch.randn(N=3, C=3, H=3, W=3)` (Python >= 3.6) 2. `x = torch.randn(torch.dims(N=3, C=3, H=3, W=3))` (Python >= 3.6) 3. `x = torch.randn(3, 3, 3, 3, names='N C H W')` 4. `x = torch.randn(3, 3, 3, 3, names='NCHW')` (number of characters must match number of dims) ## Motivation Type less, feel happier.
triaged,enhancement,module: named tensor
medium
Major
501,201,279
vscode
[css] css.lint.hexColorLength seems to be now irrelevant
Issue still occurs in Insiders v1.39.0 <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: 1.39.0 - OS Version: macOS 10.14.6 Steps to Reproduce: 1. Set css.lint.hexColorLength to error or warning 2. Create a css file with a wrongly formatted color value ``` div { color: #ccc0003; } ``` Expected behavior: An error or warning as per the `css.lint.hexColorLength` setting. Actual behavior: A `css-propertyvaluexpected` error. The `css.lint.hexColorLength` setting seems to no longer be relevant. Does this issue occur when all extensions are disabled? Yes
bug,css-less-scss
low
Critical
501,224,422
flutter
ListView parameter to keep rendered children alive
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Use case There is a problem other developers and I have encountered: scrolling **up** in a `ListView` or `ScrollView` with async children (`FutureBuilder` or `StreamBuilder`) causes "jerking" or "snapping" to occur. This is because flutter disposes of child elements that are out of view. For my use case, I know my list will never be long enough to require this type of virtual scrolling. To prevent this "jerking" ux, I'd like to not dispose of rendered children. Others facing this issue: - https://stackoverflow.com/a/57984979/3969602 - https://github.com/flutter/flutter/issues/27611 - https://medium.com/saugo360/flutter-creating-a-listview-that-loads-one-page-at-a-time-c5c91b6fabd3#a358 Right now, it seems the solution to this problem is to have all the children implement the [`AutomaticKeepAliveClientMixin`](https://api.flutter.dev/flutter/widgets/AutomaticKeepAliveClientMixin-mixin.html), but it is unclear how to do this with stateless widgets. <!-- Please tell us the problem you are running into that led to you wanting a new feature. Is your feature request related to a problem? Please give a clear and concise description of what the problem is. Describe alternative solutions you've considered. Is there a package on pub.dev/flutter that already solves this? --> ## Proposal I'd like a simple fix parameter to pass into `ListView`, say `keepChildrenAlive`. This will modify the virtual scrolling behavior such that once child widgets have been rendered, the `ListView` will keep them around even once the user has scrolled past them. Keeping them around will prevent this "jerking" or "snapping" behavior when the user scrolls back up and will be a simple developer experience to implement even with stateless child widgets: ```dart Scaffold( body: ListView( keepChildrenAlive: true, // new parameter children: [ futureBuilderChild(bloc), displayError(bloc), streamBuilderChild(bloc), gridViewBuiltFromStream(bloc) ] ) ); ``` <!-- Briefly but precisely describe what you would like Flutter to be able to do. Consider attaching images showing what you are imagining. Does this have to be provided by Flutter directly, or can it be provided by a package on pub.dev/flutter? If so, maybe consider implementing and publishing such a package rather than filing a bug. --> ### Considerations `ListView` already has a parameter `bool addAutomaticKeepAlives = true`. We should make sure the difference between this and the new parameter is clear just from reading the variable names.
c: new feature,framework,f: scrolling,P3,team-framework,triaged-framework
low
Critical
501,268,099
neovim
flaky test: wait_spec.lua @ 53: wait() evaluates the condition on given interval
``` [ FAILED ] test/functional\eval\wait_spec.lua @ 53: wait() evaluates the condition on given interval test/functional\eval\wait_spec.lua:62: Expected objects to be the same. Passed in: (number) 0 Expected: (number) -1 stack traceback: test/functional\eval\wait_spec.lua:62: in function <test/functional\eval\wait_spec.lua:53> ``` https://ci.appveyor.com/project/neovim/neovim/builds/27813594/job/uiksgfa184xoy394#L8340
bug,test
low
Critical
501,292,969
flutter
Automatically migrate app project to use the new Android embedding
If an app is using the old embedding and a plugin is using the new embedding. Then, we could try to migrate the app to the new embedding automatically.
c: new feature,platform-android,tool,a: existing-apps,P3,team-android,triaged-android
low
Major
501,309,059
flutter
Draggable zone on a transformed element is wrong.
When having a transformed element inside a draggable zone, the draggable zone is not transformed. ## Steps to Reproduce Minimal example: ``` import 'dart:math' as math; import 'package:flutter/material.dart'; void main() => runApp(MyApp()); class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( primarySwatch: Colors.blue, ), home: new Align( alignment: FractionalOffset.center, child: Draggable( child: Transform.rotate( angle: math.pi / 4, child: Container( color: Colors.blue, height: 200.0, width: 400.0, ), ), feedback: Transform.rotate( angle: math.pi / 4, child: Container( color: Colors.red, height: 200.0, width: 400.0, ), ), ), ), ); } } ``` ![transformed](https://user-images.githubusercontent.com/5709489/66023171-a69b7280-e4f0-11e9-8598-5c04675c102f.jpeg) ## Logs <!-- Run `flutter analyze` and attach any output of that command below. If there are any analysis errors, try resolving them before filing this issue. --> ``` flutter analyze Analyzing transform_draggable... No issues found! (ran in 1.4s) ``` <!-- Finally, paste the output of running `flutter doctor -v` here. --> ``` flutter doctor -v [✓] Flutter (Channel beta, v1.9.1+hotfix.4, on Mac OS X 10.14.6 18G87, locale en-CH) • Flutter version 1.9.1+hotfix.4 at /Users/thomasfrick/development/flutter • Framework revision cc949a8e8b (4 days ago), 2019-09-27 15:04:59 -0700 • Engine revision b863200c37 • Dart version 2.5.0 [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) • Android SDK at /Users/thomasfrick/Library/Android/sdk • Android NDK location not configured (optional; useful for native profiling support) • Platform android-28, build-tools 28.0.3 • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01) • All Android licenses accepted. [✓] Xcode - develop for iOS and macOS (Xcode 10.3) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 10.3, Build version 10G8 • CocoaPods version 1.7.5 [✓] Android Studio (version 3.4) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 38.1.1 • Dart plugin version 183.6270 • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01) [✓] IntelliJ IDEA Ultimate Edition (version 2019.2.3) • IntelliJ at /Applications/IntelliJ IDEA.app • Flutter plugin version 39.0.5 • Dart plugin version 192.6817.14 [✓] Connected device (1 available) • iPhone Xʀ • 9D105B73-37E4-492B-B4F0-54DD490C2F15 • ios • com.apple.CoreSimulator.SimRuntime.iOS-12-4 (simulator) ```
framework,d: api docs,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-framework,triaged-framework
low
Critical
501,323,003
rust
Missed optimization: Vec::splice() is not zero-cost
To reproduce, compile the following two functions with, say, `-C opt-level=3` using, say, `rustc 1.38.0`: ```rust pub fn one(xs: &mut Vec<i32>) { xs.clear(); xs.push(1); } pub fn two(xs: &mut Vec<i32>) { xs.splice(.., Some(1)); } ``` [Godbolt](https://godbolt.org/z/CHJXuU) Since they are obviously equivalent, they should compile to comparable code. Instead, the `splice` version performs a lot of unnecessary work. ```asm example::one: push rbx mov rbx, rdi mov qword ptr [rdi + 16], 0 cmp qword ptr [rdi + 8], 0 je .LBB0_2 mov rax, qword ptr [rbx] mov dword ptr [rax], 1 add qword ptr [rbx + 16], 1 pop rbx ret .LBB0_2: mov edi, 4 mov esi, 4 call qword ptr [rip + __rust_alloc@GOTPCREL] test rax, rax je .LBB0_5 mov qword ptr [rbx], rax mov qword ptr [rbx + 8], 1 mov dword ptr [rax], 1 add qword ptr [rbx + 16], 1 pop rbx ret .LBB0_5: mov edi, 4 mov esi, 4 call qword ptr [rip + alloc::alloc::handle_alloc_error@GOTPCREL] ud2 example::two: push r15 push r14 push r13 push r12 push rbx sub rsp, 48 mov r15, rdi mov rax, qword ptr [rdi] mov rcx, qword ptr [rdi + 16] mov qword ptr [rdi + 16], 0 lea rbx, [rax + 4*rcx] mov qword ptr [rsp], rcx mov qword ptr [rsp + 8], 0 mov qword ptr [rsp + 16], rax mov qword ptr [rsp + 24], rbx mov qword ptr [rsp + 32], rdi movabs rdx, 4294967297 mov qword ptr [rsp + 40], rdx test rcx, rcx je .LBB1_1 mov rcx, rbx sub rcx, rax add rcx, -4 and rcx, -4 lea r12, [rcx + rax] add r12, 4 mov qword ptr [rsp + 16], r12 mov rcx, qword ptr [r15 + 8] test rcx, rcx je .LBB1_5 .LBB1_4: xor ecx, ecx mov rdx, qword ptr [rsp + 40] mov qword ptr [rsp + 40], 0 cmp edx, 1 je .LBB1_8 jmp .LBB1_10 .LBB1_1: mov r12, rax mov rcx, qword ptr [r15 + 8] test rcx, rcx jne .LBB1_4 .LBB1_5: add rcx, rcx mov r13d, 1 cmovne r13, rcx lea r14, [4*r13] mov esi, 4 mov rdi, r14 call qword ptr [rip + __rust_alloc@GOTPCREL] test rax, rax je .LBB1_17 mov qword ptr [r15], rax mov qword ptr [r15 + 8], r13 mov rcx, qword ptr [r15 + 16] mov rdx, qword ptr [rsp + 40] mov qword ptr [rsp + 40], 0 cmp edx, 1 jne .LBB1_10 .LBB1_8: shr rdx, 32 mov dword ptr [rax + 4*rcx], edx add rcx, 1 mov rdx, qword ptr [rsp + 40] mov qword ptr [rsp + 40], 0 cmp edx, 1 je .LBB1_8 mov r12, qword ptr [rsp + 16] mov rbx, qword ptr [rsp + 24] .LBB1_10: mov qword ptr [r15 + 16], rcx cmp r12, rbx je .LBB1_12 sub rbx, r12 add rbx, -4 and rbx, -4 lea rax, [rbx + r12] add rax, 4 mov qword ptr [rsp + 16], rax .LBB1_12: mov r15, qword ptr [rsp + 8] test r15, r15 je .LBB1_16 mov rax, qword ptr [rsp] mov r14, qword ptr [rsp + 32] mov rbx, qword ptr [r14 + 16] cmp rax, rbx je .LBB1_15 mov rcx, qword ptr [r14] lea rsi, [rcx + 4*rax] lea rdi, [rcx + 4*rbx] lea rdx, [4*r15] call qword ptr [rip + memmove@GOTPCREL] .LBB1_15: add rbx, r15 mov qword ptr [r14 + 16], rbx .LBB1_16: add rsp, 48 pop rbx pop r12 pop r13 pop r14 pop r15 ret .LBB1_17: mov esi, 4 mov rdi, r14 call qword ptr [rip + alloc::alloc::handle_alloc_error@GOTPCREL] ud2 ```
I-slow,A-collections,T-libs-api,T-compiler,C-bug
low
Critical
501,324,161
TypeScript
Function body is not checked against assertion signature
**TypeScript Version:** 3.7.0-dev.20191002 **Search Terms:** assertion signatures, asserts, not checked, unchecked, unsound **Code** ```ts function assertIsString(x: number | string): asserts x is string { } function test(x: number | string) { assertIsString(x); x.toUpperCase(); } test(4); ``` **Expected behavior:** This incorrect empty implementation of `assertIsString` should not type check, because there are execution paths through `assertIsString` that don’t narrow the type of `x` to `string` as the type of `assertIsString` should require. **Actual behavior:** No TS errors. Compiled JS code fails at runtime: `TypeError: x.toUpperCase is not a function`. **Playground Link:** Playground nightly isn’t new enough, but maybe it will be by the time you read this: [link](https://www.typescriptlang.org/play/?ts=Nightly#code/GYVwdgxgLglg9mABAQwM6oKYCcoElUDKUWMYA5gBQAeAXImCALYBG2iAPoqsaWQJR00mHKkRVEMUdxLlEAbwBQAXwULQkWAkRQM3anQYs2nabz7yFiKynTY8hHuWp8A3JetUAdFDgBVAA7+2ADCaBgUrsqqOnoALK5AA). **Related Issues:** <!-- Did you find other bugs that looked similar? -->
Suggestion,Needs Proposal
low
Critical
501,416,827
TypeScript
Allow overload signatures when writing class property initializers
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ --> ## Search Terms <!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily --> 1) typescript class bound function parameter overload 2) typescript class bound function overload 3) typescript class bound method overload 4) [typescript class bound arrow overload](https://stackoverflow.com/a/56109925) ## Suggestion <!-- A summary of what you'd like to see added or changed --> It would be nice if we could overload bound arrow function methods in a class without the need to specifically declare a constructor and bind methods in it. ## Use Cases <!-- What do you want to use this for? What shortcomings exist with current approaches? --> ## Examples <!-- Show how this would be used and what the behavior would be --> ```typescript // existing valid implementation // class `A` has method `a` bound to its instance in the constructor class A { constructor(){ this.a = this.a.bind(this); } a(a: string): string; a(a: string, b: string): string; a(a: string, b?: string): string { if(b) return a + b; return a; } } // suggested alternative implementation // class `B` declares a bound arrow function `a` and its overloads without the need for a ctor class B { a = (a: string): string; a = (a: string, b: string): string; a = (a: string, b?: string): string => { if(b) return a + b; return a; } } ``` ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Critical