id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
โ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
487,727,273 | godot | Controls intercept hidden mouse input events | **Godot version:** 3.2
**OS/device including version:** Linux
**Issue description:**
I have some free look camera code which uses Input.set_mouse_mode(Input.MOUSE_MODE_CAPTURED);
The problem is this would seemingly "lockup" and become unresponsive. I managed to find that the problem was that the Control elements I had on screen would take the input even when though the mouse was not visible!
**Steps to reproduce:**
Enable Input.set_mouse_mode(Input.MOUSE_MODE_CAPTURED); which will force the mouse to the centre of the viewport.
Then display a control on the centre of the screen that doesn't have mouse_filter set to MOUSE_FILTER_IGNORE
I have worked around the problem for now by ensuring I set mouse filter to MOUSE_FILTER_IGNORE when I go enable Input.set_mouse_mode(Input.MOUSE_MODE_CAPTURED); | bug,confirmed,topic:input | low | Major |
487,732,603 | pytorch | Assign torch.cuda.FloatTensor to List tensor | ## โ Questions and Help
I make custom cell and use eager execution on CUDA.
Then I meet segmentation fault to assign torach.cuda.FloatTensor to List tensor.
List Tensor is defined in __init(self)__ as;
```python
self.x = [torch.zeros(NUM_INPUT, device='cuda') for _ in range(NUM_HIDDEN)]
```
And the self.x is done as;
```python
for x, t in dataloader_train:
for time in range(TIME_STEPS):
for index in range(NUM_HIDDEN-1, 0, -1):
model.x[index] = model.x[index - 1]
model.x[0] = torch.cuda.FloatTensor(x[0][0][time])
```
Then output is
```python
Segmentation fault
```
How to avoid from the fault? | module: crash,module: cuda,triaged,has workaround | low | Minor |
487,733,187 | flutter | Driver over WebSocket instead of VMService | Internal: b/140286752
It would be interesting to provide a way to run Flutter Driver tests over a WebSocket connection instead of the VM Service protocol. That would allow it to be used in release builds, for example.
This would not be a feature that is enabled by default, and enabling it would have to involve some sort of out-of-band key exchange (with the driver extension generating part of the key) to ensure that only code that we expect to connect can connect. Or alternatively maybe the connection would be outgoing (you provide the endpoint to the driver extension). Or maybe you have to implement the endpoint logic and just hand in a socket or stream/sink pair. | a: tests,tool,t: flutter driver,customer: dream (g3),P3,team-tool,triaged-tool | low | Minor |
487,747,943 | pytorch | pytorch c++ api cannot call operator() on torch::nn::Sequential | ## ๐ Bug
pytorch c++ api cannot call operator() on torch::nn::Sequential.
```cpp
class Net : torch::nn::Module {
public:
Net(int64_t in_size, int64_t out_size) {
linears = register_module("linears", torch::nn::Sequential(
torch::nn::Linear(in_size, out_size));
}
torch::Tensor forward(const torch::Tensor& input) {
return linears(input);
// return linears->forward(input) is okay but ModuleHolder should have implemented the operator() function.
}
torch::nn::Sequential linears;
};
```
The error is "no viable conversion from torch::detail::return_type_of_forward_t to function return type torch::Tensor"
## To Reproduce
Steps to reproduce the behavior:
invoke operator() on torch::nn::Sequential
## Expected behavior
the same as torch::nn::Suqnential::forward
## Environment
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).
You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```
- PyTorch Version (e.g., 1.0): 1.2
- OS (e.g., Linux): linux
- How you installed PyTorch (`conda`, `pip`, source): conda
- Build command you used (if compiling from source):
- Python version: 3.6
- CUDA/cuDNN version: /
- GPU models and configuration: /
- Any other relevant information: /
| module: cpp,module: nn,triaged | low | Critical |
487,763,690 | godot | Light 2D masking changes brightness on sprites with transparency [GLES3 only] | **Godot version:**
3.1
**OS/device including version:**
Ubuntu 19.04
**Issue description:**
When using a Light2D as a mask on a sprite with transparency it alters it's colour slightly.
**Steps to reproduce:**
1. Add a sprite with transparency (or a opaque sprite and modulate the alpha by .5)
2. Add a Light2D in mask mode
3. Move the Light2D on and then of the sprite.
**Example Project:**
[Wrong masking.zip](https://github.com/godotengine/godot/files/3562431/Wrong.masking.zip)
| bug,topic:rendering,confirmed,topic:2d | low | Minor |
487,764,680 | storybook | Addon-docs: Load prop table from file | Parsing prop tables for typescript project takes a long time. react-docgen-typescript-loader parses all the prop table on every storybook load.
However most times the prop tables very rarely change. A faster solution would be to generate prop table files only once in a while when the props of the components actually change.
If possible can you allow for loading prop tables from external files. By default, I am naming the external .json files for an example story ComponentName.stories.tsx as ComponentName.json
example external json file generated using directly "react-docgen-typescript":
https://github.com/atanasster/grommet-controls/blob/master/src/components/ColorInput/doc/ColorInput.json
my current (temporary) solution to use a webpack plugin to load the prop tables from files:
https://github.com/atanasster/grommet-controls/blob/master/.storybook/webpack.config.js
my current script to generate external json prop tables:
https://github.com/atanasster/grommet-controls/blob/master/tools/generate-docs.js
If the feature request is accepted I can clean up my script and release it for other people to also use if they have typescript docgen prop tables. | feature request,addon: docs,block: props | low | Major |
487,765,986 | storybook | Addon-docs: Expand/collapse prop table entries by their 'parent' | the typescript prop tables can often times get very long with components that are accepting props from many interfaces. Example:
```
export type IDropInputProps = IDropInputOwnProps & TextInputProps & JSX.IntrinsicElements['input'];
```
the prop table in this case is really long:
https://atanasster.github.io/grommet-controls/?path=/docs/controls-input-dropinput--main
The example prop table json file:
https://github.com/atanasster/grommet-controls/blob/master/src/components/DropInput/doc/DropInput.json
A screenshot how the parent interface name can be collapsed. By default suggestion is to have expanded only the first interface name:
| feature request,typescript,addon: docs,block: props | medium | Critical |
487,766,421 | storybook | Addon-docs: Proposal to link interfaces | In typescript projects, some (legacy) components accept large interfaces into a single prop name. In this case the prop table is really not very helpful as it shows only the top level property. I understand this is not a top priority, but just to keep it on file, can we have an option to 'link' embedded properties.
example of a prop table https://atanasster.github.io/grommet-controls/?path=/docs/charts-chartjs-barchart--main
it has only two props:
```
options: IChartjsOptions;
data:IChartjsData;
```
It would be more helpful to be able to link or expand the `IChartjsOptions` interface to actually see the available properties.
| feature request,addon: docs | medium | Major |
487,767,271 | pytorch | [dataloader] Problem in exception reraise mechanism | For some reason my implementation of `dataset.__getitem__` is throwing a `subprocess.CalledProcessError` (a problem in my dataset loading code).
If I pass to DataLoader `num_workers > 0`, I get the following - probably some issues with exception reraising (missing exception args). This is rather un-informative, since even exception type is missing.
```
Traceback (most recent call last):
File "train.py", line 255, in <module>
traineval(parser.parse_args())
File "train.py", line 148, in traineval
for batch_idx, (inputs, targets, filenames, input_percentages, target_lengths) in enumerate(train_data_loader):
File "/miniconda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 819, in __next__
return self._process_data(data)
File "/miniconda/lib/python3.7/site-packages/torch/utils/data/dataloader.py", line 846, in _process_data
data.reraise()
File "/miniconda/lib/python3.7/site-packages/torch/_utils.py", line 369, in reraise
raise self.exc_type(msg)
TypeError: __init__() missing 1 required positional argument: 'cmd'
```
My PyTorch version is updated a week ago to a nightly.
@SsnL
cc @SsnL | module: dataloader,triaged | low | Critical |
487,776,566 | flutter | Flutter Test Driver: find.bySemanticsLabel missing documentation | I'm having difficulties understanding how `find.bySemanticsLabel` works inside an `integration test`.
There doesn't seem to be one single example inside the documentation.
Following test is the easiest example which it think should work, however it fails.
What am I missing?
**simple_semantics_test.dart**
```
import 'package:flutter_driver/flutter_driver.dart';
import 'package:test/test.dart';
void main() {
group("bySemanticsLabel test", () {
FlutterDriver driver;
setUpAll(() async {
driver = await FlutterDriver.connect();
});
test("click by semantics", () async {
await driver.tap(find.bySemanticsLabel(RegExp('testLabel')));
//Do note that I tried `await driver.tap(find.bySemanticsLabel("testLabel")` too.
});
tearDownAll(() async {
await driver.close();
});
});
}
```
**simple_semantics.dart**
```
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:flutter_driver/driver_extension.dart';
void main() {
enableFlutterDriverExtension();
runApp(MaterialApp(
home: Scaffold(
body: Container(
child: Center(
child: Semantics(
label: "testLabel",
child: FlatButton(
child: Text("rguhergeugr"),
onPressed: () {},
),
),
),
),
),
));
}
```
Which fails with the following error message
```
flutter drive --target=test_driver/simple_semantics.dart
Using device Android SDK built for x86.
Starting application: test_driver/simple_semantics.dart
Initializing gradle... 0.6s
Resolving dependencies... 1.8s
Installing build/app/outputs/apk/app.apk... 3.0s
Running Gradle task 'assembleDevDebug'...
Running Gradle task 'assembleDevDebug'... Done 4.5s
Built build/app/outputs/apk/dev/debug/app-dev-debug.apk.
Installing build/app/outputs/apk/app.apk... 2.8s
I/flutter (10928): Observatory listening on http://127.0.0.1:44027/2b8-xlSds4o=/
00:00 +0: Semantics Screen (setUpAll)
[info ] FlutterDriver: Connecting to Flutter application at http://127.0.0.1:52142/2b8-xlSds4o=/
[trace] FlutterDriver: Isolate found with number: 898244776
[trace] FlutterDriver: Isolate is not paused. Assuming application is ready.
[info ] FlutterDriver: Connected to Flutter application.
00:00 +0: Semantics Screen click by semantics
[warning] FlutterDriver: tap message is taking a long time to complete...
00:30 +0 -1: Semantics Screen click by semantics [E]
TimeoutException after 0:00:30.000000: Test timed out after 30 seconds.
package:test_api/src/backend/invoker.dart 324:28 Invoker._handleError.<fn>
dart:async/zone.dart 1120:38 _rootRun
dart:async/zone.dart 1021:19 _CustomZone.run
package:test_api/src/backend/invoker.dart 322:10 Invoker._handleError
package:test_api/src/backend/invoker.dart 275:9 Invoker.heartbeat.<fn>.<fn>
dart:async/zone.dart 1124:13 _rootRun
dart:async/zone.dart 1021:19 _CustomZone.run
package:test_api/src/backend/invoker.dart 273:38 Invoker.heartbeat.<fn>
package:stack_trace/src/stack_zone_specification.dart 209:15 StackZoneSpecification._run
package:stack_trace/src/stack_zone_specification.dart 119:48 StackZoneSpecification._registerCallback.<fn>
dart:async/zone.dart 1124:13 _rootRun
dart:async/zone.dart 1021:19 _CustomZone.run
dart:async/zone.dart 947:23 _CustomZone.bindCallback.<fn>
dart:async-patch/timer_patch.dart 21:15 Timer._createTimer.<fn>
dart:isolate-patch/timer_impl.dart 382:19 _Timer._runTimers
dart:isolate-patch/timer_impl.dart 416:5 _Timer._handleMessage
dart:isolate-patch/isolate_patch.dart 172:12 _RawReceivePortImpl._handleMessage
===== asynchronous gap ===========================
dart:async/zone.dart 1045:19 _CustomZone.registerCallback
dart:async/zone.dart 946:22 _CustomZone.bindCallback
dart:async/zone.dart 1191:21 _rootCreateTimer
dart:async/zone.dart 1088:19 _CustomZone.createTimer
package:test_api/src/backend/invoker.dart 272:34 Invoker.heartbeat
package:test_api/src/backend/invoker.dart 235:5 Invoker.waitForOutstandingCallbacks
package:test_api/src/backend/declarer.dart 166:33 Declarer.test.<fn>.<fn>
dart:async/zone.dart 1124:13 _rootRun
dart:async/zone.dart 1021:19 _CustomZone.run
dart:async/zone.dart 1516:10 _runZoned
dart:async/zone.dart 1463:12 runZoned
package:test_api/src/backend/declarer.dart 165:13 Declarer.test.<fn>
===== asynchronous gap ===========================
dart:async/zone.dart 1045:19 _CustomZone.registerCallback
dart:async/zone.dart 962:22 _CustomZone.bindCallbackGuarded
dart:async/timer.dart 52:45 new Timer
dart:async/timer.dart 87:9 Timer.run
dart:async/future.dart 174:11 new Future
package:test_api/src/backend/invoker.dart 391:21 Invoker._onRun.<fn>.<fn>.<fn>
00:30 +0 -1: Semantics Screen (tearDownAll)
00:30 +0 -1: Semantics Screen click by semantics [E]
DriverError: Failed to fulfill Tap due to remote error
Original error: Bad state: The client closed with pending request "ext.flutter.driver".
Original stack trace:
#0 new Client.withoutJson.<anonymous closure> (package:json_rpc_2/src/client.dart:70:24)
#1 StackZoneSpecification._run (package:stack_trace/src/stack_zone_specification.dart:209:15)
#2 StackZoneSpecification._registerCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:119:48)
#3 _rootRun (dart:async/zone.dart:1120:38)
#4 _CustomZone.run (dart:async/zone.dart:1021:19)
#5 _FutureListener.handleWhenComplete (dart:async/future_impl.dart:150:18)
#6 Future._propagateToListeners.handleWhenCompleteCallback (dart:async/future_impl.dart:609:39)
#7 Future._propagateToListeners (dart:async/future_impl.dart:665:37)
#8 Future._propagateToListeners (dart:async/future_impl.dart:566:9)
#9 Future._completeWithValue (dart:async/future_impl.dart:483:5)
#10 Future._asyncComplete.<anonymous closure> (dart:async/future_impl.dart:513:7)
#11 StackZoneSpecification._run (package:stack_trace/src/stack_zone_specification.dart:209:15)
#12 StackZoneSpecification._registerCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:119:48)
#13 _rootRun (dart:async/zone.dart:1124:13)
#14 _CustomZone.run (dart:async/zone.dart:1021:19)
#15 _CustomZone.runGuarded (dart:async/zone.dart:923:7)
#16 _CustomZone.bindCallbackGuarded.<anonymous closure> (dart:async/zone.dart:963:23)
#17 _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#18 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#19 _Timer._runTimers (dart:isolate-patch/timer_impl.dart:391:30)
#20 _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
#21 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
package:flutter_driver/src/driver/driver.dart 426:7 FlutterDriver._sendCommand
===== asynchronous gap ===========================
dart:async/future_impl.dart 22:43 _Completer.completeError
dart:async-patch/async_patch.dart 40:18 _AsyncAwaitCompleter.completeError
package:flutter_driver/src/driver/driver.dart FlutterDriver._sendCommand
===== asynchronous gap ===========================
dart:async/zone.dart 1062:19 _CustomZone.registerBinaryCallback
dart:async-patch/async_patch.dart 86:23 _asyncErrorWrapperHelper
package:flutter_driver/src/driver/driver.dart FlutterDriver._sendCommand
package:flutter_driver/src/driver/driver.dart 459:11 FlutterDriver.tap
===== asynchronous gap ===========================
dart:async/zone.dart 1053:19 _CustomZone.registerUnaryCallback
dart:async-patch/async_patch.dart 77:23 _asyncThenWrapperHelper
package:test_api/src/backend/declarer.dart Declarer.test.<fn>.<fn>.<fn>
package:test_api/src/backend/invoker.dart 242:15 Invoker.waitForOutstandingCallbacks.<fn>
===== asynchronous gap ===========================
dart:async/zone.dart 1045:19 _CustomZone.registerCallback
dart:async/zone.dart 962:22 _CustomZone.bindCallbackGuarded
dart:async/timer.dart 52:45 new Timer
dart:async/timer.dart 87:9 Timer.run
dart:async/future.dart 174:11 new Future
package:test_api/src/backend/invoker.dart 391:21 Invoker._onRun.<fn>.<fn>.<fn>
00:30 +0 -1: Some tests failed.
Unhandled exception:
Dummy exception to set exit code.
#0 _rootHandleUncaughtError.<anonymous closure> (dart:async/zone.dart:1112:29)
#1 _microtaskLoop (dart:async/schedule_microtask.dart:41:21)
#2 _startMicrotaskLoop (dart:async/schedule_microtask.dart:50:5)
#3 _Timer._runTimers (dart:isolate-patch/timer_impl.dart:391:30)
#4 _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:416:5)
#5 _RawReceivePortImpl._handleMessage (dart:isolate-patch/isolate_patch.dart:172:12)
Stopping application instance.
Driver tests failed: 255
```
| tool,d: examples,t: flutter driver,P3,team-tool,triaged-tool | low | Critical |
487,789,944 | angular | Moving routing animation into parent breaks child sequence order | <!--๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
Oh hi there! ๐
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
๐
-->
# ๐ bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- โ๏ธedit: --> The issue is caused by package @angular/animations
### Is this a regression?
<!-- Did this behavior use to work in the previous version? -->
<!-- โ๏ธ--> Yes, the previous version in which this bug was not present was: Unsure
### Description
<!-- โ๏ธ--> A clear and concise description of the problem...
When moving a routing animation into a parent animation that calls `animateChild()`, child animations are not sequenced anymore.
## ๐ฌ Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2
-->
<!-- โ๏ธ-->
Working version :
https://stackblitz.com/github/loicmarie/angular-nested-routing-animation-bug/tree/working
Not working version (with a div wrapper and a parent trigger)
https://stackblitz.com/github/loicmarie/angular-nested-routing-animation-bug/tree/notWorking
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## ๐ฅ Exception or Error
<pre><code>
<!-- If the issue is accompanied by an exception or an error, please share it below: -->
<!-- โ๏ธ-->
</code></pre>
## ๐ Your Environment
**Angular Version:**
<pre><code>
<!-- run `ng version` and paste output below -->
<!-- โ๏ธ-->Angular CLI: 8.3.2
Node: 10.15.3
OS: linux x64
Angular: 8.2.4
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.803.2
@angular-devkit/build-angular 0.803.2
@angular-devkit/build-optimizer 0.803.2
@angular-devkit/build-webpack 0.803.2
@angular-devkit/core 8.3.2
@angular-devkit/schematics 8.3.2
@angular/cdk 8.1.4
@angular/cli 8.3.2
@angular/flex-layout 8.0.0-beta.27
@angular/material 8.1.4
@ngtools/webpack 8.3.2
@schematics/angular 8.3.2
@schematics/update 0.803.2
rxjs 6.5.2
typescript 3.5.3
webpack 4.39.2
</code></pre>
**Anything else relevant?**
<!-- โ๏ธIs this a browser specific issue? If so, please specify the browser and version. -->
In the example, I used flex-layout but the error is still here when using backgroundColor or whatever.
<!-- โ๏ธDo any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->
| type: bug/fix,area: animations,freq2: medium,P3 | low | Critical |
487,800,181 | node | Uncaught error stack trace is misformatted on some platforms | * **Version**: v12.9.1
* **Platform**: Windows 8.1 (6.3 Build 9600)
* **Subsystem**: console
Some consoles do not convert ANSI escape sequences to colors, rather display them directly to the stdout. On those consoles, libuv emulates colors by intercepting stdout stream and calling corresponding Windows API functions for setting console colors, if needed.
PR https://github.com/nodejs/node/pull/27052 introduced stack trace highlighting, but it bypasses libuv and prints the raw string. It works on Linux and on some Windows console emulators that support ANSI colors, but does not work on most Windows consoles, including the default console (cmd.exe) on Windows 8.1
As pointed out in https://github.com/nodejs/node/pull/28308#issuecomment-503790444, a possible fix is to modify `PrintErrorString()` to use `uv_write`. However, I tried different approaches, but can't get all tests to pass. I'm opening this thread so that we at least have a tracking issue for this old bug. | tty,errors | low | Critical |
487,805,284 | vscode | Convert inline comment to block comment, and vice-versa | Issue Type: <b>Feature Request</b>
I have several JS lines commented out, like so:
```js
// This
// is
// a
// test
```
When I select these lines, there should be a VSC command to convert the inline comments to one block comment. So that the result is:
```js
/**
* This
* is
* a
* test
*/
```
And then the opposite can be allowed, too, so that when I select the block comment, I can run a command to convert them to several inline comments.
VS Code version: Code 1.37.1 (f06011ac164ae4dc8e753a3fe7f9549844d15e35, 2019-08-15T16:16:34.800Z)
OS version: Darwin x64 18.7.0
<!-- generated by issue reporter --> | feature-request,editor-comments | low | Major |
487,816,359 | go | x/mobile: gobind failed: exit status 2 | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.9 linux/amd64
</pre>
### What version of Gomobile are you using (`gomobile version`)?
<pre>
$ gomobile version
gomobile version +c6da959 Fri Aug 30 20:13:51 2019 +0000 (android); androidSDK=/home/jason/Android/Sdk/platforms/android-29
</pre>
### Does this issue reproduce with the latest release?
yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/jason/.cache/go-build"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOOS="linux"
GOPATH="/home/jason/go"
GOPROXY=""
GORACE=""
GOROOT="/usr/local/go"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GCCGO="gccgo"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build025736357=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
```
gomobile bind -target android -o v2.aar github.com/v2ray/v2ray-core
```
### What did you expect to see?
nothing (build success)
### What did you see instead?
<details><summary>Error</summary><br><pre>gomobile: /usr/local/go/bin/go build -buildmode=c-shared -o=/tmp/gomobile-work-571427279/android/src/main/jniLibs/armeabi-v7a/libgojni.so gobind failed: exit status 2
# gobind
core_android.c:380:1: error: redefinition of 'Java_core_InboundHandlerConfig_getTag'
core_android.c:306:1: note: previous definition is here
core_android.c:554:1: error: redefinition of 'Java_core_OutboundHandlerConfig_getTag'
core_android.c:480:1: note: previous definition is here
core_android.c:573:1: error: redefinition of 'Java_core_OutboundHandlerConfig_getExpire'
core_android.c:468:1: note: previous definition is here
core_android.c:588:1: error: redefinition of 'Java_core_OutboundHandlerConfig_getComment'
core_android.c:460:1: note: previous definition is here</pre></details>
| NeedsInvestigation,mobile | low | Critical |
487,834,885 | TypeScript | Continuing #17110 - Given generic `W extends { x: A }` should be able to use `keyof W['x']` to index w.x | <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** `[email protected]`
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** tagged disjoint union generic
This issue stems from a question I asked on [StackOverflow](https://stackoverflow.com/questions/56718622/generic-function-operating-on-tagged-disjoint-union-why-is-type-specification?noredirect=1#comment100017317_56718622) that @jcalz generously researched for me. I adapted his example to be a closer parallel to the example given in #17110.
**Code**
```ts
interface A { a: string; }
interface W {
x: A
}
function foo<W1 extends W>(w: W1, k: keyof W1['x']) {
w.x[k]; // Type 'keyof W1["x"]' cannot be used to index type 'A'.
const x: W1['x'] = w.x; // Okay
x[k] // Okay
}
```
**Expected behavior:**
Same as #17110. However, unlike #17110, `W['x']` is only `A` instead of `A | B | undefined`. The [explanation given](https://github.com/microsoft/TypeScript/issues/17110#issuecomment-459911913) as to why #17110 was not a bug was:
> The constraint of `keyof W1["x"]` is `keyof (A | B)`, which simplifies to `keyof A & keyof B`, which is `never` (because there are no common properties).
However, here `keyof W1['x']` is `keyof A` which is _not_ `never`.
**Actual behavior:**
Same as #17110.
**Playground Link:** http://www.typescriptlang.org/play/#code/JYOwLgpgTgZghgYwgAgILIN7LgLmQZzClAHMBuZAXwChrRJZEUB1Ta5D5ADz1WpuowAriARhgAexDIYEiQB5mARmQQukEABN8yZgD4AFAHc8ygDTIA1nksQAnhJi6lAbQDkXNwF0AlGw5GAHRcLpZeFAD0EcgAKnYADihutg5Oyi4ARFwZXm7ICHAgIBJgyABGKEL4EJrIYBLIoJpqdQlJqG6BtBwIUoTcpq4e3sgAvMhBXJHRAPKWcHbs3KFeyFHIcwv8QA
**Related Issues:** #17110
| Suggestion,Experimentation Needed | low | Critical |
487,851,436 | flutter | [in_app_purchase][ios] - Listener not working for items when a user is trying to re-purchase a not consumed item | Hi, I am having problems with items that have not been consumed on iOS.
I'm not sure if the behavior is intended but my issue is as following:
1) I purchase a consumable item
2) I fake that an error happened and the item failed to be consumed
3) When I try to make a purchase for the same item I get a message from Apple that the item will be restored for free, but there is no new data in InAppPurchaseConnection.instance.purchaseUpdatedStream
I do have a solution in mind, which is to save the PurchaseDetails and re-try to consume it at a later time, but I am not 100% sure that's how this is intended to work.
## Flutter doctor
```
[โ] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
โข Android SDK at /Users/baloo/Library/Android/sdk
โข Android NDK location not configured (optional; useful for native profiling support)
โข Platform android-28, build-tools 28.0.3
โข Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
โข Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
โข All Android licenses accepted.
[โ] Xcode - develop for iOS and macOS (Xcode 10.3)
โข Xcode at /Applications/Xcode.app/Contents/Developer
โข Xcode 10.3, Build version 10G8
โข CocoaPods version 1.7.2
[โ] Android Studio (version 3.4)
โข Android Studio at /Applications/Android Studio.app/Contents
โข Flutter plugin version 36.1.1
โข Dart plugin version 183.6270
โข Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[โ] VS Code (version 1.37.1)
โข VS Code at /Applications/Visual Studio Code.app/Contents
โข Flutter extension version 3.3.0
``` | platform-ios,p: in_app_purchase,package,P2,team-ios,triaged-ios | low | Critical |
487,856,079 | godot | TabContainer ignores `label_valign_fg`, `hseparation`, `label_valign_bg` and `top_margin` constants (fixed in `master`) | **Godot version:** 979e772
**Issue description:** After briefing through the source code for [`TabContainer`](https://github.com/godotengine/godot/blob/master/scene/gui/tab_container.cpp) I noticed that the `top_margin` is never taken into account. While in the editor I also noticed that the changing the custom constant didn't have any influence on the positioning.
_The selected property_
**Edit:** Additionally `label_valign_fg` and `label_valign_bg` aren't used in the code | bug,confirmed,topic:gui | low | Major |
487,859,064 | bitcoin | ThreadDNSAddressSeed hangs on sk_wait_data and doesn't stop on exit | This is a continue of previously opened issue [Unable to stop bitcoin-qt. ThreadDNSAddressSeed hangs. #16642](https://github.com/bitcoin/bitcoin/issues/16642#issue-481935673). Now hardware problems are sorted out. Single consumer-grade HDD on USB3.0 is changed for RAID1 of HGST Ultrastarยฎ 7K4000 on SATA. Database was changed for know working archived version. Except already repaired HDD problem, hardware is stable, none failures or glitches was found for several month of operation under different operating systems.
The problem is sometimes Bitcoin Core, particularly bitcoin-qt, unable to finish it's operation on close.
I'm expecting normal bitcoin-qt application finishing after clicking "close" sign at top right corner of main GUI window.
Actual behavior: after several successful application shutdowns, the application remains to hang with a message "Bitcoin Core is shutting down... Don't shut down the computer until this window dissapears."
Natively compiled 01 Sep 2019 for arm-linux-gnueabihf, master branch.
Debug output:
```
2019-09-01T07:44:54Z GUI: requestShutdown : Requesting shutdown
2019-09-01T07:44:54Z GUI: shutdown : Running Shutdown in thread
2019-09-01T07:44:54Z Interrupting HTTP server
2019-09-01T07:44:54Z Interrupting HTTP RPC server
2019-09-01T07:44:54Z Interrupting RPC
2019-09-01T07:44:54Z addcon thread exit
2019-09-01T07:44:54Z opencon thread exit
2019-09-01T07:44:54Z msghand thread exit
2019-09-01T07:44:54Z Shutdown: In progress...
2019-09-01T07:44:54Z Stopping HTTP RPC server
2019-09-01T07:44:54Z Stopping RPC
2019-09-01T07:44:54Z Stopping HTTP server
2019-09-01T07:44:54Z Stopped HTTP server
2019-09-01T07:44:54Z net thread exit
2019-09-01T07:44:54Z BerkeleyEnvironment::Flush: [/bdb] Flush(false)
2019-09-01T07:44:54Z BerkeleyEnvironment::Flush: Flushing wallet.dat (refcount = 0)...
2019-09-01T07:44:55Z BerkeleyEnvironment::Flush: wallet.dat checkpoint
2019-09-01T07:44:55Z BerkeleyEnvironment::Flush: wallet.dat detach
2019-09-01T07:44:55Z BerkeleyEnvironment::Flush: wallet.dat closed
2019-09-01T07:44:55Z BerkeleyEnvironment::Flush: Flush(false) took 271ms
2019-09-01T07:58:54Z Flushed 64452 addresses to peers.dat 1854ms
2019-09-01T08:13:56Z Flushed 64452 addresses to peers.dat 2216ms
2019-09-01T08:22:11Z Potential stale tip detected, will try using extra outbound peer (last tip update: 2245 seconds ago)
2019-09-01T08:22:11Z net: setting try another outbound peer=true
2019-09-01T08:28:58Z Flushed 64452 addresses to peers.dat 1895ms
```
Threads after shutdown request:
```
rock@Debian-Desktop:~$ ps -eLl
...
F S UID PID PPID LWP C PRI NI ADDR SZ WCHAN TTY TIME CMD
0 S 1000 3094 1336 3094 4 80 0 - 139807 poll_s pts/0 00:02:43 bitcoin-main
1 S 1000 3094 1336 3095 0 80 0 - 139807 poll_s pts/0 00:00:01 QXcbEventReader
1 S 1000 3094 1336 3097 0 80 0 - 139807 futex_ pts/0 00:00:00 mali-mem-purge
1 S 1000 3094 1336 3098 0 80 0 - 139807 futex_ pts/0 00:00:00 mali-utility-wo
1 S 1000 3094 1336 3099 0 80 0 - 139807 futex_ pts/0 00:00:00 mali-utility-wo
1 S 1000 3094 1336 3100 0 80 0 - 139807 futex_ pts/0 00:00:00 mali-utility-wo
1 S 1000 3094 1336 3101 0 80 0 - 139807 futex_ pts/0 00:00:00 mali-utility-wo
1 S 1000 3094 1336 3102 0 80 0 - 139807 futex_ pts/0 00:00:00 mali-utility-wo
1 S 1000 3094 1336 3103 0 80 0 - 139807 futex_ pts/0 00:00:00 mali-utility-wo
1 S 1000 3094 1336 3104 0 80 0 - 139807 poll_s pts/0 00:00:00 mali-cmar-backe
1 S 1000 3094 1336 3105 0 80 0 - 139807 futex_ pts/0 00:00:00 mali-hist-dump
1 S 1000 3094 1336 3106 0 80 0 - 139807 poll_s pts/0 00:00:00 QDBusConnection
1 S 1000 3094 1336 3112 3 80 0 - 139807 futex_ pts/0 00:01:54 bitcoin-shutoff
1 S 1000 3094 1336 3117 0 80 0 - 139807 futex_ pts/0 00:00:26 bitcoin-scriptc
1 S 1000 3094 1336 3118 0 80 0 - 139807 futex_ pts/0 00:00:17 bitcoin-schedul
1 S 1000 3094 1336 3122 17 80 0 - 139807 futex_ pts/0 00:09:23 bitcoin-qt-init
1 S 1000 3094 1336 3151 0 80 0 - 139807 sk_wai pts/0 00:00:00 bitcoin-dnsseed
1 S 1000 3094 1336 3156 0 80 0 - 139807 poll_s pts/0 00:00:00 QThread
1 S 1000 3094 1336 3157 0 80 0 - 139807 poll_s pts/0 00:00:00 Qt bearer threa
...
```
The issue is reproducing quite reliable. With 0.18 versions on different computers, different builds I had this problem at least three times even after DB rescan. For some time the Core works normally but at some point, usually after network disturbance, it hangs on shutdown.
Now it is self-compiled from https://github.com/bitcoin/bitcoin.git
Bitcoin Core version v0.18.99.0-495db72ee-dirty
The machine is ROCKPro64, RK3399 CPU, 4GB RAM.
Configure command was:
```
./configure --enable-debug --enable-werror BDB_LIBS="-L${BDB_PREFIX}/lib -ldb_cxx-4.8" BDB_CFLAGS="-I${BDB_PREFIX}/include" --with-boost-libdir=/usr/lib/arm-linux-gnueabihf
```
This time I compiled the Core with debug enabled. If being provided with more debug instructions I will try to investigate it deeper.
After the compilation and installation, test_bitcoin was completed with none errors.
As I wrote in #16642 before, the problem persist not only at mine ARM CPU but on an Intel CPU too.
Thank you. | P2P | low | Critical |
487,863,283 | flutter | Drag n Drop functionality needs to be added in Flutter_Driver | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
Drag element fuctionality in flutter_driver
<!--
Please tell us the problem you are running into that led to you wanting
a new feature.
Is your feature request related to a problem? Please give a clear and
concise description of what the problem is.
Describe alternative solutions you've considered. Is there a package
on pub.dev/flutter that already solves this?
-->
## Proposal
As Appium is depended upon flutter_driver APIs. So we required other APIs which needs to be integrated. So, for now, drag and drop functionality is not there in Flutter_Driver. We need an API through which we can drag an element to a particular position(target should be an element or x/y co-ordinate)
<!--
Briefly but precisely describe what you would like Flutter to be able to do.
Consider attaching images showing what you are imagining.
Does this have to be provided by Flutter directly, or can it be provided
by a package on pub.dev/flutter? If so, maybe consider implementing and
publishing such a package rather than filing a bug.
-->
| c: new feature,framework,t: flutter driver,c: proposal,P3,team-framework,triaged-framework | low | Critical |
487,873,154 | godot | Joints slide | **Godot version:**
**OS/device including version:**
Windows 10 64
**Issue description:**
There is looseness in the joint that can't be removed (it's not rigid). I'm guessing this is not supposed to happen?
**Minimal reproduction project:**
[physics test1.zip](https://github.com/godotengine/godot/files/3563401/physics.test1.zip)
| bug,confirmed,topic:physics | low | Minor |
487,881,743 | TypeScript | Narrow length of tuples | ## Search Terms
tuple length narrow
## Suggestion
Narrow the `length` property on tuple types when used as an Array.
## Use Cases
Often times a method expects an array of some particular length. This can be expressed as `[T, T, T]` where the number of tuple items is the length of the array. However, sometimes the length is itself generic and in order to properly constrain the type you need to type the parameter as `Array<T> & {length:L}`. The problem with this is that if you have a tuple of length L, the compiler still assumes that the `length` is of type `number`.
It would be useful if a tuple type correctly narrowed the type of `length` to be the number of elements in the tuple. This way you could pass a tuple into a method that expects a fixed length array without casting.
## Examples
```typescript
declare function bytesToInt(bytes: Array<number> & {length:4}): number
bytesToInt([1,2,3,4]) // currently errors, would be nice if it didn't.
bytesToInt([1,2,3,4] as Array<number> & {length:4}) // error prone and something the compiler could do for you.
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
----
It would be super cool if TypedArrays could get this behavior, since their `length` is fixed at construction time. I'm not sure exactly how to achieve this, so I'll leave it out of this suggestion but if it is possible for `new Uint8Array(4)` to result in a type `Uint8Array & {length:4}` that would be great. | Suggestion,In Discussion | low | Critical |
487,907,860 | TypeScript | Resolving hoisted `typeRoots` paths | <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.6.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
* resolve typeRoots in parent package node_modules
* sharing tsconfig in yarn workspaces
* use hoisted tsconfig in child package
**Code**
I've set up a Lerna monorepo which uses Yarn Workspaces. Within this monorepo is a config package, which other packages depend on. This config package has `@types/node` and `@types/jest` as dependencies.
From sibling packages, the shared config is used like so:
```json
{
"extends": "@project/config/ts.json",
"include": ["src", "tests"],
"compilerOptions": {
"outDir": "lib"
}
}
```
In the shared config, I point to the appropriate types root:
```json
{
"compilerOptions": {
// ...
"typeRoots": ["node_modules/@types"]
}
}
```
However, within the shared config package, `@types/*` have been hoisted from the local `node_modules` to the monorepo's top-level `node_modules`. This behavior is usually fine given node's resolution... but it seems the config does not resolve to its parent's `node_modules`.
**Expected behavior:**
For the specified type root to resolve to the parent's `node_modules`
**Actual behavior:**
Tests fail with messages such as `Cannot find name 'describe'. Do you need to install type definitions for a test runner? ...`
One workaround:
```json
{
"compilerOptions": {
// ...
"typeRoots": ["../../node_modules/@types"]
}
}
```
This workaround isn't very clean. Lerna & Yarn definitely pose some complexity for type root resolution. Hopefully resolving parents is considered a worthwhile modification.
Please let me know. Thank you :) | Suggestion,Needs Proposal | medium | Critical |
487,918,056 | rust | #[cold] attribute does is not propagated across crates | Hi!
When hacking on `once_cell`, I've noticed that it is significantly faster than `lazy_static`. Digging into this, it seems like the difference is in the usage of the `#[cold]` attribute.
Specifically, I've applied a patch which marks initialization function as `#[cold]` in lazy_static, and it indeed improved perf quite a bunch:
https://github.com/matklad/lazy-static.rs/commit/7863cc078d7d21108feacd3a26ef9801ea667457
And this is really weird, because `Once`, which powers `lazy_static`, already has the `#[cold]` attribute. Seems like it doesn't take an effect for whatever reason?
@rustbot modify labels to: +I-slow | I-slow,A-codegen,T-compiler,C-bug | low | Major |
487,928,246 | go | cmd/vet: incorrect printf "invalid argument index" with ... argument | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
tip (79669dc705)
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
darwin/amd64
### What did you do?
https://play.golang.org/p/uIeIGQWBhgB
```
package main
import (
"fmt"
)
func main() {
s := []interface{}{"Hello", "playground"}
fmt.Printf("%[2]s\n", s...)
}
```
### What did you expect to see?
No vet warning.
I think this is a valid program, which prints "playground" as intended. It doesn't seem like a potential bug to me.
### What did you see instead?
```
./prog.go:9:2: Printf format has invalid argument index [2]
```
| help wanted,NeedsFix,Analysis | low | Critical |
487,930,197 | flutter | default plugin gitignore too permissive | I recently started developing my first plugin and hit a pretty hard to debug situation when deploying it inside the app of a customer, due to the plugin scaffold's .gitignore.
My flutter plugin bundles a precompiled .framework that contains a Resources.bundle with a bunch of icons. Concretely i'm referring to the GoogleCastSDK. [Here you can see the project.](https://github.com/mschneider/flutter_google_cast_plugin/tree/master/ios/Frameworks/GoogleCastSDK-4.4.4/GoogleCast.framework/GoogleCastUIResources.bundle/Icons)
When testing the plugin with the example app, I did not experience any issues, but once I added the plugin to my client's app as a git reference in the `pubspec.yaml` my plugin caused the app to crash with the following error messages:
```
2019-09-01 22:04:13.188048+0200 Runner[3781:1245359] Could not load the "Icons/pause_48pt" image referenced from a nib in the bundle with identifier "(null)"
```
Apparently the folder containing the Icons `Icons` was not included in the github repo due to a rule in the default `ios/.gitignore` of the flutter plugin scaffold.
The respective rule is
```
Icon?
```
I managed to fix the issue by force-adding the respective files in my own repository, effectively overriding the .gitignore rule. But because this nasty pitfall was quite difficult to debug ๐คฏ I thought it would be best to discuss here, why this rule was created and if it is possible to make it less restrictive.
Cheers,
Max | tool,c: proposal,P2,a: plugins,team-tool,triaged-tool | low | Critical |
487,943,245 | TypeScript | Ability to get generic type from typeof and infer | TypeScript version: 3.6.2
## Search Terms
typeof generic function return generic type
infer arguments from generic function
## Suggestion
I ran into the issue described at #32170, where the answer was
> I expect what you're trying to do is refer to a specific call instantiation of a generic function, which isn't currently possible.
The feature request is to make this possible.
## Examples
In the following code, `dragHelperReact` is a helper function for implementing draggable functionality, which also abstracts over Mouse vs Touch events (since Pointer Events are not supported in older browsers). It takes as input three callbacks; since those callbacks have fairly lengthy signatures, I want to infer their argument types. The difficulty is that `React.SyntheticEvent` is a generic type, which allows narrowing of `e.currentTarget`.
```typescript
import * as React from "react";
function dragHelper<T>(
move: (e: MouseEvent | TouchEvent, coords: {x: number; y: number; dx: number; dy: number}) => void,
down: (
e: React.MouseEvent<T> | React.TouchEvent<T>,
coords: {x: number; y: number},
upHandler: (e: MouseEvent | TouchEvent) => void,
moveHandler: (e: MouseEvent | TouchEvent) => void
) => void,
up: (e: MouseEvent | TouchEvent) => void
) {
return {
onMouseDown: () => {
/* implementation */
}
};
}
type Args<T extends (...args: any) => any> = T extends (...args: infer A) => ReturnType<T> ? A : void;
type Move = typeof dragHelperReact extends (down: infer M, move: infer D, up: infer U) => void ? M : never;
type Down = typeof dragHelperReact extends (move: infer M, down: infer D, up: infer U) => void ? D : never;
type Up = typeof dragHelperReact extends (move: infer M, down: infer D, up: infer U) => void ? U : never;
// these work
type MoveArgs = Args<Move>;
type UpArgs = Args<Up>;
// I want to do something like this; it does not work.
type DownArgs<T> = Args<Down<T>>;
// This is a workaround I tried; it does not work either.
type DownArgs<T> = Down extends (e: any, ...args: infer U) => void ? [React.MouseEvent<T> | React.TouchEvent<T>, ...U] : never;
// This workaround works.
type DownArgs<T> = Down extends (e: any, ...args: infer U) => void ? [React.MouseEvent<T> | React.TouchEvent<T>, U[0], U[1], U[2]] : never;
class Example extends React.Component {
down(...[e, coords, upHandler, downHandler]: DownArgs<HTMLDivElement>) {
// e.currentTarget is narrowed to HTMLDivElement
}
move(...[e, coords]: MoveArgs) {}
up(...[e]: UpArgs) {}
render() {
return (
<div {...dragHelper(this.move, this.down, this.up)}/>
);
}
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Needs Proposal | low | Major |
488,011,206 | go | cmd/compile: does not check go:writebarrierrec for print functions | The runtime function `sighandler` is marked `go:nowritebarrierrec`. It calls `print` which cmd/compile turns into calls to `printstring` and friends. However, if I modify `printstring` to force a write barrier, no error is issued when compiling the runtime package. If I then mark `printstring` as `go:nowritebarrierrec`, I do get an error. My conclusion from this is that cmd/compile does not apply `go:nowritebarrierrec` to the calls generated by calling the `print` function.
I believe this is because in `(*nowritebarrierrecChecker).check` the `printstring` functions are never added to the `symToFunc` map.
CC @aclements | NeedsInvestigation,compiler/runtime | low | Critical |
488,026,571 | pytorch | The inference speed of the torch c++ dynamic library compiled manually is slower than the torch library officially provided | ## โ Questions and Help
I compile the torch c++ library(v1.2.0) with the command "python tools/build_libtorch.py". And then load the model of renet50 with the compiled library(batchsize=5), the speed is 20fps. But when I load the model resnet50 with the library officially provided from the website https://download.pytorch.org/libtorch/cu100/libtorch-shared-with-deps-1.2.0.zip, the speed is 130fps. Why is this fast?
cc @ezyang | module: binaries,module: performance,module: cuda,triaged | low | Major |
488,114,860 | material-ui | Togglebutton does not follow WAI-ARIA toolbar keyboard navigation principles | <!-- Provide a general summary of the issue in the Title above -->
Togglebuttons do not follow WAI-ARIA toolbar keyboard navigation principles.
<!-- Checked checkbox should look like this: [x] -->
- [x] The issue is present in the latest release.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Current Behavior ๐ฏ
Navigation works only via (Shift +) TAB key.
https://material-ui.com/components/toggle-button/
## Expected Behavior ๐ค
Navigation should be possible with arrow keys, home, end ...
See https://www.w3.org/TR/wai-aria-practices/examples/toolbar/toolbar.html
| new feature,accessibility,component: toggle button | low | Major |
488,140,857 | rust | Missed-optimization: extern "C" fn type calls are not nounwind | See https://rust.godbolt.org/z/9UvEyu
```rust
#![feature(unwind_attributes)]
extern "C" {
#[unwind(allow)] fn foo();
// fn bar();
static bar: extern "C" fn();
static mut BAR: i32;
}
struct Foo;
impl Drop for Foo {
fn drop(&mut self) {
unsafe { BAR = 42; }
}
}
pub unsafe fn unwind() {
let x = Foo;
foo();
std::mem::forget(x);
}
pub unsafe fn nounwind() {
let x = Foo;
bar();
std::mem::forget(x);
}
```
When the function `extern "C" { fn bar(); }` is called, the `nounwind` function is compiled to:
```asm
example::nounwind:
jmpq *bar@GOTPCREL(%rip)
```
However, when the function type `static bar: extern "C" fn();` is called, this sub-optimal machine code is emitted:
```asm
example::nounwind:
pushq %rbx
movq bar@GOTPCREL(%rip), %rax
callq *(%rax)
popq %rbx
retq
movq %rax, %rbx
callq core::ptr::real_drop_in_place
movq %rbx, %rdi
callq _Unwind_Resume@PLT
ud2
```
This means that we can't call the large majority of C FFI functions, which cannot unwind, and all of the C++ `noexcept` functions, which cannot unwind either, from Rust function pointers efficiently. | A-LLVM,I-slow,A-FFI,T-lang,T-compiler | medium | Major |
488,147,591 | go | cmd/compile: optimize conditional pointer assignment | ### What version of Go are you using (`go version`)?
<pre>
$ go version
go version devel +d15dfdc Sun Sep 1 02:31:50 2019 +0000 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What did you do?
I compiled the following function (https://godbolt.org/z/rRkMVJ):
```go
func fn(cond bool) int {
a := new(int)
if cond {
*a = 1
} else {
*a = 2
}
return *a
}
```
### What did you expect to see?
I expected that the generated instructions would be similar to https://godbolt.org/z/q0k3NT
### What did you see instead?
Instead, there are `MOV` instructions to temporary stack variables and there is no use of the `CMOV` instruction.
| Performance,NeedsDecision,compiler/runtime | low | Minor |
488,149,051 | terminal | Documentation update: explain the color names and how they related to ECMA-48 | <!--
๐จ๐จ๐จ๐จ๐จ๐จ๐จ๐จ๐จ๐จ
I ACKNOWLEDGE THE FOLLOWING BEFORE PROCEEDING:
1. If I delete this entire template and go my own path, the core team may close my issue without further explanation or engagement.
2. If I list multiple bugs/concerns in this one issue, the core team may close my issue without further explanation or engagement.
3. If I write an issue that has many duplicates, the core team may close my issue without further explanation or engagement (and without necessarily spending time to find the exact duplicate ID number).
4. If I leave the title incomplete when filing the issue, the core team may close my issue without further explanation or engagement.
5. If I file something completely blank in the body, the core team may close my issue without further explanation or engagement.
All good? Then proceed!
-->
# Description of the new feature/enhancement
Currently colors in the config are names in what arguably is a somewhat confusing way. E. g. it's not immediately obvious what "BrightBlack" or "BrightWhite" actually is.
It's also not clear if those names are consistent with any other public color names?
# Proposed technical implementation details
Can we reuse .NET's ConsoleColor enum instead?
https://docs.microsoft.com/en-us/dotnet/api/system.consolecolor?view=netframework-4.8
It's already used in .NET and powershell, and is widely known.
<!--
A clear and concise description of what you want to happen.
-->
| Help Wanted,Issue-Docs,Area-Settings,Product-Terminal,good first issue | low | Critical |
488,159,792 | pytorch | Usage of DDP on a module that doesn't require gradients | Per #25550, this raises a terrible error message.
Instead, we can choose to do one of two things:
* Raise a nicer error message to say it's not needed to use DDP.
* Allow this and become a non-functional pass through.
@mrshenli @zhaojuanmao @pritamdamania87 Thoughts?
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera | oncall: distributed,triaged,enhancement | low | Critical |
488,160,427 | godot | AnimationPlayer - Bezier curves values won't show in the inspector in Curve Edit Mode | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
3.1 stable
**OS/device including version:**
Win 7
**Issue description:**
Because of https://github.com/godotengine/godot/issues/31697 I try to set keys in the Curve Edit mode. But because of https://github.com/godotengine/godot/issues/19468 I need to set the keys numerically in the Inspector.
But the AnimationTrackKeyEdit will only show up outside the Bezier Curve mode when a key is selected.
**Proposal:**
- When a key is selected, show AnimationTrackKeyEdit in the Inspector for both regular track mode as well as Bezier curve edit mode.
- If a key is selected in regular track mode and the user switches to Bezier curve edit mode, the same key should be selected (and therefore AnimationTrackKeyEdit should still show all the keys values).
- Likewise, if a key is selected in Bezier Curve edit mode, and then switched to regular track edit, the same key should be still selected and AnimationTrackKeyEdit should show all it's values.
| enhancement,topic:editor | low | Minor |
488,169,742 | scrcpy | scrcpy client as virtual webcam driver | First of all... I would like to say thanks to scrcpy creators. I am in love with scrcpy, my life's history can be resumed as: before scrcpy and after scrcpy. Thanks so much!
However, I think it would be a nice feature to scrcpy client act as a Windows "Virtual Webcam".
I am not talking about displaying the Phone Cameras, but the frames displayed into the client's window.
It would be something similar what DroidCam, vCam (e2esoft) and OBS-VirtualCam do, all of them create a "Virtual Webcam Driver" which we can use as any other regular webcam.
Would it be possible? | feature request,webcam | medium | Major |
488,190,154 | flutter | Please add ability to disable font smoothing | <!-- Thank you for using Flutter!
If you are looking for support, please check out our documentation
or consider asking a question on Stack Overflow:
* https://flutter.dev/
* https://api.flutter.dev/
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
If you have found a bug or if our documentation doesn't have an answer
to what you're looking for, then fill our the template below. Please read
our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports
-->
## Use case
Please add ability to disable font smoothing. This is necessary to disabling smoothing on desktop systems (with low DPI)
Related: https://github.com/google/flutter-desktop-embedding/issues/524 | c: new feature,engine,a: typography,a: desktop,P3,team-engine,triaged-engine | low | Critical |
488,261,789 | TypeScript | [language server] Apply codefix to all files | <!-- ๐จ STOP ๐จ ๐ฆ๐ง๐ข๐ฃ ๐จ ๐บ๐ป๐ถ๐ท ๐จ
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker.
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ, especially the "Common Feature Requests" section: https://github.com/Microsoft/TypeScript/wiki/FAQ
-->
## Search Terms
* File is a CommonJS module; it may be converted to an ES6 module.
* Apply codefixes to all files (vscode, visual studio code)
* Convert all files from CommonJS to ES6
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
I would like to have some way to apply a specific codefix to all files in a directory. For example, convert a bunch of files from CommonJS format to the new ES6 module format using the codefix [here](https://github.com/microsoft/TypeScript/blob/master/src/services/codefixes/convertToEs6Module.ts).
## Use Cases
I have a few hundred files in CommonJS module format that I want to convert to ES6 module syntax (export/import instead of exports/require).
Currently, my text editor (vscode) shows after some delay three dots at the top of the current file which, when hovered over with the mouse shows after a few more seconds delay a "quickFix" button that, when clicked, causes the current file to be converted. To convert all of my files with this method would take hours of tedious clicking.
I want some method of automating this process.
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
<!-- Show how this would be used and what the behavior would be -->
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
488,295,491 | go | net: Lookup does not support Android/ios |
<pre>
$ go version
1.12.9
</pre>
```
package main
import (
"fmt"
"net"
)
func main() {
txtrecords, _ := net.LookupTXT("facebook.com")
for _, txt := range txtrecords {
fmt.Println(txt)
}
}
```
`lookup facebook.com on [::1]:53: read udp [::1]:57440->[::1]:53: read: connection refused`
android There is no `/etc/resolv.conf` file.
| help wanted,NeedsInvestigation,mobile | low | Minor |
488,297,162 | rust | A tuple of primitives function parameter is passed via the stack even though the tuple constituents could be passed as registers | 1.36.0 x86_64-unknown-linux-gnu
---
```rust
#[inline(never)]
pub fn foo((a, b, c, d): (usize, usize, usize, usize)) -> ((usize, usize), (usize, usize)) {
if a == 0 {
((0, b), (0, d))
}
else {
((a, b), (c, d))
}
}
pub fn bar() {
foo((1, 2, 3, 4));
}
```
passes the tuple via the stack
```asm
example::bar:
sub rsp, 72
movaps xmm0, xmmword ptr [rip + .LCPI1_0]
movaps xmmword ptr [rsp], xmm0
movaps xmm0, xmmword ptr [rip + .LCPI1_1]
movaps xmmword ptr [rsp + 16], xmm0
lea rdi, [rsp + 40]
mov rsi, rsp
call qword ptr [rip + example::foo@GOTPCREL]
add rsp, 72
ret
```
However if the function has four `usize` parameters, they're passed via registers.
```rust
#[inline(never)]
pub fn foo(a: usize, b: usize, c: usize, d: usize) -> ((usize, usize), (usize, usize)) {
if a == 0 {
((0, b), (0, d))
}
else {
((a, b), (c, d))
}
}
```
```asm
example::bar:
sub rsp, 40
lea rdi, [rsp + 8]
mov esi, 1
mov edx, 2
mov ecx, 3
mov r8d, 4
call qword ptr [rip + example::foo@GOTPCREL]
add rsp, 40
ret
```
It would be nice if the tuple case also used registers.
---
Perhaps related to / same as https://github.com/rust-lang/rust/issues/63244 . The tuple-taking `foo` has an aggregate parameter, and making multi-constituent tuples transparent (as suggested there) would help?
Tuple-taking `foo`:
```
define void @_ZN7example3foo17hffb69e1018702615E({ [0 x i64], { i64, i64 }, [0 x i64], { i64, i64 }, [0 x i64] }* noalias nocapture sret dereferenceable(32), { [0 x i64], i64, [0 x i64], i64, [0 x i64], i64, [0 x i64], i64, [0 x i64] }* noalias nocapture readonly dereferenceable(32) %arg0) unnamed_addr #0 !dbg !5 {
```
vs four-parameter `foo`:
```
define void @_ZN7example3foo17hb403de2e6269ef77E({ [0 x i64], { i64, i64 }, [0 x i64], { i64, i64 }, [0 x i64] }* noalias nocapture sret dereferenceable(32), i64 %a, i64 %b, i64 %c, i64 %d) unnamed_addr #0 !dbg !5 {
```
---
I discovered this with a `fn (Option<(NonNull<FatPointer>, NonNull<FatPointer>)>) -> (Option<NonNull<FatPointer>>, Option<NonNull<FatPointer>>)`. So I can't just rewrite this to use four separate parameters.
The two `usize` cases and the `Option` case are in [this godbolt](https://rust.godbolt.org/z/Up5SHj) for reference. | I-slow,O-linux,O-x86_64,T-compiler | low | Minor |
488,304,756 | youtube-dl | [UFC.com] Add support? | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.09.01. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.09.01**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
##
<!--
-->
- Single video: https://www.ufc.com/video/ufc-242-countdown-full-episode
- Single video: https://www.ufc.com/video/ufc-242-free-fight-poirier-vs-alvarez-2
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
youtube-dl https://www.ufc.com/video/ufc-242-countdown-full-episode
[generic] ufc-242-countdown-full-episode: Requesting header
WARNING: Falling back on generic information extractor.
[generic] ufc-242-countdown-full-episode: Downloading webpage
[generic] ufc-242-countdown-full-episode: Extracting information
ERROR: Unsupported URL: https://www.ufc.com/video/ufc-242-countdown-full-episode
-----
Verbose:
-----
youtube-dl https://www.ufc.com/video/ufc-242-countdown-full-episode
[generic] ufc-242-countdown-full-episode: Requesting header
WARNING: Falling back on generic information extractor.
[generic] ufc-242-countdown-full-episode: Downloading webpage
[generic] ufc-242-countdown-full-episode: Extracting information
ERROR: Unsupported URL: https://www.ufc.com/video/ufc-242-countdown-full-episode
youtube-dl --verbose https://www.ufc.com/video/ufc-242-countdown-full-episode
[debug] System config: []
[debug] User config: ['--format', 'bestvideo[ext=mp4]+bestaudio[ext=m4a]/mp4', '-i', '-o', 'E:\\Videos\\%(upload_date)s - %(title)s.%(ext)s']
[debug] Custom config: []
[debug] Command-line args: ['--verbose', 'https://www.ufc.com/video/ufc-242-countdown-full-episode']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.09.01
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg 4.1.4, ffprobe 4.1.4
[debug] Proxy map: {}
[generic] ufc-242-countdown-full-episode: Requesting header
WARNING: Falling back on generic information extractor.
[generic] ufc-242-countdown-full-episode: Downloading webpage
[generic] ufc-242-countdown-full-episode: Extracting information
ERROR: Unsupported URL: https://www.ufc.com/video/ufc-242-countdown-full-episode
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpbzyg5d3a\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpbzyg5d3a\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpbzyg5d3a\build\youtube_dl\extractor\generic.py", line 3355, in _real_extract
youtube_dl.utils.UnsupportedError: Unsupported URL: https://www.ufc.com/video/ufc-242-countdown-full-episode
| site-support-request | low | Critical |
488,326,165 | flutter | Import multiple Flutter modules in a native app | Hello guys,
I'm Matheus Romรฃo, software engineer at [ArcTouch](https://arctouch.com/). Here, we are going with Flutter as the technology choice for an important project but recently hit a major roadblock. The principal difficulty relates to using different Flutter modules on different projects. Further explanation and proposal can be found on this issue.
TL;DR: We would like to import different modules in the same project, so we could reuse them in different projects. Today if we try that, we won't pass from Project Sync on Android or `pod install` on iOS.
## Use case
Following the [add-to-app guide](https://github.com/flutter/flutter/wiki/Add-Flutter-to-existing-apps) we can import a Flutter module to an existing native app. However, there's no way to import multiple modules and access each module unitarily.
For example, if we have the following structure:
```
- flutter-modules
- login
- register
- (...) other modules/features
- android-project
- ios-project
- (...) other projects
```
It would be nice if there were a way to import `login` and `register` modules depending on the needs of each project, so we could reuse them.
### Android
Following the "depend on the module's source code" method, I was able to "import" both modules (login and register, in the example) leaving one of the `include_flutter.groovy` script as it is and changing the other, renaming `:flutter` to `:register`. I'm no specialist in gradle/groovy, but I'm pretty sure that was a workaround to make the script work in project sync phase because if you change `:flutter` to another name in both scripts, the project sync won't work, it will raise an exception:
```
> Failed to notify project evaluation listener.
> assert flutterProject != null
| |
null false
[...]
```
Anyway, the project sync works if you leave one script as it is and change the other. However, if you try to run the app, even without using Flutter inside of it, the build fails with the following exception:
```
Task :app:mergeDebugNativeLibs FAILED
More than one file was found with OS independent path 'lib/x86/libflutter.so'
```
Which makes sense for me as I'm trying to import Flutter twice.
If I try to import the modules following the "Depend on the Android Archive (AAR)" method, the project sync works. But when you try to run the app the build fails with the following message:
```
Execution failed for task ':app:checkDebugDuplicateClasses'.
> 1 exception was raised by workers:
java.lang.RuntimeException: Duplicate class io.flutter.BuildConfig found in modules flutter.jar (com.arctouch.login:flutter_debug:1.0) and flutter.jar (com.arctouch.register:flutter_debug:1.0)
[...]
```
Same problem with duplicates.
### iOS
I wasn't able to import the modules using a Podfile. First, `install_all_flutter_pods` accepts only one module and if we try to call that twice in the same target, we get an error:
```
Invalid `Podfile` file: Script phase with name `Run Flutter Build Script` name already present for target `iOS Native`.
```
But I went to `podhelper.rb` to check the reference and found `install_flutter_application_pod`, so I tried to run the following Podfile:
```
login = '../flutter_modules/login'
register = '../flutter_modules/register'
load File.join(login, '.ios', 'Flutter', 'podhelper.rb')
load File.join(register, '.ios', 'Flutter', 'podhelper.rb')
target 'iOS Native' do
install_flutter_engine_pod
install_flutter_application_pod(login)
install_flutter_application_pod(register)
end
```
But I still got the same error "script phase already present for target".
### Workaround
At last, discussing all of that with my colleagues, they suggested trying to import all the modules in an umbrella-like project and then import in the native app. So, I tried to import both modules as packages of a third module, here called `umbrella`:
`umbrella/pubspec.yaml`:
```
dependencies:
flutter:
sdk: flutter
cupertino_icons: ^0.1.2
login:
path: ../flutter_modules/login
register:
path: ../flutter_modules/register
```
That works, but you have to create the routes in the `umbrella` module to map the `login` and `register` widgets.
Well, clearly this is not desirable and it feels pretty hacky. In addition, it adds one more layer to the import process and depending on the method you use, you'll have to repeat some steps as the need for modules change.
## Proposal
We should be able to import each module and access its features individually.
For Android, it would be great if we could import Flutter engine and then the modules:
```
implementation project(:flutter)
implementation project(:login)
implementation project(:register)
````
After that, we could specify which module and route we want to use in the Flutter view/fragment/activity (facade or Android embedding). Also, the same idea applies to ".aar" method.
For iOS, we could do something like the Podfile above, calling `install_flutter_application_pod` for each module we want to import or even use varags to pass an array of modules on `install_all_flutter_pods`.
Thank you guys for taking your time to read this (sorry for the long issue)! | c: new feature,framework,engine,a: existing-apps,customer: crowd,c: proposal,P3,team-engine,triaged-engine | high | Critical |
488,331,127 | TypeScript | Error on static class members named 'constructor' should be consistent | **TypeScript Version:** 3.7.0-dev.20190831
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** class, constructor, static, computed, quoted
**Code**
```ts
class A { static constructor() {} }
class B { static "constructor"() {} }
class C { static ["constructor"]() {} }
```
**Expected behavior:**
Even though it may be confused with non-standard extensions like #265, I think treating all cases equally would be less confusing, because unlike non-static `["constructor"]` there is no difference at runtime.
**Actual behavior:**
`A` and `B` (with #31949) get a `'static' modifier cannot appear on a constructor declaration.
` diagnostic.
**Playground Link:**
http://www.typescriptlang.org/play/#code/MYGwhgzhAECC0G9oQC5hQS2NYB7AdqgE4CuwKuRAFAJSIC+09AUKJDAEKLJqbYBEeQilLlK-WgyatwUaAGFuqdFmgBtQQWJkKRfgF1JCRiyA
**Related Issues:** #31020, https://github.com/eslint/eslint/pull/12110
| Suggestion,In Discussion,Awaiting More Feedback | low | Critical |
488,361,504 | TypeScript | Object literals should have a `this` type too | <!-- ๐จ STOP ๐จ ๐ฆ๐ง๐ข๐ฃ ๐จ ๐บ๐ป๐ถ๐ท ๐จ
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.7.0-dev.20190831
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** `this` return type object composing composition
**Code**
I tried writing some self-contained parts of objects as a kind of multiple-inheritance or object composition, which I would combine later, and ran into this case.
```ts
const a = {
Clone() {
return this;
},
x: 1,
};
const b = {
Clone: a.Clone,
y: 2,
};
console.log(b.Clone().x); // number, bad! Should be an error!
console.log(b.Clone().y); // compiler error, bad! This should be acceptable!
```
**Expected behavior:** `this`, the return type of `Clone`, should evaluate to `typeof b` in `b.Clone()`
**Actual behavior:** It evaluates to `typeof a`, since it was defined in `a`
This can be circumvented by defining `this` as a type parameter like so:
```ts
const a = {
Clone<T>(this: T) {
return this;
},
x: 1,
}
const b = {
Clone: a.Clone,
y: 2
};
console.log(b.Clone().x); // compiler error, good!
console.log(b.Clone().y); // works! Also good!
```
Another interesting problem at play here though, is that using a type parameter for `this` also means that TS doesn't know what could be inside of `this`. This means you have to manually specify whatever members you hope to have access to. It would be nice if you could do `T extends typeof a` and it would automatically drop all the members of `a` in there. Right now, it will error if you do this:
`'a' implicitly has type 'any' because it does not have a type annotation and is referenced directly or indirectly in its own initializer.ts(7022)`
I think all methods like this should, therefore, be implicitly equivalent to the following:
```ts
const a = {
Clone<T extends typeof a>(this: T) {
console.log(this.x); // should work
return this;
},
x: 1,
}
```
Then, `b.Clone()` would error since `b` is not a superset of `a`. Unless you did `c = Object.assign({}, a, b)`, and did `c.Clone()`
**Playground Link:** https://www.typescriptlang.org/play/?target=6#code/MYewdgzgLgBAhjAvDA3gKAJAGEA24CmAFAJSqYYBO+UArhWDFABYCWEA3JgL4A0mAHgC4YARjRdOaUJFgAjJGWx4w+YXAB0uAnwwBPYQCZxk6RBA586vAHNCszcqLF1-YuxgB6DzBpgAJvgAZiwqflLgZhZWILb2Wiok6rpunt6gALYADiwWFDD4FBQgFEA<!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
**Related Issues:** https://github.com/microsoft/TypeScript/issues/29122 <!-- Did you find other bugs that looked similar? -->
| Suggestion,Needs Proposal,Awaiting More Feedback,Experimentation Needed | low | Critical |
488,375,116 | pytorch | Remote memory access similar to MPI one-sided in pytorch | torch.distributed package currently implements two-sided point to point communication, i.e. send and recv. However, one-sided communication, i.e., put, get and accumulate routines are getting popular in mpi due to performance benefits and dynamic communication patterns. It would be great to implement these routines in pytorch.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera | oncall: distributed,feature,triaged,module: mpi | low | Major |
488,408,434 | flutter | More ascii in logs | Non-ascii characters appearing in logs seem non-essential. For example.
```
I/flutter (10543): The AnimationController notifying listeners was:
I/flutter (10543): AnimationController#0218f(โญ 1.000; paused)
```
And as an image:
This is not only distracting.
Rendering such a log will depend on system fonts, terminals, etc. It also will break pastebins not robust to non-ascii, like ix.io. Consider http://ix.io/1U7J/dart vs http://ix.io/1U7O/dart. This can be seen as limitations in a particular pastebin, a terminal, or a user's system fonts, but if these characters are not essentials to logs, then it seems unnecessary to force this issue with various tools.
| framework,c: proposal,a: error message,P3,team-framework,triaged-framework | low | Minor |
488,432,077 | neovim | :terminal fails to clear ANSI background color for some code sequences | - `nvim --version`:
NVIM v0.4.0-1887-ge29b89ca5
Build type: Debug
LuaJIT 2.0.5
Compilation: /usr/bin/cc -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=always -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/home/shmaryar/src/neovim/build/config -I/home/shmaryar/src/neovim/src -I/home/shmaryar/src/neovim/.deps/usr/include -I/usr/include -I/home/shmaryar/src/neovim/build/src/nvim/auto -I/home/shmaryar/src/neovim/build/include
Compiled by shmaryar@SHMARYAR
Features: +acl +iconv +tui
See ":help feature-compile"
system vimrc file: "$VIM/sysinit.vim"
fall-back for $VIM: "/home/shmaryar/src/neovim/install/share/nvim"
Run :checkhealth for more info
- `vim -u DEFAULTS` (version: ) behaves differently?
Not relevant to standard vim, as it doesn't have :terminal
- Operating system/version:
ubuntu 18.10
- Terminal name/version:
kitty 0.14.3
- `$TERM`:
xterm-kitty
### Steps to reproduce using `nvim -u NORC`
```
nvim -u NORC
:terminal
cat <attached file>
```
[26R4Gk1a.txt](https://github.com/neovim/neovim/files/3568211/26R4Gk1a.txt)
### Actual behaviour
There are green background bars all the way to the right on some of the lines. As seen in the screenshot:
### Expected behaviour
No highlighting except for within the lines.
| bug,terminal,has:repro | low | Critical |
488,485,367 | TypeScript | Support for JSDoc interface definition | ## Search Terms
jsdoc, interface
I found https://github.com/microsoft/TypeScript/issues/16142 which was closed by the reporter, and never reopened even though some other people suggested it.
## Suggestion
JSDoc has a way to declare interfaces, through `@interface`, `@function` (and then `@implements` on the class). It would be great if tsc could support them (defining a TS interface based on that info).
## Use Cases
JSDoc interfaces are useful to define interfaces implemented by multiple classes, that are then used based on this interface. This is part of JSDoc, but currently unsupported by tsc.
## Examples
```js
/**
* @interface Metric
*/
/**
* @function
* @name Metric#getName
* @returns {string}
*/
/**
* @function
* @name Metric#compute
* @param context
* @param [extra]
* @returns {Promise<object>}
*/
/**
* @constructor
* @implements {Metric}
*/
function ActivityScoreMetric () {
// [REDACTED]
}
ActivityScoreMetric.prototype = {
compute: function (context, extra) {
// [REDACTED]
},
getName: function () {
return 'activity_score'
}
}
// Other implementations go there
// Later code deals with `Array<Metric>` for some variables
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Major |
488,525,979 | godot | Crash in animation bezier editor when moving keys | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
3.2.alpha latest master with a few patches of my own.
<!-- Specify commit hash if non-official. -->
Ubuntu 18.04
<!-- Specify GPU model and drivers if graphics-related. -->
Crash with backtrace when moving keys. The terminal shows the following:
```
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_remove_key_at_position: Condition ' idx < 0 ' is true.
At: scene/resources/animation.cpp:888.
ERROR: track_get_key_time: Index p_key_idx=63 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=62 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=61 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=60 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=59 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=58 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=57 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=56 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=55 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=54 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=53 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=52 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=51 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=50 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=49 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=48 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=47 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=46 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=45 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=44 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=43 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=42 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=41 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=40 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=39 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=38 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=37 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=36 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=35 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=34 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=33 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=32 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=31 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=30 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=29 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=28 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=27 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=26 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=25 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=24 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=23 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=22 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=21 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=20 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=19 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=18 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=17 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=16 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=15 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=14 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=13 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=12 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=11 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=10 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=9 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=8 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=7 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=6 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=5 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=4 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_time: Index p_key_idx=63 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1278.
ERROR: track_get_key_value: Index p_key_idx=63 out of size (bt->values.size()=4)
At: scene/resources/animation.cpp:1211.
ERROR: operator[]: FATAL: Index p_index=0 out of size (((Vector<T> *)(this))->_cowdata.size()=0)
At: ./core/vector.h:49.
handle_crash: Program crashed with signal 4
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[1] /lib/x86_64-linux-gnu/libc.so.6(+0x3ef20) [0x7feb2e2c7f20] (??:0)
[2] VectorWriteProxy<Variant>::operator[](int) (/home/puthre/godot/mygodot/godot/./core/vector.h:49 (discriminator 7))
[3] Array::operator[](int) (/home/puthre/godot/mygodot/godot/core/array.cpp:76)
[4] AnimationBezierTrackEdit::_gui_input(Ref<InputEvent> const&) (/home/puthre/godot/mygodot/godot/editor/animation_bezier_editor.cpp:905)
[5] MethodBind1<Ref<InputEvent> const&>::call(Object*, Variant const**, int, Variant::CallError&) (/home/puthre/godot/mygodot/godot/./core/method_bind.gen.inc:775 (discriminator 12))
[6] Object::call_multilevel(StringName const&, Variant const**, int) (/home/puthre/godot/mygodot/godot/core/object.cpp:763 (discriminator 1))
[7] Object::call_multilevel(StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) (/home/puthre/godot/mygodot/godot/core/object.cpp:864)
[8] Viewport::_gui_call_input(Control*, Ref<InputEvent> const&) (/home/puthre/godot/mygodot/godot/scene/main/viewport.cpp:1520 (discriminator 2))
[9] Viewport::_gui_input_event(Ref<InputEvent>) (/home/puthre/godot/mygodot/godot/scene/main/viewport.cpp:1894 (discriminator 3))
[10] Viewport::input(Ref<InputEvent> const&) (/home/puthre/godot/mygodot/godot/scene/main/viewport.cpp:2668 (discriminator 2))
[11] Viewport::_vp_input(Ref<InputEvent> const&) (/home/puthre/godot/mygodot/godot/scene/main/viewport.cpp:1297)
[12] MethodBind1<Ref<InputEvent> const&>::call(Object*, Variant const**, int, Variant::CallError&) (/home/puthre/godot/mygodot/godot/./core/method_bind.gen.inc:775 (discriminator 12))
[13] Object::call(StringName const&, Variant const**, int, Variant::CallError&) (/home/puthre/godot/mygodot/godot/core/object.cpp:921 (discriminator 1))
[14] Object::call(StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) (/home/puthre/godot/mygodot/godot/core/object.cpp:848)
[15] SceneTree::call_group_flags(unsigned int, StringName const&, StringName const&, Variant const&, Variant const&, Variant const&, Variant const&, Variant const&) (/home/puthre/godot/mygodot/godot/scene/main/scene_tree.cpp:264)
[16] SceneTree::input_event(Ref<InputEvent> const&) (/home/puthre/godot/mygodot/godot/scene/main/scene_tree.cpp:419 (discriminator 6))
[17] InputDefault::_parse_input_event_impl(Ref<InputEvent> const&, bool) (/home/puthre/godot/mygodot/godot/main/input_default.cpp:416)
[18] InputDefault::parse_input_event(Ref<InputEvent> const&) (/home/puthre/godot/mygodot/godot/main/input_default.cpp:260)
[19] InputDefault::flush_accumulated_events() (/home/puthre/godot/mygodot/godot/main/input_default.cpp:679)
[20] OS_X11::process_xevents() (/home/puthre/godot/mygodot/godot/platform/x11/os_x11.cpp:2619)
[21] OS_X11::run() (/home/puthre/godot/mygodot/godot/platform/x11/os_x11.cpp:3182)
[22] /home/puthre/godot/mygodot/godot/bin/godot.x11.tools.64(main+0x128) [0x13c054f] (/home/puthre/godot/mygodot/godot/platform/x11/godot_x11.cpp:57)
[23] /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xe7) [0x7feb2e2aab97] (??:0)
[24] /home/puthre/godot/mygodot/godot/bin/godot.x11.tools.64(_start+0x2a) [0x13c036a] (??:?)
-- END OF BACKTRACE --
```
| bug,topic:editor,confirmed,crash | low | Critical |
488,532,749 | rust | xLTO: Code from standard library does not partake in linker-based LTO (unless compiling with -Clto) | xLTO works by emitting LLVM bitcode instead of machine code and then letting the linker run LLVM optimizations (at a point where also code from C/C++ is available for IPO). In the current setup, this means that code from the standard library does *not* partake in the final LTO step because it is pre-compiled to machine code.
This limitation can be lifted by compiling to a staticlib with `-Clto` because the fat LTO step that `rustc` does pulls in the compressed bitcode version of the standard library and then emits the unified bitcode file for further processing by the linker. However, this adds an additional fat LTO step into the compilation pipeline, which is very costly.
In theory it should be possible to make `rustc` emit `libstd` LLVM bitcode into the staticlib instead of the object files (if `-Clinker-plugin-lto` is specified). The bitcode is available and `rustc` knows how to decompress it. Then the linker could do its LTO step with the standard library included but without the additional cost. | A-LLVM,A-codegen,I-compiletime,T-compiler,C-feature-request | low | Minor |
488,549,447 | flutter | [Feature] NetworkImage : custom 'makeRequest' function ? | ## Use case
To deal with redirects and authorization and any future problem that may arise.
Currently, the NetworkImage will create an http request, set headers, and use it.
However, when dealing with redircet and authorization ( e.g. #34894 ), the user may want:
(1) To not follow redirect (boolean property)
(2) When the request returns, if it's a redirect, to make another request without the authorization.
## Proposal
Since I can't see a good enough use-case for a specific property of the NetworkImage,
using the parameter will give the NetworkImage users enough control to pretty much do what ever they want
The type of the new parameter will be an function that accepts `HttpClientRequest` and returns `Future<HttpClientResponse>`.
The default value of the function will be `request.close()`
This is just a proposal, and although it's very generic I'm not a big fan of it, so I'd love a discussion here about more ideas, hopefully better than mine.
## Implementation
I'm willing to implement this feature, the Flutter team just needs to decide what the feature is.
| c: new feature,framework,a: images,c: proposal,P3,team-framework,triaged-framework | low | Minor |
488,556,359 | youtube-dl | Cannot download Viki Pass Plus Video | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.09.01. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that all URLs and arguments with special characters are properly quoted or escaped as explained in http://yt-dl.org/escape.
- Search the bugtracker for similar issues: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Read bugs section in FAQ: http://yt-dl.org/reporting
- Finally, put x into all relevant boxes (like this [x])
-->
- [ X] I'm reporting a broken site support issue
- [ X] I've verified that I'm running youtube-dl version **2019.09.01**
- [ X] I've checked that all provided URLs are alive and playable in a browser
- [ X] I've checked that all URLs and arguments with special characters are properly quoted or escaped
- [ X] I've searched the bugtracker for similar bug reports including closed ones
- [ X] I've read bugs section in FAQ
## Verbose log
<!--
Provide the complete verbose output of youtube-dl that clearly demonstrates the problem.
Add the `-v` flag to your command line you run youtube-dl with (`youtube-dl -v <your command line>`), copy the WHOLE output and insert it below. It should look similar to this:
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2019.09.01
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
<more lines>
-->
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--username', 'PRIVATE', '--password', 'PRIVATE', '-
v', 'https://www.viki.com/videos/1155532v-issue-makers-episode-3']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.09.01
[debug] Python version 3.4.4 (CPython) - Windows-2012ServerR2-6.3.9600
[debug] exe versions: ffmpeg N-72900-g178ba1f, ffprobe N-72900-g178ba1f, phantom
js 2.1.1
[debug] Proxy map: {}
[viki] Logging in
[viki] 1155532v: Downloading video JSON
[viki] 1155532v: Downloading video streams JSON
ERROR: No video formats found; please report this issue on https://yt-dl.org/bug
. Make sure you are using the latest version; type youtube-dl -U to update. B
e sure to call youtube-dl with the --verbose flag and include its complete outpu
t.
Traceback (most recent call last):
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpbzyg5d
3a\build\youtube_dl\YoutubeDL.py", line 796, in extract_info
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpbzyg5d
3a\build\youtube_dl\extractor\common.py", line 530, in extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpbzyg5d
3a\build\youtube_dl\extractor\viki.py", line 319, in _real_extract
File "C:\Users\dst\AppData\Roaming\Build archive\youtube-dl\ytdl-org\tmpbzyg5d
3a\build\youtube_dl\extractor\common.py", line 1327, in _sort_formats
youtube_dl.utils.ExtractorError: No video formats found; please report this issu
e on https://yt-dl.org/bug . Make sure you are using the latest version; type y
outube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and
include its complete output.
```
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
My Viki account subscription is already Viki Pass Plus but still cannot download video that is available for Viki Pass Plus subscribers.
Example video:
`https://www.viki.com/videos/1155532v-issue-makers-episode-3`
After investigated, i see this API function responds "{}" (there is not stream info/url)
`GET /v4/videos/VIDEO_ID/streams.json`
I don't have any idea to solve this issue, hope you guys can help me to find another way to download these videos.
Thank you so much! | account-needed | low | Critical |
488,586,205 | go | x/tools/internal/imports: test frequently times out on `dragonfly-amd64` builder | The test for `golang.org/x/tools/internal/imports` seems to be timing out on around 25% of runs on the `dragonfly-amd64` builder.
Example logs:
* https://build.golang.org/log/e697ac9c8ea86c4aa83321b80d9c1371c7c630fb
* https://build.golang.org/log/7a7c78010de15f81e9b3411c020e1048006e39e2
* https://build.golang.org/log/606423ffa1cb92cf42e35073469762d25b9e282c
* https://build.golang.org/log/ed9923ceaf868e900d12bf6e7c296d916c7f6a2c
The `dragonfly-amd64` builder seems to be a bit underpowered in general (see also #29583 and #25796). Perhaps we should set `GO_TEST_TIMEOUT_SCALE=2` in its environment and see if that improves the situation for `x/tools`?
CC @matloob @ianthehat @tdfbsd | Testing,OS-Dragonfly,Builders,NeedsInvestigation,Tools | low | Major |
488,586,474 | youtube-dl | Add air.tv | - [X] I'm reporting a new site support request
- [X] I've verified that I'm running youtube-dl version **2019.09.01**
- [X] I've checked that all provided URLs are alive and playable in a browser
- [X] I've checked that none of provided URLs violate any copyrights
- [X] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
- Single video: https://www.air.tv/watch?v=sv57EC8tRXG6h8dNXFUU1Q
- Single video 2: https://www.air.tv/watch?v=qVOWEB4tSSi7nDVl9FZbMQ | site-support-request | low | Critical |
488,611,661 | TypeScript | Suggestion: an option to make --showConfig more verbose | ## Search Terms
`showConfig`, `verbose`, `verbosity`
## Suggestion
Currently, the `--showConfig` option will only print the compiler options that are provided by the given `tsconfig.json`.
The suggestion is to introduce another command line option to use together with `--showConfig`, for example `--verbose`, that would additionally print out the default values of all of the missing compiler options.
## Use Cases
This new option hopes to make debugging configuration files easier by explicitly displaying the value of every compiler option.
## Examples
Given the following folder structure:
```
.
โโโ main.ts
โโโ tsconfig.json
```
And the following `tsconfig.json`:
```json
{
"compilerOptions": {
"target": "es5"
},
"include": ["**/*.ts"]
}
```
Running the command `tsc --showConfig` produces:
```json
{
"compilerOptions": {
"target": "es5"
},
"files": [
"./main.ts"
],
"include": [
"**/*.ts"
]
}
```
Here's an example output of `tsc --showConfig --verbose`. It was derived in the following way:
1. Use the Typescript Handbook's [table of compiler options and their defaults](https://www.typescriptlang.org/docs/handbook/compiler-options.html#compiler-options) as a reference.
2. Exclude deprecated options (`out`, `reactNamespace`, and `skipDefaultLibCheck`)
3. Also exclude any options that are missing a default value in the table, since JSON doesn't have a notion of `undefined`.
```json5
{
"compilerOptions": {
"allowJs": false,
"allowSyntheticDefaultImports": false,
"allowUmdGlobalAccess": false,
"allowUnreachableCode": false,
"allowUnusedLabels": false,
"alwaysStrict": false,
"build": false,
"charset": "utf8",
"checkJs": false,
"composite": true,
"declaration": false,
"declarationMap": false,
"diagnostics": false,
"disableSizeLimit": false,
"downlevelIteration": false,
"emitBOM": false,
"emitDeclarationOnly": false,
"emitDecoratorMetadata": false,
"esModuleInterop": false,
"experimentalDecorators": false,
"extendedDiagnostics": false,
"forceConsistentCasingInFileNames": false,
"importHelpers": false,
"incremental": false,
"inlineSourceMap": false,
"inlineSources": false,
"isolatedModules": false,
"jsx": "preserve",
"jsxFactory": "React.createElement",
"keyofStringsOnly": false,
"listEmittedFiles": false,
"listFiles": false,
"locale": "en", // [2]
"module": "commonjs",
"moduleResolution": "classic",
"newLine": "lf", // [2]
"noEmit": false,
"noEmitHelpers": false,
"noEmitOnError": false,
"noErrorTruncation": false,
"noFallthroughCasesInSwitch": false,
"noImplicitAny": false,
"noImplicitReturns": false,
"noImplicitThis": false,
"noImplicitUseStrict": false,
"noLib": false,
"noResolve": false,
"noStrictGenericChecks": false,
"noUnusedLocals": false,
"noUnusedParameters": false,
"preserveConstEnums": false,
"preserveSymlinks": false,
"preserveWatchOutput": false,
"pretty": true, // [1]
"removeComments": false,
"resolveJsonModule": false,
"rootDir": "(computed from the list of input files)", // [3]
"showConfig": false,
"skipLibCheck": false,
"sourceMap": false,
"strict": false,
"strictBindCallApply": false,
"strictFunctionTypes": false,
"strictPropertyInitialization": false,
"strictNullChecks": false,
"suppressExcessPropertyErrors": false,
"suppressImplicitAnyIndexErrors": false,
"target": "es5",
"traceResolution": false,
"tsBuildInfoFile": ".tsbuildinfo"
},
"files": [
"./main.ts"
],
"include": [
"**/*.ts"
]
}
```
<sup>[1]</sup> The Handbook says `pretty` should be `true` unless piping or redirecting output to file, so the desired value here may be ambiguous?
<sup>[2]</sup> `locale` and `newLine` are platform-specific.
<sup>[3]</sup> `rootDir` would need to be calculated so it can be displayed.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Help Wanted,Experience Enhancement | medium | Critical |
488,649,495 | flutter | Button widget should provide enable/disable properties instead of setting onpressed to null | ## Steps to Reproduce
I want disable button first, then process logic, then enable button at last.
My logic is : first set onpressed to null to disable button, then do some async operation, at last set onpressed to origin to enable button.
My purpose is to avoid user tapping the button many times when processing async operation.
But got errors:
Unhandled Exception: setState() called after dispose(): _LoginPageState#e0856(lifecycle state: defunct, not mounted)
Codes Steps :
```
Widget _buildButton(BuildContext context) {
return OutlineButton(
child: Text('Login'),
onPressed: _enableButton
? () async {
if (!_formKey.currentState.validate()) return;
setState(() {
_enableButton = false;
});
await doLogin(context);
setState(() {
_enableButton = true;
});
}
: null,
);
}
```
But got errors:
```
[VERBOSE-2:ui_dart_state.cc(148)] Unhandled Exception: setState() called after dispose(): _LoginPageState#e0856(lifecycle state: defunct, not mounted)
This error happens if you call setState() on a State object for a widget that no longer appears in the widget tree (e.g., whose parent widget no longer includes the widget in its build). This error can occur when code calls setState() from a timer or an animation callback.
The preferred solution is to cancel the timer or stop listening to the animation in the dispose() callback. Another solution is to check the "mounted" property of this object before calling setState() to ensure the object is still in the tree.
This error might indicate a memory leak if setState() is being called because another object is retaining a reference to this State object after it has been removed from the tree. To avoid memory leaks, consider breaking the reference to this object during dispose().
#0 State.setState.<anonymous closure> (package:flutter/src/widgets/framew<โฆ>
```
Is there any way to enable/disable button directly?
like this:
```
OutlineButton(
child:Text('button here'),
onPressed:(){},
enabled:true,
)
```
## Logs
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
Analyzing app_travel...
No issues found! (ran in 1.7s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
No issues found!
```
| c: new feature,framework,f: material design,P3,team-design,triaged-design | low | Critical |
488,700,096 | flutter | TextSpans within Text widgets render badly in debug output | The textSpan is displayed as a property within a tree style that displays all properties as a single line. Given the parent tree structure, the property needs to render as a single line instead of using the multi-line style. There is some functionality to force styles on a property based on the parent's style but it isn't triggering for this case.
Full log.
http://ix.io/1U1J
Problem case:
```
I/flutter (29873): โ โText(null,
I/flutter (29873): โ โโโโฆโโ textSpan โโโ
I/flutter (29873): โ โ โ TextSpan:
I/flutter (29873): โ โ โ ""
I/flutter (29873): โ โ, inherit: true, family: IBMPlexMono, dependencies: [MediaQuery, DefaultTextStyle])
I/flutter (29873): โ โRichText(softWrap: wrapping at box width, maxLines: unlimited, text: "", dependencies: [_LocalizationsScope-[GlobalKey#de547], Directionality], renderObject: RenderParagraph#48cf1 relayoutBoundary=up6)
``` | framework,a: typography,has reproducible steps,P2,found in release: 3.7,found in release: 3.9,team-framework,triaged-framework | low | Critical |
488,711,801 | flutter | Selection of any justified-text is inaccurate in non-latin languages | I hope I can clarify this issue because it is a little weird. It took me a while to figure out when exactly does it occur.
Here is a very primitive application:
```dart
// main.dart
import 'package:flutter/material.dart';
void main() => runApp(MaterialApp(
home: Scaffold(
appBar: AppBar(),
body: Padding(
padding: const EdgeInsets.all(18.0),
child: TextField(
textAlign: TextAlign.justify,
maxLines: null,
),
),
),
));
```
Now, type any latin charachter text. Try to select any single or multiple words, you will find that the selection blue highlight matches accurately the boundaries of the word(s). See this screen shot:
_____________________
Then, put some Korean text. You will find that some words are poorly highlighted:
> ํ๊ตญ์ด(้ๅ่ช)๋ ๋ํ๋ฏผ๊ตญ๊ณผ ์กฐ์ ๋ฏผ์ฃผ์ฃผ์์ธ๋ฏผ๊ณตํ๊ตญ์ ๊ณต์ฉ์ด๋ก, ๋ํ๋ฏผ๊ตญ์์๋ ํ๊ตญ์ด ๋๋ ํ๊ตญ๋ง์ด๋ผ๊ณ ๋ถ๋ฅด๊ณ , ์กฐ์ ๋ฏผ์ฃผ์ฃผ์์ธ๋ฏผ๊ณตํ๊ตญ์์๋ ์กฐ์ ๋ง์ด๋ผ๊ณ ๋ถ๋ฅธ๋ค.
_____________________
Also in Arabic texts (it does not matter here that the `textDirection` is not RTL. Both RTL and LTR have the same issue):
> ุงูุนุฑุจูุฉ ูุบุฉ ุฑุณู
ูุฉ ูู ูู ุฏูู ุงููุทู ุงูุนุฑุจู ุฅุถุงูุฉ ุฅูู ููููุง ูุบุฉ ุฑุณู
ูุฉ ูู ุชุดุงุฏ ูุฅุฑูุชุฑูุง ูุฅุณุฑุงุฆูู. ููู ุฅุญุฏู ุงููุบุงุช ุงูุฑุณู
ูุฉ ุงูุณุช ูู ู
ูุธู
ุฉ ุงูุฃู
ู
ุงูู
ุชุญุฏุฉุ ูููุญุชูู ุจุงูููู
ุงูุนุงูู
ู ููุบุฉ ุงูุนุฑุจูุฉ ูู 18 ุฏูุณู
ุจุฑ ูุฐูุฑู ุงุนุชู
ุงุฏ ุงูุนุฑุจูุฉ ุจูู ูุบุงุช ุงูุนู
ู ูู ุงูุฃู
ู
ุงูู
ุชุญุฏุฉ.
_____________________
Same in Hebrew:
> ืขึดืึฐืจึดืืช ืืื ืฉืคื ืฉืืืช, ืืืฉืคืืช ืืฉืคืืช ืืืคืจื-ืืกืืืชืืืช, ืืืืืขื ืืฉืคืชื ืฉื ืืืืืืื ืืฉื ืืฉืืืจืื ืื, ืืฉืจ ื ืื ืืืืจื ื ืฉืื (ืขืืจืืช ืืฉืจืืืืช) ืืื ืฉืคืชื ืืจืฉืืืช ืฉื ืืืื ืช ืืฉืจืื, ืืขืื ืฉืขืืื ืืฉื ืช 2018 ืืืืง ืืกืื: ืืฉืจืื โ ืืืื ืช ืืืืื ืฉื ืืขื ืืืืืื.
_____________________
Just copy these texts and paste them in the input field, then try to select one word. In all cases above I just long tapped on one word and the highlight missed the word boundry as shown.
It does have to be a text field or input though. Any justified selectable text would reproduce the same behavior. I tried in both stable and master channels.
Here is my `flutter doctor` output:
```
Doctor summary (to see all details, run flutter doctor -v):
[โ] Flutter (Channel master, v1.9.8-pre.54, on Linux, locale en_US.UTF-8)
[โ] Android toolchain - develop for Android devices (Android SDK version 29.0.2)
[โ] Android Studio (version 3.5)
[โ] VS Code (version 1.37.1)
[โ] Connected device (1 available)
โข No issues found!
``` | a: text input,framework,f: material design,a: internationalization,a: typography,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-framework,triaged-framework | low | Major |
488,727,384 | flutter | doctor -v should display the previous version after a flutter upgrade | This will help bisect issues reported with `flutter doctor -v` output. | c: new feature,team,tool,t: flutter doctor,P3,team-tool,triaged-tool | low | Minor |
488,740,104 | pytorch | IValue pickle does not work properly if an empty tensor table is not provided | ## ๐ Bug
According to the description for the torch::jit::pickle API, the parameter tensor_table is optional. If not provided, the tensors are expected to be stored in the same byte stream as the pickle data. See https://github.com/pytorch/pytorch/blob/master/torch/csrc/jit/pickle.h#L9-L39.
However, if we only pass IValue without an empty tensor_table. The program will throw exception:
```
C++ exception with description "Expected length to be 8, got 10 (readInstruction at external/torch/torch/csrc/jit/pickler.cpp:654)
frame #0: <unknown function> + (0x7f8afbe1ee9f in [0x7f8afbe1ee9f])
frame #1: <unknown function> + (0x7f8afbe1ee3f in [0x7f8afbe1ee3f])
...
```
## To Reproduce
Steps to reproduce the behavior:
1. We can reuse the test case at https://github.com/pytorch/pytorch/blob/75c1419b46624e2bcd01709d93def0bceaaf05a2/test/cpp/api/jit.cpp#L115-L127 and only change:
```cpp
auto data = torch::jit::pickle(float_value, &tensor_table);
```
to
```cpp
auto data = torch::jit::pickle(float_value);
```
2. It would be better if we can test with more complex cases. For example:
```cpp
// Test of list of tensors
c10::List<torch::Tensor> list;
vector<torch::Tensor> tensor_table;
list.push_back(torch::rand({2, 3}));
list.push_back(torch::rand({3, 2}));
auto data = torch::jit::pickle(list, &tensor_table);
c10::IValue deserialized = torch::jit::unpickle(data.data(), data.size());
```
Or
```cpp
// Elements:
// list<dict<string, tensor>, dict<string, tensor>>
// 1x1 tensor
// 2x1 tensor
c10::impl::GenericList inputs = static_cast<c10::impl::GenericList>(c10::impl::deprecatedUntypedList());
torch::Dict<string, torch::Tensor> iDict1;
iDict1.insert("key1", torch::ones(1));
iDict1.insert("key2", torch::ones({2, 2}));
torch::Dict<string, torch::Tensor> iDict2;
iDict2.insert("key3", torch::rand({3, 3}));
iDict2.insert("key4", torch::rand({4, 4}));
// list<dict<string, tensor>, dict<string, tensor>>
torch::List<c10::Dict<string, torch::Tensor>> iComplex;
iComplex.push_back(iDict1);
iComplex.push_back(iDict2);
torch::jit::IValue tensorA = torch::ones(1);
torch::jit::IValue tensorB = torch::zeros({2, 1});
inputs.push_back(iComplex);
inputs.push_back(tensorA);
inputs.push_back(tensorB);
vector<char> data = torch::jit::pickle(inputs);
torch::IValue deserialized = torch::jit::unpickle(data.data(), data.size());
```
## Expected behavior
It would be expected that the deserialized IValue equals to the original IValue.
## Environment
Please copy and paste the output from our
[environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py)
(or fill out the checklist below manually).
You can get the script and run it with:
```
wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py
# For security purposes, please check the contents of collect_env.py before running it.
python collect_env.py
```
- PyTorch Version (e.g., 1.0): 50161f3b3c95635c82d43add453a7c1692eface1 (after 1.3)
- OS (e.g., Linux): Ubuntu 18.04.3 LTS
- How you installed PyTorch (`conda`, `pip`, source): source
- Build command you used (if compiling from source): bazel
- Python version: 3.4.10
- cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.6.2
- GPU models and configuration: GPU 0: Quadro P2000
- Nvidia driver version: 430.40
## Additional context
We are Uber ATG and this feature is requested by us (#23241. Thanks @driazati for working on it!). This feature was not included in pytorch 1.3.
cc @suo | oncall: jit,triaged,jit-backlog | low | Critical |
488,779,147 | kubernetes | Large CRDs go over size limits (e.g. those with embedded podspecs) | Over in KubeBuilder land, we've started to see issues around very large validation blocks going over size limits. Thus far, it's mainly just been the client-size-apply-induced annotation limit, but I worry that when we start getting multiple versions we might go over the 1M limit. For instance, see https://github.com/kubernetes-sigs/kubebuilder/issues/962, which has single-version 700k CRD, due to the large validation schema.
So far, we've mostly been able to solve the issues by partially or fully truncating the field descriptions, but this seems suboptimal, since you're basically saying "you don't get API docs now".
From what I've seen so far, the issues are usually hit with things like PodSpec (e.g. we hit the client-side-apply annotation limit with our conversion of CronJob in our tutorial when we introduced a new version).
Worst comes to worst, we can add more pruning in controller-tools/kubebuilder, but I was wondering if some folks had better ideas or more discussion upstream.
Refs (https://github.com/kubernetes/kubernetes/issues/62872) could help alleviate this a bit in the case of multiple podspecs, but don't solve the problem entirely (unless we get cross-object refs, which have previously been rejected).
Increasing the object size avoids the issue we *haven't* hit yet, but won't solve the client-side-apply annotation limit issue. Practically even though SSA will get here eventually, folks are going to be using pre-SSA kubectls for a while, I expect.
**TL;DR:** Pod spec validation makes CRDs large, any suggestions?
/sig api-machinery
| sig/api-machinery,kind/feature,priority/important-longterm,area/custom-resources,lifecycle/frozen | medium | Critical |
488,786,874 | flutter | flutter/packages should enforce an expected clang-format version | Right now our formatting tools use whatever version of `clang-format` is in the user's path, but CI always uses `clang-format-7`. Apparently this has also changed over time, since looking at the related issue #12864 there's some mention of CI using `clang-format-5`. Formatting differences from `clang-format` version mismatches are hard to diagnose and can even be introduced just from running the formatting tool without any arguments. Ideally `pub global run flutter_plugin_tools format` should know what `clang-format` version CI is expecting and either download it itself (ideal) or throw if it can't find it. | team,p: tooling,package,team-ecosystem,P3,triaged-ecosystem | low | Minor |
488,789,137 | kubernetes | Authentication audit logging - denote the authentication mechanism used. | **What would you like to be added**:
Logging for the authentication mechanism used by a user for requests to the API server.
**Why is this needed**:
At the moment Kubernetes does not put the mechanism used to authenticate a user into it's audit logs. As Kubernetes supports multiple authentication mechanisms, this could lead to a circumstance where an identical username is defined under different authentication schemes and it would be impossible to identify which had been used for a given request.
This is particularly serious in the case of client certificate authentication. As all that is required for the creation of client certificate credentials is access to the `ca.key` file for the cluster and credentials can be created using `openssl` commands, there may be no audit trail of users created with this mechanism.
An attacker who gained read-only access to that file would be able to create new credentials with the same usernames as users authenticated via other mechanisms, removing the ability of cluster operators to accurately audit user actions. | kind/feature,sig/auth,help wanted,priority/important-longterm,area/audit,lifecycle/frozen | medium | Major |
488,790,819 | three.js | Scene: background, fog and shadow. | This cycle I was hoping to do some API design clean up in the `Scene` object.
This is the current thinking:
### Background
Taking #16900 and #17199 into account...
```js
scene.background = new THREE.ColorBackground( color );
scene.background = new THREE.TextureBackground( texture, { fit: 'contain' } );
scene.background = new THREE.CubeTextureBackground( texture, { blurriness: 0.5, rotation: 90 * THREE.Math.DEG2RAD } );
```
Note: When using `THREE.CubeTextureBackground`, all meshes in the scene will use it as `material.envMap` by default so it'll be easier for users to get good looking results.
### Fog
Taking #17355 into account...
```js
scene.fog = new THREE.RangeFog( color, near, far );
scene.fog = new THREE.ExponentialFog( color, density );
scene.fog = new THREE.ExponentialSquaredFog( color, density );
```
### Shadow
I thought that we could also move `WebGLRenderer.shadowMap` to `Scene` as `Scene.shadow` so it can be serialised (and will allow us to do some API redesign too).
```js
scene.shadow = new THREE.PCFShadow();
scene.shadow = new THREE.VSMShadow();
scene.shadow = new THREE.PCSSShadow();
```
Suggestions? Improvements?
/cc @WestLangley @Mugen87 @bhouston @sunag @DanielSturk @supereggbert @EliasHasle | Design | medium | Critical |
488,817,668 | pytorch | Avoid non-POD data in thread_local | I have heard that @jamesr66a ran benchmarks indicating that thread local access in PyTorch was quite slow. While most of the overhead is probably coming from the mandatory use of `_tls_getaddr()` which happens when you compile with `-fPIC`, a little bit of overhead is probably also coming from the extra wrapper code that has to be inserted if you put a non-POD data type in `thread_local`: https://godbolt.org/z/gm_tjb
Many of our classes are non-POD for not very good reasons (e.g., most wrappers on integer representations are non-POD, simply due to the fact that they define some constructors). When these classes are put in `thread_local`, you get the bad wrapper code, even if the zero-initialized POD representation would have been good enough. So, instead of:
```
thread_local TensorTypeSet x;
TensorTypeSet tls_get_x() {
return x;
}
```
write instead:
```
static thread_local uint64_t x;
TensorTypeSet tls_get_x() {
return TensorTypeSet(x);
}
```
and you will get marginally better code in this case (it's also better to make sure the variable is static or in an anonymous namespace). Probably doesn't matter for most TLS variables, but we have a few which are very heavily trafficked... | module: performance,triaged,module: multithreading,better-engineering | low | Major |
488,822,749 | TypeScript | Add ElementInternals, attachInternals from HTML standard | **TypeScript Version:** 3.5.2
**Search Terms:** ElementInternals, attachInternals
**Code**
```ts
let internals: ElementInternals;
```
**Expected behavior:**
No errors. The [`ElementInternals`](https://html.spec.whatwg.org/multipage/custom-elements.html#the-elementinternals-interface) interface and the related `attachInternals` method on `HTMLElement` are recent additions to the DOM spec. They are supported in Chrome 78 (scheduled for public release at the end of October 2019) and Edge canary builds.
**Actual behavior:**
Error `Cannot find name 'ElementInternals'.`
**Playground Link:** https://www.typescriptlang.org/play/#code/DYUwLgBAlgdmICcYENgGcBcECioC2IcAknIiugNwBQQA
| Bug,Domain: lib.d.ts | medium | Critical |
488,915,182 | go | cmd/go: allow serving module under the subdirectory of git repository | **NOTE**: The accepted proposal is https://github.com/golang/go/issues/34055#issuecomment-785279844.
- - -
If you head to [https://github.com/nhooyr/websocket](https://github.com/nhooyr/websocket/tree/93d751f3b3fdfa806f4ae3f49fa1bf4e31cee04c) presently, you'll get blasted with a massive root directory listing, mostly due to all the Go files. It's obnoxious.
Compare that to https://github.com/nhooyr/websocket/tree/067b40e227d0d6af9e399c1efe0dd80efae1b79f where the Go module has been moved to the subdirectory `./mod` inside the repository.
See https://github.com/nhooyr/websocket/pull/136
So I want to move the Go module to the subdirectory `./mod` inside the repository and serve that subdirectory for the `nhooyr.io/websocket` import path but it doesn't look like there is an easy way to do that.
The go-import meta tag only allows me to specify the import path of the repository, which in this case would make it `nhooyr.io/websocket/mod` which is nasty. I want to serve the subdirectory directly under `nhooyr.io/websocket`. Looks like I can do this with the new mod vcs to the go-import tag but then I have to run my own module server which I want to ideally avoid.
Is this something that would be considered or is already possible? | Proposal,Proposal-Accepted,FeatureRequest,GoCommand,modules,FixPending | high | Critical |
488,952,554 | pytorch | [C++] Support negative index in `torch::TensorAccessor::size()` | ## ๐ Feature
<!-- A clear and concise description of the feature proposal -->
Add support for negative indices in `torch::TensorAccessorBase::size()` and `torch::PackedTensorAccessorBase::size()`
## Motivation
<!-- Please outline the motivation for the proposal. Is your feature request related to a problem? e.g., I'm always frustrated when [...]. If this is related to another GitHub issue, please link here too -->
Negative indices are widely used in LibTorch. For example, `torch::Tensor::size()` has proper support for index like `-1`. It would be great if `torch::TensorAccessor::size()` and `torch::PackedTensorAccessor::size()` could have such supports as well.
## Pitch
<!-- A clear and concise description of what you want to happen. -->
Add support for negative indices in `torch::TensorAccessor::size()` and `torch::PackedTensorAccessor::size()`
## Alternatives
<!-- A clear and concise description of any alternative solutions or features you've considered, if any. -->
## Additional context
<!-- Add any other context or screenshots about the feature request here. -->
cc @yf225 | module: cpp,triaged | low | Minor |
488,972,667 | fastapi | document response in depends | **Is your feature request related to a problem? Please describe.**
No not related to a problem.
I'm using ` fastapi.security.api_key.APIKeyCookie` as a depends and it may raise `HTTPException(403, detail="Not authenticated")` for any router it is used. So i have to document a 403 responses in all related router.
**Describe the solution you'd like**
Could there by a way when I'm using a class as Depends, document responses once as a class member or some thing else instead of document it many times in routers as fastAPI could find all depends of a router.
| feature,confirmed,reviewed | low | Major |
488,998,049 | pytorch | [distributed] all_gather on a List of Tensors directly | ## ๐ Feature
Now, latest pytorch version only gather or reduce the single tensor from different nodes a time. So we need use a loop to aggregate all tensors of the model on different nodes. if my understanding is not wrong, it needs much communication time and is very time-consuming, so I want to know whether there are ways to gather the tensor list (or gather all the tensors of a model) a time, not gather a tensor a time.
cc @pietern @mrshenli @pritamdamania87 @zhaojuanmao @satgera @rohan-varma @gqchen @aazzolini @xush6528 | oncall: distributed,module: bootcamp,triaged,enhancement | low | Major |
489,034,160 | go | net/http: error message in case of bad certificate leaks implementation details in Go 1.13 | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/cuonglm/Library/Caches/go-build"
GOENV="/Users/cuonglm/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/cuonglm/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/Users/cuonglm/sdk/go1.13"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/Users/cuonglm/sdk/go1.13/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/y4/hs76ltbn7sb66lw_6934kq4m0000gn/T/go-build839999394=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
```
$ export GO111MODULE=off
$ go1.13 get -d github.com/loadimpact/k6
$ cd $GOPATH/src/github.com/loadimpact/k6/js
$ go1.13 test -count=1 -race -run=TestVUIntegrationClientCerts/Unauthenticated
--- FAIL: TestVUIntegrationClientCerts (5.16s)
--- FAIL: TestVUIntegrationClientCerts/Unauthenticated (0.56s)
--- FAIL: TestVUIntegrationClientCerts/Unauthenticated/Source (0.11s)
Error Trace: runner_test.go:1168
Error: Error message not equal:
expected: "GoError: Get https://127.0.0.1:51407: remote error: tls: bad certificate"
actual : "GoError: Get https://127.0.0.1:51407: readLoopPeekFailLocked: remote error: tls: bad certificate"
Test: TestVUIntegrationClientCerts/Unauthenticated/Source
--- FAIL: TestVUIntegrationClientCerts/Unauthenticated/Archive (0.11s)
Error Trace: runner_test.go:1168
Error: Error message not equal:
expected: "GoError: Get https://127.0.0.1:51407: remote error: tls: bad certificate"
actual : "GoError: Get https://127.0.0.1:51407: readLoopPeekFailLocked: remote error: tls: bad certificate"
Test: TestVUIntegrationClientCerts/Unauthenticated/Archive
FAIL
exit status 1
FAIL github.com/loadimpact/k6/js 5.344s
```
### What did you expect to see?
Test passed.
### What did you see instead?
Test failed.
**Note**
- The test will pass with go1.11 to go1.12.9 or go1.13 without `-race`.
- The problem also occurs in `linux/amd64`. | NeedsInvestigation | low | Critical |
489,046,571 | go | cmd/go: emit an explicit error when packages in GOPATH/src/vendor overlap with GOROOT/src/vendor | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.13 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
only in go1.13 happened, back to go1.12.9 can fix this
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/username/Library/Caches/go-build"
GOENV="/Users/username/Library/Application Support/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH=""
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/b1/bhf9j3q96m75223l3hh41ccw0000gn/T/go-build173249759=/tmp/go-build -gno-record-gcc-switches -fno-common"
</pre></details>
### What did you do?
<!--
If possible, provide a recipe for reproducing the error.
A complete runnable program is good.
A link on play.golang.org is best.
-->
go install -v ./...
### What did you expect to see?
no errrors
### What did you see instead?
src/vendor/golang.org/x/net/http2/frame.go:17:2: use of vendored package not allowed
src/vendor/google.golang.org/grpc/internal/transport/controlbuf.go:28:2: use of vendored package not allowed
src/vendor/golang.org/x/net/http2/transport.go:35:2: use of vendored package not allowed | NeedsFix,modules | medium | Critical |
489,068,684 | flutter | [google_maps_flutter] Change camera animation speed (and curve?) | Hey there,
Awesome work on the plugin, loving it! I was wondering if there is currently a way to change the animation speed of the `.animateCamera` method and if not, is it planned for a future release?
Cheers
| c: new feature,customer: crowd,p: maps,package,team-ecosystem,P3,triaged-ecosystem | high | Critical |
489,071,230 | godot | Children of ARVRCamera aren't at the expected position | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:**
<!-- Specify commit hash if non-official. -->
3.1.1
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Windows 10, Oculus Rift (with OpenVR plugin)
**Issue description:**
<!-- What happened, and what was expected. -->
I'd like to have a mesh which is always directly in front of the ARVRCamera. However, when moving the VR headset, this does not work as expected: The mesh is not in front of the camera, but at or close to the coordinate origin. Rotation does seem to be applied to the mesh in some way.
Trying the same with a normal Camera or an uninitialized ARVRCamera (no VR headset) yields the expected results (the mesh stays in the same position relative to the camera).
I wasn't sure whether to open this issue here or at https://github.com/GodotVR/godot_openvr. If this is the wrong place, please let me know and I'll open it there.
| documentation,topic:xr | low | Major |
489,079,230 | neovim | "nvim -u NONE --headless" does not log "Nvim exit" on SIGINT | Running `nvim -u NONE --headless` and using `Ctrl-C` there then only logs:
```
INFO 2019-09-04T12:20:56.499 7898 main:564: starting main loop
```
It could handle SIGINT in this case (no UI attached), and call `ex_cquit` then maybe?
OTOH it might be feasible to explicitly not call the normal exit routines (possibly involving autocommands) - but logging this somehow should still be done. | bug,system,logging | low | Minor |
489,140,572 | rust | File::open() on directories does not return Err(), leads to breakage with BufReader | I tripped onto some odd behaviour.
I was under the assumption calling `File::open()` on a directory would Err(), and that I could use that to handle a user specifying a path that was not a file, ( instead of falling prey to race conditions by stat-ing first and then opening second ).
However, ... bad things happened instead.
```rust
use std::path::PathBuf;
use std::fs::File;
use std::io::BufRead;
use std::io::BufReader;
fn main() {
let file = File::open(PathBuf::from("/tmp")).unwrap();
let buf = BufReader::with_capacity(100, file);
let _lines: Vec<std::io::Result<String>> = buf.lines().collect();
}
```
The last of these lines will run forever, with strace reporting:
```
read(3, 0x564803253b80, 100) = -1 EISDIR (Is a directory)
```
Over and over again ad-infinitum with no end in sight.
Somehow I had a variation of this go crazy and eat 200% of my ram, but I'm having a hard time reproducing that exact case (Though it may have been related to the target-directory in question also being massive in my case).
Digging shows related bug #43504
The profound question that remains unanswered is: "Why is calling File::open on a directory fine?"
And the residual question is "How does one invoke File::open in such a way that it refuses to work on directories".
And importantly, how do I achieve that portably?
And if none of these concerns can be mitigated, the very least that could be done is have this giant foot-gun documented somewhere in `File::open`.
( As far as I can divine, there's no useful behaviour to be found by allowing File::open to work on directories, as standard read() semantics simply don't work on directory filehandles, you have to use readdir() )
| C-enhancement,T-libs-api,A-docs,A-io | medium | Critical |
489,197,219 | pytorch | libtorch forward memory leak | when I input arbitrary size to my network, the memory will increase all the timeใbut when i fix my input on 224 * 224, the memory will not increase!
I have tried export my network using torch.jit.script and torch.jit.trace. this problem always exist !
by the way, I use libtorch1.1
cc @yf225 | module: cpp,module: memory usage,triaged | low | Major |
489,218,367 | pytorch | Torch.jit.trace unexpected error with `torch.cat(โฆ, dim=-1)` | Find below a Minimum Reproducible Example that crashes both in Pytorch 1.1 and Pytorch 1.2 with CUDA (it works with CPU).
```
import torch
from torch import nn
device = torch.device('cuda') # crashes with cuda, works with cpu
class Model(nn.Module):
def __init__(self):
super().__init__()
self.linear1 = nn.Linear(2, 16)
self.linear2 = nn.Linear(2, 16)
def forward(self, x, y):
x = self.linear1(x)
y = self.linear2(y)
return torch.cat([x, y], dim=-1) # if we replace -1 with 1 works fine with either GPU or CPU
model = Model().to(device)
data = [torch.randn(1, 2).to(device), torch.randn(1, 2).to(device)]
traced = torch.jit.trace(model, data)
print(traced)
```
Surprisingly the above works with CPU backend but not with CUDA backend. It also works when `torch.cat(..., dim=1)` but crashes with a negative dimension referring to the same one `torch.cat(..., dim=-1)`.
Find the jit.trace error below (not very explanatory):
```
torch.jit.TracingCheckError: Tracing failed sanity checks!
Encountered an exception while running the trace with test inputs.
Exception:
vector::_M_range_check: __n (which is 18446744073709551615) >= this->size() (which is 2)
The above operation failed in interpreter, with the following stack trace:
```
cc @suo | oncall: jit,triaged | low | Critical |
489,240,237 | go | net/http: on CheckRedirect failure, error message should refer to the original (redirected) URL, not the rejected redirect | ### What version of Go are you using (`go version`)?
<pre>
example.com$ go1.13 version
go version go1.13 linux/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
example.com$ go1.13 env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/usr/local/google/home/bcmills/.cache/go-build"
GOENV="/usr/local/google/home/bcmills/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/tmp/tmp.V4fL5k5JdS/_gopath"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/google/home/bcmills/sdk/go1.13"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/google/home/bcmills/sdk/go1.13/pkg/tool/linux_amd64"
GCCGO="/usr/local/google/home/bcmills/bin/gccgo"
AR="ar"
CC="gcc"
CXX="c++"
CGO_ENABLED="1"
GOMOD="/tmp/tmp.V4fL5k5JdS/example.com/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build400745746=/tmp/go-build -gno-record-gcc-switches"
</pre></details>
### What did you do?
Ran the program found at https://play.golang.org/p/42egMHzeuTR.
<details>
```
example.com$ cat >./main.go <<EOF
package main
import (
"fmt"
"net/http"
)
var securityPreservingHTTPClient = &http.Client{
CheckRedirect: func(req *http.Request, via []*http.Request) error {
if len(via) > 0 && via[0].URL.Scheme == "https" && req.URL.Scheme != "https" {
lastHop := via[len(via)-1].URL
return fmt.Errorf("redirected from secure URL %s to insecure URL %s", lastHop, req.URL)
}
return nil
},
}
func main() {
_, err := securityPreservingHTTPClient.Get("https://vcs-test.golang.org/insecure/go/insecure")
fmt.Println(err)
}
EOF
example.com$ cat >./go.mod <<EOF
module example.com
go 1.13
EOF
example.com$ go1.13 run .
```
</details>
### What did you expect to see?
```
Get "https://vcs-test.golang.org/insecure/go/insecure": redirected from secure URL https://vcs-test.golang.org/insecure/go/insecure to insecure URL http://vcs-test.golang.org/go/insecure
```
Since the `http.Client` should not have attempted to fetch the insecure URL in the first place, the insecure URL should not be the one reported for the failed `Get` operation.
### What did you see instead?
```
Get "http://vcs-test.golang.org/go/insecure": redirected from secure URL https://vcs-test.golang.org/insecure/go/insecure to insecure URL http://vcs-test.golang.org/go/insecure
```
The URL that follows the `Get` token is one for which no HTTP `GET` was actually attempted.
CC @bradfitz | NeedsInvestigation | low | Critical |
489,246,622 | material-ui | Errors when dynamically importing components | <!--
Thank you very much for contributing to Material-UI by creating an issue! โค๏ธ
To avoid duplicate issues we ask you to check off the following list.
-->
<!-- Checked checkbox should look like this: [x] -->
- [x] The issue is present in the latest release.
- [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate.
## Current Behavior ๐ฏ
When doing a dynamic import with an expression that can only be evaluated at run-time (e.g. `import('@material-ui/core/' + window.buttonComponentName)`), there are a bunch of errors, e.g. (just to list one of them):
> Error: Can't resolve './props' in '/Users/mbrowne/_temp/react-webpack-error-template/node_modules/@material-ui/core/styles'
Interestingly, in my demo repo, the button actually still renders despite the errors, but you can't do a production build.
## Expected Behavior ๐ค
Dynamic imports should work without errors
## Steps to Reproduce ๐น
Clone the `material-ui-dynamic-imports` branch of my [demo repo](https://github.com/mbrowne/react-webpack-error-template/tree/material-ui-dynamic-imports):
`git clone [email protected]:mbrowne/react-webpack-error-template.git --single-branch --branch material-ui-dynamic-imports`.
Run `yarn start` and you'll see the compile errors (both at the command line and in the browser console).
## Context ๐ฆ
A practical use case for doing this would be receiving the name/ID of which component to use for rendering something from an API response, so that the import would really need to be fully dynamic. `window.buttonComponentName` (if set elsewhere, e.g. in index.html) mimics such a fully dynamic import.
## Details
The errors are probably at least partially due to issues with webpack. I tried a very simple test module with a fake Button component (instead of material-ui), and I was still getting warnings and errors as soon as I introduced `.d.ts` files, even if I removed the `typings` entry from the `package.json` of the test module. It seems that fully dynamic imports cause webpack to scan the entire package being imported (at build time) no matter what, including `.d.ts` files.
So as an experiment, I tried removing all the `.d.ts` files and many of the errors went away. There were some remaining errors related to `test-utils`, so I tried deleting `test-utils`, `es/test-utils`, and `esm/test-utils`, and those errors went away too. Afterwards there were only a couple warnings leftโ"unexpected character" and "unexpected token"s in the markdown files and the LICENSE file, which obviously aren't JS files.
I'm not sure what, if anything, that material-ui can do about all of this, since clearly webpack is doing something odd here, but I wanted to report it so you all are aware.
## Your Environment ๐
| Tech | Version |
| ----------- | ------- |
| Material-UI | v4.4.0 |
| React | 16.9.0 |
| Browser | Chrome 76 |
| Webpack | 4.39.3 | | new feature,performance | low | Critical |
489,310,713 | flutter | Better handling of malformed yaml for plugins | https://github.com/flutter/flutter/pull/38632 added support for adding/extracting new information about plugins in a yaml file, but the validation of the yaml needs improvement. See my comments on the PR for details.
Failing to improve the validation will lead to unhandled exceptions reported to crash logging for problems that only the end-user can address. | team,c: crash,tool,a: quality,P2,team-tool,triaged-tool | low | Critical |
489,338,126 | pytorch | finfo operator not bound into JIT | ## ๐ Bug
When calling torch.jit.script() on code using torch.finfo, a Runtime Error is generated with:
`Unknown builtin op: aten::finfo.`
## To Reproduce
Steps to reproduce the behavior:
1. Use `torch.finfo(torch.float32).eps` in an expression in a forward() function
1. Tag forward() with `@torch.jit.script`
1. Run model
class Foo(torch.autograd.Function):
@torch.jit.script
... in script
fn = torch._C._jit_script_compile(qualified_name, ast, _rcb, get_default_args(obj))
RuntimeError:
Unknown builtin op: aten::finfo.
Here are some suggestions:
aten::find
The original call is:
bar = torch.clamp(bar, min=torch.finfo(torch.float32).eps)
~~~~~~~~~~~ <--- HERE
## Expected behavior
Model to compile and execute
## Environment
`
PyTorch version: 1.3.0a0+f3f83cc
Is debug build: Yes
CUDA used to build PyTorch: None
OS: CentOS Linux 7 (Core)
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
CMake version: version 3.14.0
Python version: 3.7
Is CUDA available: No
CUDA runtime version: No CUDA
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
Versions of relevant libraries:
[pip] numpy==1.16.4
[pip] torch==1.3.0a0+f3f83cc
[conda] blas 1.0 mkl
[conda] mkl 2019.4 243
[conda] mkl-include 2019.4 243
[conda] mkl_fft 1.0.12 py37ha843d7b_0
[conda] mkl_random 1.0.2 py37hd81dba3_0
[conda] torch 1.3.0a0+d806257 pypi_0 pypi
`
cc @suo | oncall: jit,triaged,jit-backlog | low | Critical |
489,374,545 | rust | E0207 when type parameter's associated type is used in `Self`. | Not sure if this needs to be an error or not.
Per `rustc --explain E0207`, `impl` type parameter are acceptable if they appear in the `Self` type of the `impl`. Emphasis mine:
>Any type parameter or lifetime parameter of an `impl` must meet at least one of
>the following criteria:
>
> - **it appears in the _implementing type_ of the impl, e.g. `impl<T> Foo<T>`**
> - for a trait impl, it appears in the _implemented trait_, e.g.
`impl<T> SomeTrait<T> for Foo`
> - it is bound as an associated type, e.g. `impl<T, U> SomeTrait for T
where T: AnotherTrait<AssocType=U>`
Rustc currently generates an error even if an associated type of the parameter appears in the `Self` type: [playground link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=da0a2f797e01058a852dd82ea70b5e7e):
```rust
trait Field {}
trait Vector {
type MyField: Field;
}
struct BaseFieldPrinter<F: Field>;
impl<V: Vector> BaseFieldPrinter<V::MyField> {
}
```
It seems like this doesn't need to be an error, but perhaps I'm missing something? | C-enhancement,A-diagnostics,A-associated-items,T-compiler | low | Critical |
489,385,794 | flutter | [iOS] video_player plays mp3 on Android, but not on iOS | The video_player plugin appears to behave differently on Android and iOS depending on the file extension used - Android will load a mis-named file and do a best effort, iOS just silently fails.
While this is definitely an edge case that might not need to be supported at all, the different behavior on the two platforms made hunting down the root cause a little more confusing than usual.
Thanks for considering!
## Steps to Reproduce
1. Create an .mp4 video `file` with an .mp3 `extension`, such as: https://res.cloudinary.com/demo/video/upload/f_mp4/dog.mp3.
2. Add this to the `video_player` [example app](https://github.com/flutter/plugins/tree/master/packages/video_player#example):
```dart
_controller = VideoPlayerController.network(
'https://res.cloudinary.com/demo/video/upload/f_mp4/dog.mp3')
..initialize().then((_) {
// Ensure the first frame is shown after the video is initialized, even before the play button has been pressed.
setState(() {});
});
```
3. Build & run on Android & iOS - the video plays on Android, and does not on iOS.
4. Note that with cloudinary you can provide different extensions - the /f_mp4/ part of the path is forcing the file format. Re-run the app using an .mp4 extension to verify that the iOS build can load the video: https://res.cloudinary.com/demo/video/upload/f_mp4/dog.mp4
## Logs
<!--
Run your application with `flutter run --verbose` and attach all the
log output below between the lines with the backticks. If there is an
exception, please see if the error message includes enough information
to explain how to solve the issue.
-->
```
โ> ~/D/video_player_test flutter run --verbose
...
[ +3 ms] ๐ฅ To hot reload changes while running, press "r". To hot restart (and rebuild state), press "R".
[ ] An Observatory debugger and profiler on bigbubble is available at: http://127.0.0.1:1029/eKHkw2VM5DQ=/
[ ] For a more detailed help message, press "h". To detach, press "d"; to quit, press "q".
```
<!--
Run `flutter analyze` and attach any output of that command below.
If there are any analysis errors, try resolving them before filing this issue.
-->
```
โ> ~/D/video_player_test flutter analyze 13:39:09
Analyzing video_player_test...
No issues found! (ran in 4.9s)
```
<!-- Finally, paste the output of running `flutter doctor -v` here. -->
```
โ> ~/D/video_player_test flutter doctor -v 13:39:20
[โ] Flutter (Channel stable, v1.7.8+hotfix.4, on Mac OS X 10.14.6 18G87, locale en-US)
โข Flutter version 1.7.8+hotfix.4 at /Users/deg/Development/flutter
โข Framework revision 20e59316b8 (7 weeks ago), 2019-07-18 20:04:33 -0700
โข Engine revision fee001c93f
โข Dart version 2.4.0
[โ] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
โข Android SDK at /Users/deg/Library/Android/sdk
โข Android NDK location not configured (optional; useful for native profiling support)
โข Platform android-28, build-tools 28.0.3
โข Java binary at: /Users/deg/Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
โข Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
โข All Android licenses accepted.
[โ] Xcode - develop for iOS and macOS (Xcode 10.3)
โข Xcode at /Applications/Xcode.app/Contents/Developer
โข Xcode 10.3, Build version 10G8
โข CocoaPods version 1.7.5
[โ] iOS tools - develop for iOS devices
โข ios-deploy 1.9.4
[โ] Android Studio (version 3.4)
โข Android Studio at /Users/deg/Applications/Android Studio.app/Contents
โข Flutter plugin version 37.1.1
โข Dart plugin version 183.6270
โข Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01)
[โ] VS Code
โข VS Code at /Users/deg/Applications/Visual Studio Code.app/Contents
โข Flutter extension version 3.4.1
[โ] Connected device (1 available)
โข bigbubble โข 00008027-001A51A036EB002E โข ios โข iOS 12.4.1
โข No issues found!
```
| platform-ios,d: api docs,p: video_player,package,P3,team-ios,triaged-ios | low | Critical |
489,405,937 | go | errors, cmd/vet: too easy to pass a pointer-to-pointer to `errors.As` when it should be a pointer-to-value | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
pi@raspberrypi:~/temper/go/blort $ go version
go version go1.13 linux/arm
pi@raspberrypi:~/temper/go/blort $
</pre>
### Does this issue reproduce with the latest release?
I am using the latest release.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
pi@raspberrypi:~/temper/go/blort $ go env
GO111MODULE=""
GOARCH="arm"
GOBIN=""
GOCACHE="/home/pi/.cache/go-build"
GOENV="/home/pi/.config/go/env"
GOEXE=""
GOFLAGS=""
GOHOSTARCH="arm"
GOHOSTOS="linux"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/pi/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_arm"
GCCGO="gccgo"
GOARM="6"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/home/pi/temper/go/blort/go.mod"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -marm -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build073091018=/tmp/go-build -gno-record-gcc-switches"
pi@raspberrypi:~/temper/go/blort $
</pre></details>
### What did you do?
I've been exploring the new `errors.As()` and wasn't able to get it to recognize a wrapped `syscall.Errno`. I've distilled a simpler case. Here is a [playground link](https://play.golang.org/p/eD-97z1XhYO)
```go
package main
import (
"fmt"
"syscall"
"errors"
"os"
"reflect"
)
func main() {
e1 := &os.PathError{Op: "read", Path: "/", Err: errors.New("YIKES")}
var pe *os.PathError
if errors.As(e1, &pe) {
fmt.Println("Found an os.PathError")
}
e2 := syscall.Errno(1)
var se *syscall.Errno
fmt.Println("Type of e2 is: ", reflect.TypeOf(e2))
if errors.As(e2, &se) {
fmt.Println("Found a syscall.Errno")
}
}
```
### What did you expect to see?
```
Found an os.PathError
Type of e2 is: syscall.Errno
Found a syscall.Errno
```
### What did you see instead?
```
Found an os.PathError
Type of e2 is: syscall.Errno
``` | NeedsInvestigation,Analysis | low | Critical |
489,465,120 | scrcpy | SendKeys using app, only numbers received in phone | Hi, i'm trying to send string to the android window using application (simple c++);
The strangest thing is... when I send "123abc", in Android text box only received "123"
At first I think this is the problem with the keyboard (I used null keyboard), but after switching to several keyboards.. I believe scrcpy doesn't *fully* process the input generated by app?
When I typed normally.. no problem,,,, but when the typing is generated by app, only numbers received by phone omitting (a-z). Is this known issue? thanks.
| input events,keyboard | low | Minor |
489,473,288 | godot | KinematicBody still able to move Rigidbodies and VehicleBodies when infinite inertia disabled | ___
***Bugsquad edit:** This issue has been confirmed several times already. No need to confirm it further.*
___
**Godot version:** 3.1.1
**OS/device including version:** Ubuntu 19.04
**Issue description:**
According to the documentation, setting infinite inertia to false on a KinematicBody should make so it cannot move RigidBodies. However, when I disable it, I'm still able to move rigidbodies
**Minimal reproduction project:**
WASD movement
space to jump
mouse look
exit to escape
try pushing or jumping on the trucks, one uses VehicleBody and the other Rigidbody.
If you check the player script you can uncomment and use move_and_slide, move_and_slide_and_snap, and move_and_collide. All will move the trucks.
[clustertruckclone.zip](https://github.com/godotengine/godot/files/3576978/clustertruckclone.zip)
| bug,confirmed,topic:physics,topic:3d | medium | Critical |
489,489,418 | rust | Distinguish between fenced and indented code blocks in error message | EDIT: It turns out that the issue I was facing was caused by my doc comment being interpreted as a code block, based on the indented code block rule in markdown.
--
## Summary
The following doc comment fails to compile using `cargo test --doc`:
```rust
///
/// \
///x
```
Example repository [here](https://github.com/lightclient/rust-doc-comment-bug).
## Error Output
```console
> cargo test --doc
Finished dev [unoptimized + debuginfo] target(s) in 0.00s
Doc-tests weird
running 1 test
test src/lib.rs - main (line 2) ... FAILED
failures:
---- src/lib.rs - main (line 2) stdout ----
error: unknown start of token: \
--> src/lib.rs:3:1
|
3 | \
| ^
error: aborting due to previous error
Couldn't compile the test.
failures:
src/lib.rs - main (line 2)
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out
error: test failed, to rerun pass '--doc'
```
## What I've Tried
I've found a few things (I'm sure this is not an exhaustive list to describe the problem):
* There must be an empty line above the backslash
* There must be a non-empty line below the backslash
* There must be at least 4 spaces between the backslash and the doc comment `///`
## Expected
The snippet compiles without issue.
## Meta
I've verified the issue is present using `1.37.0` on both `x86_64-apple-darwin` and `x86_64-unknown-linux-gnu`. | T-rustdoc,C-enhancement,A-diagnostics,A-docs,A-doctests | low | Critical |
489,504,089 | TypeScript | keyof T should never print as a union of strings | <!-- ๐จ STOP ๐จ ๐ฆ๐ง๐ข๐ฃ ๐จ ๐บ๐ป๐ถ๐ท ๐จ
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.6.2
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:** extends keyof generic
**Code**
```ts
export const bindEvent = <Node extends HTMLElement | HTMLDocument,
K extends keyof HTMLElementEventMap>(
node: Node,
type: K,
callback: (event: HTMLElementEventMap[K]) => unknown,
) => {
node.addEventListener(type, callback as EventListener);
return () => {
node.removeEventListener(type, callback as EventListener);
};
};
tsc
```
**Expected behavior:**
The generic `K` to still be extends keyof, instead of spreading the type out.
**Actual behavior:**
types generated:
```ts
export declare const bindEvent: <Node_1 extends HTMLElement | HTMLDocument, K extends "fullscreenchange" | "fullscreenerror" | "abort" | "animationcancel" | "animationend" | "animationiteration" | "animationstart" | "auxclick" | "blur" | "cancel" | "canplay" | "canplaythrough" | "change" | "click" | "close" | "contextmenu" | "cuechange" | "dblclick" | "drag" | "dragend" | "dragenter" | "dragexit" | "dragleave" | "dragover" | "dragstart" | "drop" | "durationchange" | "emptied" | "ended" | "error" | "focus" | "focusin" | "focusout" | "gotpointercapture" | "input" | "invalid" | "keydown" | "keypress" | "keyup" | "load" | "loadeddata" | "loadedmetadata" | "loadend" | "loadstart" | "lostpointercapture" | "mousedown" | "mouseenter" | "mouseleave" | "mousemove" | "mouseout" | "mouseover" | "mouseup" | "pause" | "play" | "playing" | "pointercancel" | "pointerdown" | "pointerenter" | "pointerleave" | "pointermove" | "pointerout" | "pointerover" | "pointerup" | "progress" | "ratechange" | "reset" | "resize" | "scroll" | "securitypolicyviolation" | "seeked" | "seeking" | "select" | "selectionchange" | "selectstart" | "stalled" | "submit" | "suspend" | "timeupdate" | "toggle" | "touchcancel" | "touchend" | "touchmove" | "touchstart" | "transitioncancel" | "transitionend" | "transitionrun" | "transitionstart" | "volumechange" | "waiting" | "wheel" | "copy" | "cut" | "paste">(node: Node_1, type: K, callback: (event: HTMLElementEventMap[K]) => unknown) => () => void;
```
| Suggestion,In Discussion | low | Critical |
489,513,737 | flutter | [google_maps_flutter] Markers do not obey consumeTapEvents configuration | If you set Marker.consumeTapEvents I would expect the onTap handler not to be called. Currently the event is passed to onTap.
When setting consumeTapEvents to false for Polygons, Polylines, Circles etc. the click handler is not attached to the element, for markers there is no option to disable the click listener in the Google Maps implementation so the result needs to be filtered out in the marker click listener.
Both iOS and Android are affected.
| p: maps,package,team-ecosystem,has reproducible steps,P2,found in release: 2.3,triaged-ecosystem | low | Minor |
489,550,613 | pytorch | [dataloader] Hang because of too many open files (and probably some process dead) | After many hours of training I got this. After this the training process is hung (maybe during running the finalizers). I imagine some workers are killed, and the main process somehow can't detect that.
Unfortunately the backtrace isn't very easy to parse (I forced a core dump using `kill -QUIT pid`)
```
Traceback (most recent call last):
File "/miniconda/lib/python3.7/multiprocessing/queues.py", line 236, in _feed
File "/miniconda/lib/python3.7/multiprocessing/reduction.py", line 51, in dumps
File "/miniconda/lib/python3.7/site-packages/torch/multiprocessing/reductions.py", line 327, in reduce_storage
File "/miniconda/lib/python3.7/multiprocessing/reduction.py", line 194, in DupFd
File "/miniconda/lib/python3.7/multiprocessing/resource_sharer.py", line 48, in __init__
OSError: [Errno 24] Too many open files
Traceback (most recent call last):
File "/miniconda/lib/python3.7/multiprocessing/queues.py", line 236, in _feed
File "/miniconda/lib/python3.7/multiprocessing/reduction.py", line 51, in dumps
File "/miniconda/lib/python3.7/site-packages/torch/multiprocessing/reductions.py", line 327, in reduce_storage
File "/miniconda/lib/python3.7/multiprocessing/reduction.py", line 194, in DupFd
File "/miniconda/lib/python3.7/multiprocessing/resource_sharer.py", line 48, in __init__
OSError: [Errno 24] Too many open files
root@faece257e5fe:/deepspeech.pytorch/convasr# Traceback (most recent call last):
Traceback (most recent call last):
Traceback (most recent call last):
Traceback (most recent call last):
File "/miniconda/lib/python3.7/multiprocessing/util.py", line 265, in _run_finalizers
finalizer()
File "/miniconda/lib/python3.7/multiprocessing/util.py", line 265, in _run_finalizers
finalizer()
File "/miniconda/lib/python3.7/multiprocessing/util.py", line 189, in __call__
res = self._callback(*self._args, **self._kwargs)
File "/miniconda/lib/python3.7/multiprocessing/util.py", line 189, in __call__
res = self._callback(*self._args, **self._kwargs)
File "/miniconda/lib/python3.7/shutil.py", line 491, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/miniconda/lib/python3.7/shutil.py", line 410, in _rmtree_safe_fd
onerror(os.scandir, path, sys.exc_info())
File "/miniconda/lib/python3.7/shutil.py", line 406, in _rmtree_safe_fd
with os.scandir(topfd) as scandir_it:
Traceback (most recent call last):
Traceback (most recent call last):
File "/miniconda/lib/python3.7/shutil.py", line 491, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/miniconda/lib/python3.7/multiprocessing/util.py", line 265, in _run_finalizers
finalizer()
OSError: [Errno 24] Too many open files: '/tmp/pymp-gy1ijv6t'
File "/miniconda/lib/python3.7/multiprocessing/util.py", line 189, in __call__
res = self._callback(*self._args, **self._kwargs)
Traceback (most recent call last):
File "/miniconda/lib/python3.7/shutil.py", line 491, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/miniconda/lib/python3.7/shutil.py", line 410, in _rmtree_safe_fd
onerror(os.scandir, path, sys.exc_info())
File "/miniconda/lib/python3.7/shutil.py", line 406, in _rmtree_safe_fd
with os.scandir(topfd) as scandir_it:
OSError: [Errno 24] Too many open files: '/tmp/pymp-qe4lk3v5'
File "/miniconda/lib/python3.7/multiprocessing/util.py", line 265, in _run_finalizers
finalizer()
OSError: [Errno 24] Too many open files: '/tmp/pymp-erfgy5xu'
File "/miniconda/lib/python3.7/shutil.py", line 406, in _rmtree_safe_fd
with os.scandir(topfd) as scandir_it:
File "/miniconda/lib/python3.7/multiprocessing/util.py", line 189, in __call__
res = self._callback(*self._args, **self._kwargs)
OSError: [Errno 24] Too many open files: '/tmp/pymp-8zwxnw9d'
File "/miniconda/lib/python3.7/shutil.py", line 491, in rmtree
_rmtree_safe_fd(fd, path, onerror)
File "/miniconda/lib/python3.7/shutil.py", line 410, in _rmtree_safe_fd
onerror(os.scandir, path, sys.exc_info())
File "/miniconda/lib/python3.7/shutil.py", line 406, in _rmtree_safe_fd
with os.scandir(topfd) as scandir_it:
OSError: [Errno 24] Too many open files: '/tmp/pymp-uw_vsn4_'
#0 signal_handler (sig_num=17) at /tmp/build/80754af9/python_1553721932202/work/Modules/signalmodule.c:302
#1 <signal handler called>
#2 0x00007f7caec9c8c2 in do_futex_wait () from /lib/x86_64-linux-gnu/libpthread.so.0
#3 0x00007f7caec9c9d3 in __new_sem_wait_slow () from /lib/x86_64-linux-gnu/libpthread.so.0
#4 0x000055d691cf5f39 in PyThread_acquire_lock_timed () at /tmp/build/80754af9/python_1553721932202/work/Python/thread_pthread.h:366
#5 0x000055d691d2d84a in acquire_timed (timeout=4999998652, lock=0x7f78d800e4e0) at /tmp/build/80754af9/python_1553721932202/work/Modules/_threadmodule.c:61
#6 lock_PyThread_acquire_lock () at /tmp/build/80754af9/python_1553721932202/work/Modules/_threadmodule.c:144
#7 0x000055d691cfc6e4 in _PyMethodDef_RawFastCallKeywords () at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:690
#8 0x000055d691cfc86f in _PyMethodDescr_FastCallKeywords () at /tmp/build/80754af9/python_1553721932202/work/Objects/descrobject.c:288
#9 0x000055d691d5807c in call_function (kwnames=0x0, oparg=3, pp_stack=<synthetic pointer>) at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:4593
#10 _PyEval_EvalFrameDefault () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3110
#11 0x000055d691c994f9 in _PyEval_EvalCodeWithName () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3930
#12 0x000055d691cfb9c5 in _PyFunction_FastCallKeywords () at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:433
#13 0x000055d691d53ad0 in call_function (kwnames=0x0, oparg=<optimized out>, pp_stack=<synthetic pointer>) at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:4616
#14 _PyEval_EvalFrameDefault () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3110
#15 0x000055d691c994f9 in _PyEval_EvalCodeWithName () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3930
#16 0x000055d691cfba27 in _PyFunction_FastCallKeywords () at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:433
#17 0x000055d691d548fe in call_function (kwnames=0x7f7c5a49fba8, oparg=<optimized out>, pp_stack=<synthetic pointer>)
at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:4616
#18 _PyEval_EvalFrameDefault () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3139
#19 0x000055d691c994f9 in _PyEval_EvalCodeWithName () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3930
#20 0x000055d691cfb9c5 in _PyFunction_FastCallKeywords () at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:433
#21 0x000055d691d53ad0 in call_function (kwnames=0x0, oparg=<optimized out>, pp_stack=<synthetic pointer>) at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:4616
#22 _PyEval_EvalFrameDefault () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3110
#23 0x000055d691cfb79b in function_code_fastcall (globals=<optimized out>, nargs=1, args=<optimized out>, co=<optimized out>)
at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:283
#24 _PyFunction_FastCallKeywords () at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:408
#25 0x000055d691d53ad0 in call_function (kwnames=0x0, oparg=<optimized out>, pp_stack=<synthetic pointer>) at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:4616
#26 _PyEval_EvalFrameDefault () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3110
#27 0x000055d691c9a50b in function_code_fastcall (globals=<optimized out>, nargs=1, args=<optimized out>, co=0x7f7c5a4a6420)
at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:283
#28 _PyFunction_FastCallDict () at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:322
#29 0x000055d691cb1bd0 in _PyObject_FastCall_Prepend () at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:866
#30 0x000055d691cf49ba in call_unbound (nargs=0, args=0x0, self=0x7f7c51731160, func=0x7f7c5a438158, unbound=1)
at /tmp/build/80754af9/python_1553721932202/work/Objects/typeobject.c:1481
#31 call_method (nargs=0, args=0x0, name=0x55d691eb57c0 <PyId___next__.15069>, obj=0x7f7c51731160) at /tmp/build/80754af9/python_1553721932202/work/Objects/typeobject.c:1513
#32 slot_tp_iternext () at /tmp/build/80754af9/python_1553721932202/work/Objects/typeobject.c:6555
#32 slot_tp_iternext () at /tmp/build/80754af9/python_1553721932202/work/Objects/typeobject.c:6555
#33 0x000055d691cc120f in enum_next () at /tmp/build/80754af9/python_1553721932202/work/Objects/enumobject.c:156
#34 0x000055d691d53e76 in _PyEval_EvalFrameDefault () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:2809
#35 0x000055d691c99db9 in _PyEval_EvalCodeWithName () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3930
#36 0x000055d691cfba27 in _PyFunction_FastCallKeywords () at /tmp/build/80754af9/python_1553721932202/work/Objects/call.c:433
#37 0x000055d691d53846 in call_function (kwnames=0x0, oparg=<optimized out>, pp_stack=<synthetic pointer>) at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:4616
#38 _PyEval_EvalFrameDefault () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3124
#39 0x000055d691c994f9 in _PyEval_EvalCodeWithName () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3930
#40 0x000055d691c9a3c4 in PyEval_EvalCodeEx () at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:3959
#41 0x000055d691c9a3ec in PyEval_EvalCode (co=<optimized out>, globals=<optimized out>, locals=<optimized out>) at /tmp/build/80754af9/python_1553721932202/work/Python/ceval.c:524
#42 0x000055d691db2874 in run_mod () at /tmp/build/80754af9/python_1553721932202/work/Python/pythonrun.c:1035
#43 0x000055d691dbcb81 in PyRun_FileExFlags () at /tmp/build/80754af9/python_1553721932202/work/Python/pythonrun.c:988
#44 0x000055d691dbcd73 in PyRun_SimpleFileExFlags () at /tmp/build/80754af9/python_1553721932202/work/Python/pythonrun.c:429
---Type <return> to continue, or q <return> to quit---bt~
#45 0x000055d691dbde5f in pymain_run_file (p_cf=0x7fff7e420f70, filename=0x55d693201fa0 L"train.py", fp=0x55d693248ab0)
at /tmp/build/80754af9/python_1553721932202/work/Modules/main.c:427
#46 pymain_run_filename (cf=0x7fff7e420f70, pymain=0x7fff7e421080) at /tmp/build/80754af9/python_1553721932202/work/Modules/main.c:1627
#47 pymain_run_python (pymain=0x7fff7e421080) at /tmp/build/80754af9/python_1553721932202/work/Modules/main.c:2877
#48 pymain_main () at /tmp/build/80754af9/python_1553721932202/work/Modules/main.c:3038
#49 0x000055d691dbdf7c in _Py_UnixMain () at /tmp/build/80754af9/python_1553721932202/work/Modules/main.c:3073
#50 0x00007f7cae8bcb97 in __libc_start_main () from /lib/x86_64-linux-gnu/libc.so.6
#51 0x000055d691d63122 in _start () at ../sysdeps/x86_64/elf/start.S:103
```
My data loader creates a lot of external processes (not a good thing, but I need this for now), but data loader should not hang like that (better to have it crashed).
cc @SsnL | module: dataloader,triaged | low | Critical |
489,561,248 | create-react-app | Soft introduction of new ESLint rules impossible due to warnings becoming errors in CI | ### Is your proposal related to a problem?
The problem itself is well-known (e.g. https://github.com/facebook/create-react-app/issues/3657, https://github.com/facebook/create-react-app/issues/2453 and probably more). There are many problems with the `CI=true` approach (mostly about unexpected discrepancy between local and remote build for developers who have no intimate knowledge of CI/CD or a particular build system in a project), but in this issue I want to highlight how it's a blocker for gradually introducing changes to project's ESLint rules.
Basically, imagine you'd like to introduce a new rule into your (project- or company-wide) ESLint configuration. What you'd want to do is add the rule, make it visible, but you'd definitely not want the build to fail and you'd also want to avoid fixing all the code at once automatically (code ownership, commit size and other issues) or manually (a lot of work). That's what a warning is for: you add it as an indicator of "things to come", make people aware of a potential problem when they come across a piece of code and hope that gradually the issue will be fixed over time, at which point the rule can be promoted to "error", which indeed would fail the build both locally and in CI.
The issue is that with current system, there is no alternative: setting `CI=false` is bound to break other things that might be dependent on knowing about CI environment (automated UI tests?), fixing every issue as soon as the rule is introduced is not feasible for large projects and might break at some point (if not technically, then socially, since a rule introduction might have been well-intended, but does more damage in the long run), disabling the rule "for now" is the same as not having it at all.
### Describe the solution you'd like
Like in other mentioned issues, a setting (in `package.json`?) disabling upgrading warnings to errors would go a really long way. | issue: proposal,needs triage | low | Critical |
489,575,899 | rust | Moving out of field error should emit resolution suggestions | The current error doesn't help users resolve the problem. Even just including a message that one should try borrowing the field by prepending a `&` would be of help. I don't think it matters that this isn't possible for e.g. `self.foo.consuming_method()`
```rust
struct Foo {
v: Vec<u32>,
}
impl Foo {
fn bar(&self) {
for _ in self.v {
}
}
}
```
([Playground](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=e0d90406ab93df35dcba4fd8cbe558cc))
Errors:
```
Compiling playground v0.0.1 (/playground)
error[E0507]: cannot move out of `self.v` which is behind a shared reference
--> src/lib.rs:7:18
|
7 | for _ in self.v {
| ^^^^^^ move occurs because `self.v` has type `std::vec::Vec<u32>`, which does not implement the `Copy` trait
error: aborting due to previous error
For more information about this error, try `rustc --explain E0507`.
error: Could not compile `playground`.
To learn more, run the command again with --verbose.
``` | A-diagnostics,T-compiler | low | Critical |
489,581,142 | TypeScript | @ts-ignore is broken in 3.6 when code line is broken into 2 lines | **Search Terms:**
@ts-ignore
ts-ignore
ignore
multiline
**Code**
```ts
const veryLongStructureNameWithFooInside = {
foo: (x: number): Promise<number> => {
return Promise.resolve(x);
},
};
// @ts-ignore
veryLongStructureNameWithFooInside
.foo() // Notice the line break here caused by prettier
.then((result) => {
console.log(result);
})
.catch((err) => {
console.log(err);
});
```
**Expected behavior:**
There should be no errors as `@ts-ignore` is set on the function call (works in 3.5.2)
**Actual behavior:**
In next version the following error occurs:
```bash
error TS2554: Expected 1 arguments, but got 0.
.foo()
~~~~~
foo: (x: number): Promise<number> => {
~~~~~~~~~
An argument for 'x' was not provided.
```
**Playground Link:**
[playground](https://typescript-play.js.org/?noImplicitAny=false#code/MYewdgzgLgBAbgUwE4E8Ay4DmBlKSCuwU+SCAcgIYC2CA6gJZQAWAYiCAJKT0AmCMAXhgBvAFAwYAM3YAuGAAoAHnLD4qAI2QBKOQAUkIKvQgIAPKo3IAfIJtiJE0sSRgY+w8YQA6UhBAAbRCUtAG5xGABfABpRCLCAeniYAAEoCABaekwwEFJRRFQMMBw8QmdyajpGVnYuCF4EcK9pEHktJuYEMHl5X3x-KC1bEXCJUEgA738QTF6ECH7BsIkI9okvYAooYCYe5CQhgTtRmHG-fymZ+X3Q8NWQoA)
| Suggestion,Needs Proposal | low | Critical |
489,638,663 | create-react-app | Enable and configure svgo usage with svgr | As i understood svgr svgo is disabled by default and can't be activated
Is there any chance you could allow activating svgo to optimize the svgs? This way we could use .svgo.yml file to configure it depending on our needs | issue: proposal | low | Minor |
489,656,833 | godot | Alt+Numpad is equivalent to deactivating Num Lock | **Godot version:**
3.1.1 stable
**OS/device including version:**
Windows 10, French AZERTY keyboard with a numpad
**Issue description:**
Pressing **Alt+Kp1**, **Alt+Kp3**, **Alt+Kp7**, **Alt+Kp9** is equivalent to pressing End, PgDown, Begin, PgUp.
It is as if the NumLock was off.
Note that:
- It doesn't affect Alt+Kp0, Alt+Kp., Alt+Kp2, Alt+Kp4, Alt+Kp6, Alt+Kp8 (Ins, Del, Down, Left, Right, Up)
- The bug is present with NumLock on and off.
Thus, it is impossible to use Alt codes (like Alt+144 to display ร), even if you only need 0, 2, 4, 5, 6, 8 (Alt+268 doesn't display anything, while it should display โ)
I tested my keyboard in other software, that issue does not happen.
**Steps to reproduce:**
You need a keyboard with a Numpad.
I spotted the bug in LineEdit and TextEdit, so you can try within the editor.
Type some text and play with Alt+Kp(1,3,7,9), and try to enter some Alt codes
| bug,topic:input | low | Critical |
489,678,653 | opencv | WITH_LAPACK failed to build with the LAPACK(MKL) 2019.0.4 on Linux | ##### System information (version)
- OpenCV => master
- Operating System / Platform => Linux (CentOS 6.10 x64)
- Compiler => cmake 3.13.4
##### Detailed description
The LAPACK(MKL) library is found, but the LAPACK check code failed to build. The log is:
-- Found MKL 2019.0.4 at: /opt/intel/compilers_and_libraries_2019.4.243/linux/mkl
-- LAPACK(MKL): LAPACK_LIBRARIES: /opt/intel/compilers_and_libraries_2019.4.243/linux/mkl/lib/intel64/libmkl_intel_lp64.so;/opt/intel/compilers_and_libraries_2019.4.243/linux/mkl/lib/intel64/libmkl_tbb_thread.so;/usr/lib64/libtbb.so;/opt/intel/compilers_and_libraries_2019.4.243/linux/mkl/lib/intel64/libmkl_core.so;-lpthread;-lm;-ldl
-- LAPACK(MKL): Can't build LAPACK check code. This LAPACK version is not supported.
##### Steps to reproduce
CMake build with "-D WITH_IPP=ON -D WITH_OPENMP=ON -D MKL_WITH_OPENMP=ON -D WITH_TBB=ON -D MKL_WITH_TBB=ON -D WITH_LAPACK=ON", and the LAPACK failed.
| bug,category: build/install,needs investigation | low | Critical |
489,828,607 | scrcpy | Windows 10 taskbar icon flash orange for notification | You know the way Windows 10 handles it when something happens
to a running but minimized-to-taskbar app?
It flashes/turns orange.
Is there any way to make the scrcpy icon on my taskbar
turn or flash orange when a notification comes through?
So I don't have to keep leaning over to look at my phone screen,
or flicking back to the app window to check I've not missed anything. | feature request | low | Minor |
489,846,179 | flutter | No text input from HID device after hiding keyboard/inputAccessory programmatically | I am currently developing a Flutter app which uses a bluetooth barcode scanner to input text in a text field. The bluetooth scanner is detected as a HID.
One of the constraints of this application is, that a user cannot enter a barcode manually using the virtual keyboard. To prevent this, I automatically hide the keyboard via `SystemChannels.textInput.invokeMethod('TextInput.hide')` on focus gain.
On Android, this works without issues (Android 9, Samsung tablet).
On iOS, when a HID is connected, it shows what seems to be called `inputAccessory` when a text field is focused. I noticed that after hiding the keyboard/inputAccessory programmatically, there is no input detected from the barcode scanner anymore, even if the text field is still in focus.
Invoking `TextInput.show` restores functionality, but also (obviously) shows the inputAccessory again, which is undesirable.
I would accept this as an iOS specific quirk, however, when I hide the inputAccessory manually by tapping on its down arrow, it becomes hidden, but input from the scanner is still detected and put into the text field. In addition to this, I also noticed that after hiding the inputAccessory manually, I am unable to make it reappear by invoking `TextInput.show` again.
As I can reach the desired keyboard/inputAccessory state when hiding the inputAccessory manually, I assume there must be a way to achieve the same state programmatically. Is there a way to do this in Flutter?
Alternatively, is there a way to specifically only hide the virtual keyboard, but not the inputAccessory? I don't mind the inputAccessory bar, as long as I can prevent users from using the virtual keyboard to input barcodes.
If anyone knows of a solution or workaround, please let me know.
I'm attaching a two videos to illustrate the issue.
## Steps to Reproduce
1. focus a `TextField`
2. call `SystemChannels.textInput.invokeMethod('TextInput.hide')`
3. scan a barcode / type something on a physical keyboard
Expected result: text should be put into text field
Actual result: no text input happening
## Videos
First is the flow as described in "Steps to Reproduce", i.e. focus a textfield, hide the keyboard/inputAccessory, scan an item: https://gfycat.com/rashoccasionalboilweevil
Second is about the quirk I mentioned, that initially I can hide and show the inputAccessory without issues, but if I hide the inputAccessory manually (by clicking on the arrow), I cannot reveal the inputAccessory programmatically anymore, but in this case the input of the scanner is respected and handled: https://gfycat.com/selfishmelodicindri
## Code
Here is the relevant code of an example app, the same you see in the videos:
```dart
class MyApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
return MaterialApp(
title: 'Flutter Demo',
theme: ThemeData(
primarySwatch: Colors.blue,
),
home: MyHomePage(title: 'Flutter Demo Home Page'),
);
}
}
class MyHomePage extends StatefulWidget {
MyHomePage({Key key, this.title}) : super(key: key);
final String title;
@override
_MyHomePageState createState() => _MyHomePageState();
}
class _MyHomePageState extends State<MyHomePage> {
TextEditingController _textFieldController = TextEditingController();
FocusNode _textFieldFocus = FocusNode();
@override
Widget build(BuildContext context) {
return Scaffold(
appBar: AppBar(
title: Text(widget.title),
),
body: Column(
mainAxisAlignment: MainAxisAlignment.center,
children: <Widget>[
Text(
'1. click "request focus"\n'
'(keyboard indicator should be visible)\n'
'2. click "hide keyboard"\n'
'3. scan a barcode / type something on the physical keyboard\n'
'expected: text should be put into text field\n'
'actual: no text input happening\n'
),
TextField(
onSubmitted: (text) => debugPrint('text submitted: $text'),
controller: _textFieldController,
focusNode: _textFieldFocus,
autofocus: false,
),
ButtonBar(
children: <Widget>[
RaisedButton(
child: Text('request focus'),
onPressed: () => _textFieldFocus.requestFocus(),
),
RaisedButton(
child: Text('hide keyboard'),
onPressed: () =>
SystemChannels.textInput.invokeMethod('TextInput.hide'),
),
RaisedButton(
child: Text('show keyboard'),
onPressed: () =>
SystemChannels.textInput.invokeMethod('TextInput.show'),
),
],
),
],
),
);
}
}
```
## Logs
I have tested multiple Flutter versions, but here is the log after trying it with the master branch state
```
[โ] Flutter (Channel master, v1.9.8-pre.79, on Mac OS X 10.14.3 18D42, locale en-DE)
โข Flutter version 1.9.8-pre.79 at /Users/ren/Stuff/flutter
โข Framework revision 72cacb4040 (2 days ago), 2019-09-03 18:00:45 -0700
โข Engine revision e7f9ef6aa0
โข Dart version 2.5.0 (build 2.5.0-dev.4.0 36985859e4)
[โ] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
โข Android SDK at /Users/ren/Library/Android/sdk
โข Android NDK location not configured (optional; useful for native profiling support)
โข Platform android-28, build-tools 28.0.3
โข Java binary at: /Users/ren/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/191.5791312/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java
โข Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
โข All Android licenses accepted.
[โ] Xcode - develop for iOS and macOS (Xcode 10.2.1)
โข Xcode at /Applications/Xcode.app/Contents/Developer
โข Xcode 10.2.1, Build version 10E1001
โข CocoaPods version 1.7.5
[โ] Android Studio (version 3.5)
โข Android Studio at /Users/ren/Library/Application Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/191.5791312/Android Studio.app/Contents
โข Flutter plugin version 39.0.3
โข Dart plugin version 191.8423
โข Java version OpenJDK Runtime Environment (build 1.8.0_202-release-1483-b49-5587405)
[โ] VS Code (version 1.37.1)
โข VS Code at /Applications/Visual Studio Code.app/Contents
โข Flutter extension version 3.4.1
[โ] Connected device (1 available)
โข Andreas' iPhone 6S โข 8bef8d20ae638b8f483f05cfc456b4ab4edb8177 โข ios โข iOS 12.4
โข No issues found!
```
| a: text input,platform-ios,framework,f: material design,has reproducible steps,P2,found in release: 3.3,workaround available,found in release: 3.7,team-ios,triaged-ios,fyi-text-input | low | Critical |
489,866,814 | flutter | Asynchonous SearchDelegate | # Use case
I want to show a list of users, but filtering this list is not _super_ fast, in a custom implementation I was able to use stateful widgets and callbacks (streams might have been better) that update al the widgets when search is changed. all this would be handled outside of a build function and the widgets could call setState().
But with SearchDelegate this is not possible since you only have a synchronous buildSuggestions which is called upon text change but is also inside a build function.
So I have to do all the computation synchronously. Using a ListView.Builder helps in that I can avoid filtering offscreen users, but when you search for the last person it still goes through all the users.
Being able to use a onTextChanged method that is asynchronous instead of the buildSuggestions would allow users of flutter to have statefull widgets to do the computation asynchronously and avoiding high frame times.
## Proposal
Add an onTextChange method, and make it optional and if the onTextChange is not null call that and avoid rebuilding the suggestions. Call the buildSuggestions once for the initial widget. | c: new feature,framework,f: material design,P3,team-design,triaged-design | low | Minor |
489,878,013 | PowerToys | [FancyZones] Create layout from current windows | Feature to "snapshot" your current windows into a new layout
| Idea-Enhancement,FancyZones-Layouts,Product-FancyZones | low | Major |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.