id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
⌀ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
445,860,256 | go | go/types: review/document AssignableTo code path for untyped value types | <!-- Please answer these questions before submitting your issue. Thanks! -->
### What version of Go are you using (`go version`)?
<pre>
$ go version
go version go1.12.1 darwin/amd64
</pre>
### Does this issue reproduce with the latest release?
Yes.
### What operating system and processor architecture are you using (`go env`)?
<details><summary><code>go env</code> Output</summary><br><pre>
$ go env
GOARCH="amd64"
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
</pre></details>
### What did you do?
I called `types.AssignableTo` to see if an untyped int constant was assignable to a named int type.
https://play.golang.org/p/Xq33qWpFsy5
### What did you expect to see?
I expected it to be assignable.
### What did you see instead?
It was reported as not assignable.
At first I thought it was due to an implicit type conversion and they weren't technically assignable, but in the spec [assignability](https://golang.org/ref/spec#Assignability) seems to include implicit conversions, at least for non-constant values. For untyped constants in particular it says an untyped constant x is assignable to type T if `x is in the set of values determined by T.`. I'm not sure exactly what that means or if it disqualifies this case. In general since the untyped constant _is_ assignable to the named type, I assumed the AssignableTo function would agree.
Also note that reflect.Type.AssignableTo behaves consistently with types.AssignableTo.
/cc @griesemer since you are primary owner of go/types | Documentation,NeedsFix | low | Major |
446,030,245 | opencv | Dnn Winrt Support? | Current Dnn unsupport Winrt platform, Is there any plan for Dnn to support the Winrt platform? | feature,priority: low,category: dnn | low | Minor |
446,064,391 | flutter | Support build/debug iOS on a remote Mac | ## Use case
Main development environment is Windows.
A Mac exists on the same local network. Xcode and all the tools are installed.
Currently we have to switch between Mac and Windows all the time, doing frequent unnecessary git commits just to synchronize between the two.
While we could theoretically switch to Mac completely and do all our work there there are financial and technical limitations that will keep us on Windows in the near future.
## Proposal
We would like to see a feature like VisualStudio offers with Xamarin, where you can remotely connect to the Mac and do your build/debug work from inside the VS IDE.
This is different to #22771 in that it would actually make use of an existing local Mac infrastructure rather than circumventing it completely.
| c: new feature,tool,platform-mac,P3,team-tool,triaged-tool | high | Critical |
446,095,427 | youtube-dl | [youtube] Extra subtitles being overwritten | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.05.11. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that all URLs and arguments with special characters are properly quoted or escaped as explained in http://yt-dl.org/escape.
- Search the bugtracker for similar issues: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a broken site support
- [x] I've verified that I'm running youtube-dl version **2019.05.11**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
- [x] I've searched the bugtracker for similar issues including closed ones
## Verbose log
<!--
Provide the complete verbose output of youtube-dl that clearly demonstrates the problem.
Add the `-v` flag to your command line you run youtube-dl with (`youtube-dl -v <your command line>`), copy the WHOLE output and insert it below. It should look similar to this:
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2019.05.11
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
<more lines>
-->
```
youtube-dl.exe --all-subs --skip-download --verbose -f303+251,299+140 https://www.youtube.com/watch?v=jc5DlOkOcU4
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['--all-subs', '--skip-download', '--verbose', '-f303+251,299+140', 'https://www.youtube.com/watch?v=jc5DlOkOcU4']
[debug] Encodings: locale cp1252, fs mbcs, out cp437, pref cp1252
[debug] youtube-dl version 2019.05.11
[debug] Python version 3.4.4 (CPython) - Windows-10-10.0.18362
[debug] exe versions: ffmpeg N-92573-gc047901012, ffprobe N-92573-gc047901012, rtmpdump 2.4-20151223-gfa8646d-LibreSSL_2.5.4-x86_64-static
[debug] Proxy map: {}
[youtube] jc5DlOkOcU4: Downloading webpage
[youtube] jc5DlOkOcU4: Downloading video info webpage
[info] jc5DlOkOcU4: downloading video in 2 formats
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.en.vtt
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.ja.vtt
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.es.vtt
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.en.vtt
[info] Writing video subtitles to: M2 - Complete Works _ MY LIFE IN GAMING-jc5DlOkOcU4.ja.vtt
```
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Provide any additional information, suggested solution and as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
https://www.youtube.com/watch?v=jc5DlOkOcU4 contains two sets of English subtitles (not auto-generated). One is a full subtitle, the other is a translation of the Japanese parts of the video. Unfortunately one overwrites the other as they are named the same by youtube-dl.
| subtitles | low | Critical |
446,101,749 | TypeScript | Strict version of Extract for literal union types | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
extract, pick, union, literal, string
## Suggestion
<!-- A summary of what you'd like to see added or changed -->
Currently we have `Pick<T, K>` to select a type-safe subset of a given type `T` using a union of keys `K`. Unfortunately this does not work for unions of literals and requires `Extract` which subjectively isn't strict enough:
```typescript
type ShirtSizes = "xxxl" | "xxl" | "xl" | "l" | "m" | "s" | "xs" | "xxs";
type Subset = Extract<ShirtSizes, "l" | "m" | "s" | "this-is-allowed-as-well">;
```
One caveat is that `Extract` does not support code completion when writing the literal union for the keys and it allows keys not in the first type as well. The former is error-prone while the latter is not causing a different behavior since the illegal keys are ignored but it can't be strictly checked in the long run. Of course I understand there are use cases wherein you'd like to use `Extract` more liberally so the definition
```typescript
type Extract<T, U> = T extends U ? T : never;
```
is reasonable enough. Nevertheless, I'd like to propose an additional strict variant as follows
```typescript
// short-hand form
type ExtractStrict<T, U extends T> = Extract<T, U>;
// equivalent full form
type ExtractStrict<T, U extends T> = T extends U ? T : never;
```
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
```typescript
type ShirtSizes = "xxxl" | "xxl" | "xl" | "l" | "m" | "s" | "xs" | "xxs";
// this allows for code completion
type Subset = ExtractStrict<ShirtSizes, "l" | "m" | "s">;
// this is causing an error
type Subset2 = ExtractStrict<ShirtSizes, "l" | "m" | "s" | "illegal-literal">;
```
## Checklist
My suggestion meets these guidelines:
* [X] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [X] This wouldn't change the runtime behavior of existing JavaScript code
* [X] This could be implemented without emitting different JS based on the types of the expressions
* [X] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [X] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | medium | Critical |
446,161,828 | flutter | Isn't Google Map Street View available in Flutter? | Hello
Is Google Map Street View available in Flutter? If not is there a plan to provide the plugin in the future? I really want to integrate Street View into my app.
Thanks. | c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem | medium | Critical |
446,161,931 | rust | Implement IzZero for zeroable default types | As discussed in #54628 there are some critical optimizations based on fact that type default value can be represented with `mem::zeroed()`, such as [this vec allocation code](https://github.com/rust-lang/rust/blob/372be4f360ce42b1a10126a711189796f8440ab4/src/liballoc/vec.rs#L1579).
[There is a trait](https://github.com/rust-lang/rust/blob/372be4f360ce42b1a10126a711189796f8440ab4/src/liballoc/vec.rs#L1594) describing this behavior. I propose implementing it for some standard types, such as `std::num::Wrapping` or `Option`, or even making it public. | C-enhancement,A-collections,T-libs-api | low | Major |
446,172,653 | rust | Sometimes `DiagnosticBuilder::span_suggestion` doesn't print the suggestion | In Clippy we have a convenience function for `DiagnosticBuilder::span_suggestion`: https://github.com/rust-lang/rust-clippy/blob/fd563810158425c20f27768da4ef54c54230bbbf/clippy_lints/src/utils/diagnostics.rs#L169-L177
Until now we had 3 cases where the suggestion wasn't emitted: rust-lang/rust-clippy#4119, https://github.com/rust-lang/rust-clippy/pull/3582#discussion_r246656947, rust-lang/rust-clippy#3913
This issue still occurs, when replacing the convenience functions with the normal `DiagnosticBuilder` methods.
Until now I couldn't figure out a pattern when or why this happens. | A-diagnostics,T-compiler,C-bug | low | Minor |
446,209,651 | pytorch | Remove unpack() in torch/csrc/nn/type_checks.h and its caller functions in the codebase | The `unpack()` function in torch/csrc/nn/type_checks.h is not used anymore because we had already killed torch.legacy.nn and all the normal NN ops go through ATen bindings right now. A proper removal of the `unpack()` function would also involve removing all of its caller functions. | module: internals,module: nn,good first issue,triaged | low | Major |
446,240,105 | vscode | Add New Project menu item and open it to extension developers to add project types | Add a new menu item called New Project and then allow extension authors the ability to register their own project type and handler for it.
For example, the Electron team can create an extension that creates an Election project. When selecting that option they then create the folders and projects and open that project.
File > New Project >
- Electron
- Angular
- React
- anything else
<!-- Describe the feature you'd like. -->
| feature-request | low | Minor |
446,253,084 | vscode | Expose vscode remote reconnecting UI. | <!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
Can an API be exposed to extensions to re-use vscode "Reconnecting" UI? Outside of vscode remote scenario, some extensions like liveshare do communication with another instance of vscode over the network. Being able to reconnect due to spotty network connection via the extension is very similar to the vscode remote scenario. Blocking the UI here, like vscode does during reconnection makes the network reconnection problem for liveshare simpler, else we would have to deal with coediting and other editor operations being out of sync. It would be nice, if extensions like liveshare can use the reconnecting UI that vscode uses for its remote scenario.
cc @lostintangent
| feature-request,api | low | Minor |
446,253,752 | godot | Polygon2D texture "leaking" | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:** 3.2.dev.custom_build
**Commit:** d111d59
This bug is also occuring in the Godot 3.1 stable version.
<!-- Specify commit hash if non-official. -->
**OS/device including version:**
<!-- Specify GPU model and drivers if graphics-related. -->
Windows 10
**Issue description:**
<!-- What happened, and what was expected. -->
I don't know how else I can describe this issue besides "texture leaking". I hope someone has better description / title for this problem.
Any way as you see in this image below at the red arrows there is kind of a line of white pixels leaking towards a Polygon2D points.
At first I thought it was because my strange Polygon2D shape, but I tried with a simple Polygon2D shape and it's still behaving like that:
But even the default Godot square shaped sprite is leaking texture towards the Polygon2D points... even more actually than expected, so it's not my image fault either...
It's strange because in new project with simple sprites it works fine, but when I use complex shaped texture, the Polygon2D node seems to get bugged for the whole project?
**Steps to reproduce:**
1. Create a Polygon around the odd shaped sprite like the pink hand.
2. Sometimes it gets bugged.. sometimes no bug at all.
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
[Polygon2DLeaking.zip](https://github.com/godotengine/godot/files/3199256/Polygon2DLeaking.zip)
| bug,topic:editor,confirmed | low | Critical |
446,273,601 | kubernetes | Volume ownership function ignore errors during chown or chmod | <!-- Please use this template while reporting a bug and provide as much info as possible. Not doing so may result in your bug not being addressed in a timely manner. Thanks!
If the matter is security related, please disclose it privately via https://kubernetes.io/security/
-->
**What happened**:
In current [SetVolumeOwnership](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/volume_linux.go#L71) function, it ignore any errors returned from chmod or chown. This means that even if ownership or permission is not set up correctly, pods will still be starting and it might cause some unexpected behavior.
Also noticed that in configmap_test.go, the test sets the fsGroup for the volume. However, seems like bazel test are running under non-root, so chown to an non existing group will have error "permission denied" and fail to set up fsGroup. But the test does not check this ownership, it still pass.
**What you expected to happen**:
SetVolumeOnwerhsip should fail if chown/chmod fails. Also the configmap test may not set fsGroup if we cannot guarantee the test is running under root. We can have a separate test for this SetVolumeOwnership function to find out existing group id from current user and use that group to set up.
**How to reproduce it (as minimally and precisely as possible)**:
**Anything else we need to know?**:
**Environment**:
- Kubernetes version (use `kubectl version`):
- Cloud provider or hardware configuration:
- OS (e.g: `cat /etc/os-release`):
- Kernel (e.g. `uname -a`):
- Install tools:
- Network plugin and version (if this is a network-related bug):
- Others:
| kind/bug,sig/storage,lifecycle/frozen,triage/needs-information | medium | Critical |
446,301,835 | youtube-dl | Koreus.com | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.05.20. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.05.20**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.koreus.com/video/technique-emballer-velo-pliant.html
- Single video: https://www.koreus.com/video/acteurs-big-bang-theory-au-revoir.html
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
Ytdl downloads the html page instead of the video. The video url is in the html file as plain text and can be downloaded with wget.
They recently updated their webplayer so older videos on the page still work properly (only newer videos are affected). | site-support-request | low | Critical |
446,325,346 | go | x/sys/unix: standardize Kevent_t Udata as integer, not pointer | `unix.SetKevent` only takes `mode`(eg. `Filter` field) and `flags` parameter.
Other fields also have different types depending on the ach/platform, say `Udata` which is either a `*byte` or a `int32`.
Since Go1 compat promise prevent us from changing the `SetKevent` function, perhaps it could be feasible to add new methods to the `Kevent_t` type to set the others fields, similar to `*Iovec.SetLen` for example.
`Fflags` and `Data` methods looks straightforward to implement, on the model of `SetKevent`, since types are integers on all platforms/archs.
However, so far, I am unsure about the type of the `Udata` parameter for the eponym method. I typically would do `kev.Udata = (*byte)(unsafe.Pointer(&foobar))` on my own currently for darwin/amd64, but I guess that exposing `unsafe.Pointer` as a parameter type is not a good solution. | help wanted,NeedsFix | medium | Major |
446,345,847 | godot | Input.set_mouse_cursor doesn't immediately refresh the cursor in HTML5 exported games | **Godot version:**
3.1.1
**OS/device including version:**
Windows 10 (up-to-date) - Chrome (latest version) / Firefox (latest version)
**Issue description:**
When running a game on a browser, calling `Input.set_mouse_cursor` with a custom cursor will (often, see below) not update the cursor until the mouse is moved again. Sometimes (apparently only on Chrome), the cursor will also become hidden when you attempt to change it again into the same one (easily fixable by storing the last set cursor to not call it twice in a row, but still not ideal).
**Notes:**
This kinda happens randomly depending on browsers, settings, and maybe setup / graphic card / etc. On my own project, it only happens on Firefox, but sometimes stops occurring when debug is enabled. At work, it also happens on Chrome (same build of the game).
**Demo:**
https://pleesher.com/resources/temp/browser_cursor_bug/browser_cursor_bug.html
Wait until the screen is grey (scene fully loaded). Click anywhere to set the cursor, but try not moving the mouse right after doing so. The default cursor stays until you move it again. (As mentioned above, on Chrome, clicking again also makes the cursor disappear until the following move, and so on.)
**Steps to reproduce:**
```gdscript
extends Node2D
onready var alt_cursor = preload('res://left_ptr.png')
func _input(event):
if event is InputEventMouseButton and event.button_index == BUTTON_LEFT and event.pressed:
Input.set_custom_mouse_cursor(alt_cursor)
```
This is the exact code used in the demo above. left_ptr.png is a 32x32 cursor. | bug,platform:web,topic:core,topic:porting,confirmed,documentation | low | Critical |
446,346,097 | angular | Add Architect API documentation | <!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 📚 Docs or angular.io bug report
### Description
The PR for the [Architect Guide](https://github.com/angular/angular/pull/29964) mentions a lot of important Architect classes like `BuilderOutput` and `BuilderContext` but those the docs can't link to the API docs for those classes since the CLI APIs don't show up in the API docs.
## 🔬 Minimal Reproduction
### What's the affected URL?**
https://next.angular.io/api
### Expected vs Actual Behavior**
Expected
- Crticial, official, stable APIs are captured in the API docs
Actual
- Angular CLI APIs aren't available in the API docs
## 📷Screenshot
## 🌍 Your Environment
### Browser info
Chrome
### Anything else relevant?
https://github.com/angular/angular/pull/29964#discussion_r285753679
| feature,freq2: medium,P4,area: docs | low | Critical |
446,347,520 | pytorch | [jit] set up views for Autodiff and autograd hooks | Derived from the bug finding in #19769 , Here is what we found is missing in our Autodiff infrastructure. In Autodiff, we don't set up the views for inputs/outputs after we execute the forward graph(see this [TODO](https://github.com/pytorch/pytorch/blob/be33434d85953fe6f237d475cc8ae2e9a822ed34/torch/csrc/jit/graph_executor.cpp#L350)). This disables us from adding complicated Ad formulas (such as `linear` and `layer_norm`, etc.), because when we calculate higher level gradients, we usually ended up capturing multiple outputs, and some of the output is just a view of another output, and we want the gradient to flow to the original output, which we could not do in the current autodiff infrastructure.
Taking a example from a graph after we added `linear` in AD, the first order backward graph of a simple model might (second order gradient forward graph) looks like the blow:
```
graph(%1 : int[],
%4 : Float(*, *),
%8 : int[],
%11 : Float(*, *),
%15 : int[],
%17 : Float(*, *),
%19 : Float(*, *),
%21 : Float(*, *),
%22 : Tensor):
%28 : int = prim::Constant[value=1]()
%146 : int[] = aten::size(%22)
%24 : Tensor = aten::add(%21, %22, %28)
%grad_input.2 : Float(*, *) = aten::mm(%24, %19)
%grad_input.3 : Float(*, *) = aten::mm(%grad_input.2, %17)
%16 : Tensor = aten::reshape(%grad_input.3, %15)
%self_size.6 : int[] = aten::size(%grad_input.3)
%97 : Float(*, *) = aten::t(%grad_input.2)
%grad_weight.3 : Float(*, *) = aten::mm(%97, %11)
%self_size.4 : int[] = aten::size(%grad_input.2)
%72 : Tensor = aten::_grad_sum_to_size(%grad_input.2, %8)
%63 : Tensor = aten::t(%24)
%grad_weight.1 : Float(*, *) = aten::mm(%63, %4)
%self_size.2 : int[] = aten::size(%24)
%38 : Tensor = aten::_grad_sum_to_size(%24, %1)
return (%38, %grad_weight.1, %72, %grad_weight.3, %16, %146, %24, %grad_input.2, %self_size.6, %97, %self_size.4, %63, %self_size.2)
```
The reason why we have so much outputs is that the second order backward need to know the intermediate outputs of this graph, and autodiff captures them during the reverse of the forward graph, which can bee seen as below:
```
%grad_bias.4 : Tensor, %grad_weight.1 : Float(*, *), %grad_bias.1 : Tensor, %grad_weight.3 : Float(*, *), %102 : Tensor = prim::DifferentiableGraph[Subgraph=<Graph>, ReverseSubgraph=<Graph>, f_real_outputs=5, df_input_vjps=[0, 1, 2, 3, 4, 6, 7], df_input_captured_inputs=[1, 3, 5, 6]
, df_input_captured_outputs=[5, 6, 7, 8, 9, 10, 11, 12], df_output_vjps=[1, 3, 5, 6, 8]](%22, %input.2, %34, %input.1, %self_size.1, %6, %4, %1, %14)
```
We can see that in the above forward graph, `%97` is just a view variable of `%grad_input.2`, but our Autodiff will create a new variable (instead of a view variable) for `%97` which will make this variable be a leaf that trying to flow the gradients back to it, which is wrong. This could be fixed if we correctly set up the views for `df_input_vjps` and `caputuredOutputs`.
Because we allow tensor lists to show up in the symbolic differentiable graph in https://github.com/pytorch/pytorch/pull/16784, we could not scan the lists to do the view discovery otherwise we will make the compiler slow on execution. It is possible after the Tensor/Variable merge, we can refactor the autograd to make it safe for tensors to be constructed and automatically track the viewing relationship.
Creating this issue to keep track of the content discovered and potential solutions.
CC @zdevito @apaszke @ailzhang @yf225 @bwasti @bddppq | oncall: jit,triaged | low | Critical |
446,357,125 | flutter | Audit all existing users of SkiaGPUObject<T> to ensure these are necessary. | In the past, we have not had a good handle on which Skia objects are safe to dispose on the UI thread. This is because `dart:ui` objects that reference GL handles cannot be disposed on the UI thread without the corresponding GL objects leaking. To work around this, we devised the `SkiaGPUObject<T>` wrapper which holds an `sk_sp<T>` as well as a task runner on which all references to the Skia shared pointer have to be released. Excessive and unnecessary use of the task runner causes the delays in the disposal of Skia objects that may sometimes references large amounts of memory. With the aid of the Skia team, we should [audit existing users of `SkiaGPUObject<T>`](https://github.com/flutter/engine/search?q=SkiaGPUObject&unscoped_q=SkiaGPUObject) to ensure that we only use the same when absolutely necessary. | engine,dependency: skia,P2,team-engine,triaged-engine | low | Major |
446,360,272 | flutter | Delete old shader caches when the GPU driver, Skia or Flutter version is updated. | Currently, the old shaders remain on disk. This is wasteful and we should collect the now invalid entries. @staniliev and @drwulf may have guidance on how Android and Chrome key their shader caches. We should emulate the same. | engine,dependency: skia,P2,team-engine,triaged-engine | low | Minor |
446,363,497 | go | x/tools/go/analysis: running the same analysis with different sets of flags | By convention, analyses are provided as singletons in package variables, a la `var Analysis = &analysis.Analyzer{...}`. Furthermore, analysis.Analyzer stores a flag.FlagSet for providing options to the analysis. However, this combination of singleton and FlagSet makes it difficult to run one analysis multiple times concurrently with different options. This becomes especially problematic when multiple independent tools coexist in the same address space and want to use the same analysis with different options, as they won't be coordinating with each other.
As far as I am aware, there is no suitable workaround.
/cc @matloob | NeedsInvestigation,FeatureRequest,Tools,Analysis | low | Minor |
446,365,239 | flutter | [google_maps_flutter] Ability to show caption/label underneath the marker | <!-- Thank you for using Flutter!
Please check out our documentation first:
* https://flutter.dev/
* https://api.flutter.dev/
If you can't find the answer there, please consider asking a question on
the Stack Overflow Web site:
* https://stackoverflow.com/questions/tagged/flutter?sort=frequent
Please don't file a GitHub issue for support requests. GitHub issues are
for tracking defects in the product. If you file a bug asking for help, we
will consider this a request for a documentation update.
-->
I am using google_maps_flutter: ^0.5.13 in my app. When I add markers, there is no way to specify a caption\label under the marker. I do use InfoWindow option but this only gets displayed when user taps on it. What I need is a static text under each marker to show the user what that marker is for. | c: new feature,p: maps,package,team-ecosystem,P3,triaged-ecosystem | low | Critical |
446,379,000 | opencv | OpenCV causes Weblogic to shut down | <!--
If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses.
If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute).
Please:
* Read the documentation to test with the latest developer build.
* Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue.
* Try to be as detailed as possible in your report.
* Report only one problem per created issue.
This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library.
-->
##### System information (version)
<!-- Example
- OpenCV => 3.1
- Operating System / Platform => Windows 64 Bit
- Compiler => Visual Studio 2015
-->
- OpenCV => :2.4
- Operating System / Platform => :Redhat 6.5
- Compiler => :running in weblogic
##### Detailed description
The weblgoic process sometimes shuts down and leaves a log when the access is busy
java: jas_image.c:1387: jas_image_chclrspc: Assertion `j >= 0' failed.
/weblogic/user_projects/domains/wbqt/bin/startWebLogic.sh: line 180: 50660 Aborted
##### Steps to reproduce
<!-- to add code example fence it with triple backticks and optional file extension
```.cpp
// C++ code example
```
or attach as .txt or .zip file
-->
| affected: 2.4,incomplete,needs investigation | low | Critical |
446,385,492 | youtube-dl | Error in downloading LCI video | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.05.20. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [ ] I'm reporting a new site support request
- [X] I've verified that I'm running youtube-dl version **2019.05.20**
- [X] I've checked that all provided URLs are alive and playable in a browser
- [X] I've checked that none of provided URLs violate any copyrights
- [X] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
<!--
Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours.
-->
- Single video: https://www.lci.fr/elections/en-direct-europeennes-2019-la-grande-confrontation-suivez-notre-2e-debat-evenement-loiseau-bardella-bellamy-aubry-dupont-aignan-jadot-glucksmann-2117221.html
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
youtube-dl --verbose https://www.lci.fr/elections/en-direct-europeennes-2019-la-grande-confrontation-suivez-notre-2e-debat-evenement-loiseau-bardella-bellamy-aubry-dupont-aignan-jadot-glucksmann-2117221.html
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: [u'--verbose', u'https://www.lci.fr/elections/en-direct-europeennes-2019-la-grande-confrontation-suivez-notre-2e-debat-evenement-loiseau-bardella-bellamy-aubry-dupont-aignan-jadot-glucksmann-2117221.html']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.05.20
[debug] Python version 2.7.16 (CPython) - Darwin-18.6.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.1.3, ffprobe 4.1.3, rtmpdump 2.4
[debug] Proxy map: {}
[LCI] 2117221: Downloading webpage
ERROR: Unable to extract wat id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
Traceback (most recent call last):
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 796, in extract_info
ie_result = ie.extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 529, in extract
ie_result = self._real_extract(url)
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/lci.py", line 25, in _real_extract
webpage, 'wat id')
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 1004, in _search_regex
raise RegexNotFoundError('Unable to extract %s' % _name)
RegexNotFoundError: Unable to extract wat id; please report this issue on https://yt-dl.org/bug . Make sure you are using the latest version; type youtube-dl -U to update. Be sure to call youtube-dl with the --verbose flag and include its complete output.
WRITE DESCRIPTION HERE | site-support-request | low | Critical |
446,393,182 | flutter | flutter screenshot should work in add-to-app | It doesn't work currently unless on a Flutter screen on Android even though it's just using adb shell screencap.
| platform-android,tool,a: existing-apps,P3,team-android,triaged-android | low | Minor |
446,403,261 | node | stream: `end` cannot throw ERR_STREAM_DESTROYED after `destroy` | <!--
Thank you for reporting a possible bug in Node.js.
Please fill in as much of the template below as you can.
Version: output of `node -v`
Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows)
Subsystem: if known, please specify the affected core module name
If possible, please provide code that demonstrates the problem, keeping it as
simple and free of external dependencies as you can.
-->
* **Version**: 12.1.0
* **Platform**: Darwin leaves 18.6.0 Darwin Kernel Version 18.6.0: Thu Apr 25 23:16:27 PDT 2019; root:xnu-4903.261.4~2/RELEASE_X86_64 x86_64
<!-- Please provide more details below this comment. -->
In `objectMode` mode, call `end` can receive null and also unable throw `ERR_STREAM_DESTROYED`.
```javascript
const fs = require('fs');
const { createWriteStream } = fs;
const ws = createWriteStream('./test.js', { objectMode: true });
ws.on('close', () => {
console.log('ws close');
});
ws.on('error', (error) => {
throw error;
});
ws.destroy();
setTimeout(() => ws.end(null, 'utf-8', () => {
console.log('ws ended');
}), 1000);
/**
* output:
* ws close
* ws ended
*/
``` | stream | low | Critical |
446,415,985 | flutter | Leaving the FlutterViewController hosting a webview breaks the next launch | 
Navigating between Flutter routes is ok, but navigating between native view controller and Flutter view controller leaves glitches the next time the webview is shown. The webview is blank, the nav bar with blur no longer renders, the page transition glitches. Works ok once the webview is removed.
| platform-ios,engine,a: existing-apps,p: webview,package,P2,team-ios,triaged-ios | low | Minor |
446,419,680 | TypeScript | [quick fix][typescript] Quick fix to change return type of method - ts(2322) | Sample method that returns number instead of string. Quick fix should change return type to number. Now it does nothing.
```javascript
public someMethod(a: number): string {
return 1;
}
```
| Suggestion,Awaiting More Feedback | low | Minor |
446,419,767 | TypeScript | [quick fix][typescript] Quick fix to add method parameter if missing - ts(2554) | Sample method that accepts only one parameter. Later in code I want to call this method with extra parameter. Quick fix action should add it for me. Now it does nothing.
```javascript
public someMethod(a: number):void {
// ...
}
this.someMethod(1, 'test');
```
| Suggestion,Awaiting More Feedback | low | Major |
446,442,707 | TypeScript | Allow non-inherited static class members. | ## Search Terms
inheritance inherit static class extendStatics
## Suggestion
Provide a way to mark static class members as non-inherited. This is particularly meaningful for factory methods.
## Use Cases
Static factory methods are often useful because they can be used for async construction of an object. They also can be useful for providing alternative constructor implementations (effectively) since TypeScript doesn't support constructor overloads (without a bunch of conditional ugliness in the constructor). Unfortunately, while the constructor for a subclass isn't inherited by the superclass, all static members are which means you cannot have a factory method like `create` or `from` in both the subclass and the superclass. One of them gets the name, the other doesn't.
Looking at the emitted code, there is explicit code for emitting static class extension. It would be nice if there were a way to tell the compiler to _not_ emit static extension for a particular static method.
## Examples
```typescript
class Point1 {
public constructor(private readonly x: number) { }
}
class Point2 extends Point1 {
public constructor(x: number, private readonly y: number) { super(x) }
public static from = (point1: Point1, y) => new Point2(point1.x, y)
}
class Point3 extends Point2 {
public constructor(x: number, y: number, private readonly z: number) { super(x, y) }
public static from = (point2: Point2, z) => new Point3(point2.x, point2.y, z)
}
```
The above code currently fails to compile. It would be nice if I could somehow annotate the `from` method on `Point2` such that it was _not_ inherited. Currently, if I rename them to `from1` and `from2` then a user calling `Point3.from1(...)` will get back a `Point2` instead of the expected `Point3`. When I am authoring a `Point2` factory method, I want to tell the compiler, "It doesn't make sense to call this static method from the context of a derived class".
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals). | Suggestion,Awaiting More Feedback | low | Minor |
446,475,725 | pytorch | Segmentation fault when use torch::from_blob | my code like this:
```c++
#include <torch/script.h>
#include <torch/torch.h>
#include <opencv2/opencv.hpp>
#include <opencv2/imgproc/imgproc.hpp>
#include <iostream>
#include <memory>
#include <string>
#include <vector>
/* main */
int main(int argc, const char* argv[]) {
if (argc < 3) {
std::cerr << "usage: example-app <path-to-exported-script-module> "
<< "<path-to-image>\n";
return -1;
}
// Deserialize the ScriptModule from a file using torch::jit::load().
std::shared_ptr<torch::jit::script::Module> module = torch::jit::load(argv[1]);
assert(module != nullptr);
std::cout << "load model ok\n";
// Create a vector of inputs.
std::vector<torch::jit::IValue> inputs;
// load image with opencv and transform
cv::Mat image;
image = cv::imread(argv[2]);
cv::cvtColor(image, image, CV_BGR2RGB);
cv::Mat img_float;
image.convertTo(img_float, CV_32F, 1.0);
cv::Mat img_resize;
cv::resize(img_float, img_resize, cv::Size(144, 288));
//std::cout << img_float.at<cv::Vec3f>(56,34)[1] << std::endl;
cv::imwrite("1.png",img_resize);
auto img_tensor = torch::from_blob(img_resize.data, {1, 144, 288, 3});
img_tensor = img_tensor.permute({0,3,1,2});
img_tensor[0][0] = img_tensor[0][0].sub_(0.485).div_(0.229);
img_tensor[0][1] = img_tensor[0][1].sub_(0.456).div_(0.224);
img_tensor[0][2] = img_tensor[0][2].sub_(0.406).div_(0.225);
// //auto img_var = torch::autograd::make_variable(img_tensor, false).data();
inputs.push_back(img_tensor);
// Execute the model and turn its output into a tensor.
torch::Tensor out_tensor = module->forward(inputs).toTensor();
std::cout << out_tensor.slice(/*dim=*/1, /*start=*/0, /*end=*/23) << '\n';
printf("ok ok ok ok ok ok ok ok \n");
return 0;
}
```
and the enc is: ubuntu16.04 cuda10 pytorch1.0
my input image size is 108*271
my network is resnet50
the code can print "ok ok ok ok ok ok ok ok", then the error happens like this:
```
Thread 1 "example-app" received signal SIGSEGV, Segmentation fault.
std::_Function_handler<void (void*), torch::from_blob(void*, c10::ArrayRef<long>, c10::TensorOptions const&)::{lambda(void*)#1}>::_M_invoke(std::_Any_data const&, void*&&) (
__functor=..., __args#0=<unknown type in /home/ulsee/often/lqc/Pedestrain attribute/Person-Reid/cpp/attribute-recognition/build/example-app, CU 0x0, DIE 0xc3f92>)
at /usr/include/c++/5/functional:1871
1871 (*_Base::_M_get_pointer(__functor))(
``` | module: crash,module: cpp,module: abi,triaged | low | Critical |
446,515,006 | rust | Doc comments can be passed to macros as literals | Doc comments are the only tokens that cannot be passed to macros precisely, they are converted into a `#[doc = "text"]` form instead, which is a pretty big hack.
This conversion may change escaping in the text irrecoverably and can also change semantics in corner cases (e.g. `doc` starts going through name resolution).
Also, this is the single reason why doc comments may need a conversion at all (https://github.com/rust-lang/rust/issues/60935).
Lexically doc comments are raw string literals with weird quotes (`/**` + `*/` and `///` + `\n`).
Syntactically they certainly can be interpreted as attribute literals, similarly to how strings or integers are expression literals, and how `!` would be a type literal if it wasn't a punctuation lexically.
We can use this intuition for fixing the situation with passing doc comments to macros.
#### Declarative macros
The recently introduced `literal` matcher can start matching doc comments.
```rust
macro m($doc: literal) {
$doc
struct S;
}
m!(/** text */);
```
I don't think there are going to be any implementation issues with that.
#### Proc macros
We cannot add a new variant to `TokenTree` backward compatibly, but the content of `TokenTree::Literal` is only available through `to_string()` and is open for additions.
So, `literal.to_string()` can start returning things like `/// Text`.
Of course, `syn` and friends must be ready to get a result like this from stringifying a literal token.
| A-frontend,C-enhancement,A-macros,T-lang | low | Major |
446,519,215 | youtube-dl | [FrontendMasters.com] Course download is broken | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.05.20. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that all URLs and arguments with special characters are properly quoted or escaped as explained in http://yt-dl.org/escape.
- Search the bugtracker for similar issues: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a broken site support
- [x] I've verified that I'm running youtube-dl version **2019.05.20**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that all URLs and arguments with special characters are properly quoted or escaped
- [x] I've searched the bugtracker for similar issues including closed ones
## Verbose log
<!--
Provide the complete verbose output of youtube-dl that clearly demonstrates the problem.
Add the `-v` flag to your command line you run youtube-dl with (`youtube-dl -v <your command line>`), copy the WHOLE output and insert it below. It should look similar to this:
[debug] System config: []
[debug] User config: []
[debug] Command-line args: [u'-v', u'http://www.youtube.com/watch?v=BaW_jenozKcj']
[debug] Encodings: locale cp1251, fs mbcs, out cp866, pref cp1251
[debug] youtube-dl version 2019.05.20
[debug] Python version 2.7.11 - Windows-2003Server-5.2.3790-SP2
[debug] exe versions: ffmpeg N-75573-g1d0487f, ffprobe N-75573-g1d0487f, rtmpdump 2.4
[debug] Proxy map: {}
<more lines>
-->
```
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['-v', '-u', 'PRIVATE', '-p', 'PRIVATE', 'https://frontendmasters.com/courses/api-design-nodejs-v3']
[debug] Encodings: locale UTF-8, fs utf-8, out UTF-8, pref UTF-8
[debug] youtube-dl version 2019.05.20
[debug] Python version 3.7.3 (CPython) - Darwin-18.2.0-x86_64-i386-64bit
[debug] exe versions: ffmpeg 4.1.3, ffprobe 4.1.3, rtmpdump 2.4
[debug] Proxy map: {}
[FrontendMastersCourse] Downloading login page
[FrontendMastersCourse] Logging in
[FrontendMastersCourse] api-design-nodejs-v3: Downloading course JSON
[download] Downloading playlist: API Design in Node.js, v3
[FrontendMastersCourse] playlist API Design in Node.js, v3: Collected 43 video ids (downloading 43 of them)
[download] Downloading video 1 of 43
[FrontendMasters] Downloading login page
[FrontendMasters] Logging in
[FrontendMasters] FCTNhDyqII: Downloading webm-low source JSON
WARNING: Unable to download JSON metadata: HTTP Error 403: Forbidden
Traceback (most recent call last):
File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 193, in _run_module_as_main
"__main__", mod_spec)
File "/usr/local/Cellar/python/3.7.3/Frameworks/Python.framework/Versions/3.7/lib/python3.7/runpy.py", line 85, in _run_code
exec(code, run_globals)
File "/usr/local/bin/youtube-dl/__main__.py", line 19, in <module>
File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 474, in main
File "/usr/local/bin/youtube-dl/youtube_dl/__init__.py", line 464, in _real_main
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 2008, in download
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 807, in extract_info
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 1006, in process_ie_result
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 873, in process_ie_result
File "/usr/local/bin/youtube-dl/youtube_dl/YoutubeDL.py", line 796, in extract_info
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/common.py", line 529, in extract
File "/usr/local/bin/youtube-dl/youtube_dl/extractor/frontendmasters.py", line 161, in _real_extract
TypeError: 'bool' object is not subscriptable
```
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Provide any additional information, suggested solution and as much context and examples as possible.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
I tried with all these links, but none worked:
- https://frontendmasters.com/courses/api-design-nodejs-v3
- https://frontendmasters.com/courses/graphql
- https://frontendmasters.com/courses/electron-v2
- https://frontendmasters.com/courses/firebase-react-v2
- https://frontendmasters.com/courses/typescript-v2
- https://frontendmasters.com/courses/deep-javascript-v3
- https://frontendmasters.com/courses/js-recent-parts
- https://frontendmasters.com/courses/python
- https://frontendmasters.com/courses/intermediate-python
| account-needed | low | Critical |
446,569,326 | angular | Template driven ngForm doesn't have a value on radio inputs | <!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🐞 bug report
### Affected Package
<!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->
<!-- ✍️edit: -->
@angular/forms
### Description
<!-- ✍️-->
When using a conditional directive like ngIf on radio input, value on ngForm for that control will be empty. As well as the control itself on ngForm. This happens on Template driven forms.
## 🔬 Minimal Reproduction
<!--
Please create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2
-->
<!-- ✍️-->
https://stackblitz.com/fork/angular-dssxnc
<!--
If StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.
A good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem.
Share the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.
Issues that don't have enough info and can't be reproduced will be closed.
You can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue
-->
## 🌍 Your Environment
**Angular Version:**
<pre><code>
Angular CLI: 7.0.5
Node: 10.14.1
OS: linux x64
Angular: 7.0.3
... animations, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... platform-server, router
Package Version
-----------------------------------------------------------
@angular-devkit/architect 0.10.5
@angular-devkit/build-optimizer 0.10.5
@angular-devkit/core 7.0.5
@angular-devkit/schematics 7.0.5
@angular/cli 7.0.5
@ngtools/webpack 7.0.5
@schematics/angular 7.0.5
@schematics/update 0.10.5
rxjs 6.3.3
typescript 3.1.6
webpack 4.25.1
</code></pre>
| type: bug/fix,freq2: medium,area: forms,state: confirmed,forms: template-driven,P3 | low | Critical |
446,600,392 | pytorch | cmake for Torch unusable in archlinux | ## 🐛 Bug
When running the example of using libtorch with cmake, it errors about missing `libc10_cuda` during `find_library(Torch REQUIRED)`:
```
CMake Error at /usr/lib64/cmake/Caffe2/Caffe2Targets.cmake:107 (message):
The imported target "c10_cuda" references the file
"/usr/lib/libc10_cuda.so"
but this file does not exist. Possible reasons include:
* The file was deleted, renamed, or moved to another location.
* An install or uninstall procedure did not complete successfully.
* The installation package was faulty and contained
"/usr/lib64/cmake/Caffe2/Caffe2Targets.cmake"
but not all the files it references.
Call Stack (most recent call first):
/usr/lib64/cmake/Caffe2/Caffe2Config.cmake:116 (include)
/usr/lib64/cmake/Torch/TorchConfig.cmake:39 (find_package)
CMakeLists.txt:4 (find_package)
-- Configuring incomplete, errors occurred!
```
It tries to find it under `/usr/lib`, but arch's package manager installs it to `/usr/lib/pytorch`. So it's either the packager didn't install it to the correct place, or the `Caffe2Targets.cmake` file not rigorous enough about ELF location.
What's your thought on this? Is it proper to modify `Caffe2Targets.cmake` so it can find the lib correctly under this circumstance, or at least provides a variable or something to workaround this please.
## To Reproduce
```cmake
cmake_minimum_required(VERSION 3.0 FATAL_ERROR)
project(custom_ops)
find_package(Torch REQUIRED)
add_executable(test test.cc)
# target_link_libraries(test "-L/usr/lib/pytorch -lc10 -lc10_cuda -lcaffe2 -lmklml_intel -ltorch -lshm -L/opt/cuda/targets/x86_64-linux/lib -lnvrtc -lcuda")
target_link_libraries(test "${TORCH_LIBRARIES}")
set_property(TARGET test PROPERTY CXX_STANDARD 11)
```
```
cmake ..
```
## Environment
PyTorch version: 1.0.1
Is debug build: No
CUDA used to build PyTorch: 10.1.105
OS: Arch Linux
GCC version: (GCC) 8.3.0
CMake version: version 3.14.4
Python version: 3.7
Is CUDA available: Yes
CUDA runtime version: 10.1.168
GPU models and configuration: GPU 0: GeForce GTX 1060 6GB
Nvidia driver version: 430.14
cuDNN version: /usr/lib/libcudnn.so.7.5.1
Versions of relevant libraries:
[pip3] numpy==1.16.3
[pip3] torch==1.0.1
[pip3] torchvision==0.2.2.post3
[conda] Could not collect
## Additional context
the package I install is named "python-pytorch-cuda" under arch.
| module: dependency bug,module: build,triaged | low | Critical |
446,646,037 | electron | Feature Request: continuity camera for macOS app | ### Preflight Checklist
<!-- Please ensure you've completed the following steps by replacing [ ] with [x]-->
* [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/master/CONTRIBUTING.md) for this project.
* [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/master/CODE_OF_CONDUCT.md) that this project adheres to.
* [x] I have searched the issue tracker for a feature request that matches the one I want to file, without success.
### Problem Description
I want paste photo from my iPhone camera in my application. This feature implemented in macOS Mojave.
<img width="402" alt="Screenshot 2019-05-21 at 17 12 49" src="https://user-images.githubusercontent.com/9060043/58103681-12d5a380-7bec-11e9-80e7-da58150ad690.png">
### Proposed Solution
Add method for opening camera in my iPhone and returning image
### Alternatives Considered
None
### Additional Information
[Doc](https://developer.apple.com/documentation/appkit/supporting_continuity_camera_in_your_mac_app) for Xcode | enhancement :sparkles:,platform/macOS | low | Minor |
446,649,020 | vue-element-admin | 安装过程出现问题 | <!--
注意：为更好的解决你的问题，请参考模板提供完整信息，准确描述问题，信息不全的 issue 将被关闭。
Note: In order to better solve your problem, please refer to the template to provide complete information, accurately describe the problem, and the incomplete information issue will be closed.
-->
## Bug report（问题描述）
npm install安装出现问题
yarn安装出现问题
#### Steps to reproduce（问题复现步骤）
先使用npm install安装失败
见图1
使用yarn安装出现一个warn警告，提示jsonlint包不再维护安装失败。
见图2
讲jsonlint从package.json删除，依旧安装失败
见图3
将yarn的registry换成淘宝源再次安装依旧失败见
图2
最后使用万恶的cnpm安装成功。。。
见图4
#### Screenshot or Gif（截图或动态图）
1.
2.
3.
4.
#### Link to minimal reproduction（最小可在线还原demo）
<!--
Please only use Codepen, JSFiddle, CodeSandbox or a github repo
-->
#### Other relevant information（格外信息）
- Your OS:windows朋友的mac也是一样
- Node.js version:10.13.0
- vue-element-admin version:4.2.0
| enhancement :star: | low | Critical |
446,661,834 | TypeScript | Optional arguments in JSDoc types may be moved to TypeScript types quickfix | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.3
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
- `80004`
- `jsdoc quickfix optional`
**Code**
With Closure Compiler, you mark a function parameter optional by adding an `=` after its type ([reference][2]):
```ts
/**
* @param a {string} Base string.
* @param b {string=} Optional string to add
* @return {string}
*/
function foo(a, b) {
if (b) return a + b;
return a;
}
```
TypeScript offers a quickfix to convert these jsdoc annotations to TypeScript types:
**Expected behavior:**
The `b` parameter should be optional:
```ts
/**
* @param a {string} Base string.
* @param b {string=} Optional string to add
* @return {string}
*/
function foo(a: string, b?: string): string {
if (b) return a + b;
return a;
}
```
**Actual behavior:**
The `b` parameter is required but has type `string | optional`:
```ts
/**
* @param a {string} Base string.
* @param b {string=} Optional string to add
* @return {string}
*/
function foo(a: string, b: string | undefined): string {
if (b) return a + b;
return a;
}
```
This means that all calls of the function which don't specify `b` will be flagged as errors.
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> [link][1], though quickfixes are not available there
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
[1]: http://www.typescriptlang.org/play/#src=%2F**%0D%0A%20*%20%40param%20a%20%7Bstring%7D%20Base%20string.%0D%0A%20*%20%40param%20b%20%7Bstring%3D%7D%20Optional%20string%20to%20add%0D%0A%20*%20%40return%20%7Bstring%7D%0D%0A%20*%2F%0D%0Afunction%20foo(a%2C%20b)%20%7B%0D%0A%20%20if%20(b)%20return%20a%20%2B%20b%3B%0D%0A%20%20return%20a%3B%0D%0A%7D%0D%0A
[2]: https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#optional-parameter-in-a-param-annotation | Suggestion,Awaiting More Feedback | low | Critical |
446,665,952 | TypeScript | Move types from jsdoc quickfix (instead of copy) | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
- `jsdoc quickfix`
- 80004
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
There's a great quickfix available to copy JSDoc type annotations to TypeScript annotations:
When you do this, however, you still have type annotations in your JSDoc. This is duplicative and is likely to lead to the types getting out of sync over time. It's best to avoid putting type information in JSDoc once you're using TypeScript.
I'd like a quickfix that annotates types _and_ removes the types from the JSDoc.
<!-- A summary of what you'd like to see added or changed -->
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
This would be helpful for any project converting from JavaScript to TypeScript. You should convert your JSDoc types to TypeScript types and you should remove types from your JSDoc once you do. This sort of quickfix would help people get to the right place.
## Examples
<!-- Show how this would be used and what the behavior would be -->
```ts
/**
* @param a {string} Base string.
* @param b {string=} Optional string to add
* @return {string}
*/
function foo(a, b) {
if (b) return a + b;
return a;
}
```
should get converted to:
```ts
/**
* @param a Base string.
* @param b Optional string to add
*/
function foo(a: string, b?: string): string {
if (b) return a + b;
return a;
}
```
rather than:
```ts
/**
* @param a {string} Base string.
* @param b {string=} Optional string to add
* @return {string}
*/
function foo(a: string, b: string | undefined): string {
if (b) return a + b;
return a;
}
```
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
446,673,450 | flutter | CupertinoSliverNavigationBar and CupertinoNavigationBar leading and trailing are always CupertinoColors.activeBlue during transition | ## Use case
2 Widgets:
1. One with a `CupertinoSliverNavigationBar` inside `CustomScrollView`
2. the second with a `CupertinoNavigationBar` at the top.
3.
4. Set the `CupertinoTheme`'s data's `brightness` to `Brightness.dark`.
5.
6. Push Widget 2 onto the stack.
7. Widget 2 has an **orange leading back arrow** icon.
8. Pop Widget 2 from the stack: **During the transition the back arrow is blue**.
## Proposal
Maintain the color of the leading and trailing during transition.
| waiting for customer response,framework,f: cupertino,c: proposal,P2,team-design,triaged-design | low | Minor |
446,690,122 | TypeScript | Support Closure Compiler-style @typedef | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
- Closure Compiler typedef
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
With Closure Compiler-style JSDoc, you name an `@typedef` type definition by introducing a `var` in the next statement:
```ts
/** @typedef {(string|number)} */
var NumberLike;
```
TypeScript doesn't recognize this construct. Instead, it wants you to write:
```ts
/** @typedef {(string|number)} NumberLike */
```
## Use Cases
Migrating code written for use with Google's Closure Compiler over to TypeScript.
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
<!-- Show how this would be used and what the behavior would be -->
See above. My proposal is that, when prefixed with an `@typedef` with only a type (and no name), a variable definition would create a symbol in the type namespace in addition to the value namespace.
## Checklist
My suggestion meets these guidelines:
* [ ] This wouldn't be a breaking change in existing TypeScript/JavaScript code
→ If the variable has the same name as an existing type, this would create a break. But this would indicate an issue if the two types disagreed.
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
[1]: https://github.com/google/closure-compiler/wiki/Annotating-JavaScript-for-the-Closure-Compiler#typedef-type | Suggestion,Awaiting More Feedback | low | Critical |
446,694,041 | TypeScript | Quick fix to convert @typedef to type or interface | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
- `typedef quickfix`
- `typedef jsdoc`
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
I have lots of code in an old Closure Compiler-style project that looks like this:
```ts
/**
* @typedef {{
* px: number,
* py: number,
* isZooming: boolean,
* isPanning: boolean,
* is2DPan: boolean,
* cancelNextDblclick: boolean,
* initializeMouseDown: (e: !Event, dygraph:!DygraphAny, context: !DygraphInteractionContext) => void
* }} DygraphInteractionContext
*/
```
If I declare a variable with this type, I can see that TypeScript understands the `@typedef`:
```ts
type DygraphInteractionContext = {
px: number;
py: number;
isZooming: boolean;
isPanning: boolean;
is2DPan: boolean;
cancelNextDblclick: boolean;
initializeMouseDown: (e: Event, dygraph: any, context: ...) => void;
}
```
I'd like to convert this to a `type` or `interface`. I can introduce a dummy variable, copy the TS-style `type` declaration and paste it in to do the conversion.
But it'd be easier if there were a quickfix!
## Use Cases
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
Migrating a project that used JSDoc-based typing. A workaround is available, but a quickfix would be a big improvement.
## Examples
<!-- Show how this would be used and what the behavior would be -->
(see above)
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
446,696,182 | vscode | [css] Wrong selector specificity values with :nth-child(even) and :nth-child(odd) | Issue Type: <b>Bug</b>
In CSS files :
It seems like `odd` and `even` keywords count as element selectors.
`div:nth-child(odd){...}`
indicates
`<div :nth-child>`
`Selector Specificity: (0, 1, 2)`
Specificity should be `Selector Specificity: (0, 1, 1)`
VS Code version: Code 1.33.1 (51b0b28134d51361cf996d2f0a1c698247aeabd8, 2019-04-11T08:27:14.102Z)
OS version: Windows_NT x64 10.0.17763
Extensions: none
<!-- generated by issue reporter --> | bug,css-less-scss | low | Critical |
446,699,575 | rust | There should be a way to unwrap MaybeUninits without moving them | [`MaybeUninit`](https://doc.rust-lang.org/nightly/std/mem/union.MaybeUninit.html) has an API where you construct a `MaybeUninit<T>`, can operate on it via raw pointer methods, and then can call [`assume_init()`](https://doc.rust-lang.org/nightly/std/mem/union.MaybeUninit.html#method.assume_init) to move the inner value out. It also has methods that let you assume that it is initialized and obtain safe Rust references.
This is great for temporary initialization on the stack, but this doesn't work so well for the heap. What if you need to gradually initialize `Vec<T>` or `Arc<T>` heap values? This ends up leaving a carcass of a `MaybeUninit` in the type forever, basically infecting the type with an unsafe abstraction from the time of its initialization.
One solution here is to make sure `MaybeUninit` and `ManuallyDrop` have a repr of `T` (basically, `repr(transparent)`, except we haven't defined that for unions) so that you can always transmute `&MaybeUninit<T>` to `&T`, or `Arc<MaybeUninit<T>>` into `Arc<T>`.
The fact that `MaybeUninit` has methods specifically for doing this kind of thing with slices seems to point to the need for this ability to be generalized.
Either way we should have clear documentation for using `MaybeUninit` with values not on your stack (on the heap, or passed in as a reference). Ideally we allow you to transmute it in such cases (and have examples doing this), but if we can't, we should still document that you shouldn't use it that way. (I think that this choice would preclude a lot of legitimate and necessary use cases, especially in FFI)
cc @eddyb @RalfJung | T-libs-api,C-feature-request | medium | Critical |
446,704,182 | TypeScript | ServiceWorkerRegistration.Update() should return Promise<ServiceWorkerRegistration> | **TypeScript Version:** 3.4.3
**Search Terms:**
ServiceWorkerRegistration Update
**Code**
```ts
// A *self-contained* demonstration of the problem follows...
// Test this by running `tsc` on the command-line, rather than through another build tool such as Gulp, Webpack, etc.
let isUpdating: boolean;
navigator.serviceWorker.getRegistration().then(sw => {
sw.update().then(result => {
if (result.installing || result.waiting) {
isUpdating = true;
}
});
});
```
**Expected behavior:**
`result` is of type `ServiceWorkerRegistration` and `result.installing` and `result.waiting` are valid.
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorkerRegistration/update
**Actual behavior:**
`result` is of type void and tsc gives errors
`error TS2339: Property 'installing' does not exist on type 'void'.`
`error TS2339: Property 'waiting' does not exist on type 'void'.`
[**Playground Link**](https://www.typescriptlang.org/play/#src=let%20isUpdating%3A%20boolean%3B%0D%0Anavigator.serviceWorker.getRegistration().then(sw%20%3D%3E%20%7B%0D%0A%20%20%20%20sw.update().then(result%20%3D%3E%20%7B%0D%0A%20%20%20%20%20%20%20%20if%20(result.installing%20%7C%7C%20result.waiting)%20%7B%0D%0A%20%20%20%20%20%20%20%20%20%20%20%20isUpdating%20%3D%20true%3B%0D%0A%20%20%20%20%20%20%20%20%7D%0D%0A%20%20%20%20%7D)%3B%0D%0A%7D)%3B%0D%0A)
**Related Issues:**
https://github.com/microsoft/TypeScript/issues/17590 | Bug,Domain: lib.d.ts | low | Critical |
446,707,769 | youtube-dl | Add an option to change the extension of description file | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.05.20. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Search the bugtracker for similar feature requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [X] I'm reporting a feature request
- [X] I've verified that I'm running youtube-dl version **2019.05.20**
- [X] I've searched the bugtracker for similar feature requests including closed ones
## Description
<!--
Provide an explanation of your issue in an arbitrary form. Please make sure the description is worded well enough to be understood, see https://github.com/ytdl-org/youtube-dl#is-the-description-of-the-issue-itself-sufficient. Provide any additional information, suggested solution and as much context and examples as possible.
-->
By default `.description` is used, but since this isn't a standard extension, many file managers will not know how to open it. I'd prefer to change it to use `.txt`. | request | low | Critical |
446,730,459 | TypeScript | Quick Fix: Infer parameter types from usage … for one function | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
- 7043
- 7044
- `better type may be inferred from usage`
<!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily -->
## Suggestion
There's a quickfix to infer types from usage for variables that are implicitly `any`:
The two options are both useful, but for a large file the "Infer all types from usage" option feels a bit extreme. But inferring symbol-by-symbol can get tedious.
I'm proposing a middle ground option, something like "Infer all types in this block."
<!-- A summary of what you'd like to see added or changed -->
## Use Cases
Adding type annotations to variables in large files based on usage piecemeal.
<!--
What do you want to use this for?
What shortcomings exist with current approaches?
-->
## Examples
<!-- Show how this would be used and what the behavior would be -->
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
| Suggestion,Awaiting More Feedback | low | Critical |
446,796,716 | terminal | Code Health: Follow ES.9: Avoid ALL_CAPS names per ISO C++ guidelines | Per ISO C++ guidelines, ALL_CAPS is to be avoided except for macros:
[ES.9: Avoid ALL_CAPS names](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines.html#es9-avoid-all_caps-names)
The reasoning behind this is that it allows the pre-processor to silently replace you variables with a macro definition without a warning.
_Originally posted by @binarycrusader in https://github.com/microsoft/terminal/pull/913_ | Product-Meta,Issue-Task,Area-CodeHealth | low | Minor |
446,797,943 | terminal | Make all test binaries consistent in Target and Project name | Probably another area where cleanup/reconciliation is needed.
The Host Unit Tests (the O.G. of our testing libraries) says
```
<ProjectName>Host.Tests.Unit</ProjectName>
<TargetName>Conhost.Unit.Tests</TargetName>
```
So at least the target name might need to be pluralized to match the pattern in the CI (i.e. `Types.Unit.Tests`).
I think ProjectName only affects the sort order inside Visual Studio so similar projects are sorted together visually.
I'd recommend aligning at least the `TargetName` (or confirming the CI pattern isn't looking for the plural) here and then filing a follow on task to make the test libraries named more consistently.
_Originally posted by @miniksa in https://github.com/_render_node/MDIzOlB1bGxSZXF1ZXN0UmV2aWV3VGhyZWFkMTc1MTU5OTM4OnYy/pull_request_review_threads/discussion_ | Product-Meta,Issue-Task,Area-CodeHealth | low | Minor |
446,798,729 | godot | Segfault when running PCK from older Godot version with newer Server binary | **Godot version:**
3.1
**OS/device including version:**
Ubuntu 18.04
**Issue description:**
Running a 3.1 export .pck using 3.1.1 server binary results in segfault without message as to why.
*Original issue*:
Game server runs fine in editor and as exported executable, but not when running .pck file via server binary.
I have game client and server. In editor both run fine, exported and executed directly, both run fine. However when using the server template from https://godotengine.org/download/server I get segfault.
**Minimal reproduction project:**
Can follow the original ones. The server .pck provided was exported using 3.1-stable, and if run with official 3.1.1 server binary you'll see segfault.
What's curious is as far as I can tell, you still have to click the "Lets go" button on client to trigger crash.
*Original steps*:
Not sure what issue is, so included my client/server in addition to exports of both. Instructions in zip on how to run and achieve segfault.
Note if you want to export my project, be sure to include *.json resources.
Zip for download at https://menip.itch.io/deathmatch. Password is "godot"
| bug,topic:core,confirmed,crash | low | Critical |
446,801,334 | TypeScript | Convert to class declaration quick fix misses superclass | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.3
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
- class declaration quick fix
- 80002
**Code**
This code is a mix of ES2015- and function-style classes:
```ts
class A {
constructor() {
this.a = 'a';
}
doAThing() {
console.log(this.a);
}
}
/**
* @constructor
* @extends {A}
*/
function B() {
this.b = 'b';
}
B.prototype = new A();
B.prototype.doBThing = function() {
console.log('b: ', b);
};
```
The TS language services offer a quickfix to convert B into an ES2015 class. Great!
**Expected behavior:**
I'd hope that one of (or both of) the `@extends` and `B.prototype = new A();` would result in `B extends A`:
```ts
class B extends A {
constructor() {
super();
this.b = 'b';
}
doBThing() {
console.log('b: ', b);
}
}
```
**Actual behavior:**
The quick fix produces this code:
```ts
/**
* @constructor
* @extends {A}
*/
class B {
constructor() {
this.b = 'b';
}
doBThing() {
console.log('b: ', b);
}
}
B.prototype = new A();
```
TypeScript flags an error on the last line:
(property) B.prototype: B
Type 'A' is missing the following properties from type 'B': b, doBThingts(2739)
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> no quickfixes on the playground, alas!
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
| Suggestion,Awaiting More Feedback | low | Critical |
446,807,160 | rust | Handle fully enclosed multiline spans gracefully in emitter | Currently the solution to overlapping multiline spans is _correct_, but doesn't handle spans that are completely enclosed by others in any way, simply using span ordering and growing towards the left as needed. The following is a representative example of the problem:
```
error[E0308]: if and else have incompatible types
--> src/libsyntax/parse/parser.rs:2640:33
|
2636 | let (span, msg) = if self.token == token::Token::Eof && self.is_subparser {
| _______________________________________________-
2637 | | (self.sess.source_map().next_point(self.span),
| _|_________________________________-
2638 | | | "expected expression, found end of macro arguments")
| |_|_____________________________________________________________________________________- expected because of this
2639 | | } else {
2640 | / | (self.span, format!(
2641 | | | "expected expression, found {}",
2642 | | | self.this_token_descr(),
2643 | | | ))
| |_|__________________________________^ expected &str, found struct `std::string::String`
2644 | | };
| |_____________________________- if and else have incompatible types
|
= note: expected type `(syntax_pos::span_encoding::Span, &str)`
found type `(syntax_pos::span_encoding::Span, std::string::String)`
```
Ideally, the emitter should handle this case by identifying that there are overlapping spans that are fully enclosed and special case the output to make it easier to read:
```
error[E0308]: if and else have incompatible types
--> src/libsyntax/parse/parser.rs:2640:33
|
2636 | let (span, msg) = if self.token == token::Token::Eof && self.is_subparser {
| ________________________________________________-
2637 | | / (self.sess.source_map().next_point(self.span),
2638 | | | "expected expression, found end of macro arguments")
| | |____________________________________________________________________________________- expected because of this
2639 | | } else {
2640 | | / (self.span, format!(
2641 | | | "expected expression, found {}",
2642 | | | self.this_token_descr(),
2643 | | | ))
| | |_________________________________^ expected &str, found struct `std::string::String`
2644 | | };
| |______________________________- if and else have incompatible types
|
= note: expected type `(syntax_pos::span_encoding::Span, &str)`
found type `(syntax_pos::span_encoding::Span, std::string::String)`
``` | C-enhancement,A-diagnostics,P-low,T-compiler | low | Critical |
446,835,176 | pytorch | Caffe2: executor_test.py::ExecutorGPUResNetTest fails with an AssertionError | ## 🐛 Bug
The `executor_test.py::ExecutorGPUResNetTest::test_executor` test case fails on both x86 and Power9 with an error about a blob be completely different on different runs.
## To Reproduce
Steps to reproduce the behavior:
1. Install Caffe2
2. Run `python caffe2/python/test/executor_test.py ExecutorGPUResNetTest`
The `test_executor` case fails with an error about `comp_2_sum_3_grad_autosplit_0` differing in parallel runs. The full output is below:
```
$ python executor_test.py ExecutorGPUResNetTest
Ignoring @/caffe2/caffe2/contrib/nccl:nccl_ops as it is not a valid file.
Ignoring @/caffe2/caffe2/contrib/gloo:gloo_ops as it is not a valid file.
Ignoring @/caffe2/caffe2/contrib/gloo:gloo_ops_gpu as it is not a valid file.
INFO:caffe2.python.net_drawer:Cannot import pydot, which is required for drawing a network. This can usually be installed in python with "pip install pydot". Also, pydot requires graphviz to convert dot files to pdf: in ubuntu, this can usually be installed with "sudo apt-get install graphviz".
net_drawer will not run correctly. Please install the correct dependencies.
[E init_intrinsics_check.cc:43] CPU feature avx is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature avx2 is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
[E init_intrinsics_check.cc:43] CPU feature fma is present on your machine, but the Caffe2 binary is not compiled with it. It means you may not get the full speed of your CPU.
Trying example: test_executor(self=<__main__.ExecutorGPUResNetTest testMethod=test_executor>, executor='parallel', num_workers=8)
INFO:data_parallel_model:Parallelizing model for devices: [0, 1]
INFO:data_parallel_model:Create input and model training operators
INFO:data_parallel_model:Model for GPU : 0
/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/brew.py:97: DeprecationWarning: inspect.getargspec() is deprecated since Python 3.0, use inspect.signature() or inspect.getfullargspec()
var_names, _, varkw, _= inspect.getargspec(func)
INFO:data_parallel_model:Model for GPU : 1
INFO:data_parallel_model:Adding gradient operators
INFO:data_parallel_model:Add gradient all-reduces for SyncSGD
INFO:data_parallel_model:Post-iteration operators for updating params
INFO:data_parallel_model:Calling optimizer builder function
INFO:data_parallel_model:Add initial parameter sync
WARNING:data_parallel_model:------- DEPRECATED API, please use data_parallel_model.OptimizeGradientMemory() -----
/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/memonger.py:55: DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
log.warn("NOTE: Executing memonger to optimize gradient memory")
WARNING:memonger:NOTE: Executing memonger to optimize gradient memory
[I memonger.cc:236] Remapping 108 using 14 shared blobs.
INFO:memonger:Memonger memory optimization took 0.030774593353271484 secs
WARNING:memonger:NOTE: Executing memonger to optimize gradient memory
[I memonger.cc:236] Remapping 108 using 14 shared blobs.
INFO:memonger:Memonger memory optimization took 0.04712033271789551 secs
Finished iteration 1/1 (1.90 images/sec)
[I net_dag_utils.cc:102] Operator graph pruning prior to chain compute took: 0.00131458 secs
[I net_parallel.cc:87] Initialized parallel net: 'test_resnet50', #ops: 1675, #chains: 1524, #workers: 8, dfs scheduling: 0, task graph engine: futures
[I net_async_base.h:205] Using specified CUDA pool size: 8; device id: 0
[I net_async_base.h:218] Created shared CUDA pool, size: 8; device id: 0
[I net_async_base.h:205] Using specified CPU pool size: 8; device id: -1
[I net_async_base.h:218] Created shared CPU pool, size: 8; device id: -1
[I net_async_base.h:205] Using specified CUDA pool size: 8; device id: 1
[I net_async_base.h:218] Created shared CUDA pool, size: 8; device id: 1
Finished iteration 1/1 (44.82 images/sec)
Traceback (most recent call last):
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/core.py", line 672, in evaluate_test_data
result = self.execute(data, collect=True)
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/core.py", line 587, in execute
result = self.test_runner(data, run)
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/executors.py", line 58, in default_new_style_executor
return function(data)
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/core.py", line 583, in run
return test(*args, **kwargs)
File "executor_test.py", line 53, in test_executor
num_workers=st.sampled_from([8]))
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/core.py", line 525, in test
result = self.test(*args, **kwargs)
File "executor_test.py", line 67, in test_executor
model_run_func=run_model,
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/test/executor_test_util.py", line 268, in compare_executors
"Blob {} differs in {} run".format(blob_name, test_executor))
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/numpy/testing/nose_tools/utils.py", line 857, in assert_array_equal
verbose=verbose, header='Arrays are not equal')
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/numpy/testing/nose_tools/utils.py", line 781, in assert_array_compare
raise AssertionError(msg)
AssertionError:
Arrays are not equal
Blob _gpu_0/comp_2_sum_3_grad_autosplit_0 differs in parallel run
(mismatch 100.0%)
x: array([[[[ 1.008181e-04, -6.411409e-05, 5.045671e-05, ...,
-6.273524e-05, 1.340966e-04, 6.698444e-05],
[-1.703523e-04, -2.880513e-04, 3.850183e-05, ...,...
y: array([[[[-3.788031e-05, 1.195416e-04, 5.127888e-05, ...,
-1.146530e-04, 1.209393e-04, 3.692786e-05],
[-6.415213e-05, 2.887475e-05, 1.446379e-04, ...,...
```
<!-- If you have a code sample, error messages, stack traces, please provide it here as well -->
## Expected behavior
Test case should pass
## Environment
PyTorch version: 1.1.0
Is debug build: No
CUDA used to build PyTorch: 10.1.168
OS: Red Hat
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
CMake version: version 2.8.12.2
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: Tesla V100-PCIE-16GB
GPU 1: Tesla V100-PCIE-16GB
Nvidia driver version: 418.40.04
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] numpy==1.14.6
[pip] torch==1.1.0
[pip] torchvision==0.2.2
[conda] blas 1.0 mkl
[conda] magma 2.5.0
[conda] mkl 2018.0.3
[conda] mkl_fft 1.0.6
[conda] mkl_random 1.0.1
[conda] pytorch 1.1.0
### Power
PyTorch version: 1.1.0
Is debug build: No
CUDA used to build PyTorch: 10.1.168
OS: Red Hat Enterprise Linux Server 7.6 (Maipo)
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
CMake version: Could not collect
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.1.105
GPU models and configuration:
GPU 0: Tesla V100-SXM2-16GB
GPU 1: Tesla V100-SXM2-16GB
GPU 2: Tesla V100-SXM2-16GB
GPU 3: Tesla V100-SXM2-16GB
Nvidia driver version: 418.67
cuDNN version: 7.5.1
Versions of relevant libraries:
[pip] numpy==1.14.5
[pip] torch==1.1.0
[pip] torchvision==0.2.2
[conda] magma 2.5.0
[conda] pytorch 1.1.0 | caffe2 | low | Critical |
446,839,264 | pytorch | Caffe2: operator_test/instance_norm_test.py::TestInstanceNorm::test_instance_norm_gradients test case fails with "RuntimeError: dim() called on undefined TensorError from operator" | ## 🐛 Bug
The `operator_test/instance_norm_test.py::TestInstanceNorm::test_instance_norm_gradients` test case fails with a RuntimeError about ` test case fails intermittently
## To Reproduce
Steps to reproduce the behavior:
1. Install Caffe2
2. Run `python caffe2/python/operator_test/instance_norm_test.py TestInstanceNorm`
The test fails on `test_instance_norm_gradients` with the following error:
```
ERROR: test_instance_norm_gradients (__main__.TestInstanceNorm)
----------------------------------------------------------------------
Traceback (most recent call last):
File "instance_norm_test.py", line 54, in test_instance_norm_gradients
dc=hu.gcs['dc'],
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/core.py", line 1046, in wrapped_test
state.run()
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/core.py", line 814, in run
falsifying_example.__expected_traceback,
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/core.py", line 587, in execute
result = self.test_runner(data, run)
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/executors.py", line 58, in default_new_style_executor
return function(data)
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/core.py", line 578, in run
return test(*args, **kwargs)
File "instance_norm_test.py", line 54, in test_instance_norm_gradients
dc=hu.gcs['dc'],
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/hypothesis/core.py", line 525, in test
result = self.test(*args, **kwargs)
File "instance_norm_test.py", line 92, in test_instance_norm_gradients
threshold=0.01)
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/hypothesis_test_util.py", line 458, in assertGradientChecks
input_device_options=input_device_options
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/gradient_checker.py", line 281, in CheckSimple
outputs_with_grads
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/gradient_checker.py", line 200, in GetLossAndGrad
workspace.RunOperatorsOnce(grad_ops)
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/workspace.py", line 199, in RunOperatorsOnce
success = RunOperatorOnce(op)
File "/home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/workspace.py", line 190, in RunOperatorOnce
return C.run_operator_once(StringifyProto(operator))
RuntimeError: dim() called on undefined TensorError from operator:
input: "input" input: "scale" input: "bias" input: "output_grad" output: "input_grad" output: "scale_grad" output: "bias_grad" name: "" type: "InstanceNormGradient" arg { name: "order" s: "NCHW" } arg { name: "epsilon" f: 1e-06 } device_option { device_type: 1 } is_gradient_op: true (dim at ../c10/core/UndefinedTensorImpl.cpp:24)
frame #0: c10::Error::Error(c10::SourceLocation, std::__cxx11::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) + 0x6d (0x7f7bffeae80d in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libc10.so)
frame #1: c10::UndefinedTensorImpl::dim() const + 0xc3 (0x7f7bffea7aa3 in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libc10.so)
frame #2: void c10::TensorImpl::Resize<int, int>(int, int) + 0x160 (0x7f7c11980680 in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2.so)
frame #3: caffe2::InstanceNormGradientOp<float, caffe2::CUDAContext>::RunOnDeviceWithOrderNCHW() + 0x821 (0x7f7c02d097e1 in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2_gpu.so)
frame #4: <unknown function> + 0x27a449c (0x7f7c02d0a49c in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2_gpu.so)
frame #5: <unknown function> + 0x267cb28 (0x7f7c02be2b28 in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2_gpu.so)
frame #6: caffe2::Workspace::RunOperatorOnce(caffe2::OperatorDef const&) + 0x4a (0x7f7c11617f7a in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/../../torch/lib/libcaffe2.so)
frame #7: <unknown function> + 0x4fd9d (0x7f7c138e4d9d in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/caffe2_pybind11_state_gpu.cpython-36m-x86_64-linux-gnu.so)
frame #8: <unknown function> + 0x4ff17 (0x7f7c138e4f17 in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/caffe2_pybind11_state_gpu.cpython-36m-x86_64-linux-gnu.so)
frame #9: <unknown function> + 0x8dd0e (0x7f7c13922d0e in /home/cphofer/anaconda3/envs/pytorch_env/lib/python3.6/site-packages/caffe2/python/caffe2_pybind11_state_gpu.cpython-36m-x86_64-linux-gnu.so)
<omitting python frames>
```
## Expected behavior
The test case should pass
## Environment
### x86
PyTorch version: 1.1.0
Is debug build: No
CUDA used to build PyTorch: 10.1.168
OS: Red Hat
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
CMake version: version 2.8.12.2
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: Could not collect
GPU models and configuration:
GPU 0: Tesla V100-PCIE-16GB
GPU 1: Tesla V100-PCIE-16GB
Nvidia driver version: 418.40.04
cuDNN version: Could not collect
Versions of relevant libraries:
[pip] numpy==1.14.6
[pip] torch==1.1.0
[pip] torchvision==0.2.2
[conda] blas 1.0 mkl
[conda] magma 2.5.0
[conda] mkl 2018.0.3
[conda] mkl_fft 1.0.6
[conda] mkl_random 1.0.1
[conda] pytorch 1.1.0
### Power
PyTorch version: 1.1.0
Is debug build: No
CUDA used to build PyTorch: 10.1.168
OS: Red Hat Enterprise Linux Server 7.6 (Maipo)
GCC version: (GCC) 4.8.5 20150623 (Red Hat 4.8.5-36)
CMake version: Could not collect
Python version: 3.6
Is CUDA available: Yes
CUDA runtime version: 10.1.105
GPU models and configuration:
GPU 0: Tesla V100-SXM2-16GB
GPU 1: Tesla V100-SXM2-16GB
GPU 2: Tesla V100-SXM2-16GB
GPU 3: Tesla V100-SXM2-16GB
Nvidia driver version: 418.67
cuDNN version: 7.5.1
Versions of relevant libraries:
[pip] numpy==1.14.5
[pip] torch==1.1.0
[pip] torchvision==0.2.2
[conda] magma 2.5.0
[conda] pytorch 1.1.0
| caffe2 | low | Critical |
446,877,820 | TypeScript | CTRL-Click not working on require('...') path | <!-- Use Help > Report Issue to prefill these. -->
- VSCode Version: 1.34.0
- OS Version: Ubuntu 18.04
Steps to Reproduce:
1. Create a `index.js` and a `mocks.js` files in the same folder
2. Put the following code in `index.js`:
`require('./mocks.js');`
2. Try to CTRL+Click on the path to enable navigation and witness that it is not possible.
<!-- Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
| Bug | low | Minor |
446,878,589 | godot | Shader editor doesn't save its state | **Godot version:**
e2375f4
**Issue description:**
The shader editor, unlike the script editor, doesn't save its state when closed (breakpoints, bookmarks, etc). | bug,topic:editor,confirmed | low | Minor |
446,894,608 | vscode | TextEditorDecoration applied to incorrect range if racing with user edits | Version: 1.33.1 (user setup)
Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8
Date: 2019-04-11T08:27:14.102Z
Electron: 3.1.6
Chrome: 66.0.3359.181
Node.js: 10.2.0
V8: 6.6.346.32
OS: Windows_NT x64 10.0.18362
The wrong text gets decorated if the user is typing when the decoration is applied.
Steps to Reproduce:
1. Add the following to a didChangeTextDocument handler in an extension:
```
let decoration: vscode.TextEditorDecorationType = vscode.window.createTextEditorDecorationType({
color: "#FF00FF"
});
let txt1: string = textDocumentChangeEvent.document.getText();
let editors: vscode.TextEditor[] = vscode.window.visibleTextEditors.filter(e => e.document.uri === textDocumentChangeEvent.document.uri);
for (let e of editors) {
e.setDecorations(decoration, [new vscode.Range(1, 1, 1,10)]);
}
let txt2: string = textDocumentChangeEvent.document.getText();
```
2. Prepare a file with some text i.e.:
```
XXXXXXXXXXXX
XXXXXXXXXXXX
```
3. Put a breakpoint immediately after the first call to getText().
4. When you hit that breakpoint, inspect txt1. You will see the contents of the file.
5. While remaining at the breakpoint, paste a couple lines to the start of the file. For example, to make the file look like so:
```
YYYYYYYYYYYY
YYYYYYYYYYYY
XXXXXXXXXXXX
XXXXXXXXXXXX
```
6. Step past the second call to getText(). You will see it retains the original content. This is good (better then changing the state of the document out from under us, before delivering didChangeTextDocument with the new edits). The intention here is to set a decoration within the second line of X's, and the apparent state of the document seems to imply this is what to expect.
7. Continue, allowing the didChangeTextDocument handler to return.
Seeing: The decoration is applied to the wrong text.
<img width="167" alt="Capture" src="https://user-images.githubusercontent.com/49173979/58141199-64376000-7bf7-11e9-8c60-3e0a5d519dce.PNG">
Expected: The decoration range(s) should get adjusted based on the pending edits. | feature-request,editor-core,semantic-tokens | medium | Major |
446,908,184 | flutter | flutter_tools test/commands.shard/permeable/create_test.dart takes over 6 minutes | We really need to make this test more efficient somehow. Is it doing something redundant? Something we can cache? (But without making it less hermetic.) | a: tests,tool,P2,team-tool,triaged-tool | low | Minor |
446,912,209 | vscode | Screen Flickering when connected to external display on macOS | Issue Type: <b>Bug</b>
I have my MBP (docked, laptop lid closed) connected to an external 4K display, and the screen flickering is getting pretty obnoxious. Happens routinely when switching tabs. I tried disabling all extensions and running with `code --disable-gpu` and `--ignore-gpu-blacklist` which didn't solve it in my testing. Any ideas on other workarounds?
Ideally I'd want this fixed, and not need to open it from the command line every time.
VS Code version: Code 1.34.0 (a622c65b2c713c890fcf4fbf07cf34049d5fe758, 2019-05-15T21:59:22.738Z)
OS version: Darwin x64 18.6.0
<details>
<summary>System Info</summary>
|Item|Value|
|---|---|
|CPUs|Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)|
|GPU Status|2d_canvas: enabled<br>checker_imaging: disabled_off<br>flash_3d: enabled<br>flash_stage3d: enabled<br>flash_stage3d_baseline: enabled<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>native_gpu_memory_buffers: enabled<br>rasterization: enabled<br>surface_synchronization: enabled_on<br>video_decode: enabled<br>webgl: enabled<br>webgl2: enabled|
|Load (avg)|3, 2, 2|
|Memory (System)|16.00GB (0.25GB free)|
|Process Argv||
|Screen Reader|no|
|VM|0%|
</details><details><summary>Extensions (105)</summary>
Extension|Author (truncated)|Version
---|---|---
better-comments|aar|2.0.5
html-snippets|abu|0.2.1
scss-lint|ada|0.1.8
vscode-caniuse|aga|0.5.0
vscode-javascript-snippet-pack|aka|0.1.5
project-manager|ale|10.5.1
spellright|ban|3.0.38
color-info|bie|0.5.1
markdown-checkbox|bie|0.1.3
markdown-emoji|bie|0.0.9
markdown-preview-github-styles|bie|0.1.6
markdown-yaml-preamble|bie|0.0.4
htmltagwrap|bra|0.0.7
better-toml|bun|0.3.2
markdown-jira|chi|1.1.0
npm-intellisense|chr|1.3.0
path-intellisense|chr|1.4.2
regex|chr|0.2.0
open-html-in-browser|cod|0.1.21
gitignore|cod|0.6.0
bracket-pair-colorizer-2|Coe|0.0.28
compulim-vscode-closetag|Com|1.2.0
vscode-svgviewer|css|2.0.0
scala|dal|0.0.5
vue-peek|dar|1.0.2
vscode-markdownlint|Dav|0.26.0
vscode-eslint|dba|1.9.0
vscode-dash|dee|2.1.0
xml|Dot|2.4.0
gitlens|eam|9.7.4
vscode-html-css|ecm|0.2.0
EditorConfig|Edi|0.13.0
vscode-npm-script|eg2|0.3.7
LogFileHighlighter|emi|2.5.0
vscode-great-icons|emm|2.1.47
json-tools|eri|1.0.2
prettier-vscode|esb|1.9.0
vscode-todo-plus|fab|4.13.0
vimL|fal|0.0.3
markdown-table-formatter|fcr|1.4.3
git-project-manager|fel|1.7.1
file-icons|fil|1.0.17
auto-close-tag|for|0.5.6
auto-rename-tag|for|0.0.15
code-runner|for|0.9.9
shell-format|fox|4.0.11
vscode-javac|geo|0.2.19
nightswitch|gha|1.1.0
beautify|Hoo|1.5.0
output-colorizer|IBM|0.1.2
applescript|idl|0.14.2
golang-tdd|joa|0.0.9
intellij-idea-keybindings|k--|0.2.32
swift|Kas|0.0.3
vscode-gutter-preview|kis|0.19.0
vscode-fix-checksums|leh|1.1.0
expand-region|let|0.1.2
scratchpad|mac|0.0.3
MagicPython|mag|1.1.0
terraform|mau|1.3.11
rainbow-csv|mec|1.0.0
HTMLHint|mka|0.6.0
python|ms-|2019.4.12954
cpptools|ms-|0.23.1
csharp|ms-|1.19.1
Go|ms-|0.10.2
debugger-for-chrome|msj|4.11.3
vuejs-extension-pack|mub|1.1.3
vetur|oct|0.21.0
advanced-new-file|pat|1.2.0
vscode-css-peek|pra|2.2.0
itunes-vscode|Psy|0.9.1
seti-icons|qin|0.1.3
java|red|0.45.0
vscode-yaml|red|0.4.0
vscode-sort-json|ric|1.13.0
bash-debug|rog|0.3.5
rust|rus|0.6.1
partial-diff|ryu|1.4.0
crates|ser|0.4.3
code-settings-sync|Sha|3.2.9
markdown-preview-enhanced|shd|0.3.13
vscode-fileutils|sle|2.13.7
guides|spy|0.9.3
autoimport|ste|1.5.3
rewrap|stk|1.9.1
ayu|tea|0.18.0
vscode-status-bar-format-toggle|tom|1.5.0
terminal-tabs|Tyr|0.2.0
vscode-lldb|vad|1.2.3
vscodeintellicode|Vis|1.1.6
vscode-swift-development-environment|vkn|2.7.1
vscode-java-debug|vsc|0.18.0
vscode-java-dependency|vsc|0.4.0
vscode-java-pack|vsc|0.7.1
vscode-java-test|vsc|0.16.0
vscode-maven|vsc|0.17.0
vscode-icons|vsc|8.6.0
vscode-todo-highlight|way|1.0.4
vscode-import-cost|wix|2.12.0
change-case|wma|1.0.0
vscode-jumpy|wma|0.3.1
JavaScriptSnippets|xab|1.7.2
markdown-all-in-one|yzh|2.3.1
propertylist|zho|0.0.2
(7 theme extensions excluded)
</details>
<!-- generated by issue reporter --> | bug,upstream,macos,chromium,confirmation-pending,multi-monitor | high | Critical |
446,937,640 | TypeScript | Missing controlsList property in HTMLMediaElement | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.0-dev.201xxxxx
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
controlsList HTMLMediaElement
**Code**
```ts
const video = $htmlVideoElement as HTMLVideoElement
video.controlsList.value = "nodownload";
```
**Expected behavior:**
Works so we can do things as shown https://googlechrome.github.io/samples/media/controlslist.html and as documented by https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/controlsList
**Actual behavior:**
controlsList is not valid for HTMLVideoElement
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://www.typescriptlang.org/play/#src=interface%20HTMLMediaElement%20%7B%0D%0A%20%20%20%20readonly%20controlsList%3A%20DOMTokenList%20%0D%0A%7D%0D%0A%0D%0Aclass%20Greeter%20%7B%0D%0A%20%20%20%20greeting%3A%20string%3B%0D%0A%20%20%20%20constructor(message%3A%20string)%20%7B%0D%0A%20%20%20%20%20%20%20%20this.greeting%20%3D%20message%3B%0D%0A%20%20%20%20%7D%0D%0A%20%20%20%20greet()%20%7B%0D%0A%20%20%20%20%20%20%20%20return%20%22Hello%2C%20%22%20%2B%20this.greeting%3B%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A%0D%0Alet%20greeter%20%3D%20new%20Greeter(%22world%22)%3B%0D%0A%0D%0Alet%20video%20%3D%20document.createElement('video')%20as%20HTMLVideoElement%3B%0D%0A%0D%0Avideo.controlsList.value%20%3D%20%22nodownload%22%0D%0A%0D%0Adocument.body.appendChild(video)%3B
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
https://github.com/DefinitelyTyped/DefinitelyTyped/issues/19500
Workaround is to add and let the declarations get merged.
```ts
declare global {
interface HTMLMediaElement {
readonly controlsList: DOMTokenList
}
}
```
Or add an ambient type file
```typescript
interface HTMLMediaElement {
readonly controlsList: DOMTokenList;
}
interface DOMTokenList {
/**
* Returns the associated set as string.
* Can be set, to change the associated attribute.
*/
value: string;
}
``` | Needs Investigation | low | Critical |
446,988,788 | go | os: Remove and RemoveAll can't remove the current directory on AIX | On AIX, unlinkat or rmdir syscall doesn't work on the CWD. Therefore, a program like the following one doesn't remove GOPATH.
```
$ cat removeall.go
package main
import (
"io/ioutil"
"log"
"os"
)
func main() {
GOPATH, err := ioutil.TempDir("", "TestRemoveAll")
if err != nil {
log.Panic(err)
}
if err := os.Chdir(GOPATH); err != nil {
log.Panic(err)
}
if err := os.Remove(GOPATH); err != nil {
log.Panic(err)
}
}
$ ./removeall.go
2019/05/22 09:29:19 remove /tmp/TestRemoveAll186232865: device busy
panic: remove /tmp/TestRemoveAll186232865: device busy
goroutine 1 [running]:
log.Panic(0xa00010000088f58, 0x1, 0x1)
/opt/freeware/src/packages/BUILD/go-root/src/log/log.go:338 +0x9c
main.main()
/opt/freeware/src/packages/BUILD/go-root/own_test/goprogs/removeall.go:19 +0x138
exit status 2
```
There is no real documentation on that. However, rmdir seems to return EBUSY and unlinkat EPERM. So, we should be able to detect if os.Remove is failing because of that. However, what's the correct behavior if we want to fix that ?
Do we chdir to the parentdir ? "/tmp" ? the executable folder ? anything else ?
Or do we want to keep this behavior ?
Note that, when calling os.Removeall, everything except the directory itself is still being removed. Therefore, only a empty directory remains. But, as most of the tests are doing a `defer os.Removeall`, /tmp is filled with empty directories...
Do some other OSes have the same problem ?
Edit: POSIX rmdir doesn't specify which behavior must be done (cf https://pubs.opengroup.org/onlinepubs/9699919799/functions/rmdir.html)
> If the directory is the root directory or the current working directory of any process, it is unspecified whether the function succeeds, or whether it shall fail and set errno to [EBUSY]. | NeedsInvestigation,OS-AIX | low | Major |
447,074,561 | pytorch | LibTorch :About torch.jit.trace generate model.pt | ## 🐛 Bug
I use libtorch inference faceboxes,when I test generated model ,I have a problem.
1.torch.save(net1.state_dict(), \'net_params.pth\')
2.torch.save(net1, \'net.pth\')
The first way save the model,libtorch inference the model ,it make Incorrect result,the second way can make correct result. why?
- PyTorch Version (e.g., 1.0):1.1.0
- OS (e.g., Linux):ubuntu 16.04
- How you installed PyTorch (`conda`, `pip`, source):pip
- Build command you used (if compiling from source):no
- Python version:python3.5
- CUDA/cuDNN version:9.0/9.2
- GPU models and configuration:gtx 930mx
- Any other relevant information:
| needs reproduction,oncall: jit,triaged | low | Critical |
447,121,995 | TypeScript | Move TextEncoder out of lib.dom.d.ts. | ## Search Terms
TextEncoder
## Suggestion
Put `(window|global).TextEncoder` in a library that is automatically available to both browser and nodejs.
## Use Cases
`TextEncoder` now exists on `window` in all major browsers as well as on `global` in NodeJS (as of NodeJS 11). At the moment, the `TextEncoder` definition lives in `lib.dom.d.ts` which means it isn't available when working on a project/library that is targeting both NodeJS and Browser.
I don't mind submitting a PR, but I don't know where the appropriate location for such a change is, and how to reconcile it properly with removal from `lib.dom.d.ts`. It isn't part of an annual ES specification, but it should go somewhere that is automatically included in both browser and node now that it is implemented by both. The specification for it can be found at https://encoding.spec.whatwg.org/ and I believe that is what has been implemented in NodeJS.
## Checklist
My suggestion meets these guidelines:
* [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
* [x] This wouldn't change the runtime behavior of existing JavaScript code
* [x] This could be implemented without emitting different JS based on the types of the expressions
* [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.)
* [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals). | Suggestion,Awaiting More Feedback | low | Major |
447,155,519 | node | [Documentation Suggestion] How To Contribute To Unit Tests | **Description**
I'm new to the Node project and I want to help contribute, and I've seen suggestions that a great way to contribute is to look at the [code coverage report](https://coverage.nodejs.org/), find something that doesn't have full coverage, and write/add to tests to help the coverage be more complete.
However, the actual steps to do that are a bit vague (the code coverage website is a bit hard to understand), and this process isn't documented in this project. (I actually heard about doing this in [this medium article](https://medium.com/the-node-js-collection/interested-in-contributing-to-node-js-core-read-on-5614f60d074d).)
**Solution**
Can we add a section in one of the contributing documents (I guess either on the website or maybe a new doc (that gets referenced in [CONTRIBUTING.md](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md)) to list out the steps of how to either use the code coverage tool to find code that's untested, and how to help add tests (or add to current tests) to contribute?
I'm not sure if we should treat this in two parts (one part being documentation on how to use the code coverage tool, and another on how to use contribute by using it to find untested code), or to make just one document. | help wanted,doc | low | Major |
447,185,273 | svelte | Run transitions on initial rendering on a per-transition basis | I know that by default transitions do not run on the initial rendering (which is nice!) and that I can turn them on globally by setting `intro: true` when [rendering the app](https://svelte.dev/docs#Client-side_component_API).
Sometimes I can be handy to have an initial transition to create emphasize, so I am wondering if there's a way to selectively turn on initial transitions on a per-transition basis.
I am thinking about something like this:
```html
{#if visible}
<div transition:fly={{ y: -20, init: true }}>hi there!</div>
{/if}
```
This is not a pressing issue as it's easy to work around the approach but it'd be nice to not have to add fake state to achieve this. Right now I am doing the following or is that not necessary?
[See it live](https://svelte.dev/repl/5290dd52afcc428ab8cc2f48ed9843dc?version=3.4.2)
```html
<!-- App.svelte -->
<script>
import Test from './Test.svelte';
let visible = true;
</script>
<label><input type='checkbox' bind:checked={visible}> visible</label>
<Test {visible}/>
<!-- Test.svelte -->
<script>
import { onMount } from 'svelte';
import { fly } from 'svelte/transition';
export let visible = false;
let init = false;
onMount(() => {
init = true;
});
</script>
{#if init && visible}
<div transition:fly={{ y: -20 }}>hi there!</div>
{/if}
``` | feature request,awaiting submitter | medium | Major |
447,192,968 | neovim | Cannot set iminsert=2 in windows version | <!-- Before reporting: search existing issues and check the FAQ. -->
- `nvim --version`:
```
NVIM v0.3.5
Build type: RelWithDebInfo
LuaJIT 2.0.5
Compilation: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x64/cl.exe /DWIN32 /D_WINDOWS /W3 /MD /Zi /O2 /Ob1 /DNDEBUG -DMIN_LOG_LEVEL=3 /W3 -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DWIN32 -D_WIN32_WINNT=0x0600 -DINCLUDE_GENERATED_DECLARATIONS -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -IC:/projects/neovim/build/config -IC:/projects/neovim/src -IC:/projects/neovim/.deps/usr/include -IC:/projects/neovim/build/src/nvim/auto -IC:/projects/neovim/build/include
Compiled by appveyor@APPVYR-WIN
Features: -acl +iconv -jemalloc +tui
```
- Vim 8.1 behaves differently?
Yes, I can set iminsert=2 in vim
- Operating system/version:
Windows 10 Home Basic 1809
- Terminal name/version:
nvim-qt.exe
- `$TERM`:
null
### Steps to reproduce using `nvim -u NORC`
```
nvim -u NORC
:set iminsert=2
```
### Actual behaviour
```
E474: Invalid argument: iminsert=2
```
### Expected behaviour
After setting iminsert=2, my chinese input method will be turned on in insert mode, and be turned off in normal mode.
I have searched in document, and found the following lines:
```
'iminsert' 'imi' number (default 0, 2 when an input method is supported)
local to buffer
Specifies whether :lmap or an Input Method (IM) is to be used in
Insert mode. Valid values:
0 :lmap is off and IM is off
1 :lmap is ON and IM is off
2 :lmap is off and IM is ON
2 is available only when compiled with the +multi_byte_ime, +xim
or global-ime.
```
The return code of `has("multi_byte_ime")` is 0, and I think it should be the reason.
But I don't know how can I compile a version with `multi_byte_ime` support. In the document of `:help version`, it says I should edit the `feature.h`, but I cannot find the `feature.h` file or any code about `multi_byte_ime` in the source code.
Or maybe there is another way to archieve the behaviour I expect? | enhancement,api,has:plan,ui-extensibility | low | Critical |
447,204,834 | terminal | Add support for multi-param OSC sequences | @vapier wrote:
> i don't think this correctly handles chaining to following OSC sequences.
That's correct. It doesn't handle chaining at all. It also doesn't handle color names.
Since this was my first PR, I was trying not to rewrite, but to just add a little on top of what was there and learn how things work -- I even reused the color parser that was written for OSC 4, though it won't support color names, meaning you can only set RGB values, and not just reuse colors from your base 16 for foreground and background.
The structure of the OSC handler in the State Machine seems designed on the assumption that they are single-valued (meaning one value per escape sequence), which makes chaining basically impossible.
Basically, still to do:
* [x] Rewrite the `ActionOscDispatch` to support chains of values
* [x] Make OSC 4 support setting the whole color palette at once (This was done in #7578)
* [x] Make OSC 10, 11, 12 support setting all of them at once
* [ ] Add support for lookups ("?") to output the current value #3718
* [ ] Add support for resetting colors (OSC 104..119) #3719
* [x] Rewrite the color parser to include ~~x11 color names~~ more formats #3715
* [x] Support setting colors above index 16 #3717 (maybe #313?)
Those things are definitely needed, but didn't seem necessary for a first pass.
Somewhere along the way someone will need to decide if we're going to do _special colors_ for bold/italic/underline/blink/reverse ... and which window properties should be settable by OSC 3 😉 @oising?
_Originally posted by @Jaykul in https://github.com/microsoft/terminal/pull/891#issuecomment-494667974_ | Issue-Feature,Product-Conhost,Help Wanted,Area-VT | low | Major |
447,222,572 | angular | forms: update required validator when input is autofilled | <!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅
Oh hi there! 😄
To expedite issue processing please search open and closed issues before submitting a new one.
Existing issues often contain information about workarounds, resolution, or progress updates.
🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->
# 🚀 feature request
### Relevant Package
<!-- Can you pin-point one or more @angular/* packages the are relevant for this feature request? -->
<!-- ✍️edit: --> This feature request is for @angular/forms
### Description
The `RequiredValidator` does not update its validation status when an input is autofilled in Chrome. This is problematic for users who set up a required username and password input and then conditionally enable the submit button when the inputs are valid. The user sees:
1. Page loads
2. Inputs are autofilled with username and password
3. Submit button is still disabled.
This issue has been filed in the past on the components repo: https://github.com/angular/components/issues/3414, though the change would really have to happen in @angular/forms.
### Describe the solution you'd like
@angular/cdk has an `AutofillMonitor` that could be moved to @angular/forms and used to detect when an input is autofilled.
### Describe alternatives you've considered
It is possible to monkey patch a solution, as @kherock [demonstrated](https://stackblitz.com/edit/autofillmon-validate?file=app/autofillvalueaccessor.directive.ts) on the components issue.
| type: bug/fix,area: forms,forms: validators,forms: change detection,P5,feature: under consideration | high | Critical |
447,227,120 | PowerToys | swipe keyboard functionality and configurable on screen keyboard layout | This is a feature request :
- need full smaller keyboards on both left & right sides of the display with swipe typing(single finger typing where words automatically recognized and typed according to finger movement and with suggestions just above like android gboard ) with the thumb should be great for typing fast.Also an ability to place as many small keyboards on the screen as you want(like the the tablet mode small keyboards)
- And also To be able configure the layout of the on screen keyboard . Like create custom keys and remove unwanted keys in tablet mode keyboard and also the basic on screen keyboard.
For example - for people who use a lot of shortcuts in some particualr apps and do have a touch screen display then while using as a tablet can convert combination of keys to a single key (with custom name ) .And use those custom keys in a custom layout to ease there on screen typing.
- to be able to add different keyboard layouts on github or share opensource with everyone.
- To be able to set the opacity of the tablet mode keyboard and normal on screen keyboard(Dont know if its currently possible) .
And also to be able to have the tablet mode keyboard available in normal mode(Dont know if this is possible today).
Thanks
P.S. Dont know if any of the above is possible today somehow. If it is please tell how. | Idea-New PowerToy | low | Minor |
447,249,972 | godot | Fix Subtract and Multiply modes on CanvasItemMaterial to also work on alpha | <!-- Please search existing issues for potential duplicates before filing yours:
https://github.com/godotengine/godot/issues?q=is%3Aissue
-->
**Godot version:** 3.1.1
<!-- Specify commit hash if non-official. -->
**OS/device including version:** Solus Gnome NVIDIA GTX 1050 TI
<!-- Specify GPU model and drivers if graphics-related. -->
**Issue description:**
<!-- What happened, and what was expected. -->
Currently the Subtract and the Multiply modes of the CanvasItemMaterial doesn't operate on the alphas of the CanvasItems below it, so we cannot perform simple boolean operations.
Ideally it should take the alpha of the canvas item below it and multiply by its own, clipping them.
**Steps to reproduce:**
1. Create 2 CanvasItems (Preferably a Line2D so you can have graphics to overlap)
1. Add a CanvasMaterial to one of them
1. Set the CanvasMaterial blend mode to `Mul`
1. Set the Modulate or SelfModulate alpha to 0
1. Intersect both CanvasItems
**Minimal reproduction project:**
<!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
| enhancement,topic:rendering,confirmed,topic:2d | low | Critical |
447,259,571 | flutter | [Feature Request] Provide a way to change global touch ripple size (padding)? | Hi, the current touch ripple size (or padding size?) looks too big to me. I hope there is a way to reduce/change touch ripple size. (so that I will have a smaller touch ripple and smaller sized widgets for those which have touch ripple effects)
Thank you very much. | c: new feature,framework,f: material design,P3,team-design,triaged-design | low | Minor |
447,291,624 | go | cmd/gofmt: align renamed imports | Currently, my import block looks something like:
```go
import (
"bytes"
"math"
"reflect"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"google.golang.org/protobuf/internal/encoding/pack"
pimpl "google.golang.org/protobuf/internal/impl"
"google.golang.org/protobuf/internal/pragma"
ptype "google.golang.org/protobuf/internal/prototype"
"google.golang.org/protobuf/internal/scalar"
pref "google.golang.org/protobuf/reflect/protoreflect"
preg "google.golang.org/protobuf/reflect/protoregistry"
piface "google.golang.org/protobuf/runtime/protoiface"
proto2_20180125 "google.golang.org/protobuf/internal/testprotos/legacy/proto2.v1.0.0-20180125-92554152"
)
```
Most of the import paths have a shared prefix, but the lack of aligning makes this hard to see. Preferably, `gofmt` would align the imports like:
```go
import (
"bytes"
"math"
"reflect"
"testing"
"github.com/google/go-cmp/cmp"
"github.com/google/go-cmp/cmp/cmpopts"
"google.golang.org/protobuf/internal/encoding/pack"
pimpl "google.golang.org/protobuf/internal/impl"
"google.golang.org/protobuf/internal/pragma"
ptype "google.golang.org/protobuf/internal/prototype"
"google.golang.org/protobuf/internal/scalar"
pref "google.golang.org/protobuf/reflect/protoreflect"
preg "google.golang.org/protobuf/reflect/protoregistry"
piface "google.golang.org/protobuf/runtime/protoiface"
proto2_20180125 "google.golang.org/protobuf/internal/testprotos/legacy/proto2.v1.0.0-20180125-92554152"
)
``` | NeedsDecision | low | Major |
447,307,653 | pytorch | [Proposal] Data reading framework for PyTorch (Hive, MySQL, S3 etc.) | At Facebook we are building a data reading framework for PyTorch which can efficiently read from data stores like Hive, MySQL, our internal blob store and any other tabular data sources. The framework allows for specifying complex input pipelines to read from different sources. For example if you have a table which stores handles for images, you can write SQL like code to read from the table, apply filters to select certain handles and then retrieve those handles from another data source with a few lines of code.
In addition to this, the framework supports running user-defined transforms which can either be pure python (ex: [torchvision.transforms](https://pytorch.org/docs/stable/torchvision/transforms.html)) or torchscript code. This framework can also be used with the [torch.distributed](https://pytorch.org/docs/stable/distributed.html) package to distribute the data across multiple nodes for training. The input pipeline that the user specifies can be defined once, serialized as a plan and run on multiple remote machines if required.
The framework builds upon the OSS dataloader and dataset framework. In particular it uses [IterableDataset](https://github.com/pytorch/pytorch/pull/19228) to provide a stream based interface for data retrieved from input pipelines.
Sample code to illustrate what reading and pre-processing images would look like:
```
# Hive table has columns handle and partition_no. The partition column
# for the table is partition_no
df = data.data_warehouse("mynamespace", "mytable")
# Filter to partition the data across multiple workers.
partition_filter = "hash(partition_no) % {0} = {1}".format(worker_info.num_workers, worker_id)
df = df.filter(partition_filter)
# Fetch the handle from a blobstore
df = df.map(["fetch_handle(handle) as img"])
# Rebatch the data
df = df.rebatch(batch_size=16)
# transform_image is a user supplied function to run image transforms.
ds = MyDataset(df=df, transforms=transform_image)
dl = torch.utils.data.DataLoader(ds)
for batch in dl:
pass
```
We are evaluating whether it makes sense to open source this framework. For OSS users, this framework might be useful for training jobs which store large amount of data in Hive or S3 (images). Although, we would love to hear from the community whether this would be useful and also some use cases that might benefit from a framework like this.
@dzhulgakov @jspisak @aartibasant @apaszke @SsnL | feature,module: dataloader,triaged,needs research | high | Critical |
447,359,817 | flutter | Add mouse button support to GLFW shell | The embedding API now has the ability to pass mouse buttons through, enabling right click, middle click, etc. It's been wired up in the macOS shell, but still needs to be done for the GLFW shell. | engine,a: desktop,e: glfw,P3,team-linux,triaged-linux | low | Major |
447,362,542 | terminal | [Settings UI] Add a button to reset the settings to defaults | # Summary of the new feature/enhancement
Sometimes, I update between builds and see breaking changes on the configuration side. I know that this is normal on Alpha software but there should be a way to remove the configuration without having to delete profiles.json manually.
This can also be helpful for end users once the Terminal is released.
# Proposed technical implementation details (optional)
This can work like the normal Shift + Right Click on the Windows Explorer: A Shift + Left Click on the selector should show more options like the already mentioned Delete/Reset Configuration.
| Issue-Feature,Product-Terminal,Area-SettingsUI | medium | Major |
447,377,838 | flutter | Flutter tools support for packaging/linking to native libraries | **update 2022-12-05**
There are currently two options for shipping native libraries as Flutter plugins:
1. Ship sources a flutter plugins with flutter create --template=plugin_ffi --platform=..., or
2. Ship a script that downloads the native library during flutter build [see realm_flutter](https://github.com/realm/realm-dart/blob/81c8b913b5c9d639fd5d4f09b069eb4fc87de706/flutter/realm_flutter/android/build.gradle#L85), or
There is currently not a good way to make Dart (non-Flutter-plugins) with native libararies work for Flutter _and_ Dart. This work is being tracked in:
* https://github.com/dart-lang/sdk/issues/50565
For more documentation:
* https://dart.dev/guides/libraries/c-interop
* https://docs.flutter.dev/development/platform-integration/android/c-interop
* https://docs.flutter.dev/development/platform-integration/ios/c-interop
**old post**
We want to enable Flutter apps and plugins to bind to native (C/C++) libraries directly via the Dart FFI. This requires support from Flutter tools. There are four categories of use cases we'd like to enable:
0. A Flutter plugin wants to interact with a native library which should be available on the target device (e.g. Android Audio).
1. A Flutter app wants to ship business logic written in C/C++ (e.g. some add-to-app scenarios).
2. A Flutter plugin wants to ship a prebuilt native library (.so on Android or .framework on iOS) within its package (e.g. closed-source or vendored plugins like Realm).
3. A Flutter plugin wants to ship source code within its package which should be compiled by the client developer.
We should also keep in mind support for desktop, server and non-Flutter use cases (which also broadly fall into the above categories). | c: new feature,tool,P3,team-tool,triaged-tool | high | Critical |
447,406,330 | rust | Failed to build rpm-ostree on ppc64le: multiple definition of `__fixdfdi' | ref: https://bugzilla.redhat.com/show_bug.cgi?id=1713090
Trying to build [rpm-ostree](https://github.com/projectatomic/rpm-ostree) on Fedora ppc64le now gives:
```
libtool: link: gcc -shared -fPIC -DPIC src/lib/.libs/librpmostree_1_la-rpmostree.o src/lib/.libs/librpmostree_1_la-rpmostree-db.o src/lib/.libs/librpmostree_1_la-rpmostree-package.o -Wl,--whole-archive ./.libs/librpmostreepriv.a -Wl,--no-whole-archive -L/builddir/build/BUILD/rpm-ostree-2019.4/libdnf-build/libdnf -ldnf -ljson-glib-1.0 -lostree-1 -lsystemd -lpolkit-gobject-1 -lrpm -lrpmio -lrepo -lsolv -larchive -lgio-2.0 -lgobject-2.0 -lglib-2.0 -lcap /builddir/build/BUILD/rpm-ostree-2019.4/target/release/librpmostree_rust.a -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -pthread -O2 -g -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mcpu=power8 -mtune=power8 -Wl,-rpath=/usr/lib64/rpm-ostree -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,--push-state -Wl,--no-as-needed -Wl,-ldl -Wl,-lm -Wl,--pop-state -pthread -Wl,-soname -Wl,librpmostree-1.so.1 -o .libs/librpmostree-1.so.1.0.0
BUILDSTDERR: /usr/bin/ld: /usr/lib/gcc/ppc64le-redhat-linux/9/libgcc.a(ppc64-fp.o): in function `__fixdfdi':
BUILDSTDERR: (.text+0x510): multiple definition of `__fixdfdi'; /builddir/build/BUILD/rpm-ostree-2019.4/target/release/librpmostree_rust.a(compiler_builtins-cae9ea46cd4dabd1.compiler_builtins.qr7h34vq-cgu.0.rcgu.o):(.text.__fixdfdi+0x0): first defined here
BUILDSTDERR: /usr/bin/ld: /usr/lib/gcc/ppc64le-redhat-linux/9/libgcc.a(ppc64-fp.o): in function `__fixsfdi':
BUILDSTDERR: (.text+0x5c0): multiple definition of `__fixsfdi'; /builddir/build/BUILD/rpm-ostree-2019.4/target/release/librpmostree_rust.a(compiler_builtins-cae9ea46cd4dabd1.compiler_builtins.qr7h34vq-cgu.0.rcgu.o):(.text.__fixsfdi+0x0): first defined here
BUILDSTDERR: /usr/bin/ld: /usr/lib/gcc/ppc64le-redhat-linux/9/libgcc.a(ppc64-fp.o): in function `__fixunsdfsi':
BUILDSTDERR: (.text+0x680): multiple definition of `__fixunsdfsi'; /builddir/build/BUILD/rpm-ostree-2019.4/target/release/librpmostree_rust.a(compiler_builtins-cae9ea46cd4dabd1.compiler_builtins.qr7h34vq-cgu.0.rcgu.o):(.text.__fixunsdfsi+0x0): first defined here
BUILDSTDERR: /usr/bin/ld: /usr/lib/gcc/ppc64le-redhat-linux/9/libgcc.a(ppc64-fp.o): in function `__fixunssfsi':
BUILDSTDERR: (.text+0x6e0): multiple definition of `__fixunssfsi'; /builddir/build/BUILD/rpm-ostree-2019.4/target/release/librpmostree_rust.a(compiler_builtins-cae9ea46cd4dabd1.compiler_builtins.qr7h34vq-cgu.0.rcgu.o):(.text.__fixunssfsi+0x0): first defined here
BUILDSTDERR: /usr/bin/ld: /usr/lib/gcc/ppc64le-redhat-linux/9/libgcc.a(ppc64-fp.o): in function `__floatdidf':
BUILDSTDERR: (.text+0x800): multiple definition of `__floatdidf'; /builddir/build/BUILD/rpm-ostree-2019.4/target/release/librpmostree_rust.a(compiler_builtins-cae9ea46cd4dabd1.compiler_builtins.qr7h34vq-cgu.0.rcgu.o):(.text.__floatdidf+0x0): first defined here
BUILDSTDERR: /usr/bin/ld: /usr/lib/gcc/ppc64le-redhat-linux/9/libgcc.a(ppc64-fp.o): in function `__floatundidf':
BUILDSTDERR: (.text+0x840): multiple definition of `__floatundidf'; /builddir/build/BUILD/rpm-ostree-2019.4/target/release/librpmostree_rust.a(compiler_builtins-cae9ea46cd4dabd1.compiler_builtins.qr7h34vq-cgu.0.rcgu.o):(.text.__floatundidf+0x0): first defined here
BUILDSTDERR: /usr/bin/ld: /usr/lib/gcc/ppc64le-redhat-linux/9/libgcc.a(ppc64-fp.o): in function `__floatdisf':
BUILDSTDERR: (.text+0x880): multiple definition of `__floatdisf'; /builddir/build/BUILD/rpm-ostree-2019.4/target/release/librpmostree_rust.a(compiler_builtins-cae9ea46cd4dabd1.compiler_builtins.qr7h34vq-cgu.0.rcgu.o):(.text.__floatdisf+0x0): first defined here
BUILDSTDERR: /usr/bin/ld: /usr/lib/gcc/ppc64le-redhat-linux/9/libgcc.a(ppc64-fp.o): in function `__floatundisf':
BUILDSTDERR: (.text+0x900): multiple definition of `__floatundisf'; /builddir/build/BUILD/rpm-ostree-2019.4/target/release/librpmostree_rust.a(compiler_builtins-cae9ea46cd4dabd1.compiler_builtins.qr7h34vq-cgu.0.rcgu.o):(.text.__floatundisf+0x0): first defined here
BUILDSTDERR: collect2: error: ld returned 1 exit status
```
We reproduced this with Fedora 29 (with LLVM 7) as well as Fedora 30 and 31 (LLVM 8). It fails consistently with 1.34.2, but strangely it succeeds with 1.34.1. There were no packaging changes between those, apart from the version update for the CVE fix.
I also reproduced this with official Rust builds, from `1.36.0-nightly (37ff5d388 2019-05-22)` all the way back to `1.32.0`. However, it builds fine with `1.31.1`!
(For releases before `1.35`, lacking #58986, I used Fedora's cargo to avoid that `SIGILL`.)
I find it especially strange that the regression point is inconsistent... | T-libs-api,O-PowerPC,C-bug,A-intrinsics | low | Critical |
447,412,171 | rust | On type mismatch involving fn call, point at fn definition | [Given](https://play.rust-lang.org/?version=nightly&mode=debug&edition=2018&gist=27a5f6a2fb95cd907f8e5511736c82bf)
```
fn foo() -> u32 {
1
}
fn bar() {
let x: usize = foo();
}
```
we now present:
```
error[E0308]: mismatched types
--> src/lib.rs:6:20
|
6 | let x: usize = foo();
| ^^^^^ expected usize, found u32
help: you can convert an `u32` to `usize` and panic if the converted value wouldn't fit
|
6 | let x: usize = foo().try_into().unwrap();
| ^^^^^^^^^^^^^^^^^^^^^^^^^
```
We should ideally also point at `foo` and maybe tell the user to consider changing it. | C-enhancement,A-diagnostics,T-compiler,A-suggestion-diagnostics | low | Critical |
447,430,238 | flutter | Gesture detectors are unable to capture small, detailed gestures. | My app uses a GestureDetector's onPanStart, onPanUpdate and onPanEnd handlers to allow the user to draw on the screen. This worked great when I first developed the app in late 2018, but after recently updating Flutter and recompiling the app, I found that GestureDetector is much less sensitive to small movements.
By adding an onPanDown handler, I found that onPanDown is being called as soon as the pointer touches the screen, but then a fairly large drag movement is required before onPanStart will be called, and before onPanUpdate will then start being called for every ensuing movement of the pointer.
Because of how large of a movement is required before the gesture is considered a "pan", my app is no longer sensitive to small movements, and so users would not be able to draw small details as they previously could.
After digging into the Flutter code, the only solution I could find was to edit this file:
flutter\packages\flutter\lib\src\gestures\constants.dart
...to change the constant kTouchSlop from 18.0 to a lower number such as 4.0.
This is a messy solution and would need to be redone each time I update the Flutter code. So, I'm wondering if there's a better alternative method to allow GestureDetector (or ImmediateMultiDragGestureRecognizer, for multitouch gestures) to require less movement before it begins registering pans, and so to allow small, detailed gestures to be captured?
If not, I recommend adding the ability to change kTouchSlop on a case by case basis. Alternately, have the GestureDetector start reporting the gesture as soon as the pointer is down (rather than after it has already moved by kTouchSlop amount) if its dragStartBehavior is set to "down" rather than "start". (This is what I expected the behavior would be, but changing the dragStartBehavior to "down" seemed to make no difference.)
-------------------------------------
Flutter doctor -v
[√] Flutter (Channel beta, v1.5.4-hotfix.2, on Microsoft Windows [Version 10.0.17134.765], locale en-US)
• Flutter version 1.5.4-hotfix.2 at D:\src\flutter
• Framework revision 7a4c33425d (3 weeks ago), 2019-04-29 11:05:24 -0700
• Engine revision 52c7a1e849
• Dart version 2.3.0 (build 2.3.0-dev.0.5 a1668566e5)
[√] Android toolchain - develop for Android devices (Android SDK version 28.0.3)
• Android SDK at C:\Users\frogr\AppData\Local\Android\sdk
• Android NDK location not configured (optional; useful for native profiling support)
• Platform android-28, build-tools 28.0.3
• Java binary at: D:\Program Files\Android\Android Studio\jre\bin\java
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
• All Android licenses accepted.
[√] Android Studio (version 3.2)
• Android Studio at D:\Program Files\Android\Android Studio
• Flutter plugin version 30.0.1
• Dart plugin version 181.5656
• Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1136-b06)
[√] Connected device (1 available)
• SAMSUNG SGH I337 • c65ac68a • android-arm • Android 5.0.1 (API 21)
• No issues found! | c: new feature,framework,a: quality,f: gestures,c: proposal,P3,a: gamedev,team-framework,triaged-framework | low | Major |
447,442,062 | TypeScript | Regression: Type T[K] as an array when sliced loses its type | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** 3.4.5
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
array property generics
**Code**
```ts
export function GetArrayProp<U, K extends string, T extends Record<K, U[]>>(
state: T,
prop: K,
) {
//good
let x1: T[K] = state[prop];
//good
let x2: U[] = state[prop];
//good
let x3: U[] = state[prop].slice(0);
//error
let x4: T[K] = state[prop].slice(0);
}
```
While you can argue that U[] isn't necessarily assignable to type T[K]. Look at the following code.
It's hard to see how TypeFromArray<T[K]>[]'s type should be any different than T[K]
```ts
export type TypeFromArray<T> = T extends (infer R)[] ? R : never;
export function GetArrayProp<K extends string, T extends Record<K, Array<TypeFromArray<T[K]>>>>(
obj: T,
prop: K,
) {
//good
let x1: T[K] = obj[prop];
//good
let x2 = obj[prop].slice(0);
//error Type 'TypeFromArray<T[K]>[]' is not assignable to type 'T[K]'.
let x3: T[K] = obj[prop].slice(0);
}
```
**Expected behavior:**
No errors.
T[K] and U[] should be assignable to each other.
state[prop].slice(0) should be of the same type as state[prop]
TypeFromArray<T[K]>[]'s type should be not be any different than T[K]
This code works in version 3.2.4 but stopped working in 3.3.1
**Actual behavior:**
Error Type 'U[]' is not assignable to type 'T[K]'.
Error Type 'TypeFromArray<T[K]>[]' is not assignable to type 'T[K]'
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
[Playground Link](https://www.typescriptlang.org/play/index.html#src=export%20function%20GetArrayProp%3CU%2C%20K%20extends%20string%2C%20T%20extends%20Record%3CK%2C%20U%5B%5D%3E%3E(%0D%0A%20%20obj%3A%20T%2C%0D%0A%20%20prop%3A%20K%2C%0D%0A)%20%7B%0D%0A%20%20%2F%2Fgood%0D%0A%20%20let%20x1%3A%20T%5BK%5D%20%3D%20obj%5Bprop%5D%3B%0D%0A%20%20%2F%2Fgood%0D%0A%20%20let%20x2%3A%20U%5B%5D%20%3D%20obj%5Bprop%5D%3B%0D%0A%20%20%2F%2Fgood%0D%0A%20%20let%20x3%3A%20U%5B%5D%20%3D%20obj%5Bprop%5D.slice(0)%3B%0D%0A%20%20%2F%2Ferror%0D%0A%20%20let%20x4%3A%20T%5BK%5D%20%3D%20obj%5Bprop%5D.slice(0)%3B%0D%0A%7D)
My main goal is to be able to pluck array properties and modify the arrays without losing the type T[K]
The code above is simplified to show how TS is behaving.
See my use case below.
It's hard to see how TypeFromArray<T[K]>[]'s type should be any different than T[K]
The code below used to work when using 3.2.4
```ts
import { EntityState, EntityAdapter } from '@ngrx/entity';
import { Action } from '@ngrx/store';
export type TypeFromArray<T> = T extends (infer R)[] ? R : never;
type Selector<T> = (s: T) => boolean;
function ModifyEntityFromState<T>(entityId: number, state: EntityState<T>, callBack: (acnt: T) => void): T {
const t = state.entities[entityId];
const acnt = JSON.parse(JSON.stringify(t)) as T;
callBack(acnt);
return acnt;
}
export function ModifyPropertyFromState<T, K extends keyof T>(
entityId: number,
state: EntityState<T>,
prop: K,
callBack: (a: T[K]) => T[K],
): T {
return ModifyEntityFromState( entityId, state, (acnt) => {
acnt[prop] = callBack( acnt[prop] );
});
}
export function EditArrayFromState<
T extends Record<K, Array<TypeFromArray<T[K]>>>,
K extends keyof T,
U extends TypeFromArray<T[K]>
>(
entityId: number, state: EntityState<T>, prop: K,
selector: Selector<U>,
modified: U
): T {
return ModifyPropertyFromState( entityId, state, prop, (a) => {
//Argument of type '(a: T[K]) => TypeFromArray<T[K]>[]' is not assignable to parameter of type '(a: T[K]) => T[K]'.
// Type 'TypeFromArray<T[K]>[]' is not assignable to type 'T[K]'
const idx = a.findIndex(selector);
return [
...a.slice(0, idx),
...a.slice(idx + 1),
modified
];
});
}
```
| Bug | low | Critical |
447,520,895 | vue-element-admin | 关于引入冲突或者说引入死循环问题 | ## Question（提问）
我在实际开发中，经常遇到引入冲突问题，经常体验在
1. axios请求方法封装的文件中引入store
2. store中调用api方法
但我观vue-element-admin这个项目，好像也是这样写的，但并没有出现报错问题，这是为什么？
以下是我的代码片段
```
//api/base/index.js
import Axios from 'axios';
import Config from './config';
import { Storage } from '@util';
import { requestSuccess, requestFail, responseSuccess, responseFail } from './interceptors';
import Store from '@store'; //去掉它可以正常运行
//store/model/user.js
import { Storage } from '@util';
import API_USER from '@api/user';
import API_SYS from '@api/sys';
```
//一般它会抛一个Uncaught TypeError的报错，但我保证并没有这样的问题:)
```
Uncaught TypeError: Super expression must either be null or a function, not undefined
```
| not vue-element-admin bug | low | Critical |
447,524,647 | three.js | VRCamera? | ##### Description of the problem
I'm sure I'm not aware of all the issues and tradeoffs but I wonder if the way WebVR works might do from some changes?
It's really strange that I have a `PerspectiveCamera` that is ignored and that enabling VR basically ignores my camera which has implications for rendering to render targets and other uses of `renderer.render(scene, camera)`
It made me wonder if maybe there should be a `VRCamera` and you should have to manually pass it in if you want VR. That way you can easily choose when to render with some other camera for render targets for example.
I don't know what problems that would bring. Just throwing it out there as a thought to see if it makes any sense.
##### Three.js version
- [X] Dev
##### Browser
- [x] All of them
##### OS
- [x] All of them
| Suggestion | low | Minor |
447,702,099 | rust | failure to normalize associated types in supertraits | This example does not compile, but I believe it ought to ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=93dea30abcab62e4116dbec77ff37b81)):
```rust
use std::vec::Vec;
trait Foo<T> { }
trait Bar<T: Iterator>: Foo<T::Item> { }
fn a(x: &(impl Foo<u32> + ?Sized)) {
}
fn b(y: &dyn Bar<std::vec::IntoIter<u32>>) {
a(y)
}
fn main() {
}
```
we get the error:
```
error[E0277]: the trait bound `dyn Bar<std::vec::IntoIter<u32>>: Foo<u32>` is not satisfied
--> src/main.rs:12:5
|
12 | a(y)
| ^ the trait `Foo<u32>` is not implemented for `dyn Bar<std::vec::IntoIter<u32>>`
|
note: required by `a`
--> src/main.rs:7:1
|
7 | fn a(x: &(impl Foo<u32> + ?Sized)) {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```
Note that changing `b` like so compiles ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=7a50b8a49862872b76c18ddd41e89587)):
```rust
fn b(y: &(impl Bar<std::vec::IntoIter<u32>> + ?Sized)) { }
``` | A-trait-system,A-associated-items,T-compiler | low | Critical |
447,713,162 | go | net/http: support HTTP/3 | I searched for an issue to track progress of implementing HTTP/3 in the standard library but couldn't find one, so I'm opening this new issue to track this (presumably inevitable) effort.
HTTP/3 is still an IETF draft, so there's not too much point starting work on this yet. The relevant spec is (currently) available here: https://quicwg.org/base-drafts/draft-ietf-quic-http.html.
Some questions we may want to answer before any work starts:
1. Should work on this start in one of the x repos, like HTTP/2 did?
2. What if any existing libraries can be used as a base for the new HTTP/3 work?
Of note is an existing attempt at implementing QUIC and HTTP/3 in pure go: https://github.com/lucas-clemente/quic-go. | NeedsInvestigation,FeatureRequest | high | Critical |
447,740,882 | terminal | Doc issue: Spectre mitigated libraries needed? | Yesterday, I tried installing Visual Studio 2019 (16.1.0) on a new computer and cloning and building the terminal repo. When installing VS, I made sure to select the "desktop dev with C++" and "universal Windows dev" profiles, and the v141 compiler and universal Windows tools.
However, building from the command line with `bz` reliably failed. While I don't have the exact text on hand, I remember MSBuild showed the following:
- Warnings in an MSBuild-built-in settings file (in `C:\Program Files` or similar, not in the terminal repo) that Spectre-mitigated libraries were chosen but not installed.
- Errors that the linker could not find the import .lib for the C runtime or C++ library DLLs (`msvcrt.lib` , `msvcprt.lib` , ...). After observing with [Process Monitor](https://docs.microsoft.com/sysinternals/downloads/procmon), I saw that link.exe did seem to be looking only in "Spectre" folders for these files.
Is it expected that Spectre-mitigated C runtimes are required? Could it be documented if so? And if not, could it be corrected? | Issue-Docs,Area-Build,Product-Meta | low | Critical |
447,750,046 | pytorch | Import warning when using the wrong version of CUDA | ## 🚀 Feature
Emit some warning text on import when trying to use a version of PyTorch compiled with a different version of CUDA than is available.
## Motivation
I recently experienced basically this problem: https://github.com/pytorch/pytorch/issues/17543 . I was using CUDA 10.0 (based on a docker image `nvidia/cuda:10.0-base-ubuntu16.04`) and installed pytorch with `pip install torch`, but that installs a version of PyTorch that only works reliably with CUDA 9.
The actual instructions for installing a PyTorch that works with CUDA 10 (as offered at https://pytorch.org/get-started/locally/) are to install from wheel files, but this is probably not the first thing many people will try. On the other hand, it doesn't seem unreasonable for people to be installing the latest version of CUDA. So this sort of mismatch seems like it would happen a lot.
The error printed out currently (`RuntimeError: cuDNN error: CUDNN_STATUS_EXECUTION_FAILED`) is not very helpful. Also it's very confusing that the error only happens for certain code paths (RNNs, it seems), so one might have been using torch successfully for months before running into this problem. (By which point, one might too quickly rule out a bad install, since it had been working so far, leading to more wasted time.)
## Pitch
When importing torch, check the version of CUDA expected against the version of CUDA installed, and print out a warning if they don't have the same, say, major version.
## Alternatives
I don't know enough about python packaging to understand why `pip` can't do this automatically and just make sure we get the right version of PyTorch for whatever version of CUDA is already installed. Maybe this is a bad idea for some reason. | module: cuda,triaged | low | Critical |
447,771,138 | TypeScript | Go To Definition on call expression of union signature only shows one constituent signature | **TypeScript Version:** 6a559e37ee0d660fcc94f086a34370e79e94b17a
**Search Terms:** go to definition call expression union signature
**Code**
```ts
interface A {
(): string
}
interface B {
(): number
}
declare const fn: A | B;
fn(); // Go To Definition here
```
**Expected behavior:**
Should show three definitions: `declare const fn: A | B`, the call signature from `A`, and the call signature from `B`
**Actual behavior:**
Shows only `declare const fn: A | B` and the call signature from `A`
[**Playground Link**](https://www.typescriptlang.org/play/#src=interface%20A%20%7B%0D%0A%20%20%20%20()%3A%20string%0D%0A%7D%0D%0Ainterface%20B%20%7B%0D%0A%20%20%20%20()%3A%20number%0D%0A%7D%0D%0A%0D%0Adeclare%20const%20fn%3A%20A%20%7C%20B%3B%0D%0Afn()%3B%20%2F%2F%20⌘%20click%20or%20⌘%20F12%20or%20right-click%20-%3E%20Go%20To%20Definition%0D%0A) | Bug,Domain: Symbol Navigation | low | Minor |
447,773,619 | rust | --print=native-static-libs should behave as the other --print commands and not create output | It creates `.a` instead.
And if one wants to get the link line in shell you have this mouthful expression:
``` sh
NATIVE_LIBS=`rustc --crate-type staticlib \
--print native-static-libs 2>&1 - < /dev/null | \
grep native-static-libs | cut -d ':' -f 3`
``` | A-frontend,A-driver,T-compiler,C-bug | low | Minor |
447,782,447 | youtube-dl | learningcrux | <!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl:
- First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.05.20. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED.
- Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser.
- Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights.
- Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates.
- Finally, put x into all relevant boxes (like this [x])
-->
- [x] I'm reporting a new site support request
- [x] I've verified that I'm running youtube-dl version **2019.05.20**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that none of provided URLs violate any copyrights
- [x] I've searched the bugtracker for similar site support requests including closed ones
## Example URLs
https://www.learningcrux.com/course/2019-machine-learning-classification-bootcamp-in-python
## Description
<!--
Provide any additional information.
If work on your issue requires account credentials please provide them or explain how one can obtain them.
-->
Microsoft Windows [Version 10.0.17763.168]
(c) 2018 Microsoft Corporation. All rights reserved.
c:\crux>youtube-dl
[generic] 2019-machine-learning-classification-bootcamp-in-python: Requesting header
[generic] 2019-machine-learning-classification-bootcamp-in-python: Downloading webpage
[generic] 2019-machine-learning-classification-bootcamp-in-python: Extracting information
ERROR: Unsupported URL: https://www.learningcrux.com/course/2019-machine-learning-classification-bootcamp-in-python
c:\crux>
| site-support-request | low | Critical |
447,783,994 | go | x/build/app/appengine: make leftmost column fixed & not scroll horizontally | I'd like the https://build.golang.org leftmost column to stay on the screen when I scroll the page horizontally.
It's hard to see what broke something when you're scrolling far to the right...
<img width="1185" alt="Screen Shot 2019-05-23 at 10 22 48 AM" src="https://user-images.githubusercontent.com/2621/58273130-e08b8980-7d44-11e9-977c-a5c062c5f446.png">
...
<img width="1191" alt="Screen Shot 2019-05-23 at 10 22 57 AM" src="https://user-images.githubusercontent.com/2621/58273139-e4b7a700-7d44-11e9-8f97-95ed904e833b.png">
/cc @andybons @dmitshur | help wanted,Builders,NeedsFix,FeatureRequest | low | Minor |
447,845,393 | terminal | Coding Standards: Switch to using in-class initializers instead of initializers in constructors | From discussion in #825. We should probably make a point to move existing code over to this style. @adiviness might have ideas on the best way to go about this.
The relevant discussion is copied below:
<hr>
dlong11 5 days ago
@zadjii-msft Some of these variables should be class initialized.
C.48: Prefer in-class initializers to member initializers in constructors for constant initializers
zadjii-msft 3 days ago Author Member
Considering this is the style that we're consistently using throughout the rest of the codebase, I'm going to leave these.
Seems kinda odd that we've been converting things to use this style when this isn't the standard, but I'm not the standards guru here - @adiviness is
adiviness 2 days ago Member
The reasoning for doing all initialization in the constructor is to prevent splitting the initialization code across two files, it's a little easier to read when it's all done in the constructor. Ideally we could get around the chance of missing initialization of a field with a compiler warning like what clang has. This may be something we can revisit one the static analysis tools are in place.
dlong11 2 days ago
@zadjii-msft @adiviness @DHowett-MSFT @binarycrusader I wasn't sure who this comment should go to so I've added everyone I have interacted with.
From an outsiders point of view - It is very difficult to review code when you don't know what the coding standards are. I have seen that you follow the Cpp Core Guidelines but only in certain areas? Maybe this comes from the fact that you have a distinction from "old" code vs "new" code. I believe it may come from the clause - If it's inserting something into the existing classes/functions, try to follow the existing style as closely as possible. I understand the reasoning of this but this can be a real trap when you are dealing with coding standards.
This essentially means you have two coding standards and now you must know when to apply each. This may be easy for someone who is on the "team" but this can be a deal breaker for the outside community. When and how will this code get updated to the new standards? Why would we continually add code debt? Cleaning this code up in the past may have been impossible due to the team size, but now you have a community that can/will do this if they know the rules.
This is a good example -
The reasoning for doing all initialization in the constructor is to prevent splitting the initialization code across two files, it's a little easier to read when it's all done in the constructor.
This is contradictory to C.48: Prefer in-class initializers to member initializers in constructors for constant initializers
I am fine with either approach, but to effectively review this code we need to know which set of rules we are following.
I don't want this to come off as ranting. This is purely feedback and not meant to cast stones at anyone! I am just trying to figure out the rules and expectations. (I'm sure others are as well) Also, I am not trying to push for one standard vs another. Since this project has been newly opened up, it is entirely possible that you guys are still figuring this out. I can understand that.
I thought it might be helpful to give you an outsiders point of view.
zadjii-msft a day ago Author Member
This is a very valid point, and I want to make sure you don't feel like we are just dismissing this opinion. Updating our code to modern standards has been a long and arduous journey, but we're definitely not all there yet (evidently). I think where we're mostly coming from is a very Windows-centric mindset, where we have a huge codebase with varying styles across all of it. In Windows, the guidance* has been to match the existing style when writing code in an existing codebase, and try to conform to the standard when writing a new feature areas.
I definitely hear you that this is a major pain points for external contributors, and something that we really need to work with the community on going forward. There's #890, which is probably a good thread to copy most of this commentary into.
adiviness a day ago Member
Typically how we've done stylistic things in the past is that new code gets written in whatever we considered the best of coding standards/styling at the time, but we also don't know everything about C++ :) I'm actively looking into getting code formatting/linting/static analysis/etc. tools set up for the project. For something like the initializers I'd expect that we'd enable whatever check that makes a tool yell at us about them and then we'd fix all of the instances in one fell swoop. Although I'm not sure if it's possible for a tool to find instances of this particular coding guideline quite yet.
We do want to more closely follow the coding standards we've referenced, this may be something worth opening an issue for so switching the initializers could be tracked.
dlong11 17 hours ago
@zadjii-msft Thanks for the reply.
and I want to make sure you don't feel like we are just dismissing this opinion.
I don't feel like anyone is dismissing my opinion. You guys have been great. I understand that we are in forming/storming stage. All good.
Updating our code to modern standards has been a long and arduous journey, but we're definitely not all there yet (evidently). I think where we're mostly coming from is a very Windows-centric mindset, where we have a huge codebase with varying styles across all of it.
Too funny. I am in the same boat. I have been a working a large legacy windows-centric code base for a long time. A few years ago we decided to go cross platform and start to update to Modern C++. So we were in the same boat. It has been a long road and obviously when you have millions of lines of code you can't clean it all up at once. We started with a similar set of rules like you. "keep the code consistent, ....." What we found was doing this is almost impossible. It is really hard to say "follow these guidelines for this code" and "follow these for this code".
In a nutshell this is what helped us get there.
Have a style guide and follow it for all new and modified code. The more detail the better.
I mean really follow it. :) This sounds funny but until everyone commits to it and understands it you will have issues. All devs/reviewers need to understand the Core guidelines (or whatever your coding standards are) - this takes some time to get there but it is doable.
Compile with all Major compilers - Clang has great sanitizers, better warnings, etc...
Use clang-format! This will save a huge amount of time. No more - oh you have an extra line here, you have the braces in the wrong spot, etc... Also, be OK if it is not exactly the same as what you do now. Believe me, it is worth it.
Setup external tools like the CppCoreGuilines analyzer / static analyzer - this sounds great but with a large code base, it is difficult to run the analyzer and fix them all. In this repo you may be able to do that. The terminal codebase isn't that large.
Document - Contributing.md, style guide, Do's / Dont's, etc. If everyone knows what the rules are then everyone will be more productive. Also realize the community doesn't have the years of backstory that msft devs have. (this is easy to forget) Doing a good job of this will pay huge dividends.
There's #890, which is probably a good thread to copy most of this commentary into.
I opened this. 👍 For this repo to be successful this stuff is a must.
You guys seem to have a good start on this and @adiviness has a lot of this on his list. So you guys are on the right track. I'm looking forward to watching this repo mature.
<hr> | Help Wanted,Product-Meta,Issue-Task,Area-CodeHealth,good first issue | low | Minor |
447,861,272 | terminal | Some warnings aren't turned on | It looks like there's some warnings that are [turned off by default](https://docs.microsoft.com/en-us/cpp/preprocessor/compiler-warnings-that-are-off-by-default?view=vs-2019). We should enable these and fix any instances of the warnings triggering as necessary. | Help Wanted,Product-Meta,Issue-Task,Area-CodeHealth | low | Minor |
447,864,320 | flutter | flutter_tools/test/src/context.dart has non-mock "Mock*" classes | There are various classes in context.dart that are called `Mock*` but are not actually mocks. It seems random, and possibly just an oversight. For instance:
`class MockXcodeProjectInterpreter implements XcodeProjectInterpreter`
but
`class MockIOSSimulatorUtils extends Mock implements IOSSimulatorUtils`
This is bug number 1.
It looks like they are intended for use in the default `testUsingContext`, but are public (I would argue that being public is bug number 2).
Taking the `MockXcodeProjectInterpreter` example, test files that actually want to mock that class have:
`class MockXcodeProjectInterpreter extends Mock implements XcodeProjectInterpreter {}`
This shadows the version in context.dart (bug number 3).
When you put all this together, you end up with the very surprising behavior that if you take a working test using a local `MockXcodeProjectInterpreter` and move it to a new file, but neglect to add a local override in that new file, everything compiles just fine and you get mysterious `Mock method was not called within 'when()'` errors and waste a lot of time trying to figure out what's going on.
I would argue that at a minimum
1) Classes named `Mock*` need to be `Mock` objects.
2) context.dart shouldn't be vending objects that are being silently shadowed in test files. | a: tests,team,tool,P3,team-tool,triaged-tool | low | Critical |
447,894,525 | TypeScript | Generic interface callback return type validation issue | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section!
Please help us by doing the following steps before logging an issue:
* Search: https://github.com/Microsoft/TypeScript/search?type=Issues
* Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ
Please fill in the *entire* template below.
-->
<!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. -->
**TypeScript Version:** Version 3.5.0-dev.20190523
<!-- Search terms you tried before logging this (so others can find this issue more easily) -->
**Search Terms:**
union callback function flatMap overload
**Code**
```ts
interface I<A> {
foo<B>(f: (a: A) => B | I<B>): I<B>;
}
class C<A> implements I<A> {
constructor(readonly a: A) {}
public foo<B>(f: (a: A) => B | C<B>): C<B> {
const b: B | C<B> = f(this.a);
if (b instanceof C) {
return b;
}
return new C(b);
}
}
```
**Expected behavior:**
I expect that the example passes the type check without any errors based on the following assumptions: `C<A>` implements `I<A>` thus the return of `C<A>.foo` including `f: (a: A) => B | C<B>` matches the types declared in `I<A>.foo`.
Side Note: The interface of `foo` is similar to `Array.flatMap`.
**Actual behavior:**
I get the following type error for `C<A>.foo`:
```text
Property 'foo' in type 'C<A>' is not assignable to the same property in base type 'I<A>'.
Type '<B>(f: (a: A) => B | C<B>) => C<B>' is not assignable to type '<B>(f: (a: A) => B | I<B>) => I<B>'.
Type 'C<B | I<B>>' is not assignable to type 'I<B>'.
Types of property 'foo' are incompatible.
Type '<B>(f: (a: B | I<B>) => B | C<B>) => C<B>' is not assignable to type '<B>(f: (a: B) => B | I<B>) => I<B>'.
Types of parameters 'f' and 'f' are incompatible.
Types of parameters 'a' and 'a' are incompatible.
Type 'B | I<B>' is not assignable to type 'B'.
Type 'I<B>' is not assignable to type 'B'.ts(2416)
```
I don
**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
https://codesandbox.io/s/hopeful-kirch-571v7?fontsize=14&module=%2Fsrc%2Findex.ts&view=editor
**Related Issues:** <!-- Did you find other bugs that looked similar? -->
**Workaround:**
One can workaround this issue using function overloading instead of a union return for the callback.
```ts
interface I<A> {
foo<B>(f: (a: A) => B): I<B>;
foo<B>(f: (a: A) => I<B>): I<B>;
}
```
| Needs Investigation | low | Critical |
447,903,009 | react | Improving the component logging/debugging experience | # Backstory
DevTools re-renders function components that use hooks in order to build up metadata to display in the selected element panel. This may cause confusion, since these re-renders will trigger breakpoints and cause unexpected console logging (see [this comment](https://github.com/facebook/react-devtools/issues/1215#issuecomment-495382645)). We avoid unnecessary re-renders by caching data (see [PR 289](https://github.com/bvaughn/react-devtools-experimental/pull/289)) but even so this is likely to be a point of confusion.
# Solution
It would be nice if the shallow re-rendering done by DevTools were less observable (e.g. console logs were suppressed to avoid cluttering the console). Breakpoints would still be hit, but that seems like a less common use case.
While we are considering logging, we might also consider if there are additional improvements that could be made, e.g.
1. Add a new section to the Components tree that shows the most recently logged messages for a given component.
2. Add an option to coalesce render-time logs into a single message that's printed at commit (or error) time to make debug logging easier to read. (Perhaps we could use `console.group` to also indicate the nested structure of these logs.)
The proposals below address both (a) collecting per-component logging info and (b) temporarily disabling console logging while re-rendering for inspection purposes.
# API Proposals
## 1: Modify built-in `console` methods
DevTools could spy on the built-in `console` methods and disable the pass-through functionality when re-rendering.
### Pros
* Requires no effort / code changes for developers to opt in and benefit from this.
* "Just works" for advanced methods like `console.group` and `console.table`.
* "Just works" for third party libraries that may not even be React-specific.
### Cons
* Feels questionable to modify native browser APIs.
## 2: Add `React.log` and `React.info` API
React will be adding two new logging methods in the upcoming v16.9 release- `React.warn` and `React.error` (see #15170). These methods decorate `console.warn` and `console.error` and append the current component stack to any logged messages. We could extend this pattern and add additional `log` and `info` methods. These APIs could be extended by DevTools as needed.
### Pros
* Does not require mutating global APIs.
### Cons
* Requires code changes to opt-in.
* Would not cover (or would be a hassle to cover) all `console` methods (e.g. `group`)
* Would not work for third party components or non-React utility code.
## 3: Add `React.debug(callback)` API
React could add a new `debug` API that accepts a callback for general debug operations (most commonly `console` logging, but also potentially breakpoints or other things).
### Pros
* Works with breakpoints.
* Covers more complex use cases (e.g. pushing to an array for debug purposes).
* Single method rather than mirroring (or spying on) multiple `console` APIs.
### Cons
* Requires code changes to opt-in.
* Requires more boilerplate for simple logging use cases.
| Type: Discussion,React Core Team | medium | Critical |
447,903,400 | vscode | Add "type" to textDocument/references results (icon, filtering) | The C/C++ extension wants to be able to send back references of different types that users can determine what "type" of reference it is and filter out unwanted types -- in order to provide functionality equivalent to Visual Studio 2019. The types are
1. Confirmed reference (i.e. passes semantic checking): reference icon
2. Not a reference (i.e. has the same name, but fails semantic checking): cancel icon
3. Reference in a comment: comment icon
4. Reference in a string: string icon
5. Reference in an inactive (preprocessor) region: ? icon (or a better one, since it conflicts with 7)
6. Possible reference (Confirmation in progress): progress icon?
7. Possible reference (Confirmation canceled): ? icon (or a better one, since it conflicts with 5 and 7) -- this "type" doesn't exist in VS, but it seems like it should (at least for us).
8. Cannot confirm reference (due to some bug or "by design" limitation): ? icon
This is the screenshot from VS:
Our current "workaround" is to only send back Confirmed References (number 1), although we also plan to have some progress UI with a button that allows users to view the Confirmation in progress (number 6 items, merged in with number 1 items). We're currently implementing this for June: https://github.com/microsoft/vscode-cpptools/issues/15 .
The relevant LSP that would need to be changed is at
https://microsoft.github.io/language-server-protocol/specification#textDocument_references
| feature-request,api,editor-symbols | medium | Critical |
447,908,849 | react | Root-level performance events | DevTools (and other perf related infra) would benefit from being able to observer the following:
* Starting (or resuming) work on a root.
* Completing (or yielding) work on a root.
* Committing work for a root.
* A particularly component suspending during a render.
* A suspended (identified by a component stack) promise resolving/retrying.
* An update being scheduled (e.g. `setState`) by a component (identified by a component stack).
* A root-level `render` call being made.
In order to fit within the context of the scheduler, we would also want to emit/capture the following events:
* The scheduler is starting to run tasks at a specific priority.
* The scheduler is stopping.
* The scheduler currently has X number of tasks scheduled for each priority. (Maybe this could be logged periodically? Or along with each time we stopped work at a priority?)
We could use this info to e.g. draw a timeline in the Profiler UI that showed CPU/IO work breakdown.
If we used a mechanism like `performance.mark` to record these events as part of the browser's profiling session, we could also include information about _unscheduled_ JavaScript- as well as other important related concepts, like network requests, paints, etc.
### Sequencing
- [ ] (ʀᴇᴀᴄᴛ) Add logging to react-reconciler and scheduler packages.
* e.g. Make sure we are logging start/stop/yield/cancel for renders correctly
* e.g. Make sure state-updates are being logged with the scheduled priority (not just the current)
* Research: Make sure performance.mark is actually fast enough to use.
* Add some basic test coverage to ensure we are marking the expected events in the expected order.
* (Do not expose component stacks for now).
- [ ] (ʀᴇᴀᴄᴛ) Design API for DevTools to start/stop performance marking.
* This shouldn’t be on by default, only when we’re actually profiling.
- [ ] (ʀᴇᴀᴄᴛ) Design public API (if we want one) for collecting and logging these new data points.
* Web-speed would probably like to collect this data.
- [ ] (ᴅᴇᴠᴛᴏᴏʟs) [Parse Chrome](https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/preview) performance profile JSON output.
* Filter unsupported event types.
* Massage data slightly (e.g. combine multiple micro-yields into a single task).
- [ ] (ᴅᴇᴠᴛᴏᴏʟs) Create visualization (chart) UI for data.
* Turn individual events (or “B” and “E” pairs) into graphics on a timeline.
* Needs exploratory prototyping / design work.
- [ ] (ᴅᴇᴠᴛᴏᴏʟs) Create zoom-and-pan controls.
* Something that works similar to Chrome’s Performance tab probably.
* Enables zooming in on regions of profiling data.
* Would be nice to build using the interactions stuff Dominic/Nicolas made for Comet
* Consider not zooming all the way out by default (but setting some max zoom-out cap?)
* Consider adding windowing logic to avoid rendering things outside of the viewport?
- [ ] (ᴅᴇᴠᴛᴏᴏʟs) Add [Chrome debug protocol](https://chromedevtools.github.io/devtools-protocol/tot/Profiler#method-start) support
* Requires [“debugger” permission](https://developer.chrome.com/extensions/debugger), but it should be an [optional permission](https://developer.chrome.com/extensions/permissions) that we just-in-time prompt for.
- [ ] (ʀᴇᴀᴄᴛ/ᴅᴇᴠᴛᴏᴏʟs) Initial integration.
* When user starts profiling React, Chrome’s profiling recorder should also be started.
* We may want to enable running one without the other? Depends on how much overhead.
* Also call the React hook to enable performance.mark calls for scheduler and react-dom.
- [ ] (ʀᴇᴀᴄᴛ/ᴅᴇᴠᴛᴏᴏʟs) Improved integration.
* Add component stack ID to marked “update state” and “suspend” events (e.g. “state-update-normal-123”)
* Read actual component stack string from DevTools using this ID.
- [ ] (ʀᴇᴀᴄᴛ/ᴅᴇᴠᴛᴏᴏʟs) Explore implementing a queue size visualization
* Would require a new event or a hook into scheduler to get the current queue size. | React Core Team | low | Critical |
447,920,467 | TypeScript | Encapsulate type refactoring | <!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨
Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section.
-->
## Search Terms
- refactoring
- encapsulate
- return, function
## Suggestion
Add a refactoring that encapsulates a given instance of a type and updates uses of it. Encapsulating would wrap the type in an object type that has a single property of that type.
## Use cases
My original use case would be to convert a single returned type to an object that can return multiple values:
1. Start
```ts
function foo(): number { return Date.now(); }
const z = foo();
```
1. Select `number` and run `encapsulate`
1. Result
```ts
function foo(): { value: number } { return { value: Date.now() }; }
const z = foo().value;
```
This could also be used for individual parameters in a function:
1. Start
```ts
function foo(x: number) { return x * 2; }
foo(1);
```
1. Select `number` and run `encapsulate`
1. Result
```ts
function foo(x: { value: number }) { return x.value * 2; }
foo({ value: 1 });
```
This may fall under some larger class of refactoring, I'm just not sure what to call it
| Suggestion,Awaiting More Feedback,Domain: Refactorings | low | Critical |
447,926,988 | go | cmd/link: TestDWARF*/testprog is flaky on darwin/amd64 | At b84e0bc61a, on darwin/amd64:
```
$ go test -run=TestDWARF/testprog -count=10 cmd/link
--- FAIL: TestDWARFiOS (0.53s)
--- FAIL: TestDWARFiOS/testprog#03 (2.03s)
dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.50s)
--- FAIL: TestDWARFiOS/testprog#03 (1.78s)
dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.52s)
--- FAIL: TestDWARFiOS/testprog#03 (1.96s)
dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.54s)
--- FAIL: TestDWARFiOS/testprog#03 (1.83s)
dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.53s)
--- FAIL: TestDWARFiOS/testprog#03 (1.98s)
dwarf_test.go:96: exit status 255
--- FAIL: TestDWARFiOS (0.54s)
--- FAIL: TestDWARFiOS/testprog#02 (1.99s)
dwarf_test.go:96: exit status 255
FAIL
FAIL cmd/link 47.577s
FAIL
```
I've also seen
```
--- FAIL: TestDWARF (0.22s)
--- FAIL: TestDWARF/testprog (3.00s)
dwarf_test.go:96: exit status 255
FAIL
```
The failures are intermittent.
cc @dr2chase
| Testing,OS-Darwin,NeedsInvestigation | low | Critical |
447,938,539 | flutter | Create a bug report mechanism for add-to-app | Potentially interesting to dump logcat/console and file structure of the projects. Gradle, xcodeproj, Podfile etc. | tool,a: existing-apps,a: triage improvements,P3,team-tool,triaged-tool | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.