id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
440,829,066
flutter
Create onLoad event in SearchDelegate
## Use case I need to show a list of users when loading the SearchDelegate screen. Taking in consideration the [API](https://docs.flutter.io/flutter/material/SearchDelegate-class.html) there is nothing that allows me to load something based or not in the query and that is only triggered once. Playing with `buildResults` and `buildSuggestions` take me nowhere, specially because the events keep firing whenever I write anything in the SearchInput. ## Proposal Create an event that fires only on load.
c: new feature,framework,f: material design,P3,team-design,triaged-design
low
Minor
440,831,515
flutter
Allow to disable AutoFocus in input using SearchDelegate
## Use case Allow to disable the auto-focus being done in the input of the SearchDelegate. This feature is also related to [this feature request](https://github.com/flutter/flutter/issues/32153). If something is being fired in the `onLoad` event it might be counterproductive to have the keyboard immediately open because of the focusness. ## Proposal Convert this: ``` showSearch( context: context, delegate: MyDelegate(), query: '', ); ``` Into this: ``` showSearch( context: context, delegate: MyDelegate(), query: '', autoFocus: false, ); ```
c: new feature,framework,f: material design,P2,workaround available,team-design,triaged-design
low
Major
440,845,547
flutter
Support iOS short task execution
iOS supports running short tasks in a way that gives them a little extra time to complete if the app moves out of the foreground. iOS Docs: https://developer.apple.com/library/archive/documentation/iPhone/Conceptual/iPhoneOSProgrammingGuide/BackgroundExecution/BackgroundExecution.html Flutter should support the ability to schedule tasks on the Dart side in a way that they will take advantage of this iOS feature. This can either be built into Flutter or built as a plugin.
c: new feature,platform-ios,would be a good package,package,P3,team-ios,triaged-ios
low
Minor
440,850,903
flutter
Consider removing Matrix4.fromFloat32List from the engine
If we do not allocate `Matrix4` using externally instantiated lists, we can communicate to the compiler that the size of the list is always exactly 16 element. Using this information the compiler can eliminate range checks.
engine,c: performance,platform-web,c: proposal,P3,team-web,triaged-web
low
Minor
440,858,791
go
cmd/go: do not download “modules” that contain no go.mod or *.go
At the moment, `go mod download` will happily try to extract and download any arbitrary repository as long as it can be resolved by some means (through a hard-coded hosting service such as `github.com`, or using a distinguished extension like `.git`), even if it does not contain anything even marginally related to building Go code. I am not aware of any reasonable use-case for such a repository: * It's not useful for storing test data, because we currently provide no mechanism for the tests to actually locate that data. (Modules are not guaranteed to be loaded from the module cache — for example, they might be subject to a `replace` directive — and since the test itself is run within the directory containing its source code, it has no way to locate the data or run `go list` within the module that invoked it.) * It's not useful for C headers (for use with `cgo`), for the same reason. * It _might be_ useful for fetching non-Go inputs to `go generate`: in theory, the generator could run `go mod download $MODULE` to locate the sources at the required version. But the output of `go generate` is intended to be checked in anyway, which makes the use of modules somewhat spurious: if an explicit version of the non-Go inputs appears in the module's requirements, then everyone using the generated package will have an extra module to fetch that is guaranteed to have no effect on the build, and in most cases the `go generate` program can just as easily `git clone` (or similar) the input data at a specific revision. Furthermore, if someone _did_ find a way to make modules without Go source code useful (for the above use-cases or others), it's trivial to add a `go.mod` file to indicate that the repository really is _somehow_ intended for use with Go source code. (We need to support `go.mod`-only modules anyway, since they can arise naturally when splitting a large root module into smaller nested modules.) ---- On the other hand, module proxies tend to rely on the `go` command to decide what is or is not a valid module, and accepting arbitrary non-Go repositories potentially exposes such proxies to a significant amount of additional load. ---- Therefore, I propose that we change the `go` command to explicitly reject any “module” that both contains no `.go` source files **and** lacks a `go.mod` file. CC @rsc @jayconrod @heschik @hyangah @katiehockman @thepudds @marwan-at-work @ianthehat
Proposal,Proposal-Accepted,early-in-cycle,modules
medium
Critical
440,861,073
vscode
Add shift+ctrl option to editor.multiCursorModifier setting
In Xcode multiple cursors is activated via shift+ctrl and clicking. Could that option (or just any recorded modifier combination) be added to the list of options for editor.multiCursorModifier? https://stackoverflow.com/questions/50696995/multi-cursor-editing-in-xcode-10
feature-request,editor-multicursor
low
Minor
440,917,099
pytorch
Latex Errors when Compiling documentation to latexpdf
## 📚 Documentation <!-- A clear and concise description of what content in https://pytorch.org/docs is an issue. If this has to do with the general https://pytorch.org website, please file an issue at https://github.com/pytorch/pytorch.github.io/issues/new/choose instead. If this has to do with https://pytorch.org/tutorials, please file an issue at https://github.com/pytorch/tutorials/issues/new --> I raise this issue because I encountered many warnings and errors compiling the documentation. I checked out version 1.1.0, and followed the instruction of "Building the Documentation" by running pip install -r requirements, and then make latexpdf. I already have texlive, latexmk, and other necessary latex packages installed. My system is Ubuntu 19.04. Errors include missing references, missing "$", extra alignment, etc. Given how verbose latex's error list is, I am not listing everything here. I can upload a log file of the errors if that is desired. Is there any specific version of latex that is required? The reason I try to get a PDF is that PDF is so much better as a single file format when I don't get internet. PDF readers can handle very long PDF files smoothly, while my browser had a hard time to load a large single-file html is hard to handle by my browser. In this use case, PDF is overall a better solution. On the other hand, I don't really know where the errors originated (the docs, Sphinx, or latex version). So, **maybe a better solution would be providing a downloadable PDF file of every release on the website**? I suppose that if the pytorch team already have a testing pipeline for documentation generation, it wouldn't be too much work to post the pdf file on the website. However, I don't really know if that fits into your pipeline. Thank you very much!
module: docs,triaged,module: doc infra
low
Critical
440,941,402
pytorch
Unify Caffe2 and PyTorch OpenMP initialization
At the moment we have two separate OpenMP initialization procedures, one in Caffe2 in `caffe2/core/init_omp.cc`, executed when `GlobalInit` is called. Another is in PyTorch in `at::init_num_threads()` There're some differences in default settings (e.g. single-thread setting in Caffe2 and default settings in PyTorch) as well as potential conflict if two initialization procedures are called in one process.
triaged,module: multithreading
low
Minor
440,946,034
terminal
[Setting] New tab button should open another of the currently selected tab
* Your Windows build number: 10.0.18890.1000 * What you're doing and what's happening: When you press the add tab button it always opens cmd. * What's wrong / what should be happening instead: It should open another of the currently viewed tab.
Issue-Feature,Help Wanted,Area-UserInterface,Product-Terminal
medium
Major
440,947,466
terminal
Feature request: Add fluent design reveal highlight to tabs and buttons
Add reveal highlight to the tabs and buttons similar to how classic ms edge has.
Issue-Feature,Area-UserInterface,Product-Terminal
low
Minor
440,961,661
flutter
Different mainAxisMargins for different scrollbar orientations and edges
`ScrollbarPainter` now assumes `mainAxisMargin` is always the same for different scrolling directions / towards different edges On iOS, mainAxisMargin should be different for vertical and horizontal scrollbars. And for vertical scrollbars the top margin and the bottom margin are different. ### Screenshot from iPhone XR simulator: ![Simulator Screen Shot - iPhone XR - 2019-04-30 at 15 00 14](https://user-images.githubusercontent.com/31859944/57262089-7faf4200-701f-11e9-914a-83f1b047e260.png) ![Simulator Screen Shot - iPhone XR - 2019-04-30 at 15 12 06](https://user-images.githubusercontent.com/31859944/57262090-7faf4200-701f-11e9-9bd1-d0d5b7a64619.png) ![Simulator Screen Shot - iPhone XR - 2019-04-30 at 17 53 40](https://user-images.githubusercontent.com/31859944/57262091-7faf4200-701f-11e9-9c8d-3a0744307240.png)
framework,a: fidelity,f: cupertino,P2,team-design,triaged-design
low
Minor
440,979,996
PowerToys
Full window manager including specific layouts for docking and undocking laptops
This was mentioned in the README so I'm creating the issue as it sounds like a neat idea to me I'm assuming this would allow for more flexible window arrangements than the current quadrant snapping, etc.
Idea-Enhancement,Idea-New PowerToy,Product-Window Manager,Product-FancyZones
high
Critical
440,991,863
PowerToys
Window auto-alignment/snap/magnet to other windows and screen edges
When window is moved or resized, the edge should auto-align/snap when it gets within X pixels of an existing window or screen edge. Edit: To clarify, I'm talking about snapping capability like the old "AllSnap" program. This has nothing to do with layouts or window management.
Idea-Enhancement,Product-Window Manager,Product-FancyZones
high
Critical
440,991,972
vue
ability to keep `enter-to` class after show transition completes
### What problem does this feature solve? In some CSS libraries, i.e. Bootstrap, many components have opacity set to `0` by default, and only have opacity set to `1` when a class is applied. i.e. Bootstrap's `fade + show` classes: ```css .fade:not(.show) { opacity: 0; } ``` The current `<transition>` behaviour does not support retaining the `enter-to-class` (as it is immediately removed once the transition completes). Currently one has to use javascript hooks and VM data to add/remove the `show` class, which makes it impossible to make re-usable transition components, as simply adding a class via javascript to the `el` reference (via `el.classList.add/remove('show')`) doesn't guarantee persistence if the content in the default slot manipulates it's own classes, meaning the transition component _must_ be integrated into the custom component, not as a re-usable utility wrapper component). ### What does the proposed API look like? It would be nice to either be able to retain the `enter-to-class` class after the transition completes, or create a new prop that provides this behaviour for a particular class name i.e. `enter-to-retain-class`. The class would be removed on leave. The other option would be to create a new prop `active-class="classname"` which is added one frame after insertion, and removed when the leave transition is to start (basically rolling the `enter-to-class` and `leave-class` into one prop, but retain the class until leave is initiated) <!-- generated by vue-issues. DO NOT REMOVE -->
feature request,transition
low
Major
441,000,114
flutter
[maps] Get latitude and longitude when polyline is tapped
## Use case It would be nice if we can get latitude and longitude when a polyline is tapped. ## Proposal Currently the `onTap` for a polyline looks like `onTap() {}`, can you guys make it like `onTap(LatLng) {}`? Now `GoogleMap` widget does have `onTap(LatLng)` but to be able to receive click events on my polyline, I have to use `consumeTapEvents: true` and this way `GoogleMap` `onTap(...)` doesn't work.
c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem
low
Minor
441,011,198
create-react-app
`yarn tsc && react-scripts build` v3 takes 1 hour to complete
### Is this a bug report? Yes, The production build of a TypeScript project requires almost an hour to complete. I have tried many different version combinations all with the same result; either my system crashes or I get a very slow build process. yarn start takes about 5 min and my production build takes almost 1 hour; it's quite consistent. Currently on the following versions. **"@types/styled-components": "4.1.10", "react-scripts": "3.0.0", "typescript": "3.3.4000",** ### Did you try recovering your dependencies? I have deleted these files numerous times and tried a few of the typescript-dev versions as well as the styled-component types. I am using Yarn Version 1.15.2 ### Which terms did you search for in User Guide? script react-scripts tsc build slow typescript cra creating optimized production build takes an hour ### Environment Issues are consistent in both environments. 1. Windows 16GB RAM, WSL (Ubuntu Install) 2. IBM Cloud Docker Instance npx: installed 91 in 18.872s Environment Info: System: OS: Linux 4.4 Ubuntu 18.04.1 LTS (Bionic Beaver) CPU: (4) x64 Intel(R) Core(TM) i7-7500U CPU @ 2.70GHz Binaries: Node: 11.11.0 - ~/.nvm/versions/node/v11.11.0/bin/node Yarn: 1.15.2 - /usr/bin/yarn npm: 6.7.0 - ~/.nvm/versions/node/v11.11.0/bin/npm Browsers: Chrome: Not Found Firefox: Not Found npmPackages: react: Not Found react-dom: Not Found react-scripts: Not Found npmGlobalPackages: create-react-app: Not Found ### Steps to Reproduce This is a very large project with hundreds of components. "start": react-scripts start", (5-6 min) "build": "tsc && react-scripts build" (~53min), <!-- How would you describe your issue to someone who doesn’t know you or your project? Try to write a sequence of steps that anybody can repeat to see the issue. --> I upgraded my existing installation to the newest version of React which supports Hooks and integrated TypeScript which caused the development server to slow down on first launch; with the console displaying the following. Files successfully emitted, waiting for typecheck results... When I commit and merge the code, a deployment build is spun up in a Docker instance which takes almost an hour to complete. ### Expected Behavior I would expect the production build to take no more than 10 min. The development server should also launch a bit quicker.
issue: needs investigation
high
Critical
441,043,866
terminal
Workspace-specific settings and profiles
Is workspace-specific settings on the roadmap for the Windows Terminal? I was chatting with @jongalloway about it and it would really help streamline teams to be able to check in certain settings or profiles with a solution. VS Code has a great model for Workspace settings and User Settings, I would love to see it here as well. (bonus points for auto-switching settings when `cd`'ing into a workspace directory). [UserVoice recommendation](https://wpdev.uservoice.com/forums/266908-command-prompt-console-windows-subsystem-for-l/suggestions/37567330-workspace-specific-settings-and-profiles)
Issue-Feature,Area-Settings,Product-Terminal
low
Minor
441,068,209
TypeScript
support match for type infer
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section. --> ## Search Terms <!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily --> ## Suggestion As a suggestion, there is any plans to support `match` keyword in type inference to simplify the type destruction and `T extends P` test and make code more expressive. Support `match` in type inference. <!-- A summary of what you'd like to see added or changed --> ## Use Cases ```ts type Infer<T> = match T { { prop: infer P } => P [infer P] => P _ => never // default } ``` The above is equal to: ```ts type Infer<T> = T extends { prop: infer P } ? P : T extends [infer P] ? P : never ``` ``` ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Critical
441,074,342
terminal
Feature request: Recording
It would be cool to have a built-in tool to record a terminal session; this would make it easy to create demos and tutorials with no demo ghosts. Basic feature could be a animated gif The more advanced could be a playback where you get a live terminal that plays back the recorded session and leaves it open for continued use.
Issue-Feature,Area-Output,Area-Extensibility,Product-Terminal
medium
Critical
441,087,327
PowerToys
Tabbing Features
With the release of the new command line system for W10 I think this kind of feature is a no brainier. Here is another solution for reference: [TidyTabs](https://www.nurgo-software.com/products/tidytabs)
Idea-New PowerToy,Product-Window Manager
high
Critical
441,087,583
PowerToys
Disable Sticky Corners in aero snap
When moving the mouse from one monitor to the other it gets stuck because of the "sticky corners". So for example, if you want to close a window in the right monitor but your mouse is on the left monitor, you end inadvertently closing the window of the left monitor as the mouse gets stuck in the close button. The problem is described in detail here https://superuser.com/questions/947817/how-to-disable-sticky-corners-in-windows-10 A workaround https://github.com/patricknelson/win10-sticky-mouse
Idea-New PowerToy,Product-Tweak UI Design
low
Major
441,094,165
PowerToys
Scripting API for Window Manager
Just through out an idea. If you guys create a customizable window manager, I'd welcome a way to interact with it via some scripting language or the commandline. In Linux, [i3](https://i3wm.org/) comes with a commandline utility `i3-msg` which allows you to reorganize windows via scripts.
Idea-Enhancement,Product-Window Manager
medium
Major
441,096,416
ant-design
Collapse中使用form的validateFieldsAndScroll
- [ ] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate. ### What problem does this feature solve? 因为Collapse展开需要时间,调用validateFieldsAndScroll会滚动不到具体位置,需要加定时器。 ### What does the proposed API look like? 希望添加Collapse展开后回调函数。 <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
💡 Feature Request,Inactive
low
Major
441,110,850
TypeScript
Correct typing when using the index signature of an Enum
## Search Terms enum index signature ## Suggestion Imagine a non const enum (which can be accessed using properties and it's index signature). ``` typescript enum example { ONE = 1, TWO = 2, THREE = 3 } const a = example.ONE; console.log(a); // Prints 1 const aName = example[a]; // Type of aName is string and should be "ONE" | "TWO" | "THREE". Or even "ONE" since a is const console.log(aName); // Prints "ONE"; ``` The implicit type of aName is _string_ and should be "ONE" | "TWO" | "THREE" since those are the only possible values. Or even "ONE" since a is a constant. ## Use Cases More control over the values of a variable. ## Examples See above ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,In Discussion
low
Minor
441,115,204
neovim
missing redraws when rpcrequest() is used in statusline expression
This is with recent nvim HEAD, and also manifested with a version some month back. I did not investigate if there are older versions which behave correctly here. The RPC plugin in question is [here](https://github.com/KillTheMule/nvimpam/tree/impro) (take care to take the `impro` branch), so it's not minimal in any way. I might get around to produce something more minimal in python or so. If you cloned the repo, then in the master directory first you need to compile the plugin (`cargo build`, needs a rust installation), and then you can produce the error from running `nvim -u init.vim files/example.pc` as follows: 1. Start the plugin with `:NvimPamAttach` 1. move to line 50, which reads ``` NODE / 22 20.20000076 50.5 30. ``` 3. Run `3f2`, and then `i<Space><Esc>` to insert a space. * What happens: The space is inserted, no highlighting applied. * What should happen: Space inserted, highlighting applied 4. Run `x` to remove the Space inserted in 1.) * What happens: Space is removed, the highlighting from 1.) is applied * What should happen: Space is removed, a different highlighting should be applied Note that the status line involes a function that runs a request to the plugin, namely `CellHint`, which interweaves with all other communication of course. This seems to cause trouble. When I keep doing edits, it very much looks like the highlighting applied is always lagging 1 action behind. A filtered neovim log is at https://gist.github.com/KillTheMule/12378fae90419f539be2d44b48bc0547 which only includes steps 3.) and 4.). These can be seen from line 37 (the update event from inserting a space) to line 51, where the plugin answers the "CellHint" request from neovim (which is a consequence of the statusline being updated). Just to be clear, the log looks perfectly fine to me, it's just that the highlights are not applied at the right time, but "one action later". @justinmk already looked at it in gitter, and I could provide the following additional answers: * When using `<C-l>` inbetween, the correct highlighting will be applied * Using `:redraw` inbetween does not change anything * Setting `lazyredraw` does not change anything He also suggested `as a workaround setting a "dummy" highlight e.g. nvim_add_buf_hl(..., 'Normal', 1,1) i.e. highilight line 1, column 1 with "Normal" highlight every time you add a real highlight` which I will try tonight (or so...)
bug,api,channels-rpc,display
low
Critical
441,148,822
pytorch
SyncBatchNorm should support 2D input (B, C)
## 🐛 Bug In the implementation of SyncBatchNorm, I just found that there is a `_check_input_dim` to make sure the input dimension > 2. But actually it should support the input with shape (B, C), just like the BatchNorm1d. So is there any other reasons for the condition `input.dim() <=2`? If no, could you relax the input check to be `input.dim() < 2` of [SyncBatchNorm here](https://pytorch.org/docs/stable/_modules/torch/nn/modules/batchnorm.html#SyncBatchNorm) ?
oncall: distributed,module: nn,triaged,enhancement
low
Critical
441,154,515
go
crypto/tls: incompatibility with Trust Settings in CA certificate
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.12.4 linux/amd64 </pre> ### Does this issue reproduce with the latest release? yes ### What operating system and processor architecture are you using (`go env`)? golang:latest @ docker <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/root/.cache/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/go" GOPROXY="" GORACE="" GOROOT="/usr/local/go" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64" GCCGO="gccgo" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build114266566=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? Standard crypto/tls library is incompatible with CA certificates (either root or intermediate one) when they contain Trust Settings (https://www.openssl.org/docs/manmaster/man1/x509.html#TRUST_SETTINGS): <pre> $ openssl -in rootCA.crt -text -noout ... No Trusted Uses. No Rejected Uses. Alias: XXX ... </pre> Since widely used MS AD-based CAs DO have such Settings in their certs, it is hard to use encrypted connections in golang programms in such environments. ### What did you expect to see? The successfull TLS-handshake. ### What did you see instead? In our case server's cert is issued by intermediate CA which is issued by root CA and `server.crt` contains server's cert followed by the intermediate CA's one. In the case when the Trust Settings are present in the intermediate's cert, tls-negotiation fails with the following errors: client.go:40: tls: failed to parse certificate from server: asn1: syntax error: trailing data server.go:55: remote error: tls: bad certificate If only the root's cert contains the Settings, the errors are slightly different: client.go:40: x509: certificate signed by unknown authority server.go:55: remote error: tls: bad certificate (Example client&server apps are available at https://github.com/kruftik/go-tls-vs-windows-ad-ca, build.sh prepares binaries) Once the Settings are being stripped from both root and intermedia CA certs with the `openssl x509 -in rootCA.crt -out rootCA.clean.crt` command, the problem is going away.
NeedsInvestigation
low
Critical
441,154,929
create-react-app
Add support for SRI (Subresource Integrity)
SRI used to be supported in CRA (facebook/create-react-app#1176) but it was removed because of some incompatibilities (facebook/create-react-app#1231). Could we re-add SRI support in CRA? I feel like the reasons given in #1231 could be solved.
issue: proposal,tag: enhancement
medium
Critical
441,211,626
pytorch
Failed to build with system protobuf
## 🐛 Bug Failed to build (link) `caffe2_benchmark` target. ## To Reproduce Steps to reproduce the behavior: 1. `git submodule update --init --recursive` 2. `... python setup.py build` 3. Get error: ```bash [ 94%] Linking CXX executable ../bin/caffe2_benchmark /usr/bin/ld: ../../../../../lib/libpthreadpool.a(threadpool-pthreads.c.o): in function `pthreadpool_create': threadpool-pthreads.c:(.text+0x520): multiple definition of `pthreadpool_create'; ../../../../../lib/libcaffe2.a(pthreadpool_impl.cc.o):pthreadpool_impl.cc:(.text+0x140): first defined here /usr/bin/ld: ../../../../../lib/libpthreadpool.a(threadpool-pthreads.c.o): in function `pthreadpool_get_threads_count': threadpool-pthreads.c:(.text+0x670): multiple definition of `pthreadpool_get_threads_count'; ../../../../../lib/libcaffe2.a(pthreadpool_impl.cc.o):pthreadpool_impl.cc:(.text+0x120): first defined here /usr/bin/ld: ../../../../../lib/libpthreadpool.a(threadpool-pthreads.c.o): in function `pthreadpool_compute_1d': threadpool-pthreads.c:(.text+0x680): multiple definition of `pthreadpool_compute_1d'; ../../../../../lib/libcaffe2.a(pthreadpool_impl.cc.o):pthreadpool_impl.cc:(.text+0x50): first defined here /usr/bin/ld: ../../../../../lib/libpthreadpool.a(threadpool-pthreads.c.o): in function `pthreadpool_destroy': threadpool-pthreads.c:(.text+0x17d0): multiple definition of `pthreadpool_destroy'; ../../../../../lib/libcaffe2.a(pthreadpool_impl.cc.o):pthreadpool_impl.cc:(.text+0x1f0): first defined here collect2: error: ld returned 1 exit status make[2]: *** [caffe2/torch/lib/c10d/test/CMakeFiles/ProcessGroupGlooTest.dir/build.make:119: bin/ProcessGroupGlooTest] Error 1 make[1]: *** [CMakeFiles/Makefile2:10591: caffe2/torch/lib/c10d/test/CMakeFiles/ProcessGroupGlooTest.dir/all] Error 2 make[1]: *** Waiting for unfinished jobs.... ``` ## Expected behavior Expected to build and link fine ## Environment `collect_env.py`: ``` Collecting environment information... PyTorch version: N/A Is debug build: N/A CUDA used to build PyTorch: N/A OS: Arch Linux GCC version: (GCC) 8.3.0 CMake version: version 3.14.3 Python version: 3.7 Is CUDA available: N/A CUDA runtime version: 10.1.105 GPU models and configuration: Could not collect Nvidia driver version: Could not collect cuDNN version: /usr/lib/libcudnn.so.7.5.1 Versions of relevant libraries: [pip] Could not collect [conda] Could not collect ``` Manual spec: - PyTorch Version (e.g., 1.0): 1.1.0 - OS (e.g., Linux): ArchLinux x86_64 - How you installed PyTorch (`conda`, `pip`, source): source - Build command you used (if compiling from source): ```bash # Build command export CC=gcc export CXX=g++ export PYTORCH_BUILD_VERSION="1.1.0" export PYTORCH_BUILD_NUMBER=1 export BUILD_CUSTOM_PROTOBUF=0 export BUILD_SHARED_LIBS=0 export NO_CUDA=1 export WITH_CUDNN=0 export USE_OPENCV=1 export BUILD_BINARY=1 python setup.py build ``` - Python version: 3.7.3 - CUDA/cuDNN version: N/A - GPU models and configuration: N/A - Any other relevant information: ## Additional context Full config log: ``` -- The CXX compiler identification is GNU 8.3.0 -- The C compiler identification is GNU 8.3.0 -- Check for working CXX compiler: /usr/bin/g++ -- Check for working CXX compiler: /usr/bin/g++ -- works -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - done -- Detecting CXX compile features -- Detecting CXX compile features - done -- Check for working C compiler: /usr/bin/gcc -- Check for working C compiler: /usr/bin/gcc -- works -- Detecting C compiler ABI info -- Detecting C compiler ABI info - done -- Detecting C compile features -- Detecting C compile features - done -- Not forcing any particular BLAS to be found -- Performing Test COMPILER_WORKS -- Performing Test COMPILER_WORKS - Success -- Performing Test SUPPORT_GLIBCXX_USE_C99 -- Performing Test SUPPORT_GLIBCXX_USE_C99 - Success -- Performing Test CAFFE2_EXCEPTION_PTR_SUPPORTED -- Performing Test CAFFE2_EXCEPTION_PTR_SUPPORTED - Success -- std::exception_ptr is supported. -- Performing Test CAFFE2_IS_NUMA_AVAILABLE -- Performing Test CAFFE2_IS_NUMA_AVAILABLE - Failed -- NUMA is not available -- Performing Test CAFFE2_NEED_TO_TURN_OFF_DEPRECATION_WARNING -- Performing Test CAFFE2_NEED_TO_TURN_OFF_DEPRECATION_WARNING - Success -- Performing Test CAFFE2_COMPILER_SUPPORTS_AVX2_EXTENSIONS -- Performing Test CAFFE2_COMPILER_SUPPORTS_AVX2_EXTENSIONS - Success -- Current compiler supports avx2 extension. Will build perfkernels. -- Performing Test CAFFE2_COMPILER_SUPPORTS_AVX512_EXTENSIONS -- Performing Test CAFFE2_COMPILER_SUPPORTS_AVX512_EXTENSIONS - Success -- Current compiler supports avx512f extension. Will build fbgemm. -- Performing Test COMPILER_SUPPORTS_HIDDEN_VISIBILITY -- Performing Test COMPILER_SUPPORTS_HIDDEN_VISIBILITY - Success -- Performing Test COMPILER_SUPPORTS_HIDDEN_INLINE_VISIBILITY -- Performing Test COMPILER_SUPPORTS_HIDDEN_INLINE_VISIBILITY - Success -- Performing Test COMPILER_SUPPORTS_RDYNAMIC -- Performing Test COMPILER_SUPPORTS_RDYNAMIC - Success -- Caffe2: Found protobuf with new-style protobuf targets. -- Caffe2 protobuf include directory: /usr/include -- Found Threads: TRUE -- Trying to find preferred BLAS backend of choice: MKL -- Looking for sys/types.h -- Looking for sys/types.h - found -- Looking for stdint.h -- Looking for stdint.h - found -- Looking for stddef.h -- Looking for stddef.h - found -- Check size of void* -- Check size of void* - done CMake Warning at cmake/Dependencies.cmake:120 (message): MKL could not be found. Defaulting to Eigen Call Stack (most recent call first): CMakeLists.txt:236 (include) CMake Warning at cmake/Dependencies.cmake:139 (message): Preferred BLAS (MKL) cannot be found, now searching for a general BLAS library Call Stack (most recent call first): CMakeLists.txt:236 (include) -- Checking for [mkl_intel_lp64 - mkl_gnu_thread - mkl_core - gomp - pthread - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel_lp64 - mkl_intel_thread - mkl_core - gomp - pthread - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel - mkl_gnu_thread - mkl_core - gomp - pthread - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_intel - mkl_intel_thread - mkl_core - gomp - pthread - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_gf_lp64 - mkl_gnu_thread - mkl_core - gomp - pthread - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf_lp64 - mkl_intel_thread - mkl_core - gomp - pthread - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf - mkl_gnu_thread - mkl_core - gomp - pthread - m - dl] -- Library mkl_gf: not found -- Checking for [mkl_gf - mkl_intel_thread - mkl_core - gomp - pthread - m - dl] -- Library mkl_gf: not found -- Checking for [mkl_intel_lp64 - mkl_gnu_thread - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel_lp64 - mkl_intel_thread - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel - mkl_gnu_thread - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_intel - mkl_intel_thread - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_gf_lp64 - mkl_gnu_thread - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf_lp64 - mkl_intel_thread - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf - mkl_gnu_thread - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_gf: not found -- Checking for [mkl_gf - mkl_intel_thread - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_gf: not found -- Checking for [mkl_intel_lp64 - mkl_gnu_thread - mkl_core - pthread - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel_lp64 - mkl_intel_thread - mkl_core - pthread - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel - mkl_gnu_thread - mkl_core - pthread - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_intel - mkl_intel_thread - mkl_core - pthread - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_gf_lp64 - mkl_gnu_thread - mkl_core - pthread - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf_lp64 - mkl_intel_thread - mkl_core - pthread - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf - mkl_gnu_thread - mkl_core - pthread - m - dl] -- Library mkl_gf: not found -- Checking for [mkl_gf - mkl_intel_thread - mkl_core - pthread - m - dl] -- Library mkl_gf: not found -- Checking for [mkl_intel_lp64 - mkl_sequential - mkl_core - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel - mkl_sequential - mkl_core - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_gf_lp64 - mkl_sequential - mkl_core - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf - mkl_sequential - mkl_core - m - dl] -- Library mkl_gf: not found -- Checking for [mkl_intel_lp64 - mkl_core - gomp - pthread - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel - mkl_core - gomp - pthread - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_gf_lp64 - mkl_core - gomp - pthread - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf - mkl_core - gomp - pthread - m - dl] -- Library mkl_gf: not found -- Checking for [mkl_intel_lp64 - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_gf_lp64 - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf - mkl_core - iomp5 - pthread - m - dl] -- Library mkl_gf: not found -- Checking for [mkl_intel_lp64 - mkl_core - pthread - m - dl] -- Library mkl_intel_lp64: not found -- Checking for [mkl_intel - mkl_core - pthread - m - dl] -- Library mkl_intel: not found -- Checking for [mkl_gf_lp64 - mkl_core - pthread - m - dl] -- Library mkl_gf_lp64: not found -- Checking for [mkl_gf - mkl_core - pthread - m - dl] -- Library mkl_gf: not found -- Checking for [mkl - guide - pthread - m] -- Library mkl: not found -- MKL library not found -- Checking for [Accelerate] -- Library Accelerate: BLAS_Accelerate_LIBRARY-NOTFOUND -- Checking for [vecLib] -- Library vecLib: BLAS_vecLib_LIBRARY-NOTFOUND -- Checking for [openblas] -- Library openblas: BLAS_openblas_LIBRARY-NOTFOUND -- Checking for [openblas - pthread] -- Library openblas: BLAS_openblas_LIBRARY-NOTFOUND -- Checking for [goto2 - gfortran] -- Library goto2: BLAS_goto2_LIBRARY-NOTFOUND -- Checking for [goto2 - gfortran - pthread] -- Library goto2: BLAS_goto2_LIBRARY-NOTFOUND -- Checking for [acml - gfortran] -- Library acml: BLAS_acml_LIBRARY-NOTFOUND -- Checking for [ptf77blas - atlas - gfortran] -- Library ptf77blas: BLAS_ptf77blas_LIBRARY-NOTFOUND -- Checking for [blas] -- Library blas: /usr/lib/libblas.so -- Looking for sgemm_ -- Looking for sgemm_ - found -- Performing Test BLAS_F2C_DOUBLE_WORKS -- Performing Test BLAS_F2C_DOUBLE_WORKS - Failed -- Performing Test BLAS_F2C_FLOAT_WORKS -- Performing Test BLAS_F2C_FLOAT_WORKS - Success -- Performing Test BLAS_USE_CBLAS_DOT -- Performing Test BLAS_USE_CBLAS_DOT - Failed -- Found a library with BLAS API (generic). -- The ASM compiler identification is GNU -- Found assembler: /usr/bin/gcc -- Check if compiler accepts -pthread -- Check if compiler accepts -pthread - yes -- Brace yourself, we are building NNPACK -- Performing Test NNPACK_ARCH_IS_X86_32 -- Performing Test NNPACK_ARCH_IS_X86_32 - Failed -- Found PythonInterp: /usr/bin/python (found version "3.7.3") -- NNPACK backend is x86-64 -- Failed to find LLVM FileCheck -- Found Git: /usr/bin/git (found version "2.21.0") -- git Version: v1.4.0-505be96a -- Version: 1.4.0 -- Performing Test HAVE_CXX_FLAG_STD_CXX11 -- Performing Test HAVE_CXX_FLAG_STD_CXX11 - Success -- Performing Test HAVE_CXX_FLAG_WALL -- Performing Test HAVE_CXX_FLAG_WALL - Success -- Performing Test HAVE_CXX_FLAG_WEXTRA -- Performing Test HAVE_CXX_FLAG_WEXTRA - Success -- Performing Test HAVE_CXX_FLAG_WSHADOW -- Performing Test HAVE_CXX_FLAG_WSHADOW - Success -- Performing Test HAVE_CXX_FLAG_WERROR -- Performing Test HAVE_CXX_FLAG_WERROR - Success -- Performing Test HAVE_CXX_FLAG_PEDANTIC -- Performing Test HAVE_CXX_FLAG_PEDANTIC - Success -- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS -- Performing Test HAVE_CXX_FLAG_PEDANTIC_ERRORS - Success -- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32 -- Performing Test HAVE_CXX_FLAG_WSHORTEN_64_TO_32 - Failed -- Performing Test HAVE_CXX_FLAG_WFLOAT_EQUAL -- Performing Test HAVE_CXX_FLAG_WFLOAT_EQUAL - Success -- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING -- Performing Test HAVE_CXX_FLAG_FSTRICT_ALIASING - Success -- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS -- Performing Test HAVE_CXX_FLAG_WNO_DEPRECATED_DECLARATIONS - Success -- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING -- Performing Test HAVE_CXX_FLAG_WSTRICT_ALIASING - Success -- Performing Test HAVE_CXX_FLAG_WD654 -- Performing Test HAVE_CXX_FLAG_WD654 - Failed -- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY -- Performing Test HAVE_CXX_FLAG_WTHREAD_SAFETY - Failed -- Performing Test HAVE_CXX_FLAG_COVERAGE -- Performing Test HAVE_CXX_FLAG_COVERAGE - Success -- Performing Test HAVE_STD_REGEX -- Performing Test HAVE_STD_REGEX -- Performing Test HAVE_STD_REGEX -- success -- Performing Test HAVE_GNU_POSIX_REGEX -- Performing Test HAVE_GNU_POSIX_REGEX -- Performing Test HAVE_GNU_POSIX_REGEX -- failed to compile -- Performing Test HAVE_POSIX_REGEX -- Performing Test HAVE_POSIX_REGEX -- Performing Test HAVE_POSIX_REGEX -- success -- Performing Test HAVE_STEADY_CLOCK -- Performing Test HAVE_STEADY_CLOCK -- Performing Test HAVE_STEADY_CLOCK -- success -- Performing Test COMPILER_SUPPORTS_AVX512 -- Performing Test COMPILER_SUPPORTS_AVX512 - Success -- Found OpenMP_C: -fopenmp (found version "4.5") -- Found OpenMP_CXX: -fopenmp (found version "4.5") -- Found OpenMP: TRUE (found version "4.5") -- Downloading asmjit to /build/python-pytorch/src/pytorch-1.1.0/build/third_party/fbgemm/third_party/asmjit (define ASMJIT_SRC_DIR to avoid it) -- Configuring done -- Generating done -- Build files have been written to: /build/python-pytorch/src/pytorch-1.1.0/build/third_party/fbgemm/asmjit-download Scanning dependencies of target asmjit [ 11%] Creating directories for 'asmjit' [ 22%] Performing download step (git clone) for 'asmjit' Cloning into 'asmjit'... Note: checking out '673dcefaa048c5f5a2bf8b85daf8f7b9978d018a'. You are in 'detached HEAD' state. You can look around, make experimental changes and commit them, and you can discard any commits you make in this state without impacting any branches by performing another checkout. If you want to create a new branch to retain commits you create, you may do so (now or later) by using -b with the checkout command again. Example: git checkout -b <new-branch-name> HEAD is now at 673dcef Fixed #188 [ 33%] No patch step for 'asmjit' [ 44%] Performing update step for 'asmjit' [ 55%] No configure step for 'asmjit' [ 66%] No build step for 'asmjit' [ 77%] No install step for 'asmjit' [ 88%] No test step for 'asmjit' [100%] Completed 'asmjit' [100%] Built target asmjit CMake Warning (dev) at build/third_party/fbgemm/third_party/asmjit/CMakeLists.txt:34 (set): implicitly converting 'BOOLEAN' to 'STRING' type. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at build/third_party/fbgemm/third_party/asmjit/CMakeLists.txt:35 (set): implicitly converting 'BOOLEAN' to 'STRING' type. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at build/third_party/fbgemm/third_party/asmjit/CMakeLists.txt:36 (set): implicitly converting 'BOOLEAN' to 'STRING' type. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at build/third_party/fbgemm/third_party/asmjit/CMakeLists.txt:37 (set): implicitly converting 'BOOLEAN' to 'STRING' type. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning (dev) at build/third_party/fbgemm/third_party/asmjit/CMakeLists.txt:38 (set): implicitly converting 'BOOLEAN' to 'STRING' type. This warning is for project developers. Use -Wno-dev to suppress it. -- Performing Test __CxxFlag__msse -- Performing Test __CxxFlag__msse - Success -- Performing Test __CxxFlag__msse2 -- Performing Test __CxxFlag__msse2 - Success -- Performing Test __CxxFlag__msse3 -- Performing Test __CxxFlag__msse3 - Success -- Performing Test __CxxFlag__mssse3 -- Performing Test __CxxFlag__mssse3 - Success -- Performing Test __CxxFlag__msse4_1 -- Performing Test __CxxFlag__msse4_1 - Success -- Performing Test __CxxFlag__msse4_2 -- Performing Test __CxxFlag__msse4_2 - Success -- Performing Test __CxxFlag__mavx -- Performing Test __CxxFlag__mavx - Success -- Performing Test __CxxFlag__mavx2 -- Performing Test __CxxFlag__mavx2 - Success -- Performing Test __CxxFlag__std_c__17 -- Performing Test __CxxFlag__std_c__17 - Success -- Performing Test __CxxFlag__std_c__14 -- Performing Test __CxxFlag__std_c__14 - Success -- Performing Test __CxxFlag__std_c__11 -- Performing Test __CxxFlag__std_c__11 - Success -- Performing Test __CxxFlag__std_c__0x -- Performing Test __CxxFlag__std_c__0x - Success -- Performing Test __CxxFlag__fno_tree_vectorize -- Performing Test __CxxFlag__fno_tree_vectorize - Success -- Performing Test __CxxFlag__fvisibility_hidden -- Performing Test __CxxFlag__fvisibility_hidden - Success -- Performing Test __CxxFlag__Winconsistent_missing_override -- Performing Test __CxxFlag__Winconsistent_missing_override - Failed -- Performing Test __CxxFlag__O2 -- Performing Test __CxxFlag__O2 - Success -- Performing Test __CxxFlag__fno_keep_static_consts -- Performing Test __CxxFlag__fno_keep_static_consts - Success -- Performing Test __CxxFlag__fmerge_all_constants -- Performing Test __CxxFlag__fmerge_all_constants - Success -- [asmjit] BuildMode=Static BuildTest=Off ASMJIT_DIR=/build/python-pytorch/src/pytorch-1.1.0/build/third_party/fbgemm/third_party/asmjit ASMJIT_DEPS=pthread;rt ASMJIT_LIBS=asmjit;pthread;rt ASMJIT_CFLAGS=-DASMJIT_STATIC ASMJIT_SOURCE_DIR=/build/python-pytorch/src/pytorch-1.1.0/build/third_party/fbgemm/third_party/asmjit/src ASMJIT_INCLUDE_DIR=/build/python-pytorch/src/pytorch-1.1.0/build/third_party/fbgemm/third_party/asmjit/src ASMJIT_PRIVATE_CFLAGS= -DASMJIT_STATIC -std=c++17 -fno-tree-vectorize -fvisibility=hidden -O2 [RELEASE] -fno-keep-static-consts [RELEASE] -fmerge-all-constants [RELEASE] -- Could NOT find Numa (missing: Numa_INCLUDE_DIR Numa_LIBRARIES) CMake Warning at cmake/Dependencies.cmake:487 (message): Not compiling with NUMA. Suppress this warning with -DUSE_NUMA=OFF Call Stack (most recent call first): CMakeLists.txt:236 (include) -- OpenCV found (/usr/lib64/cmake/opencv4) -- Using third party subdirectory Eigen. Python 3.7.3 -- Found PythonInterp: /usr/bin/python (found suitable version "3.7.3", minimum required is "2.7") -- Found PythonLibs: /usr/lib/libpython3.7m.so.1.0 (found suitable version "3.7.3", minimum required is "2.7") -- Found PythonInterp: /usr/bin/python (found version "3.7.3") -- Found PythonLibs: /usr/lib/libpython3.7m.so.1.0 -- System pybind11 found -- pybind11 include dirs: /usr/include;/usr/include/python3.7m -- Could NOT find MPI_C (missing: MPI_C_LIB_NAMES MPI_C_HEADER_DIR MPI_C_WORKS) -- Could NOT find MPI_CXX (missing: MPI_CXX_LIB_NAMES MPI_CXX_HEADER_DIR MPI_CXX_WORKS) -- Could NOT find MPI (missing: MPI_C_FOUND MPI_CXX_FOUND) CMake Warning at cmake/Dependencies.cmake:714 (message): Not compiling with MPI. Suppress this warning with -DUSE_MPI=OFF Call Stack (most recent call first): CMakeLists.txt:236 (include) -- Adding OpenMP CXX_FLAGS: -fopenmp -- Will link against OpenMP libraries: /usr/lib/libgomp.so;/usr/lib/libpthread.so CMake Warning (dev) at third_party/gloo/CMakeLists.txt:21 (option): Policy CMP0077 is not set: option() honors normal variables. Run "cmake --help-policy CMP0077" for policy details. Use the cmake_policy command to set the policy and suppress this warning. For compatibility with older versions of CMake, option is clearing the normal variable 'BUILD_BENCHMARK'. This warning is for project developers. Use -Wno-dev to suppress it. CMake Warning at cmake/Dependencies.cmake:981 (message): Metal is only used in ios builds. Call Stack (most recent call first): CMakeLists.txt:236 (include) -- -- ******** Summary ******** -- CMake version : 3.14.3 -- CMake command : /usr/bin/cmake -- System : Linux -- C++ compiler : /usr/bin/g++ -- C++ compiler version : 8.3.0 -- CXX flags : -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -D_FORTIFY_SOURCE=2 -fvisibility-inlines-hidden -fopenmp -Wnon-virtual-dtor -- Build type : Release -- Compile definitions : -- CMAKE_PREFIX_PATH : /usr/lib/python3.7/site-packages -- CMAKE_INSTALL_PREFIX : /build/python-pytorch/src/pytorch-1.1.0/torch -- CMAKE_MODULE_PATH : /build/python-pytorch/src/pytorch-1.1.0/cmake/Modules;/usr/share/cmake/pybind11 -- -- ONNX version : 1.5.0 -- ONNX NAMESPACE : onnx_torch -- ONNX_BUILD_TESTS : OFF -- ONNX_BUILD_BENCHMARKS : OFF -- ONNX_USE_LITE_PROTO : OFF -- ONNXIFI_DUMMY_BACKEND : OFF -- ONNXIFI_ENABLE_EXT : OFF -- -- Protobuf compiler : /usr/bin/protoc -- Protobuf includes : /usr/include -- Protobuf libraries : /usr/lib/libprotobuf.so;-lpthread -- BUILD_ONNX_PYTHON : OFF -- -- ******** Summary ******** -- CMake version : 3.14.3 -- CMake command : /usr/bin/cmake -- System : Linux -- C++ compiler : /usr/bin/g++ -- C++ compiler version : 8.3.0 -- CXX flags : -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -D_FORTIFY_SOURCE=2 -fvisibility-inlines-hidden -fopenmp -Wnon-virtual-dtor -- Build type : Release -- Compile definitions : -- CMAKE_PREFIX_PATH : /usr/lib/python3.7/site-packages -- CMAKE_INSTALL_PREFIX : /build/python-pytorch/src/pytorch-1.1.0/torch -- CMAKE_MODULE_PATH : /build/python-pytorch/src/pytorch-1.1.0/cmake/Modules;/usr/share/cmake/pybind11 -- -- ONNX version : 1.4.1 -- ONNX NAMESPACE : onnx_torch -- ONNX_BUILD_TESTS : OFF -- ONNX_BUILD_BENCHMARKS : OFF -- ONNX_USE_LITE_PROTO : OFF -- ONNXIFI_DUMMY_BACKEND : OFF -- -- Protobuf compiler : /usr/bin/protoc -- Protobuf includes : /usr/include -- Protobuf libraries : /usr/lib/libprotobuf.so;-lpthread -- BUILD_ONNX_PYTHON : OFF -- Found gcc >=5 and CUDA <= 7.5, adding workaround C++ flags -- Could not find CUDA with FP16 support, compiling without torch.CudaHalfTensor -- Removing -DNDEBUG from compile flags -- MAGMA not found. Compiling without MAGMA support -- Could not find hardware support for NEON on this machine. -- No OMAP3 processor on this machine. -- No OMAP4 processor on this machine. -- Looking for cpuid.h -- Looking for cpuid.h - found -- Performing Test HAVE_GCC_GET_CPUID -- Performing Test HAVE_GCC_GET_CPUID - Success -- Performing Test NO_GCC_EBX_FPIC_BUG -- Performing Test NO_GCC_EBX_FPIC_BUG - Success -- Performing Test C_HAS_AVX_1 -- Performing Test C_HAS_AVX_1 - Failed -- Performing Test C_HAS_AVX_2 -- Performing Test C_HAS_AVX_2 - Success -- Performing Test C_HAS_AVX2_1 -- Performing Test C_HAS_AVX2_1 - Failed -- Performing Test C_HAS_AVX2_2 -- Performing Test C_HAS_AVX2_2 - Success -- Performing Test CXX_HAS_AVX_1 -- Performing Test CXX_HAS_AVX_1 - Failed -- Performing Test CXX_HAS_AVX_2 -- Performing Test CXX_HAS_AVX_2 - Success -- Performing Test CXX_HAS_AVX2_1 -- Performing Test CXX_HAS_AVX2_1 - Failed -- Performing Test CXX_HAS_AVX2_2 -- Performing Test CXX_HAS_AVX2_2 - Success -- AVX compiler support found -- AVX2 compiler support found -- Performing Test HAS_C11_ATOMICS -- Performing Test HAS_C11_ATOMICS - Success -- Atomics: using C11 intrinsics -- Looking for cheev_ -- Looking for cheev_ - found -- Found a library with LAPACK API (generic). disabling CUDA because NOT USE_CUDA is set -- CuDNN not found. Compiling without CuDNN support disabling ROCM because NOT USE_ROCM is set -- MIOpen not found. Compiling without MIOpen support % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 621 0 621 0 0 1584 0 --:--:-- --:--:-- --:--:-- 1588 100 66.4M 100 66.4M 0 0 19.6M 0 0:00:03 0:00:03 --:--:-- 28.2M Downloaded and unpacked Intel(R) MKL small libraries to /build/python-pytorch/src/pytorch-1.1.0/third_party/ideep/mkl-dnn/external -- This is a product build -- Detecting Intel(R) MKL: trying mklml_intel -- Intel(R) MKL: include /build/python-pytorch/src/pytorch-1.1.0/third_party/ideep/mkl-dnn/external/mklml_lnx_2019.0.3.20190220/include -- Intel(R) MKL: lib /build/python-pytorch/src/pytorch-1.1.0/third_party/ideep/mkl-dnn/external/mklml_lnx_2019.0.3.20190220/lib/libmklml_intel.so -- Found OpenMP_C: -fopenmp -- Found OpenMP_CXX: -fopenmp -- Found OpenMP: TRUE -- OpenMP lib: /build/python-pytorch/src/pytorch-1.1.0/third_party/ideep/mkl-dnn/external/mklml_lnx_2019.0.3.20190220/lib/libiomp5.so -- Could NOT find Doxygen (missing: DOXYGEN_EXECUTABLE) -- VTune profiling environment is unset CMake Warning (dev) at third_party/ideep/mkl-dnn/cmake/utils.cmake:120 (target_link_libraries): Policy CMP0023 is not set: Plain and keyword target_link_libraries signatures cannot be mixed. Run "cmake --help-policy CMP0023" for policy details. Use the cmake_policy command to set the policy and suppress this warning. The plain signature for target_link_libraries has already been used with the target "mkldnn". All uses of target_link_libraries with a target should be either all-keyword or all-plain. The uses of the plain signature are here: * third_party/ideep/mkl-dnn/cmake/utils.cmake:111 (target_link_libraries) Call Stack (most recent call first): third_party/ideep/mkl-dnn/src/CMakeLists.txt:108 (target_link_libraries_install) This warning is for project developers. Use -Wno-dev to suppress it. -- Found MKL-DNN: TRUE -- Looking for clock_gettime in rt -- Looking for clock_gettime in rt - found -- Looking for mmap -- Looking for mmap - found -- Looking for shm_open -- Looking for shm_open - found -- Looking for shm_unlink -- Looking for shm_unlink - found -- Looking for malloc_usable_size -- Looking for malloc_usable_size - found -- Performing Test C_HAS_THREAD -- Performing Test C_HAS_THREAD - Success -- GCC 8.3.0: Adding gcc and gcc_s libs to link line -- don't use NUMA disabling CUDA because USE_CUDA is set false -- Check size of long double -- Check size of long double - done -- Performing Test COMPILER_SUPPORTS_LONG_DOUBLE -- Performing Test COMPILER_SUPPORTS_LONG_DOUBLE - Success -- Performing Test COMPILER_SUPPORTS_FLOAT128 -- Performing Test COMPILER_SUPPORTS_FLOAT128 - Success -- Performing Test COMPILER_SUPPORTS_SSE2 -- Performing Test COMPILER_SUPPORTS_SSE2 - Success -- Performing Test COMPILER_SUPPORTS_SSE4 -- Performing Test COMPILER_SUPPORTS_SSE4 - Success -- Performing Test COMPILER_SUPPORTS_AVX -- Performing Test COMPILER_SUPPORTS_AVX - Success -- Performing Test COMPILER_SUPPORTS_FMA4 -- Performing Test COMPILER_SUPPORTS_FMA4 - Success -- Performing Test COMPILER_SUPPORTS_AVX2 -- Performing Test COMPILER_SUPPORTS_AVX2 - Success -- Performing Test COMPILER_SUPPORTS_SVE -- Performing Test COMPILER_SUPPORTS_SVE - Failed -- Performing Test COMPILER_SUPPORTS_AVX512F -- Performing Test COMPILER_SUPPORTS_AVX512F - Success -- Performing Test COMPILER_SUPPORTS_OPENMP -- Performing Test COMPILER_SUPPORTS_OPENMP - Success -- Performing Test COMPILER_SUPPORTS_WEAK_ALIASES -- Performing Test COMPILER_SUPPORTS_WEAK_ALIASES - Success -- Performing Test COMPILER_SUPPORTS_BUILTIN_MATH -- Performing Test COMPILER_SUPPORTS_BUILTIN_MATH - Success -- Configuring build for SLEEF-v3.2 Target system: Linux-5.0.10-arch1-1-ARCH Target processor: x86_64 Host system: Linux-5.0.10-arch1-1-ARCH Host processor: x86_64 Detected C compiler: GNU @ /usr/bin/gcc -- Using option `-Wall -Wno-unused -Wno-attributes -Wno-unused-result -Wno-psabi -ffp-contract=off -fno-math-errno -fno-trapping-math` to compile libsleef -- Building shared libs : OFF -- MPFR : /usr/lib/libmpfr.so -- MPFR header file in /usr/include -- GMP : /usr/lib/libgmp.so -- RUNNING_ON_TRAVIS : 0 -- COMPILER_SUPPORTS_OPENMP : 1 -- pytorch is compiling with OpenMP. OpenMP CXX_FLAGS: -fopenmp. OpenMP libraries: /usr/lib/libgomp.so;/usr/lib/libpthread.so. -- /usr/bin/g++ /build/python-pytorch/src/pytorch-1.1.0/torch/abi-check.cpp -o /build/python-pytorch/src/pytorch-1.1.0/build/abi-check -- Determined _GLIBCXX_USE_CXX11_ABI=1 -- Performing Test HAS_THREAD_LOCAL -- Performing Test HAS_THREAD_LOCAL - Success -- Could NOT find MPI_C (missing: MPI_C_LIB_NAMES MPI_C_HEADER_DIR MPI_C_WORKS) -- Could NOT find MPI_CXX (missing: MPI_CXX_LIB_NAMES MPI_CXX_HEADER_DIR MPI_CXX_WORKS) -- Could NOT find MPI (missing: MPI_C_FOUND MPI_CXX_FOUND) -- ignoring CUDA -- Building C10D without CUDA support -- Could NOT find MPI_C (missing: MPI_C_LIB_NAMES MPI_C_HEADER_DIR MPI_C_WORKS) -- Could NOT find MPI_CXX (missing: MPI_CXX_LIB_NAMES MPI_CXX_HEADER_DIR MPI_CXX_WORKS) -- Could NOT find MPI (missing: MPI_C_FOUND MPI_CXX_FOUND) -- Not able to find MPI, will compile c10d without MPI support -- NCCL operators skipped due to no CUDA support -- Including IDEEP operators -- Including image processing operators -- Excluding video processing operators due to no opencv -- MPI operators skipped due to no MPI support -- Include Observer library -- Caffe2 is compiling with OpenMP. OpenMP CXX_FLAGS: -fopenmp. OpenMP libraries: /usr/lib/libgomp.so;/usr/lib/libpthread.so. -- Using lib/python3.7/site-packages as python relative installation path CMake Warning at CMakeLists.txt:435 (message): Generated cmake files are only fully tested if one builds with system glog, gflags, and protobuf. Other settings may generate files that are not well tested. CMake Warning at CMakeLists.txt:486 (message): Generated cmake files are only available when building shared libs. -- -- ******** Summary ******** -- General: -- CMake version : 3.14.3 -- CMake command : /usr/bin/cmake -- System : Linux -- C++ compiler : /usr/bin/g++ -- C++ compiler id : GNU -- C++ compiler version : 8.3.0 -- BLAS : MKL -- CXX flags : -march=x86-64 -mtune=generic -O2 -pipe -fno-plt -D_FORTIFY_SOURCE=2 -fvisibility-inlines-hidden -fopenmp -D_FORCE_INLINES -D_MWAITXINTRIN_H_INCLUDED -D__STRICT_ANSI__ -DUSE_FBGEMM -O2 -fPIC -Wno-narrowing -Wall -Wextra -Wno-missing-field-initializers -Wno-type-limits -Wno-array-bounds -Wno-unknown-pragmas -Wno-sign-compare -Wno-unused-parameter -Wno-unused-variable -Wno-unused-function -Wno-unused-result -Wno-strict-overflow -Wno-strict-aliasing -Wno-error=deprecated-declarations -Wno-stringop-overflow -Wno-error=pedantic -Wno-error=redundant-decls -Wno-error=old-style-cast -faligned-new -Wno-unused-but-set-variable -Wno-maybe-uninitialized -fno-math-errno -fno-trapping-math -Wno-stringop-overflow -- Build type : Release -- Compile definitions : ONNX_NAMESPACE=onnx_torch;USE_C11_ATOMICS=1;HAVE_MMAP=1;_FILE_OFFSET_BITS=64;HAVE_SHM_OPEN=1;HAVE_SHM_UNLINK=1;HAVE_MALLOC_USABLE_SIZE=1 -- CMAKE_PREFIX_PATH : /usr/lib/python3.7/site-packages -- CMAKE_INSTALL_PREFIX : /build/python-pytorch/src/pytorch-1.1.0/torch -- -- TORCH_VERSION : 1.1.0 -- CAFFE2_VERSION : 1.1.0 -- BUILD_ATEN_MOBILE : OFF -- BUILD_ATEN_ONLY : OFF -- BUILD_BINARY : True -- BUILD_CUSTOM_PROTOBUF : OFF -- Protobuf compiler : /usr/bin/protoc -- Protobuf includes : /usr/include -- Protobuf libraries : /usr/lib/libprotobuf.so;-lpthread -- BUILD_DOCS : OFF -- BUILD_PYTHON : True -- Python version : 3.7.3 -- Python executable : /usr/bin/python -- Pythonlibs version : 3.7.3 -- Python library : /usr/lib/libpython3.7m.so.1.0 -- Python includes : /usr/include/python3.7m -- Python site-packages: lib/python3.7/site-packages -- BUILD_CAFFE2_OPS : True -- BUILD_SHARED_LIBS : 0 -- BUILD_TEST : True -- USE_ASAN : OFF -- USE_CUDA : False -- USE_ROCM : False -- USE_EIGEN_FOR_BLAS : ON -- USE_FBGEMM : ON -- USE_FFMPEG : False -- USE_GFLAGS : OFF -- USE_GLOG : OFF -- USE_LEVELDB : False -- USE_LITE_PROTO : OFF -- USE_LMDB : False -- USE_METAL : OFF -- USE_MKL : OFF -- USE_MKLDNN : ON -- USE_NCCL : False -- USE_NNPACK : True -- USE_NUMPY : ON -- USE_OBSERVERS : ON -- USE_OPENCL : OFF -- USE_OPENCV : True -- OpenCV version : 4.1.0 -- USE_OPENMP : ON -- USE_PROF : OFF -- USE_QNNPACK : True -- USE_REDIS : OFF -- USE_ROCKSDB : OFF -- USE_ZMQ : OFF -- USE_DISTRIBUTED : True -- USE_MPI : OFF -- USE_GLOO : ON -- USE_GLOO_IBVERBS : OFF -- Public Dependencies : Threads::Threads;caffe2::mkldnn -- Private Dependencies : qnnpack;nnpack;cpuinfo;fbgemm;opencv_core;opencv_highgui;opencv_imgproc;opencv_imgcodecs;opencv_optflow;opencv_videoio;opencv_video;fp16;gloo;aten_op_header_gen;foxi_loader;rt;gcc_s;gcc;dl -- Configuring done CMake Warning at torch/lib/c10d/test/CMakeLists.txt:9 (add_executable): Cannot generate a safe linker search path for target TCPStoreTest because files in some directories may conflict with libraries in implicit directories: link library [libiomp5.so] in /usr/lib may be hidden by files in: /build/python-pytorch/src/pytorch-1.1.0/third_party/ideep/mkl-dnn/external/mklml_lnx_2019.0.3.20190220/lib Some of these libraries may not be found correctly. Call Stack (most recent call first): torch/lib/c10d/test/CMakeLists.txt:17 (c10d_add_test) CMake Warning at torch/lib/c10d/test/CMakeLists.txt:9 (add_executable): Cannot generate a safe linker search path for target ProcessGroupGlooTest because files in some directories may conflict with libraries in implicit directories: link library [libiomp5.so] in /usr/lib may be hidden by files in: /build/python-pytorch/src/pytorch-1.1.0/third_party/ideep/mkl-dnn/external/mklml_lnx_2019.0.3.20190220/lib Some of these libraries may not be found correctly. Call Stack (most recent call first): torch/lib/c10d/test/CMakeLists.txt:26 (c10d_add_test) CMake Warning at torch/lib/c10d/test/CMakeLists.txt:9 (add_executable): Cannot generate a safe linker search path for target FileStoreTest because files in some directories may conflict with libraries in implicit directories: link library [libiomp5.so] in /usr/lib may be hidden by files in: /build/python-pytorch/src/pytorch-1.1.0/third_party/ideep/mkl-dnn/external/mklml_lnx_2019.0.3.20190220/lib Some of these libraries may not be found correctly. Call Stack (most recent call first): torch/lib/c10d/test/CMakeLists.txt:16 (c10d_add_test) CMake Warning at torch/lib/libshm/CMakeLists.txt:32 (ADD_EXECUTABLE): Cannot generate a safe linker search path for target torch_shm_manager because files in some directories may conflict with libraries in implicit directories: link library [libiomp5.so] in /usr/lib may be hidden by files in: /build/python-pytorch/src/pytorch-1.1.0/third_party/ideep/mkl-dnn/external/mklml_lnx_2019.0.3.20190220/lib Some of these libraries may not be found correctly. CMake Warning at torch/lib/libshm/CMakeLists.txt:25 (ADD_LIBRARY): Cannot generate a safe linker search path for target shm because files in some directories may conflict with libraries in implicit directories: link library [libiomp5.so] in /usr/lib may be hidden by files in: /build/python-pytorch/src/pytorch-1.1.0/third_party/ideep/mkl-dnn/external/mklml_lnx_2019.0.3.20190220/lib Some of these libraries may not be found correctly. -- Generating done CMake Warning: Manually-specified variables were not used by the project: THD_SO_VERSION ```
module: build,module: protobuf,triaged
low
Critical
441,224,537
rust
Infinite "recursive requirements" compiler error
When compiling this program, the compiler fails with an infinitely recursive error message. The message makes no sense, as it contains types that aren't even in the program. use std::ops::{Add, Sub}; struct Point2d<T> { pub x: T, pub y: T, } impl<'a, T> Sub<&'a Point2d<T>> for &'a Point2d<T> where &'a T: Sub<&'a T, Output=T>, { type Output = Point2d<T>; fn sub(self, other: &'a Point2d<T>) -> Self::Output { unimplemented!(); } } fn f1<'a, I>(x: &'a I) where &'a I: Sub<Output=I> { unimplemented!(); } fn main() { let a = 123; f1(&a); } This code won't do anything, but it should compile (I think). Instead, the compiler emits an infinite series of error messages like: error[E0275]: overflow evaluating the requirement `&hashbrown::set::HashSet<_, _>: std::ops::Sub` --> src\main.rs:28:5 | 28 | f1(&a); | ^^ | = help: consider adding a `#![recursion_limit="128"]` attribute to your crate = note: required because of the requirements on the impl of `std::ops::Sub` for `&Point2d<hashbrown::set::HashSet<_, _>>` = note: required because of the requirements on the impl of `std::ops::Sub` for `&Point2d<Point2d<hashbrown::set::HashSet<_, _>>>` = note: required because of the requirements on the impl of `std::ops::Sub` for `&Point2d<Point2d<Point2d<hashbrown::set::HashSet<_, _>>>>` = note: required because of the requirements on the impl of `std::ops::Sub` for `&Point2d<Point2d<Point2d<Point2d<hashbrown::set::HashSet<_, _>>>>>` This program doesn't even use HashSet. rustc 1.36.0-nightly (d628c2e64 2019-05-05) binary: rustc commit-hash: d628c2e642c6f8f85f24dd5d7f49de89b95bf682 commit-date: 2019-05-05 host: x86_64-pc-windows-msvc release: 1.36.0-nightly LLVM version: 8.0
E-hard,A-diagnostics,A-trait-system,P-medium,T-compiler,C-bug
low
Critical
441,238,331
rust
CP15 barrier instructions should be emitted before the exclusives loops (arm)
## Symptoms * Rustup hangs (unable to install Rust) * Tracked down to [parking_lot](https://github.com/Amanieu/parking_lot/issues/130) issue * Not just Rust related, [Swift has this problem as well](https://forums.balena.io/t/cloud-build-fails-but-local-device-build-works-on-raspberry-pi-zero/4994) * -> LLVM issue ## Environment * Linux kernel with`CP15_BARRIER_EMULATION=y` * `abi.cp15_barrier` set to `1` (emulate) * `arm-unknown-linux-gnueabihf` toolchain ## CP15 barrier instructions * They're deprecated since `armv7` * Linux kernel can [emulate or HW exec them](https://www.kernel.org/doc/Documentation/arm64/legacy_instructions.txt) * `abi.cp15_barrier` is set to `2` (HW exec) -> there's no issue * The CPU must support them * ARMv8 in our case, which still supports them * `abi.cp15_barrier` is set to `1` (emulate) -> there's this issue ## Issue description `parking_lot` author: > This seems to be closer to an LLVM bug than a parking_lot bug. The source of the problem is the CP15 emulation in the kernel. Essentially the `mcr p15, #0x0, r12, c7, c10, #0x5` is trapping to the kernel every time, which invalidates the exclusive monitor between the `ldrex` and `strex` instructions. This results in the `strex` never succeeding and looping indefinitely. <img width="1184" alt="instructions-loop" src="https://user-images.githubusercontent.com/1084172/57302722-1e997400-70dc-11e9-968c-7f1e8dc0595b.png"> ARM engineer (Will Deacon) response on this: > Hi again, Robert, > > Just a quick update on this: > > 1. CP15 barriers remain deprecated in the Armv8 architecture, and so > may be removed entirely from future CPUs. > > 2. Because of (1), the kernel defaults to trap+emulate, so that it can > warn about the use of these instructions. I think this is the right > thing to do because, once the instructions have been removed, we > will have no choice but to trap+emulate (this happened for the SWP > instruction already). This trapping will prevent your exclusives loop > from ever succeeding. > > 3. The right place to address this issue is in LLVM, where atomic > read-modify-write operations with conditional release semantics (i.e. > release on success) should actually emit the CP15 barrier before the > exclusives loop. Assuming that contention is rare (which it kind of > needs to be for performant compare-and-swap anyway), I don't see this > having a meaningful impact on performance. > > I've reached out to one of our upstream LLVM developers, and I'll be talking > with him face-to-face next week about getting this fixed. > > Will ## Solution Will's third point: > Atomic read-modify-write operations with conditional release semantics (i.e. > release on success) should actually emit the CP15 barrier before the > exclusives loop. Assuming that contention is rare (which it kind of > needs to be for performant compare-and-swap anyway), I don't see this > having a meaningful impact on performance. And: > I've reached out to one of our upstream LLVM developers, and I'll be talking > with him face-to-face next week about getting this fixed. I asked for the LLVM bug # to track it, but still no response. ## Way forward * Fix it on the Rust LLVM fork * Wait for the LLVM to have this fixed and wait till Rust's fork synces Second way can prolong fix by weeks, months, ...? Not sure how fast is the LLVM itself developed & how fast is the Rust's fork syncing. This is the main reason I did report it here as well. ## No fix People aren't / won't be able to use Rust on Linux with `CP15_BARRIER_EMULATION=y` & `abi.cp15_barrier=1` (emulation, default value) & `arm-unknown-linux-gnueabihf` toolchain.
A-LLVM,O-Arm,T-compiler,C-bug,A-atomic
low
Critical
441,257,306
go
testing: parallel benchmark results are poorly documented
The way parallel benchmark results are reported is easy to misinterpret, and the correct way to interpret them is not documented. Typically this makes perfectly-scalable benchmarks appear to perform much worse at low parallelism, and makes not-at-all-scalable benchmarks appear to be doing fine. For example, this came up in https://github.com/golang/go/issues/31820#issuecomment-489112014 Specifically, the "ns/op" reported is not CPU-ns/op, it's wall-ns/op. For example, suppose each op takes exactly 100 ns, regardless of parallelism. If the single-threaded benchmark runs for 1 sec, it will execute 10,000,000 ops, so ns/op = 1s/10,000,000 ops = 100 ns/op. But if the same benchmark runs 4-way parallel for 1 sec, it will execute 40,000,000 ops, so ns/op = 1s/40,000,000 = 25 ns/op. (I really wish it didn't work this way...) Interpreting the results of CPU-bound parallel benchmarks is further complicated by hyper-threading (though this isn't the fault of the testing package). I don't think we can change the reported ns/op at this point. We could perhaps introduce a new metric for parallel benchmarks. At the very least, we should document this.
Documentation,NeedsFix
low
Major
441,275,421
PowerToys
X Clipboard (select to copy, middle click to paste)
Select to copy, middle click to paste
Idea-New PowerToy
high
Critical
441,284,859
godot
Refused connection emits connected_to_server on client
___ ***Bugsquad note:** This issue has been confirmed several times already. No need to confirm it further.* ___ <!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** <!-- Specify commit hash if non-official. --> 3.1.1-mono **OS/device including version:** <!-- Specify GPU model and drivers if graphics-related. --> **Issue description:** <!-- What happened, and what was expected. --> connected_to_server was triggered on client when server refused connection. **Steps to reproduce:** Start server with refuse_new_connections set to true. Connect to connected_to_server on a client and let it connect. Server ignores the connection but the client receives connected_to_server. **Minimal reproduction project:** [CustomMultiplayer.zip](https://github.com/godotengine/godot/files/3155612/CustomMultiplayer.zip)
bug,confirmed,topic:network,topic:multiplayer
medium
Critical
441,338,418
rust
Behavior of panicking Drop::drop is not properly documented
It was decided in, I think, #14875, that `Drop::drop` can panic, and if this happens, the value must be leaked (at least in a generic context), that is, it cannot be re-dropped again and doing that could invoke UB (that's at least what generic unsafe code needs to assume). This does not appear to be documented anywhere. These semantics make the following snippet have undefined behavior due to double-drops ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=8aa124ceb7a72d954497891d29cf4004) uses `T = Vec<HasDrop>`): ```rust let mut a: T; let a_raw = &mut a as *mut T; match std::panic::catch_unwind(|| { // Drop `a` in place: unsafe { std::ptr::drop_in_place(a_raw) }; }) { // For exposition only, if the value isn't leaked, // it will be re-dropped, but one could also try to // explicitly re-drop on drop failure. // UB: this will double-drop some previously dropped fields of a Err(_) => std::mem::drop(a), // If dropping succeeds, leak a Ok(()) => std::mem::forget(a), } ``` To avoid UB, that snippet must be changed to unconditionally leak the value independently of whether `drop_in_place` succeeded or failed: ```rust let mut a: T; let a_raw = &mut *a as *mut T; std::panic::catch_unwind(|| { // Drop `a` in place: unsafe { std::ptr::drop_in_place(a_raw) }; }); // Always leak `a`: if dropping failed, some elements will be leaked, // but there is no way to properly drop them and trying to re-drop // a could invoke UB std::mem::forget(a); ``` --- cc @Centril - this might be a T-lang issue, I don't know the best way to word this, and I can't find any RFC designing this part of the language.
C-enhancement,A-destructors,I-needs-decision,T-lang,A-docs
low
Critical
441,340,629
flutter
[google_maps_flutter][iOS] Override default animate Camera on MarkerTap
<!-- Thank you for using Flutter! If you are looking for support, please check out our documentation or consider asking a question on Stack Overflow: * https://flutter.dev/ * https://api.flutter.dev/ * https://stackoverflow.com/questions/tagged/flutter?sort=frequent If you have found a bug or if our documentation doesn't have an answer to what you're looking for, then fill our the template below. Please read our guide to filing a bug first: https://flutter.dev/docs/resources/bug-reports --> ## Steps to Reproduce <!-- Please tell us exactly how to reproduce the problem you are running into. Please attach a small application (ideally just one main.dart file) that reproduces the problem. You could use https://gist.github.com/ for this. If the problem is with your application's rendering, then please attach a screenshot and explain what the problem is. --> 1. ... Use animateCamera in onTap of marker 2. ... Tap the marker 3. ... Tap it again and again 4. ... There should be no movement, since the camera position is already reached In my case I got a bottom sheet that might fill the half of the screen. Therefore the default behavior that centers the tapped marker does not suit the case. That's why I calculate an offset to center the marker in the upper part of the screen. When taping it again and again (see the screen video) sometimes the usual center animation is started, but then interrupted by the one from my onTap callback. Causing a jump. On Android the camera move is overwritten like expected. Link to Screen Recordings: https://photos.app.goo.gl/7mVYLPZaM4NpuX476 ```dart void _onMarkerClicked(MarkerId markerId, Toilet selectedToilet) { print( 'On Marker for Toilet ${selectedToilet.name} clicked valid=$markerTapValid'); if(!markerTapValid){ return; } final Marker tappedMarker = _markers[markerId]; if (tappedMarker != null) { // Set back old tapped & set new one as tapped setState(() { _resetOldTappedMarker(); _updateTappedMarker(selectedToilet, tappedMarker); }); } _controller.future.then((GoogleMapController controller) { controller.animateCamera(CameraUpdate.newLatLng(LatLng( selectedToilet.latitude - MapUtils.calculateLatitudeOffset(_currentCameraPosition), selectedToilet.longitude - MapUtils.calculateLongitudeOffset(_currentCameraPosition)))); }); // Store selected toilet and update bottom sheet _selectedToilet = selectedToilet; if (_bottomSheetController == null) { print('calling _showBottomSheet'); _showBottomSheet(); } else { print('calling _bottomSheetController.setState'); _bottomSheetController.setState(() {}); } } ``` ## Logs <!-- Run `flutter analyze` and attach any output of that command below. If there are any analysis errors, try resolving them before filing this issue. --> ``` info • Unused import: 'dart:async' • lib/main.dart:1:8 • unused_import info • Name non-constant identifiers using lowerCamelCase • lib/model/Toilet.dart:30:29 • non_constant_identifier_names info • Always override `hashCode` if overriding `==` • lib/model/incident_type.dart:9:17 • hash_and_equals info • This class (or a class which this class inherits from) is marked as '@immutable', but one or more of its instance fields are not final: LegalScreen._markdownData • lib/screens/legal_screen.dart:9:7 • must_be_immutable info • Don't explicitly initialize variables to null • lib/screens/map_screen.dart:35:41 • avoid_init_to_null info • Don't explicitly initialize variables to null • lib/screens/map_screen.dart:36:10 • avoid_init_to_null info • 'fromAsset' is deprecated and shouldn't be used • lib/screens/map_screen.dart:268:31 • deprecated_member_use info • 'fromAsset' is deprecated and shouldn't be used • lib/screens/map_screen.dart:272:31 • deprecated_member_use info • Don't explicitly initialize variables to null • lib/screens/report_incident_screen.dart:21:16 • avoid_init_to_null ``` <!-- Finally, paste the output of running `flutter doctor -v` here. --> ``` [✓] Flutter (Channel stable, v1.2.1, on Mac OS X 10.14.4 18E226, locale de-DE) • Flutter version 1.2.1 at /Users/adrian/Development/flutter • Framework revision 8661d8aecd (3 months ago), 2019-02-14 19:19:53 -0800 • Engine revision 3757390fa4 • Dart version 2.1.2 (build 2.1.2-dev.0.0 0a7dcf17eb) [✓] Android toolchain - develop for Android devices (Android SDK version 28.0.3) • Android SDK at /Users/adrian/Library/Android/sdk • Android NDK at /Users/adrian/Library/Android/sdk/ndk-bundle • Platform android-28, build-tools 28.0.3 • Java binary at: /Applications/Android Studio.app/Contents/jre/jdk/Contents/Home/bin/java • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01) • All Android licenses accepted. [!] iOS toolchain - develop for iOS devices (Xcode 10.2.1) • Xcode at /Applications/Xcode.app/Contents/Developer • Xcode 10.2.1, Build version 10E1001 ✗ Verify that all connected devices have been paired with this computer in Xcode. If all devices have been paired, libimobiledevice and ideviceinstaller may require updating. To update with Brew, run: brew update brew uninstall --ignore-dependencies libimobiledevice brew uninstall --ignore-dependencies usbmuxd brew install --HEAD usbmuxd brew unlink usbmuxd brew link usbmuxd brew install --HEAD libimobiledevice brew install ideviceinstaller • ios-deploy 1.9.4 • CocoaPods version 1.5.3 [✓] Android Studio (version 3.4) • Android Studio at /Applications/Android Studio 3.4.app/Contents • Flutter plugin version 34.0.2 • Dart plugin version 183.5901 • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01) [✓] Android Studio (version 3.4) • Android Studio at /Applications/Android Studio.app/Contents • Flutter plugin version 34.0.2 • Dart plugin version 183.5901 • Java version OpenJDK Runtime Environment (build 1.8.0_152-release-1343-b01) [!] IntelliJ IDEA Ultimate Edition (version 2018.3) • IntelliJ at /Applications/IntelliJ IDEA.app ✗ Flutter plugin not installed; this adds Flutter specific functionality. ✗ Dart plugin not installed; this adds Dart specific functionality. • For information about installing plugins, see https://flutter.io/intellij-setup/#installing-the-plugins [✓] Connected device (3 available) • SM T580 • 52003158e2231509 • android-arm • Android 8.1.0 (API 27) • Android SDK built for x86 • emulator-5554 • android-x86 • Android 9 (API 28) (emulator) • iPhone Xʀ • 4F39F049-E21A-4749-AA57-FA51D1CB133C • ios • com.apple.CoreSimulator.SimRuntime.iOS-12-2 (simulator) ```
platform-ios,p: maps,package,c: proposal,P3,team-ios,triaged-ios
low
Critical
441,346,944
TypeScript
`any` appears to shortcircut structural type checking
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.5.0-dev.20190507 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** any, unsound, extends, never **Code** ```ts // I detect if F is `any` by checking if F extends `never`. // (F extends never ? true : false) produces `true|false` for `F = any` // and `false` or `never` for everything else. type Decider<F> = { prop: (F extends never ? true : false) extends false ? "isNotAny" : "isAny"; }; let foo!: Decider<string>; let bar: Decider<any> = foo; let fooProp: "isNotAny" = foo.prop; let barProp: "isAny" = bar.prop; ``` **Expected behavior:** Either `bar.prop` should have the type `"isAny"|"isNotAny"` or `foo` should not be assignable to `bar`. **Actual behavior:** `foo` is assignable to `bar` and `bar.prop` has the type `"isAny"` which is incompatible with `foo.prop`'s `"isNotAny"`. **Playground Link:** [link](https://www.typescriptlang.org/play/#src=%2F%2F%20I%20detect%20if%20F%20is%20%60any%60%20by%20checking%20if%20F%20extends%20%60never%60.%0D%0A%2F%2F%20(F%20extends%20never%20%3F%20true%20%3A%20false)%20produces%20%60true%7Cfalse%60%20for%20%60F%20%3D%20any%60%0D%0A%2F%2F%20and%20%60false%60%20or%20%60never%60%20for%20everything%20else.%0D%0Atype%20Decider%3CF%3E%20%3D%20%7B%0D%0A%09prop%3A%20(F%20extends%20never%20%3F%20true%20%3A%20false)%20extends%20false%20%3F%20%22isNotAny%22%20%3A%20%22isAny%22%3B%0D%0A%7D%3B%0D%0A%0D%0Alet%20foo!%3A%20Decider%3Cstring%3E%3B%0D%0Alet%20bar%3A%20Decider%3Cany%3E%20%3D%20foo%3B%0D%0A%0D%0Alet%20fooProp%3A%20%22isNotAny%22%20%3D%20foo.prop%3B%0D%0Alet%20barProp%3A%20%22isAny%22%20%3D%20bar.prop%3B)
Bug,Domain: Conditional Types,Domain: Variance Relationships
low
Critical
441,356,590
TypeScript
API: expose isReadonlySymbol
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section. --> ## Search Terms readonly symbol property ## Suggestion Expose `isReadonlySymbol` as a method on `TypeChecker`. Currently there's no way to tell for sure if a property is readonly. While cumbersome userland implementations can check for `readonly` modifier in `Symbol.declarations`, if it's a GetAccessor without corresponding SetAccessor or if it originated in `Object.definePropery(this, 'propName', {value, writable: false})`. However, there's one more thing: `Readonly` mapped type only sets `Symbol.checkFlags` which is internal. So at the very least I need an API to tell if a property's symbol comes from a mapped type with a `readonly` modifier. /cc @CSchulz you probably need the same API for the lint rule you want to develop.
Suggestion,In Discussion,API
low
Critical
441,358,685
flutter
debugPaint is broken
If you open the gallery app the debug paint output obscures the entire app: <img width="1192" alt="Screen Shot 2019-04-23 at 8 38 37 PM" src="https://user-images.githubusercontent.com/211513/56631846-dffbb800-660b-11e9-850c-649b13758134.png"> /cc @jacob314 in case you have more info to share
framework,f: inspector,platform-web,P3,team-web,triaged-web
low
Critical
441,359,569
flutter
[Android Web] TalkBack does not read out value changes on increase/decrease. Ex: RangeSlider
TalkBack does not read out value changes on increase/decrease. iOS and Safari correctly read out the announcement.
platform-android,framework,a: accessibility,platform-web,has reproducible steps,P2,found in release: 3.3,found in release: 3.6,team-framework,triaged-framework
low
Minor
441,360,511
flutter
Add support for fontFamilyFallback in ParagraphStyle and TextStyle
See https://docs.flutter.io/flutter/painting/TextStyle/fontFamilyFallback.html
c: new feature,framework,a: typography,platform-web,e: web_html,P3,team-web,triaged-web
low
Minor
441,360,688
flutter
drawLine paint bounds are overestimated
See screenshot test: ![paint_bounds_for_line_rotated](https://user-images.githubusercontent.com/211513/56527070-f87fab80-6501-11e9-89c1-8207469f5357.png) See also this TODO: https://github.com/flutter/flutter_web/blob/dcc5b18ee643631cd3c86e3004c380576dfd9c67/packages/flutter_web_ui/lib/src/recording_canvas.dart#L172
engine,c: performance,platform-web,P3,team-web,triaged-web
low
Minor
441,361,084
flutter
TextPainter - forced line-wrapping with bidi in text_painter_rtl_test failing
We are skipping these tests right now.
a: tests,framework,a: internationalization,a: typography,platform-web,P3,team-web,triaged-web
low
Minor
441,363,612
flutter
[Web] Content is missing and misaligned when printing
**Describe the bug** There are multiple issues when attempting to print from the web browser: - All elements are missing on Safari - Canvas elements are missing on Chrome - Content is not centered on Chrome **To Reproduce** ``` import 'package:flutter_web/material.dart'; void main() => runApp(MyApp()); class MyApp extends StatelessWidget { @override Widget build(BuildContext context) { return MaterialApp( home: Scaffold( body: Container( color: Colors.white, alignment: Alignment.center, child: Container( height: 100, width: 100, child: Container( color: Colors.black, alignment: Alignment.center, child: Text('Hello world', style: TextStyle(color: Colors.white)), ), ), ), ), ); } } ``` **Expected behavior** Printing should behave similarly to traditional HTML web pages. **Screenshots** # Page <img width="494" alt="page" src="https://user-images.githubusercontent.com/2292792/55832861-7a281000-5ae4-11e9-88f0-f85833ea1309.png"> # Chrome ![chrome](https://user-images.githubusercontent.com/2292792/55832875-814f1e00-5ae4-11e9-92d1-ff508f3fcb05.png) # Safari ![safari](https://user-images.githubusercontent.com/2292792/55832570-d9395500-5ae3-11e9-859b-3ba3376bb401.png) **Desktop (please complete the following information):** - OS: mac - Browser chrome 73.0.3683.86, safari 12.0.3 - Dart Version 2.2.1 - Flutter Web commit SHA f9288f36fed5f3fda825082ac80f46eec6e7f62f
c: new feature,framework,a: fidelity,platform-web,P3,team-web,triaged-web
medium
Critical
441,393,733
angular
Location shim causes repeat hash in hash-based navigation
When using the `useHash` option for `$locationShim`, routing works until refreshing the browser, at which point the hash appears to be duplicated in the URL. Refreshing again continues to append the hash repeatedly. Repro: https://github.com/brandonroberts/phonecat-upgrade-cli/tree/840035fcc41d75bbf7b75a494ff40db98f878e7a
type: bug/fix,freq2: medium,area: router,state: confirmed,P3
low
Minor
441,429,786
PowerToys
Moving a program with you to another virtual desktop
One of the thing I've found lacking ever since I started using the virtual desktops is the ability to move a window with you while moving to another virtual desktop. Currently, we can move to another desktop using the shortcut `ctrl + win + left/right`, I feel like a shortcut along the lines of `ctrl + win + alt + left/right` could be used to make the current active window move with you to the next desktop I have no idea if this fits as a powertoy, please tell me if it doesn't !
Idea-New PowerToy,Product-Virtual Desktop
high
Critical
441,429,915
pytorch
ProcessGroupMPI tests in test_c10d.py
These are not in place yet due to the non trivial work required to launch an MPI test. Go through the test cases in `test_c10d.py` and evaluate where we need to add tests that use `ProcessGroupMPI`. Also figure out where refactoring is needed to support this. There is an opportunity to consolidate the multi process test harness in `MultiProcessTestCase` between `test_c10d.py` and `test_distributed.py` and make it work for both MPI and non-MPI tests.
oncall: distributed,module: tests,triaged
low
Minor
441,455,044
terminal
Support Right to Left (RTL) text
* What you're doing and what's happening: When writing some right-to-left characters (Farsi, Arabic, ...) after some left-to-right characters, the rtl text goes from the cursor position into the left, causing it to be mixed with the ltr text written before. * Steps to reproduce: Open a Windows Terminal window. write some english characters, like `abcdef`. Then write some Farsi/Arabic text, like: سلام Notice that the Farsi text goes inside the english text. * Screenshot: ![image](https://user-images.githubusercontent.com/1775637/57334402-e2463200-7134-11e9-8fc7-656d25e2226d.png) * what should be happening instead: As console is generally left to right, the rtl text should begin more on the right (cursor should go to right), and it should end exactly when the ltr text ended. See how Notepad (correctly) handles this situation: ![image](https://user-images.githubusercontent.com/1775637/57463000-2ea58500-728f-11e9-8414-21807c52b8a5.png) * Windows build number: 10.0.18362.86
Issue-Feature,Help Wanted,Area-Rendering,Product-Terminal
medium
Critical
441,458,453
terminal
Feature Request: Ctrl-Drag anywhere on the terminal window to move the window
Moving the terminal window around is tricky, particularly when `experimental_showTabsInTitlebar` is enabled. Many unix terminals (and some Windows console replacements) allow Ctrl-LeftDrag operations on the window to map to a window drag instead. Would love to see this added to Windows Terminal as well!
Issue-Feature,Area-UserInterface,Product-Terminal
low
Major
441,473,979
pytorch
Sparse tensors can't be used in DataLoader running many workers
## 🐛 Bug <!-- A clear and concise description of what the bug is. --> Sparse tensors can't be used in DataLoader running many workers ## To Reproduce Steps to reproduce the behavior: <!-- If you have a code sample, error messages, stack traces, please provide it here as well --> ```python import torch.utils.data as D from scipy.sparse import csr_matrix import numpy as np import torch row = np.array([0, 3, 0, 7]) col = np.array([0, 3, 1, 9]) data = np.array([4, 5, 7, 9]) # using CSR matrix as can be row indexed sparse = csr_matrix((data, (row, col)), shape=(8, 10)) class Dataset(D.Dataset): def __init__(self, sparse): self.data = sparse def __len__(self): return self.data.shape[0] def __getitem__(self, index): # convert it to COO so to get the atributes to create a sparse tensor data = self.data[index].tocoo() i = torch.LongTensor(np.vstack((data.row, data.col))) v = torch.FloatTensor(data.data) data = torch.sparse.FloatTensor(i, v, torch.Size(data.shape)) return data d = Dataset(sparse) loader = torch.utils.data.DataLoader(d, batch_size=2, num_workers=2) for i in loader: print(i) ``` ``` RuntimeError: Traceback (most recent call last): File "/Users/efelix/miniconda3/envs/release3.7/lib/python3.6/site-packages/torch/utils/data/_utils/worker.py", line 99, in _worker_loop samples = collate_fn([dataset[i] for i in batch_indices]) File "/Users/efelix/miniconda3/envs/release3.7/lib/python3.6/site-packages/torch/utils/data/_utils/collate.py", line 41, in default_collate storage = batch[0].storage()._new_shared(numel) RuntimeError: sparse tensors do not have storage ``` ## Expected behavior The same one that I have when not setting n_workers parameter. ```python loader = torch.utils.data.DataLoader(d, batch_size=2) for i in loader: print(i) ``` ``` tensor(indices=tensor([[0, 0], [0, 0], [0, 1]]), values=tensor([4., 7.]), size=(2, 1, 10), nnz=2, layout=torch.sparse_coo) tensor(indices=tensor([[1], [0], [3]]), values=tensor([5.]), size=(2, 1, 10), nnz=1, layout=torch.sparse_coo) tensor(indices=tensor([], size=(3, 0)), values=tensor([], size=(0,)), size=(2, 1, 10), nnz=0, layout=torch.sparse_coo) tensor(indices=tensor([[1], [0], [9]]), values=tensor([9.]), size=(2, 1, 10), nnz=1, layout=torch.sparse_coo) ``` <!-- A clear and concise description of what you expected to happen. --> ## Environment PyTorch version: 1.1.0 Is debug build: No CUDA used to build PyTorch: None OS: Mac OSX 10.14.4 GCC version: Could not collect CMake version: version 3.14.3 Python version: 3.6 Is CUDA available: No CUDA runtime version: No CUDA GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA Versions of relevant libraries: [pip3] numpy==1.16.3 [conda] blas 1.0 mkl [conda] mkl 2019.1 144 [conda] mkl-service 1.1.2 py36hfbe908c_5 [conda] mkl_fft 1.0.10 py36h5e564d8_0 [conda] mkl_random 1.0.2 py36h27c97d8_0 [conda] pytorch 1.1.0 py3.6_0 pytorch [conda] torchvision 0.2.2.post3 pypi_0 pypi ## Additional context <!-- Add any other context about the problem here. -->
module: sparse,module: multiprocessing,feature,triaged
medium
Critical
441,475,211
rust
powerpc64: allow querying ELF ABI version
There are two ABIs on ppc64, ELFv1 (legacy) and ELFv2 (introduced a couple years back, used by default for little endian). Rust currently has logic in it that for the `musl` libc, ELFv2 is used on big endian and ELFv1 is used otherwise. This is inadequate, as you can use ELFv2 as well with `glibc`. In my distribution, both little and big endian systems are supported, with `glibc` and `musl`, and they are all set up for ELFv2. In order to achieve that, Rust in the distribution is patched so that it will always properly use ELFv2 ABI. However, this is a potential problem for some crates that for example need to deal with assembly code; they have no way to query the ABI version. For endianness, they can do like `#[cfg(target_endian = "big")]`. For ABI, there is no equivalent (in C, you can do `#if _CALL_ELF == 2`). I can look into implementing this, but I need to know what would be the best syntax and way to implement this. As I see it, it would need a new field in the target options, but this would of course be specific to ppc64, and ABI on ppc64 in e.g. gcc is treated more like a list than a string (you can also have `-mabi=altivec`, `-mabi=ibmlongdouble` and so on, in addition to `-mabi=elfv2`), so I was wondering if something more generic/extensible would be better. Of course, eventually it'd be best to also allow setting it when compiling, and make it properly pass everything down to llvm, but that's less of a concern, for now I just need crates to be able to read it.
T-lang,O-PowerPC
low
Major
441,486,396
create-react-app
Syntax error appears twice in console
1. Create a new project 2. Make a syntax error The terminal is fine but the console reports the same error twice: <img width="838" alt="Screen Shot 2019-05-08 at 00 23 36" src="https://user-images.githubusercontent.com/810438/57339054-cbe5a980-7127-11e9-9ee8-e843d2de25ec.png">
issue: bug
low
Critical
441,535,260
TypeScript
Error in module-plugin.d.ts template
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.4.5 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** module-plugin.d.ts template Module Plugin or UMD Plugin Cannot augment module 'jquery' because it resolves to a non-module entity. **Code** ```ts // This is a copy from https://www.typescriptlang.org/docs/handbook/declaration-files/templates/module-plugin-d-ts.html // Put this file in node_modules/@types/jquery-plugin/index.d.ts // will get an error: // Cannot augment module 'jquery' because it resolves to a non-module entity. // Type definitions for [~THE LIBRARY NAME~] [~OPTIONAL VERSION NUMBER~] // Project: [~THE PROJECT NAME~] // Definitions by: [~YOUR NAME~] <[~A URL FOR YOU~]> /*~ This is the module plugin template file. You should rename it to index.d.ts *~ and place it in a folder with the same name as the module. *~ For example, if you were writing a file for "super-greeter", this *~ file should be 'super-greeter/index.d.ts' */ /*~ On this line, import the module which this module adds to */ import * as m from 'jquery'; /*~ Here, declare the same module as the one you imported above */ declare module 'jquery' { /*~ Inside, add new function, classes, or variables. You can use *~ unexported types from the original module if needed. */ export function theNewMethod(): string; /*~ You can also add new properties to existing interfaces from *~ the original module by writing interface augmentations */ export interface SomeModuleOptions { someModuleSetting?: string; } /*~ New types can also be declared and will appear as if they *~ are in the original module */ export interface MyModulePluginOptions { size: number; } } ``` **Expected behavior:** No errors and have code hint for this plugin **Actual behavior:** Have errors **Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior --> **Related Issues:** <!-- Did you find other bugs that looked similar? -->
Docs
low
Critical
441,535,296
go
cmd/compile: suboptimal assembly for a + b + 1
```go package p func f(a, b uint64) uint64 { return a + b + 1 } ``` On amd64, this assembles to: ``` "".f STEXT nosplit size=24 args=0x18 locals=0x0 0x0000 00000 (x.go:4) MOVQ "".a+8(SP), AX 0x0005 00005 (x.go:4) MOVQ "".b+16(SP), CX 0x000a 00010 (x.go:4) LEAQ (CX)(AX*1), AX 0x000e 00014 (x.go:4) LEAQ 1(AX), AX 0x0012 00018 (x.go:4) MOVQ AX, "".~r2+24(SP) 0x0017 00023 (x.go:4) RET ``` I believe the two LEAQs should instead be `ADDQ CX, AX`, `INC AX`. This would be six bytes of instructions instead of 8. I need to double-check, but I believe that this happens because we optimize `a + b + const` to `LEAQ const(a)(b*1), dst`, but then break apart the three-part LEAQ. We can't fix this when lowering to instructions, because LEAQ doesn't clobber flags and ADD and INC do. So we need to somehow catch this in the rewrite rules. I wonder whether we should reconsider the previous strategy of breaking apart "slow" LEAQs at the last minute (for https://github.com/golang/go/issues/21735). cc @martisch @randall77
Performance,NeedsInvestigation,compiler/runtime
low
Major
441,562,744
flutter
Flutter on iOS should support semantic autofilling of text fields
See https://github.com/flutter/flutter/issues/32265 for some context We currently support password autofill, but not as nicely as we could. In a native iOS app, autofill works if there's a password box anywhere on the screen. After a bug fix for the linked issue, we only support it if the box has focus. We also only support passwords right now, but could be supporting other types of auto filled input (like user names, emails, etc.). On issue with fixing this is that the framework currently increments the client id for a text input on each attach - and the engine has no knowledge of whether that client ID is for a new or existing text editing state. The framework also does not pass semantic information for the type of text entry wanted (beyond keyboard types anyway). Another issue is that the engine reuses the backing fields that the OS can interact with for autofilling for multiple fields. It would need to have a way to track (and free) those backing objects per text field on the framework side.
a: text input,c: new feature,platform-ios,framework,engine,a: fidelity,P2,team-ios,triaged-ios
low
Critical
441,569,890
TypeScript
Unable to add generic function overload for module default export
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.5.0-dev.20190508 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** module add overload **Code** ```ts // nanohtml.d.ts export default function<T extends HTMLElement = HTMLElement>(strings: TemplateStringsArray, ...keys: any[]): T; ``` ```js // @ts-check // index.js // install [email protected] const nanohtml = require("nanohtml"); /** @type {HTMLAnchorElement} */ const a = nanohtml`<a href="example.com">Example</a>`; ``` **Expected behavior:** `a` should be `HTMLAnchorElement`. **Actual behavior:** Error: Type 'HTMLElement' is missing the following properties from type 'HTMLAnchorElement': ...
Bug,Domain: JSDoc,checkJs,Domain: Type Inference
low
Critical
441,598,795
puppeteer
Can't use getDisplayMedia (and then start recording) in headless mode
<!-- STEP 1: Are you in the right place? - For general technical questions or "how to" guidance, please search StackOverflow for questions tagged "puppeteer" or create a new post. https://stackoverflow.com/questions/tagged/puppeteer - For issues or feature requests related to the DevTools Protocol (https://chromedevtools.github.io/devtools-protocol/), file an issue there: https://github.com/ChromeDevTools/devtools-protocol/issues/new. - Problem in Headless Chrome? File an issue against Chromium's issue tracker: https://bugs.chromium.org/p/chromium/issues/entry?components=Internals%3EHeadless&blocking=705916 For issues, feature requests, or setup troubles with Puppeteer, file an issue right here! --> ### Steps to reproduce **Tell us about your environment:** * Puppeteer version: 1.15.0 * Platform / OS version: Ubuntu 16.04 * URLs (if applicable): * Node.js version: v10.15.3 **What steps will reproduce the problem?** _Please include code that reproduces the issue._ 1. Run the following code, set headless to `true` or `false` and see the difference. ``` const puppeteer = require('puppeteer') ;(async () => { const url = 'https://www.google.com' const browser = await puppeteer.launch({ headless: false, args: [ `--window-size=1920,1080`, '--enable-experimental-web-platform-features', '--disable-infobars', '--enable-usermedia-screen-capturing', '--allow-http-screen-capture', '--auto-select-desktop-capture-source=webclip', '--ignore-certificate-errors', '--unsafely-treat-insecure-origin-as-secure=' + url ] }); const page = await browser.newPage() await page.setViewport({ width: 1920, height: 1080, }) await page.goto(url) page.evaluate(async () => { document.title = 'webclip' const stream = await navigator.mediaDevices.getDisplayMedia({ video: true }) const recorder = new window.MediaRecorder(stream, { mimeType: 'video/webm' }) recorder.start(10) const chunks = [] recorder.addEventListener('dataavailable', event => { if (event.data && event.data.size) { chunks.push(event.data) } }) }) })() ``` **What is the expected result?** Maybe it should start recording (I don't know whether this behavior is intended and I haven't found percisely related information). **What happens instead?** Throw exceptions.
feature,confirmed
medium
Critical
441,641,579
vue
this.$nextTick don't work fine in (android 5.1.1)android webview 55.0.2883.91.
### Version 2.6.10 ### Reproduction link [https://codesandbox.io/embed/k36zj3z5o7](https://codesandbox.io/embed/k36zj3z5o7) ### Browser info android 5.1.1 android system webview 55.0.2883.91. ### Steps to reproduce input phone number more than 3. ### What is expected? when i input phone number more than 3 ,the position of cursor will be the last . ### What is actually happening? when i input phone number more than 3 ,the position of cursor is not on the last.I suppose the reason is the bug of microtask in this version of android webview. <!-- generated by vue-issues. DO NOT REMOVE -->
need repro,browser quirks
low
Critical
441,673,093
PowerToys
Shortcuts for numbered virtual desktops
Desktops are already numbered, would be useful to have some sort of indicator of the current desktop number in the taskbar and to add a shortcut to jump between desktops, something like WinKey + Ctrl + 1..9 to go to desktop 1... all the way to 9
Idea-New PowerToy,Product-Virtual Desktop
high
Critical
441,678,321
go
internal/poll: transparently support new linux io_uring interface
A document on the latest linux IO syscall has made the rounds of discussion forums on the internet: http://kernel.dk/io_uring.pdf I wanted to open a discussion on whether we could (and should) add transparent support for this on supported linux kernels. LWN article: https://lwn.net/Articles/776703/
OS-Linux,NeedsInvestigation,compiler/runtime
high
Critical
441,689,935
pytorch
[Caffe2] Convert caffe to caffe2 with solverstate
Can I convert a caffemodel and a solverstate file to caffe2 training file? I have used below code to convert caffemodel, but it only convert the weight. I want to get the momentum information which is in solverstate. `python -m caffe2.python.caffe_translator XXX.prototxt XXX.caffemodel`
caffe2
low
Minor
441,703,211
flutter
flutter channel command output
## Use case When Dart 2.3 was announced I started to use it on flutter master channel because I really needed that. After some while, I needed to go back to the stable channel that didn't support Dart 2.3 at that time. So every time that I would like to know if Dart 2.3 was already on the stable channel, I had to change the channel to stable, upgrade it, and see my project breaks because Dart 2.3 was missing, and then go back to master channel. ## Proposal The output of `flutter channel` command could be a table showing the version numbers and details of each channel instead of a list of names
c: new feature,tool,P3,team-tool,triaged-tool
low
Minor
441,713,265
go
runtime: no examples for LockOSThread and UnlockOSThread
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version </pre> ### Does this issue reproduce with the latest release? ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env </pre></details> ### What did you do? <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> ### What did you expect to see? ### What did you see instead?
Documentation,help wanted,NeedsInvestigation,compiler/runtime
low
Critical
441,748,473
node
investigate flaky test-cpu-prof
https://ci.nodejs.org/job/node-test-commit-freebsd/26122/nodes=freebsd11-x64/console test-digitalocean-freebsd11-x64-2 <details> ```console 00:15:35 not ok 2553 sequential/test-cpu-prof 00:15:35 --- 00:15:35 duration_ms: 2.101 00:15:35 severity: fail 00:15:35 exitcode: 1 00:15:35 stack: |- 00:15:35 Dispatching message { "id": 1, "method": "Profiler.enable" } 00:15:35 Receive CPU profile message, ending = false 00:15:35 Dispatching message { "id": 2, "method": "Profiler.start" } 00:15:35 Receive CPU profile message, ending = false 00:15:35 Dispatching message { "id": 3, "method": "Profiler.setSamplingInterval", "params": { "interval": 50 } } 00:15:35 Receive CPU profile message, ending = false 00:15:35 Dispatching message { "id": 1, "method": "Profiler.enable" } 00:15:35 Receive CPU profile message, ending = false 00:15:35 Dispatching message { "id": 2, "method": "Profiler.start" } 00:15:35 Receive CPU profile message, ending = false 00:15:35 Dispatching message { "id": 3, "method": "Profiler.setSamplingInterval", "params": { "interval": 50 } } 00:15:35 Receive CPU profile message, ending = false 00:15:35 EndStartedProfilers 00:15:35 Ending cpu profiling 00:15:35 Dispatching message { "id": 4, "method": "Profiler.stop" } 00:15:35 Receive CPU profile message, ending = true 00:15:35 Written result to prof/CPU.20190508.071535.5764.1.002.cpuprofile 00:15:35 EndStartedProfilers 00:15:35 Ending cpu profiling 00:15:35 Dispatching message { "id": 4, "method": "Profiler.stop" } 00:15:35 Receive CPU profile message, ending = true 00:15:35 Written result to prof/CPU.20190508.071535.5764.0.001.cpuprofile 00:15:35 00:15:35 CPU path: /usr/home/iojs/node-tmp/.tmp.0/prof/CPU.20190508.071535.5764.0.001.cpuprofile 00:15:35 [ 00:15:35 { 00:15:35 id: 1, 00:15:35 callFrame: { 00:15:35 functionName: '(root)', 00:15:35 scriptId: '0', 00:15:35 url: '', 00:15:35 lineNumber: -1, 00:15:35 columnNumber: -1 00:15:35 }, 00:15:35 hitCount: 0, 00:15:35 children: [ 2, 3, 5, 25, 55, 58 ] 00:15:35 }, 00:15:35 { 00:15:35 id: 2, 00:15:35 callFrame: { 00:15:35 functionName: '(program)', 00:15:35 scriptId: '0', 00:15:35 url: '', 00:15:35 lineNumber: -1, 00:15:35 columnNumber: -1 00:15:35 }, 00:15:35 hitCount: 9 00:15:35 }, 00:15:35 { 00:15:35 id: 3, 00:15:35 callFrame: { 00:15:35 functionName: '', 00:15:35 scriptId: '7', 00:15:35 url: 'internal/bootstrap/loaders.js', 00:15:35 lineNumber: 0, 00:15:35 columnNumber: 0 00:15:35 }, 00:15:35 hitCount: 0, 00:15:35 children: [ 4 ] 00:15:35 }, 00:15:35 { 00:15:35 id: 4, 00:15:35 callFrame: { 00:15:35 functionName: 'internalBinding', 00:15:35 scriptId: '7', 00:15:35 url: 'internal/bootstrap/loaders.js', 00:15:35 lineNumber: 127, 00:15:35 columnNumber: 44 00:15:35 }, 00:15:35 hitCount: 1, 00:15:35 positionTicks: [ [Object] ] 00:15:35 }, 00:15:35 { 00:15:35 id: 5, 00:15:35 callFrame: { 00:15:35 functionName: '', 00:15:35 scriptId: '8', 00:15:35 url: 'internal/bootstrap/node.js', 00:15:35 lineNumber: 0, 00:15:35 columnNumber: 0 00:15:35 }, 00:15:35 hitCount: 4, 00:15:35 children: [ 6, 15, 23 ], 00:15:35 positionTicks: [ [Object], [Object], [Object], [Object] ] 00:15:35 }, 00:15:35 { 00:15:35 id: 6, 00:15:35 callFrame: { 00:15:35 functionName: 'nativeModuleRequire', 00:15:35 scriptId: '7', 00:15:35 url: 'internal/bootstrap/loaders.js', 00:15:35 lineNumber: 182, 00:15:35 columnNumber: 28 00:15:35 }, 00:15:35 hitCount: 0, 00:15:35 children: [ 7 ] 00:15:35 }, 00:15:35 { 00:15:35 id: 7, 00:15:35 callFrame: { 00:15:35 functionName: 'NativeModule.compile', 00:15:35 scriptId: '7', 00:15:35 url: 'internal/bootstrap/loaders.js', 00:15:35 lineNumber: 286, 00:15:35 columnNumber: 41 00:15:35 }, 00:15:35 hitCount: 3, 00:15:35 children: [ 8, 24 ], 00:15:35 positionTicks: [ [Object] ] 00:15:35 }, 00:15:35 { 00:15:35 id: 8, 00:15:35 callFrame: { 00:15:35 functionName: '', 00:15:35 scriptId: '9', 00:15:35 url: 'internal/util.js', 00:15:35 lineNumber: 0, 00:15:35 columnNumber: 0 00:15:35 }, 00:15:35 hitCount: 0, 00:15:35 children: [ 9, 14 ] 00:15:35 }, 00:15:35 { 00:15:35 id: 9, 00:15:35 callFrame: { 00:15:35 functionName: 'nativeModuleRequire', 00:15:35 scriptId: '7', 00:15:35 url: 'internal/bootstrap/loaders.js', 00:15:35 lineNumber: 182, 00:15:35 columnNumber: 28 00:15:35 }, 00:15:35 hitCount: 0, 00:15:35 children: [ 10 ] 00:15:35 }, 00:15:35 { 00:15:35 id: 10, 00:15:35 callFrame: { 00:15:35 functionName: 'NativeModule.compile', 00:15:35 scriptId: '7', 00:15:35 url: 'internal/bootstrap/loaders.js', 00:15:35 lineNumber: 286, 00:15:35 columnNumber: 41 00:15:35 }, 00:15:35 hitCount: 1, 00:15:35 children: [ 11 ], 00:15:35 positionTicks: [ [Object] ] 00:15:35 }, 00:15:35 { 00:15:35 id: 11, 00:15:35 callFrame: { 00:15:35 functionName: '', 00:15:35 scriptId: '10', 00:15:35 url: 'internal/errors.js', 00:15:35 lineNumber: 0, 00:15:35 columnNumber: 0 00:15:35 }, 00:15:35 hitCount: 0, 00:15:35 children: [ 12 ] 00:15:35 }, 00:15:35 { 00:15:35 id: 12, 00:15:35 callFrame: { 00:15:35 functionName: 'E', 00:15:35 scriptId: '10', 00:15:35 url: 'internal/errors.js', 00:15:35 lineNumber: 250, 00:15:36 columnNumber: 10 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 13 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 13, 00:15:36 callFrame: { 00:15:36 functionName: 'makeNodeErrorWithCode', 00:15:36 scriptId: '10', 00:15:36 url: 'internal/errors.js', 00:15:36 lineNumber: 164, 00:15:36 columnNumber: 30 00:15:36 }, 00:15:36 hitCount: 2, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 14, 00:15:36 callFrame: { 00:15:36 functionName: 'internalBinding', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 127, 00:15:36 columnNumber: 44 00:15:36 }, 00:15:36 hitCount: 2, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 24, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '21', 00:15:36 url: 'internal/async_hooks.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 15, 00:15:36 callFrame: { 00:15:36 functionName: 'setupBuffer', 00:15:36 scriptId: '8', 00:15:36 url: 'internal/bootstrap/node.js', 00:15:36 lineNumber: 376, 00:15:36 columnNumber: 20 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 16 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 16, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 17 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 17, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 18 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 18, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '12', 00:15:36 url: 'buffer.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 19, 22 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 19, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 20 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 20, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 2, 00:15:36 children: [ 21 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 21, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '14', 00:15:36 url: 'internal/util/inspect.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 22, 00:15:36 callFrame: { 00:15:36 functionName: 'createPool', 00:15:36 scriptId: '12', 00:15:36 url: 'buffer.js', 00:15:36 lineNumber: 120, 00:15:36 columnNumber: 19 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 23, 00:15:36 callFrame: { 00:15:36 functionName: 'wrapPosixCredentialSetters', 00:15:36 scriptId: '19', 00:15:36 url: 'internal/process/main_thread_only.js', 00:15:36 lineNumber: 53, 00:15:36 columnNumber: 35 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 25, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '40', 00:15:36 url: 'internal/main/run_main_module.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 26, 27 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 26, 00:15:36 callFrame: { 00:15:36 functionName: 'prepareMainThreadExecution', 00:15:36 scriptId: '41', 00:15:36 url: 'internal/bootstrap/pre_execution.js', 00:15:36 lineNumber: 7, 00:15:36 columnNumber: 35 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 27, 00:15:36 callFrame: { 00:15:36 functionName: 'Module.runMain', 00:15:36 scriptId: '44', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 807, 00:15:36 columnNumber: 25 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 28 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 28, 00:15:36 callFrame: { 00:15:36 functionName: 'Module._load', 00:15:36 scriptId: '44', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 506, 00:15:36 columnNumber: 23 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 29 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 29, 00:15:36 callFrame: { 00:15:36 functionName: 'Module.load', 00:15:36 scriptId: '44', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 619, 00:15:36 columnNumber: 32 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 30 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 30, 00:15:36 callFrame: { 00:15:36 functionName: 'Module._extensions..js', 00:15:36 scriptId: '44', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 767, 00:15:36 columnNumber: 36 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 31 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 31, 00:15:36 callFrame: { 00:15:36 functionName: 'Module._compile', 00:15:36 scriptId: '44', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 681, 00:15:36 columnNumber: 36 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 32 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 32, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '52', 00:15:36 url: 'file:///usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/fixtures/workload/fibonacci-worker.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 33, 54 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 33, 00:15:36 callFrame: { 00:15:36 functionName: 'require', 00:15:36 scriptId: '49', 00:15:36 url: 'internal/modules/cjs/helpers.js', 00:15:36 lineNumber: 14, 00:15:36 columnNumber: 18 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 34 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 34, 00:15:36 callFrame: { 00:15:36 functionName: 'Module.require', 00:15:36 scriptId: '44', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 657, 00:15:36 columnNumber: 35 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 35 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 35, 00:15:36 callFrame: { 00:15:36 functionName: 'Module._load', 00:15:36 scriptId: '44', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 506, 00:15:36 columnNumber: 23 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 36 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 36, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compileForPublicLoader', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 210, 00:15:36 columnNumber: 56 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 37 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 37, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 38 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 38, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '53', 00:15:36 url: 'worker_threads.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 39 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 39, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 40 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 40, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 41 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 41, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '54', 00:15:36 url: 'internal/worker.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 42 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 42, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 43 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 43, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 44 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 44, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '55', 00:15:36 url: 'internal/worker/io.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 45 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 45, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 46 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 46, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 47 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 47, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '56', 00:15:36 url: 'stream.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 48 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 48, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 49 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 49, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 50, 53 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 50, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '60', 00:15:36 url: '_stream_readable.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 51 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 51, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 52 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 52, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 53, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '64', 00:15:36 url: '_stream_writable.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 54, 00:15:36 callFrame: { 00:15:36 functionName: 'join', 00:15:36 scriptId: '31', 00:15:36 url: 'path.js', 00:15:36 lineNumber: 1030, 00:15:36 columnNumber: 6 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 55, 00:15:36 callFrame: { 00:15:36 functionName: 'processTicksAndRejections', 00:15:36 scriptId: '22', 00:15:36 url: 'internal/process/task_queues.js', 00:15:36 lineNumber: 61, 00:15:36 columnNumber: 34 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 56 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 56, 00:15:36 callFrame: { 00:15:36 functionName: 'resume_', 00:15:36 scriptId: '60', 00:15:36 url: '_stream_readable.js', 00:15:36 lineNumber: 932, 00:15:36 columnNumber: 16 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 57 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 57, 00:15:36 callFrame: { 00:15:36 functionName: 'Readable.read', 00:15:36 scriptId: '60', 00:15:36 url: '_stream_readable.js', 00:15:36 lineNumber: 376, 00:15:36 columnNumber: 34 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 58, 00:15:36 callFrame: { 00:15:36 functionName: 'onmessage', 00:15:36 scriptId: '55', 00:15:36 url: 'internal/worker/io.js', 00:15:36 lineNumber: 63, 00:15:36 columnNumber: 62 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 59 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 59, 00:15:36 callFrame: { 00:15:36 functionName: 'emit', 00:15:36 scriptId: '11', 00:15:36 url: 'events.js', 00:15:36 lineNumber: 144, 00:15:36 columnNumber: 43 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 60 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 60, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '54', 00:15:36 url: 'internal/worker.js', 00:15:36 lineNumber: 117, 00:15:36 columnNumber: 30 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 61 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 61, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '54', 00:15:36 url: 'internal/worker.js', 00:15:36 lineNumber: 178, 00:15:36 columnNumber: 14 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 62 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 62, 00:15:36 callFrame: { 00:15:36 functionName: 'Readable.push', 00:15:36 scriptId: '60', 00:15:36 url: '_stream_readable.js', 00:15:36 lineNumber: 208, 00:15:36 columnNumber: 34 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 63 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 63, 00:15:36 callFrame: { 00:15:36 functionName: 'readableAddChunk', 00:15:36 scriptId: '60', 00:15:36 url: '_stream_readable.js', 00:15:36 lineNumber: 233, 00:15:36 columnNumber: 25 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 64 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 64, 00:15:36 callFrame: { 00:15:36 functionName: 'addChunk', 00:15:36 scriptId: '60', 00:15:36 url: '_stream_readable.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 17 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 65 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 65, 00:15:36 callFrame: { 00:15:36 functionName: 'maybeReadMore', 00:15:36 scriptId: '60', 00:15:36 url: '_stream_readable.js', 00:15:36 lineNumber: 564, 00:15:36 columnNumber: 22 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 } 00:15:36 ] 00:15:36 CPU path: /usr/home/iojs/node-tmp/.tmp.0/prof/CPU.20190508.071535.5764.1.002.cpuprofile 00:15:36 [ 00:15:36 { 00:15:36 id: 1, 00:15:36 callFrame: { 00:15:36 functionName: '(root)', 00:15:36 scriptId: '0', 00:15:36 url: '', 00:15:36 lineNumber: -1, 00:15:36 columnNumber: -1 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 2, 3, 5, 37 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 2, 00:15:36 callFrame: { 00:15:36 functionName: '(program)', 00:15:36 scriptId: '0', 00:15:36 url: '', 00:15:36 lineNumber: -1, 00:15:36 columnNumber: -1 00:15:36 }, 00:15:36 hitCount: 2 00:15:36 }, 00:15:36 { 00:15:36 id: 3, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 4 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 4, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 148, 00:15:36 columnNumber: 21 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 5, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '8', 00:15:36 url: 'internal/bootstrap/node.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 6, 14, 15, 16 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 6, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 7 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 7, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 8, 25 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 8, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '9', 00:15:36 url: 'internal/util.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 9, 13 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 9, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 10 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 10, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 11 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 11, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '10', 00:15:36 url: 'internal/errors.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 12 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 12, 00:15:36 callFrame: { 00:15:36 functionName: 'E', 00:15:36 scriptId: '10', 00:15:36 url: 'internal/errors.js', 00:15:36 lineNumber: 250, 00:15:36 columnNumber: 10 00:15:36 }, 00:15:36 hitCount: 2, 00:15:36 positionTicks: [ [Object], [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 13, 00:15:36 callFrame: { 00:15:36 functionName: 'internalBinding', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 127, 00:15:36 columnNumber: 44 00:15:36 }, 00:15:36 hitCount: 2, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 25, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '19', 00:15:36 url: 'internal/process/worker_thread_only.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 26 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 26, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 27 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 27, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 28 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 28, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '20', 00:15:36 url: 'internal/worker/io.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 29 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 29, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 30 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 30, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 31 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 31, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '21', 00:15:36 url: 'stream.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 32 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 32, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 33 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 33, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 3, 00:15:36 children: [ 34 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 34, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '25', 00:15:36 url: '_stream_readable.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 35 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 35, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 36 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 36, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 14, 00:15:36 callFrame: { 00:15:36 functionName: 'setupProcessObject', 00:15:36 scriptId: '8', 00:15:36 url: 'internal/bootstrap/node.js', 00:15:36 lineNumber: 292, 00:15:36 columnNumber: 27 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 15, 00:15:36 callFrame: { 00:15:36 functionName: 'setupGlobalProxy', 00:15:36 scriptId: '8', 00:15:36 url: 'internal/bootstrap/node.js', 00:15:36 lineNumber: 337, 00:15:36 columnNumber: 25 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 16, 00:15:36 callFrame: { 00:15:36 functionName: 'setupBuffer', 00:15:36 scriptId: '8', 00:15:36 url: 'internal/bootstrap/node.js', 00:15:36 lineNumber: 376, 00:15:36 columnNumber: 20 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 17 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 17, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 18 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 18, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 children: [ 19 ], 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 19, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '12', 00:15:36 url: 'buffer.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 20, 24 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 20, 00:15:36 callFrame: { 00:15:36 functionName: 'nativeModuleRequire', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 182, 00:15:36 columnNumber: 28 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 21 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 21, 00:15:36 callFrame: { 00:15:36 functionName: 'NativeModule.compile', 00:15:36 scriptId: '7', 00:15:36 url: 'internal/bootstrap/loaders.js', 00:15:36 lineNumber: 286, 00:15:36 columnNumber: 41 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 22, 23 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 22, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '14', 00:15:36 url: 'internal/util/inspect.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 3, 00:15:36 positionTicks: [ [Object], [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 23, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '17', 00:15:36 url: 'internal/buffer.js', 00:15:36 lineNumber: 0, 00:15:36 columnNumber: 0 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 24, 00:15:36 callFrame: { 00:15:36 functionName: 'createPool', 00:15:36 scriptId: '12', 00:15:36 url: 'buffer.js', 00:15:36 lineNumber: 120, 00:15:36 columnNumber: 19 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 37, 00:15:36 callFrame: { 00:15:36 functionName: 'onmessage', 00:15:36 scriptId: '20', 00:15:36 url: 'internal/worker/io.js', 00:15:36 lineNumber: 63, 00:15:36 columnNumber: 62 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 38 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 38, 00:15:36 callFrame: { 00:15:36 functionName: 'emit', 00:15:36 scriptId: '11', 00:15:36 url: 'events.js', 00:15:36 lineNumber: 144, 00:15:36 columnNumber: 43 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 39 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 39, 00:15:36 callFrame: { 00:15:36 functionName: '', 00:15:36 scriptId: '52', 00:15:36 url: 'internal/main/worker_thread.js', 00:15:36 lineNumber: 89, 00:15:36 columnNumber: 19 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 40 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 40, 00:15:36 callFrame: { 00:15:36 functionName: 'Module.runMain', 00:15:36 scriptId: '61', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 807, 00:15:36 columnNumber: 25 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 41 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 41, 00:15:36 callFrame: { 00:15:36 functionName: 'Module._load', 00:15:36 scriptId: '61', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 506, 00:15:36 columnNumber: 23 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 42 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 42, 00:15:36 callFrame: { 00:15:36 functionName: 'Module.load', 00:15:36 scriptId: '61', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 619, 00:15:36 columnNumber: 32 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 43 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 43, 00:15:36 callFrame: { 00:15:36 functionName: 'Module._extensions..js', 00:15:36 scriptId: '61', 00:15:36 url: 'internal/modules/cjs/loader.js', 00:15:36 lineNumber: 767, 00:15:36 columnNumber: 36 00:15:36 }, 00:15:36 hitCount: 0, 00:15:36 children: [ 44 ] 00:15:36 }, 00:15:36 { 00:15:36 id: 44, 00:15:36 callFrame: { 00:15:36 functionName: 'readFileSync', 00:15:36 scriptId: '64', 00:15:36 url: 'fs.js', 00:15:36 lineNumber: 332, 00:15:36 columnNumber: 21 00:15:36 }, 00:15:36 hitCount: 3, 00:15:36 children: [ 45 ], 00:15:36 positionTicks: [ [Object], [Object], [Object] ] 00:15:36 }, 00:15:36 { 00:15:36 id: 45, 00:15:36 callFrame: { 00:15:36 functionName: 'tryReadSync', 00:15:36 scriptId: '64', 00:15:36 url: 'fs.js', 00:15:36 lineNumber: 320, 00:15:36 columnNumber: 20 00:15:36 }, 00:15:36 hitCount: 1, 00:15:36 positionTicks: [ [Object] ] 00:15:36 } 00:15:36 ] 00:15:36 assert.js:362 00:15:36 throw err; 00:15:36 ^ 00:15:36 00:15:36 AssertionError [ERR_ASSERTION]: The expression evaluated to a falsy value: 00:15:36 00:15:36 assert(profile1.frames.length > 0 || profile2.frames.length > 0) 00:15:36 00:15:36 at Object.<anonymous> (/usr/home/iojs/build/workspace/node-test-commit-freebsd/nodes/freebsd11-x64/test/sequential/test-cpu-prof.js:366:3) 00:15:36 at Module._compile (internal/modules/cjs/loader.js:759:30) 00:15:36 at Object.Module._extensions..js (internal/modules/cjs/loader.js:770:10) 00:15:36 at Module.load (internal/modules/cjs/loader.js:628:32) 00:15:36 at Function.Module._load (internal/modules/cjs/loader.js:555:12) 00:15:36 at Function.Module.runMain (internal/modules/cjs/loader.js:822:10) 00:15:36 at internal/main/run_main_module.js:17:11 00:15:36 ... ``` </details> @joyeecheung
flaky-test
low
Critical
441,754,064
pytorch
Redundantly saving sizes of SavedVariables in autograd Function
I was reading some autograd code and I noticed this: ``` struct MmBackward : public TraceableFunction { using TraceableFunction::TraceableFunction; variable_list apply(variable_list&& grads) override; std::string name() const override { return "MmBackward"; } void release_variables() override { self_.reset_data(); self_.reset_grad_function(); mat2_.reset_data(); mat2_.reset_grad_function(); } SavedVariable self_; std::vector<int64_t> mat2_sizes; SavedVariable mat2_; }; ``` The `mat2_sizes` here is pointless; we can trivially reconstruct it from `mat2_`. So it's just a waste of space. Marked as low priority as I don't think is actually affecting anything.
module: bootcamp,module: autograd,low priority,triaged
low
Minor
441,764,162
pytorch
Linker errors when linking statically (avx perfkernels) [Caffe2]
## 🐛 Bug I've been trying to build the caffe2 v1.1.0 release and link it statically with our application, but I'm getting a lot of undefined symbols related to avx functions. ## To Reproduce I've built caffe2 142c973f4179e768164cd578951489e89021b29c using the following flags: ```bash $ cd pytorch $ mkdir build $ cd build $ cmake .. -DCMAKE_INSTALL_PREFIX=/home/giachero/runtimes/caffe2-v1.1.0-avx -DBUILD_PYTHON=OFF -DUSE_CUDA=OFF -DUSE_NATIVE_ARCH=ON -DUSE_GFLAGS=OFF -DUSE_GLOG=OFF -DUSE_GLOO=OFF -DBUILD_SHARED_LIBS=OFF -DBUILD_TEST=OFF -DBUILD_BINARY=OFF -DUSE_LMDB=OFF -DUSE_LEVELDB=OFF -DUSE_MPI=OFF -DUSE_OPENMP=OFF -DUSE_OPENCV=OFF -DBUILD_ATEN_MOBILE=ON -DUSE_NNPACK=OFF -DCAFFE2_DISABLE_NUMA=1 -DUSE_QNNPACK=OFF ``` Minimal application code: ```c++ #include <caffe2/core/init.h> int main(int argc, char *argv[]) { caffe2::GlobalInit(); return 0; } ``` Build flags: ```bash $ g++ main.cpp -I /home/giachero/runtimes/caffe2-v1.1.0-avx/include/ -L /home/giachero/runtimes/caffe2-v1.1.0-avx/lib/ -Wl,--whole-archive -lcaffe2 -Wl,--no-whole-archive -lcaffe2_protos -lcpuinfo -lc10 -lclog -lonnx -lprotobuf -lonnx_proto -lonnxifi_loader -lm -lpthread -ldl -o test ``` Output: ``` /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int32_t_float_float_false(long, long, long, long, float const*, int const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x2caa): undefined reference to `caffe2::EmbeddingLookup_int32_t_float_float_false__avx2_fma(long, long, long, long, float const*, int const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int64_t_float_float_false(long, long, long, long, float const*, long const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x2e3a): undefined reference to `caffe2::EmbeddingLookup_int64_t_float_float_false__avx2_fma(long, long, long, long, float const*, long const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int32_t_half_float_false(long, long, long, long, c10::Half const*, int const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x2fca): undefined reference to `caffe2::EmbeddingLookup_int32_t_half_float_false__avx2_fma(long, long, long, long, c10::Half const*, int const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int64_t_half_float_false(long, long, long, long, c10::Half const*, long const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x315a): undefined reference to `caffe2::EmbeddingLookup_int64_t_half_float_false__avx2_fma(long, long, long, long, c10::Half const*, long const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int32_t_uint8_t_float_false(long, long, long, long, unsigned char const*, int const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x32ec): undefined reference to `caffe2::EmbeddingLookup_int32_t_uint8_t_float_false__avx2_fma(long, long, long, long, unsigned char const*, int const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int64_t_uint8_t_float_false(long, long, long, long, unsigned char const*, long const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x347c): undefined reference to `caffe2::EmbeddingLookup_int64_t_uint8_t_float_false__avx2_fma(long, long, long, long, unsigned char const*, long const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int32_t_float_float_true(long, long, long, long, float const*, int const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x360a): undefined reference to `caffe2::EmbeddingLookup_int32_t_float_float_true__avx2_fma(long, long, long, long, float const*, int const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int64_t_float_float_true(long, long, long, long, float const*, long const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x379a): undefined reference to `caffe2::EmbeddingLookup_int64_t_float_float_true__avx2_fma(long, long, long, long, float const*, long const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int32_t_half_float_true(long, long, long, long, c10::Half const*, int const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x392a): undefined reference to `caffe2::EmbeddingLookup_int32_t_half_float_true__avx2_fma(long, long, long, long, c10::Half const*, int const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int64_t_half_float_true(long, long, long, long, c10::Half const*, long const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x3aba): undefined reference to `caffe2::EmbeddingLookup_int64_t_half_float_true__avx2_fma(long, long, long, long, c10::Half const*, long const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int32_t_uint8_t_float_true(long, long, long, long, unsigned char const*, int const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x3c4c): undefined reference to `caffe2::EmbeddingLookup_int32_t_uint8_t_float_true__avx2_fma(long, long, long, long, unsigned char const*, int const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(embedding_lookup.cc.o): In function `caffe2::EmbeddingLookup_int64_t_uint8_t_float_true(long, long, long, long, unsigned char const*, long const*, int const*, float const*, float const*, bool, float*)': embedding_lookup.cc:(.text+0x3ddc): undefined reference to `caffe2::EmbeddingLookup_int64_t_uint8_t_float_true__avx2_fma(long, long, long, long, unsigned char const*, long const*, int const*, float const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(fused_8bit_rowwise_embedding_lookup.cc.o): In function `caffe2::Fused8BitRowwiseEmbeddingLookup_int64_t_uint8_t_float(long, long, long, long, unsigned char const*, long const*, int const*, float const*, bool, float*)': fused_8bit_rowwise_embedding_lookup.cc:(.text+0x858): undefined reference to `caffe2::Fused8BitRowwiseEmbeddingLookup_int64_t_uint8_t_float_false__avx2_fma(long, long, long, long, unsigned char const*, long const*, int const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(fused_8bit_rowwise_embedding_lookup.cc.o): In function `caffe2::Fused8BitRowwiseEmbeddingLookup_int32_t_uint8_t_float(long, long, long, long, unsigned char const*, int const*, int const*, float const*, bool, float*)': fused_8bit_rowwise_embedding_lookup.cc:(.text+0x958): undefined reference to `caffe2::Fused8BitRowwiseEmbeddingLookup_int32_t_uint8_t_float_false__avx2_fma(long, long, long, long, unsigned char const*, int const*, int const*, float const*, bool, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(typed_axpy.cc.o): In function `void caffe2::TypedAxpy<c10::Half, float>(int, float, c10::Half const*, float*)': typed_axpy.cc:(.text+0x10d): undefined reference to `caffe2::TypedAxpyHalffloat__avx2_fma(int, float, c10::Half const*, float*)' typed_axpy.cc:(.text+0x131): undefined reference to `caffe2::TypedAxpyHalffloat__avx_f16c(int, float, c10::Half const*, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(typed_axpy.cc.o): In function `void caffe2::TypedAxpy<unsigned char, float>(int, float, unsigned char const*, float*)': typed_axpy.cc:(.text+0x221): undefined reference to `caffe2::TypedAxpy_uint8_float__avx2_fma(int, float, unsigned char const*, float*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(adagrad.cc.o): In function `caffe2::adagrad_update(int, float const*, float const*, float const*, float*, float*, float, float, float)': adagrad.cc:(.text+0x621): undefined reference to `caffe2::adagrad_update__avx_f16c(int, float const*, float const*, float const*, float*, float*, float, float, float)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(adagrad.cc.o): In function `caffe2::adagrad_update_prefetch(int, float const*, float const*, float const*, float const*, float const*, float*, float*, float*, float*, float, float)': adagrad.cc:(.text+0x789): undefined reference to `caffe2::adagrad_update_prefetch__avx_f16c(int, float const*, float const*, float const*, float const*, float const*, float*, float*, float*, float*, float, float)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(adagrad.cc.o): In function `caffe2::adagrad_fp16_update_prefetch(int, c10::Half const*, c10::Half const*, float const*, c10::Half const*, c10::Half const*, c10::Half*, c10::Half*, c10::Half*, c10::Half*, float, float)': adagrad.cc:(.text+0xac9): undefined reference to `caffe2::adagrad_fp16_update_prefetch__avx_f16c(int, c10::Half const*, c10::Half const*, float const*, c10::Half const*, c10::Half const*, c10::Half*, c10::Half*, c10::Half*, c10::Half*, float, float)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(adagrad.cc.o): In function `caffe2::rowwise_adagrad_update(int, float*, float*, float const*, float*, float*, float, float)': adagrad.cc:(.text+0xd36): undefined reference to `caffe2::rowwise_adagrad_update__avx_f16c(int, float*, float*, float const*, float*, float*, float, float)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(adagrad.cc.o): In function `int caffe2::sparse_adagrad<int>(int, int, unsigned long, float const*, float const*, float const*, int const*, float*, float*, float, float)': adagrad.cc:(.text+0xfd6): undefined reference to `caffe2::sparse_adagrad_int32_t__avx_f16c(int, int, unsigned long, float const*, float const*, float const*, int const*, float*, float*, float, float)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(adagrad.cc.o): In function `int caffe2::sparse_adagrad<long>(int, int, unsigned long, float const*, float const*, float const*, long const*, float*, float*, float, float)': adagrad.cc:(.text+0x1276): undefined reference to `caffe2::sparse_adagrad_int64_t__avx_f16c(int, int, unsigned long, float const*, float const*, float const*, long const*, float*, float*, float, float)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(math_cpu_base.cc.o): In function `caffe2::math::quantize_and_compress(float const*, unsigned char*, unsigned long, unsigned long, bool, float const*)': math_cpu_base.cc:(.text+0x31d): undefined reference to `caffe2::math::quantize_and_compress__avx2(float const*, unsigned char*, unsigned long, unsigned long, bool, float const*)' /home/giachero/runtimes/caffe2-v1.1.0-avx/lib//libcaffe2.a(math_cpu_base.cc.o): In function `caffe2::math::decompress_and_dequantize(unsigned char const*, float*, unsigned long)': math_cpu_base.cc:(.text+0x455): undefined reference to `caffe2::math::decompress_and_dequantize__avx2(unsigned char const*, float*, unsigned long)' collect2: error: ld returned 1 exit status ``` ## Environment - Caffe2 version: 142c973f4179e768164cd578951489e89021b29c (v1.1.0) - OS: Ubuntu 18.04 x86_64 - Build command you used (if compiling from source): cmake .. -DCMAKE_INSTALL_PREFIX=/home/giachero/runtimes/caffe2-v1.1.0-avx -DBUILD_PYTHON=OFF -DUSE_CUDA=OFF -DUSE_NATIVE_ARCH=ON -DUSE_GFLAGS=OFF -DUSE_GLOG=OFF -DUSE_GLOO=OFF -DBUILD_SHARED_LIBS=OFF -DBUILD_TEST=OFF -DBUILD_BINARY=OFF -DUSE_LMDB=OFF -DUSE_LEVELDB=OFF -DUSE_MPI=OFF -DUSE_OPENMP=OFF -DUSE_OPENCV=OFF -DBUILD_ATEN_MOBILE=ON -DUSE_NNPACK=OFF -DCAFFE2_DISABLE_NUMA=1 -DUSE_QNNPACK=OFF
caffe2
low
Critical
441,769,175
rust
Inlining + target_feature broken in powerpc64
[godbolt](https://godbolt.org/z/FsNj8l) ```rust #![feature(repr_simd, powerpc_target_feature)] #![allow(non_camel_case_types)] #[repr(simd)] pub struct u32x4(u32, u32, u32, u32); impl u32x4 { #[inline] // #[inline(always)] fn splat(x: u32) -> Self { u32x4(x, x, x, x) } } #[target_feature(enable = "altivec")] pub unsafe fn splat_u32x4(x: u32) -> u32x4 { u32x4::splat(x) } ``` with `#[inline]` that code produces a function call within `splat_u32x4` (`b example::u32x4::splat`) to `u32x4::splat`, which is not eliminated, even though this method is module private. With `#[inline(always)]`, `u32x4::splat` is inlined into `splat_u32x4`, and no code for `u32x4::splat` is generated. `#[inline]` should not be needed here, much less `#[inline(always)]`, yet without `#[inline(always)]` this produces bad codegen. Removing the `#[target_feature]` attribute from `splat_u32x4` fixes the issue, no `#[inline]` necessary: [godbolt](https://godbolt.org/z/NeA-2w). So there must be some interaction between inlining and target features going on here.
A-LLVM,T-compiler,O-PowerPC,A-SIMD,C-bug
low
Critical
441,782,684
PowerToys
Disable first click handling in inactive window
instead only bring the window to front. Example of problem to be solved: only a piece of a browser window is visible. Clicking onto a link (by accident) to bring it into the foreground will also change the page shown within that browser window. As long this isn't going to be a official Windows mouse settings option it would be nice to have an option via PowerToys.. But its more tricky to implement then it sounds: the first click should be handled if that Window is completely visible...
Idea-New PowerToy
low
Major
441,783,356
PowerToys
"Jump to target" in Open/Save dialogs on Drop
Just like the MacOS handles it... For those who never experienced it: dragging a file into an open/save file dialog will jump to the enclosing folder and select the dropped file/folder. Its one of those features missing that gets (Ex-) Mac users crazy...
Idea-New PowerToy
medium
Critical
441,798,056
PowerToys
Assign Applications to Specific Desktops
Currently, very easy to open multiple versions of an app, that if on the wrong desktop, creates chaos. This especially true for apps such as Microsoft Outlook. Also not being able to assign a specific desktop for VMWare Horizon Client can cause strange behavior. This should persist across docking and undocking a laptop. Would be a nice tie in to the other laptop related ones.
Idea-Enhancement,Product-Window Manager,Product-Virtual Desktop
medium
Major
441,855,965
PowerToys
SyncToy and Robocopy
Please bring back Synctoy for a Robocopy like function....and/or open source Robocopy https://en.wikipedia.org/wiki/SyncToy
Idea-New PowerToy
high
Critical
441,856,778
godot
XMLParser get_node_name only works on NODE_ELEMENTs
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** 3.1.1 **Issue description:** `get_node_name` doesn't work on any nodes other than `NODE_ELEMENT` and `NODE_ELEMENT_END`. Sometimes I want to get the name of a `NODE_TEXT`, which isn't possible. This is probably to avoid trying to get the names of `NODE_NONE` or maybe `NODE_UNKNOWN`. The docs state ``` Get the name of the current element node. This will raise an error if the current node type is not NODE_ELEMENT nor NODE_ELEMENT_END ``` **Steps to reproduce:** Create a new `XMLParser`, load in an `xml` file with the first element being a simple text node, call `read()` and then `get_name()`. Example text element: ```xml <description> Vector3 is one of the core classes of the engine. </description> ``` **Workaround:** Since the end of an element is always `NODE_ELEMENT_END`, you can get the name from that element.
enhancement,topic:core,confirmed,documentation
low
Critical
441,869,837
rust
unused_mut warning gives bad suggestion in a macro
The following gives a suggestion to remove the `mut` which will cause the code to fail to compile. ```rust macro_rules! array { ($($element:expr),*) => {{ let mut array = Vec::new(); $( array.push($element); )* array }}; } fn main() { let _x: Vec<i32> = array![]; let _y: Vec<i32> = array![1,2,3]; } ``` ``` warning: variable does not need to be mutable --> src/main.rs:3:13 | 3 | let mut array = Vec::new(); | ----^^^^^ | | | help: remove this `mut` ... 12 | let _x: Vec<i32> = array!{}; | -------- in this macro invocation | = note: #[warn(unused_mut)] on by default ``` This causes `cargo fix` to fail. (Sorry if this is a dupe, I went hunting but couldn't find any issues that were the same.)
A-lints,T-compiler,A-NLL,C-bug,D-incorrect
low
Major
441,870,374
TypeScript
Recognize properties introduced by jQuery extend
The old VS JS language service used to make runtime types available at design-time, allowing it to support jQuery's `extend` function for adding properties dynamically. The new one uses static types and so does not offer these symbols during completion, navigate-to, etc. We've had some customer inquiries about the possibility of supporting this functionality in the TS language service. https://developercommunity.visualstudio.com/content/problem/529989/aspnet-在html-文件-js-智能提示失效.html https://developercommunity.visualstudio.com/content/problem/560277/javascript-go-to-members-doesnt-work-with-property.html The latter provided this example: ```js (function ($) { mynamespace.myClass = Class.extend({ init: function (options) { // unless you specifically type this.testProperty = "abc" in JS, the 'Go to Members' will not find the below property even though it's explicitely defined. }, __properties: { 'testProperty': { /// <summary> /// Gets or sets the test property /// </summary> /// <value type="String"></value> get: function () { return this._testProperty; }, set: function (value) { this._testProperty = value; } } } }); })(jQuery); ```
Suggestion,Awaiting More Feedback
low
Minor
441,873,341
TypeScript
GTD not working between ES5-style classes
Reported in VS, repros in VS Code. https://developercommunity.visualstudio.com/content/problem/556364/javascript-go-to-definition-or-f12-doesnt-work-wit.html ```js (function () { my.namepsace.myclass = function () { something: function something() { }; }; my.namespace.mystaticmethod = function () { return false; }; })(); (function () { another.namespace.class = function () { init: function init() { var myclass = new my.namepsace.myclass(); // GTD on myclass var result = my.namespace.mystaticmethod(); // GTD on mystaticmethod } }; })(); ``` GTD does not work on the references to `myclass` and `mystaticmethod`.
Suggestion,Awaiting More Feedback,Domain: JavaScript
low
Major
441,878,189
PowerToys
Apps remember virtual desktops between reboots and location
Preserve application and virtual desktop layout between reboots! :)
Idea-Enhancement,Product-Window Manager,Product-Virtual Desktop
medium
Critical
441,883,037
go
go/build: inconsistency on whether NoGoError includes test files
The code & documentation disagree about whether `go/build.NoGoError` includes tests. Code says: ```go if len(p.GoFiles)+len(p.CgoFiles)+len(p.TestGoFiles)+len(p.XTestGoFiles) == 0 { return p, &NoGoError{p.Dir} } ``` But docs say: ```go // NoGoError is the error used by Import to describe a directory // containing no buildable Go source files. (It may still contain // test files, files hidden by build tags, and so on.) type NoGoError struct { Dir string } ``` (Notably, the "it may still contain test files" part, implying that a directory with only `foo_test.go` should be NoGoError). /cc @bcmills @jayconrod @rsc @ianlancetaylor
NeedsInvestigation
low
Critical
441,897,905
terminal
More complete tab sizing configurations
Initially brought up in #444, the ability to enable/disable a configurable min-width for tabs when you have many of them, similar to: ![](https://i.imgur.com/UYtiZE3.png) If disabled, it would be chrome-like with tabs getting ever smaller, and if enabled, it would be firefox-like with a user-defined min-width before it starts either scrolling or being paginated.
Issue-Feature,Area-UserInterface,Product-Terminal
medium
Critical
441,901,894
TypeScript
3.5 regression: return type forced more restrictive than needed
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.5.0-dev.20190508 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** restrictive return type **Code** ```ts class Box<A> { constructor(public val: A) {} } interface ContainerFor<A> { array: Array<A>; box: Box<A>; } function single<T extends keyof ContainerFor<number>>(t: T, x: number): ContainerFor<number>[T] { switch (t) { case "array": return new Array<number>(x); case "box": return new Box<number>(x); } return new Box<number>(0); // this should not be needed } function test() { let t1 = single("array", 42); let t2 = single("box", 42); //let t3 = single("boo", 42); } ``` **Expected behavior:** This code worked with 3.4, but had an unsoundness bug in that `single` was allowed to return the wrong type (swap array and box). It was clear that switching over `t` did not increase knowledge about the expected output type and I was forced to have a fallback return which is of course unreachable. But the code itself worked. The `test` function also shows things work as expected. The types for `t1` and `t2` are inferred correctly and asking for an unknown thing ("boo") is reported as an error. I would expect this to still work in 3.5, perhaps fixing one of the issues I'm having in the internals of `single`. **Actual behavior:** Typescript 3.5 no longer accepts this code. returning `new Array` or `new Box` are flagged as wrong return types. The newly expected return type is now mandated to be the intersection type: `number[] & Box<number>`, which is too restrictive as the correct output type can be statically determined from `T` in the input. The fact that `test` correctly infers the output type is proof of this.
Suggestion,Needs Proposal,Domain: Indexed Access Types,Domain: Control Flow
low
Critical
441,904,593
flutter
[web]: Scrolling is very slow when displaying large Text
## Versions: Dart VM version: 2.3.0 (Fri May 3 10:32:31 2019 +0200) on "macos_x64" Flutter 1.5.4-hotfix.2 • channel stable • https://github.com/flutter/flutter.git Framework • revision 7a4c33425d (9 days ago) • 2019-04-29 11:05:24 -0700 Engine • revision 52c7a1e849 Tools • Dart 2.3.0 (build 2.3.0-dev.0.5 a1668566e5) ## Issue I was playing with Flutter Web and decided to put a HTTP response body (78KB) into a `Text` element. It causes the app to scroll very, very slowly. Here's simplified code you can use to reproduce: ```dart @override Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: Padding( child: Text("Pull Requests"), padding: EdgeInsets.all(5), ), ), body: Center( child: ListView( children: <Widget>[ Text(Iterable.generate(10000, (i) => "Hello Flutter $i").join('\n')) ], ), ), ); } ```
engine,c: performance,platform-web,customer: webeap,e: web_html,has reproducible steps,P2,found in release: 3.3,found in release: 3.7,team-web,triaged-web
low
Major
441,921,768
youtube-dl
Add Support for MQube.net
<!-- ###################################################################### WARNING! IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE ###################################################################### --> ## Checklist <!-- Carefully read and work through this check list in order to prevent the most common mistakes and misuse of youtube-dl: - First of, make sure you are using the latest version of youtube-dl. Run `youtube-dl --version` and ensure your version is 2019.04.30. If it's not, see https://yt-dl.org/update on how to update. Issues with outdated version will be REJECTED. - Make sure that all provided video/audio/playlist URLs (if any) are alive and playable in a browser. - Make sure that site you are requesting is not dedicated to copyright infringement, see https://yt-dl.org/copyright-infringement. youtube-dl does not support such sites. In order for site support request to be accepted all provided example URLs should not violate any copyrights. - Search the bugtracker for similar site support requests: http://yt-dl.org/search-issues. DO NOT post duplicates. - Finally, put x into all relevant boxes (like this [x]) --> - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2019.04.30** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs <!-- Provide all kinds of example URLs support for which should be included. Replace following example URLs by yours. --> - Single audio: https://mqube.net/play/20181228624995 - User: https://mqube.net/user/tsukunesoba ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> MQube is a Japanese audio-sharing website. Signing in is not required.
site-support-request
low
Critical
441,923,749
go
cmd/go: 'list std' unnecessarily opens *_test.go files
While working in an environment with a slow filesystem (immediate stats+readdirs, but slow opens), I noticed that `go list std` was very slow (~6 seconds), which prompted me to look at what it was doing. One thing that jumped out was that it's opening *_test.go files, which should not be necessary to answer the question of whether a directory in $GOROOT contains a Go package. ``` $ go install cmd/go && strace -f -e open,openat go list std 2>&1 | grep _test.go | wc -l 2181 ``` That's about 37% of the overall files opened: ``` $ go install cmd/go && strace -f -e open,openat go list std 2>&1 | grep O_RDONLY | grep '.go"' | wc -l 5887 ``` Overall, we read 67 MB in from disk just to answer `go list std`: ``` $ strace -o trace -f -e read go list std > /dev/null && perl -ne '$num += $1 if /.+?(\d+)/; END{ print "$num\n" }' < trace 67894893 ``` If I make os.Open panic on an `_test.go` open, I see a number of backtraces just by re-running it a few times: ``` panic: os.OpenFile opening /home/bradfitz/go/src/regexp/syntax/parse_test.go goroutine 1 [running]: os.OpenFile(0xc00002fbc0, 0x31, 0x0, 0x0, 0xc0001565ac, 0x0, 0x200) /home/bradfitz/go/src/os/file.go:296 +0x1ca os.Open(...) /home/bradfitz/go/src/os/file.go:276 cmd/go/internal/imports.scanFiles(0xc00027e400, 0xb, 0x10, 0xc000113080, 0x0, 0xc00027e400, 0x8, 0x10, 0x0, 0x7f200d2c5ab0, ...) /home/bradfitz/go/src/cmd/go/internal/imports/scan.go:52 +0x20a cmd/go/internal/imports.ScanDir(0xc0001db740, 0x23, 0xc000113080, 0xc0003bd8e8, 0x47d6f7, 0xc000450256, 0xd, 0xc000156740, 0xffffffffffffffff, 0x97e620, ...) /home/bradfitz/go/src/cmd/go/internal/imports/scan.go:39 +0x20b cmd/go/internal/modload.scanDir(0xc0001db740, 0x23, 0xc000113080, 0x3, 0x0, 0x0, 0xc0001db740, 0x23, 0x0, 0x0, ...) /home/bradfitz/go/src/cmd/go/internal/modload/load.go:863 +0x5a cmd/go/internal/modload.(*loader).doPkg(0xc0000726c0, 0x98dd20, 0xc000397cc0) /home/bradfitz/go/src/cmd/go/internal/modload/load.go:771 +0x46c cmd/go/internal/par.(*Work).runner(0xc00017c080) /home/bradfitz/go/src/cmd/go/internal/par/work.go:101 +0x157 cmd/go/internal/par.(*Work).Do(0xc00017c080, 0xa, 0xc0002d8290) /home/bradfitz/go/src/cmd/go/internal/par/work.go:69 +0xbf cmd/go/internal/modload.(*loader).load(0xc0000726c0, 0xc000156f60) /home/bradfitz/go/src/cmd/go/internal/modload/load.go:641 +0x9ed cmd/go/internal/modload.loadPatterns(0xc000020710, 0x1, 0x1, 0xc000149901, 0xc0001571d8, 0xd0, 0x9cf140, 0x448467) /home/bradfitz/go/src/cmd/go/internal/modload/load.go:262 +0x25f cmd/go/internal/modload.ImportPathsQuiet(0xc000020710, 0x1, 0x1, 0x203000, 0x203000, 0x0) /home/bradfitz/go/src/cmd/go/internal/modload/load.go:173 +0x84 cmd/go/internal/modload.ImportPaths(0xc000020710, 0x1, 0x1, 0xd0, 0x9cf080, 0xc000034000) /home/bradfitz/go/src/cmd/go/internal/modload/load.go:57 +0x43 cmd/go/internal/load.ImportPaths(0xc000020710, 0x1, 0x1, 0x0, 0xe7cf60, 0x7f200d35a008) /home/bradfitz/go/src/cmd/go/internal/load/pkg.go:1999 +0x5f cmd/go/internal/load.PackagesAndErrors(0xc000020710, 0x1, 0x1, 0x0, 0x0, 0x0) /home/bradfitz/go/src/cmd/go/internal/load/pkg.go:1946 +0xcd cmd/go/internal/load.Packages(0xc000020710, 0x1, 0x1, 0xc0001268c0, 0x0, 0x0) /home/bradfitz/go/src/cmd/go/internal/load/pkg.go:1923 +0x5a cmd/go/internal/list.runList(0xe707a0, 0xc000020710, 0x1, 0x1) /home/bradfitz/go/src/cmd/go/internal/list/list.go:448 +0x2210 main.main() /home/bradfitz/go/src/cmd/go/main.go:188 +0x57f ``` and ``` goroutine 279 [running]: os.OpenFile(0xc00027f3e0, 0x2f, 0x0, 0x0, 0xc000057ce0, 0x0, 0x400) /home/bradfitz/go/src/os/file.go:296 +0x1ca os.Open(...) /home/bradfitz/go/src/os/file.go:276 cmd/go/internal/imports.scanFiles(0xc000178700, 0xf, 0x10, 0xc000113080, 0x0, 0xc000178700, 0x8, 0x10, 0x0, 0x0, ...) /home/bradfitz/go/src/cmd/go/internal/imports/scan.go:52 +0x20a cmd/go/internal/imports.ScanDir(0xc00027eba0, 0x21, 0xc000113080, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...) /home/bradfitz/go/src/cmd/go/internal/imports/scan.go:39 +0x20b cmd/go/internal/modload.scanDir(0xc00027eba0, 0x21, 0xc000113080, 0x3, 0x0, 0x0, 0xc00027eba0, 0x21, 0x0, 0x0, ...) /home/bradfitz/go/src/cmd/go/internal/modload/load.go:863 +0x5a cmd/go/internal/modload.(*loader).doPkg(0xc0000726c0, 0x98dd20, 0xc000368d20) /home/bradfitz/go/src/cmd/go/internal/modload/load.go:771 +0x46c cmd/go/internal/par.(*Work).runner(0xc000176080) /home/bradfitz/go/src/cmd/go/internal/par/work.go:101 +0x157 created by cmd/go/internal/par.(*Work).Do /home/bradfitz/go/src/cmd/go/internal/par/work.go:67 +0x9b ``` I tried to hide all the *_test.go files by altering the build context early in the list command, ```patch diff --git a/src/cmd/go/internal/list/list.go b/src/cmd/go/internal/list/list.go index 4a6633d9a1..0d0c8d36ad 100644 --- a/src/cmd/go/internal/list/list.go +++ b/src/cmd/go/internal/list/list.go @@ -9,7 +9,9 @@ import ( "bufio" "bytes" "encoding/json" + "fmt" "io" + "io/ioutil" "os" "sort" "strings" @@ -312,6 +314,7 @@ func runList(cmd *base.Command, args []string) { out := newTrackingWriter(os.Stdout) defer out.w.Flush() + hadEmptyFmt := *listFmt == "" if *listFmt == "" { if *listM { *listFmt = "{{.String}}" @@ -417,6 +420,26 @@ func runList(cmd *base.Command, args []string) { base.Fatalf("go list -test cannot be used with -find") } + // Can we skip processing *_test.go files? + if !*listTest && !*listJson && hadEmptyFmt { + println("filtering") + readDir := cfg.BuildContext.ReadDir + if readDir == nil { + readDir = ioutil.ReadDir + } + cfg.BuildContext.ReadDir = func(dir string) ([]os.FileInfo, error) { + println(fmt.Sprintf("in filtered ReadDir(%q)", dir)) + fis, err := readDir(dir) + filtered := fis[:0] + for _, fi := range fis { + if !strings.HasSuffix(fi.Name(), "_test.go") { + filtered = append(filtered, fi) + } + } + return filtered, err + } + } + load.IgnoreImports = *listFind var pkgs []*load.Package if *listE { ``` ... but there are several places that are concurrently pre-loading some data, making that not fully effective. (It helps a bit). /cc @bcmills @jayconrod @rsc @ianlancetaylor
help wanted,ToolSpeed,NeedsInvestigation,GoCommand
low
Critical
441,947,502
PowerToys
Manage right-click - Customize context menu
Easily manage the right click actions to edit, open at. Right now this is all over the place, different applications add right-click extensions and it is a mess. You can somehow change the default open application. But it would be great to be able to manage other actions to for example edit e.g Tiff file, HTML file, compile, etc.
Idea-New PowerToy,Product-Tweak UI Design,Product-File Explorer
high
Critical
441,947,867
neovim
MSVC builds of same source are not identical
I've downloaded the `nvim-win64.zip` file of version 0.3.5 last week (2019-04-29). I've downloaded the same file today (2019-05-08). When I check the sha256 sums of the two files, they are different. When I check the content of the files inside the zips (using FreeFileSync and WinMerge), it appears that the following files have different contents. `lua51.dll`, `msgpackc.dll`, `nvim.exe` and `uv.dll` I have discussed this problem with people on IRC (#nvim). After several tests, @justinmk advised me to make a diff on the two nvim.exe files. He also advised me to read this link on StackOverflow : [Deterministic builds unde winwos](https://stackoverflow.com/questions/1180852/deterministic-builds-under-windows/10605862#10605862) I used the tool advised on the SO post : [peparser](https://github.com/smarttechnologies/peparser). After running the comparison on the two `nvim.exe` files, it appears that **the two files are "functionally" identical.** The only differences are due to timestamps and other things produced by the compilation of files. Here is an extract from `peparser` ``` Ignored offsets: offset: 128 size: 4 PE timestamp offset: 178 size: 4 PE checksum offset: 1c8 size: 8 Digital signature directory entry offset: 318334 size: 4 Debugger timestamp offset: 318350 size: 4 Debugger timestamp offset: 31836c size: 4 Debugger timestamp offset: 318388 size: 4 Debugger timestamp offset: 3184a0 size: 3e PDB section offset: 3184a4 size: 10 PDB 7.00 guid offset: 3184b4 size: 4 PDB 7.00 age offset: 3184b8 size: 25 PDB 7.00 file path ... Functionally equivalent. Difference: 0.00% (0 bytes) ``` - `nvim --version`: ``` NVIM v0.3.5 Build type: RelWithDebInfo LuaJIT 2.0.5 Compilation: C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.16.27023/bin/Hostx86/x64/cl.exe /DWIN32 /D_WINDOWS /W3 /MD /Zi /O2 /Ob1 /DNDEBUG -DMIN_LOG_LEVEL=3 /W3 -D_CRT_SECURE_NO_WARNINGS -D_CRT_NONSTDC_NO_DEPRECATE -DWIN32 -D_WIN32_WINNT=0x0600 -DINCLUDE_GENERATED_DECLARATIONS -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -IC:/projects/neovim/build/config -IC:/projects/neovim/src -IC:/projects/neovim/.deps/usr/include -IC:/projects/neovim/build/src/nvim/auto -IC:/projects/neovim/build/include Compiled by appveyor@APPVYR-WIN Features: -acl +iconv -jemalloc +tui See ":help feature-compile" system vimrc file: "$VIM\sysinit.vim" fall-back for $VIM: "C:/Program Files/nvim/share/nvim" Run :checkhealth for more info ``` - Operating system/version: Windows 10 - Terminal name/version: ConEmu v190331
platform:windows,distribution,complexity:low,has:plan
low
Critical
441,949,970
PowerToys
Change size of task bar and alt tab thumbnail previews
My greatest motivation for this is because I'd like the previews of the app windows that you get when you hover over the taskbar or hit alt+tab to be big enough for me to see what's going on in that window without actually clicking on it (for example, to have task manager open behind a maximized window, and let the thumbnail be big enough for me to read what's taking up all my CPU time without bringing task manager in front of that maximized window). In Windows 7, there were a lot of "desktop tweaker" programs that altered a reg key that did this for the task bar thumbnails (HKEY_CURRENT_USER\Software\Microsoft\Windows\CurrentVersion\Explorer\Taskband!MinThumbSizePx), but it doesn't work on all machines, and does nothing for max size, and does nothing for alt+tab.
Idea-New PowerToy,Product-Tweak UI Design
low
Major
441,954,604
youtube-dl
www.myfreecams.com
## Checklist - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2019.04.30** - [x] I've checked that all provided URLs are alive and playable in a browser - [x] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs - Single video: https://www.myfreecams.com/#Miss_Marilin - Single video: https://www.myfreecams.com/#SashaSwan - Site: https://www.myfreecams.com/ ## Description This site is much like chaturbate
site-support-request
low
Critical
441,982,367
rust
ICE in LlvmArchiveBuilder when cross-compiling openssl for Android ARM64
There is an ICE in nightly that I can trigger by adding a dependency on vendored openssl when cross-compiling for aarch64 android with the NDK. It's possible the problem here isn't really rustc's fault, but it does crash. Test repo: https://github.com/thombles/rust-ice-openssl (Requires Android NDK - tested on Darwin host) This test case is a hello world app with a dependency that requires it to build and link openssl from source: ``` [dependencies] openssl = { version = "0.10", features = ["vendored"] } ``` I run the following script to build it: ``` #!/bin/bash set -eu # Set this to location of Android NDK NDK=/Users/tk/Library/Android/sdk/ndk-bundle/ # (Tested on NDK 19.2.5345600, installed via Android Studio SDK Manager) # Set this to your platform - probably "darwin-x86_64", "windows-x86_64", "linux-x86_64" HOST_PLATFORM=darwin-x86_64 echo "Using Android NDK at $NDK for $HOST_PLATFORM" export AR="$NDK/toolchains/llvm/prebuilt/${HOST_PLATFORM}/bin/aarch64-linux-android-ar" export CC="$NDK/toolchains/llvm/prebuilt/${HOST_PLATFORM}/bin/aarch64-linux-android21-clang" export CARGO_TARGET_AARCH64_LINUX_ANDROID_LINKER="${CC}" export RUST_BACKTRACE=1 cargo build --target aarch64-linux-android ``` This results in the following log and backtrace. ``` $ ./bug.sh Using Android NDK at /Users/tk/Library/Android/sdk/ndk-bundle/ for darwin-x86_64 Compiling cc v1.0.36 Compiling libc v0.2.54 Compiling pkg-config v0.3.14 Compiling autocfg v0.1.2 Compiling foreign-types-shared v0.1.1 Compiling openssl v0.10.21 Compiling bitflags v1.0.4 Compiling cfg-if v0.1.7 Compiling lazy_static v1.3.0 Compiling foreign-types v0.3.2 Compiling openssl-src v111.2.1+1.1.1b Compiling openssl-sys v0.9.45 thread 'rustc' panicked at 'called `Option::unwrap()` on a `None` value', src/libcore/option.rs:347:21 note: Some details are omitted, run with `RUST_BACKTRACE=full` for a verbose backtrace. stack backtrace: 0: std::sys::unix::backtrace::tracing::imp::unwind_backtrace 1: std::sys_common::backtrace::_print 2: std::panicking::default_hook::{{closure}} 3: std::panicking::default_hook 4: rustc::util::common::panic_hook 5: std::panicking::rust_panic_with_hook 6: std::panicking::continue_panic_fmt 7: rust_begin_unwind 8: core::panicking::panic_fmt 9: core::panicking::panic 10: <rustc_codegen_llvm::back::archive::LlvmArchiveBuilder as rustc_codegen_ssa::back::archive::ArchiveBuilder>::build 11: rustc_codegen_ssa::back::link::link_binary 12: rustc::util::common::time 13: <rustc_codegen_llvm::LlvmCodegenBackend as rustc_codegen_utils::codegen_backend::CodegenBackend>::join_codegen_and_link 14: rustc_interface::queries::Query<T>::compute 15: rustc_interface::queries::<impl rustc_interface::interface::Compiler>::link 16: rustc_interface::interface::run_compiler_in_existing_thread_pool 17: std::thread::local::LocalKey<T>::with 18: scoped_tls::ScopedKey<T>::set query stack during panic: end of query stack error: internal compiler error: unexpected panic note: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/rust/blob/master/CONTRIBUTING.md#bug-reports note: rustc 1.36.0-nightly (cfdc84a00 2019-05-07) running on x86_64-apple-darwin note: compiler flags: -C debuginfo=2 -C linker=/Users/tk/Library/Android/sdk/ndk-bundle//toolchains/llvm/prebuilt/darwin-x86_64/bin/aarch64-linux-android21-clang --crate-type lib note: some of the compiler flags provided by cargo are hidden error: Could not compile `openssl-sys`. To learn more, run the command again with --verbose. ``` ``` $ rustc --version --verbose rustc 1.36.0-nightly (cfdc84a00 2019-05-07) binary: rustc commit-hash: cfdc84a009020c59e53e4039beae22eb59e41685 commit-date: 2019-05-07 host: x86_64-apple-darwin release: 1.36.0-nightly LLVM version: 8.0 ```
A-codegen,I-ICE,O-android,P-medium,T-compiler,C-bug,O-AArch64
low
Critical
441,985,142
youtube-dl
Add support for gounlimited.to
## Checklist - [x] I'm reporting a new site support request - [x] I've verified that I'm running youtube-dl version **2019.04.30** - [x] I've checked that all provided URLs are alive and playable in a browser - [ ] I've checked that none of provided URLs violate any copyrights - [x] I've searched the bugtracker for similar site support requests including closed ones ## Example URLs - Single video: https://gounlimited.to/embed-tgvof09mkt72.html ## Description <!-- Provide any additional information. If work on your issue requires account credentials please provide them or explain how one can obtain them. --> Gounlimited is a video hosting platform. Siginin not required
site-support-request
low
Critical
441,988,416
flutter
Would be nice to let archives in flutter.cn pre-set the env vars for mirrors
tool,a: china,c: proposal,customer: countless,P3,team-tool,triaged-tool
low
Major
442,030,268
neovim
address sanitizer report heap use after free
<!-- Before reporting: search existing issues and check the FAQ. --> nvim -version ``` NVIM v0.4.0-731-g400ee5924 Build type: Debug LuaJIT 2.0.5 Compilation: /usr/bin/cc -fsanitize=address -g -Wall -Wextra -pedantic -Wno-unused-parameter -Wstrict-prototypes -std=gnu99 -Wshadow -Wconversion -Wmissing-prototypes -Wimplicit-fallthrough -Wvla -fstack-protector-strong -fdiagnostics-color=auto -Wno-array-bounds -DINCLUDE_GENERATED_DECLARATIONS -D_GNU_SOURCE -DNVIM_MSGPACK_HAS_FLOAT32 -DNVIM_UNIBI_HAS_VAR_FROM -I/tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/build/config -I/tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src -I/usr/include -I/tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/build/src/nvim/auto -I/tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/build/include Compiled by wangxinyu@archlinux Features: +acl +iconv +tui See ":help feature-compile" system vimrc file: "$VIM/sysinit.vim" fall-back for $VIM: "/usr/share/nvim" ``` - Vim (version: ) behaves differently? not confirmed - Operating system/version: archlinux 64 - Terminal name/version: run from nvim-qt ### Steps to reproduce using `nvim -u NORC` not tried ``` ================================================================= ==5794==ERROR: AddressSanitizer: heap-use-after-free on address 0x62f000a10408 at pc 0x562841629ce8 bp 0x7ffc4af3fc60 sp 0x7ffc4af3fc50 READ of size 8 at 0x62f000a10408 thread T0 #0 0x562841629ce7 in syn_stack_find_entry /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/syntax.c:1227 #1 0x56284162b787 in syntax_end_parsing /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/syntax.c:1459 #2 0x56284154d553 in win_update /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/screen.c:1429 #3 0x56284154651a in update_screen /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/screen.c:473 #4 0x56284141c2f5 in normal_redraw /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/normal.c:1244 #5 0x56284141ca43 in normal_check /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/normal.c:1321 #6 0x56284161d380 in state_enter /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/state.c:28 #7 0x562841414915 in normal_enter /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/normal.c:462 #8 0x562841368c6c in main /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/main.c:597 #9 0x7f2799db0222 in __libc_start_main (/usr/lib/libc.so.6+0x24222) #10 0x56284102475d in _start (/usr/bin/nvim+0x15575d) 0x62f000a10408 is located 8 bytes inside of 49248-byte region [0x62f000a10400,0x62f000a1c460) freed by thread T0 here: #0 0x7f279a4c7c19 in __interceptor_free /build/gcc/src/gcc/libsanitizer/asan/asan_malloc_linux.cc:66 #1 0x5628413ba5f5 in xfree /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/memory.c:115 #2 0x5628416283b1 in syn_stack_free_block /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/syntax.c:997 #3 0x562841628445 in syn_stack_free_all /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/syntax.c:1008 #4 0x562841636290 in syntax_clear /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/syntax.c:3195 #5 0x5628410b9290 in buf_freeall /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/buffer.c:744 #6 0x5628410b8161 in close_buffer /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/buffer.c:559 #7 0x5628412162ac in do_ecmd /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/ex_cmds.c:2370 #8 0x562841276b4e in do_exedit /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/ex_docmd.c:7036 #9 0x562841275f41 in ex_edit /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/ex_docmd.c:6964 #10 0x56284125875b in do_one_cmd /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/ex_docmd.c:2242 #11 0x56284124cd43 in do_cmdline /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/ex_docmd.c:593 #12 0x56284124b43b in do_cmdline_cmd /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/src/nvim/ex_docmd.c:269 #13 0x562841287779 in ex_terminal /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovi #14 0x56284125875b in do_one_cmd /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim #15 0x56284124cd43 in do_cmdline /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim #16 0x5628414357ff in nv_colon /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-g #17 0x56284141b5cc in normal_execute /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/ne #18 0x56284161d4c4 in state_enter /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovi #19 0x562841414915 in normal_enter /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neov #20 0x562841368c6c in main /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/s #21 0x7f2799db0222 in __libc_start_main (/usr/lib/libc.so.6+0x24222) previously allocated by thread T0 here: #0 0x7f279a4c8231 in __interceptor_calloc /build/gcc/src/gcc/libsanitizer/asan/asan_ #1 0x5628413ba655 in xcalloc /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git #2 0x562841628944 in syn_stack_alloc /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/ne #3 0x562841625cd8 in syntax_start /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovi #4 0x562841552ec8 in win_line /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-gi #5 0x56284154cdaf in win_update /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim- #6 0x56284154651a in update_screen /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neov #7 0x56284166db65 in redraw /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/ #8 0x56284166c7b8 in refresh_timer_cb /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/n #9 0x5628412085ac in time_event /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim- #10 0x5628411fd1e1 in multiqueue_process_events /tmp/yaourt-tmp-wangxinyu/aur-neovim #11 0x5628414512e2 in nv_event /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-g #12 0x56284141b5cc in normal_execute /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/ne #13 0x56284161d4c4 in state_enter /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovi #14 0x562841414915 in normal_enter /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neov #15 0x562841368c6c in main /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/src/neovim-git/s #16 0x7f2799db0222 in __libc_start_main (/usr/lib/libc.so.6+0x24222) SUMMARY: AddressSanitizer: heap-use-after-free /tmp/yaourt-tmp-wangxinyu/aur-neovim-git/ Shadow bytes around the buggy address: 0x0c5e8013a030: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c5e8013a040: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c5e8013a050: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c5e8013a060: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c5e8013a070: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa =>0x0c5e8013a080: fd[fd]fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c5e8013a090: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c5e8013a0a0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c5e8013a0b0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c5e8013a0c0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd 0x0c5e8013a0d0: fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd fd Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb ==5794==ABORTING ``` [asan.error.5794.txt](https://github.com/neovim/neovim/files/3160195/asan.error.5794.txt)
needs:repro,has:backtrace,bug-crash,syntax
medium
Critical
442,034,986
go
net/http: log ServeContent errors reading from the content during Copy?
ERROR: type should be string, got "https://github.com/golang/go/blob/f766b68023c7fa4076d61824d631b3fe2cc697d2/src/net/http/fs.go#L298\r\n\r\n\r\nfunc serveContent was used by docker distribution project,I get 'unexpect eof error 'when I pull image for registry server may be related the bad network(just 20mb bandwidth).I can'not find any error in registry server log,it alwayls return response complete and 200 http status code.so i found error in io.CopyN after debug,it just copy only part of entire content due to ceph( the regitry storage backend ) rst the connection(mayby slow network). \r\n\r\nI found same issue in [9709](https://github.com/golang/go/issues/9709 ) ,however ,If it's not worth the cost of adding return error,can add error in ResponseWriter.like this\r\n\r\n```\r\n\tif r.Method != \"HEAD\" {\r\n\t\tlength, err := io.CopyN(w, sendContent, sendSize)\r\n\t\tif err != nil {\r\n\t\t\terrDetail := fmt.Sprintf(\"copy error,Just copy %d of %d\", length, sendSize)\r\n\t\t\tError(w, errDetail, StatusInternalServerError)\r\n\t\t\treturn\r\n\t\t}\r\n\t}\r\n```\r\n"
NeedsInvestigation
low
Critical
442,037,865
rust
Wrong Send constraint when using a trait with lifetime + associated type in async
**Update: See https://github.com/rust-lang/rust/issues/60658#issuecomment-1509321859 for the latest reproducer** Minimal: ```rust #![feature(async_await, await_macro)] use std::future::Future; pub trait Foo<'a> { type Future: Future<Output = ()>; fn foo() -> Self::Future; } struct MyType<T>; impl<'a, T> Foo<'a> for MyType<T> where T: Foo<'a>, T::Future: Send, { type Future = Box<Future<Output = ()> + Send>; fn foo() -> Self::Future { Box::new(async move { await!(T::foo()) }) } } fn main() { } ``` Out: ``` Compiling playground v0.0.1 (/playground) error[E0308]: mismatched types --> src/main.rs:21:9 | 21 | / Box::new(async move { 22 | | await!(T::foo()) 23 | | }) | |__________^ one type is more general than the other | = note: expected type `std::marker::Send` found type `std::marker::Send` error: aborting due to previous error For more information about this error, try `rustc --explain E0308`. error: Could not compile `playground`. To learn more, run the command again with --verbose. ``` Compiler version: `rustc 1.36.0-nightly (2019-05-07)`
C-enhancement,A-diagnostics,T-compiler,A-async-await,AsyncAwait-Triaged
low
Critical
442,076,524
PowerToys
Profiles for Network Cards
Could we get Profiles for Network Cards? Would be great to change from Manual Assigned IP to DHCP with Keyboard Shortcuts or Shortcuts in the Taskbar.
Idea-New PowerToy
low
Major
442,082,397
TypeScript
Convert to discriminated union
A refactoring to convert from enums or plain unions to discriminated unions. <!-- ![convertToTaggedUnionConcept](https://user-images.githubusercontent.com/972891/57433841-542e8200-71ee-11e9-8c27-3609ed51b88a.gif) --> ![convertToTaggedUnionConcept2](https://user-images.githubusercontent.com/972891/57434065-e8004e00-71ee-11e9-93e6-949580de2b6f.gif)
Suggestion,Awaiting More Feedback,Domain: Refactorings
medium
Major
442,092,603
flutter
Docset for objective-c/java APIs
Like https://github.com/flutter/flutter/issues/9955 but for https://api.flutter.dev/javadoc/ and https://api.flutter.dev/objcdoc
team,framework,engine,d: api docs,a: existing-apps,P3,team-engine,triaged-engine
low
Major
442,115,843
rust
HIR printing of `async fn` is broken
```rust async fn foo(_: &u8) {} ``` expanded with `rustc --edition 2018 -Z unpretty=hir` yields ```rust async fn foo<'_>(__arg0: &'_ u8) -> ::std::future::from_generator(move || { let __arg0 = __arg0; let _ = __arg0; }) ``` which is not correct. We should drop the `async`, give a return type and print some `{}` around the function body. cc @cramertj
A-pretty,T-compiler,A-HIR,C-bug,A-async-await,AsyncAwait-Triaged
low
Critical
442,136,843
PowerToys
Minimize to tray
Minimize to tray by right clicking the minimize button
Idea-New PowerToy,Product-Window Manager
high
Critical
442,157,569
vscode
Stabilize FileSearchProvider API
@roblourens I created this issue in the hope `FileSearchProvider` is going to get finalized at some point. If yes, maybe add the api-finalization label here. If I'm out of order creating this, or if I've overlooked another issue dealing with its finalization, please close.
feature-request,api,search,on-testplan,api-proposal,search-api
medium
Critical
442,193,765
PowerToys
Apps launch on screen where they were invoked
When clicking on a shortcut or Start Menu item in Monitor 1 I'd like it to launch in Monitor 2. Vice-versa for Monitor 2. If we could teach Windows which apps we like in which monitor over time, and any snap-to preferences while in each monitor that would be awesome!
Idea-Enhancement,Product-Window Manager
low
Major
442,194,841
pytorch
libtorch+opencv Mat result error: different from the python ones
``` #include <torch/script.h> // One-stop header. #include <iostream> #include <memory> #include <string> #include <opencv2/opencv.hpp> using namespace std; using namespace cv; int main(int argc, const char* argv[]) { //加载模型 string model = "model.pt"; // Deserialize the ScriptModule from a file using torch::jit::load(). shared_ptr<torch::jit::script::Module> module = torch::jit::load(model); assert(module != nullptr); cout << "ok"; //load 图像 Mat img=imread("2.jpg"); resize(img, img, Size(224, 224), (0, 0), (0, 0), INTER_LINEAR); img.convertTo(img, CV_32F, 1.0 / 255.0); torch::TensorOptions option(torch::kFloat32); //Mat to Torch at::Tensor img_tensor = torch::from_blob(img.data, { 1,img.channels(),img.rows,img.cols }, option); //prediction at::Tensor result = module->forward({ img_tensor }).toTensor();//result different from python //Torch to Mat Mat prediction(Size(img.cols, img.rows), CV_32FC3, result.data_ptr()); //cout << result; //result = result.unsqueeze(0); //result.accessor<float, 3>(); //cout << result; waitKey(3000); return 0; } ``` ![image](https://user-images.githubusercontent.com/34785633/57451266-631b4000-7293-11e9-9766-07e76c330ee4.png) why there are lines in my results?It's so strange. I tested the model.pt in python and it didnt have such problem. Could you help me? thanks very much !
module: cpp,triaged
low
Critical