id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
435,323,818
TypeScript
Go to definition unnecessary shows export along true definition
<!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ --> <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: 1.33.1 and 1.34.0-insiders - OS Version: Arch Linux Steps to Reproduce: 1. create foo.js ``` function foo() {} module.exports = { foo }; ``` create bar.js ``` const foo = require('./foo'); foo.foo(); ``` 2. In bar.js Ctrl+click on foo() to go to definition. It shows both function definition and export from modules.exports ![2019-04-16-201758_592x252_scrot](https://user-images.githubusercontent.com/1936195/56235129-1757eb00-6087-11e9-9384-332307687b0e.png) <!-- Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes
Bug,Domain: Symbol Navigation
low
Minor
435,334,340
flutter
flutter plugins references to flutter.io should probably be flutter.dev
There are several places where flutter.io appears in the flutter/plugins repo, mostly in method channel names and Android namespaces. We might want to update this to flutter.dev.
team,package,team-ecosystem,P3,p: requires breaking change,triaged-ecosystem
low
Minor
435,336,015
vscode
Yank back killed text `ctrl+y` stopped working
<!-- Please search existing issues to avoid creating duplicates. --> <!-- Also please test using the latest insiders build to make sure your issue has not already been fixed: https://code.visualstudio.com/insiders/ --> <!-- Use Help > Report Issue to prefill these. --> - VSCode Version: 1.33.1 ( Recent ) - OS Version: Mac 10.14.4 Steps to Reproduce: 1. `ctrl+k` to kill text. 2. `ctrl+y` to paste the kill text does not work. <!-- Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes Works on all other program except vscode.
feature-request,macos,editor-commands
medium
Major
435,336,901
flutter
PointerUpEvent can contain non-zero pressure
## Description Pointer-up events are defined as the event when a pointer stops contacting the device, which intuitively should have zero pressure. However, it's possible for a `ui.PointerData` instance with `PointerChange.up` to contain non-zero pressure. It can be reproduced in [devicelab embedded_android_views_integration_test](https://github.com/flutter/flutter/blob/d340e2f229c93229e83fbfdf64475c0576b9b9e3/dev/devicelab/bin/tasks/embedded_android_views_integration_test.dart). This test simulates [this real recording](https://github.com/flutter/goldens/blob/cb8264b1953000a603ecc2659ece3483859438a1/dev/integration_tests/assets_for_android_views/assets/touchEvents) onto an Android device, and among the events received by `PointerEventConverter` such counter-intuitive instances can be found. ## Related Issues - https://github.com/flutter/flutter/pull/30874 tries to remove pressure customization from pointers, but did not end up removing it from `PointerUpEvent` because of this.
team,platform-android,framework,engine,f: gestures,P2,team-android,triaged-android
low
Minor
435,341,033
pytorch
failed to load model which is saved as text format(pickle_protocol=0) instead of binary format
``` import torch import torch.nn as nn class Net(nn.Module): def __init__(self): super(Net, self).__init__() self.l1 = nn.Linear(10, 20) def forward(self, inputs): return {"output": self.l1(inputs).sum()} net = Net() torch.save(net, "torch_save.pkl1", pickle_protocol=0) net_reload = torch.load("torch_save.pkl1", map_location=torch.device('cpu')) ``` with the code as above, pickle_protocol=0, "save" can be successful while load will fail with the error message as below: ``` File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/torch/serialization.py", line 368, in load return _load(f, map_location, pickle_module) File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/torch/serialization.py", line 543, in _load result = unpickler.load() File "/Library/Frameworks/Python.framework/Versions/3.7/lib/python3.7/site-packages/torch/serialization.py", line 493, in persistent_load assert isinstance(saved_id, tuple) AssertionError ``` but, if pickle_protocol=2 for save, the load will succeed. Is it a bug not fixed by pytorch yet or something is wrong with my coding way? Please help. Thank you in advance.
module: pickle,module: serialization,triaged
low
Critical
435,357,396
godot
Setting World2D on a Viewport Node using the World2D of another node breaks ParallaxBackgrounds.
**Godot version:** 3.1.1 Mono 2fbc421 **Issue description:** When you set World2D on a Viewport Node using the World2D of another node everything works as expected except that ParallaxBackgrounds Nodes inside that World2D will not be rendered in the Viewport. Is there any way to fix this?
bug,topic:core,topic:rendering,confirmed
low
Major
435,373,385
godot
Crash for creating viewport render to texture on android gles 2
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** 3.1 stable <!-- Specify commit hash if non-official. --> **OS/device including version:** Color OS 6 (Android V9) GPU Mali G72MP3 <!-- Specify GPU model and drivers if graphics-related. --> **Issue description:** Device crash with this Logcat with attach. <!-- What happened, and what was expected. --> **Steps to reproduce:** [logcat.txt](https://github.com/godotengine/godot/files/3099903/logcat.txt) **Minimal reproduction project:** any usage of viewport to texture will crash. normal usage with camera works fine. i think this is just some corner case. <!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
bug,platform:android,topic:rendering,confirmed
low
Critical
435,378,517
go
math/bits: Division by constant
### What version of Go are you using (`go version`)? <pre>1.12</pre> ### Does this issue reproduce with the latest release? Yes. ### What did you do? When dividing by constant (e.g. `x/5`), Go uses multiplication by a magic constant, instead of using `DIVQ` instruction. However, `bits.Div64` apparently still uses that instruction. ### What did you expect to see? That the following two functions would compile roughly to same code, i.e. there would be no `DIVQ`. func Div(x uint64) (uint64, uint64) { z := x y := x/5 z -= y return y, z } func Div(x uint64) (uint64, uint64) { y, z := bits.Div64(0, x, 5) return y, z } ### What did you see instead? First function compiles to: movq $-3689348814741910323, AX mulq CX shrq $2, DX subq DX, CX The second function includes `DIVQ`. xorl DX, DX movl $5, CX divq CX
Performance,NeedsFix
low
Major
435,382,280
flutter
Colors.{color}[x] not constant
All the sub-colours of all the colours should also be constant. I am not sure why this isn't the case, if it can't be done then it cant be done, but it seems like something that should be done if possible for obvious reasons.
framework,f: material design,c: proposal,P3,team-design,triaged-design
low
Major
435,435,534
rust
Warn on unused `pub fn` in binary targets
```rust pub fn foo() {} fn main() {} ``` gives no warnings today
C-enhancement,A-lints,T-lang
low
Major
435,436,064
rust
Coercion on trait function argument breaks when trait implemented twice
Coercion of `baz` from fn item to fn pointer works only when `Bar` is implemented for `Foo` once. Adding any other implementation breaks coercion and requires manual cast. [Playground](https://play.rust-lang.org/?gist=59a53d2e860d39ef50145b89391f08b9) ```rust fn main() { Foo.bar(baz); // Causes error Foo.bar(baz as fn()); } struct Foo; trait Bar<T> { fn bar(&self, _: T) {} } impl Bar<fn()> for Foo {} impl Bar<()> for Foo {} // Commenting it fixes error fn baz() {} ``` Error: ``` error[E0277]: the trait bound `Foo: Bar<fn() {baz}>` is not satisfied --> src/main.rs:2:9 | 2 | Foo.bar(baz); // Causes error | ^^^ the trait `Bar<fn() {baz}>` is not implemented for `Foo` | = help: the following implementations were found: <Foo as Bar<()>> <Foo as Bar<fn()>> ```
A-trait-system,T-compiler,C-bug,A-coercions
low
Critical
435,440,336
godot
When an exported variable of a tool script is edited in the editor, collision shapes for all instances of that scene are unexpectedly modified
**Godot version:** v3.1 **OS/device including version:** MacBook Pro macOS 10.14.4 **Issue description:** I have a scene that represents a brick wall. I have a single brick texture that should repeat, so I figured I could use a tool script to allow the amount of bricks to be set, and then have the setter update the sprite's region_rect and collision shape's extents accordingly. What actually happens is that, although the sprite repeats as expected for _only_ the instance that was modified, the collision shape extents seem to be modified on _every_ instance of the scene (wall) that was modified: ![Kapture 2019-04-20 at 22 49 39](https://user-images.githubusercontent.com/6002340/56462160-bc8ffd80-63be-11e9-921d-b823124a2589.gif) **Steps to reproduce:** Take the same steps shown in the GIF with the attached minimal project below. **Minimal reproduction project:** [tool-test.zip](https://github.com/godotengine/godot/files/3100596/tool-test.zip)
topic:core,confirmed,documentation
medium
Major
435,441,474
opencv
Building OpenCV for IOS fails w/ code signing error
##### System information (version) - OpenCV => 4.1.0 - Operating System / Platform => MacOS 10.14.4 - XCode => 10.2.1 - Compiler => AppleClang 10.0.1.10010046 - Cmake => 3.5.2 ##### Detailed description Building OpenCV 4.1.0 for IOS fails. The error that sticks out the most is from `build/build-arm64-iphoneos/CMakeFiles/CMakeError.log` (attached) and it states: `error: An empty identity is not valid when signing a binary for the product type 'Application'` There is another error in the stdout (attached) that might be related but seems like a red-herring ``` CMake Error at cmake/OpenCVDetectCXXCompiler.cmake:188 (message): OpenCV 4.x requires C++11 ``` It should be noted that the OSX build doesn't not have this issue on my machine, only the IOS one. Thanks in advance for the help. ##### Steps to reproduce ``` cd $CODE/opencv git checkout tags/4.1.0 mkdir -p $CODE/opencvbuild python $CODE/opencv/platforms/ios/build_framework.py \ --iphoneos_deployment_target 12.2 \ --iphoneos_archs arm64 \ --opencv $CODE/opencv \ $CODE/opencvbuild ``` #### STDOUT ``` Using IPHONEOS_DEPLOYMENT_TARGET=12.2 Using iPhoneOS ARCHS=['arm64'] Using iPhoneSimulator ARCHS=['i386', 'x86_64'] Executing: ['cmake', '-GXcode', '-DAPPLE_FRAMEWORK=ON', '-DCMAKE_INSTALL_PREFIX=install', '-DCMAKE_BUILD_TYPE=Release', '-DOPENCV_INCLUDE_INSTALL_PATH=include', '-DOPENCV_3P_LIB_INSTALL_PATH=lib/3rdparty', '-DIOS_ARCH=arm64', '-DCMAKE_TOOLCHAIN_FILE=/Users/cbabraham/code/opencv/platforms/ios/cmake/Toolchains/Toolchain-iPhoneOS_Xcode.cmake', '-DCPU_BASELINE=DETECT', '/Users/cbabraham/code/opencv', '-DCMAKE_C_FLAGS=-fembed-bitcode', '-DCMAKE_CXX_FLAGS=-fembed-bitcode'] in /Users/cbabraham/code/opencvbuild/build/build-arm64-iphoneos Executing: cmake -GXcode -DAPPLE_FRAMEWORK=ON -DCMAKE_INSTALL_PREFIX=install -DCMAKE_BUILD_TYPE=Release -DOPENCV_INCLUDE_INSTALL_PATH=include -DOPENCV_3P_LIB_INSTALL_PATH=lib/3rdparty -DIOS_ARCH=arm64 -DCMAKE_TOOLCHAIN_FILE=/Users/cbabraham/code/opencv/platforms/ios/cmake/Toolchains/Toolchain-iPhoneOS_Xcode.cmake -DCPU_BASELINE=DETECT /Users/cbabraham/code/opencv -DCMAKE_C_FLAGS=-fembed-bitcode -DCMAKE_CXX_FLAGS=-fembed-bitcode -- Setting up iPhoneOS toolchain for IOS_ARCH='arm64' -- iPhoneOS toolchain loaded -- Setting up iPhoneOS toolchain for IOS_ARCH='arm64' -- iPhoneOS toolchain loaded -- The CXX compiler identification is AppleClang 10.0.1.10010046 -- The C compiler identification is AppleClang 10.0.1.10010046 -- Detecting CXX compiler ABI info -- Detecting CXX compiler ABI info - failed -- Detecting CXX compile features -- Detecting CXX compile features - failed -- Detecting C compiler ABI info -- Detecting C compiler ABI info - failed -- Detecting C compile features -- Detecting C compile features - failed -- Performing Test HAVE_CXX11 (check file: cmake/checks/cxx11.cpp) -- Performing Test HAVE_CXX11 - Failed CMake Error at cmake/OpenCVDetectCXXCompiler.cmake:188 (message): OpenCV 4.x requires C++11 Call Stack (most recent call first): CMakeLists.txt:160 (include) -- Configuring incomplete, errors occurred! See also "opencvbuild/build/build-arm64-iphoneos/CMakeFiles/CMakeOutput.log". See also "opencvbuild/build/build-arm64-iphoneos/CMakeFiles/CMakeError.log". ``` ##### opencvbuild/build/build-arm64-iphoneos/CMakeFiles/CMakeError.log ``` Detecting CXX compiler ABI info failed to compile with the following output: Change Dir: opencvbuild/build/build-arm64-iphoneos/CMakeFiles/CMakeTmp Run Build Command:"opencvbuild/build/build-arm64-iphoneos/xcodebuild_wrapper" "-project" "CMAKE_TRY_COMPILE.xcodeproj" "build" "-target" "cmTC_f2f02" "-configuration" "Debug" Build settings from command line: ARCHS = arm64 IPHONEOS_DEPLOYMENT_TARGET = 12.2 SDKROOT = iphoneos12.2 note: Using new build system note: Planning build note: Constructing build description Build system information error: An empty identity is not valid when signing a binary for the product type 'Application'. (in target 'cmTC_f2f02') ```
category: build/install,platform: ios/osx
low
Critical
435,447,300
godot
TextureRect resizes whole structure width/height
**Godot version:** v3.1-stable **OS/device including version:** Windows 10 Home 64-Bit PC, AMD Threadripper 1950X - 32 GB RAM - 1080Ti **Issue description:** In the Designer, if I add a Texture Rect into a for example HBoxContainer and add an Image that is bigger than my HBoxContainer, the HBoxContainer gets resized to the Imagesize. If I now edit the Size of the Image and set it to "Margin 50 Right, 50 Bottom" and click on the visibility icon of the HBoxContainer in the "Scene" Menu the image gets resized to the width of the full HBoxContainer and the height of 0. Unfortunately the "Output" tab does not show anything additional. **Steps to reproduce:** Create new Project Create Node of Type "Control" Add Node of type "HBoxContainer" Add Node of Type "TextureRect" Import an image ".jpg" Assign the image via drag'n drop to the "Texture" of the TextureRect" Watch the Magic happen **Minimal reproduction project:** [GoDot.zip](https://github.com/godotengine/godot/files/3100643/GoDot.zip)
topic:editor,usability,topic:gui
low
Minor
435,463,644
flutter
Desktop Client Side Decoration support
(accidentally filed at and since moved from https://github.com/google/flutter-desktop-embedding/issues/340) It would be great if desktop embedding supported CSDs. Something to the effect of: ```dart import 'package:csd/csd.dart'; //... Csd.enableIfPossible(); // inside main() // inside a build function AppBar( actions: [ if (Csd.enabled) MyCloseButton(), ] ) ``` I'd be happy to contribute to this, but it seems to be [pending some upstream GLFW stuff](https://github.com/glfw/glfw/pull/1420), unless Flutter does the window drag / resize callbacks manually...
c: new feature,framework,engine,platform-windows,customer: crowd,platform-linux,a: desktop,P3,team-framework,triaged-framework
high
Critical
435,468,716
TypeScript
Using the typechecker tutorial does not work anymore
https://github.com/Microsoft/TypeScript/wiki/Using-the-Compiler-API#using-the-type-checker describes how to use the type checker in the compiler API but the example code does not work with typescript 3.4.
Docs
low
Minor
435,497,418
flutter
Add a way to listen to AnimationController.isAnimating
`AnimationController` possess a public field named `isAnimating`. The issue is, there is no way for a widget to rebuild whenever that value changed. There are currently three scenarios where this value can be updated: - start (after a `.forward`/`.reverse`) - end (after the animation naturally finishes) - paused (a call to `.stop` or potentially muted Tickers). The thing is, a widget can listen to the first two scenarios with an `AnimationStatus` listener. But the pause event is never notified anywhere. _____ A potential use-case is for a play button: ```dart IconButton( icon: Icon(controller.isAnimating ? Icons.stop : Icons.play_arrow), onPressed: () { if (controller.isAnimating) { controller.stop(); } else { controller.forward(); } }, ); ```
c: new feature,framework,a: animation,P3,team-framework,triaged-framework
low
Minor
435,525,689
go
testing: Inconsistent benchmark data when  GOMAXPROCS=1
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.12.4 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Yes. ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/Users/xuanjiazhen/Library/Caches/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/xuanjiazhen/work" GOPROXY="" GORACE="" GOROOT="/Users/xuanjiazhen/Desktop/go" GOTMPDIR="" GOTOOLDIR="/Users/xuanjiazhen/Desktop/go/pkg/tool/darwin_amd64" GCCGO="gccgo" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/w3/64tyfz3n4cs2jw5lrl7mc5c80000gn/T/go-build723171853=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> <pre> $GOMAXPROCS=1 go test runtime -v -run none -bench ^BenchmarkConvT2ILarge$ -count 10 goos: darwin goarch: amd64 pkg: runtime BenchmarkConvT2ILarge 50000000 46.8 ns/op BenchmarkConvT2ILarge 30000000 46.9 ns/op BenchmarkConvT2ILarge 50000000 39.5 ns/op BenchmarkConvT2ILarge 30000000 39.1 ns/op BenchmarkConvT2ILarge 30000000 47.6 ns/op BenchmarkConvT2ILarge 30000000 46.8 ns/op BenchmarkConvT2ILarge 30000000 49.6 ns/op BenchmarkConvT2ILarge 30000000 43.6 ns/op BenchmarkConvT2ILarge 30000000 52.2 ns/op BenchmarkConvT2ILarge 50000000 46.9 ns/op PASS ok runtime 16.874s $GOMAXPROCS=1 go test runtime -v -run none -bench ^BenchmarkConvT2ILarge -count 10 goos: darwin goarch: amd64 pkg: runtime BenchmarkConvT2ILarge 100000000 19.6 ns/op BenchmarkConvT2ILarge 100000000 19.8 ns/op BenchmarkConvT2ILarge 100000000 20.3 ns/op BenchmarkConvT2ILarge 100000000 21.2 ns/op BenchmarkConvT2ILarge 100000000 21.0 ns/op BenchmarkConvT2ILarge 100000000 20.6 ns/op BenchmarkConvT2ILarge 100000000 21.1 ns/op BenchmarkConvT2ILarge 100000000 20.6 ns/op BenchmarkConvT2ILarge 100000000 20.6 ns/op BenchmarkConvT2ILarge 100000000 20.8 ns/op PASS ok runtime 21.803s </pre> ### What did you expect to see? The test results of the two types of writing should be consistent. ### What did you see instead? Test results with $ are much worse than test results without it. <pre> $GODEBUG=gctrace=1 GOMAXPROCS=1 go test runtime -v -run none -bench ^BenchmarkConvT2ILarge -count 10 ... gc 3984 @22.195s 2%: 0.001+0.12+0.001 ms clock, 0.001+0.12/0/0+0.001 ms cpu, 4->4->0 MB, 5 MB goal, 1 P gc 3985 @22.202s 2%: 0.003+0.13+0.001 ms clock, 0.003+0.12/0/0+0.001 ms cpu, 4->4->0 MB, 5 MB goal, 1 P gc 3986 @22.207s 2%: 0.001+0.11+0.001 ms clock, 0.001+0.11/0/0+0.001 ms cpu, 4->4->0 MB, 5 MB goal, 1 P gc 3987 @22.213s 2%: 0.001+0.11+0 ms clock, 0.001+0.11/0/0+0 ms cpu, 4->4->0 MB, 5 MB goal, 1 P gc 3988 @22.218s 2%: 0.001+0.12+0.001 ms clock, 0.001+0.12/0/0+0.001 ms cpu, 4->4->0 MB, 5 MB goal, 1 P gc 3989 @22.224s 2%: 0.001+0.12+0 ms clock, 0.001+0.12/0/0+0 ms cpu, 4->4->0 MB, 5 MB goal, 1 P gc 3990 @22.230s 2%: 0+0.12+0 ms clock, 0+0.12/0/0+0 ms cpu, 4->4->0 MB, 5 MB goal, 1 P gc 3991 @22.236s 2%: 0.001+0.14+0.001 ms clock, 0.001+0.14/0/0+0.001 ms cpu, 4->4->0 MB, 5 MB goal, 1 P 100000000 22.8 ns/op PASS </pre> <pre> $GODEBUG=gctrace=1 GOMAXPROCS=1 go test runtime -v -run none -bench ^BenchmarkConvT2ILarge$ -count 10 ... gc 1052 @18.124s 0%: 0.001+20+0.002 ms clock, 0.001+0.13/0.021/0+0.002 ms cpu, 6->11->5 MB, 10 MB goal, 1 P gc 1053 @18.146s 0%: 0.001+21+0.001 ms clock, 0.001+0.11/0.013/0+0.001 ms cpu, 6->12->6 MB, 11 MB goal, 1 P gc 1054 @18.169s 0%: 0.001+19+0.001 ms clock, 0.001+0.11/0.014/0+0.001 ms cpu, 7->12->5 MB, 12 MB goal, 1 P gc 1055 @18.190s 0%: 0.001+23+0.001 ms clock, 0.001+0.11/0.015/0+0.001 ms cpu, 6->12->6 MB, 10 MB goal, 1 P gc 1056 @18.216s 0%: 0.002+19+0.001 ms clock, 0.002+0.13/0.013/0+0.001 ms cpu, 7->12->5 MB, 12 MB goal, 1 P gc 1057 @18.237s 0%: 0.002+19+0.001 ms clock, 0.002+0.13/0.017/0+0.001 ms cpu, 6->11->5 MB, 10 MB goal, 1 P gc 1058 @18.258s 0%: 0.001+20+0.002 ms clock, 0.001+0.11/0.020/0+0.002 ms cpu, 6->12->6 MB, 11 MB goal, 1 P gc 1059 @18.281s 0%: 0.001+19+0.001 ms clock, 0.001+0.11/0.016/0+0.001 ms cpu, 7->12->5 MB, 12 MB goal, 1 P gc 1060 @18.302s 0%: 0.001+19+0.002 ms clock, 0.001+0.11/0.017/0+0.002 ms cpu, 6->11->5 MB, 11 MB goal, 1 P gc 1061 @18.323s 0%: 0.002+11+0.002 ms clock, 0.002+0.13/0.023/0+0.002 ms cpu, 6->8->2 MB, 10 MB goal, 1 P 50000000 51.7 ns/op PASS ok runtime 18.342s gc 21 @19.662s 0%: 0.015+1.6+0.002 ms clock, 0.015+0.099/0.52/0.90+0.002 ms cpu, 4->4->1 MB, 5 MB goal, 1 P </pre>
NeedsInvestigation
low
Critical
435,531,075
vscode
[folding] Option to show both fold/unfold controls on mouseover only
Like "editor.showFoldingControls": "always", "mouseover", "mouseoverOnly", "never"
feature-request,editor-folding
low
Minor
435,539,218
godot
Gles2 crash on ios
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** 3.1 <!-- Specify commit hash if non-official. --> **OS/device including version:** iOS 12 <!-- Specify GPU model and drivers if graphics-related. --> **Issue description:** godot 3.1 projects crash on startup when gles2 is used. project runs if changed to gles 3. <!-- What happened, and what was expected. --> **Steps to reproduce:** any 3.1 project with gles2 rendering. **Minimal reproduction project:** <!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. -->
bug,platform:ios,crash
low
Critical
435,578,124
godot
Godot C# Parser Fails to Parse Namespace Alias Qualifiers
**Godot version:** v3.1.mono.official **OS/device including version:** Windows 10 **Issue description:** Cannot compile C# script with namespace alias qualifier. Using Visual Studio 2019 MSBUILD. **Minimal reproduction project:** Build with following script ``` using shorthand = System.Collections.Generic; public class KeyExtension : shorthand::KeyNotFoundException {} ``` **Result** ``` modules/mono/editor/csharp_project.cpp:183 - Parse error: Unexpected token: : Failed to determine namespace and class for script: res://Scripts/Card.cs modules/mono/editor/mono_bottom_panel.cpp:168 - Condition ' metadata_err != OK ' is true ``` **Sanity** The above script compiles in Visual Studio Community 2019. If I change the script from using '::' to a '.', it will compile in Godot. EG: ``` using shorthand = System.Collections.Generic; public class KeyExtension : shorthand.KeyNotFoundException {} ``` **Use Case** We are using protoc (Google's Protobuf) to generate C# files for our Godot project. It generates fine on the Golang backend, but the generated C# code will not compile due to it generating namespace aliases. EG (partial generated code): ``` using pb = global::Google.Protobuf; namespace Card { public sealed partial class Card : pb::IMessage<Card> {} } ```
bug,confirmed,topic:dotnet
low
Critical
435,642,482
go
x/net/http/httpguts: add parser/accessors for Link header
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.12.4 linux/amd64 </pre> ### Does this issue reproduce with the latest release? yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/home/user/.cache/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" GOPATH="/home/user/go" GOPROXY="" GORACE="" GOROOT="/usr/lib/go" GOTMPDIR="" GOTOOLDIR="/usr/lib/go/pkg/tool/linux_amd64" GCCGO="gccgo" CC="gcc" CXX="g++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build550614768=/tmp/go-build -gno-record-gcc-switches" </pre></details> ### What did you do? I am consuming an API that implements pagination via the link header, see [RFC5988](http://www.rfc-editor.org/rfc/rfc5988.txt). ### What did you expect to see? I hoped that the std lib would have implemented a parser for this bespoke syntax. This could even be done lazily to prevent overhead. ### What did you see instead? I was forced to grab a 3rd party library (e.g. `github.com/deiu/linkheader`, `github.com/tomnomnom/linkheader`), or implement the parser myself.
NeedsInvestigation,FeatureRequest
low
Critical
435,714,763
flutter
Enable custom location indicator (marker) when using "myLocationEnabled" property
c: new feature,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem
low
Minor
435,720,984
vue-element-admin
编译报错
## Question(提问) window上开发编译,是好的 系统: centos 7.2 node : 10.15.3 ``` npm run dev # 是可以的 ``` ``` [root@hyahm vue]# npm run build:prod > [email protected] build:prod /source/ITflow/vue > cross-env NODE_ENV=production env_config=prod node build/build.js ⠦ building for prod environment...(node:1313) UnhandledPromiseRejectionWarning: Error: Cyclic dependency at visit (/source/ITflow/vue/node_modules/toposort/index.js:35:13) at visit (/source/ITflow/vue/node_modules/toposort/index.js:53:9) at visit (/source/ITflow/vue/node_modules/toposort/index.js:53:9) at Function.toposort [as array] (/source/ITflow/vue/node_modules/toposort/index.js:22:22) at Object.module.exports.dependency (/source/ITflow/vue/node_modules/html-webpack-plugin/lib/chunksorter.js:50:35) at HtmlWebpackPlugin.sortChunks (/source/ITflow/vue/node_modules/html-webpack-plugin/index.js:364:35) at /source/ITflow/vue/node_modules/html-webpack-plugin/index.js:113:21 at AsyncSeriesHook.eval [as callAsync] (eval at create (/source/ITflow/vue/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:41:1) at AsyncSeriesHook.lazyCompileHook (/source/ITflow/vue/node_modules/tapable/lib/Hook.js:154:20) at Compiler.emitAssets (/source/ITflow/vue/node_modules/webpack/lib/Compiler.js:364:19) at onCompiled (/source/ITflow/vue/node_modules/webpack/lib/Compiler.js:231:9) at hooks.afterCompile.callAsync.err (/source/ITflow/vue/node_modules/webpack/lib/Compiler.js:553:14) at AsyncSeriesHook.eval [as callAsync] (eval at create (/source/ITflow/vue/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1) at AsyncSeriesHook.lazyCompileHook (/source/ITflow/vue/node_modules/tapable/lib/Hook.js:154:20) at compilation.seal.err (/source/ITflow/vue/node_modules/webpack/lib/Compiler.js:550:30) at AsyncSeriesHook.eval [as callAsync] (eval at create (/source/ITflow/vue/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:6:1) (node:1313) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 4) ```
not vue-element-admin bug
low
Critical
435,839,683
flutter
Run symbol visibility checks on host builds.
Skia to Flutter engine rolls failed twice over the past couple of weeks. [This was because symbol visibility rules in Skia changed. ](https://skia-review.googlesource.com/c/skia/+/209680)The tests that checked for unexpected symbols being exported were only run on iOS and Android. We should run those same checks for host builds as well (the Embedder targets are a good candidate).
team,engine,dependency: skia,P2,team-engine,triaged-engine
low
Critical
435,850,921
pytorch
[doc] Document general guidelines to work with CUDA async copying and streams
## 📚 Documentation Until very recently, I had never understood when async copying is safe. We should document the exact behaviors about async computing, including: + copying: + Async device2device: the stream synchronization behavior. device2device is always async, regardless of `non_blocking` (IIUC). + Async device2host copy: danger of accessing CPU data without synchronization when host is pinned memory. + Async pinned host2device copy: Always safe. + Async pageable host2device copy: This is also safe. See @colesbury 's reply below. + General compute with streams + GC behavior when computing in S1 on tensors created in S0. Document `tensor.record_stream` please! cc @ezyang @gchanan @zou3519 @bdhirsh @jbschlosser @brianjo @mruberry @ngimel
high priority,module: docs,feature,module: cuda,triaged,better-engineering
low
Major
435,855,120
godot
Add a "strict mode"-type project setting that enables assertions on failed connect() calls
Currently, refactoring code can easily leave connect calls failing without any obvious/immediate indication. Rather than make users wrap all connect calls in asserts assert(connect("body_entered", self, "_on_body_entered") == OK) there could be a project setting that causes connect() to automatically assert upon failure. Naturally, this would only happen for debug builds. I imagine settings for "strict mode"-type stuff could be quite useful in general, since a lot of errors are only caught at runtime.
enhancement,topic:core
low
Critical
435,860,537
TypeScript
[Feature request] allow use `as const` + `type` or `interface`
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section. --> ## Search Terms <!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily --> ## Suggestion <!-- A summary of what you'd like to see added or changed --> ## Use Cases allow use `as const` + `type` or `interface` so we can make sure `as const` is follow `type` or `interface` ## Examples check `as const` output is follow `IVueCliPrompt[]` .ts ```ts interface IVueCliPrompt { name: string, type: 'confirm' | string, message: string, default: unknown } const prompts = [ { name: 'replaceFiles', type: 'confirm', message: 'Replace current files with preset files?', default: false }, ] as const IVueCliPrompt[]; export = prompts ``` .d.ts ```ts declare const prompts: readonly [{ readonly name: "replaceFiles"; readonly type: "confirm"; readonly message: "Replace current files with preset files?"; readonly default: false; }]; export = prompts; ``` ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [ ] This could be implemented without emitting different JS based on the types of the expressions * [ ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [ ] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,In Discussion
medium
Critical
435,901,137
pytorch
[jit] Do aten::values dispatch at build time instead of runtime
Dict flattening currently goes through `dictValues`, which does a type check and dynamic dispatch to generate the output for the op according to the schema. But, we can know the possible types statically, and we can use distinct `Operation`s for all of them, which will improve interpreter perf. cc @suo
oncall: jit,triaged
low
Minor
435,915,778
TypeScript
Compiling async/await to ES5 may fail to warn about missing Promise constructor
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs section! Please help us by doing the following steps before logging an issue: * Search: https://github.com/Microsoft/TypeScript/search?type=Issues * Read the FAQ: https://github.com/Microsoft/TypeScript/wiki/FAQ Please fill in the *entire* template below. --> <!-- Please try to reproduce the issue with `typescript@next`. It may have already been fixed. --> **TypeScript Version:** 3.3.4000, 3.4.4, 3.5.0-dev.20190420 <!-- Search terms you tried before logging this (so others can find this issue more easily) --> **Search Terms:** async, ES5, promise, return value **Code** ```ts async function helper() { await fetch('https://www.example.com'); return true; } export async function main() { await helper(); } ``` **Expected behavior:** When targeting `es5`, I expect this example to fail to type check because there is no `Promise` constructor in scope. **Actual behavior:** This code type checks successfully, but will not work at runtime. **Playground Link:** N/A; playground does not expose the full set of compiler options, and so I am not able to reproduce this issue there. See https://github.com/jwmerrill/ts-promise-repro for a full working example. **Related Issues:** https://github.com/Microsoft/TypeScript/pull/30790 (possibly?) **Additional notes:** See https://github.com/jwmerrill/ts-promise-repro for a working minimal example. Note that if the return statement in `helper()` is omitted, I see the error that I expect to see, which is ``` error TS2468: Cannot find global value 'Promise'. src/fails.ts:1:16 - error TS2705: An async function or method in ES5/ES3 requires the 'Promise' constructor. Make sure you have a declaration for the 'Promise' constructor or include 'ES2015' in your `--lib` option. 1 async function helper() { ~~~~~~ ``` A related example that I expect to fail to type check when targeting ES5, but which does type check, is ```ts export async function main() { await fetch('https://www.example.com'); } ``` The compiler configuration I'm using is ```json { "compilerOptions": { "target": "es5", "module": "commonjs", "strict": true, "esModuleInterop": true } } ```
Bug
low
Critical
435,919,572
flutter
Support querying display refresh rate in engine for iOS and setup 120fps benchmarks on iPad Pro
Related with https://github.com/flutter/flutter/issues/27259 The Android part is done in https://github.com/flutter/engine/pull/7002
c: new feature,platform-ios,engine,c: performance,customer: alibaba,P2,team-ios,triaged-ios
low
Major
435,925,378
go
cmd/vet: bombs out before reporting all errors
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? <pre> % go version go version devel +68d4b1265e Sat Apr 20 19:34:03 2019 +0000 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? yes ### What did you do? ``` (~/devel/vet) % ls go.mod go.sum tools.go (~/devel/vet) % cat go.mod module github.com/davecheney/vetbug go 1.13 require mvdan.cc/unparam v0.0.0-20190310220240-1b9ccfa71afe (~/devel/vet) % cat tools.go // +build tools package main import _ "mvdan.cc/unparam" ``` ### What did you expect to see? ``` % go vet # github.com/davecheney/vetbug ./tools.go:1:1: +build comment must appear before package clause and be followed by a blank line tools.go:4:8: import "mvdan.cc/unparam" is a program, not an importable package ``` ### What did you see instead? ``` (~/devel/vet) % go vet tools.go:4:8: import "mvdan.cc/unparam" is a program, not an importable package ``` The failure to report the incorrect build tag on line 1 is masked by the complaint about the non importable package.
NeedsInvestigation,Analysis
low
Critical
435,943,163
godot
Collider returns an Object. no access to .Name
**Godot version:** 3.1 Mono Windows 10, i5, GTX1050 Trying to convert the following into C#: `var collision = get_slide_collision(idx) if collision.collider.name == 'Danger':` `KinematicCollision2D collision = GetSlideCollision(i);` Doing `collison.Collider` doesn't expose the name property.
enhancement,topic:core,topic:physics,topic:dotnet
low
Major
435,945,993
material-ui
[Modal] Better focus management
Current(master) focus-management is broken for shift+tab, while _forward tapping_ is also working not as expected, as long as you may leave a modal, and got into browser address line, which is good, but should be impossible. A new `TrapFocus` implementation also does not seems to be correct, especially due to the absence of `RootRef`, used to discover nested portals (like here - https://nk7zmp3900.codesandbox.io/) - [x] This is not a v0.x issue. <!-- (v0.x is no longer maintained) --> - [x] I have searched the [issues](https://github.com/mui-org/material-ui/issues) of this repository and believe that this is not a duplicate. ## Expected Behavior 🤔 - loop then tabbing forward - loop then tabbing backwards ## Current Behavior 😯 - loop then tabbing forward, with focus on body and modal after leaving browser address bar - causing 1 or 2 _tabs_ without visible response. - does not loop backwards. A new `TrapFocus` would probably fix it, but might introduce other issues. ## Steps to Reproduce 🕹 See an example with 3 buttons inside a modal - https://codesandbox.io/s/j1ll74o3v9 ## Context 🔦 Sorry, I have a professional deformation :) I've invested too much time in focus management, and all focus-related problems are _visible_ to me. ## Proposed solution Replace `TrapFocus` by [react-focus-lock](https://github.com/theKashey/react-focus-lock), which would handle all edge cases including Portals. There is only one downside of it - +4kb.
accessibility,component: modal,component: FocusTrap
low
Critical
435,970,196
pytorch
cudnn conv doesn't check batch_size > 0
## 🐛 Bug ```py In [1]: import torch In [2]: c = torch.nn.Conv2d(3, 3, 3) In [5]: x = torch.randn(0, 3, 3, 3) In [6]: c(x) Out[6]: tensor([], size=(0, 3, 1, 1), grad_fn=<MkldnnConvolutionBackward>) In [7]: c = c.cuda() x In [8]: c(x.cuda()) --------------------------------------------------------------------------- RuntimeError Traceback (most recent call last) <ipython-input-8-265f16c6653b> in <module> ----> 1 c(x.cuda()) /data/packages/pytorch/torch/nn/modules/module.py in __call__(self, *input, **kwargs) 491 result = self._slow_forward(*input, **kwargs) 492 else: --> 493 result = self.forward(*input, **kwargs) 494 for hook in self._forward_hooks.values(): 495 hook_result = hook(self, input, result) /data/packages/pytorch/torch/nn/modules/conv.py in forward(self, input) 337 _pair(0), self.dilation, self.groups) 338 return F.conv2d(input, self.weight, self.bias, self.stride, --> 339 self.padding, self.dilation, self.groups) 340 341 RuntimeError: cuDNN error: CUDNN_STATUS_BAD_PARAM ```
module: cudnn,module: cuda,module: error checking,triaged
low
Critical
435,997,298
go
encoding/base64: decoder output depends on chunking of underlying reader
The output of a decoder produced from Encoding.NewDecoder differs depending on how you chunk the input to it. I noticed these differences: 1. The decoder may ignore "internal" padding (`=` characters not at the end of the stream). For example, decoding `["QQ==Qg=="]` (correctly) results in an error, but `["QQ==", "Qg=="]` (incorrectly) decodes to `"AB"`. 2. The byte offset in error messages may get reset to 0 instead of indicating the absolute offset in the stream. For example, decoding `["AAAA####"]` says the error occurs at offset 4, but decoding `["AAAA" "####"]` says the error occurs at offset 0. I think that the output of a decoder should always be the same as if the entire Reader were serialized to a string and then passed to DecodeString. Item 1 is more important IMO. Item 2 was unexpected but I can live with inconsistent byte offsets in error messages. However seeing as CorruptInputError is already an int64, it would be nice to have if it doesn't complicate the internals too much. This bug is somewhat similar to #25296 for encoding/base32. ### What version of Go are you using (`go version`)? <pre> $ go version go version go1.11.5 linux/amd64 </pre> ### Does this issue reproduce with the latest release? Yes, using go1.12 on play.golang.org ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOHOSTARCH="amd64" GOHOSTOS="linux" GOOS="linux" </pre></details> ### What did you do? https://play.golang.org/p/6rcDYtro36S ``` package main import ( "encoding/base64" "fmt" "io" "io/ioutil" ) func test(chunks []string) { fmt.Printf("\n") fmt.Printf("%+q\n", chunks) pr, pw := io.Pipe() go func() { for _, chunk := range chunks { pw.Write([]byte(chunk)) } pw.Close() }() dec := base64.NewDecoder(base64.StdEncoding, pr) output, err := ioutil.ReadAll(dec) fmt.Printf("%+q %v\n", output, err) } func main() { fmt.Printf("DecodeString(%+q)\n", "QQ==Qg==") output, err := base64.StdEncoding.DecodeString("QQ==Qg==") fmt.Printf("%+q %v\n", output, err) fmt.Printf("DecodeString(%+q)\n", "AAAA####") output, err = base64.StdEncoding.DecodeString("AAAA####") fmt.Printf("%+q %v\n", output, err) for _, chunks := range [][]string{ {"QQ==Qg=="}, {"Q", "Q==Qg=="}, {"QQ==", "Qg=="}, {"QQ==Qg=", "="}, {"Q", "Q", "=", "=", "Q", "g", "=", "="}, {"AAAA####"}, {"AAAA", "####"}, } { test(chunks) } } ``` ### What did you expect to see? ``` DecodeString("QQ==Qg==") "A" illegal base64 data at input byte 4 DecodeString("AAAA####") "\x00\x00\x00" illegal base64 data at input byte 4 ["QQ==Qg=="] "A" illegal base64 data at input byte 4 ["Q" "Q==Qg=="] "A" illegal base64 data at input byte 4 ["QQ==" "Qg=="] "A" illegal base64 data at input byte 4 ["QQ==Qg=" "="] "A" illegal base64 data at input byte 4 ["Q" "Q" "=" "=" "Q" "g" "=" "="] "A" illegal base64 data at input byte 4 ["AAAA####"] "\x00\x00\x00" illegal base64 data at input byte 4 ["AAAA" "####"] "\x00\x00\x00" illegal base64 data at input byte 4 ``` ### What did you see instead? ``` DecodeString("QQ==Qg==") "A" illegal base64 data at input byte 4 DecodeString("AAAA####") "\x00\x00\x00" illegal base64 data at input byte 4 ["QQ==Qg=="] "A" illegal base64 data at input byte 4 ["Q" "Q==Qg=="] "A" illegal base64 data at input byte 4 ["QQ==" "Qg=="] "AB" <nil> ["QQ==Qg=" "="] "AB" <nil> ["Q" "Q" "=" "=" "Q" "g" "=" "="] "AB" <nil> ["AAAA####"] "\x00\x00\x00" illegal base64 data at input byte 4 ["AAAA" "####"] "\x00\x00\x00" illegal base64 data at input byte 0 ```
help wanted,NeedsFix
low
Critical
436,045,233
flutter
Dismissible when used in conjunction with PageView is obstructing access to PageView
When in a PageView, there's a ListView in first page whose items are dismissible from `DismissibleDirection,startToEnd` which is opposite of the swiping action required to reach the second page in the `PageView`, the swiping does nothing. I can understand if the direction of dismissing is the same as that of transitioning from one page to another and can be argued that the design is weak, but when the direction is opposing, surely there must be a way to give priority to the gestures. I think [**this**](https://stackoverflow.com/questions/55369200/dismissible-in-listview-picks-up-swipes-from-pageview) is a related question that has been unanswered. Now, I've read across issues of such nature that when two gesture related widgets are conflicting, then the child gets the preference. But in this case, the direction is opposite and so I would think PageView's transition would take place. How to resolve this? Code to reproduce the said issue: ``` import 'package:flutter/material.dart'; class Demo extends StatelessWidget { final List<int> nums = [1, 2, 3, 4, 5, 6, 7, 8, 9, 10]; Widget buildItem(int n) { if (n % 2 == 0) { return Dismissible( key: Key('$n'), child: ListTile( title: Text('$n'), subtitle: Text('Dismissible'), ), direction: DismissDirection.startToEnd, onDismissed: (_) { print('Dismissed!'); }, ); } return ListTile(title: Text('$n'), subtitle: Text('Non Dismissible')); } @override Widget build(BuildContext context) { return Scaffold( body: PageView( children: <Widget>[ ListView.builder( itemBuilder: (context, n) { return buildItem(nums[n]); }, itemCount: nums.length, ), Container( child: Center( child: Padding( padding: EdgeInsets.all(20.0), child: Text( 'I am unreachable if you swipe on even number, but odd is okay.'), )), ) ], )); } } ```
c: new feature,framework,f: material design,f: gestures,P3,team-design,triaged-design
low
Major
436,045,249
kubernetes
proxy protocol support in kube-apiserver
**What would you like to be added**: Proxy Protocol support for kube-apiserver **Why is this needed**: When inspecting audit logs I've noticed load balancer private address is passed to the API - this makes bit harder to inspect API usage. Currently when enabling audit logs and enabling proxy-protocol on AWS ELB results in: ``` ➜ ~ k cluster-info To further debug and diagnose cluster problems, use 'kubectl cluster-info dump'. Unable to connect to the server: remote error: tls: record overflow ``` I'd like to see real-user-IP address in audit logs.
priority/awaiting-more-evidence,sig/api-machinery,kind/feature,sig/auth,triage/accepted
high
Critical
436,048,124
create-react-app
[v3] PostCSS module imports use relative path instead of baseUrl
### Is this a bug report? Yes ### Did you try recovering your dependencies? Yes ### Environment ``` Environment Info: System: OS: Linux 4.15 Ubuntu 18.04.2 LTS (Bionic Beaver) CPU: (8) x64 Intel(R) Core(TM) i7-7700K CPU @ 4.20GHz Binaries: Node: 10.15.3 - ~/.nvm/versions/node/v10.15.3/bin/node Yarn: 1.15.2 - ~/.yarn/bin/yarn npm: 6.9.0 - ~/.nvm/versions/node/v10.15.3/bin/npm Browsers: Chrome: 73.0.3683.86 Firefox: 66.0.3 npmPackages: react: 16.8.6 => 16.8.6 react-dom: 16.8.6 => 16.8.6 react-scripts: 3.0.0 => 3.0.0 npmGlobalPackages: create-react-app: Not Found ``` ### Steps to Reproduce Given the project structure: ``` src/ - components/ ---- YoutubePlaylist.tsx ---- YoutubePlaylist.module.css - res/ ---- breakpoints.css tsconfig.json ``` 1. Configure baseUrl in tsconfig.json (or jsconfig.json) ```json { "compilerOptions": { "baseUrl": "src", } } ``` 2. Use the following code snippet anywhere in a CSS module ``` @value tablet from "res/breakpoints.css"; ``` 2. Run `npm start` 3. See the following error message: ``` Failed to compile. ./src/components/YoutubePlaylist.module.scss (./node_modules/css-loader/dist/cjs.js??ref--6-oneOf-6-1!./node_modules/postcss-loader/src??postcss!./node_modules/sass-loader/lib/loader.js??ref--6-oneOf-6-3!./src/components/YoutubePlaylist.module.scss) Module not found: Can't resolve './res/breakpoints.css' in '/home/jamsch/Documents/test-site/client/src/components' ``` ### Expected Behavior Module resolution should be relative to the src directory. ### Actual Behavior Module resolution attempts to resolve relative to the directory the file is importing from. ### Additional info I had this configured for v2 using aliases, react-app-rewired, & customize-cra **./config-overrides.js** ```js const path = require("path"); const { override, addWebpackAlias } = require("customize-cra"); module.exports = override( addWebpackAlias({ "~": path.resolve(__dirname, "src") }) ); ``` **./tsconfig.json** -- CRA was hard removing paths so I was forced to do this: ```json { "extends": "./paths.json", } ``` **./paths.json** ```json { "compilerOptions": { "baseUrl": "src", "rootDir": ".", "paths": { "~/*": ["*"] } } } ``` **./src/components/YoutubePlaylist.module.scss** ``` @value tablet from "~/res/breakpoints.css"; ``` On v2 this works fine, but on v3 it seems to import from the root dir. ```Module not found: You attempted to import ../../../../../../../../../res/breakpoints.css which falls outside of the project src/ directory. Relative imports outside of src/ are not supported.```
issue: needs investigation
low
Critical
436,121,156
create-react-app
:global() css stopped working in CRA v3.
<!-- PLEASE READ THE FIRST SECTION :-) --> ### Is this a bug report? Yes ### Did you try recovering your dependencies? Yes. yarn 1.15.2 ### Which terms did you search for in User Guide? global css modules global styles ### Environment Environment: OS: Windows 10 Node: 8.11.1 Yarn: 1.15.2 npm: 6.4.1 Watchman: Not Found Xcode: N/A Android Studio: Version 3.3.0.0 AI-182.5107.16.33.5314842 Packages: (wanted => installed) react: ^16.8.6 => 16.8.6 react-dom: ^16.8.6 => 16.8.6 react-scripts: 3.0.0 => 3.0.0 ### Expected Behavior I expected the global styles to work like previously. On (CRA v2) I was using `:global(a) { ... }` in my index.scss file to set global style for links. After upgrading to CRA v3 it stopped working. ### Actual Behavior Global styles are ignored. ### Reproducible Demo https://codesandbox.io/s/20w902rmk0 I tried to create another demo to show it working on the previous CRA version, but it didn't work. Strange. Perhaps I misunderstood global styles, but I have no clue why it's been working for me for over a year until now.
issue: needs investigation
low
Critical
436,191,565
TypeScript
Avoid nesting IIFE for nested namespaces
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section. --> ## Search Terms iife namespace nest ## Suggestion Produce a single IIFE for a nested namespace, where applicable. The point is to reduce onion-like layering in scenarios where it is both trivial and safe to do. There would still be at least 1 level of IIFE wrapping. **Every aspect** of runtime/semantic/scoping behaviours is **preserved** as in the current emit. ## Example <a href="https://www.typescriptlang.org/play/#src=namespace%20A.B.C%20%7B%0D%0A%20%20%20%20export%20function%20some()%20%7B%0D%0A%20%20%20%20%20%20%20%20return%20'A.B.C.some'%3B%0D%0A%20%20%20%20%7D%0D%0A%7D%0D%0A%0D%0Avar%20A1%3B%0D%0A(function%20(A1)%20%7B%0D%0A%20%20%20%20var%20B1%20%3D%20A1.B1%20%7C%7C%20(A1.B1%20%3D%20%7B%7D)%3B%0D%0A%20%20%20%20var%20C1%20%3D%20B1.C1%20%7C%7C%20(B1.C1%20%3D%20%7B%7D)%3B%0D%0A%20%20%20%20function%20some()%20%7B%0D%0A%20%20%20%20%20%20%20%20return%20'A1.B1.C1.some'%3B%0D%0A%20%20%20%20%7D%0D%0A%20%20%20%20C1.some%20%3D%20some%3B%0D%0A%7D)(A1%20%7C%7C%20(A1%20%3D%20%7B%7D))%0D%0A%0D%0Aalert(A.B.C.some())%3B%0D%0Aalert(A1.B1.C1.some())%3B">TypeScript Playground</a> <table> <tr><th> TypeScript </th><th> JavaScript </th></tr> <tr><td> ```ts namespace A.B.C { export function some() { return 'A.B.C.some'; } } ``` </td><td> ```js var A; (function (A) { var B; (function (B) { var C; (function (C) { function some() { return 'A.B.C.some'; } C.some = some; })(C = B.C || (B.C = {})); })(B = A.B || (A.B = {})); })(A || (A = {})); ``` </td></tr> <tr><th></th><th>desired JavaScript</th></tr> <tr><td></td> <td> ```js var A; (function (A) { var B = A.B || (A.B = {}); var C = B.C || (B.C = {}); function some() { return 'A.B.C.some'; } C.some = some; })(A || (A = {})); ``` </td></tr> </table> ## Use Cases Nested IIFE can affect performance, epecially in older/constrained environments. Of course, in general case they cannot be avoided, as they create lexical scopes and may have code living in all those nesting levels. But there are several easy-to-detect scenarios where avoiding IIFE infestation is cheap and easy: * `namespace A.B.C` with single statement of dot-separated nest chain * `namespace A { namespace B {} }` with namespace having a single AST node child of another namespace * may have 2 slightly different cases depends on `export` modifier * combination of the above Note that this feature only affects JS emits, but not parsing neither declaration handling. Also, this may feel related to <a href="https://github.com/Microsoft/TypeScript/issues/447"><b>#447</b> Partial modules and output optimization</a>, but the suggestion there is much more broad and heavy to implementation. Here I do not suggest merging of scopes, just eliminating an easy-to-detect subset of empty scopes that have no code in them. ## Non-targeted cases 1. This feature explicitly DOES NOT suggest merging consecutive scopes, whether in one file or multiple (that may be a valid thing to do elsewhere). 2. This feature explicitly DOES NOT suggest eliding scopes that have code in them (that would be an error, and should be tested against by a valid implementation). 3. This feature explicitly DOES NOT intend to elide all possible scopes/layers, only a very few specific easy to check cases. ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Critical
436,194,928
rust
`Cow<T>` does not implement `ToOwned`
I think it would be reasonable to implement `ToOwned<Target = <T as ToOwned>::Target>` for `Cow<T>`. The inherent `into_owned` method on `Cow` does exactly what I'd expect from `to_owned`, but `to_owned` does not exist on `Cow`.
T-libs-api,C-feature-request
low
Minor
436,195,881
rust
Compiler confused about lifetime when calling mutable method
The compiler wants the function parameter to outlive the call block in this example, but it's not clear why. It only happens if I call a method takes &mut self. Example snippet https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=fc4b17ad3403da39389481dfb43fac9d ```rust struct Demo<T>(Option<T>); struct Obj { a: Vec<u8>, b: Vec<u8>, } impl<T> Demo<T> { fn non_mut_self(&self, _: &T) {} fn mut_self(&mut self, _: &T) {} fn something(&mut self) {} } fn happy(s: impl Iterator<Item = Result<Obj, ()>>) { let mut demo = Demo(None); for obj in s { let obj = obj.unwrap(); let pair = (&obj.a, &obj.b); demo.non_mut_self(&pair); // << happy borrow } demo.something(); } fn sad(s: impl Iterator<Item = Result<Obj, ()>>) { let mut demo = Demo(None); for obj in s { let obj = obj.unwrap(); let pair = (&obj.a, &obj.b); demo.mut_self(&pair); // << sad borrow } demo.something(); } fn main() { happy(vec![Ok(Obj { a: vec![], b: vec![] })].into_iter()); sad(vec![Ok(Obj { a: vec![], b: vec![] })].into_iter()); } ``` ``` error[E0597]: `obj.a` does not live long enough --> src/main.rs:28:21 | 28 | let pair = (&obj.a, &obj.b); | ^^^^^^ borrowed value does not live long enough 29 | demo.mut_self(&pair); // << sad borrow 30 | } | - `obj.a` dropped here while still borrowed 31 | demo.something(); | ---- borrow later used here ```
C-enhancement,A-diagnostics,A-lifetimes,T-compiler
low
Critical
436,230,316
godot
Input lag when working with big scenes
**Godot version:** 3.2 49b6423 **OS/device including version:** Ubuntu 18.04 and also Windows 10 **Issue description:** If I working with bigger scene and engine is under heavy load and then I click on the UP key for e.g. 10 seconds to change selection in scene tree, then engine stops operation a few seconds after releasing the key. **Steps to reproduce:** https://streamable.com/kmcuo I stop pressing RIGHT button at 0:10 and Godot stops selecting nodes at 0:16 **Minimal reproduction project:** TPS Demo
bug,platform:linuxbsd,topic:editor,confirmed
low
Major
436,280,212
opencv
`minAreaRect` error with Intel C++ compiler
<!-- If you have a question rather than reporting a bug please go to http://answers.opencv.org where you get much faster responses. If you need further assistance please read [How To Contribute](https://github.com/opencv/opencv/wiki/How_to_contribute). Please: * Read the documentation to test with the latest developer build. * Check if other person has already created the same issue to avoid duplicates. You can comment on it if there already is an issue. * Try to be as detailed as possible in your report. * Report only one problem per created issue. This is a template helping you to create an issue which can be processed as quickly as possible. This is the bug reporting section for the OpenCV library. --> ##### System information (version) <!-- Example - OpenCV => 3.4.6 - Operating System / Platform => Ubuntu 16.04.6 - Compiler => Intel® C++ Compiler (icc & icpc) --> - OpenCV => 3.4.6 & 3.4.5 - Operating System / Platform => Ubuntu 16.04.6 - Compiler => Intel® C++ Compiler Intel® System Studio 2019 (update 3) Ultimate Edition with icc & icpc version 9.0.3.206 (gcc version 5.4.0 compatibility), student license. ##### Detailed description <!-- your description --> I installed Intel® System Studio 2019 (update 3) Ultimate Edition on latest Ubuntu 16.04. I compiled OpenCV 3.4.6 with icc & icpc. When I run `cv::minAreaRect(std::vector<cv::Point>)`, An error report as following: ```bash terminate called after throwing an instance of 'cv::Exception' what(): OpenCV(3.4.6) /home/sp/opt/opencv-3.4.6/modules/imgproc/src/rotcalipers.cpp:166: error: (-215:Assertion failed) orientation != 0 in function 'rotatingCalipers' Aborted (core dumped) ``` So is OpenCV 3.4.5. When I use OpenCV Comiled with GCC 5.4.0, there is no error. I have test on four machines. Only one of them has no error. - A: i7 8850U without standalone gpu: no error - B: i7 8850U without standalone gpu: has error - C: i5 8300H without standalone gpu: has error - D: i7 4712HQ without standalone gpu: has error A, B and C all begin to test after reinstalling Ubuntu 16.04. All these machines has same config files, including installing required packages. ##### Steps to reproduce I use following configure command to compile OpenCV 3.4.6 with its contrib files. ```bash # in ~/.bashrc source /opt/intel/system_studio_2019/bin/compilervars.sh export CC='icc' export CXX='icpc' # install required packages sudo apt-get install -y v4l* libv4* cutecom htop vim sudo apt-get install -y build-essential rar cpufrequtils libusb-1.0-0 libusb-dev libhdf5-dev sudo apt-get install -y cmake git libgtk2.0-dev pkg-config libavcodec-dev libavformat-dev libswscale-dev sudo apt-get install -y libtbb2 libtbb-dev libjpeg-dev libpng-dev libtiff-dev libjasper-dev libdc1394-22-dev # [optional] sudo apt-get install -y libavcodec-dev libavformat-dev libswscale-dev libv4l-dev liblapacke-dev sudo apt-get install -y libxvidcore-dev libx264-dev sudo apt-get install -y libatlas-base-dev gfortran sudo apt-get install -y ffmpeg sudo apt-get install -y libopenblas-dev libgflags-dev libgeotiff-dev libgtkglext1-dev libdc1394-22-dev libgphoto2-dev libavresample-dev sudo apt-get install -y libgstreamer-plugins-base1.0-dev libgstreamer1.0-dev sudo apt-get install -y libeigen3-dev # cmake command cmake -D CMAKE_BUILD_TYPE=RELEASE \ -D CMAKE_INSTALL_PREFIX=/usr/local \ -D INSTALL_PYTHON_EXAMPLES=OFF \ -D INSTALL_C_EXAMPLES=OFF \ -D OPENCV_EXTRA_MODULES_PATH=/home/sp/opt/opencv-3.4.6/opencv_contrib-3.4.6/modules \ -D WITH_OPENBLAS=ON \ -D WITH_GTK_2_X=ON \ -D WITH_TBB=ON \ -D WITH_V4L=ON \ -D WITH_LIBV4L=ON \ -D WITH_GTK=ON \ -D WITH_OPENGL=ON \ -D WITH_OPENMP=ON \ -D WITH_OPENCL=ON \ -D WITH_TBB=ON \ -D WITH_IPP=ON \ -D BUILD_DOCS=OFF \ -D BUILD_PERF_TESTS=OFF \ -D BUILD_TESTS=OFF \ -D WITH_CSTRIPES=ON \ -D BUILD_EXAMPLES=OFF .. # compile make -j10 # install sudo make install -j4 ``` if I compile OpenCV with GCC 5.4.0 by commenting `export CC='icc'` and `export CXX='icpc'` in `~/.bashrc`,everthing goes well. I have no idea what happened during the process of compiling. Hope someone can give some ideas.
incomplete
low
Critical
436,286,769
flutter
Improve fuzzy check for text selection handles
iOS text selection handles were fixed in https://github.com/flutter/flutter/pull/31332, but a hacky approximation had to be used to account for rounding error. It was suggested that the same effect could be achieved without the approximation and without all the breaking changes required to fix the rounding error: https://github.com/flutter/flutter/pull/31332#discussion_r277470613 We should remove the approximation as discussed to avoid relying on errors in the engine.
framework,a: typography,c: proposal,P2,team-framework,triaged-framework
low
Critical
436,295,182
kubernetes
Allow probes to run on a more granular timer.
<!-- Please only use this template for submitting enhancement requests --> **What would you like to be added**: For posterity: ```golang type Probe struct { InitialDelaySeconds int32 TimeoutSeconds int32 PeriodSeconds int32 ... } ``` Probes today take all their specified timeouts and delays in **seconds**. I feel like that arbitrarily sets a lower bound on pod readiness of at least 1 second. For usual operations of K8s workloads, that's all fine. When looking at serverless workloads, where a quick startup of new containers is key and directly reflected in the end user's latency. Can these be `Duration` instead, so the user can define the granularity like she pleases? **Why is this needed**: To make workloads with very sensitive startup latency (like serverless workloads) easier to implement on Kubernetes. --- Sorry if this is a duplicate, I haven't found a similar issue.
sig/node,kind/feature,lifecycle/frozen,needs-triage
medium
Major
436,321,280
go
x/tools/go/packages: implement Load-ing package ids
`packages.Load` should be able to load packages based on their ids. We've decided that ids **will** persist across calls to `Load`, so there's no reason for us to not allow this. It also enables use cases of Load where one call rounds up a set of packages and the second requests detailed info about them.
NeedsInvestigation,Tools
low
Minor
436,337,259
rust
Inconsistent whitespace definitions in string literals and language itself
Lexer uses Pattern_White_Space unicode property when skipping over trivia. However, when we process string literals with escaped newlines, we only skip ASCII whitespace: https://github.com/rust-lang/rust/blob/fe0a415b4ba3310c2263f07e0253e2434310299c/src/libsyntax/parse/mod.rs#L379 Here's an example program that shows that U+200F is ignored in program text, but not in the string literal https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=ec59778d31dde69f29f1095aff2c9b66 Here's the text of the program in Debug format, to make whitespace slightly more visible ``` "fn main() {\n\u{200f}\u{200f}\u{200f}\n let s = \"\\\n\u{200f}\u{200f}\u{200f}hello\n\";\n println!(\"{:?}\", s);\n} \n" ```
A-frontend,A-parser,A-Unicode,T-compiler,C-bug
low
Critical
436,340,508
rust
Tracking issue for future-incompatbility warning 'invalid literal suffix on tuple index' (not a lint)
This is the **summary issue** for a bug fix related to tuple indexing. The goal of this page is describe why this change was made and how you can fix code that is affected by it. It also provides a place to ask questions or register a complaint if you feel the change should not be made. For more information on the policy around future-compatibility warnings, see our [breaking change policy guidelines][guidelines]. [guidelines]: https://forge.rust-lang.org/rustc-bug-fix-procedure.html ### What is the warning for? As reported in https://github.com/rust-lang/rust/issues/59418, the compiler incorrectly accepts `foo.0_u32` (and other suffixes) when indexing into tuples. The expected syntax is simply `foo.0`. We are presently issuing **warnings** when this incorrect syntax is used but we expect to transition those warnings to **errors** in the future. ### How can you fix your code? Most often this error manifests in procedural macros that employ the `syn` or `quote` crates. It can be avoided by using `syn::Index::from` or `proc_macro::Literal::*_unsuffixed`. For example, if before you were generating `foo.0` doing something like this: ```rust let i = 0; quote! { foo.$i } ``` you might now do instead: ```rust let i = syn::Index::from(0); quote! { foo.$i } ``` ### When will this warning become a hard error? At the beginning of each 6-week release cycle, the Rust compiler team will review the set of outstanding future compatibility warnings and nominate some of them for **Final Comment Period**. Toward the end of the cycle, we will review any comments and make a final determination whether to convert the warning into a hard error or remove it entirely. ### Related bugs Here are some of the regressions found in the wild: - https://github.com/rust-lang/rust/issues/59553 - https://github.com/rust-lang/rust/issues/60138
A-frontend,A-parser,T-lang,C-future-incompatibility,C-tracking-issue
low
Critical
436,345,509
flutter
Marker Colors for Android and iOS are not equal
First I would like to thanks the google map team for an excellent plugin. Works perfect for both Android and iOS. Minor snag (version 0.5.7): Marker Colors for Android and iOS are not equal. My app has a legend table that is correct for Android but not for iOS. The URL below shows the miss match. https://github.com/StephanCassel/Aviator-Tracker/blob/master/flutter_google_map_color2.png
a: quality,p: maps,package,team-ecosystem,has reproducible steps,P3,found in release: 2.3,triaged-ecosystem
low
Minor
436,348,462
godot
Reparenting a bakedlightmap causes the engine to crash
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** 3.1 6098a7f1914f64c77d689f54d5432095911b744f <!-- Specify commit hash if non-official. --> **OS/device including version:** Windows 10 Pro 64-bit (10.0, Build 17134) (17134.rs4_release.180410-1804) GeForce GTX 1070 with Max-Q Design/PCIe/SSE2 (plus Intel(R) UHD Graphics 630 which is disabled) <!-- Specify GPU model and drivers if graphics-related. --> **Issue description:** <!-- What happened, and what was expected. --> Generate a baked lightmap with baked textures and then try to move the lightmap into a spatial ``` godot.windows.tools.64.exe!Object::call(const StringName & p_name, const Variant & p_arg1, const Variant & p_arg2, const Variant & p_arg3, const Variant & p_arg4, const Variant & p_arg5) Line 866 C++ godot.windows.tools.64.exe!BakedLightmap::_assign_lightmaps() Line 667 C++ godot.windows.tools.64.exe!BakedLightmap::_notification(int p_what) Line 645 C++ godot.windows.tools.64.exe!BakedLightmap::_notificationv(int p_notification, bool p_reversed) Line 91 C++ godot.windows.tools.64.exe!Object::notification(int p_notification, bool p_reversed) Line 954 C++ godot.windows.tools.64.exe!Node::_propagate_ready() Line 189 C++ godot.windows.tools.64.exe!Node::_set_tree(SceneTree * p_tree) Line 2557 C++ godot.windows.tools.64.exe!Node::_add_child_nocheck(Node * p_child, const StringName & p_name) Line 1154 C++ godot.windows.tools.64.exe!Node::add_child(Node * p_child, bool p_legible_unique_name) Line 1185 C++ godot.windows.tools.64.exe!MethodBind2<Node,Node *,bool>::call(Object * p_object, const Variant * * p_args, int p_arg_count, Variant::CallError & r_error) Line 1517 C++ godot.windows.tools.64.exe!Object::call(const StringName & p_method, const Variant * * p_args, int p_argcount, Variant::CallError & r_error) Line 942 C++ ``` Tries to call `node->call("get_bake_mesh_instance")` when `node` is `NULL` (result of `get_node(light_data->get_user_path(i))`) ``` for (int i = 0; i < light_data->get_user_count(); i++) { Ref<Texture> lightmap = light_data->get_user_lightmap(i); ERR_CONTINUE(!lightmap.is_valid()); Node *node = get_node(light_data->get_user_path(i)); // <- node is set to NULL here, i == 1 ``` **Steps to reproduce:** Open sample project, move `$BakedLightMap` node inside `$Spatial` **Minimal reproduction project:** <!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. --> [baked_light_map_crash.zip](https://github.com/godotengine/godot/files/3109227/baked_light_map_crash.zip)
bug,topic:rendering,confirmed,crash,topic:3d
low
Critical
436,362,491
pytorch
[jit] nn.LSTM errors in nn.ScriptModule
## 🐛 Bug Torch script errors on nn.LSTM due to return type mismatch. ## To Reproduce run the following: ```python from __future__ import print_function import torch class TestModule(torch.jit.ScriptModule): def __init__(self): super(TestModule, self).__init__() self.rnn = torch.nn.LSTM(10, 20, 2) @torch.jit.script_method def forward(self, x, seq_len): return self.rnn(x[:seq_len]) onnx_path = "test.onnx" model = TestModule() max_seq_len = 10 seq_len = 3 torch_in = (torch.randn(max_seq_len, 1, 10), torch.tensor(seq_len)) torch_out = model(*torch_in) torch.onnx._export(model, torch_in, onnx_path, verbose=True, operator_export_type=torch.onnx.OperatorExportTypes.ONNX, example_outputs=torch_out) ``` Error msg: ``` RuntimeError: expected value of type Tensor for return value but instead got value of type tuple. Value: (tensor([[[ 0.0131, -0.0189, -0.0382, -0.0485, -0.0530, 0.0576, -0.0215, -0.0476, 0.0310, -0.0649, 0.0208, 0.0090, 0.0506, -0.0437, -0.0655, -0.0741, -0.0753, 0.0451, 0.0434, 0.0034]], [[ 0.0340, -0.0401, -0.0431, -0.0574, -0.0925, 0.1075, -0.0670, -0.0510, 0.0298, -0.1264, 0.0319, 0.0326, 0.0778, -0.0714, -0.1181, -0.0624, -0.1227, 0.0611, 0.0881, 0.0121]], [[ 0.0505, -0.0539, -0.0696, -0.0169, -0.0946, 0.1010, -0.0840, -0.0454, 0.0468, -0.1656, 0.0414, 0.0265, 0.0885, -0.0955, -0.1255, -0.0831, -0.1381, 0.0460, 0.0934, -0.0063]]], grad_fn=<StackBackward>), (tensor([[[ 0.0751, -0.0792, 0.1354, -0.1189, 0.0777, 0.1595, 0.0664, 0.0679, -0.0291, -0.0530, 0.0622, 0.1268, 0.0217, 0.3393, 0.0827, -0.0393, 0.0058, 0.1860, -0.1476, -0.0161]], [[ 0.0505, -0.0539, -0.0696, -0.0169, -0.0946, 0.1010, -0.0840, -0.0454, 0.0468, -0.1656, 0.0414, 0.0265, 0.0885, -0.0955, -0.1255, -0.0831, -0.1381, 0.0460, 0.0934, -0.0063]]], grad_fn=<StackBackward>), tensor([[[ 0.1532, -0.1940, 0.2310, -0.2605, 0.1665, 0.2493, 0.1354, 0.3215, -0.1180, -0.1350, 0.3478, 0.3017, 0.0412, 0.5556, 0.2099, -0.0888, 0.0103, 0.5196, -0.3361, -0.0461]], [[ 0.1015, -0.1073, -0.1859, -0.0310, -0.1853, 0.2024, -0.1587, -0.1042, 0.1006, -0.3469, 0.0950, 0.0528, 0.2027, -0.1976, -0.2762, -0.2110, -0.3665, 0.0898, 0.1874, -0.0121]]], grad_fn=<StackBackward>))): operation failed in interpreter: @torch.jit.script_method def forward(self, x, seq_len): return self.rnn(x[:seq_len]) ~~~~~~~~ <--- HERE ``` ## Environment PyTorch version: 1.0.1.post2 Is debug build: No CUDA used to build PyTorch: None OS: Mac OSX 10.14.5 GCC version: Could not collect CMake version: version 3.12.2 Python version: 3.7 Is CUDA available: No CUDA runtime version: No CUDA GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA cc @suo
oncall: jit,triaged
low
Critical
436,371,795
flutter
Document the relationships of markNeedsSematicsUpdate/Layout/Paint
framework,d: api docs,c: proposal,P2,team-framework,triaged-framework
low
Minor
436,390,127
rust
False positive 'type parameter is never used' with struct
Consider the following code snippet [playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=f59a38d253ea423eecea6ae445f618c3) ```rust trait MyTrait<I> {} trait SecondTrait {} fn bar<A: MyTrait<B>, B: SecondTrait>() {} struct MyStruct<A: MyTrait<B>, B: SecondTrait> { field: A } ``` This procudes the error: ``` error[E0392]: parameter `B` is never used --> src/lib.rs:6:32 | 6 | struct MyStruct<A: MyTrait<B>, B: SecondTrait> { | ^ unused type parameter | = help: consider removing `B` or using a marker such as `std::marker::PhantomData` ``` However, the parameter `B` is used - it's part of how we bound `A`. The function and struct are equivalent in terms of generic parameters - since the equalivalent function compiles, the struct should as well. Though this can be worked around via `PhantomData`, there's no reason to require using it. The struct definition is perfectly valid and useful, and should be useable without any workarounds.
T-lang
low
Critical
436,410,459
go
x/build: TryBots should check go.mod files are tidy
[CL 172972](https://go-review.googlesource.com/c/tools/+/172972) added a dependency on `golang.org/x/sync` in `golang.org/x/tools`. The go.mod and go.sum files were not updated. There's nothing wrong with this dependency, but it should have been more noticeable during code review. If unexpected requirement were added to go.mod, human reviewers would see it. TryBots should report an error if go.mod and go.sum change with `go mod tidy`. This will make sure dependency changes are explicit, and it will keep builds deterministic.
Builders,NeedsInvestigation,modules
low
Critical
436,412,023
pytorch
[jit] Traced {zeros,empty}()/{zeros,empty}_like() calls do not respect device args.
## 🐛 Bug Tracing a call to `torch.{zeros,empty}_like(x)` produces a script module where the resulting allocation is always made on the same device as `x` was in the trace, not at runtime. If the call is made in a function/method annotated with `@th.jit.script{,_method}` then everything works as expected. In the case of `zeros(sizes, device=device)`, this is understandable since I can see that the passed non-tensor args (the device) would be considered constants for tracing, but in the case of zeros_like it is not obvious. (sorry, not 100% sure this is a bug but the behavior isn't entirely expected. Perhaps a warning is warranted for traced `..._like(x)`?) ## To Reproduce Simple test: ```python import torch as th def make_zeros(x): return th.zeros_like(x) x = th.zeros(3) func = th.jit.trace(make_zeros, (x,)) print(func(x).device) x = th.zeros(3).cuda(0) print(func(x).device) x = th.zeros(3).cuda(1) print(func(x).device) ``` 1. Run the script above on a machine with 2 GPUs (comment out the last 2 lines for a single-GPU machine). ## Expected behavior Code prints ``` cpu cuda:0 cuda:1 ``` Actual behavior: Code prints ``` cpu cpu cpu ``` ## Environment Please copy and paste the output from our [environment collection script](https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py) (or fill out the checklist below manually). You can get the script and run it with: ``` wget https://raw.githubusercontent.com/pytorch/pytorch/master/torch/utils/collect_env.py # For security purposes, please check the contents of collect_env.py before running it. python collect_env.py ``` - PyTorch Version (e.g., 1.0): Nightly 20190423 - OS (e.g., Linux): Linux (Fedora 29) - How you installed PyTorch (`conda`, `pip`, source): conda - Python version: 3.7 - CUDA/cuDNN version: 10.0.130 / 7.4.2 - GPU models and configuration: 2x Titan RTX
oncall: jit,triaged
low
Critical
436,429,739
rust
`impl {Div,Mul,DivAssign,MulAssign}<{u16, u8}> for Duration` should also exist
Currently only `impl {Div,Mul,DivAssign,MulAssign}<u32> for Duration` exist, and there is no functional reason why the other implementations should not exist.
T-libs-api,C-feature-request
low
Minor
436,440,861
kubernetes
Create an integration test suite for dry-run sub-resources
There is currently no integration test for dry-run sub-resources, which for example led to #76943. We have a test that goes over all the resources, we should probably have one that goes over all sub-resources too and make sure that it works.
priority/important-soon,sig/api-machinery,sig/cli,lifecycle/frozen
low
Major
436,449,211
TypeScript
Weird inference bug where a union is expanded with "never" in the position of generics
**TypeScript Version:** 3.5.0-dev.20190423 This code works in 3.3.4000 and is broken in 3.4.5 **Code** ```ts function MyComponent({a, b}: {a: number; b: number}) { return a + b; } function test<Props>( _getComponent: () => Promise<(props: Props) => number | string>, ) {} test(() => Promise.resolve({MyComponent}).then(m => m.MyComponent)); ``` Of course this is a simplified example. The code I found this in uses React and lazy loading with `import()`. **Expected behavior:** This example should pass type checking without any problems. **Actual behavior:** ``` test.ts:9:12 - error TS2322: Type 'Promise<(({ a, b }: { a: number; b: number; }) => number) | ((props: never) => string | number)>' is not assignable to type 'Promise<(props: { a: number; b: number; }) => string | number>'. Type '(({ a, b }: { a: number; b: number; }) => number) | ((props: never) => string | number)' is not assignable to type '(props: { a: number; b: number; }) => string | number'. Type '(props: never) => string | number' is not assignable to type '(props: { a: number; b: number; }) => string | number'. Types of parameters 'props' and 'props' are incompatible. Type '{ a: number; b: number; }' is not assignable to type 'never'. 9 test(() => Promise.resolve({MyComponent}).then(m => m.MyComponent)); ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ test.ts:6:18 6 _getComponent: () => Promise<(props: Props) => number | string>, ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ The expected type comes from the return type of this signature. ``` Notably here the _actual_ type is inferred to be… ``` Promise<(({ a, b }: { a: number; b: number; }) => number) | ((props: never) => string | number)> ``` …which has an extra union variant… ``` (props: never) => string | number ``` …coming out of nowhere. **Playground Link:** You need to enable `strictFunctionTypes`. http://www.typescriptlang.org/play/index.html#src=function%20MyComponent(%7Ba%2C%20b%7D%3A%20%7Ba%3A%20number%3B%20b%3A%20number%7D)%20%7B%0A%20%20return%20a%20%2B%20b%3B%0A%7D%0A%0Afunction%20test%3CProps%3E(%0A%20%20_getComponent%3A%20()%20%3D%3E%20Promise%3C(props%3A%20Props)%20%3D%3E%20number%20%7C%20string%3E%2C%0A)%20%7B%7D%0A%0Atest(()%20%3D%3E%20Promise.resolve(%7BMyComponent%7D).then(m%20%3D%3E%20m.MyComponent))%3B%0A
Needs Investigation
low
Critical
436,452,177
rust
Mismatched order of lifetimes between declaration and usage causes confusing errors
This code works fine: ```rust struct Parser<'c, 's> { context: &'c &'s str, } impl<'c, 's> Parser<'c, 's> { fn parse(&self) -> &'s str { self.context } } fn parse_context<'s>(context: &'s str) -> &'s str { Parser { context: &context }.parse() } fn main() { parse_context("Available?"); } ``` If you swap the declaration order of the lifetimes, it breaks: ```rust struct Parser<'s, 'c> { ``` ``` error[E0515]: cannot return value referencing function parameter `context` --> src/main.rs:12:5 | 12 | Parser { context: &context }.parse() | ^^^^^^^^^^^^^^^^^^--------^^^^^^^^^^ | | | | | `context` is borrowed here | returns a value referencing data owned by the current function ``` This seems like nonsense to me, so I'm declaring it a bug.
C-enhancement,A-diagnostics,A-lifetimes,T-compiler,D-confusing
low
Critical
436,461,243
godot
Cannot scroll/pan/zoom with mousepad/trackpad in TextureRegion panel
**Godot version:** 3.1.stable.official **OS/device including version:** OSX 10.14, Macbook Pro **Issue description:** Scrolling or zooming in TextureRegion panel with trackpad is impossible. (spacebar+mouse-movement) works for panning around as a last resort, but the spacebar input toggles off the panel back to its minimized state. It becomes essencially impossible to select big regions using only mousepad.
bug,topic:editor,confirmed,usability
low
Minor
436,462,284
pytorch
[docs] torch.set_flush_denormal(...) to mention default mode
Currently the [torch.set_flush_denormal docs](https://pytorch.org/docs/stable/torch.html?highlight=set_flush_denormal#torch.set_flush_denormal) do not mention what is the default mode. It would also be nice if they mentioned the FTZ / DAZ flags and a link to some reference page (like [intel's](https://software.intel.com/en-us/cpp-compiler-developer-guide-and-reference-setting-the-ftz-and-daz-flags)?) - like that this method would show up for google queries like `pytorch ftz`. Also, a note on whether denormals are flushed [on GPU](https://devblogs.nvidia.com/cuda-pro-tip-flush-denormals-confidence/) would be helpful.
module: docs,triaged
low
Minor
436,477,501
ant-design
Ant Design currently generates inaccessible forms. Blind people cannot use forms made by Ant Design.
- [x] I have searched the [issues](https://github.com/ant-design/ant-design/issues) of this repository and believe that this is not a duplicate. ### What problem does this feature solve? A substantial percentage of the internet relies on screen readers (e.g. all blind people, many old people, etc.) - and having forms be easily read by them is critical. People who use screen readers currently *cannot* use forms generated by Ant Design. Considering how widely adopted And Design is, many people are trying to access Ant Design forms with screen readers daily - and currently, they can't read them. AntD has been advertised as an accessible platform, and accordingly - I hope that it is updated to make forms accessible. Here is a post with a lot more info (including screenshots of current problems): https://github.com/ant-design/ant-design/issues/16268 ### What does the proposed API look like? The proposed API would be the same as it is currently. However, the output would be very slightly different. All that's needed is 2 extra attributes per `<Form.Item/>` - e.g. `for` in label, and `id` in input. That's really all that's needed for all the Ant Design forms to become accessible!! As an alternative, perhaps the top level `<Form />` can have an extra prop available called `accessible` that is a boolean, and when set to `true`, forms are made accessible. (personally, however, i think they should be accessible by default always). ----------------------------------------- * [ ] Select * [ ] Checkboxes * [ ] Radio Buttons * [ ] Datepicker * [ ] Modal * [ ] Menu description ref: [comment](#issuecomment-486393323) <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Inactive,⌨️ Accessibility
high
Critical
436,500,572
opencv
OpenCV CocoaPod maintainer wanted
Hi, I'm listed as the maintainer of the [OpenCV CocoaPod](https://cocoapods.org/pods/OpenCV), however, I'm not able to actively maintain the pod. Does the OpenCV project or someone in the community want to take over the responsibility of maintaining it?
category: infrastructure,platform: ios/osx,community help requested
medium
Critical
436,515,827
go
x/tools/cmd/goimports: -local adds local packages before external packages
### What version of Go are you using (`go version`)? <pre> $ go version go version go1.11.2 darwin/amd64 </pre> ### Does this issue reproduce with the latest release? Yes ### What operating system and processor architecture are you using (`go env`)? <details><summary><code>go env</code> Output</summary><br><pre> $ go env GOARCH="amd64" GOBIN="" GOCACHE="/Users/raywu/Library/Caches/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/raywu/go:/Users/raywu" GOPROXY="" GORACE="" GOROOT="/usr/local/Cellar/go/1.11.2/libexec" GOTMPDIR="" GOTOOLDIR="/usr/local/Cellar/go/1.11.2/libexec/pkg/tool/darwin_amd64" GCCGO="gccgo" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/v8/q5brnv35699835dr_mt01t0m0000gn/T/go-build432413042=/tmp/go-build -gno-record-gcc-switches -fno-common" </pre></details> ### What did you do? Use `goimports` to add missing `timeutil` import, which is our local package. ```go package main import ( "fmt" "github.com/cespare/wait" ) func main() { fmt.Println("asdf") var wg wait.Group wg.Wait() timeutil.MustParseRFC3339("2019-01-01T00:00:00Z") } ``` ### What did you expect to see? ```go ▶ cat abc.go | ~/goimports -local liftoff/ package main import ( "fmt" "github.com/cespare/wait" "liftoff/go/timeutil" ) func main() { fmt.Println("asdf") var wg wait.Group wg.Wait() timeutil.MustParseRFC3339("2019-01-01T00:00:00Z") } ``` ### What did you see instead? ```go ▶ cat abc.go | ~/goimports -local liftoff/ package main import ( "fmt" "liftoff/go/timeutil" "github.com/cespare/wait" ) func main() { fmt.Println("asdf") var wg wait.Group wg.Wait() timeutil.MustParseRFC3339("2019-01-01T00:00:00Z") } ```
NeedsInvestigation,Tools
low
Critical
436,571,123
godot
Low physics FPS makes mouse wheel scrolling in GDScript inoperable after restarting the Editor
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** <!-- Specify commit hash if non-official. --> Godot 3.1 **OS/device including version:** <!-- Specify GPU model and drivers if graphics-related. --> NVIDIA GeForce GTX 1070 **Issue description:** <!-- What happened, and what was expected. --> Higher Physics (tested with 700, but the number may be lower) FPS makes mouse wheel scrolling in GDScript inoperable after restarting the Editor **Steps to reproduce:** Create a new project Project Settings > Physics > Common >Physics Fps > 700 Restart the Editor Create new GDScript Move cursor down, so you can scroll the script with the mouse wheel But actually, you can't *Bugsquad edit (keywords for easier searching): mousewheel*
bug,topic:editor,confirmed,topic:gui
medium
Critical
436,625,810
pytorch
Importing matlab.engine after torch causes bad_alloc
## 🐛 Bug ## Importing matlab.engine after torch causes bad_alloc. ## To reproduce: \>\>\> import torch \>\>\> import matlab.engine terminate called after throwing an instance of 'std::bad_alloc' what(): std::bad_alloc Aborted (core dumped) ## Environment (from collect_env.py) PyTorch version: 1.0.0 Is debug build: No CUDA used to build PyTorch: 9.0.176 OS: Ubuntu 16.04.5 LTS GCC version: (Ubuntu 5.5.0-12ubuntu1~16.04) 5.5.0 20171010 CMake version: version 3.7.2 Python version: 3.5 Is CUDA available: Yes CUDA runtime version: 9.0.176 GPU models and configuration: GPU 0: GeForce GTX 1070 Nvidia driver version: 390.87 cuDNN version: Could not collect Versions of relevant libraries: [pip3] numpy==1.13.3 [pip3] pytorch-fft==0.15 [pip3] torch==1.0.0 [pip3] torchsummary==1.1 [pip3] torchvision==0.2.1 [conda] blas 1.0 mkl [conda] mkl 2018.0.2 1 [conda] mkl-service 1.1.2 py27hb2d42c5_4 [conda] mkl_fft 1.0.1 py27h3010b51_0 [conda] mkl_random 1.0.1 py27h629b387_0 ## Additional context matlab version: R2018a It works well if I import matlab.engine first...
module: internals,triaged,module: assert failure
low
Critical
436,646,868
material-ui
[material-ui][docs] Fade (and other transition helpers) fails silently when children aren't able to receive the style prop
## Expected Behavior 🤔 That the `Fade` component complains if it gets `children` that doesnt take the style prop. ## Current Behavior 😯 If you give `Fade` an element that doesnt take and apply the `style` prop the `Fade` component does nothing. See this codesandbox: https://codesandbox.io/s/n3z26zp6n0 There you can see the the component that returns a `React.Fragment` the root never fades but the one with a `div` does. Here are some suggestions/thoughts/options: - Validate that the element that it receives takes the `style` prop (via typescript types and/or prop-types) - Receive a `Component` prop and render that instead of receiving an element and doing [cloneElement](https://github.com/mui-org/material-ui/blob/next/packages/material-ui/src/Fade/Fade.js#L57-L67). I think there is some problems typing react elements, see [this](https://gist.github.com/karol-majewski/ccd0ddbf97864afdd837dd8b1ddc993f) - Output its own element (default to div and make it overridable?) to ensure that the style prop is applied - Take a render function that receives the style and have the user apply the style props (and other logic depending on the transition state it gets in its own callback function).
docs,component: transitions
low
Major
436,712,099
react
<details> open attribute not synchronised
<!-- Note: if the issue is about documentation or the website, please file it at: https://github.com/reactjs/reactjs.org/issues/new --> **What is the current behavior?** `open` attribute does not synchronise with the virtual dom on the `details` element, when using the `details` element as a controlled component. I have a codesandbox [here](https://codesandbox.io/s/xl756mk82w) that demonstrates the current behaviour. **What is the expected behavior?** The `open` attribute stays synchronised with the virtual dom and is added/removed. **Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?** React: **`16.8.6`** Browser: **Chrome** Did this work in previous versions of React? **No**
Type: Needs Investigation
medium
Critical
436,750,995
pytorch
torch.set_flush_denormal not working on some (old) OSX machines
## 🐛 Bug `torch.set_flush_denormal` not working on some OSX machines ## To Reproduce 1. Find an old Macbook, for example MBP A1398 as listed in https://github.com/pytorch/pytorch/issues/19651#issuecomment-486176859 2. Run the following script on it: https://github.com/pytorch/pytorch/issues/19651#issuecomment-486170718 ## Expected behavior FTZ is set and the script runs fast
triaged,module: macos
low
Critical
436,754,582
TypeScript
Import type over generic argument
<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨 Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Please read the FAQ first, especially the "Common Feature Requests" section. --> ## Search Terms <!-- List of keywords you searched for before creating this issue. Write them down here so that others can find this suggestion more easily --> import type, generic, module string type ## Suggestion To allow for giving a generic argument as an import() type's argument, something like `function <Mod extends string>(obj: unknown, modPath: Mod): obj is import(Mod);` ## Use Cases Would allow generic functions that type inference from any module path string literal to the type exported by that module. This is helpful for encapsulating good module loading practices. For instance, in a large AMD application I work on, we need to manage the application footprint by not loading modules that aren't needed for the current execution path. There are a number of utility functions we could write around handling modules to support good behavior on this front. ## Examples One of the signatures of AMD's require() could be typed as: `function require<Mod extends string>(path: Mod): import(Mod);` This actually does work today if that declaration is put in a .d.ts file and skipLibCheck is set to true. If a string literal is passed, the return type is inferred from the path; if non-literal, the return type is any. In fact, if this worked but disallowed anything other than a module path, it would be super handy for typo avoidance. I'm pretty sure what's happening now is accidental, though, since any more complex use yields a "string literal expected" error on the import type. Likewise, I'm pretty sure a really useful signature for define() could be done with a mapped type and tuple typed-rest params, something like: ``` type ImportsOf<Paths extends string[]> = { P in keyof Paths: import(Paths[P]) }; function define<Paths extends string[]>(paths: Paths, callback: (...args: ImportsOf<Paths>)=>void); ``` Specifically, the function I wanted to write with this was a type-narrowing instanceof check over a module path. Given a module that exports a constructor: ``` function isModuleInstance<Mod extends string>(obj: unknown, path: Mod): obj is InstanceType<import(Mod)> { const modValue = require(path); return modValue && obj instanceof modValue } ``` If the module for a constructor hasn't been loaded, we can assume no object has been constructed by it, so this technique is very handy for keeping down the module load footprint in applications with lots of modules. A question for discussion would be the value of an import-type on a non-literal argument, or a non-module argument for that matter. My initial impression is if the import() type can't be resolved, it should evaluate to never and produce an error just like import('some_garbage_string_i_made_up')". That might require the type checker to be given a stricter bound than "extends string", though. If necessary, a user-visible built-in type that means "a string representing a known module" seems like it might be useful in lots of contexts. ## Checklist My suggestion meets these guidelines: * [X ] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [X ] This wouldn't change the runtime behavior of existing JavaScript code * [X ] This could be implemented without emitting different JS based on the types of the expressions * [X ] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [Seems like it to me] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
medium
Critical
436,757,331
TypeScript
Invalid Semantic Links for Inferred Type Arguments
Tested in `3.5.0-dev.20190424`. Given this code [(playground)](https://www.typescriptlang.org/play/#src=class%20Main%3CTData%3E%20%7B%0D%0A%09test1(obj%3A%20TData)%3A%20void%20%7B%7D%0D%0A%09test2(obj%3A%20Partial%3CTData%3E)%3A%20void%20%7B%7D%0D%0A%09test3%3CT%20extends%20TData%3E(obj%3A%20T)%3A%20void%20%7B%7D%0D%0A%09test4%3CT%20extends%20Partial%3CTData%3E%3E(obj%3A%20T)%3A%20void%20%7B%7D%0D%0A%7D%0D%0A%0D%0Ainterface%20Bla%20%7B%0D%0A%09foo%3A%20number%3B%0D%0A%09bar%3A%20number%3B%0D%0A%7D%0D%0A%0D%0Aconst%20m%20%3D%20new%20Main%3CBla%3E()%3B%0D%0Am.test1(%7B%20bar%3A%201%2C%20foo%3A%201%20%7D)%3B%0D%0Am.test1(%7B%20bar%3A%20true%2C%20foo%3A%201%20%7D)%3B%0D%0A%0D%0Am.test2(%7B%20bar%3A%201%20%7D)%3B%0D%0Am.test2(%7B%20bar%3A%20true%20%7D)%3B%0D%0A%0D%0Am.test3(%7B%20bar%3A%201%2C%20foo%3A%201%20%7D)%3B%0D%0Am.test3(%7B%20bar%3A%20true%2C%20foo%3A%201%20%7D)%3B%0D%0A%0D%0Am.test4(%7B%20bar%3A%201%20%7D)%3B%0D%0Am.test4(%7B%20bar%3A%20true%20%7D)%3B): ```ts class Main<TData> { test1(obj: TData): void {} test2(obj: Partial<TData>): void {} test3<T extends TData>(obj: T): void {} test4<T extends Partial<TData>>(obj: T): void {} } interface Bla { foo: number; bar: number; } const m = new Main<Bla>(); m.test1({ bar: 1, foo: 1 }); m.test1({ bar: true, foo: 1 }); m.test2({ bar: 1 }); m.test2({ bar: true }); m.test3({ bar: 1, foo: 1 }); m.test3({ bar: true, foo: 1 }); m.test4({ bar: 1 }); m.test4({ bar: true }); ``` The references are not resolved correctly: ![image](https://user-images.githubusercontent.com/2931520/56671142-67046b00-66b4-11e9-96e0-91351209b1f4.png) `bar` in line `20` and `23` is not linked to `Bla.bar`. It however is in line `21` and `24` where the types don't match. This affects rename, go to definition and all other semantic actions. This might be linked to #30507.
Bug
low
Minor
436,787,869
rust
add a disclaimer to the net::ip methods that are susceptible to change
This issue has come up in https://github.com/rust-lang/rust/pull/60145 See in particular [@the8472's comment](https://github.com/rust-lang/rust/pull/60145#issuecomment-485977968). The IP specifications are constantly changing as new [RFCs](https://www.ietf.org/standards/rfcs/) get written and accepted, and the bits of the specification that are implemented in the standard library may need to be updated accordingly. That means that in the future, we may have to change the behavior of methods that are stable (I _think_ that this is allowed by Rust's rules regarding stability as long as we don't modify the API, but someone more knowledgeable should confirm). For this reason, it would be nice to add a disclaimer in the documentation of the methods which behavior is susceptible to change in the future, a little bit like the [Platform Specific Behavior disclaimer](https://doc.rust-lang.org/std/fs/fn.read_dir.html#platform-specific-behavior) in the doc of some IO methods. cc @the8472
C-enhancement,T-libs-api,A-docs
low
Major
436,788,079
flutter
Feature request: Improve customizability of built-in widget styles
Some built-in widgets hard-code styles like padding, colors, and sizes. We have `material/constants.dart`, plus a mixture of `const k` values, default values in constructors, and hard-coded values inside private (and therefore not overridable) methods. This feature request is for a comprehensive and principled sweep through to find hard-coded values and make the majority customizable. I'm in the middle of porting one of my apps to the framework, and when a widget did not offer sufficient customization, I either had to: 1. Copy the code for the built-in widget into my project and make local changes. This works, and seems relatively common practice in the community, but it's not very maintainable since my copies will not automatically benefit from bug fixes and improvements as Flutter evolves. 2. Find a third-party widget on pub that does what I want. Sometimes these widgets are mostly copies of built-in widgets with a few changes, e.g. compare https://github.com/joostlek/GradientAppBar/blob/master/lib/gradient_app_bar.dart with https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/app_bar.dart. This is slightly better but now I'm relying on package maintainers to keep the widget code in sync with Flutter. I think doing this is important for the long-term viability of Flutter, otherwise there will be lots of Flutter apps like mine containing partial copies of the widget code in various stages of out-datedness, missing the latest bug fixes and style updates. Here are some more examples I've found so far where I ended up pseudo-forking widget code: * CupertinoSegmentedControl: _kHorizontalItemPadding and customize the background and text colors separately for selected and unselected widgets. * ListTile: tile height (_RenderListTile._defaultTileHeight) and font sizes (ListTile._titleTextStyle). * BottomNavigationBar: active and inactive label text sizes, styles, and icon sizes. * AppBar and BottomNavigationBar: gradient backgrounds. It would be nice to be able to make these customizations either globally using a ThemeData-like class, per-widget using constructor arguments, or by inheritance using method or getter overrides.
c: new feature,framework,f: material design,f: cupertino,a: quality,customer: crowd,P2,team-design,triaged-design
low
Critical
436,803,601
terminal
Ctr+Wheel behavior unpredictable using Surface Precision Mouse
* Windows build number: 10.0.18362.53 * I am using the new Ctrl+Mouse wheel to resize the console * What's wrong / what should be happening instead: I am using a Surface Precision mouse, which has the option to disable detent scrolling. When detent scrolling is on, the console resizes as expected. With Detent scrolling off, even if I don't scroll rapidly the window is either not responsive to resizing, or responds in rare instances with a very significant resize, making the window unusable. In MOST cases, it is simply not responsive, which only occurs infrequntly or with rapid scrolling with detent on.
Work-Item,Product-Conhost,Area-Input,Issue-Bug
low
Major
436,820,176
godot
Lightmap Size Hint resets to 0 upon editor restart for imported meshes
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** <!-- Specify commit hash if non-official. --> Latest commit on branch 3.1 **OS/device including version:** <!-- Specify GPU model and drivers if graphics-related. --> Lubuntu Linux, integrated Intel HD Graphics **Issue description:** <!-- What happened, and what was expected. --> I'm attempting to use BakedLightmap on meshes with UV2 layers unwrapped in blender. I can bake the lights as expected, but when I restart the editor, the light data is not displayed properly, and I cannot bake the lights again. This is because the Lightmap Size Hint for all the imported meshes resets to zero, despite saving the project, and I have to change the size hints and bake again. When I close a scene and reopen it, the size hint is preserved; it's only when I close the editor that the size is reset. The documentation says the following regarding the lightmap size hint: ["If you use external meshes on import, the size will be kept."](https://docs.godotengine.org/en/3.1/tutorials/3d/baked_lightmaps.html?highlight=lightmap). It's not clear to me what this is supposed to mean, but I assumed it was saying that this size hint is supposed to be preserved for imported meshes. **Steps to reproduce:** Create a mesh with 2 UV layers unwrapped in your modelling software of choice. Import that mesh with "Light Baking" set to "Enable" in the import tab. Create an inherited scene from your imported scene. In that inherited scene, click to edit the mesh, and set "Lightmap Size Hint" to some positive numbers. Save the scene Create a scene with baked lighting, and it should bake properly with your lights visible. Close the editor and restart it. The mesh will now have "Lightmap Size Hint" values of zero, and the light data will not be properly aligned with the mesh. **Minimal reproduction project:** <!-- Recommended as it greatly speeds up debugging. Drag and drop a zip archive to upload it. --> [custom_uv2.zip](https://github.com/godotengine/godot/files/3113506/custom_uv2.zip) If in the following project, the pipe model has a Lightmap Size Hint of 0 by 0, then you've encountered the bug, as I baked the lights with a lightmap of 16 by 16 pixels.
bug,topic:editor,confirmed,topic:import,topic:3d
low
Critical
436,828,895
react
eslint-plugin-react-hooks suggests adding a dependency on a function that always changes
If you write: ```js import React, {useEffect} from 'react'; const Foo = ({ orgId }) => { const fetchOrg = () => { alert(orgId); }; useEffect(() => { fetchOrg(); }, [orgId]); return <div />; }; ``` then you get the error: > React Hook useEffect has a missing dependency: 'fetchOrg'. Either include it or remove the dependency array But if you follow that advice and add `fetchOrg` to the dep array, you get: > The 'fetchOrg' function makes the dependencies of useEffect Hook (at line 6) change on every render. Move it inside the useEffect callback. Alternatively, wrap the 'fetchOrg' definition into its own useCallback() Hook Ideally it could suggest the second solution immediately, instead of suggesting a remediation that it will immediately warn about.
Type: Enhancement,Component: ESLint Rules,Partner
low
Critical
436,836,787
pytorch
View in Sequential - reasoned case for it
I know from googling previous issues that the PyTorch team are not keen on implementing a **View**/Reshape module to be used in **Sequential**. What's missing from those issues / comments is reasoning for or against. I have 20+ years in technology, including machine learning and data mining, and more recently have focussed on teaching students of all ages. I hope this experience gives some weight to my case below. . **1. Against** There doesn't appear to be a good case presented by pytorch developers against a View() module that can be used inside Sequential. The best I can find is indications of a preference for users to build their own forward() functions but again this is not explained - not that I could find despite searching. . **2. For** There are several arguments for. - The Sequential approach is easy, simple, sufficient and requires little code for many tasks. Even of these tasks are relatively simple, that is not a reason against. The majority of uses of PyTorch are simple cases not the most extremely large networks. Make the 80% use case easy. - Permitting View in Sequential doesn't prevent the developers preference for users to build their own forward functions. Both are possible, and meet the needs of different users, or users at different stages of expertise. - Every user having to implement their own View module is wasted time, and potentially significant sources of error - which is a burden on them and also support here. If its a common task, do it once and do it well. - There is no machine learning reason not to encourage use of View in Sequential. - Supporting an easy path for newcomers to PyTorch is good strategy. It increases the user community and that is a positive. Barriers to adoption are not good. Python itself has become the leading numerical computing language, because of easy adoption, not because it was designed for fast computation. Those are my thoughts. I welcome challenge based on reasoned arguments for or against - which previously appeared lacking. Here's my own implementation which I now find doesn't handle channels... so illustrating the problem of amateur implementations like mine.. ``` # from https://github.com/pytorch/vision/issues/720 class View(nn.Module): def __init__(self, shape): super().__init__() self.shape = shape def forward(self, x): return x.view(*self.shape) ```
module: nn,triaged,enhancement
low
Critical
436,846,352
pytorch
Bad overload order for zeros_like
In the `pytorch_torch_functions.cpp` generated code, the zeros_like binding looks like ``` static PyObject * THPVariable_zeros_like(PyObject* self_, PyObject* args, PyObject* kwargs) { HANDLE_TH_ERRORS static PythonArgParser parser({ "zeros_like(Tensor input, *, ScalarType dtype=None, Layout layout=torch.strided, Device device=None, bool pin_memory=False, bool requires_grad=False)", "zeros_like(Tensor input, *, bool requires_grad=False)", }, /*traceable=*/true); ... ``` In this case, the second overload will never get hit as all the arguments in the first overload have defaults. This is causing a bug where tracing will "constant-ify" device instead of correctly deriving the device at runtime from the input tensor (see #19637). I tracked the overload sorting code to [here](https://github.com/pytorch/pytorch/blob/master/tools/autograd/gen_python_functions.py#L777) but I don't understand it. My desired behavior is to swap the order of the overloads in cases like the above. Can anyone help me out? cc. @gchanan, @cpuhrsch, @ezyang
triaged,module: pybind,module: tensor creation
low
Critical
436,853,027
flutter
[google_maps_flutter] - Change MyLocation icon
Hello, I need to change the MyLocation icon. Today the plugin just change Marks icons. I need to change the blue Circle icon to another, like Marks. I believe I don't need to post my Doctor -v because it's not a bug, but a change.
c: new feature,d: api docs,p: maps,package,c: proposal,team-ecosystem,P3,triaged-ecosystem
low
Critical
436,898,476
godot
RemoteTransform resets position of nodes in the editor
<!-- Please search existing issues for potential duplicates before filing yours: https://github.com/godotengine/godot/issues?q=is%3Aissue --> **Godot version:** master (edit: v3.2.4-beta4, v4.0.dev) **OS/device including version:** Antergos (Arch Linux), Gentoo Linux **Issue description:** When I move a camera which has a viewport in the editor, it moves but its position doesn't update after reload. When I save and reopen the .tscn file, the camera has its previous position. **Minimal reproduction project:** [update-bug.zip](https://github.com/godotengine/godot/files/5683379/update-bug.zip) File: car/1/car.tscn
bug,topic:editor,confirmed
low
Critical
436,899,650
go
cmd/go: consistently defer module path checks (including major-version matching) until import or build-list resolution
At the moment, we validate that the major version through which a module was resolved matches the major-version suffix of the path declared in its `go.mod` file. However, we perform that validation only sporadically (#31428), the resulting failure message (if any) can be difficult to understand in context (#30499, #30636), and a mismatch — even one involving mismatched major-version components — isn't even obviously correct if the module is involved in a `replace` directive (#26904, https://github.com/golang/go/issues/27171#issuecomment-486402787). I suspect that we should simply not validate module paths at all when fetching a module, and instead do the validation consistently only at loading time (when we resolve explicit package imports). At that point: * If a module is used to replace the source code of another module, we should ensure that its path — including the major-version component — matches the module whose code it replaces. * Due to existing `replace` usage, we might need to relax this to allow the module path to _also_ match the path and version from which the source code was fetched, but ideally only if the `go.mod` file specifies `go 1.12` or earlier. * If a module is used as an alias from another module path and version (#26904), then we should resolve it at the path to which the alias points during package loading, and thus the module path and major version should match that path (and the major version at which it is `require`d). * If a module is downloaded using `go mod download`, we don't know how it is going to be used, and thus should not validate anything about its path. CC @rsc @jayconrod @heschik @hyangah @katiehockman @leitzler @tbpg
NeedsInvestigation,early-in-cycle,modules
low
Critical
436,912,075
flutter
The kernel transformer to track widget creations does not handle classes that implement instead of extend Widget.
The problem is `isSubclassOf`checks in the Kernel class hierarchy don't return true for classes that implement instead of extending widgets. The kernel transformer has code like `_transformClassImplementingWidget` designed to handle classes that implement widget robustly but we are failing as the `isSubclassOf` check doesn't do what I naively thought it did based on Dart semantics. Suggested test case to track this issue: Add a class that implements widget and verify it is missing creation locations.
team,framework,engine,dependency: dart,P2,team-engine,triaged-engine
low
Minor
436,914,473
go
encoding/gob: panics encoding nil pointer - reopen
This isssue is related to https://github.com/golang/go/issues/3704# (cannot be reopened) Currently encoding/gob panics if it is not able to do something. It's incorrect as this cannot be caught and supported on code level to provide "workaround" or failsafe activity to recover. I'm not convinced by "that's the way it should react" in response of related message. ``` panic: gob: cannot encode nil pointer of type *makelibrary.MiddlewareRequest [recovered] panic: gob: cannot encode nil pointer of type *makelibrary.MiddlewareRequest ``` The code: ``` func SerializeObject(object interface{}) []byte { var serializationBuffer bytes.Buffer enc := gob.NewEncoder(&serializationBuffer) err := enc.Encode(object) if err != nil { log.Println("Cannot serialize object. Error is: " + err.Error()) return []byte{} } return serializationBuffer.Bytes() } ``` As you see I don't care about panic here. It can be empty in my case. This error could be supported on code level if it's catchable - in my context for example I can skip object that has nil pointer because it will not be deserialized back. Platform details: Go version: 1.12 GOOS = linux GOARCH = amd64 I would expect to have error returned so it will be caught and workaround could be done.
NeedsFix,FixPending
low
Critical
436,932,850
go
cmd/compile: utf8.DecodeRune should be fast/slow-path inlineable
We manually partially inline utf8.DecodeRune in a few places in the tree. For example, in `bytes.EqualFold`, we have: ```go if s[0] < utf8.RuneSelf { sr, s = rune(s[0]), s[1:] } else { r, size := utf8.DecodeRune(s) sr, s = r, s[size:] } ``` It'd be nice to rewrite `utf8.DecodeRune` like this: ```go func DecodeRune(p []byte) (r rune, size int) { if len(p) > 0 && p[0] < RuneSelf { return rune(p[0]), 1 } return decodeRuneSlow(p) } ``` and then let mid-stack inlining take it from there. (And delete all the manual partial inlining.) Unfortunately, this has a cost of 89, over the budget of 80. This is basically just another variant of https://github.com/golang/go/issues/17566, but I'm filing it separately since that issue is super noisy. cc @bradfitz @mvdan @dr2chase
Performance,NeedsFix,compiler/runtime
low
Major
436,952,533
TypeScript
'Omit' should alias a distinct mapped type (for display purposes)
Today, `Omit` will expand to `Pick<Exclude<...>, ...>` in quick info, error messages, etc. which is gross. By defining `Omit` as its own conditional type, we can get a slightly nicer display, though it will introduce duplication of code between the two helpers.
Suggestion,Help Wanted,Effort: Moderate,Experience Enhancement,Fix Available
low
Critical
436,956,990
rust
Compiler fails to identify type mismatch on function that returns impl Trait
the following function, added to [tower-grpc](https://github.com/tower-rs/tower-grpc/) hello world client [example,](https://github.com/tower-rs/tower-grpc/blob/master/tower-grpc-examples/src/helloworld/client.rs) to wrap the service connection setup, when used, the compiler fails to identify the type mismatch, `()` in the return type should be `BoxBody` ```rust pub fn get_service() -> impl Future< Item = hello_world::client::Greeter< RequestModifier<Connection<TcpStream, DefaultExecutor, BoxBody>, ()>, >, Error = ConnectError<std::io::Error>, > { let uri: http::Uri = format!("http://localhost:50051") .parse() .expect("could not parse grpc address as uri"); let h2_settings = Default::default(); let mut make_client = Connect::new(Dst, h2_settings, DefaultExecutor::current()); make_client.make_service(()).map(|conn| { let conn = tower_request_modifier::Builder::new() .set_origin(uri) .build(conn) .unwrap(); hello_world::client::Greeter::new(conn) }) } ``` and gives the following error: ``` error[E0599]: no method named `say_hello` found for type `hello_world::client::Greeter<tower_request_modifier::RequestModifier<tower_h2::client::connection::Connection<tokio_tcp::stream::TcpStream, tokio_executor::global::DefaultExecutor, tower_grpc::body::BoxBody>, ()>>` in the current scope --> src/main.rs:22:18 | 22 | .say_hello(Request::new(HelloRequest { | ^^^^^^^^^ | ::: /Volumes/data/dev/jxs/tower-error-example/target/debug/build/tower-error-example-5d3017ffe78d8a92/out/helloworld.rs:19:5 | 19 | pub struct Greeter<T> { | --------------------- method `say_hello` not found for this | = help: items from traits can only be used if the trait is implemented and in scope = note: the following trait defines an item `say_hello`, perhaps you need to implement it: candidate #1: `hello_world::server::Greeter` ``` but if the following code is added just before the function return: ```rust let hello = hello_world::client::Greeter::new(conn).say_hello(Request::new(HelloRequest { name: "What is in a name?".to_string(), })); ``` the error given by the compiler becomes a lot more useful: ``` error[E0271]: type mismatch resolving `<[closure@src/main.rs:67:38: 78:6 uri:_] as std::ops::FnOnce<(tower_h2::client::connection::Connection<tokio_tcp::stream::TcpStream, tokio_executor::global::DefaultExecutor, tower_grpc::body::BoxBody>,)>>::Output == hello_world::client::Greeter<tower_request_modifier::RequestModifier<tower_h2::client::connection::Connection<tokio_tcp::stream::TcpStream, tokio_executor::global::DefaultExecutor, tower_grpc::body::BoxBody>, ()>>` --> src/main.rs:55:25 | 55 | pub fn get_service() -> impl Future< | _________________________^ 56 | | Item = hello_world::client::Greeter< 57 | | RequestModifier<Connection<TcpStream, DefaultExecutor, BoxBody>, ()>, 58 | | >, 59 | | Error = ConnectError<std::io::Error>, 60 | | > { | |_^ expected struct `tower_grpc::body::BoxBody`, found () ``` pushed the whole example [here](https://github.com/jxs/tower-error-example/blob/master/src/main.rs) thanks
C-enhancement,A-diagnostics,T-compiler,A-impl-trait,D-confusing
low
Critical
436,957,376
vscode
FileSystemWatcher fires events to extensions before text documents are updated
Version: 1.33.1 (user setup) Commit: 51b0b28134d51361cf996d2f0a1c698247aeabd8 Date: 2019-04-11T08:27:14.102Z Electron: 3.1.6 Chrome: 66.0.3359.181 Node.js: 10.2.0 V8: 6.6.346.32 OS: Windows_NT x64 10.0.17763 I can repro this debugging the C/C++ extension ( https://github.com/Microsoft/vscode-cpptools ). In the handling of an onDidChange event from a FileSystemWatcher, we are loading the contents of that file (using vscode.workspace.openTextDocument), but the contents that are returned are outdated (prior to the change). This repro's for me regardless of whether the file is currently open for edit. If open, I see updated content in the UI. Even if I wait to step over openTextDocument until after the change is apparent in the UI, I still get the old contents.
api,under-discussion,file-watcher
medium
Critical
436,971,186
pytorch
Test failure for depthwise3x3_conv
## Bug Recently I start to get test failure on `depthwise3x3_conv`. And this happened on both CPU/GPU build, although this is probably not GPU related. I haven't get chance to dig deeper yet. ``` Start 89: depthwise3x3_conv_op_test 89/92 Test #89: depthwise3x3_conv_op_test ...............***Failed 0.24 sec ``` Here's the details: ``` Running main() from ../third_party/googletest/googletest/src/gtest_main.cc [==========] Running 1 test from 1 test case. [----------] Global test environment set-up. [----------] 1 test from DEPTHWISE3x3 [ RUN ] DEPTHWISE3x3.Conv WARNING: Logging before InitGoogleLogging() is written to STDERR I0425 01:23:28.802515 49204 depthwise3x3_conv_op_test.cc:54] running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 W0425 01:23:28.803205 49204 init.h:115] Caffe2 GlobalInit should be run before any other API calls. ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 25 20 (rel err 0.2222222238779068) (0 0 0 0) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 50 45 (rel err 0.10526315867900848) (0 0 0 1) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 2) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 3) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 4) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 5) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 6) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 7) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 8) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 9) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 10) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 11) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 12) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 13) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 14) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 15) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 16) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) Actual: false Expected: true 75 70 (rel err 0.068965516984462738) (0 0 0 17) running N 1 inputC 2 H 95 W 77 outputC 2 kernelH 3 kernelW 3 strideH 1 strideW 1 padT 2 padL 2 padB 2 padR 2 group 2 ../caffe2/share/contrib/depthwise/depthwise3x3_conv_op_test.cc:145: Failure Value of: relErr <= maxRelErr || (relErr > maxRelErr && absErr <= absErrForRelErrFailure) ``` ## Environment - PyTorch Version (e.g., 1.0): master - OS (e.g., Linux): CentOS-7 and Ubuntu-19.04 - How you installed PyTorch (`conda`, `pip`, source): source - Build command you used (if compiling from source): cmake + ninja + gcc8 - Python version: Stock 3.6 on both distro - CUDA/cuDNN version: 10.1 - GPU models and configuration: Volta
caffe2
low
Critical
436,998,127
node
Discussion: private fields and util.inspect
Now that we have support for private class fields... we need to figure out how (and if) we want to support them with regards to `util.inspect()`... Right now, those properties are hidden from the output even when `showHidden` is `true`... ```js class F { #foo = 1; } const f = new F() util.inspect(f) // returns 'F {}' util.inspect(f, { showHidden: true }) // returns 'F {}' ``` How should we handle these with inspect?
util
high
Critical
437,006,547
go
x/mobile/cmd/gomobile: bind -target=ios app.sdk/lightControl fail
<!-- Please answer these questions before submitting your issue. Thanks! --> ### What version of Go are you using (`go version`)? go version go1.12.4 darwin/amd64 ### Does this issue reproduce with the latest release? yes, always ### What operating system and processor architecture are y, ou using (`go env`)? GOARCH="amd64" GOBIN="/Users/fredlee/Documents/develop/go/workspace/bin" GOCACHE="/Users/fredlee/Library/Caches/go-build" GOEXE="" GOFLAGS="" GOHOSTARCH="amd64" GOHOSTOS="darwin" GOOS="darwin" GOPATH="/Users/fredlee/Documents/develop/go/workspace" GOPROXY="" GORACE="" GOROOT="/usr/local/go" GOTMPDIR="" GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64" GCCGO="gccgo" CC="clang" CXX="clang++" CGO_ENABLED="1" GOMOD="" CGO_CFLAGS="-g -O2" CGO_CPPFLAGS="" CGO_CXXFLAGS="-g -O2" CGO_FFLAGS="-g -O2" CGO_LDFLAGS="-g -O2" PKG_CONFIG="pkg-config" GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/go-build760905676=/tmp/go-build -gno-record-gcc-switches -fno-common" <details><summary><code>go env</code> Output</summary><br><pre> $ go env </pre></details> ### What did you do? <!-- If possible, provide a recipe for reproducing the error. A complete runnable program is good. A link on play.golang.org is best. --> ### What did you expect to see? macbookpro:lightControl fredlee$ gomobile bind -o android/lightControl.aar -target=android app.sdk/lightControl macbookpro:lightControl fredlee$ gomobile bind -target=ios app.sdk/lightControl ### What did you see instead? macbookpro:lightControl fredlee$ gomobile bind -o android/lightControl.aar -target=android app.sdk/lightControl macbookpro:lightControl fredlee$ gomobile bind -target=ios app.sdk/lightControl gomobile: darwin-arm: go build -tags ios -buildmode=c-archive -o /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/lightControl-arm.a gobind failed: exit status 2 gobind In file included from LightControl_darwin.m:9: /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:87:4: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:88:22: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:89:4: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:90:25: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:95:4: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:96:26: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:99:4: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:100:22: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:101:4: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:102:17: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:109:4: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:110:19: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:111:4: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:112:19: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:113:4: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:114:19: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:115:4: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:116:19: error: expected a type /var/folders/34/z2z_vp1573g5014m8k7wys100000gn/T/gomobile-work-626724909/src/gobind/LightControl.objc.h:272:4: error: expected a type fatal error: too many errors emitted, stopping now [-ferror-limit=]
NeedsInvestigation,mobile
low
Critical
437,024,068
go
proposal: net: export isDomainName
I'd like to essentially re-open https://github.com/golang/go/issues/2880 for consideration. The motivating factor here is I have yet to find a good canonical piece of code which callers can leverage to validate an input name against [RFC 1035](https://tools.ietf.org/html/rfc1035). Searching around for such code yields a whole world of regexes people have come up with that don't fully implement the spec. `net.isDomainName` may not be perfect either (see: https://github.com/golang/go/issues/17659), but it would do a better job that what I'm finding out there otherwise (and be faster). The original issue got kicked around a lot and eventually closed, so I'm hoping for some feedback one way or the other this time around. Thanks!
Proposal,Proposal-Hold
low
Major
437,035,739
rust
Consider shipping llvm-rc.exe on windows.
I wonder if it's feasible to ship llvm-rc.exe for windows targets. This tool has limited capacity compared with windres.exe from MinGW and rc.exe from MSVC, but i think it can make steps towards solving https://github.com/rust-lang/rfcs/issues/721 or similar issues.
A-LLVM,O-windows,C-enhancement,T-compiler,T-dev-tools
low
Minor
437,048,933
node
--cpu-prof not generate profile file when killed by SIGINT
<!-- Thank you for reporting a possible bug in Node.js. Please fill in as much of the template below as you can. Version: output of `node -v` Platform: output of `uname -a` (UNIX), or version and 32 or 64-bit (Windows) Subsystem: if known, please specify the affected core module name If possible, please provide code that demonstrates the problem, keeping it as simple and free of external dependencies as you can. --> * **Version**: 12.0.0 * **Platform**: mac 10.12.4 && Debian 8 * **Subsystem**: <!-- Please provide more details below this comment. --> ``` // app.js // for more info about ReDoS, see: // https://en.wikipedia.org/wiki/ReDoS var r = /([a-z]+)+$/ var s = 'aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa!' console.log('Running regular expression... please wait') for(let i=1;i<100;i++){ console.time('benchmark'); const s = 'a'.repeat(i) + '!' r.test(s); console.timeEnd('benchmark'); } ``` ``` $ node --cpu-prof app.js $ kill -SIGINT {pid} ``` is this purpose ? or how can i get profile file when app killed by SIGINT?
v8 engine
low
Critical
437,169,405
opencv
Mantiuk06 tonemapping does not converge for this image
<!-- * Try to be as detailed as possible in your report. --> ##### System information (version) - OpenCV => 4.0.0 - Operating System / Platform => Windows 64 Bit - Compiler => Visual Studio 2017 ##### Detailed description In many cases, the result of cv's mantiuk tonemapping is a mess, which leads me to believe that the iterative algorithm does not converge. Attached one such case. [MantiukTestcase.zip](https://github.com/opencv/opencv/files/3116812/MantiukTestcase.zip)
category: photo
low
Minor
437,174,821
pytorch
Importing open3d after PyTorch causes free(): invalid pointer
## 🐛 Bug Importing the open3d python package after importing PyTorch causes the above crash. ## To Reproduce Steps to reproduce the behavior: >>> import torch >>> import open3d A two line script with the above statements crashes every time for me. Reversing the order of the imports fixes the problem. I'm using open3d version 0.6.0.0 and PyTorch version 1.0.1.post2. ## Expected behavior Both packages should be imported normally. ## Environment PyTorch version: 1.0.1.post2 Is debug build: No CUDA used to build PyTorch: 9.0.176 OS: Ubuntu 18.04.2 LTS GCC version: (Ubuntu 7.3.0-27ubuntu1~18.04) 7.3.0 CMake version: version 3.14.0 Python version: 3.6 Is CUDA available: Yes CUDA runtime version: 10.0.130 GPU models and configuration: GPU 0: GeForce GTX 1080 Ti GPU 1: GeForce GTX 1080 Ti GPU 2: GeForce GTX 1080 Ti GPU 3: GeForce GTX 1080 Ti Nvidia driver version: 410.78 cuDNN version: /usr/lib/x86_64-linux-gnu/libcudnn.so.7.4.2 Versions of relevant libraries: [pip3] numpy==1.16.3 [pip3] torch==1.0.1.post2 [pip3] torchfile==0.1.0 [pip3] torchvision==0.2.2.post3 [pip3] torchviz==0.0.1 [conda] Could not collect
module: crash,triaged,module: pybind
medium
Critical
437,180,151
TypeScript
Type safety for enum property names
## Suggestion Enums work in two directions, where an enum property value can be retrieved via `AnEnum.aProperty` and a property name can be retrieved via `AnEnum[aValue]`. In TypeScript 3.4.3, the type of the second expression is `string`. Instead, it should be equivalent to `keyof typeof AnEnum | undefined`. ## Use Cases While the `nameof` operator (suggested in #1579) does not exist yet, a construct such as `AnEnum[AnEnum.aProperty]` can currently be used to safely refer to an enum property name. Unfortunately, since the type of that expression is `string` it requires a cast when assigning it to a type safe target. ## Examples ```typescript enum AnEnum { aProperty = 1, anotherProperty = 23, yetAnotherOne = 42 }; let target: keyof typeof AnEnum; … // Compilation error here: Type 'string' is not assignable to type '"aProperty" | "anotherProperty" | "yetAnotherOne"'. target = AnEnum[AnEnum.aProperty]; ``` ## Checklist My suggestion meets these guidelines: * [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code * [x] This wouldn't change the runtime behavior of existing JavaScript code * [x] This could be implemented without emitting different JS based on the types of the expressions * [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, etc.) * [x] This feature would agree with the rest of [TypeScript's Design Goals](https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals).
Suggestion,Awaiting More Feedback
low
Critical
437,188,375
vue-element-admin
标签栏导航关闭有问题
<!-- 注意:为更好的解决你的问题,请参考模板提供完整信息,准确描述问题,信息不全的 issue 将被关闭。 Note: In order to better solve your problem, please refer to the template to provide complete information, accurately describe the problem, and the incomplete information issue will be closed. --> ## Bug report(问题描述) 当标签栏导航打开多个的时候入demo中的综合实例-文章列表-点开多个详情的时候如果大于2的数目的时候,页面的显示会出错,之前的详情都被激活.... #### Steps to reproduce(问题复现步骤) <!-- 1. 版本 3.9.3 2. 在综合实例中点开多个文章详情,然后从最后一个依次关闭 3. 即可复现问题 --> #### Screenshot or Gif(截图或动态图) ![image](https://user-images.githubusercontent.com/31301552/56737742-ae1a5b00-679d-11e9-8f7a-51338a3ccb29.png) #### Link to minimal reproduction(最小可在线还原demo) 版本 3.9.3 即可 <!-- Please only use Codepen, JSFiddle, CodeSandbox or a github repo --> #### Other relevant information(格外信息) - Your OS: window - Node.js version: 8.12.0 - vue-element-admin version: 3.9.3
need repro :mag_right:
low
Critical
437,199,356
flutter
At the driver test case, i want to know the details about the phone that is being tested such as the chosen locale and screen size
At the driver test case, i want to know few things like which locale where used within the app or the screen size that is being tested (Consider that i run the same set of tests on several combinations of phones and locales). I can use this informations to test some behaviors that should happen depending on the screen size or locale. Sometimes, you want to be sure that some localized info is being displayed on the screen. Or some behavior should happen depending on the locale.
c: new feature,framework,t: flutter driver,c: proposal,P3,team-framework,triaged-framework
low
Major