id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
โŒ€
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
2,799,429,388
rust
Allow attribute does not surpress unknown_or_malformed_diagnostic_attributes
### Code ```Rust trait _Trait {} #[allow(unknown_or_malformed_diagnostic_attributes)] #[diagnostic::abcdef] impl _Trait for () {} ``` ### Current output ```Shell warning: unknown diagnostic attribute --> src/lib.rs:3:15 | 3 | #[diagnostic::abcdef] | ^^^^^^ | = note: `#[warn(unknown_or_malformed_diagnostic_attributes)]` on by default warning: `playground` (lib) generated 1 warning ``` ### Desired output ```Shell (no warning) ``` ### Rationale and extra context See https://github.com/bevyengine/bevy/pull/17441 for a case where this comes up, where it can't be worked around by introducing a module (because of https://github.com/rust-lang/rust/issues/79260) or allowing it globally because the lint triggers in a macro. ### Rust Version ```Shell rustc 1.86.0-nightly (9a1d156f3 2025-01-19) binary: rustc commit-hash: 9a1d156f38c51441ee51e5a068f1d0caf4bb0f27 commit-date: 2025-01-19 host: x86_64-unknown-linux-gnu release: 1.86.0-nightly LLVM version: 19.1.7 ```
A-lints,A-diagnostics,T-compiler,C-bug,D-diagnostic-infra,L-unknown_or_malformed_diagnostic_attributes
low
Minor
2,799,473,740
next.js
Error when adding FormatJS SWC Plugin
### Link to the code that reproduces this issue https://github.com/rubanooo/next-swc-formatjs-error ### To Reproduce 1. Install the SWC plugin 2. Add to the next config with the following format: ```ts import type { NextConfig } from "next"; const nextConfig: NextConfig = { /* config options here */ experimental: { swcPlugins: [ ['@swc/plugin-formatjs', {}] ] } }; export default nextConfig; ``` 3. Run the dev server ### Current vs. Expected behavior Following the 3 steps, I expect the server to not panic at least ### Provide environment information ```bash Operating System: Platform: darwin Arch: arm64 Version: Darwin Kernel Version 24.2.0: Fri Dec 6 19:01:59 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6000 Available memory (MB): 16384 Available CPU cores: 10 Binaries: Node: 20.14.0 npm: 10.7.0 Yarn: N/A pnpm: 9.15.2 Relevant Packages: next: 15.1.5 // Latest available version is detected (15.1.5). eslint-config-next: N/A react: 19.0.0 react-dom: 19.0.0 typescript: N/A Next.js Config: output: N/A ``` ### Which area(s) are affected? (Select all that apply) SWC ### Which stage(s) are affected? (Select all that apply) next dev (local), next build (local), next start (local) ### Additional context The error message when using turbopack: ``` Panic: panicked at turbopack/crates/turbopack-swc-utils/src/emitter.rs:52:13: IssueCollector and IssueEmitter were dropped without calling `collector.emit().await?` Backtrace: 0: _napi_register_module_v1 1: <unknown> 2: _napi_register_module_v1 3: _napi_register_module_v1 4: _napi_register_module_v1 5: _napi_register_module_v1 6: _napi_register_module_v1 7: _BrotliDecoderVersion 8: _BrotliDecoderVersion 9: _BrotliDecoderVersion 10: _BrotliDecoderVersion 11: <unknown> 12: <unknown> 13: <unknown> 14: <unknown> 15: <unknown> 16: <unknown> 17: <unknown> 18: <unknown> 19: <unknown> 20: <unknown> 21: <unknown> 22: _napi_register_module_v1 23: _napi_register_module_v1 24: _napi_register_module_v1 25: _napi_register_module_v1 26: _napi_register_module_v1 27: _napi_register_module_v1 28: _napi_register_module_v1 29: _napi_register_module_v1 30: _napi_register_module_v1 31: _napi_register_module_v1 32: _napi_register_module_v1 33: _napi_register_module_v1 34: _napi_register_module_v1 35: __pthread_deallocate ``` The error message when not using turbopack: ``` Panic: panicked at /Users/geist/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc-5.0.2/src/plugin.rs:169:14: failed to invoke plugin: failed to invoke plugin on 'Some("/Users/ruben/Code/tosize/next-swc-formatjs-error/src/app/layout.tsx")' Caused by: 0: failed to invoke `/Users/ruben/Code/tosize/next-swc-formatjs-error/node_modules/.pnpm/@[email protected]/node_modules/@swc/plugin-formatjs/swc_plugin_formatjs.wasm` as js transform plugin at /Users/ruben/Code/tosize/next-swc-formatjs-error/node_modules/.pnpm/@[email protected]/node_modules/@swc/plugin-formatjs/swc_plugin_formatjs.wasm 1: wasm plugin bytecheck failed "check bytes error: check failed for tuple struct member 0: check failed for struct member pkg_version: pointer out of bounds: base 0x4c246060b98 offset -51922 not in range 0x4c246060a00..0x4c246060bb4" Backtrace: 0: _napi_register_module_v1 1: <unknown> 2: _napi_register_module_v1 3: _napi_register_module_v1 4: _napi_register_module_v1 5: _napi_register_module_v1 6: _napi_register_module_v1 7: _napi_register_module_v1 8: _BrotliDecoderVersion 9: _BrotliDecoderVersion 10: <unknown> 11: <unknown> 12: _BrotliDecoderVersion 13: _BrotliDecoderVersion 14: _BrotliDecoderVersion 15: _BrotliDecoderVersion 16: _BrotliDecoderVersion 17: <unknown> 18: <unknown> 19: <unknown> 20: <unknown> 21: <unknown> 22: <unknown> 23: <unknown> --------------------------- Panic: panicked at /Users/geist/.cargo/registry/src/index.crates.io-6f17d22bba15001f/swc-5.0.2/src/plugin.rs:169:14: failed to invoke plugin: failed to invoke plugin on 'Some("/Users/ruben/Code/tosize/next-swc-formatjs-error/node_modules/.pnpm/[email protected][email protected][email protected][email protected]/node_modules/next/dist/pages/_app.js")' Caused by: 0: failed to invoke `/Users/ruben/Code/tosize/next-swc-formatjs-error/node_modules/.pnpm/@[email protected]/node_modules/@swc/plugin-formatjs/swc_plugin_formatjs.wasm` as js transform plugin at /Users/ruben/Code/tosize/next-swc-formatjs-error/node_modules/.pnpm/@[email protected]/node_modules/@swc/plugin-formatjs/swc_plugin_formatjs.wasm 1: wasm plugin bytecheck failed "check bytes error: check failed for tuple struct member 0: check failed for struct member pkg_version: pointer out of bounds: base 0x4c248081198 offset -51922 not in range 0x4c248081000..0x4c2480811b4" Backtrace: 0: _napi_register_module_v1 1: <unknown> 2: _napi_register_module_v1 3: _napi_register_module_v1 4: _napi_register_module_v1 5: _napi_register_module_v1 6: _napi_register_module_v1 7: _napi_register_module_v1 8: _BrotliDecoderVersion 9: _BrotliDecoderVersion 10: <unknown> 11: <unknown> 12: _BrotliDecoderVersion 13: _BrotliDecoderVersion 14: _BrotliDecoderVersion 15: _BrotliDecoderVersion 16: _BrotliDecoderVersion 17: <unknown> 18: <unknown> 19: <unknown> 20: <unknown> 21: <unknown> 22: <unknown> 23: <unknown> ```
SWC
low
Critical
2,799,537,441
flutter
MacOS sandbox embed a command-line tool testing
### Steps to reproduce When developing MacOS sandbox app you can embed a command-line tool in a sandboxed app, see: https://developer.apple.com/documentation/xcode/embedding-a-helper-tool-in-a-sandboxed-app but when testing how can you access this embed command-line tool? ### Expected results I expect to have access to it like in my app ### Actual results permission issue when trying to use it. disabling the sandbox solve my test but this is not an option because the app need to run in sandbox mode ### Code sample <details open><summary>Code sample</summary> ```dart [Paste your code here] ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> [Upload media here] </details> ### Logs <details open><summary>Logs</summary> ```console [Paste your logs here] ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [Paste your output here] ``` </details>
waiting for customer response,in triage
low
Major
2,799,538,041
opencv
No way to initialize the IStreamReader class in the Java wrapper.
### System Information OpenCV version: 4.11.0 Operating System / Platform: Windows 10 22H2 Compiler & compiler version: 3.18.1 ### Detailed description In the Java wrapper of OpenCV, there is currently no way to initialize the IStreamReader class. While the class is exposed in the Java bindings, no constructor or factory method is implemented, making it impossible to create an instance. Specifically, the following constructor in the Videoio module of the Videoio class requires an instance of the IStreamReader class, but since there is no way to initialize IStreamReader, this functionality is unusable: `public VideoCapture(IStreamReader source, int apiPreference, MatOfInt params)` As a result, even though the IStreamReader class is supported in the native C++ implementation, it cannot be used in Java applications. ### Steps to reproduce Build with the BUILD_opencv_java_bindings_generator flag ON. ### Issue submission checklist - [x] I report the issue, it's not a question - [x] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution - [x] I updated to the latest OpenCV version and the issue is still there - [ ] There is reproducer code and related data files (videos, images, onnx, etc)
feature,category: videoio,category: java bindings
low
Minor
2,799,547,686
ollama
Cannot overcome Ollama error : ollama._types.ResponseError: POST predict: Post "http://127.0.0.1:35843/completion": EOF / panic: failed to decode batch: could not find a kv cache slot
### What is the issue? I believe there is a bug in ollama's processing which flags the following two errors: (result from running python file:) Ollama error : ollama._types.ResponseError: POST predict: Post "http://127.0.0.1:35843/completion": EOF (error in ollama logs:) panic: failed to decode batch: could not find a kv cache slot To recreate: I am using Ollama as my LLM to create a property graph in Llamaindex, repeatable following the code in this documentation: https://docs.llamaindex.ai/en/stable/examples/property_graph/property_graph_advanced/ Shortly after the code begins to run, it flags the above errors with Ollama. I confirmed with LlamaIndex the problem is with Ollama, and not Llamaindex (https://github.com/run-llama/llama_index/issues/17424). The LlamaIndex team linked my issue to (https://github.com/ollama/ollama/issues/7949). I have Ollama_DEBUG set and have the error flagged from the python script and then the Ollama logs. Request your support in fixing this issue. I am currently running Ollama v 0.5.1, but have tried with 0.3.14 per other comments in GitHub and get the same error. Here is the error from the python script: Traceback (most recent call last): File "/home/LlamaIndexTutorials/main.py", line 150, in <module> index = PropertyGraphIndex.from_documents( File "/home/.local/lib/python3.10/site-packages/llama_index/core/indices/base.py", line 119, in from_documents return cls( File "/home/.local/lib/python3.10/site-packages/llama_index/core/indices/property_graph/base.py", line 134, in __init__ super().__init__( File "/home/.local/lib/python3.10/site-packages/llama_index/core/indices/base.py", line 77, in __init__ index_struct = self.build_index_from_nodes( File "/home/.local/lib/python3.10/site-packages/llama_index/core/indices/base.py", line 185, in build_index_from_nodes return self._build_index_from_nodes(nodes, **build_kwargs) File "/home/.local/lib/python3.10/site-packages/llama_index/core/indices/property_graph/base.py", line 334, in _build_index_from_nodes nodes = self._insert_nodes(nodes or []) File "/home/.local/lib/python3.10/site-packages/llama_index/core/indices/property_graph/base.py", line 200, in _insert_nodes nodes = asyncio.run( File "/home/.local/lib/python3.10/site-packages/nest_asyncio.py", line 30, in run return loop.run_until_complete(task) File "/home/.local/lib/python3.10/site-packages/nest_asyncio.py", line 98, in run_until_complete return f.result() File "/usr/lib/python3.10/asyncio/futures.py", line 201, in result raise self._exception.with_traceback(self._exception_tb) File "/usr/lib/python3.10/asyncio/tasks.py", line 232, in __step result = coro.send(None) File "/home/.local/lib/python3.10/site-packages/llama_index/core/ingestion/pipeline.py", line 137, in arun_transformations nodes = await transform.acall(nodes, **kwargs) File "/home/.local/lib/python3.10/site-packages/llama_index/core/indices/property_graph/transformations/schema_llm.py", line 380, in acall return await run_jobs( File "/home/.local/lib/python3.10/site-packages/llama_index/core/instrumentation/dispatcher.py", line 367, in async_wrapper result = await func(*args, **kwargs) File "/home/.local/lib/python3.10/site-packages/llama_index/core/async_utils.py", line 146, in run_jobs results = await tqdm_asyncio.gather(*pool_jobs, desc=desc) File "/home/.local/lib/python3.10/site-packages/tqdm/asyncio.py", line 79, in gather res = [await f for f in cls.as_completed(ifs, loop=loop, timeout=timeout, File "/home/.local/lib/python3.10/site-packages/tqdm/asyncio.py", line 79, in <listcomp> res = [await f for f in cls.as_completed(ifs, loop=loop, timeout=timeout, File "/usr/lib/python3.10/asyncio/tasks.py", line 571, in _wait_for_one return f.result() # May raise f.exception(). File "/usr/lib/python3.10/asyncio/futures.py", line 201, in result raise self._exception.with_traceback(self._exception_tb) File "/usr/lib/python3.10/asyncio/tasks.py", line 232, in __step result = coro.send(None) File "/home/.local/lib/python3.10/site-packages/tqdm/asyncio.py", line 76, in wrap_awaitable return i, await f File "/home/.local/lib/python3.10/site-packages/llama_index/core/instrumentation/dispatcher.py", line 367, in async_wrapper result = await func(*args, **kwargs) File "/home/.local/lib/python3.10/site-packages/llama_index/core/async_utils.py", line 139, in worker return await job File "/home/.local/lib/python3.10/site-packages/llama_index/core/indices/property_graph/transformations/schema_llm.py", line 344, in _aextract kg_schema = await self.llm.astructured_predict( File "/home/.local/lib/python3.10/site-packages/llama_index/core/instrumentation/dispatcher.py", line 367, in async_wrapper result = await func(*args, **kwargs) File "/home/.local/lib/python3.10/site-packages/llama_index/llms/ollama/base.py", line 521, in astructured_predict response = await self.achat(messages, **llm_kwargs) File "/home/.local/lib/python3.10/site-packages/llama_index/core/instrumentation/dispatcher.py", line 367, in async_wrapper result = await func(*args, **kwargs) File "/home/.local/lib/python3.10/site-packages/llama_index/core/llms/callbacks.py", line 75, in wrapped_async_llm_chat f_return_val = await f(_self, messages, **kwargs) File "/home/.local/lib/python3.10/site-packages/llama_index/llms/ollama/base.py", line 435, in achat response = await self.async_client.chat( File "/home/.local/lib/python3.10/site-packages/ollama/_client.py", line 834, in chat return await self._request( File "/home/.local/lib/python3.10/site-packages/ollama/_client.py", line 679, in _request return cls(**(await self._request_raw(*args, **kwargs)).json()) File "/home/.local/lib/python3.10/site-packages/ollama/_client.py", line 624, in _request_raw raise ResponseError(e.response.text, e.response.status_code) from None ollama._types.ResponseError: POST predict: Post "http://127.0.0.1:35843/completion": EOF Here is the Ollama log: Jan 20 09:55:34 ollama[174]: time=2025-01-20T09:55:34.271-05:00 level=INFO source=.:0 msg="Server listening on 127.0.0.1:35843" Jan 20 09:55:34 ollama[174]: llama_model_loader: loaded meta data with 29 key-value pairs and 291 tensors from /usr/share/ollama/.ollama/models/blobs/sha256-87048bcd55216712ef14c11c2c303728463207b165bf18440b9b84b07ec00f87 (version GGUF V3 (latest)) Jan 20 09:55:34 ollama[174]: llama_model_loader: Dumping metadata keys/values. Note: KV overrides do not apply in this output. Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 0: general.architecture str = llama Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 1: general.type str = model Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 2: general.name str = Meta Llama 3.1 8B Instruct Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 3: general.finetune str = Instruct Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 4: general.basename str = Meta-Llama-3.1 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 5: general.size_label str = 8B Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 6: general.license str = llama3.1 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 7: general.tags arr[str,6] = ["facebook", "meta", "pytorch", "llam... Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 8: general.languages arr[str,8] = ["en", "de", "fr", "it", "pt", "hi", ... Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 9: llama.block_count u32 = 32 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 10: llama.context_length u32 = 131072 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 11: llama.embedding_length u32 = 4096 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 12: llama.feed_forward_length u32 = 14336 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 13: llama.attention.head_count u32 = 32 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 14: llama.attention.head_count_kv u32 = 8 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 15: llama.rope.freq_base f32 = 500000.000000 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 16: llama.attention.layer_norm_rms_epsilon f32 = 0.000010 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 17: general.file_type u32 = 2 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 18: llama.vocab_size u32 = 128256 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 19: llama.rope.dimension_count u32 = 128 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 20: tokenizer.ggml.model str = gpt2 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 21: tokenizer.ggml.pre str = llama-bpe Jan 20 09:55:34 ollama[174]: time=2025-01-20T09:55:34.325-05:00 level=INFO source=server.go:610 msg="waiting for server to become available" status="llm server loading model" Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 22: tokenizer.ggml.tokens arr[str,128256] = ["!", "\"", "#", "$", "%", "&", "'", ... Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 23: tokenizer.ggml.token_type arr[i32,128256] = [1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, 1, ... Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 24: tokenizer.ggml.merges arr[str,280147] = ["ฤ  ฤ ", "ฤ  ฤ ฤ ฤ ", "ฤ ฤ  ฤ ฤ ", "... Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 25: tokenizer.ggml.bos_token_id u32 = 128000 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 26: tokenizer.ggml.eos_token_id u32 = 128009 Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 27: tokenizer.chat_template str = {% set loop_messages = messages %}{% ... Jan 20 09:55:34 ollama[174]: llama_model_loader: - kv 28: general.quantization_version u32 = 2 Jan 20 09:55:34 ollama[174]: llama_model_loader: - type f32: 65 tensors Jan 20 09:55:34 ollama[174]: llama_model_loader: - type q4_0: 225 tensors Jan 20 09:55:34 ollama[174]: llama_model_loader: - type q6_K: 1 tensors Jan 20 09:55:34 ollama[174]: llm_load_vocab: special tokens cache size = 256 Jan 20 09:55:34 ollama[174]: llm_load_vocab: token to piece cache size = 0.7999 MB Jan 20 09:55:34 ollama[174]: llm_load_print_meta: format = GGUF V3 (latest) Jan 20 09:55:34 ollama[174]: llm_load_print_meta: arch = llama Jan 20 09:55:34 ollama[174]: llm_load_print_meta: vocab type = BPE Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_vocab = 128256 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_merges = 280147 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: vocab_only = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_ctx_train = 131072 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_embd = 4096 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_layer = 32 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_head = 32 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_head_kv = 8 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_rot = 128 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_swa = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_embd_head_k = 128 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_embd_head_v = 128 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_gqa = 4 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_embd_k_gqa = 1024 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_embd_v_gqa = 1024 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: f_norm_eps = 0.0e+00 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: f_norm_rms_eps = 1.0e-05 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: f_clamp_kqv = 0.0e+00 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: f_max_alibi_bias = 0.0e+00 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: f_logit_scale = 0.0e+00 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_ff = 14336 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_expert = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_expert_used = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: causal attn = 1 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: pooling type = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: rope type = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: rope scaling = linear Jan 20 09:55:34 ollama[174]: llm_load_print_meta: freq_base_train = 500000.0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: freq_scale_train = 1 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: n_ctx_orig_yarn = 131072 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: rope_finetuned = unknown Jan 20 09:55:34 ollama[174]: llm_load_print_meta: ssm_d_conv = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: ssm_d_inner = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: ssm_d_state = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: ssm_dt_rank = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: ssm_dt_b_c_rms = 0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: model type = 8B Jan 20 09:55:34 ollama[174]: llm_load_print_meta: model ftype = Q4_0 Jan 20 09:55:34 ollama[174]: llm_load_print_meta: model params = 8.03 B Jan 20 09:55:34 ollama[174]: llm_load_print_meta: model size = 4.33 GiB (4.64 BPW) Jan 20 09:55:34 ollama[174]: llm_load_print_meta: general.name = Meta Llama 3.1 8B Instruct Jan 20 09:55:34 ollama[174]: llm_load_print_meta: BOS token = 128000 '<|begin_of_text|>' Jan 20 09:55:34 ollama[174]: llm_load_print_meta: EOS token = 128009 '<|eot_id|>' Jan 20 09:55:34 ollama[174]: llm_load_print_meta: LF token = 128 'ร„' Jan 20 09:55:34 ollama[174]: llm_load_print_meta: EOT token = 128009 '<|eot_id|>' Jan 20 09:55:34 ollama[174]: llm_load_print_meta: EOM token = 128008 '<|eom_id|>' Jan 20 09:55:34 ollama[174]: llm_load_print_meta: EOG token = 128008 '<|eom_id|>' Jan 20 09:55:34 ollama[174]: llm_load_print_meta: EOG token = 128009 '<|eot_id|>' Jan 20 09:55:34 ollama[174]: llm_load_print_meta: max token length = 256 Jan 20 09:55:34 ollama[174]: ggml_cuda_init: GGML_CUDA_FORCE_MMQ: no Jan 20 09:55:34 ollama[174]: ggml_cuda_init: GGML_CUDA_FORCE_CUBLAS: no Jan 20 09:55:34 ollama[174]: ggml_cuda_init: found 1 CUDA devices: Jan 20 09:55:34 ollama[174]: Device 0: NVIDIA GeForce RTX 4090 Laptop GPU, compute capability 8.9, VMM: yes Jan 20 09:55:35 ollama[174]: llm_load_tensors: ggml ctx size = 0.27 MiB Jan 20 09:55:39 ollama[174]: llm_load_tensors: offloading 32 repeating layers to GPU Jan 20 09:55:39 ollama[174]: llm_load_tensors: offloading non-repeating layers to GPU Jan 20 09:55:39 ollama[174]: llm_load_tensors: offloaded 33/33 layers to GPU Jan 20 09:55:39 ollama[174]: llm_load_tensors: CPU buffer size = 281.81 MiB Jan 20 09:55:39 ollama[174]: llm_load_tensors: CUDA0 buffer size = 4155.99 MiB Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: n_ctx = 15616 Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: n_batch = 2048 Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: n_ubatch = 512 Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: flash_attn = 0 Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: freq_base = 500000.0 Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: freq_scale = 1 Jan 20 09:55:40 ollama[174]: llama_kv_cache_init: CUDA0 KV buffer size = 1952.00 MiB Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: KV self size = 1952.00 MiB, K (f16): 976.00 MiB, V (f16): 976.00 MiB Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: CUDA_Host output buffer size = 2.02 MiB Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: CUDA0 compute buffer size = 1038.50 MiB Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: CUDA_Host compute buffer size = 38.51 MiB Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: graph nodes = 1030 Jan 20 09:55:40 ollama[174]: llama_new_context_with_model: graph splits = 2 Jan 20 09:55:40 ollama[174]: time=2025-01-20T09:55:40.352-05:00 level=INFO source=server.go:615 msg="llama runner started in 6.28 seconds" Jan 20 09:56:01 ollama[174]: [GIN] 2025/01/20 - 09:56:01 | 200 | 27.323051198s | 127.0.0.1 | POST "/api/chat" Jan 20 09:56:16 ollama[174]: [GIN] 2025/01/20 - 09:56:16 | 200 | 42.63900776s | 127.0.0.1 | POST "/api/chat" Jan 20 09:56:20 ollama[174]: [GIN] 2025/01/20 - 09:56:20 | 200 | 47.105286485s | 127.0.0.1 | POST "/api/chat" Jan 20 09:56:23 ollama[174]: [GIN] 2025/01/20 - 09:56:23 | 200 | 49.422469993s | 127.0.0.1 | POST "/api/chat" Jan 20 09:57:02 ollama[174]: [GIN] 2025/01/20 - 09:57:02 | 200 | 1m1s | 127.0.0.1 | POST "/api/chat" Jan 20 09:57:07 ollama[174]: [GIN] 2025/01/20 - 09:57:07 | 200 | 44.852374838s | 127.0.0.1 | POST "/api/chat" Jan 20 09:57:10 ollama[174]: [GIN] 2025/01/20 - 09:57:10 | 200 | 54.031440642s | 127.0.0.1 | POST "/api/chat" Jan 20 09:57:17 ollama[174]: [GIN] 2025/01/20 - 09:57:17 | 200 | 7.628685854s | 127.0.0.1 | POST "/api/chat" Jan 20 09:57:54 ollama[174]: [GIN] 2025/01/20 - 09:57:54 | 200 | 51.377588763s | 127.0.0.1 | POST "/api/chat" Jan 20 09:57:58 ollama[174]: [GIN] 2025/01/20 - 09:57:58 | 200 | 50.995044466s | 127.0.0.1 | POST "/api/chat" Jan 20 09:58:05 ollama[174]: [GIN] 2025/01/20 - 09:58:05 | 200 | 47.414462265s | 127.0.0.1 | POST "/api/chat" Jan 20 09:58:45 ollama[174]: [GIN] 2025/01/20 - 09:58:45 | 200 | 51.214899981s | 127.0.0.1 | POST "/api/chat" Jan 20 09:59:12 ollama[174]: [GIN] 2025/01/20 - 09:59:12 | 200 | 1m13s | 127.0.0.1 | POST "/api/chat" Jan 20 09:59:18 ollama[174]: [GIN] 2025/01/20 - 09:59:18 | 200 | 1m13s | 127.0.0.1 | POST "/api/chat" Jan 20 09:59:37 ollama[174]: [GIN] 2025/01/20 - 09:59:37 | 200 | 51.817729012s | 127.0.0.1 | POST "/api/chat" Jan 20 10:00:11 ollama[174]: [GIN] 2025/01/20 - 10:00:11 | 200 | 59.507936464s | 127.0.0.1 | POST "/api/chat" Jan 20 10:00:22 ollama[174]: [GIN] 2025/01/20 - 10:00:22 | 200 | 1m3s | 127.0.0.1 | POST "/api/chat" Jan 20 10:00:52 ollama[174]: [GIN] 2025/01/20 - 10:00:52 | 200 | 1m15s | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:05 ollama[174]: [GIN] 2025/01/20 - 10:01:05 | 200 | 42.657578432s | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:10 ollama[174]: [GIN] 2025/01/20 - 10:01:10 | 200 | 58.529013717s | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:16 ollama[174]: [GIN] 2025/01/20 - 10:01:16 | 200 | 23.427177508s | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:23 ollama[174]: [GIN] 2025/01/20 - 10:01:23 | 200 | 17.708491186s | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:32 ollama[174]: [GIN] 2025/01/20 - 10:01:32 | 200 | 22.494067591s | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:37 ollama[174]: [GIN] 2025/01/20 - 10:01:37 | 200 | 21.82285361s | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:41 ollama[174]: [GIN] 2025/01/20 - 10:01:41 | 200 | 18.875235561s | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:50 ollama[174]: [GIN] 2025/01/20 - 10:01:50 | 200 | 17.608728526s | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:51 ollama[174]: panic: failed to decode batch: could not find a kv cache slot Jan 20 10:01:51 ollama[174]: goroutine 7 [running]: Jan 20 10:01:51 ollama[174]: main.(*Server).run(0xc0000ec120, {0x55e6900a79a0, 0xc0000c20a0}) Jan 20 10:01:51 ollama[174]: github.com/ollama/ollama/llama/runner/runner.go:344 +0x23e Jan 20 10:01:51 ollama[174]: created by main.main in goroutine 1 Jan 20 10:01:51 ollama[174]: github.com/ollama/ollama/llama/runner/runner.go:980 +0xd3e Jan 20 10:01:51 ollama[174]: [GIN] 2025/01/20 - 10:01:51 | 500 | 753.826293ms | 127.0.0.1 | POST "/api/chat" Jan 20 10:01:51 ollama[174]: [GIN] 2025/01/20 - 10:01:51 | 500 | 5m30s | 127.0.0.1 | POST "/api/chat" ### OS Linux ### GPU Nvidia ### CPU Intel ### Ollama version 0.5.1
bug
low
Critical
2,799,618,700
tauri
[feat] Add deprecation warning for `updater.dialog: true` in v1
### Describe the problem In v2 we somewhat quietly got rid of the built-in dialog. This is especially unexpected for devs that didn't set the `updater.dialog` config at all because it defaulted to `true` hiding the fact that no config in v2 is vastly different in behavior. For example one dev on discord updated many of their users to a v2 version of their app and now just noticed that those users can't receive any further updates. Very very unfortunate situation... ### Describe the solution you'd like The cli and/or compiler should print warnings. ### Alternatives considered I've already updated the migration docs with a bit of color to make this more apparent. ### Additional context _No response_
type: feature request
low
Minor
2,799,652,753
rust
UI test `multiple-reprs` fails on targets that set `c-enum-min-bits`
[This part of the test](https://github.com/rust-lang/rust/blob/b5741a36a897dd93936d31ea0c1688f1399a2e06/tests/ui/structs-enums/multiple-reprs.rs#L72) assumes that the enum's discriminant has a size of `c_int` which is true for most targets but not for targets that set [`TargetOptions.c_enum_min_bits`](https://github.com/rust-lang/rust/blob/b5741a36a897dd93936d31ea0c1688f1399a2e06/compiler/rustc_target/src/spec/base/thumb.rs#L56) like `thumbv7em-none-eabihf`. The `multiple-reprs` test fails when run on those target. affected revision: b5741a36a897dd93936d31ea0c1688f1399a2e06 I'll submit a PR fixing the test on those targets shortly
A-testsuite,T-compiler,C-bug
low
Minor
2,799,684,676
go
net/http: Response.Request doesn't contain updated URL after following redirects on js/wasm
### Go version go version go1.23.5 darwin/arm64 ### Output of `go env` in your module/workspace: ```shell GO111MODULE='' GOARCH='arm64' GOBIN='' GOCACHE='/Users/andrea/Library/Caches/go-build' GOENV='/Users/andrea/Library/Application Support/go/env' GOEXE='' GOEXPERIMENT='' GOFLAGS='' GOHOSTARCH='arm64' GOHOSTOS='darwin' GOINSECURE='' GOMODCACHE='/Users/andrea/go/pkg/mod' GONOPROXY='' GONOSUMDB='' GOOS='darwin' GOPATH='/Users/andrea/go' GOPRIVATE='' GOPROXY='https://proxy.golang.org,direct' GOROOT='/opt/homebrew/Cellar/go/1.23.5/libexec' GOSUMDB='sum.golang.org' GOTMPDIR='' GOTOOLCHAIN='auto' GOTOOLDIR='/opt/homebrew/Cellar/go/1.23.5/libexec/pkg/tool/darwin_arm64' GOVCS='' GOVERSION='go1.23.5' GODEBUG='' GOTELEMETRY='local' GOTELEMETRYDIR='/Users/andrea/Library/Application Support/go/telemetry' GCCGO='gccgo' GOARM64='v8.0' AR='ar' CC='cc' CXX='c++' CGO_ENABLED='1' GOMOD='/dev/null' GOWORK='' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_FFLAGS='-O2 -g' CGO_LDFLAGS='-O2 -g' PKG_CONFIG='pkg-config' GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/sq/sd718h_s6lq1hgfdnt_qq3d00000gn/T/go-build2937344254=/tmp/go-build -gno-record-gcc-switches -fno-common' ``` ### What did you do? I'm trying to get the url i've been redirected to. ```go package main import ( "log" "net/http" ) func main() { resp, err := http.Get("https://mock.httpstatus.io/301") if err != nil { log.Fatalln(err) } log.Printf("%s", resp.Request.URL.String()) } ``` build with `GOARCH=wasm GOOS=js go build -o test.wasm` Repro: https://github.com/andreademasi/go-redirect-repro ### What did you see happen? `resp.Request.URL.String()` is equal to `"https://mock.httpstatus.io/301"` ### What did you expect to see? `resp.Request.URL.String()` is equal to `"https://mock.httpstatus.io/200"` I understand that this happens because the browser automatically follows redirects and it is not possible to alter this behaviour under normal circumstances. I also tried using [http.Client.CheckRedirect](https://pkg.go.dev/net/http#Client.CheckRedirect) but the function never got called while running in wasm environment. The fetch API does expose the `redirected` property on the `Response` object to detect if a request got redirected or not (https://developer.mozilla.org/en-US/docs/Web/API/Response/redirected) and the `url` property contains the url you're redirected to. As a workaround this issue, I patched my own version of go to reflect the behaviour i'd like to see: ```go // net/http/response.go type Response struct { ... // Redirected indicates whether or not the response is the result of a redirect Redirected bool } // net/http/roundtrip_js.go ... redirected := result.Get("redirected").Bool() if redirected { if url, err := url.ParseRequestURI(result.Get("url").String()); err != nil { errCh <- fmt.Errorf("net/http: failed to parse response url: %v", err) return nil } else { req.URL = url } } respCh <- &Response{ Status: fmt.Sprintf("%d %s", code, StatusText(code)), StatusCode: code, Header: header, ContentLength: contentLength, Uncompressed: uncompressed, Body: body, Request: req, Redirected: redirected, } ... ``` I'll be willing to open a PR to patch this issue (if needed) and/or discuss a different approach
NeedsInvestigation,arch-wasm,OS-JS
low
Critical
2,799,689,367
PowerToys
[ARM64] EXception 0xD0000701 - PowerToys Run crashing while computer is idle
### Microsoft PowerToys version 0.87.1 ### Installation method Microsoft Store ### Running as admin Yes ### Area(s) with issue? PowerToys Run ### Steps to reproduce No perceptible steps - Error happens while computer is idle [2025-01-16.txt](https://github.com/user-attachments/files/18479814/2025-01-16.txt) [2025-01-17.txt](https://github.com/user-attachments/files/18479817/2025-01-17.txt) [2025-01-18.txt](https://github.com/user-attachments/files/18479816/2025-01-18.txt) [2025-01-19.txt](https://github.com/user-attachments/files/18479813/2025-01-19.txt) [2025-01-20.txt](https://github.com/user-attachments/files/18479815/2025-01-20.txt) ### โœ”๏ธ Expected Behavior _No response_ ### โŒ Actual Behavior _No response_ ### Other Software _No response_
Issue-Bug,Needs-Triage
low
Critical
2,799,697,500
vscode
Neither .vscode/settings.json or <user-data-dir>/User/settings.json are honored with serve-web
<!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- ๐Ÿ•ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- ๐Ÿ”Ž Search existing issues to avoid creating duplicates. --> <!-- ๐Ÿงช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- ๐Ÿ’ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- ๐Ÿ”ง Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes <!-- ๐Ÿช“ If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- ๐Ÿ“ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - VS Code Version: 1.96.4 cd4ee3b1c348a13bafd8f9ad8060705f6d4b9cba arm64 - OS Version: Darwin Chriss-MacBook-Pro-2.local 24.2.0 Darwin Kernel Version 24.2.0: Fri Dec 6 19:02:12 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6031 arm64 Steps to Reproduce: For the user-data-dir settings not being recognized: 1. Create a file `~/test-user-data-dir/User/settings.json` 2. Add settings.json something like this (easy to immediately see if they were applied): ```json { "workbench.startupEditor": "none", "workbench.colorTheme": "Default Dark Modern", "editor.fontSize": 16, "terminal.integrated.fontSize": 16, "files.autoSave": "afterDelay", "workbench.tree.indent": 16, "editor.minimap.enabled": false, "terminal.integrated.open": true, "terminal.integrated.defaultLocation": "bottom", "workbench.panel.defaultLocation": "bottom", "terminal.integrated.shellIntegration.enabled": true, "terminal.integrated.defaultProfile.osx": "zsh", "terminal.integrated.defaultProfile.linux": "bash", "terminal.integrated.profiles.osx": { "zsh": { "path": "/bin/zsh" } }, "terminal.integrated.profiles.linux": { "bash": { "path": "/bin/bash" } }, "security.workspace.trust.enabled": false, "security.workspace.trust.startupPrompt": "never", "security.workspace.trust.emptyWindow": true, "git.openRepositoryInParentFolders": "never" } ``` 3. Launch with: ```shell code serve-web \ --user-data-dir=~/test-user-data-dir \ --extensions-dir=~/test-ext-dir \ --server-data-dir=~/test-server-dir \ --accept-server-license-terms \ --without-connection-token \ --port=8000 ``` And navigate to `http://127.0.0.1:8000` Alternatively, if using a local `.vscode/settings.json` in the project of your choice 1. Create `~/my-project/.vscode/settings.json` (with this repro make sure you leave the `test-user-data-dir` completely empty) 2. Add same json settings as above 3. Launch with: ```shell code serve-web \ --user-data-dir=~/test-user-data-dir \ --extensions-dir=~/test-ext-dir \ --server-data-dir=~/test-server-dir \ --accept-server-license-terms \ --without-connection-token \ --port=8000 ``` And for this example, navigate to `http://127.0.0.1:8000/?folder=/my-project` In both cases, you will see things like the "Do you trust the authors?" popup (which should not be the case) and things like the font size(s), theme, all of which are not applied.
debt,code-cli
low
Critical
2,799,752,185
neovim
Don't include non-essential paths in runtimepath with `nvim --clean`
### Problem Apart from paths coming from `CMAKE_INSTALL_PREFIX`, my `rtp` value contains also (on Debian Sid) ``` /etc/xdg/nvim /etc/xdg/nvim/after /usr/local/share/nvim/site /usr/local/share/nvim/site/after /usr/share/gnome/nvim/site /usr/share/gnome/nvim/site/after /usr/share/nvim/site /usr/share/nvim/site/after ``` when I run `nvim --clean` and have `CMAKE_EXTRA_FLAGS="-DCMAKE_INSTALL_PREFIX=${HOME}/tmp/nvim/builds/from-src"` used to build and install Nvim. ### Steps to reproduce - build and install Nvim with `CMAKE_EXTRA_FLAGS="-DCMAKE_INSTALL_PREFIX=${HOME}/tmp/nvim/builds/from-src"` (or another path under home directory). - create `/usr/local/share/nvim/site/plugin/echo.lua` with `print('System-wide plugin here!')` - run `${HOME}/tmp/nvim/builds/from-src/bin/nvim --clean --headless -c q` and see the output. ### Expected behavior `rtp` consists only of paths under $CMAKE_INSTALL_PREFIX (or its default equivalent, when empty). ### Nvim version (nvim -v) v0.11.0-dev-1565+g43f4290bc6 ### Vim (not Nvim) behaves the same? no, vim --clean does not try to include "not prefixed" paths to rtp ### Operating system/version Debian Sid ### Terminal name/version alacritty 0.16.0-dev (c9c41e63) ### $TERM environment variable alacritty ### Installation from repo
defaults,runtime,core,startup
low
Major
2,799,757,000
ollama
Support for num_beam and Advanced Decoding Parameters
Thanks for creating Ollama. Itโ€™s been great getting models up and running quickly. As someone working on developing an LLM, Iโ€™d love to see support for advanced decoding parameters like num_beam. It would be very useful for fine-tuning the output. Right now, it seems a little limiting, and being able to tweak the settings. > >
feature request
low
Minor
2,799,831,175
godot
LSP rename of class_name also changes node path
### Tested versions 4.3.stable.arch_linux ### System information Godot v4.3.stable unknown - Arch Linux #1 SMP PREEMPT_DYNAMIC Sat, 18 Jan 2025 02:26:57 +0000 - Wayland - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (nvidia; 565.77) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads) ### Issue description Child.gd: ```gdscript extends Node3D class_name Child ``` Parent.gd: ```gdscript extends Node3D @onready var child: Child = $Child ``` In Child.gd, position the cursor over `Child` and request a lsp rename action. Change the name to `Other`. This changes Parent.gd to: ```gdscript extends Node3D @onready var child: Other = $Other ``` It should have changed to: ```gdscript extends Node3D @onready var child: Other = $Child ``` Renaming a class in gdscript does not imply you changed the node path. ### Steps to reproduce Open the example project, use a LSP to rename `Child` to `Other` ### Minimal reproduction project (MRP) [example.zip](https://github.com/user-attachments/files/18480232/example.zip)
bug,topic:gdscript
low
Minor
2,799,907,914
PowerToys
Crash After Sleeping For Weekend
### Microsoft PowerToys version 0.86.0 ### Installation method GitHub ### Running as admin Yes ### Area(s) with issue? Awake ### Steps to reproduce Computer slept over the weekend at work. Move mouse to awake, ### โœ”๏ธ Expected Behavior To have it wake without issues. ### โŒ Actual Behavior When move mouse to awaken. Shows all my window borders with XP grey colors. And multiple error pop-ups [2025-01-20.txt](https://github.com/user-attachments/files/18480481/2025-01-20.txt) ### Other Software _No response_
Issue-Bug,Needs-Triage
low
Critical
2,799,922,467
storybook
[Bug]: A11y addon with `manual: true` gets stuck in loading state
### Describe the bug When the A11y addon is configured with `manual: true` it does not work anymore. The UI got stuck in the loading state with the message: > Please wait while the accessibility scan is running ### Reproduction link https://stackblitz.com/edit/github-h1gyzzpc-ab5abiso?file=.storybook%2Fpreview.ts&preset=node ### Reproduction steps * Go to the Button Primary story * Switch to the Accessibility tab ### System ```bash Storybook Environment Info: System: OS: Linux 5.0 undefined CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz Shell: 1.0 - /bin/jsh Binaries: Node: 18.20.3 - /usr/local/bin/node Yarn: 1.22.19 - /usr/local/bin/yarn <----- active npm: 10.2.3 - /usr/local/bin/npm pnpm: 8.15.6 - /usr/local/bin/pnpm npmPackages: @storybook/addon-a11y: ^8.5.0 => 8.5.0 @storybook/addon-essentials: ^8.5.0 => 8.5.0 @storybook/blocks: ^8.5.0 => 8.5.0 @storybook/test: ^8.5.0 => 8.5.0 @storybook/web-components: ^8.5.0 => 8.5.0 @storybook/web-components-vite: ^8.5.0 => 8.5.0 storybook: ^8.5.0 => 8.5.0 ``` ### Additional context _No response_
bug,has workaround,addon: a11y,upgrade:8.5
low
Critical
2,799,951,834
yt-dlp
[SenateGov] Add metadata fields to extractor
### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE - [x] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field ### Checklist - [x] I'm requesting a site-specific feature - [x] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels)) - [x] I've checked that all provided URLs are playable in a browser with the same IP and same login details - [x] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates - [x] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue) - [x] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and I'm willing to share it if required ### Region US, probably no geo restrictions ### Example URLs https://www.help.senate.gov/hearings/vaccines-saving-lives-ensuring-confidence-and-protecting-public-health ### Provide a description that is worded well enough to be understood Add additional metadata fields to the `SenateGov` extractor. `upload_date`, `timestamp` The `Date` and `Time` fields should be present on most hearings pages. This can be used to calculate the `upload_date` and `timestamp`. Ex. ``` Date: Wednesday, September 9th, 2020 Time: 10:00am Location: 430 Dirksen Senate Office Building ``` Since the hearings take place in Washington, DC, I believe these should all be eastern US time. In addition to the metadata fields for `upload_date` and `timestamp`, it would be nice if the `Date` and `Time` could be preserved without time zone conversion. `live_status` I'm not particularly sure how to extract `live_status` from the `SenateGov` pages. For my use case, I just want to avoid downloading the livestreams, so only videos with a `live_status` of `not_live` or `was_live`. `hearing_type` I would like a custom metadata field for `hearing_type`. For this example, it would be `Full Committee Hearing` above the title in `<div class="Heading--overline"> Full Committee Hearing </div>`. `witnesses` I would also like to add a custom metadata field for `witnesses` to get the witnesses present in the hearing. For the included URL, that would be `Francis Collins, MD, PhD` and `VADM Jerome M. Adams, MD, MPH`. The additional witness information could be included in a dictionary: ``` witnesses = {'Francis Collins, MD, PhD': 'Director\nNational Institutes of Health\nBethesda, MD', 'VADM Jerome M. Adams, MD, MPH': 'Surgeon\nGeneral of the United States\nUnited States Department of Health and Human Services\nWashington, DC' ``` For my use case, I really only need the witness names, so the additional witness information is not a priority. `description` I would like to change the content of `description` to not be a generic descriptor like `The U.S. Senate Committee on Health, Education, Labor & Pensions`, but rather include the specific hearing information available on the webpage. Maybe something like `innerText` of `<div class="Hearing container pt-0 PageContent">` ``` Date: Wednesday, September 9th, 2020 Time: 10:00am Location: 430 Dirksen Senate Office Building OPEN IN NEW WINDOW Witnesses Francis Collins, MD, PhD Director National Institutes of Health Bethesda, MD DOWNLOAD TESTIMONY VADM Jerome M. Adams, MD, MPH Surgeon General of the United States United States Department of Health and Human Services Washington, DC DOWNLOAD TESTIMONY Related Transcripts Click here to view the final hearing transcript as printed. Related Photos View null Photo 1 View null Photo 2 View null Photo 3 View null Photo 4 View null Photo 5 View null Photo 6 ``` For my use case, I would be using description to manually check the other above metadata fields if there is some problem with the extractor. There might be some formatting differences on some of the senate websites, so I'm not sure if it will be easy to parse all the information correctly. ### Provide verbose output that clearly demonstrates the problem - [x] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`) - [x] If using API, add `'verbose': True` to `YoutubeDL` params instead - [x] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below ### Complete Verbose Output ```shell PyDev console: using IPython 8.18.1 Python 3.11.11 (main, Dec 4 2024, 08:55:07) [GCC 11.4.0] on linux import yt_dlp ydl_opts = { 'verbose': True } gov_url = 'https://www.help.senate.gov/hearings/vaccines-saving-lives-ensuring-confidence-and-protecting-public-health' with yt_dlp.YoutubeDL(ydl_opts) as ydl: gov_info = ydl.sanitize_info(ydl.extract_info(url=gov_url, download=False)) [debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8 (No ANSI), error utf-8 (No ANSI), screen utf-8 (No ANSI) [debug] yt-dlp version [email protected] from yt-dlp/yt-dlp-nightly-builds [68221ecc8] (pip) API [debug] params: {'verbose': True, 'compat_opts': set(), 'http_headers': {'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36', 'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8', 'Accept-Language': 'en-us,en;q=0.5', 'Sec-Fetch-Mode': 'navigate'}} [debug] Python 3.11.11 (CPython x86_64 64bit) - Linux-6.8.0-51-generic-x86_64-with-glibc2.35 (OpenSSL 3.0.2 15 Mar 2022, glibc 2.35) [debug] exe versions: ffmpeg N-71064-gd5e603ddc0-static (setts), ffprobe 4.4.2 [debug] Optional libraries: Cryptodome-3.19.0, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.32.3, secretstorage-3.3.3, sqlite3-3.37.2, urllib3-2.2.3, websockets-13.1 [debug] Proxy map: {} [debug] Request Handlers: urllib, requests, websockets [debug] Loaded 1837 extractors [SenateGov] Extracting URL: https://www.help.senate.gov/hearings/vaccines-saving-lives-ensuring-confidence-and-protecting-public-health [SenateGov] vaccines-saving-lives-ensuring-confidence-and-protecting-public-health: Downloading webpage [SenateISVP] Extracting URL: https://www.senate.gov/isvp/?auto_play=false&comm=help&filename=help090920&poster=https://www.help.senate.gov/assets/images/video-poster.png&stt=950 [SenateISVP] help090920: Downloading webpage [SenateISVP] help090920: Downloading m3u8 information [debug] Formats sorted by: hasvid, ie_pref, lang, quality, res, fps, hdr:12(7), vcodec, channels, acodec, size, br, asr, proto, vext, aext, hasaud, source, id [debug] Default format spec: bestvideo*+bestaudio/best gov_info Out[3]: {'id': 'help090920', 'title': 'Vaccines: Saving Lives, Ensuring Confidence, and Protecting Public Health', 'formats': [{'format_id': '395', 'format_index': None, 'url': 'https://www-senate-gov-msl3archive.akamaized.net/help/help090920_1/index_396_av-p.m3u8?sd=10&rebase=on', 'manifest_url': 'https://www-senate-gov-msl3archive.akamaized.net/help/help090920_1/master.m3u8', 'tbr': 395.0, 'ext': 'mp4', 'fps': None, 'protocol': 'm3u8_native', 'preference': None, 'quality': None, 'has_drm': False, 'width': 640, 'height': 360, 'vcodec': 'avc1.77.30', 'acodec': 'mp4a.40.2', 'dynamic_range': 'SDR', 'video_ext': 'mp4', 'audio_ext': 'none', 'vbr': None, 'abr': None, 'resolution': '640x360', 'aspect_ratio': 1.78, 'http_headers': {'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36', 'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8', 'Accept-Language': 'en-us,en;q=0.5', 'Sec-Fetch-Mode': 'navigate'}, 'format': '395 - 640x360'}], 'subtitles': {}, 'thumbnail': 'https://www.help.senate.gov/assets/images/sharelogo.jpg', '_old_archive_ids': ['senategov help090920'], 'original_url': 'https://www.help.senate.gov/hearings/vaccines-saving-lives-ensuring-confidence-and-protecting-public-health', 'webpage_url': 'https://www.help.senate.gov/hearings/vaccines-saving-lives-ensuring-confidence-and-protecting-public-health', 'webpage_url_basename': 'vaccines-saving-lives-ensuring-confidence-and-protecting-public-health', 'webpage_url_domain': 'help.senate.gov', 'extractor': 'SenateISVP', 'extractor_key': 'SenateISVP', 'display_id': 'vaccines-saving-lives-ensuring-confidence-and-protecting-public-health', 'description': 'The U.S. Senate Committee on Health, Education, Labor & Pensions', 'age_limit': 0, 'playlist': None, 'playlist_index': None, 'thumbnails': [{'url': 'https://www.help.senate.gov/assets/images/sharelogo.jpg', 'id': '0'}], 'fulltitle': 'Vaccines: Saving Lives, Ensuring Confidence, and Protecting Public Health', 'release_year': None, 'requested_subtitles': None, '_has_drm': None, 'epoch': 1737391137, 'format_id': '395', 'format_index': None, 'url': 'https://www-senate-gov-msl3archive.akamaized.net/help/help090920_1/index_396_av-p.m3u8?sd=10&rebase=on', 'manifest_url': 'https://www-senate-gov-msl3archive.akamaized.net/help/help090920_1/master.m3u8', 'tbr': 395.0, 'ext': 'mp4', 'fps': None, 'protocol': 'm3u8_native', 'preference': None, 'quality': None, 'has_drm': False, 'width': 640, 'height': 360, 'vcodec': 'avc1.77.30', 'acodec': 'mp4a.40.2', 'dynamic_range': 'SDR', 'video_ext': 'mp4', 'audio_ext': 'none', 'vbr': None, 'abr': None, 'resolution': '640x360', 'aspect_ratio': 1.78, 'http_headers': {'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/93.0.4577.63 Safari/537.36', 'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8', 'Accept-Language': 'en-us,en;q=0.5', 'Sec-Fetch-Mode': 'navigate'}, 'format': '395 - 640x360', '_type': 'video', '_version': {'version': '2025.01.19.232735', 'current_git_head': None, 'release_git_head': '68221ecc87c6a3f3515757bac2a0f9674a38e3f2', 'repository': 'yt-dlp/yt-dlp-nightly-builds'}} ```
site-enhancement,triage
low
Critical
2,799,956,277
yt-dlp
[SenateGov] Add channel / hearing list extractor
### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE - [x] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field ### Checklist - [x] I'm requesting a site-specific feature - [x] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels)) - [x] I've checked that all provided URLs are playable in a browser with the same IP and same login details - [x] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates - [x] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue) - [x] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and I'm willing to share it if required ### Region US, probably no geo restrictions ### Example URLs https://www.help.senate.gov/hearings ### Provide a description that is worded well enough to be understood Download all hearing list information like a Youtube channel / playlist. There are metadata fields in the table for `Hearing`, `Type`, `Location`, and `Date`. I believe these fields should be available in the individual hearing page, but I am not sure if they are consistent with one another. It would probably be best to default to the metadata available on the individual hearing page. The individual hearing page link is available as `<a class="LegislationList__link Link" href="https://www.help.senate.gov/hearings/starting-the-119th-congress"> Starting the 119th Congress </a>` Some hearings such as `[POSTPONED: S. 2305, S. 2780, S. 4436, S. 4583, S.5146, and S. 5103](https://www.help.senate.gov/hearings/s-2305-s-2780-s-4436-s-4583-s_-medical-graduate-investment-act-and-s_-food-and-drug-administration-foods-accountability-act)` are postponed, which means there is no video available. Such videos would be skipped, but this can happen when processing the individual hearing videos in `SenateGov`. Probably not a concern for the channel extraction. ![Image](https://github.com/user-attachments/assets/1d22871e-e194-49f4-be86-bdbeee9eb541) ### Provide verbose output that clearly demonstrates the problem - [x] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`) - [x] If using API, add `'verbose': True` to `YoutubeDL` params instead - [x] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below ### Complete Verbose Output ```shell PyDev console: using IPython 8.18.1 Python 3.11.11 (main, Dec 4 2024, 08:55:07) [GCC 11.4.0] on linux import yt_dlp ydl_opts = { 'verbose': True } hearing_list_url = 'https://www.help.senate.gov/hearings' with yt_dlp.YoutubeDL(ydl_opts) as ydl: hearing_list_info = ydl.sanitize_info(ydl.extract_info(url=hearing_list_url, download=False)) [debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8 (No ANSI), error utf-8 (No ANSI), screen utf-8 (No ANSI) [debug] yt-dlp version [email protected] from yt-dlp/yt-dlp-nightly-builds [68221ecc8] (pip) API [debug] params: {'verbose': True, 'compat_opts': set(), 'http_headers': {'User-Agent': 'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/96.0.4664.55 Safari/537.36', 'Accept': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8', 'Accept-Language': 'en-us,en;q=0.5', 'Sec-Fetch-Mode': 'navigate'}} [debug] Python 3.11.11 (CPython x86_64 64bit) - Linux-6.8.0-51-generic-x86_64-with-glibc2.35 (OpenSSL 3.0.2 15 Mar 2022, glibc 2.35) [debug] exe versions: ffmpeg N-71064-gd5e603ddc0-static (setts), ffprobe 4.4.2 [debug] Optional libraries: Cryptodome-3.19.0, brotli-1.1.0, certifi-2023.11.17, mutagen-1.47.0, requests-2.32.3, secretstorage-3.3.3, sqlite3-3.37.2, urllib3-2.2.3, websockets-13.1 [debug] Proxy map: {} [debug] Request Handlers: urllib, requests, websockets [debug] Loaded 1837 extractors [SenateGov] Extracting URL: https://www.help.senate.gov/hearings [SenateGov] hearings: Downloading webpage ERROR: Unsupported URL: https://www.help.senate.gov/hearings Traceback (most recent call last): File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/YoutubeDL.py", line 1637, in wrapper return func(self, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/YoutubeDL.py", line 1772, in __extract_info ie_result = ie.extract(url) ^^^^^^^^^^^^^^^ File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/extractor/common.py", line 742, in extract ie_result = self._real_extract(url) ^^^^^^^^^^^^^^^^^^^^^^^ File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/extractor/senategov.py", line 229, in _real_extract raise UnsupportedError(url) yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.help.senate.gov/hearings Traceback (most recent call last): File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/YoutubeDL.py", line 1637, in wrapper return func(self, *args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/YoutubeDL.py", line 1772, in __extract_info ie_result = ie.extract(url) ^^^^^^^^^^^^^^^ File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/extractor/common.py", line 742, in extract ie_result = self._real_extract(url) ^^^^^^^^^^^^^^^^^^^^^^^ File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/extractor/senategov.py", line 229, in _real_extract raise UnsupportedError(url) yt_dlp.utils.UnsupportedError: Unsupported URL: https://www.help.senate.gov/hearings During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/IPython/core/interactiveshell.py", line 3550, in run_code exec(code_obj, self.user_global_ns, self.user_ns) File "<ipython-input-2-0b0b74c9db58>", line 9, in <module> hearing_list_info = ydl.sanitize_info(ydl.extract_info(url=hearing_list_url, download=False)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/YoutubeDL.py", line 1626, in extract_info return self.__extract_info(url, self.get_info_extractor(key), download, extra_info, process) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/YoutubeDL.py", line 1655, in wrapper self.report_error(str(e), e.format_traceback()) File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/YoutubeDL.py", line 1095, in report_error self.trouble(f'{self._format_err("ERROR:", self.Styles.ERROR)} {message}', *args, **kwargs) File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/yt_dlp/YoutubeDL.py", line 1034, in trouble raise DownloadError(message, exc_info) yt_dlp.utils.DownloadError: ERROR: Unsupported URL: https://www.help.senate.gov/hearings hearing_list_info Traceback (most recent call last): File "/home/tianzi/.virtualenvs/python3.11news/lib/python3.11/site-packages/IPython/core/interactiveshell.py", line 3550, in run_code exec(code_obj, self.user_global_ns, self.user_ns) File "<ipython-input-3-08fd9e7b8150>", line 1, in <module> hearing_list_info NameError: name 'hearing_list_info' is not defined ```
site-enhancement,triage
low
Critical
2,799,960,952
vscode
Support for Single-Line Comments with Custom Endings
<!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- ๐Ÿ•ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- ๐Ÿ”Ž Search existing issues to avoid creating duplicates. --> <!-- ๐Ÿงช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- ๐Ÿ’ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- ๐Ÿ”ง Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes <!-- ๐Ÿช“ If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- ๐Ÿ“ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - VS Code Version: 1.96.4 - OS Version: macOS 15.2 Currently, Visual Studio Code does not natively support single-line comments with custom endings. This limitation affects the ability to properly handle comment syntax in certain templating languages, such as Django HTML, where single-line comments are enclosed with {# at the beginning and #} at the end. In the configuration file, it is not possible to specify lineComment as: ```json "lineComment": [ "{#", "#}" ] ``` Instead, it must be specified as: ```json "lineComment": "{#" ``` Steps to Reproduce: Create a file with Django HTML syntax. Attempt to use single-line comments with {# at the beginning and #} at the end. Notice that the comments are not handled correctly by the editor. **Expected Behavior:** Visual Studio Code should support single-line comments with custom endings, allowing for proper handling of comment syntax in templating languages like Django HTML. **Actual Behavior:** Visual Studio Code does not support single-line comments with custom endings, leading to incorrect handling of comments in templating languages. **Example:** ```django-html {# This is a single-line comment #} ``` **Additional Context:** This feature would greatly improve the development experience for users working with templating languages that use custom comment syntax.
feature-request
low
Critical
2,799,965,612
electron
Add "saveImageAt" and "copyImageAt" methods to "WebFrameMain" API
### Preflight Checklist - [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project. - [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to. - [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a feature request that matches the one I want to file, without success. ### Problem Description It would be beneficial to add context menu items to save images in Electron applications. This is currently not directly supported in the Electron API, which limits the functionality developers can offer to users in terms of image handling. ### Proposed Solution Introduce two new methods, `WebFrameMain.saveImageAt(x, y)` and `WebFrameMain.copyImageAt(x, y)`, in the Electron API. These methods should internally call the corresponding methods in Chromium's `content::RenderFrameHost` class to enable saving and copying images directly from the application interface. ### Alternatives Considered An alternative approach would be to implement this functionality manually using existing web technologies, but this could lead to inconsistent implementations and increased complexity for developers who need to implement this feature across different applications. ### Additional Information Chromium has a C++ class called `content::RenderFrameHost` which contains the functionality required for this feature: [Chromium Source](https://source.chromium.org/chromium/chromium/src/+/main:content/public/browser/render_frame_host.h;l=617-627;drc=61a5359d2a66fc8484ddcad5d7384c98e753f0da) Electron's `WebFrameMain` API is a JavaScript abstraction of `RenderFrameHost`. By adding `saveImageAt` and `copyImageAt` methods to `WebFrameMain`, developers can easily integrate image saving and copying features into their Electron applications. **References:** - [Electron WebFrameMain API Source](https://github.com/electron/electron/blob/main/shell/browser/api/electron_api_web_frame_main.cc) Adding these methods would allow developers to create context menu items for saving and copying images, enhancing the functionality of Electron-based applications.
enhancement :sparkles:,component/webframe
low
Minor
2,799,971,356
rust
Binary operators still have worse trait error information than their corrosponding operators.
### Code ```Rust struct Whatever; fn main() { let _ = Some([1, 2].into_iter()) == &Some([1, 2].into_iter()); } ``` ### Current output ```Shell error[E0369]: binary operation `==` cannot be applied to type `Option<std::array::IntoIter<{integer}, 2>>` --> src/main.rs:4:38 | 4 | let _ = Some([1, 2].into_iter()) == &Some([1, 2].into_iter()); | ------------------------ ^^ ------------------------- &Option<std::array::IntoIter<{integer}, 2>> | | | Option<std::array::IntoIter<{integer}, 2>> | note: the foreign item type `Option<std::array::IntoIter<{integer}, 2>>` doesn't implement `PartialEq<&Option<std::array::IntoIter<{integer}, 2>>>` --> /playground/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/option.rs:572:1 | 572 | pub enum Option<T> { | ^^^^^^^^^^^^^^^^^^ not implement `PartialEq<&Option<std::array::IntoIter<{integer}, 2>>>` For more information about this error, try `rustc --explain E0369`. ``` ### Desired output ```Shell error[E0369]: binary operation `==` cannot be applied to type `Option<std::array::IntoIter<{integer}, 2>>` --> src/main.rs:4:38 | 4 | let _ = Some([1, 2].into_iter()) == &Some([1, 2].into_iter()); | ------------------------ ^^ ------------------------- &Option<std::array::IntoIter<{integer}, 2>> | | | Option<std::array::IntoIter<{integer}, 2>> | | = note: the following trait bounds were not satisfied: `std::array::IntoIter<{integer}, 2>: PartialEq` which is required by `Option<std::array::IntoIter<{integer}, 2>>: PartialEq` `Option<std::array::IntoIter<{integer}, 2>>: Iterator` which is required by `&mut Option<std::array::IntoIter<{integer}, 2>>: Iterator` For more information about this error, try `rustc --explain E0369`. ``` ### Rationale and extra context compare to this code: ```rust struct Whatever; fn main() { let _ = Some([1, 2].into_iter()).eq(&Some([1, 2].into_iter())); } ``` that gives the exact trait bounds that were not satisfied (in particular, iterators over arrays do not implement PartialEq). this isn't the most realistic case, but i wanted to repro it without external dependencies, and there's a different diagnostic that triggers if the type is defined in the same crate as the error. ### Other cases ```Rust this diagnostic should fire whenever there is a type whose ability to implement a trait is dependent on one of its type variables implementing a trait. ``` ### Rust Version ```Shell rustc 1.85.0-nightly (7442931d4 2024-11-30) ``` ### Anything else? related to https://github.com/rust-lang/rust/issues/125631 this time it would be nice if the logic could be unified somehow.
A-diagnostics,T-compiler
low
Critical
2,799,972,235
rust
LLVM build failures on Windows/Mac
<!-- Thank you for submitting a bootstrap report! Please provide detailed information to help us reproduce and diagnose the issue. --> ### Summary On Windows and Mac, `x.py build src/llvm-project` can fail when `download-ci-llvm = false` is set in the `config.toml`. ### Command used Clone the rust repo, then copy the `config.example.toml` to `config.toml` and set the following: ```toml [llvm] download-ci-llvm = false ``` Then run: ```sh x.py build src/llvm-project ``` ### Expected behaviour A successful build, exiting 0. ### Actual behaviour On Mac, the result is: ``` -- Installing: /Users/ana/git/ferrocene/ferrocene/build/aarch64-apple-darwin/lld/lib/cmake/lld/LLDConfigVersion.cmake cargo:root=/Users/ana/git/ferrocene/ferrocene/build/aarch64-apple-darwin/lld finished in 31.764 seconds Building crtbegin.o and crtend.o for aarch64-apple-darwin cargo:warning=/Users/ana/git/ferrocene/ferrocene/src/llvm-project/compiler-rt/lib/builtins/crtbegin.c:15:28: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma cargo:warning= 15 | __attribute__((section(".eh_frame"), aligned(sizeof(void *)))) = {}; cargo:warning= | ^ cargo:warning=/Users/ana/git/ferrocene/ferrocene/src/llvm-project/compiler-rt/lib/builtins/crtbegin.c:49:24: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma cargo:warning= 49 | __attribute__((section(".init_array"), cargo:warning= | ^ cargo:warning=/Users/ana/git/ferrocene/ferrocene/src/llvm-project/compiler-rt/lib/builtins/crtbegin.c:106:24: error: argument to 'section' attribute is not valid for this target: mach-o section specifier requires a segment and section separated by a comma cargo:warning= 106 | __attribute__((section(".fini_array"), cargo:warning= | ^ cargo:warning=3 errors generated. error occurred: Command env -u IPHONEOS_DEPLOYMENT_TARGET "cc" "-O3" "-ffunction-sections" "-fdata-sections" "-fPIC" "--target=arm64-apple-macosx15.2" "-std=c11" "-DCRT_HAS_INITFINI_ARRAY" "-DEH_USE_FRAME_REGISTRY" "-o" "/Users/ana/git/ferrocene/ferrocene/build/aarch64-apple-darwin/native/crt/df7af2d07715af86-crtbegin.o" "-c" "/Users/ana/git/ferrocene/ferrocene/src/llvm-project/compiler-rt/lib/builtins/crtbegin.c" with args cc did not execute successfully (status code exit status: 1). ``` On Windows, the result is: ``` -- Installing: D:/git/ferrocene/ferrocene/build/x86_64-pc-windows-msvc/llvm/include/llvm/Config/llvm-config.h -- Installing: D:/git/ferrocene/ferrocene/build/x86_64-pc-windows-msvc/llvm/include/llvm/Support/VCSRevision.h -- Installing: D:/git/ferrocene/ferrocene/build/x86_64-pc-windows-msvc/llvm/lib/cmake/llvm/LLVMConfigExtensions.cmake cargo:root=D:\git\ferrocene\ferrocene\build\x86_64-pc-windows-msvc\llvm finished in 1242.431 seconds Building crtbegin.o and crtend.o for x86_64-pc-windows-msvc cargo:warning=cl : Command line warning D9002 : ignoring unknown option '-std=c11' crtbegin.c D:\git\ferrocene\ferrocene\src/llvm-project/compiler-rt/lib/builtins/crtbegin.c(9): fatal error C1034: stddef.h: no include path set error occurred: Command "C:\\Program Files\\Microsoft Visual Studio\\2022\\Community\\VC\\Tools\\MSVC\\14.40.33807\\bin\\HostX64\\x64\\cl.exe" "-nologo" "-MD" "-O2" "-Brepro" "-std=c11" "-DCRT_HAS_INITFINI_ARRAY" "-DEH_USE_FRAME_REGISTRY" "-FoD:\\git\\ferrocene\\ferrocene\\build\\x86_64-pc-windows-msvc\\native\\crt\\89a91fa0b39682bb-crtbegin.o" "-c" "D:\\git\\ferrocene\\ferrocene\\src/llvm-project/compiler-rt/lib/builtins/crtbegin.c" with args cl.exe did not execute successfully (status code exit code: 2). Build completed unsuccessfully in 0:39:09 ``` ### Bootstrap configuration (config.toml) The same as the `config.example.toml` but: ```toml [llvm] download-ci-llvm = false ``` ### Operating system This is happening on, as far as I know, all Windows and Mac targets. I tested on Mac 15.2 and Windows 11 24H2. ### HEAD bcd0683e5dce1945b5d940714742e7502883bb5c and 6a64e3b89724395d87a394ed9ebd954c474b080a both display the issue ### Additional context After discussing with @japaric, I believe that these steps (building crtbegin.o and crtend.o) are unnecessary, bootstrap seems to claim that these steps are for cross compiling to MUSL. We believe the issue happened sometime between #134839 (where the problem is not present) and #134987 (where the problem is now present) <!-- Include the complete build log in the section below. Enable backtrace and verbose mode if possible for more detailed information e.g., with `RUST_BACKTRACE=1 ./x build -v`. --> (Build logs excluded as they are longer than the Github Issues limit) [windows-log.txt](https://github.com/user-attachments/files/18480761/windows-log.txt) [mac-log.txt](https://github.com/user-attachments/files/18480762/mac-log.txt)
O-windows,O-macos,T-bootstrap,C-bug,E-needs-bisection,E-needs-investigation
low
Critical
2,799,979,331
deno
use `Object.defineProperty` to tamper `Uint8Array`.
Version: Deno x.x.x Hi, I would like to report a bug. The code below shows that `Unit8Array` properties, such as `length`, can be tampered with. ```javascript var desc = { get: function getLen() { return 0; } }; Object.defineProperty(Object.getPrototypeOf(Uint8Array).prototype, "length", desc); const uint8 = new Uint8Array(2); uint8[0] = 42; console.log(uint8[0]); // 42 console.log(uint8.length); // it should give 2, but it gives 0. ``` The bug would be triggered especially when we use a standard function of Deno: encoding/hex ```javascript var desc = { get: function getLen() { return 0; } }; Object.defineProperty(Object.getPrototypeOf(Uint8Array).prototype, "length", desc); import { crypto } from "jsr:@std/crypto"; import { encodeHex } from "jsr:@std/encoding/hex"; const readableStream = new TextEncoder().encode("test"); const hashBuffer = await crypto.subtle.digest("SHA-1", readableStream); const hash = encodeHex(hashBuffer); console.log("fileHash: ", hash.length, "HashBuffer: ", hashBuffer); //node does not affect the equivalent snippet using 'crypto' pkg. ``` By running the code above, the output would be an empty string based on tampering `length` property of `Uint8Array`. Regards, AH
question
low
Critical
2,799,988,704
godot
Lag caused by adding mesh to MeshInstance3D (possibly due to the use of threads) in Godot 4.4 dev4,5,6,7 and beta1
### Tested versions Reproducible in: Godot 4.4 beta1, dev4,5,6,7, ~Godot 4.4 dev1~ Not reproducible in: Godot 4.3 stable ### System information Godot v4.4.beta1 - Windows 10 (build 19045) - Multi-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3070 (NVIDIA; 32.0.15.6636) - AMD Ryzen 7 5800X 8-Core Processor (16 threads) ### Issue description In ~Godot 4.4 dev1~ **dev4,5,6,7 and 4.4 beta1**, a noticeable lag occurs when assigning a new not empty mesh to a MeshInstance3D. This happens specifically on the line: ```gdscript # sb.gd func changeMesh() -> void: # The lag issue is caused by this line in Godot 4.4 beta1 and dev4,5,6,7. # The issue persists from Godot 4.4 dev4,5,6,7 up to and including Godot 4.4 beta1. # If the same project is run in Godot 4.3 release, there are no issues. # Commenting out this line in Godot 4.4 removes the lag, suggesting the issue might be related to CSG/Mesh handling. # Replacing the line with add_child(CSGBox3D.new()) also causes lag in 4.4. # However, using add_child(Node3D.new()) works without any lag in 4.4. mi.mesh = BoxMesh.new() pass ``` The issue does not appear in Godot 4.3, where the same project works without any performance drops. When running the project in Godot 4.4 with this line active, there is significant lag, which can be resolved by commenting out the line. Additionally, replacing `mi.mesh = BoxMesh.new()` with `add_child(CSGBox3D.new())` triggers the same lag. However, using `add_child(Node3D.new())` works without any lag, suggesting the problem is related to mesh handling or CSG node processing in Godot 4.4. **In my project, there are parallel tasks (threads) being executed through a task manager, similar to what was used in my main project. Iโ€™m unsure whether the presence of these tasks is contributing to this issue. I added the same multithreading setup here, but I haven't been able to determine if the lag is caused by the mesh handling or if the task manager's threads are influencing it.** https://youtu.be/Uw34gAoN7HE ### Steps to reproduce Create a new Godot project and copy the provided scripts from MRP into your project or use MRP. - main.gd: Attach this script to a Node3D node. - sb.gd: Used in main.gd for creating instances of SB. - taskManager.gd: This is a helper script to manage tasks using WorkerThreadPool and should be Global. - Open the project in the Godot editor and run the scene. Observe the performance issue: The project creates 255 instances of the SB node. Each SB runs a heavy computation (simulated in the `somethingProcess()` method). After computation completes, the `changeMesh()` method is called to change the mesh of the SB instance. Check the lag that occurs when the `changeMesh()` method sets `mi.mesh = BoxMesh.new()`. This will introduce a noticeable lag in ~Godot 4.4 dev1~ dev4,5,6,7 and 4.4 beta1. The lag does not occur in Godot 4.3 stable. Test different changes: - Comment out the line `mi.mesh = BoxMesh.new()`. This removes the lag. - Replace the line with `add_child(CSGBox3D.new())`. This also causes the lag to appear in ~Godot 4.4 dev1~ dev4,5,6,7 and 4.4 beta1. - Replace it with `add_child(Node3D.new())`. The lag does not occur when using a simple Node3D instead of a meshes. ### Minimal reproduction project (MRP) [mrp-meshIssue4.4.zip](https://github.com/user-attachments/files/18480836/mrp-meshIssue4.4.zip)
bug,topic:rendering,confirmed,regression,topic:3d,performance
medium
Major
2,800,008,353
godot
Some DirectionalLight2D and PointLight2Ds are incorrectly rendered on Direct3D 12
### Tested versions - Reproducible in: 4.3.stable, 4.4.beta1, 4.4.beta 791c87eb7 ### System information Godot v4.4.beta (791c87eb7) - Windows 11 (build 22631) - Multi-window, 1 monitor - Direct3D 12 (Forward+) - dedicated NVIDIA GeForce RTX 4090 (NVIDIA; 32.0.15.6636) - 13th Gen Intel(R) Core(TM) i9-13900K (32 threads) ### Issue description Some DirectionalLight2D and PointLight2Ds are incorrectly rendered on Direct3D 12: ### DirectionalLight2D Vulkan | Direct3D 12 -|- ![Image](https://github.com/user-attachments/assets/d98f861d-7b2b-4363-a79a-0b28c21f7a76) | ![Image](https://github.com/user-attachments/assets/1b7b8b62-36b4-4fbb-8a31-5948f420e1cc) ### PointLight2D Vulkan | Direct3D 12 -|- ![Image](https://github.com/user-attachments/assets/68f14065-075b-4773-8a75-f615b675b676) | ![Image](https://github.com/user-attachments/assets/7aab2179-e22b-48fc-bbf2-8fb289d8a4fc) ### Steps to reproduce - Run `test_directional_light_2d.tscn` and `test_point_light_2d.tscn` in the MRP on Windows with a build that has Direct3D 12 enabled. - Notice how some lights are not present in the resulting image that is saved to `user://`. - Switch the RenderingDevice driver to `vulkan` in the Project Settings and try again. ### Minimal reproduction project (MRP) [test-light2d-d3d12.zip](https://github.com/user-attachments/files/18480961/test-light2d-d3d12.zip)
bug,platform:windows,topic:rendering,topic:2d
low
Minor
2,800,052,863
PowerToys
System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\Users\abood\AppData\Local\Microsoft\PowerToys\PowerToys Run\Plugins\PowerToys Run Plugin Updater\PowerToys Run Plugin Updater.exe'.
### Microsoft PowerToys version 0.87.1 ### Installation method Microsoft Store ### Running as admin No ### Area(s) with issue? PowerToys Run ### Steps to reproduce Just opened PowerToys Run after a reboot ### โœ”๏ธ Expected Behavior PowerToys Run works normally ### โŒ Actual Behavior A window appears with the following error: ``` Version: 0.87.1.0 OS Version: Microsoft Windows NT 10.0.26100.0 IntPtr Length: 8 x64: True Date: 20/01/2025 21:02:07 Exception: System.IO.DirectoryNotFoundException: Could not find a part of the path 'C:\Users\abood\AppData\Local\Microsoft\PowerToys\PowerToys Run\Plugins\PowerToys Run Plugin Updater\PowerToys Run Plugin Updater.exe'. at Microsoft.Win32.SafeHandles.SafeFileHandle.CreateFile(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options) at Microsoft.Win32.SafeHandles.SafeFileHandle.Open(String fullPath, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode) at System.IO.Strategies.OSFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode) at System.IO.Strategies.AsyncWindowsFileStreamStrategy..ctor(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode) at System.IO.Strategies.FileStreamHelpers.ChooseStrategyCore(String path, FileMode mode, FileAccess access, FileShare share, FileOptions options, Int64 preallocationSize, Nullable`1 unixCreateMode) at System.IO.FileStream..ctor(String path, FileMode mode, FileAccess access, FileShare share, Int32 bufferSize, Boolean useAsync) at Community.PowerToys.Run.Plugin.UniversalSearchSuggestions.Main.UpdatePlugin() at System.Threading.Tasks.Task.<>c.<ThrowAsync>b__128_0(Object state) at System.Windows.Threading.ExceptionWrapper.InternalRealCall(Delegate callback, Object args, Int32 numArgs) at System.Windows.Threading.ExceptionWrapper.TryCatchWhen(Object source, Delegate callback, Object args, Int32 numArgs, Delegate catchHandler) ``` [Also here's the log (2025-01-20.txt)](https://github.com/user-attachments/files/18481162/2025-01-20.txt) ### Other Software I have the following plugins installed: [Everything](https://github.com/lin-ycv/EverythingPowerToys) [Universal Search Suggestions](https://github.com/Fefedu973/PowerToys-Run-Universal-Search-Suggestions-Plugin) [Winget](https://github.com/bostrot/PowerToysRunPluginWinget) [Install](https://github.com/hlaueriksson/Community.PowerToys.Run.Plugin.Install) Also here are my settings: [settings.json](https://github.com/user-attachments/files/18481220/settings.json)
Issue-Bug,Needs-Triage
low
Critical
2,800,064,286
neovim
`==` should respect injected languages
### Problem I frequently run into annoying issues when I try to format injected languages using `==` because they aren't indented according to my usual settings for those languages. A good example is code blocks containing R, which I indent using treesitter, embedded in markdown documents, which I indent using vim syntax rules. If I try to indent my R code using `==`, Neovim treats it like markdown and the result is always very different from what I want. ### Expected behavior It would be great if `==` respected injected languages. NB, I found it fairly easy to put together a small [plugin](https://github.com/wurli/contextindent.nvim) which does exactly this using `vim.filetype.get_option("<ft for current line>", "indentexpr")`, but someone suggested that this really should be the default behaviour, hence this issue. I'd be more than happy to contribute a PR if anyone is willing to support/review. Thank you!
treesitter,options
low
Minor
2,800,075,791
rust
Assembly for Rc::<str>::default() looks quite inefficient
<!-- Thank you for filing a bug report! ๐Ÿ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> I tried this code: ```rust #[no_mangle] pub fn rc_str() -> std::rc::Rc<str> { std::rc::Rc::<str>::default() } ``` I expected this to allocate with a known layout and and handle potential allocation errors. Instead, before the allocation, the assembly contains not one, but two calls to `rc_inner_layout_for_value_layout` (indirect via `call r15`) ([compiler explorer](https://rust.godbolt.org/z/czTh317od)): ```asm rc_str: push r15 push r14 push rbx mov r15, qword ptr [rip + alloc::rc::rc_inner_layout_for_value_layout::h02e271ca20ae9f03@GOTPCREL] mov edi, 1 xor esi, esi call r15 mov rbx, rax mov r14, rdx mov edi, 1 xor esi, esi call r15 test rdx, rdx je .LBB0_2 mov rcx, qword ptr [rip + __rust_no_alloc_shim_is_unstable@GOTPCREL] movzx ecx, byte ptr [rcx] mov rdi, rdx mov rsi, rax call qword ptr [rip + __rust_alloc@GOTPCREL] .LBB0_2: test rax, rax je .LBB0_4 mov qword ptr [rax], 1 mov qword ptr [rax + 8], 1 xor edx, edx pop rbx pop r14 pop r15 ret .LBB0_4: mov rdi, rbx mov rsi, r14 call qword ptr [rip + alloc::alloc::handle_alloc_error::ha0642996a160fa99@GOTPCREL] ``` The two calls seem to [correspond to the source code (line 257 and 2076)](https://github.com/rust-lang/rust/blob/6a64e3b89724395d87a394ed9ebd954c474b080a/library/alloc/src/rc.rs#L2057), but I would have expected the compiler to be smart enough to see those should be the same, and even to compute that value at compile time. ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` rustc 1.86.0-nightly (6067b3631 2025-01-17) binary: rustc commit-hash: 6067b36314ab5eb2eb47cecc464545ba58e1ad24 commit-date: 2025-01-17 host: x86_64-unknown-linux-gnu release: 1.86.0-nightly LLVM version: 19.1.7 Compiler returned: 0 ``` </p> </details>
T-compiler,C-optimization
low
Critical
2,800,090,856
PowerToys
Support Vietnamese for Text Extractor
### Description of the new feature / enhancement Currently, the Text Extractor tool does not fully support the Vietnamese language. I propose an enhancement to enable the tool to accurately process and recognize Vietnamese text, including diacritical marks and the unique word arrangement of the language. ### Scenario when this would be used? Managing documents in Vietnam for both personal and professional purposes. Supporting translation, archiving, or data processing tasks involving Vietnamese text in fields such as education, administration, or commerce. ### Supporting information Vietnamese consists of 29 letters with diacritical marks: acute (ฬ), grave (ฬ€), tilde (ฬƒ), hook (ฬ‰), dot (ฬฃ). References for Vietnamese language processing: Research on Vietnamese Natural Language Processing. Open-source libraries supporting Vietnamese, such as Pyvi and VnCoreNLP.
Resolution-Already Fixed/Doesn't Apply,Product-Text Extractor
low
Minor
2,800,094,641
PowerToys
Add Alt+1, 2, 3, 4, 5 shortcuts for quick selection in PowerToys Run
### Description of the new feature / enhancement I propose adding keyboard shortcuts Alt+1, Alt+2, Alt+3, Alt+4, Alt+5 to PowerToys Run to allow quick selection of the corresponding search results. This feature will make the tool more efficient for users who rely on keyboard navigation. ### Scenario when this would be used? When a user searches for a command or application in PowerToys Run and wants to quickly execute it without additional navigation. This feature is particularly useful for power users who prefer keyboard shortcuts for speed and efficiency. ### Supporting information The addition of these shortcuts aligns with common UI patterns, such as using numbered shortcuts in command palettes or search tools. Similar implementations can be found in tools like Visual Studio Code and IntelliJ IDEA, which also support number-based quick selection.
Needs-Triage
low
Minor
2,800,121,921
vscode
Editor sticky scroll rendering error
<!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- ๐Ÿ•ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- ๐Ÿ”Ž Search existing issues to avoid creating duplicates. --> <!-- ๐Ÿงช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- ๐Ÿ’ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- ๐Ÿ”ง Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes/No (not tested at this time) <!-- ๐Ÿช“ If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- ๐Ÿ“ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> Version: 1.96.4 (user setup) Commit: cd4ee3b1c348a13bafd8f9ad8060705f6d4b9cba Date: 2025-01-16T00:16:19.038Z Electron: 32.2.6 ElectronBuildId: 10629634 Chromium: 128.0.6613.186 Node.js: 20.18.1 V8: 12.8.374.38-electron.0 OS: Windows_NT x64 10.0.22631 Steps to Reproduce: 1. You must have a document which triggers sticky-scroll while scrolling, you must use the mouse to position the view scroll bar specifically, and a region of the document that triggers sticky-scroll must specifically end in the scrolled state with blank lines between it and the next region. ![Image](https://github.com/user-attachments/assets/e9691681-e6a3-498e-910f-ae09b0f03764) Note how line 121 is partially scrolled within the sticky scroll area. Sometimes only the bottom pixel or two of the last line will be visible. Doesn't matter how many lines total are in the sticky scroll. It can be just one line. Note the blank line at the end of the region and the fact the region ends indented seems to be important, as is scrolling specifically with the mouse dragging the scroll bar to maximize the rendering error when the blank line after the region is effectively at the top but only about 1 pixel of it is showing. (Note line 54 is included below for completeness of what is seen in the issue image above...) ``` cpp constexpr CFG_CONSTANT_DATA_SJAR_LaRPairs_List_Struct SJAR_LaRPairs_A109_4_RM_STD = LaRPairs_List(5, {{5400, 305}, // 45 feet {6000, 353}, // 50 feet {6600, 425}, // 55 feet {11040, 720}, // 92 feet {10560, 720}}), // 88 feet, special 109 reach limit for CCC, 500lbs no water // based on 500lbs /w water calibration ** needs update ``` The file containing this code is about 610 lines long, and the length may have an effect as to how well the rendering issue shows up.
editor-sticky-scroll
low
Critical
2,800,138,098
go
reflect: allow stack allocation of underlying value for reflect.Value.Interface
### Go version tip ### What did you do? Run this simple test ([playground link](https://go.dev/play/p/zDD-8Yl91kk?v=gotip)): ```go func TestAllocsReflectInterface(t *testing.T) { allocs := testing.AllocsPerRun(100, func() { v := reflect.ValueOf(Point{x: 1, y: 1}) _ = v.Interface() // Causes the Point value to escape to heap. }) if allocs != 0 { t.Errorf("allocs = %d, want 0", int(allocs)) } } ``` ### What did you see happen? ``` prog_test.go:18: allocs = 1, want 0 --- FAIL: TestAllocsReflectInterface (0.00s) ``` ### What did you expect to see? Ideally, zero heap allocations in this test, and ideally reflect.Value.Interface would allow the underlying value to not always be heap allocated. This affects the fmt package and can affect other users of reflect like serialization libraries. This issue is a spin out from https://github.com/golang/go/issues/8618#issuecomment-1720049443. There are currently two reasons the underlying value escapes to the heap: 1. reflect.packEface causes reflect.Value.Interface to escape its underlying value: ``` parameter v leaks to <heap> for packEface with derefs=0: flow: <heap> โ† v: from v.ptr (dot) at .\value.go:145:13 from e.word = v.ptr (assign) at ./value.go:145:10 ``` 2. Within reflect.Value.Interface and its helpers, method values cause conditional allocation of a methodValue struct, which also causes underlying values of other types to also escape: ``` parameter v leaks to <heap> for valueInterface with derefs=0: flow: {heap} โ† v: from makeMethodValue("Interface", v) (call parameter) at ./value.go:1492:22 ``` I sent https://go.dev/cl/528535 to hopefully address the first reason in reflect.packEface. For addressing the second reason above and handling method values, I sent: * https://go.dev/cl/530095, which changes the runtime so that it manually creates the stack map for reflect.methodValueCall so that a stack-based methodValue can be tracked, including for example to properly update pointers during a stack copy operation. * https://go.dev/cl/530097, which updates reflect.Value.Interface to stack allocate a methodValue if needed and pass a pointer to it down the stack. This is done while side-stepping other reasons the *methodValue might escape, while keeping reflect.Value.Interface within the inlining budget so that a caller of reflect.Value.Interface can stack allocate a methodValue (which then ends up avoiding the need to always store all underlying values in the heap, regardless of whether or not they are a method value). * https://go.dev/cl/530096, which updates the compiler's escape analysis to recognize more self-assignment patterns. (This was originally used to help squeak past the inlining budget without escaping, but 530096 might end up not being needed for this issue). Together, these changes allow the test to pass without heap allocations. ----- I am hopefully returning to this shortly, and filing this issue to re-summarize the approach and to help with tracking & discussion. (Previously, a short overview was in https://github.com/golang/go/issues/8618#issuecomment-1720049443, in addition to more details in the individual CLs).
compiler/runtime,BugReport
low
Critical
2,800,144,465
react-native
ImageBackground sometimes only renders a portion of the image and does not fill the entire space
### Description There seems to be an issue with the ImageBackground component where it does not always render correctly. 90% of the time, it renders as expected, but that other 10% it won't fill the entire space. Instead, it only shows the image as what appears to be a 150 x 150 block. The issue happens on Android and IOS. I don't have a reproducer since the issue happens intermittently and looking at a reproducer likely won't actually show you the issue. I've included a screenshot and the code I'm using. ### Steps to reproduce Use ImageBackground and run the app ### React Native Version 0.76.2 ### Affected Platforms Runtime - Android, Runtime - iOS ### Output of `npx react-native info` ```text System: OS: macOS 13.5 CPU: (10) arm64 Apple M1 Pro Memory: 95.38 MB / 16.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 23.3.0 path: /opt/homebrew/bin/node Yarn: version: 3.6.4 path: /opt/homebrew/bin/yarn npm: version: 10.9.0 path: /opt/homebrew/bin/npm Watchman: version: 2024.11.18.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.16.2 path: /opt/homebrew/bin/pod SDKs: iOS SDK: Platforms: - DriverKit 23.2 - iOS 17.2 - macOS 14.2 - tvOS 17.2 - visionOS 1.0 - watchOS 10.2 Android SDK: Not Found IDEs: Android Studio: 2023.2 AI-232.10300.40.2321.11668458 Xcode: version: 15.2/15C500b path: /usr/bin/xcodebuild Languages: Java: version: 17.0.10 path: /usr/bin/javac Ruby: version: 3.1.4 path: /Users/johngoodman/.rbenv/shims/ruby npmPackages: "@react-native-community/cli": installed: 15.1.2 wanted: ^15.1.2 react: installed: 18.3.1 wanted: 18.3.1 react-native: installed: 0.76.2 wanted: 0.76.2 react-native-macos: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: true newArchEnabled: true iOS: hermesEnabled: true newArchEnabled: true ``` ### Stacktrace or Logs ```text n/a ``` ### Reproducer ... ### Screenshots and Videos Here's the screenshot - see how the image is only showing in the top right corner - in this instance, it's supposed to fill the entire screen. Again, this image issue only happens 10% of the time and the other 90% the ImageBackground renders as expected ( it fills the entire ImageBackground component ). Also note, the screenshot is of the simulator, but this issue happens in production builds on actual phones too. <img width="440" alt="Image" src="https://github.com/user-attachments/assets/62cfd118-6d5c-41e5-8aa4-6194ca58cc12" /> Here's the sample code: ``` import React from 'react'; import { StyleSheet, ImageBackground, Image, View, Text, SafeAreaView, ScrollView } from 'react-native'; const gradientDark = require('../../../assets/images/gradient-dark.png'); function Screen() { return ( <ImageBackground source={{uri: imageUrl}} resizeMode={'cover'} style={{height: '100%', resizeMode: 'cover'}} > <Image source={gradientDark} resizeMode={'cover'} style={styles.imageGradient} /> <SafeAreaView style={[ isAndroid ? headerPadding : null, {position: 'relative', zIndex: 1}] }> <ScrollView showsVerticalScrollIndicator={false} bounces={false} contentContainerStyle={{flexGrow: 1}} > <View> <Text>Body content goes here</Text> </View> </ScrollView> </SafeAreaView> <ImageBackground source={gradientDark} resizeMode={'cover'} style={styles.footer} /> </ImageBackground> ); } export default Screen; // -- const styles = StyleSheet.create({ imageGradient: { position: 'absolute', top: -10, zIndex: 0, width: '100%', height: 260, transform: [{rotate: '180deg'}], resizeMode: 'cover' }, footer: { position: 'absolute', bottom: 0, zIndex: 0, width: '100%', height: 200, resizeMode: 'cover' } }); ```
Component: Image,Component: ImageBackground,Needs: Repro,Newer Patch Available,Needs: Attention
low
Major
2,800,146,378
ui
[bug]: Monorepo import cn wrong path
### Describe the bug cd apps/web npx shadcn@canary add login-05 components create in package/ui -> correct components import cn from @repo/lib/utils -> wrong. should import from @repo/ui or ../utils ### Affected component/components Monorepo ### How to reproduce cd apps/web npx shadcn@canary add login-05 components create in package/ui -> correct components import cn from @repo/lib/utils -> wrong. should import from @repo/ui or ../utils ### Codesandbox/StackBlitz link _No response_ ### Logs ```bash ``` ### System Info ```bash mac, canary shadcn monorepo setup ``` ### Before submitting - [x] I've made research efforts and searched the documentation - [x] I've searched for existing issues
bug
low
Critical
2,800,165,926
rust
Missed optimization opportunity when trivially moving struct by moving fields
Example code: ```rust #[repr(C)] pub struct ThreeFields<'a> { a: &'a [u32], b: &'a [u32], c: &'a [u32], } #[inline(always)] pub fn should_be_no_op(val: ThreeFields) -> ThreeFields { ThreeFields { a: val.a, b: val.b, c: val.c, } } pub fn sum_slices_1(val: ThreeFields) -> u32 { sum(&val) } pub fn sum_slices_2(val: ThreeFields) -> u32 { let val = should_be_no_op(val); sum(&val) } #[inline(never)] pub fn sum(val: &ThreeFields) -> u32 { val.a.iter().sum::<u32>() + val.b.iter().sum::<u32>() + val.c.iter().sum::<u32>() } ``` In rustc 1.84 stable this generates a number of moves that I don't think need to be there, especially when inlining: ``` example::sum_slices_1::hc2a0527df8a4985d: jmp qword ptr [rip + example::sum::h228167780f08fdbb@GOTPCREL] example::sum_slices_2::hfa5e09ed5de6d084: sub rsp, 56 movups xmm0, xmmword ptr [rdi] movups xmm1, xmmword ptr [rdi + 16] movups xmm2, xmmword ptr [rdi + 32] movups xmmword ptr [rsp + 8], xmm0 movups xmmword ptr [rsp + 24], xmm1 movups xmmword ptr [rsp + 40], xmm2 lea rdi, [rsp + 8] call qword ptr [rip + example::sum::h228167780f08fdbb@GOTPCREL] add rsp, 56 ret ``` See https://rust.godbolt.org/z/erxfM53Kq While this is a pretty pointless example, this comes up in situations where you might want to convert a tuple of slices into a struct of slices in order to assign names to the tuple members (I've been running into these issues working on [gecs](https://github.com/recatek/gecs)). See also: https://github.com/rust-lang/rust/issues/107436 and https://github.com/rust-lang/rust/issues/135787
T-compiler,C-optimization
low
Minor
2,800,171,335
rust
Missed optimization opportunity when trivially converting between tuple struct and field struct by field values
Example code: ```rust #[repr(C)] pub struct Triple<'a>(&'a [u32], &'a [u32], &'a [u32]); #[repr(C)] pub struct ThreeFields<'a> { a: &'a [u32], b: &'a [u32], c: &'a [u32], } #[inline(always)] pub fn should_be_no_op(val: Triple) -> ThreeFields { ThreeFields { a: val.0, b: val.1, c: val.2, } } pub fn sum_slices_1(val: ThreeFields) -> u32 { sum(&val) } pub fn sum_slices_2(val: Triple) -> u32 { let val = should_be_no_op(val); sum(&val) } #[inline(never)] pub fn sum(val: &ThreeFields) -> u32 { val.a.iter().sum::<u32>() + val.b.iter().sum::<u32>() + val.c.iter().sum::<u32>() } ``` In rustc 1.84 stable this generates a number of moves that I don't think need to be there, especially when inlining: ``` example::sum_slices_1::hc2a0527df8a4985d: jmp qword ptr [rip + example::sum::h228167780f08fdbb@GOTPCREL] example::sum_slices_2::hc5b364eabe45dc38: sub rsp, 56 movups xmm0, xmmword ptr [rdi] movups xmm1, xmmword ptr [rdi + 16] movups xmm2, xmmword ptr [rdi + 32] movups xmmword ptr [rsp + 8], xmm0 movups xmmword ptr [rsp + 24], xmm1 movups xmmword ptr [rsp + 40], xmm2 lea rdi, [rsp + 8] call qword ptr [rip + example::sum::h228167780f08fdbb@GOTPCREL] add rsp, 56 ret ``` See https://rust.godbolt.org/z/3sG9nz3oc While this is a pretty pointless example, this comes up in situations where you might want to convert a tuple of slices into a struct of slices in order to assign names to the tuple members (I've been running into these issues working on [gecs](https://github.com/recatek/gecs)). See also: https://github.com/rust-lang/rust/issues/107436 and https://github.com/rust-lang/rust/issues/135786
T-compiler,C-optimization
low
Minor
2,800,218,474
pytorch
The `sympy` dependency spec for pytorch on PyPi wheel is still unchanged.
When run `pip install -U torch`, it will still require `sympy==1.13.1` and will uninstall the latest `sympy` which is version `1.13.3` in the virtual environment. The reason is due to the dependency spec unchanged in `setup.py`.
oncall: releng,triaged,module: third_party
low
Minor
2,800,221,889
go
x/tools/gopls: "missing reachable node for %q" bug in evaluatePackageHandle
``` #!stacks "bug.Reportf" && "evaluatePackageHandle.func2:+4" ``` Issue created by [stacks](https://pkg.go.dev/golang.org/x/tools/gopls/internal/telemetry/cmd/stacks). ```go // Collect reachable nodes. var reachableNodes []*handleNode // In the presence of context cancellation, any package may be missing. // We need all dependencies to produce a key. reachable.Elems(func(id typerefs.IndexID) { dh := b.nodes[id] if dh == nil { // Previous code reported an error (not a bug) here. bug.Reportf("missing reachable node for %q", id) <---------- here } else { reachableNodes = append(reachableNodes, dh) } }) ``` This stack `HFIUJQ` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-01-18.json): - `gopls/bug` - [`golang.org/x/tools/gopls/internal/util/bug.report:+35`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/util/bug/bug.go;l=109) - [`golang.org/x/tools/gopls/internal/util/bug.Reportf:+1`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/util/bug/bug.go;l=54) - [`golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).evaluatePackageHandle.func2:+4`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=1211) - [`golang.org/x/tools/gopls/internal/cache/typerefs.(*PackageSet).Elems:+10`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/typerefs/packageset.go;l=135) - [`golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).evaluatePackageHandle:+140`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=1207) - [`golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles.func2.1:+8`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=896) - [`golang.org/x/sync/errgroup.(*Group).Go.func1:+3`](https://cs.opensource.google/go/x/sync/+/v0.9.0:errgroup/errgroup.go;l=78) - `runtime.goexit:+0` ``` golang.org/x/tools/[email protected] go1.23.4 linux/amd64 vscode (1) golang.org/x/tools/[email protected] go1.23.2 linux/amd64 vscode (2) ```
NeedsInvestigation,gopls,Tools,gopls/telemetry-wins,BugReport
low
Critical
2,800,224,303
go
x/tools/gopls: "nil handle" assert in getPackageHandles
``` #!stacks "cache.assert" && "getPackageHandles:+93" ``` Issue created by [stacks](https://pkg.go.dev/golang.org/x/tools/gopls/internal/telemetry/cmd/stacks). ```go // Copy handles into the result map. handles := make(map[PackageID]*packageHandle, len(b.nodes)) for _, v := range b.nodes { assert(v.ph != nil, "nil handle") <--- here handles[v.mp.ID] = v.ph } ``` This stack `DcqCUg` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-01-18.json): - `crash/crash` - [`runtime.gopanic:+69`](https://cs.opensource.google/go/go/+/go1.23.4:src/runtime/panic.go;l=804) - [`golang.org/x/tools/gopls/internal/cache.assert:=10`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/debug.go;l=10) - [`golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles:+93`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=919) - [`golang.org/x/tools/gopls/internal/cache.(*Snapshot).forEachPackage:+37`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=194) - [`golang.org/x/tools/gopls/internal/cache.(*Snapshot).PackageDiagnostics:+28`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/snapshot.go;l=565) - [`golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedFiles:+50`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/server/diagnostics.go;l=292) - [`golang.org/x/tools/gopls/internal/server.(*server).diagnoseSnapshot:+14`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/server/diagnostics.go;l=215) - [`golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedViews.func1:+3`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/server/diagnostics.go;l=156) - [`golang.org/x/tools/gopls/internal/server.(*server).diagnoseChangedViews.gowrap1:+16`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/server/diagnostics.go;l=169) - `runtime.goexit:+0` ``` golang.org/x/tools/[email protected] go1.23.4 linux/amd64 vscode (1) ```
NeedsInvestigation,gopls,Tools,gopls/telemetry-wins,BugReport
low
Critical
2,800,226,349
go
x/tools/gopls: "missing reference to package %s" bug in getOneTransitiveRefLocked
``` #!stacks "bug.Reportf" && "getOneTransitiveRefLocked:+32" ``` Issue created by [stacks](https://pkg.go.dev/golang.org/x/tools/gopls/internal/telemetry/cmd/stacks). ```go // Note that if (!ok && trefs.complete), the name does not exist in the // referenced package, and we should not write to trefs as that may introduce // a race. if !ok && !trefs.complete { n := b.nodes[sym.Package] if n == nil { // We should always have IndexID in our node set, because symbol references // should only be recorded for packages that actually exist in the import graph. // // However, it is not easy to prove this (typerefs are serialized and // deserialized), so make this code temporarily defensive while we are on a // point release. // // TODO(rfindley): in the future, we should turn this into an assertion. bug.Reportf("missing reference to package %s", b.s.view.pkgIndex.PackageID(sym.Package)) <---- here return nil } ``` This stack `vcyB-g` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-01-18.json): - `gopls/bug` - [`golang.org/x/tools/gopls/internal/util/bug.report:+35`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/util/bug/bug.go;l=109) - [`golang.org/x/tools/gopls/internal/util/bug.Reportf:+1`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/util/bug/bug.go;l=54) - [`golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).getOneTransitiveRefLocked:+32`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=1039) - [`golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).getTransitiveRefs:+22`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=990) - [`golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).evaluatePackageHandle:+129`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=1196) - [`golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles.func2.1:+8`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/cache/check.go;l=896) - [`golang.org/x/sync/errgroup.(*Group).Go.func1:+3`](https://cs.opensource.google/go/x/sync/+/v0.9.0:errgroup/errgroup.go;l=78) - `runtime.goexit:+0` ``` golang.org/x/tools/[email protected] go1.23.2 linux/amd64 vscode (2) ```
NeedsInvestigation,gopls,Tools,gopls/telemetry-wins,BugReport
low
Critical
2,800,228,087
go
x/tools/gopls: Completion: SIGSEGV in scorePenalty
``` #!stacks "sigpanic"&& "completion.(*deepCompletionState).scorePenalty:+2" ``` Issue created by [stacks](https://pkg.go.dev/golang.org/x/tools/gopls/internal/telemetry/cmd/stacks). ```go // scorePenalty computes a deep candidate score penalty. A candidate is // penalized based on depth to favor shallower candidates. We also give a // slight bonus to unexported objects and a slight additional penalty to // function objects. func (s *deepCompletionState) scorePenalty(cand *candidate) float64 { var deepPenalty float64 for _, dc := range cand.path { <-- sigpanic deepPenalty++ if !dc.Exported() { deepPenalty -= 0.1 } if _, isSig := dc.Type().Underlying().(*types.Signature); isSig { deepPenalty += 0.1 } } // Normalize penalty to a max depth of 10. return deepPenalty / 10 } ``` This stack `AZThiA` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-01-18.json): - `crash/crash` - [`runtime.gopanic:+69`](https://cs.opensource.google/go/go/+/go1.23.4:src/runtime/panic.go;l=804) - `runtime.panicmem:=262` - [`runtime.sigpanic:+19`](https://cs.opensource.google/go/go/+/go1.23.4:src/runtime/signal_unix.go;l=917) - [`golang.org/x/tools/gopls/internal/golang/completion.(*deepCompletionState).scorePenalty:+2`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/golang/completion/deep_completion.go;l=55) - [`golang.org/x/tools/gopls/internal/golang/completion.(*completer).addCandidate:+37`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/golang/completion/deep_completion.go;l=287) - [`golang.org/x/tools/gopls/internal/golang/completion.(*completer).deepSearch:+71`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/golang/completion/deep_completion.go;l=180) - [`golang.org/x/tools/gopls/internal/golang/completion.Completion:+158`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/golang/completion/completion.go;l=659) - [`golang.org/x/tools/gopls/internal/server.(*server).Completion:+19`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/server/completion.go;l=43) - [`golang.org/x/tools/gopls/internal/protocol.serverDispatch:+193`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/protocol/tsserver.go;l=363) - [`golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.ServerHandler.func3:+5`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/protocol/protocol.go;l=160) - [`golang.org/x/tools/gopls/internal/lsprpc.(*streamServer).ServeStream.handshaker.func4:+52`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:gopls/internal/lsprpc/lsprpc.go;l=509) - [`golang.org/x/tools/gopls/internal/protocol.Handlers.MustReplyHandler.func1:+2`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:internal/jsonrpc2/handler.go;l=35) - [`golang.org/x/tools/gopls/internal/protocol.Handlers.AsyncHandler.func2.2:+3`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.1:internal/jsonrpc2/handler.go;l=104) - `runtime.goexit:+0` ``` golang.org/x/tools/[email protected] go1.23.4 linux/amd64 vscode (1) ```
NeedsInvestigation,gopls,Tools,gopls/telemetry-wins,BugReport
low
Critical
2,800,244,589
go
x/tools/gopls: "expected exported symbol" assert in getOneTransitiveRefLocked
``` #!stacks "cache.assert" && "evaluatePackageHandle.func1:+2" ``` Issue created by [stacks](https://pkg.go.dev/golang.org/x/tools/gopls/internal/telemetry/cmd/stacks). ```go // getOneTransitiveRefLocked computes the full set packages transitively // reachable through the given sym reference. // // It may return nil if the reference is invalid (i.e. the referenced name does // not exist). func (b *packageHandleBuilder) getOneTransitiveRefLocked(sym typerefs.Symbol) *typerefs.PackageSet { assert(token.IsExported(sym.Name), "expected exported symbol") <--- here trefs := b.transitiveRefs[sym.Package] if trefs == nil { trefs = &partialRefs{ refs: make(map[string]*typerefs.PackageSet), complete: false, } b.transitiveRefs[sym.Package] = trefs } ``` This stack `N2fS6w` was [reported by telemetry](https://storage.googleapis.com/prod-telemetry-merged/2025-01-17.json): - `crash/crash` - [`runtime.gopanic:+69`](https://cs.opensource.google/go/go/+/go1.23.4:src/runtime/panic.go;l=804) - [`golang.org/x/tools/gopls/internal/cache.assert:=10`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.0:gopls/internal/cache/debug.go;l=10) - [`golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).evaluatePackageHandle.func1:+2`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.0:gopls/internal/cache/check.go;l=1074) - [`runtime.gopanic:+50`](https://cs.opensource.google/go/go/+/go1.23.4:src/runtime/panic.go;l=785) - [`golang.org/x/tools/gopls/internal/cache.assert:=10`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.0:gopls/internal/cache/debug.go;l=10) - [`golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).getOneTransitiveRefLocked:+1`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.0:gopls/internal/cache/check.go;l=1008) - [`golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).getTransitiveRefs:+22`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.0:gopls/internal/cache/check.go;l=990) - [`golang.org/x/tools/gopls/internal/cache.(*packageHandleBuilder).evaluatePackageHandle:+129`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.0:gopls/internal/cache/check.go;l=1196) - [`golang.org/x/tools/gopls/internal/cache.(*Snapshot).getPackageHandles.func2.1:+8`](https://cs.opensource.google/go/x/tools/+/gopls/v0.17.0:gopls/internal/cache/check.go;l=896) - [`golang.org/x/sync/errgroup.(*Group).Go.func1:+3`](https://cs.opensource.google/go/x/sync/+/v0.9.0:errgroup/errgroup.go;l=78) - `runtime.goexit:+0` ``` golang.org/x/tools/[email protected] go1.23.4 linux/amd64 vscode (1) ```
NeedsInvestigation,gopls,Tools,gopls/telemetry-wins
low
Critical
2,800,248,089
godot
Error "get_cached_object: Failed to get cached node from peer 1686838219 with cache ID 1." when removing node in MultiplayerSpawner's auto spawn list with client as authority
### Tested versions 4.3.stable ### System information Godot v4.3.stable - Windows 10.0.26100 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3060 (NVIDIA; 32.0.15.6636) - 12th Gen Intel(R) Core(TM) i7-12700F (20 Threads) ### Issue description An error is raised when removing/freeing a scene/node that is in MultiplayerSpawner's auto spawn list and client is set as authority. ![Image](https://github.com/user-attachments/assets/dcc82e96-e0cc-42dc-be09-caf3d2a377f5) ### Steps to reproduce 1. Create an ENet mutliplayer connection over localhost using Godot's high level multiplayer peer. 2. Add some nodes/scenes to the tree that are in MultiplayerSpawner's auto spawn list and set the clients as their authorities when applicable. 3. Start erasing the added nodes. 4. You'll see that when erasing some of the nodes that the error is raised. ### Minimal reproduction project (MRP) [multiplayer-spawner-bug.zip](https://github.com/user-attachments/files/18482351/multiplayer-spawner-bug.zip)
bug,topic:multiplayer
low
Critical
2,800,259,609
flutter
[go_router_builder] Nested TypedStatefulShellRoute is not generating parameters
### Steps to reproduce 1. Using go_router_builder: ^2.7.3 2. Run build_runner to generate routes 3. Start compiling ### Expected results In the generated file it should have generated this: ```dart extension $HomeStatefulShellRouteCExtension on HomeStatefulShellRouteC { static HomeStatefulShellRouteC _fromState(GoRouterState state) => HomeStatefulShellRouteC(id: state.pathParameters['id']!); } ``` ### Actual results ```dart extension $HomeStatefulShellRouteCExtension on HomeStatefulShellRouteC { static HomeStatefulShellRouteC _fromState(GoRouterState state) => HomeStatefulShellRouteC(); } ``` ### Code sample <details open><summary>Code sample</summary> ```dart // Copyright 2013 The Flutter Authors. All rights reserved. // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. // ignore_for_file: public_member_api_docs, unreachable_from_main import 'package:collection/collection.dart'; import 'package:flutter/material.dart'; import 'package:go_router/go_router.dart'; part 'main.g.dart'; void main() => runApp(App()); class App extends StatelessWidget { App({super.key}); @override Widget build(BuildContext context) => MaterialApp.router( routerConfig: _router, ); final GoRouter _router = GoRouter( routes: $appRoutes, initialLocation: '/home/a', ); } @TypedShellRoute<HomeShellRoute>( routes: [ TypedGoRoute<HomeRouteA>(path: '/home/a'), TypedGoRoute<HomeRouteB>(path: '/home/b'), TypedGoRoute<HomeRouteC>( path: '/home/:id', routes: [ TypedStatefulShellRoute<HomeStatefulShellRouteC>( branches: <TypedStatefulShellBranch<StatefulShellBranchData>>[ TypedStatefulShellBranch<BranchAData>( routes: <TypedRoute<RouteData>>[ TypedGoRoute<DetailsARouteData>(path: 'detailsA'), ], ), TypedStatefulShellBranch<BranchBData>( routes: <TypedRoute<RouteData>>[ TypedGoRoute<DetailsBRouteData>(path: 'detailsB'), ], ), ], ) ], ) ], ) class HomeShellRoute extends ShellRouteData { @override Widget builder(BuildContext context, GoRouterState state, Widget navigator) { return navigator; } } class HomeStatefulShellRouteC extends StatefulShellRouteData { const HomeStatefulShellRouteC({required this.id}); final String id; @override Widget builder( BuildContext context, GoRouterState state, StatefulNavigationShell navigationShell, ) { return ScaffoldWithNavBar(navigationShell: navigationShell, id: id); } } class BranchAData extends StatefulShellBranchData { const BranchAData(); } class BranchBData extends StatefulShellBranchData { const BranchBData(); } class HomeRouteA extends GoRouteData { @override Widget build(BuildContext context, GoRouterState state) { return HomeScreen(label: 'Home A'); } } class HomeRouteB extends GoRouteData { @override Widget build(BuildContext context, GoRouterState state) { return HomeScreen(label: 'Home B'); } } class HomeRouteC extends GoRouteData { const HomeRouteC({required this.id}); final String id; @override Widget build(BuildContext context, GoRouterState state) { return SizedBox(); } } class DetailsARouteData extends GoRouteData { const DetailsARouteData({required this.id}); final String id; @override Widget build(BuildContext context, GoRouterState state) { return const DetailsScreen(label: 'A'); } } class DetailsBRouteData extends GoRouteData { const DetailsBRouteData({required this.id}); final String id; @override Widget build(BuildContext context, GoRouterState state) { return const DetailsScreen(label: 'B'); } } class HomeScreen extends StatelessWidget { const HomeScreen({required this.label, super.key}); final String label; @override Widget build(BuildContext context) => Scaffold( appBar: AppBar(title: Text(label)), body: Center( child: ElevatedButton( onPressed: () => context.push('/home/1/detailsA'), child: Text('Go to ID page')), ), ); } /// Builds the "shell" for the app by building a Scaffold with a /// BottomNavigationBar, where [child] is placed in the body of the Scaffold. class ScaffoldWithNavBar extends StatelessWidget { /// Constructs an [ScaffoldWithNavBar]. const ScaffoldWithNavBar({ required this.navigationShell, required this.id, Key? key, }) : super(key: key ?? const ValueKey<String>('ScaffoldWithNavBar')); /// The navigation shell and container for the branch Navigators. final StatefulNavigationShell navigationShell; /// Id final String id; @override Widget build(BuildContext context) { return Scaffold( body: navigationShell, bottomNavigationBar: BottomNavigationBar( // Here, the items of BottomNavigationBar are hard coded. In a real // world scenario, the items would most likely be generated from the // branches of the shell route, which can be fetched using // `navigationShell.route.branches`. items: const <BottomNavigationBarItem>[ BottomNavigationBarItem(icon: Icon(Icons.home), label: 'Section A'), BottomNavigationBarItem(icon: Icon(Icons.work), label: 'Section B'), ], currentIndex: navigationShell.currentIndex, onTap: (int index) => _onTap(context, index), ), ); } /// Navigate to the current location of the branch at the provided index when /// tapping an item in the BottomNavigationBar. void _onTap(BuildContext context, int index) { // When navigating to a new branch, it's recommended to use the goBranch // method, as doing so makes sure the last navigation state of the // Navigator for the branch is restored. navigationShell.goBranch( index, // A common pattern when using bottom navigation bars is to support // navigating to the initial location when tapping the item that is // already active. This example demonstrates how to support this behavior, // using the initialLocation parameter of goBranch. initialLocation: index == navigationShell.currentIndex, ); } } /// Custom branch Navigator container that provides animated transitions /// when switching branches. class AnimatedBranchContainer extends StatelessWidget { /// Creates a AnimatedBranchContainer const AnimatedBranchContainer( {super.key, required this.currentIndex, required this.children}); /// The index (in [children]) of the branch Navigator to display. final int currentIndex; /// The children (branch Navigators) to display in this container. final List<Widget> children; @override Widget build(BuildContext context) { return Stack( children: children.mapIndexed( (int index, Widget navigator) { return AnimatedScale( scale: index == currentIndex ? 1 : 1.5, duration: const Duration(milliseconds: 400), child: AnimatedOpacity( opacity: index == currentIndex ? 1 : 0, duration: const Duration(milliseconds: 400), child: _branchNavigatorWrapper(index, navigator), ), ); }, ).toList()); } Widget _branchNavigatorWrapper(int index, Widget navigator) => IgnorePointer( ignoring: index != currentIndex, child: TickerMode( enabled: index == currentIndex, child: navigator, ), ); } /// The details screen for either the A or B screen. class DetailsScreen extends StatefulWidget { /// Constructs a [DetailsScreen]. const DetailsScreen({ required this.label, this.param, this.extra, super.key, }); /// The label to display in the center of the screen. final String label; /// Optional param final String? param; /// Optional extra object final Object? extra; @override State<StatefulWidget> createState() => DetailsScreenState(); } /// The state for DetailsScreen class DetailsScreenState extends State<DetailsScreen> { int _counter = 0; @override Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: Text('Details Screen - ${widget.label}'), ), body: _build(context), ); } Widget _build(BuildContext context) { return Center( child: Column( mainAxisSize: MainAxisSize.min, children: <Widget>[ Text('Details for ${widget.label} - Counter: $_counter', style: Theme.of(context).textTheme.titleLarge), const Padding(padding: EdgeInsets.all(4)), TextButton( onPressed: () { setState(() { _counter++; }); }, child: const Text('Increment counter'), ), const Padding(padding: EdgeInsets.all(8)), if (widget.param != null) Text('Parameter: ${widget.param!}', style: Theme.of(context).textTheme.titleMedium), const Padding(padding: EdgeInsets.all(8)), if (widget.extra != null) Text('Extra: ${widget.extra!}', style: Theme.of(context).textTheme.titleMedium), ], ), ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> </details> ### Logs <details open><summary>Logs</summary> ```console lib/app/router/router_builder.g.dart:321:46: Error: Required named parameter 'id' must be provided. const HomeStatefulShellRouteC(); ^ lib/app/router/router_builder.dart:183:3: Context: Found this candidate, but the arguments don't match. HomeStatefulShellRouteC({required this.id}); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console Doctor summary (to see all details, run flutter doctor -v): [โœ“] Flutter (Channel stable, 3.27.2, on macOS 15.2 24C101 darwin-arm64, locale en-US) [โœ“] Android toolchain - develop for Android devices (Android SDK version 34.0.0) [โœ“] Xcode - develop for iOS and macOS (Xcode 16.2) [โœ“] Chrome - develop for the web [โœ“] Android Studio (version 2024.2) [โœ“] VS Code (version 1.96.3) [โœ“] Connected device (5 available) [โœ“] Network resources โ€ข No issues found! ``` </details>
package,has reproducible steps,p: go_router_builder,team-go_router,found in release: 3.27,found in release: 3.28
low
Critical
2,800,261,632
rust
Tracking issue for release notes of #134690: CI: Add LTO support to clang in dist-x86_64-linux
This issue tracks the release notes text for #134690. ### Steps - [ ] Proposed text is drafted by PR author (or team) making the noteworthy change. - [ ] Issue is nominated for release team review of clarity for wider audience. - [ ] Release team includes text in release notes/blog posts. ### Release notes text The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing). ````markdown # Internal Changes - [Build x86_64-unknown-linux-gnu with LTO for C/C++ code (e.g., jemalloc)](https://github.com/rust-lang/rust/pull/134690) ```` > [!TIP] > Use the [previous releases](https://doc.rust-lang.org/nightly/releases.html) categories to help choose which one(s) to use. > The category will be de-duplicated with all the other ones by the release team. > > *More than one section can be included if needed.* ### Release blog section If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section. *Otherwise leave it empty.* ````markdown ```` cc @clubby789, @Mark-Simulacrum -- origin issue/PR authors and assignees for starting to draft text
A-testsuite,relnotes,T-bootstrap,T-infra,needs-triage,relnotes-tracking-issue
low
Minor
2,800,273,295
rust
Tracking issue for release notes of #133801: Promote powerpc64le-unknown-linux-musl to tier 2 with host tools
This issue tracks the release notes text for #133801. ### Steps - [ ] Proposed text is drafted by PR author (or team) making the noteworthy change. - [ ] Issue is nominated for release team review of clarity for wider audience. - [ ] Release team includes text in release notes/blog posts. ### Release notes text The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing). ````markdown # Platform Support - [Promote `powerpc64le-unknown-linux-musl` to tier 2 with host tools](https://github.com/rust-lang/rust/pull/133801) ```` > [!TIP] > Use the [previous releases](https://doc.rust-lang.org/nightly/releases.html) categories to help choose which one(s) to use. > The category will be de-duplicated with all the other ones by the release team. > > *More than one section can be included if needed.* ### Release blog section If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section. *Otherwise leave it empty.* ````markdown ```` cc @Gelbpunkt, @Mark-Simulacrum -- origin issue/PR authors and assignees for starting to draft text
A-testsuite,T-compiler,relnotes,T-bootstrap,T-infra,relnotes-tracking-issue
low
Minor
2,800,277,454
svelte
False positive on a11y_label_has_associated_control when spreading object
### Describe the bug When spreading an object with a `for` attribute on a label, Svelte puts a warning `a11y_label_has_associated_control` ### Reproduction https://svelte.dev/playground/5efcafb51a0043968060da3514f41a74?version=5.19.0 ### Logs ```shell ``` ### System Info ```shell System: OS: Linux 6.6 cpe:/o:nixos:nixos:24.11 24.11 (Vicuna) CPU: (32) x64 AMD Ryzen 9 7950X3D 16-Core Processor Memory: 53.46 GB / 62.01 GB Container: Yes Shell: 3.7.1 - /run/current-system/sw/bin/fish Binaries: Node: 20.18.1 - /run/current-system/sw/bin/node npm: 10.8.2 - /run/current-system/sw/bin/npm pnpm: 9.15.3 - /run/current-system/sw/bin/pnpm ``` ### Severity annoyance
a11y
low
Critical
2,800,282,345
godot
[4.4] Godot 4.4 Beta 1 uses ~32% more VRAM when activating viewports compared to 4.3 Stable
### Tested versions - Reproducible in Godot 4.4 Dev 1, Godot 4.4 Beta 1 (haven't tested versions in between) - Not reproducible in Godot 4.3 Stable ### System information Godot v4.4.beta1 - Windows 10 (build 19045) - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated AMD Radeon R9 M200X Series (Advanced Micro Devices, Inc.; 27.20.20913.2000) - Intel(R) Core(TM) i7-4720HQ CPU @ 2.60GHz (8 threads) ### Issue description While testing the [Godot Benchmarks](https://github.com/godotengine/godot-benchmarks) project using Godot 4.4 Beta 1 on some older computer setups, I found that the benchmark would always crash at the "Viewport > Activation > Activate 1024 Viewports" part on a system with only 1 GB of VRAM. When the console is open, the output reads: ``` Running benchmark 1 of 1: viewport/activation/activate_1024_viewports ERROR: Can't allocate memory for image, error: -2. at: (drivers/vulkan/rendering_device_driver_vulkan.cpp:1812) ERROR: Condition "!texture.driver_id" is true. Returning: RID() at: texture_create (servers/rendering/rendering_device.cpp:1020) ERROR: Condition "texture.rd_texture.is_null()" is true. at: texture_2d_initialize (servers/rendering/renderer_rd/storage_rd/texture_storage.cpp:820) ERROR: Attempting to use an uninitialized RID at: (./core/templates/rid_owner.h:259) ``` This same issue occurs on both Windows 10 and Ubuntu 22.04 LTS, and none of the other tests fail, only Activate 1024 Viewports. When converting the benchmark project to 4.3 Stable, the test is able to run successfully. I tried reproducing the issue on a separate computer with 2 GB of VRAM, and while the issue didn't occur, I found in Task Manager that the Activate 1024 Viewports test would use around 0.75 GB of VRAM in 4.3 Stable, but around 1.1 GB in 4.4 Dev 1 and 4.4 Beta 1 (I haven't tested any of the versions in between yet). In the images below, the green line represents the test being run in 4.3 Stable, and the red line represents the same test being run in 4.4 Beta 1. ![Image](https://github.com/user-attachments/assets/b9744ad3-3bf6-41e1-8600-6460ee29b14c) ![Image](https://github.com/user-attachments/assets/09c6bffb-2791-49d2-b341-ca1d1d0b1f61) (I understand that old hardware can't be supported forever, so if this issue is a side effect of a new feature that will benefit most users then that's okay. I just wanted to bring attention to it in case it's not a known or intended change.) ### Steps to reproduce Run the [Godot Benchmarks](https://github.com/godotengine/godot-benchmarks) project in Godot 4.4 Beta 1, select and run only the following tests and note how much VRAM was used: - Activate 1024 Viewports - Activate 256 Viewports - Activate 64 Viewports Then, repeat the same process using Godot 4.3 Stable and compare the VRAM usage to 4.4 Beta 1. ### Minimal reproduction project (MRP) https://github.com/godotengine/godot-benchmarks
bug,topic:core,topic:rendering,regression
low
Critical
2,800,302,791
tensorflow
How to enable compiler flags for avx2 avx512f fma
I've compiled Tensorflow on Debian 12 successfully but when use jupyter I get this message **To enable the following instructions: AVX2 AVX512F FMA, in other operations, rebuild Tensorflow with the appropriate compiler flags.** ``` the compilation is like this: $ python ./configure.py Please specify optimization flags to use during compilation when bazel option "--config=opt" is specified [Default is -Wno-sign-compare]: -Wno-sign-compare -march=native -mavx2 -mavx512f -mfma -msse4.1 -msse4.2 $ bazelisk build //tensorflow/tools/pip_package:wheel --repo_env=WHEEL_NAME=tensorflow_cpu --local_ram_resources=2048 --config=monolithic --verbose_failures -c opt --config=opt --copt=-Wno-gnu-offsetof-extensions --copt=-march=native --copt=-mavx --copt=-mavx2 --copt=-mfma --copt=-msse4.1 --copt=-msse4.2 ``` How to correctly compile tensorflow with AVX2 AVX512F FMA flags
stat:awaiting response
low
Critical
2,800,324,910
rust
Tracking issue for release notes of #134633: Stabilize `get_many_mut` as `get_disjoint_mut`
This issue tracks the release notes text for #134633. ### Steps - [ ] Proposed text is drafted by PR author (or team) making the noteworthy change. - [ ] Issue is nominated for release team review of clarity for wider audience. - [ ] Release team includes text in release notes/blog posts. ### Release notes text The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing). ````markdown # Category (e.g. Language, Compiler, Libraries, Compatibility notes, ...) - [Stabilize `get_many_mut` as `get_disjoint_mut`](https://github.com/rust-lang/rust/pull/134633) ```` > [!TIP] > Use the [previous releases](https://doc.rust-lang.org/nightly/releases.html) categories to help choose which one(s) to use. > The category will be de-duplicated with all the other ones by the release team. > > *More than one section can be included if needed.* ### Release blog section If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section. *Otherwise leave it empty.* ````markdown ```` cc @GrigorenkoPV, @joshtriplett -- origin issue/PR authors and assignees for starting to draft text
relnotes,T-libs,needs-triage,relnotes-tracking-issue
low
Minor
2,800,336,535
node
fs: can't require non-ASCII file paths in Shift-JIS filesystem
### Version v22.13.0, v23.6.0 ### Platform ```text Microsoft Windows NT 10.0.26100.0 x64 ``` ### Subsystem fs ### What steps will reproduce the bug? 1. Use Japanese Windows with `Shift-JIS` (aka `CP932`) 2. Load a non-ASCII file path with `require` such as `ใƒ˜ใƒซใƒ—.js` ### How often does it reproduce? Is there a required condition? Always reproduceable under a Shift-JIS filesystem. ### What is the expected behavior? Why is that the expected behavior? The file is loaded correctly. ### What do you see instead? "Process exited with code 3221225477" ### Additional information - May be similar to https://github.com/nodejs/node/issues/56049, although it's an issue for a different method and doesn't mention the Shift-JIS requirement. - The issue was found in https://github.com/sapphiredev/pieces/issues/460 for reference, which used `require` in the user's case, the aforementioned issue also links a [reproducible example repository](https://github.com/c7e715d1b04b17683718fb1e8944cc28/my-sapphire-bot), although not a minimal one for testing purposes, the issue has been reproduced with a simple `require` in REPL as well. - The same code works fine: - If the filesystem isn't Shift-JIS (UNIX, non-Japanese Windows). - ASCII names are used instead. - When run with an alternative runtime such as Deno.
fs,windows
low
Critical
2,800,343,468
godot
Editor crashes when trying to edit a dock-made signal connection to a deleted node
### Tested versions NOT Reproducible in: - v4.0.stable.official [92bee43ad] - v4.2.stable.official [46dc27791] - v4.2.2.stable.official [15073afe3] - v4.3.dev2.official [352434668] - v4.3.dev3.official [36e943b6b] Reproducible in: - v4.3.dev4.official [df78c0636] - v4.3.beta1.official [a4f2ea91a] - v4.3.stable.official [77dcf97d8] - v4.4.beta1.official [d33da79d3] ### System information Windows 11 - Godot v4.3.stable - Vulkan (Forward+) ### Issue description When deleting a Node from the scene tree, the Editor does not delete connections made to that Node that were made in the Node Signal Dock. After trying to edit such a "null" connection in the Node Signal Dock, the Editor crashes. I would expect it not to crash, but instead delete any GUI-made connections to a Node that is being deleted from the Scene. Upon clicking "Edit..." on a "null" connection, the following is the console output from Godot: ``` <...> ERROR: Cannot get path of node as it is not in a scene tree. at: (scene/main/node.cpp:2257) ERROR: Parameter "common_parent" is null. at: get_path_to (scene/main/node.cpp:2192) ERROR: Node not found: "" (relative to "/root/@EditorNode@16886/@Panel@13/@VBoxContainer@14/DockHSplitLeftL/DockHSp. at: (scene/main/node.cpp:1792) ================================================================ CrashHandlerException: Program crashed with signal 11 Engine version: Godot Engine v4.3.stable.official (77dcf97d82cbfe4e4615475fa52ca03da645dbd8) Dumping the backtrace. Please include this when reporting the bug to the project developer. [1] error(-1): no debug info in PE/COFF executable [2] error(-1): no debug info in PE/COFF executable [3] error(-1): no debug info in PE/COFF executable [4] error(-1): no debug info in PE/COFF executable [5] error(-1): no debug info in PE/COFF executable [6] error(-1): no debug info in PE/COFF executable [7] error(-1): no debug info in PE/COFF executable [8] error(-1): no debug info in PE/COFF executable [9] error(-1): no debug info in PE/COFF executable [10] error(-1): no debug info in PE/COFF executable [11] error(-1): no debug info in PE/COFF executable [12] error(-1): no debug info in PE/COFF executable [13] error(-1): no debug info in PE/COFF executable [14] error(-1): no debug info in PE/COFF executable [15] error(-1): no debug info in PE/COFF executable [16] error(-1): no debug info in PE/COFF executable [17] error(-1): no debug info in PE/COFF executable [18] error(-1): no debug info in PE/COFF executable [19] error(-1): no debug info in PE/COFF executable [20] error(-1): no debug info in PE/COFF executable [21] error(-1): no debug info in PE/COFF executable [22] error(-1): no debug info in PE/COFF executable [23] error(-1): no debug info in PE/COFF executable [24] error(-1): no debug info in PE/COFF executable [25] error(-1): no debug info in PE/COFF executable [26] error(-1): no debug info in PE/COFF executable [27] error(-1): no debug info in PE/COFF executable [28] error(-1): no debug info in PE/COFF executable -- END OF BACKTRACE -- ================================================================ ``` ### Steps to reproduce 1. Create a new Project 2. Create a scene with a root Node called `NodeX` 3. Attach a new script to `NodeX`, define a signal `my_signal` in it 4. Create a child of `NodeX`, a Node called `NodeY` 5. Attach a new script to `NodeY` 6. Select `NodeX` in the Scene Dock 7 .Open the Node Dock > Signals 8. Connect the signal from `NodeX` to `NodeY` > note: the saved project file is in this state 9. Delete `NodeY` in the Scene Dock 10. Select `NodeX` in the Scene Dock 11. Open the Node Dock > Signals 12. Under `my_signal()`, right-click the "connection", and select "Edit..." 13. A new empty window opens 14. Godot Editor crashes ### Minimal reproduction project (MRP) [project.zip](https://github.com/user-attachments/files/18482710/project.zip) Made in v4.3.dev4.official
bug,topic:editor,crash
low
Critical
2,800,353,958
rust
Basic wrapping arithmetic on pointers is pessimized compared to integers
Consider these two very simple functions: ```rust pub fn foo_int(x: usize, y: usize, z: isize) -> (usize, usize) { let mask = (z.wrapping_sub(15) >> (isize::BITS - 1)) as usize; (x.wrapping_sub(mask), y ^ mask) } pub fn foo_ptr(x: *const u8, y: usize, z: isize) -> (*const u8, usize) { let mask = (z.wrapping_sub(15) >> (isize::BITS - 1)) as usize; (x.wrapping_sub(mask), y ^ mask) } ``` I would expect these to generate identical codegen. Here we are treating a pointer as an ordinary number, with `wrapping_sub`. But we actually see a pessimization in the codegen for the pointer version: ```asm foo_int: mov rax, rdi add rdx, -15 sar rdx, 63 sub rax, rdx xor rdx, rsi ret foo_ptr: add rdx, -15 mov rax, rdx shr rax, 63 sar rdx, 63 add rax, rdi xor rdx, rsi ret ``` I think this has something to do with provenance. Consider the following two modified examples: ```rust pub fn foo_expose_ptr(x: *const u8, y: usize, z: isize) -> (*const u8, usize) { let mask = (z.wrapping_sub(15) >> (isize::BITS - 1)) as usize; let u = x.expose_provenance().wrapping_sub(mask); (std::ptr::with_exposed_provenance(u), y ^ mask) } pub fn foo_map_addr_ptr(x: *const u8, y: usize, z: isize) -> (*const u8, usize) { let mask = (z.wrapping_sub(15) >> (isize::BITS - 1)) as usize; (x.map_addr(|a| a.wrapping_sub(mask)), y ^ mask) } ``` `foo_expose_ptr` is efficient like `foo_int`, but `foo_map_addr_ptr` is pessimized like `foo_ptr`. I think this is a bug, provenance should not pessimize basic wrapping integer arithmetic, even if it occurs on pointers.
A-LLVM,I-slow,T-compiler,C-optimization
low
Critical
2,800,360,670
flutter
[Impller] The laptop freezes when running the project on the emulator. After deactivating Impller, it returned to work normally without any problems.
### Steps to reproduce [Impller] The laptop freezes when running the project on the emulator. After deactivating Impller, it returned to work normally without any problems. ### Expected results [Impller] The laptop freezes when running the project on the emulator. After deactivating Impller, it returned to work normally without any problems. ### Actual results [Impller] The laptop freezes when running the project on the emulator. After deactivating Impller, it returned to work normally without any problems. ### Code sample <details open><summary>Code sample</summary> ```dart [Paste your code here] ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> [Upload media here] </details> ### Logs <details open><summary>Logs</summary> ```console [Paste your logs here] ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [Paste your output here] ``` </details>
waiting for customer response,in triage
low
Minor
2,800,363,155
godot
SpotLight3D shadow has significant peter-panning with default settings (4.4-dev7 and 4.4-beta1)
### Tested versions Reproducible in: 4.4-dev7 and 4.4-beta1 Not reproducible in: 4.4-dev6 and before ### System information Godot v4.4.dev7 - Windows 11 (build 22631) - Single-window, 2 monitors - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4070 (NVIDIA; 32.0.15.6603) - 13th Gen Intel(R) Core(TM) i7-13700K (24 threads) ### Issue description Shadow casting SpotLight3D has noticeable peter-panning effect with default bias value. Example below: ![Image](https://github.com/user-attachments/assets/501f57ff-6c38-477d-aa8e-0e2e695ab5ba) ### Steps to reproduce Create a new 3D scene Add floor into the scene and add mesh on the floor Add SpotLight3D and enable shadows Point the spotlight towards mesh and observe shadow it casts ### Minimal reproduction project (MRP) N/A
bug,topic:rendering,confirmed,regression,topic:3d
low
Major
2,800,376,114
rust
Option to pass flags to `rustc` while bootstrapping using a file
When bootstrapping `rustc` invocations can be rather large. For example this is an invocation I wanted to debug today (~10.9 KiB): ```text LD_LIBRARY_PATH="/loc/waffle/rust-h/build/x86_64-unknown-linux-gnu/stage1/lib:/loc/waffle/rust-h/build/x86_64-unknown-linux-gnu/stage1-std/release/deps" RUST_BACKTRACE="1" "/loc/waffle/rust-h/build/x86_64-unknown-linux-gnu/stage1/bin/rustc" "--crate-name" "compiler_builtins" "--edition=2021" "/usr/sec/waffle/.cargo/registry/src/index.crates.io-6f17d22bba15001f/compiler_builtins-0.1.138/src/[lib.rs](http://lib.rs/)" "--error-format=json" "--json=diagnostic-rendered-ansi,artifacts,future-incompat" "--diagnostic-width=204" "--crate-type" "lib" "--emit=dep-info,metadata,link" "-C" "opt-level=3" "-C" "embed-bitcode=no" "-C" "codegen-units=10000" "-C" "debuginfo=line-tables-only" "--cfg" "feature=\"compiler-builtins\"" "--cfg" "feature=\"core\"" "--cfg" "feature=\"default\"" "--cfg" "feature=\"mem\"" "--cfg" "feature=\"rustc-dep-of-std\"" "--check-cfg" "cfg(docsrs)" "--check-cfg" "cfg(feature, values(\"c\", \"cc\", \"compiler-builtins\", \"core\", \"default\", \"mangled-names\", \"mem\", \"no-asm\", \"no-f16-f128\", \"public-test-deps\", \"rustc-dep-of-std\"))" "-C" "metadata=8b1a123d4d7caf72" "-C" "extra-filename=-8b1a123d4d7caf72" "--out-dir" "/loc/waffle/rust-h/build/x86_64-unknown-linux-gnu/stage1-std/riscv32i-unknown-none-tasking/release/deps" "--target" "riscv32i-unknown-none-tasking" "-C" "linker=cc" "-L" "dependency=/loc/waffle/rust-h/build/x86_64-unknown-linux-gnu/stage1-std/riscv32i-unknown-none-tasking/release/deps" "-L" "dependency=/loc/waffle/rust-h/build/x86_64-unknown-linux-gnu/stage1-std/release/deps" "--extern" "core=/loc/waffle/rust-h/build/x86_64-unknown-linux-gnu/stage1-std/riscv32i-unknown-none-tasking/release/deps/librustc_std_workspace_core-2e8331c85d5501e5.rmeta" "--cap-lints" "warn" "-Csymbol-mangling-version=legacy" "--check-cfg=cfg(feature,values(any()))" "-Zunstable-options" "--check-cfg=cfg(bootstrap)" "-Zmacro-backtrace" "-Csplit-debuginfo=off" "-Cforce-frame-pointers=true" "-Cprefer-dynamic" "-Zinline-mir" "-Zinline-mir-preserve-debug" "-Clink-args=-Wl,-z,origin" "-Clink-args=-Wl,-rpath,$ORIGIN/../lib" "-Cembed-bitcode=yes" "-Clto=off" "-Cforce-unwind-tables=yes" "-Cforce-frame-pointers=yes" "-Zcrate-attr=doc(html_root_url=\[https://doc.rust-lang.org/nightly/\](https://doc.rust-lang.org/nightly/))" "-Z" "binary-dep-depinfo" "--cfg" "f16_enabled" "--cfg" "f128_enabled" "--cfg" "feature=\"unstable\"" "--cfg" "feature=\"force-soft-floats\"" "--cfg" "feature=\"mem\"" "--check-cfg" "cfg(__ashldi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__ashlsi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__ashrdi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__ashrsi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__bswapsi2, values(\"optimized-c\"))" "--check-cfg" "cfg(__bswapdi2, values(\"optimized-c\"))" "--check-cfg" "cfg(__bswapti2, values(\"optimized-c\"))" "--check-cfg" "cfg(__divdi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__divsi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__divmoddi4, values(\"optimized-c\"))" "--check-cfg" "cfg(__divmodsi4, values(\"optimized-c\"))" "--check-cfg" "cfg(__divmodsi4, values(\"optimized-c\"))" "--check-cfg" "cfg(__divmodti4, values(\"optimized-c\"))" "--check-cfg" "cfg(__lshrdi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__lshrsi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__moddi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__modsi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__muldi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__udivdi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__udivmoddi4, values(\"optimized-c\"))" "--check-cfg" "cfg(__udivmodsi4, values(\"optimized-c\"))" "--check-cfg" "cfg(__udivsi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__umoddi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__umodsi3, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas1_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas1_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas1_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas1_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas2_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas2_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas2_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas2_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas4_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas4_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas4_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas4_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas8_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas8_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas8_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas8_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas16_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas16_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas16_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_cas16_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd1_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd1_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd1_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd1_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd2_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd2_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd2_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd2_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd4_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd4_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd4_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd4_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd8_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd8_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd8_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldadd8_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr1_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr1_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr1_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr1_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr2_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr2_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr2_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr2_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr4_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr4_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr4_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr4_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr8_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr8_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr8_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldclr8_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor1_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor1_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor1_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor1_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor2_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor2_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor2_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor2_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor4_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor4_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor4_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor4_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor8_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor8_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor8_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldeor8_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset1_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset1_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset1_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset1_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset2_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset2_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset2_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset2_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset4_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset4_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset4_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset4_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset8_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset8_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset8_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_ldset8_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp1_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp1_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp1_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp1_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp2_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp2_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp2_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp2_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp4_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp4_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp4_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp4_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp8_relax, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp8_acq, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp8_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(__aarch64_swp8_acq_rel, values(\"optimized-c\"))" "--check-cfg" "cfg(target_feature, values(\"vis3\"))" "--check-cfg" "cfg(feature, values(\"checked\"))" "--check-cfg" "cfg(assert_no_panic)" "--check-cfg" "cfg(f16_enabled)" "--check-cfg" "cfg(f128_enabled)" "--check-cfg" "cfg(feature, values(\"unstable\", \"force-soft-floats\"))" "--check-cfg" "cfg(feature, values(\"mem-unaligned\"))" "--check-cfg" "cfg(thumb)" "--check-cfg" "cfg(thumb_1)" "--check-cfg" "cfg(kernel_user_helpers)" "-Wrust_2018_idioms" "-Wunused_lifetimes" "--sysroot" "/loc/waffle/rust-h/build/x86_64-unknown-linux-gnu/stage1" "-Z" "force-unstable-if-unmarked" ``` This causes shells to melt (good luck editing a command when it doesn't render), which is very annoying when you want to change something about the command, or even simply run it through `gdb` (NB: you need to insert `gdb --args` in between the env vars and the rest of the command, which is mostly impossible when the command doesn't render!!). One of the things I'd wish for is a way for `cargo` to pass `check-cfg` without repeating `--check-cfg` ~139 times. Something like `--check-cfg "all(cfg(uwu), cfg(owo))"` (or `"cfg(uwu); cfg(owo)"`) maybe? The second thing is for bootstrap to have an option (cli, config) to pass options to the `rustc` binary via a file. Note that `rustc` supports reading command line arguments from a file with `@file`: ```shell : ~; echo '--version' > ./args.txt : ~; rustc @./args.txt rustc 1.86.0-nightly (48a426eca 2025-01-12) ``` Bootstrap could create a file in `/tmp` or in `./build/..` with the arguments and pass that to `rustc`. That would make it much easier to re-run commands run by bootstrap, which is sometimes useful when debugging. cc @jieyouxu
C-enhancement,T-bootstrap,F-check-cfg
low
Critical
2,800,385,353
rust
minor editing issue in atomic.rs makes it harder to understand
### Location Here is a minor editing change to the documentation of `fence()` that makes the example easier to understand. Just read the example with and without this change to understand why this is better: ``` diff --git a/library/core/src/sync/atomic.rs b/library/core/src/sync/atomic.rs index fda26a67299..8edf0d9e48d 100644 --- a/library/core/src/sync/atomic.rs +++ b/library/core/src/sync/atomic.rs @@ -3608,24 +3608,24 @@ unsafe fn atomic_umin<T: Copy>(dst: *mut T, val: T, order: Ordering) -> T { /// /// A fence 'A' which has (at least) [`Release`] ordering semantics, synchronizes /// with a fence 'B' with (at least) [`Acquire`] semantics, if and only if there -/// exist operations X and Y, both operating on some atomic object 'M' such +/// exist operations X and Y, both operating on some atomic object 'm' such /// that A is sequenced before X, Y is sequenced before B and Y observes -/// the change to M. This provides a happens-before dependence between A and B. +/// the change to m. This provides a happens-before dependence between A and B. /// /// ```text /// Thread 1 Thread 2 /// /// fence(Release); A -------------- -/// x.store(3, Relaxed); X --------- | +/// m.store(3, Relaxed); X --------- | /// | | /// | | -/// -------------> Y if x.load(Relaxed) == 3 { +/// -------------> Y if m.load(Relaxed) == 3 { /// |-------> B fence(Acquire); /// ... /// } /// ``` /// -/// Note that in the example above, it is crucial that the accesses to `x` are atomic. Fences cannot +/// Note that in the example above, it is crucial that the accesses to `m` are atomic. Fences cannot /// be used to establish synchronization among non-atomic accesses in different threads. However, /// thanks to the happens-before relationship between A and B, any non-atomic accesses that /// happen-before A are now also properly synchronized with any non-atomic accesses that ``` ### Summary Small improvement to docs to clarify example.
A-docs,T-libs
low
Minor
2,800,404,195
vscode
SCM Graph - Add support for graph for remote repositories
Type: <b>Bug</b> "connect to" -> "open remote repository" -> "Open repository from GitHub" -> "repo-name" the source control graph is empty and does not show commits VS Code version: Code 1.96.3 (91fbdddc47bc9c09064bf7acf133d22631cbf083, 2025-01-09T18:14:09.060Z) OS version: Windows_NT x64 10.0.26100 Modes: <details> <summary>System Info</summary> |Item|Value| |---|---| |CPUs|11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz (16 x 2304)| |GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off| |Load (avg)|undefined| |Memory (System)|31.73GB (5.77GB free)| |Process Argv|--crash-reporter-id 6d6f1ec5-eef8-4c70-aa02-95843cfea593| |Screen Reader|no| |VM|0%| </details><details><summary>Extensions (13)</summary> Extension|Author (truncated)|Version ---|---|--- dart-code|Dar|3.102.0 flutter|Dar|3.102.0 remotehub|Git|0.64.0 vscode-pull-request-github|Git|0.102.0 vscode-autohotkey-plus-plus|mar|6.4.3 vscode-http-client|mkl|0.34.0 vscode-apache|mrm|1.2.0 debugpy|ms-|2024.14.0 python|ms-|2024.22.2 vscode-pylance|ms-|2024.12.1 azure-repos|ms-|0.40.0 remote-repositories|ms-|0.42.0 vscode-gradle|vsc|3.16.4 </details><details> <summary>A/B Experiments</summary> ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805cf:30301675 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 vscrpc:30673769 962ge761:30959799 pythonnoceb:30805159 pythonmypyd1:30879173 h48ei257:31000450 pythontbext0:30879054 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 dsvsc021:30996838 dvdeprecation:31068756 dwnewjupyter:31046869 2f103344:31071589 nativerepl2:31139839 pythonrstrctxt:31112756 nativeloc2:31192216 cf971741:31144450 iacca1:31171482 notype1cf:31157160 5fd0e150:31155592 dwcopilot:31170013 stablechunks:31184530 2j25a237:31215806 6074i472:31201624 dwoutputs:31217127 9064b325:31222308 ``` </details> <!-- generated by issue reporter -->
feature-request,github
low
Critical
2,800,411,089
langchain
deepseek-r1 not working with Ollama format correctly
### Checked other resources - [x] I added a very descriptive title to this issue. - [x] I searched the LangChain documentation with the integrated search. - [x] I used the GitHub search to find a similar question and didn't find it. - [x] I am sure that this is a bug in LangChain rather than my code. - [x] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package). ### Example Code No Code needed ### Error Message and Stack Trace (if applicable) There is no exception ### Description I was trying deepseek-r1:14b today with ollama format:Json schema looks like the integration need to be update as this kind of model when you ask question it start with thinking section before it start answering so I was getting wrong output mainly the output was part of the thinking process same code works with Phi4 and llamaa 3.2 ### System Info I'm using the js version of langchain
๐Ÿค–:bug
low
Critical
2,800,431,461
godot
Memory starvation while (re)importing assets
### Tested versions - Reproducible in Godot 4.3 stable and 4.4 beta 01 ### System information Godot v4.4.beta1 - macOS Sequoia (15.2.0) - Multi-window, 1 monitor - Metal (Mobile) - integrated Apple M1 Pro (Apple7) - Apple M1 Pro (8 threads) ### Issue description I have a few asset packs on my Godot project, which is fine. Re-scanning is not really a problem as it is usually pretty fast. But after deleting all *.import files on my asset folder (I was trying to force a re-import) I can't open my project anymore, as it keeps reimporting assets until there is no RAM available anymore. I wonder if this is expected behavior of if there might be a memory leak somewhere. ![Image](https://github.com/user-attachments/assets/a7b2a2bc-a36c-4229-b323-8296b585b3cd) ![Image](https://github.com/user-attachments/assets/ee650261-c37a-49d0-83b2-2b8f94989125) My assets are mostly .fbx files and a few .jpg for textures, as these are paid assets I can't share an MRP unfortunately. ### Steps to reproduce - Have a bunch of files on a 'assets' folder - Open the project - Bam! ### Minimal reproduction project (MRP) I've been using a few of the packs from this [bundle](https://justcreate3d.itch.io/low-poly-mega-bundle). As they're paid, I can't share them unfortunately.
bug,topic:import
low
Minor
2,800,442,395
flutter
SegmentedButton keyboard navigation incorrectly moves focus on click with multi selection enabled.
### Steps to reproduce 1. Navigate to the first SegmentedButton doc example: https://api.flutter.dev/flutter/material/SegmentedButton-class.html. 2. Focus one of "Multiple choice" buttons. 3. Click to interact with the button. 4. Observe that focus is moved to another button, instead of staying on the interacted button. ### Expected results The focus should remain on the current button when clicked. ### Actual results The focus moves when button is clicked. ### Code sample See SegmentedButton doc example: https://api.flutter.dev/flutter/material/SegmentedButton-class.html. ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> https://github.com/user-attachments/assets/ca1a8629-a30c-4fde-b89f-774558a5d8a3 </details> ### Logs _No response_ ### Flutter Doctor output <details open><summary>Doctor output</summary> N/A </details>
a: text input,framework,f: material design,f: focus,has reproducible steps,P2,team-design,triaged-design,found in release: 3.27,found in release: 3.28
low
Minor
2,800,445,753
PowerToys
Atalho para o powertoys run nรฃo estรก funcionando
### Microsoft PowerToys version 0.87.1 ### Installation method Microsoft Store ### Running as admin Yes ### Area(s) with issue? PowerToys Run ### Steps to reproduce Ao pressionar o atalho para a funรงรฃo do powertoys run, nada ocorre, depois da รบltima atualizaรงรฃo nenhum problema foi identificado, contudo ao reiniciar o notebook, esta funรงรฃo para de ser ativada, preciso desinstalar e reinstalar novamente para poder voltar a funcionar, porรฉm ao reiniciar o dispositivo o erro persiste. When pressing the shortcut for the powertoys run function, nothing happens, after the last update no problem was identified, however when restarting the notebook, this function stops being activated, I need to uninstall and reinstall again to be able to work again, however when restarting the device the error persists. ### โœ”๏ธ Expected Behavior _No response_ ### โŒ Actual Behavior O comportamento esperado era que ao iniciar o micro a funรงรฃo estivesse disponรญvel, mesmo que reiniciasse varias vezes, porรฉm, nรฃo รฉ isso que ocorre. The expected behavior was that when starting the computer the function would be available, even if it restarted several times, however, this is not what happens. ### Other Software _No response_
Issue-Bug,Needs-Triage
low
Critical
2,800,460,550
pytorch
Flaky Dynamo test: TestAutograd.test_gradcheck_nondeterministic
### ๐Ÿ› Describe the bug Reproduce command: ``` PYTORCH_TEST_WITH_DYNAMO=1 python test/test_autograd.py TestAutograd.test_gradcheck_nondeterministic ``` This issue was discovered while I was working on #142830. The core problem is that this unit test produces different results on CI compared to running it locally. The test passes in the main branch, but if I remove the `assertRaisesRegex` assertion (#145205), the test still passes locally but fails on CI. I suspect that even though it currently passes on CI, itโ€™s likely coincidental. After making changes in #142830, this test began failing. However, Iโ€™ve been unable to reproduce the failure locally. There is a similar flaky test marked at #127115. ### Versions main cc @ezyang @albanD @gqchen @pearu @nikitaved @soulitzer @Varal7 @xmfan @chauhang @penguinwu
module: autograd,triaged,module: testing,oncall: pt2
low
Critical
2,800,470,058
pytorch
Not using set_num_threads results in very slow .all()
### ๐Ÿ› Describe the bug ```python import torch import time # print(f'{torch.get_num_threads()}') # default is 256, it isn't important how many we set, but the fact that we set num_threads is critical # torch.set_num_threads(32) x = torch.zeros(13456, 4) # starts at some size of first dim z_out = torch.zeros(1024, 4, dtype=torch.uint8) start = time.time() for _ in range(64): (x == x).all() print(time.time() - start) ``` with code commented: > 6 seconds with code uncommented: <0.1 seconds. I initially thought it is linked to https://github.com/pytorch/pytorch/issues/90760 , but that issue mentions only matmul and cholecky (also, because of that, I was initially searching for those operations), nothing about .all(), but difference observed in this minimal setup is more dramatic. ### Versions ``` Collecting environment information... PyTorch version: 2.3.1+cu121 Is debug build: False CUDA used to build PyTorch: 12.1 ROCM used to build PyTorch: N/A OS: Ubuntu 22.04.5 LTS (x86_64) GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 Clang version: Could not collect CMake version: Could not collect Libc version: glibc-2.35 Python version: 3.11.11 (main, Dec 4 2024, 08:55:07) [GCC 11.4.0] (64-bit runtime) Python platform: Linux-6.5.0-1025-oracle-x86_64-with-glibc2.35 Is CUDA available: True CUDA runtime version: Could not collect CUDA_MODULE_LOADING set to: LAZY GPU models and configuration: GPU 0: NVIDIA A100-SXM4-80GB Nvidia driver version: 535.183.01 cuDNN version: Could not collect HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 48 bits physical, 48 bits virtual Byte Order: Little Endian CPU(s): 256 On-line CPU(s) list: 0-254 Off-line CPU(s) list: 255 Vendor ID: AuthenticAMD Model name: AMD EPYC 7J13 64-Core Processor CPU family: 25 Model: 1 Thread(s) per core: 2 Core(s) per socket: 64 Socket(s): 2 Stepping: 1 Frequency boost: enabled CPU max MHz: 3673.0950 CPU min MHz: 0.0000 BogoMIPS: 4900.16 Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl nonstop_tsc cpuid extd_apicid aperfmperf rapl pni pclmulqdq monitor ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt aes xsave avx f16c rdrand lahf_lm cmp_legacy svm extapic cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw ibs skinit wdt tce topoext perfctr_core perfctr_nb bpext perfctr_llc mwaitx cpb cat_l3 cdp_l3 invpcid_single hw_pstate ssbd mba ibrs ibpb stibp vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local clzero irperf xsaveerptr rdpru wbnoinvd amd_ppin brs arat npt lbrv svm_lock nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold avic v_vmsave_vmload vgif v_spec_ctrl umip pku ospke vaes vpclmulqdq rdpid overflow_recov succor smca fsrm Virtualization: AMD-V L1d cache: 4 MiB (128 instances) L1i cache: 4 MiB (128 instances) L2 cache: 64 MiB (128 instances) L3 cache: 512 MiB (16 instances) NUMA node(s): 8 NUMA node0 CPU(s): 0-15,128-143 NUMA node1 CPU(s): 16-31,144-159 NUMA node2 CPU(s): 32-47,160-175 NUMA node3 CPU(s): 48-63,176-191 NUMA node4 CPU(s): 64-79,192-207 NUMA node5 CPU(s): 80-95,208-223 NUMA node6 CPU(s): 96-111,224-239 NUMA node7 CPU(s): 112-127,240-254 Vulnerability Gather data sampling: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Vulnerable Vulnerability Spec store bypass: Vulnerable Vulnerability Spectre v1: Vulnerable: __user pointer sanitization and usercopy barriers only; no swapgs barriers Vulnerability Spectre v2: Vulnerable; IBPB: disabled; STIBP: disabled; PBRSB-eIBRS: Not affected; BHI: Not affected Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Versions of relevant libraries: [pip3] mypy==1.9.0 [pip3] mypy-extensions==1.0.0 [pip3] numpy==1.26.4 [pip3] nvidia-cublas-cu12==12.1.3.1 [pip3] nvidia-cuda-cupti-cu12==12.1.105 [pip3] nvidia-cuda-nvrtc-cu12==12.1.105 [pip3] nvidia-cuda-runtime-cu12==12.1.105 [pip3] nvidia-cudnn-cu12==8.9.2.26 [pip3] nvidia-cufft-cu12==11.0.2.54 [pip3] nvidia-curand-cu12==10.3.2.106 [pip3] nvidia-cusolver-cu12==11.4.5.107 [pip3] nvidia-cusparse-cu12==12.1.0.106 [pip3] nvidia-nccl-cu12==2.20.5 [pip3] nvidia-nvjitlink-cu12==12.4.127 [pip3] nvidia-nvtx-cu12==12.1.105 [pip3] pytorch-lightning==2.2.1 [pip3] torch==2.3.1 [pip3] torchmetrics==1.3.2 [pip3] triton==2.3.1 [conda] Could not collect ``` cc @msaroufim @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10
module: performance,module: cpu,triaged
low
Critical
2,800,481,427
rust
`repr(transparent)` wrapper with uninhabited ZST has different return ABI than wrapped field.
<!-- Thank you for finding an Internal Compiler Error! ๐ŸงŠ If possible, try to provide a minimal verifiable example. You can read "Rust Bug Minimization Patterns" for how to create smaller examples. http://blog.pnkfx.org/blog/2019/11/18/rust-bug-minimization-patterns/ --> This code ICEs Miri, the normal compiler compiles this without complaint, but might be miscompiling it[^1], though a `const` version using `-Zunleash-the-miri-inside-of-you` does ICE the compiler. ### Code ```Rust type Field = u8; // any non-1ZST probably #[repr(transparent)] struct Foo { _zst: std::convert::Infallible, _field: Field, } fn foo() -> Foo { panic!() } fn main() { let f: fn() -> Foo = foo; let f: fn() -> Field = unsafe { std::mem::transmute(f) }; f(); } ``` ```sh cargo +nightly miri run ``` <details> <summary> modified version using `-Zunleash-the-miri-inside-of-you` that ICEs rustc </summary> ```rs type Field = u8; // any non-1ZST probably #[repr(transparent)] struct Foo { _zst: std::convert::Infallible, _field: Field, } const fn foo() -> Foo { panic!() } fn main() { const { let f: fn() -> Foo = foo; let f: fn() -> Field = unsafe { std::mem::transmute(f) }; f(); } } ``` ```sh RUSTFLAGS="-Zunleash-the-miri-inside-of-you" cargo +nightly run ``` Backtrace: ``` thread 'rustc' panicked at compiler/rustc_const_eval/src/interpret/call.rs:253:13: assertion failed: caller_abi.eq_abi(callee_abi) stack backtrace: 0: 0x7e3cb9b652a5 - std::backtrace::Backtrace::create::h8985a2f6ef2eb84f 1: 0x7e3cb80e39f5 - std::backtrace::Backtrace::force_capture::h9a611efb2a942dc9 2: 0x7e3cb725a4e0 - std[4faddc71fb6fa0e5]::panicking::update_hook::<alloc[c55780341d73682]::boxed::Box<rustc_driver_impl[80a9ca323d3e3890]::install_ice_hook::{closure#1}>>::{closure#0} 3: 0x7e3cb80fc333 - std::panicking::rust_panic_with_hook::hf47d9e178e038701 4: 0x7e3cb80fbff6 - std::panicking::begin_panic_handler::{{closure}}::hd9b9f2d3dd54e86c 5: 0x7e3cb80f99e9 - std::sys::backtrace::__rust_end_short_backtrace::h342bb668fc58e319 6: 0x7e3cb80fbced - rust_begin_unwind 7: 0x7e3cb4da8db0 - core::panicking::panic_fmt::hb3cd74fdfc019257 8: 0x7e3cb5897b9c - core::panicking::panic::h92e08174b9fe42d1 9: 0x7e3cb92c11bb - <rustc_const_eval[e3d2a21e14ef9d90]::interpret::eval_context::InterpCx<rustc_const_eval[e3d2a21e14ef9d90]::const_eval::machine::CompileTimeMachine>>::init_stack_frame 10: 0x7e3cb92bde11 - <rustc_const_eval[e3d2a21e14ef9d90]::interpret::eval_context::InterpCx<rustc_const_eval[e3d2a21e14ef9d90]::const_eval::machine::CompileTimeMachine>>::init_fn_call 11: 0x7e3cb6314e8f - rustc_const_eval[e3d2a21e14ef9d90]::const_eval::eval_queries::eval_to_allocation_raw_provider 12: 0x7e3cb9041f5c - rustc_query_impl[283282ac12660651]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[283282ac12660651]::query_impl::eval_to_allocation_raw::dynamic_query::{closure#2}::{closure#0}, rustc_middle[d099a8b084c78b18]::query::erase::Erased<[u8; 24usize]>> 13: 0x7e3cb9041fb7 - <rustc_query_impl[283282ac12660651]::query_impl::eval_to_allocation_raw::dynamic_query::{closure#2} as core[b8d8efd06dd057cd]::ops::function::FnOnce<(rustc_middle[d099a8b084c78b18]::ty::context::TyCtxt, rustc_middle[d099a8b084c78b18]::ty::PseudoCanonicalInput<rustc_middle[d099a8b084c78b18]::mir::interpret::GlobalId>)>>::call_once 14: 0x7e3cb90406be - rustc_query_system[57efd1c10fae1b2]::query::plumbing::try_execute_query::<rustc_query_impl[283282ac12660651]::DynamicConfig<rustc_query_system[57efd1c10fae1b2]::query::caches::DefaultCache<rustc_middle[d099a8b084c78b18]::ty::PseudoCanonicalInput<rustc_middle[d099a8b084c78b18]::mir::interpret::GlobalId>, rustc_middle[d099a8b084c78b18]::query::erase::Erased<[u8; 24usize]>>, false, false, false>, rustc_query_impl[283282ac12660651]::plumbing::QueryCtxt, true> 15: 0x7e3cb903fffd - rustc_query_impl[283282ac12660651]::query_impl::eval_to_allocation_raw::get_query_incr::__rust_end_short_backtrace 16: 0x7e3cb904475f - rustc_const_eval[e3d2a21e14ef9d90]::const_eval::eval_queries::eval_to_const_value_raw_provider 17: 0x7e3cb9044554 - rustc_query_impl[283282ac12660651]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[283282ac12660651]::query_impl::eval_to_const_value_raw::dynamic_query::{closure#2}::{closure#0}, rustc_middle[d099a8b084c78b18]::query::erase::Erased<[u8; 24usize]>> 18: 0x7e3cb904450d - <rustc_query_impl[283282ac12660651]::query_impl::eval_to_const_value_raw::dynamic_query::{closure#2} as core[b8d8efd06dd057cd]::ops::function::FnOnce<(rustc_middle[d099a8b084c78b18]::ty::context::TyCtxt, rustc_middle[d099a8b084c78b18]::ty::PseudoCanonicalInput<rustc_middle[d099a8b084c78b18]::mir::interpret::GlobalId>)>>::call_once 19: 0x7e3cb903f2e6 - rustc_query_system[57efd1c10fae1b2]::query::plumbing::try_execute_query::<rustc_query_impl[283282ac12660651]::DynamicConfig<rustc_query_system[57efd1c10fae1b2]::query::caches::DefaultCache<rustc_middle[d099a8b084c78b18]::ty::PseudoCanonicalInput<rustc_middle[d099a8b084c78b18]::mir::interpret::GlobalId>, rustc_middle[d099a8b084c78b18]::query::erase::Erased<[u8; 24usize]>>, false, true, false>, rustc_query_impl[283282ac12660651]::plumbing::QueryCtxt, true> 20: 0x7e3cb903ebc7 - rustc_query_impl[283282ac12660651]::query_impl::eval_to_const_value_raw::get_query_incr::__rust_end_short_backtrace 21: 0x7e3cb95e110b - <rustc_middle[d099a8b084c78b18]::ty::context::TyCtxt>::const_eval_resolve 22: 0x7e3cb5825b39 - <rustc_mir_transform[e7af90bdb15a3f20]::known_panics_lint::ConstPropagator as rustc_middle[d099a8b084c78b18]::mir::visit::Visitor>::visit_operand 23: 0x7e3cb5829080 - <rustc_mir_transform[e7af90bdb15a3f20]::known_panics_lint::ConstPropagator as rustc_middle[d099a8b084c78b18]::mir::visit::Visitor>::visit_assign 24: 0x7e3cb582799b - <rustc_mir_transform[e7af90bdb15a3f20]::known_panics_lint::ConstPropagator as rustc_middle[d099a8b084c78b18]::mir::visit::Visitor>::visit_body 25: 0x7e3cb95f79f9 - <rustc_mir_transform[e7af90bdb15a3f20]::known_panics_lint::KnownPanicsLint as rustc_mir_transform[e7af90bdb15a3f20]::pass_manager::MirLint>::run_lint 26: 0x7e3cb880b6f3 - rustc_mir_transform[e7af90bdb15a3f20]::run_analysis_to_runtime_passes 27: 0x7e3cb8c28174 - rustc_mir_transform[e7af90bdb15a3f20]::mir_drops_elaborated_and_const_checked 28: 0x7e3cb8c27da5 - rustc_query_impl[283282ac12660651]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[283282ac12660651]::query_impl::mir_drops_elaborated_and_const_checked::dynamic_query::{closure#2}::{closure#0}, rustc_middle[d099a8b084c78b18]::query::erase::Erased<[u8; 8usize]>> 29: 0x7e3cb8c2bcd9 - rustc_query_system[57efd1c10fae1b2]::query::plumbing::try_execute_query::<rustc_query_impl[283282ac12660651]::DynamicConfig<rustc_data_structures[ff6b6eb237e26604]::vec_cache::VecCache<rustc_span[6fdbe82b95f770dc]::def_id::LocalDefId, rustc_middle[d099a8b084c78b18]::query::erase::Erased<[u8; 8usize]>, rustc_query_system[57efd1c10fae1b2]::dep_graph::graph::DepNodeIndex>, false, false, false>, rustc_query_impl[283282ac12660651]::plumbing::QueryCtxt, true> 30: 0x7e3cb8c24dae - rustc_query_impl[283282ac12660651]::query_impl::mir_drops_elaborated_and_const_checked::get_query_incr::__rust_end_short_backtrace 31: 0x7e3cb8c248f3 - <rustc_middle[d099a8b084c78b18]::hir::map::Map>::par_body_owners::<rustc_interface[5facaafd3cd44e6f]::passes::run_required_analyses::{closure#3}::{closure#0}>::{closure#0} 32: 0x7e3cb8c21df4 - rustc_interface[5facaafd3cd44e6f]::passes::run_required_analyses 33: 0x7e3cb976ca9e - rustc_interface[5facaafd3cd44e6f]::passes::analysis 34: 0x7e3cb976ca6f - rustc_query_impl[283282ac12660651]::plumbing::__rust_begin_short_backtrace::<rustc_query_impl[283282ac12660651]::query_impl::analysis::dynamic_query::{closure#2}::{closure#0}, rustc_middle[d099a8b084c78b18]::query::erase::Erased<[u8; 0usize]>> 35: 0x7e3cb97683cf - rustc_query_system[57efd1c10fae1b2]::query::plumbing::try_execute_query::<rustc_query_impl[283282ac12660651]::DynamicConfig<rustc_query_system[57efd1c10fae1b2]::query::caches::SingleCache<rustc_middle[d099a8b084c78b18]::query::erase::Erased<[u8; 0usize]>>, false, false, false>, rustc_query_impl[283282ac12660651]::plumbing::QueryCtxt, true> 36: 0x7e3cb9767d47 - rustc_query_impl[283282ac12660651]::query_impl::analysis::get_query_incr::__rust_end_short_backtrace 37: 0x7e3cb9820669 - rustc_interface[5facaafd3cd44e6f]::passes::create_and_enter_global_ctxt::<core[b8d8efd06dd057cd]::option::Option<rustc_interface[5facaafd3cd44e6f]::queries::Linker>, rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0} 38: 0x7e3cb9813896 - rustc_interface[5facaafd3cd44e6f]::interface::run_compiler::<(), rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}>::{closure#1} 39: 0x7e3cb9670807 - std[4faddc71fb6fa0e5]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_with_globals<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_pool_with_globals<rustc_interface[5facaafd3cd44e6f]::interface::run_compiler<(), rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()> 40: 0x7e3cb96704d9 - <<std[4faddc71fb6fa0e5]::thread::Builder>::spawn_unchecked_<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_with_globals<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_pool_with_globals<rustc_interface[5facaafd3cd44e6f]::interface::run_compiler<(), rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core[b8d8efd06dd057cd]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} 41: 0x7e3cb966fc6b - std::sys::pal::unix::thread::Thread::new::thread_start::h07063fc11dcd9adf 42: 0x7e3cb389ca94 - start_thread at ./nptl/pthread_create.c:447:8 43: 0x7e3cb3929c3c - clone3 at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:78:0 44: 0x0 - <unknown> rustc version: 1.86.0-nightly (9a1d156f3 2025-01-19) platform: x86_64-unknown-linux-gnu query stack during panic: #0 [eval_to_allocation_raw] const-evaluating + checking `main::{constant#0}` #1 [eval_to_const_value_raw] simplifying constant for the type system `main::{constant#0}` #2 [mir_drops_elaborated_and_const_checked] elaborating drops for `main` #3 [analysis] running analysis passes on this crate end of query stack ``` </details> ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` rustc 1.86.0-nightly (9a1d156f3 2025-01-19) binary: rustc commit-hash: 9a1d156f38c51441ee51e5a068f1d0caf4bb0f27 commit-date: 2025-01-19 host: x86_64-unknown-linux-gnu release: 1.86.0-nightly LLVM version: 19.1.7 ``` ### Error output <details> <summary> Error output </summary> ``` thread 'rustc' panicked at /rustc/9a1d156f38c51441ee51e5a068f1d0caf4bb0f27/compiler/rustc_const_eval/src/interpret/call.rs:253:13: assertion failed: caller_abi.eq_abi(callee_abi) stack backtrace: 0: 0x78aed8af951a - <std::sys::backtrace::BacktraceLock::print::DisplayBacktrace as core::fmt::Display>::fmt::h70d5098cfd90b01a 1: 0x78aed9212da6 - core::fmt::write::h854c563aac02d08a 2: 0x78aeda171291 - std::io::Write::write_fmt::hac4174e389a0e8e6 3: 0x78aed8af9372 - std::sys::backtrace::BacktraceLock::print::hc6aba0d6b3a91e1f 4: 0x78aed8afb7f2 - std::panicking::default_hook::{{closure}}::h9628a97795328020 5: 0x78aed8afb67a - std::panicking::default_hook::h0dc7e102448ae736 6: 0x78aed7c59eeb - std[4faddc71fb6fa0e5]::panicking::update_hook::<alloc[c55780341d73682]::boxed::Box<rustc_driver_impl[80a9ca323d3e3890]::install_ice_hook::{closure#1}>>::{closure#0} 7: 0x78aed8afc333 - std::panicking::rust_panic_with_hook::hf47d9e178e038701 8: 0x78aed8afbff6 - std::panicking::begin_panic_handler::{{closure}}::hd9b9f2d3dd54e86c 9: 0x78aed8af99e9 - std::sys::backtrace::__rust_end_short_backtrace::h342bb668fc58e319 10: 0x78aed8afbced - rust_begin_unwind 11: 0x78aed57a8db0 - core::panicking::panic_fmt::hb3cd74fdfc019257 12: 0x78aed6297b9c - core::panicking::panic::h92e08174b9fe42d1 13: 0x592a4689f7ae - <rustc_const_eval[e3d2a21e14ef9d90]::interpret::eval_context::InterpCx<miri[d18ac4a41561b88d]::machine::MiriMachine>>::check_argument_compat 14: 0x592a4689ec5a - <rustc_const_eval[e3d2a21e14ef9d90]::interpret::eval_context::InterpCx<miri[d18ac4a41561b88d]::machine::MiriMachine>>::init_stack_frame 15: 0x592a4689c98b - <rustc_const_eval[e3d2a21e14ef9d90]::interpret::eval_context::InterpCx<miri[d18ac4a41561b88d]::machine::MiriMachine>>::init_fn_call 16: 0x592a46915db4 - miri[d18ac4a41561b88d]::eval::eval_entry::{closure#0} 17: 0x592a46911e9b - miri[d18ac4a41561b88d]::eval::eval_entry 18: 0x592a467c4226 - <miri[e9b5d2e94aebaf6c]::MiriCompilerCalls as rustc_driver_impl[80a9ca323d3e3890]::Callbacks>::after_analysis 19: 0x78aeda220676 - rustc_interface[5facaafd3cd44e6f]::passes::create_and_enter_global_ctxt::<core[b8d8efd06dd057cd]::option::Option<rustc_interface[5facaafd3cd44e6f]::queries::Linker>, rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0} 20: 0x78aeda213896 - rustc_interface[5facaafd3cd44e6f]::interface::run_compiler::<(), rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}>::{closure#1} 21: 0x78aeda070807 - std[4faddc71fb6fa0e5]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_with_globals<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_pool_with_globals<rustc_interface[5facaafd3cd44e6f]::interface::run_compiler<(), rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()> 22: 0x78aeda0704d9 - <<std[4faddc71fb6fa0e5]::thread::Builder>::spawn_unchecked_<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_with_globals<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_pool_with_globals<rustc_interface[5facaafd3cd44e6f]::interface::run_compiler<(), rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core[b8d8efd06dd057cd]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} 23: 0x78aeda06fc6b - std::sys::pal::unix::thread::Thread::new::thread_start::h07063fc11dcd9adf 24: 0x78aed429ca94 - start_thread at ./nptl/pthread_create.c:447:8 25: 0x78aed4329c3c - clone3 at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:78:0 26: 0x0 - <unknown> error: the compiler unexpectedly panicked. this is a bug. note: we would appreciate a bug report: https://github.com/rust-lang/miri/issues/new note: please make sure that you have updated to the latest nightly note: please attach the file at `/tmp/sadkjlhfsakdf/rustc-ice-2025-01-21T00_17_45-3693735.txt` to your bug report note: compiler flags: --crate-type bin -C embed-bitcode=no -C debuginfo=2 -C incremental=[REDACTED] note: some of the compiler flags provided by cargo are hidden query stack during panic: end of query stack Miri caused an ICE during evaluation. Here's the interpreter backtrace at the time of the panic: note: the place in the program where the ICE was triggered --> src/main.rs:7:5 | 7 | panic!() | ^^^^^^^^ | = note: BACKTRACE: = note: inside `foo` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/panic.rs:90:9: 90:30 note: inside `main` --> src/main.rs:12:5 | 12 | f(); | ^^^ = note: inside `<fn() as std::ops::FnOnce<()>>::call_once - shim(fn())` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:250:5: 250:71 = note: inside `std::sys::backtrace::__rust_begin_short_backtrace::<fn(), ()>` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/sys/backtrace.rs:152:18: 152:21 = note: inside closure at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/rt.rs:194:18: 194:75 = note: inside `std::ops::function::impls::<impl std::ops::FnOnce<()> for &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>::call_once` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/core/src/ops/function.rs:284:13: 284:31 = note: inside `std::panicking::r#try::do_call::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:587:40: 587:43 = note: inside `std::panicking::r#try::<i32, &dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe>` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:550:19: 550:88 = note: inside `std::panic::catch_unwind::<&dyn std::ops::Fn() -> i32 + std::marker::Sync + std::panic::RefUnwindSafe, i32>` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panic.rs:358:14: 358:33 = note: inside closure at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/rt.rs:163:24: 163:49 = note: inside `std::panicking::r#try::do_call::<{closure@std::rt::lang_start_internal::{closure#0}}, isize>` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:587:40: 587:43 = note: inside `std::panicking::r#try::<isize, {closure@std::rt::lang_start_internal::{closure#0}}>` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panicking.rs:550:19: 550:88 = note: inside `std::panic::catch_unwind::<{closure@std::rt::lang_start_internal::{closure#0}}, isize>` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/panic.rs:358:14: 358:33 = note: inside `std::rt::lang_start_internal` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/rt.rs:159:5: 181:7 = note: inside `std::rt::lang_start::<()>` at /home/zachary/.rustup/toolchains/nightly-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/std/src/rt.rs:193:5: 198:6 = note: this note originates in the macro `$crate::panic::panic_2021` which comes from the expansion of the macro `panic` (in Nightly builds, run with -Z macro-backtrace for more info) ``` </details> <!-- Include a backtrace in the code block by setting `RUST_BACKTRACE=1` in your environment. E.g. `RUST_BACKTRACE=1 cargo build`. --> <details><summary><strong>ICE file</strong></summary> <p> ``` thread 'rustc' panicked at /rustc/9a1d156f38c51441ee51e5a068f1d0caf4bb0f27/compiler/rustc_const_eval/src/interpret/call.rs:253:13: assertion failed: caller_abi.eq_abi(callee_abi) stack backtrace: 0: 0x78aeda5652a5 - std::backtrace::Backtrace::create::h8985a2f6ef2eb84f 1: 0x78aed8ae39f5 - std::backtrace::Backtrace::force_capture::h9a611efb2a942dc9 2: 0x78aed7c5a4e0 - std[4faddc71fb6fa0e5]::panicking::update_hook::<alloc[c55780341d73682]::boxed::Box<rustc_driver_impl[80a9ca323d3e3890]::install_ice_hook::{closure#1}>>::{closure#0} 3: 0x78aed8afc333 - std::panicking::rust_panic_with_hook::hf47d9e178e038701 4: 0x78aed8afbff6 - std::panicking::begin_panic_handler::{{closure}}::hd9b9f2d3dd54e86c 5: 0x78aed8af99e9 - std::sys::backtrace::__rust_end_short_backtrace::h342bb668fc58e319 6: 0x78aed8afbced - rust_begin_unwind 7: 0x78aed57a8db0 - core::panicking::panic_fmt::hb3cd74fdfc019257 8: 0x78aed6297b9c - core::panicking::panic::h92e08174b9fe42d1 9: 0x592a4689f7ae - <rustc_const_eval[e3d2a21e14ef9d90]::interpret::eval_context::InterpCx<miri[d18ac4a41561b88d]::machine::MiriMachine>>::check_argument_compat 10: 0x592a4689ec5a - <rustc_const_eval[e3d2a21e14ef9d90]::interpret::eval_context::InterpCx<miri[d18ac4a41561b88d]::machine::MiriMachine>>::init_stack_frame 11: 0x592a4689c98b - <rustc_const_eval[e3d2a21e14ef9d90]::interpret::eval_context::InterpCx<miri[d18ac4a41561b88d]::machine::MiriMachine>>::init_fn_call 12: 0x592a46915db4 - miri[d18ac4a41561b88d]::eval::eval_entry::{closure#0} 13: 0x592a46911e9b - miri[d18ac4a41561b88d]::eval::eval_entry 14: 0x592a467c4226 - <miri[e9b5d2e94aebaf6c]::MiriCompilerCalls as rustc_driver_impl[80a9ca323d3e3890]::Callbacks>::after_analysis 15: 0x78aeda220676 - rustc_interface[5facaafd3cd44e6f]::passes::create_and_enter_global_ctxt::<core[b8d8efd06dd057cd]::option::Option<rustc_interface[5facaafd3cd44e6f]::queries::Linker>, rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}::{closure#2}>::{closure#2}::{closure#0} 16: 0x78aeda213896 - rustc_interface[5facaafd3cd44e6f]::interface::run_compiler::<(), rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}>::{closure#1} 17: 0x78aeda070807 - std[4faddc71fb6fa0e5]::sys::backtrace::__rust_begin_short_backtrace::<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_with_globals<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_pool_with_globals<rustc_interface[5facaafd3cd44e6f]::interface::run_compiler<(), rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()> 18: 0x78aeda0704d9 - <<std[4faddc71fb6fa0e5]::thread::Builder>::spawn_unchecked_<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_with_globals<rustc_interface[5facaafd3cd44e6f]::util::run_in_thread_pool_with_globals<rustc_interface[5facaafd3cd44e6f]::interface::run_compiler<(), rustc_driver_impl[80a9ca323d3e3890]::run_compiler::{closure#0}>::{closure#1}, ()>::{closure#0}, ()>::{closure#0}::{closure#0}, ()>::{closure#1} as core[b8d8efd06dd057cd]::ops::function::FnOnce<()>>::call_once::{shim:vtable#0} 19: 0x78aeda06fc6b - std::sys::pal::unix::thread::Thread::new::thread_start::h07063fc11dcd9adf 20: 0x78aed429ca94 - start_thread at ./nptl/pthread_create.c:447:8 21: 0x78aed4329c3c - clone3 at ./misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:78:0 22: 0x0 - <unknown> rustc version: 1.86.0-nightly (9a1d156f3 2025-01-19) platform: x86_64-unknown-linux-gnu query stack during panic: end of query stack ``` </p> </details> @rustbot label +A-miri +A-ABI ----- This shouldn't ICE regardless, but whether there is a miscompilation depends on if the original code is sound: CC https://github.com/rust-lang/unsafe-code-guidelines/issues/485 <details> <summary> Possible Miscompilation </summary> ### Does `#[repr(transparent)]`s ABI-compatility guarantee apply in the prescence of uninhabited 1-ZST fields? A `#[repr(transparent)]` wrapper that contains an uninhabited 1-ZST field gets `Uninhabited` ABI IIUC, which may contradict the guarantees about `#[repr(transparent)]` wrappers being ABI-compatible. Consider `Foo` from above: ```rust type Field = u8; // any non-1ZST probably #[repr(transparent)] struct Foo { _zst: std::convert::Infallible, _field: Field, } ``` If `#[repr(transparent)]`'s ABI-compatility guarantees *do* apply, then the above code should be sound: 1. If a function returns `Foo`, it must diverge (e.g. by panicking). 2. If `Foo` is ABI-compatible with `Field`, then it should be sound to transmute a function pointer to a diverging `fn() -> Foo` into a `fn() -> Field` that also diverges. <details> <summary> rustc_layout(debug) </summary> Using `#![feature(rustc_attrs)]` and `#[rustc_layout(debug)]` we see that the ABI it has is ```rs error: layout_of(Foo) = Layout { // snip abi: Uninhabited, // snip } ``` whereas `Field` has ```rs error: layout_of(u8) = Layout { // snip abi: Scalar( Initialized { value: Int( I8, false, ), valid_range: 0..=255, }, ), // snip } ``` </details> ### Possible Miscompilation Assuming this is supposed to be sound, then there is an observable miscompilation here too. Where `Field` is returned by invisible reference, `fn(u32) -> Foo` does not return `Foo` by invisible reference, so transmuting `fn(u32) -> Foo` into `fn(u32) -> Field` will pass a different number of arguments. Specifically on `x86_64-unknown-linux-gnu`: If `Field` is returned on the stack, then `fn(..) -> Foo` does not reserve stack space or pass a hidden reference parameter, but `fn(..) -> Field` does. This can be made into an observable miscompilation if the function takes parameters: ([playground link](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=8457797447ef2a581f598b4fe7053f42), IIUC: the invisible reference is being passed, but the callee isn't expecting it, so it thinks it's the first "real" parameter instead (caller: ret by-ref in `rdi`, `x` in `rsi`; callee: ret uninhabited, `x` in `rdi`)). </details> [^1]: see "Possible Miscompilation" section
I-ICE,T-lang,T-compiler,C-bug,A-miri,A-ABI,A-repr
medium
Critical
2,800,500,030
flutter
[go_router] Root routes require a `/` despite docs saying otherwise
### Steps to reproduce The Changelog says: >14.2.9 Relaxes route path requirements. Both root and child routes can now start with or without '/'. But when I try this: ```dart inal router = GoRouter( initialLocation: '/${LandingPage.routeName}', routes: [ GoRoute( name: SplashPage.routeName, path: SplashPage.routeName, builder: (context, routerState) => const SplashPage(), ), GoRoute( name: LandingPage.routeName, path: LandingPage.routeName, // This is the string 'landing' builder: (context, routerState) => const LandingPage(), routes: [ .....] ``` I get a page saying `GoException: no routes for location: /landing`. If I change the code to use `initialLocation: LandingPage.routeName,`, thus removing the `/`, I get an assertion error: >'package:go_router/src/match.dart': Failed assertion: line 235 pos 12: 'uri.path.startsWith(newMatchedLocation)': is not true. So I think this new feature is broken, or I am missing something here I am using go_router version 14.6.3, confirmed on pubspec.lock. ### Expected results The package would ignore the absence of a `/` in all route definitions. ### Actual results I can only start my app if I declare my root routes with a `/` at their paths, as in: ```dart final router = GoRouter( initialLocation: '/${LandingPage.routeName}', routes: [ GoRoute( name: SplashPage.routeName, path: '/${SplashPage.routeName}', builder: (context, routerState) => const SplashPage(), ), GoRoute( name: LandingPage.routeName, path: '/${LandingPage.routeName}', builder: (context, routerState) => const LandingPage(), routes: [....] ``` ### Code sample See above ### Screenshots or Video _No response_ ### Logs _No response_ ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [โœ“] Flutter (Channel stable, 3.24.4, on macOS 15.1.1 24B91 darwin-arm64, locale en-AU) โ€ข Flutter version 3.24.4 on channel stable at /Users/michelfeinstein/.puro/envs/3.24.4/flutter โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision 603104015d (3 months ago), 2024-10-24 08:01:25 -0700 โ€ข Engine revision db49896cf2 โ€ข Dart version 3.5.4 โ€ข DevTools version 2.37.3 [โœ“] Android toolchain - develop for Android devices (Android SDK version 35.0.0) โ€ข Android SDK at /Users/michelfeinstein/Library/Android/sdk โ€ข Platform android-35, build-tools 35.0.0 โ€ข ANDROID_HOME = /Users/michelfeinstein/Library/Android/sdk โ€ข Java binary at: /opt/homebrew/Cellar/openjdk@17/17.0.13/libexec/openjdk.jdk/Contents/Home/bin/java โ€ข Java version OpenJDK Runtime Environment Homebrew (build 17.0.13+0) โ€ข All Android licenses accepted. [โœ“] Xcode - develop for iOS and macOS (Xcode 16.2) โ€ข Xcode at /Applications/Xcode.app/Contents/Developer โ€ข Build 16C5032a โ€ข CocoaPods version 1.16.2 [โœ“] Chrome - develop for the web โ€ข Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [โœ“] Android Studio (version 2024.2) โ€ข Android Studio at /Applications/Android Studio.app/Contents โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 21.0.4+-12422083-b607.1) [โœ“] IntelliJ IDEA Community Edition (version 2024.1.1) โ€ข IntelliJ at /Applications/IntelliJ IDEA CE.app โ€ข Flutter plugin version 79.0.3 โ€ข Dart plugin version 241.15989.9 [โœ“] VS Code (version 1.95.1) โ€ข VS Code at /Applications/Visual Studio Code.app/Contents โ€ข Flutter extension version 3.98.0 [โœ“] Connected device (6 available) โ€ข Snorlax (mobile) โ€ข 00008027-001964DE212B002E โ€ข ios โ€ข iOS 17.7.1 21H216 โ€ข Abra (mobile) โ€ข 00008112-000E18181E6BA01E โ€ข ios โ€ข iOS 18.1 22B83 โ€ข iPhone 16 (mobile) โ€ข 1A2D81B2-5F45-4F24-84B0-636DD475E1D6 โ€ข ios โ€ข com.apple.CoreSimulator.SimRuntime.iOS-18-2 (simulator) โ€ข macOS (desktop) โ€ข macos โ€ข darwin-arm64 โ€ข macOS 15.1.1 24B91 darwin-arm64 โ€ข Mac Designed for iPad (desktop) โ€ข mac-designed-for-ipad โ€ข darwin โ€ข macOS 15.1.1 24B91 darwin-arm64 โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 131.0.6778.266 ! Device R5CW41Q82WT is not authorized. You might need to check your device for an authorization dialog. ! Error: Browsing on the local area network for Celebi. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac. The device must be opted into Developer Mode to connect wirelessly. (code -27) ! Error: Browsing on the local area network for iPhone. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac. The device must be opted into Developer Mode to connect wirelessly. (code -27) [โœ“] Network resources โ€ข All expected network resources are available. โ€ข No issues found! ``` </details>
waiting for customer response,in triage
low
Critical
2,800,521,659
storybook
[Bug]: Infinite re-render for async RSC stories
### Describe the bug There was always some funkiness around using `await` in RSC story renders in Storybook (eg see https://github.com/amannn/next-intl/discussions/771#discussioncomment-10610137), but in the version 8.5.0+ the behavior has changed for the worse. Now if I have a server component with `await` in it, some recent change on the Storybook side seems to be causing an infinite render. It's a bit tricky to point out what factor exactly causes this, as in my isolated repro even a **single** `await` is enough to trigger it, whereas in my actual codebase it only seems to happen when there are 2+. ![Image](https://github.com/user-attachments/assets/910ac6a6-7fb8-462f-b61d-c32498c62de4) ### Reproduction link https://github.com/dmitrc/storybook-repro ### Reproduction steps ``` git clone https://github.com/dmitrc/storybook-repro cd storybook-repro pnpm install pnpm dev # verify that the components render pnpm storybook # open the console to see the infinite render loop ``` Or setup from scratch: ``` pnpm dlx create-next-app@latest pnpm dlx storybook@latest init ``` .storybook/main.ts: ``` features: { experimentalRSC: true, developmentModeForBuild: true, }, ``` page.tsx: ``` export default function Home() { return ( <div> <ServerComponentWithOneAwait /> <ServerComponentWithManyAwaits /> </div> ); } export async function ServerComponentWithOneAwait() { console.log(`ServerComponentWithOneAwait`); const md1 = await getMockData(1); return <p>{md1}</p> } export async function ServerComponentWithManyAwaits() { console.log(`ServerComponentWithManyAwaits`); const md1 = await getMockData(1); const md2 = await getMockData(2); return <p>{md1} + {md2}</p> } export function getMockData(i: number): Promise<string> { return new Promise((resolve) => setTimeout(() => resolve(`mock data ${i}`), 1000)); } ``` ServerComponentWithOneAwait.stories.tsx: ``` import type { Meta, StoryObj } from "@storybook/react"; import { ServerComponentWithOneAwait } from "../app/page"; const meta: Meta<typeof ServerComponentWithOneAwait> = { title: "RSC/OneAwait", component: ServerComponentWithOneAwait, }; export default meta; type Story = StoryObj<typeof meta>; export const Default: Story = {}; ``` ### System ```bash Storybook Environment Info: System: OS: Linux 5.15 Ubuntu 24.04.1 LTS 24.04.1 LTS (Noble Numbat) CPU: (32) x64 AMD Ryzen Threadripper PRO 3955WX 16-Cores Shell: 5.9 - /usr/bin/zsh Binaries: Node: 22.12.0 - ~/.nvm/versions/node/v22.12.0/bin/node npm: 10.9.0 - ~/.nvm/versions/node/v22.12.0/bin/npm pnpm: 9.15.1 - ~/.nvm/versions/node/v22.12.0/bin/pnpm <----- active npmPackages: @storybook/nextjs: ^8.5.0 => 8.5.0 @storybook/react: ^8.5.0 => 8.5.0 eslint-plugin-storybook: ^0.11.2 => 0.11.2 storybook: ^8.5.0 => 8.5.0 ``` ### Additional context _No response_
bug,nextjs
medium
Critical
2,800,558,666
ui
[bug]: SelectTrigger call onOpenChange of Dialog
### Describe the bug I use Select in Dialog, but when click to ```<SelectTrigger>``` then Dialog close by ```onOpenChange``` ``` <Dialog modal={false} open={open} onOpenChange={setOpen}> <DialogContent className="max-h-[90vh] overflow-y-auto"> <Form {...form}> <FormField control={form.control} name="personType" render={({ field }) => ( <FormItem> <FormLabel>Person Type</FormLabel> <Select onValueChange={(value) => field.onChange(Number(value))} value={field.value?.toString()} > <FormControl> <SelectTrigger> <SelectValue placeholder="Select a person type" /> </SelectTrigger> </FormControl> <SelectContent> {personTypeOptions.map((option) => ( <SelectItem key={option.value} value={option.value.toString()} > {option.label} </SelectItem> ))} </SelectContent> </Select> <FormMessage /> </FormItem> )} /> </Form> </DialogContent> </Dialog> ``` ### Affected component/components Dialog, Select ### How to reproduce 1. Open ```Select``` dropdown 2. CLick again to ```<SelectTrigger>``` or outside ```<Select>``` 3. ```<Dialog>``` auto close by call event ```onOpenChange``` ### Codesandbox/StackBlitz link _No response_ ### Logs ```bash ``` ### System Info ```bash try on Chrome, Edge. ``` ### Before submitting - [x] I've made research efforts and searched the documentation - [x] I've searched for existing issues
bug
low
Critical
2,800,610,919
react-native
FlatList children sometimes stop responding to taps when using pull-to-refresh
### Description When performing a FlatList pull-to-refresh shortly after a regular scroll up, the contents of the list sometimes become completely unresponsive to taps. When that happens, a slight scroll down immediately fixes the issue, ### Steps to reproduce 1. Scroll to the top of the list 2. Scroll down slightly so there's room for the next maneuver 3. Do a gentle scroll up, and while the scroll still has momentum and you are near the top of the list, do another scroll up to engage the pull-to-refresh (you don't need to actually trigger a refresh but the bug remains even if you do) 4. After you release the gesture, the buttons in the list are unresponsive to taps until you perform a scroll down again ### React Native Version 0.76.6 ### Affected Platforms Runtime - Android ### Output of `npx react-native info` ```text System: OS: Windows 11 10.0.22631 CPU: "(12) x64 AMD Ryzen 5 5600H with Radeon Graphics " Memory: 2.94 GB / 13.86 GB Binaries: Node: version: 22.12.0 path: C:\nvm4w\nodejs\node.EXE Yarn: version: 1.22.22 path: C:\nvm4w\nodejs\yarn.CMD npm: version: 10.9.0 path: C:\nvm4w\nodejs\npm.CMD Watchman: version: 20241222.093427.0 path: C:\ProgramData\chocolatey\bin\watchman.EXE SDKs: Android SDK: API Levels: - "31" - "33" - "34" - "35" Build Tools: - 30.0.3 - 33.0.1 - 34.0.0 - 35.0.0 System Images: - android-34 | Google Play Intel x86_64 Atom Android NDK: Not Found Windows SDK: AllowDevelopmentWithoutDevLicense: Enabled AllowAllTrustedApps: Disabled Versions: - 10.0.19041.0 - 10.0.22000.0 - 10.0.22621.0 IDEs: Android Studio: AI-242.23726.103.2422.12816248 Visual Studio: - 17.12.35527.113 (Visual Studio Community 2022) Languages: Java: version: 17.0.13 path: C:\Program Files\Microsoft\jdk-17.0.13.11-hotspot\bin\javac.EXE Ruby: version: 3.2.1 path: C:\Ruby32-x64\bin\ruby.EXE npmPackages: "@react-native-community/cli": installed: 15.1.3 wanted: ^15.1.3 react: installed: 18.3.1 wanted: 18.3.1 react-native: installed: 0.76.6 wanted: ^0.76.6 react-native-windows: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: true newArchEnabled: true iOS: hermesEnabled: Not found newArchEnabled: Not found ``` ### Stacktrace or Logs ```text N/A ``` ### Reproducer https://snack.expo.dev/@the_cetus/thankful-orange-kiwi ### Screenshots and Videos https://github.com/user-attachments/assets/5ccada90-67ef-42a3-90d3-7be33df7db47
Issue: Author Provided Repro,Component: FlatList
low
Critical
2,800,619,388
godot
RichTextLabel emits "finished" signal when is_ready() is false
### Tested versions Reproducible in 4.1, 4.3 stable Semi-reproducible in 4.0 stable (Method and signal were introduced in 4.0) ### System information Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Mobile) - dedicated NVIDIA GeForce GTX 1060 with Max-Q Design (NVIDIA; 30.0.15.1278) - Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 Threads) ### Issue description RichTextLabel emits "finished" signal when is_ready() is false. According to the docs, "finished" means all the text is loaded and functions such as get_visible_line_count() should perform correctly, but this is not the case. ![Image](https://github.com/user-attachments/assets/66d5a464-9a10-4bfa-8ca4-f335fc12d32e) The code in the screenshot: ``` extends Control func _ready(): $Timer.connect("timeout",msgOuter) #Timer should be auto-start and oneshot $RichTextLabel.connect("finished",msg) func msgOuter(): print("Timer done") msg() func msg(): print("Is ready? ", $RichTextLabel.is_ready()) var all = $RichTextLabel.get_line_count() var vis = $RichTextLabel.get_visible_line_count() print(all, " lines total, ", vis, " visible") ``` I have confirmed the issue is present in Godot 4.1 Stable and 4.3 Stable In Godot 4.0 Stable, is_ready() returns true, but get_visible_line_count() still incorrectly returns 0, so I believe is_ready() is behaving incorrectly too in this version. Opening and running the project in 4.0 produces the following: ![Image](https://github.com/user-attachments/assets/76a4428a-aa33-48ff-97f9-09bb23987a0c) ### Steps to reproduce Connect a parent node and a child RichTextLabel that contains some text. Connect the child's "finished" signal to a function in the parent. In the function, print the result of is_ready(). You will see that the signal is passes when is_ready is false. Alternatively, use the minimal reproduction below. Note that finished/is_ready are used when threading is enabled, so this may be due to system/processor dependent race conditions. ### Minimal reproduction project (MRP) [LabelBugZip.zip](https://github.com/user-attachments/files/18484385/LabelBugZip.zip)
bug,topic:gui
low
Critical
2,800,686,289
pytorch
Expose configurable path instead of using fixed path in the inductor module for serialized pattern generation
### ๐Ÿš€ The feature, motivation and pitch Expose configurable path instead of using fixed path in the inductor module for serialized pattern generation ### Alternatives _No response_ ### Additional context _No response_ cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @chauhang @aakhundov
triaged,oncall: pt2,module: inductor
low
Minor
2,800,723,771
node
Node executes a JS file with error code 3221225477 in VS Code.
### Version 23.6.0 and 22.13.0 ### Platform ```text Microsoft Windows NT 10.0.22631.0 x64 ``` ### Subsystem _No response_ ### What steps will reproduce the bug? vscode run code ![Image](https://github.com/user-attachments/assets/5820f8f3-a365-49a3-9874-492ed765c574) The previous run of Qieben output an error code. But everything is normal when I run it in the root directory of the folder before switching. Switching to 18.20.4 and everything is back to normal after the update. Here are the steps to reproduce the error when switching to version 23. ![Image](https://github.com/user-attachments/assets/92c991a8-a90a-4240-87af-bff270865d5b) ![Image](https://github.com/user-attachments/assets/7f44232a-8ff6-4979-a4d3-8a0b6b9fc58f) ### How often does it reproduce? Is there a required condition? every ### What is the expected behavior? Why is that the expected behavior? normal ececute and output ### What do you see instead? exited with code=3221225477 ### Additional information _No response_
fs,windows
low
Critical
2,800,729,237
excalidraw
Continuous Line Doesn't Add the Last Line When Using a Stylus on iPad
When using a stylus on an iPad, the continuous line drawing feature in Excalidraw does not add the last segment of the line. The line stops short, leaving a gap instead of completing the drawing as expected. **Environment:** Device: iPad Stylus: Metapen Browser: Safari **Additional Notes:** Referencing issue [#8617](https://github.com/excalidraw/excalidraw/issues/8617) for other related concerns, but this is a separate issue. https://github.com/user-attachments/assets/587d0eff-fd5d-412f-8953-3afb82de9eb7
bug,tablet
low
Minor
2,800,747,989
go
x/tools/go/analysis/passes/copylock: fails to report re-assignment of sync.WaitGroup variables
### Proposal Details Reassignment of variables of type `sync.WaitGroup` is likely to cause bugs due to the potential to overwrite a WaitGroup with a non-zero counter value with a WaitGroup that has a zero counter. I can't think of any scenarios whereby reassigning a variable of type `sync.WaitGroup` would be required or useful. The waitgroup analysis pass should be extended to report reassignments of `sync.WaitGroup` variables. ### Example ```go package main import ( "sync" ) type Object struct { wg sync.WaitGroup } var wg0 sync.WaitGroup func main() { var wg1 sync.WaitGroup // ok wg2 := sync.WaitGroup{} // ok var wg3 sync.WaitGroup = sync.WaitGroup{} // ok obj := Object{ wg: sync.WaitGroup{}, // ok } wg0 = sync.WaitGroup{} // want: variable of type sync.WaitGroup reassigned wg1 = sync.WaitGroup{} // want: variable of type sync.WaitGroup reassigned obj.wg = sync.WaitGroup{} // want: variable of type sync.WaitGroup reassigned wg0.Wait() wg1.Wait() wg2.Wait() wg3.Wait() } ``` Should this proposal be approved, I'd like to contribute the aforementioned changes.
NeedsInvestigation,Tools
low
Critical
2,800,749,460
deno
`deno info` does not list all peerDependencies
Version: Deno 2.1.6 To reproduce the error: `deno info npm:[email protected]/dom` it will show only these dependencies: ``` npm:/[email protected]/dom (2.17MB) โ”œโ”€โ”€ npm:/@types/[email protected] (9.84KB) โ”œโ”€โ”€ npm:/[email protected] (45.43KB) โ”œโ”€โ”€ npm:/[email protected] (231.91KB) โ”œโ”€โ”€ npm:/[email protected] (15.7KB) โ””โ”€โ”€ npm:/[email protected] (53.22KB) ``` But this is not correct since also `react-dom` should be listed here, because `react-dom` like `react` is listed as peerDependency in the package json of the distributed npm package that you can check here: https://www.npmjs.com/package/react-router?activeTab=code
deno info
low
Critical
2,800,786,116
pytorch
[Break XPU] device type in test_aot_inductor.py is not passed correctly to cpp_builder.
### ๐Ÿ› Describe the bug #### Description Currently XPU Ci is broken by the newly added test case `AOTInductorTestABICompatibleGpu.test_assert_tensor_meta_xpu` The CI log: https://github.com/pytorch/pytorch/actions/runs/12869396818/job/35880652376 Error msg: ``` =================================== FAILURES =================================== _________ AOTInductorTestABICompatibleGpu.test_assert_tensor_meta_xpu __________ Traceback (most recent call last): File "/var/lib/jenkins/pytorch/test/inductor/test_torchinductor.py", line 12376, in new_test return value(self) File "/var/lib/jenkins/pytorch/test/inductor/test_aot_inductor.py", line 4252, in test_assert_tensor_meta self.check_model( File "/var/lib/jenkins/pytorch/test/inductor/test_aot_inductor_utils.py", line 185, in check_model actual = AOTIRunnerUtil.run( File "/var/lib/jenkins/pytorch/test/inductor/test_aot_inductor_utils.py", line 137, in run optimized = AOTIRunnerUtil.load(device, so_path) File "/var/lib/jenkins/pytorch/test/inductor/test_aot_inductor_utils.py", line 119, in load return torch._export.aot_load(so_path, device) File "/opt/conda/envs/py_3.9/lib/python3.9/site-packages/torch/_export/__init__.py", line 167, in aot_load runner = torch._C._aoti.AOTIModelContainerRunnerXpu(so_path, 1, device) # type: ignore[assignment, call-arg] RuntimeError: create_func_( &container_handle_, num_models, device_str.c_str(), cubin_dir.empty() ? nullptr : cubin_dir.c_str()) API call failed at /var/lib/jenkins/workspace/torch/csrc/inductor/aoti_runner/model_container_runner.cpp, line 81 To execute this test, run the following from the base repo dir: python test/inductor/test_aot_inductor.py AOTInductorTestABICompatibleGpu.test_assert_tensor_meta_xpu This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0 ``` #### The root cause analysis: The case raised runtime error at: https://github.com/pytorch/pytorch/blob/00ffeca1b1fe753571412778996fe78deef49059/torch/csrc/inductor/aoti_runtime/model.h#L104-L109 here it should go to the USE_XPU part but actually not. Because the model for `toch.compile` is not set to XPU. The model in newly added test case: https://github.com/pytorch/pytorch/blob/00ffeca1b1fe753571412778996fe78deef49059/test/inductor/test_aot_inductor.py#L4237-L4257 In the `check_model`, it only set the model to `xpu`, and input tensors are not converted to `xpu`. Since there is no model internal tensor, `torch.compile` can not find any `xpu` tensor , so it's still a cpu model. Except for set the model to device, We should also set the input tensors to corresponding device too. ### Versions PyTorch version: 2.7.0a0+git225a10f Is debug build: False CUDA used to build PyTorch: None ROCM used to build PyTorch: N/A OS: Ubuntu 22.04.5 LTS (x86_64) GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 Clang version: Could not collect CMake version: version 3.31.2 Libc version: glibc-2.35 Python version: 3.10.15 | packaged by conda-forge | (main, Oct 16 2024, 01:24:24) [GCC 13.3.0] (64-bit runtime) Python platform: Linux-5.15.47+prerelease24.6.13-x86_64-with-glibc2.35 Is CUDA available: False CUDA runtime version: No CUDA CUDA_MODULE_LOADING set to: N/A GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True cc @gujinghui @EikanWang @fengyuan14 @guangyey
triaged,module: xpu
low
Critical
2,800,837,437
neovim
Roadmap to Array/Dict options
## Background: Evolving Plans for Array/Dict Options One of the primary goals of #25672 was to provide a clear path to Array and Dictionary option types. Much of the initial plan has changed. At first, the plan was to add multi-type options, options that would support multiple types, and then add Array/Dict typing to array-like or dict-like string options. A discussion in Matrix chat, where the conclusion was that options should have a single, canonical type, ruled out this approach. This decision meant that array-like or dict-like string options have to be converted into Array/Dict options internally. They would be translated to and from strings in interfaces where backwards compatibility is needed. While this approach might work, it introduces a new issues: a lack of sentinel values. ## Challenges with Backwards Compatibility and Sentinel Values Typically, global-local options have some sort of sentinel value to indicate an unset local value, which indicates to Neovim that the global value should be used instead. For number options (like `undolevels`), we use arbitrary values like `123456`, for boolean options (currently only `autoread`), we use `-1`, for string options we use an empty string (`""`). It is worth noting that using empty string as a sentinel value for global-local string options leads to its own problem where we can't use a literal empty string as option value for global-local string options such as `winbar`. This manifests itself in issues such as #18660. If we add Array/Dict options, this would mean we need a sentinel value for those options as well. An empty array or empty dict may not make much sense in that regard, because it'd mean a literal empty array or empty dict would not be usable as an option value, much like what is currently the case for string options. ## Proposed solution: Redesigning option scopes With the option scope redesign proposed in #29314, this would change. Because redesigning option scopes would allow us to instead use a boolean flag for each scope of an option, which would simply indicate if the option value is set at that scope or not. This forgoes the need for sentinel values entirely and solves the issue for both string and future Array/Dict options. However, such a refactor is quite expensive and time-consuming to do, and introduces the risk for some breaking changes. ## Choosing a path forward This dilemma brings us to an important crossroads, we could either: (a) Ignore the scope refactors and just implement Array/Dict options without them while setting some arbitrary sentinel value. This is the fastest way to achieve Array/Dict options but has the highest probability of introducing future baggage in terms of backwards compatibility, as well as a host of other issues relating to not being able to set an Array/Dict option to specific values. (b) Do the scope refactors (which, once again, is very time-consuming and has the potential for breaking changes) before adding new option types. This ensures that sentinel values are unnecessary and has the best future prospects, but requires a substantial amount of work to be done beforehand.
needs:discussion,complexity:high,options
low
Minor
2,800,841,969
godot
Enum autocomplete in match is not in enum value order
### Tested versions Reproducible in v4.4.beta1.official [d33da79d3] ### System information Godot v4.4.beta1 - Windows 10 (build 19045) - Multi-window, 3 monitors - Vulkan (Forward+) - dedicated GeForce GTX 1050 - Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz (12 threads) ### Issue description **Description**: When using an Enum in a match statement, autocomplete for each case shows enum in order of alphabetical name, along with other properties. **Expected**: To have same behavior when autocomplete an enum elsewhere, it shows the enum names first, sorted in order of enum value. **What happens**: Autocomplete shows all properties and methods of the enum that can be autocompleted. Mixed in with the result are the enum entry names, but in alphabetical order, not the numeric value order. ### Steps to reproduce **To reproduce**: - create a enum where alphabetical sorting would be different than numeric. Example: var TestEnum : Enum {Z : 100, B: 200, P : 500, A : 999}. - Create a match statement on a variable of that enum type, like var aa : TestEnum match aa: TestEnum. When you type "." to get the autocomplete, instead of seeing "Z, B, P, A", you will see "A, B, P, Z". Compare to: if aa == TestEnum. The autocomplete will properly show Z, B, P, A ### Minimal reproduction project (MRP) [mrp-enum-match.zip](https://github.com/user-attachments/files/18485791/mrp-enum-match.zip)
enhancement,topic:gdscript,topic:editor,needs testing
low
Minor
2,800,854,692
react
Bug:
Bug Report: Blinking Form Inputs Summary: The form inputs on the React state management tutorial page (https://react.dev/learn/state-a-components-memory) are blinking even when the browser is in incognito mode. Steps to Reproduce: Open the link: https://react.dev/learn/state-a-components-memory2. Navigate to Challenge 2 of 4: Fix stuck form inputs2. Enter incognito mode in your browser. Observe the form inputs. Expected Behavior: The form inputs should not blink and should remain stable regardless of the browser mode. Actual Behavior: The form inputs are blinking continuously, which can be distracting and may affect the user experience.
Status: Unconfirmed
low
Critical
2,800,862,397
godot
SCONS: Visual studio project generation is hardcoded for VS2022 MSVC build tools
### Tested versions - Reproducible in 4.4.beta.1 ### System information Windows 10 ### Issue description Using the SCONS command `scons platform=windows vsproj=yes dev_build=yes` To create the Visual Studio project will always create the project using **PlatformToolset v143**, which is the one used for **VS2022**. Right now, the [docs says it supports 2019](https://docs.godotengine.org/en/stable/contributing/development/compiling/compiling_for_windows.html) so I think the project generation should work with that. I **only have VS2019 installed** in my system (Windows 10), and it generates using build toolset 143, which means it can't build unless I manually change the .vsproj file. (which is what I did last year, but it skipped my mind to report it) The platform toolset version seems to be hard-coded since the introduction of https://github.com/godotengine/godot/pull/84885 Not sure if it worked before or not. https://github.com/godotengine/godot/blob/1b7b009674e05b566be11a5377b935f5d3d6c0ee/misc/msvs/vcxproj.template#L14-L21 I'm investigating SCONS methods.py to see if there is anything there to check for the msvc version. At some point there, something calls `find_visual_c_batch_file`, which IS getting my correct MSVC version. `msvc_version = get_default_version(env)` which gets 14.2 (that is one of the v142 versions) Looking at the vsproj creation, it doesn't try to detect the msvc version. It just uses the template file there. So this is indeed hardcoded. https://github.com/godotengine/godot/blob/1b7b009674e05b566be11a5377b935f5d3d6c0ee/methods.py#L1383-L1393 ### Steps to reproduce In a system with only VS2019 installed, run `scons platform=windows vsproj=yes dev_build=yes` **Expected:** A working visual studio solution created **Result:** : Can't compile Godot project out-of-the-box `F:\Godot\Godot Source\godot\godot.vcxproj : warning : The build tools for v143 cannot be found. Install v143 to build using the v143 build tools.` Needs to manually change .vsproj file to use build tools v142 for it to work. Which can cause a new user with not much experience some problems. ### Minimal reproduction project (MRP) (Does not apply)
enhancement,platform:windows,discussion,topic:buildsystem
low
Minor
2,800,864,757
flutter
Native folders (.android, .ios, etc.) are not created for add-to-app module when run "pub get" in workspace
Native folders (.android, .ios, etc.) are not created for add-to-app module when run "pub get" in workspace. ### Steps to reproduce 1. `git clone [email protected]:mit-73/flutter_workspace_bug.git` 2. `cd flutter_workspace_bug` 3. run `flutter pub get` in root folder 4. run `cd module/.ios` or `cd module/.android` ### Expected results Folders have appeared and you can navigate to them. ### Actual results We get `cd: no such file or directory: module/.ios` or `cd: no such file or directory: module/.android` ### Code sample https://github.com/mit-73/flutter_workspace_bug ### Screenshots or Video _No response_ ### Logs _No response_ ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [โœ“] Flutter (Channel stable, 3.27.2, on macOS 14.2.1 23C71 darwin-arm64, locale ru-RU) โ€ข Flutter version 3.27.2 on channel stable at /Users/itmiftah10/SDK/flutter/versions/3.27.2 โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision 68415ad1d9 (8 days ago), 2025-01-13 10:22:03 -0800 โ€ข Engine revision e672b006cb โ€ข Dart version 3.6.1 โ€ข DevTools version 2.40.2 [โœ“] Android toolchain - develop for Android devices (Android SDK version 33.0.2) โ€ข Android SDK at /Users/itmiftah10/SDK/android_studio โ€ข Platform android-35, build-tools 33.0.2 โ€ข ANDROID_HOME = /Users/itmiftah10/SDK/android_studio โ€ข Java binary at: /Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java โ€ข Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231) โ€ข All Android licenses accepted. [โœ“] Xcode - develop for iOS and macOS (Xcode 15.2) โ€ข Xcode at /Applications/Xcode.app/Contents/Developer โ€ข Build 15C500b โ€ข CocoaPods version 1.15.2 [โœ“] Chrome - develop for the web โ€ข Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [โœ“] Android Studio (version 2022.3) โ€ข Android Studio at /Applications/Android Studio.app/Contents โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 17.0.6+0-17.0.6b829.9-10027231) [โœ“] VS Code (version 1.96.4) โ€ข VS Code at /Applications/Visual Studio Code.app/Contents โ€ข Flutter extension version 3.102.0 [โœ“] Connected device (1 available) โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 131.0.6778.70 [โœ“] Network resources โ€ข All expected network resources are available. โ€ข No issues found! ``` </details>
tool,a: existing-apps,has reproducible steps,P2,team-tool,triaged-tool,found in release: 3.27,found in release: 3.28
low
Critical
2,800,881,248
PowerToys
Mouse Pointer crosshairs: Add the angle adjustment function for the indicator line
### Description of the new feature / enhancement The x-shaped indicator does not block the viewใ€‚ ```c \ / \ / \ / \ / \ / \ / \ / / / \ / \ / \ / \ / \ / \ / \ ``` ### Scenario when this would be used? same as Scenarios for Mouse Pointer crosshairs ### Supporting information _No response_
Needs-Triage
low
Minor
2,800,890,099
pytorch
PyObject preservation does not prevent weakrefs being cleared by Python garbage collector
### ๐Ÿ› Describe the bug If a dead cycle holds the last reference to a resurrectable Tensor, gc will clear its weakrefs. One implication of this interaction is that entries can spuriously vanish from WeakTensorKeyDictionary, which is used in various places across the code base. Repro: ```python import gc; gc.disable() a = torch.tensor(1.) param = torch.tensor(2., requires_grad=True) param.grad = a b = [a] b.append(b) # create a cycle def callback(x): print("callback called!") a_ref = weakref.ref(a, callback) del a, b gc.collect() print("done collecting") assert a_ref() is None ``` https://github.com/pytorch/pytorch/issues/75932 is a good read for more background; this issue is the same as that one except we also check weakrefs. The TLDR: Today, PyObject preservation logic already has special handling for interaction with Python's garbage collector in two ways: 1) [In the original PR to add PyObject preservation](https://github.com/pytorch/pytorch/pull/56017), @ezyang and @albanD foresaw that if gc detected a unreachable cycle that included a ressurectable Tensor, `tp_clear` may be called on it, preventing a clean resurrection. The fix here is to tell `tp_traverse` to not traverse its members in the case we are resurrectable (thus preventing any cycle involving the resurrectable Tensor from being detected). 2) Later @Chillee [investigated](https://github.com/pytorch/pytorch/issues/75932) a separate case where the ressurectable Tensor is not directly part of the cycle, but is instead kept alive by a reference from a dead cycle. The `tp_traverse` fix did not address this because `tp_clear` will be called on all unreachable objects whether they are directly part of the cycle or not. The resolution here is to bail from `tp_clear` if the Tensor is resurrectable. The `tp_clear` fix, however, does not prevent weakrefs from already being cleared because gc clears weakrefs before calling `tp_clear`! https://github.com/python/cpython/blob/e65a1eb93ae35f9fbab1508606e3fbc89123629f/Python/gc.c#L1725-L1744 https://github.com/python/cpython/blob/main/InternalDocs/garbage_collector.md#destroying-unreachable-objects ### Versions main cc @albanD
triaged,module: python frontend
low
Critical
2,800,893,899
go
cmd/compile: avoid allocs by better tracking of literals for interface conversions and make
In this example, converting a concrete value to an interface does not cause the integer value to be heap allocated: ```go fmt.Println(1000) ``` For that example, escape analysis currently marks the value as escaping to the heap due to the interface conversion and the call to fmt.Println (and all that happens inside Println), but walk later recognizes the value does not need to be heap allocated. On the other hand, the integer value in the following interface conversion does get heap allocated because the optimization in walk is thwarted by the literal getting assigned to a local variable prior to use in the interface conversion: ```go v := 1000 fmt.Println(v) ``` We should be able to recognize this and get a similar result with those two cases. (This would be a follow up to Josh's work in #18704). Separately, this slice can be stack allocated with a constant size (if it doesn't otherwise escape): ```go s := make([]int, 100) ``` But this slice is heap allocated because escape analysis treats it as having a non-constant size: ```go count := 100 s := make([]int, count) ``` We also should be able to recognize this. The above scenarios might happen in a single function, but can also be the result of inlining one function into another. We can hopefully handle this early in the compiler after inlining and devirtualization but before finalizing escape analysis results. Part of the solution can be using the new-ish ir.ReassignOracle. --------------- I have a rough proof-of-concept that seems to hopefully handle cases similar to the ones above for basic literals and I plan to send a couple of CLs. The approach likely could be extended further. (I noticed this a while ago when working on #62653; there is some overlap with cases handled between that issue and this issue, though #62653 would be the broader solution for interface conversions).
compiler/runtime,BugReport
low
Minor
2,800,905,473
vscode
Inline git blame cannot be deactivated
<!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- ๐Ÿ•ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- ๐Ÿ”Ž Search existing issues to avoid creating duplicates. --> <!-- ๐Ÿงช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- ๐Ÿ’ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- ๐Ÿ”ง Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Did not try yet <!-- ๐Ÿช“ If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- ๐Ÿ“ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> Version: ``` Version: 1.96.0 (Universal) Commit: 138f619c86f1199955d53b4166bef66ef252935c Date: 2024-12-11T02:29:09.626Z (1 mo ago) Electron: 32.2.6 ElectronBuildId: 10629634 Chromium: 128.0.6613.186 Node.js: 20.18.1 V8: 12.8.374.38-electron.0 OS: Darwin arm64 23.6.0 ``` Steps to Reproduce: 1. Change user settings: `"git.blame.editorDecoration.enabled": false` 2. Reload window 3. Inline blame is still there Note that I'm also using gitlens and want to use the one from gitlens instead of this one. I like the Popup from gitlens better when hovering. Since it displays both now, I want to deactivate the native one.
info-needed,git
low
Critical
2,800,945,285
godot
Possible memory leak in gdextension.cpp when method names are duplicated
### Tested versions nightly ### System information linux ### Issue description While working on something unrelated, I got a memcheck failure in CI: https://github.com/godot-rust/gdext/actions/runs/12881698201/job/35912681146#step:3:1706 <details> ``` ================================================================= ==3088==ERROR: LeakSanitizer: detected memory leaks Direct leak of 232 byte(s) in 1 object(s) allocated from: #0 0x55ba3602b62e in malloc (/home/runner/work/_temp/godot_bin/godot.linuxbsd.editor.dev.x86_64.llvm.san+0x21c9c62e) (BuildId: 874db2a84ccfa9b3) #1 0x55ba55e654e6 in Memory::alloc_static(unsigned long, bool) /home/runner/work/godot4-nightly/godot4-nightly/core/os/memory.cpp:106:14 #2 0x55ba55e65362 in operator new(unsigned long, char const*) /home/runner/work/godot4-nightly/godot4-nightly/core/os/memory.cpp:39:9 #3 0x55ba58953974 in GDExtension::_register_extension_class_method(void*, void const*, GDExtensionClassMethodInfo const*) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:509:12 #4 0x7f5c738209e0 in godot_core::registry::method::ClassMethodInfo::register_nonvirtual_class_method::h6f44d6b7c80457d4 /home/runner/work/gdext/gdext/godot-core/src/registry/method.rs:157:13 #5 0x7f5c7381fff8 in godot_core::registry::method::ClassMethodInfo::register_extension_class_method::hfb75fa1a2544ea5f /home/runner/work/gdext/gdext/godot-core/src/registry/method.rs:147:13 #6 0x7f5c730ae1e2 in itest::register_tests::func_test::_::__init::__inner_init::_$u7b$$u7b$closure$u7d$$u7d$::h9ae97532f88693d3 /home/runner/work/gdext/gdext/itest/rust/src/register_tests/func_test.rs:79:1 #7 0x7f5c72dbfffd in core::ops::function::FnOnce::call_once::h0a8edd5c08646abf /rustc/f3d1d47fd84dfcf7f513be1dbad356e74c8f3b2b/library/core/src/ops/function.rs:250:5 #8 0x7f5c72c230a2 in godot_core::registry::callbacks::register_user_methods_constants::ha0604185de96699d /home/runner/work/gdext/gdext/godot-core/src/registry/callbacks.rs:392:5 #9 0x7f5c7381756d in godot_core::registry::class::auto_register_classes::h71cfbbdffdad7470 /home/runner/work/gdext/gdext/godot-core/src/registry/class.rs:228:9 #10 0x7f5c7386886c in godot_core::init::gdext_on_level_init::h1d4172dd01e950e9 /home/runner/work/gdext/gdext/godot-core/src/init/mod.rs:161:5 #11 0x7f5c72fd3a5a in godot_core::init::ffi_initialize_layer::_$u7b$$u7b$closure$u7d$$u7d$::hdf873678b0f13b97 /home/runner/work/gdext/gdext/godot-core/src/init/mod.rs:107:9 #12 0x7f5c71290641 in godot_core::private::handle_panic_with_print::h4b774d0a828afef5 /home/runner/work/gdext/gdext/godot-core/src/private.rs:377:17 #13 0x7f5c70cf8878 in godot_core::private::handle_panic::h129b9f0e49e1359a /home/runner/work/gdext/gdext/godot-core/src/private.rs:275:5 #14 0x55ba5895bbdd in GDExtension::initialize_library(GDExtension::InitializationLevel) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:745:2 #15 0x55ba589f5fb1 in GDExtensionManager::initialize_extensions(GDExtension::InitializationLevel) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension_manager.cpp:228:12 #16 0x55ba364c1f2b in Main::setup2(bool) /home/runner/work/godot4-nightly/godot4-nightly/main/main.cpp:3381:40 #17 0x55ba364aed45 in Main::setup(char const*, int, char**, bool) /home/runner/work/godot4-nightly/godot4-nightly/main/main.cpp:2676:14 #18 0x55ba36068f93 in main /home/runner/work/godot4-nightly/godot4-nightly/platform/linuxbsd/godot_linuxbsd.cpp:74:14 #19 0x7f5c7be29d8f (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: 490fef8403240c91833978d494d39e537409b92e) Direct leak of 232 byte(s) in 1 object(s) allocated from: #0 0x55ba3602b62e in malloc (/home/runner/work/_temp/godot_bin/godot.linuxbsd.editor.dev.x86_64.llvm.san+0x21c9c62e) (BuildId: 874db2a84ccfa9b3) #1 0x55ba55e654e6 in Memory::alloc_static(unsigned long, bool) /home/runner/work/godot4-nightly/godot4-nightly/core/os/memory.cpp:106:14 #2 0x55ba55e65362 in operator new(unsigned long, char const*) /home/runner/work/godot4-nightly/godot4-nightly/core/os/memory.cpp:39:9 #3 0x55ba58953974 in GDExtension::_register_extension_class_method(void*, void const*, GDExtensionClassMethodInfo const*) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:509:12 #4 0x7f5c738209e0 in godot_core::registry::method::ClassMethodInfo::register_nonvirtual_class_method::h6f44d6b7c80457d4 /home/runner/work/gdext/gdext/godot-core/src/registry/method.rs:157:13 #5 0x7f5c7381fff8 in godot_core::registry::method::ClassMethodInfo::register_extension_class_method::hfb75fa1a2544ea5f /home/runner/work/gdext/gdext/godot-core/src/registry/method.rs:147:13 #6 0x7f5c730ae00f in itest::register_tests::func_test::_::__init::__inner_init::_$u7b$$u7b$closure$u7d$$u7d$::h9ae97532f88693d3 /home/runner/work/gdext/gdext/itest/rust/src/register_tests/func_test.rs:79:1 #7 0x7f5c72dbfffd in core::ops::function::FnOnce::call_once::h0a8edd5c08646abf /rustc/f3d1d47fd84dfcf7f513be1dbad356e74c8f3b2b/library/core/src/ops/function.rs:250:5 #8 0x7f5c72c230a2 in godot_core::registry::callbacks::register_user_methods_constants::ha0604185de96699d /home/runner/work/gdext/gdext/godot-core/src/registry/callbacks.rs:392:5 #9 0x7f5c7381756d in godot_core::registry::class::auto_register_classes::h71cfbbdffdad7470 /home/runner/work/gdext/gdext/godot-core/src/registry/class.rs:228:9 #10 0x7f5c7386886c in godot_core::init::gdext_on_level_init::h1d4172dd01e950e9 /home/runner/work/gdext/gdext/godot-core/src/init/mod.rs:161:5 #11 0x7f5c72fd3a5a in godot_core::init::ffi_initialize_layer::_$u7b$$u7b$closure$u7d$$u7d$::hdf873678b0f13b97 /home/runner/work/gdext/gdext/godot-core/src/init/mod.rs:107:9 #12 0x7f5c71290641 in godot_core::private::handle_panic_with_print::h4b774d0a828afef5 /home/runner/work/gdext/gdext/godot-core/src/private.rs:377:17 #13 0x7f5c70cf8878 in godot_core::private::handle_panic::h129b9f0e49e1359a /home/runner/work/gdext/gdext/godot-core/src/private.rs:275:5 #14 0x55ba5895bbdd in GDExtension::initialize_library(GDExtension::InitializationLevel) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:745:2 #15 0x55ba589f5fb1 in GDExtensionManager::initialize_extensions(GDExtension::InitializationLevel) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension_manager.cpp:228:12 #16 0x55ba364c1f2b in Main::setup2(bool) /home/runner/work/godot4-nightly/godot4-nightly/main/main.cpp:3381:40 #17 0x55ba364aed45 in Main::setup(char const*, int, char**, bool) /home/runner/work/godot4-nightly/godot4-nightly/main/main.cpp:2676:14 #18 0x55ba36068f93 in main /home/runner/work/godot4-nightly/godot4-nightly/platform/linuxbsd/godot_linuxbsd.cpp:74:14 #19 0x7f5c7be29d8f (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: 490fef8403240c91833978d494d39e537409b92e) Indirect leak of 20 byte(s) in 1 object(s) allocated from: #0 0x55ba3602b62e in malloc (/home/runner/work/_temp/godot_bin/godot.linuxbsd.editor.dev.x86_64.llvm.san+0x21c9c62e) (BuildId: 874db2a84ccfa9b3) #1 0x55ba55e654e6 in Memory::alloc_static(unsigned long, bool) /home/runner/work/godot4-nightly/godot4-nightly/core/os/memory.cpp:106:14 #2 0x55ba3957bf2d in Variant::Type* memnew_arr_template<Variant::Type>(unsigned long) /home/runner/work/godot4-nightly/godot4-nightly/./core/os/memory.h:180:28 #3 0x55ba58b24fc5 in MethodBind::_generate_argument_types(int) /home/runner/work/godot4-nightly/godot4-nightly/core/object/method_bind.cpp:104:24 #4 0x55ba5898964e in GDExtensionMethodBind::update(GDExtensionClassMethodInfo const*) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:223:3 #5 0x55ba5896bf65 in GDExtensionMethodBind::GDExtensionMethodBind(GDExtensionClassMethodInfo const*) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:237:3 #6 0x55ba589539b7 in GDExtension::_register_extension_class_method(void*, void const*, GDExtensionClassMethodInfo const*) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:509:12 #7 0x7f5c738209e0 in godot_core::registry::method::ClassMethodInfo::register_nonvirtual_class_method::h6f44d6b7c80457d4 /home/runner/work/gdext/gdext/godot-core/src/registry/method.rs:157:13 #8 0x7f5c7381fff8 in godot_core::registry::method::ClassMethodInfo::register_extension_class_method::hfb75fa1a2544ea5f /home/runner/work/gdext/gdext/godot-core/src/registry/method.rs:147:13 #9 0x7f5c730ae1e2 in itest::register_tests::func_test::_::__init::__inner_init::_$u7b$$u7b$closure$u7d$$u7d$::h9ae97532f88693d3 /home/runner/work/gdext/gdext/itest/rust/src/register_tests/func_test.rs:79:1 #10 0x7f5c72dbfffd in core::ops::function::FnOnce::call_once::h0a8edd5c08646abf /rustc/f3d1d47fd84dfcf7f513be1dbad356e74c8f3b2b/library/core/src/ops/function.rs:250:5 #11 0x7f5c72c230a2 in godot_core::registry::callbacks::register_user_methods_constants::ha0604185de96699d /home/runner/work/gdext/gdext/godot-core/src/registry/callbacks.rs:392:5 #12 0x7f5c7381756d in godot_core::registry::class::auto_register_classes::h71cfbbdffdad7470 /home/runner/work/gdext/gdext/godot-core/src/registry/class.rs:228:9 #13 0x7f5c7386886c in godot_core::init::gdext_on_level_init::h1d4172dd01e950e9 /home/runner/work/gdext/gdext/godot-core/src/init/mod.rs:161:5 #14 0x7f5c72fd3a5a in godot_core::init::ffi_initialize_layer::_$u7b$$u7b$closure$u7d$$u7d$::hdf873678b0f13b97 /home/runner/work/gdext/gdext/godot-core/src/init/mod.rs:107:9 #15 0x7f5c71290641 in godot_core::private::handle_panic_with_print::h4b774d0a828afef5 /home/runner/work/gdext/gdext/godot-core/src/private.rs:377:17 #16 0x7f5c70cf8878 in godot_core::private::handle_panic::h129b9f0e49e1359a /home/runner/work/gdext/gdext/godot-core/src/private.rs:275:5 #17 0x55ba5895bbdd in GDExtension::initialize_library(GDExtension::InitializationLevel) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:745:2 #18 0x55ba589f5fb1 in GDExtensionManager::initialize_extensions(GDExtension::InitializationLevel) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension_manager.cpp:228:12 #19 0x55ba364c1f2b in Main::setup2(bool) /home/runner/work/godot4-nightly/godot4-nightly/main/main.cpp:3381:40 #20 0x55ba364aed45 in Main::setup(char const*, int, char**, bool) /home/runner/work/godot4-nightly/godot4-nightly/main/main.cpp:2676:14 #21 0x55ba36068f93 in main /home/runner/work/godot4-nightly/godot4-nightly/platform/linuxbsd/godot_linuxbsd.cpp:74:14 #22 0x7f5c7be29d8f (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: 490fef8403240c91833978d494d39e537409b92e) Indirect leak of 20 byte(s) in 1 object(s) allocated from: #0 0x55ba3602b62e in malloc (/home/runner/work/_temp/godot_bin/godot.linuxbsd.editor.dev.x86_64.llvm.san+0x21c9c62e) (BuildId: 874db2a84ccfa9b3) #1 0x55ba55e654e6 in Memory::alloc_static(unsigned long, bool) /home/runner/work/godot4-nightly/godot4-nightly/core/os/memory.cpp:106:14 #2 0x55ba3957bf2d in Variant::Type* memnew_arr_template<Variant::Type>(unsigned long) /home/runner/work/godot4-nightly/godot4-nightly/./core/os/memory.h:180:28 #3 0x55ba58b24fc5 in MethodBind::_generate_argument_types(int) /home/runner/work/godot4-nightly/godot4-nightly/core/object/method_bind.cpp:104:24 #4 0x55ba5898964e in GDExtensionMethodBind::update(GDExtensionClassMethodInfo const*) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:223:3 #5 0x55ba5896bf65 in GDExtensionMethodBind::GDExtensionMethodBind(GDExtensionClassMethodInfo const*) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:237:3 #6 0x55ba589539b7 in GDExtension::_register_extension_class_method(void*, void const*, GDExtensionClassMethodInfo const*) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:509:12 #7 0x7f5c738209e0 in godot_core::registry::method::ClassMethodInfo::register_nonvirtual_class_method::h6f44d6b7c80457d4 /home/runner/work/gdext/gdext/godot-core/src/registry/method.rs:157:13 #8 0x7f5c7381fff8 in godot_core::registry::method::ClassMethodInfo::register_extension_class_method::hfb75fa1a2544ea5f /home/runner/work/gdext/gdext/godot-core/src/registry/method.rs:147:13 #9 0x7f5c730ae00f in itest::register_tests::func_test::_::__init::__inner_init::_$u7b$$u7b$closure$u7d$$u7d$::h9ae97532f88693d3 /home/runner/work/gdext/gdext/itest/rust/src/register_tests/func_test.rs:79:1 #10 0x7f5c72dbfffd in core::ops::function::FnOnce::call_once::h0a8edd5c08646abf /rustc/f3d1d47fd84dfcf7f513be1dbad356e74c8f3b2b/library/core/src/ops/function.rs:250:5 #11 0x7f5c72c230a2 in godot_core::registry::callbacks::register_user_methods_constants::ha0604185de96699d /home/runner/work/gdext/gdext/godot-core/src/registry/callbacks.rs:392:5 #12 0x7f5c738[1756](https://github.com/godot-rust/gdext/actions/runs/12881698201/job/35912681146#step:3:1772)d in godot_core::registry::class::auto_register_classes::h71cfbbdffdad7470 /home/runner/work/gdext/gdext/godot-core/src/registry/class.rs:228:9 #13 0x7f5c7386886c in godot_core::init::gdext_on_level_init::h1d4172dd01e950e9 /home/runner/work/gdext/gdext/godot-core/src/init/mod.rs:161:5 #14 0x7f5c72fd3a5a in godot_core::init::ffi_initialize_layer::_$u7b$$u7b$closure$u7d$$u7d$::hdf873678b0f13b97 /home/runner/work/gdext/gdext/godot-core/src/init/mod.rs:107:9 #15 0x7f5c71290641 in godot_core::private::handle_panic_with_print::h4b774d0a828afef5 /home/runner/work/gdext/gdext/godot-core/src/private.rs:377:17 #16 0x7f5c70cf8878 in godot_core::private::handle_panic::h129b9f0e49e1359a /home/runner/work/gdext/gdext/godot-core/src/private.rs:275:5 #17 0x55ba5895bbdd in GDExtension::initialize_library(GDExtension::InitializationLevel) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension.cpp:745:2 #18 0x55ba589f5fb1 in GDExtensionManager::initialize_extensions(GDExtension::InitializationLevel) /home/runner/work/godot4-nightly/godot4-nightly/core/extension/gdextension_manager.cpp:228:12 #19 0x55ba364c1f2b in Main::setup2(bool) /home/runner/work/godot4-nightly/godot4-nightly/main/main.cpp:3381:40 #20 0x55ba364aed45 in Main::setup(char const*, int, char**, bool) /home/runner/work/godot4-nightly/godot4-nightly/main/main.cpp:2676:14 #21 0x55ba36068f93 in main /home/runner/work/godot4-nightly/godot4-nightly/platform/linuxbsd/godot_linuxbsd.cpp:74:14 #22 0x7f5c7be29d8f (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) (BuildId: 490fef8403240c91833978d494d39e537409b92e) SUMMARY: AddressSanitizer: 504 byte(s) leaked in 4 allocation(s). ``` </details> Looking into that error, ``method`` is allocated in L509 and passed into ``ClassDB::bind_method_custom``. https://github.com/godotengine/godot/blob/1b7b009674e05b566be11a5377b935f5d3d6c0ee/core/extension/gdextension.cpp#L508-L520 If, for some reason, a method with the same name was already registered, it returns an error: https://github.com/godotengine/godot/blob/1b7b009674e05b566be11a5377b935f5d3d6c0ee/core/object/class_db.cpp#L1879-L1882 The fix might be as simple as freeing ``p_method`` before returning. ### Steps to reproduce none ### Minimal reproduction project (MRP) none
bug,needs testing,topic:gdextension
low
Critical
2,800,947,097
stable-diffusion-webui
[Feature Request]: Hide specific directory buttons when viewing extra networks in Dirs view style
### Is there an existing issue for this? - [x] I have searched the existing issues and checked the recent builds/commits ### What would your feature do ? I would like there to be a setting that lets you select available directories in your extra networks tab to hide individually. I like to keep my LoRAs organized in folders by their supported checkpoints and categories. For instance, my checkpoints are SDXL, Pony, and Illustrious. Then within those folders I have Characters (Male, Female, Non-Human), Styles, and Concepts. Then I have even more specific folders within those. The result is I get every possible directory as a button I can click to filter the cards. There's the feature that hides folders and models from being shown if the folder starts with a period, but it hides _all_ the subfolders and models within that folder. I know I could simply have fewer folders to reduce the amount of directory buttons, but I think the ability to hide specific ones to have a personalized list would be a good feature overall. Alongside this, I think being able to save presets of hidden buttons would be great when going between different checkpoint versions. ### Proposed workflow 1. Go to .... 2. Press .... 3. ... ### Additional information _No response_
enhancement
low
Minor
2,800,969,750
kubernetes
The pod is in pending state and cannot be scheduled.
### What happened? https://github.com/kubernetes/kubernetes/blob/e69a5ed9b3764347c485cd4854149f3174d4bd95/pkg/scheduler/framework/plugins/volumebinding/binder.go#L471-L474 During pod scheduling, if the csi does not create a PV in time due to certain reasons, an error is reported due to timeout. However, the annotation volume.kubernetes.io/selected-node of the PVC is not deleted, and local scheduling fails. The scheduler starts to schedule other pods. If the current deployment has pod anti-affinity, it cannot be scheduled to the same node. When the second copy is scheduled, the csi is normal. Assume that the copy is scheduled to the master1 node. At the same time, the csi creates the PV of the first replica pod corresponding to the deployment on the master1 node. When the first pod is scheduled again, the first pod cannot be scheduled and remains in the pending state due to pod anti-affinity. Why is the PVC of the pod that fails to be scheduled not considered during pod scheduling? ### What did you expect to happen? The pod should be rescheduled successfully. ### How can we reproduce it (as minimally and precisely as possible)? Simulate a fault that the csi cannot work properly. When BindPodVolumes times out, restore the csi. ### Anything else we need to know? _No response_ ### Kubernetes version <details> ```console $ kubectl version # paste output here ``` 1.31 </details> ### Cloud provider <details> </details> ### OS version <details> ```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ``` </details> ### Install tools <details> </details> ### Container runtime (CRI) and version (if applicable) <details> </details> ### Related plugins (CNI, CSI, ...) and versions (if applicable) <details> </details>
kind/bug,sig/scheduling,needs-triage
low
Critical
2,800,992,352
material-ui
[Autocomplete] Custom slot props types
### Steps to reproduce Steps: 1. Open this link to live example: https://stackblitz.com/edit/react-wgjewylg?file=Demo.tsx 2. Check the typescript error on the `listbox` slot prop: `Types of parameters 'props' and 'props' are incompatible. Property 'a' is missing in type 'HTMLAttributes<HTMLElement>' but required in type 'CustomListboxProps'.` ### Current behavior I cannot define or extend the type of the listbox (and other) slot props when passing a custom component. For the Paper and Popper there are two interfaces `AutocompletePaperSlotPropsOverrides` and `AutocompletePopperSlotPropsOverrides` that could be redeclared but that is less flexible. ### Expected behavior I can use custom slots with custom props with type safety. ### Context I want to use a TreeView in the Autocomplete component. Thus I either have to replace the paper or listbox slot. Is something like a TreeViewSelect planned at some point in the future? ### Your environment <details> <summary><code>npx @mui/envinfo</code></summary> ``` Don't forget to mention which browser you used. Output from `npx @mui/envinfo` goes here. ``` </details> **Search keywords**: autocomplete slot props
status: waiting for author,typescript,package: material-ui,component: autocomplete
low
Critical
2,800,998,264
vscode
The Bash terminal outputs an annoying line when opened
Type: <b>Bug</b> When I open the bash terminal it always prints that string: "633;EnvSingleEntry;ORIGINAL_TEMP;/tmp;4b2baa3e-3304-4425-82ad-ce5a372dfb25633;EnvSingleEntry;PATHEXT;.COM\x3b.EXE\x3b.BAT\x3b.CMD\x3b.VBS\x3b.VBE\x3b.JS\x3b.JSE\x3b.WSF\x3b.WSH\x3b.MSC\x3b.PY\x3b.PYW;4b2baa3e-3304-4425-82ad-ce5a372dfb25633;EnvSingleEntry;PSModulePath;C:\\Program Files\\WindowsPowerShell\\Modules\x3bC:\\Windows\\system32\\WindowsPowerShell\\v1.0\\Modules;4b2baa3e-3304-4425-82ad-ce5a372dfb25633;EnvSingleEntry;ORIGINAL_TEMP;/tmp;4b2baa3e-3304-4425-82ad-ce5a372dfb25633;EnvSingleEntry;PATHEXT;.COM\x3b.EXE\x3b.BAT\x3b.CMD\x3b.VBS\x3b.VBE\x3b.JS\x3b.JSE\x3b.WSF\x3b.WSH\x3b.MSC\x3b.PY\x3b.PYW;4b2baa3e-3304-4425-82ad-ce5a372dfb25633;EnvSingleEntry;PSModulePath;C:\\Program Files\\WindowsPowerShell\\Modules\x3bC:\\Windows\\system32\\WindowsPowerShell\\v1.0\\Modules;4b2baa3e-3304-4425-82ad-ce5a372dfb25" It looks like there is some issue in the shell sript: AppData\Local\Programs\Microsoft VS Code Insiders\resources\app/out/vs/workbench/contrib/terminal/common/scripts/shellIntegration-bash.sh ![Image](https://github.com/user-attachments/assets/b65e2899-7c5b-4305-96de-8193ad450064) VS Code version: Code - Insiders 1.97.0-insider (3d0aeb47a2ecfde9ff5141470b30c36d41c321d9, 2025-01-20T05:04:25.114Z) OS version: Windows_NT x64 10.0.19045 Modes: <details> <summary>System Info</summary> |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-6600 CPU @ 3.30GHz (4 x 3312)| |GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off| |Load (avg)|undefined| |Memory (System)|15.91GB (5.39GB free)| |Process Argv|--crash-reporter-id f6782a88-ad58-4a99-8c91-7424936ca9d2| |Screen Reader|no| |VM|0%| </details><details><summary>Extensions (10)</summary> Extension|Author (truncated)|Version ---|---|--- vscode-tailwindcss|bra|0.12.18 vscode-eslint|dba|3.0.10 gitlens|eam|16.2.0 vsc-material-theme|Equ|34.7.9 prettier-vscode|esb|11.0.0 color-highlight|nau|2.8.0 php-docblocker|nei|2.7.0 indent-rainbow|ode|8.3.1 vscode-versionlens|pfl|1.16.2 vscode-icons|vsc|12.10.0 (2 theme extensions excluded) </details><details> <summary>A/B Experiments</summary> ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vsc_aa:30263845 vscod805cf:30301675 vsaa593cf:30376535 py29gd2263:31024238 c4g48928:30535728 962ge761:30841072 pythonnoceb:30776497 dsvsc014:30777825 dsvsc015:30821418 pythonmypyd1:30859725 h48ei257:31000450 pythontbext0:30879054 cppperfnew:30980852 pythonait:30973460 dvdeprecation:31040973 dwnewjupyter:31046869 newcmakeconfigv2:31071590 nativerepl1:31134653 pythonrstrctxt:31093868 nativeloc1:31118317 cf971741:31144450 e80f6927:31120813 iacca1:31150324 notype1:31143044 dwcopilot:31158714 h409b430:31177054 5b1c1929:31184661 6074i472:31201624 dwoutputs:31217127 6e63a538:31218797 9064b325:31222308 ``` </details> <!-- generated by issue reporter -->
bug,important,windows,terminal-shell-git-bash
low
Critical
2,801,007,636
vscode
SCM Graph - display list of files in the commit in the graph
Type: <b>Feature Request</b> currently the source control graph does not have a file explorer view. if you have a file with a large number of changes ex. package-lock.json in a commit and you are clicking on the commit it takes a long time to open the diff view. most of the time i want to know the file names i have in the commit and then explore one or two of these file. the current implementation forces to view all file diff instead of specific files, making it slower in my opinion. my suggestion is to have a file explorer kind of view (Git Graph like approach). VS Code version: Code - Insiders 1.97.0-insider (3d0aeb47a2ecfde9ff5141470b30c36d41c321d9, 2025-01-20T05:04:25.114Z) OS version: Windows_NT x64 10.0.22621 Modes: <!-- generated by issue reporter -->
feature-request,scm
low
Major
2,801,010,381
flutter
RangeError when selecting text in SelectionArea
### Steps to reproduce 1. Select the text "Hello". 2. Use `Shift + Left Arrow` to expand the selected text towards the start. 3. After reaching the beginning of the text, pressing `Shift + Left Arrow` causes an error (**RangeError**). 4. While "Hello" is selected, click on the text in the first line (**AssertionError**). ### Expected results - The text selection stops gracefully at the beginning of the text. - No errors or unexpected behavior occur when interacting with the text on Line 1. ### Actual results - Using `Shift + Left Arrow` beyond the start of the text causes a runtime error. - Clicking on the text in the first line triggers an AssertionError. ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( primarySwatch: Colors.blue, ), home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } class MyHomePage extends StatelessWidget { const MyHomePage({super.key, required this.title}); final String title; @override Widget build(BuildContext context) { return Scaffold( appBar: AppBar( title: Text(title), ), body: const Center( child: SelectionArea( child: Column( mainAxisAlignment: MainAxisAlignment.center, children: [ Directionality( textDirection: TextDirection.ltr, child: Text('This is the first line.'), ), Directionality( textDirection: TextDirection.ltr, child: Text('hello'), ), ], ), ), ), ); } } ``` </details> ### Screenshots or Video <details open> <summary>Video demonstration</summary> https://github.com/user-attachments/assets/465ae9e0-8539-4857-a74d-4f388678b26b </details> ### Logs <details open><summary>Logs</summary> ```console โ•โ•โ•ก EXCEPTION CAUGHT BY SERVICES LIBRARY โ•žโ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ• The following IndexError was thrown while processing the key message handler: RangeError (index): Index out of range: index should be less than 1: 1 When the exception was thrown, this was the stack KeyMessage: KeyMessage([KeyDownEvent#3c2fc(physicalKey: PhysicalKeyboardKey#70050(usbHidUsage: "0x00070050", debugName: "Arrow Left"), logicalKey: LogicalKeyboardKey#7a008(keyId: "0x100000302", keyLabel: "Arrow Left", debugName: "Arrow Left"), character: null, timeStamp: 0:00:08.077599)]) โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ• Another exception was thrown: Assertion failed: file:///opt/flutter/packages/flutter/lib/src/widgets/selectable_region.dart:2807:14 ``` </details> ### Flutter Doctor output This has been tested on DartPad with Dart SDK 3.6.1 and Flutter SDK 3.27.2 (Stable Channel). However, I also encountered this issue on Windows. <details open><summary>Doctor output</summary> ```console [โˆš] Flutter (Channel master, 3.28.0-2.0.pre.38795, on Microsoft Windows [Version 10.0.22635.4800]) [6.7s] โ€ข Flutter version 3.28.0-2.0.pre.38795 on channel master โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision 79550446df (16 hours ago), 2025-01-20 19:10:34 +0330 โ€ข Engine revision 63110570da โ€ข Dart version 3.8.0 (build 3.8.0-1.0.dev) โ€ข DevTools version 2.42.0 [โˆš] Windows Version (11 Enterprise 64-bit, 23H2, 2009) [3.3s] [โˆš] Android toolchain - develop for Android devices (Android SDK version 33.0.1) [11.7s] โ€ข Platform android-35, build-tools 33.0.1 โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314) โ€ข All Android licenses accepted. [โˆš] Chrome - develop for the web [194ms] [โˆš] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.12.4) [193ms] โ€ข Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community โ€ข Visual Studio Community 2022 version 17.12.35707.178 โ€ข Windows 10 SDK version 10.0.22621.0 [โˆš] Android Studio (version 2024.1) [34ms] โ€ข Flutter plugin can be installed from: https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314) [โˆš] Connected device (3 available) [219ms] โ€ข Windows (desktop) โ€ข windows โ€ข windows-x64 โ€ข Microsoft Windows [Version 10.0.22635.4800] โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 131.0.6778.265 โ€ข Edge (web) โ€ข edge โ€ข web-javascript โ€ข Microsoft Edge 132.0.2957.111 [โˆš] Network resources [893ms] โ€ข All expected network resources are available. โ€ข No issues found! ``` </details>
framework,f: material design,has reproducible steps,f: selection,team-framework,found in release: 3.27,found in release: 3.28
low
Critical
2,801,013,507
PowerToys
Text Extractor
### Description of the new feature / enhancement We cannot extract the text of Bangla Language. Please add this facility. ### Scenario when this would be used? when it would use many MS bangla app, bangla website and Bangla image then we can not text copy as The English text. ### Supporting information _No response_
Needs-Triage
low
Minor
2,801,052,313
opencv
Wrong python type hints for imread
### System Information OpenCV python version 4.10.0.84 / Fails also on OpenCV python version 4.11.0.86 Operating System / Platform: Ubuntu 24.04 python version 3.10.14 ### Detailed description I would like to report that the function `cv2.imread` reports a return type `cv2.typing.MatLike` when according to documentation, it should report `cv2.typing.MatLike | None`. [Documentation](https://docs.opencv.org/4.10.0/d4/da8/group__imgcodecs.html#gab32ee19e22660912565f8140d0f675a8): > The function imread loads an image from the specified file and returns it. If the image cannot be read (because of missing file, improper permissions, unsupported or invalid format), the function returns an empty matrix ( [Mat::data](https://docs.opencv.org/4.10.0/d3/d63/classcv_1_1Mat.html#a4d33bed1c850265370d2af0ff02e1564)==NULL ). Note: In OpenCV for python, this translates into returning `None`. Additional notes: - Correctly reporting through the typing system that the function `cv2.imread` can return `None` in case the image cannot be read allows users to be forced through static type checkers to explicitly handle (or at least log) the case where a image can not be read. This adds value. - This issue might apply to other functions. `cv2.imdecode` is one example. ### Steps to reproduce ```python import tempfile import cv2 with tempfile.TemporaryFile() as temp_file: temp_file.write(b"Corrupted binary data. Not a image") temp_file.seek(0) image = cv2.imread(str(temp_file.name)) assert image is None ``` This code passes, showing that the type hint (no None returned) doesn't match the actual behavior. ### Issue submission checklist - [x] I report the issue, it's not a question - [x] I checked the problem with documentation, FAQ, open issues, forum.opencv.org, Stack Overflow, etc and have not found any solution - [x] I updated to the latest OpenCV version and the issue is still there - [x] There is reproducer code and related data files (videos, images, onnx, etc)
bug,category: python bindings
low
Minor
2,801,096,348
rust
Tracking Issue for `#![feature(phantom_variance_markers)]`
Feature gate: `#![feature(phantom_variance_markers)]` This is a tracking issue for phantom variance markers, which are identical to `PhantomData` but provide a self-documenting variance rather than contrived types such as `PhantomData<fn() -> T>` to indicate contravariance. ### Public API ```rust // in core::marker pub struct PhantomCovariant<T: ?Sized>(/* ... */); pub struct PhantomInvariant<T: ?Sized>(/* ... */); pub struct PhantomContravariant<T: ?Sized>(/* ... */); pub struct PhantomCovariantLifetime<'a>(/* ... */); pub struct PhantomInvariantLifetime<'a>(/* ... */); pub struct PhantomContravariantLifetime<'a>(/* ... */); pub trait Variance: Sealed {} impl<T: ?Sized> Variance for PhantomCovariant<T> {} impl<T: ?Sized> Variance for PhantomInvariant<T> {} impl<T: ?Sized> Variance for PhantomContravaiant<T> {} impl<T: ?Sized> Variance for PhantomCovariantLifetime<T> {} impl<T: ?Sized> Variance for PhantomInvariantLifetime<T> {} impl<T: ?Sized> Variance for PhantomContravaiantLifetime<T> {} pub fn variance<T: Variance>() -> T {} // also the trait impls you would expect; identical to PhantomData ``` ### Steps / History - [x] ACP: https://github.com/rust-lang/libs-team/issues/488 - [ ] Implementation: #135807 - [ ] Final comment period (FCP)[^1] - [ ] Stabilization PR ### Unresolved Questions - Should there be a single `Lifetime` type or one for each possible variance? The former would mean writing `PhantomCovariant<Lifetime<'a>>` instead of `PhantomCovariantLifetime<'a>`, with the API otherwise being identical. - Should the values be directly constructable, eliminating the need for `::new()`? This would presumably mean adding 4โ€“6 lang items, depending on the previous bullet point. [^1]: https://std-dev-guide.rust-lang.org/feature-lifecycle/stabilization.html
T-libs-api,C-tracking-issue
low
Minor
2,801,132,420
vscode
Do not enable editor.stickyScroll.enabled on every update by default
<!-- โš ๏ธโš ๏ธ Do Not Delete This! feature_request_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. --> Hi. On every update seems like editor.stickyScroll.enabled is set to enable, this is quite anoying if you dislike the feature, please do not override local settings on updates. Regards.
editor-sticky-scroll
low
Minor
2,801,183,921
pytorch
Missing Length Check for `reflection_pad3d` `padding` Argument
### ๐Ÿ› Describe the bug An issue was identified with the `reflection_pad3d` function in PyTorch regarding the handling of its `padding` argument. The function expects padding to be an array of length 6, but currently, there is no validation check for this length. This oversight can cause undefined behavior when padding is of incorrect length. ```cpp struct test_31948B271C680B9_args { std::array<long, 4> sym_0; at::ScalarType sym_1; at::DeviceType sym_2; bool sym_3; std::array<long, 1> sym_4; }; void test_31948B271C680B9(const test_31948B271C680B9_args &args) { try { auto var_87 = at::rand(args.sym_0, args.sym_1, std::nullopt, args.sym_2, args.sym_3); auto var_643 = at::reflection_pad3d(var_87, args.sym_4); // Incorrect padding length } catch (std::exception &e) { // Exception handling } } ``` The reflection_pad3d function accesses the padding array assuming it is of length 6. However, if padding is shorter, the function reads out-of-bounds, leading to potential memory issues. This behavior is present in ReflectionPad.cpp (line 106): https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/ReflectionPad.cpp#L106 ```cpp TORCH_META_FUNC(reflection_pad3d)(const Tensor& input, IntArrayRef padding) { // TORCH_CHECK(padding.size() == 6, "Expected padding of length 6, but got ", padding.size()); // missed check here. int64_t pad_left = padding[0]; int64_t pad_right = padding[1]; int64_t pad_top = padding[2]; int64_t pad_bottom = padding[3]; int64_t pad_front = padding[4]; int64_t pad_back = padding[5]; // Further processing } ``` This issue can be reproduced using AddressSanitizer. Would it be possible to submit a PR to add this validation check? A similar scenario was addressed here: [https://github.com/pytorch/pytorch/blob/main/aten/src/ATen/native/ReflectionPad.cpp#L164](url) CC: @malfet ### Versions Collecting environment information... PyTorch version: 2.7.0.dev20250116+cu124 Is debug build: False CUDA used to build PyTorch: 12.4 ROCM used to build PyTorch: N/A OS: Manjaro Linux (x86_64) GCC version: (GCC) 14.2.1 20240805 Clang version: 18.1.8 CMake version: version 3.30.2 Libc version: glibc-2.40 Python version: 3.11.11 | packaged by conda-forge | (main, Dec 5 2024, 14:17:24) [GCC 13.3.0] (64-bit runtime) Python platform: Linux-6.6.47-1-MANJARO-x86_64-with-glibc2.40 Is CUDA available: True CUDA runtime version: Could not collect CUDA_MODULE_LOADING set to: LAZY GPU models and configuration: GPU 0: NVIDIA GeForce RTX 4070 Nvidia driver version: 550.107.02 cuDNN version: Probably one of the following: /usr/lib/libcudnn.so.9.2.1 /usr/lib/libcudnn_adv.so.9.2.1 /usr/lib/libcudnn_cnn.so.9.2.1 /usr/lib/libcudnn_engines_precompiled.so.9.2.1 /usr/lib/libcudnn_engines_runtime_compiled.so.9.2.1 /usr/lib/libcudnn_graph.so.9.2.1 /usr/lib/libcudnn_heuristic.so.9.2.1 /usr/lib/libcudnn_ops.so.9.2.1 HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: ๆžถๆž„๏ผš x86_64 CPU ่ฟ่กŒๆจกๅผ๏ผš 32-bit, 64-bit Address sizes: 39 bits physical, 48 bits virtual ๅญ—่Š‚ๅบ๏ผš Little Endian CPU: 16 ๅœจ็บฟ CPU ๅˆ—่กจ๏ผš 0-15 ๅŽ‚ๅ•† ID๏ผš GenuineIntel ๅž‹ๅทๅ็งฐ๏ผš 13th Gen Intel(R) Core(TM) i5-13400F CPU ็ณปๅˆ—๏ผš 6 ๅž‹ๅท๏ผš 191 ๆฏไธชๆ ธ็š„็บฟ็จ‹ๆ•ฐ๏ผš 2 ๆฏไธชๅบง็š„ๆ ธๆ•ฐ๏ผš 10 ๅบง๏ผš 1 ๆญฅ่ฟ›๏ผš 2 CPU(s) scaling MHz: 25% CPU ๆœ€ๅคง MHz๏ผš 4600.0000 CPU ๆœ€ๅฐ MHz๏ผš 800.0000 BogoMIPS๏ผš 4993.00 ๆ ‡่ฎฐ๏ผš fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf tsc_known_freq pni pclmulqdq dtes64 monitor ds_cpl vmx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow flexpriority ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb intel_pt sha_ni xsaveopt xsavec xgetbv1 xsaves split_lock_detect user_shstk avx_vnni dtherm ida arat pln pts hwp hwp_notify hwp_act_window hwp_epp hwp_pkg_req hfi vnmi umip pku ospke waitpkg gfni vaes vpclmulqdq rdpid movdiri movdir64b fsrm md_clear serialize arch_lbr ibt flush_l1d arch_capabilities ่™šๆ‹ŸๅŒ–๏ผš VT-x L1d ็ผ“ๅญ˜๏ผš 416 KiB (10 instances) L1i ็ผ“ๅญ˜๏ผš 448 KiB (10 instances) L2 ็ผ“ๅญ˜๏ผš 9.5 MiB (7 instances) L3 ็ผ“ๅญ˜๏ผš 20 MiB (1 instance) NUMA ่Š‚็‚น๏ผš 1 NUMA ่Š‚็‚น0 CPU๏ผš 0-15 Vulnerability Gather data sampling: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Reg file data sampling: Mitigation; Clear Register File Vulnerability Retbleed: Not affected Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI BHI_DIS_S Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Versions of relevant libraries: [pip3] numpy==2.1.2 [pip3] nvidia-cublas-cu12==12.4.5.8 [pip3] nvidia-cuda-cupti-cu12==12.4.127 [pip3] nvidia-cuda-nvrtc-cu12==12.4.127 [pip3] nvidia-cuda-runtime-cu12==12.4.127 [pip3] nvidia-cudnn-cu12==9.1.0.70 [pip3] nvidia-cufft-cu12==11.2.1.3 [pip3] nvidia-curand-cu12==10.3.5.147 [pip3] nvidia-cusolver-cu12==11.6.1.9 [pip3] nvidia-cusparse-cu12==12.3.1.170 [pip3] nvidia-cusparselt-cu12==0.6.2 [pip3] nvidia-nccl-cu12==2.21.5 [pip3] nvidia-nvjitlink-cu12==12.4.127 [pip3] nvidia-nvtx-cu12==12.4.127 [pip3] pytorch-triton==3.2.0+git0d4682f0 [pip3] torch==2.7.0.dev20250116+cu124 [pip3] torchaudio==2.6.0.dev20250116+cu124 [pip3] torchvision==0.22.0.dev20250116+cu124 [conda] numpy 2.1.2 pypi_0 pypi [conda] nvidia-cublas-cu12 12.4.5.8 pypi_0 pypi [conda] nvidia-cuda-cupti-cu12 12.4.127 pypi_0 pypi [conda] nvidia-cuda-nvrtc-cu12 12.4.127 pypi_0 pypi [conda] nvidia-cuda-runtime-cu12 12.4.127 pypi_0 pypi [conda] nvidia-cudnn-cu12 9.1.0.70 pypi_0 pypi [conda] nvidia-cufft-cu12 11.2.1.3 pypi_0 pypi [conda] nvidia-curand-cu12 10.3.5.147 pypi_0 pypi [conda] nvidia-cusolver-cu12 11.6.1.9 pypi_0 pypi [conda] nvidia-cusparse-cu12 12.3.1.170 pypi_0 pypi [conda] nvidia-cusparselt-cu12 0.6.2 pypi_0 pypi [conda] nvidia-nccl-cu12 2.21.5 pypi_0 pypi [conda] nvidia-nvjitlink-cu12 12.4.127 pypi_0 pypi [conda] nvidia-nvtx-cu12 12.4.127 pypi_0 pypi [conda] pytorch-triton 3.2.0+git0d4682f0 pypi_0 pypi [conda] torch 2.7.0.dev20250116+cu124 pypi_0 pypi [conda] torchaudio 2.6.0.dev20250116+cu124 pypi_0 pypi [conda] torchvision 0.22.0.dev20250116+cu124 pypi_0 pypi cc @jbschlosser @malfet
module: crash,module: cpp,module: error checking,triaged,topic: fuzzer
low
Critical
2,801,188,323
ollama
Support for Multiple Images in /chat Endpoint
Currently, the /chat endpoint includes the images field, but it only supports a single image. While this is functional, it introduces an additional layer of complexity when performing RAG with images embedded in base64. For instance, if the content retriever returns multiple embeddings with the highest scores referencing different images, we need to manually reconstruct the full images (potentially missing lower-score records in case the embedding size isn't big enough to store the whole image in one record) and then make a separate /chat call for each retrieved image. Finally, all the responses must be summarized into one. This manual process could be significantly simplified if the images field allowed for passing multiple images in a single request. Is there any plan in the near future to support multiple images in the images field? This enhancement would greatly streamline workflows and reduce the overhead in scenarios like the one described above. Additionally, Iโ€™m just getting started and donโ€™t have much experience yet, so itโ€™s possible that Iโ€™m overlooking something that could make this process easier. If thereโ€™s a better approach or workaround I might have missed, Iโ€™d be grateful for any guidance. Thank you beforehand!
feature request
low
Minor
2,801,194,244
opencv
VideoCapture using CAP_FFMPEG to capture the camera device
Currently, opencv does not support using the ffmpeg backend to open the camera device. Is there any support plan at present? My current problem is that I want to use ffmpeg's hardware acceleration to decode the camera data.
feature,category: videoio(camera)
low
Minor
2,801,215,487
tensorflow
Tensorflow 2.14.0 installation/run on C++ in visual studio code
### Issue type Build/Install ### Have you reproduced the bug with TensorFlow Nightly? No ### Source source ### TensorFlow version 2.14 ### Custom code Yes ### OS platform and distribution macos 14.4 ### Mobile device _No response_ ### Python version _No response_ ### Bazel version 6.1 ### GCC/compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current behavior? Hi I would like to try to run a custom model on C++, how should I setup the tensorflow so that i could call and use function like i did in python? ### Standalone code to reproduce the issue ```shell tried bazel build //tensorflow/tools/pip_package, yet it pops up error Skipping '//tensorflow/tools/pip_package': no such target '//tensorflow/tools/pip_package:pip_package': target 'pip_package' not declared in package 'tensorflow/tools/pip_package' defined by /Users/XXXX/Documents/testing/tensorflow/tensorflow/tools/pip_package/BUILD (Tip: use `query "//tensorflow/tools/pip_package:*"` to see all the targets in that package) WARNING: Target pattern parsing failed. ERROR: no such target '//tensorflow/tools/pip_package:pip_package': target 'pip_package' not declared in package 'tensorflow/tools/pip_package' defined by /Users/XXXX/Documents/testing/tensorflow/tensorflow/tools/pip_package/BUILD (Tip: use `query "//tensorflow/tools/pip_package:*"` to see all the targets in that package) ``` ### Relevant log output ```shell ```
type:build/install,awaiting PR merge,TF2.14
low
Critical
2,801,222,226
rust
relaxing a non-`Sized` bounds is a hard-warning
https://github.com/rust-lang/rust/blob/b605c65b6eb5fa71783f8e26df69975f9f1680ee/compiler/rustc_hir_analysis/src/hir_ty_lowering/bounds.rs#L97-L111 ```rust fn foo() -> impl ?Send {} ``` ``` warning: relaxing a default bound only does something for `?Sized`; all other traits are not bound by default --> src/lib.rs:1:18 | 1 | fn foo() -> impl ?Send {} | ^^^^^ ``` This should either be a (future-compat) lint or a hard-error.
T-lang,C-bug
low
Critical