id
int64 393k
2.82B
| repo
stringclasses 68
values | title
stringlengths 1
936
| body
stringlengths 0
256k
โ | labels
stringlengths 2
508
| priority
stringclasses 3
values | severity
stringclasses 3
values |
|---|---|---|---|---|---|---|
2,738,515,674 | deno | Auto-merge lockfile conflicts | pnpm, npm (and maybe yarn?) all support merging lockfile conflicts automatically. Hand-merging deno lockfiles is a pain, because it sometimes includes versions and peers, and sometimes doesn't. I know I can just delete it, but that makes an unclean merge. I quite often corrupt the lockfile and have to restart, but it's feasible to be able to do it automatically. | cli,suggestion | low | Minor |
2,738,516,827 | tauri | Android Build Missing Libraries? (libandroid.so, etc.) | ### Describe the bug
In summary, the application does not want to compile to Android *specifically*. Desktop works fine. I have tried looking for ways to install these missing libraries, but it looks like either I already have the prerequisite packages, or whatever the fix a given forum page proposes is irrelevant to my context somehow.
### Reproduction
1. Create a Tauri project on Linux Mint using `pnpm` and Svelte for the front end
2. Install prerequisites (Android Studio, SDK, GTK, etc.)
3. Run `pnpm tauri android init` (successfully!)
4. Run `pnpm tauri dev --open --verbose`
### Expected behavior
A mobile emulator akin to that on Android Studio should pop up with the base Tauri app.
### Full `tauri info` output
```text
[โ] Environment
- OS: Linux Mint 21.3.0 x86_64 (X64)
โ webkit2gtk-4.1: 2.46.3
โ rsvg2: 2.52.5
โ rustc: 1.83.0 (90b35a623 2024-11-26)
โ cargo: 1.83.0 (5ffbef321 2024-10-29)
โ rustup: 1.27.1 (54dd3d00f 2024-04-24)
โ Rust toolchain: stable-x86_64-unknown-linux-gnu (default)
- node: 20.11.0
- pnpm: 9.0.5
- npm: 10.2.4
[-] Packages
- tauri ๐ฆ: 2.1.1
- tauri-build ๐ฆ: 2.0.3
- wry ๐ฆ: 0.47.2
- tao ๐ฆ: 0.30.8
- tauri-cli ๐ฆ: 1.5.12
- @tauri-apps/api ๎: 2.1.1
- @tauri-apps/cli ๎: 2.1.0
[-] Plugins
[-] App
- build-type: bundle
- CSP: unset
- frontendDist: ../build
- devUrl: http://localhost:1420/
- framework: Svelte
- bundler: Vite
```
### Stack trace
Getting an error like this when I run `pnpm run tauri dev --open --verbose`:
```text
Info [cargo_mobile2::android::jnilibs] symlinking lib "/home/ender/Documents/Projects/ChatLogged/client/src-tauri/target/aarch64-linux-android/debug/libclient_lib.so" in jniLibs dir "/home/ender/Documents/Projects/ChatLogged/client/src-tauri/gen/android/app/src/main/jniLibs/arm64-v8a"
Info [cargo_mobile2::android::ndk] "/home/ender/Documents/Projects/ChatLogged/client/src-tauri/target/aarch64-linux-android/debug/libclient_lib.so" requires shared lib "libandroid.so"
Info [cargo_mobile2::android::ndk] "/home/ender/Documents/Projects/ChatLogged/client/src-tauri/target/aarch64-linux-android/debug/libclient_lib.so" requires shared lib "libdl.so"
Info [cargo_mobile2::android::ndk] "/home/ender/Documents/Projects/ChatLogged/client/src-tauri/target/aarch64-linux-android/debug/libclient_lib.so" requires shared lib "liblog.so"
Info [cargo_mobile2::android::ndk] "/home/ender/Documents/Projects/ChatLogged/client/src-tauri/target/aarch64-linux-android/debug/libclient_lib.so" requires shared lib "libm.so"
Info [cargo_mobile2::android::ndk] "/home/ender/Documents/Projects/ChatLogged/client/src-tauri/target/aarch64-linux-android/debug/libclient_lib.so" requires shared lib "libc.so"
Info [tauri_cli::mobile::android] Opening Android Studio
Error [tauri_cli::mobile::android] Launch failed: No such file or directory (os error 2)
```
I'm pretty sure it has something to do with libraries straight up not existing, OR it's Android Studio not wanting to open some file. However, I'm thinking it might be the former due to how the error message is laid out.
### Additional context
```
which pkg-config
/home/linuxbrew/.linuxbrew/bin/pkg-config
java --version
java 17.0.10 2024-01-16 LTS
Java(TM) SE Runtime Environment (build 17.0.10+11-LTS-240)
Java HotSpot(TM) 64-Bit Server VM (build 17.0.10+11-LTS-240, mixed mode, sharing)
/opt/android-studio/bin/studio --version
Android Studio Ladybug | 2024.2.1 Patch 3
Build #AI-242.23339.11.2421.12700392
printenv ANDROID_HOME
/home/ender/Android/Sdk
printenv NDK_HOME
/home/ender/Android/Sdk/ndk/28.0.12674087
```
In case any of that helps. `pkg-config --list-all` doesn't seem to list anything with "android" in it, neither does `sudo ldconfig -p`.
`libdl.so.2` exists according to `ldconfig`? Interestingly? Not sure if that matters. `libc.so.6` also shows up in there. | type: bug,status: needs triage | low | Critical |
2,738,520,499 | go | proposal: crypto/x509: support for RFC 9336 Document Signing EKU | ### Proposal Details
RFC 9336 specifies a new EKU for document signing, allowing for a separate and distinct EKU from either code signing or smime email signing. That document explains the reason for the new EKU.
Form a golang perspective, this requires entries in three tables in src/crypto/x509/x509.go for id-kp-documentSigning, or OID 1.3.6.1.5.5.7.3.36.
| Proposal,Proposal-Crypto | low | Major |
2,738,525,106 | bitcoin | cmake inconsistently overriding `-O3` (sometimes) | Using master @ d73f37dda221835b5109ede1b84db2dc7c4b74a1.
The following seems incorrect, because
```bash
make -C depends/ NO_QT=1 NO_WALLET=1 NO_ZMQ=1 -j18 CFLAGS="-O3" CXXFLAGS="-O3"
cmake -B build --toolchain /root/ci_scratch/depends/aarch64-unknown-linux-gnu/toolchain.cmake
<snip>
C++ compiler flags .................... -O3 -O2 -g
Linker flags .......................... -O3 -O2 -g
```
is overriding the user-provided `-O3`.
If you configure by providing an explicit `-DCMAKE_BUILD_TYPE=RelWithDebInfo`, you get:
```bash
cmake -B build --toolchain /root/ci_scratch/depends/aarch64-unknown-linux-gnu/toolchain.cmake -DCMAKE_BUILD_TYPE=RelWithDebInfo
C++ compiler flags .................... -O3
Linker flags .......................... -O3
```
No `-O2` at all, so the user provided `-O3` is used (also missing `-g` for debug info?).
If you configure with `-DCMAKE_BUILD_TYPE=Release`:
```bash
cmake -B build --toolchain /root/ci_scratch/depends/aarch64-unknown-linux-gnu/toolchain.cmake -DCMAKE_BUILD_TYPE=Release
C++ compiler flags .................... -O3 -O2
Linker flags .......................... -O3 -O2
```
Now we are back to (inconsistently) overriding the user. | Build system | low | Critical |
2,738,525,815 | go | proposal: spec: pipe operator with explicit result passing | ### Go Programming Experience
Experienced
### Other Languages Experience
Elixir, JavaScript, Ruby, Kotlin, Dart, Python, C
### Related Idea
- [X] Has this idea, or one like it, been proposed before?
- [ ] Does this affect error handling?
- [ ] Is this about generics?
- [ ] Is this change backward compatible? Breaking the Go 1 compatibility guarantee is a large cost and requires a large benefit
### Has this idea, or one like it, been proposed before?
Yes, several times. This variant directly addresses the main issues brought up in those proposals.
### Does this affect error handling?
Not directly, though it possible could in some cases.
### Is this about generics?
Not directly, though it addresses a situation that has arisen as a result of generics.
### Proposal
When a pipe operator has been proposed before (#33361), the primary issues with it were
1. Not enough interest.
2. Not explicit enough.
3. Might lead to APIs being written specifically to accommodate it, thus potentially making them awkward for no reason.
I think that the first point is arguable as a reason not to consider a feature, but more importantly I think that the situation there has changed and I think that #49085's continued discussion is good evidence that _some_ way to fix the issue that a pipe operator would address is a very popular idea. With generics being added and now iterators, too, some way to write chains of function/method calls in a left-to-right or top-to-bottom manner has, I think, gained a fair bit of usefulness that it didn't have back in 2019 (#33361). Simply using methods like many other languages, such as Rust, do, has a lot of problems that have been pointed out in the above issue, but functions have none of those problems. Their only issue in this regard is simply syntactic.
Points 2 and 3, however, I think are very solvable in a simple way: Add a special variable that is defined for the scope of each piece of the pipe that contains the value of the previous expression instead of magically inserting function arguments. For example, assuming that the bikeshed is painted `piped`:
```go
a() |> f1(piped, b) |> f2(c, piped)
```
The first `|>` operator creates a new scope that exists only for the expression immediately to its right, in this case a call to `f1()`. In that scope, it defines a variable, `piped`, containing the result of the expression to its left, in this case just `a()`. The second `|>` operator creates a _new_ scope that shadows the existing `piped`, introducing a _new_ `piped` variable containing the result of the expression to _its_ left, in this case `a() |> f1(piped, b)`. And so on with a longer pipeline.
This completely fixes problem 2, as it now makes piping extremely explicit. It _mostly_ fixes problem 3 as it makes the operator significantly more flexible, reducing the need for writing APIs specifically to accommodate it. I think this not completely solvable, though, as, at some point, someone will always write something that they probably shouldn't have.
It also allows the pipe operator to become non-exclusive to function calls. Any single-value expression now becomes valid at any point in a pipeline, allowing even things like
```go
a() |> f1(piped, b) |> S{Value: piped} |> f2(c, piped)
```
For a more practical example, here's some iterator usage:
```go// Current way of writing some simple usage with the proposed x/exp/xiter package:
// Problem: Horrendously unreadable and uneditable.
xiter.Filter(
func(v int) bool { return v > 0 },
xiter.Map(
func(v string) int {
n, _ := strconv.ParseInt(v, 10, 0)
return int(n)
},
strings.SplitSeq(input, "\n"),
),
)
// Using multiple explicit variables:
// Problem: Better than the last one in terms of readability, but
// still difficult to edit by, for example, adding or removing
// operations in the middle because of needing to avoid variable name
// reuse if types change and also being sure to pass the correct one
// to the next in the chain.
lines := strings.SplitSeq(input, "\n")
ints := xiter.Map(lines, func(v string) int {
n, _ := strconv.ParseInt(v, 10, 0)
return int(n)
})
ints = xiter.Filter(ints, func(v int) bool { return v > 0 })
// With this proposal:
ints := strings.SplitSeq(input, "\n") |>
xiter.Map(func(v string) int {
n, _ := strconv.ParseInt(v, 10, 0)
return n,
}, piped) |>
xiter.Filter(func(v int) bool { return v > 0 }, piped)
```
Side note: I'm not a huge fan of needing to put the `|>` operator at the _end_ of a line. I think Elixir's way of doing it with the operator at the beginning of each of the subsequent lines looks way better. Unfortunately, Go's semicolon insertion rules kind of make this necessary unless someone can come up with a way to do it that doesn't involve special-casing the `|>` operator, which I definitely think would be unnecessary. For comparison's sake, here's that same iterator chain written the other way around:
```go
strings.SplitSeq(input, "\n")
|> xiter.Map(func(v string) int {
n, _ := strconv.ParseInt(v, 10, 0)
return n,
}, piped)
|> xiter.Filter(func(v int) bool { return v > 0 }, piped)
```
### Language Spec Changes
A section would have to be added about the `|>` operator. It shouldn't directly affect any existing parts of the spec, I don't think.
### Informal Change
The `|>` operator allows expressions to be written in a left-to-right manner by implicitly passing the result of one into the next in the form of a variable called `piped` that is scoped only to the right-hand side of each usage of `|>`, shadowing any existing variables named `piped` in parent scopes, including previous `|>` usages in the same pipeline.
### Is this change backward compatible?
Yes.
### Orthogonality: How does this change interact or overlap with existing features?
It allows a compromise between adding generic types in method calls (#49085) and function calls having poor ergonomics for certain use cases.
### Would this change make Go easier or harder to learn, and why?
Slightly harder as the idea of the specially-scoped variable and its automatic shadowing of its counterparts in previous pipeline stages would have to be explained.
### Cost Description
Tiny compile-time cost. No runtime costs. Slight increase in language complexity. Slight increase in potential for poorly written code as some people might misuse the operator.
### Changes to Go ToolChain
All tools that parse Go code would have to be updated. gofmt and goimports would be affected the most.
### Performance Costs
Compile-time cost is minimal. Runtime cost is nonexistent.
### Prototype
_No response_ | LanguageChange,Proposal,Proposal-FinalCommentPeriod,LanguageChangeReview | medium | Critical |
2,738,556,444 | next.js | Suspense infinite fallback loading state with javascript turned off | ### Link to the code that reproduces this issue
https://github.com/vladshcherbin/suspense-infinite-loading
### To Reproduce
1. Start the app
2. From home page go to /recipes and see loading state and recipes list
3. Turn off javascript and do same thing (or reload the page)
4. See infinite loading state
- Check server logs to confirm data was fetched (logs output recipes number)
- Check page source to see data actually exists, hidden at the end
### Current vs. Expected behavior
**Current**
When javascript is turned off, suspense fallback state is infinite and never shows actual data. For the end user or search engine bot it results in an infinite loading state. Data is actually fetched on the server (can be seen in server logs) and exists hidden at the end of the page.
Screenshots:
<details>
<summary>Infinite loading state</summary>
<img width="536" alt="image" src="https://github.com/user-attachments/assets/c8c344ec-6832-4b98-9668-85d7eff2bef3" />
</details>
<details>
<summary>Server logs with data fetched</summary>
<img width="440" alt="image" src="https://github.com/user-attachments/assets/c4570848-3c84-4ed9-8ab8-87f3397a7296" />
</details>
<details>
<summary>Actual data and hidden html tags</summary>
<img width="643" alt="image" src="https://github.com/user-attachments/assets/3051c2ce-7720-4f8c-b0c8-77f22c88080a" />
</details>
If `Suspense` is removed, data is shown to the end user but loading state is gone ๐ฅฒ
**Expected**
Since data is actually fetched and exists on the page, it should be shown to the end user even with javascript turned off
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:02:45 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T8112
Available memory (MB): 8192
Available CPU cores: 8
Binaries:
Node: 22.10.0
npm: 10.9.0
Yarn: 1.22.22
pnpm: 9.14.2
Relevant Packages:
next: 15.1.0 // Latest available version is detected (15.1.0).
eslint-config-next: N/A
react: 19.0.0
react-dom: 19.0.0
typescript: 5.7.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Lazy Loading, Runtime
### Which stage(s) are affected? (Select all that apply)
next dev (local), next start (local)
### Additional context
_No response_ | Lazy Loading,Runtime | low | Minor |
2,738,586,569 | svelte | onclick seems to not be working on web components | ### Describe the bug
Using `onclick` on a web-component (ApplePay button, on this case) is not working. The handler function is not being called. If I change to Svelte's 4 `on:click` the handler function is called normally
As far as I understand the `apple-pay-button` web-component fires a click event
### Reproduction
https://github.com/GCastilho/svelte-5-onclick-bug-reproduction
(Note the usage of 'vite-plugin-mkcert' to use https on localhost. HTTPS is required for the ApplePay button to be displayed)
### Logs
_No response_
### System Info
```shell
System:
OS: Windows 11 10.0.26100
CPU: (8) x64 Intel(R) Core(TM) i5-1035G1 CPU @ 1.00GHz
Memory: 3.05 GB / 15.77 GB
Binaries:
Node: 20.16.0 - C:\Program Files\nodejs\node.EXE
npm: 10.8.1 - C:\Program Files\nodejs\npm.CMD
pnpm: 9.7.0 - C:\Program Files\nodejs\pnpm.CMD
Browsers:
Edge: Chromium (131.0.2903.86)
Internet Explorer: 11.0.26100.1882
npmPackages:
svelte: ^5.2.7 => 5.11.2
```
### Severity
blocking an upgrade | custom element | low | Critical |
2,738,590,953 | godot | SceneTreeTween not work properly when tween one axis with from() | ### Tested versions
Reproduce in Godot 3.5.3( Issue not exist in 4.x)
### System information
Windows10 Pro
### Issue description
When tween "One Axis" with SceneTreeTween with tween_property(self, "position:x").from(), tween looks different and clunky from tween both axis, or without from().
### Steps to reproduce
Create a normal sprite and attach the script:[TweenAxis.zip](https://github.com/user-attachments/files/18127865/TweenAxis.zip)
`if _Tween:
_Tween.kill()
_Tween = create_tween()
_Tween.set_ease(Tween.EASE_OUT).set_trans(Tween.TRANS_BACK)
_Tween.tween_property($Sprite, "position:x", 300, 0.3).from(0)
_Tween.play()`
### Minimal reproduction project (MRP)
[TweenAxis.zip](https://github.com/user-attachments/files/18127874/TweenAxis.zip)
| bug,topic:animation | low | Minor |
2,738,616,330 | go | x/website: anchor links don't show up if one hovers directly on a heading | Splitting from https://github.com/golang/go/issues/68596#issuecomment-2402302152, which got ignored as it was a closed issue.
When I hover over ["Doc Links"](https://go.dev/doc/comment#doclinks), nothing happens - which is why I didn't even realise this got fixed earlier today. I have to move my cursor to the right of the heading - where the "reverse P" anchor symbol would be - for it to appear, as if I had to know ahead of time it would be there.
Can we make the anchor link show up whenever I hover over any of the heading area too? I think this is how anchor link hovers usually work on other websites, or at least that's how I intuitively think they work.
cc @hyangah @matttproud @cespare | help wanted,NeedsInvestigation,website | low | Minor |
2,738,629,207 | go | cmd/compile: better error message for ambiguous parse | ### Go version
go version 1.23
### Output of `go env` in your module/workspace:
```shell
GO111MODULE=''
GOARCH='amd64'
GOBIN=''
GOCACHE='/home/smu/.cache/go-build'
GOENV='/home/smu/.config/go/env'
GOEXE=''
GOEXPERIMENT='fieldtrack,boringcrypto'
GOFLAGS=''
GOHOSTARCH='amd64'
GOHOSTOS='linux'
GOINSECURE=''
GOMODCACHE='/home/smu/go/pkg/mod'
GONOPROXY=''
GONOSUMDB=''
GOOS='linux'
GOPATH='/home/smu/go'
GOPRIVATE=''
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/usr/lib/google-golang'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='auto'
GOTOOLDIR='/usr/lib/google-golang/pkg/tool/linux_amd64'
GOVCS=''
GOVERSION='go1.23 [redacted] X:fieldtrack,boringcrypto'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/home/smu/.config/go/telemetry'
GCCGO='gccgo'
GOAMD64='v1'
AR='ar'
CC='clang'
CXX='clang++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build1689118444=/tmp/go-build -gno-record-gcc-switches'
```
### What did you do?
I expected
```
if mErr := &MyError{}; errors.As(err1, &mErr) {
...
}
```
to be parse correctly. See https://go.dev/play/p/XHkampOkowJ for a reproduction case.
Actual result of that playground snippet was:
./prog.go:23:10: syntax error: cannot use mErr := &MyError as value
./prog.go:26:1: syntax error: non-declaration statement outside function body
Changing the line
```
if mErr := &MyError{}; errors.As(err1, &mErr) {
```
into
```
if mErr := &(MyError{}); errors.As(err1, &mErr) {
```
or into
```
mErr := &MyError{}
if errors.As(err1, &mErr) {
```
makes the code work, but I would expect the first variant to work just as well.
### What did you see happen?
./prog.go:23:10: syntax error: cannot use mErr := &MyError as value
./prog.go:26:1: syntax error: non-declaration statement outside function body
### What did you expect to see?
A compiled program | NeedsInvestigation,compiler/runtime,BadErrorMessage | low | Critical |
2,738,635,215 | TypeScript | instantiation expression usage leading to an invalid d.ts file generation | ### ๐ Search Terms
partial function generic application, function generic variant from another function, instantiation-expressions
### ๐ Version & Regression Information
- This changed between versions 5.6.2 and 5.7.2
### โฏ Playground Link
https://www.typescriptlang.org/play/?ts=5.7.2#code/C4TwDgpgBAyg9gWwgBQE50q0BpCIDOUAvFAEoQCGAJnAHYA2IAgqqhSADxoYRYi4gAfAChQkKE2AcmUCAA9gEWlULlqdRizacArrQDWtOAHdaggDRQAkrIVKVUWjoQAjXsUfO3qQR6YBtKwBdYWF5MDgsKAAzPQBjYABLOigECkTaAQBxHQpUKg5hKChsW0VlQlRKGgYQKH9uTBw8SwA6dvgkRt5mgiDzYUEACiKofTx8AC4SgYBKaY4AFTL7QjgXACsIBOHRgDcKeh0IacW54l8Do+hEwgBRBTYEpctyOMiCyQ5sSwAGCygekMJjMvgA3qMqsAdKhaFAlisKlB1lsdiNisUrsdTgNivMoFibvdHhRnmcyNsPtIpD8oP9LECjKZBL4iODRsUoTC4eMCP5fkEoBkCYdjqMAL7CSWicDQABicDgHjBMUVAEZpvhgKgMgBzSzRRUAJk12r1UElYmgACE8sqoC48hqoFqdbR9Q68iaXWb3RaZeIFXBbagPEGoAAfKAh4TvWhaz2oASEEj+ADkjtQarTlgzXrTgoohDjWrCcgiURLwCF+BDHjSGWyuXyQ0zydmHCDIZEoSAA
### ๐ป Code
```ts
type SomePropertyKeys = ReadonlyArray<PropertyKey>
type At<A extends ReadonlyArray<unknown>, I extends number = number> = A[I]
export function mainKeyGuard<
K extends readonly [PropertyKey, ...SomePropertyKeys],
>(
keys: K,
): <T extends object>(
value: T,
) => value is Extract<T, Record<At<K, 0>, unknown>> {
return <T extends object>(
value: T,
): value is Extract<T, Record<At<K, 0>, unknown>> => {
return keys[0] in value
}
}
type Foo = { foo1: string, foo2: string }
type Bar = { bar1: string, bar2: string }
type FooBar = Foo | Bar
const barKeys = ['bar1', 'bar2'] as const
export const isBar = mainKeyGuard(barKeys)<FooBar>
```
### ๐ Actual behavior
Starting with the v5.7.2, the generated d.ts file declares `isBar` as a function which reference a missing generic type T, so an error is raised
```ts
export declare const isBar: (value: FooBar) => value is Extract<T, Record<At<K, 0>, unknown>>;
```
### ๐ Expected behavior
I would expect the `isBar` function d.ts declaration to not reference a missing generic type T.
Previously, the generated d.ts file behaved like the following
```ts
export declare const isBar: (value: FooBar) => value is Bar;
```
### Additional information about the issue
The title mentions "instantiation expression" but I'm not totally sure about how the involved feature is actually named | Bug,Fix Available | low | Critical |
2,738,686,911 | yt-dlp | extractor/Smotrim fix for site updates | ### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field
### Checklist
- [X] I'm reporting that yt-dlp is broken on a **supported** site
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
- [X] I've checked that all URLs and arguments with special characters are [properly quoted or escaped](https://github.com/yt-dlp/yt-dlp/wiki/FAQ#video-url-contains-an-ampersand--and-im-getting-some-strange-output-1-2839-or-v-is-not-recognized-as-an-internal-or-external-command)
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
- [X] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and I'm willing to share it if required
### Region
russia
### Provide a description that is worded well enough to be understood
.
### Provide verbose output that clearly demonstrates the problem
- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [X] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below
### Complete Verbose Output
```shell
yt-dlp -vU https://smotrim.ru/channel/4
[debug] Command-line config: ['-vU', 'https://smotrim.ru/channel/4']
[debug] Encodings: locale UTF-8, fs utf-8, pref UTF-8, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version [email protected] from yt-dlp/yt-dlp [542166962]
[debug] Lazy loading extractors is disabled
[debug] Python 3.12.8 (CPython x86_64 64bit) - Linux-6.12.3-amd64-x86_64-with-glibc2.40 (OpenSSL 3.3.2 3 Sep 2024, glibc 2.40)
[debug] exe versions: ffmpeg 7.1-3 (setts), ffprobe 7.1-3
[debug] Optional libraries: Cryptodome-3.20.0, certifi-2024.08.30, mutagen-1.47.0, requests-2.32.3, sqlite3-3.46.1, urllib3-2.2.3, websockets-13.0
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets
[debug] Loaded 1837 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest
Latest version: [email protected] from yt-dlp/yt-dlp
yt-dlp is up to date ([email protected] from yt-dlp/yt-dlp)
[generic] Extracting URL: https://smotrim.ru/channel/4
[generic] 4: Downloading webpage
WARNING: [generic] Falling back on generic information extractor
[generic] 4: Extracting information
[debug] Looking for embeds
ERROR: Unsupported URL: https://smotrim.ru/channel/4
Traceback (most recent call last):
File "/srv/git/yt-dlp/yt_dlp/YoutubeDL.py", line 1624, in wrapper
return func(self, *args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/srv/git/yt-dlp/yt_dlp/YoutubeDL.py", line 1759, in __extract_info
ie_result = ie.extract(url)
^^^^^^^^^^^^^^^
File "/srv/git/yt-dlp/yt_dlp/extractor/common.py", line 742, in extract
ie_result = self._real_extract(url)
^^^^^^^^^^^^^^^^^^^^^^^
File "/srv/git/yt-dlp/yt_dlp/extractor/generic.py", line 2553, in _real_extract
raise UnsupportedError(url)
yt_dlp.utils.UnsupportedError: Unsupported URL: https://smotrim.ru/channel/4
```
| site-bug,triage | low | Critical |
2,738,711,218 | go | runtime: corruption after wasm stack overflow RangeError | Open https://swtch.com/tmp/wasmbug/ in Chrome.
Open the developer console (right click on page, Inspect, then click the Console tab).
It should say "Go starting".
Now click Run.
You should see an "Uncaught RangeError: Maximum call stack size exceeded":
```
0133597e:0x6304a Uncaught RangeError: Maximum call stack size exceeded
at runtime.__mspan_.init (0133597e:0x6304a)
at runtime.__mheap_.initSpan (0133597e:0x612a5)
at runtime.__mheap_.allocSpan (0133597e:0x60bf7)
at runtime.__mheap_.alloc.func1 (0133597e:0x5f504)
at runtime.systemstack (0133597e:0xfe0bd)
at runtime.__mheap_.alloc (0133597e:0x5f361)
at runtime.__mcentral_.grow (0133597e:0x28d09)
at runtime.__mcentral_.cacheSpan (0133597e:0x28161)
at runtime.__mcache_.refill (0133597e:0x26ca7)
at runtime.__mcache_.nextFree (0133597e:0x1c94b)
```
I'm a little surprised that it shows this stack and not a stack inside user code if the stack is too big. Perhaps this is the "m" stack and it is not supposed to be overflowing?
I am not sure whether Go is expected to continue at this point, but it seems to still be running. Click Run again.
Now you should see a fatal error like this:
```
fatal error: bad sweepgen in refill
wasm_exec.js:22
runtime stack:
wasm_exec.js:22 runtime.throw({0x46795, 0x16})
wasm_exec.js:22 /Users/rsc/go/src/runtime/panic.go:1099 +0x3 fp=0x24eec8 sp=0x24eea0 pc=0x143d0003
wasm_exec.js:22 runtime.(*mcache).refill(0x250108, 0x5)
wasm_exec.js:22 /Users/rsc/go/src/runtime/mcache.go:158 +0x29 fp=0x24ef18 sp=0x24eec8 pc=0x10b50029
wasm_exec.js:22 runtime.(*mcache).nextFree(0x250108, 0x5)
wasm_exec.js:22 /Users/rsc/go/src/runtime/malloc.go:964 +0xa fp=0x24ef50 sp=0x24ef18 pc=0x1088000a
wasm_exec.js:22 runtime.mallocgcTiny(0x8, 0x19840, 0x1)
wasm_exec.js:22 /Users/rsc/go/src/runtime/malloc.go:1175 +0x48 fp=0x24efa8 sp=0x24ef50 pc=0x10890048
wasm_exec.js:22 runtime.mallocgc(0x8, 0x19840, 0x1)
wasm_exec.js:22 /Users/rsc/go/src/runtime/malloc.go:1053 +0x15 fp=0x24efe0 sp=0x24efa8 pc=0x141e0015
wasm_exec.js:22 runtime.newobject(0x19840)
wasm_exec.js:22 /Users/rsc/go/src/runtime/malloc.go:1714 +0x4 fp=0x24f008 sp=0x24efe0 pc=0x10920004
wasm_exec.js:22 syscall/js.makeValue(0x7ff8000100000014)
wasm_exec.js:22 /Users/rsc/go/src/syscall/js/js.go:51 +0x5 fp=0x24f038 sp=0x24f008 pc=0x166d0005
wasm_exec.js:22 syscall/js.Value.Get({{}, 0x7ff8000100000006, 0x0}, {0x442f4, 0xd})
wasm_exec.js:22 /Users/rsc/go/src/syscall/js/js.go:298 +0x9 fp=0x24f078 sp=0x24f038 pc=0x16740009
wasm_exec.js:22 syscall/js.handleEvent()
wasm_exec.js:22 /Users/rsc/go/src/syscall/js/func.go:90 +0x2 fp=0x24f158 sp=0x24f078 pc=0x166c0002
wasm_exec.js:22 runtime.handleEvent()
wasm_exec.js:22 /Users/rsc/go/src/runtime/lock_js.go:287 +0x16 fp=0x24f1c8 sp=0x24f158 pc=0x10820016
wasm_exec.js:22 runtime.(*mheap).initSpan(0x241860, 0x372078, 0x0, 0x5, 0x5e4000, 0x1)
wasm_exec.js:22 /Users/rsc/go/src/runtime/mheap.go:1393 +0x2 fp=0x24f208 sp=0x24f1c8 pc=0x117b0002
wasm_exec.js:22 runtime.(*mheap).allocSpan(0x241860, 0x1, 0x0, 0x5)
wasm_exec.js:22 /Users/rsc/go/src/runtime/mheap.go:1346 +0x8e fp=0x24f2d0 sp=0x24f208 pc=0x117a008e
wasm_exec.js:22 runtime.(*mheap).alloc.func1()
wasm_exec.js:22 /Users/rsc/go/src/runtime/mheap.go:970 +0xb fp=0x24f318 sp=0x24f2d0 pc=0x1175000b
wasm_exec.js:22 runtime.systemstack(0x24f328)
wasm_exec.js:22 /Users/rsc/go/src/runtime/asm_wasm.s:172 +0x3 fp=0x24f320 sp=0x24f318 pc=0x14760003
wasm_exec.js:22 runtime.mstart()
wasm_exec.js:22 /Users/rsc/go/src/runtime/asm_wasm.s:29 fp=0x24f328 sp=0x24f320 pc=0x14720000
```
As I said, it is unclear to me whether the bug is the original RangeError or that it can't continue after the RangeError.
To reproduce:
git clone https://github.com/rsc/tmp
cd tmp/wasmshell
go generate # builds main.wasm, copies wasm_exec.js into local directory
go run serve.go
open http://localhost:8001/ | NeedsFix,arch-wasm,compiler/runtime,FixPending | low | Critical |
2,738,724,421 | react-native | Textinput Issue | ### Description
While typing in a TextInput, moving to the next line causes the top line of text to partially hide under the input area. It reappears only after typing a character, creating a poor UI/UX experience.
### Steps to reproduce
1. while typing
### React Native Version
0.76.5
### Affected Platforms
Runtime - Android, Runtime - iOS, Build - MacOS, Build - Windows
### Output of `npx react-native info`
```text
System:
OS: Windows 11 10.0.22631
CPU: "(8) x64 AMD Ryzen 3 5300U with Radeon Graphics "
Memory: 556.77 MB / 7.33 GB
Binaries:
Node:
version: 22.11.0
path: C:\Program Files\nodejs\node.EXE
Yarn: Not Found
npm:
version: 10.9.0
path: ~\AppData\Roaming\npm\npm.CMD
Watchman: Not Found
SDKs:
Android SDK:
API Levels:
- "33"
- "34"
- "35"
Build Tools:
- 33.0.0
- 34.0.0
- 35.0.0
Android NDK: Not Found
Windows SDK:
AllowDevelopmentWithoutDevLicense: Enabled
IDEs:
Android Studio: AI-241.18034.62.2411.12169540
Visual Studio: Not Found
Languages:
Java: javac 23
Ruby: Not Found
npmPackages:
"@react-native-community/cli":
installed: 15.1.3
wanted: ^15.1.3
react:
installed: 18.3.1
wanted: 18.3.1
react-native:
installed: 0.76.5
wanted: 0.76.5
react-native-windows: Not Found
npmGlobalPackages:
"*react-native*": Not Found
Android:
hermesEnabled: true
newArchEnabled: false
iOS:
hermesEnabled: Not found
newArchEnabled: Not found
```
### Stacktrace or Logs
```text
none
```
### Reproducer
none
### Screenshots and Videos
https://github.com/user-attachments/assets/ddcc07a5-68e2-4dfd-b559-0e7d60b41bb8
| Component: TextInput,Needs: Author Feedback,Needs: Repro | low | Major |
2,738,731,477 | kubernetes | DaemonsetSetStatus need CurrentRevision to tracking controllerrevision | ### What would you like to be added?
DaemonsetSetStatus need CurrentRevision to tracking controllerrevision
### Why is this needed?
We need to track current controllerrevision for the daemonset like StatefulSetStatus does
<img width="380" alt="ๆชๅฑ2024-12-14 00 00 35" src="https://github.com/user-attachments/assets/cf43607d-ad3e-44fa-ab86-4f23f831dbe1" />
<img width="542" alt="ๆชๅฑ2024-12-14 00 10 51" src="https://github.com/user-attachments/assets/b5993e32-36ef-41f8-b36f-8967fa94d26b" />
| kind/feature,sig/apps,needs-triage | low | Major |
2,738,784,131 | neovim | `vim.diagnostic.config` does not apply options returned from functions | ### Problem
`:h vim.diagnostic.Opts` says
```
Each of the configuration options below accepts one of the following:
โข `false`: Disable this feature
โข `true`: Enable this feature, use default settings.
โข `table`: Enable this feature with overrides. Use an empty table to use
default values.
โข `function`: Function with signature (namespace, bufnr) that returns any
of the above.
...
โข {float}? (`boolean|vim.diagnostic.Opts.Float|fun(namespace: integer, bufnr:integer): vim.diagnostic.Opts.Float`)
Options for floating windows. See
|vim.diagnostic.Opts.Float|.
```
but
```lua
vim.diagnostic.config({
float = {
border = 'rounded',
header = '',
scope = 'cursor',
},
})
```
and
```lua
vim.diagnostic.config({
float = function (namespace, bufnr)
return {
border = 'rounded',
header = '',
scope = 'cursor',
}
end,
})
```
have totally different behaviors; the function version doesn't seem to do anything at all.
### Steps to reproduce
Add
```lua
vim.diagnostic.config({
float = function (namespace, bufnr)
return {
border = 'rounded',
header = '',
scope = 'cursor',
}
end,
})
```
to your config and open a diagnostic floating window `vim.diagnostic.show_float()`
### Expected behavior
Should look the same as
```lua
vim.diagnostic.config({
float = {
border = 'rounded',
header = '',
scope = 'cursor',
},
})
```
### Nvim version (nvim -v)
v0.10.2
### Vim (not Nvim) behaves the same?
n/a
### Operating system/version
macOS 15.2
### Terminal name/version
Terminal.app
### $TERM environment variable
xterm-256color
### Installation
brew | bug,diagnostic | low | Minor |
2,738,794,544 | TypeScript | Adding documentation comments to the return values of destructuring syntax |
Type: <b>Feature Request</b>
- In ReactJS, we often write code similar to `const [stateX, setStateX] = useState({ ... });`.
- I would like to hover over the variable name `stateX` with the mouse in other places where this variable is used to get an explanation similar to JSDoc (not for type, but to more clearly annotate the purpose of the variable).
- The reason I think this way is because the following approach often works:
```typescript
/** It's a ref for X */
const refX = useRef({ ... });
```
(When I hover over the `refX` variable in other places where it is accessed, the tooltip can display the documentation "It's a ref for X".)
- However, I have not found any way to annotate without disrupting the original code structure, so that VSCode can recognize my documentary comments for the tuple.
- I'm not sure whether this should be considered a feature request or a bug report.
VS Code version: Code 1.95.3 (Universal) (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z)
OS version: Darwin arm64 22.3.0
Modes:
<!-- generated by issue reporter --> | Suggestion,Awaiting More Feedback | low | Critical |
2,738,806,293 | TypeScript | Include constant type properties in navtree | TypeScript code: Intl. DisplayNames.supportedLocalesOf ();
SupportedLocalesOf Go to Definitions and view the outline:
One is vscode and the other is WebStorm.
VScode does not have this outline item, WebStorm does
| Suggestion,Awaiting More Feedback | low | Minor |
2,738,834,831 | ollama | arch linux package missing cuda v11 runners | ### What is the issue?
After a recent update attempting run any previously functional models now leads to errors, ex;
```bash
ollama run codellama "Hello"
#> Error: POST predict: Post "http://127.0.0.1:41711/completion": EOF
```
### Meta/system-data
- Initially installed version (worked) `ollama-cuda-0.3.10-1-x86_64`
- Broken on or before `0.5.1-2`
- Installation method: `sudo packman -S ollama-cuda`
- Linux _flavor_: Arch (I use Arch BTWโข)
### Logs (snippet)
> `sudo journalctl -u ollama --no-pager | grep -C3 -i -- error | sed "s/$HOSTNAME/<HOST>/g"`
```
Dec 13 08:41:19 <HOST> ollama[6310]: time=2024-12-13T08:41:19.590-08:00 level=INFO source=server.go:594 msg="llama runner started in 1.01 seconds"
Dec 13 08:41:19 <HOST> ollama[6310]: [GIN] 2024/12/13 - 08:41:19 | 200 | 1.129576145s | 127.0.0.1 | POST "/api/generate"
Dec 13 08:41:23 <HOST> ollama[6310]: ggml_cuda_compute_forward: ADD failed
Dec 13 08:41:23 <HOST> ollama[6310]: CUDA error: no kernel image is available for execution on the device
Dec 13 08:41:23 <HOST> ollama[6310]: current device: 0, in function ggml_cuda_compute_forward at llama/ggml-cuda.cu:2403
Dec 13 08:41:23 <HOST> ollama[6310]: err
Dec 13 08:41:23 <HOST> ollama[6310]: llama/ggml-cuda.cu:132: CUDA error
Dec 13 08:41:23 <HOST> ollama[6310]: ptrace: Operation not permitted.
Dec 13 08:41:23 <HOST> ollama[6310]: No stack.
Dec 13 08:41:23 <HOST> ollama[6310]: The program is not being run.
--
Dec 13 08:42:16 <HOST> ollama[6310]: time=2024-12-13T08:42:16.962-08:00 level=INFO source=server.go:376 msg="starting llama server" cmd="/usr/lib/ollama/runners/cuda_v12_avx/ollama_llama_server runner --model /var/lib/ollama/blobs/sha256-1cecc26325a197571a1961bfacf64dc6e35e0f05faf57d3c6941a982e1eb2e1d --ctx-size 2048 --batch-size 512 --n-gpu-layers 25 --threads 4 --parallel 1 --port 40811"
Dec 13 08:42:16 <HOST> ollama[6310]: time=2024-12-13T08:42:16.962-08:00 level=INFO source=sched.go:449 msg="loaded runners" count=1
Dec 13 08:42:16 <HOST> ollama[6310]: time=2024-12-13T08:42:16.962-08:00 level=INFO source=server.go:555 msg="waiting for llama runner to start responding"
Dec 13 08:42:16 <HOST> ollama[6310]: time=2024-12-13T08:42:16.962-08:00 level=INFO source=server.go:589 msg="waiting for server to become available" status="llm server error"
Dec 13 08:42:16 <HOST> ollama[6310]: time=2024-12-13T08:42:16.998-08:00 level=INFO source=runner.go:946 msg="starting go runner"
Dec 13 08:42:16 <HOST> ollama[6310]: time=2024-12-13T08:42:16.999-08:00 level=INFO source=runner.go:947 msg=system info="AVX = 1 | AVX_VNNI = 0 | AVX2 = 0 | AVX512 = 0 | AVX512_VBMI = 0 | AVX512_VNNI = 0 | AVX512_BF16 = 0 | FMA = 0 | NEON = 0 | SVE = 0 | ARM_FMA = 0 | F16C = 0 | FP16_VA = 0 | RISCV_VECT = 0 | WASM_SIMD = 0 | BLAS = 1 | SSE3 = 1 | SSSE3 = 1 | VSX = 0 | MATMUL_INT8 = 0 | LLAMAFILE = 1 | cgo(gcc)" threads=4
Dec 13 08:42:16 <HOST> ollama[6310]: time=2024-12-13T08:42:16.999-08:00 level=INFO source=.:0 msg="Server listening on 127.0.0.1:40811"
--
Dec 13 08:42:52 <HOST> ollama[6310]: time=2024-12-13T08:42:52.414-08:00 level=INFO source=server.go:594 msg="llama runner started in 35.45 seconds"
Dec 13 08:42:52 <HOST> ollama[6310]: [GIN] 2024/12/13 - 08:42:52 | 200 | 40.77210645s | 127.0.0.1 | POST "/api/generate"
Dec 13 08:43:07 <HOST> ollama[6310]: ggml_cuda_compute_forward: ADD failed
Dec 13 08:43:07 <HOST> ollama[6310]: CUDA error: no kernel image is available for execution on the device
Dec 13 08:43:07 <HOST> ollama[6310]: current device: 0, in function ggml_cuda_compute_forward at llama/ggml-cuda.cu:2403
Dec 13 08:43:07 <HOST> ollama[6310]: err
Dec 13 08:43:07 <HOST> ollama[6310]: llama/ggml-cuda.cu:132: CUDA error
Dec 13 08:43:07 <HOST> ollama[6310]: ptrace: Operation not permitted.
Dec 13 08:43:07 <HOST> ollama[6310]: No stack.
Dec 13 08:43:07 <HOST> ollama[6310]: The program is not being run.
```
### Questions
- Are there any additional details needed or wanted?
- Any advice on testing intervening versions for when breaking changes were introduced?
### Attachments
[ollama-cuda-error.log](https://github.com/user-attachments/files/18129248/ollama-cuda-error.log)
### OS
Linux
### GPU
Nvidia
### CPU
Intel
### Ollama version
0.5.1
______
## Updates
### 2024-12-13 09:15 -0800
Possible answer to; `Any advice on testing intervening versions for when breaking changes were introduced?`
Arch `pacman` archives for `ollama-cuda` are available via;
https://archive.archlinux.org/packages/o/ollama-cuda/
Steps to test:
0. Make a directory path for saving logs
```bash
mkdir -vp "${HOME}/Documents/logs/pacman/downgrade"
```
1. Set some Bash variables
```bash
_version='0.3.9-2'
_url="https://archive.archlinux.org/packages/o/ollama-cuda/ollama-cuda-${_version}-x86_64.pkg.tar.zst"
```
> Note: as of 09:58 -0800 incrementally downgrading to version `0.3.9-2` finally lead to joy!
2. Downgrade package to target `_version`
```bash
script -ac "sudo pacman -U ${_url}" "${HOME}/Documents/logs/pacman/downgrade/ollama-cuda-${_version}.script"
```
3. Restart service
```bash
sudo systemctl restart ollama.service
```
4. Test if things work now
```
ollama run codellama "Hello"
#> Error: POST predict: Post "http://127.0.0.1:37775/completion": EOF
```
If things no work, then update `_version` and `_url` variables and try again from that step onward.
| bug | low | Critical |
2,738,839,787 | node | node:net blocklist upgrade | ### What is the problem this feature will solve?
the save of the blocklist into the disk to not have do reblock manualy
### What is the feature you are proposing to solve the problem?
a parameter in the class named file who is the storage off the rules
### What alternatives have you considered?
manualy create a loader | feature request | low | Minor |
2,738,840,616 | PowerToys | [QuickAccent] Missing ฤ for Slovenian | ### Microsoft PowerToys version
0.84.0
### Installation method
PowerToys auto-update
### Running as admin
No
### Area(s) with issue?
Quick Accent
### Steps to reproduce
While Slovenian doesn't use ฤ in words, this letter is common in surnames. For QuickAccent to be fully complete for Slovenian, this letter is required.
How to reproduce: Set QuickAccent to Slovenian and press C + Space on the keyboard.
### โ๏ธ Expected Behavior
Both ฤ and ฤ should show up in the list. In this order, since ฤ is more common.
### โ Actual Behavior
Only ฤ is displayed.
### Other Software
_No response_ | Issue-Bug,Status-In progress,Product-Quick Accent | low | Minor |
2,738,865,602 | pytorch | Define release branch creation readiness process | ### ๐ Describe the bug
It feels like current process for creating release branch is based purely on the date, not on some state of release readiness.
In my opinion, it would be good to have a list of well defined criteria that must be made before release branch as created. Few of those:
- CI for all HW/SW architectures important to release must be green
- Binary builds for all respective architecture should complete and pass some basic smoke tests
- (Optional, but was used in the past ) Branch base must be merged thru DiffTrain
### Versions
nightly? | oncall: releng,triaged | low | Critical |
2,738,866,647 | flutter | Zero-width character (\u200b) does not have zero-width | ### Steps to reproduce
1. Copy-paste the code sample in DartPad
2. Run it with the `useScaffold` flag set to true
3. Run it with the `useScaffold` flag set to false
4. Compare results
### Expected results
I expect the zero-width characters in the string to have zero width, even when many such characters are placed in sequence.
### Actual results
When the text is placed in a Scaffold, the zero-width characters take up a lot of space when multiple are combined in sequence. See the attached screenshots. It does not happen if there is not a Material parent, and it does not seem to be an issue with the default Roboto font either. I presume it is an issue with the rendering engine.
I am creating these strings because I'm extending `TextEditingController`, where the stored `text` is different from what I want to display, and what I want to display is typically shorter than what I have stored, so I pad it with these zero-width characters to make the displayed text have the same length as the stored text for the sake of correcting cursor issues (the cursor shows weird behaviour when trying to navigate through text that has a different amount of characters compared to the controller's text).
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() => runApp(const MyApp());
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: const MyHomePage(),
);
}
}
class MyHomePage extends StatelessWidget {
const MyHomePage({super.key});
final String zeroWidthCharacter = '\u200b';
final useScaffold = false;
@override
Widget build(BuildContext context) {
final body = Center(
child: Column(
mainAxisSize: MainAxisSize.min,
children: [
Text('One${zeroWidthCharacter * 100}Two'),
Text('One${zeroWidthCharacter * 10}Two'),
Text('One${zeroWidthCharacter * 1}Two'),
Text('OneTwo'),
],
)
);
return useScaffold
? Scaffold(body: body)
: body;
}
}
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
<p>
<img src="https://github.com/user-attachments/assets/ad9d2c05-72a9-44c0-bb58-6fe34d918474"
alt="Behaviour of zero-width characters with a Material parent" height="240"/>
<img src="https://github.com/user-attachments/assets/983a9dd5-16a4-4e20-b569-d6e3b86f5ba8"
alt="Behaviour of zero-width characters without a Material parent" height="240"/>
</p>
</details>
### Logs
_No response_
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[โ] Flutter (Channel stable, 3.22.3, on Microsoft Windows [Version 10.0.22631.4460], locale en-GB)
โข Flutter version 3.22.3 on channel stable at C:\Users\wesse\fvm\versions\3.22.3
โข Upstream repository https://github.com/flutter/flutter.git
โข Framework revision b0850beeb2 (5 months ago), 2024-07-16 21:43:41 -0700
โข Engine revision 235db911ba
โข Dart version 3.4.4
โข DevTools version 2.34.3
[โ] Windows Version (Installed version of Windows is version 10 or higher)
[โ] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
โข Android SDK at C:\Users\wesse\AppData\Local\Android\Sdk
โข Platform android-34, build-tools 34.0.0
โข ANDROID_HOME = C:\Users\wesse\AppData\Local\Android\Sdk
โข Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java
โข Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
โข All Android licenses accepted.
[โ] Chrome - develop for the web
โข Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe
[โ] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.8.1)
โข Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community
โข Visual Studio Community 2022 version 17.8.34316.72
โข Windows 10 SDK version 10.0.22621.0
[โ] Android Studio (version 2022.3)
โข Flutter plugin can be installed from:
https://plugins.jetbrains.com/plugin/9212-flutter
โข Dart plugin can be installed from:
https://plugins.jetbrains.com/plugin/6351-dart
โข Java version OpenJDK Runtime Environment (build 17.0.6+0-b2043.56-10027231)
[โ] VS Code (version 1.96.0-insider)
โข VS Code at C:\Users\wesse\AppData\Local\Programs\Microsoft VS Code Insiders
โข Flutter extension version 3.102.0
[โ] Connected device (4 available)
โข SM A715F (mobile) โข R58N51AWRTP โข android-arm64 โข Android 13 (API 33)
โข Windows (desktop) โข windows โข windows-x64 โข Microsoft Windows [Version 10.0.22631.4460]
โข Chrome (web) โข chrome โข web-javascript โข Google Chrome 127.0.6533.74
โข Edge (web) โข edge โข web-javascript โข Microsoft Edge 131.0.2903.86
[โ] Network resources
โข All expected network resources are available.
โข No issues found!
```
</details>
| framework,dependency: skia,has reproducible steps,P3,team-engine,triaged-engine,found in release: 3.27,found in release: 3.28 | low | Minor |
2,738,868,310 | storybook | [BUG] Environment Variables Undefined After Adding Storybook Packages to Next.js 14 + NX 19 Project | ### Describe the bug
After adding any of the following Storybook packages (@storybook/nextjs, @storybook/react-webpack5, or @storybook/server-webpack5) to a Next.js 14 + NX 19 project, all environment variables become undefined after the build. The issue occurs even without implementing any Storybook-specific code. Changing the environment variable file from `.env.serve.local` to `.env` resolves the issue, but this is not a desirable solution since we need to use runtime environment variables with the serve prefix.
**Expected behavior:**
The environment variables should be accessible in runtime (after the build) with the serve prefix, and the Storybook packages should not interfere with this configuration.
**Actual behavior:**
When any of the mentioned Storybook packages are added to package.json, the environment variables become undefined after the build. This happens even if no code implementation for Storybook is added. Changing the file name from .env.serve.local to .env makes the variables accessible again, but this is not a desired solution since we need to inject environment variables during runtime, not at build time.
**Questions:**
How can I prevent Storybook packages from overwriting my existing environment variable configuration during build?
Is there a way to integrate Storybook with the existing runtime environment variable setup without causing issues with the build configuration?
### Reproduction link
-
### Reproduction steps
Steps to reproduce:
1) Set up a project using Next.js 14 and NX 19.
2) Configure environment variables in runtime (using `.env.serve.local` with a serve prefix as per [[NX's documentation]](https://nx.dev/recipes/tips-n-tricks/define-environment-variables)(https://nx.dev/recipes/tips-n-tricks/define-environment-variables)).
Only files with `serve` prefix, without original `.env file`
3) Add one of the following Storybook packages to package.json:
@storybook/nextjs
@storybook/react-webpack5
@storybook/server-webpack5
4) Build the application.
5) Run application using `serve:[appropriate prefix for the environment variable file]`
5) Observe that all environment variables are undefined in runtime
### System
```bash
OS: [e.g., macOS, Windows, Linux]
Node version: [e.g., 18.18.0]
Next.js version: 14.x
NX version: 19.x
```
### Additional context
1) The environment variables are correctly injected during runtime with the serve prefix (.env.serve.local).
2) The issue appears to stem from the configuration in the Storybook packages, which may be overriding the NX/webpack setup for environment variables.
3) We do not want to change the variable file naming convention to .env, as this would affect the runtime behavior. | bug,needs triage | low | Critical |
2,738,875,500 | pytorch | We should switch Tensor object (and other perf-critical objects) to use the new managed dict feature from CPython | This should lead to small perf benefit, in particular for programs using a lot of these objects.
This will be because the dict creation will be lazy (so not initialized when not used) and it's access will be more efficient within the object.
This is done by passing Py_TPFLAGS_MANAGED_DICT when creating the class and making sure it is properly propagated to the python version of Tensor.
cc @msaroufim | triaged,actionable,module: python frontend | low | Minor |
2,738,940,004 | flutter | Prepare to enable `explicit-package-dependencies` | This flag gates the new "label plugins as dev_dependencies" feature, as well as deprecates two old features:
- https://docs.flutter.dev/release/breaking-changes/flutter-generate-i10n-source
- https://docs.flutter.dev/release/breaking-changes/flutter-plugins-configuration
As of the time of this writing `flutter_tools/test/general.shard` has 100+ tests that fail with this flag enabled, mostly because they use `compute_dev_dependencies` transitively, and a fake `Pub` instance is not hooked up. I have yet to try the other test suites, but likely some fail in `commands.shard` and `integration.shard`.
Two options:
1. Opt failing tests out explicitly (turn off the feature), turn the feature on, work through failing tests
2. Fix failing tests before turning on the feature (opt-them in early)
Will chat with @bkonyi and @andrewkolos to figure out what they prefer.
My intuition is (2) leaves us in a better incremental state. Here is an example: https://github.com/flutter/flutter/pull/160258.
---
## TODOs
- [ ] Update `test/commands.shard/permeable/create_test.dart` (and `templates/skeleton`)
Potentially also a bug in `lib/src/dart/generate_synthetic_packages.dart` | P1,c: tech-debt,team-tool | medium | Critical |
2,738,952,422 | godot | Distant Shadow Splits have Wrong Bias | ### Tested versions
since https://github.com/godotengine/godot/pull/68339
### System information
Vulkan
### Issue description
https://github.com/godotengine/godot/pull/48776 and https://github.com/godotengine/godot/pull/68339 Modify Blur and Bias respectively, but the latter adjusts bias based on the non modified blur value and doesn't take blur modification that the first PR is doing inside the shader.
The bias modification code should be applied to the modified - Final blur values, not the base blur.
### Steps to reproduce
Observe Distant Splits bias increase as blur levels increase, without blending splits, and observe how blur levels are the same for the splits, but the bias still increases for those distant splits
### Minimal reproduction project (MRP)
N/A | bug,topic:rendering,topic:3d | low | Minor |
2,738,968,892 | next.js | Support node --conditions/-C as a `NODE_OPTION`. | ### Link to the code that reproduces this issue
https://github.com/Falven/turborepo/tree/feature/debugging
### To Reproduce
Run Nextjs with `NODE_OPTIONS -C=development`
> -C=development is not allowed in NODE_OPTIONS
### Current vs. Expected behavior
[Next.js should allow conditions, including community conditions.](https://nodejs.org/api/packages.html#packages_community_conditions_definitions)
### Provide environment information
```bash
Operating System:
Platform: darwin
Arch: arm64
Version: Darwin Kernel Version 24.2.0: Fri Dec 6 18:56:34 PST 2024; root:xnu-11215.61.5~2/RELEASE_ARM64_T6020
Available memory (MB): 32768
Available CPU cores: 12
Binaries:
Node: 22.11.0
npm: 10.9.0
Yarn: N/A
pnpm: 9.13.2
Relevant Packages:
next: 15.0.3 // There is a newer version (15.1.0) available, upgrade recommended!
eslint-config-next: 15.0.3
react: 19.0.0-rc-69d4b800-20241021
react-dom: 19.0.0-rc-69d4b800-20241021
typescript: 5.7.2
Next.js Config:
output: standalone
```
### Which area(s) are affected? (Select all that apply)
Developer Experience, Module Resolution, Output (export/standalone), Runtime, Turbopack, TypeScript, SWC, Webpack
### Which stage(s) are affected? (Select all that apply)
next dev (local), next build (local), next start (local)
### Additional context
_No response_ | SWC,Output (export/standalone),Webpack,TypeScript,Runtime,Turbopack,Module Resolution | low | Critical |
2,738,974,794 | terminal | Strange vertical transparent line appears when "Hide the title bar" is off | ### Windows Terminal version
1.21.3231.0
### Windows build number
10.0.26100.0
### Other Software
_No response_
### Steps to reproduce
1. Settings / Appearance / Hide the title bar (requires relaunch) -> OFF
2. Relaunch
### Expected Behavior
_No response_
### Actual Behavior
Strange vertical transparent line appears on the right side of the terminal.
(The line disappears in screenshots, so I had to take a photo with my phone.)
 | Help Wanted,Issue-Bug,Product-Terminal,Area-Windowing | low | Minor |
2,738,991,719 | ui | [bug]: CommandDialog Infinite Loop Freezes Page | ### Describe the bug
The CommandDialog goes into an infinite loop and freezes page, even with the most basic implementation.
### Affected component/components
CommandDialog
### How to reproduce
This broke everything in my app:
```
<CommandDialog
open
// open={isOpen}
// onOpenChange={(open) => handleIsOpen(open)} // Toggle `isOpen` only when needed
>
<CommandInput placeholder="Search country..." />
<CommandList>
<CommandItem>Calendar</CommandItem>
{/* {countries.map((country) => (
<CommandItem
key={country.isoCode}
onSelect={() => handleCountrySelect(country)}
className="flex items-center space-x-2"
>
<span
className={`flag-icon flag-icon-${country.isoCode.toLowerCase()}`}
/>
<span>{country.name}</span>
<span className="ml-auto text-muted">
{country.dialCode}
</span>
</CommandItem>
))} */}
</CommandList>
</CommandDialog>
```
### Codesandbox/StackBlitz link
NA
### Logs
```bash
NA
```
### System Info
```bash
node v20.10.0
next 15.0.4
chrome 130.0.6723.117
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,739,034,652 | vscode | Notebook: Selection Highlight Background | > Many of the highlighting differences between notebooks and python files have been reconciled in the Nov release 1.96, but I don't think this is one.
>
> Editor settings (for dramatic effect):
> "workbench.colorCustomizations": {
> "editor.selectionBackground": "#f00",
> "editor.selectionHighlightBackground": "#afb47f80",
> "editor.selectionHighlightBorder": "#ffffff91",
> }
>
> Python file:
> 
>
> Notebook file:
> 
>
> The python file highlight aligns with expectations but the notebook doesn't.
>
>
_Originally posted by @Wmuntean in [#200406](https://github.com/microsoft/vscode/issues/200406#issuecomment-2541784896)_
---
- VS Code Version: 1.96
| bug,notebook,editor-highlight | low | Minor |
2,739,064,470 | kubernetes | Metrics test should be using a fake deprecated API in testing | Came up from https://github.com/kubernetes/kubernetes/pull/128279#discussion_r1882520074
The metrics integration test need to test for metrics on a deprecated API. Unfortunately we nee d to update this every couple of releases as deprecated APIs become removed and puts a toll on maintainers: https://github.com/kubernetes/kubernetes/blob/master/test/integration/metrics/metrics_test.go#L121-L124
Per [Ben's comment](https://github.com/kubernetes/kubernetes/pull/128279#discussion_r1882905186):
> Actually discussed briefly with @jpbetz that since we run api-server in-process we could probably ... actually register an integration-test-only deprecated API that will be perpetually deprecated?
/cc @jpbetz @BenTheElder
/sig instrumentation
/sig api-machinery
| sig/api-machinery,sig/instrumentation,triage/accepted | low | Minor |
2,739,071,996 | go | net/http: request context cancelled on readtimeout, persists across connection reuse | ### Go version
go version go1.23.4 darwin/arm64
### Output of `go env` in your module/workspace:
```shell
GO111MODULE=''
GOARCH='arm64'
GOBIN=''
GOCACHE='/Users/jmaguire/Library/Caches/go-build'
GOENV='/Users/jmaguire/Library/Application Support/go/env'
GOEXE=''
GOEXPERIMENT=''
GOFLAGS=''
GOHOSTARCH='arm64'
GOHOSTOS='darwin'
GOINSECURE=''
GOMODCACHE='/Users/jmaguire/go/pkg/mod'
GONOPROXY='github.com/DefinedNet'
GONOSUMDB='github.com/DefinedNet'
GOOS='darwin'
GOPATH='/Users/jmaguire/go'
GOPRIVATE='github.com/DefinedNet'
GOPROXY='https://proxy.golang.org,direct'
GOROOT='/opt/homebrew/Cellar/go/1.23.4/libexec'
GOSUMDB='sum.golang.org'
GOTMPDIR=''
GOTOOLCHAIN='local'
GOTOOLDIR='/opt/homebrew/Cellar/go/1.23.4/libexec/pkg/tool/darwin_arm64'
GOVCS=''
GOVERSION='go1.23.4'
GODEBUG=''
GOTELEMETRY='local'
GOTELEMETRYDIR='/Users/jmaguire/Library/Application Support/go/telemetry'
GCCGO='gccgo'
GOARM64='v8.0'
AR='ar'
CC='cc'
CXX='c++'
CGO_ENABLED='1'
GOMOD='/dev/null'
GOWORK=''
CGO_CFLAGS='-O2 -g'
CGO_CPPFLAGS=''
CGO_CXXFLAGS='-O2 -g'
CGO_FFLAGS='-O2 -g'
CGO_LDFLAGS='-O2 -g'
PKG_CONFIG='pkg-config'
GOGCCFLAGS='-fPIC -arch arm64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -ffile-prefix-map=/var/folders/2t/rbxbv8612sq9_rdrxhtw8rzc0000gn/T/go-build1060450768=/tmp/go-build -gno-record-gcc-switches -fno-common'
```
### What did you do?
This code demonstrates an issue in Go HTTP/1.1 request handling when the following conditions are true:
- An incoming request has an empty body
- A `ResponseController` is created and `SetReadDeadline` is called
- The time spent processing the request exceeds the read deadline
When these conditions are true, the HTTP server will erroneously cancel the request context. Additionally, a substantial percentage of future requests made on this HTTP connection will have their context immediately canceled.
To reproduce the issue, run the script found here: https://go.dev/play/p/wiX9Fyt2S2s
### What did you see happen?
The expected result is that both requests return 200 OK. Instead, both requests return 408 Request Timeout.
### What did you expect to see?
We expect a `200 OK` for the first request because the docs for [`func (*ResponseController) SetReadDeadline`](https://pkg.go.dev/net/http#ResponseController.SetReadDeadline) state:
> SetReadDeadline sets the deadline for reading the entire request, including the body. Reads from the request body after the deadline has been exceeded will return an error. A zero value means no deadline.
>
> Setting the read deadline after it has been exceeded will not extend it.
Since the request contains no body to read, the read deadline should not have been exceeded.
A secondary problem is that when HTTP keep-alive is enabled, future requests made against this connection (which is not closed by the server) will also be immediately canceled when processing starts.
In the proof of concept, we expect a `200 OK` for the second request not only because is there no body to read, but this request uses a fast endpoint which returns well within the read deadline. Instead, the context is canceled as soon as we start processing the request. None of the conditions listed under the docs for [`func (*Request) Context`](https://pkg.go.dev/net/http#Request.Context) are true:
> For incoming server requests, the context is canceled when the client's connection closes, the request is canceled (with HTTP/2), or when the ServeHTTP method returns.
While we have not root-caused the issue with the read deadline being exceeded when there is no body (update: see comment https://github.com/golang/go/issues/70834#issuecomment-2546088897 below), we believe that the connection is not closed correctly for this read error due to the this context being unchecked for cancellation in the `for` loop directly below: https://github.com/golang/go/blob/8391579ecea7dede2f2c1dc79954131e1eae1ade/src/net/http/server.go#L2008-L2010
It is canceled by the call to `handleReadError` here: https://github.com/golang/go/blob/8391579ecea7dede2f2c1dc79954131e1eae1ade/src/net/http/server.go#L721
In our testing, some requests _do_ succeed on the reused connection, but many fail with immediate context cancellation. Attempting to manually read the (nonexistent) body in the handler prior to the read deadline does not prevent context cancellation (e.g. `io.Copy(io.Discard, r.Body)`.) If the client sends any data in the body, this issue does not occur (set `-body` flag.) Additionally, the HTTP/2 server is not affected by the read deadline bug nor the cross-request state contamination bug (set `-http2` flag.)
### Workaround
We are catching `context.Canceled` and calling `r.Header.Set("Connection", "close")` to ensure that the connection is not reused. We are also contemplating checking the `Content-Length` header to ensure it's non-zero before calling `SetReadDeadline`.
### Related Issues
- https://github.com/golang/go/issues/45559 complains that the HTTP/2 server closes the connection to the client when the deadline is exceeded and the context is canceled. We believe that this is in fact the correct behavior, and HTTP/1.1 server should be doing this as well. Once a read error is hit, the connection should not be reused.
- https://github.com/golang/go/issues/70833 is probably just a docs issue, but was discovered while investigating this bug. | NeedsInvestigation | low | Critical |
2,739,107,512 | flutter | Remove `WebGoldenComparator` | Update: It is now deprecated. When the HTML backend is removed, it can also be removed.
---
There are two interfaces with nearly identical roles in `flutter_test`:
- [`GoldenFileComparator`](https://api.flutter.dev/flutter/flutter_test/GoldenFileComparator-class.html) and the current implementation, [`goldenFileComparator`](https://api.flutter.dev/flutter/flutter_test/goldenFileComparator.html).
- [`WebGoldenComparator`](https://api.flutter.dev/flutter/flutter_test/WebGoldenComparator-class.html) and the current implementation, [`webGoldenComparator`](https://api.flutter.dev/flutter/flutter_test/webGoldenComparator.html).
The latter is only used in a web browser/web context, and the former is used otherwise.
For the workstream that will be making `package:integration_test` be able to take and compare screenshots, even on mobile devices (i.e. Android and iOS), we'll be bleeding the lines further - using `GoldenFileComparator` as a _proxy_, which coincidentally is almost exactly what `WebGoldenComparator` does.
Here is a draft PR where I do exactly that: <https://github.com/flutter/flutter/pull/160131>.
It would be nice for `flutter_test` to have a cleaner interface, and not have a web and non-web configuration. The interfaces are nearly identical. I've initially assigned this to `team-framework` as owners of `flutter_test` to give a reaction; feel free to reach out to me directly to discuss further. | P2,c: tech-debt,fyi-tool,team-web,triaged-web | low | Major |
2,739,133,761 | deno | Official Deno Version Manager | To have a seperate CLI application that will allow you to install and manage different versions of Deno and be the official way to install Deno.
Perhaps by adding new commands in deno such as...
```
deno set 2.0.0
deno install 2.0.0
deno default 2.0.0
deno list
```
And to allow deno to detect if a file in the directory demands the current deno version is changed such as a `deno-version.json` file
https://github.com/denoland/deno/discussions/26848 | cli,suggestion | low | Minor |
2,739,143,375 | pytorch | Runners, torchbench, & the future | The purpose of this issue is to centralize discussions regarding the state of our runners and torchbench, in particular what should be expected when they go through transitions. It is a bit of a weird issue as this does not point to any codebase problems with pytorch/pytorch, but the intended discussion group spans beyond pytorch/benchmark so I'm putting the issue here.
### Context
I recently wanted to send someone my optimizers unidash to discover that it was empty, oh no! I traced the problem back to the GHA in pytorch/benchmark that runs the benchmark (and writes the stats) to discover that it's been red again, for weeks, because the a100-runner runner it ran on had been removed: https://github.com/pytorch/benchmark/actions/workflows/userbenchmark-regression-detector.yml
I fixed it with @xuzhao9's help https://github.com/pytorch/benchmark/pull/2557 but two things picked at me:
(1) Not just my workflow, but all the userbenchmark workflows + anything else using A100 were not migrated, and were just failing: https://github.com/pytorch/benchmark/actions/workflows/userbenchmark-a100.yml and https://github.com/pytorch/benchmark/actions/workflows/v3-nightly.yml. Was I the first to notice because I'm the only one to care? Are there others who care but haven't been notified? We should migrate the workflows that do matter and delete the code for the ones that don't.
(2) It would have been nice to have a heads up. I believe there was a migration plan (cc @seemethere @malfet @pytorch/pytorch-dev-infra @jeanschmidt @atalman @xuzhao9) as I saw some budding draft PRs, though I would have expected for all usages of the runner to be migrated before the runner was removed completely. Is this incident a fluke or should I shift expectations?
### Questions to answer
(1) Across the repos in the org (not just pytorch/pytorch), what is the expected transition plan for when a runner will no longer be running anymore? cc @seemethere
(2) (or 1b) Does it matter whether it's a repo-level runner vs org-level runner?
(3) Do people care about the userbenchmarks in torchbench/are there owners (other than me)? If not, we should do a big code delete! cc @drisspg for torchao, @pytorch-dev-infra for nightly-V3.
(4) Is torchbench userbenchmarks still the recommended path for writing recurring benchmarks? Where are folks moving to? cc @xuzhao9
### What I ultimately care about
That my optim benchmarks will have a home to keep running, that they won't surprisingly break on me if we could help it! | module: ci,triaged | low | Major |
2,739,172,707 | tauri | [bug] Windows pixels mapping is inconsistent or broken | ### Describe the bug
On Windows, the events coordinates are incorrect and require mapping.
To me, multiplying both `x` and `y` by `window.devicePixelRatio` helped, but it breaks the logic on the other platforms.
What is the correct approach? I don't want to check `if (platform === 'windows')` ๐ฟ
### Reproduction
- Windows (in my case, Windows 11 with a high resolution monitor, if it might affect scale factors)
- Just a minimal `webviewWindow.listen('tauri://drag-drop', listener)` is enough
### Expected behavior
I need either to correct the coordinates or leave them as is.
Is there a variable or method for calculating it? It might check the platform under the hood but at least it will be internal Tauri logic.
I tried `scaleFactor` but it didn't help.
### Full `tauri info` output
```text
[โ] Environment
- OS: Windows 10.0.22631 x86_64 (X64)
โ WebView2: 131.0.2903.86
โ MSVC: Visual Studio Build Tools 2022
โ rustc: 1.83.0 (90b35a623 2024-11-26)
โ cargo: 1.83.0 (5ffbef321 2024-10-29)
โ rustup: 1.27.1 (54dd3d00f 2024-04-24)
โ Rust toolchain: stable-x86_64-pc-windows-msvc (default)
- node: 23.3.0
- yarn: 1.22.22
- npm: 10.9.0
[-] Packages
- tauri ๐ฆ: 2.1.1
- tauri-build ๐ฆ: 2.0.3
- wry ๐ฆ: 0.47.2
- tao ๐ฆ: 0.30.8
- @tauri-apps/api ๎: 2.1.1
- @tauri-apps/cli ๎: 2.1.0
[-] Plugins
- tauri-plugin-http ๐ฆ: 2.2.0
- @tauri-apps/plugin-http ๎: 2.2.0
- tauri-plugin-dialog ๐ฆ: 2.2.0
- @tauri-apps/plugin-dialog ๎: 2.2.0
- tauri-plugin-persisted-scope ๐ฆ: 2.2.0
- @tauri-apps/plugin-persisted-scope ๎: not installed!
- tauri-plugin-fs ๐ฆ: 2.2.0
- @tauri-apps/plugin-fs ๎: 2.0.3
- tauri-plugin-single-instance ๐ฆ: 2.2.0
- @tauri-apps/plugin-single-instance ๎: not installed!
- tauri-plugin-shell ๐ฆ: 2.2.0
- @tauri-apps/plugin-shell ๎: 2.0.1
- tauri-plugin-log ๐ฆ: 2.2.0
- @tauri-apps/plugin-log ๎: 2.0.1
- tauri-plugin-store ๐ฆ: 2.2.0
- @tauri-apps/plugin-store ๎: 2.1.0
- tauri-plugin-window-state ๐ฆ: 2.2.0
- @tauri-apps/plugin-window-state ๎: 2.2.0
- tauri-plugin-os ๐ฆ: 2.2.0
- @tauri-apps/plugin-os ๎: 2.2.0
[-] App
- build-type: bundle
- CSP: unset
- frontendDist: ../dist
- devUrl: http://localhost:1420/
- framework: React
- bundler: Vite
```
### Stack trace
_No response_
### Additional context
I'm trying to handle the Drag'n'Drop functionality, which already works smoothly on macOS and Linux (at least tested on Ubuntu). | type: bug,status: needs triage | low | Critical |
2,739,186,444 | next.js | Turbopack crashing in dev server after prolonged usage | ### Link to the code that reproduces this issue
https://github.com/soulr344/CGPA-calculator
### To Reproduce
Run the dev server continuously for some time (a day in my case). (The reproduction link is NOT related in this case, it's present just so the issue doesn't get closed by the bot)
### Current vs. Expected behavior
The turbopack dev server crashes after prolonged usage due to failing memory allocation. In this instance, it crashed after a day of continuous, uninterrupted usage.
Last lines in terminal:
```
<--- Last few GCs --->
[31799:0x3a034cb0] 23773750 ms: Mark-sweep (reduce) 3696.7 (3829.4) -> 3696.7 (3779.2) MB, 413.8 / 0.0 ms (average mu = 0.324, current mu = 0.037) last resort; GC in old space requested
[31799:0x3a034cb0] 23774179 ms: Mark-sweep (reduce) 3696.7 (3779.2) -> 3696.7 (3767.4) MB, 428.7 / 0.0 ms (average mu = 0.189, current mu = 0.000) last resort; GC in old space requested
<--- JS stacktrace --->
FATAL ERROR: CALL_AND_RETRY_LAST Allocation failed - JavaScript heap out of memory
1: 0xb9c1f0 node::Abort() [next-server (v15.1.0)]
2: 0xaa27ee [next-server (v15.1.0)]
3: 0xd73950 v8::Utils::ReportOOMFailure(v8::internal::Isolate*, char const*, bool) [next-server (v15.1.0)]
4: 0xd73cf7 v8::internal::V8::FatalProcessOutOfMemory(v8::internal::Isolate*, char const*, bool) [next-server (v15.1.0)]
5: 0xf3f18f v8::internal::HeapAllocator::AllocateRawWithRetryOrFailSlowPath(int, v8::internal::AllocationType, v8::internal::AllocationOrigin, v8::internal::AllocationAlignment) [next-server (v15.1.0)]
6: 0xf1f158 v8::internal::Factory::CodeBuilder::AllocateCode(bool) [next-server (v15.1.0)]
7: 0xf330cc v8::internal::Factory::CodeBuilder::BuildInternal(bool) [next-server (v15.1.0)]
8: 0xf33b1e v8::internal::Factory::CodeBuilder::Build() [next-server (v15.1.0)]
9: 0x15ed38e v8::internal::RegExpMacroAssemblerX64::GetCode(v8::internal::Handle<v8::internal::String>) [next-server (v15.1.0)]
10: 0x12b1e86 v8::internal::RegExpCompiler::Assemble(v8::internal::Isolate*, v8::internal::RegExpMacroAssembler*, v8::internal::RegExpNode*, int, v8::internal::Handle<v8::internal::String>) [next-server (v15.1.0)]
11: 0x12d1db7 v8::internal::RegExpImpl::Compile(v8::internal::Isolate*, v8::internal::Zone*, v8::internal::RegExpCompileData*, v8::base::Flags<v8::internal::RegExpFlag, int>, v8::internal::Handle<v8::internal::String>, v8::internal::Handle<v8::internal::String>, bool, unsigned int&) [next-server (v15.1.0)]
12: 0x12d2532 v8::internal::RegExpImpl::CompileIrregexp(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSRegExp>, v8::internal::Handle<v8::internal::String>, bool) [next-server (v15.1.0)]
13: 0x12d30ee v8::internal::RegExpImpl::IrregexpPrepare(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSRegExp>, v8::internal::Handle<v8::internal::String>) [next-server (v15.1.0)]
14: 0x12d3293 v8::internal::RegExpImpl::IrregexpExec(v8::internal::Isolate*, v8::internal::Handle<v8::internal::JSRegExp>, v8::internal::Handle<v8::internal::String>, int, v8::internal::Handle<v8::internal::RegExpMatchInfo>, v8::internal::RegExp::ExecQuirks) [next-server (v15.1.0)]
15: 0x12f862e v8::internal::Runtime_RegExpExec(int, unsigned long*, v8::internal::Isolate*) [next-server (v15.1.0)]
16: 0x17120b9 [next-server (v15.1.0)]
```
.next/trace:
[trace.txt](https://github.com/user-attachments/files/18131618/trace.txt)
### Provide environment information
```bash
Operating System:
Platform: linux
Arch: x64
Version: #1 SMP PREEMPT_DYNAMIC Fri, 22 Nov 2024 16:04:27 +0000
Available memory (MB): 31799
Available CPU cores: 32
Binaries:
Node: 22.6.0
npm: 10.7.0
Yarn: N/A
pnpm: N/A
Relevant Packages:
next: 15.1.0 // Latest available version is detected (15.1.0).
eslint-config-next: 15.1.0
react: 19.0.0
react-dom: 19.0.0
typescript: 5.7.2
Next.js Config:
output: N/A
```
### Which area(s) are affected? (Select all that apply)
Turbopack
### Which stage(s) are affected? (Select all that apply)
next dev (local)
### Additional context
_No response_ | Turbopack | low | Critical |
2,739,196,800 | ollama | Add an ollama example that enables users to chat with a code generation model and then tests the code generated by the model | Often times, code generated by code generation models such as qwen2.5-coder:7b is not perfect. It may not even be syntactically correct. I am proposing to add an example program, possibly derived from the the python-simplechat example, that extracts the code generated by the model and runs/tests it. The first iteration would only know to run python programs.
The name python-code-iterate sounds like a reasonable name for this example program
1. User enters a prompt e.g. write a python program to quantize a model stored in my local dir /home/userabc/model1
2. The model generates code for this task and provides it as part of its response, i.e. the 'assistant' message
3. Our new program python-code-iterate then asks the user whether to run the program and check output
4. If the user says yes, then python-code-iterate will use a subprocess to run the program and check return code, stdout and stderr
5. If the return code is non zero, then the stderr contents will be added as a user message and the chat will continue
6. repeat steps 2 to 5 till satisfactory results are obtained | feature request | low | Minor |
2,739,215,074 | PowerToys | Deprecate Video Conference Mute in v0.88 | ### Description of the new feature / enhancement
We're planning to remove Video Conference Mute (VCM) in v0.88. It has been in maintenance mode since v0.67, has low usage, and there are similar features already available in Windows. We appreciate everyone's contributions and we want to thank you all for continuing to support PowerToys. โค
### Scenario when this would be used?
If you still want access to the source code, you can find it in a previous release's tree: https://github.com/microsoft/PowerToys/tree/v0.86.0
### Supporting information
_No response_ | Resolution-Fix Committed,Product-Video Conference Mute,Issue-Task | medium | Major |
2,739,216,294 | go | runtime: map cold cache improvements | There is room for improvement when some or all of a map is not in cache. The hierarchical design we use to enable incremental growth leaves us with several different allocations that can experience cache misses:
1. The Map itself (on [m.Used](https://cs.opensource.google/go/go/+/master:src/internal/runtime/maps/runtime_fast32_swiss.go;l=24;drc=dce30a19200d06b778fa90c96231b3cf71fe72d8))
1. The directory slice (on [m.directoryAt](https://cs.opensource.google/go/go/+/master:src/internal/runtime/maps/runtime_fast32_swiss.go;l=56;drc=dce30a19200d06b778fa90c96231b3cf71fe72d8))
1. The table (on [t.groups.lengthMask](https://cs.opensource.google/go/go/+/master:src/internal/runtime/maps/runtime_fast32_swiss.go;l=59;drc=dce30a19200d06b778fa90c96231b3cf71fe72d8))
1. The control word (on [matchH2](https://cs.opensource.google/go/go/+/master:src/internal/runtime/maps/runtime_fast32_swiss.go;l=63;drc=dce30a19200d06b778fa90c96231b3cf71fe72d8))
1. The slot key (on [key comparison](https://cs.opensource.google/go/go/+/master:src/internal/runtime/maps/runtime_fast32_swiss.go;l=69;drc=dce30a19200d06b778fa90c96231b3cf71fe72d8))
1. The slot value (on access in the caller)
(4), (5), and (6) are in the same object, so they may share a cache line depending on how far apart they are.
Some changes that may help (or may make things worse!):
* Grouping control words together ([prototype](https://go.dev/cl/635756)).
* Good for locality of control words. Probably most useful for lookup of keys that aren't in the map (as the key has worse locality with the control word).
* Also good for optimistic prefetch of the first control word, something that [Abseil does](https://github.com/abseil/abseil-cpp/blob/7316f5616bad0a794b2a75901cc20b0099718085/absl/container/internal/raw_hash_set.h#L4052).
* Change the directory from `[]*table` to `[]table` ([prototype](https://go.dev/cl/635757)).
* Effectively merges cases (2) and (3).
* Store group data directly in the table. The table becomes variable size, with a `table8` containing 1 group, `table16` containing 2 groups, and so on up to `table1024`.
* Effectively merges cases (3) and (4).
* Allows optimistic prefetch of the control word / first key before even touching the table as they are at fixed offsets.
* We'd likely want to store the size in the directory as well to enable above.
* This is unfortunately mutually exclusive with the previous option, as the table is variable-sized.
There is also the question of whether to store the key and value together (KVKVKV...), as we do today, or to group the keys together (KKKVVV...), as we do in the old maps. Both cases have pros and cons:
K/V together:
* Map hit
* Cache miss on control word
* Cache miss on key comparison
* No cache miss on value use in parent
* Map miss
* Cache miss on control word
* Cache miss on key comparison in false positive matches (~1%)
* No value
All keys together:
* Map hit
* Cache miss on control word
* No cache miss on key comparison
* Cache miss on value use in parent (if used)
* Map miss
* Cache miss on control word
* No cache miss on key comparison in false positive matches (~1%)
* No value
| Performance,NeedsInvestigation,compiler/runtime | low | Minor |
2,739,217,798 | flutter | Should the defaults for `TestFeatureFlags` represent the real defaults? | `TestFeatureFlags` is used to enable or disable flags explicitly in unit tests:
https://github.com/flutter/flutter/blob/2948917a470470c1ee2a3b5897dc229417776829/packages/flutter_tools/test/src/fakes.dart#L469-L486
However, the defaults are (except for the case of CLI animations) always `false`. That means if you want to enable a flag for a test, you need to also know what other flags were _implicitly_ enabled before by not having any `FeatureFlags` override. Should these default values instead be the same defaults, say, on the master branch? | c: proposal,c: tech-debt,team-tool | low | Minor |
2,739,218,743 | flutter | Buttons are mis-aligned in NavigationRail samples | ### Steps to reproduce
Check out the NavigationRail API docs: https://api.flutter.dev/flutter/material/NavigationRail-class.html
### Expected results
Buttons should be aligned.
### Actual results
<img src="https://github.com/user-attachments/assets/a9f64dc7-2b35-42d1-9fa9-d7e5c77be3f5" height=640>
### Code sample
<details open><summary>Code sample</summary>
```dart
~
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[Paste your output here]
```
</details>
| framework,f: material design,waiting for PR to land (fixed),d: api docs,d: examples,P2,team-design,triaged-design | low | Minor |
2,739,221,020 | flutter | Should we remove `FeatureFlags` that are both true and never intended to be false at this point? | For example, these come to mind:
https://github.com/flutter/flutter/blob/2948917a470470c1ee2a3b5897dc229417776829/packages/flutter_tools/lib/src/features.dart#L21-L37
What is the value in keeping these as flags? | c: proposal,P3,c: tech-debt,team-tool,triaged-tool | low | Minor |
2,739,222,517 | ui | [feat]: Missing data table's pagination, adding columns, rows and rows expansion as part of Figma's component | ### Feature description
Hey!
I'd like see if you guys could improve the data table component in FIgma (and possibily showcase it in the Docs site as well).
It's been difficult to meet design needs with the way the component was laid down.
Suggestions:
1. Add more columns and rows (like you did with Tabs maybe)
2. Make the columns resizable
3. Better align column header label and rows values
4. Add a flag to show pagination
5. Add rows expansion (for secondary information without having to open the record)
6. Add a slot option in the cell so we can replace text by another component
7. Overflow button expanded
In your "Table" component there are some nice flags already, maybe can re-use some of that.
Thank you in advance for your attention!
### Affected component/components
Data table
### Additional Context
If you want an example of all those suggestions, Data Table from Carbon Design System has them:
https://carbondesignsystem.com/components/data-table/usage/
Once thing they did as well, was to group rows instead of columns, so you can see another type of approach to create the component if it makes more sense.
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Minor |
2,739,226,515 | go | maps: optimized Clone with swissmaps | Prior to swissmaps, we had an [optimized implementation](https://cs.opensource.google/go/go/+/master:src/runtime/map_noswiss.go;l=1654;drc=1f8fa4941f632575468498bfac48fc1cbbf1a54f) of `maps.Clone` that reached into the internals to copy directly between the backing store of each map.
That was dropped when implementing swissmaps, but could be brought back. | Performance,NeedsFix,compiler/runtime | low | Minor |
2,739,240,193 | go | runtime: reduce duplicate work by merging map operations | ```
default := ...
v, ok := m[k]
if !ok {
m[k] = default
v = default
}
// Use v
```
This is a `mapaccess2` followed (conditionally) by a `mapassign`. The beginning of `mapassign` is identical to `mapaccess2`: hashing the key and looking for an existing entry (which won't be found).
In theory, the compiler could detect this pattern and use a special call for the map assignment that avoids the duplicate work (this would effectively be `internal/runtime/maps.(*table).uncheckedPutSlot` in today's implementation).
Another pattern is iteration plus delete:
```
for k := range m {
if iDontLikeIt {
delete(m, k)
}
}
```
It could be optimized in a similar way. This is also `maps.DeleteFunc` which could be directly specialized more easily than adding new compiler optimizations. | Performance,NeedsInvestigation,compiler/runtime | low | Major |
2,739,249,659 | PowerToys | [Remap shortcut] run program: running program window is not active (loose focus?). | ### Microsoft PowerToys version
0.86.0
### Installation method
Microsoft Store
### Running as admin
None
### Area(s) with issue?
Keyboard Manager
### Steps to reproduce
Remap shortcut -> new shortcut: ANY shortcut
action: Run program
App: ANY, ex. notepad.exe
Args: none
Elevation: normal
If running: Show window
Visibility: normal
### โ๏ธ Expected Behavior
Selected application is running and it's main window became active. (in case of notepad, you can write into it)
### โ Actual Behavior
Application is running, but active application still has a focus. Therefore you need to switch to just runned application.
### Other Software
_No response_ | Issue-Bug,Product-Keyboard Shortcut Manager,Needs-Triage | low | Minor |
2,739,253,649 | pytorch | torch.onnx.export fails with <class 'torch._dynamo.exc.UserError'>: Could not guard on data-dependent expression u1 < 0 (unhinted: u1 < 0). (Size-like symbols: none) | ### ๐ Describe the bug
```python
import torch
from detectron2.structures import ImageList
batched_inputs = [{"image": torch.randint(0, 256, (3, 1024, 1024), dtype=torch.uint8), "height": 1024, "width": 1024}]
class test_model(torch.nn.Module):
def __init__(self):
super(test_model, self).__init__()
def forward(self, batched_inputs):
images = [x["image"] for x in batched_inputs]
images = ImageList.from_tensors(images, 32)
return images
test_model_ = test_model()
torch.onnx.export(test_model_, (batched_inputs,), 'test_model.onnx', dynamo=True, verbose=True)
```
Failure:
orch.onnx._internal.exporter._errors.TorchExportError: Failed to export the model with torch.export. This is step 1/2 of exporting the model to ONNX. Next steps:
- Modify the model code for `torch.export.export` to succeed. Refer to https://pytorch.org/docs/stable/generated/exportdb/index.html for more information.
- Debug `torch.export.export` and summit a PR to PyTorch.
- Create an issue in the PyTorch GitHub repository against the *torch.export* component and attach the full error stack as well as reproduction scripts.
## Exception summary
<class 'torch._dynamo.exc.UserError'>: Could not guard on data-dependent expression u1 < 0 (unhinted: u1 < 0). (Size-like symbols: none)
Potential framework code culprit (scroll up for full backtrace):
File "/home/liqfu/.conda/envs/BiomedParse/lib/python3.11/site-packages/torch/_refs/__init__.py", line 2882, in constant_pad_nd
if pad[pad_idx + 1] < 0:
For more information, run with TORCH_LOGS="dynamic"
For extended logs when we create symbols, also add TORCHDYNAMO_EXTENDED_DEBUG_CREATE_SYMBOL="u1"
If you suspect the guard was triggered from C++, add TORCHDYNAMO_EXTENDED_DEBUG_CPP=1
For more debugging help, see https://docs.google.com/document/d/1HSuTTVvYH1pTew89Rtpeu84Ht3nQEFTYhAX3Ypa_xJs/edit?usp=sharing
User Stack (most recent call last):
(snipped, see stack below for prefix)
File "/home/liqfu/LiqunWA/BiomedParse/inference_utils/inference.py", line 10, in forward
images = ImageList.from_tensors(images, 32)
File "/home/liqfu/LiqunWA/detectron2/detectron2/structures/image_list.py", line 115, in from_tensors
batched_imgs = F.pad(tensors[0], padding_size, value=pad_value).unsqueeze_(0)
File "/home/liqfu/.conda/envs/BiomedParse/lib/python3.11/site-packages/torch/nn/functional.py", line 5096, in pad
return torch._C._nn.pad(input, pad, mode, value)
For C++ stack trace, run with TORCHDYNAMO_EXTENDED_DEBUG_CPP=1
For more information about this error, see: https://pytorch.org/docs/main/generated/exportdb/index.html#constrain-as-size-example
from user code:
File "/home/liqfu/LiqunWA/BiomedParse/inference_utils/inference.py", line 10, in forward
images = ImageList.from_tensors(images, 32)
File "/home/liqfu/LiqunWA/detectron2/detectron2/structures/image_list.py", line 115, in from_tensors
batched_imgs = F.pad(tensors[0], padding_size, value=pad_value).unsqueeze_(0)
File "/home/liqfu/.conda/envs/BiomedParse/lib/python3.11/site-packages/torch/nn/functional.py", line 5096, in pad
return torch._C._nn.pad(input, pad, mode, value)
Set TORCH_LOGS="+dynamo" and TORCHDYNAMO_VERBOSE=1 for more information
### Versions
Collecting environment information...
PyTorch version: 2.5.1
Is debug build: False
CUDA used to build PyTorch: 11.8
ROCM used to build PyTorch: N/A
OS: CBL-Mariner 2.0.20241208 (x86_64)
GCC version: (GCC) 11.2.0
Clang version: Could not collect
CMake version: version 3.31.0
Libc version: glibc-2.35
Python version: 3.11.10 (main, Oct 3 2024, 07:29:13) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.15.167.1-2.cm2-x86_64-with-glibc2.35
Is CUDA available: True
CUDA runtime version: 11.8.89
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA H100 80GB HBM3
GPU 1: NVIDIA H100 80GB HBM3
GPU 2: NVIDIA H100 80GB HBM3
GPU 3: NVIDIA H100 80GB HBM3
GPU 4: NVIDIA H100 80GB HBM3
GPU 5: NVIDIA H100 80GB HBM3
GPU 6: NVIDIA H100 80GB HBM3
GPU 7: NVIDIA H100 80GB HBM3
Nvidia driver version: 550.54.15
cuDNN version: Probably one of the following:
/usr/local/cuda-11.8/targets/x86_64-linux/lib/libcudnn.so.8.9.7
/usr/local/cuda-11.8/targets/x86_64-linux/lib/libcudnn_adv_infer.so.8.9.7
/usr/local/cuda-11.8/targets/x86_64-linux/lib/libcudnn_adv_train.so.8.9.7
/usr/local/cuda-11.8/targets/x86_64-linux/lib/libcudnn_cnn_infer.so.8.9.7
/usr/local/cuda-11.8/targets/x86_64-linux/lib/libcudnn_cnn_train.so.8.9.7
/usr/local/cuda-11.8/targets/x86_64-linux/lib/libcudnn_ops_infer.so.8.9.7
/usr/local/cuda-11.8/targets/x86_64-linux/lib/libcudnn_ops_train.so.8.9.7
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 46 bits physical, 57 bits virtual
Byte Order: Little Endian
CPU(s): 96
On-line CPU(s) list: 0-95
Vendor ID: GenuineIntel
Model name: Intel(R) Xeon(R) Platinum 8480C
CPU family: 6
Model: 143
Thread(s) per core: 1
Core(s) per socket: 48
Socket(s): 2
Stepping: 8
BogoMIPS: 4000.00
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology tsc_reliable nonstop_tsc cpuid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single fsgsbase tsc_adjust bmi1 hle avx2 smep bmi2 erms invpcid rtm avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves avx_vnni avx512_bf16 avx512vbmi umip waitpkg avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg avx512_vpopcntdq rdpid cldemote movdiri movdir64b fsrm serialize avx512_fp16 arch_capabilities
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 4.5 MiB (96 instances)
L1i cache: 3 MiB (96 instances)
L2 cache: 192 MiB (96 instances)
L3 cache: 210 MiB (2 instances)
NUMA node(s): 2
NUMA node0 CPU(s): 0-47
NUMA node1 CPU(s): 48-95
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Unknown: No mitigations
Vulnerability Reg file data sampling: Not affected
Vulnerability Retbleed: Vulnerable
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Retpoline
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Versions of relevant libraries:
[pip3] mypy-extensions==1.0.0
[pip3] numpy==1.26.4
[pip3] onnx==1.17.0
[pip3] onnxscript==0.1.0.dev20241208
[pip3] open_clip_torch==2.26.1
[pip3] torch==2.5.1
[pip3] torchaudio==2.5.1
[pip3] torchvision==0.20.1
[pip3] triton==3.1.0
[conda] blas 1.0 mkl
[conda] cuda-cudart 11.8.89 0 nvidia
[conda] cuda-cupti 11.8.87 0 nvidia
[conda] cuda-libraries 11.8.0 0 nvidia
[conda] cuda-nvrtc 11.8.89 0 nvidia
[conda] cuda-nvtx 11.8.86 0 nvidia
[conda] cuda-runtime 11.8.0 0 nvidia
[conda] ffmpeg 4.3 hf484d3e_0 pytorch
[conda] libcublas 11.11.3.6 0 nvidia
[conda] libcufft 10.9.0.58 0 nvidia
[conda] libcurand 10.3.7.77 0 nvidia
[conda] libcusolver 11.4.1.48 0 nvidia
[conda] libcusparse 11.7.5.86 0 nvidia
[conda] libjpeg-turbo 2.0.0 h9bf148f_0 pytorch
[conda] mkl 2023.1.0 h213fc3f_46344
[conda] mkl-service 2.4.0 py311h5eee18b_1
[conda] mkl_fft 1.3.11 py311h5eee18b_0
[conda] mkl_random 1.2.8 py311ha02d727_0
[conda] numpy 1.26.4 py311h08b1b3b_0
[conda] numpy-base 1.26.4 py311hf175353_0
[conda] open-clip-torch 2.26.1 pypi_0 pypi
[conda] pytorch 2.5.1 py3.11_cuda11.8_cudnn9.1.0_0 pytorch
[conda] pytorch-cuda 11.8 h7e8668a_6 pytorch
[conda] pytorch-mutex 1.0 cuda pytorch
[conda] torchaudio 2.5.1 py311_cu118 pytorch
[conda] torchtriton 3.1.0 py311 pytorch
[conda] torchvision 0.20.1 py311_cu118 pytorch | module: onnx,triaged,actionable | low | Critical |
2,739,263,794 | PowerToys | powertoys run: input smoothing not really being helpful and focusing on wrong files | ### Microsoft PowerToys version
0.86.0
### Installation method
PowerToys auto-update
### Running as admin
Yes
### Area(s) with issue?
PowerToys Run
### Steps to reproduce
i am using the voidtools Everything plugin (https://github.com/lin-ycv/EverythingPowerToys) with powertoys run.
i can't really give specific steps to reproduce but i'm sure people can figure out how to set up something like this situation:
i have a specific file i want to run (redo-online.sh)
i type "redo".
note that that result is not focused. powertoys run shows the voidtools plugin results with a split second delay (after the immediate results: notably apps/programs), causing the result from before the Everything plugin results to stay focused, but it also goes out of scroll view; at the bottom of the results list is this one focused
in a second scenario, i try being more specific. i type "redo o".
again, the correct result appears on the top of the list, but a split second after the other results. the actual result that appeared first on the list and is focused is...
again, you cannot see it is focused and only if you scroll down you see that THIS is the focused result.
(and yes, i did press enter and did accidentally just factory reset that program because of this.)
note that i have tried various input smoothing settings,
the best one so far is "immediate plugins" set to 300ms and "background execution plugins" set to 0. this almost makes them appear at the same time, but the immediate plugins still always appear before the voidtools results (even when i set "immediate plugins" to 500ms)
### โ๏ธ Expected Behavior
it would be way more useful if the result that stayed focused was the first one in the UI, and not the first one focused.
### โ Actual Behavior
(mentioned above, couldn't put it here because i have two separate scenarios that should be described in sequence)
### Other Software
Everything Powertoys plugin (https://github.com/lin-ycv/EverythingPowerToys) v0.86.0 | Issue-Bug,Product-PowerToys Run,Needs-Triage | low | Major |
2,739,340,594 | flutter | InputDecorator prefix and suffix text isn't included in semantics when TextField is wrapped in MergeSemantics. | ## Description
When creating a `TextField` (or `TextFormField`), there isn't a good way to merge the semantics of the prefix/suffix fields of an `InputDecorator`. If you do the obvious thing:
```dart
MergeSemantics(
child: Semantics(
label: 'Room Height',
child: TextField(
controller: _heightController,
keyboardType: TextInputType.number,
decoration: const InputDecoration(
prefixText: 'height',
suffixText: 'feet',
prefixStyle: TextStyle(color: Colors.red),
),
),
),
)
```
<details>
<summary>Semantic Tree</summary>
```
SemanticsNode#0
โ Rect.fromLTRB(0.0, 0.0, 1080.0, 2340.0)
โ
โโSemanticsNode#1
โ Rect.fromLTRB(0.0, 0.0, 411.4, 891.4) scaled by 2.6x
โ textDirection: ltr
โ
โโSemanticsNode#2
โ Rect.fromLTRB(0.0, 0.0, 411.4, 891.4)
โ sortKey: OrdinalSortKey#a7ceb(order: 0.0)
โ
โโSemanticsNode#3
โ Rect.fromLTRB(0.0, 0.0, 411.4, 891.4)
โ flags: scopesRoute
โ
โโSemanticsNode#6
โ Rect.fromLTRB(16.0, 24.5, 76.5, 55.5)
โ tags: []
โ label: "height"
โ textDirection: ltr
โ sortKey: OrdinalSortKey#c3609(name: "238345892", order: 0.0)
โ
โโSemanticsNode#4
โ merge boundary โ๏ธ
โ Rect.fromLTRB(16.0, 16.0, 395.4, 64.0)
โ actions: focus, moveCursorBackwardByCharacter,
โ moveCursorBackwardByWord, setSelection, setText, tap
โ flags: isTextField, isFocused, hasEnabledState, isEnabled
โ label: "Room Height"
โ value: ""
โ textDirection: ltr
โ sortKey: OrdinalSortKey#59316(name: "238345892", order: 1.0)
โ text selection: [3, 3]
โ currentValueLength: 3
โ
โโSemanticsNode#7
โ Rect.fromLTRB(357.6, 24.5, 395.4, 55.5)
โ tags: []
โ label: "feet"
โ textDirection: ltr
โ sortKey: OrdinalSortKey#390ca(name: "238345892", order: 2.0)
โ
โโSemanticsNode#5
Rect.fromLTRB(161.1, 64.0, 250.3, 112.0)
actions: focus, tap
flags: isButton, hasEnabledState, isEnabled, isFocusable
label: "Dump"
textDirection: ltr
thickness: 1.0
```
</details>
Then the semantics label you get on Talkback when the field is focused is "Room Height", not "Room Height height feet" (or, more usefully: "Room Height prefix height suffix feet" or something similar).
This is probably a design choice because people often put controls in the suffix and prefix fields, but if those are text (via `prefixText` and `suffixText`), then it seems like a good idea to merge their semantics somehow if there is a `MergeSemantics` around the text field.
Below is a simple reproduction case. Also, if you uncomment the `container: true`, then it merges in the prefix and suffix to the semantics nodes as expected, but Talkback doesn't read them, and you can no longer navigate to them (because they are merged in, which makes sense).
There needs to be a way to merge in the semantics so that a suffix or prefix will be read, but without it appearing to be part of the user's text (in Talkback).
```dart
import 'package:flutter/material.dart';
import 'package:flutter/rendering.dart';
void main() {
runApp(const MyApp());
}
class MyApp extends StatelessWidget {
const MyApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
appBar: AppBar(
title: const Text('Semantics Demo'),
),
body: const Center(
child: Padding(
padding: EdgeInsets.all(16.0),
child: HeightInput(),
),
),
),
);
}
}
class HeightInput extends StatefulWidget {
const HeightInput({super.key});
@override
State<HeightInput> createState() => _HeightInputState();
}
class _HeightInputState extends State<HeightInput> {
final TextEditingController _heightController = TextEditingController();
@override
void initState() {
super.initState();
_heightController.addListener(() {
if (_heightController.text.startsWith('d')) {
debugDumpSemanticsTree();
}
});
}
@override
Widget build(BuildContext context) {
return Column(
children: <Widget>[
MergeSemantics(
child: Semantics(
label: 'Room Height',
// container: true, // Uncomment this to see container effect.
child: TextField(
controller: _heightController,
keyboardType: TextInputType.text,
decoration: const InputDecoration(
prefixText: 'height',
suffixText: 'feet',
),
),
),
),
const ElevatedButton(
onPressed: debugDumpSemanticsTree,
child: Text('Dump'),
)
],
);
}
@override
void dispose() {
_heightController.dispose();
super.dispose();
}
}
```
<details>
<summary>Semantic Tree with container:true</summary>
```
SemanticsNode#0
โ Rect.fromLTRB(0.0, 0.0, 1080.0, 2340.0)
โ
โโSemanticsNode#1
โ Rect.fromLTRB(0.0, 0.0, 411.4, 891.4) scaled by 2.6x
โ textDirection: ltr
โ
โโSemanticsNode#2
โ Rect.fromLTRB(0.0, 0.0, 411.4, 891.4)
โ sortKey: OrdinalSortKey#317df(order: 0.0)
โ
โโSemanticsNode#3
โ Rect.fromLTRB(0.0, 0.0, 411.4, 891.4)
โ flags: scopesRoute
โ
โโSemanticsNode#7
โ โ Rect.fromLTRB(0.0, 0.0, 411.4, 97.1)
โ โ
โ โโSemanticsNode#8
โ Rect.fromLTRB(16.0, 51.1, 233.0, 87.1)
โ flags: isHeader, namesRoute
โ label: "Semantics Demo"
โ textDirection: ltr
โ
โโSemanticsNode#4
โ โ merge boundary โ๏ธ
โ โ Rect.fromLTRB(16.0, 113.1, 395.4, 161.1)
โ โ
โ โโSemanticsNode#9
โ โ merged up โฌ๏ธ
โ โ Rect.fromLTRB(0.0, 8.5, 60.5, 39.5)
โ โ tags: []
โ โ label: "height"
โ โ textDirection: ltr
โ โ sortKey: OrdinalSortKey#dbfb4(name: "859212319", order: 0.0)
โ โ
โ โโSemanticsNode#5
โ โ merged up โฌ๏ธ
โ โ Rect.fromLTRB(0.0, 0.0, 379.4, 48.0)
โ โ actions: focus, setSelection, setText, tap
โ โ flags: isTextField, isFocused, hasEnabledState, isEnabled
โ โ label: "Room Height"
โ โ textDirection: ltr
โ โ sortKey: OrdinalSortKey#3e8c4(name: "859212319", order: 1.0)
โ โ text selection: [0, 0]
โ โ currentValueLength: 0
โ โ
โ โโSemanticsNode#10
โ merged up โฌ๏ธ
โ Rect.fromLTRB(341.6, 8.5, 379.4, 39.5)
โ tags: []
โ label: "feet"
โ textDirection: ltr
โ sortKey: OrdinalSortKey#bbdd6(name: "859212319", order: 2.0)
โ
โโSemanticsNode#6
Rect.fromLTRB(161.1, 161.1, 250.3, 209.1)
actions: focus, tap
flags: isButton, hasEnabledState, isEnabled, isFocusable
label: "Dump"
textDirection: ltr
thickness: 1.0
I/flutter ( 8407):
```
</details>
<details>
<summary>flutter doctor -v</summary>
```
[!] Flutter (Channel [user-branch], 3.27.0-1.0.pre.523, on macOS 14.7.1 23H222 darwin-arm64, locale en)
! Flutter version 3.27.0-1.0.pre.523 on channel [user-branch] at /Users/user/code/flutter
Currently on an unknown channel. Run `flutter channel` to switch to an official channel.
If that doesn't fix the issue, reinstall Flutter by following instructions at https://flutter.dev/setup.
! Upstream repository [email protected]:gspencergoog/flutter.git is not a standard remote.
Set environment variable "FLUTTER_GIT_URL" to [email protected]:gspencergoog/flutter.git to dismiss this error.
โข Framework revision 71faeb3b12 (4 weeks ago), 2024-11-15 13:58:02 -0800
โข Engine revision 619804c0fb
โข Dart version 3.7.0 (build 3.7.0-140.0.dev)
โข DevTools version 2.41.0-dev.2
โข If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to
perform update checks and upgrades.
[โ] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
โข Android SDK at /Users/user/Library/Android/sdk
โข Platform android-35, build-tools 34.0.0
โข ANDROID_HOME = /Users/user/Library/Android/sdk
โข Java binary at: /opt/homebrew/opt/openjdk/bin/java
โข Java version OpenJDK Runtime Environment Homebrew (build 23.0.1)
โข All Android licenses accepted.
[โ] Xcode - develop for iOS and macOS (Xcode 15.0.1)
โข Xcode at /Applications/Xcode.app/Contents/Developer
โข Build 15A507
โข CocoaPods version 1.16.2
[โ] Chrome - develop for the web
โข Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome
[โ] Android Studio (version 2022.1)
โข Android Studio at /Applications/Android Studio.app/Contents
โข Flutter plugin can be installed from:
๐จ https://plugins.jetbrains.com/plugin/9212-flutter
โข Dart plugin can be installed from:
๐จ https://plugins.jetbrains.com/plugin/6351-dart
โข Java version OpenJDK Runtime Environment (build 11.0.15+0-b2043.56-8887301)
[โ] Android Studio (version 4.0)
โข Android Studio at /Users/user/Library/Application
Support/JetBrains/Toolbox/apps/AndroidStudio/ch-0/193.6514223/Android Studio.app/Contents
โข Flutter plugin can be installed from:
๐จ https://plugins.jetbrains.com/plugin/9212-flutter
โข Dart plugin can be installed from:
๐จ https://plugins.jetbrains.com/plugin/6351-dart
โข Java version OpenJDK Runtime Environment (build 1.8.0_242-release-1644-b3-6222593)
[โ] IntelliJ IDEA Community Edition (version 2022.1.3)
โข IntelliJ at /Applications/IntelliJ IDEA CE.app
โข Flutter plugin version 70.0.4
โข Dart plugin version 221.5921.27
[โ] VS Code (version 1.95.3)
โข VS Code at /Applications/Visual Studio Code.app/Contents
โข Flutter extension version 3.102.0
[โ] Connected device (4 available)
โข Pixel 7 Pro (mobile) โข 2A281FDH3004PL โข android-arm64 โข Android 15 (API 35)
โข macOS (desktop) โข macos โข darwin-arm64 โข macOS 14.7.1 23H222 darwin-arm64
โข Mac Designed for iPad (desktop) โข mac-designed-for-ipad โข darwin โข macOS 14.7.1 23H222 darwin-arm64
โข Chrome (web) โข chrome โข web-javascript โข Google Chrome 131.0.6778.140
[โ] Network resources
โข All expected network resources are available.
! Doctor found issues in 1 category.
```
</details> | framework,a: accessibility,c: proposal,P2,customer: quake (g3),team-accessibility,triaged-accessibility | low | Critical |
2,739,346,379 | vscode | During an edits generation, a scrollbar appears below the tab being edited | This only happened once so far, but I have tab wrapping enabled and a good amount of tabs open
<img width="1262" alt="Image" src="https://github.com/user-attachments/assets/c519edef-ed37-4f18-b415-693cc2d666bb" />
| bug,workbench-tabs | low | Minor |
2,739,357,893 | rust | Rust's `i128` return ABI does not agree with Clang and GCC on Windows targets | Originally reported at https://github.com/rust-lang/lang-team/issues/255#issuecomment-2214459945, Clang and GCC-MinGW return `__int128` in xmm0. Rust currently returns it on the stack.
@wesleywiser has a proposed patch to make Clang return on the stack for `-msvc` targets, while keeping the behavior for MinGW https://github.com/wesleywiser/llvm-project/commit/b2f8b8308bc25f81debe5bd99b02f497fdcc372a.
Rustc could probably just change the Windows ABI to always return in xmm0 for now, and then if the Clang patch lands we can change this to apply only to MinGW.
Demo: https://godbolt.org/z/o9h8We69o | A-LLVM,O-windows,T-compiler,C-bug,A-ABI | low | Minor |
2,739,357,952 | flutter | [ios] AdMob banner's touch is not blocked successfully for some cases | This is an issue I found while researching https://github.com/flutter/flutter/issues/158961. The 2 issues seem related, but that issue only happens on iOS 18.2, while this issue happens in previous iOS as well (tried on 18.1).
### Steps to reproduce
1. Running the attached code
2A. Tap the center dropdown menu to open it up
2B. Tap on the ad banner area that's **outside of the drop down menu**
2C. See the ad is clicked, which means drop down menu fails to block the touch.
3A. Tap the top right corner `...` menu to open it up
3B. Tap on the ad banner area outside of the drop down menu
3C. See the ad is not clicked, which means drop down menu successfully blocked the touch.
https://github.com/user-attachments/assets/6c5530bf-8794-4020-ba99-ba4e38c20938
### Code sample
<details open><summary>Dart code</summary>
```dart
// Copyright 2013 The Flutter Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
// ignore_for_file: public_member_api_docs
import 'dart:async';
import 'dart:convert';
import 'dart:io';
import 'package:flutter/foundation.dart';
import 'package:flutter/material.dart';
import 'package:path_provider/path_provider.dart';
import 'package:webview_flutter/webview_flutter.dart';
// #docregion platform_imports
// Import for Android features.
import 'package:webview_flutter_android/webview_flutter_android.dart';
// Import for iOS/macOS features.
import 'package:webview_flutter_wkwebview/webview_flutter_wkwebview.dart';
// #enddocregion platform_imports
import 'package:google_mobile_ads/google_mobile_ads.dart';
import 'package:collection/collection.dart';
typedef ColorEntry = DropdownMenuEntry<ColorLabel>;
// DropdownMenuEntry labels and values for the first dropdown menu.
enum ColorLabel {
blue('Blue', Colors.blue),
pink('Pink', Colors.pink),
green('Green', Colors.green),
yellow('Orange', Colors.orange),
grey('Grey', Colors.grey);
const ColorLabel(this.label, this.color);
final String label;
final Color color;
static final List<ColorEntry> entries = UnmodifiableListView<ColorEntry>(
values.map<ColorEntry>(
(ColorLabel color) => ColorEntry(
value: color,
label: color.label,
enabled: color.label != 'Grey',
style: MenuItemButton.styleFrom(
foregroundColor: color.color,
),
),
),
);
}
void main() => runApp(const MaterialApp(home: WebViewExample()));
const String kNavigationExamplePage = '''
<!DOCTYPE html><html>
<head><title>Navigation Delegate Example</title></head>
<body>
<p>
The navigation delegate is set to block navigation to the youtube website.
</p>
<ul>
<ul><a href="https://www.youtube.com/">https://www.youtube.com/</a></ul>
<ul><a href="https://www.google.com/">https://www.google.com/</a></ul>
</ul>
</body>
</html>
''';
const String kLocalExamplePage = '''
<!DOCTYPE html>
<html lang="en">
<head>
<title>Load file or HTML string example</title>
</head>
<body>
<h1>Local demo page</h1>
<p>
This is an example page used to demonstrate how to load a local file or HTML
string using the <a href="https://pub.dev/packages/webview_flutter">Flutter
webview</a> plugin.
</p>
</body>
</html>
''';
const String kTransparentBackgroundPage = '''
<!DOCTYPE html>
<html>
<head>
<title>Transparent background test</title>
</head>
<style type="text/css">
body { background: transparent; margin: 0; padding: 0; }
#container { position: relative; margin: 0; padding: 0; width: 100vw; height: 100vh; }
#shape { background: red; width: 200px; height: 200px; margin: 0; padding: 0; position: absolute; top: calc(50% - 100px); left: calc(50% - 100px); }
p { text-align: center; }
</style>
<body>
<div id="container">
<p>Transparent background test</p>
<div id="shape"></div>
</div>
</body>
</html>
''';
const String kLogExamplePage = '''
<!DOCTYPE html>
<html lang="en">
<head>
<title>Load file or HTML string example</title>
</head>
<body onload="console.log('Logging that the page is loading.')">
<h1>Local demo page</h1>
<p>
This page is used to test the forwarding of console logs to Dart.
</p>
<style>
.btn-group button {
padding: 24px; 24px;
display: block;
width: 25%;
margin: 5px 0px 0px 0px;
}
</style>
<div class="btn-group">
<button onclick="console.error('This is an error message.')">Error</button>
<button onclick="console.warn('This is a warning message.')">Warning</button>
<button onclick="console.info('This is a info message.')">Info</button>
<button onclick="console.debug('This is a debug message.')">Debug</button>
<button onclick="console.log('This is a log message.')">Log</button>
</div>
</body>
</html>
''';
class WebViewExample extends StatefulWidget {
const WebViewExample({super.key});
@override
State<WebViewExample> createState() => _WebViewExampleState();
}
class _WebViewExampleState extends State<WebViewExample> {
late final WebViewController _controller;
Widget _getBannerWidget() {
// Test IDs from Admob:
// https://developers.google.com/admob/ios/test-ads
// https://developers.google.com/admob/android/test-ads
final String bannerId = 'ca-app-pub-3940256099942544/2934735716';
final BannerAd bannerAd = BannerAd(
adUnitId: bannerId,
request: const AdRequest(),
size: AdSize.banner,
listener: const BannerAdListener(),
);
bannerAd.load();
return Align(
alignment: Alignment.bottomCenter,
// Use 320x50 Admob standard banner size.
child: SizedBox(
width: 320,
height: 50,
child: AdWidget(ad: bannerAd),
),
);
}
@override
void initState() {
super.initState();
// #docregion platform_features
late final PlatformWebViewControllerCreationParams params;
if (WebViewPlatform.instance is WebKitWebViewPlatform) {
params = WebKitWebViewControllerCreationParams(
allowsInlineMediaPlayback: true,
mediaTypesRequiringUserAction: const <PlaybackMediaTypes>{},
);
} else {
params = const PlatformWebViewControllerCreationParams();
}
final WebViewController controller =
WebViewController.fromPlatformCreationParams(params);
// #enddocregion platform_features
controller
..setJavaScriptMode(JavaScriptMode.unrestricted)
..setNavigationDelegate(
NavigationDelegate(
onProgress: (int progress) {
debugPrint('WebView is loading (progress : $progress%)');
},
onPageStarted: (String url) {
debugPrint('Page started loading: $url');
},
onPageFinished: (String url) {
debugPrint('Page finished loading: $url');
},
onWebResourceError: (WebResourceError error) {
debugPrint('''
Page resource error:
code: ${error.errorCode}
description: ${error.description}
errorType: ${error.errorType}
isForMainFrame: ${error.isForMainFrame}
''');
},
onNavigationRequest: (NavigationRequest request) {
if (request.url.startsWith('https://www.youtube.com/')) {
debugPrint('blocking navigation to ${request.url}');
return NavigationDecision.prevent;
}
debugPrint('allowing navigation to ${request.url}');
return NavigationDecision.navigate;
},
onHttpError: (HttpResponseError error) {
debugPrint('Error occurred on page: ${error.response?.statusCode}');
},
onUrlChange: (UrlChange change) {
debugPrint('url change to ${change.url}');
},
onHttpAuthRequest: (HttpAuthRequest request) {
openDialog(request);
},
),
)
..addJavaScriptChannel(
'Toaster',
onMessageReceived: (JavaScriptMessage message) {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(content: Text(message.message)),
);
},
)
..loadRequest(Uri.parse('https://flutter.dev'));
// setBackgroundColor is not currently supported on macOS.
if (kIsWeb || !Platform.isMacOS) {
controller.setBackgroundColor(const Color(0x80000000));
}
// #docregion platform_features
if (controller.platform is AndroidWebViewController) {
AndroidWebViewController.enableDebugging(true);
(controller.platform as AndroidWebViewController)
.setMediaPlaybackRequiresUserGesture(false);
}
// #enddocregion platform_features
_controller = controller;
}
final TextEditingController colorController = TextEditingController();
@override
Widget build(BuildContext context) {
return DefaultTabController(
initialIndex: 1,
length: 3,
child:
Scaffold(
backgroundColor: Colors.green,
appBar: AppBar(
title: const Text('Flutter WebView example'),
// This drop down menu demonstrates that Flutter widgets can be shown over the web view.
actions: <Widget>[
NavigationControls(webViewController: _controller),
SampleMenu(webViewController: _controller),
],
),
// body: WebViewWidget(controller: _controller),
body: SafeArea(
child: Column(children: <Widget>[
DropdownMenu<ColorLabel>(
initialSelection: ColorLabel.green,
controller: colorController,
// requestFocusOnTap is enabled/disabled by platforms when it is null.
// On mobile platforms, this is false by default. Setting this to true will
// trigger focus request on the text field and virtual keyboard will appear
// afterward. On desktop platforms however, this defaults to true.
requestFocusOnTap: true,
label: const Text('Color'),
onSelected: (ColorLabel? color) {
},
dropdownMenuEntries: ColorLabel.entries,
),
_getBannerWidget(),
Expanded(
child: Stack(
children: [
WebViewWidget(controller: _controller),
])),
])),
// SafeArea(child: <Widget>[
// // _getBannerWidget(),
// ]),
floatingActionButton: favoriteButton(),
)
);
}
Widget favoriteButton() {
return FloatingActionButton(
onPressed: () async {
final String? url = await _controller.currentUrl();
if (mounted) {
ScaffoldMessenger.of(context).showSnackBar(
SnackBar(content: Text('Favorited $url')),
);
}
},
child: const Icon(Icons.favorite),
);
}
Future<void> openDialog(HttpAuthRequest httpRequest) async {
final TextEditingController usernameTextController =
TextEditingController();
final TextEditingController passwordTextController =
TextEditingController();
return showDialog(
context: context,
barrierDismissible: false,
builder: (BuildContext context) {
return AlertDialog(
title: Text('${httpRequest.host}: ${httpRequest.realm ?? '-'}'),
content: SingleChildScrollView(
child: Column(
mainAxisSize: MainAxisSize.min,
children: <Widget>[
TextField(
decoration: const InputDecoration(labelText: 'Username'),
autofocus: true,
controller: usernameTextController,
),
TextField(
decoration: const InputDecoration(labelText: 'Password'),
controller: passwordTextController,
),
],
),
),
actions: <Widget>[
// Explicitly cancel the request on iOS as the OS does not emit new
// requests when a previous request is pending.
TextButton(
onPressed: () {
httpRequest.onCancel();
Navigator.of(context).pop();
},
child: const Text('Cancel'),
),
TextButton(
onPressed: () {
httpRequest.onProceed(
WebViewCredential(
user: usernameTextController.text,
password: passwordTextController.text,
),
);
Navigator.of(context).pop();
},
child: const Text('Authenticate'),
),
],
);
},
);
}
}
enum MenuOptions {
showUserAgent,
listCookies,
clearCookies,
addToCache,
listCache,
clearCache,
navigationDelegate,
doPostRequest,
loadLocalFile,
loadFlutterAsset,
loadHtmlString,
transparentBackground,
setCookie,
logExample,
basicAuthentication,
}
class SampleMenu extends StatelessWidget {
SampleMenu({
super.key,
required this.webViewController,
});
final WebViewController webViewController;
late final WebViewCookieManager cookieManager = WebViewCookieManager();
@override
Widget build(BuildContext context) {
return PopupMenuButton<MenuOptions>(
key: const ValueKey<String>('ShowPopupMenu'),
onSelected: (MenuOptions value) {
switch (value) {
case MenuOptions.showUserAgent:
_onShowUserAgent();
case MenuOptions.listCookies:
_onListCookies(context);
case MenuOptions.clearCookies:
_onClearCookies(context);
case MenuOptions.addToCache:
_onAddToCache(context);
case MenuOptions.listCache:
_onListCache();
case MenuOptions.clearCache:
_onClearCache(context);
case MenuOptions.navigationDelegate:
_onNavigationDelegateExample();
case MenuOptions.doPostRequest:
_onDoPostRequest();
case MenuOptions.loadLocalFile:
_onLoadLocalFileExample();
case MenuOptions.loadFlutterAsset:
_onLoadFlutterAssetExample();
case MenuOptions.loadHtmlString:
_onLoadHtmlStringExample();
case MenuOptions.transparentBackground:
_onTransparentBackground();
case MenuOptions.setCookie:
_onSetCookie();
case MenuOptions.logExample:
_onLogExample();
case MenuOptions.basicAuthentication:
_promptForUrl(context);
}
},
itemBuilder: (BuildContext context) => <PopupMenuItem<MenuOptions>>[
const PopupMenuItem<MenuOptions>(
value: MenuOptions.showUserAgent,
child: Text('Show user agent'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.listCookies,
child: Text('List cookies'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.clearCookies,
child: Text('Clear cookies'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.addToCache,
child: Text('Add to cache'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.listCache,
child: Text('List cache'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.clearCache,
child: Text('Clear cache'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.navigationDelegate,
child: Text('Navigation Delegate example'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.doPostRequest,
child: Text('Post Request'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.loadHtmlString,
child: Text('Load HTML string'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.loadLocalFile,
child: Text('Load local file'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.loadFlutterAsset,
child: Text('Load Flutter Asset'),
),
const PopupMenuItem<MenuOptions>(
key: ValueKey<String>('ShowTransparentBackgroundExample'),
value: MenuOptions.transparentBackground,
child: Text('Transparent background example'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.setCookie,
child: Text('Set cookie'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.logExample,
child: Text('Log example'),
),
const PopupMenuItem<MenuOptions>(
value: MenuOptions.basicAuthentication,
child: Text('Basic Authentication Example'),
),
],
);
}
Future<void> _onShowUserAgent() {
// Send a message with the user agent string to the Toaster JavaScript channel we registered
// with the WebView.
return webViewController.runJavaScript(
'Toaster.postMessage("User Agent: " + navigator.userAgent);',
);
}
Future<void> _onListCookies(BuildContext context) async {
final String cookies = await webViewController
.runJavaScriptReturningResult('document.cookie') as String;
if (context.mounted) {
ScaffoldMessenger.of(context).showSnackBar(SnackBar(
content: Column(
mainAxisAlignment: MainAxisAlignment.end,
mainAxisSize: MainAxisSize.min,
children: <Widget>[
const Text('Cookies:'),
_getCookieList(cookies),
],
),
));
}
}
Future<void> _onAddToCache(BuildContext context) async {
await webViewController.runJavaScript(
'caches.open("test_caches_entry"); localStorage["test_localStorage"] = "dummy_entry";',
);
if (context.mounted) {
ScaffoldMessenger.of(context).showSnackBar(const SnackBar(
content: Text('Added a test entry to cache.'),
));
}
}
Future<void> _onListCache() {
return webViewController.runJavaScript('caches.keys()'
// ignore: missing_whitespace_between_adjacent_strings
'.then((cacheKeys) => JSON.stringify({"cacheKeys" : cacheKeys, "localStorage" : localStorage}))'
'.then((caches) => Toaster.postMessage(caches))');
}
Future<void> _onClearCache(BuildContext context) async {
await webViewController.clearCache();
await webViewController.clearLocalStorage();
if (context.mounted) {
ScaffoldMessenger.of(context).showSnackBar(const SnackBar(
content: Text('Cache cleared.'),
));
}
}
Future<void> _onClearCookies(BuildContext context) async {
final bool hadCookies = await cookieManager.clearCookies();
String message = 'There were cookies. Now, they are gone!';
if (!hadCookies) {
message = 'There are no cookies.';
}
if (context.mounted) {
ScaffoldMessenger.of(context).showSnackBar(SnackBar(
content: Text(message),
));
}
}
Future<void> _onNavigationDelegateExample() {
final String contentBase64 = base64Encode(
const Utf8Encoder().convert(kNavigationExamplePage),
);
return webViewController.loadRequest(
Uri.parse('data:text/html;base64,$contentBase64'),
);
}
Future<void> _onSetCookie() async {
await cookieManager.setCookie(
const WebViewCookie(
name: 'foo',
value: 'bar',
domain: 'httpbin.org',
path: '/anything',
),
);
await webViewController.loadRequest(Uri.parse(
'https://httpbin.org/anything',
));
}
Future<void> _onDoPostRequest() {
return webViewController.loadRequest(
Uri.parse('https://httpbin.org/post'),
method: LoadRequestMethod.post,
headers: <String, String>{'foo': 'bar', 'Content-Type': 'text/plain'},
body: Uint8List.fromList('Test Body'.codeUnits),
);
}
Future<void> _onLoadLocalFileExample() async {
final String pathToIndex = await _prepareLocalFile();
await webViewController.loadFile(pathToIndex);
}
Future<void> _onLoadFlutterAssetExample() {
return webViewController.loadFlutterAsset('assets/www/index.html');
}
Future<void> _onLoadHtmlStringExample() {
return webViewController.loadHtmlString(kLocalExamplePage);
}
Future<void> _onTransparentBackground() {
return webViewController.loadHtmlString(kTransparentBackgroundPage);
}
Widget _getCookieList(String cookies) {
if (cookies == '""') {
return Container();
}
final List<String> cookieList = cookies.split(';');
final Iterable<Text> cookieWidgets =
cookieList.map((String cookie) => Text(cookie));
return Column(
mainAxisAlignment: MainAxisAlignment.end,
mainAxisSize: MainAxisSize.min,
children: cookieWidgets.toList(),
);
}
static Future<String> _prepareLocalFile() async {
final String tmpDir = (await getTemporaryDirectory()).path;
final File indexFile = File(
<String>{tmpDir, 'www', 'index.html'}.join(Platform.pathSeparator));
await indexFile.create(recursive: true);
await indexFile.writeAsString(kLocalExamplePage);
return indexFile.path;
}
Future<void> _onLogExample() {
webViewController
.setOnConsoleMessage((JavaScriptConsoleMessage consoleMessage) {
debugPrint(
'== JS == ${consoleMessage.level.name}: ${consoleMessage.message}');
});
return webViewController.loadHtmlString(kLogExamplePage);
}
Future<void> _promptForUrl(BuildContext context) {
final TextEditingController urlTextController = TextEditingController();
return showDialog<String>(
context: context,
builder: (BuildContext context) {
return AlertDialog(
title: const Text('Input URL to visit'),
content: TextField(
decoration: const InputDecoration(labelText: 'URL'),
autofocus: true,
controller: urlTextController,
),
actions: <Widget>[
TextButton(
onPressed: () {
if (urlTextController.text.isNotEmpty) {
final Uri? uri = Uri.tryParse(urlTextController.text);
if (uri != null && uri.scheme.isNotEmpty) {
webViewController.loadRequest(uri);
Navigator.pop(context);
}
}
},
child: const Text('Visit'),
),
],
);
},
);
}
}
class NavigationControls extends StatelessWidget {
const NavigationControls({super.key, required this.webViewController});
final WebViewController webViewController;
@override
Widget build(BuildContext context) {
return Row(
children: <Widget>[
IconButton(
icon: const Icon(Icons.arrow_back_ios),
onPressed: () async {
if (await webViewController.canGoBack()) {
await webViewController.goBack();
} else {
if (context.mounted) {
ScaffoldMessenger.of(context).showSnackBar(
const SnackBar(content: Text('No back history item')),
);
}
}
},
),
IconButton(
icon: const Icon(Icons.arrow_forward_ios),
onPressed: () async {
if (await webViewController.canGoForward()) {
await webViewController.goForward();
} else {
if (context.mounted) {
ScaffoldMessenger.of(context).showSnackBar(
const SnackBar(content: Text('No forward history item')),
);
}
}
},
),
IconButton(
icon: const Icon(Icons.replay),
onPressed: () => webViewController.reload(),
),
],
);
}
}
```
</details>
<details open><summary>pubspec</summary>
```
name: webview_flutter_example
description: Demonstrates how to use the webview_flutter plugin.
publish_to: none
environment:
sdk: ^3.3.0
flutter: ">=3.19.0"
dependencies:
flutter:
sdk: flutter
path_provider: ^2.0.6
webview_flutter: ^4.7.0
# webview_flutter:
# # When depending on this package from a real application you should use:
# # webview_flutter: ^x.y.z
# # See https://dart.dev/tools/pub/dependencies#version-constraints
# # The example app is bundled with the plugin so we use a path dependency on
# # the parent directory to use the current plugin's version.
# path: ../
webview_flutter_android: ^3.0.0
webview_flutter_wkwebview: ^3.13.0
google_mobile_ads: ^5.2.0
dev_dependencies:
build_runner: ^2.1.5
espresso: ^0.4.0
flutter_test:
sdk: flutter
integration_test:
sdk: flutter
webview_flutter_platform_interface: ^2.10.0
flutter:
uses-material-design: true
assets:
- assets/sample_audio.ogg
- assets/sample_video.mp4
- assets/www/index.html
- assets/www/styles/style.css
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[Paste your output here]
```
</details>
| platform-ios,engine,P2,team-ios,triaged-ios | low | Critical |
2,739,367,978 | vscode | Create activation event/way for extensions to activate upon installation | <!-- โ ๏ธโ ๏ธ Do Not Delete This! feature_request_template โ ๏ธโ ๏ธ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
## Feature Request
It'd be great if there was an activation event/way for an extension to activate upon its installation, similar to how an extension's walkthroughs are automatically opened when the extension is installed. This would allow extensions to provide a more customized experience than what is possible with a walkthrough, without having to resort to using the `*` activation event.
Assuming this is to be done, it may also be nice to expose the activation event that activated an extension, to the extension. That way the extension can know it was activated for install vs just a "normal" activation. I can open that feature request as well if this feature is deemed doable.
## Alternative Solution Explored
1. Add a walkthrough to the extension
2. Listen to the `onWalkthrough` activation event for that walkthrough
Now, assuming the walkthrough is actually shown [when the docs say it should be](https://code.visualstudio.com/api/references/contribution-points#contributes.walkthroughs:~:text=Walkthroughs%20are%20automatically%20opened%20on%20install%20of%20your%20extension), the extension can be activated on install.
However, I've had trouble exploring this solution due to not being able to get a walkthrough to show more than once for an extension. | under-discussion,getting-started | low | Major |
2,739,371,572 | vscode | Improve linkification in notebook outputs | We currently have a set of issue for linkification for notebook outputs (e.g., error outputs). Here a couple of failing scenarios:
- [ ] broken when path contains space https://github.com/microsoft/vscode/issues/226882
- [ ] slash is linkified https://github.com/microsoft/vscode/issues/208935
- [ ] links in nested folders https://github.com/microsoft/vscode/issues/185205
- [ ] not rendered properly on Windows https://github.com/microsoft/vscode/issues/177854
- [ ] clicking directory link shows an error https://github.com/microsoft/vscode-python/issues/23999
We might need to revisit the linkification code and one alternative is xterm. | debt,notebook-output | low | Critical |
2,739,381,175 | pytorch | xpu: torch.nn.DataParallel fails on multi-XPU environment with "module 'torch._C' has no attribute '_scatter'" | With:
* Nightly PyTorch XPU:
* torch `2.6.0.dev20241209+xpu`
* torchaudio `2.5.0.dev20241209+xpu`
* torchvision `0.20.0.dev20241209+xpu`
* https://github.com/huggingface/transformers/commit/add53e25ffa3d1750a944086d2fbb016aee35406
`torch.nn.DataParallel` fails on multi-XPU environment with: `"AttributeError: module 'torch._C' has no attribute '_scatter'"`. This can be reproduced on Huggingface Transformers tests. One of the tests:
* https://github.com/huggingface/transformers/blob/add53e25ffa3d1750a944086d2fbb016aee35406/tests/models/vits/test_modeling_vits.py#L195
```
$ cat spec.py
import torch
DEVICE_NAME = 'xpu'
MANUAL_SEED_FN = torch.xpu.manual_seed
EMPTY_CACHE_FN = torch.xpu.empty_cache
DEVICE_COUNT_FN = torch.xpu.device_count
$ TRANSFORMERS_TEST_DEVICE_SPEC=spec.py python3 -m pytest tests/models/ -k test_multi_gpu_data_parallel_forward
<...>
tensor = _handle_complex(tensor)
if out is None:
devices = [_get_device_index(d) for d in devices]
> return tuple(torch._C._scatter(tensor, devices, chunk_sizes, dim, streams))
E AttributeError: module 'torch._C' has no attribute '_scatter'
../../miniforge3/envs/xpu-nightly/lib/python3.12/site-packages/torch/nn/parallel/comm.py:205: AttributeError
------------------------------------------------------ Captured stdout call -------------------------------------------------------
pixel_values torch.Size([64, 3, 30, 30])
===================================================== short test summary info =====================================================
FAILED tests/models/falcon_mamba/test_modeling_falcon_mamba.py::FalconMambaModelTest::test_multi_gpu_data_parallel_forward - AttributeError: module 'torch._C' has no attribute '_scatter'
FAILED tests/models/mamba/test_modeling_mamba.py::MambaModelTest::test_multi_gpu_data_parallel_forward - AttributeError: module 'torch._C' has no attribute '_scatter'
FAILED tests/models/splinter/test_modeling_splinter.py::SplinterModelTest::test_multi_gpu_data_parallel_forward - AttributeError: module 'torch._C' has no attribute '_scatter'
FAILED tests/models/vits/test_modeling_vits.py::VitsModelTest::test_multi_gpu_data_parallel_forward - AttributeError: module 'torch._C' has no attribute '_scatter'
FAILED tests/models/x_clip/test_modeling_x_clip.py::
Here we also overwrite some of the tests of test_modeling_common.py, as X-CLIP does not use input_ids, inputs_embeds,
attention_mask and seq_length.
::test_multi_gpu_data_parallel_forward - AttributeError: module 'torch._C' has no attribute '_scatter'
======================================== 5 failed, 346 skipped, 77245 deselected in 10.52s ========================================
```
CC: @gujinghui @EikanWang @fengyuan14 @guangyey @jgong5
cc @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @gujinghui @EikanWang @fengyuan14 @guangyey | oncall: distributed,triaged,module: xpu | low | Critical |
2,739,394,856 | TypeScript | Add a "Export unused declaration" codefix | ### ๐ Search Terms
fix unused
### โ
Viability Checklist
- [x] This wouldn't be a breaking change in existing TypeScript/JavaScript code
- [x] This wouldn't change the runtime behavior of existing JavaScript code
- [x] This could be implemented without emitting different JS based on the types of the expressions
- [x] This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
- [x] This isn't a request to add a new utility type: https://github.com/microsoft/TypeScript/wiki/No-New-Utility-Types
- [x] This feature would agree with the rest of our Design Goals: https://github.com/Microsoft/TypeScript/wiki/TypeScript-Design-Goals
### โญ Suggestion
Add a "Export unused declaration" codefix.
### ๐ Motivating Example
Before:
```ts
function Foo () {
}
```
After (depends on module type):
```ts
export function Foo () {
}
```
### ๐ป Use Cases
Sometime we may forget to export a declaration and hence the declaration is marked as unused.
To fix it, we have to back to export it manully, which is cumbersome. | Suggestion,Awaiting More Feedback | low | Minor |
2,739,402,765 | ui | [bug]: Build Error With Tailwind CSS Prefix `The 'border-border' class does not exist.` | ### Describe the bug
When working with a Next.js project using Tailwind CSS with a Prefix such as `tw-`, the project got Build Error below. It seem like there was a [PR 770](https://github.com/shadcn-ui/ui/pull/770) trying to fix this issue, but I am getting this error on a project I am working on, as well as from a newly created project for testing.
I read [someone noted on the PR](https://github.com/shadcn-ui/ui/pull/770#pullrequestreview-1506748574) that classes applied in the CSS is missing the prefix, and [someone updated stating fix was added to latest commit](https://github.com/shadcn-ui/ui/pull/770#issuecomment-1614471624), but I am still encountering this issue.
```
Error evaluating Node.js code
CssSyntaxError: /Users/yk/Desktop/Project/Repository/YK/T/napp/app/globals.css:1:1: The `border-border` class does not exist. If `border-border` is a custom class, make sure it is defined within a `@layer` directive.
```
<img width="971" alt="image" src="https://github.com/user-attachments/assets/432d5f59-79af-4452-b5ae-ecbf19898a0c" />
### Affected component/components
All
### How to reproduce
1. Create a Next.js application using `npx create-next-app@latest`
2. Navigate to the new application directory, update the project with `npx shadcn@latest init -d`
3. Update `tailwind.config.ts` with `prefix: "tw-",` under `export default` configuration
4. Update `components.json` configuration with `"prefix": "tw-"`
> Note: I tried with updating `tailwind.config.ts` first then running `npx shadcn@latest init -d`, but same result.
### Codesandbox/StackBlitz link
https://stackblitz.com/edit/stackblitz-starters-g75bc5hq?file=tailwind.config.ts,components.json
### Logs
```bash
Error evaluating Node.js code
CssSyntaxError: /Users/yk/Desktop/Project/Repository/YK/T/napp/app/globals.css:1:1: The `border-border` class does not exist. If `border-border` is a custom class, make sure it is defined within a `@layer` directive.
[at Input.error (turbopack://[project]/node_modules/postcss/lib/input.js:106:16)]
[at AtRule.error (turbopack://[project]/node_modules/postcss/lib/node.js:145:32)]
[at processApply (/Users/yk/Desktop/Project/Repository/YK/T/napp/node_modules/tailwindcss/lib/lib/expandApplyAtRules.js:380:29)]
[at /Users/yk/Desktop/Project/Repository/YK/T/napp/node_modules/tailwindcss/lib/lib/expandApplyAtRules.js:551:9]
[at /Users/yk/Desktop/Project/Repository/YK/T/napp/node_modules/tailwindcss/lib/processTailwindFeatures.js:55:50]
[at async plugins (/Users/yk/Desktop/Project/Repository/YK/T/napp/node_modules/tailwindcss/lib/plugin.js:38:17)]
[at async LazyResult.runAsync (turbopack://[project]/node_modules/postcss/lib/lazy-result.js:261:11)]
[at async transform (turbopack://[project]/postcss.config.mjs/transform.ts:79:34)]
[at async run (turbopack://[turbopack-node]/ipc/evaluate.ts:92:23)]
```
### System Info
```bash
System:
- macOS Sequoia 15.2 (24C101)
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,739,445,963 | godot | File picker can stall attempting to download off-device files from OneDrive | ### Tested versions
exhibits anomalous behavior:
v4.4.dev3.official [f4af8201b]
v4.4.dev6.official [1f47e4c4e]
does NOT exhibit behavior (works as expected);
v4.3.stable.official [77dcf97d8]
### System information
Godot v4.4.dev3 - Windows 10.0.22631 - Multi-window, 1 monitor - Vulkan (Forward+) - integrated AMD Radeon(TM) Graphics (Advanced Micro Devices, Inc.; 31.0.21024.11002) - AMD Ryzen 7 PRO 6850U with Radeon Graphics (16 threads)
### Issue description
Godot will become unresponsive and attempt to download from OneDrive if there are files in the root of the directory that are not stored on-device immediately on opening the file picker in order to open an existing project. If it's unable to download all files, it will hang. This is particularly problematic because Godot's default project directory, C:/Users/_username_/OneDrive/Documents, is synchronized with OneDrive by default.
You can work around this by creating a new, blank project by manually typing in a directory (opening the picker will cause the issue), going to the editor settings, and selecting a different default directory that's not synchronized with OneDrive.
Unsure if this extends to other kinds of symbolic links or non-local files.
I would recommend triaging by changing the default directory to C: if the problem can't be quickly resolved.
### Steps to reproduce
- put a large file in a OneDrive synchronized folder
- select "free up space" in Windows Explorer to move the file into the cloud
- open the Godot file picker in said directory
### Minimal reproduction project (MRP)
No project needed to reproduce, bug happens before getting to the editor. | bug,platform:windows,topic:core | low | Critical |
2,739,457,870 | ui | [bug]: Password input in multi-step form inherits value from previous step despite separate form instances | ### Describe the bug
When using Form and Input components in a multi-step form where one step collects an old password and the next step collects a new password:
1. The new password field in step 2 automatically inherits the old password value from step 1
2. This happens even when using completely separate useForm instances for each step
3. The form state (via watch() or logging) shows the correct empty value, but the input field visually displays the old password
4. The field becomes impossible to edit when using two separate forms, but becomes editable(while retaining the oldPassword value) if a single form is used.
### Affected component/components
Input, Form
### How to reproduce
1. Create a multi-step form using shadcn components
2. Step 1: Form with password input for "current password"
3. Step 2: Form with password input for "new password"
4. After entering current password and moving to step 2, the new password field is pre-filled
## Minimal Reproduction
```jsx
// frontend/src/components/Account/Info/PasswordUpdateDialog.js
import {
Form,
FormField,
FormItem,
FormLabel,
FormControl,
} from "@/components/ui/form";
import { Input } from "@/components/ui/input";
import { useState } from "react";
import { useForm } from "react-hook-form";
import {
Dialog,
DialogContent,
DialogHeader,
DialogTitle,
} from "@/components/ui/dialog";
import { Lock } from "lucide-react";
export default function PasswordUpdateDialog({ isOpen, onClose }) {
const [step, setStep] = useState(1);
const stepOneForm = useForm({
defaultValues: { oldPassword: "" },
});
const stepTwoForm = useForm({
defaultValues: { newPassword: "" },
});
return (
<Dialog
open={isOpen}
onOpenChange={(open) => {
if (!open) {
stepOneForm.reset();
stepTwoForm.reset();
}
onClose();
}}
>
<DialogContent className="sm:max-w-[425px]">
<DialogHeader>
<DialogTitle className="flex items-center gap-2">
<Lock className="h-4 w-4" /> Change Password
</DialogTitle>
</DialogHeader>
{step === 1 ? (
<Form {...stepOneForm}>
<form>
<FormField
control={stepOneForm.control}
name="oldPassword"
render={({ field }) => (
<FormItem>
<FormLabel>Current Password</FormLabel>
<FormControl>
<Input type="password" {...field} />
</FormControl>
</FormItem>
)}
/>
<button onClick={() => setStep(2)}>Next</button>
</form>
</Form>
) : (
<Form {...stepTwoForm}>
<form>
<FormField
control={stepTwoForm.control}
name="newPassword"
render={({ field }) => (
<FormItem>
<FormLabel>New Password</FormLabel>
<FormControl>
<Input type="password" {...field} />
</FormControl>
</FormItem>
)}
/>
</form>
</Form>
)}
</DialogContent>
</Dialog>
);
}
```
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
node v20.10.0
Chrome 131.0.6778.86
Safari 19616.2.9.11.12
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,739,468,591 | flutter | [flutter_markdown] New lines (`\n`) do not behave as expected. | ### The problems
- `\n` by itself doesn't work inside the markdown widget unless there are 2 spaces before it like ` \n`.
- `\n\n\n` and `\n\n\n\n` (3, 4, or more) show the same as `\n\n`
### Steps to reproduce
~~~Dart
MarkdownBody(
data: """
Testing123 test123\nTesting123 test123 \nTesting123 test123\n\nTesting123 test123 \n\nTesting123 test123\n\n\nTesting123 \n\n\nTesting123 test123
```
code snippet here
asdasdad
```
asdasd
# Hi
asdasd\n\n\n\ntest
""",
);
~~~
<details>
<summary>Note<strong> (click to expand)</strong></summary>
Sorry, in the example images below, the colours might be different to yours because I also set the `Markdown` widget's `style` parameter to:
```Dart
final style = MarkdownStyleSheet.fromTheme(Theme.of(context)).copyWith(
p: Theme.of(context).textTheme.bodyMedium?.apply(
color: Theme.of(context).colorScheme.primary,
),
);
```
Also, I haven't tested on mobile, this is Flutter web.
</details>
### Expected results
### Actual results
### My temporary fix
~~~Dart
MarkdownBody(
data: """
Testing123 test123\nTesting123 test123 \nTesting123 test123\n\nTesting123 test123 \n\nTesting123 test123\n\n\nTesting123 \n\n\nTesting123 test123
```
code snippet here
asdasdad
```
asdasd
# Hi
asdasd\n\n\n\ntest
""",
);
String _fixMarkdownNewLines(String data) {
final codeBlockPattern =
RegExp(r'```.*?```', dotAll: true); // Matches code blocks
final nonCodeBlocks = <String>[];
final codeBlocks = <String>[];
// Split data into segments of code blocks and non-code blocks
final matches = codeBlockPattern.allMatches(data);
int lastMatchEnd = 0;
for (final match in matches) {
// Add text before the code block as a non-code block
if (match.start > lastMatchEnd) {
nonCodeBlocks.add(data.substring(lastMatchEnd, match.start));
}
// Add the code block itself
codeBlocks.add(data.substring(match.start, match.end));
lastMatchEnd = match.end;
}
// Add any remaining non-code block text
if (lastMatchEnd < data.length) {
nonCodeBlocks.add(data.substring(lastMatchEnd));
}
// Process non-code blocks (using \u200B as a temporary hack to show new lines):
final processedNonCodeBlocks = nonCodeBlocks.map((block) {
return block
.replaceAll(
'\n\n\n\n', '\n\n\n\u200B\n') // First replace quadruple newlines
.replaceAll('\n\n\n', '\n\n\u200B\n') // Then replace triple newlines
.replaceAll('\n', ' \n'); // Then replace single newlines
}).toList();
// Combine processed non-code blocks and code blocks back together
final buffer = StringBuffer();
int codeIndex = 0, nonCodeIndex = 0;
for (final _ in matches) {
if (nonCodeIndex < processedNonCodeBlocks.length) {
buffer.write(processedNonCodeBlocks[nonCodeIndex++]);
}
if (codeIndex < codeBlocks.length) {
buffer.write(codeBlocks[codeIndex++]);
}
}
// Add any remaining non-code block
if (nonCodeIndex < processedNonCodeBlocks.length) {
buffer.write(processedNonCodeBlocks[nonCodeIndex]);
}
return buffer.toString();
}
~~~ | package,team-ecosystem,has reproducible steps,P2,p: flutter_markdown,triaged-ecosystem,found in release: 3.27,found in release: 3.28 | low | Minor |
2,739,491,021 | langchain | DOC: Colab link routes to deadlink in 'Classify Text into Labels' tutorial | ### URL
https://python.langchain.com/docs/tutorials/classification/
### Checklist
- [X] I added a very descriptive title to this issue.
- [X] I included a link to the documentation page I am referring to (if applicable).
### Issue with current documentation:
The 'Open in Colab' .svg in the above [article](https://python.langchain.com/docs/tutorials/classification/) links to https://github.com/langchain-ai/langchain/blob/master/docs/docs/use_cases/tagging.ipynb. Which does not exist. I didn't find any other similar named notebooks in the updated docs directory.
### Idea or request for content:
_No response_ | ๐ค:docs | low | Minor |
2,739,492,256 | vscode | Opening a `devcontainer.json` file in a codespace opens a prompt to install git locally | <!-- โ ๏ธโ ๏ธ Do Not Delete This! bug_report_template โ ๏ธโ ๏ธ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- ๐ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- ๐ Search existing issues to avoid creating duplicates. -->
<!-- ๐งช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- ๐ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- ๐ง Launch with `code --disable-extensions` to check. -->
<!-- ๐ช If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- ๐ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.96.0
- OS Version: macOS 14.7.1
- Github Codespaces extension version: 1.17.3
1. Open a Github Codespace using the Codespaces extension
2. Open the `.devcontainer/devcontainer.json` file in the codespace
Then this window pops up:
<img width="497" alt="Image" src="https://github.com/user-attachments/assets/8b357253-d347-4d2e-9b8b-fdd90c90cc8e" />
It seems that opening a `devcontainer.json` file causes VS Code or the Codespaces extension to try to invoke `git` locally, which opens a window if the "command line tools" package from Apple isn't installed.
In my opinion, VS Code shouldn't be trying to invoke git locally if I am only using it to access a codespace. But if it is necessary, perhaps VS Code should first check if git is available. | info-needed,git | low | Critical |
2,739,504,736 | tauri | `tauri-runtime-wry` fails to create webview | We have instrumentation in our app that reports all warnings and errors logged. We've received a couple of alerts from the following line: https://github.com/tauri-apps/tauri/blob/ca7f025fd8666f8fce6894bb5e16cf2d4fc81e0c/crates/tauri-runtime-wry/src/lib.rs#L3551-L3558
> failed to create webview: WebView2 error: WindowsError(Error { code: HRESULT(0x8007139F), message: "The group or resource is not in the correct state to perform the requested operation." })
> failed to create webview: WebView2 error: WindowsError(Error { code: HRESULT(0x80070002), message: "Le fichier spรฉcifiรฉ est introuvable." })
> failed to create webview: WebView2 error: WindowsError(Error { code: HRESULT(0x8000FFFF), message: "Catastrophic failure" })
There isn't much we can do about these I guess but I figured it is worth reporting.
Ideally, those errors wouldn't be logged but instead, there would be a mechanism to report these problems to the app? On fatal errors like this, I guess the application should better exit but currently, there is no way to learn about this error. | type: bug,type: feature request | low | Critical |
2,739,572,165 | godot | Godot 3.x does not build with mbedTLS 3.x | ### Tested versions
- Reproducible in 3.6.stable
### System information
Debian 13 - Godot v3.6.stable
### Issue description
I'm currently working to get 3.6 packaged in Debian before moving on to 4.3.
https://github.com/godotengine/godot/commit/40fa684c181d3138d8f86c70e5933fb0b3dcbac8 added support to 4.3 for mbedTLS 3.x but this hasn't been backported to 3.x yet.
As Debian strives to minimize embedded code copies, particularly security-related ones, is there a possibility of this happening?
### Steps to reproduce
Try to build 3.6-stable with mbedTLS 3.x and `builtin_mbedtls=no`.
### Minimal reproduction project (MRP)
N/A | bug,enhancement,topic:thirdparty | low | Minor |
2,739,581,843 | godot | Compatibility Renderer: Environment Color Changed after Turn off Glow | ### Tested versions
v4.3.stable.official [77dcf97d8] and all the version of 4.0 (probably)
### System information
Godot v4.3.stable - Android - GLES3 (Compatibility) - Adreno (TM) 610 - (8 Threads)
### Issue description
I had a environment with colorful objects. When I turn on the glow in Compatibility Renderer everything was normal. But when I just turn off the glow my colorful environment turn into dry environment. Here is the preview.
Glow Off:
Glow On:
Glow off after On:
above preview has minimal things. But still difference between screenshot 1 and screenshot 3 is notice able.
### Steps to reproduce
- created colorful environment
- turn on glow
- turn off glow
### Minimal reproduction project (MRP)
[big-problem.zip](https://github.com/user-attachments/files/18134356/big-problem.zip)
| bug,topic:rendering | low | Minor |
2,739,581,853 | godot | Variants aren't valid keys in typed dictionaries when using 'operator[]' unless assigned | ### Tested versions
Current master: v4.4.dev.custom_build [dc5f1b7a2]
### System information
Godot v4.4.dev (dc5f1b7a2) - Windows 10.0.22631 - Multi-window, 1 monitor - Vulkan (Mobile) - dedicated NVIDIA GeForce RTX 4090 (NVIDIA; 32.0.15.6094) - AMD Ryzen 9 7950X 16-Core Processor (32 threads)
### Issue description
Sorry about the title, found just before going to sleep ๐ . Typed dictionary doesn't allow assigning variants, excluding objects, as keys when the type of the dictionarys value is not a variant... unless the key is explicitly converted to a variant! Just see the code below, much simpler... _Good Night!_ ๐ด
๐ค and some lines are not colored safe. Breaks the pretty colored streak of numbers : ( ๐ค
### Steps to reproduce
```gdscript
var d1: Dictionary[int, int] = { 0 : 0 } # Works and safe
d1[1] = 1 # Works and safe
var d2: Dictionary[int, Variant] = { 0 : 0 } # Works and safe
d2[1] = 1 as Variant # Works but unsafe
d2[1] = 1 # Works but unsafe
var d3: Dictionary[Variant, Variant] = { 0 : 0 } # Works and safe
d3[1 as Variant] = 1 as Variant # Works but unsafe
d3[1] = 1 # Works but unsafe
var d4: Dictionary[Variant, int] = { 0 : 0 } # Works and safe
d4[Object.new()] = 1 # Works and safe
d4[1 as Variant] = 1 # Works and safe
d4[1] = 1 # Doesn't work, error:
# ERROR Invalid index type "int" for a base of type "Dictionary[Variant, int]".
```
### Minimal reproduction project (MRP)
Contains same code as above [arraytypebug.zip](https://github.com/user-attachments/files/18134325/arraytypebug.zip)
| bug,topic:gdscript | low | Critical |
2,739,585,191 | godot | 4.3: Android Editor: Unable to Drag and Drop Files from File System | ### Tested versions
v4.3.stable.official [77dcf97d8]
### System information
Godot v4.3.stable - Android - GLES3 (Compatibility) - Adreno (TM) 610 - (8 Threads)
### Issue description
In Godot Android Editor file can't be drag and drop from file system. Like if i try to drag and image/textures. It can't be drag.
releted:
https://github.com/godotengine/godot/issues/100308#issue-2735639155
### Steps to reproduce
Toggle file system.
try to drag any file
### Minimal reproduction project (MRP)
N/A | bug,platform:android,topic:editor,usability,regression | low | Minor |
2,739,682,964 | godot | Lightmap baking transferring incorrect edges to adjacent faces | ### Tested versions
v4.4.dev6.official [1f47e4c4e]
### System information
Godot v4.4.dev (aa287f7e7) - Windows 10.0.19045 - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated Radeon RX 5500 XT (Advanced Micro Devices, Inc.; 32.0.11027.1003) - AMD Ryzen 7 5800X 8-Core Processor (16 threads)
### Issue description
Baked lightmaps appear to have darken edges or light leaks, both when generating UV2 or importing a model from Blender with a pre-generated UV2
No amount of tweaking settings removes the problem fully. After testing a lightmap UV generated in blender I noticed misalignment
After locating and rotating the misaligned UV by 180, the texture lines up, but a darkened seam appeared
After rotating the first tris back and rotating its neighbours, the alignment is corrected and the incorrect seam is gone. The edge bleed generator correctly extends the edge
Here is another example of a suspected "leak"
After rotating 180, the bottom edge (in world, side edge in UV) is corrected, but the side is now transferring the incorrect edge data
Given that the problem was transferred to the bottom edge of the UVs (left edge of wall) and not the opposite side, it might be that vertex winding order matters. Snapping to pixel centre or edge didn't seem to overly matter, only UV face orientation
### Steps to reproduce
Export a pre-lightmapped model, or auto generate light maps, setup scene and bake. (spend a few hours fiddling around with UV's in blender)
### Minimal reproduction project (MRP)
Let me know if you actually want the MRP, its a bit messy ๐ | bug,topic:rendering,topic:3d | low | Minor |
2,739,684,706 | flutter | Please emphasize "pinned" dependencies in `flutter pub get` summary. | Sometimes we need to "pin" a dependency version to certain version level to make things work, and often you forget that "pinning", since the summary of `flutter pub get` doesn't give you a note that this version is "pinned".
It would have been very helpful if `flutter pub get` showed a hint or warning that I have pinned this version, it is easy to forget and a `^` isn't always easy to spot...
| tool,c: proposal,team-tool | low | Minor |
2,739,699,538 | ui | [bug]: npx shadcn@latest add button | ### Describe the bug
npx shadcn@latest add button.
bug
### Affected component/components
button
### How to reproduce
yingyang@YingdeMacBook-Pro react-ts-dome % npx shadcn@latest add button
node:internal/modules/run_main:122
triggerUncaughtException(
^
Error: Cannot find package '/Users/yingyang/.npm/_npx/d66c5096c7023bfb/node_modules/npm-run-path/node_modules/path-key/index.js' imported from /Users/yingyang/.npm/_npx/d66c5096c7023bfb/node_modules/npm-run-path/index.js
Did you mean to import "path-key/index.js"?
at legacyMainResolve (node:internal/modules/esm/resolve:204:26)
at packageResolve (node:internal/modules/esm/resolve:846:14)
at moduleResolve (node:internal/modules/esm/resolve:926:18)
at defaultResolve (node:internal/modules/esm/resolve:1056:11)
at ModuleLoader.defaultResolve (node:internal/modules/esm/loader:654:12)
at #cachedDefaultResolve (node:internal/modules/esm/loader:603:25)
at ModuleLoader.resolve (node:internal/modules/esm/loader:586:38)
at ModuleLoader.getModuleJobForImport (node:internal/modules/esm/loader:242:38)
at ModuleJob._link (node:internal/modules/esm/module_job:135:49) {
code: 'ERR_MODULE_NOT_FOUND'
}
Node.js v22.12.0
### Codesandbox/StackBlitz link
_No response_
### Logs
_No response_
### System Info
```bash
web
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,739,708,405 | flutter | [video_player] Pub reports that the Package is not compatible with platform Web | ### What package does this bug report belong to?
video_player
### What target platforms are you seeing this bug on?
Web
### Have you already upgraded your packages?
Yes
### Dependency versions
<details><summary>pubspec.lock</summary>
```lock
N/A
```
</details>
### Steps to reproduce
1. Open https://pub.dev/packages/video_player/score
2. It says "Package not compatible with platform Web"
### Expected results
Since the package declares Web support, I would expect no issues reported on the score page.
### Actual results
It says "Package not compatible with platform Web"
Because:
package:video_player/video_player.dart that imports:
dart:io
Similarly, it reports there is no wasm support for the same reason.
Assuming the static analysis is as intended, it would be nice if this 1st party package set an example for how to conditionally import `dart:io`. Ironically, one of the main reasons Flutter plugins import `dart:io` is simply to do platform checks:
```dart
if (!kIsWeb && Platform.isXYZ)
```
So maybe there needs to be a more convenient way to do this that doesn't get flagged as not supporting web. Although in the case of video_player, it actually does use the `File` API.
### Code sample
<details open><summary>Code sample</summary>
```dart
N/A
```
</details>
### Screenshots or Videos
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
N/A
```
</details>
| p: video_player,package,team-ecosystem,P3,triaged-ecosystem | low | Critical |
2,739,739,400 | flutter | `OverscrollNotification` constructor throws assertion error without a message | ### Steps to reproduce
I put scrollbars using stack on top of InteractiveViewer and while testing I got this crash:
assert(overscroll.isFinite),
Stack trace:
_AssertionError._doThrowNew (d:\Programs\FlutterSDK\flutter\bin\cache\pkg\sky_engine\lib\_internal\vm\lib\errors_patch.dart:50)
_AssertionError._throwNew (d:\Programs\FlutterSDK\flutter\bin\cache\pkg\sky_engine\lib\_internal\vm\lib\errors_patch.dart:40)
new OverscrollNotification (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\widgets\scroll_notification.dart:242)
BallisticScrollActivity.dispatchOverscrollNotification (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\widgets\scroll_activity.dart:621)
ScrollPosition.didOverscrollBy (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\widgets\scroll_position.dart:1062)
ScrollPosition.setPixels (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\widgets\scroll_position.dart:393)
ScrollPositionWithSingleContext.setPixels (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\widgets\scroll_position_with_single_context.dart:87)
BallisticScrollActivity.applyMoveTo (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\widgets\scroll_activity.dart:608)
BallisticScrollActivity._tick (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\widgets\scroll_activity.dart:594)
AnimationLocalListenersMixin.notifyListeners (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\animation\listener_helpers.dart:161)
AnimationController._tick (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\animation\animation_controller.dart:921)
Ticker._tick (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\scheduler\ticker.dart:275)
SchedulerBinding._invokeFrameCallback (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\scheduler\binding.dart:1397)
SchedulerBinding.handleBeginFrame.<anonymous closure> (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\scheduler\binding.dart:1240)
_LinkedHashMapMixin.forEach (d:\Programs\FlutterSDK\flutter\bin\cache\pkg\sky_engine\lib\_internal\vm_shared\lib\compact_hash.dart:726)
SchedulerBinding.handleBeginFrame (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\scheduler\binding.dart:1238)
SchedulerBinding._handleBeginFrame (d:\Programs\FlutterSDK\flutter\packages\flutter\lib\src\scheduler\binding.dart:1155)
_invoke1 (d:\Programs\FlutterSDK\flutter\bin\cache\pkg\sky_engine\lib\ui\hooks.dart:328)
PlatformDispatcher._beginFrame (d:\Programs\FlutterSDK\flutter\bin\cache\pkg\sky_engine\lib\ui\platform_dispatcher.dart:405)
_beginFrame (d:\Programs\FlutterSDK\flutter\bin\cache\pkg\sky_engine\lib\ui\hooks.dart:272)
### Expected results
Proper exception message that is simple for the developer to understand.
### Actual results
(See stack trace in step to reproduce).
### Code sample
<details open><summary>Code sample</summary>
```dart
[Paste your code here]
```
</details>
### Screenshots or Video
<details open>
<summary>Screenshots / Video demonstration</summary>
[Upload media here]
</details>
### Logs
<details open><summary>Logs</summary>
```console
[Paste your logs here]
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
D:\flutter_checkouts\fast-integration>flutter doctor
Doctor summary (to see all details, run flutter doctor -v):
[โ] Flutter (Channel stable, 3.27.0, on Microsoft Windows [Version 10.0.26100.2454], locale en-IN)
[โ] Windows Version (Installed version of Windows is version 10 or higher)
[โ] Android toolchain - develop for Android devices (Android SDK version 34.0.0)
[โ] Chrome - develop for the web
[โ] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.13.0 Preview 1.0)
[โ] Android Studio (version 2022.3)
[โ] Connected device (3 available)
[โ] Network resources
โข No issues found!
```
</details>
| framework,f: scrolling,P3,team-framework,triaged-framework | low | Critical |
2,739,740,888 | go | net/http: TestServerCancelsReadTimeoutWhenIdle/h2 failures | ```
#!watchflakes
default <- pkg == "net/http" && test == "TestServerCancelsReadTimeoutWhenIdle/h2"
```
Issue created automatically to collect these failures.
Example ([log](https://ci.chromium.org/b/8728722762195289041)):
=== RUN TestServerCancelsReadTimeoutWhenIdle/h2
=== PAUSE TestServerCancelsReadTimeoutWhenIdle/h2
=== CONT TestServerCancelsReadTimeoutWhenIdle/h2
serve_test.go:5942: Server.Config.ReadTimeout = 10ms
clientserver_test.go:282: server log: http: TLS handshake error from 127.0.0.1:63166: write tcp 127.0.0.1:63167->127.0.0.1:63166: i/o timeout
serve_test.go:6038: retrying after error with duration 10ms: Get: Get "https://127.0.0.1:63167": EOF
serve_test.go:5942: Server.Config.ReadTimeout = 50ms
clientserver_test.go:282: server log: http: TLS handshake error from 127.0.0.1:63161: write tcp 127.0.0.1:63162->127.0.0.1:63161: i/o timeout
serve_test.go:6038: retrying after error with duration 50ms: Get: Get "https://127.0.0.1:63162": EOF
serve_test.go:5942: Server.Config.ReadTimeout = 250ms
clientserver_test.go:282: server log: http: TLS handshake error from 127.0.0.1:63159: write tcp 127.0.0.1:63160->127.0.0.1:63159: i/o timeout
serve_test.go:6038: retrying after error with duration 250ms: Get: Get "https://127.0.0.1:63160": EOF
serve_test.go:5942: Server.Config.ReadTimeout = 1s
clientserver_test.go:282: server log: http: TLS handshake error from 127.0.0.1:63155: write tcp 127.0.0.1:63156->127.0.0.1:63155: i/o timeout
serve_test.go:6038: retrying after error with duration 1s: Get: Get "https://127.0.0.1:63156": EOF
serve_test.go:5942: Server.Config.ReadTimeout = 2s
clientserver_test.go:282: server log: http: TLS handshake error from 127.0.0.1:63132: write tcp 127.0.0.1:63133->127.0.0.1:63132: i/o timeout
serve_test.go:6036: failed with duration 2s: Get: Get "https://127.0.0.1:63133": EOF
--- FAIL: TestServerCancelsReadTimeoutWhenIdle/h2 (5.77s)
โ [watchflakes](https://go.dev/wiki/Watchflakes)
| NeedsInvestigation | low | Critical |
2,739,746,500 | rust | Tracking Issue for de-stabilizing (and eventually removing?) the old serialization infrastructure (feature gate: rustc_encodable_decodable) | This tracks the progress on https://github.com/rust-lang/libs-team/issues/272. That issue says that #105572 will cause `rustc-serialize` to stop building; it seems like a semver-compatible update was released to avoid that, so currently that crate can still be used on stable. Since Rust 1.79, the future compatibility report shows this as a warning (even for dependencies).
Implementation:
- https://github.com/rust-lang/rust/pull/116016
- https://github.com/rust-lang/rust/pull/134272 | T-libs-api,C-tracking-issue | low | Minor |
2,739,774,440 | transformers | Strange behavior with attn_implementation="eager" | ### System Info
- `transformers` version: 4.47.0
- Platform: Linux-5.15.0-120-generic-x86_64-with-glibc2.35
- Python version: 3.10.15
- Huggingface_hub version: 0.26.2
- Safetensors version: 0.4.5
- Accelerate version: 1.1.0
- Accelerate config: not found
- PyTorch version (GPU?): 2.5.1+cu124 (True)
- Tensorflow version (GPU?): not installed (NA)
- Flax version (CPU?/GPU?/TPU?): not installed (NA)
- Jax version: not installed
- JaxLib version: not installed
- Using distributed or parallel set-up in script?: No
- Using GPU in script?: Yes
- GPU type: NVIDIA A100-PCIE-40GB
### Who can help?
@zucchini-nlp
### Information
- [ ] The official example scripts
- [X] My own modified scripts
### Tasks
- [ ] An officially supported task in the `examples` folder (such as GLUE/SQuAD, ...)
- [X] My own task or dataset (give details below)
### Reproduction
I am trying to analyze the attention pattern of the `LLAVA v1.5 7B` model, so I used `attn_implementation="eager"` when initing the model to obtain the attention weights. However, this has led to several issues. Firstly, the output IDs are incorrect, and secondly, errors may occur. I've noticed that this problem only appears with specific images and user prompts, while it does not occur in other cases, which is quite peculiar. Below is my code:
``` python
import numpy as np
import torch
from dotenv import load_dotenv
from PIL import Image
from transformers import (
LlavaForConditionalGeneration,
LlavaProcessor,
)
from transformers.generation.utils import GenerateDecoderOnlyOutput
np.set_printoptions(threshold=np.inf)
model_name = "llava-hf/llava-1.5-7b-hf"
model: LlavaForConditionalGeneration = LlavaForConditionalGeneration.from_pretrained(
model_name,
cache_dir="/root/llm/utils/models/hub",
torch_dtype=torch.float16,
low_cpu_mem_usage=True,
device_map="cuda:0",
attn_implementation="eager",
)
processor: LlavaProcessor = LlavaProcessor.from_pretrained(
model_name,
cache_dir="/root/llm/utils/models/hub",
padding_side="left",
patch_size=model.config.vision_config.patch_size,
vision_feature_select_strategy=model.config.vision_feature_select_strategy,
)
images = [
Image.open("/root/llm/utils/eval/Object_HalBench/images/339761.jpg"),
Image.open("/root/llm/utils/eval/Object_HalBench/images/431256.jpg"),
]
users = [
"Provide a thorough description of the given image.",
"What is this photo about? Please answer in great detail.",
]
prompts: list[str] = []
for u in users:
conversation: list[dict[str]] = [
{
"role": "user",
"content": [
{"type": "image"},
{"type": "text", "text": u},
],
},
]
prompt: str = processor.apply_chat_template(
conversation,
tokenize=False,
add_generation_prompt=True,
)
prompts.append(prompt)
with torch.inference_mode():
encoded_inputs: dict[str, torch.Tensor] = processor(
images=images,
text=prompts,
return_tensors="pt",
return_token_type_ids=False,
padding=True,
).to("cuda:0", torch.float16)
output: GenerateDecoderOnlyOutput = model.generate(
**encoded_inputs,
max_new_tokens=50,
num_beams=1,
do_sample=False,
temperature=0.7,
output_attentions=True,
use_cache=True,
return_legacy_cache=True,
return_dict_in_generate=True,
)
generated_ids: list[torch.LongTensor] = output.sequences # list of shape (batch_size, sequence_length)
print(generated_ids.cpu().numpy())
generated_ids = [o[len(i) :] for i, o in zip(encoded_inputs.input_ids, generated_ids)]
print()
decoded_outputs: list[str] = processor.batch_decode(
generated_ids,
skip_special_tokens=True,
clean_up_tokenization_spaces=True,
)
print(decoded_outputs)
decoded_outputs = [d.rstrip("\n").strip(" ") for d in decoded_outputs]
print(decoded_outputs)
print(len(output.attentions))
```
Notice: the image I used is from Object_HalBench benchmark
The output is:
Some other warning:
```
/root/anaconda3/envs/LVLM/lib/python3.10/site-packages/transformers/generation/configuration_utils.py:628: UserWarning: `do_sample` is set to `False`. However, `temperature` is set to `0.7` -- this flag is only used in sample-based generation modes. You should set `do_sample=True` or unset `temperature`.
warnings.warn(
Expanding inputs for image tokens in LLaVa should be done in processing. Please add `patch_size` and `vision_feature_select_strategy` to the model's processing config or set directly with `processor.patch_size = {{patch_size}}` and processor.vision_feature_select_strategy = {{vision_feature_select_strategy}}`. Using processors without these attributes in the config is deprecated and will throw an error in v4.50.
From v4.47 onwards, when a model cache is to be returned, `generate` will return a `Cache` instance instead by default (as opposed to the legacy tuple of tuples format). If you want to keep returning the legacy format, please set `return_legacy_cache=True`.
```
The generated_ids: (I remove a large number of `<image>` token for readability)
```
[[32001 1 3148 1001 29901 29871 32000 32000 32000 32000 32000 32000
32000 32000 32000 32000 32000 32000 29871 13 1184 29894 680 263
17826 6139 310 278 2183 1967 29889 319 1799 9047 13566 29901
0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0
0 0 0 0 0 0 0 0 0 0 0 0
0 0]
[ 1 3148 1001 29901 29871 32000 32000 32000 32000 32000 32000 32000
32000 32000 32000 32000 32000 29871 13 5618 338 445 15373 1048
29973 3529 1234 297 2107 9493 29889 319 1799 9047 13566 29901
450 1967 4332 1973 263 15007 3377 261 297 3158 29892 15859
263 8938 373 263 15007 29899 11911 287 364 1160 29889 450
15007 3377 261 338 297 278 7256 310 278 9088 29892 411
1009 15007 3377 7962 19540 963 29889 29871 13 13 8439 526
3196 916]]
```
Notice that `<image>`: 32000, `<pad>`: 32001
The output after `batch_decode` is:
```
['', 'The image captures a snowboarder in action, performing a trick on a snow-covered ramp. The snowboarder is in the middle of the scene, with their snowboard visible beneath them. \n\nThere are several other']
```
It's strange that there is token id 0 generated.
Only set `output_attentions=False` and `return_dict_in_generate=False` without removing `attn_implementation="eager",` won't make any change.
Notice that removing `attn_implementation="eager"`, and not returning dict overcome this question, the output then become correct:
```
[[32001 1 3148 1001 29901 29871 32000 32000 32000 32000 32000 32000
32000 32000 32000 32000 32000 32000 29871 13 1184 29894 680 263
17826 6139 310 278 2183 1967 29889 319 1799 9047 13566 29901
450 1967 5680 263 27683 8345 411 263 2919 7933 8024 15678
701 278 10090 29892 4969 263 301 1878 322 325 4626 424
25005 29889 450 8024 338 24046 2978 278 1510 261 4038 29892
4417 263 6023 310 5469 304 278 2913 29889 29871 13 13
797 278]
[ 1 3148 1001 29901 29871 32000 32000 32000 32000 32000 32000 32000
32000 32000 32000 32000 32000 29871 13 5618 338 445 15373 1048
29973 3529 1234 297 2107 9493 29889 319 1799 9047 13566 29901
450 1967 4332 1973 263 15007 3377 261 297 3158 29892 15859
263 8938 373 263 15007 29899 11911 287 364 1160 29889 450
15007 3377 261 338 297 278 7256 310 278 9088 29892 411
1009 15007 3377 7962 19540 963 29889 29871 13 13 8439 526
3196 916]]
['The image features a bathroom with a large green plant growing up the wall, creating a lush and vibrant atmosphere. The plant is situated near the shower area, adding a touch of nature to the space. \n\nIn the',
'The image captures a snowboarder in action, performing a trick on a snow-covered ramp. The snowboarder is in the middle of the scene, with their snowboard visible beneath them. \n\nThere are several other']
```
Beside this, some error may occur with `attn_implementation="eager"`, in some other case (different Image input)
```
Loading checkpoint shards: 100%|โโโโ| 3/3 [00:03<00:00, 1.12s/it]
../aten/src/ATen/native/cuda/TensorCompare.cu:110: _assert_async_cuda_kernel: block: [0,0,0], thread: [0,0,0] Assertion `probability tensor contains either `inf`, `nan` or element < 0` failed.
Traceback (most recent call last):
File "/root/llm/LVLM/test2.py", line 38, in <module>
print(generator.gen(images, users,do_sample=True,
File "/root/llm/LVLM/model/generator/llava.py", line 184, in gen
out = gen_hf(
File "/root/llm/LVLM/model/generator/utils.py", line 279, in gen_hf
output, encoded_inputs = _gen_hf(
File "/root/llm/LVLM/model/generator/utils.py", line 229, in _gen_hf
output: GenerateDecoderOnlyOutput = model.generate(
File "/root/anaconda3/envs/LVLM/lib/python3.10/site-packages/torch/utils/_contextlib.py", line 116, in decorate_context
return func(*args, **kwargs)
File "/root/anaconda3/envs/LVLM/lib/python3.10/site-packages/transformers/generation/utils.py", line 2252, in generate
result = self._sample(
File "/root/anaconda3/envs/LVLM/lib/python3.10/site-packages/transformers/generation/utils.py", line 3297, in _sample
next_tokens = torch.multinomial(probs, num_samples=1).squeeze(1)
RuntimeError: CUDA error: device-side assert triggered
CUDA kernel errors might be asynchronously reported at some other API call, so the stacktrace below might be incorrect.
For debugging consider passing CUDA_LAUNCH_BLOCKING=1
Compile with `TORCH_USE_CUDA_DSA` to enable device-side assertions.
```
### Expected behavior
fix it | bug,Multimodal | medium | Critical |
2,739,778,038 | vscode | Swap button in replace modal | <!-- โ ๏ธโ ๏ธ Do Not Delete This! feature_request_template โ ๏ธโ ๏ธ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
I think there should be a button in the replace modal to switch Find โ๏ธ Replace
E.g:
In the context of the above image, there should be a button like `โ๏ธ`. When clicked, the value in the 'find' field should swap with the value in the 'replace' field. For example, in our case: clicking the 'Swap' button would result in 'that' becoming 'this' and 'this' becoming 'that'. | feature-request,editor-find | low | Major |
2,739,795,525 | ollama | Using structured output with tools always produces empty tool_calls array | ### What is the issue?
With OpenAI API, you can pass both tools and response_format. In case model wants to call tools, message will be `null` and tools will be called.
With Ollama, it appears that when response_format is present as JSON schema, the tool calls is an empty array, despite model wanting to call the tools.
### OS
macOS
### GPU
Apple
### CPU
Apple
### Ollama version
0.5.1 | bug,needs more info | low | Minor |
2,739,798,341 | ui | [feat]: Implement components that are present in nextui, but not in shadcn | ### Feature description
From https://github.com/mikesol/purescript-deku/issues/134#issue-2569970444
- **Only in nextui**: Components like Autocomplete, Chip, Circular Progress, Code, Date Input, Image, Kbd, Navbar, Range Calendar, Scroll Shadow, and User are specific to nextui.
### Affected component/components
Components like Autocomplete, Chip, Circular Progress, Code, Date Input, Image, Kbd, Navbar, Range Calendar, Scroll Shadow, and User
### Additional Context
_No response_
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues and PRs | area: request | low | Minor |
2,739,869,869 | pytorch | Proper support for optionals in TorchScript | ### ๐ The feature, motivation and pitch
This came up as part of https://github.com/pytorch/pytorch/pull/142326.
TorchScript should support `Optional[T]` or `T | None` annotations correctly. Currently something basic like the following fails:
```py
import torch
class MyScriptModule(torch.nn.Module):
bias: torch.Tensor | None
def __init__(self, use_bias: bool = True):
super().__init__()
if use_bias:
self.bias = torch.nn.Parameter(torch.tensor(1.0))
else:
self.bias = None
def forward(self, input):
if self.bias is not None:
return input + self.bias
else:
return input
my_script_module = torch.jit.script(MyScriptModule())
```
The TorchScript compilation here fails, because TorchScript does not handle `bias: Optional[torch.Tensor]` correctly. Note that this is a fairly common pattern, so supporting it properly would be quite valuable.
What's even worse: The example can be compiled by using a **wrong** type annotation `bias: torch.Tensor` or omitting the type annotation, which implicitly also results in a **wrong** type annotation due to how `__getattr__` is typed (falsely promising non-optionality). Of course that is pretty bad, because we are forced to lie to the type checker, sweeping bugs under the carpet.
---
Possibly related to https://github.com/pytorch/pytorch/issues/75002
cc @EikanWang @jgong5 @wenzhe-nrv @sanchitintel | oncall: jit | low | Critical |
2,739,876,992 | yt-dlp | [adobepass] `--ap-mso` HTTP Error 451: Unavailable For Legal Reasons | ### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE
- [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field
### Checklist
- [X] I'm reporting that yt-dlp is broken on a **supported** site
- [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels))
- [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details
- [X] I've checked that all URLs and arguments with special characters are [properly quoted or escaped](https://github.com/yt-dlp/yt-dlp/wiki/FAQ#video-url-contains-an-ampersand--and-im-getting-some-strange-output-1-2839-or-v-is-not-recognized-as-an-internal-or-external-command)
- [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates
- [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue)
- [X] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and I'm willing to share it if required
### Region
United States
### Provide a description that is worded well enough to be understood
Unable to download any videos from NBC. They work in the browser.
### Provide verbose output that clearly demonstrates the problem
- [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`)
- [X] If using API, add `'verbose': True` to `YoutubeDL` params instead
- [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below
### Complete Verbose Output
```shell
[debug] Command-line config: ['https://www.nbc.com/lopez-vs-lopez/video/lopez-vs-dateline/9000396845', '--ap-mso', 'Verizon', '--ap-username', 'PRIVATE', '--ap-password', 'PRIVATE', '-vU']
[debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8
[debug] yt-dlp version [email protected] from yt-dlp/yt-dlp-master-builds [542166962] (win_exe)
[debug] Python 3.10.11 (CPython AMD64 64bit) - Windows-10-10.0.26100-SP0 (OpenSSL 1.1.1t 7 Feb 2023)
[debug] exe versions: ffmpeg N-93302-g147ef1d947, ffprobe N-93302-g147ef1d947
[debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.40.1, urllib3-2.2.3, websockets-14.1
[debug] Proxy map: {}
[debug] Request Handlers: urllib, requests, websockets, curl_cffi
[debug] Loaded 1837 extractors
[debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-master-builds/releases/latest
Latest version: [email protected] from yt-dlp/yt-dlp-master-builds
yt-dlp is up to date ([email protected] from yt-dlp/yt-dlp-master-builds)
[NBC] Extracting URL: https://www.nbc.com/lopez-vs-lopez/video/lopez-vs-dateline/9000396845
[NBC] 9000396845: Downloading JSON metadata
[NBC] 9000396845: Downloading JSON metadata
[NBC] 9000396845: Downloading Provider Redirect Page
ERROR: [NBC] 9000396845: Unable to download webpage: HTTP Error 451: Unavailable For Legal Reasons (caused by <HTTPError 451: Unavailable For Legal Reasons>)
File "yt_dlp\extractor\common.py", line 742, in extract
File "yt_dlp\extractor\nbc.py", line 212, in _real_extract
File "yt_dlp\extractor\adobepass.py", line 1449, in _extract_mvpd_auth
File "yt_dlp\extractor\adobepass.py", line 1367, in _download_webpage_handle
File "yt_dlp\extractor\common.py", line 962, in _download_webpage_handle
File "yt_dlp\extractor\common.py", line 911, in _request_webpage
File "yt_dlp\extractor\common.py", line 898, in _request_webpage
File "yt_dlp\YoutubeDL.py", line 4162, in urlopen
File "yt_dlp\networking\common.py", line 117, in send
File "yt_dlp\networking\_helper.py", line 208, in wrapper
File "yt_dlp\networking\common.py", line 340, in send
File "yt_dlp\networking\_requests.py", line 365, in _send
yt_dlp.networking.exceptions.HTTPError: HTTP Error 451: Unavailable For Legal Reasons
```
| account-needed,geo-blocked,site-bug,can-share-account | medium | Critical |
2,739,896,619 | rust | Tracking issue for release notes of #133392: Fix ICE when multiple supertrait substitutions need assoc but only one is provided |
This issue tracks the release notes text for #133392.
### Steps
- [ ] Proposed text is drafted by PR author (or team) making the noteworthy change.
- [ ] Issue is nominated for release team review of clarity for wider audience.
- [ ] Release team includes text in release notes/blog posts.
### Release notes text
The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).
````markdown
# Compatibility Notes
- [Error if multiple super-trait instantiations of `dyn Trait` need assoc but only one is provided](https://github.com/rust-lang/rust/pull/133392)
````
> [!TIP]
> Use the [previous releases](https://doc.rust-lang.org/nightly/releases.html) categories to help choose which one(s) to use.
> The category will be de-duplicated with all the other ones by the release team.
>
> *More than one section can be included if needed.*
### Release blog section
If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
*Otherwise leave it empty.*
````markdown
````
cc @compiler-errors, @lcnr -- origin issue/PR authors and assignees for starting to draft text
| relnotes,T-types,relnotes-tracking-issue | low | Critical |
2,739,906,832 | rust | Tracking issue for release notes of #132325: rework winnowing to sensibly handle global where-bounds |
This issue tracks the release notes text for #132325.
### Steps
- [ ] Proposed text is drafted by PR author (or team) making the noteworthy change.
- [ ] Issue is nominated for release team review of clarity for wider audience.
- [ ] Release team includes text in release notes/blog posts.
### Release notes text
The responsible team for the underlying change should edit this section to replace the automatically generated link with a succinct description of what changed, drawing upon text proposed by the author (either in discussion or through direct editing).
````markdown
# Compatibility notes
- [Disable potentially incorrect type inference if there are trivial and non-trivial where-clauses](https://github.com/rust-lang/rust/pull/132325)
````
> [!TIP]
> Use the [previous releases](https://doc.rust-lang.org/nightly/releases.html) categories to help choose which one(s) to use.
> The category will be de-duplicated with all the other ones by the release team.
>
> *More than one section can be included if needed.*
### Release blog section
If the change is notable enough for inclusion in the blog post, the responsible team should add content to this section.
*Otherwise leave it empty.*
````markdown
````
cc @lcnr, @compiler-errors -- origin issue/PR authors and assignees for starting to draft text
| relnotes,T-types,relnotes-tracking-issue | low | Critical |
2,739,911,866 | vscode | Breakpoint over line number | <!-- โ ๏ธโ ๏ธ Do Not Delete This! feature_request_template โ ๏ธโ ๏ธ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- Please search existing issues to avoid creating duplicates. -->
<!-- Describe the feature you'd like. -->
Hello vscode developers,
I would like the option to have my breakpoints on the line numbers instead of on the side, similar to intellij ide.
# Example
My current vs code version: 1.95
Thank you | feature-request,debug | low | Major |
2,739,917,001 | flutter | [android 15] Status bar text not legible with edge to edge and light theme | ### Steps to reproduce
1. `flutter create -e flutter_bug`
2. `cd flutter_bug && flutter run`
I am able to reproduce this bug on a Pixel 7a (android 15) both on the latest stable and master channels.
### Expected results
Clearly legible text on the status bar
### Actual results
<img src="https://github.com/user-attachments/assets/1162fac7-2a59-499b-a247-5b15e4d85e4b" width="300">
<img src="https://github.com/user-attachments/assets/d9f14e3d-fde1-44cb-b1a0-060ba1db7c16" width="300">
The status bar text is legible only if the theme of the app is dark
### Code sample
<details open><summary>Code sample</summary>
```dart
import 'package:flutter/material.dart';
void main() {
runApp(const MainApp());
}
class MainApp extends StatelessWidget {
const MainApp({super.key});
@override
Widget build(BuildContext context) {
return MaterialApp(
home: Scaffold(
body: Center(
child: Text('Hello World!'),
),
),
);
}
}
```
</details>
### Flutter Doctor output
<details open><summary>Doctor output</summary>
```console
[โ] Flutter (Channel master, 3.28.0-1.0.pre.122, on EndeavourOS 6.12.4-arch1-1, locale
en_US.UTF-8)
โข Flutter version 3.28.0-1.0.pre.122 on channel master at /usr/bin/flutter
โข Upstream repository https://github.com/flutter/flutter.git
โข Framework revision 7877a076a6 (11 hours ago), 2024-12-13 22:46:08 -0500
โข Engine revision a9f7fa8ca6
โข Dart version 3.7.0 (build 3.7.0-243.0.dev)
โข DevTools version 2.41.0
[โ] Android toolchain - develop for Android devices (Android SDK version 35.0.0)
โข Android SDK at /home/damiano/Android/Sdk
โข Platform android-35, build-tools 35.0.0
โข Java binary at: /usr/lib/jvm/java-17-openjdk/bin/java
This JDK is specified in your Flutter configuration.
To change the current JDK, run: `flutter config --jdk-dir="path/to/jdk"`.
โข Java version OpenJDK Runtime Environment (build 17.0.13+11)
โข All Android licenses accepted.
[โ] Chrome - develop for the web
โข CHROME_EXECUTABLE =
/var/lib/flatpak/app/com.google.Chrome/current/active/files/extra/chrome
[โ] Linux toolchain - develop for Linux desktop
โข clang version 18.1.8
โข cmake version 3.31.2
โข ninja version 1.12.1
โข pkg-config version 2.3.0
[โ] Android Studio (version 2024.2)
โข Android Studio at /opt/android-studio/
โข Flutter plugin version 83.0.3
โข Dart plugin can be installed from:
๐จ https://plugins.jetbrains.com/plugin/6351-dart
โข android-studio-dir = /opt/android-studio/
โข Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11)
[!] Android Studio (version unknown)
โข Android Studio at /opt/android-studio
โข Flutter plugin can be installed from:
๐จ https://plugins.jetbrains.com/plugin/9212-flutter
โข Dart plugin can be installed from:
๐จ https://plugins.jetbrains.com/plugin/6351-dart
โ Unable to determine Android Studio version.
โข Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11)
[โ] Connected device (3 available)
โข Pixel 7a (mobile) โข 37281JEHN00912 โข android-arm64 โข Android 15 (API 35)
โข Linux (desktop) โข linux โข linux-x64 โข EndeavourOS 6.12.4-arch1-1
โข Chrome (web) โข chrome โข web-javascript โข Google Chrome 131.0.6778.139
[โ] Network resources
โข All expected network resources are available.
! Doctor found issues in 1 category.
```
</details>
| platform-android,framework,e: OS-version specific,P1,team-android | medium | Critical |
2,739,942,466 | go | slices: redundant comparison in BinarySearchFunc | ### Go version
go version go1.23.4 windows/amd64
### Output of `go env` in your module/workspace:
```shell
set GO111MODULE=
set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\telic\AppData\Local\go-build
set GOENV=C:\Users\telic\AppData\Roaming\go\env
set GOEXE=.exe
set GOEXPERIMENT=aliastypeparams
set GOFLAGS=
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOINSECURE=
set GOMODCACHE=C:\Users\telic\go\pkg\mod
set GONOPROXY=
set GONOSUMDB=
set GOOS=windows
set GOPATH=C:\Users\telic\go
set GOPRIVATE=
set GOPROXY=https://proxy.golang.org,direct
set GOROOT=C:\Program Files\Go
set GOSUMDB=sum.golang.org
set GOTMPDIR=
set GOTOOLCHAIN=auto
set GOTOOLDIR=C:\Program Files\Go\pkg\tool\windows_amd64
set GOVCS=
set GOVERSION=go1.23.4
set GODEBUG=gotypesalias=1
set GOTELEMETRY=local
set GOTELEMETRYDIR=C:\Users\telic\AppData\Roaming\go\telemetry
set GCCGO=gccgo
set GOAMD64=v1
set AR=ar
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set GOMOD=C:\Code\Go\playground\go.mod
set GOWORK=C:\Code\Go\go.work
set CGO_CFLAGS=-O2 -g
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-O2 -g
set CGO_FFLAGS=-O2 -g
set CGO_LDFLAGS=-O2 -g
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=-m64 -mthreads -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=C:\Users\telic\AppData\Local\Temp\go-build1876904163=/tmp/go-build -gno-record-gcc-switches
```
### What did you do?
Ran [this code](https://go.dev/play/p/MFinklsK3-g).
### What did you see happen?
Three comparisons being made.
### What did you expect to see?
Two comparisons.
BinarySearchFunc always does a final comparison for its boolean return value, even though the slice element in question and the target might already have been compared. Since the comparison function could potentially be costly, this should be avoided. | Performance,WaitingForInfo,NeedsInvestigation | low | Critical |
2,739,950,046 | ui | [bug]: ShadCN Installer asking for tailwind.config.ts but it Version 4 | ### Describe the bug
auto install is asking for `tailwind.config.ts` and I moved on tailwindcss v4
### Affected component/components
Accordion
### How to reproduce
1. โ pnpm dlx shadcn@latest add accordion
โ Checking registry.
โ Updating tailwind.config.ts
Something went wrong. Please check the error below for more details.
If the problem persists, please open an issue on GitHub.
ENOENT: no such file or directory, open '/Users/gio/Dev/nextjs15-template/tailwind.config.ts'
โ git:(master) โ npx shadcn@latest add accordion
Need to install the following packages:
[email protected]
Ok to proceed? (y) npm ERR! canceled
npm ERR! A complete log of this run can be found in: /Users/gio/.npm/_logs/2024-12-14T15_27_57_257Z-debug-0.log
โ git:(master) โ
### Codesandbox/StackBlitz link
the installer is looking tailwind.config.ts but it Version 4
### Logs
```bash
โ nextjs15-template git:(master) โ pnpm dlx shadcn@latest add accordion
โ Checking registry.
โ Updating tailwind.config.ts
Something went wrong. Please check the error below for more details.
If the problem persists, please open an issue on GitHub.
ENOENT: no such file or directory, open '/Users/gio/Dev/nextjs15-template/tailwind.config.ts'
โ nextjs15-template git:(master) โ npx shadcn@latest add accordion
Need to install the following packages:
[email protected]
Ok to proceed? (y) npm ERR! canceled
npm ERR! A complete log of this run can be found in: /Users/gio/.npm/_logs/2024-12-14T15_27_57_257Z-debug-0.log
โ nextjs15-template git:(master) โ
```
### System Info
```bash
No binaries necessary
```
### Before submitting
- [X] I've made research efforts and searched the documentation
- [X] I've searched for existing issues | bug | low | Critical |
2,739,963,894 | godot | set_deferred does not throw error with invalid arguments | ### Tested versions
v4.3.stable.mono.official [77dcf97d8]
v4.3.stable.official [77dcf97d8]
v4.0.stable.mono.official [92bee43ad]
v4.4.dev.custom_build [dc5f1b7a2]
### System information
Godot v4.3.stable.mono - Ubuntu 22.04.5 LTS 22.04 - X11 - GLES3 (Compatibility) - RENOIR (renoir, LLVM 15.0.7, DRM 3.57, 6.8.0-49-generic) - AMD Ryzen 5 5500U with Radeon Graphics (12 Threads)
### Issue description
When using `set_deferred` with an non-existent property, or with an invalid value no error message gets thrown.
For example calling `set_deferred("Disabled", true)` in a CollisionShape2D will not make the shape disabled, due to property names not being capitalized, and thus the correct name being `"disabled"`. However this will not throw an error during runtime, making the issue needlessly hard to debug.
Similarly using an invalid value on a property, like `set_deferred("position", "abc")` also doesn't throw an error, while also not affecting the provided property.
This issue is especially annoying when coding in C#, due to C# Properites using PascalCase, making it more likely to accidentally misspell a Property.
### Steps to reproduce
create a Sprite2D Node, add a Texture and add the following script
```gdscript
extends Sprite2D
func _process(delta: float) -> void:
if (Input.is_action_just_pressed("ui_accept")):
# doesn't change the visibility of the node
# due to the property name being "visible" (not capitalized) and not "Visible" (capitalized)
set_deferred("Visible", !visible)
# uncommenting the following line toggles the Visibility as expected
# set_deferred("visible", !visible)
# doesn't do anything due to the Property 'asdf' not existing
set_deferred("asdf", true)
# doesn't do anything, due to material not accepting floats
set_deferred("material", 1.0)
```
Pressing 'Enter' does effectively nothing, and no error will be thrown during runtime or in the editor.
----
The provided MRP contains 2 Sprite2Ds, the one on the left has the script above attached, while the one on the right has a functioning script, which toggles the visibility as expected, attached.
### Minimal reproduction project (MRP)
[set_deferred_problem_MRP.zip](https://github.com/user-attachments/files/18136450/set_deferred_problem_MRP.zip)
| bug,topic:core | low | Critical |
2,739,976,449 | rust | Hidden type of "discarded" and thus unconstrained RPIT(IT) opaque types gets inferred to be the unit type `()` | This only affects RPIT(IT), not TAIT or ATPIT.
Fixing this issue would be a breaking change.
This exploits the issue #132212 (syntactically rejecting impl-Trait inside non-final path segments & inside fn ptr types is futile).
---
All subsequent snippets assume the following definitions:
```rs
type DiscardT<T> = <T as Discard>::Output;
trait Discard { type Output; }
impl<T: ?Sized> Discard for T { type Output = Point; } // you can substitute `Point` with `()` everywhere, this is just for clarity
struct Point;
trait NobodyImplsThis {}
```
RPIT check-pass reproducer ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=f2cb70d7362bb7d48f0dcb88462d3676)):
```rs
fn demo0() -> DiscardT<impl ?Sized> { Point }
```
RPIT check-fail reproducer ([playground](https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=273bbd96006fe4bcb0784ec419d7c1dc)):
```rs
fn demo1() -> DiscardT<impl NobodyImplsThis + ?Sized> { Point }
//~^ ERROR the trait bound `(): NobodyImplsThis` is not satisfied
```
I expected both reproducers to get rejected by the compiler due to uninferable types or unconstrained opaque types (with an error roughly of the form *item does not constrain `demoN::{opaque#0}`, but has it in its signature* (mirroring TAIT/ATPIT)). The opaque types should be unconstrained because `DiscardT<{opaque}>` normalizes to `Point` which does not contain any opaque types.
However, in both cases the hidden type gets inferred to be `()`. See also the compiler log for the first reproducer:
```rs
rustc_hir_analysis::check::check::check_opaque_meets_bounds def_id=DefId(0:13 ~ oi[08b9]::demo0::{opaque#0}), span=oi.rs:6:24: 6:35 (#4), origin=FnReturn { parent: DefId(0:12 ~ oi[08b9]::demo0), in_trait_or_impl: None }
rustc_middle::ty::sty::new_opaque def_id=DefId(0:13 ~ oi[08b9]::demo0::{opaque#0}), args=[]
rustc_infer::infer::opaque_types::register_hidden_type opaque_type_key=OpaqueTypeKey { def_id: DefId(0:13 ~ oi[08b9]::demo0::{opaque#0}), args: [] }, span=oi.rs:6:24: 6:35 (#4), param_env=ParamEnv { caller_bounds: [], reveal: UserFacing }, hidden_ty=()
rustc_infer::infer::opaque_types::table::register key=OpaqueTypeKey { def_id: DefId(0:13 ~ oi[08b9]::demo0::{opaque#0}), args: [] }, hidden_type=OpaqueHiddenType { span: oi.rs:6:24: 6:35 (#4), ty: () }
```
It's odd that some sort of type inference fallback occurs (in case you're wondering: In Rust 2024, it also falls back to `()`, not `!` (since we don't have anything diverging here)).
Related: The fixed issue #96460 (`PhantomData<{opaque}>`).
Ranking this P-low because it's pretty artificial and not unsound.
<details><summary>For completeness, RPITIT reproducers</summary>
```rs
trait Demo2 { fn f() -> DiscardT<impl ?Sized> { Point } }
```
```rs
trait Demo3 { fn f() -> DiscardT<impl NobodyImplsThis + ?Sized> { Point } }
//~^ ERROR the trait bound `(): NobodyImplsThis` is not satisfied
```
</details>
---
For comparison, the TAIT and ATPIT analogues result in an error (though I'm not sure if that's an interesting comparison to draw).
<details><summary>TAIT/ATPIT</summary>
```rs
#![feature(type_alias_impl_trait, impl_trait_in_assoc_type)]
type Weak0 = impl ?Sized;
fn demo4() -> DiscardT<Weak0> { Point }
//~^ ERROR item does not constrain `Weak0::{opaque#0}`, but has it in its signature
type Weak1 = DiscardT<impl ?Sized>;
fn demo5() -> Weak1 { Point }
//~^ ERROR item does not constrain `Weak1::{opaque#0}`, but has it in its signature
trait Demo6 {
type Proj: ?Sized;
fn f() -> DiscardT<Self::Proj>;
}
impl Demo6 for i32 {
type Proj = impl ?Sized;
fn f() -> DiscardT<Self::Proj> { Point }
//~^ ERROR item does not constrain `<i32 as Demo6>::Proj::{opaque#0}`, but has it in its signature
}
trait Demo7 {
type Proj;
fn f() -> Self::Proj;
}
impl Demo7 for i32 {
type Proj = DiscardT<impl ?Sized>;
fn f() -> Self::Proj { Point }
//~^ ERROR item does not constrain `<i32 as Demo7>::Proj::{opaque#0}`, but has it in its signature
}
```
</details> | P-low,A-inference,A-impl-trait,C-bug,T-types,fixed-by-next-solver | low | Critical |
2,739,980,624 | godot | VisualShader: Naming Texture2DParameter "AO" breaks shader | ### Tested versions
4.4 dev6
### System information
Godot v4.4.dev6 - Windows 10.0.19045 - Multi-window, 1 monitor - Vulkan (Forward+) - dedicated AMD Radeon RX 580 2048SP (Advanced Micro Devices, Inc.; 31.0.21921.1000) - Intel(R) Core(TM) i5-7500 CPU @ 3.40GHz (4 threads)
### Issue description
Naming texture2DParameter "AO" breaks the shader, as seen in the first image. Second image is the same node setup with the name changed.
### Steps to reproduce
Texture2DParameter connected to samplerPort, name Texture2DParameter "AO"
### Minimal reproduction project (MRP)
Any project | bug,topic:editor,topic:shaders | low | Minor |
2,739,982,272 | go | x/website: automatic URL fragments for sub-sections of 'Minor changes to the library' are overly repetitive | Is something duplicating the fragment names in the release notes?
https://tip.golang.org/doc/go1.24#gotypespkggotypes
https://tip.golang.org/doc/go1.24#encodingjsonpkgencodingjson
https://tip.golang.org/doc/go1.24#archivepkgarchive
I'd expect just `archive` or `pkgarchive` at most.
Others are pretty: https://tip.golang.org/doc/go1.24#runtime (which is why I guess the `pkg` is in there, to distinguish it from https://tip.golang.org/doc/go1.24#runtimepkgruntime ... but that's two `runtime` in that fragment)
/cc @dmitshur
| help wanted,NeedsInvestigation,website | low | Minor |
2,739,988,920 | pytorch | s.isIntegral(false) INTERNAL ASSERT FAILED | ### ๐ Describe the bug
When training ViT_b_16 (https://pytorch.org/vision/main/models/generated/torchvision.models.vit_b_16.html#torchvision.models.vit_b_16) on CUDA
```
model = helper.train_model(model, dataloaders, criterion, optimizer, scheduler,
File "/home/birdy/meng_thesis/code/master_ifcb_classifier/utils/resnet_experiment_helpers.py", line 298, in train_model
loss.backward()
File "/home/birdy/.conda/envs/cv-env/lib/python3.10/site-packages/torch/_tensor.py", line 396, in backward
torch.autograd.backward(self, gradient, retain_graph, create_graph, inputs=inputs)
File "/home/birdy/.conda/envs/cv-env/lib/python3.10/site-packages/torch/autograd/__init__.py", line 173, in backward
Variable._execution_engine.run_backward( # Calls into the C++ engine to run the backward pass
RuntimeError: s.isIntegral(false) INTERNAL ASSERT FAILED at "/opt/conda/conda-bld/pytorch-base_1664259963002/work/aten/src/ATen/ScalarOps.h":39, please report a bug to PyTorch.
```
Code defining model
```
model = models.vit_b_16(weights='IMAGENET1K_V1')
model.heads.head = nn.Linear(model.heads.head.in_features, NUM_CLASSES)
model = nn.DataParallel(model)
model= model.to(device)
```
Code for training function
```
def train_model(model, dataloaders, criterion, optimizer, scheduler, num_epochs=25, save_checkpoints = False, DEST='', model_name="ResNet", val_fqn=1, device="cpu"):
since = time.time()
# Create a temporary directory to save training checkpoints
with TemporaryDirectory() as tempdir:
#best_model_params_path = os.path.join(tempdir, 'best_model_params.pt')
best_model_params_path = f'{DEST}/{model_name}-best.pt'
torch.save(model.state_dict(), best_model_params_path)
best_acc = 0.0
# intialize training history if model doesn't already have it
if hasattr(model, 'history') == False:
model.history = {
'train_loss': [],
'train_acc': [],
'train_class_acc': [],
'train_epoch_duration': [],
'val_epochs': [],
'val_loss': [],
'val_acc': [],
'val_class_acc': [],
'val_epoch_duration': []
}
dt_string = datetime.now().strftime("%d-%m-%Y-%H-%M-%S")
for epoch in range(num_epochs):
print(f'Epoch {epoch}/{num_epochs - 1}')
print('-' * 10)
epoch_start_time = time.time()
# Each epoch has a training and validation phase
for phase in ['train', 'val']:
if phase == 'val' and epoch % val_fqn !=0:
continue # only validate model every nth time
if phase == 'train':
model.train() # Set model to training mode
else:
model.history['val_epochs'].append(epoch)
model.eval() # Set model to evaluate mode
running_loss = 0.0
running_corrects = 0
running_class_acc = 0.0
batch_counter = 0
# Iterate over data.
for inputs, labels in tqdm(dataloaders[phase]):
batch_counter += 1
inputs = inputs.to(device)
labels = labels.to(device)
# labels = torch.tensor(labels).to(device)
# zero the parameter gradients
optimizer.zero_grad()
# print(inputs.shape)
# forward
# track history if only in train
with torch.set_grad_enabled(phase == 'train'):
outputs = model(inputs)
_, preds = torch.max(outputs, 1)
loss = criterion(outputs, labels)
# backward + optimize only if in training phase
if phase == 'train':
loss.backward()
optimizer.step()
# statistics
running_loss += loss.item() * inputs.size(0)
running_corrects += torch.sum(preds == labels.data)
avg_class_acc, _ = calculate_per_class_accuracy(labels.data.cpu().numpy(), preds.cpu().numpy())
running_class_acc += avg_class_acc
if phase == 'train':
if type(scheduler) == lr_scheduler.ReduceLROnPlateau:
scheduler.step(running_loss)
else:
scheduler.step()
epoch_loss = running_loss / len(dataloaders[phase].dataset)
epoch_acc = running_corrects.double() / len(dataloaders[phase].dataset)
epoch_class_acc = running_class_acc / batch_counter
epoch_duration = time.time() - epoch_start_time
print(f'{phase} Loss: {epoch_loss:.4f} Acc: {epoch_acc:.4f}')
model.history[f'{phase}_loss'].append(epoch_loss)
model.history[f'{phase}_acc'].append(epoch_acc.item())
model.history[f'{phase}_class_acc'].append(epoch_class_acc)
model.history[f'{phase}_epoch_duration'].append(epoch_duration)
if save_checkpoints:
# write over the old checkpoint - saves mem space
PATH = f"{DEST}/{model_name}-{dt_string}-checkpoint.pt"
save_checkpoint(model, optimizer, PATH, epoch)
# deep copy the model
if phase == 'val' and epoch_acc > best_acc:
best_acc = epoch_acc
torch.save(model.state_dict(), best_model_params_path)
print()
time_elapsed = time.time() - since
model.history['time_elapsed'] = time_elapsed
print(f'Training complete in {time_elapsed // 60:.0f}m {time_elapsed % 60:.0f}s')
print(f'Best val Acc: {best_acc:4f}')
# load best model weights
# model.load_state_dict(torch.load(best_model_params_path))
return model
```
### Versions
Collecting environment information...
PyTorch version: 1.12.1
Is debug build: False
CUDA used to build PyTorch: 11.4
ROCM used to build PyTorch: N/A
OS: Red Hat Enterprise Linux release 8.3 (Ootpa) (ppc64le)
GCC version: (GCC) 8.3.1 20191121 (Red Hat 8.3.1-5)
Clang version: Could not collect
CMake version: version 3.11.4
Libc version: glibc-2.28
Python version: 3.10.13 (main, Sep 11 2023, 13:14:29) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-4.18.0-240.el8.ppc64le-ppc64le-with-glibc2.28
Is CUDA available: False
CUDA runtime version: No CUDA
CUDA_MODULE_LOADING set to: N/A
GPU models and configuration: No CUDA
Nvidia driver version: No CUDA
cuDNN version: No CUDA
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: False
CPU:
Architecture: ppc64le
Byte Order: Little Endian
CPU(s): 128
On-line CPU(s) list: 0-127
Thread(s) per core: 4
Core(s) per socket: 16
Socket(s): 2
NUMA node(s): 2
Model: 2.2 (pvr 004e 1202)
Model name: POWER9, altivec supported
CPU max MHz: 3800.0000
CPU min MHz: 2166.0000
L1d cache: 32K
L1i cache: 32K
L2 cache: 512K
L3 cache: 10240K
NUMA node0 CPU(s): 0-63
NUMA node8 CPU(s): 64-127
Versions of relevant libraries:
[pip3] numpy==1.23.5
[pip3] torch==1.12.1
[pip3] torchprofile==0.0.4
[pip3] torchvision==0.13.1
[conda] _pytorch_select 2.0 cuda_2 https://opence.mit.edu
[conda] cudatoolkit 11.4.4 h5d40d8d_10 https://opence.mit.edu
[conda] cudnn 8.3.0_11.4 h5b181e6_1 https://opence.mit.edu
[conda] nccl 2.12.7 cuda11.4_1 https://opence.mit.edu
[conda] numpy 1.23.5 py310h87cc683_0
[conda] numpy-base 1.23.5 py310hac71eb6_0
[conda] pytorch-base 1.12.1 cuda11.4_py310_pb3.19_2 https://opence.mit.edu
[conda] torchprofile 0.0.4 pypi_0 pypi
[conda] torchvision 0.13.1 cuda11.4_py310_1 https://opence.mit.edu
[conda] torchvision-base 0.13.1 cuda11.4_py310_1 https://opence.mit.edu
cc @ezyang @albanD @gqchen @pearu @nikitaved @soulitzer @Varal7 @xmfan | needs reproduction,module: autograd,triaged | low | Critical |
2,739,992,063 | svelte | Unify `intro`/`outro` defaults | ### Describe the problem
[`5.13.0`](https://github.com/sveltejs/svelte/releases/tag/svelte%405.13.0) adds the `outro` option for `unmount` with default `false`.
`mount` has an `intro` option with default `true`.
### Describe the proposed solution
Use the same default for both options.
(Probably would need to happen in a major release.)
### Importance
nice to have | breaking change,needs discussion | low | Minor |
2,740,003,288 | vscode | RPM %post scriplet deletes /usr/local/bin/code | <!-- โ ๏ธโ ๏ธ Do Not Delete This! bug_report_template โ ๏ธโ ๏ธ -->
<!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ -->
<!-- ๐ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions -->
<!-- ๐ Search existing issues to avoid creating duplicates. -->
<!-- ๐งช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ -->
<!-- ๐ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. -->
<!-- ๐ง Launch with `code --disable-extensions` to check. -->
Does this issue occur when all extensions are disabled?: Yes
<!-- ๐ช If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. -->
<!-- ๐ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. -->
- VS Code Version: 1.96.0 (RPM from the Microsoft repo)
- OS Version: Fedora 41
The `%post` scriptlet in the RPM spec file deletes `/usr/local/bin/code` even if it doesn't belong to a previous vscode installation. This is very irritating because it's the easiest way to append arbitrary command line arguments such as `--ozone-platform=wayland` **system-wide**. Please either add some validation before deleting it, or just stop deleting it altogether.
https://github.com/microsoft/vscode/blob/1.96.0/resources/linux/rpm/code.spec.template#L48-L51
Steps to Reproduce:
1. Install a script at `/usr/local/bin/code` which launches `/usr/bin/code` with extra arguments
2. Reinstall the RPM file provided by Microsoft
3. `/usr/local/bin/code` is now deleted
| bug,install-update,rpm | low | Critical |
2,740,003,424 | angular | Add more granular scope to @let syntax | ### Which @angular/* package(s) are relevant/related to the feature request?
compiler-cli
### Description
Currently, the scope for a local variable in Angular is limited to each block such as @for, @if, or @switch. Because of this, it's not possible to reuse variables in a more generic way, as I showed in the example. Initially, I would like to use @addressFormControls for multiple individual mat-form-field elements, so that in each of them I could use a nested variable with a generic name like controls. Unfortunately, I get an error because the name repeats what is defined above.
```
<!-- First variable -->
@let addressFormControls = employeeOffboardForm.controls.address.controls;
<div class="offboard__form-row">
<mat-form-field subscriptSizing="dynamic">
// it's ok to use nested variable
@let control = addressFormControls.streetLine;
<mat-label>Street line</mat-label>
<input [formControl]="addressFormControls.streetLine" matInput />
@if (control.hasError("required")) {
<mat-error>To pole jest wymagane</mat-error>
}
@if (control.hasError("maxlength")) {
<mat-error>Maksymalna dลugoลฤ to 50 znakรณw</mat-error>
}
</mat-form-field>
<mat-form-field subscriptSizing="dynamic">
<!-- here is an error becouse of repeated variable name -->
@let control = addressFormControls.streetLine;
<mat-label>Postal code</mat-label>
<input [formControl]="addressFormControls.postalCode" matInput />
@if (control.hasError("required")) {
<mat-error>To pole jest wymagane</mat-error>
}
@if (control.hasError("pattern")) {
<mat-error>Nieprawidลowy kod pocztowy</mat-error>
}
</mat-form-field>
</div>
```
### Proposed solution
It would be very useful if the scope was applied to HTML tags. Currently, I am forced to give specific names for each one, which is not always convenient. However, if the reason for this is performance, I would understand, but I would appreciate it if you could explain why this particular model was adopted.
### Alternatives considered
An alternative is to leave it as it is now. | area: core | low | Critical |
2,740,003,513 | rust | Trait resolution fails, and then `rustc` hangs. | <!--
Thank you for filing a bug report! ๐ Please provide a short summary of the bug,
along with any information you feel relevant to replicating the bug.
-->
I tried this code:
```rust
trait Index {
type IndexRef;
}
trait Borrow {
type Borrowed<'a>;
}
trait Test {
type Ref<'a>;
type Container: Borrow where for<'a> <Self::Container as Borrow>::Borrowed<'a> : Index<IndexRef = Self::Ref<'a>>;
}
```
This builds fine if `<Self::Container as Borrow>::Borrowed<'a>` is replaced by `&'a Self::Container`. However, the above both errors, and also hangs `rustc` (still running after many minutes; wedges playground). The error is
> binding for associated type `Ref` references lifetime `'a`, which does not appear in the trait input types
I don't understand the error, though I could imagine that it is my fault or a known limitation of GATs. However, the hanging of `rustc` seems likely to be a bug.
### Meta
<!--
If you're using the stable version of the compiler, you should also check if the
bug also exists in the beta or nightly versions.
-->
`rustc --version --verbose`:
```
rustc 1.83.0 (90b35a623 2024-11-26)
```
<details><summary>Compiler output before hang</summary>
<p>
```
error[E0582]: binding for associated type `IndexRef` references lifetime `'a`, which does not appear in the trait input types
--> lib.rs:11:92
|
11 | type Container: Borrow where for<'a> <Self::Container as Borrow>::Borrowed<'a> : Index<IndexRef = Self::Ref<'a>>;
| ^^^^^^^^^^^^^^^^^^^^^^^^
error: aborting due to 1 previous error
```
</p>
</details>
| A-trait-system,A-associated-items,T-compiler,C-bug,I-hang,T-types,fixed-by-next-solver,A-higher-ranked | low | Critical |
2,740,005,803 | stable-diffusion-webui | [Bug]: git clone error in windows 10 environment | ### Checklist
- [ ] The issue exists after disabling all extensions
- [ ] The issue exists on a clean installation of webui
- [ ] The issue is caused by an extension, but I believe it is caused by a bug in the webui
- [ ] The issue exists in the current version of the webui
- [ ] The issue has not been reported before recently
- [ ] The issue has been reported before but has not been fixed yet
### What happened?
I am trying to install the Stable diffusion broser from the cmd.
I keep getting this :
"error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 1395 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output"
I am logged in the github platform , coppied the code link and AFAIK all dependancies are met .
Is it something with the windows , like firewalls or other network related ?
Thank you
### Steps to reproduce the problem
Perhaps is not a bug of the package .
### What should have happened?
Perhaps the Python settings are not right ?
### What browsers do you use to access the UI ?
_No response_
### Sysinfo
Edition Windows 10 Pro
Version 22H2
Installed on
OS build 19045.5247
Experience Windows Feature Experience Pack 1000.19060.1000.0
### Console logs
```Shell
PS C:\stable-diffusion> git clone https://github.com/AUTOMATIC1111/stable-diffusion-webui.git
Cloning into 'stable-diffusion-webui'...
remote: Enumerating objects: 34787, done.
remote: Counting objects: 100% (16/16), done.
remote: Compressing objects: 100% (10/10), done.
error: RPC failed; curl 92 HTTP/2 stream 5 was not closed cleanly: CANCEL (err 8)
error: 1395 bytes of body are still expected
fetch-pack: unexpected disconnect while reading sideband packet
fatal: early EOF
fatal: fetch-pack: invalid index-pack output
```
### Additional information
_No response_ | asking-for-help-with-local-system-issues | low | Critical |
2,740,017,317 | pytorch | Regression: `BlockMask__getitem__` returns a new BlockMask but forgets to change its shape on the Q dimension | ### ๐ Describe the bug
## Problem
Before af883262509b80f13a08dd5184d7b9456da38173, slicing a BlockMask along the query dimension would shrink its length on that dimension (and unfortunately round up the KV dimension):
```python
from torch.nn.attention.flex_attention import create_block_mask
block_mask = create_block_mask(
lambda b, h, q_idx, kv_idx: q_idx >= kv_idx,
B=None,
H=None,
Q_LEN=1024,
KV_LEN=1025, # it would be rounded up to 1280 = 1024 + 256
device="cuda",
BLOCK_SIZE=256,
)
print(block_mask[:, :, :1].shape) # obtain the first block along the Q dimension
# Output: (1, 1, 256, 1280)
```
## Output
But now, it will keep the original shape and make the output worse:
```python
# Same code as above
print(block_mask[:, :, :1].shape)
# Output: (1, 1, 1024, 1025)
```
The `shape` matters, because the same commit added the strong validation against input QKV lengths with `shape`. If `shape` is wrong, the BlockMask will assert.
## Expected Output
`(1, 1, 256, 1025)`
## Additional Information
af883262509b80f13a08dd5184d7b9456da38173 introduced `seq_lengths` to store `(kv_indices.shape[-2] * BLOCK_SIZE[0], q_indices.shape[-2] * BLOCK_SIZE[1])`.
But in the `__getitem__` function, it passes the original `self.seq_lengths` to the newly created BlockMask without recalculating it:
https://github.com/pytorch/pytorch/blob/91bf2e16debdc41f5dde2bb5cc8e4f39f8955d4e/torch/nn/attention/flex_attention.py#L478
### Versions
```
PyTorch version: 2.6.0.dev20241214+cu124
Is debug build: False
CUDA used to build PyTorch: 12.4
ROCM used to build PyTorch: N/A
OS: Ubuntu 20.04.6 LTS (x86_64)
GCC version: (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0
Clang version: Could not collect
CMake version: Could not collect
Libc version: glibc-2.31
Python version: 3.12.7 | packaged by Anaconda, Inc. | (main, Oct 4 2024, 13:27:36) [GCC 11.2.0] (64-bit runtime)
Python platform: Linux-5.15.0-107-generic-x86_64-with-glibc2.31
Is CUDA available: True
CUDA runtime version: 12.1.66
CUDA_MODULE_LOADING set to: LAZY
GPU models and configuration:
GPU 0: NVIDIA A800 80GB PCIe
GPU 1: NVIDIA A800 80GB PCIe
GPU 2: NVIDIA A800 80GB PCIe
GPU 3: NVIDIA A800 80GB PCIe
GPU 4: NVIDIA A800 80GB PCIe
GPU 5: NVIDIA A800 80GB PCIe
GPU 6: NVIDIA A800 80GB PCIe
GPU 7: NVIDIA A800 80GB PCIe
Nvidia driver version: 535.183.01
cuDNN version: Probably one of the following:
/usr/lib/x86_64-linux-gnu/libcudnn.so.9.1.0
/usr/lib/x86_64-linux-gnu/libcudnn_adv.so.9.1.0
/usr/lib/x86_64-linux-gnu/libcudnn_cnn.so.9.1.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_precompiled.so.9.1.0
/usr/lib/x86_64-linux-gnu/libcudnn_engines_runtime_compiled.so.9.1.0
/usr/lib/x86_64-linux-gnu/libcudnn_graph.so.9.1.0
/usr/lib/x86_64-linux-gnu/libcudnn_heuristic.so.9.1.0
/usr/lib/x86_64-linux-gnu/libcudnn_ops.so.9.1.0
HIP runtime version: N/A
MIOpen runtime version: N/A
Is XNNPACK available: True
CPU:
Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Byte Order: Little Endian
Address sizes: 46 bits physical, 57 bits virtual
CPU(s): 112
On-line CPU(s) list: 0-111
Thread(s) per core: 2
Core(s) per socket: 28
Socket(s): 2
NUMA node(s): 4
Vendor ID: GenuineIntel
CPU family: 6
Model: 106
Model name: Intel(R) Xeon(R) Gold 6330 CPU @ 2.00GHz
Stepping: 6
CPU MHz: 2600.000
CPU max MHz: 3100.0000
CPU min MHz: 800.0000
BogoMIPS: 4000.00
L1d cache: 2.6 MiB
L1i cache: 1.8 MiB
L2 cache: 70 MiB
L3 cache: 84 MiB
NUMA node0 CPU(s): 0-13,56-69
NUMA node1 CPU(s): 14-27,70-83
NUMA node2 CPU(s): 28-41,84-97
NUMA node3 CPU(s): 42-55,98-111
Vulnerability Gather data sampling: Mitigation; Microcode
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Mitigation; Clear CPU buffers; SMT vulnerable
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Not affected
Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Enhanced IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI Syscall hardening, KVM SW loop
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx pdpe1gb rdtscp lm constant_tsc art arch_perfmon pebs bts rep_good nopl xtopology nonstop_tsc cpuid aperfmperf pni pclmulqdq dtes64 monitor ds_cpl smx est tm2 ssse3 sdbg fma cx16 xtpr pdcm pcid dca sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand lahf_lm abm 3dnowprefetch cpuid_fault epb cat_l3 invpcid_single intel_ppin ssbd mba ibrs ibpb stibp ibrs_enhanced fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid cqm rdt_a avx512f avx512dq rdseed adx smap avx512ifma clflushopt clwb intel_pt avx512cd sha_ni avx512bw avx512vl xsaveopt xsavec xgetbv1 xsaves cqm_llc cqm_occup_llc cqm_mbm_total cqm_mbm_local split_lock_detect wbnoinvd dtherm ida arat pln pts avx512vbmi umip pku ospke avx512_vbmi2 gfni vaes vpclmulqdq avx512_vnni avx512_bitalg tme avx512_vpopcntdq la57 rdpid fsrm md_clear pconfig flush_l1d arch_capabilities
Versions of relevant libraries:
[pip3] numpy==2.1.3
[pip3] nvidia-cublas-cu12==12.4.5.8
[pip3] nvidia-cuda-cupti-cu12==12.4.127
[pip3] nvidia-cuda-nvrtc-cu12==12.4.127
[pip3] nvidia-cuda-runtime-cu12==12.4.127
[pip3] nvidia-cudnn-cu12==9.1.0.70
[pip3] nvidia-cufft-cu12==11.2.1.3
[pip3] nvidia-curand-cu12==10.3.5.147
[pip3] nvidia-cusolver-cu12==11.6.1.9
[pip3] nvidia-cusparse-cu12==12.3.1.170
[pip3] nvidia-cusparselt-cu12==0.6.2
[pip3] nvidia-nccl-cu12==2.21.5
[pip3] nvidia-nvjitlink-cu12==12.4.127
[pip3] nvidia-nvtx-cu12==12.4.127
[pip3] nvtx==0.2.10
[pip3] pynvjitlink-cu12==0.4.0
[pip3] pytorch-triton==3.2.0+git35c6c7c6
[pip3] torch==2.6.0.dev20241214+cu124
[pip3] torchvision==0.22.0.dev20241214+cu124
[conda] numpy 2.1.3 pypi_0 pypi
[conda] nvidia-cublas-cu12 12.4.5.8 pypi_0 pypi
[conda] nvidia-cuda-cupti-cu12 12.4.127 pypi_0 pypi
[conda] nvidia-cuda-nvrtc-cu12 12.4.127 pypi_0 pypi
[conda] nvidia-cuda-runtime-cu12 12.4.127 pypi_0 pypi
[conda] nvidia-cudnn-cu12 9.1.0.70 pypi_0 pypi
[conda] nvidia-cufft-cu12 11.2.1.3 pypi_0 pypi
[conda] nvidia-curand-cu12 10.3.5.147 pypi_0 pypi
[conda] nvidia-cusolver-cu12 11.6.1.9 pypi_0 pypi
[conda] nvidia-cusparse-cu12 12.3.1.170 pypi_0 pypi
[conda] nvidia-cusparselt-cu12 0.6.2 pypi_0 pypi
[conda] nvidia-nccl-cu12 2.21.5 pypi_0 pypi
[conda] nvidia-nvjitlink-cu12 12.4.127 pypi_0 pypi
[conda] nvidia-nvtx-cu12 12.4.127 pypi_0 pypi
[conda] nvtx 0.2.10 pypi_0 pypi
[conda] pynvjitlink-cu12 0.4.0 pypi_0 pypi
[conda] pytorch-triton 3.2.0+git35c6c7c6 pypi_0 pypi
[conda] torch 2.6.0.dev20241214+cu124 pypi_0 pypi
[conda] torchvision 0.22.0.dev20241214+cu124 pypi_0 pypi
```
cc @chauhang @penguinwu @zou3519 @ydwu4 @bdhirsh @yf225 @Chillee @drisspg @yanboliang @BoyuanFeng | triaged,oncall: pt2,module: higher order operators,module: pt2-dispatcher,module: flex attention | low | Critical |
2,740,021,853 | godot | Android build fails when Arabic characters are in the file path. | ### Tested versions
tested it on Godot 4.1.4-stable
### System information
Windows 11 - Godot v4.1.4 - compatibility - Dedicated NVIDIA GeForce RTX 3070
### Issue description
Building an Android project fails when the project path contains Arabic characters. This issue appears to be specific to file paths with non-Latin characters ( I didn't try any other language beside arabic so this is a theory ).
### Steps to reproduce
1- Create a new Godot project.
2- Save the project in a directory with Arabic characters in the path (e.g., "C:/ู
ุดุฑูุน/").
3- Attempt to build the project for Android.
4- Observe the error in the build process.
### Minimal reproduction project (MRP)
[ูุนุจุฉ.zip](https://github.com/user-attachments/files/18137000/default.zip)
The project file named in arabic, so that should get you the error | discussion,platform:android,confirmed,topic:export | low | Critical |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.