id
int64
393k
2.82B
repo
stringclasses
68 values
title
stringlengths
1
936
body
stringlengths
0
256k
โŒ€
labels
stringlengths
2
508
priority
stringclasses
3 values
severity
stringclasses
3 values
2,693,112,165
godot
Game view button tooltips are inconsistently written as names and descriptions
### Tested versions - Reproducible in v4.4.dev (0c45ace15) ### System information Godot v4.4.dev (0c45ace15) - macOS 15.1.1 - Multi-window, 2 monitors - OpenGL 3 (Compatibility) - AMD Radeon Pro 5500 XT OpenGL Engine - Intel(R) Core(TM) i7-10700K CPU @ 3.80GHz (16 threads) ### Issue description The tooltips for the toolbar in the Game view are inconsistently worded. Some of them are names, whereas others are worded as descriptions. ![Image](https://github.com/user-attachments/assets/480f7c2f-0ee8-4de5-949b-fa3acbbc4093) The tooltips for these buttons, from left to right, are: - Suspend *(Name)* - Next Frame *(Name)* - Allow game input. *(Description)* - Disable game input and allow to select Node2Ds, Controls, and manipulate the 2D camera. *(Description)* - Disable game input and allow to select Node3Ds and manipulate the 3D camera. *(Description)* - Toggle Selection Visibility *(Description)* - Select Mode (Q) Command+Alt+RMB: Show list of all nodes at position clicked. *(Name, keyboard shortcuts, and description)* - Show list of selectable nodes at position clicked. *(Description)* - Override the in-game camera. *(Description)* - Camera Override Options *(Name)* All of these should use a matching convention/type for consistency. For example, if all of them were to use a description, potential descriptions could be: - Suspend the game. - Move execution of the game forward by one frame. - Allow game input. - Disable game input and allow to select Node2Ds, Controls, and manipulate the 2D camera. - Disable game input and allow to select Node3Ds and manipulate the 3D camera. - Toggle the visibility of selections. - Allow nodes to be selected by clicking on them in the game window. - Show list of selectable nodes at position clicked. - Override the in-game camera. - Change how the in-game camera override works. (It'd probably be important to ensure that keyboard shortcuts are included for the functions that have them, though). ### Steps to reproduce Open the Godot 4.4 editor, move to the Game view/tab, and hover over the buttons to view the tooltips. ### Minimal reproduction project (MRP) N/A
enhancement,discussion,topic:editor,usability
low
Minor
2,693,148,563
three.js
TSL Transpiler varying : /* unknown statement */;
### Description Currently the TSL Transpiler don't seem to recognize `varying`. Maybe it's because there isn't a vertex/fragment context? `varying vec2 vUV;` ---transpile to----> `/* unknown statement */;` ### Solution take varying in account ### Alternatives Have the tsl transpilor editor split in 2 so we can add the main of the vertex and the main of the fragment and it can use the varying correctly in both. ### Additional context I was doing a quick test on this reference : `https://github.com/pmndrs/meshline/blob/master/src/MeshLineMaterial.ts`
Enhancement,TSL
low
Minor
2,693,153,773
pytorch
Missing Fake/Meta/Abstract Kernels for Operators
### ๐Ÿ› Describe the bug Based on description of https://pytorch.org/docs/stable/export.html#missing-fake-meta-abstract-kernels-for-operators. I'm trying to use torch.export to describe llama2 model with a reference implementation. Full error log here: ``` Traceback (most recent call last): File "/home/neil/code/pytorch-llama/inference_inst.py", line 208, in <module> out_tokens, out_texts = model.text_completion(prompts, max_gen_len=64) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/inference_inst.py", line 119, in text_completion exported_program: torch.export.ExportedProgram = export( ^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/export/__init__.py", line 270, in export return _export( ^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/export/_trace.py", line 1017, in wrapper raise e File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/export/_trace.py", line 990, in wrapper ep = fn(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/export/exported_program.py", line 114, in wrapper return fn(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/export/_trace.py", line 1880, in _export export_artifact = export_func( # type: ignore[operator] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/export/_trace.py", line 1683, in _non_strict_export aten_export_artifact = _to_aten_func( # type: ignore[operator] ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/export/_trace.py", line 637, in _export_to_aten_ir gm, graph_signature = transform(aot_export_module)( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/export/_trace.py", line 1611, in _aot_export_non_strict gm, sig = aot_export(wrapped_mod, args, kwargs=kwargs, **flags) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/_functorch/aot_autograd.py", line 1246, in aot_export_module fx_g, metadata, in_spec, out_spec = _aot_export_function( ^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/_functorch/aot_autograd.py", line 1480, in _aot_export_function fx_g, meta = create_aot_dispatcher_function( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/_functorch/aot_autograd.py", line 522, in create_aot_dispatcher_function return _create_aot_dispatcher_function( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/_functorch/aot_autograd.py", line 623, in _create_aot_dispatcher_function fw_metadata = run_functionalized_fw_and_collect_metadata( ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/_functorch/_aot_autograd/collect_metadata_analysis.py", line 173, in inner flat_f_outs = f(*flat_f_args) ^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/_functorch/_aot_autograd/utils.py", line 182, in flat_fn tree_out = fn(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/_functorch/_aot_autograd/traced_function_transforms.py", line 863, in functional_call out = mod(*args[params_len:], **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl return self._call_impl(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl return forward_call(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/export/_trace.py", line 1598, in forward tree_out = self._export_root(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl return self._call_impl(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl return forward_call(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/model.py", line 274, in forward h = layer(h, start_pos, freqs_complex) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1736, in _wrapped_call_impl return self._call_impl(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/nn/modules/module.py", line 1747, in _call_impl return forward_call(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/model.py", line 231, in forward h = x + self.attention.forward(self.attention_norm(x), start_pos, freqs_complex) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/model.py", line 150, in forward self.cache_k[:batch_size, start_pos : start_pos + seq_len] = xk ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/_export/non_strict_utils.py", line 520, in __torch_function__ return func(*args, **kwargs) ^^^^^^^^^^^^^^^^^^^^^ File "/home/neil/code/pytorch-llama/venv/lib/python3.11/site-packages/torch/_subclasses/functional_tensor.py", line 534, in __torch_dispatch__ outs_unwrapped = func._op_dk( ^^^^^^^^^^^^ RuntimeError: false INTERNAL ASSERT FAILED at "aten/src/ATen/RegisterFunctionalization_0.cpp":3931, please report a bug to PyTorch. mutating a non-functional tensor with a functional tensor is not allowed. Please ensure that all of your inputs are wrapped inside of a functionalize() call. ``` I'm opening this issue based on torch.export limitaion document. ### Versions Collecting environment information... PyTorch version: 2.5.1+cu124 Is debug build: False CUDA used to build PyTorch: 12.4 ROCM used to build PyTorch: N/A OS: Ubuntu 22.04.4 LTS (x86_64) GCC version: (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 Clang version: 14.0.0-1ubuntu1.1 CMake version: Could not collect Libc version: glibc-2.35 Python version: 3.11.9 (main, Apr 15 2024, 18:24:23) [Clang 17.0.6 ] (64-bit runtime) Python platform: Linux-5.15.167.4-microsoft-standard-WSL2-x86_64-with-glibc2.35 Is CUDA available: True CUDA runtime version: Could not collect CUDA_MODULE_LOADING set to: LAZY GPU models and configuration: GPU 0: NVIDIA GeForce RTX 4090 Laptop GPU Nvidia driver version: 560.94 cuDNN version: Could not collect HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Architecture: x86_64 CPU op-mode(s): 32-bit, 64-bit Address sizes: 46 bits physical, 48 bits virtual Byte Order: Little Endian CPU(s): 20 On-line CPU(s) list: 0-19 Vendor ID: GenuineIntel Model name: 13th Gen Intel(R) Core(TM) i9-13900H CPU family: 6 Model: 186 Thread(s) per core: 2 Core(s) per socket: 10 Socket(s): 1 Stepping: 2 BogoMIPS: 5990.39 Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology tsc_reliable nonstop_tsc cpuid pni pclmulqdq vmx ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single ssbd ibrs ibpb stibp ibrs_enhanced tpr_shadow vnmi ept vpid ept_ad fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves avx_vnni umip waitpkg gfni vaes vpclmulqdq rdpid movdiri movdir64b fsrm md_clear serialize flush_l1d arch_capabilities Virtualization: VT-x Hypervisor vendor: Microsoft Virtualization type: full L1d cache: 480 KiB (10 instances) L1i cache: 320 KiB (10 instances) L2 cache: 12.5 MiB (10 instances) L3 cache: 24 MiB (1 instance) Vulnerability Gather data sampling: Not affected Vulnerability Itlb multihit: Not affected Vulnerability L1tf: Not affected Vulnerability Mds: Not affected Vulnerability Meltdown: Not affected Vulnerability Mmio stale data: Not affected Vulnerability Reg file data sampling: Mitigation; Clear Register File Vulnerability Retbleed: Mitigation; Enhanced IBRS Vulnerability Spec rstack overflow: Not affected Vulnerability Spec store bypass: Mitigation; Speculative Store Bypass disabled via prctl and seccomp Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization Vulnerability Spectre v2: Mitigation; Enhanced / Automatic IBRS; IBPB conditional; RSB filling; PBRSB-eIBRS SW sequence; BHI BHI_DIS_S Vulnerability Srbds: Not affected Vulnerability Tsx async abort: Not affected Versions of relevant libraries: [pip3] numpy==1.26.4 [pip3] nvidia-cublas-cu12==12.4.5.8 [pip3] nvidia-cuda-cupti-cu12==12.4.127 [pip3] nvidia-cuda-nvrtc-cu12==12.4.127 [pip3] nvidia-cuda-runtime-cu12==12.4.127 [pip3] nvidia-cudnn-cu12==9.1.0.70 [pip3] nvidia-cufft-cu12==11.2.1.3 [pip3] nvidia-curand-cu12==10.3.5.147 [pip3] nvidia-cusolver-cu12==11.6.1.9 [pip3] nvidia-cusparse-cu12==12.3.1.170 [pip3] nvidia-nccl-cu12==2.21.5 [pip3] nvidia-nvjitlink-cu12==12.4.127 [pip3] nvidia-nvtx-cu12==12.4.127 [pip3] torch==2.5.1 [pip3] torchvision==0.20.1 [pip3] triton==3.1.0 [conda] Could not collect cc @chauhang @penguinwu @eellison @zou3519 @bdhirsh @yf225
triaged,oncall: pt2,module: fakeTensor,module: pt2-dispatcher
low
Critical
2,693,159,288
godot
Anchored controls don't resize properly when rotated
### Tested versions -Reproducible in v4.3.stable.mono.official [77dcf97d8] ### System information Godot v4.3.stable.mono - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3050 Laptop GPU (NVIDIA; 31.0.15.4630) - 11th Gen Intel(R) Core(TM) i7-11800H @ 2.30GHz (16 Threads) ### Issue description Anchors do not work properly if the node they are set on is rotated. The node's transform is updated as if the anchors were present on a node with no rotation, leading to the following (undesirable) behavior: https://github.com/user-attachments/assets/aad86ad8-4d5b-41f2-880e-a301c5b5534d The expected behavior is for each of the objects to maintain their anchored positions as the parent is resized. For example, in the video above, the "bottom" node should remain anchored to the bottom edge of its parent, taking up ~10% of its height even as it is resized. The expected behavior is exhibited by the "top" node, which is not rotated. ### Steps to reproduce Rotate a control node 90 degrees and set its anchors so that it will have to be dynamically resized on one edge of the parent. Resize the parent node. (See above video). ### Minimal reproduction project (MRP) MRP: [rotated_control_anchors_mrp.zip](https://github.com/user-attachments/files/17913011/rotated_control_anchors_mrp.zip)
bug,topic:editor,topic:gui
low
Minor
2,693,279,063
flutter
RichText renders empty text's height incorrectly when TextStyle.height > 1
### Steps to reproduce Use this code, works in DartPad (web platform affected as well). 1. Create 2 RichText widgets, where one contains empty TextSpan and the other non-empty (single character is fine). 2. Set both have TextStyle.height set to 1.8. 3. Observe heights of the two RichTexts, the empty RichText is taller. ### Expected results RichText heights to be identical. I believe the correct one should be the non-empty version. ### Actual results The empty RichText gets bigger height. On desktop (macos) I observed difference of 2px. ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple), useMaterial3: true, ), home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } class MyHomePage extends StatefulWidget { const MyHomePage({super.key, required this.title}); final String title; @override State<MyHomePage> createState() => _MyHomePageState(); } class _MyHomePageState extends State<MyHomePage> { GlobalKey _key1 = GlobalKey(); GlobalKey _key2 = GlobalKey(); double _height1 = 0; double _height2 = 0; void _incrementCounter() { setState(() { _height1 = _key1.currentContext!.size!.height; _height2 = _key2.currentContext!.size!.height; }); } @override Widget build(BuildContext context) { final style = TextStyle(height: 1.8); return Scaffold( appBar: AppBar( backgroundColor: Theme.of(context).colorScheme.inversePrimary, title: Text(widget.title), ), body: Center( child: Column( mainAxisAlignment: MainAxisAlignment.center, children: <Widget>[ Text('empty'), RichText( key: _key1, text: TextSpan(text: '', style: style), ), Text( '$_height1', style: Theme.of(context).textTheme.headlineMedium, ), RichText( key: _key2, text: TextSpan(text: 'non empty', style: style), ), Text( '$_height2', style: Theme.of(context).textTheme.headlineMedium, ), ], ), ), floatingActionButton: FloatingActionButton( onPressed: _incrementCounter, tooltip: 'Increment', child: const Icon(Icons.add), ), // This trailing comma makes auto-formatting nicer for build methods. ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> <img width="200" alt="image" src="https://github.com/user-attachments/assets/ce75083a-ce7c-4e53-8a78-337fbe5ce425"> </details> ### Logs <details open><summary>Logs</summary> ```console [Paste your logs here] ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console flutter doctor -v โ”Œโ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ” โ”‚ A new version of Flutter is available! โ”‚ โ”‚ โ”‚ โ”‚ To update to the latest version, run "flutter upgrade". โ”‚ โ””โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”€โ”˜ [โœ“] Flutter (Channel stable, 3.24.3, on Microsoft Windows [Version 10.0.22631.4460], locale en-US) โ€ข Flutter version 3.24.3 on channel stable at C:\Users\anato\dev\flutter โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision 2663184aa7 (3 months ago), 2024-09-11 16:27:48 -0500 โ€ข Engine revision 36335019a8 โ€ข Dart version 3.5.3 โ€ข DevTools version 2.37.3 [โœ“] Windows Version (Installed version of Windows is version 10 or higher) [โœ“] Android toolchain - develop for Android devices (Android SDK version 35.0.0) โ€ข Android SDK at C:\Users\anato\AppData\Local\Android\sdk โ€ข Platform android-35, build-tools 35.0.0 โ€ข Java binary at: C:\Program Files\Android\Android Studio\jbr\bin\java โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314) โ€ข All Android licenses accepted. [โœ“] Chrome - develop for the web โ€ข Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe [โœ“] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.11.2) โ€ข Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community โ€ข Visual Studio Community 2022 version 17.11.35222.181 โ€ข Windows 10 SDK version 10.0.22621.0 [โœ“] Android Studio (version 2024.1) โ€ข Android Studio at C:\Program Files\Android\Android Studio โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314) [โœ“] VS Code (version 1.94.0) โ€ข VS Code at C:\Users\anato\AppData\Local\Programs\Microsoft VS Code โ€ข Flutter extension version 3.98.0 [โœ“] Connected device (3 available) โ€ข Windows (desktop) โ€ข windows โ€ข windows-x64 โ€ข Microsoft Windows [Version 10.0.22631.4460] โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 131.0.6778.86 โ€ข Edge (web) โ€ข edge โ€ข web-javascript โ€ข Microsoft Edge 131.0.2903.63 [โœ“] Network resources โ€ข All expected network resources are available. โ€ข No issues found! ``` </details>
framework,a: typography,platform-web,a: desktop,has reproducible steps,P3,team-engine,triaged-engine,found in release: 3.24,found in release: 3.27
low
Minor
2,693,286,218
flutter
Method `getOffsetForCaret` return incorrect offset.
### Steps to reproduce 1. Copy paste the provided code. 2. Type `i` n number times till we don't reach the next line. 3. Then type `i` 4 more time in the next line. ### Expected results Method `getOffsetForCaret` should return correct offset. When we go to the next line, the `getOffsetForCaret` should return `dy` offest to be `23` and `dx` should be `4.86...`. ### Actual results We type the 'i' character n number of times until we reach the end of the line. While continuing to type 'i' characters, if a line break occurs (which is rendered correctly on the screen), the Offset remains invalid. A valid line break is only considered when we type 4 more 'i' characters on the next line. However, if we type a different character, such as '@', as the last character and a line break occurs, the offset is correctly returned. ### Code sample <details open><summary>Code sample</summary> ```dart import 'dart:ui'; import 'package:flutter/material.dart'; void main() => runApp(MyApp()); class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Get cursor (caret) position', debugShowCheckedModeBanner: false, theme: ThemeData( useMaterial3: true, colorScheme: ColorScheme.highContrastLight(), inputDecorationTheme: InputDecorationTheme( border: OutlineInputBorder( borderRadius: BorderRadius.circular(8.0), ))), home: MyHomePage(title: 'Get cursor (caret) position'), ); } } class MyHomePage extends StatefulWidget { const MyHomePage({ required this.title, super.key, }); final String title; @override State<MyHomePage> createState() => _MyHomePageState(); } class _MyHomePageState extends State<MyHomePage> { final TextStyle _textFieldStyle = TextStyle(fontSize: 20); final TextEditingController _textFieldController = TextEditingController(); late final TextField _textField; double xCaret = 0.0; double yCaret = 0.0; double painterWidth = 0.0; double painterHeight = 0.0; double preferredLineHeight = 0.0; Size physicalSize = Size.zero; Size devicePixelRatio = Size.zero; @override void initState() { super.initState(); /// Listen changes on your text field controller _textFieldController.addListener(() { _updateCaretOffset(_textFieldController.text); }); _textField = TextField( controller: _textFieldController, keyboardType: TextInputType.multiline, style: _textFieldStyle, maxLines: 5, ); } void _updateCaretOffset(String text) { // First get the FlutterView. FlutterView view = WidgetsBinding.instance.platformDispatcher.views.first; // Dimensions in physical pixels (px) physicalSize = view.physicalSize; // Dimensions in logical pixels (dp) devicePixelRatio = view.physicalSize / view.devicePixelRatio; TextPainter painter = TextPainter( textDirection: TextDirection.ltr, text: TextSpan(style: _textFieldStyle, text: text), maxLines: _textField.maxLines, ); painter.layout( // 32 is (symmetric horizontal padding) around the whole body // 32 is (symmetric horizontal padding) inside input decoration maxWidth: devicePixelRatio.width - (32 + 32 + _textField.cursorWidth), ); TextPosition cursorTextPosition = _textFieldController.selection.base; Rect caretPrototype = Rect.fromLTWH( 0.0, 0.0, _textField.cursorWidth, _textField.cursorHeight ?? painter.preferredLineHeight, ); Offset caretOffset = painter.getOffsetForCaret(cursorTextPosition, caretPrototype); setState(() { xCaret = caretOffset.dx; yCaret = caretOffset.dy; painterWidth = painter.width; painterHeight = painter.height; preferredLineHeight = painter.preferredLineHeight; }); } @override Widget build(BuildContext context) { final dataMap = { "xCaret": xCaret.toString(), "yCaret": yCaret.toString(), "yCaretBottom": (yCaret + preferredLineHeight).toString(), "Painter Width": painterWidth.toString(), "Painter Height": painterHeight.toString(), "Preferred Line Height": preferredLineHeight.toString(), "Physical Size": "${physicalSize.width} x ${physicalSize.height}", "Device Pixel Ratio": "${devicePixelRatio.width} x ${devicePixelRatio.height}", }; return Scaffold( appBar: AppBar(title: Text(widget.title)), body: SingleChildScrollView( child: Padding( padding: const EdgeInsets.symmetric(horizontal: 16), child: Column( mainAxisAlignment: MainAxisAlignment.center, crossAxisAlignment: CrossAxisAlignment.center, children: [ Text(dataMap.entries .map((e) => '${e.key}: ${e.value}') .join('\n')), _textField, ], ), ), ), ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> https://github.com/user-attachments/assets/037f2824-55dd-41e7-9b81-0bc135dbe314 </details> ### Logs <details open><summary>Logs</summary> ```console [!] Flutter (Channel beta, 3.27.0-0.1.pre, on Microsoft Windows [Version 10.0.22631.4460], locale en-IN) โ€ข Flutter version 3.27.0-0.1.pre on channel beta at C:\Users\harsh\fvm\default ! Warning: `flutter` on your path resolves to C:\Users\harsh\fvm\versions\beta\bin\flutter, which is not inside your current Flutter SDK checkout at C:\Users\harsh\fvm\default. Consider adding C:\Users\harsh\fvm\default\bin to the front of your path. ! Warning: `dart` on your path resolves to C:\Users\harsh\fvm\versions\beta\bin\dart, which is not inside your current Flutter SDK checkout at C:\Users\harsh\fvm\default. Consider adding C:\Users\harsh\fvm\default\bin to the front of your path. โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision 2e2c358c9b (5 weeks ago), 2024-10-22 11:02:13 -0400 โ€ข Engine revision af0f0d559c โ€ข Dart version 3.6.0 (build 3.6.0-334.3.beta) โ€ข DevTools version 2.40.1 โ€ข If those were intentional, you can disregard the above warnings; however it is recommended to use "git" directly to perform update checks and upgrades. [โœ“] Windows Version (Installed version of Windows is version 10 or higher) [โœ“] Android toolchain - develop for Android devices (Android SDK version 35.0.0-rc2) โ€ข Android SDK at C:\Users\harsh\AppData\Local\Android\sdk โ€ข Platform android-35, build-tools 35.0.0-rc2 โ€ข Java binary at: C:\Program Files\Android\Android Studio2\jbr\bin\java โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314) โ€ข All Android licenses accepted. [โœ“] Chrome - develop for the web โ€ข Chrome at C:\Users\harsh\AppData\Local\Google\Chrome\Application\chrome.exe [!] Android Studio (version 2023.1) โ€ข Android Studio at C:\Program Files\Android\Android Studio1 โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โœ— Unable to determine bundled Java version. โ€ข Try updating or re-installing Android Studio. [โœ“] Android Studio (version 2024.1) โ€ข Android Studio at C:\Program Files\Android\Android Studio2 โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0--11852314) [โœ“] IntelliJ IDEA Community Edition (version 2023.2) โ€ข IntelliJ at C:\Program Files\JetBrains\IntelliJ IDEA Community Edition 2023.2.1 โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart [โœ“] VS Code (version 1.95.3) โ€ข VS Code at C:\Users\harsh\AppData\Local\Programs\Microsoft VS Code โ€ข Flutter extension version 3.101.20241031 [โœ“] Connected device (3 available) โ€ข SM G990B2 (mobile) โ€ข RZCX1046DPX โ€ข android-arm64 โ€ข Android 14 (API 34) โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 131.0.6778.86 โ€ข Edge (web) โ€ข edge โ€ข web-javascript โ€ข Microsoft Edge 129.0.2792.89 [โœ“] Network resources โ€ข All expected network resources are available. ! Doctor found issues in 2 categories. ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console [Paste your output here] ``` </details>
a: text input,has reproducible steps,P2,team-text-input,triaged-text-input,found in release: 3.24,found in release: 3.27
low
Critical
2,693,318,491
three.js
TSL infinity loop
### Description Create an attribute and name it the same than the attribute name using `toVar( name )` create infinity loop in the NodeBuilder ### Reproduction steps see jsfiddle / code below ### Code ```js const counters = attribute( 'counters', 'float' ).toVar( 'counters' ) // work with toVar('aCounters') this.vertexNode = Fn( () => { varyingProperty( 'float', 'vCounters' ).assign( counters ) }) () ``` ### Live example https://jsfiddle.net/Makio64/yp7tw0j1/3/ ### Screenshots _No response_ ### Version r170 ### Device _No response_ ### Browser _No response_ ### OS _No response_
Enhancement,TSL
low
Minor
2,693,327,236
kubernetes
Add Metrics for Lead Time and Defects
### What would you like to be added? Introduce two new metrics to enhance the observability of development and release cycles: Lead Time Metrics: Work Item Lead Time: Time from work item creation to production deployment. Release Lead Time: Average lead time for all work items in a release. Defects Metrics: Definition: Number of new bugs detected between the current and next release. ### Why is this needed? Lead Time: Helps identify bottlenecks and optimize delivery timelines. Defects: Indicates release quality and helps track regression issues. -Metric Details 1. Lead Time Type: Histogram/Summary Labels: work_item_id, release_id, team 2. Defects Type: Counter Labels: release_id, bug_severity, module -Implementation Overview Collect timestamps/logs for lead time metrics and integrate with issue trackers for defect metrics. Instrument metrics in relevant Kubernetes components. Validate via simulated workflows and ensure proper labeling.
sig/contributor-experience,kind/feature,needs-triage
low
Critical
2,693,335,992
pytorch
Compiled `nn.Module` with tensor subclass can't be moved to another device
### ๐Ÿ› Describe the bug ```python import torch aten = torch.ops.aten class Subclass(torch.Tensor): def __new__(cls, data): return torch.Tensor._make_wrapper_subclass(cls, data.shape, dtype=data.dtype, device=data.device) def __init__(self, data): self._data = data def __repr__(self): return f"{self.__class__.__name__}(data={self._data})" def __tensor_flatten__(self): return ["_data"], [] @classmethod def __tensor_unflatten__(cls, inner_tensors, ctx, outer_size, outer_stride): return cls(inner_tensors["_data"]) def __torch_function__(self, func, types, args, kwargs=None): if func == torch.nn.functional.linear: return func(args[0], args[1]._data, *args[2:]) with torch._C.DisableTorchFunctionSubclass(): return func(*args, **(kwargs or dict())) def __torch_dispatch__(self, func, types, args, kwargs): if func in (aten._to_copy.default, aten.detach.default): args = [x._data if isinstance(x, Subclass) else x for x in args] out = func(*args, **kwargs) return Subclass(out) raise NotImplementedError(f"{func=}") linear = torch.nn.Linear(2, 2) linear.weight = torch.nn.Parameter(Subclass(linear.weight.detach())) linear.compile() linear(torch.randn(1, 2)) linear.cpu() # doesn't work even for the same device ``` ``` RuntimeError Traceback (most recent call last) File ~/xxx/python3.10/site-packages/torch/nn/modules/module.py:948, in Module._apply(self, fn, recurse) 945 param_applied = torch.nn.Parameter( 946 param_applied, requires_grad=param.requires_grad 947 ) --> 948 torch.utils.swap_tensors(param, param_applied) 949 except Exception as e: File ~/xxx/python3.10/site-packages/torch/utils/__init__.py:51, in swap_tensors(t1, t2) 50 if weakref.getweakrefs(t1): ---> 51 raise RuntimeError("Cannot swap t1 because it has weakref associated with it") 52 if weakref.getweakrefs(t2): RuntimeError: Cannot swap t1 because it has weakref associated with it The above exception was the direct cause of the following exception: RuntimeError Traceback (most recent call last) Cell In[1], line 42 40 linear.compile() 41 linear(torch.randn(1, 2)) ---> 42 linear.cpu() File ~/xxx/python3.10/site-packages/torch/nn/modules/module.py:1121, in Module.cpu(self) 1112 def cpu(self: T) -> T: 1113 r"""Move all model parameters and buffers to the CPU. 1114 1115 .. note:: (...) 1119 Module: self 1120 """ -> 1121 return self._apply(lambda t: t.cpu()) File ~/xxx/python3.10/site-packages/torch/nn/modules/module.py:952, in Module._apply(self, fn, recurse) 950 if param_grad is not None: 951 param.grad = param_grad --> 952 raise RuntimeError( 953 f"_apply(): Couldn't swap {self._get_name()}.{key}" 954 ) from e 955 out_param = param 956 elif p_should_use_set_data: RuntimeError: _apply(): Couldn't swap Linear.weight ``` Per title. A compiled module with tensor subclass can't be moved to another device. cc: pytorch/ao#1309 ### Versions torch==2.6.0.dev20241125+cu124 cc @ezyang @albanD @chauhang @penguinwu
triaged,tensor subclass,oncall: pt2
low
Critical
2,693,378,911
deno
It has become more difficult to import PrismaClient in Deno 2.1
Version: Deno 2.1.1 Hello, First of all, Iโ€™m really excited about the improvements in Deno 2.1. However, since Deno 2.1 fixed the bug where files required from .cjs files were automatically treated as CommonJS, I've been unable to import Prisma Client. I understand that this is not an issue with Deno itself, but rather one of the many compatibility issues with Prisma. Nevertheless, as it relates to Deno's compatibility with CommonJS, I'd like to ask a question here. Before Deno 2.1, we used a helper script to import Prisma Client: ```js // prisma-client.cjs const mod = require("./generated/client/index.js"); Object.keys(mod).forEach((key) => { exports[key] = mod[key]; }); ``` ```ts // prisma-client.ts // @deno-types="./generated/client/deno/index.d.ts" export * from "./prisma-client.cjs"; ``` This allowed imports in other script files like: ```ts // foo.ts import { PrismaClient } from "./prisma-client.ts"; ``` This approach depended on the behavior fixed in Deno 2.1, where files required from .cjs were automatically considered CommonJS. When updating to Deno 2.1, I expected that this helper script would become unnecessary and that we could import like this: ```ts // package.json { "type": "commonjs", // other settings here... } ``` ```ts // foo.ts import { PrismaClient } from "./generated/client/index.js"; ``` Unfortunately, this didn't work as expected because Prisma generates its own package.json file in `./generated/client/package.json`, which doesn't include "type": "commonjs". Since there are several situations Prisma Client is regenerated, modifying `./generated/client/package.json` or changing filenames to `.cjs` after each regeneration isn't a sustainable solution. Iโ€™d really appreciate any advice or suggestions on how to fix this situation. Thank you!
upstream
low
Critical
2,693,401,792
pytorch
RISC-V CI support
### ๐Ÿš€ The feature, motivation and pitch We want to enable RISC-V CI support. However, the https://github.com/pytorch/pytorch/pull/140816 was closed. Any opportunity to add this feature? ### Alternatives _No response_ ### Additional context _No response_ cc @seemethere @malfet @pytorch/pytorch-dev-infra
feature,module: ci,triaged
low
Major
2,693,425,275
deno
Document how to run/update WPT tests
There should be a README.md in the tests/wpt folder.
docs,chore
low
Minor
2,693,455,617
tauri
`window.add_child(webview_builder)` support for mobile
### Describe the bug By viewing the source code, I'm found `add_child` only supports desktop, can it be compatible with mobile target? If wry is used, multiple webviews can be implemented like the following: ``` #[cfg(any(target_os = "ios", target_os = "android"))] let mut builder = wry::WebViewBuilder::new().with_url(curl); if !proxy.is_empty() { let parts: Vec<&str> = proxy.split(':').collect(); // Access the parts safely let proxy_host = parts.get(0).unwrap_or(&""); let proxy_port = parts.get(1).unwrap_or(&""); let proxy_config = wry::ProxyConfig::Socks5(wry::ProxyEndpoint { host: proxy_host.to_string(), port: proxy_port.to_string() }); builder = builder.with_proxy_config(proxy_config); } let webview = builder.build_as_child(&main_window).unwrap(); ``` But I think has some fatal issues, like not being able to access the **window__ TAURI__** And I don't know how to make them public through `Wry` ("withGlobalTauri"= true not effective) Multiple webviews on mobile target are a common requirement. ### Reproduction _No response_ ### Expected behavior 1. tauri **window.add_child** api compatible with mobile 2. wry creator can access **window__ TAURI__** 3. have a other rust sample for mobile create `multiple webviews` 1 ~ 3 Just satisfy any point ,the issue will be solved ### Full `tauri info` output ```text [โœ”] Environment - OS: Mac OS 14.5.0 arm64 (X64) โœ” Xcode Command Line Tools: installed โœ” rustc: 1.81.0 (eeb90cda1 2024-09-04) โœ” cargo: 1.81.0 (2dbb1af80 2024-08-20) โœ” rustup: 1.27.1 (54dd3d00f 2024-04-24) โœ” Rust toolchain: stable-aarch64-apple-darwin (default) - node: 20.18.0 - pnpm: 8.10.5 - yarn: 1.22.17 - npm: 8.19.4 [-] Packages - tauri ๐Ÿฆ€: 2.0.6 - tauri-build ๐Ÿฆ€: 2.0.2 - wry ๐Ÿฆ€: 0.46.3 - tao ๐Ÿฆ€: 0.30.5 - @tauri-apps/api ๎œ˜: 2.0.3 - @tauri-apps/cli ๎œ˜: 2.0.5 ``` ### Stack trace _No response_ ### Additional context _No response_
type: feature request,platform: iOS,platform: Android,scope: unstable flag
low
Critical
2,693,482,392
langchain
Langchain pgvector database sessions remain in idle mode
### Checked other resources - [X] I added a very descriptive title to this issue. - [X] I searched the LangChain documentation with the integrated search. - [X] I used the GitHub search to find a similar question and didn't find it. - [X] I am sure that this is a bug in LangChain rather than my code. - [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package). ### Example Code from langchain_postgres import PGVector from sqlalchemy.ext.asyncio import create_async_engine engine = create_async_engine(self.__CONNECTION_STRING) try: store = PGVector( embeddings = embeddings, collection_name = collection, connection = engine, use_jsonb = True, ) except Exception as e: raise e ### Error Message and Stack Trace (if applicable) Once I reach the maximum number of possible concurrent sessions in pgAdmin I get an error message telling me I reached the max level of open sessions. I have used the timeout parameters of PostgreSQL to close these sessions automatically (idle_in_transaction_session_timeout and idle_session_timeout), but normally they should get closed from the PGVector library. ### Description I am using PGVector library from langchain_postgres.vectorstores and create_async_engine from sqlalchemy.ext.asyncio to retrieve embeddings from a PostgreSQL database. I observed that for each retrieval from db, I get many sessions that become idle but never disappear from pgAdmin interface: ![SS_IssuePGVector](https://github.com/user-attachments/assets/83ad82a1-75cb-4119-9a6a-9ad01530f47c) I am using pgAdmin 4 8.2 version, PostgreSQL 16.2-1. ### System Info System Information ------------------ > OS: Windows > OS Version: 10.0.20348 > Python Version: 3.12.4 (tags/v3.12.4:8e8a4ba, Jun 6 2024, 19:30:16) [MSC v.1940 64 bit (AMD64)] Package Information ------------------- > langchain_core: 0.3.15 > langchain: 0.3.7 > langchain_community: 0.3.5 > langsmith: 0.1.137 > langchain_chroma: 0.1.4 > langchain_experimental: 0.3.3 > langchain_openai: 0.2.5 > langchain_postgres: 0.0.12 > langchain_text_splitters: 0.3.2 > langgraph: 0.2.46 Optional packages not installed ------------------------------- > langserve Other Dependencies ------------------ > aiohttp: 3.10.10 > async-timeout: Installed. No version info available. > chromadb: 0.5.17 > dataclasses-json: 0.6.7 > fastapi: 0.115.4 > httpx: 0.27.2 > httpx-sse: 0.4.0 > jsonpatch: 1.33 > langgraph-checkpoint: 2.0.3 > langgraph-sdk: 0.1.35 > numpy: 1.26.4 > openai: 1.54.0 > orjson: 3.10.10 > packaging: 24.1 > pgvector: 0.2.5 > psycopg: 3.2.3 > psycopg-pool: 3.2.3 > pydantic: 2.9.2 > pydantic-settings: 2.6.0 > PyYAML: 6.0.2 > requests: 2.32.3 > requests-toolbelt: 1.0.0 > SQLAlchemy: 2.0.35 > sqlalchemy: 2.0.35 > tenacity: 9.0.0 > tiktoken: 0.8.0 > typing-extensions: 4.12.2
โฑญ: vector store,investigate
low
Critical
2,693,507,537
tensorflow
The Doc of tfl.reverse_v2 need to be updated for supporting axes
**System information** - OS Platform and Distribution (e.g., Linux Ubuntu 16.04): Linux Ubuntu 22.04 - TensorFlow installed from (source or binary): source - TensorFlow version (or github SHA if from source): the latest version **Standalone code to reproduce the issue** The [doc of tfl.reverse_v2](https://www.tensorflow.org/mlir/tfl_ops#tflreverse_v2_tflreversev2op) only supports axis, but [the kernel implementation](https://source.chromium.org/chromium/chromium/src/+/main:third_party/tflite/src/tensorflow/lite/kernels/reverse.cc;l=85) can support axes, the implementation seems not be consistent with the doc.
type:docs-bug,stat:awaiting tensorflower,comp:lite
medium
Minor
2,693,615,498
flutter
[google_maps_flutter] iOS infoWindow is not showing always
### Steps to reproduce Click on a marker in the Google sample code ### Expected results The InfoWindow should be showing ### Actual results The InfoWindow is not showing. This issue only occurs on iOS. It does not occur on Android. ios version : 17.5 My yaml code .. name: flutter_application_1 description: "A new Flutter project." publish_to: 'none' version: 1.0.0+1 environment: sdk: ^3.5.4 dependencies: flutter: sdk: flutter cupertino_icons: ^1.0.8 google_maps_flutter: ^2.10.0 dev_dependencies: flutter_test: sdk: flutter flutter_lints: ^4.0.0 flutter: uses-material-design: true ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; import 'package:google_maps_flutter/google_maps_flutter.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); // This widget is the root of your application. @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple), useMaterial3: true, ), home: const MyHomePage(), ); } } class MyHomePage extends StatefulWidget { const MyHomePage({super.key}); @override State<MyHomePage> createState() => _MyHomePageState(); } class _MyHomePageState extends State<MyHomePage> { late GoogleMapController mapController; final LatLng _center = const LatLng(-33.86, 151.20); void _onMapCreated(GoogleMapController controller) { mapController = controller; } @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( primarySwatch: Colors.green, ), home: Scaffold( appBar: AppBar( title: const Text('Sydney'), backgroundColor: Colors.green[700]), body: GoogleMap( onMapCreated: _onMapCreated, initialCameraPosition: CameraPosition( target: _center, zoom: 14.0, ), markers: { const Marker( markerId: MarkerId('Sydney'), position: LatLng(-33.86, 151.20), infoWindow: InfoWindow( title: "Sydney", snippet: "Capital of New South Wales", ), ) }, ), ), ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> [Upload media here] ![Simulator Screenshot - iPhone 15 - 2024-11-26 at 16 52 52](https://github.com/user-attachments/assets/24b65505-3849-41f7-bc3d-9e8196f51784) </details> ### Logs <details open><summary>Logs</summary> ```console Launching lib/main.dart on iPhone 15 in debug mode... Xcode build done. 9.1s Connecting to VM Service at ws://127.0.0.1:56399/ujeJXU6tVYU=/ws Connected to the VM Service. Google Maps SDK for iOS version: 8.4.0.0 New version of Google Maps SDK for iOS available: 9.1.1.0 Reloaded 1 of 785 libraries in 188ms (compile: 8 ms, reload: 71 ms, reassemble: 86 ms). ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console Doctor summary (to see all details, run flutter doctor -v): [โœ“] Flutter (Channel stable, 3.24.5, on macOS 14.1.1 23B81 darwin-arm64, locale ko-KR) [โœ“] Android toolchain - develop for Android devices (Android SDK version 35.0.0) [โœ“] Xcode - develop for iOS and macOS (Xcode 15.4) [โœ“] Chrome - develop for the web [โœ“] Android Studio (version 2024.2) [โœ“] VS Code (version 1.95.3) [โœ“] Connected device (5 available) [โœ“] Network resources ``` </details>
platform-ios,p: maps,package,has reproducible steps,P2,team-ios,triaged-ios,found in release: 3.24,found in release: 3.27
low
Critical
2,693,616,264
vscode
code file not getting uploded in vs code
Type: <b>Bug</b> I am trying to upload code file it not getting uploaded. showing mw empty editor VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z) OS version: Windows_NT x64 10.0.19045 Modes: <details> <summary>System Info</summary> |Item|Value| |---|---| |CPUs|Intel(R) Core(TM) i5-6300U CPU @ 2.40GHz (4 x 2496)| |GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: enabled<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: enabled<br>webnn: disabled_off| |Load (avg)|undefined| |Memory (System)|15.89GB (10.07GB free)| |Process Argv|--crash-reporter-id c9c7fbdc-f352-48fc-8028-56a446029c76| |Screen Reader|no| |VM|0%| </details><details><summary>Extensions (2)</summary> Extension|Author (truncated)|Version ---|---|--- playwright|ms-|1.1.12 vscode-css-custom-properties|Toc|0.0.5 </details><details> <summary>A/B Experiments</summary> ``` vsliv368cf:30146710 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805cf:30301675 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 vscaac:30438847 c4g48928:30535728 azure-dev_surveyone:30548225 2i9eh265:30646982 962ge761:30959799 pythonnoceb:30805159 asynctok:30898717 pythonmypyd1:30879173 2e7ec940:31000449 pythontbext0:30879054 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 dsvsc021:30996838 jg8ic977:31013176 dvdeprecation:31068756 dwnewjupytercf:31046870 2f103344:31071589 nativerepl2:31139839 pythonrstrctxt:31112756 nativeloc2:31185842 cf971741:31144450 iacca1:31171482 notype1:31157159 5fd0e150:31155592 dwcopilot:31170013 stablechunks:31184530 ``` </details> <!-- generated by issue reporter -->
info-needed,triage-needed
low
Critical
2,693,623,384
langchain
Trying to use SQLDatabaseLoader gives error
### Checked other resources - [X] I added a very descriptive title to this issue. - [X] I searched the LangChain documentation with the integrated search. - [X] I used the GitHub search to find a similar question and didn't find it. - [X] I am sure that this is a bug in LangChain rather than my code. - [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package). ### Example Code def initialise(self): print("initialising...") connect_Url = URL.create( drivername="mssql+pyodbc", username=ConfigSettings.userId, password=ConfigSettings.password, host=ConfigSettings.server, database=ConfigSettings.database, query={"driver": "ODBC Driver 17 for SQL Server"}, ) engine = create_engine(connect_Url,echo=False) con = engine.connect() #self.db = SQLDatabase(engine=engine) self.db = SQLDatabase.from_uri(connect_Url, include_tables=["TestTable"], sample_rows_in_table_info=2) #table_names = self.db.get_usable_table_names() #print("Number of tables: ", len(table_names)) #response = self.db.run("SELECT top 10 * FROM InvoiceStatus") #print(response) query = "SELECT top 10 * FROM TestTable" self.llm = OpenAI(api_key=OPENAI_API_KEY) databaseLoader = SQLDatabaseLoader(db=self.db,query=query) docs = databaseLoader.load() print("Number of documents: ", len(docs)) print("Exiting...\n\n") ### Error Message and Stack Trace (if applicable) def initialise(self): print("initialising...") connect_Url = URL.create( drivername="mssql+pyodbc", username=ConfigSettings.userId, password=ConfigSettings.password, host=ConfigSettings.server, database=ConfigSettings.database, query={"driver": "ODBC Driver 17 for SQL Server"}, ) engine = create_engine(connect_Url,echo=False) con = engine.connect() #self.db = SQLDatabase(engine=engine) self.db = SQLDatabase.from_uri(connect_Url, include_tables=["TestTable"], sample_rows_in_table_info=2) #table_names = self.db.get_usable_table_names() #print("Number of tables: ", len(table_names)) #response = self.db.run("SELECT top 10 * FROM InvoiceStatus") #print(response) query = "SELECT top 10 * FROM TestTable" self.llm = OpenAI(api_key=OPENAI_API_KEY) databaseLoader = SQLDatabaseLoader(db=self.db,query=query) docs = databaseLoader.load() print("Number of documents: ", len(docs)) print("Exiting...\n\n") ### Description Hi there, I'm new here so apologies if its a silly question. I'm trying to query the database using the **SQLDatabaseLoader** but getting an error when calling load(). **sqlalchemy.exc.DBAPIError: (pyodbc.Error) ('HY010', '[HY010] [Microsoft][ODBC Driver 17 for SQL Server]Function sequence error (0) (SQLFetch)')** If I do any arbitrary SQL query, it works fine e.g #response = self.db.run("SELECT top 10 * FROM InvoiceStatus") #print(response) I tried different versions of SQLAlchemy with no luck either.. However, when calling load() it gives the following error: ----------------- RAG Db With OpenAI ---------------- initialising... Traceback (most recent call last): File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\sqlalchemy\engine\cursor.py", line 1109, in fetchone row = dbapi_cursor.fetchone() ^^^^^^^^^^^^^^^^^^^^^^^ pyodbc.Error: ('HY010', '[HY010] [Microsoft][ODBC Driver 17 for SQL Server]Function sequence error (0) (SQLFetch)') The above exception was the direct cause of the following exception: Traceback (most recent call last): File "E:\Projects\Python\main.py", line 28, in <module> dbRag1.initialise() File "E:\Projects\Python\ragWithOpenAI_Database.py", line 82, in initialise docs = databaseLoader.load() ^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\langchain_core\document_loaders\base.py", line 31, in load return list(self.lazy_load()) ^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\langchain_community\document_loaders\sql_database.py", line 90, in lazy_load for i, row in enumerate(result.mappings()): ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\sqlalchemy\engine\result.py", line 508, in iterrows for raw_row in self._fetchiter_impl(): ^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\sqlalchemy\engine\cursor.py", line 2086, in _fetchiter_impl row = fetchone(self, self.cursor) ^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\sqlalchemy\engine\cursor.py", line 1114, in fetchone self.handle_exception(result, dbapi_cursor, e) File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\sqlalchemy\engine\cursor.py", line 1085, in handle_exception result.connection._handle_dbapi_exception( File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\sqlalchemy\engine\base.py", line 2325, in _handle_dbapi_exception raise sqlalchemy_exception.with_traceback(exc_info[2]) from e File "C:\Users\User\AppData\Local\Packages\PythonSoftwareFoundation.Python.3.12_qbz5n2kfra8p0\LocalCache\local-packages\Python312\site-packages\sqlalchemy\engine\cursor.py", line 1109, in fetchone row = dbapi_cursor.fetchone() ^^^^^^^^^^^^^^^^^^^^^^^ sqlalchemy.exc.DBAPIError: (pyodbc.Error) ('HY010', '[HY010] [Microsoft][ODBC Driver 17 for SQL Server]Function sequence error (0) (SQLFetch)') Any help would be greatly appreciated. Thank you all, J ### System Info System Information ------------------ > OS: Windows > OS Version: 10.0.22631 > Python Version: 3.12.7 (tags/v3.12.7:0b05ead, Oct 1 2024, 03:06:41) [MSC v.1941 64 bit (AMD64)] Package Information ------------------- > langchain_core: 0.3.21 > langchain: 0.3.8 > langchain_community: 0.3.8 > langsmith: 0.1.146 > langchain_experimental: 0.3.3 > langchain_text_splitters: 0.3.2 Optional packages not installed ------------------------------- > langserve Other Dependencies ------------------ > aiohttp: 3.10.10 > async-timeout: Installed. No version info available. > dataclasses-json: 0.6.7 > httpx: 0.27.2 > httpx-sse: 0.4.0 > jsonpatch: 1.33 > numpy: 1.26.4 > orjson: 3.10.11 > packaging: 24.1 > pydantic: 2.9.2 > pydantic-settings: 2.6.1 > PyYAML: 6.0.2 > requests: 2.32.3 > requests-toolbelt: 1.0.0 > SQLAlchemy: 2.0.0 > tenacity: 8.5.0
๐Ÿค–:bug,investigate
low
Critical
2,693,632,985
kubernetes
The kubelet is unable to delete the cgroup path and not started static pods
### What happened? I have a single-node Kubernetes cluster, and after upgrading the Kubernetes cluster from v1.29.8 to v1.30.4 using kubeadm, the kubelet did not work properly. The etcd and control plane static pods were not started. The kubelet logs are as follows: ``` Nov 20 18:16:41 idp-yfsu-ppp9n-xqvk2-dn4sk kubelet[1083348]: time="2024-11-20T18:16:41+08:00" level=warning msg="Failed to remove cgroup (will retry)" error="rmdir /sys/fs/cgroup/freezer/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-podca1703cc072c4c5daa5a934e15a9ae5d.slice/cri-containerd-c576b43f0d4a95442d34e0b9a36407df75420306a2ec88e50dc615414b9bd5d0.scope: device or resource busy" Nov 20 18:16:41 idp-yfsu-ppp9n-xqvk2-dn4sk kubelet[1083348]: time="2024-11-20T18:16:41+08:00" level=warning msg="Failed to remove cgroup (will retry)" error="rmdir /sys/fs/cgroup/net_cls,net_prio/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-podca1703cc072c4c5daa5a934e15a9ae5d.slice/cri-containerd-c576b43f0d4a95442d34e0b9a36407df75420306a2ec88e50dc615414b9bd5d0.scope: device or resource busy" Nov 20 18:16:41 idp-yfsu-ppp9n-xqvk2-dn4sk kubelet[1083348]: time="2024-11-20T18:16:41+08:00" level=warning msg="Failed to remove cgroup (will retry)" error="rmdir /sys/fs/cgroup/net_cls,net_prio/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-podca1703cc072c4c5daa5a934e15a9ae5d.slice/cri-containerd-c576b43f0d4a95442d34e0b9a36407df75420306a2ec88e50dc615414b9bd5d0.scope: device or resource busy" Nov 20 18:16:41 idp-yfsu-ppp9n-xqvk2-dn4sk kubelet[1083348]: E1120 18:16:41.491031 1083348 controller.go:145] "Failed to ensure lease exists, will retry" err="Get \"https://192.168.136.227:6443/apis/coordination.k8s.io/v1/namespaces/kube-node-lease/leases/192.168.136.227?timeout=8s\": dial tcp 192.168.136.227:6443: connect: connection refused" interval="7s" Nov 20 18:16:41 idp-yfsu-ppp9n-xqvk2-dn4sk kubelet[1083348]: time="2024-11-20T18:16:41+08:00" level=error msg="Failed to remove cgroup" error="rmdir /sys/fs/cgroup/pids/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-podca1703cc072c4c5daa5a934e15a9ae5d.slice/cri-containerd-c576b43f0d4a95442d34e0b9a36407df75420306a2ec88e50dc615414b9bd5d0.scope: device or resource busy" Nov 20 18:16:41 idp-yfsu-ppp9n-xqvk2-dn4sk kubelet[1083348]: time="2024-11-20T18:16:41+08:00" level=error msg="Failed to remove cgroup" error="rmdir /sys/fs/cgroup/blkio/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-podca1703cc072c4c5daa5a934e15a9ae5d.slice/cri-containerd-c576b43f0d4a95442d34e0b9a36407df75420306a2ec88e50dc615414b9bd5d0.scope: device or resource busy" Nov 20 18:16:41 idp-yfsu-ppp9n-xqvk2-dn4sk kubelet[1083348]: time="2024-11-20T18:16:41+08:00" level=error msg="Failed to remove cgroup" error="rmdir /sys/fs/cgroup/hugetlb/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-podca1703cc072c4c5daa5a934e15a9ae5d.slice/cri-containerd-c576b43f0d4a95442d34e0b9a36407df75420306a2ec88e50dc615414b9bd5d0.scope: device or resource busy" Nov 20 18:16:41 idp-yfsu-ppp9n-xqvk2-dn4sk kubelet[1083348]: time="2024-11-20T18:16:41+08:00" level=error msg="Failed to remove cgroup" error="rmdir /sys/fs/cgroup/perf_event/kubepods.slice/kubepods-burstable.slice/kubepods-burstable-podca1703cc072c4c5daa5a934e15a9ae5d.slice/cri-containerd-c576b43f0d4a95442d34e0b9a36407df75420306a2ec88e50dc615414b9bd5d0.scope: device or resource busy" ``` ### What did you expect to happen? The kubelet should work properly and the static pods should be started normally. ### How can we reproduce it (as minimally and precisely as possible)? It is an intermittent issue and cannot be guaranteed to be reproducible. ### Anything else we need to know? everything returned to normal after I restarted the kubelet. ### Kubernetes version <details> ```console $ kubectl version Client Version: v1.30.4 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.30.4 ``` </details> ### Cloud provider <details> </details> ### OS version <details> ```console # On Linux: $ cat /etc/os-release NAME="CentOS Linux" VERSION="7 (Core)" ID="centos" ID_LIKE="rhel fedora" VERSION_ID="7" PRETTY_NAME="CentOS Linux 7 (Core)" ANSI_COLOR="0;31" CPE_NAME="cpe:/o:centos:centos:7" HOME_URL="https://www.centos.org/" BUG_REPORT_URL="https://bugs.centos.org/" CENTOS_MANTISBT_PROJECT="CentOS-7" CENTOS_MANTISBT_PROJECT_VERSION="7" REDHAT_SUPPORT_PRODUCT="centos" $ uname -a Linux idp-zgjia-8h9vw-5rr64-6f4d8 3.10.0-1160.el7.x86_64 #1 SMP Mon Oct 19 16:18:59 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux </details> ### Install tools <details> $ kubeadm version kubeadm version: &version.Info{Major:"1", Minor:"30", GitVersion:"v1.30.4", GitCommit:"a51b3b711150f57ffc1f526a640ec058514ed596", GitTreeState:"clean", BuildDate:"2024-09-10T11:08:31Z", GoVersion:"go1.22.7", Compiler:"gc", Platform:"linux/amd64"} </details> ### Container runtime (CRI) and version (if applicable) <details> dockerd version: v25.0.5 cri-docker version๏ผšv0.3.15 </details> ### Related plugins (CNI, CSI, ...) and versions (if applicable) <details> </details>
kind/support,sig/node,triage/needs-information,needs-triage
low
Critical
2,693,659,439
TypeScript
`tsserver` diagnostic discrepancy on identifier completion
### ๐Ÿ”Ž Search Terms region diagnostics auto complete ### ๐Ÿ•— Version & Regression Information - This changed between versions 5.5 and 5.6 I suspect this is a regression caused by #57842 ### โฏ Playground Link _No response_ ### ๐Ÿ’ป Code Any code that auto-completes an identifier should trigger the bug (sometimes) ### ๐Ÿ™ Actual behavior Typing an identifier that TS recognizes, then selecting one of the possible completions, may cause the server to see the source in a way that's inconsistent with the currently opened buffer. For example, some hours ago, I tried ```ts import { Typog/*cursor*/ } from "@mui/material"; ``` Completed to `Typography` succesfully, but the LSP said ``` Module '"@mui/material"' has no exported member 'Tyraphypog'. ``` Sometimes, instead of a permutation of chars, it's a duplicate substring (example: `useState` -> `useStState`) I can assure you this is **not an ESM-specific issue**, it happens with regular variables, and object properties too, even on minimal projects with 0 dependencies. I have to **restart the LSP multiple times** during a coding session. However, as I said, this is non-deterministic, sometimes it's fine for a while. A single restart is enough to sync the states, until the bug happens again. ### ๐Ÿ™‚ Expected behavior The LSP must have an internal state that's consistent (no discrepancies) with the actual buffer ### Additional information about the issue `hx -V`: `helix 24.7 (079f5442)` `npm ls -g` (snip): `[email protected]`
Needs More Info
low
Critical
2,693,669,225
flutter
window.print has no effect in webview_flutter
### What package does this bug report belong to? webview_flutter ### What target platforms are you seeing this bug on? Android, iOS ### Have you already upgraded your packages? Yes ### Dependency versions <details><summary>pubspec.lock</summary> ```lock # Generated by pub # See https://dart.dev/tools/pub/glossary#lockfile packages: async: dependency: transitive description: name: async sha256: "947bfcf187f74dbc5e146c9eb9c0f10c9f8b30743e341481c1e2ed3ecc18c20c" url: "https://pub.dev" source: hosted version: "2.11.0" boolean_selector: dependency: transitive description: name: boolean_selector sha256: "6cfb5af12253eaf2b368f07bacc5a80d1301a071c73360d746b7f2e32d762c66" url: "https://pub.dev" source: hosted version: "2.1.1" characters: dependency: transitive description: name: characters sha256: "04a925763edad70e8443c99234dc3328f442e811f1d8fd1a72f1c8ad0f69a605" url: "https://pub.dev" source: hosted version: "1.3.0" clock: dependency: transitive description: name: clock sha256: cb6d7f03e1de671e34607e909a7213e31d7752be4fb66a86d29fe1eb14bfb5cf url: "https://pub.dev" source: hosted version: "1.1.1" collection: dependency: transitive description: name: collection sha256: ee67cb0715911d28db6bf4af1026078bd6f0128b07a5f66fb2ed94ec6783c09a url: "https://pub.dev" source: hosted version: "1.18.0" cupertino_icons: dependency: "direct main" description: name: cupertino_icons sha256: ba631d1c7f7bef6b729a622b7b752645a2d076dba9976925b8f25725a30e1ee6 url: "https://pub.dev" source: hosted version: "1.0.8" fake_async: dependency: transitive description: name: fake_async sha256: "511392330127add0b769b75a987850d136345d9227c6b94c96a04cf4a391bf78" url: "https://pub.dev" source: hosted version: "1.3.1" flutter: dependency: "direct main" description: flutter source: sdk version: "0.0.0" flutter_lints: dependency: "direct dev" description: name: flutter_lints sha256: "5398f14efa795ffb7a33e9b6a08798b26a180edac4ad7db3f231e40f82ce11e1" url: "https://pub.dev" source: hosted version: "5.0.0" flutter_test: dependency: "direct dev" description: flutter source: sdk version: "0.0.0" leak_tracker: dependency: transitive description: name: leak_tracker sha256: "3f87a60e8c63aecc975dda1ceedbc8f24de75f09e4856ea27daf8958f2f0ce05" url: "https://pub.dev" source: hosted version: "10.0.5" leak_tracker_flutter_testing: dependency: transitive description: name: leak_tracker_flutter_testing sha256: "932549fb305594d82d7183ecd9fa93463e9914e1b67cacc34bc40906594a1806" url: "https://pub.dev" source: hosted version: "3.0.5" leak_tracker_testing: dependency: transitive description: name: leak_tracker_testing sha256: "6ba465d5d76e67ddf503e1161d1f4a6bc42306f9d66ca1e8f079a47290fb06d3" url: "https://pub.dev" source: hosted version: "3.0.1" lints: dependency: transitive description: name: lints sha256: "3315600f3fb3b135be672bf4a178c55f274bebe368325ae18462c89ac1e3b413" url: "https://pub.dev" source: hosted version: "5.0.0" matcher: dependency: transitive description: name: matcher sha256: d2323aa2060500f906aa31a895b4030b6da3ebdcc5619d14ce1aada65cd161cb url: "https://pub.dev" source: hosted version: "0.12.16+1" material_color_utilities: dependency: transitive description: name: material_color_utilities sha256: f7142bb1154231d7ea5f96bc7bde4bda2a0945d2806bb11670e30b850d56bdec url: "https://pub.dev" source: hosted version: "0.11.1" meta: dependency: transitive description: name: meta sha256: bdb68674043280c3428e9ec998512fb681678676b3c54e773629ffe74419f8c7 url: "https://pub.dev" source: hosted version: "1.15.0" path: dependency: transitive description: name: path sha256: "087ce49c3f0dc39180befefc60fdb4acd8f8620e5682fe2476afd0b3688bb4af" url: "https://pub.dev" source: hosted version: "1.9.0" plugin_platform_interface: dependency: transitive description: name: plugin_platform_interface sha256: "4820fbfdb9478b1ebae27888254d445073732dae3d6ea81f0b7e06d5dedc3f02" url: "https://pub.dev" source: hosted version: "2.1.8" sky_engine: dependency: transitive description: flutter source: sdk version: "0.0.99" source_span: dependency: transitive description: name: source_span sha256: "53e943d4206a5e30df338fd4c6e7a077e02254531b138a15aec3bd143c1a8b3c" url: "https://pub.dev" source: hosted version: "1.10.0" stack_trace: dependency: transitive description: name: stack_trace sha256: "73713990125a6d93122541237550ee3352a2d84baad52d375a4cad2eb9b7ce0b" url: "https://pub.dev" source: hosted version: "1.11.1" stream_channel: dependency: transitive description: name: stream_channel sha256: ba2aa5d8cc609d96bbb2899c28934f9e1af5cddbd60a827822ea467161eb54e7 url: "https://pub.dev" source: hosted version: "2.1.2" string_scanner: dependency: transitive description: name: string_scanner sha256: "556692adab6cfa87322a115640c11f13cb77b3f076ddcc5d6ae3c20242bedcde" url: "https://pub.dev" source: hosted version: "1.2.0" term_glyph: dependency: transitive description: name: term_glyph sha256: a29248a84fbb7c79282b40b8c72a1209db169a2e0542bce341da992fe1bc7e84 url: "https://pub.dev" source: hosted version: "1.2.1" test_api: dependency: transitive description: name: test_api sha256: "5b8a98dafc4d5c4c9c72d8b31ab2b23fc13422348d2997120294d3bac86b4ddb" url: "https://pub.dev" source: hosted version: "0.7.2" vector_math: dependency: transitive description: name: vector_math sha256: "80b3257d1492ce4d091729e3a67a60407d227c27241d6927be0130c98e741803" url: "https://pub.dev" source: hosted version: "2.1.4" vm_service: dependency: transitive description: name: vm_service sha256: "5c5f338a667b4c644744b661f309fb8080bb94b18a7e91ef1dbd343bed00ed6d" url: "https://pub.dev" source: hosted version: "14.2.5" webview_flutter: dependency: "direct main" description: name: webview_flutter sha256: "889a0a678e7c793c308c68739996227c9661590605e70b1f6cf6b9a6634f7aec" url: "https://pub.dev" source: hosted version: "4.10.0" webview_flutter_android: dependency: "direct main" description: name: webview_flutter_android sha256: "285cedfd9441267f6cca8843458620b5fda1af75b04f5818d0441acda5d7df19" url: "https://pub.dev" source: hosted version: "4.1.0" webview_flutter_platform_interface: dependency: transitive description: name: webview_flutter_platform_interface sha256: d937581d6e558908d7ae3dc1989c4f87b786891ab47bb9df7de548a151779d8d url: "https://pub.dev" source: hosted version: "2.10.0" webview_flutter_wkwebview: dependency: "direct main" description: name: webview_flutter_wkwebview sha256: b7e92f129482460951d96ef9a46b49db34bd2e1621685de26e9eaafd9674e7eb url: "https://pub.dev" source: hosted version: "3.16.3" sdks: dart: ">=3.5.3 <4.0.0" flutter: ">=3.24.0" ``` </details> ### Steps to reproduce Create a webview and open a webpage that contains a javascript call to `window.print()` A call to `console.log(window.print)` confirms that `window.print` is defined with native code as expected: ``` I/flutter (10914): Console message: function print() { [native code] } ``` Calling the `window.print()` has no effect. ### Expected results A native print dialog should open to print the page, or there should at least be a callback that can be defined similar to the other `setOn...` methods on the `WebViewController`. ### Actual results Nothing happens, there is also no configurable callback or any other documented way to use the print functionality. ### Code sample <details open><summary>Code sample</summary> ```dart // main.dart import 'package:flutter/material.dart'; import 'package:webview_flutter/webview_flutter.dart'; void main() { runApp(SafeArea( child: WebViewDemo(), )); } class WebViewDemo extends StatelessWidget { WebViewDemo({super.key}); final WebViewController controller = WebViewController() ..setJavaScriptMode(JavaScriptMode.unrestricted); @override Widget build(BuildContext context) { controller.loadHtmlString(html); return WebViewWidget(controller: controller); } } const String html = """ <button onclick="window.print();">Print</button> """; ``` </details> ### Screenshots or Videos _No response_ ### Logs <details open><summary>Logs</summary> ```console Launching lib/main.dart on sdk gphone64 arm64 in debug mode... Running Gradle task 'assembleDebug'... โœ“ Built build/app/outputs/flutter-apk/app-debug.apk Debug service listening on ws://127.0.0.1:60619/nzRYAXrcRdA=/ws Syncing files to device sdk gphone64 arm64... W/ziparchive(10914): Unable to open '/data/app/~~Vme_rk0-AslMu3303wjosQ==/com.google.android.trichromelibrary_677803933-XkffO01gI6R9ejGrXcUYvA==/base.dm': No such file or directory W/ziparchive(10914): Unable to open '/data/app/~~Vme_rk0-AslMu3303wjosQ==/com.google.android.trichromelibrary_677803933-XkffO01gI6R9ejGrXcUYvA==/base.dm': No such file or directory W/e.webview_print(10914): Entry not found D/nativeloader(10914): Configuring clns-7 for other apk /data/app/~~Vme_rk0-AslMu3303wjosQ==/com.google.android.trichromelibrary_677803933-XkffO01gI6R9ejGrXcUYvA==/base.apk. target_sdk_version=34, uses_libraries=ALL, library_path=/data/app/~~8gwkLz-FZPyeh0xFCaWjgQ==/com.google.android.webview-tPjHsVuT-xUfucET8eEAng==/lib/arm64:/data/app/~~8gwkLz-FZPyeh0xFCaWjgQ==/com.google.android.webview-tPjHsVuT-xUfucET8eEAng==/base.apk!/lib/arm64-v8a:/data/app/~~Vme_rk0-AslMu3303wjosQ==/com.google.android.trichromelibrary_677803933-XkffO01gI6R9ejGrXcUYvA==/base.apk!/lib/arm64-v8a, permitted_path=/data:/mnt/expand D/ApplicationLoaders(10914): Returning zygote-cached class loader: /system_ext/framework/androidx.window.extensions.jar D/nativeloader(10914): Configuring clns-8 for other apk /data/app/~~8gwkLz-FZPyeh0xFCaWjgQ==/com.google.android.webview-tPjHsVuT-xUfucET8eEAng==/base.apk. target_sdk_version=34, uses_libraries=, library_path=/data/app/~~8gwkLz-FZPyeh0xFCaWjgQ==/com.google.android.webview-tPjHsVuT-xUfucET8eEAng==/lib/arm64:/data/app/~~8gwkLz-FZPyeh0xFCaWjgQ==/com.google.android.webview-tPjHsVuT-xUfucET8eEAng==/base.apk!/lib/arm64-v8a:/data/app/~~Vme_rk0-AslMu3303wjosQ==/com.google.android.trichromelibrary_677803933-XkffO01gI6R9ejGrXcUYvA==/base.apk!/lib/arm64-v8a, permitted_path=/data:/mnt/expand I/WebViewFactory(10914): Loading com.google.android.webview version 131.0.6778.39 (code 677803933) I/cr_WVCFactoryProvider(10914): version=131.0.6778.39 (677803933) minSdkVersion=29 isBundle=true multiprocess=true packageId=2 E/chromium(10914): [1126/091900.622208:ERROR:variations_seed_loader.cc(39)] Seed missing signature. I/chromium(10914): [1126/091900.623419:INFO:variations_seed_loader.cc(68)] Failed to open file for reading.: No such file or directory (2) I/cr_LibraryLoader(10914): Successfully loaded native library I/cr_CachingUmaRecorder(10914): Flushed 6 samples from 6 histograms, 0 samples were dropped. I/cr_CombinedPProvider(10914): #registerProvider() provider:WV.y8@cb1aef0 isPolicyCacheEnabled:false policyProvidersSize:0 I/cr_PolicyProvider(10914): #setManagerAndSource() 0 I/cr_CombinedPProvider(10914): #linkNativeInternal() 1 D/CompatibilityChangeReporter(10914): Compat change id reported: 183155436; UID 10198; state: ENABLED I/cr_AppResProvider(10914): #getApplicationRestrictionsFromUserManager() Bundle[EMPTY_PARCEL] I/cr_PolicyProvider(10914): #notifySettingsAvailable() 0 I/cr_CombinedPProvider(10914): #onSettingsAvailable() 0 I/cr_CombinedPProvider(10914): #flushPolicies() W/chromium(10914): [WARNING:dns_config_service_android.cc(81)] Failed to read DnsConfig. D/CompatibilityChangeReporter(10914): Compat change id reported: 214741472; UID 10198; state: ENABLED D/CompatibilityChangeReporter(10914): Compat change id reported: 171228096; UID 10198; state: ENABLED W/cr_media(10914): BLUETOOTH_CONNECT permission is missing. W/cr_media(10914): getBluetoothAdapter() requires BLUETOOTH permission W/cr_media(10914): registerBluetoothIntentsIfNeeded: Requires BLUETOOTH permission I/PlatformViewsController(10914): Hosting view in view hierarchy for platform view: 0 I/PlatformViewsController(10914): PlatformView is using SurfaceProducer backend D/CompatibilityChangeReporter(10914): Compat change id reported: 236825255; UID 10198; state: ENABLED E/FrameEvents(10914): updateAcquireFence: Did not find frame. D/CompatibilityChangeReporter(10914): Compat change id reported: 193247900; UID 10198; state: ENABLED W/chromium(10914): [WARNING:viz_main_impl.cc(85)] VizNullHypothesis is disabled (not a warning) E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. D/EGL_emulation(10914): app_time_stats: avg=355.47ms min=49.46ms max=882.58ms count=3 E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. D/EGL_emulation(10914): app_time_stats: avg=378.97ms min=171.96ms max=508.60ms count=4 E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. D/EGL_emulation(10914): app_time_stats: avg=145.45ms min=11.97ms max=460.91ms count=10 D/EGL_emulation(10914): app_time_stats: avg=111.88ms min=2.87ms max=463.58ms count=9 D/ProfileInstaller(10914): Installing profile for com.example.webview_print D/CompatibilityChangeReporter(10914): Compat change id reported: 289878283; UID 10198; state: ENABLED E/FrameEvents(10914): updateAcquireFence: Did not find frame. D/EGL_emulation(10914): app_time_stats: avg=11490.51ms min=11490.51ms max=11490.51ms count=1 D/EGL_emulation(10914): app_time_stats: avg=1485.16ms min=22.76ms max=11471.93ms count=8 E/FrameEvents(10914): updateAcquireFence: Did not find frame. D/EGL_emulation(10914): app_time_stats: avg=11484.67ms min=11484.67ms max=11484.67ms count=1 I/flutter (10914): Console message: function print() { [native code] } E/FrameEvents(10914): updateAcquireFence: Did not find frame. I/e.webview_print(10914): NativeAlloc concurrent copying GC freed 46037(2715KB) AllocSpace objects, 4(80KB) LOS objects, 49% free, 3312KB/6625KB, paused 281us,14us total 187.689ms E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. D/EGL_emulation(10914): app_time_stats: avg=1550.96ms min=18.14ms max=5938.52ms count=4 D/EGL_emulation(10914): app_time_stats: avg=1542.25ms min=15.84ms max=5937.07ms count=4 D/EGL_emulation(10914): app_time_stats: avg=1231.06ms min=25.68ms max=5922.11ms count=5 E/FrameEvents(10914): updateAcquireFence: Did not find frame. E/FrameEvents(10914): updateAcquireFence: Did not find frame. ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console flutter doctor -v [โœ“] Flutter (Channel stable, 3.24.3, on macOS 15.1.1 24B91 darwin-arm64, locale en-US) โ€ข Flutter version 3.24.3 on channel stable at /Users/xxx/Tools/flutter โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision 2663184aa7 (3 months ago), 2024-09-11 16:27:48 -0500 โ€ข Engine revision 36335019a8 โ€ข Dart version 3.5.3 โ€ข DevTools version 2.37.3 [โœ“] Android toolchain - develop for Android devices (Android SDK version 35.0.0) โ€ข Android SDK at /Users/xxx/Library/Android/sdk โ€ข Platform android-35, build-tools 35.0.0 โ€ข ANDROID_HOME = /Users/xxx/Library/Android โ€ข Java binary at: /Users/xxx/Applications/Android Studio.app/Contents/jbr/Contents/Home/bin/java โ€ข Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11) โ€ข All Android licenses accepted. [โœ“] Xcode - develop for iOS and macOS (Xcode 16.1) โ€ข Xcode at /Applications/Xcode.app/Contents/Developer โ€ข Build 16B40 โ€ข CocoaPods version 1.16.2 [โœ“] Chrome - develop for the web โ€ข Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [โœ“] Android Studio (version 2024.2) โ€ข Android Studio at /Users/xxx/Applications/Android Studio.app/Contents โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 21.0.3+-79915917-b509.11) [โœ“] IntelliJ IDEA Ultimate Edition (version 2024.3) โ€ข IntelliJ at /Users/xxx/Applications/IntelliJ IDEA Ultimate.app โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart [โœ“] VS Code (version 1.95.3) โ€ข VS Code at /Applications/Visual Studio Code.app/Contents โ€ข Flutter extension can be installed from: ๐Ÿ”จ https://marketplace.visualstudio.com/items?itemName=Dart-Code.flutter [โœ“] Connected device (5 available) โ€ข sdk gphone64 arm64 (mobile) โ€ข emulator-5554 โ€ข android-arm64 โ€ข Android 14 (API 34) (emulator) โ€ข iPhone SE (3rd generation) (mobile) โ€ข F36E9547-5F62-4989-9B36-7692CA2AADEC โ€ข ios โ€ข com.apple.CoreSimulator.SimRuntime.iOS-17-5 (simulator) โ€ข macOS (desktop) โ€ข macos โ€ข darwin-arm64 โ€ข macOS 15.1.1 24B91 darwin-arm64 โ€ข Mac Designed for iPad (desktop) โ€ข mac-designed-for-ipad โ€ข darwin โ€ข macOS 15.1.1 24B91 darwin-arm64 โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 131.0.6778.86 ! Error: Browsing on the local area network for Ownership of Hana. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac. The device must be opted into Developer Mode to connect wirelessly. (code -27) [โœ“] Network resources โ€ข All expected network resources are available. โ€ข No issues found! ``` </details>
p: webview,package,team-ecosystem,has reproducible steps,P3,triaged-ecosystem,found in release: 3.24,found in release: 3.27
low
Critical
2,693,785,037
react
Bug: web animation cancel() followed by animate() behave oddly when requestAnimationFrame's involved
See repro: [tinyurl.com/4u85ehnh](https://t.co/3eMtHJfEQ5) Video of the glitch: https://x.com/_chenglou/status/1860978002643063054 Tldr on button click I cancel the existing animation and in `useLayoutEffect` I start a new one. The animation goes from translate 100px to 200px. However, clicking on the button will show a split second glitched unstyled view of the animated text (position at 0px) before jumping to 100px and animating to 200px. Commenting out the `requestAnimationFrame` wrapper inside `handleClick` solves it. Happens across Chrome, Safari and Firefox. Notes: - The rAF happens on the same frame as everything else, so there shouldn't be any visible DOM repaint - Even if the rAF is executed later, it'd means `cancel()` is executed _later_, which should hide the unstyled visual, not reveal it - Although, the fact is that rAF can be _scheduled_ earlier, if this is relevant: https://x.com/nomsternom/status/1853687984266055983 (original post unrelated to this issue) - You can check the difference in console.logs. The microtask log result & order is different. The logs themselves (including getComputedStyle which forces reflows) don't disturb this repro - FWIW, I was wondering whether the first frame of `animate()` is skipped when `cancel()` is done in the rAF, and it seems it's preserved. Another debugging video (first 6 times glitching, 7th time not) below. The first frame's position is 100px, which is where the red square is. For alignment. Here: https://github.com/user-attachments/assets/c7a9a21f-57e7-4123-bac5-8a07a02741f4 I'd also like to be able to get a clean, React-less repro but not sure how complicated that'd be.
Status: Unconfirmed
low
Critical
2,693,822,993
rustdesk
When the host computer screenshots and transfers it to the controlled computer, pasting it into WeChat 4.0 results in a blank image.
### Bug Description When the host computer screenshots and transfers it to the controlled computer, pasting it into WeChat 4.0 results in a blank image. ### How to Reproduce You can reproduce the issue by directly pasting the screenshot from the host computer into WeChat 4.0. ### Expected Behavior The image should be a normal image when pasted into WeChat. ### Operating system(s) on local (controlling) side and remote (controlled) side Windows11->windows10ltsc2019 ### RustDesk Version(s) on local (controlling) side and remote (controlled) side 1.3.2->1.3.2 ### Screenshots https://github.com/user-attachments/assets/0f6ce0aa-cb01-4898-88a5-2451d647dc98 ### Additional Context _No response_
bug
low
Critical
2,693,824,227
react-native
Bug: startTransition is causing TypeError when used directly from react
### Description Getting this error message when using SWR with expo SDK 52, this issue was not present in expo SDK 51. This issue is only present on android and ios for react native web the SWR calls works without any type error. `TypeError: Cannot read property 'add' of undefined` On Expo snack the error says `Error: "Cannot read property 'add' of undefined" in TypeError: Cannot read property 'add' of undefined << at requestUpdateLane (/data/user/0/host.exp.exponent/files/.expo-internal/5cb1b0c52b8fcab94364327c83b808ee:18892:43) << at dispatchSetState (/data/user/0/host.exp.exponent/files/.expo-internal/5cb1b0c52b8fcab94364327c83b808ee:16726:33) << at anonymous (swr.mutation:12:14616)` This is how SWR is using the startTransition API, When I tried using the `startTransition` from the `useTransition` hook the problem got solved ``` export const startTransition: (scope: TransitionFunction) => void = IS_REACT_LEGACY ? cb => { cb() } : React.startTransition ``` And use like this ``` startTransition(() => setState({ data, isMutating: false, error: undefined }) ) ``` Code from this repository https://github.com/vercel/swr/blob/1585a3e37d90ad0df8097b099db38f1afb43c95d/src/mutation/state.ts#L5-L10 Some of my findings are here - https://github.com/facebook/react/issues/31622 ### Steps to reproduce 1. Run the code example https://snack.expo.dev/@raajnadar/swr-error-in-expo-sdk-52 2. Run android or ios, the web version works without the error 3. Click the "Call the API button" button inside the mobile app 4. Check the logs tab, when switched to axios there is no issue 5. This happens with `swr` because it uses startTransition internally ### React Native Version 0.76.3 ### Affected Platforms Runtime - Android, Runtime - iOS ### Output of `npx react-native info` ```text System: OS: macOS 14.2.1 CPU: (10) arm64 Apple M1 Pro Memory: 102.55 MB / 16.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 18.19.0 path: ~/.nvm/versions/node/v18.19.0/bin/node Yarn: version: 1.22.19 path: /usr/local/bin/yarn npm: version: 10.2.3 path: ~/.nvm/versions/node/v18.19.0/bin/npm Watchman: Not Found Managers: CocoaPods: version: 1.12.0 path: /Users/chris/.rbenv/shims/pod SDKs: iOS SDK: Platforms: - DriverKit 23.4 - iOS 17.4 - macOS 14.4 - tvOS 17.4 - visionOS 1.1 - watchOS 10.4 Android SDK: Not Found IDEs: Android Studio: 2024.2 AI-242.21829.142.2421.12409432 Xcode: version: 15.3/15E204a path: /usr/bin/xcodebuild Languages: Java: version: 17.0.12 path: /usr/bin/javac Ruby: version: 2.7.5 path: /Users/chris/.rbenv/shims/ruby npmPackages: "@react-native-community/cli": installed: 15.0.1 wanted: 15.0.1 react: installed: 18.3.1 wanted: 18.3.1 react-native: installed: 0.76.2 wanted: 0.76.2 react-native-macos: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: true newArchEnabled: true iOS: hermesEnabled: true newArchEnabled: true ``` ### Stacktrace or Logs ```text TypeError: Cannot read property 'add' of undefined at requestCurrentTransition (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server&app={BUNDLE_ID}:13106:36) at requestUpdateLane (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server&app={BUNDLE_ID}:15752:50) at dispatchSetState (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server&app={BUNDLE_ID}:9607:37) at anonymous (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server&app={BUNDLE_ID}:373831:17) at anonymous (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server&app={BUNDLE_ID}:373890:32) at startTransition (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server&app={BUNDLE_ID}:20591:16) at ?anon_0_ (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server&app={BUNDLE_ID}:373889:30) at next (native) at asyncGeneratorStep (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server&app={BUNDLE_ID}:23563:19) at _next (http://localhost:8081/index.bundle//&platform=ios&dev=true&lazy=true&minify=false&inlineSourceMap=false&modulesOnly=false&runModule=true&excludeSource=true&sourcePaths=url-server&app={BUNDLE_ID}:23577:29) at tryCallOne (address at InternalBytecode.js:1:1180) at anonymous (address at InternalBytecode.js:1:1874) ``` ### Reproducer https://snack.expo.dev/@raajnadar/swr-error-in-expo-sdk-52 ### Screenshots and Videos _No response_
Needs: Triage :mag:,Type: Expo
low
Critical
2,693,830,730
kubernetes
kubelet can't print stack like containerd
### What would you like to be added? kill -s SIGUSR1 `pidof containerd ` containerd will print stack. but i can't find kubelet how to print stack ### Why is this needed? to print where is hanging.
sig/node,kind/feature,needs-triage
low
Major
2,693,894,812
flutter
Issue with widget boundaries when specifying widget dimensions under non-integer windows display scaling.
### Steps to reproduce ISSUE: When Windows display scaling is set to non-integer values, such as 125% or 150%, setting the dimensions of widgets can result in some sizes being displayed incompletely, with partially transparent borders. 1. Change windows display scale to non 100% 200% values, such as 150%. 2. New flutter project. 3. In the initial page, keep the Scaffold, remove all child widgets, and replace them with a Column containing Containers of different heights (e.g., 30-40 height), each with the same color which contrast with the background. 4. Run this page and there are some line will show between containers, and these lines has color same to container with alpha. ### Expected results example on 100% windows display scale: ![image](https://github.com/user-attachments/assets/61916eb7-ea4e-4ca9-b7f4-2c593cf20e74) ### Actual results example on 150% windows display scale: ![image](https://github.com/user-attachments/assets/4ce9379c-a9fb-4dcb-810e-4ce630aa4c58) ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple), useMaterial3: true, ), home: const DpiScalePage(), ); } } class DpiScalePage extends StatelessWidget { const DpiScalePage({super.key}); @override Widget build(BuildContext context) { return Scaffold( body: Column( mainAxisSize: MainAxisSize.max, children: [ testContainer(26), testContainer(27), testContainer(28), testContainer(29), testContainer(30), testContainer(31), testContainer(32), testContainer(33), testContainer(34), testContainer(35), testContainer(36), testContainer(37), testContainer(38), testContainer(39), testContainer(40), ], ), ); } } Widget testContainer(double height) { return Container( color: Colors.grey.shade700, padding: const EdgeInsets.only(left: 20), height: height, width: double.infinity, alignment: Alignment.centerLeft, child: Text( "height: $height.", style: const TextStyle(fontSize: 14, color: Colors.black), ), ); } ``` [main.zip](https://github.com/user-attachments/files/17917156/main.zip) </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> ![image](https://github.com/user-attachments/assets/c36877e4-56ee-46d7-a64e-546cd9e5bbe1) </details> ### Logs <details open><summary>Logs</summary> ```console Wrong displays, don't have logs. ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console PS F:\ๆกŒ้ข> flutter doctor -v [โœ“] Flutter (Channel stable, 3.24.5, on Microsoft Windows [็‰ˆๆœฌ 10.0.19045.5131], locale zh-CN) โ€ข Flutter version 3.24.5 on channel stable at D:\0-SDK\flutter โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision dec2ee5c1f (13 days ago), 2024-11-13 11:13:06 -0800 โ€ข Engine revision a18df97ca5 โ€ข Dart version 3.5.4 โ€ข DevTools version 2.37.3 [โœ“] Windows Version (Installed version of Windows is version 10 or higher) [โœ“] Android toolchain - develop for Android devices (Android SDK version 34.0.0) โ€ข Android SDK at D:\0-SDK\android-sdk โ€ข Platform android-34, build-tools 34.0.0 โ€ข Java binary at: D:\Android Studio\jbr\bin\java โ€ข Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11) โ€ข All Android licenses accepted. [โœ“] Chrome - develop for the web โ€ข Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe [โœ“] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.11.5) โ€ข Visual Studio at D:\Microsoft VS โ€ข Visual Studio Community 2022 version 17.11.35327.3 โ€ข Windows 10 SDK version 10.0.22621.0 [โœ“] Android Studio (version 2024.2) โ€ข Android Studio at D:\Android Studio โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11) [โœ“] Proxy Configuration โ€ข HTTP_PROXY is set โ€ข NO_PROXY is 127.0.0.1,localhost,::1 โ€ข NO_PROXY contains localhost โ€ข NO_PROXY contains ::1 โ€ข NO_PROXY contains 127.0.0.1 [โœ“] Connected device (3 available) โ€ข Windows (desktop) โ€ข windows โ€ข windows-x64 โ€ข Microsoft Windows [็‰ˆๆœฌ 10.0.19045.5131] โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 131.0.6778.86 โ€ข Edge (web) โ€ข edge โ€ข web-javascript โ€ข Microsoft Edge 130.0.2849.80 [โœ“] Network resources โ€ข All expected network resources are available. ``` </details>
platform-windows,platform-web,a: desktop,team-framework,fyi-web
low
Minor
2,694,015,027
TypeScript
`Intl.DurationFormat` missing from library definitions
### โš™ Compilation target ESNext ### โš™ Library ESNext ### Missing / Incorrect Definition `Intl.DurationFormat` is missing. It's implemented in all browsers except Firefox. ### Sample Code ```TypeScript new Intl.DurationFormat('en-US', { style: 'long' }).format({ hours: 5, minutes: 2, seconds: 42 }) // '5 hours, 2 minutes, 42 seconds' ``` ### Documentation Link https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DurationFormat https://github.com/tc39/proposal-intl-duration-format
Bug,Help Wanted,Domain: lib.d.ts
low
Minor
2,694,036,469
angular
`FormResetEvent` is not emitted via `AbstractControl.reset()`
### Which @angular/* package(s) are the source of the bug? forms ### Is this a regression? No ### Description While working with forms, I was trying to subscribe to the `FormResetEvent` on `AbstractControl.events` and adding some special logic for when a form is reset (by the user or programatically with new initial values). Surprisingly the event is never emitted when using `AbstractControl.reset()`, but only when a `<input type="reset">` button is clicked. Here are some screenshots from the StackBlitz linked below: ![Image](https://github.com/user-attachments/assets/a093f008-b93c-4b99-8688-a9f2f5cf80aa) As you can see the `FormResetEvent` is only emitted by the second form: ![Image](https://github.com/user-attachments/assets/701a4a44-9479-4bc0-aa8e-69edac3ab1b1) ### Please provide a link to a minimal reproduction of the bug https://stackblitz.com/edit/stackblitz-starters-y6dgmq?file=src%2Fmain.ts ### Please provide the exception or error you saw ```true ``` ### Please provide the environment you discovered this bug in (run `ng version`) ```true Angular CLI: 18.2.12 Node: 22.11.0 Package Manager: npm 10.9.0 OS: linux x64 Angular: 18.2.12 ... animations, cli, common, compiler, compiler-cli, core, forms ... platform-browser, platform-browser-dynamic, router Package Version --------------------------------------------------------- @angular-devkit/architect 0.1802.12 @angular-devkit/build-angular 18.2.12 @angular-devkit/core 18.2.12 @angular-devkit/schematics 18.2.12 @angular/cdk 18.2.14 @schematics/angular 18.2.12 ng-packagr 18.2.1 rxjs 7.8.1 typescript 5.5.4 zone.js 0.14.10 But also happens with Angular 19 (see StackBlitz) ``` ### Anything else? _No response_
area: forms
low
Critical
2,694,064,193
rust
macOS: Crate symbols get discarded when crate appears unused
<!-- Thank you for filing a bug report! ๐Ÿ› Please provide a short summary of the bug, along with any information you feel relevant to replicating the bug. --> <details> <summary>I tried <a href="https://gitlab.com/Fraser999/divan-example">this code</a>:</summary> Within the base crate, the [`#[divan::bench]`](https://docs.rs/divan/latest/divan/attr.bench.html) macro is used for benchmarking crate internals. Its generated code translates to something similar to: ```rs #[used] #[cfg_attr(target_os = "macos", link_section = "__DATA,__mod_init_func,mod_init_funcs")] #[cfg_attr(target_os = "linux", link_section = ".init_array")] #[cfg_attr(target_os = "windows", link_section = ".CRT$XCU")] static CONSTRUCTOR: extern "C" fn() = constructor; extern "C" fn constructor() { // Register benchmark... } ``` This crate has a benchmark executable with only: ```rs fn main() { divan::main(); } ``` </details> I expected to see this happen: run the `add` benchmark and output the results. This runs correctly on Linux and Windows, but not macOS. Instead, this happened: [`divan::main()`](https://docs.rs/divan/latest/divan/fn.main.html) cannot find the benchmark because the pre-`main` constructor function never ran. In order to make the benchmarks visible to the executable, the base crate needs to have one of its items appear to be used, such as `black_box`-ing _any_ item from the crate. Note that this also happens with code like: ```rs #[used(linker)] #[link_section = "__DATA,__my_values,regular,no_dead_strip"] static VALUE: u32 = 42; ``` This issue occurs even when doing `extern crate my_crate` or `use my_crate as _`, which is a known workaround for similar issues. ### Meta <!-- If you're using the stable version of the compiler, you should also check if the bug also exists in the beta or nightly versions. --> `rustc --version --verbose`: ``` rustc 1.82.0 (f6e511eec 2024-10-15) binary: rustc commit-hash: f6e511eec7342f59a25f7c0534f1dbea00d01b14 commit-date: 2024-10-15 host: aarch64-apple-darwin release: 1.82.0 LLVM version: 19.1.1 ```
A-linkage,O-macos,T-compiler,C-bug,O-apple
low
Critical
2,694,068,063
flutter
SIGSEGV Fatal Signal 11 in DartVM (Null Pointer Dereference)
**Description:** I'm encountering a fatal crash (SIGSEGV) in my Flutter application due to a null pointer dereference within the DartVM. The crash occurs during a hot reload after making changes to a file related to order payment processing. **Steps to Reproduce:** 1. Run the Flutter application on an Android emulator (sdk_gphone64_arm64) or physical device. 4. Initiate a multiple hot reloads. 5. The application crashes with the SIGSEGV error. ### Expected results App should not crash randomly because of doing a hot-reload. ### Actual results App should is crash randomly because of doing a hot-reload in debug mode. There is not much information about what exactly is causing this issue. ### Code sample No reproducible steps found yet. ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> [Upload media here] </details> ### Logs ``` [+2963 ms] Skipping target: gen_localizations [ ] Skipping target: gen_dart_plugin_registrant [ ] Skipping target: _composite [ ] complete [ +78 ms] Scanned through 2011 files in 54ms [ +1 ms] Compiling dart to kernel with 1 updated files [ ] Processing bundle. [ ] <- recompile package:app/main.dart d812b473-2083-4f7c-b566-2293279dcef5 [ ] package:app/view_binder.dart [ ] <- d812b473-2083-4f7c-b566-2293279dcef5 [ +5 ms] Bundle processing done. [+1712 ms] Updating files. [ ] Pending asset builds completed. Writing dirty entries. [ +237 ms] DevFS: Sync finished [ ] Synced 12.2MB. [+1186 ms] E/DartVM ( 624): become: Cannot forward to multiple targets [ ] E/DartVM ( 624): before: 7813544831 [ ] E/DartVM ( 624): after: 7815e2d491 [ ] E/DartVM ( 624): before header: 3236 [ ] E/DartVM ( 624): after header: 104c236 [ ] F/libc ( 624): Fatal signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x2b8 in tid 985 (DartWorker), pid 624 (taurant.pos.uat) [ +705 ms] *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** *** [ ] Build fingerprint: 'google/sdk_gphone64_arm64/emu64a:14/UPB5.230623.003/10615560:userdebug/dev-keys' [ ] Revision: '0' [ ] ABI: 'arm64' [ ] Timestamp: 2024-11-26 15:29:25.776258813+0530 [ ] Process uptime: 207s [ ] Cmdline: ################### [ ] pid: 624, tid: 985, name: DartWorker >>> ################### <<< [ ] uid: 10189 [ ] tagged_addr_ctrl: 0000000000000001 (PR_TAGGED_ADDR_ENABLE) [ ] pac_enabled_keys: 000000000000000f (PR_PAC_APIAKEY, PR_PAC_APIBKEY, PR_PAC_APDAKEY, PR_PAC_APDBKEY) [ ] signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 0x00000000000002b8 [ ] Cause: null pointer dereference [ ] x0 b400007b8017cda0 x1 0000007815e2d491 x2 0000000000000004 x3 0000000000000003 [ ] x4 00000079c34f9070 x5 0000000000714f90 x6 0000000000000010 x7 7f7f7f7f7f7f7f7f [ ] x8 0000000000000000 x9 0000007a08785790 x10 b400007b8017cda0 x11 0000000000000001 [ ] x12 00000079c34f91a0 x13 0000000000000017 x14 00000079c34f9250 x15 000019b028ecf368 [ ] x16 0000007a08763ff0 x17 0000007d3b72e280 x18 00000079c24d8000 x19 0000007a06365b4e [ ] x20 b400007b8017cdb0 x21 b400007b8017cda0 x22 0000007815e2d491 x23 0000007813544831 [ ] x24 0000007813544830 x25 0000000000002574 x26 0000007a086eeb58 x27 0000007a086eef98 [ ] x28 0000007a08785000 x29 0000000000000000 [ ] lr 0000007a084b4e3c sp 00000079c34fa950 pc 0000007a084b4e48 pst 0000000020001000 [ ] 16 total frames [ ] backtrace: [ ] #00 pc 0000000002353e48 /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #01 pc 0000000002353da4 /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #02 pc 00000000022291ec /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #03 pc 00000000022254b0 /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #04 pc 000000000221ebf0 /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #05 pc 00000000023183f0 /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #06 pc 000000000230ef68 /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #07 pc 000000000230f458 /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #08 pc 000000000221cdbc /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #09 pc 00000000022408e8 /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #10 pc 0000000002240d48 /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #11 pc 000000000233781c /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #12 pc 0000000002337a6c /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #13 pc 00000000022ca1fc /data/app/~~ts6acVdx08zbNGTVPAOatA==/###################-ueS568_-88gSl5IxHOpDXQ==/base.apk!libflutter.so (offset 0xa0a8000) (BuildId: 78551bb34007bb924e8d0a744b490d6df4d1e038) [ ] #14 pc 00000000000be6a8 /apex/com.android.runtime/lib64/bionic/libc.so (__pthread_start(void*)+208) (BuildId: c74277f481a383c87215b672f6465e24) [ ] #15 pc 000000000005b21c /apex/com.android.runtime/lib64/bionic/libc.so (__start_thread+64) (BuildId: c74277f481a383c87215b672f6465e24) [ +152 ms] Service protocol connection closed. [ ] Lost connection to device. [ ] DevFS: Deleting filesystem on the device (file:///data/user/0/###################/code_cache/EXAMPLE_APPWDXONW/EXAMPLE_APP/) [ ] DevFS: Deleted filesystem on the device (file:///data/user/0/###################/code_cache/EXAMPLE_APPWDXONW/EXAMPLE_APP/) [ +5 ms] "flutter run" took 2,33,939ms. [ +120 ms] ensureAnalyticsSent: 95ms [ ] Running 2 shutdown hooks [ +15 ms] Shutdown hooks complete [ +99 ms] exiting with code 0 Exited. ``` ### Flutter Doctor output **Flutter Doctor Output:** ``` [โœ“] Flutter (Channel stable, 3.24.5, on macOS 15.0.1 24A348 darwin-arm64, locale en-IN) โ€ข Flutter version 3.24.5 on channel stable at /Users/development/flutter_v3.24.4 โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision dec2ee5c1f (13 days ago), 2024-11-13 11:13:06 -0800 โ€ข Engine revision a18df97ca5 โ€ข Dart version 3.5.4 โ€ข DevTools version 2.37.3 [!] Android toolchain - develop for Android devices (Android SDK version 34.0.0) โ€ข Android SDK at /Users/Library/Android/sdk โœ— cmdline-tools component is missing Run `path/to/sdkmanager --install "cmdline-tools;latest"` See https://developer.android.com/studio/command-line for more details. โœ— Android license status unknown. Run `flutter doctor --android-licenses` to accept the SDK licenses. See https://flutter.dev/to/macos-android-setup for more details. [โœ“] Xcode - develop for iOS and macOS (Xcode 15.4) โ€ข Xcode at /Applications/Xcode.app/Contents/Developer โ€ข Build 15F31d โ€ข CocoaPods version 1.15.2 [โœ“] Chrome - develop for the web โ€ข Chrome at /Applications/Google Chrome.app/Contents/MacOS/Google Chrome [โœ“] Android Studio (version 2024.1) โ€ข Android Studio at /Applications/Android Studio.app/Contents โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 17.0.11+0-17.0.11b1207.24-11852314) [โœ“] VS Code (version 1.95.3) โ€ข VS Code at /Applications/Visual Studio Code.app/Contents โ€ข Flutter extension version 3.100.0 [โœ“] Connected device (4 available) โ€ข D3 PRO (mobile) โ€ข adb-DP02P45Q10201-ecYAkE._adb-tls-connect._tcp. โ€ข android-arm64 โ€ข Android 13 (API 33) โ€ข sdk gphone64 arm64 (mobile) โ€ข emulator-5554 โ€ข android-arm64 โ€ข Android 14 (API 34) (emulator) โ€ข Mac Designed for iPad (desktop) โ€ข mac-designed-for-ipad โ€ข darwin โ€ข macOS 15.0.1 24A348 darwin-arm64 โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 131.0.6778.86 ! Error: Browsing on the local area network for 401E iPhone14. Ensure the device is unlocked and attached with a cable or associated with the same local area network as this Mac. The device must be opted into Developer Mode to connect wirelessly. (code -27) [โœ“] Network resources โ€ข All expected network resources are available. ``` **Device Information:** * Device: Android 13, Android Emulator * OS Version: Mac os sequoia 15.0.1 (24A348) * Flutter Version: 3.24.5 **Additional Notes:** * The crash occurs consistently after modifying any file and performing a hot reload. * I have tested on android 13 & 14 and observed the same behavior. **Please let me know if you require any further information to investigate this issue.**
waiting for customer response,in triage
low
Critical
2,694,081,331
three.js
NodeMaterial: Add utility to convert normal materials to their node pendants.
### Description Copying a model to get its properties assigned from a meshmaterial to a nodematerial breaks ### Reproduction steps 1. create a MeshBasicMaterial 2.create a MeshBasicNodeMaterial 3.copy the meshbasicmaterial into the node one ### Live example [Live fiddle test ](https://jsfiddle.net/njf1mae9/8/) Line 53 ### Screenshots <img width="425" alt="Screenshot 2024-11-26 at 11 28 01" src="https://github.com/user-attachments/assets/2efff5f5-5e6a-46bf-90ee-4d4fabbbc142"> ### Version r170 ### Device Desktop ### Browser Chrome ### OS MacOS
Enhancement
low
Major
2,694,202,150
pytorch
Incremental CI testing
### ๐Ÿš€ The feature, motivation and pitch This is an idea about how we could reduce some of the on-PR testing while shortening the feedback cycle on PR for PyTorch contributors. This is based on the assumption that PRs typically go through one or more iterations, driven by a combination of automated testing and human reviews. Today we run the whole matrix of relevant tests on PR submission. If one of the linter jobs fails, it is likely that the whole matrix will be run again. Looking at the data for September and October 2024 on the [PyTorch CI Cost](https://hud.pytorch.org/cost_analysis) tool, the `pull` category accounts for ~30% of the entire expenditure, so a significant reduction in pull request testing would have a significant impact on expenditure. A different approach could be as follows: - on PR submission (and sync) only run a subset of the matrix (e.g. linters plus non-backend specific tests) - a list of available tests is posted as a comment to the PRs, contributors may trigger extra tests on demand - an admin may request to run the whole test matrix on demand - all tests (same as today) are executed before merge, so we still gate on the same matrix as today The downside of this approach is that it introduces the risk of discovering issues only at merge time, and we would have to measure this to see if on average this leads to a reduction in resource utilisation and an improvement on the user experience. One metric to consider would be the average number of CI runs per PR, or perhaps the cost analytics tool (https://hud.pytorch.org/cost_analysis) could be extended to calculate the cost per PR and average cost per PR. In terms of user experience with the CI system, a survey could be used. ### Alternatives There are already a number of strategies in place to reduce waste in CI testing: - When a test job fails, the entire group is cancelled - Test jobs are filtered based on the files touched by a PR Alternative approaches could be: - Make the cancelling more aggressive: when a job fail cancel more than the group. This is a risky strategy thought, and might result in more resource consumption ultimately, as a flake job or temporary infra issue on one of the jobs would cancel the entire run, wasting all CI resources used up to that point. - Make the filtering more precise. This also involves a good amount of risk, as it is easy to over-optimise which could lead to a reduction of quality for the project. Quality is not something we should compromise on. If we had good quality data about relationship between changes and failures in tests, we could attempt to use AI to decide when to run a test, but I believe such dataset is not available ### Additional context With this issue, I would like to gauge how the community of PyTorch contributors about the idea, and hopefully evolve it into a form that can help us reduce CI resource consumption without compromising on quality and user experience. cc @seemethere @malfet @pytorch/pytorch-dev-infra
feature,module: ci,triaged
low
Critical
2,694,342,252
vscode
test "hint is not shown when there has been input" always fails
* run `./scripts/test.sh --dev` * notice silent fails of ``` 2 !== 0 at terminalInitialHint.test.js:95:17 (anonymous) @ terminalInitialHint.test.js:95 setTimeout (anonymous) @ terminalInitialHint.test.js:93 ```
debt,unit-test-failure
low
Minor
2,694,371,569
ollama
Ovis1.6-Gemma2-27B Model request
https://huggingface.co/AIDC-AI/Ovis1.6-Gemma2-27B very good multi modal. Could be the best open source multimodal atm. Would love to have it in Ollama.
model request
low
Minor
2,694,403,459
pytorch
[Feature Request] Add source Inductor Python file path to each Triton kernel
### ๐Ÿš€ The feature, motivation and pitch When using torch.compile, we have noticed that the generated Triton code may throw runtime errors. One possible solution is to locate the corresponding source code and then use `torch.compiler.disable` to fallback to ATen. It seems that the only way to locate the source code is finding the Python file generated by Inductor that contains the Triton kernel, then identifying the relevant FxGraph nodes from the its comments, and finally speculating on which part of the source code these FxGraph nodes belong to. However, searching the Triton kernel's origin Inductor Python file can be quite cumbersome, as the Python file may contains too many Triton kernels. If the Triton code could include a path to its Inductor Python file, debugging would be much easier. ```diff + # Origin: /tmp/torchinductor_xxx/yy/zzz.py import triton import triton.language as tl from triton.compiler.compiler import AttrsDescriptor from torch._inductor.runtime import triton_helpers, triton_heuristics from torch._inductor.runtime.triton_helpers import libdevice, math as tl_math from torch._inductor.runtime.hints import AutotuneHint, ReductionHint, TileHint, instance_descriptor, DeviceProperties @triton_heuristics.pointwise @triton.jit def triton_(in_ptr0, out_ptr0, xnumel, XBLOCK : tl.constexpr): ``` ### Alternatives _No response_ ### Additional context I'm glad to submit a PR if this Feature Request passed. cc @chauhang @penguinwu
triaged,oncall: pt2
low
Critical
2,694,476,300
terminal
Foreground and background are inverted for certain characters
### Windows Terminal version 1.22.3232.0 ### Windows build number 10.0.22631.0 ### Other Software _No response_ ### Steps to reproduce The *Black Large Circle* โฌค (`0x2b24`) has inverted colors, e.g. printing both *Black Circle* โ— (`0x25cf`) and the large version in red via PowerShell: ```pwsh echo "$([char]0x001b)[31mโ—โฌค$([char]0x001b)[0m" ``` (The explicit coloring is not necessary to show this, though my use case requires the color to indicate various statuses.) ### Expected Behavior In both cases the circle is red. ### Actual Behavior Only for the small circle is red, for the larger one, the background becomes red instead: ![screenshot showing inversion](https://github.com/user-attachments/assets/18273490-2eb0-46d0-8dcc-f64f1b951f6c) VS Code seems to do this as well in the editor ๐Ÿค” ![screenshot showing inversion in VS code text file](https://github.com/user-attachments/assets/a142c610-7482-46c3-9fee-da277174e0cd) ...but its terminal does not ![screenshot showing no inversion in VS Code terminal](https://github.com/user-attachments/assets/0c933aad-f62d-45e0-80c9-9c201ef27b49)
Needs-Repro,Area-Rendering,Issue-Bug,Product-Terminal
low
Major
2,694,491,040
pytorch
Advanced indexing with empty ellipsis (discrepency to numpy)
### ๐Ÿ› Describe the bug There is a difference in handling empty ellipses in advanced indexing. The order of the result axes changes if the axes indexed are not next to each other. In that case, the new axes are prepended at the beginning. If they are neighboring, the are put in place of the original axes. Here pytorch seems to check if an ellipsis actually covers any axes. Numpy always treats it as covering axes and moves the new dimensions to the front ```python import numpy as np a=np.ones((3,4,5)) print(a[:,(0,1),...,(0,1)].shape) # (2, 3) import torch a=torch.ones(3,4,5) print(a[:,(0,1),...,(0,1)].shape) # torch.Size([3, 2]) ``` Is this an intentional deviation? Is this documented anywhere? Or is it a bug? (If it is a bug, I am not sure if it is possible to fix this without breaking compilation or backward compatibility. ) ### Versions torch version: 2.5.1+cu121
triaged,module: advanced indexing
low
Critical
2,694,515,378
langchain
PromptTemplate doesn't work with multi layer metadata (e.g. BedrockKnowledgeBase/AmazonKnowledgeBasesRetriever)
### Checked other resources - [X] I added a very descriptive title to this issue. - [X] I searched the LangChain documentation with the integrated search. - [X] I used the GitHub search to find a similar question and didn't find it. - [X] I am sure that this is a bug in LangChain rather than my code. - [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package). ### Example Code ``` def _get_document_info(doc: Document, prompt: BasePromptTemplate[str]) -> dict: if 'source_metadata' in doc.metadata: base_info = {"page_content": doc.page_content, **doc.metadata, **doc.metadata['source_metadata']} else: base_info = {"page_content": doc.page_content, **doc.metadata} ``` ### Error Message and Stack Trace (if applicable) _No response_ ### Description I'm trying to use Langchain as a conversational retrieval chain to pull documents with metadata from BedrockKnowledgeBase, include the document prompt with some Bedrock Metadata in the prompt template. The document metadata for the Document object looks like: metadata: { location: "s3://xyz", score: 0.654, source_metadata: { field_i_want: 123, another_field: 456} } The prompt template is failing in base_get_document_info() on the missing_metadata check as it only draws on the base level of metadata. The following is a (hack) resolution: ``` def _get_document_info(doc: Document, prompt: BasePromptTemplate[str]) -> dict: if 'source_metadata' in doc.metadata: base_info = {"page_content": doc.page_content, **doc.metadata, **doc.metadata['source_metadata']} else: base_info = {"page_content": doc.page_content, **doc.metadata} ``` however the tactical resolution would be to somehow allow the dict path to be specified. ### System Info System Information ------------------ > OS: Darwin > OS Version: Darwin Kernel Version 23.6.0: Thu Sep 12 23:36:12 PDT 2024; root:xnu-10063.141.1.701.1~1/RELEASE_ARM64_T6020 > Python Version: 3.12.5 (main, Aug 6 2024, 19:08:49) [Clang 15.0.0 (clang-1500.3.9.4)] Package Information ------------------- > langchain_core: 0.3.15 > langchain: 0.3.7 > langchain_community: 0.3.5 > langsmith: 0.1.142 > langchain_aws: 0.2.7 > langchain_text_splitters: 0.3.2 Optional packages not installed ------------------------------- > langgraph > langserve Other Dependencies ------------------ > aiohttp: 3.10.10 > async-timeout: Installed. No version info available. > boto3: 1.35.57 > dataclasses-json: 0.5.9 > httpx: 0.27.2 > httpx-sse: 0.4.0 > jsonpatch: 1.33 > numpy: 1.26.4 > orjson: 3.10.11 > packaging: 23.2 > pydantic: 2.9.2 > pydantic-settings: 2.6.1 > PyYAML: 6.0.2 > requests: 2.32.3 > requests-toolbelt: 1.0.0 > SQLAlchemy: 2.0.35 > tenacity: 8.3.0 > typing-extensions: 4.12.2
๐Ÿค–:bug
low
Critical
2,694,534,573
PowerToys
PowerToys Peek
### Microsoft PowerToys version 0.86.0 ### Installation method Microsoft Store, PowerToys auto-update ### Running as admin No ### Area(s) with issue? Peek ### Steps to reproduce - Open a file using Peek (ctrl + space) - Minimize the file - Select another file and open the file using Peek ### โœ”๏ธ Expected Behavior I expected peek to un-minimize itself and show the file I opened. ### โŒ Actual Behavior Instead it seems to stay minimized until I open it from my taskbar. I'm not sure if this is considered a bug, but usually when you open a file in an app, the app will "un-minimize" to show the file you opened using the app. But peek doesnt seem to do so. ### Other Software _No response_
Issue-Bug,Help Wanted,Resolution-Fix Committed,Status-Reproducible,Product-Peek
low
Critical
2,694,535,611
tensorflow
Heap-buffer-overflow in `SparseMatrixSparseCholesky`
### Issue type Bug ### Have you reproduced the bug with TensorFlow Nightly? Yes ### Source source ### TensorFlow version tf2.17.0 tf2.16.1 ### Custom code Yes ### OS platform and distribution Ubuntu 20.04 ### Mobile device _No response_ ### Python version 3.11 ### Bazel version _No response_ ### GCC/compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current behavior? When batch_index is scalar, `SparseMatrixSparseCholesky` triggered a crash. ### Standalone code to reproduce the issue ```shell import tensorflow as tf indices = tf.constant([[0, 0], [1, 1], [2, 1], [2, 2], [3, 3]], dtype=tf.int64) values = tf.constant([1.0, 2.0, 1.0, 3.0, 4.0], tf.float32) dense_shape = tf.constant([4, 4], dtype=tf.int64) input = tf.raw_ops.SparseTensorToCSRSparseMatrix( indices=indices, values=values, dense_shape=dense_shape, name=None ) permutation = tf.constant([4,1,1,1], dtype=tf.int32) tf.raw_ops.SparseMatrixSparseCholesky( input=input, permutation=permutation, type=tf.float32 ) ``` ### Relevant log output ```shell ================================================================= ==3331846==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x60700049d1d0 at pc 0x7faa202d6d87 bp 0x7ffd09bf8fe0 sp 0x7ffd09bf8fd0 WRITE of size 4 at 0x60700049d1d0 thread T0 #0 0x7faa202d6d86 in tensorflow::CSRSparseCholeskyCPUOp<float>::Compute(tensorflow::OpKernelContext*)::{lambda(long, long)#1}::operator()(long, long) const (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x3e2a2d86) #1 0x7faa4e5b373a in std::_Function_handler<void (long, long), tsl::thread::ThreadPool::ParallelFor(long, long, std::function<void (long, long)> const&)::{lambda(long, long)#1}>::_M_invoke(std::_Any_data const&, long&&, long&&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x41f373a) #2 0x7faa4e5b84e9 in Eigen::ThreadPoolDevice::parallelFor(long, Eigen::TensorOpCost const&, std::function<long (long)>, std::function<void (long, long)>) const (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x41f84e9) #3 0x7faa4e5c1d41 in tsl::thread::ThreadPool::ParallelFor(long, long, std::function<void (long, long)> const&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x4201d41) #4 0x7faa4ca98d71 in tensorflow::Shard(int, tsl::thread::ThreadPool*, long, long, std::function<void (long, long)>) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x26d8d71) #5 0x7faa202e1ab6 in tensorflow::CSRSparseCholeskyCPUOp<float>::Compute(tensorflow::OpKernelContext*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x3e2adab6) #6 0x7faa4c09c14a in tensorflow::ThreadPoolDevice::Compute(tensorflow::OpKernel*, tensorflow::OpKernelContext*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x1cdc14a) #7 0x7faa4bc22fe6 in tensorflow::(anonymous namespace)::SingleThreadedExecutorImpl::Run(tensorflow::Executor::Args const&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x1862fe6) #8 0x7faa4baff306 in tensorflow::FunctionLibraryRuntimeImpl::RunSync(tensorflow::FunctionLibraryRuntime::Options, unsigned long, absl::lts_20230802::Span<tensorflow::Tensor const>, std::vector<tensorflow::Tensor, std::allocator<tensorflow::Tensor> >*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x173f306) #9 0x7faa4bb5cf74 in tensorflow::ProcessFunctionLibraryRuntime::RunMultiDeviceSync(tensorflow::FunctionLibraryRuntime::Options const&, unsigned long, std::vector<std::variant<tensorflow::Tensor, tensorflow::TensorShape>, std::allocator<std::variant<tensorflow::Tensor, tensorflow::TensorShape> > >*, std::function<absl::lts_20230802::Status (tensorflow::ProcessFunctionLibraryRuntime::ComponentFunctionData const&, tensorflow::ProcessFunctionLibraryRuntime::InternalArgs*)>) const (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x179cf74) #10 0x7faa4bb6a8b1 in tensorflow::ProcessFunctionLibraryRuntime::RunSync(tensorflow::FunctionLibraryRuntime::Options const&, unsigned long, absl::lts_20230802::Span<tensorflow::Tensor const>, std::vector<tensorflow::Tensor, std::allocator<tensorflow::Tensor> >*) const (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x17aa8b1) #11 0x7faa13c8c2eb in tensorflow::KernelAndDeviceFunc::Run(tensorflow::ScopedStepContainer*, tensorflow::EagerKernelArgs const&, std::vector<std::variant<tensorflow::Tensor, tensorflow::TensorShape>, std::allocator<std::variant<tensorflow::Tensor, tensorflow::TensorShape> > >*, tsl::CancellationManager*, std::optional<tensorflow::EagerFunctionParams> const&, std::optional<tensorflow::ManagedStackTrace> const&, tsl::CoordinationServiceAgent*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31c582eb) #12 0x7faa13b21c2c in tensorflow::EagerKernelExecute(tensorflow::EagerContext*, absl::lts_20230802::InlinedVector<tensorflow::TensorHandle*, 4ul, std::allocator<tensorflow::TensorHandle*> > const&, std::optional<tensorflow::EagerFunctionParams> const&, tsl::core::RefCountPtr<tensorflow::KernelAndDevice> const&, tensorflow::GraphCollector*, tsl::CancellationManager*, absl::lts_20230802::Span<tensorflow::TensorHandle*>, std::optional<tensorflow::ManagedStackTrace> const&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31aedc2c) #13 0x7faa13b2466a in tensorflow::ExecuteNode::Run() (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31af066a) #14 0x7faa13c5e939 in tensorflow::EagerExecutor::SyncExecute(tensorflow::EagerNode*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31c2a939) #15 0x7faa13b11de4 in tensorflow::(anonymous namespace)::EagerLocalExecute(tensorflow::EagerOperation*, tensorflow::TensorHandle**, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31addde4) #16 0x7faa13b15dd4 in tensorflow::DoEagerExecute(tensorflow::EagerOperation*, tensorflow::TensorHandle**, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31ae1dd4) #17 0x7faa13b1fd26 in tensorflow::EagerExecute(tensorflow::EagerOperation*, tensorflow::TensorHandle**, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31aebd26) #18 0x7faa02b08c33 in tensorflow::EagerOperation::Execute(absl::lts_20230802::Span<tensorflow::AbstractTensorHandle*>, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x20ad4c33) #19 0x7faa13c53e5e in tensorflow::CustomDeviceOpHandler::Execute(tensorflow::ImmediateExecutionOperation*, tensorflow::ImmediateExecutionTensorHandle**, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31c1fe5e) #20 0x7fa9f268645b in TFE_Execute (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x1065245b) #21 0x7faa4a034274 in TFE_Py_FastPathExecute_C(_object*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../_pywrap_tensorflow_internal.so+0x3c2274) #22 0x7fa9ddff2ccb in pybind11::cpp_function::initialize<pybind11_init__pywrap_tfe(pybind11::module_&)::{lambda(pybind11::args)#61}, pybind11::object, pybind11::args, pybind11::name, pybind11::scope, pybind11::sibling>(pybind11_init__pywrap_tfe(pybind11::module_&)::{lambda(pybind11::args)#61}&&, pybind11::object (*)(pybind11::args), pybind11::name const&, pybind11::scope const&, pybind11::sibling const&)::{lambda(pybind11::detail::function_call&)#3}::_FUN(pybind11::detail::function_call&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/_pywrap_tfe.so+0xb7ccb) #23 0x7fa9de109899 in pybind11::cpp_function::dispatcher(_object*, _object*, _object*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/_pywrap_tfe.so+0x1ce899) #24 0x51ad66 (/usr/bin/python3.11+0x51ad66) #25 0x4e75db in _PyObject_MakeTpCall (/usr/bin/python3.11+0x4e75db) #26 0x4fb151 in _PyEval_EvalFrameDefault (/usr/bin/python3.11+0x4fb151) #27 0x531822 in _PyFunction_Vectorcall (/usr/bin/python3.11+0x531822) #28 0x541194 in PyObject_Call (/usr/bin/python3.11+0x541194) #29 0x4fefe0 in _PyEval_EvalFrameDefault (/usr/bin/python3.11+0x4fefe0) #30 0x62e1b3 (/usr/bin/python3.11+0x62e1b3) #31 0x4f3a66 in PyEval_EvalCode (/usr/bin/python3.11+0x4f3a66) #32 0x647c36 (/usr/bin/python3.11+0x647c36) #33 0x64534f (/usr/bin/python3.11+0x64534f) #34 0x650d14 (/usr/bin/python3.11+0x650d14) #35 0x650a63 in _PyRun_SimpleFileObject (/usr/bin/python3.11+0x650a63) #36 0x650832 in _PyRun_AnyFileObject (/usr/bin/python3.11+0x650832) #37 0x64f786 in Py_RunMain (/usr/bin/python3.11+0x64f786) #38 0x61ee0c in Py_BytesMain (/usr/bin/python3.11+0x61ee0c) #39 0x7faaf80d1d8f (/lib/x86_64-linux-gnu/libc.so.6+0x29d8f) #40 0x7faaf80d1e3f in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x29e3f) #41 0x61ec94 in _start (/usr/bin/python3.11+0x61ec94) 0x60700049d1d0 is located 0 bytes to the right of 80-byte region [0x60700049d180,0x60700049d1d0) allocated by thread T0 here: #0 0x7faaf84bf887 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145 #1 0x7faa202d6803 in tensorflow::CSRSparseCholeskyCPUOp<float>::Compute(tensorflow::OpKernelContext*)::{lambda(long, long)#1}::operator()(long, long) const (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x3e2a2803) #2 0x7faa4e5b373a in std::_Function_handler<void (long, long), tsl::thread::ThreadPool::ParallelFor(long, long, std::function<void (long, long)> const&)::{lambda(long, long)#1}>::_M_invoke(std::_Any_data const&, long&&, long&&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x41f373a) #3 0x7faa4e5b84e9 in Eigen::ThreadPoolDevice::parallelFor(long, Eigen::TensorOpCost const&, std::function<long (long)>, std::function<void (long, long)>) const (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x41f84e9) #4 0x7faa4e5c1d41 in tsl::thread::ThreadPool::ParallelFor(long, long, std::function<void (long, long)> const&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x4201d41) #5 0x7faa4ca98d71 in tensorflow::Shard(int, tsl::thread::ThreadPool*, long, long, std::function<void (long, long)>) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x26d8d71) #6 0x7faa202e1ab6 in tensorflow::CSRSparseCholeskyCPUOp<float>::Compute(tensorflow::OpKernelContext*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x3e2adab6) #7 0x7faa4c09c14a in tensorflow::ThreadPoolDevice::Compute(tensorflow::OpKernel*, tensorflow::OpKernelContext*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x1cdc14a) #8 0x7faa4bc22fe6 in tensorflow::(anonymous namespace)::SingleThreadedExecutorImpl::Run(tensorflow::Executor::Args const&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x1862fe6) #9 0x7faa4baff306 in tensorflow::FunctionLibraryRuntimeImpl::RunSync(tensorflow::FunctionLibraryRuntime::Options, unsigned long, absl::lts_20230802::Span<tensorflow::Tensor const>, std::vector<tensorflow::Tensor, std::allocator<tensorflow::Tensor> >*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x173f306) #10 0x7faa4bb5cf74 in tensorflow::ProcessFunctionLibraryRuntime::RunMultiDeviceSync(tensorflow::FunctionLibraryRuntime::Options const&, unsigned long, std::vector<std::variant<tensorflow::Tensor, tensorflow::TensorShape>, std::allocator<std::variant<tensorflow::Tensor, tensorflow::TensorShape> > >*, std::function<absl::lts_20230802::Status (tensorflow::ProcessFunctionLibraryRuntime::ComponentFunctionData const&, tensorflow::ProcessFunctionLibraryRuntime::InternalArgs*)>) const (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x179cf74) #11 0x7faa4bb6a8b1 in tensorflow::ProcessFunctionLibraryRuntime::RunSync(tensorflow::FunctionLibraryRuntime::Options const&, unsigned long, absl::lts_20230802::Span<tensorflow::Tensor const>, std::vector<tensorflow::Tensor, std::allocator<tensorflow::Tensor> >*) const (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_framework.so.2+0x17aa8b1) #12 0x7faa13c8c2eb in tensorflow::KernelAndDeviceFunc::Run(tensorflow::ScopedStepContainer*, tensorflow::EagerKernelArgs const&, std::vector<std::variant<tensorflow::Tensor, tensorflow::TensorShape>, std::allocator<std::variant<tensorflow::Tensor, tensorflow::TensorShape> > >*, tsl::CancellationManager*, std::optional<tensorflow::EagerFunctionParams> const&, std::optional<tensorflow::ManagedStackTrace> const&, tsl::CoordinationServiceAgent*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31c582eb) #13 0x7faa13b21c2c in tensorflow::EagerKernelExecute(tensorflow::EagerContext*, absl::lts_20230802::InlinedVector<tensorflow::TensorHandle*, 4ul, std::allocator<tensorflow::TensorHandle*> > const&, std::optional<tensorflow::EagerFunctionParams> const&, tsl::core::RefCountPtr<tensorflow::KernelAndDevice> const&, tensorflow::GraphCollector*, tsl::CancellationManager*, absl::lts_20230802::Span<tensorflow::TensorHandle*>, std::optional<tensorflow::ManagedStackTrace> const&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31aedc2c) #14 0x7faa13b2466a in tensorflow::ExecuteNode::Run() (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31af066a) #15 0x7faa13c5e939 in tensorflow::EagerExecutor::SyncExecute(tensorflow::EagerNode*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31c2a939) #16 0x7faa13b11de4 in tensorflow::(anonymous namespace)::EagerLocalExecute(tensorflow::EagerOperation*, tensorflow::TensorHandle**, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31addde4) #17 0x7faa13b15dd4 in tensorflow::DoEagerExecute(tensorflow::EagerOperation*, tensorflow::TensorHandle**, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31ae1dd4) #18 0x7faa13b1fd26 in tensorflow::EagerExecute(tensorflow::EagerOperation*, tensorflow::TensorHandle**, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31aebd26) #19 0x7faa02b08c33 in tensorflow::EagerOperation::Execute(absl::lts_20230802::Span<tensorflow::AbstractTensorHandle*>, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x20ad4c33) #20 0x7faa13c53e5e in tensorflow::CustomDeviceOpHandler::Execute(tensorflow::ImmediateExecutionOperation*, tensorflow::ImmediateExecutionTensorHandle**, int*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x31c1fe5e) #21 0x7fa9f268645b in TFE_Execute (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x1065245b) #22 0x7faa4a034274 in TFE_Py_FastPathExecute_C(_object*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../_pywrap_tensorflow_internal.so+0x3c2274) #23 0x7fa9ddff2ccb in pybind11::cpp_function::initialize<pybind11_init__pywrap_tfe(pybind11::module_&)::{lambda(pybind11::args)#61}, pybind11::object, pybind11::args, pybind11::name, pybind11::scope, pybind11::sibling>(pybind11_init__pywrap_tfe(pybind11::module_&)::{lambda(pybind11::args)#61}&&, pybind11::object (*)(pybind11::args), pybind11::name const&, pybind11::scope const&, pybind11::sibling const&)::{lambda(pybind11::detail::function_call&)#3}::_FUN(pybind11::detail::function_call&) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/_pywrap_tfe.so+0xb7ccb) #24 0x7fa9de109899 in pybind11::cpp_function::dispatcher(_object*, _object*, _object*) (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/_pywrap_tfe.so+0x1ce899) #25 0x51ad66 (/usr/bin/python3.11+0x51ad66) SUMMARY: AddressSanitizer: heap-buffer-overflow (/mnt/venv/tensorflow-2.16.1-asan/lib/python3.11/site-packages/tensorflow/python/platform/../../libtensorflow_cc.so.2+0x3e2a2d86) in tensorflow::CSRSparseCholeskyCPUOp<float>::Compute(tensorflow::OpKernelContext*)::{lambda(long, long)#1}::operator()(long, long) const Shadow bytes around the buggy address: 0x0c0e8008b9e0: 00 00 00 00 00 00 fa fa fa fa fd fd fd fd fd fd 0x0c0e8008b9f0: fd fd fd fd fa fa fa fa 00 00 00 00 00 00 00 00 0x0c0e8008ba00: 00 fa fa fa fa fa 00 00 00 00 00 00 00 00 04 fa 0x0c0e8008ba10: fa fa fa fa 00 00 00 00 00 00 00 00 04 fa fa fa 0x0c0e8008ba20: fa fa 00 00 00 00 00 00 00 00 04 fa fa fa fa fa =>0x0c0e8008ba30: 00 00 00 00 00 00 00 00 00 00[fa]fa fa fa fa fa 0x0c0e8008ba40: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e8008ba50: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e8008ba60: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e8008ba70: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c0e8008ba80: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Shadow gap: cc ==3331846==ABORTING ```
stat:awaiting tensorflower,type:bug,comp:ops,2.17
medium
Critical
2,694,600,860
deno
`deno doc`: add Native Markdown Export Functionality
Currently, the deno doc command provides documentation generation capabilities, but lacks a direct option to export documentation in Markdown (.md) format. This feature request proposes adding a `--markdown` or `--md` flag to enable seamless documentation export. Add a new CLI flag to deno doc that allows exporting documentation as a Markdown file: ``` # Proposed usage deno doc --markdown web/ui/button.tsx deno doc --md web/ui/button.tsx ```
cli,suggestion
low
Minor
2,694,616,279
tauri
[feat] Enhance Tauri Tray Menus: Support Icons for Submenus and Checkable Items
### Describe the problem The tray menu system has limitations in supporting icons for menu items. Currently: - Menu items cannot have icons if they include submenus. - Submenu items themselves cannot have icons. - Checked menu items cannot display icons. These limitations restrict the ability to create visually rich and user-friendly tray menus. On macOS, applications like Klack demonstrate that all these features are possible, enhancing the overall user experience. <img width="391" alt="image" src="https://github.com/user-attachments/assets/3bbb66a6-7f52-4ed2-b2a3-44a400cab615"> ### Describe the solution you'd like Iโ€™d like Tauri v2 to enhance its tray menu functionality by: - Supporting icons for menu items that include submenus. - Allowing submenu items to have icons. - Enabling icons for checkable menu items. This functionality would allow developers to build visually consistent and feature-complete tray menus, leveraging the design capabilities of macOS. ### Alternatives considered 1. Custom tray menu implementations using native bindings or platform-specific workarounds, which significantly increase development complexity. 2. Accepting the current limitations and avoiding icons in menus, which compromises design and usability. Both alternatives are less than ideal compared to having first-class support directly in Tauri. ### Additional context _No response_
type: feature request
low
Minor
2,694,634,223
go
x/tools/go/packages: TestAdHocContains/Modules failures
``` #!watchflakes default <- pkg == "golang.org/x/tools/go/packages" && test == "TestAdHocContains/Modules" ``` Issue created automatically to collect these failures. Example ([log](https://ci.chromium.org/b/8730221114690153217)): === RUN TestAdHocContains/Modules === PAUSE TestAdHocContains/Modules === CONT TestAdHocContains/Modules invoke.go:205: starting GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go list -e -f {{context.ReleaseTags}} -- unsafe invoke.go:205: 149.271579ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=off GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go list -e -f {{context.ReleaseTags}} -- unsafe invoke.go:205: starting GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=false -test=true -export=false -deps=true -find=false -pgo=off -- /home/swarming/.swarming/w/ir/x/t invoke.go:205: 167.387431ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=false -test=true -export=false -deps=true -find=false -pgo=off -- /home/swarming/.swarming/w/ir/x/t invoke.go:205: starting GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go env -json GOMOD GOPATH invoke.go:205: 2.329448988s for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go env -json GOMOD GOPATH invoke.go:205: starting GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go list -m -json all invoke.go:205: 198.164334ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go list -m -json all invoke.go:205: starting GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=false -test=true -export=false -deps=true -find=false -pgo=off -- /home/swarming/.swarming/w/ir/x/t/adhoc1270394003.go invoke.go:205: 139.934514ms for GOROOT= GOPATH=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modcache GO111MODULE=on GOPROXY=file:///home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/modproxy PWD=/home/swarming/.swarming/w/ir/x/t/TestAdHocContains_Modules2682472817/fake go list -e -json=Name,ImportPath,Error,Dir,GoFiles,IgnoredGoFiles,IgnoredOtherFiles,CFiles,CgoFiles,CXXFiles,MFiles,HFiles,FFiles,SFiles,SwigFiles,SwigCXXFiles,SysoFiles,TestGoFiles,XTestGoFiles,DepOnly,Imports,ImportMap,TestImports,XTestImports -compiled=false -test=true -export=false -deps=true -find=false -pgo=off -- /home/swarming/.swarming/w/ir/x/t/adhoc1270394003.go --- FAIL: TestAdHocContains/Modules (4.16s) โ€” [watchflakes](https://go.dev/wiki/Watchflakes)
NeedsInvestigation,Tools
low
Critical
2,694,640,651
kubernetes
internal convert cause patchMergeKey lost
### What happened? I have a deployment, which have imagePullSecrets issue. At revision 1: ```yaml imagePullSecrets: - name: test ``` At revision 2: We update it to ```yaml imagePullSecrets: - name: test - name: "" ``` And k8s accept it, and it become ```yaml imagePullSecrets: - name: test - {} ``` However, any update after it failed with `error: map: map[] does not contain declared merge key: name` We want to delete it by `kubectl edit` to remove its `{}` line, but also failed with same error. This seems to happen in k8s convert strategy rather than patchStrategy. Help wanted. ### What did you expect to happen? Deployment should become ```yaml imagePullSecrets: - name: test - name: "" ``` Also, any update after it should succees. ### How can we reproduce it (as minimally and precisely as possible)? Edit any deployment so you can produce. ### Anything else we need to know? _No response_ ### Kubernetes version Client Version: v1.28.2 Kustomize Version: v5.0.4-0.20230601165947-6ce0bf390ce3 Server Version: v1.19.9-20 WARNING: version difference between client (1.28) and server (1.19) exceeds the supported minor version skew of +/-1 Its a forked version, but should produce in community version. ### Cloud provider None, we build it in virtual machines. ### OS version <details> ```console # On Linux: $ cat /etc/os-release # paste output here $ uname -a # paste output here # On Windows: C:\> wmic os get Caption, Version, BuildNumber, OSArchitecture # paste output here ``` </details> ### Install tools <details> </details> ### Container runtime (CRI) and version (if applicable) <details> </details> ### Related plugins (CNI, CSI, ...) and versions (if applicable) <details> </details>
kind/bug,needs-sig,needs-triage
low
Critical
2,694,670,014
react-native
[android] Image component can't load image in latest version
### Description I init a react native project without framework by npx @react-native-community/cli@latest init AwesomeProject. The version is 0.76.3. But image with remote uri load very slow first time in android, and it is ok in ios. ``` <Image style={{width:100,height:100}} source={{ uri: 'https://reactnative.dev/img/tiny_logo.png', }} onLoad={() => console.warn('onLoad')} onLoadStart={() => console.warn('onLoadStart')} onLoadEnd={() => console.warn('onLoadEnd')} onProgress={() => console.warn('onProgress')} onError={() => console.warn('onError')} /> ``` The console just print "onLoadStart", then nothing printed. I wait for about 5 mins, the image loaded, and then reload app, the image shows immediately. But when I changed the image uri and reload app, I need to wait for 5 mins again to load the image. My app is pure and no dependences. Could you help me check it? Thank you ### Steps to reproduce 1. install pure react-native without framework by npx @react-native-community/cli@latest init AwesomeProject. The version is 0.76.3. 2. Add codes in App.tsx ``` <Image style={{width:100,height:100}} source={{ uri: 'https://reactnative.dev/img/tiny_logo.png', }} onLoad={() => console.warn('onLoad')} onLoadStart={() => console.warn('onLoadStart')} onLoadEnd={() => console.warn('onLoadEnd')} onProgress={() => console.warn('onProgress')} onError={() => console.warn('onError')} /> ``` 3. yarn android and check the image load or console print. ### React Native Version 0.76.3 ### Affected Platforms Runtime - Android, Build - MacOS ### Output of `npx react-native info` ```text System: OS: macOS 14.2 CPU: (8) x64 Intel(R) Core(TM) i7-10510U CPU @ 1.80GHz Memory: 10.44 GB / 16.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 20.10.0 path: /usr/local/bin/node Yarn: version: 1.22.19 path: /usr/local/bin/yarn npm: version: 10.3.0 path: ~/.npm-global/bin/npm Watchman: Not Found Managers: CocoaPods: version: 1.14.3 path: /usr/local/opt/ruby/bin/pod SDKs: iOS SDK: Platforms: - DriverKit 23.4 - iOS 17.4 - macOS 14.4 - tvOS 17.4 - visionOS 1.1 - watchOS 10.4 Android SDK: Not Found IDEs: Android Studio: 2024.2 AI-242.23339.11.2421.12550806 Xcode: version: 15.3/15E204a path: /usr/bin/xcodebuild Languages: Java: version: 17.0.9 path: /usr/bin/javac Ruby: version: 3.2.2 path: /usr/local/opt/ruby/bin/ruby npmPackages: "@react-native-community/cli": installed: 15.0.1 wanted: ^15.0.1 react: installed: 18.3.1 wanted: 18.3.1 react-native: installed: 0.76.3 wanted: 0.76.3 react-native-macos: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: true newArchEnabled: false iOS: hermesEnabled: true newArchEnabled: true ``` ### Stacktrace or Logs ```text no logs in android studio ``` ### Reproducer https://github.com/llr101/react-native-android-image-error ### Screenshots and Videos _No response_
Platform: Android,Component: Image,Needs: Attention
low
Critical
2,694,695,685
ant-design
Menu does not auto-scroll when an item at the bottom is expanded
### Reproduction link [![Edit on CodeSandbox](https://codesandbox.io/static/img/play-codesandbox.svg)](https://codesandbox.io/p/sandbox/inline-menu-antd-5-22-2-forked-yfydvh?file=%2Findex.html) ### Steps to reproduce Create a Menu component with several items, ensuring that some items are positioned at the bottom of the screen. Click on a main menu item that is located at the bottom of the screen to expand its submenu. Observe that the submenu expands, but the screen does not scroll down to display the expanded submenu. ### What is expected? When a main menu item at the bottom of the screen is clicked and its submenu expands, the screen should automatically scroll down to display the expanded submenu. ### What is actually happening? The submenu expands, but the screen does not scroll down, making it appear as though the submenu has not opened. | Environment | Info | | --- | --- | | antd | 5.22.2 | | React | 18.2.0 | | System | Windows 11 | | Browser | Google Chrome 130.0.6723.70 | --- I am experiencing an issue with the Ant Design (antd) Menu component. When I click on a main menu item that is located at the bottom of the screen, the submenu expands, but the screen does not automatically scroll down to show the expanded submenu. As a result, it appears as though the submenu has not opened, which can be confusing for users.This issue affects the user experience as it can be confusing for users who may not realize that the submenu has expanded. An automatic scroll to the expanded submenu would improve usability. <!-- generated by ant-design-issue-helper. DO NOT REMOVE -->
Inactive,improvement
low
Minor
2,694,716,072
tensorflow
When using `tf.math.log1p` and NumPy's `np.log1p` with the same complex input, the outputs are inconsistent.
### Issue type Bug ### Have you reproduced the bug with TensorFlow Nightly? No ### Source source ### TensorFlow version 2.17.1 ### Custom code Yes ### OS platform and distribution Ubuntu 22.04.3 ### Mobile device _No response_ ### Python version 3.11 ### Bazel version _No response_ ### GCC/compiler version _No response_ ### CUDA/cuDNN version _No response_ ### GPU model and memory _No response_ ### Current behavior? TensorFlow's `tf.math.log1p` produces inconsistent results with NumPy's `np.log1p` for complex inputs containing `inf`, such as `[inf+0.j, 0+inf.j, inf+inf.j]`. TensorFlow outputs `[inf+0.j, nan+nanj, nan+nanj]`, while NumPy returns `[inf+0.j, inf+1.57079633j, inf+0.78539816j]`. ### Standalone code to reproduce the issue ```shell python import tensorflow as tf import numpy as np test_input = tf.constant([complex(float('inf'), 0), complex(0, float('inf')), complex(float('inf'), float('inf'))], dtype=tf.complex128) # TensorFlow computation with tf.device('/CPU:0'): cpu_out = tf.math.log1p(test_input) # NumPy computation numpy_out = np.log1p(test_input.numpy()) print(f"CPU Output: {cpu_out}") print(f"NumPy Output: {numpy_out}") ``` ### Relevant log output ```shell CPU Output: [inf +0.j nan+nanj nan+nanj] NumPy Output: [inf+0.j inf+1.57079633j inf+0.78539816j] ```
stat:awaiting tensorflower,type:bug,comp:ops,2.17
low
Critical
2,694,749,733
rust
track whether a non-coherence `TypingMode` has been used to reuse cache entries
see the WIP branch https://github.com/lcnr/rust/tree/typing-mode-is-coherence. It is now fairly straightforward to track whether evaluation relied on the exact typing mode. finishing this work should result in a reasonable perf improvement
C-feature-request,T-types
low
Minor
2,694,774,185
react-native
ScrollView's scrollToEnd scrolls too far on android
### Description ScrollView's `scrollToEnd` method gives different results on iOs and Android. Expected behaviour: ScrollView's `scrollToEnd` method should function consistently across platforms. Ideally The view should scroll until the bottom of the content reaches the bottom of the view. Actual behaviour: On iOs the view tries to scroll until the bottom of the content reaches the bottom of the view. On Android the view tries to scroll until the bottom of the content reaches the top of the view. This is especially annoying if you add content while the view is scrolling, as it then scrolls too far, or if you have an animation of content being added to slide in from the bottom. ### Steps to reproduce 1. Open the provided snack on Android 2. Press the button labeled "Press me!" 3. The view scrolls until element "Test 50" reaches the top of the screen 4. Open the provided snack on iOs 5. Press the button labeled "Press me!" 6. The view scrolls until element "Test 49" reaches the bottom of the screen ### React Native Version 0.76.3 ### Affected Platforms Runtime - Android ### Output of `npx react-native info` ```text System: OS: macOS 14.7 CPU: (10) arm64 Apple M1 Pro Memory: 124.23 MB / 16.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 20.11.1 path: ~/.nvm/versions/node/v20.11.1/bin/node Yarn: version: 1.22.19 path: /opt/homebrew/bin/yarn npm: version: 10.2.4 path: ~/.nvm/versions/node/v20.11.1/bin/npm Watchman: version: 2024.09.16.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.15.2 path: /opt/homebrew/bin/pod SDKs: iOS SDK: Platforms: - DriverKit 24.1 - iOS 18.1 - macOS 15.1 - tvOS 18.1 - visionOS 2.1 - watchOS 11.1 Android SDK: Not Found IDEs: Android Studio: 2024.2 AI-242.23339.11.2421.12550806 Xcode: version: 16.1/16B40 path: /usr/bin/xcodebuild Languages: Java: version: 18.0.2.1 path: /Users/chriscoerdes/.jenv/shims/javac Ruby: version: 2.6.10 path: /usr/bin/ruby npmPackages: "@react-native-community/cli": installed: 15.0.1 wanted: 15.0.1 react: installed: 18.3.1 wanted: 18.3.1 react-native: installed: 0.76.3 wanted: 0.76.3 react-native-macos: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: true newArchEnabled: true iOS: hermesEnabled: true newArchEnabled: true ``` ### Stacktrace or Logs ```text N/A ``` ### Reproducer https://github.com/coerdes-chris/react-native-scrollview ### Screenshots and Videos https://github.com/user-attachments/assets/ad2a0bcd-4c59-4291-8891-9f2dfbd1d13f
Issue: Author Provided Repro,Resolution: PR Submitted,Platform: Android,Component: ScrollView
low
Major
2,694,776,004
kubernetes
DRA: mark devices as unhealthy in ResourceSlice
### What would you like to be added? The current method of preventing allocation of an unhealthy device is to remove the device from the ResourceSlice. There's an inherent race here between that and the scheduler seeing the update, but that's unavoidable. Some way of marking the device as unhealthy and/or unavailable would be nicer. ### Why is this needed? Use cases: - Users can see all devices which exist in the cluster, including those which are unhealthy. Ideally there's also some information about *why* they are unhealthy. - A system admin may want to take a device offline for maintenance. The driver doesn't (and shouldn't) need to be aware of that. - A monitoring solution separate from the driver detects that the device is unhealthy or not performing as expected.
sig/node,kind/feature,needs-triage,wg/device-management
medium
Critical
2,694,786,973
bitcoin
RFC: support for writing UTXO set dump (`dumptxoutset` RPC) to a named pipe
### Please describe the feature you'd like to see added. While the primary obvious use-case for the `dumptxoutset` RPC is to create AssumeUTXO snapshots (to be distributed and loaded on newly created nodes via the `loadtxoutset` RPC later), it can also be useful as input for external tooling like converters to other UTXO set formats, e.g. https://github.com/bitcoin/bitcoin/pull/27432. For those, the intermediate step of writing a >10GB file to disk and then reading it again is wasteful and annoying, as it consumes both more time and space than necessary. By supporting writing to a [named pipe](https://en.wikipedia.org/wiki/Named_pipe#In_Unix), the output data could be fed directly into another process instead. Thanks to the UNIX "everything is a file" philosophy, no logic changes in the tooling are even needed -- the reader only sees an input stream and doesn't notice or care if the input file represents an actual physical file on disk or if the data is generated on-the-fly from another process. Currently needed steps for external tools: 1. call `dumptxoutset` to create utxo.dump (>10GB on mainnet) 2. call external tool with utxo.dump as input (run only after step 1 is finished) 3. delete utxo.dump Needed steps for external tools with named pipe support: 1. create a named pipe utxo.pipe (e.g. via https://linux.die.net/man/3/mkfifo) 2. call `dumptxoutset` to write to utxo.pipe 3. call external tool with utxo.pipe as input (run in *parallel* to step 2) 4. delete utxo.pipe I've tried this yesterday and it works as expected with minimal changes (see proposed solution below). Will push the branch later with concrete instructions, if people feel that this is worthwhile to support. ### Is your feature related to a problem, if so please describe it. _No response_ ### Describe the solution you'd like The `dumptxoutset` call only needs two minor behaviour modificiations. If the passed `path` is a named pipe (trivially detectable via C++ standard library routine [std::filesystem::is_fifo](https://en.cppreference.com/w/cpp/filesystem/is_fifo)), then: * don't error if the file already exists * don't create a temporary file with `.incomplete` suffix, but write directly into the specified path ### Describe any alternatives you've considered _No response_ ### Please leave any additional context _No response_
Feature
low
Critical
2,694,795,708
next.js
[Windows] Server-side debugger doesn't stop in breakpoints after v15.0.3-canary.7
### Link to the code that reproduces this issue https://github.com/emilioestebanez/next-15-issues ### To Reproduce 1. Open in VSCode 2. Go to `Run and Debug` and execute the `Next.js: debug server-side` 3. Set a breakpoint in `src/app/page.tsx` 4. Visit http://localhost:3000 You'll see that the debugger doesn't stop in the breakpoint in Windows. Now, if you go to `package.json` and remove `--turbopack` from the `dev` script and try the steps above again, you'll see that the debugger is able to stop in the breakpoint correctly. This happens after [email protected] ### Current vs. Expected behavior I expect the breakpoint to stop with and without `--turbopack` enabled. ### Provide environment information ```bash Operating System: Platform: win32 Arch: x64 Version: Windows 11 Pro Available memory (MB): 65208 Available CPU cores: 20 Binaries: Node: 20.18.0 npm: 10.8.2 Yarn: 1.22.22 pnpm: 9.12.3 Relevant Packages: next: 15.0.3 // Latest available version is detected (15.0.3). eslint-config-next: 15.0.3 react: 19.0.0-rc-66855b96-20241106 react-dom: 19.0.0-rc-66855b96-20241106 typescript: 5.7.2 Next.js Config: output: N/A ``` ### Which area(s) are affected? (Select all that apply) Turbopack ### Which stage(s) are affected? (Select all that apply) next dev (local) ### Additional context I think this is the cause of the issue: https://github.com/vercel/next.js/pull/71984
bug,Turbopack
low
Critical
2,694,802,315
react-native
Transaction merging can cause `CREATE` mutations to be effectively dropped
### Description Related to https://github.com/facebook/react-native/issues/38743 Transaction merging introduced in https://github.com/facebook/react-native/pull/44188 may cause `CREATE` mutations to be effectively dropped. When two transactions, where the first one contains a `DELETE` mutation for a view with a view tag `X` and the other contains a `CREATE` mutation for a view with a view tag `X`, get merged the result is a transaction containing both mutations. When that transaction is executed, the `DELETE` operations are run after `CREATE` operations, so the view will not exist after the transaction finishes which results in the host tree diverging from the shadow tree. Inside `FabricUIManagerBinding` `pendingTransactions_` field tracks transactions to be executed but only one per surface: https://github.com/facebook/react-native/blob/a6b2355b8d559aba2f1f13394c91f563f9b9e1a4/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricUIManagerBinding.h#L164-L166 Inside `schedulerDidFinishTransaction` transactions are merged when a transaction for a given surface is already pending: https://github.com/facebook/react-native/blob/a6b2355b8d559aba2f1f13394c91f563f9b9e1a4/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricUIManagerBinding.cpp#L546-L550 If instead of merging transactions into one, multiple ones could be queued for a single surface and executed in order, the issue would be fixed. I can open a PR with that change but before that, I'd like to know whether that could have any unwanted side effects, as I'm lacking context on why merging was chosen there. It also seems like this may be a known problem: https://github.com/facebook/react-native/blob/69356b7f2144283fa6be7e9998e25a0681e159f0/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp#L828-L829 ### Steps to reproduce 1. Open the application (the code may be pasted to RNTester) 2. Click the `Click this first` button 3. Click the `Click this second` button ### React Native Version 0.76.2 ### Affected Platforms Runtime - Android ### Areas Fabric - The New Renderer ### Output of `npx react-native info` <details> ```text System: OS: macOS 14.7.1 CPU: (12) arm64 Apple M3 Pro Memory: 96.86 MB / 18.00 GB Shell: version: "5.9" path: /bin/zsh Binaries: Node: version: 20.18.0 path: ~/.nvm/versions/node/v20.18.0/bin/node Yarn: version: 1.22.19 path: /opt/homebrew/bin/yarn npm: version: 10.8.2 path: ~/.nvm/versions/node/v20.18.0/bin/npm Watchman: version: 2024.09.09.00 path: /opt/homebrew/bin/watchman Managers: CocoaPods: version: 1.15.2 path: /Users/jakubpiasecki/.rvm/gems/ruby-2.7.5/bin/pod SDKs: iOS SDK: Platforms: - DriverKit 23.5 - iOS 17.5 - macOS 14.5 - tvOS 17.5 - visionOS 1.2 - watchOS 10.5 Android SDK: API Levels: - "24" - "26" - "28" - "29" - "30" - "31" - "32" - "33" - "34" - "35" Build Tools: - 26.0.3 - 28.0.3 - 29.0.2 - 29.0.3 - 30.0.2 - 30.0.3 - 31.0.0 - 32.0.0 - 32.1.0 - 33.0.0 - 33.0.1 - 34.0.0 - 35.0.0 - 35.0.0 System Images: - android-28 | Google ARM64-V8a Play ARM 64 v8a - android-33 | Google APIs ARM 64 v8a - android-34 | Google Play ARM 64 v8a - android-35 | Google Play ARM 64 v8a Android NDK: Not Found IDEs: Android Studio: 2024.2 AI-242.23339.11.2421.12550806 Xcode: version: 15.4/15F31d path: /usr/bin/xcodebuild Languages: Java: version: 17.0.2 path: /usr/bin/javac Ruby: version: 2.7.5 path: /Users/jakubpiasecki/.rvm/rubies/ruby-2.7.5/bin/ruby npmPackages: "@react-native-community/cli": Not Found react: Not Found react-native: Not Found react-native-macos: Not Found npmGlobalPackages: "*react-native*": Not Found Android: hermesEnabled: false newArchEnabled: false iOS: hermesEnabled: true newArchEnabled: true ``` </details> ### Stacktrace or Logs ```text Exception in native call com.facebook.react.bridge.RetryableMountingLayerException: Unable to find viewState for tag 4. Surface stopped: false at com.facebook.react.fabric.mounting.SurfaceMountingManager.getViewState(SurfaceMountingManager.java:1103) at com.facebook.react.fabric.mounting.SurfaceMountingManager.updateProps(SurfaceMountingManager.java:687) at com.facebook.react.fabric.mounting.mountitems.IntBufferBatchMountItem.execute(IntBufferBatchMountItem.java:157) at com.facebook.react.fabric.mounting.MountItemDispatcher.executeOrEnqueue(MountItemDispatcher.java:370) at com.facebook.react.fabric.mounting.MountItemDispatcher.dispatchMountItems(MountItemDispatcher.java:265) at com.facebook.react.fabric.mounting.MountItemDispatcher.tryDispatchMountItems(MountItemDispatcher.java:122) at com.facebook.react.fabric.FabricUIManager$DispatchUIFrameCallback.doFrameGuarded(FabricUIManager.java:1392) at com.facebook.react.fabric.GuardedFrameCallback.doFrame(GuardedFrameCallback.kt:22) at com.facebook.react.modules.core.ReactChoreographer.frameCallback$lambda$1(ReactChoreographer.kt:59) at com.facebook.react.modules.core.ReactChoreographer.$r8$lambda$nSkFhrr5T7rop_XKwzlLov4NLLw(Unknown Source:0) at com.facebook.react.modules.core.ReactChoreographer$$ExternalSyntheticLambda0.doFrame(D8$$SyntheticClass:0) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1404) at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1415) at android.view.Choreographer.doCallbacks(Choreographer.java:1015) at android.view.Choreographer.doFrame(Choreographer.java:941) at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1389) at android.os.Handler.handleCallback(Handler.java:959) at android.os.Handler.dispatchMessage(Handler.java:100) at android.os.Looper.loopOnce(Looper.java:232) at android.os.Looper.loop(Looper.java:317) at android.app.ActivityThread.main(ActivityThread.java:8699) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886) ``` ### Reproducer https://snack.expo.dev/@jpiasecki/unable_to_find_viewstate_repro ### Screenshots and Videos https://github.com/user-attachments/assets/7df6bc47-a741-48cc-85e3-398239415b11
Partner,p: Software Mansion,Needs: Triage :mag:,Newer Patch Available,Type: New Architecture
low
Major
2,694,837,677
kubernetes
DRA: competition between schedulers + allocators
### What would you like to be added? At the moment, DRA uses the approach that one scheduler instance "owns" all resources on a node or available for a node (in the case of network-attached devices). This is the same approach that is used for other resources. It enables faster scheduling because allocation can happen without coordination with other entities. This approach breaks down when there are multiple schedulers in the cluster such that each scheduler instance is responsible for its own subset of the nodes ("sharding") and there are network-attached devices that are available for more than one set of nodes. Also, sometimes users run additional schedulers for the same nodes as the system scheduler. While that is already problematic regarding CPU and memory, with devices it might be even worse. /sig scheduling /wg device-management ### Why is this needed? For more advanced cluster setups.
sig/scheduling,kind/feature,needs-triage,wg/device-management
low
Minor
2,694,904,579
TypeScript
Bloomberg feedback for 5.7
### Acknowledgement - [x] I acknowledge that issues using this template may be closed without further explanation at the maintainer's discretion. ### Comment We evaluated the 5.7 release and it seems to be a low impact release for us. We only found one issue, which we reported: | # | Change | Affects | Release notes | Packages affected| Reported As | |---|-------------------------------------------------------------------------|------------------|---------------|------------------|--------------| | 1| Index signature added to classes that inherit an any typed class | Declaration Emit | Not Announced | <1% | [#60383](https://github.com/microsoft/TypeScript/issues/60383) | | 2| Minor changes to declaration text | Declaration Emit | Not Announced | <1% | | ### Minor changes to declaration text These seem to be related to isolated declaration emit alignment with external tools. The changes were in a limited number of places and did not impact the correctness of the declarations (some string delimiters changed, some types got preserved as `typeof x` instead being inlined, some recursive types got expanded one level deeper). Examples: ```diff - get sourceFn(): SourceFnArgs<TParams>['sourceFn']; + get sourceFn(): SourceFnArgs<TParams>["sourceFn"]; + readonly Source: any; - readonly Source: typeof LazySource.default; ```
Discussion
low
Minor
2,694,986,983
kubernetes
DRA drivers: helper code for checking device allocations
### What would you like to be added? A DRA driver has to check in NodePrepareResources whether the devices are a) already prepared for other claims and b) really currently available. If so, it has to refuse to prepare them again. This is a sanity check that acts as last line of defense against unintended concurrent usage of a device (case a) or race conditions. DRA tries hard to avoid such situations, but at least the ["device became unhealthy"](https://github.com/kubernetes/kubernetes/issues/128979) is inherently racy. Allocating the same device for different claims could be the result of a bug or allocation by different schedulers without [coordination](https://github.com/kubernetes/kubernetes/issues/128980#issuecomment-2500948711). DRA driver authors might forget to implement this check. Perhaps we can move it into [k8s.io/dynamic-resource-allocation/kubeletplugin](https://github.com/kubernetes/kubernetes/tree/master/staging/src/k8s.io/dynamic-resource-allocation/kubeletplugin) with such an API change that the driver authors are forced to do something? ### Why is this needed? Higher quality of DRA drivers.
sig/node,kind/feature,needs-triage,wg/device-management
low
Critical
2,695,029,191
PowerToys
Extend Quick Accent to space and dash
### Description of the new feature / enhancement Use Quick Accent (PowerToys) to get the possibility to insert any kind of space or dash available (variable, fix, unbreakable, quadratin, half quadratin, quarter quadratin for the spaces, and all dashes used in typography). ### Scenario when this would be used? Each time you compose a text with the need to insert a specific dash or space. ### Supporting information the way Quick Accent is working for special accentuation seems to perfectly fit to this use. It just add a precious typographic ressource. Thank for this excellent set of utility!
Needs-Triage
low
Minor
2,695,057,759
flutter
ListView wrapped with a FocusTraversalGroup and placed between two text buttons, the focus does not follow correct order using up and down arrow keys.
### Steps to reproduce When a ListView is wrapped with a FocusTraversalGroup and placed between two text buttons, the focus behaves erratically when using the arrow up and down keys. See the attached video made with the attached code. This makes it very hard to get the focus behavior that we want in more complicated scenarios. Please run attached main.dart on Android or iOS device. 1. Use the Arrow Down key to get to the last element on the page. 2. Use the Arrow Up key. 3. Use the Arrow Down key to get to the second element in the list. 4. Use the Arrow Up key two times. 5. Use the Arrow Up key to get to the topmost button. 6. Use the Arrow Down key once to get to the first item in the list. 7. Use the Arrow Down key once. ### Expected results 1. Focus is on the last element on the page. 2. Focus is moved to the last element in the list. 3. . 4. Focus is moved to topmost element on the page. 5. . 6. . 7. Focus is moved to the second element in the list. ### Actual results 1. Focus is on the last element on the page. 2. Focus is moved to the topmost element on the page. 3. . 4. Focus is moved to the last element in the list. 5. . 6. . 7. Focus remains on the first element in the list. ### Code sample <details open><summary>Code sample</summary> ```dart import 'package:flutter/material.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); // This widget is the root of your application. @override Widget build(BuildContext context) { return MaterialApp(title: 'Focus Bug', home: Scaffold(body: MyHomePage())); } } class MyHomePage extends StatelessWidget { const MyHomePage({super.key}); @override Widget build(BuildContext context) { return ListView( physics: const AlwaysScrollableScrollPhysics(), children: [ TextButton(onPressed: () {}, child: const Text('Button')), FocusTraversalGroup( child: ListView.separated( shrinkWrap: true, physics: const NeverScrollableScrollPhysics(), itemBuilder: (context, index) { return TextButton( onPressed: () {}, child: const Text('ListTextButton'), ); }, separatorBuilder: (context, index) => const SizedBox(height: 8), itemCount: 5, ), ), TextButton(onPressed: () {}, child: const Text('Button')), ], ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> https://github.com/user-attachments/assets/d0bf13fe-aeaa-41ca-aec8-ce5ebbcb14b1 </details> ### Logs <details open><summary>Logs</summary> ```console [Paste your logs here] ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console $ flutter doctor -v [โˆš] Flutter (Channel master, 3.27.0-1.0.pre.645, on Microsoft Windows [Version 10.0.19045.5131], locale en-SE) โ€ข Flutter version 3.27.0-1.0.pre.645 on channel master at C:\Users\henrik.andersson\fvm\versions\3.19.6 โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision 1e824af6bd (12 hours ago), 2024-11-25 21:55:41 -0500 โ€ข Engine revision fb64399182 โ€ข Dart version 3.7.0 (build 3.7.0-184.0.dev) โ€ข DevTools version 2.41.0-dev.2 [โˆš] Windows Version (10 Enterprise 64-bit, 22H2, 2009) [โˆš] Android toolchain - develop for Android devices (Android SDK version 34.0.0) โ€ข Android SDK at C:\Users\henrik.andersson\AppData\Local\Android\sdk โ€ข Platform android-35, build-tools 34.0.0 โ€ข Java binary at: C:\Program Files\Android\Android Studio3\jbr\bin\java This is the JDK bundled with the latest Android Studio installation on this machine. To manually set the JDK path, use: `flutter config --jdk-dir="path/to/jdk"`. โ€ข Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11) โ€ข All Android licenses accepted. [โˆš] Chrome - develop for the web โ€ข Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe [X] Visual Studio - develop Windows apps X Visual Studio not installed; this is necessary to develop Windows apps. Download at https://visualstudio.microsoft.com/downloads/. Please install the "Desktop development with C++" workload, including all of its default components [โˆš] Android Studio (version 2023.2) โ€ข Android Studio at C:\Program Files\Android\Android Studio1 โ€ข Flutter plugin can be installed from: https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 17.0.9+0--11185874) [โˆš] Android Studio (version 2024.1) โ€ข Android Studio at C:\Program Files\Android\Android Studio2 โ€ข Flutter plugin can be installed from: https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 17.0.10+0--11609105) [โˆš] Android Studio (version 2024.2) โ€ข Android Studio at C:\Program Files\Android\Android Studio3 โ€ข Flutter plugin can be installed from: https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11) [โˆš] VS Code (version 1.94.2) โ€ข VS Code at C:\Users\henrik.andersson\AppData\Local\Programs\Microsoft VS Code โ€ข Flutter extension version 3.88.0 [โˆš] Connected device (4 available) โ€ข SM G973F (mobile) โ€ข RF8M91E2RSB โ€ข android-arm64 โ€ข Android 10 (API 29) โ€ข Windows (desktop) โ€ข windows โ€ข windows-x64 โ€ข Microsoft Windows [Version 10.0.19045.5131] โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 130.0.6723.117 โ€ข Edge (web) โ€ข edge โ€ข web-javascript โ€ข Microsoft Edge 131.0.2903.63 [โˆš] Network resources โ€ข All expected network resources are available. ! Doctor found issues in 1 category. ``` </details>
framework,a: desktop,f: focus,has reproducible steps,P3,team-framework,triaged-framework,found in release: 3.24,found in release: 3.27
low
Critical
2,695,080,209
deno
TypeError: expected i32
Version: Deno 2.1.1 I wrote an LTI integration using ltijs as an node app. Then I tried to move the code into an edge function and it fails with the following error: ``` runtime has escaped from the event loop unexpectedly: event loop error: TypeError: expected i32 at IncomingMessageForClient._read (node:http:781:10) at Readable.read (ext:deno_node/_stream.mjs:2995:16) at resume_ (ext:deno_node/_stream.mjs:3345:16) at processTicksAndRejections (ext:deno_node/_next_tick.ts:33:15) at runNextTicks (ext:deno_node/_next_tick.ts:71:3) at eventLoopTick (ext:core/01_core.js:175:21) failed to send request to user worker: event loop error: TypeError: expected i32 at IncomingMessageForClient._read (node:http:781:10) at Readable.read (ext:deno_node/_stream.mjs:2995:16) at resume_ (ext:deno_node/_stream.mjs:3345:16) at processTicksAndRejections (ext:deno_node/_next_tick.ts:33:15) at runNextTicks (ext:deno_node/_next_tick.ts:71:3) at eventLoopTick (ext:core/01_core.js:175:21) user worker failed to respond: event loop error: TypeError: expected i32 at IncomingMessageForClient._read (node:http:781:10) at Readable.read (ext:deno_node/_stream.mjs:2995:16) at resume_ (ext:deno_node/_stream.mjs:3345:16) at processTicksAndRejections (ext:deno_node/_next_tick.ts:33:15) at runNextTicks (ext:deno_node/_next_tick.ts:71:3) at eventLoopTick (ext:core/01_core.js:175:21) InvalidWorkerResponse: event loop error: TypeError: expected i32 at IncomingMessageForClient._read (node:http:781:10) at Readable.read (ext:deno_node/_stream.mjs:2995:16) at resume_ (ext:deno_node/_stream.mjs:3345:16) at processTicksAndRejections (ext:deno_node/_next_tick.ts:33:15) at runNextTicks (ext:deno_node/_next_tick.ts:71:3) at eventLoopTick (ext:core/01_core.js:175:21) at async Promise.allSettled (index 1) at async UserWorker.fetch (ext:sb_user_workers/user_workers.js:72:61) at async Object.handler (file:///root/index.ts:173:14) at async respond (ext:sb_core_main_js/js/http.js:163:14) { name: "InvalidWorkerResponse" } ``` While working with the node app I was able to modify the ltijs code in the node_modules to pinpoint any issues. This is no longer possible since I moved everything into Supabase edge functions. The library uses the node module [debug](https://www.npmjs.com/package/debug) for logging. But when I try to turn on logging using an environment variable I get a completely new error. ``` runtime has escaped from the event loop unexpectedly: event loop error: NotSupported: The operation is not supported at Object.setEnv [as set] (ext:sb_env/env.js:5:9) at Object.set (ext:deno_node/_process/process.ts:66:14) at Function.save (file:///var/tmp/sb-compile-edge-runtime/node_modules/localhost/debug/4.3.7/src/node.js:205:21) at Function.enable (file:///var/tmp/sb-compile-edge-runtime/node_modules/localhost/debug/4.3.7/src/common.js:163:15) at file:///Users/joel/IdeaProjects/business-simulation/supabase/functions/ltijs/index.ts:6:7 ``` Does this mean that certain node features required by this library are not yet supported by Deno? Without logging or being able to modify the ltijs library I am unsure how to further narrow down the problem. Here is my code: ```ts import { Provider as lti } from 'ltijs'; import Database from './DB.ts'; import pg from 'pg'; // Setup ltijs-sequelize using the same arguments as Sequelize's generic contructor // Database is hosted under http://localhost:54322/ const db = new Database('postgres', 'postgres', 'postgres', { host: '172.17.0.1', port: 54322, dialect: 'postgres', schema: 'lti', dialectModule: pg, logging: true, }); // Setup provider lti.setup( 'LTIKEY', // Key used to sign cookies and tokens { plugin: db, }, { // Options appRoute: '/ltijs/launch', loginRoute: '/ltijs/login', // Optionally, specify some of the reserved routes cookies: { secure: false, // Set secure to true if the testing platform is in a different domain and https is being used sameSite: '', // Set sameSite to 'None' if the testing platform is in a different domain and https is being used }, devMode: true, // Set DevMode to false if running in a production environment with https }, ); // Set lti launch callback lti.onConnect((token, req, res) => { console.log('onConnect'); console.log(token); return res.send("It's alive!"); }); const setup = async () => { // Deploy server and open connection to the database await lti.deploy({ port: 3000 }); // Specifying port. Defaults to 3000 // Register platform await lti.registerPlatform({ url: 'https://saltire.lti.app/platform', name: 'Saltire LTI App', clientId: 'saltire.lti.app', authenticationEndpoint: 'https://saltire.lti.app/platform/auth', accesstokenEndpoint: 'https://saltire.lti.app/platform/token/30d3313d7c655cdc2e722bafeb7374b9', authConfig: { method: 'JWK_SET', key: 'https://saltire.lti.app/platform/jwks/30d3313d7c655cdc2e722bafeb7374b9', }, }); }; setup(); ```
bug,node compat,ext/http,node:http
low
Critical
2,695,223,821
PowerToys
New+ Folder "Bookmarks"
### Description of the new feature / enhancement In the new+ context menu, it would be amazing to expand into subfolders, similar to the the way that you can expand folders on browser bookmarks. Perhaps a specific set of characters at the start of a folder in the templates could indicate an expandable folder? Thank you in advance for consideration of this feature! ### Scenario when this would be used? This would allow you to better categorize template folders and or files, and have the ability to manage a large list of templates. ### Supporting information _No response_
Needs-Triage
low
Minor
2,695,240,334
vscode
Dynamically change run buttons to debug when breakpoints are placed
In a recent user study, we observed a participant struggling to discover how to run in debug mode. After they placed breakpoints in their testing code, they would hit the run button next to their test expecting it to start the debugger and hit the breakpoint. It would be nice if when a user adds a breakpoint, the run button (whether it's for run file or for run test) would start the debugger cc/ @luabud <!-- โš ๏ธโš ๏ธ Do Not Delete This! feature_request_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. -->
feature-request
low
Critical
2,695,255,647
vscode
Provide entry point to run and debug view in the debug console
In a recent user study, we observed participants clicking through the debug console hoping something would populate there on run. This might be a good entry point for the Run and Debug panel where they could configure the debugger for their use case rather than saying "Please start a debug session to evaluate expression" since we noticed this messaging wasn't helpful to get them setup with the debugger. Perhaps we could link to open the Run and Debug panel or provide similar buttons as the panel to create a config and run and debug. cc/ @luabud <!-- โš ๏ธโš ๏ธ Do Not Delete This! feature_request_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- Please search existing issues to avoid creating duplicates. --> <!-- Describe the feature you'd like. -->
feature-request,debug-console
low
Critical
2,695,259,946
langchain
DOC: Broken API Reference Link for Google Vertex AI Embeddings
### URL https://python.langchain.com/docs/integrations/text_embedding/google_vertex_ai_palm/#credentials ### Checklist - [X] I added a very descriptive title to this issue. - [X] I included a link to the documentation page I am referring to (if applicable). ### Issue with current documentation: The API reference link for the Google Vertex AI Embeddings feature in LangChain's documentation is broken and leads to a "**Page Not Found**" error. **Location of the broken link:** The issue appears in the section that mentions: For detailed documentation on Google Vertex AI Embeddings features and configuration options, please refer to the **API reference**. The hyperlink here does not resolve to a valid page. **![Screenshot 2024-11-26 214525](https://github.com/user-attachments/assets/1da3d4a8-a43f-48a5-8354-d94ed5745e6e)** The link should direct users to the relevant API reference page that provides detailed documentation on the Google Vertex AI Embeddings feature. **Current behavior:** The link currently leads to a "Page Not Found" error, which hinders users from accessing detailed API reference material. ### Idea or request for content: Please update the broken link to point to the correct API(https://python.langchain.com/api_reference/index.html) reference page or provide an explanation in the documentation if the reference is unavailable.
๐Ÿค–:docs
low
Critical
2,695,263,425
go
os: TestGetwdDeepWithPWDSet failures
``` #!watchflakes default <- pkg == "os" && test == "TestGetwdDeepWithPWDSet" ``` Issue created automatically to collect these failures. Example ([log](https://ci.chromium.org/b/8732062106131155793)): === RUN TestGetwdDeepWithPWDSet getwd_unix_test.go:57: $PWD len: 253 getwd_unix_test.go:61: Getwd len: 253 getwd_unix_test.go:57: $PWD len: 454 getwd_unix_test.go:61: Getwd len: 454 getwd_unix_test.go:57: $PWD len: 655 getwd_unix_test.go:61: Getwd len: 655 getwd_unix_test.go:57: $PWD len: 856 getwd_unix_test.go:61: Getwd len: 856 getwd_unix_test.go:57: $PWD len: 1057 getwd_unix_test.go:61: Getwd len: 0 getwd_unix_test.go:69: getwd: file name too long --- FAIL: TestGetwdDeepWithPWDSet (0.00s) โ€” [watchflakes](https://go.dev/wiki/Watchflakes)
NeedsInvestigation
low
Critical
2,695,274,735
godot
Godot crashes when re-arranging nodes in the list of AnimationPlayer with some timeline options active.
### Tested versions - v3.6.stable.official [de2f0f147] (Official latest release) - v4.3.stable.official [77dcf97d8] - v3.6.stable.custom_build [de2f0f147] (custom latest build from Spine - Esoteric Software) Crash happens it these three releases, traversing major Godot revisions. ### System information Windows 10, Godot v3.6/v4.3 stable official, Nvidia 1070. ### Issue description Re-arranging entries in ActionPlayers is usually required to sort the list in a convenient way mostly when there is a lot of nodes involved. I use it combined with the Funnel filter (**Only show tracks from nodes selected in the tree**) and the List filter (**Group tracks by node or display them as plain list**). Those filters helps to have a compact view of the ActionPlayer and manage nodes selectively since I have projects sometimes with a hundred entries in ActionPlayers, I am experiencing crashes when the re-arrangement is made to certain locations in the ActionPlayer tree. ### Steps to reproduce For testing I have included a Minimal reproduction project below or you can follow all these steps: - Create a 2D scene. Create four Node2D nodes under the root node (name those as 1, 2, 3 and 4). - Create an ActionPlayer and into it a new animation. - In the animation create a Visibility property keyframe in frame 0 for the nodes 1, 2, 3 and 4. - Activate the Funnel and List icon filters (**Only show tracks from nodes selected in the tree** and **Group tracks by node or display them as plain list**) - In the scene node tree select nodes 1, 2 and 4 (not 3). Then you will see only three entries in the ActionPlayer. - In the ActionPlayer, drag the first node track right under the last track. The crash must happen. This also occur in different ways to re-arrange tracks, not only when moving a track to the bottom location. Thank you for your time. ### Minimal reproduction project (MRP) [gd_scene load_steps=2 format=2] [sub_resource type="Animation" id=1] resource_name = "New Anim" tracks/0/type = "value" tracks/0/path = NodePath("1:visible") tracks/0/interp = 1 tracks/0/loop_wrap = true tracks/0/imported = false tracks/0/enabled = true tracks/0/keys = { "times": PoolRealArray( 0 ), "transitions": PoolRealArray( 1 ), "update": 1, "values": [ true ] } tracks/1/type = "value" tracks/1/path = NodePath("2:visible") tracks/1/interp = 1 tracks/1/loop_wrap = true tracks/1/imported = false tracks/1/enabled = true tracks/1/keys = { "times": PoolRealArray( 0 ), "transitions": PoolRealArray( 1 ), "update": 1, "values": [ true ] } tracks/2/type = "value" tracks/2/path = NodePath("3:visible") tracks/2/interp = 1 tracks/2/loop_wrap = true tracks/2/imported = false tracks/2/enabled = true tracks/2/keys = { "times": PoolRealArray( 0 ), "transitions": PoolRealArray( 1 ), "update": 1, "values": [ true ] } tracks/3/type = "value" tracks/3/path = NodePath("4:visible") tracks/3/interp = 1 tracks/3/loop_wrap = true tracks/3/imported = false tracks/3/enabled = true tracks/3/keys = { "times": PoolRealArray( 0 ), "transitions": PoolRealArray( 1 ), "update": 1, "values": [ true ] } [node name="node_2d" type="Node2D"] [node name="1" type="Node2D" parent="."] modulate = Color( 1, 1, 1, 0 ) [node name="2" type="Node2D" parent="."] modulate = Color( 1, 1, 1, 0 ) [node name="3" type="Node2D" parent="."] modulate = Color( 1, 1, 1, 0 ) [node name="4" type="Node2D" parent="."] modulate = Color( 1, 1, 1, 0 ) [node name="animation_player" type="AnimationPlayer" parent="."] "anims/New Anim" = SubResource( 1 )
bug,needs testing,crash,topic:animation
low
Critical
2,695,291,866
react
[DevTools Bug]: Component flashing many times but profiler says it was rendered once
### Website or app https://berrotools.vercel.app/signin ### Repro steps - Access the website https://berrotools.vercel.app/signin, you'll see a sign in form. - Open the DevTools, go to the Profiler tab and start profiling. - Focus the e-mail input and start typing any letter, should not be a valid e-mail so the error label will show. You'll see the error message flashing as long as you type. - Stop the profiling. - Check the profiling results, you'll see that the error message was rendered once, if you have typed random letters. The problem is, why did it flash many times? If the website doesn't work try cloning and running the project located at https://github.com/rhberro/berrotools. Thank you in advance! ### How often does this bug happen? Every time ### DevTools package (automated) _No response_ ### DevTools version (automated) 6.0.1-c7c68ef842 ### Error message (automated) _No response_ ### Error call stack (automated) _No response_ ### Error component stack (automated) _No response_ ### GitHub query string (automated) _No response_
Type: Bug,Status: Unconfirmed,Component: Developer Tools
medium
Critical
2,695,305,907
yt-dlp
Thrivecart Embedded Vimeo Video
### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE - [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field ### Checklist - [X] I'm reporting a new site support request - [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels)) - [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details - [X] I've checked that none of provided URLs [violate any copyrights](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#is-the-website-primarily-used-for-piracy) or contain any [DRM](https://en.wikipedia.org/wiki/Digital_rights_management) to the best of my knowledge - [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates - [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue) - [X] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and am willing to share it if required ### Region USA ### Example URLs https://cart.audreyslittlefarm.com/l/how-to-start-grow-a-raised-bed-garden-masterclass/masterclass-video/ ### Provide a description that is worded well enough to be understood I tried yt-dlp with URL given above. Got "Unsupported URL" message. Content creator states host is Thrivecart. (I am just user, I don't know how to verify). Next, on the playing video I right-clicked and chose "open frame in new window". The new URL is Vimeo. https://player.vimeo.com/video/867026229?h=0bcd10eae4&badge=0&autopause=0&player_id=0&app_id=58479 I tried this URL and yt-dlp successfully downloaded the video. My credentials may be needed, happy to provide privately. ### Provide verbose output that clearly demonstrates the problem - [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`) - [ ] If using API, add `'verbose': True` to `YoutubeDL` params instead - [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below ### Complete Verbose Output ```shell yt-dlp -vU https://cart.audreyslittlefarm.com/l/how-to-start-grow-a-raised-bed-garden-masterclass/masterclass-video/ [debug] Command-line config: ['-vU', 'https://cart.audreyslittlefarm.com/l/how-to-start-grow-a-raised-bed-garden-masterclass/masterclass-video/'] [debug] Portable config "C:\Users\home\Downloads\ytdlp_try\yt-dlp.conf": ['-o', '%(title).150B [%(id)s].%(ext)s'] [debug] Encodings: locale cp1252, fs utf-8, pref cp1252, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version [email protected] from yt-dlp/yt-dlp [7ea278792] (win_exe) [debug] Python 3.10.11 (CPython AMD64 64bit) - Windows-10-10.0.22631-SP0 (OpenSSL 1.1.1t 7 Feb 2023) [debug] exe versions: ffmpeg 7.1-full_build-www.gyan.dev (setts), ffprobe 7.1-full_build-www.gyan.dev [debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.40.1, urllib3-2.2.3, websockets-13.1 [debug] Proxy map: {} [debug] Request Handlers: urllib, requests, websockets, curl_cffi [debug] Loaded 1837 extractors [debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp/releases/latest Latest version: [email protected] from yt-dlp/yt-dlp yt-dlp is up to date ([email protected] from yt-dlp/yt-dlp) [generic] Extracting URL: https://cart.audreyslittlefarm.com/l/how-to-start-grow-a-raised-bed-garden-masterclass/masterclass-video/ [generic] masterclass-video: Downloading webpage WARNING: [generic] Falling back on generic information extractor [generic] masterclass-video: Extracting information [debug] Looking for embeds ERROR: Unsupported URL: https://cart.audreyslittlefarm.com/l/how-to-start-grow-a-raised-bed-garden-masterclass/masterclass-video/ Traceback (most recent call last): File "yt_dlp\YoutubeDL.py", line 1624, in wrapper File "yt_dlp\YoutubeDL.py", line 1759, in __extract_info File "yt_dlp\extractor\common.py", line 742, in extract File "yt_dlp\extractor\generic.py", line 2553, in _real_extract yt_dlp.utils.UnsupportedError: Unsupported URL: https://cart.audreyslittlefarm.com/l/how-to-start-grow-a-raised-bed-garden-masterclass/masterclass-video/ ```
site-request,account-needed,can-share-account
low
Critical
2,695,307,968
vscode
keybinding's 'when' clause for 'view focused' and workbench's 'focus action' items for views are missing for some side bar views
<!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- ๐Ÿ•ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- ๐Ÿ”Ž Search existing issues to avoid creating duplicates. --> <!-- ๐Ÿงช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- ๐Ÿ’ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- ๐Ÿ”ง Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes <!-- ๐Ÿช“ If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- ๐Ÿ“ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - VS Code Version: 1.95.3 - OS Version: linux mint mate 21.3 Version: 1.95.3 Commit: f1a4fb101478ce6ec82fe9627c43efbf9e98c813 Date: 2024-11-13T14:50:04.152Z Electron: 32.2.1 ElectronBuildId: 10427718 Chromium: 128.0.6613.186 Node.js: 20.18.0 V8: 12.8.374.38-electron.0 OS: Linux x64 5.15.0-126-generic __Issue__ when setting keybindings, some action items and some relevant focus items for when clause are missing List of when clause items missing ( so far found, not exhaustive ) - callstackFocused ( from Run & Debug section ) - outlineFocued ( from explorer section ) - timelineFocused ( from explorer section ) - searchResultListFocused ( from Search section of activity bar ) - extensionResultListFocused ( from extension section ) List of Focus action items missing, unable to bind keybindings ( so far found, not exhaustive ) - workbench.action.search.focusResultList - workbench.action.search.focusSearchInputBox or search.action.focusSearchInputBox - workbench.extensions.action.focusResultList - workbench.extensions.action.focusSearchInputBox the above command id naming were guessed for missing items, please improvise and provide the missing action and when clause items __Suggesting better support for keyboard navigation__ eg for side bar items, just like there is focus action and when clause for different views in sections of sidebar, focus action and when clause for view heading tabs and buttons located in tab for easier keyboard navigation to buttons in each view heading tab __Suggesting consistent naming for command-ids__ of workbench action items, when clauses focus for better clarity just like workbench.files.action.focusOpenEditorsView, - instead of 'timeline.focus' can have 'workbench.files.action.focusTimelineView' - instead of 'outline.focus' can have 'workbench.files.action.focusOutlineView' or ''workbench.explorer.action.focusOutlineView', whichever meaningful - instead of 'workbench.explorer.fileView.focus' can have 'workbench.explorer.action.focusFileView' Implementing these will help with good keyboard navigation. Thank you
help wanted,feature-request,accessibility,context-keys
low
Critical
2,695,307,973
godot
SubViewport with transparent background results in premultiplied alpha colors in viewport texture
### Tested versions Reproducible in 4.3.stable ### System information Godot v4.3.stable - macOS 15.1.1 - Vulkan (Mobile) ### Issue description Using a subviewport with the transparent background option results in colors in the viewport texture being premultiplied with the blending alpha. This means semi-transparent pixels will become darker in color if rendered with a material (like the default CanvasItem material) that assumes the colors not to be premultiplied with the alpha. This is consistent across Compatibility, Mobile and Forward + renderers for me. There are multiple other issues like https://github.com/godotengine/godot/issues/88603 https://github.com/godotengine/godot/issues/91828 that seem related, but they contain some contradictory information like the issue being exclusive to Forward+ or related to sRGB conversion, and they are marked as requiring more testing to confirm the issue. These issues could probably be consolidated into one. ### Steps to reproduce - Add a subviewport container to your scene to display a viewport texture - Add subviewport in the container and set it to have transparent background - Add a TextureRect in the subviewport and change the modulate of it to make it semi-transparent - Copy the TextureRect and place in outside the subviewport container to compare - Observe that the two TextureRects do not look the same and the one rendered via the subviewport is darker. ![Image](https://github.com/user-attachments/assets/812c70a0-eebc-491b-809c-324392e03eee) - To see that the issue seems to be alpha premultiplication you can add a second TextureRect to your scene, and assign the viewport texture to it as well. Now, assign a new CanvasItem material to this texture rect, and change only its blend mode to use premultiplied alpha. Observe that the colors here seem to be correct again. ![Image](https://github.com/user-attachments/assets/1e5e8267-f103-4f10-b839-02ea0731404d) In other words you can compensate for this by creating a material that uses premultiplied alpha to show your viewport texture. However, this is not very obvious, and it might suffer from precision loss if color values are multiplied back/forth using the alpha. There's also the issue with this approach that if this is fixed/changed and the viewport texture colors stop being premultiplied this fix will make the colors incorrect again. If changing/fixing this would be considered breaking compatibility too much a more conservative option could be to add information about that the viewport texture uses premultiplied alpha for transparent background viewports to the [documentation](https://docs.godotengine.org/en/stable/classes/class_viewporttexture.html#class-viewporttexture). And maybe change the material used for the default SubViewportContainer to use premultiplied alpha to show blended colors in transparent viewports correctly. ### Minimal reproduction project (MRP) [viewporttransparency.zip](https://github.com/user-attachments/files/17922231/viewporttransparency.zip)
bug,topic:rendering,topic:gui
low
Minor
2,695,468,134
PowerToys
Font size increaser and decreser
### Description of the new feature / enhancement Size increaser and decreser ### Scenario when this would be used? Size increaser and decreser ### Supporting information _No response_
Needs-Triage
low
Minor
2,695,470,005
storybook
[Bug]: 8.4.5 Hangs on initial launch requires full reload
### Describe the bug Upgraded from 8.3.6 to 8.4.5, No additional updates to the code base. Browser opens, Storybook frame renders (Sidebar Nav & Component list), but the actual components/docs are NOT visible. No build errors. Haven't been able to repro in a fresh repo, hence not providing a link to one. ![Image](https://github.com/user-attachments/assets/66947f96-3539-4ebc-ba43-004ecf0609ba) ### Reproduction link https://github.com/pvisciano-pcty?tab=repositories ### Reproduction steps `npm run storybook` `"storybook": "storybook dev -p 6006",` Expected : Storybook launches and components are visible Actual : Browser opens, Storybook frame renders (Sidebar Nav & Component list), but the actual components/docs are not visible. Couple of 404s in the network tab. A full browser refresh clears the error and you are able to view the components. This only happens on initial launch ![Image](https://github.com/user-attachments/assets/d566c0d2-34f5-4b52-a3c3-4bc93da69529) ### System ```bash Storybook Environment Info: System: OS: macOS 14.5 CPU: (10) arm64 Apple M1 Pro Shell: 5.9 - /bin/zsh Binaries: Node: 20.10.0 - /usr/local/bin/node npm: 10.2.3 - /usr/local/bin/npm <----- active Browsers: Chrome: 131.0.6778.86 Safari: 17.5 ``` ### Additional context _No response_
bug,builder-vite
low
Critical
2,695,484,263
rust
rustdoc: Please use sticky headers for impl blocks
If you have a long rustdoc page with different `impl` blocks for the same type, such as https://doc.rust-lang.org/1.82.0/std/primitive.slice.html , each of which has various methods, it's really easy to lose track of which `impl` block a method is in. I'd love to see rustdoc use "sticky" headings for impl blocks, which stay visible while scrolling through the contents of the impl block, and scroll away when past that impl block. This should be possible with a bit of CSS (no JavaScript required). This came up when discussing some methods we wanted to add to `[MaybeUninit<T>]`.
C-enhancement,A-rustdoc-ui,T-rustdoc-frontend
low
Major
2,695,492,176
rust
Channel used for emitting diagnostic from codegen threads is not guaranteed to be fully drained when compilation session is aborted
> AFAIK, the channel used for emitting diagnostic from codegen threads is not guaranteed to be fully drained when compilation session is aborted. _Originally posted by @tmiasko in [#82886](https://github.com/rust-lang/rust/issues/82886#issuecomment-792944737)_ This may have lead to e.g. #82886.
A-testsuite,T-compiler,C-bug,E-needs-investigation
low
Minor
2,695,511,168
next.js
Nested parallel routes not unmounted when navigating back using router.back after a hard refresh
### Verify canary release - [X] I verified that the issue exists in the latest Next.js canary release ### Provide environment information ```bash Operating System: Platform: win32 Arch: x64 Version: Windows 11 Pro Available memory (MB): 16329 Available CPU cores: 6 Binaries: Node: 20.9.0 npm: 10.1.0 Yarn: 1.22.19 pnpm: N/A Relevant Packages: next: 15.0.4-canary.28 // Latest available version is detected (15.0.4-canary.28). eslint-config-next: 14.2.13 react: 18.3.1 react-dom: 18.3.1 typescript: 5.6.2 Next.js Config: output: N/A ``` ### Which example does this report relate to? https://github.com/rexfordessilfie/next-tabs ### What browser are you using? (if relevant) _No response_ ### How are you deploying your application? (if relevant) _No response_ ### Describe the Bug When navigating through the application, the following sequence of actions leads to the sub-a route being mounted: 1. Starting from the root, navigate to tab-a. 2. Then, navigate to sub-a under tab-a. 3. Perform a hard reload of the page. 4. Use the browser back button (or router.back()) to return to tab-a. ### Expected Behavior Upon navigating back to tab-a, the sub-a route should be unmounted, and the view should correctly reflect the state of tab-a. ### To Reproduce 1. Navigate to root. 2. Navigate to tab-a. 3. Navigate to sub-a. 4. Hard reload the page (Ctrl + R or Command + R). 5. Use the browser back button (or router.back()). 6. Observe that the sub-a route remains mounted under tab-a.
bug
low
Critical
2,695,516,415
langchain
langchain.agents.openai_assistant.base method parameters don't allow response_format
### Checked other resources - [X] I added a very descriptive title to this issue. - [X] I searched the LangChain documentation with the integrated search. - [X] I used the GitHub search to find a similar question and didn't find it. - [X] I am sure that this is a bug in LangChain rather than my code. - [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package). ### Example Code Methods such as the following, from langchain.agents.openai_assistant.base do not accept 'response_format' for json schemas: ```python def _create_thread_and_run(self, input: dict, thread: dict) -> Any: params = { k: v for k, v in input.items() if k in ("instructions", "model", "tools", "run_metadata") } run = self.client.beta.threads.create_and_run( assistant_id=self.assistant_id, thread=thread, **params, ) return run ### Error Message and Stack Trace (if applicable) There's no exception; it just filters out response_format as it's not in the accepted list. openai clients and method such as "create_and_run" accept this parameter, so you shouldn't be filtering it. ### Description I'm trying to submit response_format as one of my input parameters, but your code explicitly filters it out as per the example code from langchain.openai_assistant.base. When I edit your code to accept response_format everything works fine, as it's (now) an accepted parameter to openai assistants and the openai client library code. I understand this is relatively new, so I'm figuring you just have to update your code to reflect that it's now valid. ### System Info not applicable
๐Ÿค–:bug
low
Critical
2,695,527,738
pytorch
Minimizing recompiles when compiling multiple inlined `nn.Module`s
### ๐Ÿ› Describe the bug I'm working on integrating `torch.compile` into our RLHF recipe for torchtune (https://github.com/pytorch/torchtune/pull/2066). I'm seeing a lot of recompiles - some of which I can definitely try address on our side. I'm hoping for some advice on how I might go about this. Context: Our RLHF recipe involves 4 separate models, all of which I'd like to speed-up with `torch.compile`: - A policy model which requires optimization - A value model which requires optimization - A reference policy model which is frozen and which has params set to `requires_grad=False` - A reward model which is frozen and which has params set to `requires_grad=False` All of these models share the same architecture and model definition (with the exception of the value and reward model which have different final output layers). When we compile a model in torchtune, we compile each [attention layer in the model individually](https://github.com/pytorch/torchtune/blob/d7f8eb0bec68fd33975d6ad22ead51b44affada4/torchtune/training/_compile.py#L28). IIUC the entire block is inlined and the same graph is shared across all attention layers, with the layer weights being parameterized. One graph which is reused across all the attention layers, across all four models, right? Please see this minimal repro for how I'm using these models in our recipe, and the tlparse output below: ```python import os import torch from torchtune import training from torchtune.models.llama3_2 import llama3_2_1b os.environ["TORCH_COMPILE_BACKEND"] = "eager" torch._logging.set_logs(recompiles=True, graph_breaks=True, perf_hints=True) torch.set_default_device(torch.device("mps")) torch.set_default_dtype(torch.bfloat16) policy_model = llama3_2_1b() value_model = llama3_2_1b() reference_policy_model = llama3_2_1b() reward_model = llama3_2_1b() training.compile_model(policy_model) training.compile_model(value_model) training.compile_model(reference_policy_model) training.compile_model(reward_model) reference_policy_model.eval() for param in reference_policy_model.parameters(): param.requires_grad = False reward_model.eval() for param in reward_model.parameters(): param.requires_grad = False inps_full_seq = torch.ones(1, 64, dtype=torch.long) inps_single_token = torch.ones(1, 1, dtype=torch.long) inps_longer_seq_len = torch.ones(1, 68, dtype=torch.long) inps_medium_seq_len = torch.ones(1, 66, dtype=torch.long) with torch.no_grad(): policy_model(inps_full_seq) # recompile due to seq len 1 policy_model(inps_single_token) policy_model(inps_single_token) policy_model(inps_single_token) policy_model(inps_single_token) print("Running reference model with longer sequence length") # recompile - now graph is dynamic on dim 1 reference_policy_model(inps_longer_seq_len) print("Running value model with longer sequence length") # recompile - param grad changed! value_model(inps_longer_seq_len) print("Running reward model with medium sequence length") reward_model(inps_medium_seq_len) print("Optimizing") out1 = policy_model(inps_full_seq) out2 = value_model(inps_longer_seq_len) out1.mean().backward() out2.mean().backward() """outputs 2024-11-26:11:19:09,639 INFO [_compile.py:50] Compiling model layers with torch.compile... 2024-11-26:11:19:09,655 INFO [_compile.py:50] Compiling model layers with torch.compile... 2024-11-26:11:19:09,656 INFO [_compile.py:50] Compiling model layers with torch.compile... 2024-11-26:11:19:09,657 INFO [_compile.py:50] Compiling model layers with torch.compile... V1126 11:19:10.402000 89573 torch/_dynamo/guards.py:2760] [0/1] [__recompiles] Recompiling function forward in /Users/salmanmohammadi/projects/torchtune/torchtune/modules/transformer.py:82 V1126 11:19:10.402000 89573 torch/_dynamo/guards.py:2760] [0/1] [__recompiles] triggered by the following guard failure(s): V1126 11:19:10.402000 89573 torch/_dynamo/guards.py:2760] [0/1] [__recompiles] - 0/0: tensor 'L['x']' size mismatch at index 1. expected 64, actual 1 Running reference model with longer sequence length V1126 11:19:11.178000 89573 torch/_dynamo/guards.py:2760] [0/2] [__recompiles] Recompiling function forward in /Users/salmanmohammadi/projects/torchtune/torchtune/modules/transformer.py:82 V1126 11:19:11.178000 89573 torch/_dynamo/guards.py:2760] [0/2] [__recompiles] triggered by the following guard failure(s): V1126 11:19:11.178000 89573 torch/_dynamo/guards.py:2760] [0/2] [__recompiles] - 0/1: tensor 'L['x']' size mismatch at index 1. expected 1, actual 68 V1126 11:19:11.178000 89573 torch/_dynamo/guards.py:2760] [0/2] [__recompiles] - 0/0: tensor 'L['x']' size mismatch at index 1. expected 64, actual 68 Running value model with longer sequence length V1126 11:19:12.002000 89573 torch/_dynamo/guards.py:2760] [0/3] [__recompiles] Recompiling function forward in /Users/salmanmohammadi/projects/torchtune/torchtune/modules/transformer.py:82 V1126 11:19:12.002000 89573 torch/_dynamo/guards.py:2760] [0/3] [__recompiles] triggered by the following guard failure(s): V1126 11:19:12.002000 89573 torch/_dynamo/guards.py:2760] [0/3] [__recompiles] - 0/2: tensor 'L['self']._modules['attn']._modules['q_proj']._parameters['weight']' requires_grad mismatch. expected requires_grad=0. Guard failed on a parameter, consider using torch._dynamo.config.force_parameter_static_shapes = False to allow dynamism on parameters. V1126 11:19:12.002000 89573 torch/_dynamo/guards.py:2760] [0/3] [__recompiles] - 0/1: tensor 'L['x']' size mismatch at index 1. expected 1, actual 68 V1126 11:19:12.002000 89573 torch/_dynamo/guards.py:2760] [0/3] [__recompiles] - 0/0: tensor 'L['x']' size mismatch at index 1. expected 64, actual 68 Running reward model with medium sequence length Optimizing V1126 17:33:20.792000 95109 torch/_dynamo/guards.py:2760] [0/4] [__recompiles] Recompiling function forward in /Users/salmanmohammadi/projects/torchtune/torchtune/modules/transformer.py:82 V1126 17:33:20.792000 95109 torch/_dynamo/guards.py:2760] [0/4] [__recompiles] triggered by the following guard failure(s): V1126 17:33:20.792000 95109 torch/_dynamo/guards.py:2760] [0/4] [__recompiles] - 0/2: GLOBAL_STATE changed: grad_mode V1126 17:33:20.792000 95109 torch/_dynamo/guards.py:2760] [0/4] [__recompiles] - 0/3: GLOBAL_STATE changed: grad_mode V1126 17:33:20.792000 95109 torch/_dynamo/guards.py:2760] [0/4] [__recompiles] - 0/1: GLOBAL_STATE changed: grad_mode V1126 17:33:20.792000 95109 torch/_dynamo/guards.py:2760] [0/4] [__recompiles] - 0/0: GLOBAL_STATE changed: grad_mode """ ``` A few immediate questions I have: 1) Can we somehow avoid the recompile on `._parameters["weight"].requires_grad`? The relevant code is already being executed under `no_grad`. This seems like a relevant issue https://github.com/pytorch/pytorch/issues/131975. I suppose if these models are always run under `no_grad` I could avoid explicitly setting `param.requires_grad=False`? EDIT: I see a recompile on `_module["attn"].training` with this approach instead. 2) I was thinking of trying to isolate some portions of the code - for example, we have a function which we know will always be calling `policy_model` on inputs of shape `[bsz, 1, ...`]. If I try move this into a function and compile it separately with `dynamic=False`, is there a way I can avoid re-using the graph generated when we do `module.compile()`, and use this very static function instead? 3) Separately, if we divide the repro code above into their analagous counterparts in the recipe: a "generation" stage (under `no_grad`), and an "optimization" stage (the `backwards` after) - in the full recipe I only really see speedups for the generation stage. Infact, I pretty much always see slowdowns during the optimization stage vs. without compile. Could there be something immediately obvious behind this? Thanks! ### Error logs [dedicated_log_torch_trace_5kkmzqju.log](https://github.com/user-attachments/files/17923545/dedicated_log_torch_trace_5kkmzqju.log) ### Versions ```bash Collecting environment information... PyTorch version: 2.6.0.dev20241121 Is debug build: False CUDA used to build PyTorch: None ROCM used to build PyTorch: N/A OS: macOS 14.4.1 (arm64) GCC version: Could not collect Clang version: 15.0.0 (clang-1500.3.9.4) CMake version: Could not collect Libc version: N/A Python version: 3.12.4 (main, Jun 6 2024, 18:26:44) [Clang 15.0.0 (clang-1500.3.9.4)] (64-bit runtime) Python platform: macOS-14.4.1-arm64-arm-64bit Is CUDA available: False CUDA runtime version: No CUDA CUDA_MODULE_LOADING set to: N/A GPU models and configuration: No CUDA Nvidia driver version: No CUDA cuDNN version: No CUDA HIP runtime version: N/A MIOpen runtime version: N/A Is XNNPACK available: True CPU: Apple M1 Max Versions of relevant libraries: [pip3] flake8==7.1.1 [pip3] mypy-extensions==1.0.0 [pip3] numpy==1.26.4 [pip3] pytorch_sphinx_theme==0.0.24 [pip3] torch==2.6.0.dev20241121 [pip3] torchao==0.5.0 [pip3] torchaudio==2.5.0.dev20241121 [pip3] torchtune==0.0.0 [pip3] torchvision==0.20.0.dev20241121 [conda] No relevant packages ``` cc @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @amjames
triaged,oncall: pt2,module: dynamo,module: guards
low
Critical
2,695,580,075
deno
No Autocomplete featuire
Version: Deno latest There is no autocomplete feature for packages... Please fix it... ```json { "tasks": { "dev": "deno run --watch main.ts" }, "imports": { "@std/assert": "jsr:@std/assert@1", "mongoose": "npm:mongoose@^8.8.3" }, "fmt": { "indentWidth": 2, "useTabs": false, "semiColons": false } } ``` My MongoDB package is installed but in my editor autocomplete is not working.. I mean no autocomplete suggestion in Deno please add this feature
needs info
low
Major
2,695,614,353
yt-dlp
[NiconicoChannelPlus] Unable to fetch channel list: HTTP Error 400: Bad Request
### DO NOT REMOVE OR SKIP THE ISSUE TEMPLATE - [X] I understand that I will be **blocked** if I *intentionally* remove or skip any mandatory\* field ### Checklist - [X] I'm reporting that yt-dlp is broken on a **supported** site - [X] I've verified that I have **updated yt-dlp to nightly or master** ([update instructions](https://github.com/yt-dlp/yt-dlp#update-channels)) - [X] I've checked that all provided URLs are playable in a browser with the same IP and same login details - [X] I've checked that all URLs and arguments with special characters are [properly quoted or escaped](https://github.com/yt-dlp/yt-dlp/wiki/FAQ#video-url-contains-an-ampersand--and-im-getting-some-strange-output-1-2839-or-v-is-not-recognized-as-an-internal-or-external-command) - [X] I've searched [known issues](https://github.com/yt-dlp/yt-dlp/issues/3766) and the [bugtracker](https://github.com/yt-dlp/yt-dlp/issues?q=) for similar issues **including closed ones**. DO NOT post duplicates - [X] I've read the [guidelines for opening an issue](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#opening-an-issue) - [X] I've read about [sharing account credentials](https://github.com/yt-dlp/yt-dlp/blob/master/CONTRIBUTING.md#are-you-willing-to-share-account-details-if-needed) and I'm willing to share it if required ### Region Japan ### Provide a description that is worded well enough to be understood I tried to download a video on NiconicoChannel Plus that is exclusive to channel members, but I got error 400 and could not download it. I have looked on other forums and it seems that similar errors are often a problem with the region you are viewing. However, I live in Japan, so it is hard to believe that the region is the cause. ### Provide verbose output that clearly demonstrates the problem - [X] Run **your** yt-dlp command with **-vU** flag added (`yt-dlp -vU <your command line>`) - [ ] If using API, add `'verbose': True` to `YoutubeDL` params instead - [X] Copy the WHOLE output (starting with `[debug] Command-line config`) and insert it below ### Complete Verbose Output ```shell [debug] Command-line config: ['-vU', '--cookies', 'C:\\Users\\hidem\\Downloads\\nicochannelcookies.txt', 'https://nicochannel.jp/ihara-rikka-officialfc/video/smo4DKnipKSrBACNu6SyddMg'] [debug] Encodings: locale cp932, fs utf-8, pref cp932, out utf-8, error utf-8, screen utf-8 [debug] yt-dlp version [email protected] from yt-dlp/yt-dlp-nightly-builds [4b5eec0aa] (win_exe) [debug] Python 3.10.11 (CPython AMD64 64bit) - Windows-10-10.0.26100-SP0 (OpenSSL 1.1.1t 7 Feb 2023) [debug] exe versions: ffmpeg N-113785-gfe340c3244-20240223 (setts), ffprobe N-113785-gfe340c3244-20240223 [debug] Optional libraries: Cryptodome-3.21.0, brotli-1.1.0, certifi-2024.08.30, curl_cffi-0.5.10, mutagen-1.47.0, requests-2.32.3, sqlite3-3.40.1, urllib3-2.2.3, websockets-14.1 [debug] Proxy map: {} [debug] Request Handlers: urllib, requests, websockets, curl_cffi [debug] Loaded 1837 extractors [debug] Fetching release info: https://api.github.com/repos/yt-dlp/yt-dlp-nightly-builds/releases/latest Latest version: [email protected] from yt-dlp/yt-dlp-nightly-builds yt-dlp is up to date ([email protected] from yt-dlp/yt-dlp-nightly-builds) [NiconicoChannelPlus] Extracting URL: https://nicochannel.jp/ihara-rikka-officialfc/video/smo4DKnipKSrBACNu6SyddMg [NiconicoChannelPlus] channels/ihara-rikka-officialfc: Fetching channel list ERROR: [NiconicoChannelPlus] Unable to fetch channel list: HTTP Error 400: Bad Request (caused by <HTTPError 400: Bad Request>) File "yt_dlp\extractor\common.py", line 742, in extract File "yt_dlp\extractor\niconicochannelplus.py", line 103, in _real_extract File "yt_dlp\extractor\niconicochannelplus.py", line 26, in _find_fanclub_site_id File "yt_dlp\extractor\niconicochannelplus.py", line 22, in _call_api File "yt_dlp\extractor\common.py", line 1152, in download_content File "yt_dlp\extractor\common.py", line 1112, in download_handle File "yt_dlp\extractor\common.py", line 962, in _download_webpage_handle File "yt_dlp\extractor\common.py", line 911, in _request_webpage File "yt_dlp\extractor\common.py", line 898, in _request_webpage File "yt_dlp\YoutubeDL.py", line 4162, in urlopen File "yt_dlp\networking\common.py", line 117, in send File "yt_dlp\networking\_helper.py", line 208, in wrapper File "yt_dlp\networking\common.py", line 340, in send File "yt_dlp\networking\_requests.py", line 365, in _send yt_dlp.networking.exceptions.HTTPError: HTTP Error 400: Bad Request ```
site-bug,triage
low
Critical
2,695,617,872
next.js
formData with app router: Upload error: TypeError: Failed to parse body as FormData.
### Link to the code that reproduces this issue https://codesandbox.io/p/sandbox/twilight-flower-v6pl9s ### To Reproduce i am uploading a file using axios in a client side component in this way: ``` const options: AxiosRequestConfig = { headers: { 'Content-Type': 'multipart/form-data' } }; const { data } = await axios.post<{ success: boolean; }>( '/api/upload', formData, options ); ``` in the **/api/upload** route i have the following code: ``` export async function POST(request: NextRequest) { try { console.log('in post'); let formData = await request.formData(); console.log('formData', formData); const file = formData.get('file') as File; } catch (error) { console.error('Upload error:', error); return NextResponse.json( { error: 'Failed to upload file' }, { status: 500 } ); } } ``` if the file is <~2GB everythings is working, the formData is returned with the correct values, otherwise if the file is bigger i get the following output: ``` Upload error: TypeError: Failed to parse body as FormData. at node:internal/deps/undici/undici:5668:27 at successSteps (node:internal/deps/undici/undici:5712:27) at fullyReadBody (node:internal/deps/undici/undici:4609:9) at process.processTicksAndRejections (node:internal/process/task_queues:105:5) at async consumeBody (node:internal/deps/undici/undici:5721:7) at async POST (/Users/539hex/dev/deft.cx/.next/server/chunks/_bc0f62._.js:282:24) at async /Users/539hex/dev/deft.cx/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:55831 at async eO.execute (/Users/539hex/dev/deft.cx/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:46527) at async eO.handle (/Users/539hex/dev/deft.cx/node_modules/next/dist/compiled/next-server/app-route.runtime.dev.js:6:57165) at async doRender (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/base-server.js:1353:42) at async cacheEntry.responseCache.get.routeKind (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/base-server.js:1575:28) at async DevServer.renderToResponseWithComponentsImpl (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/base-server.js:1483:28) at async DevServer.renderPageComponent (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/base-server.js:1911:24) at async DevServer.renderToResponseImpl (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/base-server.js:1949:32) at async DevServer.pipeImpl (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/base-server.js:921:25) at async NextNodeServer.handleCatchallRenderRequest (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/next-server.js:272:17) at async DevServer.handleRequestImpl (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/base-server.js:817:17) at async /Users/539hex/dev/deft.cx/node_modules/next/dist/server/dev/next-dev-server.js:339:20 at async Span.traceAsyncFn (/Users/539hex/dev/deft.cx/node_modules/next/dist/trace/trace.js:154:20) at async DevServer.handleRequest (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/dev/next-dev-server.js:336:24) at async invokeRender (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/lib/router-server.js:173:21) at async handleRequest (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/lib/router-server.js:350:24) at async requestHandlerImpl (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/lib/router-server.js:374:13) at async Server.requestListener (/Users/539hex/dev/deft.cx/node_modules/next/dist/server/lib/start-server.js:141:13) POST /api/upload 500 in 9203ms ``` ### Current vs. Expected behavior I expect always to have the formData returned despite the file size ### Provide environment information ```bash Operating System: Platform: darwin Arch: arm64 Version: Darwin Kernel Version 24.1.0: Thu Oct 10 21:03:11 PDT 2024; root:xnu-11215.41.3~2/RELEASE_ARM64_T6020 Available memory (MB): 32768 Available CPU cores: 12 Binaries: Node: 23.3.0 npm: 10.9.0 Yarn: 1.22.22 pnpm: 9.12.1 Relevant Packages: next: 14.2.18 // An outdated version detected (latest is 15.0.3), upgrade is highly recommended! eslint-config-next: N/A react: 18.3.1 react-dom: 18.3.1 typescript: 5.6.2 Next.js Config: output: N/A โš  An outdated version detected (latest is 15.0.3), upgrade is highly recommended! Please try the latest canary version (`npm install next@canary`) to confirm the issue still exists before creating a new issue. Read more - https://nextjs.org/docs/messages/opening-an-issue ``` ### Which area(s) are affected? (Select all that apply) Not sure ### Which stage(s) are affected? (Select all that apply) next dev (local) ### Additional context i tried also to update to next 15.0.3 and i have the same exact issue.
bug
low
Critical
2,695,639,132
node
Byte stream support for Socket readableWebStream
### What is the problem this feature will solve? As mentioned by the [winterCG](https://sockets-api.proposal.wintercg.org/#readable-attribute/) it is reasonable to assume that most TCP cases are bytes oriented. And my case (MQTT server/client) is one of them. However: ```javascript import { createConnection } from "node:net"; import { Readable } from "node:stream"; const socket = createConnection({ port:1883, host: "localhost" }, () => { const readable= Readable.toWeb(socket); const reader = readable.getReader({ mode: "byob" }); }); ``` Gives me: ``` node:internal/webstreams/readablestream:2280 throw new ERR_INVALID_ARG_VALUE('stream', stream, 'must be a byte stream'); ^ TypeError [ERR_INVALID_ARG_VALUE]: The argument 'stream' must be a byte stream. Received ReadableStream { locked: false, state: 'readable', supportsBYOB: false } at setupReadableStreamBYOBReader (node:internal/webstreams/readablestream:2280:11) at new ReadableStreamBYOBReader (node:internal/webstreams/readablestream:935:5) at ReadableStream.getReader (node:internal/webstreams/readablestream:346:12) at Socket.<anonymous> (file:///home/hansklunder/github/opifex/tmp.js:6:29) at Object.onceWrapper (node:events:632:28) at Socket.emit (node:events:518:28) at TCPConnectWrap.afterConnect [as oncomplete] (node:net:1595:10) { code: 'ERR_INVALID_ARG_VALUE' } ``` Which makes sense in its current implementation. Solving this would bring better compatibility with the WinterCG standards and would make it easier to implement TCP bytestream protocols in NodeJS. ### What is the feature you are proposing to solve the problem? It would be nice if I could signal either at the creation of the socket or the Readable.toWeb() that I want a ReadableByteStream instead of ReadableDefaultStream. Even more brilliant would be if I could skip the `Readable.toWeb()` call also somehow, e.g. by importing `node:sockets` or something similar. ### What alternatives have you considered? I've currently hacked my own layer on top of the socket event API: ``` javascript import { Writable } from "node:stream"; function closer(sock) { if (!sock.closed) { sock.end(); } } export function wrapNodeSocket(socket) { const readable = new ReadableStream({ type: "bytes", start(controller) { socket.on("data", (data) => { controller.enqueue(data); const desiredSize = controller.desiredSize ?? 0; if (desiredSize <= 0) { // The internal queue is full, so propagate // the backpressure signal to the underlying source. socket.pause(); } }); socket.on("error", (err) => controller.error(err)); socket.on("end", () => { // close the controller controller.close(); // and unlock the last BYOB read request controller.byobRequest?.respond(0); }); }, pull: () => { socket.resume(); }, cancel: () => { socket.end(); }, }); const writable = Writable.toWeb(socket); const remoteAddr = { hostname: socket.remoteAddress || "", port: socket.remotePort || 0, }; const conn = { readable: readable, writable: writable, close: () => closer(socket), remoteAddr, }; return conn; } ``` This works, but it would be nice if it was part of standard NodeJS functionality.
feature request
low
Critical
2,695,653,766
pytorch
Marking integer inputs to a compiled region requires `torch._dynamo.assume_static_by_default = True`
From some discussion with @drisspg after looking https://github.com/pytorch/pytorch/issues/141486#issuecomment-2501574320. Here is a slightly modified repro: ``` import torch from torch.nn.attention.flex_attention import create_block_mask, flex_attention flex_attention_compile = torch.compile(flex_attention, fullgraph=True) fast_create = torch.compile(create_block_mask, fullgraph=True) B = 1 S = 10_000 H = 8 D = 16 def sliding_window_mask(window_size: int): def mask_fn(b, h, q_idx, kv_idx): return (q_idx - kv_idx <= window_size // 2) & (kv_idx - q_idx <= window_size // 2) return mask_fn mask_mod = sliding_window_mask(1024) xs = [torch.randn(B, H, i, D, dtype=torch.float16, device="cuda", requires_grad=True) for i in range(10_000, 100_000, 1_000)] # Warmpup #block_mask = fast_create(mask_mod, B=None, H=None, Q_LEN=S, KV_LEN=S, device="cuda") #torch._dynamo.mark_dynamic(xs[0], -2) #flex_attention_compile(xs[0], xs[0], xs[0], block_mask=block_mask) from pathlib import Path torch.cuda.synchronize() # with profiler(Path("user_2.json")): from contextlib import nullcontext with nullcontext(): for x in xs: block_mask = fast_create(mask_mod, B=None, H=None, Q_LEN=x.size(-2), KV_LEN=x.size(-2), device="cuda") out = flex_attention_compile(x, x, x, block_mask=block_mask) bwd = out.sum().backward() ``` Running with `TORCH_LOGS="recompiles"` gives you an initial recompile with this message: ``` triggered by the following guard failure(s): - 0/0: L['Q_LEN'] == 10000 ``` What's happening is that: (1) even though we mark `x.size(2)` has having a dynamic shape, we end up passing it **directly** as an input to the compiled region (`block_mask`) (2) We don't have a way (that I could find) to mark specific integer inputs to a compiled region as dynamic. I found `torch._dynamo.assume_static_by_default=True`, but this flag looks deprecated, and also applies to all inputs. Do we have, or do we want to add, a way to mark integer inputs on an int-by-int basis? One side note from talking to @drisspg is that it would be very nice if in eager mode, calling `Q_LEN=x.size(-2)` "remembered" that `Q_LEN` is now dynamic as well, without the user needing to do extra work to tell the compiler about the dynamism though. This would require doing the provenance tracking in eager though, which will have a performance cost. cc @chauhang @penguinwu @ezyang @bobrenjc93
triaged,oncall: pt2,module: dynamic shapes
low
Critical
2,695,664,819
pytorch
FX graph cache does not do provenance tracking for inductor guards
Given the below repro, if I run it with `TORCHINDUCTOR_FX_GRAPH_CACHE=0 TORCH_LOGS="+recompiles"`, I get a recompile due to a shape guard that tells me about inductor recompiling on 32 bit indexing: ``` DEBUG: Recompiling function create_block_mask in /home/hirsheybar/.conda/envs/torchtune/lib/python3.11/site-packages/torch/nn/attention/flex_attention.py:810 triggered by the following guard failure(s): - 0/0: L['BLOCK_SIZE']**2*(((L['BLOCK_SIZE'] + L['Q_LEN'] - 1)//L['BLOCK_SIZE']))*(((L['BLOCK_SIZE'] + L['KV_LEN'] - 1)//L['BLOCK_SIZE'])) < 2147483648 # (_inductor/codegen/simd.py:1227 in can_use_32bit_indexing) ``` If I run it with an FX graph cache hit, though (running multiple times without the env var to skip caching), we lose the nice provenance tracking of the guard. It would be nice if the source information of the guard was included in the FX graph cache, so we could include it in the recompile reason: ``` DEBUG: Recompiling function create_block_mask in /home/hirsheybar/.conda/envs/torchtune/lib/python3.11/site-packages/torch/nn/attention/flex_attention.py:810 triggered by the following guard failure(s): - 0/0: L['BLOCK_SIZE']**2*(((L['BLOCK_SIZE'] + L['Q_LEN'] - 1)//L['BLOCK_SIZE']))*(((L['BLOCK_SIZE'] + L['KV_LEN'] - 1)//L['BLOCK_SIZE'])) < 2147483648 # (<string>:1 in <module>) ``` repro code: ``` import torch from torch.nn.attention.flex_attention import create_block_mask, flex_attention flex_attention_compile = torch.compile(flex_attention, fullgraph=True) fast_create = torch.compile(create_block_mask, fullgraph=True, dynamic=True) B = 1 S = 10_000 H = 8 D = 16 def sliding_window_mask(window_size: int): def mask_fn(b, h, q_idx, kv_idx): return (q_idx - kv_idx <= window_size // 2) & (kv_idx - q_idx <= window_size // 2) return mask_fn mask_mod = sliding_window_mask(1024) xs = [torch.randn(B, H, i, D, dtype=torch.float16, device="cuda", requires_grad=True) for i in range(10_000, 100_000, 1_000)] from pathlib import Path torch.cuda.synchronize() from contextlib import nullcontext with nullcontext(): for x in xs: torch._dynamo.mark_dynamic(x, 2) block_mask = fast_create(mask_mod, B=None, H=None, Q_LEN=x.size(-2), KV_LEN=x.size(-2), device="cuda") out = flex_attention_compile(x, x, x, block_mask=block_mask) bwd = out.sum().backward() ``` cc @chauhang @penguinwu @voznesenskym @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @yf225 @chenyang78 @kadeng @muchulee8 @ColinPeppler @amjames @desertfire @aakhundov @drisspg
triaged,oncall: pt2,module: inductor
low
Critical
2,695,667,545
vscode
Can't open remote Network folder within VSCode
Type: <b>Bug</b> Add a remote Network Folder into Dolphin on SteamOS, then try to open that folder within VSCode. It won't open. I can open a single file from the folder in VSCode and that works, but the whole folder doesn't work. VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z) OS version: Linux x64 6.5.0-valve22-1-neptune-65-g9a338ed8a75e Modes: <details> <summary>System Info</summary> |Item|Value| |---|---| |CPUs|AMD Custom APU 0405 (8 x 2975)| |GPU Status|2d_canvas: enabled<br>canvas_oop_rasterization: enabled_on<br>direct_rendering_display_compositor: disabled_off_ok<br>gpu_compositing: enabled<br>multiple_raster_threads: enabled_on<br>opengl: enabled_on<br>rasterization: enabled<br>raw_draw: disabled_off_ok<br>skia_graphite: disabled_off<br>video_decode: enabled<br>video_encode: disabled_software<br>vulkan: disabled_off<br>webgl: enabled<br>webgl2: enabled<br>webgpu: disabled_off<br>webnn: disabled_off| |Load (avg)|6, 9, 13| |Memory (System)|14.47GB (2.85GB free)| |Process Argv|--ms-enable-electron-run-as-node --extensions-dir=/home/deck/.var/app/com.visualstudio.code/data/vscode/extensions --reuse-window /run/user/1000/doc/2069314f/README.md --crash-reporter-id 5f3ed78c-a0ce-4c74-8e88-01b1d9af7c21| |Screen Reader|no| |VM|0%| |DESKTOP_SESSION|plasma-steamos-oneshot| |XDG_CURRENT_DESKTOP|KDE| |XDG_SESSION_DESKTOP|KDE (One-Time Launch)| |XDG_SESSION_TYPE|x11| </details><details><summary>Extensions (34)</summary> Extension|Author (truncated)|Version ---|---|--- delphi-keybindings|ale|9.8.0 delphi-pack|ale|2.1.0 numbered-bookmarks|ale|8.5.0 pascal|ale|9.8.0 vscode-intelephense-client|bme|1.12.6 delphilsp|Emb|1.0.1 code-runner|for|0.12.2 copilot|Git|1.246.0 copilot-chat|Git|0.22.4 remotehub|Git|0.64.0 discord-vscode|icr|5.8.0 compareit|in4|0.0.2 vscord|Leo|5.2.13 debugpy|ms-|2024.12.0 isort|ms-|2023.10.1 python|ms-|2024.20.0 vscode-pylance|ms-|2024.11.3 jupyter|ms-|2024.10.0 jupyter-keymap|ms-|1.1.2 jupyter-renderers|ms-|1.0.21 vscode-jupyter-cell-tags|ms-|0.1.9 vscode-jupyter-slideshow|ms-|0.1.6 remote-ssh|ms-|0.115.1 remote-ssh-edit|ms-|0.87.0 remote-wsl|ms-|0.88.5 azure-repos|ms-|0.40.0 remote-explorer|ms-|0.4.3 remote-repositories|ms-|0.42.0 remote-server|ms-|1.5.2 rcore-unused-css-classes|rco|0.1.7 format-html-in-php|rif|1.7.0 snyk-vulnerability-scanner|sny|2.19.2 ide-ext|sta|0.5.7 vscode-wakatime|Wak|24.9.1 (1 theme extensions excluded) </details><details> <summary>A/B Experiments</summary> ``` vsliv368:30146709 vspor879:30202332 vspor708:30202333 vspor363:30204092 vscod805cf:30301675 binariesv615:30325510 vsaa593:30376534 py29gd2263:31024239 c4g48928:30535728 azure-dev_surveyone:30548225 a9j8j154:30646983 962ge761:30959799 pythonnoceb:30805159 asynctok:30898717 pythonmypyd1:30879173 2e7ec940:31000449 pythontbext0:30879054 cppperfnew:31000557 dsvsc020:30976470 pythonait:31006305 dsvsc021:30996838 0ee40948:31013168 dvdeprecation:31068756 dwnewjupytercf:31046870 nativerepl2:31139839 pythonrstrctxt:31112756 cf971741:31144450 iacca1:31171482 notype1:31157159 5fd0e150:31155592 dwcopilot:31170013 stablechunks:31184530 ``` </details> <!-- generated by issue reporter -->
upstream,linux,electron,native-file-dialog
low
Critical
2,695,773,754
flutter
[webview_flutter_android] Garbage collection tests are failing
To test that objects are collected for `webview_flutter_android`, the tests use `IntegrationTestWidgetsFlutterBinding.watchPerformance` to force the garbage collector to run in Dart. However, calling this during integration tests causes this error: ``` โ•โ•โ•ก EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK โ•žโ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ• The following StateError was thrown running a test: Bad state: Failed to connect to VM Service at ws://localhost:56445/Jw3X0DnPT7Y=/ws. This may happen if DDS is enabled. If this test was launched via `flutter drive`, try adding `--no-dds`. The original exception was: SocketException: Connection refused (OS Error: Connection refused, errno = 111), address = localhost, port = 46384 #0 _NativeSocket.startConnect (dart:io-patch/socket_patch.dart:824:35) #1 _RawSocket.startConnect (dart:io-patch/socket_patch.dart:2281:26) #2 RawSocket.startConnect (dart:io-patch/socket_patch.dart:41:23) #3 Socket._startConnect (dart:io-patch/socket_patch.dart:2561:22) #4 Socket.startConnect (dart:io/socket.dart:890:21) #5 _ConnectionTarget.connect (dart:_http/http_impl.dart:2686:24) #6 _HttpClient._getConnection.connect (dart:_http/http_impl.dart:3200:12) #7 _HttpClient._getConnection (dart:_http/http_impl.dart:3205:12) #8 _HttpClient._openUrl (dart:_http/http_impl.dart:3028:12) #9 _HttpClient.openUrl (dart:_http/http_impl.dart:2850:7) #10 _WebSocketImpl.connect (dart:_http/websocket_impl.dart:1096:10) #11 WebSocket.connect (dart:_http/websocket.dart:332:24) #12 _vmServiceConnectUri (package:integration_test/integration_test.dart:482:44) #13 IntegrationTestWidgetsFlutterBinding.enableTimeline (package:integration_test/integration_test.dart:270:28) <asynchronous suspension> #14 IntegrationTestWidgetsFlutterBinding.traceTimeline (package:integration_test/integration_test.dart:302:5) <asynchronous suspension> #15 IntegrationTestWidgetsFlutterBinding._runAndGetGCInfo (package:integration_test/integration_test.dart:377:34) <asynchronous suspension> #16 IntegrationTestWidgetsFlutterBinding.watchPerformance (package:integration_test/integration_test.dart:432:43) <asynchronous suspension> #17 main.<anonymous closure> (file:///Users/bmparr/Development/packages/packages/webview_flutter/webview_flutter_android/example/integration_test/webview_flutter_test.dart:100:5) <asynchronous suspension> #18 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:189:15) <asynchronous suspension> #19 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1027:5) <asynchronous suspension> #20 StackZoneSpecification._registerCallback.<anonymous closure> (package:stack_trace/src/stack_zone_specification.dart:114:42) <asynchronous suspension> When the exception was thrown, this was the stack: #0 IntegrationTestWidgetsFlutterBinding.enableTimeline (package:integration_test/integration_test.dart:272:9) <asynchronous suspension> #1 IntegrationTestWidgetsFlutterBinding.traceTimeline (package:integration_test/integration_test.dart:302:5) <asynchronous suspension> #2 IntegrationTestWidgetsFlutterBinding._runAndGetGCInfo (package:integration_test/integration_test.dart:377:34) <asynchronous suspension> #3 IntegrationTestWidgetsFlutterBinding.watchPerformance (package:integration_test/integration_test.dart:432:43) <asynchronous suspension> #4 main.<anonymous closure> (file:///Users/bmparr/Development/packages/packages/webview_flutter/webview_flutter_android/example/integration_test/webview_flutter_test.dart:100:5) <asynchronous suspension> #5 testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:189:15) <asynchronous suspension> #6 TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1027:5) <asynchronous suspension> <asynchronous suspension> (elided one frame from package:stack_trace) The test description was: withWeakRefenceTo allows encapsulating class to be garbage collected โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ•โ• ```
fyi-android,fyi-ecosystem,fyi-tool
low
Critical
2,695,774,487
flutter
ColorScheme onInverseSurface does not follow M3 specification.
### Steps to reproduce `ColorScheme` incorrectly defines [`onInverseSurface`](https://api.flutter.dev/flutter/material/ColorScheme/onInverseSurface.html) as the property to configure the "Inverse On Surface" color role. This is confusing when comparing Flutter configurations against M3 specifications. ### Expected results `inverseOnSurface` should be used consistently within Flutter assets to refer to the "Inverse On Surface" color role. ### Actual results **Compliant** * `MaterialDynamicColors` uses [`inverseOnSurface`](https://api.flutter.dev/flutter/package-material_color_utilities_dynamiccolor_material_dynamic_colors/MaterialDynamicColors/inverseOnSurface.html) * `DynamicScheme` uses [`inverseOnSurface`](https://api.flutter.dev/flutter/package-material_color_utilities_dynamiccolor_dynamic_scheme/DynamicScheme/inverseOnSurface.html) * `Scheme` (deprecated) uses [`inverseOnSurface`](https://api.flutter.dev/flutter/package-material_color_utilities_scheme_scheme/Scheme/inverseOnSurface.html) **Non-compliant** * `ColorScheme` uses [`onInverseSurface`](https://api.flutter.dev/flutter/material/ColorScheme/onInverseSurface.html) ### Code sample n/a ### Screenshots or Video [M3 Color roles - Inverse colors](https://m3.material.io/styles/color/roles#7fc6b47e-db22-4e98-8359-7649a099e4a1) ![PixelSnap 2024-11-26 at 12 37 41@2x](https://github.com/user-attachments/assets/4c3be23e-92ff-4c91-962a-7269ed59363a) ### Logs n/a ### Flutter Doctor output n/a
framework,f: material design,a: fidelity,P2,team-design,triaged-design
low
Minor
2,695,787,548
godot
Reflection probes ambient lighting does not conserve energy when probes overlap.
### Tested versions v4.3.stable.official [77dcf97d8] ### System information Godot v4.3.stable - Windows 10.0.19045 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 2060 (NVIDIA; 32.0.15.6094) - AMD Ryzen 5 5600X 6-Core Processor (12 Threads) ### Issue description It looks like instead of blending the ambient lighting all probes apply their ambient lighting equally. The more overlapping probes in a particular area, the brighter or darker this area gets (depending on the environment). I found this while testing #61416, placing a smaller "detail" probe in a room which already had a main probe. That PR shows the effect much more prominently. The setup of these probes may seem really dubious, but it's representative of a common workflow where you nest reflection probes. Commonly one probe would be placed covering an entire space, and subsequent smaller probes are used to resolve reflection inaccuracies, often resulting in a setup with several overlapping probes. This is very relevant for #89408 because that PR makes this workflow feasible in Godot. **4.3 stable:** ![Image](https://github.com/user-attachments/assets/8fde888a-dc3f-4648-989f-ea5fc1a206fd) **In Calinou's PR:** ![Image](https://github.com/user-attachments/assets/52d93d2c-0809-4be8-adc3-d96dfa40e128) **4.3 MRP:** Notice how in this case overlapping dark spots get even darker. ![Image](https://github.com/user-attachments/assets/5f86db1f-32ec-4412-8c02-6b313343473d) The MRP is set up with one main probe, covering the entire space, and a bunch of tiny probes placed close to the back wall. A secondary structure just has a main probe and a smaller probe representing what an artist might place to get more accurate reflections on a mesh that's a bit too far away from that main probes capture point. In this case I've placed that secondary probe deliberately very close to the main probe, so that the ambient lighting it captures should in principle be the same. The expected behavior would be more or less constant ambient lighting. The captured lighting from these probes should be similar enough (since they're all placed in close proximity of each other) to allow them to blend much more subtly. ### Steps to reproduce Place several overlapping reflection probes. ### Minimal reproduction project (MRP) [reflection_probe_energy_conservation.zip](https://github.com/user-attachments/files/17924638/reflection_probe_energy_conservation.zip)
bug,topic:rendering
low
Minor
2,695,788,997
deno
Support tsconfig.json
It would be convenient if deno could be pick up an existing repo, and be compatible with the tsconfig.json files, to ease the gradual migration. This is in many ways similar to the package.json compat, where deno favors the package.json if present, which made big improvements to the incremental adoption story.
suggestion
low
Minor
2,695,798,579
flutter
video_player does not render on NVIDIA SHIELD (Android TV).
### Steps to reproduce Target an NVIDIA SHIELD. Compile the three files (main.dart, video_play_widget.dart, alert_dialog_widget.dart). The test is using flutter.dev cross_file and video_player. Also, please note to see it work on Windows please add (video_player_win). I simplified my test case to a simple build() and the image does not show on the NVIDIA SHIELD (Android TV). You can hear the audio but see no image. It works properly on Windows and Android phone/tablets. ### Expected results Should see the image and hear the audio. ### Actual results No image. Only audio. ### Code sample <details open><summary>Code sample</summary> Video Player ```dart import 'dart:io'; import 'package:cross_file/cross_file.dart'; import 'package:flutter/material.dart'; import 'package:video_player/video_player.dart'; import 'alert_dialog_widget.dart'; //ignore: must_be_immutable class VideoPlayerWidget extends StatefulWidget { VideoPlayerWidgetState? theState; void Function(VideoPlayerWidgetState? theState)? callback; VideoPlayerWidget({required Key key, this.callback}) : super(key: key); @override VideoPlayerWidgetState createState() => VideoPlayerWidgetState(); } class VideoPlayerWidgetState extends State<VideoPlayerWidget> { late VideoPlayerController controller; bool isInitialized = false; VideoPlayerWidgetState() : super(); void playVideo(XFile? file) { if (file != null) { Uri? uri = Uri.tryParse(file.path); if (uri != null) { controller = VideoPlayerController.networkUrl(uri); } else { controller = VideoPlayerController.file(File(file.path)); } controller.addListener(onVideoControllerUpdate); controller.initialize().catchError((e) { AlertDialogBox(title: 'controller.initialize() error occurred', desc: e.toString()); }); } } void onVideoControllerUpdate() { if (!mounted) { return; } if (controller.value.isInitialized) { isInitialized = controller.value.isInitialized; controller.setVolume(1.0); controller.setLooping(true); controller.play(); } else { AlertDialogBox(title: 'Video failed to load'); } setState(() { }); } void play() { if (isInitialized) { controller.play(); } } void pause() { if (isInitialized) { controller.pause(); } } void seekTo(Duration position) { if (isInitialized) { controller.seekTo(position); } } void setPlaybackSpeed(double speed) { if (isInitialized) { controller.setPlaybackSpeed(speed); } } void setVolume(double volume) { if (isInitialized) { controller.setVolume(volume); } } void setLooping(bool looping) { if (isInitialized) { controller.setLooping(looping); } } @override void initState() { super.initState(); widget.theState = this; widget.callback!(this); } @override void dispose() { controller.removeListener(onVideoControllerUpdate); super.dispose(); } @override Widget build(BuildContext context) { if (isInitialized) { return Center( child: AspectRatio( aspectRatio: controller.value.aspectRatio, child: VideoPlayer(controller), ), ); } else { return Container(); } } } ``` Main ```dart import 'package:cross_file/cross_file.dart'; import 'package:flutter/material.dart'; import 'video_player_widget.dart'; void main() { runApp(const MyApp()); } class MyApp extends StatelessWidget { const MyApp({super.key}); @override Widget build(BuildContext context) { return MaterialApp( title: 'Flutter Demo', theme: ThemeData( colorScheme: ColorScheme.fromSeed(seedColor: Colors.deepPurple), useMaterial3: true, ), home: const MyHomePage(title: 'Flutter Demo Home Page'), ); } } class MyHomePage extends StatefulWidget { const MyHomePage({super.key, required this.title}); final String title; @override State<MyHomePage> createState() => _MyHomePageState(); } class _MyHomePageState extends State<MyHomePage> { static const String videoPath = 'https://commondatastorage.googleapis.com/gtv-videos-bucket/sample/BigBuckBunny.mp4'; XFile theMovie = XFile(videoPath); VideoPlayerWidget createVideoPlayerWidget() { VideoPlayerWidget videoPlayer = VideoPlayerWidget(key: UniqueKey(), callback: (VideoPlayerWidgetState? theState) { theState!.playVideo(theMovie); }); return videoPlayer; } @override Widget build(BuildContext context) { return Scaffold ( appBar: AppBar ( backgroundColor: Theme.of(context).colorScheme.inversePrimary, title: Text(widget.title), ), body: createVideoPlayerWidget(), ); } } ``` Alert Box ```dart import 'package:flutter/material.dart'; //ignore: must_be_immutable class AlertDialogBox extends StatelessWidget { String title; String desc; AlertDialogBox({super.key, this.title = '', this.desc = ''}) : super(); @override Widget build(BuildContext context) { return TextButton( onPressed: () => showDialog<String>( context: context, builder: (BuildContext context) => AlertDialog( title: Text(title), content: Text(desc), actions: <Widget>[ TextButton( onPressed: () => Navigator.pop(context, 'Cancel'), child: const Text('Cancel'), ), TextButton( onPressed: () => Navigator.pop(context, 'OK'), child: const Text('OK'), ), ], ), ), child: const Text('Show Dialog'), ); } } ``` </details> ### Screenshots or Video <details open> <summary>Screenshots / Video demonstration</summary> [Upload media here] </details> ### Logs <details open><summary>Logs</summary> ```console [Paste your logs here] ``` </details> ### Flutter Doctor output <details open><summary>Doctor output</summary> ```console E:\Dev\Repos\r2d2Proton\videotest>flutter doctor -v [โœ“] Flutter (Channel main, 3.27.0-1.0.pre.582, on Microsoft Windows [Version 10.0.26100.2454], locale en-US) โ€ข Flutter version 3.27.0-1.0.pre.582 on channel main at E:\Dev\flutter โ€ข Upstream repository https://github.com/flutter/flutter.git โ€ข Framework revision 364e4be816 (6 days ago), 2024-11-20 17:10:10 -0500 โ€ข Engine revision 2d32cf3a79 โ€ข Dart version 3.7.0 (build 3.7.0-164.0.dev) โ€ข DevTools version 2.41.0-dev.2 [โœ“] Windows Version (11 Home 64-bit, 24H2, 2009) [โœ“] Android toolchain - develop for Android devices (Android SDK version 35.0.0) โ€ข Android SDK at E:\Dev\Android\Sdk โ€ข Platform android-35, build-tools 35.0.0 โ€ข ANDROID_HOME = E:\Dev\Android\Sdk โ€ข Java binary at: E:\Dev\Android\Android Studio\jbr\bin\java โ€ข Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11) โ€ข All Android licenses accepted. [โœ“] Chrome - develop for the web โ€ข Chrome at C:\Program Files\Google\Chrome\Application\chrome.exe [โœ“] Visual Studio - develop Windows apps (Visual Studio Community 2022 17.11.4) โ€ข Visual Studio at C:\Program Files\Microsoft Visual Studio\2022\Community โ€ข Visual Studio Community 2022 version 17.11.35312.102 โ€ข Windows 10 SDK version 10.0.26100.0 [โœ“] Android Studio (version 2024.2) โ€ข Android Studio at E:\Dev\Android\Android Studio โ€ข Flutter plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/9212-flutter โ€ข Dart plugin can be installed from: ๐Ÿ”จ https://plugins.jetbrains.com/plugin/6351-dart โ€ข Java version OpenJDK Runtime Environment (build 21.0.3+-12282718-b509.11) [โœ“] VS Code (version 1.95.3) โ€ข VS Code at C:\Users\Jerry\AppData\Local\Programs\Microsoft VS Code โ€ข Flutter extension version 3.100.0 [โœ“] Connected device (4 available) โ€ข SHIELD Android TV (mobile) โ€ข 1322224009825 โ€ข android-arm64 โ€ข Android 11 (API 30) โ€ข Windows (desktop) โ€ข windows โ€ข windows-x64 โ€ข Microsoft Windows [Version 10.0.26100.2454] โ€ข Chrome (web) โ€ข chrome โ€ข web-javascript โ€ข Google Chrome 131.0.6778.86 โ€ข Edge (web) โ€ข edge โ€ข web-javascript โ€ข Microsoft Edge 131.0.2903.63 [โœ“] Network resources โ€ข All expected network resources are available. โ€ข No issues found! ``` </details>
e: device-specific,platform-android,p: video_player,package,P3,team-android,triaged-android
low
Critical
2,695,802,111
go
cmd/go: identify tool dependencies in go list / go mod why
### Go version go version devel go1.24-f8dba5f8c1 2024-11-23 01:01:47 +0000 linux/amd64 ### Output of `go env` in your module/workspace: ```shell AR='ar' CC='gcc' CGO_CFLAGS='-O2 -g' CGO_CPPFLAGS='' CGO_CXXFLAGS='-O2 -g' CGO_ENABLED='0' CGO_FFLAGS='-O2 -g' CGO_LDFLAGS='-O2 -g' CXX='g++' GCCGO='gccgo' GO111MODULE='' GOAMD64='v3' GOARCH='amd64' GOAUTH='netrc' GOBIN='' GOCACHE='/home/user/.cache/go-build' GODEBUG='' GOENV='/home/user/.config/go/env' GOEXE='' GOEXPERIMENT='' GOFIPS140='off' GOFLAGS='-trimpath "-ldflags=-s -w" -vet=all' GOGCCFLAGS='-fPIC -m64 -Wl,--no-gc-sections -fmessage-length=0 -ffile-prefix-map=/tmp/go-build4089643650=/tmp/go-build -gno-record-gcc-switches' GOHOSTARCH='amd64' GOHOSTOS='linux' GOINSECURE='' GOMOD='/home/user/code/mono/default/go.mod' GOMODCACHE='/home/user/.data/go/pkg/mod' GONOPROXY='' GONOSUMDB='' GOOS='linux' GOPATH='/home/user/.data/go' GOPRIVATE='' GOPROXY='https://proxy.golang.org,direct' GOROOT='/home/user/sdk/gotip' GOSUMDB='sum.golang.org' GOTELEMETRY='on' GOTELEMETRYDIR='/home/user/.config/go/telemetry' GOTMPDIR='' GOTOOLCHAIN='path' GOTOOLDIR='/home/user/sdk/gotip/pkg/tool/linux_amd64' GOVCS='' GOVERSION='devel go1.24-f8dba5f8c1 2024-11-23 01:01:47 +0000' GOWORK='' PKG_CONFIG='pkg-config' ``` ### What did you do? <details><summary><code>go list -json honnef.co/go/tools/cmd/staticcheck</code></summary> <pre> { "Dir": "/home/user/.data/go/pkg/mod/honnef.co/go/[email protected]/cmd/staticcheck", "ImportPath": "honnef.co/go/tools/cmd/staticcheck", "Name": "main", "Doc": "staticcheck analyses Go code and makes it better.", "Target": "/home/user/.data/go/bin/staticcheck", "Root": "/home/user/.data/go/pkg/mod/honnef.co/go/[email protected]", "Module": { "Path": "honnef.co/go/tools", "Version": "v0.5.1", "Time": "2024-08-14T20:27:15Z", "Indirect": true, "Dir": "/home/user/.data/go/pkg/mod/honnef.co/go/[email protected]", "GoMod": "/home/user/.data/go/pkg/mod/cache/download/honnef.co/go/tools/@v/v0.5.1.mod", "GoVersion": "1.22.1", "Sum": "h1:4bH5o3b5ZULQ4UrBmP+63W9r7qIkqJClEA9ko5YKx+I=", "GoModSum": "h1:e9irvo83WDG9/irijV44wr3tbhcFeRnfpVlRqVwpzMs=" }, "Match": [ "honnef.co/go/tools/cmd/staticcheck" ], "Stale": true, "StaleReason": "stale dependency: internal/saferio", "GoFiles": [ "staticcheck.go" ], "Imports": [ "honnef.co/go/tools/lintcmd", "honnef.co/go/tools/lintcmd/version", "honnef.co/go/tools/quickfix", "honnef.co/go/tools/simple", "honnef.co/go/tools/staticcheck", "honnef.co/go/tools/stylecheck", "honnef.co/go/tools/unused", "log", "os" ], "Deps": [ "bufio", "bytes", "cmp", "compress/flate", "compress/gzip", "compress/zlib", "container/heap", "container/list", "context", "crypto", "crypto/aes", "crypto/cipher", "crypto/des", "crypto/dsa", "crypto/ecdh", "crypto/ecdsa", "crypto/ed25519", "crypto/elliptic", "crypto/hmac", "crypto/internal/boring", "crypto/internal/boring/bbig", "crypto/internal/boring/sig", "crypto/internal/entropy", "crypto/internal/fips140", "crypto/internal/fips140/aes", "crypto/internal/fips140/aes/gcm", "crypto/internal/fips140/alias", "crypto/internal/fips140/bigmod", "crypto/internal/fips140/check", "crypto/internal/fips140/drbg", "crypto/internal/fips140/ecdh", "crypto/internal/fips140/ecdsa", "crypto/internal/fips140/ed25519", "crypto/internal/fips140/edwards25519", "crypto/internal/fips140/edwards25519/field", "crypto/internal/fips140/hkdf", "crypto/internal/fips140/hmac", "crypto/internal/fips140/mlkem", "crypto/internal/fips140/nistec", "crypto/internal/fips140/nistec/fiat", "crypto/internal/fips140/rsa", "crypto/internal/fips140/sha256", "crypto/internal/fips140/sha3", "crypto/internal/fips140/sha512", "crypto/internal/fips140/subtle", "crypto/internal/fips140/tls12", "crypto/internal/fips140/tls13", "crypto/internal/fips140deps/byteorder", "crypto/internal/fips140deps/cpu", "crypto/internal/fips140deps/godebug", "crypto/internal/fips140only", "crypto/internal/hpke", "crypto/internal/impl", "crypto/internal/randutil", "crypto/internal/sysrand", "crypto/md5", "crypto/rand", "crypto/rc4", "crypto/rsa", "crypto/sha1", "crypto/sha256", "crypto/sha512", "crypto/subtle", "crypto/tls", "crypto/tls/internal/fips140tls", "crypto/x509", "crypto/x509/pkix", "debug/dwarf", "debug/elf", "debug/macho", "encoding", "encoding/asn1", "encoding/base64", "encoding/binary", "encoding/gob", "encoding/hex", "encoding/json", "encoding/pem", "errors", "flag", "fmt", "github.com/BurntSushi/toml", "github.com/BurntSushi/toml/internal", "go/ast", "go/build", "go/build/constraint", "go/constant", "go/doc", "go/doc/comment", "go/format", "go/parser", "go/printer", "go/scanner", "go/token", "go/types", "go/version", "golang.org/x/exp/typeparams", "golang.org/x/mod/semver", "golang.org/x/sync/errgroup", "golang.org/x/tools/go/analysis", "golang.org/x/tools/go/analysis/passes/inspect", "golang.org/x/tools/go/ast/astutil", "golang.org/x/tools/go/ast/inspector", "golang.org/x/tools/go/buildutil", "golang.org/x/tools/go/gcexportdata", "golang.org/x/tools/go/internal/cgo", "golang.org/x/tools/go/loader", "golang.org/x/tools/go/packages", "golang.org/x/tools/go/types/objectpath", "golang.org/x/tools/go/types/typeutil", "golang.org/x/tools/internal/aliases", "golang.org/x/tools/internal/event", "golang.org/x/tools/internal/event/core", "golang.org/x/tools/internal/event/keys", "golang.org/x/tools/internal/event/label", "golang.org/x/tools/internal/gcimporter", "golang.org/x/tools/internal/gocommand", "golang.org/x/tools/internal/packagesinternal", "golang.org/x/tools/internal/pkgbits", "golang.org/x/tools/internal/stdlib", "golang.org/x/tools/internal/typeparams", "golang.org/x/tools/internal/typesinternal", "golang.org/x/tools/internal/versions", "hash", "hash/adler32", "hash/crc32", "honnef.co/go/tools/analysis/callcheck", "honnef.co/go/tools/analysis/code", "honnef.co/go/tools/analysis/edit", "honnef.co/go/tools/analysis/facts/deprecated", "honnef.co/go/tools/analysis/facts/directives", "honnef.co/go/tools/analysis/facts/generated", "honnef.co/go/tools/analysis/facts/nilness", "honnef.co/go/tools/analysis/facts/purity", "honnef.co/go/tools/analysis/facts/tokenfile", "honnef.co/go/tools/analysis/facts/typedness", "honnef.co/go/tools/analysis/lint", "honnef.co/go/tools/analysis/report", "honnef.co/go/tools/config", "honnef.co/go/tools/go/ast/astutil", "honnef.co/go/tools/go/buildid", "honnef.co/go/tools/go/ir", "honnef.co/go/tools/go/ir/irutil", "honnef.co/go/tools/go/loader", "honnef.co/go/tools/go/types/typeutil", "honnef.co/go/tools/internal/passes/buildir", "honnef.co/go/tools/internal/renameio", "honnef.co/go/tools/internal/robustio", "honnef.co/go/tools/internal/sharedcheck", "honnef.co/go/tools/internal/sync", "honnef.co/go/tools/knowledge", "honnef.co/go/tools/lintcmd", "honnef.co/go/tools/lintcmd/cache", "honnef.co/go/tools/lintcmd/runner", "honnef.co/go/tools/lintcmd/version", "honnef.co/go/tools/pattern", "honnef.co/go/tools/printf", "honnef.co/go/tools/quickfix", "honnef.co/go/tools/quickfix/qf1001", "honnef.co/go/tools/quickfix/qf1002", "honnef.co/go/tools/quickfix/qf1003", "honnef.co/go/tools/quickfix/qf1004", "honnef.co/go/tools/quickfix/qf1005", "honnef.co/go/tools/quickfix/qf1006", "honnef.co/go/tools/quickfix/qf1007", "honnef.co/go/tools/quickfix/qf1008", "honnef.co/go/tools/quickfix/qf1009", "honnef.co/go/tools/quickfix/qf1010", "honnef.co/go/tools/quickfix/qf1011", "honnef.co/go/tools/quickfix/qf1012", "honnef.co/go/tools/sarif", "honnef.co/go/tools/simple", "honnef.co/go/tools/simple/s1000", "honnef.co/go/tools/simple/s1001", "honnef.co/go/tools/simple/s1002", "honnef.co/go/tools/simple/s1003", "honnef.co/go/tools/simple/s1004", "honnef.co/go/tools/simple/s1005", "honnef.co/go/tools/simple/s1006", "honnef.co/go/tools/simple/s1007", "honnef.co/go/tools/simple/s1008", "honnef.co/go/tools/simple/s1009", "honnef.co/go/tools/simple/s1010", "honnef.co/go/tools/simple/s1011", "honnef.co/go/tools/simple/s1012", "honnef.co/go/tools/simple/s1016", "honnef.co/go/tools/simple/s1017", "honnef.co/go/tools/simple/s1018", "honnef.co/go/tools/simple/s1019", "honnef.co/go/tools/simple/s1020", "honnef.co/go/tools/simple/s1021", "honnef.co/go/tools/simple/s1023", "honnef.co/go/tools/simple/s1024", "honnef.co/go/tools/simple/s1025", "honnef.co/go/tools/simple/s1028", "honnef.co/go/tools/simple/s1029", "honnef.co/go/tools/simple/s1030", "honnef.co/go/tools/simple/s1031", "honnef.co/go/tools/simple/s1032", "honnef.co/go/tools/simple/s1033", "honnef.co/go/tools/simple/s1034", "honnef.co/go/tools/simple/s1035", "honnef.co/go/tools/simple/s1036", "honnef.co/go/tools/simple/s1037", "honnef.co/go/tools/simple/s1038", "honnef.co/go/tools/simple/s1039", "honnef.co/go/tools/simple/s1040", "honnef.co/go/tools/staticcheck", "honnef.co/go/tools/staticcheck/fakejson", "honnef.co/go/tools/staticcheck/fakereflect", "honnef.co/go/tools/staticcheck/fakexml", "honnef.co/go/tools/staticcheck/sa1000", "honnef.co/go/tools/staticcheck/sa1001", "honnef.co/go/tools/staticcheck/sa1002", "honnef.co/go/tools/staticcheck/sa1003", "honnef.co/go/tools/staticcheck/sa1004", "honnef.co/go/tools/staticcheck/sa1005", "honnef.co/go/tools/staticcheck/sa1006", "honnef.co/go/tools/staticcheck/sa1007", "honnef.co/go/tools/staticcheck/sa1008", "honnef.co/go/tools/staticcheck/sa1010", "honnef.co/go/tools/staticcheck/sa1011", "honnef.co/go/tools/staticcheck/sa1012", "honnef.co/go/tools/staticcheck/sa1013", "honnef.co/go/tools/staticcheck/sa1014", "honnef.co/go/tools/staticcheck/sa1015", "honnef.co/go/tools/staticcheck/sa1016", "honnef.co/go/tools/staticcheck/sa1017", "honnef.co/go/tools/staticcheck/sa1018", "honnef.co/go/tools/staticcheck/sa1019", "honnef.co/go/tools/staticcheck/sa1020", "honnef.co/go/tools/staticcheck/sa1021", "honnef.co/go/tools/staticcheck/sa1023", "honnef.co/go/tools/staticcheck/sa1024", "honnef.co/go/tools/staticcheck/sa1025", "honnef.co/go/tools/staticcheck/sa1026", "honnef.co/go/tools/staticcheck/sa1027", "honnef.co/go/tools/staticcheck/sa1028", "honnef.co/go/tools/staticcheck/sa1029", "honnef.co/go/tools/staticcheck/sa1030", "honnef.co/go/tools/staticcheck/sa1031", "honnef.co/go/tools/staticcheck/sa1032", "honnef.co/go/tools/staticcheck/sa2000", "honnef.co/go/tools/staticcheck/sa2001", "honnef.co/go/tools/staticcheck/sa2002", "honnef.co/go/tools/staticcheck/sa2003", "honnef.co/go/tools/staticcheck/sa3000", "honnef.co/go/tools/staticcheck/sa3001", "honnef.co/go/tools/staticcheck/sa4000", "honnef.co/go/tools/staticcheck/sa4001", "honnef.co/go/tools/staticcheck/sa4003", "honnef.co/go/tools/staticcheck/sa4004", "honnef.co/go/tools/staticcheck/sa4005", "honnef.co/go/tools/staticcheck/sa4006", "honnef.co/go/tools/staticcheck/sa4008", "honnef.co/go/tools/staticcheck/sa4009", "honnef.co/go/tools/staticcheck/sa4010", "honnef.co/go/tools/staticcheck/sa4011", "honnef.co/go/tools/staticcheck/sa4012", "honnef.co/go/tools/staticcheck/sa4013", "honnef.co/go/tools/staticcheck/sa4014", "honnef.co/go/tools/staticcheck/sa4015", "honnef.co/go/tools/staticcheck/sa4016", "honnef.co/go/tools/staticcheck/sa4017", "honnef.co/go/tools/staticcheck/sa4018", "honnef.co/go/tools/staticcheck/sa4019", "honnef.co/go/tools/staticcheck/sa4020", "honnef.co/go/tools/staticcheck/sa4021", "honnef.co/go/tools/staticcheck/sa4022", "honnef.co/go/tools/staticcheck/sa4023", "honnef.co/go/tools/staticcheck/sa4024", "honnef.co/go/tools/staticcheck/sa4025", "honnef.co/go/tools/staticcheck/sa4026", "honnef.co/go/tools/staticcheck/sa4027", "honnef.co/go/tools/staticcheck/sa4028", "honnef.co/go/tools/staticcheck/sa4029", "honnef.co/go/tools/staticcheck/sa4030", "honnef.co/go/tools/staticcheck/sa4031", "honnef.co/go/tools/staticcheck/sa4032", "honnef.co/go/tools/staticcheck/sa5000", "honnef.co/go/tools/staticcheck/sa5001", "honnef.co/go/tools/staticcheck/sa5002", "honnef.co/go/tools/staticcheck/sa5003", "honnef.co/go/tools/staticcheck/sa5004", "honnef.co/go/tools/staticcheck/sa5005", "honnef.co/go/tools/staticcheck/sa5007", "honnef.co/go/tools/staticcheck/sa5008", "honnef.co/go/tools/staticcheck/sa5009", "honnef.co/go/tools/staticcheck/sa5010", "honnef.co/go/tools/staticcheck/sa5011", "honnef.co/go/tools/staticcheck/sa5012", "honnef.co/go/tools/staticcheck/sa6000", "honnef.co/go/tools/staticcheck/sa6001", "honnef.co/go/tools/staticcheck/sa6002", "honnef.co/go/tools/staticcheck/sa6003", "honnef.co/go/tools/staticcheck/sa6005", "honnef.co/go/tools/staticcheck/sa6006", "honnef.co/go/tools/staticcheck/sa9001", "honnef.co/go/tools/staticcheck/sa9002", "honnef.co/go/tools/staticcheck/sa9003", "honnef.co/go/tools/staticcheck/sa9004", "honnef.co/go/tools/staticcheck/sa9005", "honnef.co/go/tools/staticcheck/sa9006", "honnef.co/go/tools/staticcheck/sa9007", "honnef.co/go/tools/staticcheck/sa9008", "honnef.co/go/tools/staticcheck/sa9009", "honnef.co/go/tools/stylecheck", "honnef.co/go/tools/stylecheck/st1000", "honnef.co/go/tools/stylecheck/st1001", "honnef.co/go/tools/stylecheck/st1003", "honnef.co/go/tools/stylecheck/st1005", "honnef.co/go/tools/stylecheck/st1006", "honnef.co/go/tools/stylecheck/st1008", "honnef.co/go/tools/stylecheck/st1011", "honnef.co/go/tools/stylecheck/st1012", "honnef.co/go/tools/stylecheck/st1013", "honnef.co/go/tools/stylecheck/st1015", "honnef.co/go/tools/stylecheck/st1016", "honnef.co/go/tools/stylecheck/st1017", "honnef.co/go/tools/stylecheck/st1018", "honnef.co/go/tools/stylecheck/st1019", "honnef.co/go/tools/stylecheck/st1020", "honnef.co/go/tools/stylecheck/st1021", "honnef.co/go/tools/stylecheck/st1022", "honnef.co/go/tools/stylecheck/st1023", "honnef.co/go/tools/unused", "html", "html/template", "internal/abi", "internal/asan", "internal/bisect", "internal/buildcfg", "internal/bytealg", "internal/byteorder", "internal/chacha8rand", "internal/coverage/rtcov", "internal/cpu", "internal/filepathlite", "internal/fmtsort", "internal/goarch", "internal/godebug", "internal/godebugs", "internal/goexperiment", "internal/goos", "internal/goroot", "internal/gover", "internal/goversion", "internal/itoa", "internal/lazyregexp", "internal/msan", "internal/nettrace", "internal/oserror", "internal/platform", "internal/poll", "internal/profilerecord", "internal/race", "internal/reflectlite", "internal/runtime/atomic", "internal/runtime/exithook", "internal/runtime/maps", "internal/runtime/math", "internal/runtime/sys", "internal/runtime/syscall", "internal/saferio", "internal/singleflight", "internal/stringslite", "internal/sync", "internal/syscall/execenv", "internal/syscall/unix", "internal/syslist", "internal/testlog", "internal/types/errors", "internal/unsafeheader", "internal/zstd", "io", "io/fs", "io/ioutil", "iter", "log", "log/internal", "maps", "math", "math/big", "math/bits", "math/rand", "math/rand/v2", "mime", "mime/multipart", "mime/quotedprintable", "net", "net/http", "net/http/httptrace", "net/http/internal", "net/http/internal/ascii", "net/netip", "net/textproto", "net/url", "os", "os/exec", "os/signal", "path", "path/filepath", "reflect", "regexp", "regexp/syntax", "runtime", "runtime/debug", "runtime/pprof", "runtime/trace", "slices", "sort", "strconv", "strings", "sync", "sync/atomic", "syscall", "text/tabwriter", "text/template", "text/template/parse", "time", "unicode", "unicode/utf16", "unicode/utf8", "unique", "unsafe", "vendor/golang.org/x/crypto/chacha20", "vendor/golang.org/x/crypto/chacha20poly1305", "vendor/golang.org/x/crypto/cryptobyte", "vendor/golang.org/x/crypto/cryptobyte/asn1", "vendor/golang.org/x/crypto/internal/alias", "vendor/golang.org/x/crypto/internal/poly1305", "vendor/golang.org/x/net/dns/dnsmessage", "vendor/golang.org/x/net/http/httpguts", "vendor/golang.org/x/net/http/httpproxy", "vendor/golang.org/x/net/http2/hpack", "vendor/golang.org/x/net/idna", "vendor/golang.org/x/sys/cpu", "vendor/golang.org/x/text/secure/bidirule", "vendor/golang.org/x/text/transform", "vendor/golang.org/x/text/unicode/bidi", "vendor/golang.org/x/text/unicode/norm", "weak" ] } </pre> </details> <details><summary><code>go list -m -json honnef.co/go/tools</code></summary> <pre> { "Path": "honnef.co/go/tools", "Version": "v0.5.1", "Time": "2024-08-14T20:27:15Z", "Indirect": true, "Dir": "/home/user/.data/go/pkg/mod/honnef.co/go/[email protected]", "GoMod": "/home/user/.data/go/pkg/mod/cache/download/honnef.co/go/tools/@v/v0.5.1.mod", "GoVersion": "1.22.1", "Sum": "h1:4bH5o3b5ZULQ4UrBmP+63W9r7qIkqJClEA9ko5YKx+I=", "GoModSum": "h1:e9irvo83WDG9/irijV44wr3tbhcFeRnfpVlRqVwpzMs=" } </pre> </details> A tool dependency shows no relation to the main module ```sh $ go mod why honnef.co/go/tools/cmd/staticcheck # honnef.co/go/tools/cmd/staticcheck honnef.co/go/tools/cmd/staticcheck $ go mod why -m honnef.co/go/tools # honnef.co/go/tools honnef.co/go/tools/cmd/staticcheck ``` Compared to a direct dependency ```sh $ go mod why golang.org/x/sync/errgroup # golang.org/x/sync/errgroup go.seankhliao.com/mono/yrun golang.org/x/sync/errgroup $ go mod why -m golang.org/x/sync # golang.org/x/sync go.seankhliao.com/mono/yrun golang.org/x/sync/errgroup ``` But it is listed as a dependency edge in the module graph: ```sh $ go mod graph | grep honnef.co/go/tools go.seankhliao.com/mono honnef.co/go/[email protected] # ... omitted ... ``` ### What did you see happen? I think tool dependencies are not consistently represented in `go mod graph`, `go mod why`, `go list` output. And there's no way to identify whether a package / module is a tool dependency (except maybe checking against `go list tool`). ### What did you expect to see? Not sure if it should be consistently directly linked or detached from the main module. And some attribute in the package to identify it being pulled in as a tool.
NeedsInvestigation,GoCommand
low
Critical
2,695,808,797
vscode
search.action.focusFilesToExclude and Include not working
<!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- ๐Ÿ•ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- ๐Ÿ”Ž Search existing issues to avoid creating duplicates. --> <!-- ๐Ÿงช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- ๐Ÿ’ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- ๐Ÿ”ง Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes/ <!-- ๐Ÿช“ If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- ๐Ÿ“ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - VS Code Version: 1.95.3 - OS Version: linux mint mate 21.3 Version: 1.95.3 Commit: https://github.com/microsoft/vscode/commit/f1a4fb101478ce6ec82fe9627c43efbf9e98c813 Date: 2024-11-13T14:50:04.152Z Electron: 32.2.1 ElectronBuildId: 10427718 Chromium: 128.0.6613.186 Node.js: 20.18.0 V8: 12.8.374.38-electron.0 OS: Linux x64 5.15.0-126-generic __Issue__ search.action.focusFilesToExclude and search.action.focusFilesToInclude not working ( the relevant inputboxes are not getting highlighted ) checked by key binding these action items __Steps to Reproduce:__ 1. Assign keybindings alt + I and alt + O to search.action.focusFilesToInclude and search.action.focusFilesToExclude 2. set when expression for both as 'searchInputBoxFocus || searchViewletFocus' 3. now in search side bar pane focused, either focus in inputbox or the result area, trigger the newly set keybindings to focus the include or exclude input boxes. We see no transfer of focus to these input boxes. When checked with developer: keyboard shortcuts troubleshooting the keybindings do get triggered, but relevant action is not executed. __Additionally,__ only action item is present to focus these 2 include & exclude boxes there is __NO when clause__ items to check while triggering keybindings focusFilesToInclude & focusFilesToExclude
bug,search-editor
low
Critical
2,695,878,703
PowerToys
Video Cut/Trim
### Description of the new feature / enhancement I got no idea why this isn't already a default windows feature, to simply cut/trim videos. And when I tried using some applications, they either put a watermark over my video, significantly lowered the quality, or are a general nuisance that requires 5 steps to use and requires waiting for minutes. There is no way that cutting/trimming a video is that software heavy, since my phone can do it in a couple of seconds and with longer videos. This would be extremely helpful, thanks! ### Scenario when this would be used? Simple video trimming, I use AMD replay record, that automatically records last 1 and a half minutes of my screen and audio and upon pressing a shortcut I am able to save a video of the last minute and a half, of course more often then not I do not need that much time, but I don't want to lower it in case I do need it and lose the funny moment forever. I actually end up sending the videos to my phone via discord or mail (if they are too large) just to trim them, and send them back. This way I could do that in a matter of seconds. ### Supporting information I feel that I explained the scene enough, as for other people I heard my friends complain about it.
Needs-Triage
low
Minor
2,695,886,066
godot
ResourceLoader crash loading CompressedTexture2D on Android
### Tested versions This crash is reported to us via sentry.io from a released Godot 4.3 game. The crash only happens on android devices, it does not happen on windows or ios. We haven't been able to reproduce on our android devices though ### System information Android (12,13,14,15) - Godot 4.3 - Compatibility ### Issue description ``` Application Specific Information: Segfault Thread 0 Crashed: 0 libc.so 0x725c11ccf8 <unknown> + 491170942200 1 libutils.so 0x72609255f8 android::FileMap::~FileMap 2 libandroidfw.so 0x72612acdb0 android::incfs::IncFsFileMap::~IncFsFileMap 3 libandroidfw.so 0x726125dcb0 android::_FileAsset::~_FileAsset 4 libandroidfw.so 0x726125dd40 android::_FileAsset::~_FileAsset 5 libandroid.so 0x71a6426424 AAsset_close 6 split_config.arm64_v8a.apk 0x70728fe1a4 [inlined] FileAccessAndroid::_close (file_access_android.cpp:77) 7 split_config.arm64_v8a.apk 0x70728fe1a4 FileAccessAndroid::~FileAccessAndroid (file_access_android.cpp:262) 8 split_config.arm64_v8a.apk 0x7073e6b9bc [inlined] memdelete<T> (memory.h:116) 9 split_config.arm64_v8a.apk 0x7073e6b9bc [inlined] Ref<T>::unref (ref_counted.h:210) 10 split_config.arm64_v8a.apk 0x7073e6b9bc [inlined] Ref<T>::~Ref (ref_counted.h:223) 11 split_config.arm64_v8a.apk 0x7073e6b9bc CompressedTexture2D::_load_data (compressed_texture.cpp:89) 12 split_config.arm64_v8a.apk 0x7073e6c8c4 CompressedTexture2D::load (compressed_texture.cpp:138) 13 split_config.arm64_v8a.apk 0x7073e6d630 ResourceFormatLoaderCompressedTexture2D::load (compressed_texture.cpp:472) 14 split_config.arm64_v8a.apk 0x7074cd0e48 ResourceLoader::_load (resource_loader.cpp:269) 15 split_config.arm64_v8a.apk 0x7074cc93b0 ResourceFormatImporter::load (resource_importer.cpp:151) 16 split_config.arm64_v8a.apk 0x7074cd0e48 ResourceLoader::_load (resource_loader.cpp:269) 17 split_config.arm64_v8a.apk 0x7074cd1748 ResourceLoader::_thread_load_function (resource_loader.cpp:323) 18 split_config.arm64_v8a.apk 0x7074cd2c6c ResourceLoader::_load_start (resource_loader.cpp:543) 19 split_config.arm64_v8a.apk 0x7074cb5b48 ResourceLoaderBinary::load (resource_format_binary.cpp:701) 20 split_config.arm64_v8a.apk 0x7074cba238 ResourceFormatLoaderBinary::load (resource_format_binary.cpp:1240) 21 split_config.arm64_v8a.apk 0x7074cd0e48 ResourceLoader::_load (resource_loader.cpp:269) 22 split_config.arm64_v8a.apk 0x7074cd1748 ResourceLoader::_thread_load_function (resource_loader.cpp:323) 23 split_config.arm64_v8a.apk 0x707503f7d8 WorkerThreadPool::_process_task (worker_thread_pool.cpp:140) 24 split_config.arm64_v8a.apk 0x70750404e8 WorkerThreadPool::_thread_function (worker_thread_pool.cpp:205) 25 split_config.arm64_v8a.apk 0x7074aed1c8 Thread::callback (thread.cpp:64) 26 split_config.arm64_v8a.apk 0x7074aed4f8 [inlined] std::__ndk1::__invoke<T> (type_traits:3874) 27 split_config.arm64_v8a.apk 0x7074aed4f8 [inlined] std::__ndk1::__thread_execute<T> (thread:273) 28 split_config.arm64_v8a.apk 0x7074aed4f8 std::__ndk1::__thread_proxy<T> (thread:284) 29 libc.so 0x725c1c8d5c <unknown> + 491171646812 30 libc.so 0x725c15cbc0 <unknown> + 491171204032 ``` ### Steps to reproduce In C++ we call ResourceLoader::load_threaded_request() 5 times in a row to pre-load some simple scenes that contains a few Sprite2D and CPUParticles2D. I haven't been able to reproduce though. I'm assuming it has something to do with the timing of the worker threads calling AAssetManager_open and AAsset_close. I'm hoping maybe it just needs some checks or a mutex to prevent. ### Minimal reproduction project (MRP) Sorry I couldn't come up with a repro project.
bug,topic:core,needs testing,crash
low
Critical
2,695,892,170
go
x/tools/gopls: feature: "move declaration" refactoring
A generalization of renaming a symbol X to Y is to rename X to otherpkg.Y, causing the declaration of X, along with any necessary supporting declarations, to be moved into some file in the designated other package. There are a fair number of edge cases to consider, and UI questions such as how best to obtain the name of otherpkg: the only current LSP operation that supports dialog is Rename, which rather forces our hand. (Another possibility is to use the web interface, which could give a rich interactive menu of which declarations should be moved and optionally renamed at the same time.)
FeatureRequest,gopls,Tools,Refactoring
low
Major
2,695,902,166
rust
Tracking Issue for `slice_as_array`
Feature gate: `#![feature(slice_as_array)]` This is a tracking issue for adding conversion functions from slices to arrays. ### Public API ```rust impl<T> [T] { pub const fn as_array<const N: usize>(&self) -> Option<&[T; N]>; pub const fn as_mut_array<const N: usize>(&mut self) -> Option<&mut [T; N]>; } impl<T> *const [T] { pub const fn as_array<const N: usize>(self) -> Option<*const [T; N]>; } impl<T> *mut [T] { pub const fn as_mut_array<const N: usize>(self) -> Option<*mut [T; N]>; } // alloc::boxed impl<T> Box<[T]> { pub fn into_array<const N: usize>(self) -> Option<Box<[T; N]>>; } // alloc::rc impl<T> Rc<[T]> { pub fn into_array<const N: usize>(self) -> Option<Rc<[T; N]>>; } // alloc::sync impl<T> Arc<[T]> { pub fn into_array<const N: usize>(self) -> Option<Arc<[T; N]>>; } ``` ### Steps / History - [x] API change proposal (ACP): [#496](https://github.com/rust-lang/libs-team/issues/496/) - [x] Implementation for `[T]`, `*const [T]`, and `*mut [T]`: #133512 - [x] Fix docs for `<[T]>::as_array`: #133743 - [x] Implementation for `Box<[T]>`, `Rc<[T]>`, and `Arc<[T]>`: #134379 - [ ] Final comment period (FCP) - [ ] Stabilization PR ### Unresolved Questions - `const`-compatible for the non-primitive types? - `Option` or `Result` for the owning conversions? - Implementation for `Mutex` and `RwLock`?
T-libs-api,C-tracking-issue
low
Major
2,695,924,042
electron
Bugs filed against nightlies get `blocked/need-info โŒ` label
### Preflight Checklist - [x] I have read the [Contributing Guidelines](https://github.com/electron/electron/blob/main/CONTRIBUTING.md) for this project. - [x] I agree to follow the [Code of Conduct](https://github.com/electron/electron/blob/main/CODE_OF_CONDUCT.md) that this project adheres to. - [x] I have searched the [issue tracker](https://www.github.com/electron/electron/issues) for a bug report that matches the one I want to file, without success. ### Electron Version 33.2.0 ### What operating system(s) are you using? macOS ### Operating System Version macOS Sequioa 15.1.1 ### What arch are you using? arm64 (including Apple Silicon) ### Last Known Working Electron version _No response_ ### Expected Behavior A bug filed against the current Electron nightly version does not get tagged with [blocked/need-info โŒ](https://github.com/electron/electron/labels/blocked%2Fneed-info%20%E2%9D%8C). In the best possible case, it would get tagged with whatever the tag for the version is. ### Actual Behavior The Electron issue triage bot assigns the [blocked/need-info โŒ](https://github.com/electron/electron/labels/blocked%2Fneed-info%20%E2%9D%8C) label. See #44849 as an example. ### Testcase Gist URL _No response_ ### Additional Information _No response_
bug :beetle:,status/confirmed
low
Critical
2,695,938,684
storybook
[Bug]: Vue code snippets incorrect after 8.3
### Describe the bug After updating to anything past 8.3, most of our autodoc code snippets are incorrect and can no longer be copied/pasted. Here is a very simple example: Prior to 8.3 ![Image](https://github.com/user-attachments/assets/62a3ffe9-2a34-4141-8323-70b75ee77d33) After 8.3 ![Image](https://github.com/user-attachments/assets/0a8333e7-cb8b-4971-adfa-cab59a1d5a1b) The issue is that for some of our stories, we are simply passing Vuetify components into the story and documenting how we want them used internally rather that exporting our own components. For some reason, the code snippets are replacing the code we wrote and rewriting it using a component that doesn't actually exist (in this case `v-btn` changes to `Button`). I suspect this comes from the Vue code snippet improvements done in this [PR](https://github.com/storybookjs/storybook/pull/27194), but I haven't been able to figure out a way to get around it without simply downgrading to 8.2.9. If there is a config or some other option that I'm missing, I'd love to hear it. ### Reproduction link https://stackblitz.com/edit/github-d6xn5f?file=.storybook%2Fmain.ts ### Reproduction steps 1. In the Preview pane, open the Show Code panel 2. You'll see that the code shows `Button` instead of `v-btn` ### System ```bash Storybook Environment Info: System: OS: macOS 14.6.1 CPU: (16) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz Shell: 5.9 - /bin/zsh Binaries: Node: 20.12.1 - ~/.nvm/versions/node/v20.12.1/bin/node Yarn: 1.22.19 - /usr/local/bin/yarn npm: 10.9.1 - ~/source/shared-components/node_modules/.bin/npm <----- active pnpm: 9.9.0 - ~/.nvm/versions/node/v20.12.1/bin/pnpm Browsers: Chrome: 131.0.6778.86 Safari: 18.1 npmPackages: @storybook/addon-a11y: ^8.4.5 => 8.4.5 @storybook/addon-designs: ^8.0.4 => 8.0.4 @storybook/addon-essentials: ^8.4.5 => 8.4.5 @storybook/addon-interactions: ^8.4.5 => 8.4.5 @storybook/addon-links: ^8.4.5 => 8.4.5 @storybook/addon-themes: ^8.4.5 => 8.4.5 @storybook/addon-viewport: ^8.4.5 => 8.4.5 @storybook/blocks: ^8.4.5 => 8.4.5 @storybook/test: ^8.4.5 => 8.4.5 @storybook/vue3: ^8.4.5 => 8.4.5 @storybook/vue3-vite: ^8.4.5 => 8.4.5 chromatic: ^11.18.1 => 11.18.1 eslint-plugin-storybook: ^0.11.1 => 0.11.1 storybook: ^8.4.5 => 8.4.5 ``` ### Additional context _No response_
bug,vue3,upgrade:8.3
low
Critical
2,695,967,824
vscode
Command copied from fish shell gets line wrap
<!-- โš ๏ธโš ๏ธ Do Not Delete This! bug_report_template โš ๏ธโš ๏ธ --> <!-- Please read our Rules of Conduct: https://opensource.microsoft.com/codeofconduct/ --> <!-- ๐Ÿ•ฎ Read our guide about submitting issues: https://github.com/microsoft/vscode/wiki/Submitting-Bugs-and-Suggestions --> <!-- ๐Ÿ”Ž Search existing issues to avoid creating duplicates. --> <!-- ๐Ÿงช Test using the latest Insiders build to see if your issue has already been fixed: https://code.visualstudio.com/insiders/ --> <!-- ๐Ÿ’ก Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --> <!-- ๐Ÿ”ง Launch with `code --disable-extensions` to check. --> Does this issue occur when all extensions are disabled?: Yes <!-- ๐Ÿช“ If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --> <!-- ๐Ÿ“ฃ Issues caused by an extension need to be reported directly to the extension publisher. The 'Help > Report Issue' dialog can assist with this. --> - VS Code Version: 1.95.3 - OS Version: Arch Linux, GNOME 47 Steps to Reproduce: 1. Prepare a very long command in terminal. 2. Select the command, Copy, and Paste into a file. ![Image](https://github.com/user-attachments/assets/0c9063c5-c202-4fce-b713-5408c1faac1f)
bug,terminal-shell-fish
low
Critical
2,695,991,729
ollama
Support for Nvidia Hymba
It would be great to support Hymba in Ollama! https://developer.nvidia.com/blog/hymba-hybrid-head-architecture-boosts-small-language-model-performance/
model request
low
Major
2,696,042,630
langchain
Calling Chroma.from_documents() returns sqlite3.DatabaseError: database disk image is malformed
### Checked other resources - [X] I added a very descriptive title to this issue. - [X] I searched the LangChain documentation with the integrated search. - [X] I used the GitHub search to find a similar question and didn't find it. - [X] I am sure that this is a bug in LangChain rather than my code. - [X] The bug is not resolved by updating to the latest stable version of LangChain (or the specific integration package). ### Example Code Below is the sample code ``` class PromptOperator: def embed_documents(self, text): try: token_provider = get_bearer_token_provider(DefaultAzureCredential(), "https://cognitiveservices.azure.com/.default") except Exception as e: print(f"\033[91mError getting token provider: {e}\033[0m") sys.exit(1) client = AzureOpenAI( azure_endpoint = API_BASE, azure_ad_token_provider=token_provider, api_version = VERSION, ) response = client.embeddings.create(input = text, model= "text-embedding-3-small") results = [emb.embedding for emb in response.data] return results def embed_query(self, text): result = self.embed_documents([text]) return result[0] po = PromptOperator() EMBEDDING_FUNCTION = po vector_db_path = Path(db_directory_path) / "context_vector_db" if vector_db_path.exists(): os.system(f"rm -r {vector_db_path}") time.sleep(5) vector_db_path.mkdir(exist_ok=True) set_permissions(str(vector_db_path), 0o755) Chroma.from_documents(docs, EMBEDDING_FUNCTION, persist_directory=str(vector_db_path)) ``` docs looks something like this ```[Document(metadata={'table_name': 'account', 'original_column_name': 'account_id', 'column_name': 'account id', 'column_description': 'the id of the account', 'value_description': ''}, page_content='account id'), Document(metadata={'table_name': 'account', 'original_column_name': 'account_id', 'column_name': 'account id', 'column_description': 'the id of the account', 'value_description': ''}, page_content='the id of the account'), ...]``` Lastly, here is a dump of the current packages installed. I am also on **sqlite3.version=3.45.3** Package Version ---------------------------------------- ----------- aiohappyeyeballs 2.4.3 aiohttp 3.11.7 aiosignal 1.3.1 aiosqlite 0.20.0 annotated-types 0.7.0 anthropic 0.39.0 anyio 4.6.2.post1 asgiref 3.8.1 asttokens 2.4.1 attrs 24.2.0 azure-core 1.32.0 azure-identity 1.19.0 azure-storage-blob 12.24.0 backcall 0.2.0 backoff 2.2.1 bcrypt 4.2.1 beautifulsoup4 4.12.3 bleach 6.2.0 build 1.2.2.post1 cachetools 5.5.0 certifi 2024.8.30 cffi 1.17.1 charset-normalizer 3.4.0 chroma-hnswlib 0.7.6 chromadb 0.5.20 click 8.1.7 coloredlogs 15.0.1 comm 0.2.2 cryptography 43.0.3 dataclasses-json 0.6.7 datasets 3.1.0 datasketch 1.6.5 debugpy 1.8.9 decorator 5.1.1 defusedxml 0.7.1 Deprecated 1.2.15 dill 0.3.8 distro 1.9.0 docopt 0.6.2 docstring_parser 0.16 durationpy 0.9 executing 2.1.0 faiss-cpu 1.9.0.post1 fastapi 0.115.5 fastjsonschema 2.20.0 filelock 3.16.1 flatbuffers 24.3.25 frozenlist 1.5.0 fsspec 2024.9.0 func_timeout 4.3.5 google-ai-generativelanguage 0.6.10 google-api-core 2.23.0 google-api-python-client 2.154.0 google-auth 2.36.0 google-auth-httplib2 0.2.0 google-cloud-aiplatform 1.73.0 google-cloud-bigquery 3.27.0 google-cloud-core 2.4.1 google-cloud-resource-manager 1.13.1 google-cloud-storage 2.18.2 google-crc32c 1.6.0 google-generativeai 0.8.3 google-resumable-media 2.7.2 googleapis-common-protos 1.66.0 greenlet 3.1.1 grpc-google-iam-v1 0.13.1 grpcio 1.68.0 grpcio-status 1.68.0 h11 0.14.0 httpcore 1.0.7 httplib2 0.22.0 httptools 0.6.4 httpx 0.27.2 httpx-sse 0.4.0 huggingface-hub 0.26.2 humanfriendly 10.0 idna 3.10 importlib_metadata 8.5.0 importlib_resources 6.4.5 ipykernel 6.29.5 ipython 8.12.3 isodate 0.7.2 jedi 0.19.2 Jinja2 3.1.4 jiter 0.7.1 joblib 1.4.2 jsonpatch 1.33 jsonpointer 3.0.0 jsonschema 4.23.0 jsonschema-specifications 2024.10.1 jupyter_client 8.6.3 jupyter_core 5.7.2 jupyterlab_pygments 0.3.0 kubernetes 31.0.0 langchain 0.3.8 langchain-anthropic 0.3.0 langchain-chroma 0.1.4 langchain-community 0.3.8 langchain-core 0.3.21 langchain-google-genai 2.0.5 langchain-google-vertexai 2.0.7 langchain-openai 0.2.10 langchain-text-splitters 0.3.2 langgraph 0.2.53 langgraph-checkpoint 2.0.6 langgraph-sdk 0.1.36 langsmith 0.1.146 markdown-it-py 3.0.0 MarkupSafe 3.0.2 marshmallow 3.23.1 matplotlib-inline 0.1.7 mdurl 0.1.2 mistune 3.0.2 mmh3 5.0.1 monotonic 1.6 mpmath 1.3.0 msal 1.31.1 msal-extensions 1.2.0 msgpack 1.1.0 multidict 6.1.0 multiprocess 0.70.16 mypy-extensions 1.0.0 nbclient 0.10.0 nbconvert 7.16.4 nbformat 5.10.4 nest-asyncio 1.6.0 networkx 3.4.2 numpy 1.26.4 nvidia-cublas-cu12 12.4.5.8 nvidia-cuda-cupti-cu12 12.4.127 nvidia-cuda-nvrtc-cu12 12.4.127 nvidia-cuda-runtime-cu12 12.4.127 nvidia-cudnn-cu12 9.1.0.70 nvidia-cufft-cu12 11.2.1.3 nvidia-curand-cu12 10.3.5.147 nvidia-cusolver-cu12 11.6.1.9 nvidia-cusparse-cu12 12.3.1.170 nvidia-nccl-cu12 2.21.5 nvidia-nvjitlink-cu12 12.4.127 nvidia-nvtx-cu12 12.4.127 oauthlib 3.2.2 onnxruntime 1.20.1 openai 1.55.1 opentelemetry-api 1.28.2 opentelemetry-exporter-otlp-proto-common 1.28.2 opentelemetry-exporter-otlp-proto-grpc 1.28.2 opentelemetry-instrumentation 0.49b2 opentelemetry-instrumentation-asgi 0.49b2 opentelemetry-instrumentation-fastapi 0.49b2 opentelemetry-proto 1.28.2 opentelemetry-sdk 1.28.2 opentelemetry-semantic-conventions 0.49b2 opentelemetry-util-http 0.49b2 orjson 3.10.12 overrides 7.7.0 packaging 24.2 pandas 2.2.3 pandocfilters 1.5.1 parso 0.8.4 pexpect 4.9.0 pickleshare 0.7.5 pillow 11.0.0 pip 24.2 pip-chill 1.0.3 pipreqs 0.5.0 platformdirs 4.3.6 portalocker 2.10.1 posthog 3.7.3 prompt_toolkit 3.0.48 propcache 0.2.0 proto-plus 1.25.0 protobuf 5.28.3 psutil 6.1.0 ptyprocess 0.7.0 pure_eval 0.2.3 pyarrow 18.1.0 pyasn1 0.6.1 pyasn1_modules 0.4.1 pycparser 2.22 pydantic 2.9.0 pydantic_core 2.23.2 pydantic-settings 2.6.1 Pygments 2.18.0 PyJWT 2.10.0 pyparsing 3.2.0 PyPika 0.48.9 pyproject_hooks 1.2.0 python-dateutil 2.9.0.post0 python-dotenv 1.0.1 pytz 2024.2 PyYAML 6.0.2 pyzmq 26.2.0 referencing 0.35.1 regex 2024.11.6 requests 2.32.3 requests-oauthlib 2.0.0 requests-toolbelt 1.0.0 rich 13.9.4 rpds-py 0.21.0 rsa 4.9 safetensors 0.4.5 scikit-learn 1.5.2 scipy 1.14.1 sentence-transformers 3.3.1 setuptools 75.1.0 shapely 2.0.6 shellingham 1.5.4 six 1.16.0 sniffio 1.3.1 soupsieve 2.6 SQLAlchemy 2.0.35 sqlglot 25.32.0 sqlvalidator 0.0.20 stack-data 0.6.3 starlette 0.41.3 sympy 1.13.1 tenacity 9.0.0 threadpoolctl 3.5.0 tiktoken 0.8.0 tinycss2 1.4.0 tokenizers 0.20.4 torch 2.5.1 tornado 6.4.2 tqdm 4.67.1 traitlets 5.14.3 transformers 4.46.3 triton 3.1.0 typer 0.13.1 typing_extensions 4.12.2 typing-inspect 0.9.0 tzdata 2024.2 uritemplate 4.1.1 urllib3 2.2.3 uvicorn 0.32.1 uvloop 0.21.0 watchfiles 1.0.0 wcwidth 0.2.13 webencodings 0.5.1 websocket-client 1.8.0 websockets 14.1 wheel 0.44.0 wrapt 1.17.0 xxhash 3.5.0 yarg 0.1.9 yarl 1.18.0 zipp 3.21.0 ### Error Message and Stack Trace (if applicable) Traceback (most recent call last): File "/mnt/batch/tasks/shared/LS_root/mounts/clusters/jomoor1/code/Users/jomoor/CHESS-main/CHESS-main/./src/preprocess.py", line 59, in <module> worker_initializer(args.db_id, args) File "/mnt/batch/tasks/shared/LS_root/mounts/clusters/jomoor1/code/Users/jomoor/CHESS-main/CHESS-main/./src/preprocess.py", line 33, in worker_initializer make_db_context_vec_db(db_directory_path, File "/mnt/batch/tasks/shared/LS_root/mounts/clusters/jomoor1/code/Users/jomoor/CHESS-main/CHESS-main/src/database_utils/db_catalog/preprocess.py", line 90, in make_db_context_vec_db Chroma.from_documents(docs, EMBEDDING_FUNCTION, persist_directory=str(vector_db_path)) File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/langchain_chroma/vectorstores.py", line 1128, in from_documents return cls.from_texts( ^^^^^^^^^^^^^^^ File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/langchain_chroma/vectorstores.py", line 1061, in from_texts chroma_collection = cls( ^^^^ File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/langchain_chroma/vectorstores.py", line 313, in __init__ self._client = chromadb.Client(_client_settings) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/__init__.py", line 334, in Client return ClientCreator(tenant=tenant, database=database, settings=settings) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/api/client.py", line 58, in __init__ super().__init__(settings=settings) File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/api/shared_system_client.py", line 19, in __init__ SharedSystemClient._create_system_if_not_exists(self._identifier, settings) File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/api/shared_system_client.py", line 32, in _create_system_if_not_exists new_system.start() File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/config.py", line 444, in start component.start() File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/telemetry/opentelemetry/__init__.py", line 150, in wrapper return f(*args, **kwargs) ^^^^^^^^^^^^^^^^^^ File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/db/impl/sqlite.py", line 104, in start self.initialize_migrations() File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/db/migrations.py", line 140, in initialize_migrations self.apply_migrations() File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/telemetry/opentelemetry/__init__.py", line 150, in wrapper return f(*args, **kwargs) ^^^^^^^^^^^^^^^^^^ File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/db/migrations.py", line 167, in apply_migrations db_migrations = self.db_migrations(dir) ^^^^^^^^^^^^^^^^^^^^^^^ File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/telemetry/opentelemetry/__init__.py", line 150, in wrapper return f(*args, **kwargs) ^^^^^^^^^^^^^^^^^^ File "/anaconda/envs/chess_engine_3.12/lib/python3.12/site-packages/chromadb/db/impl/sqlite.py", line 202, in db_migrations cur.execute( sqlite3.DatabaseError: database disk image is malformed ### Description Chroma.from_documents() appears to be failing when trying to write persisted files. I have tried using the latest python libraries. I have also tried on different python versions (3.10, 3.11, 3.12) all with the same error. The only thing I am doing that is different than standard setups is defining my own embedding object and passing it in. I made sure it had the right method (embed_documents). I found two files in the output persisted folder. Here are the contents 00001-embeddings.sqlite.sql ```CREATE TABLE embeddings_queue ( seq_id INTEGER PRIMARY KEY, created_at TIMESTAMP NOT NULL DEFAULT CURRENT_TIMESTAMP, operation INTEGER NOT NULL, topic TEXT NOT NULL, id TEXT NOT NULL, vector BLOB, encoding TEXT, metadata TEXT ); ``` 00002-embeddingsj-queue-config.sqlite.sql ``` CREATE TABLE embeddings_queue_config ( id INTEGER PRIMARY KEY, config_json_str TEXT ); ``` ### System Info > OS: Linux > OS Version: #82~20.04.1-Ubuntu SMP Tue Sep 3 12:27:43 UTC 2024 > Python Version: 3.12.7 | packaged by Anaconda, Inc. | (main, Oct 4 2024, 13:27:36) [GCC 11.2.0] Package Information ------------------- > langchain_core: 0.3.21 > langchain: 0.3.8 > langchain_community: 0.3.8 > langsmith: 0.1.146 > langchain_anthropic: 0.3.0 > langchain_chroma: 0.1.4 > langchain_google_genai: 2.0.5 > langchain_google_vertexai: 2.0.7 > langchain_openai: 0.2.10 > langchain_text_splitters: 0.3.2 > langgraph_sdk: 0.1.36 Optional packages not installed ------------------------------- > langserve Other Dependencies ------------------ > aiohttp: 3.11.7 > anthropic: 0.39.0 > anthropic[vertexai]: Installed. No version info available. > async-timeout: Installed. No version info available. > chromadb: 0.5.20 > dataclasses-json: 0.6.7 > defusedxml: 0.7.1 > fastapi: 0.115.5 > google-cloud-aiplatform: 1.73.0 > google-cloud-storage: 2.18.2 > google-generativeai: 0.8.3 > httpx: 0.27.2 > httpx-sse: 0.4.0 > jsonpatch: 1.33 > langchain-mistralai: Installed. No version info available. > numpy: 1.26.4 > openai: 1.55.1 > orjson: 3.10.12 > packaging: 24.2 > pydantic: 2.9.0 > pydantic-settings: 2.6.1 > PyYAML: 6.0.2 > requests: 2.32.3 > requests-toolbelt: 1.0.0 > SQLAlchemy: 2.0.35 > tenacity: 9.0.0 > tiktoken: 0.8.0 > typing-extensions: 4.12.2
โฑญ: vector store,investigate
low
Critical
2,696,051,279
storybook
[Bug]: Running Storybook with vite v6.0.0
### Describe the bug Hi, I tried running `npx storybook@latest init` after `npm create vite@latest` (using react + typescript) . I got the following from storybook.log: npm error code ERESOLVE npm error ERESOLVE unable to resolve dependency tree npm error npm error While resolving: [email protected] npm error Found: [email protected] npm error node_modules/vite npm error dev vite@"^6.0.0" from the root project npm error npm error Could not resolve dependency: npm error peer vite@"^4.0.0 || ^5.0.0" from @storybook/[email protected] npm error node_modules/@storybook/react-vite npm error dev @storybook/react-vite@"^8.4.5" from the root project npm error npm error Fix the upstream dependency conflict, or retry npm error this command with --force or --legacy-peer-deps npm error to accept an incorrect (and potentially broken) dependency resolution. npm error npm error npm error For a full report see: npm error /Users/omarihab/.npm/_logs/2024-11-26T20_17_48_529Z-eresolve-report.txt npm error A complete log of this run can be found in: /Users/omarihab/.npm/_logs/2024-11-26T20_17_48_529Z-debug-0.log ### Reproduction link https://github.com/omarihab99/storybook-vitev6 ### Reproduction steps - `npm create vite@latest`. using react + ts template. - `npm install` - `npx storybook@latest init` ### System ```bash Storybook Environment Info: System: OS: macOS 15.1 CPU: (8) arm64 Apple M1 Shell: 5.9 - /bin/zsh Binaries: Node: 18.20.2 - ~/.nvm/versions/node/v18.20.2/bin/node Yarn: 1.22.22 - ~/.nvm/versions/node/v18.20.2/bin/yarn npm: 10.8.2 - ~/.nvm/versions/node/v18.20.2/bin/npm <----- active Browsers: Chrome: 131.0.6778.86 Safari: 18.1 ``` ### Additional context _No response_
bug,dependencies,builder-vite
low
Critical