codecov-io: # [Codecov](https://codecov.io/gh/repobee/repobee/pull/225?src=pr&el=h1) Report
> Merging [#225](https://codecov.io/gh/repobee/repobee/pull/225?src=pr&el=desc) into [master](https://codecov.io/gh/repobee/repobee/commit/6d643bd78e9f3be1b0e28e135400bb01f09e9e89?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/repobee/repobee/pull/225/graphs/tree.svg?width=650&token=5vOKgkphZe&height=150&src=pr)](https://codecov.io/gh/repobee/repobee/pull/225?src=pr&el=tree)

```diff
@@           Coverage Diff           @@
##           master     #225   +/-   ##
=======================================
  Coverage   91.38%   91.38%           
=======================================
  Files          19       19           
  Lines        1312     1312           
  Branches      237      237           
=======================================
  Hits         1199     1199           
  Misses         93       93           
  Partials       20       20
```


| [Impacted Files](https://codecov.io/gh/repobee/repobee/pull/225?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [repobee/command.py](https://codecov.io/gh/repobee/repobee/pull/225/diff?src=pr&el=tree#diff-cmVwb2JlZS9jb21tYW5kLnB5) | `95.23% <100%> (ø)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/repobee/repobee/pull/225?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/repobee/repobee/pull/225?src=pr&el=footer). Last update [6d643bd...f462b16](https://codecov.io/gh/repobee/repobee/pull/225?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).

diff --git a/repobee/command.py b/repobee/command.py
index e6e5d15..4a8e0ae 100644
--- a/repobee/command.py
+++ b/repobee/command.py
@@ -165,7 +165,7 @@ def update_student_repos(
 
     master_repo_names = [util.repo_name(url) for url in urls]
 
-    repo_urls = api.get_repo_urls(master_repo_names, students=teams)
+    repo_urls = api.get_repo_urls(master_repo_names, teams=teams)
 
     with tempfile.TemporaryDirectory() as tmpdir:
         LOGGER.info("cloning into master repos ...")
@@ -354,7 +354,7 @@ def clone_repos(
         teams: Team objects specifying student groups.
         api: A GitHubAPI instance.
     """
-    repo_urls = api.get_repo_urls(master_repo_names, students=teams)
+    repo_urls = api.get_repo_urls(master_repo_names, teams=teams)
 
     LOGGER.info("cloning into student repos ...")
     git.clone(repo_urls)

command module calls get_repo_urls with students kwarg
Will obviously crash, fix ASAP!
diff --git a/tests/test_command.py b/tests/test_command.py
index cf0df02..4f657e3 100644
--- a/tests/test_command.py
+++ b/tests/test_command.py
@@ -1,7 +1,9 @@
 import os
-import pytest
+from functools import partial
 from unittest.mock import patch, MagicMock, call, ANY, PropertyMock
 
+import pytest
+
 import repobee
 from repobee import command
 from repobee import git
@@ -78,17 +80,20 @@ def generate_repo_url(name):
     return generate_team_repo_url(name, "d")[:-2]
 
 
-def get_repo_urls_fake(master_repo_names, org_name=None, students=None):
+def get_repo_urls_fake(self, master_repo_names, org_name=None, teams=None):
     return list(
         map(
             generate_repo_url,
             master_repo_names
-            if not students
-            else util.generate_repo_names(students, master_repo_names),
+            if not teams
+            else util.generate_repo_names(teams, master_repo_names),
         )
     )
 
 
+# check that get_repo_urls_fake conforms to APISpec.get_repo_urls
+apimeta.check_signature(apimeta.APISpec.get_repo_urls, get_repo_urls_fake)
+
 MASTER_NAMES = ("week-1", "week-2", "week-3")
 MASTER_URLS = tuple(generate_repo_url(name) for name in MASTER_NAMES)
 
@@ -144,7 +149,9 @@ def api_mock(request, mocker):
     api_class = mocker.patch("repobee.command.GitHubAPI", autospec=True)
     api_class.return_value = mock
 
-    mock.get_repo_urls.side_effect = get_repo_urls_fake
+    mock.get_repo_urls.side_effect = partial(
+        get_repo_urls_fake, None  # pass None for self arg
+    )
     mock.create_repos.side_effect = lambda repo_infos: list(
         map(url_from_repo_info, repo_infos)
     )
@@ -367,7 +374,10 @@ class TestUpdateStudentRepos:
             fail_students, [master_name]
         )
         fail_repo_urls = get_repo_urls_fake(
-            [master_name], students=fail_students
+            # passing None for self is fine here
+            None,
+            [master_name],
+            teams=fail_students,
         )
 
         async def raise_specific(pt):

pip install -e .
parse_log_pytest
requirements.txt
pytest pytest-cov pytest-mock codecov
apt-get update apt-get install -y gcc
3.7
requirements.txt
pytest --no-header -rA --tb=line --color=no -p no:cacheprovider -W ignore::DeprecationWarning
appdirs==1.4.4
certifi @ file:///croot/certifi_1671487769961/work/certifi
cffi==1.15.1
charset-normalizer==3.4.1
codecov==2.1.13
colored==1.4.4
coverage==7.2.7
cryptography==44.0.2
daiquiri==3.2.1
Deprecated==1.2.18
exceptiongroup==1.2.2
idna==3.10
importlib-metadata==6.7.0
iniconfig==2.0.0
packaging==24.0
pluggy==1.2.0
pycparser==2.21
PyGithub==2.3.0
PyJWT==2.8.0
PyNaCl==1.5.0
pytest==7.4.4
pytest-cov==4.1.0
pytest-mock==3.11.1
python-gitlab==1.8.0
python-json-logger==3.0.1
-e git+https://github.com/repobee/repobee.git@6d643bd78e9f3be1b0e28e135400bb01f09e9e89#egg=repobee
repobee-plug==0.5.1
requests==2.31.0
six==1.17.0
tomli==2.0.1
typing_extensions==4.7.1
urllib3==2.0.7
wrapt==1.16.0
zipp==3.15.0

name: repobee
channels:
  - defaults
  - https://repo.anaconda.com/pkgs/main
  - https://repo.anaconda.com/pkgs/r
  - conda-forge
dependencies:
  - _libgcc_mutex=0.1=main
  - _openmp_mutex=5.1=1_gnu
  - ca-certificates=2025.2.25=h06a4308_0
  - certifi=2022.12.7=py37h06a4308_0
  - ld_impl_linux-64=2.40=h12ee557_0
  - libffi=3.4.4=h6a678d5_1
  - libgcc-ng=11.2.0=h1234567_1
  - libgomp=11.2.0=h1234567_1
  - libstdcxx-ng=11.2.0=h1234567_1
  - ncurses=6.4=h6a678d5_0
  - openssl=1.1.1w=h7f8727e_0
  - pip=22.3.1=py37h06a4308_0
  - python=3.7.16=h7a1cb2a_0
  - readline=8.2=h5eee18b_0
  - setuptools=65.6.3=py37h06a4308_0
  - sqlite=3.45.3=h5eee18b_0
  - tk=8.6.14=h39e8969_0
  - wheel=0.38.4=py37h06a4308_0
  - xz=5.6.4=h5eee18b_1
  - zlib=1.2.13=h5eee18b_1
  - pip:
      - appdirs==1.4.4
      - cffi==1.15.1
      - charset-normalizer==3.4.1
      - codecov==2.1.13
      - colored==1.4.4
      - coverage==7.2.7
      - cryptography==44.0.2
      - daiquiri==3.2.1
      - deprecated==1.2.18
      - exceptiongroup==1.2.2
      - idna==3.10
      - importlib-metadata==6.7.0
      - iniconfig==2.0.0
      - packaging==24.0
      - pluggy==1.2.0
      - pycparser==2.21
      - pygithub==2.3.0
      - pyjwt==2.8.0
      - pynacl==1.5.0
      - pytest==7.4.4
      - pytest-cov==4.1.0
      - pytest-mock==3.11.1
      - python-gitlab==1.8.0
      - python-json-logger==3.0.1
      - repobee==1.4.0
      - repobee-plug==0.5.1
      - requests==2.31.0
      - six==1.17.0
      - tomli==2.0.1
      - typing-extensions==4.7.1
      - urllib3==2.0.7
      - wrapt==1.16.0
      - zipp==3.15.0
prefix: /opt/conda/envs/repobee

tests/test_command.py::TestUpdateStudentRepos::test_happy_path tests/test_command.py::TestUpdateStudentRepos::test_issues_on_exceptions[issue0] tests/test_command.py::TestUpdateStudentRepos::test_issues_on_exceptions[None] tests/test_command.py::TestUpdateStudentRepos::test_issues_arent_opened_on_exceptions_if_unspeficied tests/test_command.py::TestCloneRepos::test_happy_path tests/test_command.py::TestCloneRepos::test_executes_act_hooks
tests/test_command.py::TestSetupStudentRepos::test_raises_on_clone_failure tests/test_command.py::TestSetupStudentRepos::test_raises_on_duplicate_master_urls tests/test_command.py::TestSetupStudentRepos::test_happy_path tests/test_command.py::TestUpdateStudentRepos::test_raises_on_duplicate_master_urls tests/test_command.py::TestOpenIssue::test_happy_path tests/test_command.py::TestCloseIssue::test_happy_path tests/test_command.py::TestMigrateRepo::test_happy_path tests/test_command.py::TestListIssues::test_happy_path[None-True--open] tests/test_command.py::TestListIssues::test_happy_path[None-True--closed] tests/test_command.py::TestListIssues::test_happy_path[None-True--all] tests/test_command.py::TestListIssues::test_happy_path[None-True-^.*$-open] tests/test_command.py::TestListIssues::test_happy_path[None-True-^.*$-closed] tests/test_command.py::TestListIssues::test_happy_path[None-True-^.*$-all] tests/test_command.py::TestListIssues::test_happy_path[None-False--open] tests/test_command.py::TestListIssues::test_happy_path[None-False--closed] tests/test_command.py::TestListIssues::test_happy_path[None-False--all] tests/test_command.py::TestListIssues::test_happy_path[None-False-^.*$-open] tests/test_command.py::TestListIssues::test_happy_path[None-False-^.*$-closed] tests/test_command.py::TestListIssues::test_happy_path[None-False-^.*$-all] tests/test_command.py::TestListIssues::test_happy_path[slarse-True--open] tests/test_command.py::TestListIssues::test_happy_path[slarse-True--closed] tests/test_command.py::TestListIssues::test_happy_path[slarse-True--all] tests/test_command.py::TestListIssues::test_happy_path[slarse-True-^.*$-open] tests/test_command.py::TestListIssues::test_happy_path[slarse-True-^.*$-closed] tests/test_command.py::TestListIssues::test_happy_path[slarse-True-^.*$-all] tests/test_command.py::TestListIssues::test_happy_path[slarse-False--open] tests/test_command.py::TestListIssues::test_happy_path[slarse-False--closed] tests/test_command.py::TestListIssues::test_happy_path[slarse-False--all] tests/test_command.py::TestListIssues::test_happy_path[slarse-False-^.*$-open] tests/test_command.py::TestListIssues::test_happy_path[slarse-False-^.*$-closed] tests/test_command.py::TestListIssues::test_happy_path[slarse-False-^.*$-all] tests/test_command.py::test_purge_review_teams tests/test_command.py::TestAssignPeerReviewers::test_too_few_students_raises[3-3] tests/test_command.py::TestAssignPeerReviewers::test_too_few_students_raises[3-4] tests/test_command.py::TestAssignPeerReviewers::test_zero_reviews_raises tests/test_command.py::TestAssignPeerReviewers::test_happy_path tests/test_command.py::TestCheckPeerReviewProgress::test_happy_path
repobee/command.py
repobee/command.py