commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
block: qemu-iotests - add common.qemu, for bash-controlled qemu tests
This creates some common functions for bash language qemu-iotests
to control, and communicate with, a running QEMU process.
4 functions are introduced:
1. _launch_qemu()
This launches the QEMU process(es), and sets up the file
descriptors and fifos for communication. You can choose to
launch each QEMU process listening for either QMP or HMP
monitor. You can call this function multiple times, and
save the handle returned from each. The returned handle is
in $QEMU_HANDLE. You must copy this value.
Commands 2 and 3 use the handle received from _launch_qemu(), to talk
to the appropriate process.
2. _send_qemu_cmd()
Sends a command string, specified by $2, to QEMU. If $3 is
non-NULL, _send_qemu_cmd() will wait to receive $3 as a
required result string from QEMU. Failure to receive $3 will
cause the test to fail. The command can optionally be retried
$qemu_cmd_repeat number of times. Set $qemu_error_no_exit
to not force the test the fail on exit; in this case,
$QEMU_STATUS[$1] will be set to -1 on failure.
3. _timed_wait_for()
Waits for a response, for up to a default of 10 seconds. If
$2 is not seen in that time (anywhere in the response), then
the test fails. Primarily used by _send_qemu_cmd, but could
be useful standalone, as well. To prevent automatic exit
(and therefore test failure), set $qemu_error_no_exit to a
non-NULL value. If $silent is a non-NULL value, then output
to stdout will be suppressed.
4. _cleanup_qemu()
Kills the running QEMU processes, and removes the fifos.
Signed-off-by: Jeff Cody <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
e940bc13ee15d6304f3a467961b9f33fc0f25595
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e940bc13ee15d6304f3a467961b9f33fc0f25595
|
2014-05-09 20:57:32+02:00
|
block: fix qemu-img --help invocation
This fixes a bug introduced in commit ac1307ab, that caused the
'--help' option to not be recognized as a valid command, and not
print any help.
Signed-off-by: Jeff Cody <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
7db1689c35a6f7477c691c31232ec10725ba9dfe
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7db1689c35a6f7477c691c31232ec10725ba9dfe
|
2014-04-28 17:36:30+02:00
|
dma-helpers: Initialize DMAAIOCB in_cancel flag
Initialize the dbs->in_cancel flag in dma_bdrv_io(), since qemu_aio_get()
does not return zero-initialized memory. Spotted by the clang sanitizer
(which complained when the value loaded in dma_complete() was not valid
for a bool type); this might have resulted in leaking the AIO block.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
4d1cb6e6f51b0d8405f701806a203a73e7431fe5
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4d1cb6e6f51b0d8405f701806a203a73e7431fe5
|
2014-04-04 19:36:39+02:00
|
qcow2: Put cache reference in error case
When qcow2_get_cluster_offset() sees a zero cluster in a version 2
image, it (rightfully) returns an error. But in doing so it shouldn't
leak an L2 table cache reference.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
|
8885eadedd0ea8b57c1baa367ee2c2d616700bd9
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8885eadedd0ea8b57c1baa367ee2c2d616700bd9
|
2014-04-04 17:10:08+02:00
|
qcow2: Check maximum L1 size in qcow2_snapshot_load_tmp() (CVE-2014-0143)
This avoids an unbounded allocation.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
6a83f8b5bec6f59e56cc49bd49e4c3f8f805d56f
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/6a83f8b5bec6f59e56cc49bd49e4c3f8f805d56f
|
2014-04-01 15:22:35+02:00
|
vdi: add bounds checks for blocks_in_image and disk_size header fields (CVE-2014-0144)
The maximum blocks_in_image is 0xffffffff / 4, which also limits the
maximum disk_size for a VDI image to 1024TB. Note that this is the maximum
size that QEMU will currently support with this driver, not necessarily the
maximum size allowed by the image format.
This also fixes an incorrect error message, a bug introduced by commit
5b7aa9b56d1bfc79916262f380c3fc7961becb50 (Reported by Stefan Weil)
Signed-off-by: Jeff Cody <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
63fa06dc978f3669dbfd9443b33cde9e2a7f4b41
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/63fa06dc978f3669dbfd9443b33cde9e2a7f4b41
|
2014-04-01 14:06:31+02:00
|
target-ppc: Force CPU threads count to be a power of 2
PowerPC kernel expects the number of SMT threads in a core to be a power
of 2. Since QEMU doesn't enforce this, it leads to an early guest kernel
crash if invalid threads count is specified.
Prevent this crash and make it a graceful exit from QEMU itself by
validating the user-supplied threads count.
Signed-off-by: Bharata B Rao <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Stewart Smith <[email protected]>
Signed-off-by: Andreas Färber <[email protected]>
|
5ec83c73e5ece590538878b24dfcb422904533e0
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5ec83c73e5ece590538878b24dfcb422904533e0
|
2014-03-20 02:39:33+01:00
|
hw/ppc: Avoid shifting left into sign bit
Add U suffix to various places where we were doing "1 << 31",
which is undefined behaviour, and also to other constant
definitions in the same groups, for consistency.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
a1f7f97b950a46393b0e55a9a0082e70f540cbbd
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a1f7f97b950a46393b0e55a9a0082e70f540cbbd
|
2014-03-27 19:22:49+04:00
|
XBZRLE: Fix qemu crash when resize the xbzrle cache
Resizing the xbzrle cache during migration causes qemu-crash,
because the main-thread and migration-thread modify the xbzrle
cache size concurrently without lock-protection.
Signed-off-by: ChenLiang <[email protected]>
Signed-off-by: Gonglei <[email protected]>
Reviewed-by: Dr. David Alan Gilbert <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
|
fd8cec932c2ddc687e2da954978954b46a926f90
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fd8cec932c2ddc687e2da954978954b46a926f90
|
2014-03-08 22:22:34+01:00
|
hw/misc/arm_sysctl: Fix bad boundary check on mb clock accesses
Fix incorrect use of sizeof() rather than ARRAY_SIZE() to guard
accesses into the mb_clock[] array, which was allowing a malicious
guest to overwrite the end of the array.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Paolo Bonzini <[email protected]>
Reviewed-by: Andreas Färber <[email protected]>
Message-id: [email protected]
Cc: [email protected]
|
ec1efab95767312ff4afb816d0d4b548e093b031
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ec1efab95767312ff4afb816d0d4b548e093b031
|
2014-02-26 17:19:57+00:00
|
fsdev: Fix overrun after readlink() fills buffer completely
readlink() returns the number of bytes written to the buffer, and it
doesn't write a terminating null byte. do_readlink() writes it
itself. Overruns the buffer when readlink() filled it completely.
Fix by reserving space for the null byte when calling readlink(), like
we do elsewhere.
Signed-off-by: Markus Armbruster <[email protected]>
Signed-off-by: Aneesh Kumar K.V <[email protected]>
|
d77f7779b4d74354b3444ceb0f93105ced3c26c8
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d77f7779b4d74354b3444ceb0f93105ced3c26c8
|
2014-02-26 12:24:07+05:30
|
block: Fail gracefully with missing filename
This fixes a regression introduced in commit 2a05cbe42 ('block: Allow
block devices without files'):
$ qemu-system-x86_64 -drive driver=file
qemu-system-x86_64: block.c:892: bdrv_open_common: Assertion
`!drv->bdrv_needs_filename || filename != ((void *)0)' failed.
Now the respective check must be performed not only in bdrv_file_open(),
but also in bdrv_open().
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
|
765003db029ed4660a09807958276e251de84fac
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/765003db029ed4660a09807958276e251de84fac
|
2014-02-09 09:12:38+01:00
|
Fix QEMU build on OpenBSD on x86 archs
This resolves the build issue with building the ROMs on OpenBSD on x86 archs.
As of OpenBSD 5.3 the compiler builds PIE binaries by default and thus the
whole OS/packages and so forth. The ROMs need to have PIE disabled.
Check in configure whether the compiler supports the flags for disabling
PIE, and if it does then use them for building the ROMs. This fixes the
following buildbot failure:
>From the OpenBSD buildbots..
Building optionrom/multiboot.img
ld: multiboot.o: relocation R_X86_64_16 can not be used when making a shared object; recompile with -fPIC
Signed-off by: Brad Smith <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
46eef33b89e936ca793e13c4aeea1414e97e8dbb
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/46eef33b89e936ca793e13c4aeea1414e97e8dbb
|
2014-02-17 11:44:00+00:00
|
qga: vss-win32: Fix interference with snapshot creation by other VSS requesters
When a VSS requester such as vshadow.exe or diskshadow.exe requests to
create disk snapshots, Windows may choose qemu-ga VSS provider if it is
only provider registered on the system. However, because it provides only a
function to freeze the filesystem, the snapshotting fails.
This patch adds a check into CQGAVssProvider::IsVolumeSupported() to reject
the request from other VSS requesters, so that the other provider is chosen.
The check of requester is done by confirming event channels between
qemu-ga's requester and provider established. To ensure that the events are
initialized when CQGAVssProvider::IsVolumeSupported() is called, it moves
the initialization earlier.
Signed-off-by: Tomoki Sekiyama <[email protected]>
Reviewed-by: Gal Hammer <[email protected]>
Reviewed-by: Yan Vugenfirer <[email protected]>
Signed-off-by: Michael Roth <[email protected]>
|
ff8adbcfdbbd9c0f2b01ff8a32bc75082fdd9844
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ff8adbcfdbbd9c0f2b01ff8a32bc75082fdd9844
|
2014-02-23 13:11:26-06:00
|
qom: Do not register interface "types" in the type table and fix names
There should be no need to look up nor enumerate the interface "types",
whose "classes" are really just vtables. Just create the types and
add them to the interface list of the parent type.
Interfaces not registering their type anymore means that accessing
superclass::interface by type name will fail when initializing
subclass::interface. Thus, we need to pre-initialize the subclass's
parent_type field before calling type_initialize. Apart from this, the
interface "types" should never be used and thus it is harmless to leave
them out of the hashtable.
Further, the interface types had a bug with interfaces that are
inherited from a superclass: The implementation type name was wrong
(for example it was subclass::superclass::interface rather than
just subclass::interface). This patch fixes this as well.
Reported-by: Igor Mammedov <[email protected]>
Tested-by: Igor Mammedov <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Andreas Färber <[email protected]>
|
b061dc41f62048acd4a34c6570c0ea396cd9d0b4
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b061dc41f62048acd4a34c6570c0ea396cd9d0b4
|
2013-12-24 17:27:17+01:00
|
virtio-net: switch exit callback to VirtioDeviceClass
This ensures hot-unplug is handled properly by the proxy, and avoids
leaking bus_name which is freed by virtio_device_exit.
Cc: [email protected]
Acked-by: Andreas Faerber <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
3786cff5eb384d058395a2729af627fa3253d056
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3786cff5eb384d058395a2729af627fa3253d056
|
2013-12-09 21:46:48+01:00
|
target-i386: Fix segment cache dump
When in Long Mode, cpu_x86_seg_cache() logs "DS16" because the Default
operation size bit (D/B bit) is not set for Long Mode Data Segments since
there are only Data Segments in Long Mode and no explicit 16/32/64-bit
Descriptors.
This patch fixes this by checking the Long Mode Active bit of the hidden
flags variable and logging "DS" if it is set. (I.e. in Long Mode all Data
Segments are logged as "DS")
Signed-off-by: Tobias Markus <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
469936ae0a9891b2de7e46743f683535b0819bee
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/469936ae0a9891b2de7e46743f683535b0819bee
|
2013-09-20 20:09:24+04:00
|
vscclient: remove unnecessary use of uninitialized variable
Signed-off-by: Wenchao Xia <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
69fded480e335ecfe877e2c37de0eff265fced12
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/69fded480e335ecfe877e2c37de0eff265fced12
|
2013-09-20 20:09:24+04:00
|
block: qemu-iotests for vhdx, read sample dynamic image
This adds the VHDX format to the qemu-iotests format, and adds
a read test. The test reads from an existing sample image, that
was created with Hyper-V under Windwos Server 2012.
The image file is a 1GB dynamic image, with 32MB blocks.
The pattern 0xa5 exists from 0MB-33MB (past a block size boundary)
The pattern 0x96 exists from 33MB-66MB (past another block boundary,
and leaving a partial blank block)
From 66MB-1024MB, all reads should return 0.
Although 1GB dynamic image with 66MB of data, the bzip2'ed image
file size is only 874 bytes.
This also adds in the IMGFMT_GENERIC flag, so r/o images can be
tested (e.g. ./check -vhdx) without failing tests that assume
r/w support.
Signed-off-by: Jeff Cody <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
89e911816a1d5cdbc9480d5464c571d216cf5ea8
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/89e911816a1d5cdbc9480d5464c571d216cf5ea8
|
2013-10-11 16:49:59+02:00
|
qcow2: Don't put invalid L2 table into cache
In l2_allocate, the fail path is executed if qcow2_cache_flush fails.
However, the L2 table has not yet been fetched from the L2 table cache.
The qcow2_cache_put in the fail path therefore basically gives an
undefined argument as the L2 table address (in this case).
Signed-off-by: Max Reitz <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
8585afd8133eed037dde9c14106e7eb8d7c46968
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8585afd8133eed037dde9c14106e7eb8d7c46968
|
2013-09-27 11:31:59+02:00
|
qemu-img: fix invalid JSON
Single quotes for JSON are a QMP-ism, use real JSON in
qemu-img output.
Reported-by: Kevin Wolf <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
c745bfb4300206280ce6156b4bafe765f610057c
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c745bfb4300206280ce6156b4bafe765f610057c
|
2013-09-12 13:49:50+02:00
|
block: expect errors from bdrv_co_is_allocated
Some bdrv_is_allocated callers do not expect errors, but the fallback
in qcow2.c might make other callers trip on assertion failures or
infinite loops.
Fix the callers to always look for errors.
Cc: [email protected]
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
d663640c04f2aab810915c556390211d75457704
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d663640c04f2aab810915c556390211d75457704
|
2013-09-06 15:25:09+02:00
|
tcg/mips: fix invalid op definition errors
tcg/mips/tcg-target.h defines various operations conditionally depending
upon the isa revision, however these operations are included in
mips_op_defs[] unconditionally resulting in the following runtime errors
if CONFIG_DEBUG_TCG is defined:
Invalid op definition for movcond_i32
Invalid op definition for rotl_i32
Invalid op definition for rotr_i32
Invalid op definition for deposit_i32
Invalid op definition for bswap16_i32
Invalid op definition for bswap32_i32
tcg/tcg.c:1196: tcg fatal error
Fix with ifdefs like the i386 backend does for movcond_i32.
Signed-off-by: James Hogan <[email protected]>
Cc: Aurelien Jarno <[email protected]>
Cc: Richard Henderson <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
|
85711e6bafb1910b50ff181e8507cb904ef7e84d
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/85711e6bafb1910b50ff181e8507cb904ef7e84d
|
2013-08-08 23:06:02+02:00
|
migration: don't use uninitialized variables
The qmp_migrate method uses the 'blk' and 'inc' parameter without
checking if they're valid or not (they may be uninitialized if
command is received via QMP)
Signed-off-by: Pawit Pornkitprasan <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Luiz Capitulino <[email protected]>
|
8c0426aed1d2279845e6a2c3355da8b5d9926cb6
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8c0426aed1d2279845e6a2c3355da8b5d9926cb6
|
2013-08-01 09:40:46-04:00
|
s390: Implement dump-guest-memory support for target s390x
With this patch dump-guest-memory on s390 produces an ELF formatted,
crash-readable dump.
In order to implement this, the arch-specific part of dump-guest-memory
was added:
target-s390x/arch_dump.c contains the whole set of function for writing
Elf note sections of all types for s390x.
Signed-off-by: Ekaterina Tumanova <[email protected]>
Signed-off-by: Jens Freimann <[email protected]>
[fixed indentation, use CamelCase, rename note_t to Note, use S390CPU]
Reviewed-by: Andreas Färber <[email protected]>
Signed-off-by: Christian Borntraeger <[email protected]>
|
9b4f38e182d18cac217f04b8b7fddf760a5b9d44
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/9b4f38e182d18cac217f04b8b7fddf760a5b9d44
|
2013-07-30 16:12:25+02:00
|
qcow2: Metadata overlap checks
Two new functions are added; the first one checks a given range in the
image file for overlaps with metadata (main header, L1 tables, L2
tables, refcount table and blocks).
The second one should be used immediately before writing to the image
file as it calls the first function and, upon collision, marks the
image as corrupt and makes the BDS unusable, thereby preventing
further access.
Both functions take a bitmask argument specifying the structures which
should be checked for overlaps, making it possible to also check
metadata writes against colliding with other structures.
Signed-off-by: Max Reitz <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
a40f1c2add4d5f58d594f810fe36cabcf32bc4b0
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a40f1c2add4d5f58d594f810fe36cabcf32bc4b0
|
2013-08-30 15:48:43+02:00
|
target-xtensa: don't generate dead code to access invalid SRs
This fixes the following test failure caused by access to undefined SR:
qemu-system-xtensa -M sim -cpu dc232b -nographic -semihosting -kernel ./test_sr.tst
QEMU 1.4.50 monitor - type 'help' for more information
(qemu) QEMU 1.4.50 monitor - type 'help' for more information
(qemu) qemu-system-xtensa: tcg/tcg.c:1673: temp_save: Assertion `s->temps[temp].val_type == 2 || s->temps[temp].fixed_reg' failed.
Signed-off-by: Max Filippov <[email protected]>
|
0857a06ef784783887e756d4b7b5f874512c506c
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0857a06ef784783887e756d4b7b5f874512c506c
|
2013-07-29 18:35:45+04:00
|
block/qcow2.h: Avoid "1LL << 63" (shifts into sign bit)
The expression "1LL << 63" tries to shift the 1 into the sign bit of a
'long long', which provokes a clang sanitizer warning:
runtime error: left shift of 1 by 63 places cannot be represented in type 'long long'
Use "1ULL << 63" as the definition of QCOW_OFLAG_COPIED instead
to avoid this. For consistency, we also update the other QCOW_OFLAG
definitions to use the ULL suffix rather than LL, though only the
shift by 63 is undefined behaviour.
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
127c84e1a52f11bf418cc2d3bf804da5091a190a
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/127c84e1a52f11bf418cc2d3bf804da5091a190a
|
2013-08-30 15:28:52+02:00
|
vl: new runstate transition: RUN_STATE_GUEST_PANICKED -> RUN_STATE_FINISH_MIGRATE
This fixes a problem that after guest panic happens, virsh dump without
--memory-only fails:
ERROR: invalid runstate transition: 'guest-panicked' -> 'finish-migrate'
Reported-by: Christian Borntraeger <[email protected]>
Signed-off-by: Hu Tao <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Message-id: [email protected]
Cc: [email protected]
Signed-off-by: Hu Tao <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
fd2a2e1c552cb47ca196552457e175c889b58478
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fd2a2e1c552cb47ca196552457e175c889b58478
|
2013-05-20 08:20:07-05:00
|
qapi: fix leak in unit tests
qmp_output_get_qobject() increments the qobject's reference count. Since
we currently pass this straight into qobject_to_json() so we can feed
the data into a QMP input visitor, we never actually free the underlying
qobject when qmp_output_visitor_cleanup() is called. This causes leaks
on all of the QMP serialization tests.
Fix this by holding a pointer to the qobject and decref'ing it before
returning from qmp_deserialize().
Signed-off-by: Michael Roth <[email protected]>
Signed-off-by: Luiz Capitulino <[email protected]>
|
ad7f375df681503baa6ebef065818868e1216976
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ad7f375df681503baa6ebef065818868e1216976
|
2013-05-15 08:58:43-04:00
|
qcow2: Catch some L1 table index overflows
This catches the situation that is described in the bug report at
https://bugs.launchpad.net/qemu/+bug/865518 and goes like this:
$ qemu-img create -f qcow2 huge.qcow2 $((1024*1024))T
Formatting 'huge.qcow2', fmt=qcow2 size=1152921504606846976 encryption=off cluster_size=65536 lazy_refcounts=off
$ qemu-io /tmp/huge.qcow2 -c "write $((1024*1024*1024*1024*1024*1024 - 1024)) 512"
Segmentation fault
With this patch applied the segfault will be avoided, however the case
will still fail, though gracefully:
$ qemu-img create -f qcow2 /tmp/huge.qcow2 $((1024*1024))T
Formatting 'huge.qcow2', fmt=qcow2 size=1152921504606846976 encryption=off cluster_size=65536 lazy_refcounts=off
qemu-img: The image size is too large for file format 'qcow2'
Note that even long before these overflow checks kick in, you get
insanely high memory usage (up to INT_MAX * sizeof(uint64_t) = 16 GB for
the L1 table), so with somewhat smaller image sizes you'll probably see
qemu aborting for a failed g_malloc().
If you need huge image sizes, you should increase the cluster size to
the maximum of 2 MB in order to get higher limits.
Signed-off-by: Kevin Wolf <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
2cf7cfa1cde6672b8a35bbed3fbc989f28c05dce
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2cf7cfa1cde6672b8a35bbed3fbc989f28c05dce
|
2013-05-14 16:44:33+02:00
|
Revert "pc: Kill the "use flash device for BIOS unless KVM" misfeature"
This reverts commit 9953f8822cc316eec9962f0a2858c3439a80adec.
While Markus's analysis is entirely correct, there are 1.6 patches
that fix the bug for real and without requiring machine type hacks.
Let's think of the children who will have to read this code, and
avoid a complicated mess of semantics that differ between <1.5,
1.5, and >1.5.
Conflicts:
hw/i386/pc_piix.c
hw/i386/pc_q35.c
include/hw/i386/pc.h
Signed-off-by: Paolo Bonzini <[email protected]>
Acked-by: Anthony Liguori <[email protected]>
Message-id: [email protected]
Signed-off-by: Anthony Liguori <[email protected]>
|
9e1c2ec8fd8d9a9ee299ea86c5f6c986fe25e838
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/9e1c2ec8fd8d9a9ee299ea86c5f6c986fe25e838
|
2013-05-13 09:52:43-05:00
|
rbd: Fix use after free in rbd_open()
Commit a9ccedc3 frees the QemuOpts for the driver-specific options
immediately, even though it still needs the filename string that is
contained there. This doesn't work. Move the deletion of the QemuOpts to
the end of the function where its content isn't needed any more.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
c3ca988d2b0ee94dc8d53eff4b1c2de4ac06a270
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c3ca988d2b0ee94dc8d53eff4b1c2de4ac06a270
|
2013-04-26 13:26:28+02:00
|
xhci: fix portsc writes
Check for port reset first and skip everything else then.
Add sanity checks for PLS updates.
Add PLC notification when entering PLS_U0 state.
This gets host-initiated port resume going on win8.
Signed-off-by: Gerd Hoffmann <[email protected]>
|
bdfce20df113522f389b4483ffd9d5b336e3c774
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/bdfce20df113522f389b4483ffd9d5b336e3c774
|
2013-04-16 11:59:08+02:00
|
ide: refuse WIN_READ_NATIVE_MAX on empty device
What is the highest addressable sector on an empty CD-ROM? Nothing is
addressable so produce an error.
This patch prevents a divide-by-zero in ide_set_sector() since
s->sectors and s->heads would be 0. Not to mention that a sector=-1
argument would be nonsense.
Note that WIN_READ_NATIVE_MAX can be triggered using hdparm -N 1024
/dev/cdrom. The LBA bit will be set to 1 though, so the only easy way
to go down the ide_set_sector() CHS code path which divides by zero is
to comment out the s->select & 0x40 case for testing.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
|
aad64f3193cbdc3741d10afa0237b6833e46e94e
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/aad64f3193cbdc3741d10afa0237b6833e46e94e
|
2013-04-15 10:18:05+02:00
|
trace: Provide a generic tracing event descriptor
Uses tracetool to generate a backend-independent tracing event description
(struct TraceEvent).
The values for such structure are generated with the non-public "events"
backend ("events-c" frontend).
The generation of the defines to check if an event is statically enabled is also
moved to the "events" backend ("events-h" frontend).
Signed-off-by: Lluís Vilanova <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
45be2f5d0dcdd314cd0c70a11220e5e09a44d654
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/45be2f5d0dcdd314cd0c70a11220e5e09a44d654
|
2013-03-28 14:19:57+01:00
|
savevm: Add VMSTATE_UINT64_EQUAL helpers
The savevm code already includes a number of *_EQUAL helpers which act as
sanity checks verifying that the configuration of the saved state matches
that of the machine we're loading into to work. Variants already exist
for 8 bit 16 bit and 32 bit integers, but not 64 bit integers. This patch
fills that hole, adding a UINT64 version.
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Juan Quintela <[email protected]>
|
e344b8a16de429ada3d9126f26e2a96d71348356
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e344b8a16de429ada3d9126f26e2a96d71348356
|
2013-03-26 13:30:48+01:00
|
tap: forbid creating multiqueue tap when hub is used
Obviously, hub does not support multiqueue tap. So this patch forbids creating
multiple queue tap when hub is used to prevent the crash when command line such
as "-net tap,queues=2" is used.
Cc: [email protected]
Signed-off-by: Jason Wang <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
ce675a7579fea498397c5d2da3c5367671e9f02a
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ce675a7579fea498397c5d2da3c5367671e9f02a
|
2013-02-27 16:10:47+01:00
|
mmu-hash64: Implement Virtual Page Class Key Protection
Version 2.06 of the Power architecture describes an additional page
protection mechanism. Each virtual page has a "class" (0-31) recorded in
the PTE. The AMR register contains bits which can prohibit reads and/or
writes on a class by class basis. Interestingly, the AMR is userspace
readable and writable, however user mode writes are masked by the contents
of the UAMOR which is privileged.
This patch implements this protection mechanism, along with the AMR and
UAMOR SPRs. The architecture also specifies a hypervisor-privileged AMOR
register which masks user and supervisor writes to the AMR and UAMOR. We
leave this out for now, since we don't at present model hypervisor mode
correctly in any case.
Signed-off-by: David Gibson <[email protected]>
[agraf: fix 32-bit hosts]
Signed-off-by: Alexander Graf <[email protected]>
|
f80872e21c07edd06eb343eeeefc8af404b518a6
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/f80872e21c07edd06eb343eeeefc8af404b518a6
|
2013-03-22 15:28:53+01:00
|
tests: add fuzzing to visitor tests
Perform input tests on random data.
Improvement to code coverage for qapi/string-input-visitor.c
is about 3 percentage points.
Signed-off-by: Blue Swirl <[email protected]>
|
3f0f31a0f1c9a89314e9f9ed423371f4d925d5a6
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3f0f31a0f1c9a89314e9f9ed423371f4d925d5a6
|
2013-01-26 13:32:29+00:00
|
qxl: Fix SPICE_RING_PROD_ITEM(), SPICE_RING_CONS_ITEM() sanity check
The pointer arithmetic there is safe, but ugly. Coverity grouses
about it. However, the actual comparison is off by one: <= end
instead of < end. Fix by rewriting the check in a cleaner way.
Signed-off-by: Markus Armbruster <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
|
bc5f92e5db6f303e73387278e32f8669f0abf0e5
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/bc5f92e5db6f303e73387278e32f8669f0abf0e5
|
2013-01-14 08:59:38+01:00
|
qapi: handle visitor->type_size() in QapiDeallocVisitor
visit_type_size() requires either visitor->type_size() or
visitor_uint64() to be implemented, otherwise a NULL function pointer is
invoked.
It is possible to trigger this crash as follows:
$ qemu-system-x86_64 -netdev tap,sndbuf=0,id=netdev0 \
-device virtio-blk-pci,netdev=netdev0
The 'sndbuf' option has type "size".
Reviewed-by: Andreas Färber <[email protected]>
Reviewed-by: Michael Roth <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
0c26f2eca40d6c65ea9edc62a10e510dc7f65cc8
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0c26f2eca40d6c65ea9edc62a10e510dc7f65cc8
|
2012-11-26 14:25:06-06:00
|
ide: Fix crash with too long PRD
Without this, s->nsector can become negative and badness happens (trying
to malloc huge amount of memory and glib calls abort())
Signed-off-by: Kevin Wolf <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
038268e2e8087ee2fd8987a77ba580e15f14c147
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/038268e2e8087ee2fd8987a77ba580e15f14c147
|
2012-11-21 09:47:34+01:00
|
ehci: Don't verify the next pointer for periodic qh-s and qtd-s
While testing the move to async packet handling for interrupt endpoints I
noticed that Windows-XP likes to play tricks with the next pointer for
periodic qh-s, so we should not fail qh / qtd verification when it changes.
Signed-off-by: Hans de Goede <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
|
2c7b15c1dec4b2ec17549c760df0b7a7cea3ed7d
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2c7b15c1dec4b2ec17549c760df0b7a7cea3ed7d
|
2012-11-16 11:27:32+01:00
|
combined-packet: Add a workaround for Linux usbfs + live migration
Older versions (anything but the latest) of Linux usbfs + libusb(x),
will submit larger (bulk) transfers split into multiple 16k submissions,
which means that rather then all tds getting linked into the queue in
one atomic operarion they get linked in a bunch at a time, which could
cause problems if:
1) We scan the queue while libusb is in the middle of submitting a split
bulk transfer
2) While this bulk transfer is pending we migrate to another host.
The problem is that after 2, the new host will rescan the queue and
combine the packets in one large transfer, where as 1) has caused the
original host to see them as 2 transfers. This patch fixes this by stopping
combinging if we detect a 16k transfer with its int_req flag set.
This should not adversely effect performance for other cases as:
1) Linux never sets the interrupt flag on packets other then the last
2) Windows does set the in_req flag on each td, but will submit large
transfers in 20k tds thus never triggering the check
Signed-off-by: Hans de Goede <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
|
579967bea69bf1b32faee13ff76b19ba641a2618
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/579967bea69bf1b32faee13ff76b19ba641a2618
|
2012-11-01 15:17:58+01:00
|
linux-user: If loading fails, print error as string, not number
If the attempt to load the guest executable fails, print the
error message as a string, not a number. This requires us to
fix a couple of places in loader_exec() where we were returning
-1 instead of a valid negative errno.
The change allows us to drop the "Unknown binary format" message
because the strerror-enhanced message is now a more self-explanatory
"Error while loading $guest-binary: Exec format error".
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
885c1d10b803fc37e6656e733ba916c702b6f515
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/885c1d10b803fc37e6656e733ba916c702b6f515
|
2012-10-12 14:25:56+03:00
|
mirror: add support for on-source-error/on-target-error
Error management is important for mirroring; otherwise, an error on the
target (even something as "innocent" as ENOSPC) requires to start again
with a full copy. Similar to on_read_error/on_write_error, two separate
knobs are provided for on_source_error (reads) and on_target_error (writes).
The default is 'report' for both.
The 'ignore' policy will leave the sector dirty, so that it will be
retried later. Thus, it will not cause corruption.
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
b952b5589a36114e06201c0d2e82c293dbad2b1f
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b952b5589a36114e06201c0d2e82c293dbad2b1f
|
2012-10-24 10:26:22+02:00
|
cadence_uart: Fix buffer overflow
Report from smatch:
hw/cadence_uart.c:413 uart_read(13) error: buffer overflow 's->r' 18 <= 18
This fixes read access to s->r[R_MAX] which is behind the limits of s->r.
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
5d40097fc09fe5d34cf316a411dc27d455ac2cd0
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5d40097fc09fe5d34cf316a411dc27d455ac2cd0
|
2012-09-23 07:11:28+01:00
|
hw/qxl: exit on failure to register qxl interface
This prevents a segfault later on when the device reset handler
tries to access a NULL ssd.worker since interface_attach_worker has
not been called.
Signed-off-by: Alon Levy <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
|
e25a0651f4be22099122b5e14c77c354be0aa88b
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e25a0651f4be22099122b5e14c77c354be0aa88b
|
2012-10-08 12:15:17+02:00
|
ehci: switch to new-style memory ops
Also register different memory regions for capabilities,
operational registers and port status registers. Create
separate tracepoints for operational regs and port status
regs. Ditch a bunch of sanity checks because the memory
core will do this for us now.
Offloading the byte, word and dword access handling to the
memory core also has the side effect of fixing ehci register
access on bigendian hosts.
Cc: David Gibson <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
|
3e4f910c8d490a1490409a7e381dbbb229f9d272
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3e4f910c8d490a1490409a7e381dbbb229f9d272
|
2012-09-12 08:09:49+02:00
|
ehci: Properly report completed but not yet processed packets to the guest
Reported packets which have completed before being cancelled as such to the
host. Note that the new code path this patch adds is untested since it I've
been unable to actually trigger the race which needs this code path.
Signed-off-by: Hans de Goede <[email protected]>
|
4b63a0df3bda8a2c278e45d9d94d9ba6d5791d8d
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4b63a0df3bda8a2c278e45d9d94d9ba6d5791d8d
|
2012-09-11 07:42:59+02:00
|
CHECKPATCH: Add warning for single else statement.
For an example:
WARNING: braces {} are necessary even for single statement blocks
+ } else
+ return env->regs[R_EAX];
total: 0 errors, 1 warnings, 41 lines checked
Signed-off-by: Don Slutz <[email protected]>
Signed-off-by: Blue Swirl <[email protected]>
|
dfe7053a34353079503bf350f83cb8b6101a450d
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/dfe7053a34353079503bf350f83cb8b6101a450d
|
2012-09-05 19:17:49+00:00
|
console: bounds check whenever changing the cursor due to an escape code
This is XSA-17 / CVE-2012-3515
Signed-off-by: Ian Campbell <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
3eea5498ca501922520b3447ba94815bfc109743
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3eea5498ca501922520b3447ba94815bfc109743
|
2012-09-04 10:26:17-05:00
|
target-mips: add privilege level check to several Cop0 instructions
The MIPS Architecture Verification Programs (AVPs) check privileged
instructions for the required privilege level. These changes are needed
to pass the AVP suite.
Signed-off-by: Eric Johnson <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
|
2e15497c5b8d0d172dece0cf56e2d2e977a6b679
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2e15497c5b8d0d172dece0cf56e2d2e977a6b679
|
2012-08-27 22:17:59+02:00
|
sheepdog: don't leak socket file descriptor upon connection failure
Signed-off-by: Jim Meyering <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
a7e47d4bfcbf256fae06891a8599950ff8e1b61b
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a7e47d4bfcbf256fae06891a8599950ff8e1b61b
|
2012-08-22 10:47:14-05:00
|
qcow2: implement lazy refcounts
Lazy refcounts is a performance optimization for qcow2 that postpones
refcount metadata updates and instead marks the image dirty. In the
case of crash or power failure the image will be left in a dirty state
and repaired next time it is opened.
Reducing metadata I/O is important for cache=writethrough and
cache=directsync because these modes guarantee that data is on disk
after each write (hence we cannot take advantage of caching updates in
RAM). Refcount metadata is not needed for guest->file block address
translation and therefore does not need to be on-disk at the time of
write completion - this is the motivation behind the lazy refcount
optimization.
The lazy refcount optimization must be enabled at image creation time:
qemu-img create -f qcow2 -o compat=1.1,lazy_refcounts=on a.qcow2 10G
qemu-system-x86_64 -drive if=virtio,file=a.qcow2,cache=writethrough
Update qemu-iotests 031 and 036 since the extension header size changes
when we add feature bit table entries.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
bfe8043e9214d2fc6572cc72b5f2218308747acd
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/bfe8043e9214d2fc6572cc72b5f2218308747acd
|
2012-08-06 22:39:14+02:00
|
qapi: Add Visitor interfaces for uint*_t and int*_t
This adds visitor interfaces for fixed-width integers types.
Implementing these in visitors is optional, otherwise we fall back to
visit_type_int() (int64_t) with some additional bounds checking to avoid
integer overflows for cases where the value fetched exceeds the bounds
of our target C type.
Signed-off-by: Michael Roth <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
[LE: exclude negative values in uint*_t Visitor interfaces]
Signed-off-by: Laszlo Ersek <[email protected]>
[AF: Merged fix by Laszlo]
Signed-off-by: Andreas Färber <[email protected]>
|
4e27e819bea0ea6c8108dc7e9fa48afd6ec13c46
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4e27e819bea0ea6c8108dc7e9fa48afd6ec13c46
|
2012-06-08 16:11:14+02:00
|
scsi: Add assertion for use-after-free errors
The QEMU emulation which is currently used with Raspberry PI images
(qemu-system-arm -M versatilepb ...) accesses memory which was freed.
Valgrind output (extract):
==17857== Invalid write of size 4
==17857== at 0x24EB06: scsi_req_unref (scsi-bus.c:1273)
==17857== by 0x24FFAE: scsi_read_complete (scsi-disk.c:277)
==17857== by 0x152ACC: bdrv_co_em_bh (block.c:3363)
==17857== by 0x13D49C: qemu_bh_poll (async.c:71)
==17857== by 0x211A8C: main_loop_wait (main-loop.c:503)
==17857== by 0x207954: main_loop (vl.c:1555)
==17857== by 0x20E9C9: main (vl.c:3653)
==17857== Address 0x1c54383c is 12 bytes inside a block of size 260 free'd
==17857== at 0x4824B3A: free (vg_replace_malloc.c:366)
==17857== by 0x20ADFA: free_and_trace (vl.c:2250)
==17857== by 0x4899FC5: g_free (in /lib/libglib-2.0.so.0.2400.1)
==17857== by 0x24EB3B: scsi_req_unref (scsi-bus.c:1277)
==17857== by 0x24F003: scsi_req_complete (scsi-bus.c:1383)
==17857== by 0x25022A: scsi_read_data (scsi-disk.c:334)
==17857== by 0x24EB9F: scsi_req_continue (scsi-bus.c:1289)
==17857== by 0x1C7787: lsi_do_dma (lsi53c895a.c:575)
==17857== by 0x1C8CDA: lsi_execute_script (lsi53c895a.c:1147)
==17857== by 0x1C74EA: lsi_resume_script (lsi53c895a.c:510)
==17857== by 0x1C7ECD: lsi_transfer_data (lsi53c895a.c:746)
==17857== by 0x24EC90: scsi_req_data (scsi-bus.c:1307)
(There are some more similar messages.)
This patch adds an assertion which also detects those errors:
Calling scsi_req_unref is not allowed when the previous call
of that function has decremented refcount to 0, because in this
case req was freed.
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
68bd348ade453821fd5378479e6718e69bf181f1
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/68bd348ade453821fd5378479e6718e69bf181f1
|
2012-05-07 08:44:21+02:00
|
qemu-char: Fix crash when switching consoles
qemu-system-arm (and other system emulations) crashes with SDL when
the user switches consoles (Alt-Ctrl-F4).
We already check for NULL pointers in qemu_chr_fe_ioctl,
qemu_chr_be_can_write and other functions, so do this also
for s->chr_read in qemu_chr_be_write. This fixes the crash.
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
ac3107340fbb9422ea63ee5d6729775965e121fd
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ac3107340fbb9422ea63ee5d6729775965e121fd
|
2012-04-24 09:50:31-05:00
|
nbd: Fix uninitialised use of s->sock
s->sock is assigned only afterwards, so we're really registering an
aio_fd_handler for file descriptor 0 here. Not exactly what we intended.
Signed-off-by: Kevin Wolf <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
b3adf53a3a10a1ca8347167907e4cf8bbd0204f1
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b3adf53a3a10a1ca8347167907e4cf8bbd0204f1
|
2012-04-26 17:54:22+02:00
|
virtio-pci: change virtio balloon PCI class code
Currently the virtio balloon device, when using the virtio-pci interface
advertises itself with PCI class code MEMORY_RAM. This is wrong; the
balloon is vaguely related to memory, but is nothing like a PCI memory
device in the meaning of the class code, and this code is not required
or suggested by the virtio PCI specification.
Worse, this patch causes problems on the pseries machine, because the
firmware, seeing this class code, advertises the device as memory in the
device tree, and then a guest kernel bug causes it to see this "memory"
before the real system memory, leading to a crash in early boot.
This patch fixes the problem by removing the bogus PCI class code on the
balloon device. The backwards compatibility PC machines get new compat
properties so that they don't change.
Cc: Rusty Russell <[email protected]>
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
2ba1d381c2f5f5868fe071b45977c2ed459d78f0
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2ba1d381c2f5f5868fe071b45977c2ed459d78f0
|
2012-04-11 13:24:59+03:00
|
trace: make trace_thread_create() use its function arg
This patch makes trace_thread_create() to use its function arg to
initialize thread. The other choice is to make this a function to use
void arg, but i prefer this way.
Signed-off-by: Jun Koi <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
db3bf8696358e105903b00432cad0aa50d3c0cb6
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/db3bf8696358e105903b00432cad0aa50d3c0cb6
|
2012-03-12 10:12:34+00:00
|
qemu-iotests: update expected results after qemu-img changes
The error message for leaked clusters has changed. qemu-iotests needs to be
updated to pass 026 again.
Signed-off-by: Kevin Wolf <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
|
727822f5b73089bcea48e2d97557e27d1943c7c9
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/727822f5b73089bcea48e2d97557e27d1943c7c9
|
2012-02-22 16:17:03+01:00
|
usb: fix usb_qdev_init() error handling again
Commit f462141f18ffdd75847f6459ef83d90b831d12c0 introduced clean up code
when usb_qdev_init() fails. Unfortunately it calls .handle_destroy()
when .init() was never invoked or failed. This can lead to crashes when
.handle_destroy() tries to clean up things that were never initialized.
This patch is careful to undo only those steps that completed along the
usb_qdev_init() code path. It's not as pretty as the unified error
handling in f462141f18ffdd75847f6459ef83d90b831d12c0 but it's necessary.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
db3a5ed7e4422491dac1f83264ebb01f6667ffc8
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/db3a5ed7e4422491dac1f83264ebb01f6667ffc8
|
2011-12-15 09:27:23-06:00
|
ccid: make threads joinable
Destroying a mutex that another thread might have just unlocked
is racy. It usually works, but you cannot do that in general and
can lead to deadlocks or segfaults. Change ccid to use joinable
threads instead.
(Also, qemu_mutex_init/qemu_cond_init were missing).
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
da5361cc685c004d8bb4e7c5e7b3a52c7aca2c56
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/da5361cc685c004d8bb4e7c5e7b3a52c7aca2c56
|
2011-12-12 17:06:22-06:00
|
qcow2: Cleanups and memleak fix in qcow2_snapshot_create
sn->id_str could be leaked before this. The rest of this patch changes
comments, fixes coding style or removes checks that are unnecessary with
g_malloc.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
|
03343166f703d5c8f02b8519f8493c56e5541ae7
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/03343166f703d5c8f02b8519f8493c56e5541ae7
|
2011-12-05 14:51:36+01:00
|
qemu-char: Plug memory leak on qemu_chr_open_pty() error path
Spotted by Coverity.
Signed-off-by: Markus Armbruster <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
a4e26048526d8d5b181f9a0a7d4f82b8441c5dfd
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a4e26048526d8d5b181f9a0a7d4f82b8441c5dfd
|
2011-11-11 12:49:51-06:00
|
hw/omap_gpio: Fix infinite recursion when doing 8/16 bit reads
Fix a long-standing bug which meant that any attempt to do an
8 or 16 bit read from the OMAP GPIO module would cause qemu to
crash due to an infinite recursion.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
e1556ad5b8143a15c26067c3862fe20631c0053f
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e1556ad5b8143a15c26067c3862fe20631c0053f
|
2011-11-14 11:26:32-06:00
|
hw/arm_timer.c: Fix bounds check for Integrator timer accesses
There are only three counter/timers on the integrator board:
correct the bounds check to avoid an array overrun. (Spotted
by Coverity, see bug 887883).
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
ee71c984342408a357a74f65915bf66484ba445a
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ee71c984342408a357a74f65915bf66484ba445a
|
2011-11-11 12:49:53-06:00
|
qemu-sockets: Plug fd leak on unix_connect_opts() error path
Spotted by Coverity.
Signed-off-by: Markus Armbruster <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
9d9474726274d0e1c420f055849a0e3058cad0e4
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/9d9474726274d0e1c420f055849a0e3058cad0e4
|
2011-11-11 12:49:52-06:00
|
target-xtensa: handle cache options in the overlay tool
Cache options must be enabled for the cores that have cache to avoid
illegal instruction exceptions.
Signed-off-by: Max Filippov <[email protected]>
|
0c852e171b3b6073f5b05b66d8df94eda23f6dee
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0c852e171b3b6073f5b05b66d8df94eda23f6dee
|
2011-11-02 05:05:52+04:00
|
xen_console: fix memory leak
con_init leaks the string "type", fix it.
Signed-off-by: Stefano Stabellini <[email protected]>
Signed-off-by: Alexander Graf <[email protected]>
|
5e6b701aba8689a336297dda047bf760ffc05291
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5e6b701aba8689a336297dda047bf760ffc05291
|
2011-07-17 01:54:25+02:00
|
PPC: Bump MPIC up to 32 supported CPUs
The MPIC emulation is now capable of handling up to 32 CPUs. Reflect that in
the code exporting the numbers out and fix an integer overflow while at it.
Signed-off-by: Alexander Graf <[email protected]>
---
v1 -> v2:
- Max cpus is 15 due to cINT routing
- Report nb_cpus not MAX_CPUS in MPIC capabilities
|
bbc5842211cdd90103cfe52f2ca24afac880694f
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/bbc5842211cdd90103cfe52f2ca24afac880694f
|
2011-10-06 09:43:33+02:00
|
dma-helpers: rewrite completion/cancellation
This fixes various problems with completion/cancellation:
* if the io_func fails to get an AIOCB, the callback wasn't called
* If DMA encounters a bounce buffer conflict, and the DMA operation is
canceled before the bottom half fires, bad things happen.
* memory is not unmapped after cancellation, again causing problems
when doing DMA to I/O areas
* cancellation could leak the iovec
* the callback was missed if the I/O operation failed without returning
an AIOCB
and probably more that I've missed. The patch fixes them by sharing
the cleanup code between completion and cancellation. The dma_bdrv_cb
now returns a boolean completed/not completed flag, and the wrapper
dma_continue takes care of tasks to do upon completion.
Most of these are basically impossible in practice, but it is better
to be tidy...
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
c3adb5b9168a57790b5074489b6f0275ac3cc8b5
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c3adb5b9168a57790b5074489b6f0275ac3cc8b5
|
2011-09-20 12:27:43+02:00
|
Fix subtle integer overflow bug in memory API
It is quite common to have a MemoryRegion with size of INT64_MAX.
When processing alias regions in render_memory_region() it's quite
easy to find a case where it will construct a temporary AddrRange with
a non-zero start, and size still of INT64_MAX. When means attempting
to compute the end of such a range as start + size will result in
signed integer overflow.
This integer overflow means that addrrange_intersects() can
incorrectly report regions as not intersecting when they do. For
example consider the case of address ranges {0x10000000000,
0x7fffffffffffffff} and {0x10010000000, 0x10000000} where the second
is in fact included completely in the first.
This patch rearranges addrrange_intersects() to avoid the integer
overflow, correcting this behaviour.
Signed-off-by: David Gibson <[email protected]>
Signed-off-by: Avi Kivity <[email protected]>
|
d2963631dd54ddf0f46c151b7e3013e39bb78d3b
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d2963631dd54ddf0f46c151b7e3013e39bb78d3b
|
2011-09-14 11:21:58+03:00
|
gt64xxx: fix crash in gt64120_pci_mapping()
The map/unmap code was assymetric - unmap used the local MemoryRegion while
map used isa_mmio_init(), which cannot handle dynamic mappings.
Fix by using isa_mmio_setup() and the local MemoryRegion.
Signed-off-by: Avi Kivity <[email protected]>
Signed-off-by: Edgar E. Iglesias <[email protected]>
|
89da90b1b4acf24a9a3f2fd197b1bdf69ab24e72
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/89da90b1b4acf24a9a3f2fd197b1bdf69ab24e72
|
2011-08-24 21:11:21+02:00
|
qcow2: fix range check
QCowL2Meta::offset is not cluster aligned but only sector aligned
however nb_clusters count cluster from cluster start.
This fix range check. Note that old code have no corruption issues
related to this check cause it only cause intersection to occur
when shouldn't.
Signed-off-by: Frediano Ziglio <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
ee18e730234792b33e01d47939f4c30f29c9744e
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ee18e730234792b33e01d47939f4c30f29c9744e
|
2011-09-12 15:17:22+02:00
|
usb: use iovecs in USBPacket
Zap data pointer from USBPacket, add a QEMUIOVector instead.
Add a bunch of helper functions to manage USBPacket data.
Switch over users to the new interface.
Note that USBPacket->len was used for two purposes: First to
pass in the buffer size and second to return the number of
transfered bytes or the status code on async transfers. There
is a new result variable for the latter. A new status code
was added to catch uninitialized result.
Nobody creates iovecs with more than one element (yet).
Some users are (temporarely) limited to iovecs with a single
element to keep the patch size as small as possible.
Signed-off-by: Gerd Hoffmann <[email protected]>
|
4f4321c11ff6e98583846bfd6f0e81954924b003
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4f4321c11ff6e98583846bfd6f0e81954924b003
|
2011-08-04 15:51:22+02:00
|
configure: Fix bad shell expression for non-Linux hosts
With vhost_net="" (most non-Linux hosts), configure prints an
error message:
test: 2551: =: unexpected operator
Fix this and similar code by adding the missing "".
Cc: Wolfgang Mauerer <[email protected]>
Cc: Stefan Hajnoczi <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
1ba16968ab1920e65303d814ba65793b0a83e93e
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/1ba16968ab1920e65303d814ba65793b0a83e93e
|
2011-08-04 16:43:10-05:00
|
qxl: upon reset, if spice worker is stopped, the command rings can be not empty
Spice worker does no longer process commands when it is stopped.
Otherwise, it might crash during migration when attempting to process
commands while the guest is not completely loaded.
Cc: Alon Levy <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
|
8927cfbba232e28304734f7afd463c1b84134031
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8927cfbba232e28304734f7afd463c1b84134031
|
2011-07-20 10:08:53+02:00
|
print meaningful error message in case of --disable-vhost-net
When qemu gets compiled without support of vhost-net, any attempt
to use it fails with a very clear error message:
qemu-system-x86_64: -netdev ...,vhost=on: vhost-net requested but could not be initialized
there's absolutely no reason given _why_ it coult not be
initialized, and even strace'ing the process in question
does not reveal any errors. So print a message telling
what's going on.
Signed-off-by: Michael Tokarev <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
35f754620615138aaae0ef72602f84c88fd8de0f
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/35f754620615138aaae0ef72602f84c88fd8de0f
|
2011-06-14 16:48:04+03:00
|
usb-ehci: itd handling fixes.
This patch fixes a bunch of issues in the itd descriptor handling.
Most important fix is to handle transfers which cross page borders
correctly by looking up the address of the next page. Luckily the
linux uses physically contigous memory so the data used to hits the
correct location even with this bug instead of corrupting guest
memory. Also the transfer length updates for outgoing transfers wasn't
correct.
While being at it DPRINTFs have been replaced by tracepoints.
The isoch_pause logic has been disabled. Not clear to me which propose
this serves and I think it is incorrect too as we just skip processing
itds. Even when no xfer happens we have to clear the active bit.
Signed-off-by: Gerd Hoffmann <[email protected]>
|
e654887f3880fb0f6d4d40d15d2977de245a6440
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e654887f3880fb0f6d4d40d15d2977de245a6440
|
2011-06-14 12:56:49+02:00
|
e1000: use MII status register for link up/down
Some guests will use the standard MII status register
to verify link state. They will not notice link changes
unless this register is updated.
Verified with Linux 3.0 and Windows XP guests.
Without this patch, ethtool will report speed and duplex as
unknown when the link is down, but still report the link as
up. This is because the Linux e1000 driver checks the
mac_reg[STATUS] register link state before it checks speed
and duplex, but uses the phy_reg[PHY_STATUS] register for
the actual link state check. Fix by updating both registers
on link state changes.
Linux guest before:
(qemu) set_link e1000.0 off
kvm-sid:~# ethtool eth0
Settings for eth0:
Supported ports: [ TP ]
Supported link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
1000baseT/Full
Supports auto-negotiation: Yes
Advertised link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
1000baseT/Full
Advertised pause frame use: No
Advertised auto-negotiation: Yes
Speed: Unknown!
Duplex: Unknown! (255)
Port: Twisted Pair
PHYAD: 0
Transceiver: internal
Auto-negotiation: on
MDI-X: Unknown
Supports Wake-on: umbg
Wake-on: d
Current message level: 0x00000007 (7)
drv probe link
Link detected: yes
(qemu) set_link e1000.0 on
Linux guest after:
(qemu) set_link e1000.0 off
[ 63.384221] e1000: eth0 NIC Link is Down
kvm-sid:~# ethtool eth0
Settings for eth0:
Supported ports: [ TP ]
Supported link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
1000baseT/Full
Supports auto-negotiation: Yes
Advertised link modes: 10baseT/Half 10baseT/Full
100baseT/Half 100baseT/Full
1000baseT/Full
Advertised pause frame use: No
Advertised auto-negotiation: Yes
Speed: Unknown!
Duplex: Unknown! (255)
Port: Twisted Pair
PHYAD: 0
Transceiver: internal
Auto-negotiation: on
MDI-X: Unknown
Supports Wake-on: umbg
Wake-on: d
Current message level: 0x00000007 (7)
drv probe link
Link detected: no
(qemu) set_link e1000.0 on
[ 84.304582] e1000: eth0 NIC Link is Up 1000 Mbps Full Duplex, Flow Control: RX
Signed-off-by: Bjørn Mork <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
d4044c2a6b9ba4a00dd653f515a4b0ebfcb7e125
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d4044c2a6b9ba4a00dd653f515a4b0ebfcb7e125
|
2011-08-22 10:17:51-05:00
|
target-i386: fix helper_fxtract() wrt softfloat
With softfloat it's not possible to play with the overflow of an
unsigned value to get the 0 case partially correct. Use a special case
for that. Using a division to generate an infinity is the easiest way
that works for both softfloat and softfloat-native.
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
|
c9ad19c57b4e35dda507ec636443069048a4ad72
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c9ad19c57b4e35dda507ec636443069048a4ad72
|
2011-04-25 11:18:33+02:00
|
s390x: fix cksm instruction
The cksm instruction was implemented incorrectly, rendering UDP and TCP
checksum calculation wrong, making an emulated s390x Linux guest break
in most networking operations.
This patch fixes odd end checksum calculation, takes the input register
as input for the checksum and optimizes the overflow pieces by a bit.
Signed-off-by: Alexander Graf <[email protected]>
|
5b185639c5740998de403415c749ac98e13418fd
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5b185639c5740998de403415c749ac98e13418fd
|
2011-06-03 13:34:02+02:00
|
Ignore pci unplug requests for unpluggable devices (CVE-2011-1751)
This patch makes qemu ignore unplug requests from the guest for pci
devices which are tagged as non-hotpluggable. Trouble spot is the
piix4 chipset with the ISA bridge. Requests to unplug that one will
make it go away together with all ISA bus devices, which are not
prepared to be unplugged and thus don't cleanup, leaving active
qemu timers behind in free'ed memory.
Signed-off-by: Gerd Hoffmann <[email protected]>
|
505597e4476a6bc219d0ec1362b760d71cb4fdca
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/505597e4476a6bc219d0ec1362b760d71cb4fdca
|
2011-05-19 11:06:49+02:00
|
virtio-blk: fail unaligned requests
Like all block drivers virtio-blk should not allow small than block size
granularity access. But given that the protocol specifies a
byte unit length field we currently accept such requests, which cause
qemu to abort() in lower layers. Add checks to the main read and
write handlers to catch them early.
Reported-by: Conor Murphy <[email protected]>
Tested-by: Conor Murphy <[email protected]>
Signed-off-by: Christoph Hellwig <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
52c050236eaa4f0b5e1d160cd66dc18106445c4d
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/52c050236eaa4f0b5e1d160cd66dc18106445c4d
|
2011-04-07 15:55:06+02:00
|
severe memory leak caused by broken palette_destroy() function
The following commit breaks the code of the function palette_destroy().
http://git.kernel.org/?p=virt/kvm/qemu-kvm.git;a=commit;h=e31e3694afef58ba191cbcc6875ec243e5971268
The broken code causes a severe memory leak of 'VncPalette' structures
because it never frees anything:
70 void palette_destroy(VncPalette *palette)
71 {
72 if (palette == NULL) {
73 qemu_free(palette);
74 }
75 }
Version 2 of the patch calls qemu_free() unconditionally.
Signed-off-by: Ulrich Obergfell <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
d6e58090fed20e30e6966007bc4df0c04324d9e7
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d6e58090fed20e30e6966007bc4df0c04324d9e7
|
2011-03-25 07:28:24-05:00
|
vnc: Fix stack corruption and other bitmap related bugs
Commit bc2429b9174ac2d3c56b7fd35884b0d89ec7fb02 introduced
a severe bug (stack corruption).
bitmap_clear was called with a wrong argument
which caused out-of-bound writes to the local variable width_mask.
This bug was detected with QEMU running on windows.
It also occurs with wine:
*** stack smashing detected ***: terminated
wine: Unhandled illegal instruction at address 0x6115c7 (thread 0009), starting debugger...
The bug is not windows specific!
Instead of fixing the wrong parameter value, bitmap_clear(), bitmap_set
and width_mask were removed, and bitmap_intersect() was replaced by
!bitmap_empty(). The new operation is much shorter and equivalent to
the old operations.
The declarations of the dirty bitmaps in vnc.h were also wrong for 64 bit
hosts because of a rounding effect: for these hosts, VNC_MAX_WIDTH is no
longer a multiple of (16 * BITS_PER_LONG), so the rounded value of
VNC_DIRTY_WORDS was too small.
Fix both declarations by using the macro which is designed for this
purpose.
Cc: Corentin Chary <[email protected]>
Cc: Wen Congyang <[email protected]>
Cc: Gerhard Wiesinger <[email protected]>
Cc: Anthony Liguori <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Anthony Liguori <[email protected]>
|
23bfe28fffd6fff12a39c1ff7274b0dfdecbfa38
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/23bfe28fffd6fff12a39c1ff7274b0dfdecbfa38
|
2011-03-10 16:12:25-06:00
|
ppc405: Fix memory leak
Signed-off-by: Stefan Weil <[email protected]>
Acked-by: Andreas Färber <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
|
e98ccb3fbba94d0b2165caabf7aeee370d4ce900
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e98ccb3fbba94d0b2165caabf7aeee370d4ce900
|
2011-02-20 18:23:07+01:00
|
kvm: x86: Catch and report failing IRQ and NMI injections
We do not need to abort, but the user should be notified that weird
things go on.
Signed-off-by: Jan Kiszka <[email protected]>
Signed-off-by: Marcelo Tosatti <[email protected]>
|
ce377af399563195d066d5fee0c7b717967932ee
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ce377af399563195d066d5fee0c7b717967932ee
|
2011-02-14 12:39:46-02:00
|
Support saturation with shift=0.
This patch fixes corner-case saturations, when the target range is
zero. It merely removes the guard against (sh == 0), and makes:
__ssat(0x87654321, 1) return 0xffffffff and set the saturation flag
__usat(0x87654321, 0) return 0 and set the saturation flag
Signed-off-by: Christophe Lyon <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
|
40d3c433606530ee1bb46ce95a6ca1cf2ee9d9c7
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/40d3c433606530ee1bb46ce95a6ca1cf2ee9d9c7
|
2011-01-26 14:30:24+01:00
|
kvm: Unconditionally reenter kernel after IO exits
KVM requires to reenter the kernel after IO exits in order to complete
instruction emulation. Failing to do so will leave the kernel state
inconsistently behind. To ensure that we will get back ASAP, we issue a
self-signal that will cause KVM_RUN to return once the pending
operations are completed.
We can move kvm_arch_process_irqchip_events out of the inner VCPU loop.
The only state that mattered at its old place was a pending INIT
request. Catch it in kvm_arch_pre_run and also trigger a self-signal to
process the request on next kvm_cpu_exec.
This patch also fixes the missing exit_request check in kvm_cpu_exec in
the CONFIG_IOTHREAD case.
Signed-off-by: Jan Kiszka <[email protected]>
CC: Gleb Natapov <[email protected]>
Signed-off-by: Marcelo Tosatti <[email protected]>
|
9ccfac9ea4b862a75a4270ed32db1f8e314911c5
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/9ccfac9ea4b862a75a4270ed32db1f8e314911c5
|
2011-02-14 12:39:45-02:00
|
blockdev: Fix error message for invalid -drive CHS
When cyls, heads or secs are out of range, the error message prints
buf, which points to the value of option "if". Bogus, may even be
null. Drop that.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
483848540557aef6af08adbe3ef8201b961220d5
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/483848540557aef6af08adbe3ef8201b961220d5
|
2011-01-24 16:49:49+01:00
|
savevm: Fix no_migrate
The no_migrate save state flag is currently only checked in the
last phase of migration. This means that we potentially waste
a lot of time and bandwidth with the live state handlers before
we ever check the no_migrate flags. The error message printed
when we catch a non-migratable device doesn't get printed for
a detached migration. And, no_migrate does nothing to prevent
an incoming migration to a target that includes a non-migratable
device. This attempts to fix all of these.
One notable difference in behavior is that an outgoing migration
now checks for non-migratable devices before ever connecting to
the target system. This means the target will remain listening
rather than exit from failure.
Signed-off-by: Alex Williamson <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
dc9121210eaf34e768901ffc6992dd13062c743a
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/dc9121210eaf34e768901ffc6992dd13062c743a
|
2011-01-17 18:22:17+02:00
|
ARM: linux-user: Restore VFP state from ucontext on sigreturn
Restore the VFP registers from the ucontext on return from a signal
handler in linux-user mode. This means that signal handlers cannot
accidentally corrupt the interrupted code's VFP state, and allows
them to deliberately modify the state via the ucontext structure.
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
5f9099d9cee0e9ed377aee705ca9f4db75e8948d
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5f9099d9cee0e9ed377aee705ca9f4db75e8948d
|
2010-12-03 15:09:39+02:00
|
Add Intel HD Audio support to qemu.
This patch adds three devices to qemu:
intel-hda
Intel HD Audio Controller, the PCI device. Provides a HDA bus.
Emulates ICH6 at the moment. Adding a ICH9 PCIE
variant shouldn't be hard.
hda-duplex
HDA Codec. Attaches to the HDA bus. Supports 16bit stereo,
rates 16k -> 96k, playback, recording and volume control
(with CONFIG_MIXEMU=y).
hda-output
HDA Codec without recording support. Subset of the hda-duplex
codec. Use this if you don't want your guests access your mic.
Usage: add '-device intel-hda -device hda-duplex' to your command line.
Tested guests:
* Linux works.
* Win7 works.
* DOS (mpxplay) works.
* WinXP doesn't work.
[ v2 changes ]
* Fixed endianess, big endian hosts work now.
* Fixed some emulation bugs.
* Added immediate command emulation.
* Added vmstate support.
* Make it behave like all other sound card drivers:
- can be configured via '--audio-card-list=hda'
- can be added to a VM using '-soundhw hda'
* Code style fixups.
* Zapped guest-triggerable asserts.
* Handle partial reads/writes of audio data correctly.
Cc: malc <[email protected]>
Signed-off-by: Gerd Hoffmann <[email protected]>
Signed-off-by: malc <[email protected]>
|
d61a4ce8f01ac9f1810380e043db467d536eeb6b
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d61a4ce8f01ac9f1810380e043db467d536eeb6b
|
2010-11-01 17:57:22+03:00
|
net: delay freeing peer host device
With -netdev, virtio devices present offload
features to guest, depending on the backend used.
Thus, removing host netdev peer while guest is
active leads to guest-visible inconsistency and/or crashes.
As a solution, while guest (NIC) peer device exists,
we prevent the host peer from being deleted.
This patch does this by adding peer_deleted flag in nic state:
if host device is going away while guest device
is around, set this flag and keep a shell of
the host device around for as long as guest device exists.
The link is put down so all packets will get discarded.
At the moment, management can detect that device deletion
is delayed by doing info net. As a next step, we shall add
commands that control hotplug/unplug without
removing the device, and an event to report that
guest has responded to the hotplug event.
Signed-off-by: Michael S. Tsirkin <[email protected]>
Acked-by: Alex Williamson <[email protected]>
|
a083a89d7277f3268a251ce635d9aae5559242bd
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a083a89d7277f3268a251ce635d9aae5559242bd
|
2010-10-06 18:24:37+02:00
|
trace: fix a regex portability problem
The /bin/sh in Milax has problems with the regex:
Error: invalid trace backend
Please choose a supported trace backend.
Fix it by escaping ')' like the regexes with '('.
Signed-off-by: Blue Swirl <[email protected]>
|
2184d75b4a6a253e8b1e002b3dbcc85c20ba6041
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2184d75b4a6a253e8b1e002b3dbcc85c20ba6041
|
2010-09-11 10:43:39+00:00
|
QMP: handle_qmp_command(): Move 'cmd' sanity check
Next commit will change how query commands are handled in a
way that the 'cmd' sanity check is also going to be needed
for query commands handling.
Let's move it out of the else body then.
Signed-off-by: Luiz Capitulino <[email protected]>
|
0fb88582e60e16e809c1aabc2c4b3e1f0832e267
|
qemu
|
devign
| 1 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0fb88582e60e16e809c1aabc2c4b3e1f0832e267
|
2010-10-01 10:20:06-03:00
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.