commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
target/s390x: Allow to enable "idtes" feature for TCG
STFL bit 4 and 5 are just indications to the guest, which TLB entries an
IDTE call will clear. These are performance indicators for the guest.
STFL bit 4:
INVALIDATE DAT TABLE ENTRY (IDTE) performs
the invalidation-and-clearing operation by
selectively clearing TLB segment-table entries
when a segment-table entry or entries are
invalidated. IDTE also performs the clearing-by-
ASCE operation. Unless bit 4 is one, IDTE simply
purges all TLBs. Bit 3 is one if bit 4 is one.
We can simply set STFL bit 4 ("idtes") and still purge the complete TLB.
Purging more than advertised is never bad. E.g. Linux doesn't even care
about this bit. We can optimized this later.
This is helpful, as the z9 base model contains this facility.
STFL bit 5 (clearing TLB region-table-entries) was never implemented on
real HW, therefore we can simply ignore it for now.
Signed-off-by: David Hildenbrand <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
|
19d70587b59f7879a0315a6d98c2409957154351
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/19d70587b59f7879a0315a6d98c2409957154351
|
2017-07-17 14:13:17-07:00
|
qcow2: add iotests to cover LUKS encryption support
This extends the 087 iotest to cover LUKS encryption when doing
blockdev-add.
Two further tests are added to validate read/write of LUKS
encrypted images with a single file and with a backing file.
Reviewed-by: Alberto Garcia <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-id: [email protected]
Signed-off-by: Max Reitz <[email protected]>
|
426d52d88c54cf048385eeb73d802dd87c1317bd
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/426d52d88c54cf048385eeb73d802dd87c1317bd
|
2017-07-11 17:44:56+02:00
|
qcow2: convert QCow2 to use QCryptoBlock for encryption
This converts the qcow2 driver to make use of the QCryptoBlock
APIs for encrypting image content, using the legacy QCow2 AES
scheme.
With this change it is now required to use the QCryptoSecret
object for providing passwords, instead of the current block
password APIs / interactive prompting.
$QEMU \
-object secret,id=sec0,file=/home/berrange/encrypted.pw \
-drive file=/home/berrange/encrypted.qcow2,encrypt.key-secret=sec0
The test 087 could be simplified since there is no longer a
difference in behaviour when using blockdev_add with encrypted
images for the running vs stopped CPU state.
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-id: [email protected]
Reviewed-by: Alberto Garcia <[email protected]>
Signed-off-by: Max Reitz <[email protected]>
|
b25b387fa5928e516cb2c9e7fde68e958bd7e50a
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b25b387fa5928e516cb2c9e7fde68e958bd7e50a
|
2017-07-11 17:44:56+02:00
|
stream: Drop reached_end for stream_complete()
stream_complete() skips the work of rewriting the backing file if
the job was cancelled, if data->reached_end is false, or if there
was an error detected (non-zero data->ret) during the streaming.
But note that in stream_run(), data->reached_end is only set if the
loop ran to completion, and data->ret is only 0 in two cases:
either the loop ran to completion (possibly by cancellation, but
stream_complete checks for that), or we took an early goto out
because there is no bs->backing. Thus, we can preserve the same
semantics without the use of reached_end, by merely checking for
bs->backing (and logically, if there was no backing file, streaming
is a no-op, so there is no backing file to rewrite).
Suggested-by: Kevin Wolf <[email protected]>
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: John Snow <[email protected]>
Reviewed-by: Kevin Wolf <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
158c6492571c82c5632070c7ccee36b3dffd3ca9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/158c6492571c82c5632070c7ccee36b3dffd3ca9
|
2017-07-10 13:18:06+02:00
|
9pfs: local: Add support for custom fmode/dmode in 9ps mapped security modes
In mapped security modes, files are created with very restrictive
permissions (600 for files and 700 for directories). This makes
file sharing between virtual machines and users on the host rather
complicated. Imagine eg. a group of users that need to access data
produced by processes on a virtual machine. Giving those users access
to the data will be difficult since the group access mode is always 0.
This patch makes the default mode for both files and directories
configurable. Existing setups that don't know about the new parameters
keep using the current secure behavior.
Signed-off-by: Tobias Schramm <[email protected]>
Signed-off-by: Greg Kurz <[email protected]>
|
b96feb2cb9b2714bffa342b1d4f39d8db71329ba
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b96feb2cb9b2714bffa342b1d4f39d8db71329ba
|
2017-06-29 15:11:50+02:00
|
include/exec/poison: Mark some CONFIG defines as poisoned, too
These are defined in config-target.h and thus should never be
used in common code.
Signed-off-by: Thomas Huth <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
067b913619ac36299be5ab23921fd19a0347df60
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/067b913619ac36299be5ab23921fd19a0347df60
|
2017-06-15 11:18:39+02:00
|
Convert error_report() to warn_report()
Convert all uses of error_report("warning:"... to use warn_report()
instead. This helps standardise on a single method of printing warnings
to the user.
All of the warnings were changed using these two commands:
find ./* -type f -exec sed -i \
's|error_report(".*warning[,:] |warn_report("|Ig' {} +
Indentation fixed up manually afterwards.
The test-qdev-global-props test case was manually updated to ensure that
this patch passes make check (as the test cases are case sensitive).
Signed-off-by: Alistair Francis <[email protected]>
Suggested-by: Thomas Huth <[email protected]>
Cc: Jeff Cody <[email protected]>
Cc: Kevin Wolf <[email protected]>
Cc: Max Reitz <[email protected]>
Cc: Ronnie Sahlberg <[email protected]>
Cc: Paolo Bonzini <[email protected]>
Cc: Peter Lieven <[email protected]>
Cc: Josh Durgin <[email protected]>
Cc: "Richard W.M. Jones" <[email protected]>
Cc: Markus Armbruster <[email protected]>
Cc: Peter Crosthwaite <[email protected]>
Cc: Richard Henderson <[email protected]>
Cc: "Aneesh Kumar K.V" <[email protected]>
Cc: Greg Kurz <[email protected]>
Cc: Rob Herring <[email protected]>
Cc: Peter Maydell <[email protected]>
Cc: Peter Chubb <[email protected]>
Cc: Eduardo Habkost <[email protected]>
Cc: Marcel Apfelbaum <[email protected]>
Cc: "Michael S. Tsirkin" <[email protected]>
Cc: Igor Mammedov <[email protected]>
Cc: David Gibson <[email protected]>
Cc: Alexander Graf <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Jason Wang <[email protected]>
Cc: Marcelo Tosatti <[email protected]>
Cc: Christian Borntraeger <[email protected]>
Cc: Cornelia Huck <[email protected]>
Cc: Stefan Hajnoczi <[email protected]>
Acked-by: David Gibson <[email protected]>
Acked-by: Greg Kurz <[email protected]>
Acked-by: Cornelia Huck <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed by: Peter Chubb <[email protected]>
Acked-by: Max Reitz <[email protected]>
Acked-by: Marcel Apfelbaum <[email protected]>
Message-Id: <e1cfa2cd47087c248dd24caca9c33d9af0c499b0.1499866456.git.alistair.francis@xilinx.com>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
3dc6f8693694a649a9c83f1e2746565b47683923
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3dc6f8693694a649a9c83f1e2746565b47683923
|
2017-07-13 13:49:58+02:00
|
qapi: Remove visit_start_alternate() parameter promote_int
Before the previous commit, parameter promote_int = true made
visit_start_alternate() with an input visitor avoid QTYPE_QINT
variants and create QTYPE_QFLOAT variants instead. This was used
where QTYPE_QINT variants were invalid.
The previous commit fused QTYPE_QINT with QTYPE_QFLOAT, rendering
promote_int useless and unused.
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
60390d2dc85ffade8981ca41e02335cb07353a6d
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/60390d2dc85ffade8981ca41e02335cb07353a6d
|
2017-06-20 14:31:31+02:00
|
exec: check kvm mmu notifiers earlier
Move kvm mmu notifiers check before calling file_ram_alloc(), with the
other xen precondition. (file_ram_alloc() will be reused in other cases
than -mem-path).
Signed-off-by: Marc-André Lureau <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
e45e7ae281221de48148477fd4f066091995653e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e45e7ae281221de48148477fd4f066091995653e
|
2017-06-15 11:04:04+02:00
|
qemu.py: Don't set _popen=None on error/shutdown
Keep the Popen object around to we can query its exit code later.
To keep the existing 'self._popen is None' checks working, add a
is_running() method, that will check if the process is still running.
Signed-off-by: Eduardo Habkost <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
|
37bbcd575745d9bea4f840164e75dd2f40e5ee91
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/37bbcd575745d9bea4f840164e75dd2f40e5ee91
|
2017-06-05 14:59:09-03:00
|
target/arm: add data cache invalidation cp15 instruction to cortex-r5
The cp15, CRn=15, opc1=0, CRm=5, opc2=0 instruction invalidates all the
data cache on the cortex-r5. Implementing it as a NOP.
Signed-off-by: Luc MICHEL <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
95e9a242e2a393c7d4e5cc04340e39c3a9420f03
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/95e9a242e2a393c7d4e5cc04340e39c3a9420f03
|
2017-06-04 18:42:55+03:00
|
ACPI: don't call acpi_pcihp_device_plug_cb on xen
Commit f0c9d64a exposed the issue that with a xenfv machine using
pci passthrough, acpi pci hotplug code was being executed by mistake.
Guard calls to acpi_pcihp_device_plug_cb (and corresponding
acpi_pcihp_device_unplug_cb) with a check for xen_enabled(). Without
this check I am seeing an error that the bus doesn't have the
acpi-pcihp-bsel property set.
Signed-off-by: Bruce Rogers <[email protected]>
Reviewed-by: Igor Mammedov <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
153eba4726dfa1bdfc31d1fe973b2a61b9035492
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/153eba4726dfa1bdfc31d1fe973b2a61b9035492
|
2017-05-10 22:04:23+03:00
|
numa: Fix format string for "Invalid node" message
Some compilers complain about the PRIu16 format string with the
MAX(src, dst) and MAX_NODES arguments. Example output from Apple LLVM
version 7.3.0 (clang-703.0.31):
numa.c:236:20: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
MAX(src, dst), MAX_NODES);
~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~
include/qapi/error.h:163:35: note: expanded from macro 'error_setg'
(fmt), ## __VA_ARGS__)
^~~~~~~~~~~
glib/2.52.2/include/glib-2.0/glib/gmacros.h:288:20: note: expanded from macro 'MAX'
#define MAX(a, b) (((a) > (b)) ? (a) : (b))
^~~~~~~~~~~~~~~~~~~~~~~~~
numa.c:236:35: warning: format specifies type 'unsigned short' but the argument has type 'int' [-Wformat]
MAX(src, dst), MAX_NODES);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
include/qapi/error.h:163:35: note: expanded from macro 'error_setg'
(fmt), ## __VA_ARGS__)
^~~~~~~~~~~
include/sysemu/sysemu.h:165:19: note: expanded from macro 'MAX_NODES'
#define MAX_NODES 128
^~~
MAX(src, dst) promotes the src and dst arguments to int, and MAX_NODES
is an int. Use %d to silence those warnings.
Signed-off-by: Eduardo Habkost <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
|
f892291eee376505cfec8b6cade7ccf952a6d3e0
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/f892291eee376505cfec8b6cade7ccf952a6d3e0
|
2017-05-30 16:09:58-03:00
|
jazz_led: fix bad snprintf
Detected by GCC 7's -Wformat-truncation. snprintf writes at most
2 bytes here including the terminating NUL, so the result is
truncated. In addition, the newline at the end is pointless.
Fix the buffer size and the format string.
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Reviewed-by: Laurent Vivier <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
e9c6ab62c760e333a6cf0f3f9ab021633723434c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e9c6ab62c760e333a6cf0f3f9ab021633723434c
|
2017-05-10 10:19:24+03:00
|
cpu-exec: update icount after each TB_EXIT
There is no particular reason we shouldn't update the global system
icount time as we exit each TranslationBlock run. This ensures the
main-loop doesn't have to wait until we exit to the outer loop for
executed instructions to be credited to timer_state.
The prepare_icount_for_run function is slightly tweaked to match the
logic we run in cpu_loop_exec_tb.
Based on Paolo's original suggestion.
Signed-off-by: Alex Bennée <[email protected]>
|
eda5f7c6a147c8eb927a6198ec48fe677cb079b3
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/eda5f7c6a147c8eb927a6198ec48fe677cb079b3
|
2017-04-10 10:23:38+01:00
|
s390x/css: provide introspection for virtual subchannel and device busid
Expose the busids of the virtual I/O subchannel and the virtual CCW
device to ease debugging. This is needed because:
1. subchannel id are assigned dynamically, and cannot be set from
outside.
2. device busid could possibly be auto generated.
An example of using HMP to retrieve the property values of a
virtio-balloon-ccw device looks like:
[root@localhost ~]# lscss -d 0.0.0004
Device Subchan. DevType CU Type Use PIM PAM POM CHPIDs
----------------------------------------------------------------------
0.0.0004 0.0.0003 0000/00 3832/05 yes 80 80 ff 00000000 00000000
(qemu) info qtree
... ...
dev: virtio-balloon-ccw, id "balloon0"
devno = "<unset>"
ioeventfd = true
max_revision = 2 (0x2)
dev_id = "fe.0.0004"
subch_id = "fe.0.0003"
... ...
After migration, if we have the same device that shows up on a
different subchannel, we must re-fill the subch_id of the ccw
device with the new schid, or the subch_id will have an old wrong
schid value. So this also re-fills the subch_id after migration.
While we are at it, also neaten the related error handling a bit.
Signed-off-by: Dong Jia Shi <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
|
d8d98db5f07d0a472308c70c3becb56888df156d
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d8d98db5f07d0a472308c70c3becb56888df156d
|
2017-04-21 09:32:09+02:00
|
blkdebug: Add pass-through write_zero and discard support
In order to test the effects of artificial geometry constraints
on operations like write zero or discard, we first need blkdebug
to manage these actions. It also allows us to inject errors on
those operations, just like we can for read/write/flush.
We can also test the contract promised by the block layer; namely,
if a device has specified limits on alignment or maximum size,
then those limits must be obeyed (for now, the blkdebug driver
merely inherits limits from whatever it is wrapping, but the next
patch will further enhance it to allow specific limit overrides).
This patch intentionally refuses to service requests smaller than
the requested alignments; this is because an upcoming patch adds
a qemu-iotest to prove that the block layer is correctly handling
fragmentation, but the test only works if there is a way to tell
the difference at artificial alignment boundaries when blkdebug is
using a larger-than-default alignment. If we let the blkdebug
layer always defer to the underlying layer, which potentially has
a smaller granularity, the iotest will be thwarted.
Tested by setting up an NBD server with export 'foo', then invoking:
$ ./qemu-io
qemu-io> open -o driver=blkdebug blkdebug::nbd://localhost:10809/foo
qemu-io> d 0 15M
qemu-io> w -z 0 15M
Pre-patch, the server never sees the discard (it was silently
eaten by the block layer); post-patch it is passed across the
wire. Likewise, pre-patch the write is always passed with
NBD_WRITE (with 15M of zeroes on the wire), while post-patch
it can utilize NBD_WRITE_ZEROES (for less traffic).
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Message-id: [email protected]
Signed-off-by: Max Reitz <[email protected]>
|
63188c245013dbe383e8b031e665f813e2452ea5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/63188c245013dbe383e8b031e665f813e2452ea5
|
2017-05-11 14:28:06+02:00
|
configure: Don't claim 'unsupported host OS' when better message available
The change in commit 898be3e0415c6d which made completely
unrecognized OSes cause an error_exit "Unsupported host OS"
has some unfortunate unintended effects:
* if you run 'configure --help' on an unsupported host OS
(eg if intending to use it as a build machine for a
cross compile to a supported host) then the message
is printed instead of --help
* if the C compiler doesn't work or is missing (eg if
you passed an incorrect --cross-prefix by mistake)
the message is printed instead of the more useful
'compiler does not exist or does not work' message
Fix this by postponing the error_exit in this situation
until later, when we have already identified the more
useful cases for this.
The long term fix for this would be to move handling
of --help much further up in the configure script,
and make its output not dependent on checks that configure
runs. However for 2.9 this would be too invasive.
Reported-by: Stefan Weil <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Stefan Weil <[email protected]>
Tested-by: Stefan Weil <[email protected]>
|
fb59dabd4fa7e6586824ac3012073b943fc8dc79
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fb59dabd4fa7e6586824ac3012073b943fc8dc79
|
2017-03-30 12:47:03+01:00
|
virtio: invalidate memory in vring_set_avail_event()
Remember to invalidate the avail event field so the memory pages are
marked dirty.
Cc: Paolo Bonzini <[email protected]>
Signed-off-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Tested-by: Eric Auger <[email protected]>
|
3cdf847329a9911780372e6d8239839446d09d9f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3cdf847329a9911780372e6d8239839446d09d9f
|
2017-03-02 07:14:27+02:00
|
target/ppc: Add execute permission checking to access authority check
Basic storage protection defines various access authority permissions
based on a slb storage key and pte pp value pair. This access authority
defines read, write and execute permissions however currently we only
use this to control read and write permissions and ignore the execute
control.
Fix the code to allow execute permissions based on the key-pp value pair.
Execute is allowed under the same conditions which enable reads.
(i.e. read permission -> execute permission)
Signed-off-by: Suraj Jitindar Singh <[email protected]>
Acked-by: David Gibson <[email protected]>
Signed-off-by: David Gibson <[email protected]>
|
347a5c73bafd1b5872c9d3192a4d08f8aa1d5f5a
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/347a5c73bafd1b5872c9d3192a4d08f8aa1d5f5a
|
2017-03-03 11:30:59+11:00
|
hw/intc/arm_gicv3_kvm: Add ICC_SRE_EL1 register to vmstate
To Save and Restore ICC_SRE_EL1 register introduce vmstate
subsection and load only if non-zero.
Also initialize icc_sre_el1 with to 0x7 in pre_load
function.
Signed-off-by: Vijaya Kumar K <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Reviewed-by: Eric Auger <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
6692aac41119906409dfa634ecbe3ef1634b5e5c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/6692aac41119906409dfa634ecbe3ef1634b5e5c
|
2017-02-28 17:10:00+00:00
|
nbd: Tidy up blockdev-add interface
SocketAddress is a simple union, and simple unions are awkward: they
have their variant members wrapped in a "data" object on the wire, and
require additional indirections in C. I intend to limit its use to
existing external interfaces, and convert all internal interfaces to
SocketAddressFlat.
BlockdevOptionsNbd is an external interface using SocketAddress. We
already use SocketAddressFlat elsewhere in blockdev-add. Replace it
by SocketAddressFlat while we can (it's new in 2.9) for simplicity and
consistency. For example,
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"data": { "host": "localhost",
"port": "12345" } } } }
becomes
{ "execute": "blockdev-add",
"arguments": { "node-name": "foo", "driver": "nbd",
"server": { "type": "inet",
"host": "localhost", "port": "12345" } } }
Since the internal interfaces still take SocketAddress, this requires
conversion function socket_address_crumple(). It'll go away when I
update the interfaces.
Unfortunately, SocketAddress is also visible in -drive since 2.8:
-drive if=none,driver=nbd,server.type=inet,server.data.host=127.0.0.1,server.data.port=12345
Nobody should be using it, as it's fairly new and has never been
documented, so adding still more compatibility gunk to keep it working
isn't worth the trouble. You now have to use
-drive if=none,driver=nbd,server.type=inet,server.host=127.0.0.1,server.port=12345
Signed-off-by: Markus Armbruster <[email protected]>
Message-id: [email protected]
[mreitz: Change iotest 147 accordingly]
Because of this interface change, iotest 147 has to be adapted.
Unfortunately, we cannot just flatten all of the addresses because
nbd-server-start still takes a plain SocketAddress. Therefore, we need
both and this is most easily achieved by writing the SocketAddress into
the code and flattening it where necessary.
Signed-off-by: Max Reitz <[email protected]>
Message-id: [email protected]
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Max Reitz <[email protected]>
|
9445673ea67c272616b9f718396e267caa6446b7
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/9445673ea67c272616b9f718396e267caa6446b7
|
2017-04-03 17:11:39+02:00
|
sd: sdhci: mask transfer mode register value
In SDHCI protocol, the transfer mode register is defined
to be of 6 bits. Mask its value with '0x0037' so that an
invalid value could not be assigned.
Signed-off-by: Prasad J Pandit <[email protected]>
Reviewed-by: Alistair Francis <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
8b20aefac4ee8874bb9c8826e4b30e1dc8cd7511
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8b20aefac4ee8874bb9c8826e4b30e1dc8cd7511
|
2017-02-28 12:08:14+00:00
|
test-cutils: Add missing qemu_strtol()... endptr checks
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Philippe Mathieu-Daudé <[email protected]>
Message-Id: <[email protected]>
|
73245450b302931ad291de5d8d0f0cb5e9ca3ee6
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/73245450b302931ad291de5d8d0f0cb5e9ca3ee6
|
2017-02-23 20:35:35+01:00
|
virtio: add MemoryListener to cache ring translations
The cached translations are RCU-protected to allow efficient use
when processing virtqueues.
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
c611c76417f52b335ecaab01c61743e3b705eb7c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c611c76417f52b335ecaab01c61743e3b705eb7c
|
2017-02-17 21:52:30+02:00
|
target-ppc: Add MMU model check for booke machines
Machines bamboo, e500 and virtex-ml507 assume a certain MMU model,
otherwise resulting in unpredictable behavior. Add apropriate checks
into *_init functions.
Signed-off-by: Valentin Plotkin <[email protected]>
[regarding virtex parts]
Reviewed-by: Edgar E. Iglesias <[email protected]>
Tested-by: Edgar E. Iglesias <[email protected]>
Signed-off-by: David Gibson <[email protected]>
|
00469dc3731e3d08536cd119c14dbdf149fed3e4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/00469dc3731e3d08536cd119c14dbdf149fed3e4
|
2017-02-02 09:30:06+11:00
|
Changing error message of QMP 'migrate_set_downtime' to seconds
Using QMP, the error message of 'migrate_set_downtime' was displaying
the values in milliseconds, being misleading with the command that
accepts the value in seconds:
{ "execute": "migrate_set_downtime", "arguments": {"value": 3000}}
{"error": {"class": "GenericError", "desc": "Parameter 'downtime_limit'
expects an integer in the range of 0 to 2000000 milliseconds"}}
This message is also seen in HMP when trying to set the same
parameter:
(qemu) migrate_set_parameter downtime-limit 3000000
Parameter 'downtime_limit' expects an integer in the range of 0 to
2000000 milliseconds
To allow for a proper error message when using QMP, a validation
of the user input was added in 'qmp_migrate_set_downtime'.
Signed-off-by: Daniel Henrique Barboza <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Juan Quintela <[email protected]>
Signed-off-by: Dr. David Alan Gilbert <[email protected]>
|
87c9cc1c30d2981e9686aaf245b3e2420062f7d4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/87c9cc1c30d2981e9686aaf245b3e2420062f7d4
|
2017-02-28 11:29:00+00:00
|
target-sparc: replace the last tlb entry when no free entries left
Implement the behavior described in the chapter 13.9.11 of
UltraSPARC T1™ Supplement to the UltraSPARC Architecture 2005:
"If a TLB Data-In replacement is attempted with all TLB
entries locked and valid, the last TLB entry (entry 63) is
replaced."
Signed-off-by: Artyom Tarasenko <[email protected]>
|
4797a6851975c1239df440c5f01d8566e63717bb
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/4797a6851975c1239df440c5f01d8566e63717bb
|
2017-01-18 22:03:44+01:00
|
net: optimize checksum computation
Very simple loop optimization with a significant performance impact.
Microbenchmark results, modern x86-64:
buffer size | speed up
------------+---------
1500 | 1.7x
64 | 1.5x
8 | 1.15x
Microbenchmark results, POWER7:
buffer size | speed up
------------+---------
1500 | 5x
64 | 3.3x
8 | 1.13x
There is a lot of room for further improvement at the expense of
code complexity - aligned multibyte reads, LE/BE considerations,
architecture-specific optimizations, etc. This patch still keeps
things simple and readable.
Signed-off-by: Ladi Prosek <[email protected]>
Reviewed-by: Dmitry Fleytman <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
|
d5aa3e6e0cd6259003790769c448d4fbb5b5c810
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d5aa3e6e0cd6259003790769c448d4fbb5b5c810
|
2017-01-20 10:36:38+08:00
|
virtio-crypto: avoid one cryptodev device is used by multiple virtio crypto devices
Add the check condition for cryptodev device in order
to avoid one cryptodev device is used by multiple
virtio crypto devices.
Signed-off-by: Gonglei <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
b89f8c80ccdaf6915271df6bb16ef6b292f47f9f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b89f8c80ccdaf6915271df6bb16ef6b292f47f9f
|
2017-01-10 07:02:52+02:00
|
linux-aio: poll ring for completions
The Linux AIO userspace ABI includes a ring that is shared with the
kernel. This allows userspace programs to process completions without
system calls.
Add an AioContext poll handler to check for completions in the ring.
Signed-off-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Paolo Bonzini <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
ee68697551cd81186c5b12eba10c158350cf1165
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ee68697551cd81186c5b12eba10c158350cf1165
|
2017-01-03 16:38:48+00:00
|
qcow2: Allow 'cache-clean-interval' in Linux only
The cache-clean-interval option of qcow2 only works on Linux. However
we allow setting it in other systems regardless of whether it works or
not.
In those systems this option is not simply a no-op: it actually
invalidates perfectly valid cache tables for no good reason without
freeing their memory.
This patch forbids using that option in non-Linux systems.
Signed-off-by: Alberto Garcia <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
91203f08f0ca66f1a6aba1d0e5ef62ed98fb3234
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/91203f08f0ca66f1a6aba1d0e5ef62ed98fb3234
|
2016-11-25 13:51:30+01:00
|
nvdimm acpi: rename nvdimm_acpi_hotplug
Rename it to nvdimm_plug()
Suggested-by: Igor Mammedov <[email protected]>
Signed-off-by: Xiao Guangrong <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Igor Mammedov <[email protected]>
|
284197e41f0fe98d58ce5e8acd4966c91f28c4bd
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/284197e41f0fe98d58ce5e8acd4966c91f28c4bd
|
2016-11-15 17:20:37+02:00
|
nvdimm acpi: fix two comments
fixed the English issue and code-style issue
Suggested-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Xiao Guangrong <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Igor Mammedov <[email protected]>
|
7adbce633908fd093e24eee50018898dc11802cc
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7adbce633908fd093e24eee50018898dc11802cc
|
2016-11-15 17:20:37+02:00
|
virtio: allow per-device-class legacy features
Legacy features are those that transitional devices only
expose on the legacy interface.
Allow different ones per device class.
Cc: [email protected] # dependency for the next patch
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Cornelia Huck <[email protected]>
|
9b706dbbbb81f5cb7c67e491d38cd6077205e056
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/9b706dbbbb81f5cb7c67e491d38cd6077205e056
|
2016-11-15 17:20:36+02:00
|
nvdimm acpi: clean up nvdimm_build_acpi
To make the code more clearer, we
1) check ram_slots first, and build ssdt & nfit only when it is available
2) use nvdimm_get_plugged_device_list() to check if there is nvdimm device
plugged
Suggested-by: Igor Mammedov <[email protected]>
Signed-off-by: Xiao Guangrong <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Igor Mammedov <[email protected]>
|
264813cb9d0eea199d48c6ea917060683685d1e0
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/264813cb9d0eea199d48c6ea917060683685d1e0
|
2016-11-15 17:20:37+02:00
|
block: Assert that bdrv_release_dirty_bitmap succeeded
We use a loop over bs->dirty_bitmaps to make sure the caller is
only releasing a bitmap owned by bs. Let's also assert that in this case
the caller is releasing a bitmap that does exist.
Signed-off-by: Fam Zheng <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: John Snow <[email protected]>
Message-id: [email protected]
Signed-off-by: Max Reitz <[email protected]>
|
7105007a5c8ae6228d78487e1e382d53863ab2c9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7105007a5c8ae6228d78487e1e382d53863ab2c9
|
2016-10-24 17:56:07+02:00
|
target-sparc: Use MMU_PHYS_IDX for bypass asis
Tested-by: Mark Cave-Ayland <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
|
7f87c90527d7363e8cecf1c6b5ad3d4cc85d3d28
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7f87c90527d7363e8cecf1c6b5ad3d4cc85d3d28
|
2016-10-31 09:46:25-06:00
|
acpi nvdimm: fix wrong buffer size returned by DSM method
Currently, 'RLEN' is the totally buffer size written by QEMU and it is
ACPI internally used only. The buffer size returned to guest should
not include 'RLEN' itself
Signed-off-by: Xiao Guangrong <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
d51d1d7edeb869e0010d6b3833bd53ad561ff805
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d51d1d7edeb869e0010d6b3833bd53ad561ff805
|
2016-11-01 19:21:08+02:00
|
scripts/clean-includes: added duplicate #include check
Enhance the clean-includes script to optionally check for duplicate #include
entries.
Script might output false positive entries as well. Such entries should
not be removed. So if it finds any duplicate entries script will
terminate with an exit status 1. Then each and every file should be
checked manually and corrected if necessary.
In order to enable the check use --check-dup-head option with
scripts/clean-includes.
Reviewed-by: Thomas Huth <[email protected]>
Signed-off-by: Anand J <[email protected]>
Signed-off-by: Michael Tokarev <[email protected]>
|
d66253e46ae2b9c36a9dd90b2b74c0dfa5804b22
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d66253e46ae2b9c36a9dd90b2b74c0dfa5804b22
|
2016-10-28 18:17:23+03:00
|
target-i386: emulate LOCK'ed NEG using cmpxchg helper
[rth: Move redundant qemu_load out of cmpxchg loop.]
Signed-off-by: Emilio G. Cota <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
|
8eb8c7385608b99bed6055a22d897ff727a6cb8e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8eb8c7385608b99bed6055a22d897ff727a6cb8e
|
2016-10-26 08:29:01-07:00
|
block: Pass unaligned discard requests to drivers
Discard is advisory, so rounding the requests to alignment
boundaries is never semantically wrong from the data that
the guest sees. But at least the Dell Equallogic iSCSI SANs
has an interesting property that its advertised discard
alignment is 15M, yet documents that discarding a sequence
of 1M slices will eventually result in the 15M page being
marked as discarded, and it is possible to observe which
pages have been discarded.
Between commits 9f1963b and b8d0a980, we converted the block
layer to a byte-based interface that ultimately ignores any
unaligned head or tail based on the driver's advertised
discard granularity, which means that qemu 2.7 refuses to
pass any discard request smaller than 15M down to the Dell
Equallogic hardware. This is a slight regression in behavior
compared to earlier qemu, where a guest executing discards
in power-of-2 chunks used to be able to get every page
discarded, but is now left with various pages still allocated
because the guest requests did not align with the hardware's
15M pages.
Since the SCSI specification says nothing about a minimum
discard granularity, and only documents the preferred
alignment, it is best if the block layer gives the driver
every bit of information about discard requests, rather than
rounding it to alignment boundaries early.
Rework the block layer discard algorithm to mirror the write
zero algorithm: always peel off any unaligned head or tail
and manage that in isolation, then do the bulk of the request
on an aligned boundary. The fallback when the driver returns
-ENOTSUP for an unaligned request is to silently ignore that
portion of the discard request; but for devices that can pass
the partial request all the way down to hardware, this can
result in the hardware coalescing requests and discarding
aligned pages after all.
Reported by: Peter Lieven <[email protected]>
CC: [email protected]
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
3482b9bc411a9a12b2efde1018e1ddc906cd817e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3482b9bc411a9a12b2efde1018e1ddc906cd817e
|
2016-11-22 15:59:23+01:00
|
net: pcnet: check rx/tx descriptor ring length
The AMD PC-Net II emulator has set of control and status(CSR)
registers. Of these, CSR76 and CSR78 hold receive and transmit
descriptor ring length respectively. This ring length could range
from 1 to 65535. Setting ring length to zero leads to an infinite
loop in pcnet_rdra_addr() or pcnet_transmit(). Add check to avoid it.
Reported-by: Li Qiang <[email protected]>
Signed-off-by: Prasad J Pandit <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
|
34e29ce754c02bb6b3bdd244fbb85033460feaff
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/34e29ce754c02bb6b3bdd244fbb85033460feaff
|
2016-10-26 09:57:59+08:00
|
intel-iommu: Check IOAPIC's Trigger Mode against the one in IRTE
The Trigger Mode field of IOAPIC must match the Trigger Mode in
the IRTE according to VT-d Spec 5.1.5.1.
Signed-off-by: Feng Wu <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
Reviewed-by: Peter Xu <[email protected]>
|
dea651a95af6dad0997b840241a0bf6059d9a776
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/dea651a95af6dad0997b840241a0bf6059d9a776
|
2016-10-10 02:38:14+03:00
|
block: Drop aio/cache consistency check from qmp_blockdev_add()
The TODO comment has been addressed a while ago and this is now checked
in raw-posix, so we don't have to special case this in blockdev-add any
more.
Signed-off-by: Kevin Wolf <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
|
0ffcdd9c06343a3fe0b2b3e1ca93ce8aa5366f98
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0ffcdd9c06343a3fe0b2b3e1ca93ce8aa5366f98
|
2016-09-29 14:13:38+02:00
|
target-i386: Remove has_msr_* global vars for KVM features
The global variables are not necessary because we can check KVM
feature flags in X86CPU directly.
Reviewed-by: Paolo Bonzini <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
|
55c911a58069e3742d35462d8c4e961dd6a2ba93
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/55c911a58069e3742d35462d8c4e961dd6a2ba93
|
2016-09-27 17:03:34-03:00
|
target-i386: Remove has_msr_hv_tsc global variable
The global variable is not necessary because we can check
cpu->hyperv_time directly.
We just need to ensure cpu->hyperv_time will be cleared if the
feature is not really being exposed to the guest due to missing
KVM_CAP_HYPERV_TIME capability.
Reviewed-by: Paolo Bonzini <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
|
3ddcd2edc8ca708ccd808a78424b9aadebd4f7c4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/3ddcd2edc8ca708ccd808a78424b9aadebd4f7c4
|
2016-09-27 17:03:34-03:00
|
target-i386: Clear KVM CPUID features if KVM is disabled
This will ensure all checks for features[FEAT_KVM] in the code
will be correct in case the KVM CPUID leaf is completely
disabled.
Reviewed-by: Paolo Bonzini <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
|
aec661de86894e914d2d82431d9cefa9a9a40213
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/aec661de86894e914d2d82431d9cefa9a9a40213
|
2016-09-27 17:03:34-03:00
|
tests: add a simple /vhost-user/multiqueue test
This test just checks that 2 virtio-net queues can be setup over
vhost-user and waits for them to be started.
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
ed0a8d92527195bd6009096533e7d0cd8be6fca1
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ed0a8d92527195bd6009096533e7d0cd8be6fca1
|
2016-09-23 18:51:40+03:00
|
iotest 055: refactor and speed up
Source disk is created and filled with test data before each test case.
Instead initialize it once for the whole unit.
Test disk filling patterns are merged into one pattern.
Also TestSetSpeed used different image_len for source and target (by
mistake) - this is automatically fixed here.
Signed-off-by: Vladimir Sementsov-Ogievskiy <[email protected]>
Message-id: [email protected]
Reviewed-by: Pavel Butsykin <[email protected]>
Reviewed-by: Max Reitz <[email protected]>
Signed-off-by: Max Reitz <[email protected]>
|
819cec0114eeca80444a21f2e3526ef62d729385
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/819cec0114eeca80444a21f2e3526ef62d729385
|
2016-09-20 22:12:57+02:00
|
crypto: use uint64_t for pbkdf iteration count parameters
The qcrypto_pbkdf_count_iters method uses a 64 bit int
but then checks its value against INT32_MAX before
returning it. This bounds check is premature, because
the calling code may well scale the iteration count
by some value. It is thus better to return a 64-bit
integer and let the caller do range checking.
For consistency the qcrypto_pbkdf method is also changed
to accept a 64bit int, though this is somewhat academic
since nettle is limited to taking an 'int' while gcrypt
is limited to taking a 'long int'.
Reviewed-by: Eric Blake <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
|
59b060be184aff59cfa101c937c8139e66f452f2
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/59b060be184aff59cfa101c937c8139e66f452f2
|
2016-09-19 16:30:42+01:00
|
filter-rewriter: rewrite tcp packet to keep secondary connection
We will rewrite tcp packet secondary received and sent.
When colo guest is a tcp server.
Firstly, client start a tcp handshake. the packet's seq=client_seq,
ack=0,flag=SYN. COLO primary guest get this pkt and mirror(filter-mirror)
to secondary guest, secondary get it use filter-redirector.
Then,primary guest response pkt
(seq=primary_seq,ack=client_seq+1,flag=ACK|SYN).
secondary guest response pkt
(seq=secondary_seq,ack=client_seq+1,flag=ACK|SYN).
In here,we use filter-rewriter save the secondary_seq to it's tcp connection.
Finally handshake,client send pkt
(seq=client_seq+1,ack=primary_seq+1,flag=ACK).
Here,filter-rewriter can get primary_seq, and rewrite ack from primary_seq+1
to secondary_seq+1, recalculate checksum. So the secondary tcp connection
kept good.
When we send/recv packet.
client send pkt(seq=client_seq+1+data_len,ack=primary_seq+1,flag=ACK|PSH).
filter-rewriter rewrite ack and send to secondary guest.
primary guest response pkt
(seq=primary_seq+1,ack=client_seq+1+data_len,flag=ACK)
secondary guest response pkt
(seq=secondary_seq+1,ack=client_seq+1+data_len,flag=ACK)
we rewrite secondary guest seq from secondary_seq+1 to primary_seq+1.
So tcp connection kept good.
In code We use offset( = secondary_seq - primary_seq )
to rewrite seq or ack.
handle_primary_tcp_pkt: tcp_pkt->th_ack += offset;
handle_secondary_tcp_pkt: tcp_pkt->th_seq -= offset;
Signed-off-by: Zhang Chen <[email protected]>
Signed-off-by: Li Zhijian <[email protected]>
Signed-off-by: Wen Congyang <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
|
30656b097e9dd7978d3fe9416cb9f5a421a9e63e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/30656b097e9dd7978d3fe9416cb9f5a421a9e63e
|
2016-09-27 17:54:22+08:00
|
Revert "megasas: remove useless check for cmd->frame"
This reverts commit 8cc46787b5b58f01a11c919c7ff939ed009e27fc.
It turns out that cmd->frame can be NULL and thus the commit
can cause a SIGSEGV
Reported-by: Holger Schranz <[email protected]>
Cc: [email protected]
Signed-off-by: Paolo Bonzini <[email protected]>
|
421cc3e7e89cb807d3c5f6de486abb2167c8e792
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/421cc3e7e89cb807d3c5f6de486abb2167c8e792
|
2016-09-13 19:09:43+02:00
|
fpu: add mechanism to check for invalid long double formats
All operations that take a floatx80 as an operand need to have their
inputs checked for malformed encodings. In all of these cases, use the
function floatx80_invalid_encoding to perform the check. If an invalid
operand is found, raise an invalid operation exception, and then return
either NaN (for fp-typed results) or the integer indefinite value (the
minimum representable signed integer value, for int-typed results).
For the non-quiet comparison operations, this touches adjacent code in
order to pass style checks.
Signed-off-by: Andrew Dutcher <[email protected]>
Reviewed-by: Peter Maydell <[email protected]>
Message-id: [email protected]
[PMM: changed "1 << 63" to "1ULL << 63" to fix compile errors]
Signed-off-by: Peter Maydell <[email protected]>
|
d1eb8f2acba579830cf3798c3c15ce51be852c56
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/d1eb8f2acba579830cf3798c3c15ce51be852c56
|
2016-09-15 12:43:18+01:00
|
checkpatch: Fix whitespace checks for documentation code blocks
Prevent blank lines in documentation code blocks to be signalled as
incorrect trailing whitespace.
Code blocks in documentation are 4-column aligned, and blank lines in
them should have exactly 4 columns of trailing whitespace to prevent
QEMU's wiki to render them as separate code blocks.
Signed-off-by: Lluís Vilanova <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
Signed-off-by: Lluís Vilanova <[email protected]>
|
0cebabd5e8277864ef87b4526cb1c9b3f0c06ee7
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0cebabd5e8277864ef87b4526cb1c9b3f0c06ee7
|
2016-09-13 19:09:44+02:00
|
sclpconsolelm: remove bogus check for -EAGAIN
The write_console_data() method in sclpconsole-lm.c checks
whether the return value of qemu_chr_fe_write() has the
value of -EAGAIN and if so then increments the buffer offset
by the value of EAGAIN. Fortunately qemu_chr_fe_write() will
never return EAGAIN directly, rather it returns -1 with
errno set to EAGAIN, so this broken code path was not
reachable. The behaviour on EAGAIN was stil bad though,
causing the write_console_data() to busy_wait repeatedly
calling qemu_chr_fe_write() with no sleep between iters.
Just remove all this loop logic and replace with a call
to qemu_chr_fe_write_all().
Acked-by: Cornelia Huck <[email protected]>
Signed-off-by: Daniel P. Berrange <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
7983e829336f68b6df6952dd4b03493b1486fcf5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7983e829336f68b6df6952dd4b03493b1486fcf5
|
2016-09-13 19:09:42+02:00
|
vmw_pvscsi: check page count while initialising descriptor rings
Vmware Paravirtual SCSI emulation uses command descriptors to
process SCSI commands. These descriptors come with their ring
buffers. A guest could set the page count for these rings to
an arbitrary value, leading to infinite loop or OOB access.
Add check to avoid it.
Reported-by: Tom Victor <[email protected]>
Signed-off-by: Prasad J Pandit <[email protected]>
Message-Id: <[email protected]>
Cc: [email protected]
Signed-off-by: Paolo Bonzini <[email protected]>
|
7f61f4690dd153be98900a2a508b88989e692753
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7f61f4690dd153be98900a2a508b88989e692753
|
2016-09-13 19:08:46+02:00
|
scsi: pvscsi: limit loop to fetch SG list
In PVSCSI paravirtual SCSI bus, pvscsi_convert_sglist can take a very
long time or go into an infinite loop due to two different bugs:
1) the request descriptor data length is defined to be 64 bit. While
building SG list from a request descriptor, it gets truncated to 32bit
in routine 'pvscsi_convert_sglist'. This could lead to an infinite loop
situation large 'dataLen' values when data_length is cast to uint32_t and
chunk_size becomes always zero. Fix this by removing the incorrect cast.
2) pvscsi_get_next_sg_elem can be called arbitrarily many times if the
element has a zero length. Get out of the loop early when this happens,
by introducing an upper limit on the number of SG list elements.
Reported-by: Li Qiang <[email protected]>
Signed-off-by: Prasad J Pandit <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
49adc5d3f8c6bb75e55ebfeab109c5c37dea65e8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/49adc5d3f8c6bb75e55ebfeab109c5c37dea65e8
|
2016-09-13 19:08:47+02:00
|
crypto: use glib as fallback for hash algorithm
GLib >= 2.16 provides GChecksum API which is good enough
for md5, sha1, sha256 and sha512. Use this as a final
fallback if neither nettle or gcrypt are available. This
lets us remove the stub hash impl, and so callers can
be sure those 4 algs are always available at compile
time. They may still be disabled at runtime, so a check
for qcrypto_hash_supports() is still best practice to
report good error messages.
Signed-off-by: Daniel P. Berrange <[email protected]>
|
2165477c0f65d20fdfbdb2ddcd4e0e7fe8f61df5
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2165477c0f65d20fdfbdb2ddcd4e0e7fe8f61df5
|
2016-07-21 10:46:27+01:00
|
vhost: don't set vring call if no vector
We used to set vring call fd unconditionally even if guest driver does
not use MSIX for this vritqueue at all. This will cause lots of
unnecessary userspace access and other checks for drivers does not use
interrupt at all (e.g virtio-net pmd). So check and clean vring call
fd if guest does not use any vector for this virtqueue at
all.
Perf diffs (on rx) shows lots of cpus wasted on vhost_signal() were saved:
#
28.12% -27.82% [vhost] [k] vhost_signal
14.44% -1.69% [kernel.vmlinux] [k] copy_user_generic_string
7.05% +1.53% [kernel.vmlinux] [k] __free_page_frag
6.51% +5.53% [vhost] [k] vhost_get_vq_desc
...
Pktgen tests shows 15.8% improvement on rx pps and 6.5% on tx pps.
Before: RX 2.08Mpps TX 1.35Mpps
After: RX 2.41Mpps TX 1.44Mpps
Signed-off-by: Jason Wang <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
96a3d98d2cdbd897ff5ab33427aa4cfb94077665
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/96a3d98d2cdbd897ff5ab33427aa4cfb94077665
|
2016-09-09 20:58:34+03:00
|
spapr: Prevent boot CPU core removal
Boot CPU is assumed to be always present in QEMU code. So
until that assumptions are gone, deny removal request.
In another words, QEMU won't support boot CPU core hot-unplug.
Signed-off-by: Bharata B Rao <[email protected]>
[dwg: Tweaked error message for clarity]
Signed-off-by: David Gibson <[email protected]>
|
62be8b044adf47327ebefdefb25f28a40316ebd0
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/62be8b044adf47327ebefdefb25f28a40316ebd0
|
2016-07-29 12:02:31+10:00
|
vhost-user: check qemu_chr_fe_set_msgfds() return value
Check qemu_chr_fe_set_msgfds() for errors, to make sure the message to
be sent is correct.
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
6fab2f3f6064ad0a712c6d9213b9151bcc87c3d6
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/6fab2f3f6064ad0a712c6d9213b9151bcc87c3d6
|
2016-07-29 00:33:48+03:00
|
vhost: add assert() to check runtime behaviour
All these functions must be called only after the backend is connected.
They are called from virtio-net.c, after either virtio or link status
change.
The check for nc->peer->link_down should ensure vhost_net_{start,stop}()
are always called between vhost_user_{start,stop}().
Signed-off-by: Marc-André Lureau <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
8695de0fcf739b2071018d933b407ed8c16f40e8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8695de0fcf739b2071018d933b407ed8c16f40e8
|
2016-07-29 00:33:48+03:00
|
CODING_STYLE, checkpatch: update line length rules
Line lengths above 80 characters do exist. They are rare, but
they happen from time to time. An ignored rule is worse than an
exception to the rule, so do the latter.
Some on the list expressed their preference for a soft limit that
is slightly lower than 80 characters, to account for extra characters
in unified diffs (including three-way diffs) and for email quoting.
However, there was no consensus on this so keep the 80-character
soft limit and add a hard limit at 90.
Acked-by: Cornelia Huck <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
8fbe3d1fcfa16c543f49f24e7cdfbf0024459341
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8fbe3d1fcfa16c543f49f24e7cdfbf0024459341
|
2016-08-10 12:22:33+02:00
|
target-sparc: Use explicit writes to cpu_fsr
By arranging for explicit writes to cpu_fsr after floating point
operations, we are able to mark the helpers as not writing to
tcg globals, which means that we don't need to invalidate the
integer register set across said calls.
Tested-by: Mark Cave-Ayland <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
|
7385aed20db5d83979f683b9d0048674411e963c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7385aed20db5d83979f683b9d0048674411e963c
|
2016-07-12 11:02:52-07:00
|
linux-user: Clean up hostdep.h header guards
These headers all use QEMU_HOSTDEP_H as header guard symbol. Reuse of
the same guard symbol in multiple headers is okay as long as they
cannot be included together.
Since we can avoid guard symbol reuse easily, do so: use guard symbol
$target_HOSTDEP_H for linux-user/host/$target/hostdep.h.
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Richard Henderson <[email protected]>
|
59e96bcbf904aa05185ac4161a65306dc26cda31
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/59e96bcbf904aa05185ac4161a65306dc26cda31
|
2016-07-12 16:19:16+02:00
|
s390x/pci: acceleration for getting S390pciState
There are a number of places where the code needs to get the instance
of S390pciState. It calls object_resolve_path() every time. This
wastes a lot of time and leads to low performance. Thus we add
s390_get_phb() to improve it.
Because we always have a phb, we remove all return checkings in the
callers and add an assert in s390_get_phb() to make sure that phb is
getted successfully.
Signed-off-by: Yi Min Zhao <[email protected]>
Reviewed-by: Pierre Morel <[email protected]>
Signed-off-by: Cornelia Huck <[email protected]>
|
e7d336959b7c01699702dcda4b54a822972d74a8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e7d336959b7c01699702dcda4b54a822972d74a8
|
2016-07-11 09:48:05+02:00
|
block: Wording tweaks to write zeroes limits
Improve the documentation of the write zeroes limits, to mention
additional constraints that drivers should observe. Worth squashing
into commit cf081fca, if that hadn't been pushed already :)
Signed-off-by: Eric Blake <[email protected]>
Reviewed-by: Fam Zheng <[email protected]>
Signed-off-by: Kevin Wolf <[email protected]>
|
29cc6a6834add5cddbc391d07c1b3ace2ad9b8eb
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/29cc6a6834add5cddbc391d07c1b3ace2ad9b8eb
|
2016-07-05 16:46:25+02:00
|
ICH9 LPC: handle GSI as qdev GPIO
The ICH9 LPC bridge has 24 output IRQs connected to GSI. Currently the IRQs are
referenced by pointers. The pointers are initialized at startup by direct access
to the structure fields. This violates Qemu device model.
The patch makes the IRQs handling to use GPIO model.
Signed-off-by: Efimov Vasily <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
f999c0de05103ccd91b3efff282eaa1c0ea93015
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/f999c0de05103ccd91b3efff282eaa1c0ea93015
|
2016-06-29 14:03:46+02:00
|
cadence_uart: Protect against transmit errors
If qemu_chr_fe_write() returns an error (represented by a negative
number) we should skip incrementing the count and initiating a
memmove().
Signed-off-by: Alistair Francis <[email protected]>
Reported-by: Peter Maydell <[email protected]>
Message-id: 667e5dc534d33338fcfc2471e5aa32fe7cbd13dc.1466546703.git.alistair.francis@xilinx.com
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
f6cf41932edf260c2574346a08358ad2d20c357e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/f6cf41932edf260c2574346a08358ad2d20c357e
|
2016-06-27 15:37:32+01:00
|
nvdimm acpi: support Get Namespace Label Size function
Function 4 is used to get Namespace label size
Reviewed-by: Stefan Hajnoczi <[email protected]>
Signed-off-by: Xiao Guangrong <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
5797dcdc7ade30e8c4080d9282cd9e51b3566e14
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/5797dcdc7ade30e8c4080d9282cd9e51b3566e14
|
2016-06-24 05:13:57+03:00
|
qapi: Add new visit_free() function
Making each visitor provide its own (awkwardly-named) FOO_cleanup()
is unusual, when we can instead have a polymorphic visit_free()
interface. Over the next few patches, we can use the polymorphic
functions to eliminate the need for a FOO_get_visitor() function
for accessing specific visitor functionality, once everything can
be accessed directly through the Visitor* interfaces.
The dealloc visitor is the first one converted to completely use
the new entry point, since qapi_dealloc_visitor_cleanup() was the
only reason that qapi_dealloc_get_visitor() existed, and only
generated and testsuite code was even using it. With the new
visit_free() entry point in place, we no longer need to expose
the QapiDeallocVisitor subtype through qapi_dealloc_visitor_new(),
and can get by with less generated code, with diffs that look like:
| void qapi_free_ACPIOSTInfo(ACPIOSTInfo *obj)
| {
|- QapiDeallocVisitor *qdv;
| Visitor *v;
|
| if (!obj) {
| return;
| }
|
|- qdv = qapi_dealloc_visitor_new();
|- v = qapi_dealloc_get_visitor(qdv);
|+ v = qapi_dealloc_visitor_new();
| visit_type_ACPIOSTInfo(v, NULL, &obj, NULL);
|- qapi_dealloc_visitor_cleanup(qdv);
|+ visit_free(v);
|}
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
2c0ef9f411ae6081efa9eca5b3eab2dbeee45a6c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/2c0ef9f411ae6081efa9eca5b3eab2dbeee45a6c
|
2016-07-06 10:52:04+02:00
|
nvdimm acpi: abstract the operations for root & nvdimm devices
It separates the operations between root device and nvdimm devices
in order to introducing label functions support for nvdimm device
Signed-off-by: Xiao Guangrong <[email protected]>
Reviewed-by: Stefan Hajnoczi <[email protected]>
Reviewed-by: Michael S. Tsirkin <[email protected]>
Signed-off-by: Michael S. Tsirkin <[email protected]>
|
189f4d56356f0301c9e61c7d35ec8c03c69e7133
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/189f4d56356f0301c9e61c7d35ec8c03c69e7133
|
2016-06-24 05:13:57+03:00
|
target-i386: Move features logic that requires CPUState to realize time
Making x86_cpu_parse_featurestr() a pure convertor
of legacy feature string into global properties, needs
it to be called before a CPU instance is created so
parser shouldn't modify CPUState directly or access
it at all. Hence move current hack that directly pokes
into CPUState, to set/unset +-feats, from parser to
CPU's realize method.
Signed-off-by: Igor Mammedov <[email protected]>
Reviewed-by: Eduardo Habkost <[email protected]>
Signed-off-by: Eduardo Habkost <[email protected]>
|
dc15c0517b010a9444a2c05794dae980f2a2cbd9
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/dc15c0517b010a9444a2c05794dae980f2a2cbd9
|
2016-06-14 16:17:09-03:00
|
linux-user: Use __get_user() and __put_user() to handle structs in do_fcntl()
Use the __get_user() and __put_user() to handle reading and writing the
guest structures in do_ioctl(). This has two benefits:
* avoids possible errors due to misaligned guest pointers
* correctly sign extends signed fields (like l_start in struct flock)
which might be different sizes between guest and host
To do this we abstract out into copy_from/to_user functions. We
also standardize on always using host flock64 and the F_GETLK64
etc flock commands, as this means we always have 64 bit offsets
whether the host is 64-bit or 32-bit and we don't need to support
conversion to both host struct flock and struct flock64.
In passing we fix errors in converting l_type from the host to
the target (where we were doing a byteswap of the host value
before trying to do the convert-bitmasks operation rather than
otherwise, and inexplicably shifting left by 1); these were
accidentally left over when the original simple "just shift by 1"
arm<->x86 conversion of commit 43f238d was changed to the more
general scheme of using target_to_host_bitmask() functions in 2ba7f73.
[RV: fixed ifdef guard for eabi functions]
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Laurent Vivier <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
213d3e9ea27f7fc55db7272c05255294b52ed3e4
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/213d3e9ea27f7fc55db7272c05255294b52ed3e4
|
2016-06-26 13:16:41+03:00
|
virtio-blk: Remove op blocker for dataplane
Block layer is prepared to unspecialize dataplane, an evidence is this
almost complete list of unblocked operations. It has all types except
two (actually three if DATAPLANE itself counts but blockdev.c makes sure
attaching twice is not possible): MIRROR_TARGET and BACKUP_TARGET.
blockdev-mirror refuses to start if target is attached, so the first is
not a problem.
By removing BACKUP_TARGET, blockdev-backup will become permissive to
write to a virtio-blk dataplane disk, but that is not worse than
non-dataplane given the latter is already possible. In either case,
blockdev.c always checks the target and source are on the same
AioContext, or bring them together if possible.
Signed-off-by: Fam Zheng <[email protected]>
Acked-by: Michael S. Tsirkin <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
348295838384941d1e5420d10e57366c4e303d45
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/348295838384941d1e5420d10e57366c4e303d45
|
2016-06-07 14:40:51+01:00
|
hw/arm/virt: Reject gic-version=host for non-KVM
If you try to gic-version=host with TCG on a KVM aarch64 host,
qemu segfaults, since host requires KVM APIs.
Explicitly reject gic-version=host if KVM is not enabled
https://bugzilla.redhat.com/show_bug.cgi?id=1339977
Signed-off-by: Cole Robinson <[email protected]>
Message-id: b1b3b0dd143b7995a7f4062966b80a2cf3e3c71e.1464273085.git.crobinso@redhat.com
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
0bf8039dca6bfecec243a13ebcd224d3941d9242
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0bf8039dca6bfecec243a13ebcd224d3941d9242
|
2016-06-06 16:59:29+01:00
|
i.MX: Fix FEC code for ECR register reset value.
According to the FEC chapter of i.MX25 reference manual ECR register is
initialized at 0xf0000000 at reset time.
We fix the value.
Signed-off-by: Jean-Christophe Dubois <[email protected]>
Signed-off-by: Jason Wang <[email protected]>
|
ccdb81d3274d281d770703417257bd40bcdf4c0e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ccdb81d3274d281d770703417257bd40bcdf4c0e
|
2016-06-02 10:42:46+08:00
|
linux-user: Queue synchronous signals separately
If a synchronous signal and an asynchronous signal arrive near simultaneously,
and the signal number of the asynchronous signal is lower than that of the
synchronous signal the the handler for the asynchronous would be called first,
and then the handler for the synchronous signal would be called within or
after the first handler with an incorrect context.
This is fixed by queuing synchronous signals separately. Note that this does
risk delaying a asynchronous signal until the synchronous signal handler
returns rather than handling the signal on another thread, but this seems
unlikely to cause problems for real guest programs and is unavoidable unless
we could guarantee to roll back and reexecute whatever guest instruction
caused the synchronous signal (which would be a bit odd if we've already
logged its execution, for instance, and would require careful analysis of
all guest CPUs to check it was possible in all cases).
Signed-off-by: Timothy Edward Baldwin <[email protected]>
Message-id: 1441497448-32489-24-git-send-email-T.E.Baldwin99@members.leeds.ac.uk
[PMM: added a comment]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
655ed67c2a248cf0a887229d8492d6ddc0518545
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/655ed67c2a248cf0a887229d8492d6ddc0518545
|
2016-06-07 16:39:07+03:00
|
hw/ptimer: Fix issues caused by the adjusted timer limit value
Multiple issues here related to the timer with a adjusted .limit value:
1) ptimer_get_count() returns incorrect counter value for the disabled
timer after loading the counter with a small value, because adjusted limit
value is used instead of the original.
For instance:
1) ptimer_stop(t)
2) ptimer_set_period(t, 1)
3) ptimer_set_limit(t, 0, 1)
4) ptimer_get_count(t) <-- would return 10000 instead of 0
2) ptimer_get_count() might return incorrect value for the timer running
with a adjusted limit value.
For instance:
1) ptimer_stop(t)
2) ptimer_set_period(t, 1)
3) ptimer_set_limit(t, 10, 1)
4) ptimer_run(t)
5) ptimer_get_count(t) <-- might return value > 10
3) Neither ptimer_set_period() nor ptimer_set_freq() are adjusting the
limit value, so it is still possible to make timer timeout value
arbitrary small.
For instance:
1) ptimer_set_period(t, 10000)
2) ptimer_set_limit(t, 1, 0)
3) ptimer_set_period(t, 1) <-- bypass limit correction
Fix all of the above issues by adjusting timer period instead of the limit.
Perform the adjustment for periodic timer only. Use the delta value instead
of the limit to make decision whether adjustment is required, as limit could
be altered while timer is running, resulting in incorrect value returned by
ptimer_get_count.
Signed-off-by: Dmitry Osipenko <[email protected]>
Reviewed-by: Peter Crosthwaite <[email protected]>
Message-id: cd141f74f5737480ec586b9c7d18cce1d69884e2.1464367869.git.digetx@gmail.com
Signed-off-by: Peter Maydell <[email protected]>
|
e91171e30235ae99ab8060988aa3c9536692bba8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e91171e30235ae99ab8060988aa3c9536692bba8
|
2016-06-06 16:59:30+01:00
|
docs/atomics: update atomic_read/set comparison with Linux
Recently Linux did a mass conversion of its atomic_read/set calls
so that they at least are READ/WRITE_ONCE. See Linux's commit
62e8a325 ("atomic, arch: Audit atomic_{read,set}()"). It seems though
that their documentation hasn't been updated to reflect this.
The appended updates our documentation to reflect the change, which
means there is effectively no difference between our atomic_read/set
and the current Linux implementation.
While at it, fix the statement that a barrier is implied by
atomic_read/set, which is incorrect. Volatile/atomic semantics prevent
transformations pertaining the variable they apply to; this, however,
has no effect on surrounding statements like barriers do. For more
details on this, see:
https://gcc.gnu.org/onlinedocs/gcc/Volatiles.html
Signed-off-by: Emilio G. Cota <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
56ebe02203f033a8399f7f6ea6972225ed87101c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/56ebe02203f033a8399f7f6ea6972225ed87101c
|
2016-05-29 09:11:11+02:00
|
linux-user: Support for restarting system calls for UniCore32 targets
Update the UniCore32 main loop code:
* on TARGET_ERESTARTSYS, wind guest PC backwards to repeat syscall insn
* handle TARGET_QEMU_ESIGRETURN in the main loop as the indication
that the main loop should not touch any guest CPU state
(We don't support signals on this target so there is no sigreturn code
to update.)
Signed-off-by: Timothy Edward Baldwin <[email protected]>
Message-id: 1441497448-32489-30-git-send-email-T.E.Baldwin99@members.leeds.ac.uk
Reviewed-by: Peter Maydell <[email protected]>
[PMM: tweak commit message; drop TARGET_USE_ERESTARTSYS define]
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
256cb6af7f04ae385883408084b3ef989e2423d8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/256cb6af7f04ae385883408084b3ef989e2423d8
|
2016-05-27 14:49:50+03:00
|
linux-user: Support for restarting system calls for SH4 targets
Update the SH4 main loop and sigreturn code:
* on TARGET_ERESTARTSYS, wind guest PC backwards to repeat syscall insn
* set all guest CPU state within signal.c code on sigreturn
* handle TARGET_QEMU_ESIGRETURN in the main loop as the indication
that the main loop should not touch any guest CPU state
Signed-off-by: Timothy Edward Baldwin <[email protected]>
Message-id: 1441497448-32489-12-git-send-email-T.E.Baldwin99@members.leeds.ac.uk
Reviewed-by: Peter Maydell <[email protected]>
[PMM: tweak commit message; drop TARGET_USE_ERESTARTSYS define]
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
ba41249678f8c1504bf07706ddb0eda0d36cccc2
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/ba41249678f8c1504bf07706ddb0eda0d36cccc2
|
2016-05-27 14:49:49+03:00
|
scripts/signrom.py: Allow option ROM checksum script to write the size header.
Modify the signrom.py script so that if the size byte in the header is
0 (ie. not set) then the script will set the size. If the size byte
is non-zero then we do the same as before, so this doesn't require
changes to any existing ROM sourcecode.
Signed-off-by: Richard W.M. Jones <[email protected]>
Message-Id: <[email protected]>
|
6f71b779c8b05cf60ea0fffbcd8c02adfe845ece
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/6f71b779c8b05cf60ea0fffbcd8c02adfe845ece
|
2016-05-23 16:53:45+02:00
|
scripts/signrom.py: Check for magic in option ROMs.
Because of the risk that compilers might not emit the asm() block at
the beginning of the option ROM, check that the ROM contains the
required magic signature.
Signed-off-by: Richard W.M. Jones <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Paolo Bonzini <[email protected]>
|
fd28938b7adb33f8af11849cdd0d0b2fb92990e3
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fd28938b7adb33f8af11849cdd0d0b2fb92990e3
|
2016-05-23 16:53:45+02:00
|
linux-user: Support for restarting system calls for SPARC targets
Update the SPARC main loop and sigreturn code:
* on TARGET_ERESTARTSYS, wind guest PC backwards to repeat syscall insn
* set all guest CPU state within signal.c code on sigreturn
* handle TARGET_QEMU_ESIGRETURN in the main loop as the indication
that the main loop should not touch any guest CPU state
Signed-off-by: Timothy Edward Baldwin <[email protected]>
Message-id: 1441497448-32489-9-git-send-email-T.E.Baldwin99@members.leeds.ac.uk
[PMM: Commit message tweaks; drop TARGET_USE_ERESTARTSYS define]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
Signed-off-by: Riku Voipio <[email protected]>
|
c0bea68f9ea48f0dea7a06a259a613bfd3a7e35e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/c0bea68f9ea48f0dea7a06a259a613bfd3a7e35e
|
2016-05-27 14:49:49+03:00
|
Use &error_fatal when initializing crypto on qemu-{img,io,nbd}
In addition to making the code simpler, this will replace the
long error messages:
cannot initialize crypto: Unable to initialize GNUTLS library: [...]
cannot initialize crypto: Unable to initialize gcrypt
with shorter messages:
Unable to initialize GNUTLS library: [...]
Unable to initialize gcrypt
Signed-off-by: Eduardo Habkost <[email protected]>
|
e8f2d2722eb84a809697e82c762d39c8c13f22f6
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e8f2d2722eb84a809697e82c762d39c8c13f22f6
|
2016-05-20 14:28:55-03:00
|
target-arm: Split data abort syndrome generator
Split the data abort syndrome generator into two versions:
One with a valid Instruction Specific Syndrome (ISS) and another without.
The following new flags are supported by the syndrome generator
with ISS:
* isv - Instruction syndrome valid
* sas - Syndrome access size
* sse - Syndrome sign extend
* srt - Syndrome register transfer
* sf - Sixty-Four bit register width
* ar - Acquire/Release
These flags are not yet used, so this patch has no functional change
except that we will now correctly set the IL bit in data abort
syndromes without ISS information.
Signed-off-by: Edgar E. Iglesias <[email protected]>
Message-id: [email protected]>
[PMM: squashed in with patch which was just adding the IL bit]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
094d028a7968236cd2b7f7b96394f7a3b8ad97c8
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/094d028a7968236cd2b7f7b96394f7a3b8ad97c8
|
2016-05-12 13:22:26+01:00
|
tcg: Clean up direct block chaining data fields
Briefly describe in a comment how direct block chaining is done. It
should help in understanding of the following data fields.
Rename some fields in TranslationBlock and TCGContext structures to
better reflect their purpose (dropping excessive 'tb_' prefix in
TranslationBlock but keeping it in TCGContext):
tb_next_offset => jmp_reset_offset
tb_jmp_offset => jmp_insn_offset
tb_next => jmp_target_addr
jmp_next => jmp_list_next
jmp_first => jmp_list_first
Avoid using a magic constant as an invalid offset which is used to
indicate that there's no n-th jump generated.
Signed-off-by: Sergey Fedorov <[email protected]>
Signed-off-by: Sergey Fedorov <[email protected]>
Reviewed-by: Alex Bennée <[email protected]>
Signed-off-by: Richard Henderson <[email protected]>
|
f309101c26b59641fc1aa8fb2a98a5441cdaea03
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/f309101c26b59641fc1aa8fb2a98a5441cdaea03
|
2016-05-12 14:06:41-10:00
|
qmp-input: Don't consume input when checking has_member
Commit e8316d7 mistakenly passed consume=true within
qmp_input_optional() when checking if an optional member was
present, but the mistake was silently ignored since the code
happily let us extract a member more than once. Fix
qmp_input_optional() to not consume anything, then tighten up
the input visitor to ensure that a member is consumed exactly
once (all generated code follows this pattern; and the new
assert will catch any hand-written code that tries to visit
the same key more than once).
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
e5826a2fd727f0be54a81083f31fe02a275465cd
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/e5826a2fd727f0be54a81083f31fe02a275465cd
|
2016-05-12 09:47:54+02:00
|
tcg: check for CONFIG_DEBUG_TCG instead of NDEBUG
Check for CONFIG_DEBUG_TCG instead of NDEBUG, drop now useless code.
Cc: Richard Henderson <[email protected]>
Signed-off-by: Aurelien Jarno <[email protected]>
Message-id: [email protected]
Reviewed-by: Peter Maydell <[email protected]>
Signed-off-by: Peter Maydell <[email protected]>
|
8d8fdbae010aa75a23f0307172e81034125aba6e
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/8d8fdbae010aa75a23f0307172e81034125aba6e
|
2016-04-21 15:43:20+01:00
|
MAINTAINERS: Delete invalid maintainer entries of the Exynos section
Mails to these e-mail addresses are rejected by the mail server
of Samsung with "User unknown" messages, so it seems like these
Exynos maintainers are no longer available.
Signed-off-by: Thomas Huth <[email protected]>
Message-id: [email protected]
Signed-off-by: Peter Maydell <[email protected]>
|
57528a3fef2fd65661320723ad8c3c781f4fd49f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/57528a3fef2fd65661320723ad8c3c781f4fd49f
|
2016-03-31 18:21:01+01:00
|
hw/mips_malta: add CPS to Malta board
If the user specifies smp > 1 and the CPU with CM GCR support, then
create Coherent Processing System (which takes care of instantiating CPUs)
rather than CPUs directly and connect i8259 and cbus to the pins exposed by
CPS. However, there is no GIC yet, thus CPS exposes CPU's IRQ pins so use
the same pin numbers as before.
Signed-off-by: Leon Alrae <[email protected]>
|
bff384a4fbd5d0e86939092e74e766ef0f5f592c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/bff384a4fbd5d0e86939092e74e766ef0f5f592c
|
2016-03-30 09:13:59+01:00
|
ivshmem: Compile debug prints unconditionally to prevent bit-rot
Signed-off-by: Markus Armbruster <[email protected]>
Reviewed-by: Marc-André Lureau <[email protected]>
Message-Id: <[email protected]>
|
a4fa93bf20a4be3377df6ac9c9d63cccc31ab68c
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/a4fa93bf20a4be3377df6ac9c9d63cccc31ab68c
|
2016-03-21 21:29:00+01:00
|
slirp: Adding ICMPv6 error sending
Adding icmp6_send_error to send ICMPv6 Error messages. This function is
simpler than the v4 version.
Adding some calls in various functions to send ICMP errors, when a
received packet is too big, or when its hop limit is 0.
Signed-off-by: Yann Bordenave <[email protected]>
Signed-off-by: Samuel Thibault <[email protected]>
Reviewed-by: Thomas Huth <[email protected]>
|
fc6c9257c6dd47316a1c55d356bcd89bdc5fd642
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/fc6c9257c6dd47316a1c55d356bcd89bdc5fd642
|
2016-03-15 10:35:04+01:00
|
backup: Use Bitmap to replace "s->bitmap"
"s->bitmap" tracks done sectors, we only check bit states without using any
iterator which HBitmap is good for. Switch to "Bitmap" which is simpler and
more memory efficient.
Meanwhile, rename it to done_bitmap, to reflect the intention.
Signed-off-by: Fam Zheng <[email protected]>
Reviewed-by: John Snow <[email protected]>
Message-id: [email protected]
Signed-off-by: Max Reitz <[email protected]>
|
b2f56462d51a49c28d2a7b214b3ae8e8d3329f1f
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/b2f56462d51a49c28d2a7b214b3ae8e8d3329f1f
|
2016-03-14 17:35:05+01:00
|
trace: drop trailing empty strings
Also fix a typo in the virtio_balloon_handle_output() trace while here.
[The double-quoting was a limitation of the old tracetool.sh script.
The modern tracetool.py script does not require double-quotes at the end
of the line. See commit cf85cf8e972f3ad79f203be4edb7968d6e052293
("trace: Format strings must begin/end with double quotes").
--Stefan]
Signed-off-by: Greg Kurz <[email protected]>
Reviewed-by: Eric Blake <[email protected]>
Reviewed-by: Markus Armbruster <[email protected]>
Message-id: [email protected]
Signed-off-by: Stefan Hajnoczi <[email protected]>
|
6411dd13349a6430dcefec7b96986ad0b8c6e7ff
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/6411dd13349a6430dcefec7b96986ad0b8c6e7ff
|
2016-03-01 13:20:15+00:00
|
qapi: Use strict QMP input visitor in more places
The following uses of a QMP input visitor should be strict
(that is, excess keys in QDict input should be flagged if not
converted to QAPI):
- Testsuite code unrelated to explicitly testing non-strict
mode (test-qmp-commands, test-visitor-serialization); since
we want more code to be strict by default, having more tests
of strict mode doesn't hurt
- Code used for cloning QAPI objects (replay-input.c,
qemu-sockets.c); we are reparsing a QObject just barely
produced by the qmp output visitor and which therefore should
not have any garbage, so while it is extra work to be strict,
it validates that our clone is correct [note that a later patch
series will simplify these two uses by creating an actual
clone visitor that is much more efficient than a
generate/reparse cycle]
- qmp_object_add(), which calls into user_creatable_add_type().
Since command line parsing for '-object' uses the same
user_creatable_add_type() through the OptsVisitor, and that is
always strict, we want to ensure that any nested dictionaries
would be treated the same in QMP and from the command line (I
don't actually know if such nested dictionaries exist). Note
that on this code change, strictness only matters for nested
dictionaries (if even possible), since we already flag excess
input at the top level during an earlier object_property_set()
on an unknown key, whether from QemuOpts:
$ ./x86_64-softmmu/qemu-system-x86_64 -nographic -nodefaults -qmp stdio -object secret,id=sec0,data=letmein,format=raw,foo=bar
qemu-system-x86_64: -object secret,id=sec0,data=letmein,format=raw,foo=bar: Property '.foo' not found
or from QMP:
$ ./x86_64-softmmu/qemu-system-x86_64 -nographic -nodefaults -qmp stdio
{"QMP": {"version": {"qemu": {"micro": 93, "minor": 5, "major": 2}, "package": ""}, "capabilities": []}}
{"execute":"qmp_capabilities"}
{"return": {}}
{"execute":"object-add","arguments":{"qom-type":"secret","id":"sec0","props":{"format":"raw","data":"letmein","foo":"bar"}}}
{"error": {"class": "GenericError", "desc": "Property '.foo' not found"}}
The only remaining uses of non-strict input visits are:
- QMP 'qom-set' (which eventually executes
object_property_set_qobject()) - mark it as something to revisit
in the future (I didn't want to spend any more time on this patch
auditing if we have any QOM dictionary properties that might be
impacted, and couldn't easily prove whether this code path is
shared with anything else).
- test-qmp-input-visitor: explicit tests of non-strict mode. If
we later get rid of users that don't need strictness, then this
test should be merged with test-qmp-input-strict
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
240f64b6dc3346d044d7beb7cc3a53668ce47384
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/240f64b6dc3346d044d7beb7cc3a53668ce47384
|
2016-05-12 09:47:54+02:00
|
qapi: Adjust names of implicit types
The original choice of ':obj-' as the prefix for implicit types
made it obvious that we weren't going to clash with any user-defined
names, which cannot contain ':'. But now we want to create structs
for implicit types, to get rid of special cases in the generators,
and our use of ':' in implicit names needs a tweak to produce valid
C code.
We could transliterate ':' to '_', except that C99 mandates that
"identifiers that begin with an underscore are always reserved for
use as identifiers with file scope in both the ordinary and tag name
spaces". So it's time to change our naming convention: we can
instead use the 'q_' prefix that we reserved for ourselves back in
commit 9fb081e0. Technically, since we aren't planning on exposing
the empty type in generated code, we could keep the name ':empty',
but renaming it to 'q_empty' makes the check for startswith('q_')
cover all implicit types, whether or not code is generated for them.
As long as we don't declare 'empty' or 'obj' ticklish, it shouldn't
clash with c_name() prepending 'q_' to the user's ticklish names.
Signed-off-by: Eric Blake <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Markus Armbruster <[email protected]>
|
7599697c66d22ff4c859ba6ccea30e6a9aae6b9b
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/7599697c66d22ff4c859ba6ccea30e6a9aae6b9b
|
2016-03-18 10:29:25+01:00
|
sd.c: Handle NULL block backend in sd_get_inserted()
The sd.c SD card emulation code can be in a state where the
SDState BlockBackend pointer is NULL; this is treated as
"card not present". Add a missing check to sd_get_inserted()
so that we don't segfault in this situation.
(This could be provoked by the guest writing to the SDHCI
register to do a reset on a xilinx-zynq-a9 board; it will
also happen at startup when sdhci implements its DeviceClass
reset method.)
Signed-off-by: Peter Maydell <[email protected]>
Reviewed-by: Alistair Francis <[email protected]>
Message-id: [email protected]
|
0719e71e5297f68b6b4500aa74e1b49d59806342
|
qemu
|
devign
| 0 |
https://github.com/qemu/qemu
|
https://github.com/qemu/qemu/commit/0719e71e5297f68b6b4500aa74e1b49d59806342
|
2016-03-04 11:30:17+00:00
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.