commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
block/curl: Drop TFTP "support" Because TFTP does not support byte ranges, it was never usable with our curl block driver. Since apparently nobody has ever complained loudly enough for someone to take care of the issue until now, it seems reasonable to assume that nobody has ever actually used it. Therefore, it should be safe to just drop it from curl's protocol list. [Jeff Cody: Below is additional summary pulled, with some rewording, from followup emails between Max and Markus, to explain what worked and what didn't] TFTP would sometimes work, to a limited extent, for images <= the curl "readahead" size, so long as reads started at offset zero. By default, that readahead size is 256KB. Reads starting at a non-zero offset would also have returned data from a zero offset. It can become more complicated still, with mixed reads at zero offset and non-zero offsets, due to data buffering. In short, TFTP could only have worked before in very specific scenarios with unrealistic expectations and constraints. Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Reviewed-by: Jeff Cody <[email protected]> Message-id: [email protected] Signed-off-by: Jeff Cody <[email protected]>
23dce3873f3aee6ee7d4a1c17dd26fb5f453bc5a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/23dce3873f3aee6ee7d4a1c17dd26fb5f453bc5a
2016-11-14 22:47:34-05:00
acpi nvdimm: fix Arg6 usage As the function only has 5 args, we use local7 instead of it Suggested-by: Igor Mammedov <[email protected]> Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
48bee47697c6bf89e9e58e65829337f8ce7b6e46
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/48bee47697c6bf89e9e58e65829337f8ce7b6e46
2016-11-01 19:21:08+02:00
nbd: Refactor conversion to errno to silence checkpatch Checkpatch complains that 'return EINVAL' is usually wrong (since we tend to favor 'return -EINVAL'). But it is a false positive for nbd_errno_to_system_errno(). Since NBD may add future defined wire values, refactor the code to keep checkpatch happy. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
8b34a9dbc3f2c0afe3450cb20b94cc30f450e77b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8b34a9dbc3f2c0afe3450cb20b94cc30f450e77b
2016-11-02 09:28:56+01:00
COLO: Add checkpoint-delay parameter for migrate-set-parameters Add checkpoint-delay parameter for migrate-set-parameters, so that we can control the checkpoint frequency when COLO is in periodic mode. Cc: Luiz Capitulino <[email protected]> Cc: Eric Blake <[email protected]> Cc: Markus Armbruster <[email protected]> Signed-off-by: zhanghailiang <[email protected]> Signed-off-by: Li Zhijian <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Amit Shah <[email protected]> Signed-off-by: Amit Shah <[email protected]>
68b5359187c3d4164cc546dcdd5ba3e37f0ffb55
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/68b5359187c3d4164cc546dcdd5ba3e37f0ffb55
2016-10-30 15:17:39+05:30
virtio-scsi: always use dataplane path if ioeventfd is active Override start_ioeventfd and stop_ioeventfd to start/stop the whole dataplane logic. This has some positive side effects: - no need anymore for virtio_add_queue_aio (i.e. a revert of commit 1c627137c10ee2dcf59e0383ade8a9abfa2d4355) - no need anymore to switch from generic ioeventfd handlers to dataplane It detects some errors better: $ qemu-system-x86_64 -object iothread,id=io \ -device virtio-scsi-pci,ioeventfd=off,iothread=io qemu-system-x86_64: -device virtio-scsi-pci,ioeventfd=off,iothread=io: ioeventfd is required for iothread while previously it would have started just fine. Reviewed-by: Cornelia Huck <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
ad07cd69ecaffbaa015459a46975ab32e50df805
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ad07cd69ecaffbaa015459a46975ab32e50df805
2016-10-30 19:51:32+02:00
vfio: Add support for mmapping sub-page MMIO BARs Now the kernel commit 05f0c03fbac1 ("vfio-pci: Allow to mmap sub-page MMIO BARs if the mmio page is exclusive") allows VFIO to mmap sub-page BARs. This is the corresponding QEMU patch. With those patches applied, we could passthrough sub-page BARs to guest, which can help to improve IO performance for some devices. In this patch, we expand MemoryRegions of these sub-page MMIO BARs to PAGE_SIZE in vfio_pci_write_config(), so that the BARs could be passed to KVM ioctl KVM_SET_USER_MEMORY_REGION with a valid size. The expanding size will be recovered when the base address of sub-page BAR is changed and not page aligned any more in guest. And we also set the priority of these BARs' memory regions to zero in case of overlap with BARs which share the same page with sub-page BARs in guest. Signed-off-by: Yongji Xie <[email protected]> Signed-off-by: Alex Williamson <[email protected]>
95251725e335af2b885e2ab33dd29c86f8084663
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/95251725e335af2b885e2ab33dd29c86f8084663
2016-10-31 09:53:04-06:00
sun4uv: fix serial initialization regression Since commit b6607a1a204d, serial_hds_isa_init() was introduced to factor out serial_isa_init() loops. However, sun4uv shouldn't start from 0 when there is a mm serial on 0 already. Add a "from" argument to serial_hds_isa_init(). Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
4496dc49ec9a6e24e9eeb2da970ed0ec0051968e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4496dc49ec9a6e24e9eeb2da970ed0ec0051968e
2016-10-24 15:27:20+02:00
tests/docker: test-build script Much like test-quick but only builds. This is useful for some of the build targets like ThreadSanitizer that don't yet pass "make check". Signed-off-by: Alex Bennée <[email protected]> Message-Id: <[email protected]> Signed-off-by: Fam Zheng <[email protected]>
bdecba6e978b950873255f5185dcbe2632aaa6fd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bdecba6e978b950873255f5185dcbe2632aaa6fd
2016-10-17 10:05:48+08:00
target-i386: Enable CPUID[0x8000000A] if SVM is enabled SVM needs CPUID[0x8000000A] to be available. So if SVM is enabled in a CPU model or explicitly in the command-line, adjust CPUID xlevel to expose the CPUID[0x8000000A] leaf. Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
0c3d7c0051576d220e6da0a8ac08f2d8482e2f0b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0c3d7c0051576d220e6da0a8ac08f2d8482e2f0b
2016-09-27 16:17:17-03:00
char: update read handler in all cases In commit ac1b84dd1 (rhbz#1027181), a check was added to only update the "read handler" when the front-end is opened, because the read callbacks were not restored when a device is plugged. However, this seems not correct, the handler is correctly set back on hotplug (in virtconsole_realize) and the bug can no longer be reproduced. Calling chr_update_read_handler() allows to fix the mux driver to stop calling the child handlers (which may be going to be destroyed). Signed-off-by: Marc-André Lureau <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
6a7b2b21008f271e7a91e937e521e22f94579bb9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6a7b2b21008f271e7a91e937e521e22f94579bb9
2016-10-04 10:00:26+02:00
net: mcf: limit buffer descriptor count ColdFire Fast Ethernet Controller uses buffer descriptors to manage data flow to/fro receive & transmit queues. While transmitting packets, it could continue to read buffer descriptors if a buffer descriptor has length of zero and has crafted values in bd.flags. Set upper limit to number of buffer descriptors. Reported-by: Li Qiang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Jason Wang <[email protected]>
070c4b92b8cd5390889716677a0b92444d6e087a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/070c4b92b8cd5390889716677a0b92444d6e087a
2016-09-27 17:54:22+08:00
tcg: Make tb_flush() thread safe Use async_safe_run_on_cpu() to make tb_flush() thread safe. This is possible now that code generation does not happen in the middle of execution. It can happen that multiple threads schedule a safe work to flush the translation buffer. To keep statistics and debugging output sane, always check if the translation buffer has already been flushed. Signed-off-by: Sergey Fedorov <[email protected]> Signed-off-by: Sergey Fedorov <[email protected]> [AJB: minor re-base fixes] Signed-off-by: Alex Bennée <[email protected]> Message-Id: <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
3359baad36889b83df40b637ed993a4b816c4906
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3359baad36889b83df40b637ed993a4b816c4906
2016-09-27 11:57:30+02:00
tcg: Prepare TB invalidation for lockless TB lookup When invalidating a translation block, set an invalid flag into the TranslationBlock structure first. It is also necessary to check whether the target TB is still valid after acquiring 'tb_lock' but before calling tb_add_jump() since TB lookup is to be performed out of 'tb_lock' in future. Note that we don't have to check 'last_tb'; an already invalidated TB will not be executed anyway and it is thus safe to patch it. Suggested-by: Sergey Fedorov <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
6d21e4208f382dd8ca1f7995a6dd9ea7ca281163
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6d21e4208f382dd8ca1f7995a6dd9ea7ca281163
2016-09-13 19:08:43+02:00
block: Accept node-name for block-stream In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts block-stream to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the GenericError error class now instead of DeviceNotFound, because this is what qmp_get_root_bs() returns. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Max Reitz <[email protected]> Reviewed-by: Alberto Garcia <[email protected]>
b6c1bae5df8abbed73c4c0bd92e9963df8829c74
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b6c1bae5df8abbed73c4c0bd92e9963df8829c74
2016-09-05 19:06:47+02:00
block: Accept node-name for blockdev-backup In order to remove the necessity to use BlockBackend names in the external API, we want to allow node-names everywhere. This converts blockdev-backup and the corresponding transaction action to accept a node-name without lifting the restriction that we're operating at a root node. In case of an invalid device name, the command returns the GenericError error class now instead of DeviceNotFound, because this is what qmp_get_root_bs() returns. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Max Reitz <[email protected]>
cef34eebf3d0f252a3b3e9a2a459b6c3ecc56f68
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cef34eebf3d0f252a3b3e9a2a459b6c3ecc56f68
2016-09-05 19:06:47+02:00
net: check fragment length during fragmentation Network transport abstraction layer supports packet fragmentation. While fragmenting a packet, it checks for more fragments from packet length and current fragment length. It is susceptible to an infinite loop, if the current fragment length is zero. Add check to avoid it. Reported-by: Li Qiang <[email protected]> Signed-off-by: Prasad J Pandit <[email protected]> Reviewed-by: Dmitry Fleytman <[email protected]> CC: [email protected] Signed-off-by: Jason Wang <[email protected]>
ead315e43ea0c2ca3491209c6c8db8ce3f2bbe05
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ead315e43ea0c2ca3491209c6c8db8ce3f2bbe05
2016-08-09 11:45:30+08:00
pc-bios/optionrom: Fix OpenBSD build with better detection of linker emulation The various host OSes are irritatingly variable about the name of the linker emulation we need to pass to ld's -m option to build the i386 option ROMs. Instead of doing this via a CONFIG ifdef, check in configure whether any of the emulation names we know about will work and pass the right answer through to the makefile. If we can't find one, we fall back to not trying to build the option ROMs, in the same way we would for a non-x86 host platform. This is in particular necessary to unbreak the build on OpenBSD, since it wants a different answer to FreeBSD and we don't have an existing CONFIG_ variable that distinguishes the two. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Sean Bruno <[email protected]> Message-id: [email protected]
e57218b6ed9d8e45585eea8fe1dc49068f51a1d2
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e57218b6ed9d8e45585eea8fe1dc49068f51a1d2
2016-08-15 17:21:30+01:00
Revert "pc: Enforce adding CPUs contiguously and removing them in opposite order" This reverts commit 4da7faaeb0c7dd3f7f233165d336c878f78fd1eb. Since commit: pc: init CPUState->cpu_index with index in possible_cpus[] cpu_index is stable regardless of the order cpus were created and QEMU instance stays migratable always so limitation added by 4da7faaeb could be safely removed. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]>
9527e7bde5b59005ddb2d902973915b81b4c5b2c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9527e7bde5b59005ddb2d902973915b81b4c5b2c
2016-07-26 15:32:13-03:00
error: Strip trailing '\n' from error string arguments (again) Commit 9af9e0f, 6daf194d, be62a2eb and 312fd5f got rid of a bunch, but they keep coming back. checkpatch.pl tries to flag them since commit 5d596c2, but it's not very good at it. Offenders tracked down with Coccinelle script scripts/coccinelle/err-bad-newline.cocci, an updated version of the script from commit 312fd5f. Signed-off-by: Markus Armbruster <[email protected]> Message-Id: <[email protected]> Reviewed-by: Eric Blake <[email protected]>
df3c286c53ac51e7267f2761c7a0c62e11b6e815
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/df3c286c53ac51e7267f2761c7a0c62e11b6e815
2016-08-08 09:00:44+02:00
mirror: fix request throttling in drive-mirror There are 2 deficiencies here: - mirror_iteration could start several requests inside. Thus we could simply have more in_flight requests than MAX_IN_FLIGHT. - keeping this in mind throttling in mirror_run which is checking s->in_flight == MAX_IN_FLIGHT is wrong. The patch adds the check and throttling into mirror_iteration and fixes the check in mirror_run() to be sure. Signed-off-by: Denis V. Lunev <[email protected]> Reviewed-by: Max Reitz <[email protected]> Message-id: [email protected] CC: Jeff Cody <[email protected]> CC: Kevin Wolf <[email protected]> CC: Max Reitz <[email protected]> Signed-off-by: Jeff Cody <[email protected]> (cherry picked from commit e648dc95c28fbca12e67be26a1fc4b9a0676c3fe)
cf56a3c632d039d00e29dfe8676321d6d349190c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cf56a3c632d039d00e29dfe8676321d6d349190c
2016-07-19 17:03:44-04:00
spapr_pci: Include spapr.h instead of playing games with #error include/hw/pci-host/spapr.h needs hw/ppc/spapr.h. It checks whether its header guard is defined, and errors out if it isn't. Playing games with some other header's guard symbol is not a good idea. Just include the frackin' header already. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
20668fdebdbb718238c7e80febd0249b5691c99f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/20668fdebdbb718238c7e80febd0249b5691c99f
2016-07-12 16:19:16+02:00
raw-win32: Set request_alignment during .bdrv_refresh_limits() We want to eventually stick request_alignment alongside other BlockLimits, but first, we must ensure it is populated at the same time as all other limits, rather than being a special case that is set only when a block is first opened. In this case, raw_probe_alignment() already did what we needed, so just fix its signature and wire it in correctly. Signed-off-by: Eric Blake <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
2914a1de992118286f5280eddf4f4e6060a8e00b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/2914a1de992118286f5280eddf4f4e6060a8e00b
2016-07-05 16:46:25+02:00
linux-user: fd_trans_host_to_target_data() must process only received data if we process the whole buffer, the netlink helpers can try to swap invalid data. Signed-off-by: Laurent Vivier <[email protected]> Signed-off-by: Riku Voipio <[email protected]> Reviewed-by: Peter Maydell <[email protected]>
48dc0f2c3d87c74c31a27e1d17dabf26c378b1e8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/48dc0f2c3d87c74c31a27e1d17dabf26c378b1e8
2016-06-26 13:17:22+03:00
nvdimm acpi: set HDLE properly Now we pass HDLE to Qemu properly, use 0 for root device and use the handle for nvdimm devices Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Stefan Hajnoczi <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
732b530c1bd064bdcc29975c0b78fc6de8c47e7f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/732b530c1bd064bdcc29975c0b78fc6de8c47e7f
2016-06-24 05:13:57+03:00
char: change qemu_chr_fe_add_watch to return unsigned g_source_attach can return any value between 1 and UINT_MAX if you let QEMU run long enough. However, qemu_chr_fe_add_watch can also return a negative errno value when the device is disconnected or does not support chr_add_watch. Change it to return zero to avoid overloading these values. Fix the cadence_uart which asserts in this case (easily obtained with "-serial pty"). Tested-by: Bret Ketchum <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
6f1de6b70d857d5e316ae6fd908f52818b827b08
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6f1de6b70d857d5e316ae6fd908f52818b827b08
2016-06-29 14:03:47+02:00
cadence_gem: Avoid infinite loops with a misconfigured buffer A guest can write zero to the DMACFG resulting in an infinite loop when it reaches the while(bytes_to_copy) loop. To avoid this issue enforce a minimum size for the RX buffer. Hardware does not have this enforcement and relies on the guest to set a non-zero value. Signed-off-by: Alistair Francis <[email protected]> Reported-by: Li Qiang <[email protected]> Reported-by: P J P <[email protected]> Message-id: 84bb1c391b833275da3f573d4972920cea34c188.1466539342.git.alistair.francis@xilinx.com Signed-off-by: Peter Maydell <[email protected]>
f265ae8c79ce8c194de481e9def1daa3a80dbb96
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f265ae8c79ce8c194de481e9def1daa3a80dbb96
2016-06-27 15:37:32+01:00
block: Prevent sleeping jobs from resuming if they have been paused If we pause a block job and drain its BlockDriverState we want that the job remains inactive until we call block_job_resume() again. However if we pause the job while it is sleeping then it will resume when the sleep timer fires. This patch prevents that from happening by checking if the job has been paused after it comes back from sleeping. Signed-off-by: Alberto Garcia <[email protected]> Suggested-by: Kevin Wolf <[email protected]> Message-id: 3d9011151512326b890d22bdab3530244ef349d7.1464346103.git.berto@igalia.com Reviewed-by: Max Reitz <[email protected]> Signed-off-by: Max Reitz <[email protected]>
0824afda0cd20045ffe87d58e142774514b61026
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0824afda0cd20045ffe87d58e142774514b61026
2016-06-16 15:20:37+02:00
blockdev: clean up error handling in do_open_tray Returns negative error codes and accompanying error messages in cases where the device has no tray or the tray is locked and isn't forced open. This extra information should result in better flexibility in functions that call do_open_tray. Suggested by: Markus Armbruster <[email protected]> Signed-off-by: Colin Lord <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
bf18bee547d19fde314e7b6b81f21f68b46c8a92
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/bf18bee547d19fde314e7b6b81f21f68b46c8a92
2016-06-08 10:21:09+02:00
docker: Add common.rc "requires" checks the "FEATURE" environment for specified prerequisits, and skip the execution of test if not found. "build_qemu" is the central routine to compile QEMU for tests to call. Reviewed-by: Alex Bennée <[email protected]> Signed-off-by: Fam Zheng <[email protected]> Message-id: [email protected]
3568f98ca56099309417a9bbf0e22435fa7094a5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3568f98ca56099309417a9bbf0e22435fa7094a5
2016-06-01 17:27:35+08:00
linux-user: Remove redundant default action check in queue_signal() Both queue_signal() and process_pending_signals() did check for default actions of signals, this is redundant and also causes fatal and stopping signals to incorrectly cause guest system calls to be interrupted. The code in queue_signal() is removed. Signed-off-by: Timothy Edward Baldwin <[email protected]> Message-id: 1441497448-32489-21-git-send-email-T.E.Baldwin99@members.leeds.ac.uk Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
c19c1578f8a9b894f5e368e35139620a98bf6a69
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c19c1578f8a9b894f5e368e35139620a98bf6a69
2016-06-07 16:39:07+03:00
virtio-gpu: check max_outputs value The value must be less than VIRTIO_GPU_MAX_SCANOUT. Signed-off-by: Marc-André Lureau <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
5e3d741c6a192b301692a44084f99876f0d6b643
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5e3d741c6a192b301692a44084f99876f0d6b643
2016-05-23 13:30:03+02:00
exec: Remove cpu from cpus list during cpu_exec_exit() CPUState *cpu gets added to the cpus list during cpu_exec_init(). It should be removed from cpu_exec_exit(). cpu_exec_exit() is called from generic CPU::instance_finalize and some archs like PowerPC call it from CPU unrealizefn. So ensure that we dequeue the cpu only once. Now -1 value for cpu->cpu_index indicates that we have already dequeued the cpu for CONFIG_USER_ONLY case also. Signed-off-by: Bharata B Rao <[email protected]> Reviewed-by: David Gibson <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Acked-by: Paolo Bonzini <[email protected]> Signed-off-by: David Gibson <[email protected]>
1c59eb39cf75e660b1ac4ea95ef789c84021a1c4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1c59eb39cf75e660b1ac4ea95ef789c84021a1c4
2016-05-30 13:22:20+10:00
vl: change runstate only if new state is different from current state Previously, qemu will abort at following scenario: (qemu) stop (qemu) system_reset (qemu) system_reset (qemu) 2016-04-13T20:54:38.979158Z qemu-system-x86_64: invalid runstate transition: 'prelaunch' -> 'prelaunch' Signed-off-by: Li Zhijian <[email protected]> Acked-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Cc: [email protected] Signed-off-by: Paolo Bonzini <[email protected]>
e92a2d9cb3d8f589c9fe5d2eacc83d8dddea0e16
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e92a2d9cb3d8f589c9fe5d2eacc83d8dddea0e16
2016-05-23 16:53:44+02:00
qemu-iotests: Fix regression in 136 on aio_read invalid Commit 093ea232 removed the ability for aio_read and aio_write to artificially inflate the invalid statistics counters for block devices, since it no longer flags unaligned offset or length. Add 'aio_read -i' and 'aio_write -i' to restore the ability, and update test 136 to use it. Reported-by: Kevin Wolf <[email protected]> Signed-off-by: Eric Blake <[email protected]> Message-id: [email protected] Signed-off-by: Max Reitz <[email protected]>
37546ff28fb89744ebf2223db22cbc253592abe1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/37546ff28fb89744ebf2223db22cbc253592abe1
2016-05-19 16:56:58+02:00
io: remove checking of EWOULDBLOCK Since we now canonicalize WSAEWOULDBLOCK into EAGAIN there is no longer any need to explicitly check EWOULDBLOCK for Win32. Signed-off-by: Daniel P. Berrange <[email protected]>
30fd3e27907dfd1c0c66cc1339657af1a2ce1d4b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/30fd3e27907dfd1c0c66cc1339657af1a2ce1d4b
2016-03-10 17:19:05+00:00
qemu-iotests: Some more write_zeroes tests This covers some more write_zeroes cases which are relevant for the recent qcow2 optimisations that check the allocation status of the backing file for partial cluster write_zeroes requests. This needs to be separate from 034 because we can only support qcow2 in this test case for multiple reasons: We check the allocation status after write_zeroes with 'qemu-img map' and the optimised behaviour that produces zero clusters is only implemented in qcow2; second, the map command returns offsets that are qcow2 specific; and finally, we also use 512 byte clusters which aren't supported for formats like qed. Signed-off-by: Kevin Wolf <[email protected]> Reviewed-by: Eric Blake <[email protected]>
1ef7d010216b7d1046a3f6e31b49093addad01ce
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1ef7d010216b7d1046a3f6e31b49093addad01ce
2016-05-19 16:45:31+02:00
acpi: add build_append_named_dword, returning an offset in buffer This is a very limited form of support for runtime patching - similar in functionality to what we can do with ACPI_EXTRACT macros in python, but implemented in C. This is to allow ACPI code direct access to data tables - which is exactly what DataTableRegion is there for, except no known windows release so far implements DataTableRegion. Signed-off-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Xiao Guangrong <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
f20354910893310d5496ebb6edfc551d83d95343
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f20354910893310d5496ebb6edfc551d83d95343
2016-03-11 14:54:28+02:00
hw/arm/sysbus-fdt: remove qemu_fdt_setprop returned value check qemu_fdt_setprop asserts in case of error hence no need to check the returned value. Signed-off-by: Eric Auger <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Alex Williamson <[email protected]>
c89e91a76b361feaa09a48c20e6d18ae92ad0b4a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c89e91a76b361feaa09a48c20e6d18ae92ad0b4a
2016-02-19 09:42:31-07:00
qdev-monitor: improve error message when alias device is unavailable When trying to instantiate an alias that points to a device class that doesn't exist, the error message looks like qemu misunderstood the request: $ s390x-softmmu/qemu-system-s390x -device virtio-gpu qemu-system-s390x: -device virtio-gpu: 'virtio-gpu-ccw' is not a valid device model name Special-case the error message to make it explicit that alias expansion is going on: $ s390x-softmmu/qemu-system-s390x -device virtio-gpu qemu-system-s390x: -device virtio-gpu: 'virtio-gpu' (alias 'virtio-gpu-ccw') is not a valid device model name Suggested-By: Cornelia Huck <[email protected]> Signed-off-by: Sascha Silbe <[email protected]> Message-Id: <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
f6b5319d412cda360695e2005737f91ca8201af0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f6b5319d412cda360695e2005737f91ca8201af0
2016-03-16 10:13:10+01:00
rdma: remove check on time_spent when calculating mbs Within the if statement, time_spent is assured to be non-zero. This patch just removes the check on time_spent when calculating mbs. Signed-off-by: Wei Yang <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
5b648de0ee6f705dc5792a97fd69e761bba9f1cd
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5b648de0ee6f705dc5792a97fd69e761bba9f1cd
2016-02-11 15:15:46+03:00
migration: ensure htab_save_first completes after timeout htab_save_first_pass could return without finishing its work due to timeout. The patch checks if another invocation of it is necessary and will call it in htab_save_complete if necessary. Signed-off-by: Jianjun Duan <[email protected]> Reviewed-by: Michael Roth <[email protected]> [removed overlong line] Signed-off-by: David Gibson <[email protected]>
378bc21756f016abfde16a0de4977be49f499b1c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/378bc21756f016abfde16a0de4977be49f499b1c
2016-02-17 09:59:30+11:00
vl: Reset location after handling command-line arguments After looping through all command-line arguments, error location info becomes obsolete, and any function calling error_report() will print misleading information. This breaks error reporting for some option handling, like: $ qemu-system-x86_64 -icount rr=x -vnc :0 qemu-system-x86_64: -vnc :0: Invalid icount rr option: x $ qemu-system-x86_64 -m size= -vnc :0 qemu-system-x86_64: -vnc :0: missing 'size' option value Fix this by resetting location info as soon as we exit the command-line handling loop. With this, replay_configure() and set_memory_options() won't print any location info yet, but at least they won't print incorrect information. Signed-off-by: Eduardo Habkost <[email protected]> Message-Id: <[email protected]> Reviewed-by: Laszlo Ersek <[email protected]> ["Do not insert code here" comment added to prevent regressions] Signed-off-by: Markus Armbruster <[email protected]>
43fa1e0bd98887fb5ead745de13dc9961799e97e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/43fa1e0bd98887fb5ead745de13dc9961799e97e
2016-02-19 13:46:44+01:00
block: Add blk_dev_has_tray() Pull out the check whether a block device has a tray from blk_dev_is_tray_open() into its own function so both attributes (whether there is a tray vs. whether that tray is open) can be queried independently. Cc: qemu-stable <[email protected]> Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Alberto Garcia <[email protected]> Message-id: [email protected]
8f3a73bc57ea83e5b3930d14fc596ea51859987a
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8f3a73bc57ea83e5b3930d14fc596ea51859987a
2016-02-02 17:46:56+01:00
docs/memory.txt: Improve list of different memory regions Improve the part of the memory region documentation which describes the various different kinds of memory region: * add the missing types ROM, IOMMU and reservation * mention the functions used to initialize each type, as a hint for finding the API docs and examples of use Signed-off-by: Peter Maydell <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
5056c0c3de73c4d804a62d473039bc439718777d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5056c0c3de73c4d804a62d473039bc439718777d
2016-02-09 15:46:55+01:00
target-arm: Add isread parameter to CPAccessFns System registers might have access requirements which need to be described via a CPAccessFn and which differ for reads and writes. For this to be possible we need to pass the access function a parameter to tell it whether the access being checked is a read or a write. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Alex Bennée <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]> Reviewed-by: Sergey Fedorov <[email protected]> Message-id: [email protected]
3f208fd76bcc91a8506681bb8472f2398fe6f487
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/3f208fd76bcc91a8506681bb8472f2398fe6f487
2016-02-11 11:17:31+00:00
linux-user: check fd is >= 0 in fd_trans_host_to_target_data/fd_trans_host_to_target_addr Signed-off-by: Laurent Vivier <[email protected]> Signed-off-by: Riku Voipio <[email protected]>
861d72cd28b5793fc367c46b7821a5372b66e3f4
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/861d72cd28b5793fc367c46b7821a5372b66e3f4
2016-01-08 15:20:35+02:00
ide: Correct the CHS 'cyls_max' limit to be 65535 In b7eb0c9: hw/block-common: Factor out fall back to legacy -drive cyls=... 'blkconf_geometry()' was introduced, factoring out CHS limit validation code that was repeated in ide, scsi, virtio-blk. The original IDE CHS limit prior b7eb0c9 was 65535,16,255 (as per ATA CHS addressing). However the 'cyls_max' argument passed to 'blkconf_geometry' in the ide_dev_initfn case was accidentally set to 65536 instead of 65535. Fix, providing the correct 'cyls_max'. Signed-off-by: Shmulik Ladkani <[email protected]> Reviewed-by: John Snow <[email protected]> Message-id: 1453112371-29760-1-git-send-email-shmulik.ladkani@ravellosystems.com Signed-off-by: John Snow <[email protected]>
4f0869948201af740114fed4468165cf927614fa
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4f0869948201af740114fed4468165cf927614fa
2016-01-25 14:34:40-05:00
gtk: use qemu_chr_alloc() to allocate CharDriverState The gd_vc_handler() callback is using g_malloc0() to allocate the CharDriverState struct. As a result the logfd field is getting initialized to 0, instead of -1 when no logfile is requested. The result is that when running $ qemu-system-i386 -nodefaults -chardev vc,id=mon0 -mon chardev=mon0 qemu duplicates all monitor output to stdout as well as the GTK window. Not using qemu_chr_alloc() was already a bug, but harmless until this commit commit d0d7708ba29cbcc343364a46bff981e0ff88366f Author: Daniel P. Berrange <[email protected]> Date: Mon Jan 11 12:44:41 2016 +0000 qemu-char: add logfile facility to all chardev backends which exposed the problem as a behaviour regression Reported-by: Hervé Poussineau <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]> Reviewed-by: Eric Blake <[email protected]> Tested-by: Hervé Poussineau <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
919e11f3735c524e23d049512d3306ea1cc63fba
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/919e11f3735c524e23d049512d3306ea1cc63fba
2016-02-02 14:05:07+01:00
acpi: aml: add helper for Opcode Arg2 Arg2 [Dst] AML pattern Currently AML API doesn't compose terms in form of following pattern: Opcode Arg2 Arg2 [Dst] but ASL used in piix4/q35 DSDT ACPI tables uses that form, so for clean conversion of it, AML API should be able to handle an optional 'Dst' argumet used there. Since above pattern is used by arithmetic/bit ops, introduce helper that they could reuse. It reduces code duplication in existing 5 aml_foo() functions and also will prevent more duplication when exiting functions are extended to support optional 'Dst' argument. Signed-off-by: Igor Mammedov <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Reviewed-by: Marcel Apfelbaum <[email protected]> Reviewed-by: Shannon Zhao <[email protected]>
439e2a6e10ed7f5da819bf7dcaa54b8cfdbeab0d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/439e2a6e10ed7f5da819bf7dcaa54b8cfdbeab0d
2015-12-22 18:39:20+02:00
crypto: add support for loading encrypted x509 keys Make use of the QCryptoSecret object to support loading of encrypted x509 keys. The optional 'passwordid' parameter to the tls-creds-x509 object type, provides the ID of a secret object instance that holds the decryption password for the PEM file. # printf "123456" > mypasswd.txt # $QEMU \ -object secret,id=sec0,filename=mypasswd.txt \ -object tls-creds-x509,passwordid=sec0,id=creds0,\ dir=/home/berrange/.pki/qemu,endpoint=server \ -vnc :1,tls-creds=creds0 This requires QEMU to be linked to GNUTLS >= 3.1.11. If GNUTLS is too old an error will be reported if an attempt is made to pass a decryption password. Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Daniel P. Berrange <[email protected]>
1d7b5b4afdcd76e24ec3678d5418b29d4ff06ad9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1d7b5b4afdcd76e24ec3678d5418b29d4ff06ad9
2015-12-18 16:25:08+00:00
qapi-types: Drop unnedeed ._fwdefn Previously, the generated code in qapi-types.c initialized all enum lookup tables first, prior to any other definitions. But there are no topological sorting requirements that mandate this layout, so we can drop the QAPISchemaGenTypeVisitor._fwdefn field and just generate all definitions in visitation order. The generated code shows some churn due to reordering, but it is still fairly straightforward to follow (all the deletions occur in one hunk, and all the deleted lines are re-inserted in the same order later in the same files, just spread across multiple insertion points). Suggested-by: Markus Armbruster <[email protected]> Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> Signed-off-by: Markus Armbruster <[email protected]>
0b2e84ba774651656771ed697dee8825759dffa9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0b2e84ba774651656771ed697dee8825759dffa9
2015-12-17 08:21:28+01:00
exec: Stop using memory after free memory_region_unref(mr) can free memory. For example I got: Program received signal SIGSEGV, Segmentation fault. [Switching to Thread 0x7f43280d4700 (LWP 4462)] 0x00007f43323283c0 in phys_section_destroy (mr=0x7f43259468b0) at /home/don/xen/tools/qemu-xen-dir/exec.c:1023 1023 if (mr->subpage) { (gdb) bt at /home/don/xen/tools/qemu-xen-dir/exec.c:1023 at /home/don/xen/tools/qemu-xen-dir/exec.c:1034 at /home/don/xen/tools/qemu-xen-dir/exec.c:2205 (gdb) p mr $1 = (MemoryRegion *) 0x7f43259468b0 And this change prevents this. Signed-off-by: Don Slutz <[email protected]> Message-Id: <[email protected]> Cc: [email protected] Signed-off-by: Paolo Bonzini <[email protected]>
55b4e80b047300e1512df02887b7448ba3786b62
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/55b4e80b047300e1512df02887b7448ba3786b62
2015-12-02 12:01:43+01:00
ohci: clear pending SOF on suspend On overcommitted CPU, kernel can be so slow that an interrupt can be triggered by the device whereas the driver is not ready to receive it. This drives us into an infinite loop. On suspend, if a SOF interrupt is raised between the stop of the device processing and the change of the device internal state to OHCI_USB_SUSPEND (QEMU stops SOF timer on this state change), this interrupt is never acknowledged. This patch clears pending SOF interrupt on OHCI_USB_SUSPEND setting. Some details: - ohci_irq(): the OHCI interrupt handler, acknowledges the SOF IRQ only if the state of the driver (rh_state) is OHCI_STATE_RUNNING. So if this interrupt happens and the driver is not in this state, the function is called again and again, moving the system to a CPU starvation. - ohci_rh_suspend(): the function stop the operation and acknowledge pending interrupts (but doesn't disable it). Later in the function, the device is moved to OHCI_SUSPEND_STATE, and the driver to OHCI_RH_SUSPENDED. If between the moment when the interrupt is acknowledged and the moment when the device is suspended a new interrupt is raised, it will be never acknowledged because the driver is now not in OHCI_RH_RUNNING state. Signed-off-by: Laurent Vivier <[email protected]> Reviewed-by: Thomas Huth <[email protected]> Message-id: [email protected] Signed-off-by: Gerd Hoffmann <[email protected]>
087462c7739869e9b888c06c06c8f1bbfd99779c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/087462c7739869e9b888c06c06c8f1bbfd99779c
2016-01-08 09:29:24+01:00
tests/vhost-user-bridge: propose GUEST_ANNOUNCE feature The backend has to know whether VIRTIO_NET_F_GUEST_ANNOUNCE was negotiated, so, as a hack we propose the feature by vhost-user-bridge during the feature negotiation. Signed-off-by: Victor Kaplansky <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
85ea9da5b8d8c0b2ab77b493d5ce62599279bf33
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/85ea9da5b8d8c0b2ab77b493d5ce62599279bf33
2015-11-25 13:42:38+02:00
tests: fix cdrom_pio_impl in ide-test The check for the cleared BSY flag has to be performed before each data transfer and not just before the first one. Commit 5f81724d revealed this glitch as the BSY flag was not set in ATAPI PIO transfers before. While at it fix the descriptions and add a comment before the nested for loop that transfers the data. Signed-off-by: Peter Lieven <[email protected]> Message-id: [email protected] Reviewed-by: Kevin Wolf <[email protected]> Reviewed-by: John Snow <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
f348daf3d5d2e349519764cd0c3ec3aaca113732
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f348daf3d5d2e349519764cd0c3ec3aaca113732
2015-11-20 17:37:06+00:00
q35: Check propery to determine if iommu is set The helper function machine_iommu() isn't necesary. We can directly check for the property. Signed-off-by: Bandan Das <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Bandan Das <[email protected]>
1f8431f42d833e8914f2d16ce4a49b7b72b90db0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1f8431f42d833e8914f2d16ce4a49b7b72b90db0
2015-11-17 15:41:13+02:00
qjson: surprise, allocating 6 QObjects per token is expensive Replace the contents of the tokens GQueue with a simple struct. This cuts the amount of memory allocated by tests/check-qjson from ~500MB to ~20MB, and the execution time from 600ms to 80ms on my laptop. Still a lot (some could be saved by using an intrusive list, such as QSIMPLEQ, instead of the GQueue), but the savings are already massive and the right thing to do would probably be to get rid of json-streamer completely. Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> [Straightforwardly rebased on my patches] Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]>
9bada8971173345ceb37ed1a47b00a01a4dd48cf
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9bada8971173345ceb37ed1a47b00a01a4dd48cf
2015-11-26 10:07:07+01:00
qga: allow to lookup in PATH from the passed envp for guest-exec This was original behaviour before GLIB gspawn() rework and we rely on this behaviour. Signed-off-by: Yuri Pudgorodskiy <[email protected]> Signed-off-by: Denis V. Lunev <[email protected]> CC: Michael Roth <[email protected]> * add version check (2.33.2) for G_SPAWN_SEARCH_PATH_FROM_ENVP Signed-off-by: Michael Roth <[email protected]>
0be40839519215988e207b86bc1638de53567588
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0be40839519215988e207b86bc1638de53567588
2015-11-17 16:24:18-06:00
replay: shutdown event This patch records and replays simulator shutdown event. Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]>
b60c48a7019614902f2debe4d4181ec8cfa60e0d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b60c48a7019614902f2debe4d4181ec8cfa60e0d
2015-11-06 10:16:02+01:00
replay: internal functions for replay log This patch adds functions to perform read and write operations with replay log. Reviewed-by: Paolo Bonzini <[email protected]> Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
c92079f45fec0bc6a2757aa3783dd9b0604089ba
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c92079f45fec0bc6a2757aa3783dd9b0604089ba
2015-11-05 12:19:09+01:00
replay: interrupts and exceptions This patch includes modifications of common cpu files. All interrupts and exceptions occured during recording are written into the replay log. These events allow correct replaying the execution by kicking cpu thread when one of these events is found in the log. Signed-off-by: Pavel Dovgalyuk <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
6f0609697f3670bf755a91477487507a8ffee471
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6f0609697f3670bf755a91477487507a8ffee471
2015-11-06 10:16:00+01:00
hw/misc: Add support for ADC controller in Xilinx Zynq 7000 Add support for the Xilinx XADC core used in Zynq 7000. References: - Zynq-7000 All Programmable SoC Technical Reference Manual - 7 Series FPGAs and Zynq-7000 All Programmable SoC XADC Dual 12-Bit 1 MSPS Analog-to-Digital Converter Tested with Linux using QEMU machine xilinx-zynq-a9 with devicetree files zynq-zc702.dtb and zynq-zc706.dtb, and kernel configuration multi_v7_defconfig. Reviewed-by: Alistair Francis <[email protected]> Signed-off-by: Guenter Roeck <[email protected]> [ PC changes: * Changed macro names to match TRM where possible * Made programmers model macro scheme consistent * Dropped XADC_ZYNQ_ prefix on local macros * Fix ALM field width * Update threshold-comparison interrupts in _update_ints() * factored out DFIFO pushes into helper. Renamed to "push/pop" * Changed xadc_reg to 10 bits and added OOB check. * Reduced scope of MCTL reset to just stop channel coms. * Added dummy read data to write commands * Changed _ to - seperators in string names and filenames * Dropped ------------ in header comment * Catchall'ed _update_ints() in _write handler. * Minor whitespace changes. * Use ZYNQ_XADC_FIFO_DEPTH instead of ARRAY_SIZE() ] Signed-off-by: Peter Crosthwaite <[email protected]> Tested-by: Guenter Roeck <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/74fcbd22d20a2fbc1a47a7b00cce5bf98fd7be5f
2015-11-12 21:30:42+00:00
target-arm: Add support for AArch32 S2 negative t0sz Add support for AArch32 S2 negative t0sz. In preparation for using 40bit IPAs on AArch32. Signed-off-by: Edgar E. Iglesias <[email protected]> Message-id: [email protected] Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Peter Maydell <[email protected]>
4ee38098010240e0b390061fdd0151ff62d80279
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4ee38098010240e0b390061fdd0151ff62d80279
2015-10-27 15:59:46+00:00
target-arm: lpae: Make t0sz and t1sz signed integers Make t0sz and t1sz signed integers to match tsz and to make it easier to implement support for AArch32 negative t0sz. t1sz is changed for consistensy. No functional change. Reviewed-by: Peter Maydell <[email protected]> Signed-off-by: Edgar E. Iglesias <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
5c31a10d16c595d6a59e3e7fc1808c3b1d03e02f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/5c31a10d16c595d6a59e3e7fc1808c3b1d03e02f
2015-10-27 15:59:46+00:00
sPAPR: Revert don't enable EEH on emulated PCI devices This reverts commit 7cb18007 ("sPAPR: Don't enable EEH on emulated PCI devices") as rtas_ibm_set_eeh_option() isn't the right place to check if there has the corresponding PCI device for the input address, which can be PE address, not PCI device address. Signed-off-by: Gavin Shan <[email protected]> Signed-off-by: David Gibson <[email protected]>
47445c80fb57035331574ac1ac0bcee67fb84aeb
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/47445c80fb57035331574ac1ac0bcee67fb84aeb
2015-09-23 10:51:11+10:00
qapi: Finish converting to new qapi union layout We have two issues with our qapi union layout: 1) Even though the QMP wire format spells the tag 'type', the C code spells it 'kind', requiring some hacks in the generator. 2) The C struct uses an anonymous union, which places all tag values in the same namespace as all non-variant members. This leads to spurious collisions if a tag value matches a non-variant member's name. This patch is the back end for a series that converts to a saner qapi union layout. Now that all clients have been converted to use 'type' and 'obj->u.value', we can drop the temporary parallel support for 'kind' and 'obj->value'. Given a simple union qapi type: { 'union':'Foo', 'data': { 'a':'int', 'b':'bool' } } this is the overall effect, when compared to the state before this series of patches: | struct Foo { |- FooKind kind; |- union { /* union tag is @kind */ |+ FooKind type; |+ union { /* union tag is @type */ | void *data; | int64_t a; | bool b; |- }; |+ } u; | }; The testsuite still contains some examples of artificial restrictions (see flat-union-clash-type.json, for example) that are no longer technically necessary, now that there is no longer a collision between enum tag values and non-variant member names; but fixing this will be done in later patches, in part because some further changes are required to keep QAPISchema*.check() from asserting. Also, a later patch will add a reservation for the member name 'u' to avoid a collision between a user's non-variant names and our internal choice of C union name. Note, however, that we do not rename the generated enum, which is still 'FooKind'. A further patch could generate implicit enums as 'FooType', but while the generator already reserved the '*Kind' namespace (commit 4dc2e69), there are already QMP constructs with '*Type' naming, which means changing our reservation namespace would have lots of churn to C code to deal with a forced name change. Signed-off-by: Eric Blake <[email protected]> Message-Id: <[email protected]> [Commit message tweaked] Signed-off-by: Markus Armbruster <[email protected]>
e4ba22b31943ab02373359555bd7bcd66442632f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e4ba22b31943ab02373359555bd7bcd66442632f
2015-11-02 08:30:28+01:00
crypto: introduce new module for TLS anonymous credentials Introduce a QCryptoTLSCredsAnon class which is used to manage anonymous TLS credentials. Use of this class is generally discouraged since it does not offer strong security, but it is required for backwards compatibility with the current VNC server implementation. Simple example CLI configuration: $QEMU -object tls-creds-anon,id=tls0,endpoint=server Example using pre-created diffie-hellman parameters $QEMU -object tls-creds-anon,id=tls0,endpoint=server,\ dir=/path/to/creds/dir The 'id' value in the -object args will be used to associate the credentials with the network services. For example, when the VNC server is later converted it would use $QEMU -object tls-creds-anon,id=tls0,.... \ -vnc 127.0.0.1:1,tls-creds=tls0 Signed-off-by: Daniel P. Berrange <[email protected]> Reviewed-by: Eric Blake <[email protected]>
e00adf6c3edf8dbbe7eb60c94e24fe2158e8342f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e00adf6c3edf8dbbe7eb60c94e24fe2158e8342f
2015-09-15 15:00:20+01:00
spapr: Don't use QOM [*] syntax for DR connectors. The dynamic reconfiguration (hotplug) code for the pseries machine type uses a "DR connector" QOM object for each resource it will be possible to hotplug. Each of these is added to its owner using object_property_add_child(owner, "dr-connector[*], ...); That works ok, mostly, but it means that the property indices are arbitrary, depending on the order in which the connectors are constructed. That might line up to something useful, but it doesn't have to. It will get worse once we add hotplug RAM support. That will add a DR connector object for every 256MB of potential memory. So if maxmem=2T, for example, there are 8192 objects under the same parent. The QOM interfaces aren't really designed for this. In particular object_property_add() with [*] has O(n^2) time complexity (in the number of existing children): first it has a linear search through array indices to find a free slot, each of which is attempted to a recursive call to object_property_add() with a specific [N]. Those calls are O(n) because there's a linear search through all properties to check for duplicates. By using a meaningful index value, which we already know is unique we can avoid the [*] special behaviour. That lets us reduce the total time for creating the DR objects from O(n^3) to O(n^2). O(n^2) is still kind of crappy, but it's enough to reduce the startup time of qemu (with in-progress memory hotplug support) with maxmem=2T from ~20 minutes to ~4 seconds. Signed-off-by: David Gibson <[email protected]> Cc: Bharata B Rao <[email protected]> Tested-by: Bharata B Rao <[email protected]> Reviewed-by: Alexey Kardashevskiy <[email protected]>
94649d423e4647fca3bc3e8b2b363d6d2adee9ce
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/94649d423e4647fca3bc3e8b2b363d6d2adee9ce
2015-09-23 10:51:10+10:00
target-arm: Add AArch32 banked register access to secure physical timer If EL3 is AArch32, then the secure physical timer is accessed via banking of the registers used for the non-secure physical timer. Implement this banking. Note that the access controls for the AArch32 banked registers remain the same as the physical-timer checks; they are not the same as the controls on the AArch64 secure timer registers. Signed-off-by: Peter Maydell <[email protected]> Message-id: [email protected] Reviewed-by: Edgar E. Iglesias <[email protected]>
9ff9dd3c875956523bb4c19ca712e5d05aab3c65
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/9ff9dd3c875956523bb4c19ca712e5d05aab3c65
2015-08-13 11:26:22+01:00
ui: convert VNC websockets to use crypto APIs Remove the direct use of gnutls for hash processing in the websockets code, in favour of using the crypto APIs. This allows the websockets code to be built unconditionally removing countless conditional checks from the VNC code. Signed-off-by: Daniel P. Berrange <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
8e9b0d24fb986d4241ae3b77752eca5dab4cb486
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/8e9b0d24fb986d4241ae3b77752eca5dab4cb486
2015-07-08 13:11:01+02:00
spice-display: fix segfault in qemu_spice_create_update Although it is pretty unusual the stride for the guest image and the mirror image maintained by spice-display can be different. So use separate variables for them. https://bugzilla.redhat.com/show_bug.cgi?id=1163047 Cc: [email protected] Reported-by: perrier vincent <[email protected]> Signed-off-by: Gerd Hoffmann <[email protected]>
c6e484707f28b3e115e64122a0570f6b3c585489
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c6e484707f28b3e115e64122a0570f6b3c585489
2015-06-11 09:06:14+02:00
memory: track DIRTY_MEMORY_CODE in mr->dirty_log_mask DIRTY_MEMORY_CODE is only needed for TCG. By adding it directly to mr->dirty_log_mask, we avoid testing for TCG everywhere a region is checked for the enabled/disabled state of dirty logging. Reviewed-by: Fam Zheng <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
677e7805cf95f3b2bca8baf0888d1ebed7f0c606
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/677e7805cf95f3b2bca8baf0888d1ebed7f0c606
2015-06-05 17:09:59+02:00
Stop including qemu-common.h in memory.h Including qemu-common.h from other header files is generally a bad idea, because it means it's very easy to end up with a circular dependency. For instance, if we wanted to include memory.h from qom/cpu.h we'd end up with this loop: memory.h -> qemu-common.h -> cpu.h -> cpu-qom.h -> qom/cpu.h -> memory.h Remove the include from memory.h. This requires us to fix up a few other files which were inadvertently getting declarations indirectly through memory.h. The biggest change is splitting the fprintf_function typedef out into its own header so other headers can get at it without having to include qemu-common.h. Signed-off-by: Peter Maydell <[email protected]> Message-Id: <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
fba0a593b2809ecdda68650952cf3d3332ac1990
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/fba0a593b2809ecdda68650952cf3d3332ac1990
2015-07-06 14:59:09+02:00
target-mips: Misaligned memory accesses for MSA MIPS SIMD Architecture vector loads and stores require misalignment support. MSA Memory access should work as an atomic operation. Therefore, it has to check validity of all addresses for a vector store access if it is spanning into two pages. Separating helper functions for each data format as format is known in translation. To use mmu_idx from cpu_mmu_index() instead of calculating it from hflag. Removing save_cpu_state() call in translation because it is able to use cpu_restore_state() on fault as GETRA() is passed. Signed-off-by: Yongbok Kim <[email protected]> Reviewed-by: Leon Alrae <[email protected]> [[email protected]: remove unused do_* functions] Signed-off-by: Leon Alrae <[email protected]>
adc370a48fd26b92188fa4848dfb088578b1936c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/adc370a48fd26b92188fa4848dfb088578b1936c
2015-06-11 10:13:28+01:00
tcg: add TCG_TARGET_TLB_DISPLACEMENT_BITS This will be used to size the TLB when more than 8 MMU modes are used by the target. Limitations come from the limited size of the immediate fields (which sometimes, as in the case of Aarch64, extend to instructions that shift the immediate). Signed-off-by: Paolo Bonzini <[email protected]> Message-Id: <[email protected]> Reviewed-by: Richard Henderson <[email protected]> Signed-off-by: Alexander Graf <[email protected]>
006f8638c62bca2b0caf609485f47fa5e14d8a3c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/006f8638c62bca2b0caf609485f47fa5e14d8a3c
2015-06-03 23:56:56+02:00
spice: fix spice_chr_add_watch() pre-condition Since e02bc6de30c44fd668dc0d6e1cd1804f2eed3ed3, add_watch() is called with G_IO_HUP. Even if spice-qemu-char ignores this flag, the precondition must be changed. https://bugzilla.redhat.com/show_bug.cgi?id=1128992 Signed-off-by: Gerd Hoffmann <[email protected]>
f7a8beb5e6a13dc924895244777d9ef08b23b367
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/f7a8beb5e6a13dc924895244777d9ef08b23b367
2015-05-29 09:56:01+02:00
monitor: Limit QError use to command handlers The previous commits narrowed use of QError to handle_qmp_command() and its helpers monitor_protocol_emitter(), build_qmp_error_dict(). Narrow it further to just the command handler call: instead of converting Error to QError throughout handle_qmp_command(), convert the QError gotten from the command handler to Error, and switch the helpers from QError to Error. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Reviewed-by: Luiz Capitulino <[email protected]>
710aec915d208246891b68e2ba61b54951edc508
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/710aec915d208246891b68e2ba61b54951edc508
2015-06-02 10:07:15+02:00
target-alpha: Set PC correctly for floating-point exceptions PC should be one past the faulting insn. Add better commentary for the machine-check exception path. Reported-by: Al Viro <[email protected]> Signed-off-by: Richard Henderson <[email protected]>
ba9c5de5f2d33d468a07a8794121472ea031a0b5
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ba9c5de5f2d33d468a07a8794121472ea031a0b5
2015-05-18 13:03:46-07:00
tpm: Modify DPRINTF to enable -Wformat checking Modify DPRINTF to always enable -Wformat checking. Signed-off-by: Stefan Berger <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
4d1ba9c4f8a4d68b9d053946d551ffa8f1006b77
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/4d1ba9c4f8a4d68b9d053946d551ffa8f1006b77
2015-04-30 16:05:48+03:00
qobject: Clean up around qtype_code QTYPE_NONE is a sentinel value. No QObject has this type code. Document it properly. Fix dump_qobject() to abort() on QTYPE_NONE, just like for any other invalid type code. Fix to_json() to abort() on all invalid type codes, not just QTYPE_MAX. Clean up Property member qtype's type: it's a qtype_code. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Luiz Capitulino <[email protected]>
a7c31816288a8f20fc387d69d441413e7a8c9ff1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/a7c31816288a8f20fc387d69d441413e7a8c9ff1
2015-05-11 08:59:07-04:00
target-arm: Check watchpoints against CPU security state Fix a TODO in bp_wp_matches() now that we have a function for testing whether the CPU is currently in Secure mode or not. Signed-off-by: Peter Maydell <[email protected]> Reviewed-by: Edgar E. Iglesias <[email protected]> Reviewed-by: Alex Bennée <[email protected]>
ef7bab8d73580b48bda83b8d16b5eea8a3ac43fe
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ef7bab8d73580b48bda83b8d16b5eea8a3ac43fe
2015-04-26 16:49:25+01:00
aer: fix wrong check on expose aer tlp prefix log when specify TLP Prefix log as using pcie_aer_inject_error, the TLP prefix log is always discarded. because the check is incorrect, the End-End TLP Prefix Supported bit (PCI_EXP_DEVCAP2_EETLPP) should be in Device Capabilities 2 Register. Signed-off-by: Chen Fan <[email protected]> Reviewed-by: Michael S. Tsirkin <[email protected]> Signed-off-by: Michael S. Tsirkin <[email protected]>
77a3c1d730a14c86f3f5692be9906b206afc3d3e
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/77a3c1d730a14c86f3f5692be9906b206afc3d3e
2015-03-18 12:14:45+01:00
migration/rdma: clean up qemu_rdma_dest_init a bit Do not check for rdma->host being empty twice. This removes a large "if" block, so code indentation is changed. While at it, remove an ugly goto from the loop, replacing it with a cleaner if logic. And finally, there's no need to initialize `ret' variable since is always has a value. Signed-off-by: Michael Tokarev <[email protected]> Reviewed-by: Dr. David Alan Gilbert <[email protected]> Tested-by: Dr. David Alan Gilbert <[email protected]> -- fixed space detected by Dave Signed-off-by: Juan Quintela <[email protected]>
1dbd2fd9cbf29c74131e439ce80fb2efde56ee32
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/1dbd2fd9cbf29c74131e439ce80fb2efde56ee32
2015-03-17 15:20:37+01:00
target-arm: convert check_ap to ap_to_rw_prot Instead of mixing access permission checking with access permissions to page protection flags translation, just do the translation, and leave it to the caller to check the protection flags against the access type. Also rename to ap_to_rw_prot to better describe the new behavior. Signed-off-by: Andrew Jones <[email protected]> Reviewed-by: Peter Maydell <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
0fbf5238203041f734c51b49778223686f14366b
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0fbf5238203041f734c51b49778223686f14366b
2015-03-16 12:30:46+00:00
usb: Pair g_malloc() with g_free(), not free() Spotted by Coverity with preview checker ALLOC_FREE_MISMATCH enabled and my "coverity: Model g_free() isn't necessarily free()" model patch applied. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
0c6f807f4a98e7e258765dcf22619a582995fce0
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/0c6f807f4a98e7e258765dcf22619a582995fce0
2015-02-10 09:27:20+03:00
s390x/mmu: Check bit 52 in page table entry Bit 52 in a page table entry has always to be zero, or a translation specification exception is to be recognized. Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
b4ecbf8071022a2042624baaff78cab2bf7e94af
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b4ecbf8071022a2042624baaff78cab2bf7e94af
2015-02-18 09:37:14+01:00
s390x/ioinst: Rework memory access in STCRW instruction Change the handler for STCRW to use the new logical memory access functions. Since STCRW is suppressed on protection/access exceptions, we also have to make sure to re-queue the CRW in case it could not be written to the memory. Signed-off-by: Thomas Huth <[email protected]> Signed-off-by: Jens Freimann <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Reviewed-by: Cornelia Huck <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]>
7f74f0aa74a01698ef24459f7bc2a23f3880a2b8
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7f74f0aa74a01698ef24459f7bc2a23f3880a2b8
2015-02-18 09:37:15+01:00
vfio: fix wrong initialize vfio_group_list Signed-off-by: Chen Fan <[email protected]> Signed-off-by: Alex Williamson <[email protected]>
39cb514f02c7daf6378117e28be7a659a69e48b7
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/39cb514f02c7daf6378117e28be7a659a69e48b7
2015-02-04 11:45:32-07:00
vl: fix max_cpus check We should confirm max_cpus, which is >= smp_cpus, is <= the machine's true max_cpus, not just smp_cpus. Signed-off-by: Andrew Jones <[email protected]> Reviewed-by: Eduardo Habkost <[email protected]> Signed-off-by: Eduardo Habkost <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
c00cd99527d0d1b47a387239a7e3a8cf8ff82764
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/c00cd99527d0d1b47a387239a7e3a8cf8ff82764
2015-01-09 23:41:12+01:00
balloon: Inline qemu_balloon(), qemu_balloon_status() ... and simplify a bit. Permits factoring out common error checks in the next commit. Signed-off-by: Markus Armbruster <[email protected]> Reviewed-by: Eric Blake <[email protected]>
6502a14734e71b2f6dd079b0a1e546e6aa2d2f8d
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/6502a14734e71b2f6dd079b0a1e546e6aa2d2f8d
2015-01-29 10:02:26+01:00
s390x/kvm: unknown DIAGNOSE code should give a specification exception As described in CP programming services an unimplemented DIAGNOSE function should return a specification exception. Today we give the guest an operation exception. As both exception types are suppressing and Linux as a guest does not care about the type of program check in its exception table handler as long as both types have the same kind of error handling (nullifying, terminating, suppressing etc.) this was unnoticed. Reviewed-by: Thomas Huth <[email protected]> Signed-off-by: Christian Borntraeger <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
68540b1a1b505d9578699b03fe0b5da716a21dcc
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/68540b1a1b505d9578699b03fe0b5da716a21dcc
2015-02-03 13:42:40+01:00
loader: fix NEGATIVE_RETURNS lseek will return -1 on error, g_malloc0(size) and read(,,size) paramenters cannot be negative. We should add a check for return value of lseek(). Signed-off-by: Gonglei <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]>
ddd2eab72fbd383a56f439bf278c6d647abd4f54
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/ddd2eab72fbd383a56f439bf278c6d647abd4f54
2014-11-17 11:41:56+01:00
qemu-img: Check create_opts before image amendment The image options which can be amended are described by the .create_opts field for every driver. This field must therefore be non-NULL so that anything can be amended in the first place. Check that this holds true before going into qemu_opts_create() (because if .create_opts is NULL, the create_opts pointer in img_amend() will be NULL after qemu_opts_append()). Cc: [email protected] Signed-off-by: Max Reitz <[email protected]> Reviewed-by: Kevin Wolf <[email protected]> Signed-off-by: Kevin Wolf <[email protected]>
b2439d26f078c826e5e06b34d978a6f6d5c7c56f
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b2439d26f078c826e5e06b34d978a6f6d5c7c56f
2014-12-10 10:31:20+01:00
fw_cfg_mem: introduce the "data_width" property The "data_width" property is capable of changing the maximum valid access size to the MMIO data register, and resizes the memory region similarly, at device realization time. The default value of "data_memwidth" is set so that we don't yet diverge from "fw_cfg_data_mem_ops". Most of the fw_cfg_mem users will stick with the default, and for them we should continue using the statically allocated "fw_cfg_data_mem_ops". This is beneficial for debugging because gdb can resolve pointers referencing static objects to the names of those objects. Signed-off-by: Laszlo Ersek <[email protected]> Signed-off-by: Paolo Bonzini <[email protected]> Message-id: [email protected] Signed-off-by: Peter Maydell <[email protected]>
cfaadf0e89e7c2a47462d5f96390c9a9b4de037c
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/cfaadf0e89e7c2a47462d5f96390c9a9b4de037c
2014-12-22 23:39:18+00:00
s390x/sclpconsole-lm: truncate input if line is too long As the SCLP line mode console input length is limited by the available SCCB buffer space, it might lock up if the input does not fit into the buffer. With this patch, characters that don't fit are 'eaten' up to the next CR/LF and the input line is sent truncated to the guest. Signed-off-by: Heinz Graalfs <[email protected]> Reviewed-by: David Hildenbrand <[email protected]> Signed-off-by: Cornelia Huck <[email protected]>
b3191432cf49c556f47d75c929f5aa692ae59da1
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/b3191432cf49c556f47d75c929f5aa692ae59da1
2014-11-05 16:35:55+01:00
s390x: Implement SAM{24,31,64} The SAM instructions simply change 2 bits in PSW.MASK to advertise the current memory mode. While we can't fully guarantee that 31 bit mode (or even remotely 24 bit mode) actually work correctly, we don't check whether lpswe modifies these bits, so we shouldn't keep the guest from executing SAM instructions either. This patch implements all SAM instrutions with their actual PSW changing semantics, making more recent Linux kernels boot properly which do issue a SAM31 call during early boot. Signed-off-by: Alexander Graf <[email protected]> Reviewed-by: Bastian Koppelmann <[email protected]> Reviewed-by: Richard Henderson <[email protected]>
44dd33ba8f60b5f513399f673351127af16bd304
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/44dd33ba8f60b5f513399f673351127af16bd304
2014-11-05 12:01:28+01:00
slirp/smbd: modify/set several parameters in generated smbd.conf The file sharing module should not handle printers, so disable it. The options 'load printers' and 'printing' have been available since the beginning (May 1996, commit 0e8fd3398771da2f016d72830179507f3edda51b). Option 'disable spoolss' is available since Samba 2.0.4, commit de5f42c9d9172592779fa2504d44544e3b6b1c0d). Next, "socket address" was reported as deprecated, use a combination of "interfaces" and "bind interfaces only" instead (available since October 1997, commit 79f4fb52c1ed56fd843f81b4eb0cdd2991d4d0f4). Override cache directory to avoid writing to a global directory. Option available since Samba 3.4.0, Jan 2009, commit 19a05bf2f485023b11b41dfae3f6459847d55ef7. Set "usershare max shared=0" to prevent a global directory from being used. Option available since Samba 3.0.23, February 2006, commit 5831715049f2d460ce42299963a5defdc160891b. The last option was introduced with Samba 3.4.0, but previously "state directory" was already added which exists in Samba 3.4.0. As unknown parameters are ignored (while printing a warning), it should be safe to add another option. Signed-off-by: Peter Wu <[email protected]> Cc: Jan Kiszka <[email protected]> Signed-off-by: Michael Tokarev <[email protected]>
7912d04be6322b16cfece6b698361ae6ed036ba9
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/7912d04be6322b16cfece6b698361ae6ed036ba9
2014-11-11 08:49:16+03:00
target-mips: add BadInstr and BadInstrP support BadInstr Register (CP0 Register 8, Select 1) The BadInstr register is a read-only register that capture the most recent instruction which caused an exception. BadInstrP Register (CP0 Register 8, Select 2) The BadInstrP register contains the prior branch instruction, when the faulting instruction is in a branch delay slot. Using error_code to indicate whether AdEL or TLBL was triggered during instruction fetch, in this case BadInstr is not updated as valid instruction word is not available. Signed-off-by: Leon Alrae <[email protected]> Reviewed-by: Yongbok Kim <[email protected]>
aea14095ea91f792ee43ee52fe6032cd8cdd7190
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/aea14095ea91f792ee43ee52fe6032cd8cdd7190
2014-11-03 11:48:34+00:00
target-i386: warns users when CPU threads>1 for non-Intel CPUs Only Intel CPUs support hyperthreading. When users select threads>1 in -smp option, QEMU fixes it by adjusting CPUID_0000_0001_EBX and CPUID_8000_0008_ECX based on inputs (sockets, cores, threads); so guest VM can boot correctly. However it is still better to gives users a warning when such case happens. Signed-off-by: Wei Huang <[email protected]> [As suggested by Eduardo, check for !IS_INTEL instead of AMD. - Paolo] Signed-off-by: Paolo Bonzini <[email protected]>
e48638fdb31bb79de964cd8bbd4621648f5d38c6
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/e48638fdb31bb79de964cd8bbd4621648f5d38c6
2014-10-23 16:41:26+02:00
scsi: Drop scsi_req_abort The only user of this function is spapr_vscsi.c. We can convert to scsi_req_cancel plus adding a check in vscsi_request_cancelled. Suggested-by: Paolo Bonzini <[email protected]> Signed-off-by: Fam Zheng <[email protected]> [Drop prototype. - Paolo] Signed-off-by: Paolo Bonzini <[email protected]>
eda470e41a753070e057380a9a71e2ad7347f667
qemu
devign
0
https://github.com/qemu/qemu
https://github.com/qemu/qemu/commit/eda470e41a753070e057380a9a71e2ad7347f667
2014-09-30 13:30:50+02:00