commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
avfilter/vf_decimate: check ff_insert_inpad() for failure Signed-off-by: Paul B Mahol <[email protected]>
0b940c95b2171cb1035c79b85492f5f6cdb060a6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0b940c95b2171cb1035c79b85492f5f6cdb060a6
2017-08-25 10:23:21+02:00
avconv: when using -loop option bail out if seek to start fails Fixes an infinite loop when a demuxer fails to seek to the start of the input. Signed-off-by: Peter Große <[email protected]> Signed-off-by: Anton Khirnov <[email protected]>
a58873b11198d04670b7f98f5a8a749d742db7c5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a58873b11198d04670b7f98f5a8a749d742db7c5
2017-07-28 13:13:44+02:00
avcodec/jpeg2000dec: Fix division by zero in jp2_find_codestream() Fixes: 2707/clusterfuzz-testcase-minimized-5179636394754048 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
1b00600319506a9bd81b114d2b374051dc1a29a6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1b00600319506a9bd81b114d2b374051dc1a29a6
2017-07-26 17:06:29+02:00
avcodec/aacdec_template: Fix undefined integer overflow in apply_tns() Fixes: runtime error: signed integer overflow: -2147483648 - 1202286525 cannot be represented in type 'int' Fixes: 2071/clusterfuzz-testcase-minimized-6036414271586304 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
0ef8f03133a0bd83c74200a8cf30982c0f574016
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0ef8f03133a0bd83c74200a8cf30982c0f574016
2017-07-16 01:07:27+02:00
avcodec/ffv1dec_template: Fix undefined shift Fixes: runtime error: left shift of negative value -127 Fixes: 2834/clusterfuzz-testcase-minimized-5988039123795968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
62702eebded6c6341d214405812a981f80e46ea2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/62702eebded6c6341d214405812a981f80e46ea2
2017-08-11 18:21:06+02:00
avcodec/diracdec: Check dimensions which are closer to what is allocated in alloc_sequence_buffers() Fixes OOM Fixes: 2674/clusterfuzz-testcase-minimized-4999700518273024 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
edc88646ee407bc342cc94ff495aadafcd377cee
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/edc88646ee407bc342cc94ff495aadafcd377cee
2017-07-21 17:37:05+02:00
avcodec/hevc_ps: Fix integer overflow with beta/tc offsets Fixes: runtime error: signed integer overflow: 2113929216 * 2 cannot be represented in type 'int' Fixes: 2422/clusterfuzz-testcase-minimized-5242114713583616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
de54a37c1dfa2817b5838720fac44e82312ccbfd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/de54a37c1dfa2817b5838720fac44e82312ccbfd
2017-06-30 16:24:16+02:00
avcodec/magicyuv: Check that vlc len is not too large Fixes: runtime error: shift exponent -95 is negative Fixes: 2568/clusterfuzz-testcase-minimized-4926115716005888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
341f01290c2353669ed2263f56e1a9f4c67cc597
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/341f01290c2353669ed2263f56e1a9f4c67cc597
2017-07-12 17:26:18+02:00
avcodec/ylc: Fix vlc of 31 bits Fixes: runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Fixes: 2515/clusterfuzz-testcase-minimized-6197200012967936 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Reviewed-by: Paul B Mahol <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
fe9242204d33db070b8a9d907d93c9ead8a6f3ee
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fe9242204d33db070b8a9d907d93c9ead8a6f3ee
2017-07-08 23:45:47+02:00
hwcontext_d3d11va: fix crash on frames_init failure It appears in this case, frames_ininit is called twice (once by av_hwframe_ctx_init(), and again by unreffing the frames ctx ref). Signed-off-by: Luca Barbato <[email protected]>
086321c612185469ebb85a1887527c8915b488b7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/086321c612185469ebb85a1887527c8915b488b7
2017-06-27 00:23:12+02:00
avcodec/hevc_filter: Fix invalid shift Fixes: runtime error: left shift of negative value -1 Fixes: 2299/clusterfuzz-testcase-minimized-4843509351710720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
d7b3d5c3f2e2ff1994762b5e09c05fbc33790b5b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d7b3d5c3f2e2ff1994762b5e09c05fbc33790b5b
2017-06-21 02:25:23+02:00
avcodec/truemotion2: Move skip computation after checks Fixes: runtime error: signed integer overflow: 630067357 * 4 cannot be represented in type 'int' Fixes: 2233/clusterfuzz-testcase-minimized-5943031318446080 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
3c716682a8b69e6644a385a663aaf0e5dc808ae8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/3c716682a8b69e6644a385a663aaf0e5dc808ae8
2017-06-16 00:21:30+02:00
avcodec/mpeg4videodec: Fix runtime error: signed integer overflow: 53098 * 40448 cannot be represented in type 'int' Fixes: 2106/clusterfuzz-testcase-minimized-6136503639998464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
18bca25adbae9d010d75f9fc197c0af656af758d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/18bca25adbae9d010d75f9fc197c0af656af758d
2017-06-06 16:54:50+02:00
avcodec/sbrdsp_fixed: Return an error from sbr_hf_apply_noise() if operations are impossible Fixes: 1775/clusterfuzz-testcase-minimized-5330288148217856 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
d549f026d8b64b879c3ce3b8c7d153c82aa5eb52
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d549f026d8b64b879c3ce3b8c7d153c82aa5eb52
2017-06-13 17:39:13+02:00
avcodec/qdrw: Fix null pointer dereference The RGB555 PACKBITSRGN case tries to read a palette, if such palette is actually stored then it accesses a null pointer. All 16bit samples i could find use DIRECTBITSRGN. Fixes: 2065/clusterfuzz-testcase-minimized-6298930457346048 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
46b865ea9f86cbd12e1bf701913263c7932cccb0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/46b865ea9f86cbd12e1bf701913263c7932cccb0
2017-06-04 23:41:35+02:00
libavfilter/scale2ref: Add constants for the primary input Variables pertaining to the main video are now available when using the scale2ref filter. This allows, as an example, scaling a video with another as a reference point while maintaining the original aspect ratio of the primary/non-reference video. Consider the following graph: scale2ref=iw/6:-1 [main][ref] This will scale [main] to 1/6 the width of [ref] while maintaining the aspect ratio. This works well when the AR of [ref] is equal to the AR of [main] only. What the above filter really does is maintain the AR of [ref] when scaling [main]. So in all non-same-AR situations [main] will appear stretched or compressed to conform to the same AR of the reference video. Without doing this calculation externally there is no way to scale in reference to another input while maintaining AR in libavfilter. To make this possible, we introduce eight new constants to be used in the w and h expressions only in the scale2ref filter: * main_w/main_h: width/height of the main input video * main_a: aspect ratio of the main input video * main_sar: sample aspect ratio of the main input video * main_dar: display aspect ratio of the main input video * main_hsub/main_vsub: horiz/vert chroma subsample vals of main * mdar: a shorthand alias of main_dar Of course, not all of these constants are needed for maintaining the AR, but adding additional constants in line of what is available for in/out allows for other scaling possibilities I have not imagined. So to now scale a video to 1/6 the size of another video using the width and maintaining its own aspect ratio you can do this: scale2ref=iw/6:ow/mdar [main][ref] This is ideal for picture-in-picture configurations where you could have a square or 4:3 video overlaid on a corner of a larger 16:9 feed all while keeping the scaled video in the corner at its correct aspect ratio and always the same size relative to the larger video. I've tried to re-use as much code as possible. I could not find a way to avoid duplication of the var_names array. It must now be kept in sync with the other (the normal one and the scale2ref one) for everything to work which does not seem ideal. For every new variable introduced/removed into/from the normal scale filter one must be added/removed to/from the scale2ref version. Suggestions on how to avoid var_names duplication are welcome. var_values has been increased to always be large enough for the additional scale2ref variables. I do not forsee this being a problem as the names variable will always be the correct size. From my understanding of av_expr_parse_and_eval it will stop processing variables when it runs out of names even though there may be additional (potentially uninitialized) entries in the values array. The ideal solution here would be using a variable-length array but that is unsupported in C90. This patch does not remove any functionality and is strictly a feature patch. There are no API changes. Behavior does not change for any previously valid inputs. The applicable documentation has also been updated. Signed-off-by: Kevin Mark <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
3385989b98be7940044e4f0a6b431a0a00abf2fa
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/3385989b98be7940044e4f0a6b431a0a00abf2fa
2017-06-01 22:56:08+02:00
cmdutils_opencl: Fix read of uninitialized pointer Fixes: CID1396856 Signed-off-by: Michael Niedermayer <[email protected]>
d712a5cddbfc12e21384f97a291aa64ea7e8005f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d712a5cddbfc12e21384f97a291aa64ea7e8005f
2017-05-11 13:02:12+02:00
avcodec/ra144: Fix runtime error: signed integer overflow: 11184810 * 404 cannot be represented in type 'int' Fixes: 1884/clusterfuzz-testcase-minimized-4637425835966464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
4c472c52525fcab4c80cdbc98b4625d318c84fcb
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4c472c52525fcab4c80cdbc98b4625d318c84fcb
2017-05-28 21:38:55+02:00
avcodec/jpeg2000: Fix runtime error: signed integer overflow: 4185 + 2147483394 cannot be represented in type 'int' Fixes: 1870/clusterfuzz-testcase-minimized-4686788029317120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
781f88bb26534ececc76eaa972f02536ba2f0f55
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/781f88bb26534ececc76eaa972f02536ba2f0f55
2017-05-28 14:01:12+02:00
avformat/options: log filename on open The loglevel is choosen so that the main filename and any images of multi image sequences are shown only at debug level to avoid clutter. This makes exploits in playlists more visible. As they would show accesses to private/sensitive files Signed-off-by: Michael Niedermayer <[email protected]>
53e0d5d7247548743e13c59c35e59fc2161e9582
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/53e0d5d7247548743e13c59c35e59fc2161e9582
2017-06-03 23:14:04+02:00
hevc: fix race condition in max_ra/seq_decode. These variables are shared between frame threads, but they are updated post-setup_finished() if a EOB/EOS slice type occurs. Moving the EOB/EOS slices to the next frame thread instance (by parsing them leading into the next picture instead of trailing behind the last picture) effectively prevents this race condition. This fixes tsan failures on hevc-conformance-NoOutPrior_A_Qualcomm_1.
ca2209d67af0a73fe0edb2fce1cea2445dbfd8db
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ca2209d67af0a73fe0edb2fce1cea2445dbfd8db
2017-05-25 10:29:07-04:00
avcodec/fmvc: Fix off by 1 error Fixes: out of array access Fixes: 1643/clusterfuzz-testcase-minimized-6117573403869184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
e11dcc35bb4dbacd87378465b4cafa6a604e8b87
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e11dcc35bb4dbacd87378465b4cafa6a604e8b87
2017-05-17 02:17:51+02:00
avcodec/ivi_dsp: Fix runtime error: left shift of negative value -2 Fixes: 1839/clusterfuzz-testcase-minimized-6238490993885184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
357f2316a08478a4442e8051978c7b161e10281c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/357f2316a08478a4442e8051978c7b161e10281c
2017-05-28 03:04:21+02:00
lavc/mediacodec_wrapper: fix local reference leaks
224bb46fb857dab589597bdab302ba8ba012008c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/224bb46fb857dab589597bdab302ba8ba012008c
2017-05-23 15:25:03+02:00
avcodec/aac_defines: Add missing () to AAC_HALF_SUM() macro Fixes: runtime error: shift exponent 1073741848 is too large for 32-bit type 'INTFLOAT' (aka 'int') Fixes: 1880/clusterfuzz-testcase-minimized-4900645322620928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
872bac81590ccbec40ba7ad203421d9e38d1b253
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/872bac81590ccbec40ba7ad203421d9e38d1b253
2017-05-28 21:20:28+02:00
avcodec/cllc: Check bitstream end before decoding pixels Fixes timeout Fixes: 1802/clusterfuzz-testcase-minimized-5008293510512640 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
cfec0d64752509f8ac798acca6225df630fa5284
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cfec0d64752509f8ac798acca6225df630fa5284
2017-05-24 20:03:33+02:00
avcodec/ffv1dec: Fix runtime error: signed integer overflow: 1550964438 + 1550964438 cannot be represented in type 'int' Fixes: 1559/clusterfuzz-testcase-minimized-5048096079740928 Fixes: 1560/clusterfuzz-testcase-minimized-6011037813833728 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
8630b2cd36c57918acfe18302fe77d1ceefbd676
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8630b2cd36c57918acfe18302fe77d1ceefbd676
2017-05-13 23:28:33+02:00
avcodec/cavsdec: Fix runtime error: signed integer overflow: 31 + 2147483640 cannot be represented in type 'int' Fixes: 1506/clusterfuzz-testcase-minimized-5401272918212608 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
5ac17f187ae6ec97ad41b763f999bd99782c37aa
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5ac17f187ae6ec97ad41b763f999bd99782c37aa
2017-05-13 00:43:07+02:00
avcodec/vp8dsp: vp7_luma_dc_wht_c: Fix multiple runtime error: signed integer overflow: -1366381240 + -1262413604 cannot be represented in type 'int' Fixes: 1440/clusterfuzz-testcase-minimized-5785716111966208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
ccce2248bf56692fc7bd436ca2c9acca772d486a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ccce2248bf56692fc7bd436ca2c9acca772d486a
2017-05-12 14:22:50+02:00
avcodec/scpr: mask bits to prevent out of array read Fixes: 1615/clusterfuzz-testcase-minimized-6625214647500800 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Reviewed-by: Paul B Mahol <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
5666b95c9f27efa6f9b1e1bb6c592b9a8d78bca5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5666b95c9f27efa6f9b1e1bb6c592b9a8d78bca5
2017-05-16 23:14:28+02:00
avcodec/eatqi: Fix runtime error: signed integer overflow: 4466147 * 1075 cannot be represented in type 'int' Fixes: 1443/clusterfuzz-testcase-minimized-4826998612426752 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
a8de60ba2740185c53cabbee6c00ed67a0d530e2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a8de60ba2740185c53cabbee6c00ed67a0d530e2
2017-05-10 21:32:53+02:00
avcodec/cavs: Check updated MV Fixes: runtime error: signed integer overflow: 251 + 2147483647 cannot be represented in type 'int' Fixes: 1438/clusterfuzz-testcase-minimized-4917542646710272 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
5871adc90f8c1037535563e33ebeaf032bb4d5d6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5871adc90f8c1037535563e33ebeaf032bb4d5d6
2017-05-10 15:21:10+02:00
avcodec/svq3: Fix multiple runtime error: signed integer overflow: -237341 * 24552 cannot be represented in type 'int' Fixes: 1429/clusterfuzz-testcase-minimized-5959951610544128 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
ae6fd1790f48c457a8cedb445dcac73f8f7b7698
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ae6fd1790f48c457a8cedb445dcac73f8f7b7698
2017-05-10 01:27:15+02:00
avcodec/aacsbr_fixed: Fix multiple runtime error: left shift of negative value -407 Fixes: 1674/clusterfuzz-testcase-minimized-6092531563495424 Fixes: 1686/clusterfuzz-testcase-minimized-6282691643179008 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
2ccd2c9003c77aee8ffb5f4f43863e35bdf0e4b6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2ccd2c9003c77aee8ffb5f4f43863e35bdf0e4b6
2017-05-19 13:14:12+02:00
avformat/matroskadec: fix resource leak Fixes Coverity CID: 1405453 Reviewed-by: wm4 <[email protected]> Reviewed-by: Hendrik Leppkes <[email protected]> Signed-off-by: Steven Liu <[email protected]>
cc25a887c5467be5c7b004665047a32d36c9cf42
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cc25a887c5467be5c7b004665047a32d36c9cf42
2017-05-07 11:29:08+08:00
avcodec/aacsbr_fixed: Fix multiple runtime error: shift exponent 170 is too large for 32-bit type 'int' Fixes part of 1709/clusterfuzz-testcase-minimized-4513580554649600 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
6310fc714de3cd73848416ead73228fcef8b6dc0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6310fc714de3cd73848416ead73228fcef8b6dc0
2017-05-21 02:31:45+02:00
avcodec/diracdec: Fix Assertion frame->buf[0] failed at libavcodec/decode.c:610 Fixes: 1487/clusterfuzz-testcase-minimized-6288036495097856 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
6899e6e56065d9365963e02690dc9e2ce7866050
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6899e6e56065d9365963e02690dc9e2ce7866050
2017-05-11 23:55:59+02:00
configure: fix libopus detection Prevents compilation failures on libopus < 1.0.3 Regression since 37941878.
c53bf8c9b8ad7a2dc786d5749598c4ac67c4ad2d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c53bf8c9b8ad7a2dc786d5749598c4ac67c4ad2d
2017-05-04 00:26:13-03:00
avutil/softfloat: Fix multiple runtime error: left shift of negative value -8 Fixes: 1352/clusterfuzz-testcase-minimized-5757565017260032 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
35f3df0d76e28969fa77f2b865e2e40b3ba69722
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/35f3df0d76e28969fa77f2b865e2e40b3ba69722
2017-05-06 00:33:19+02:00
avfilter/avf_showcqt: add attack option Signed-off-by: Muhammad Faiz <[email protected]>
3408f4669427f5e950774d135c007f77d0d08d61
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/3408f4669427f5e950774d135c007f77d0d08d61
2017-04-09 14:38:42+07:00
avcodec/pthread_frame, decode: allow errors to happen on draining So, all frames and errors are correctly reported in order. Also limit the numbers of error during draining to prevent infinite loop. This fix fate failure with THREADS>=4: make fate-h264-attachment-631 THREADS=4 This also reverts a755b725ec1d657609c8bd726ce37e7cf193d03f. Suggested-by: wm4, Ronald S. Bultje, Marton Balint Reviewed-by: w4 <[email protected]> Reviewed-by: Ronald S. Bultje <[email protected]> Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Muhammad Faiz <[email protected]>
d535e0c14004a15bb38ea288fa9a4f2e27d26f6b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d535e0c14004a15bb38ea288fa9a4f2e27d26f6b
2017-04-30 05:48:21+07:00
fic: set pict_type/key_frame after (instead of during) slice decoding. This fixes a race condition that was already documented in the source code, and is also reported by tsan in fate-fic-avi.
73f863d751df84db7a0ca1bd83cdff1b95dc94dd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/73f863d751df84db7a0ca1bd83cdff1b95dc94dd
2017-03-31 08:26:23-04:00
pthread_frame: don't sync items between threads for intra-only codecs. Intra-only codecs should either be able to read these items from the bitstream, or they should be set upon codec initialization. In both cases, syncing these items at runtime is unnecessary. In practice, this fixes race conditions for decoders that read these values from the bitstream.
027ee9b3ed697ff080be0f14b47a11c89ce68cdd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/027ee9b3ed697ff080be0f14b47a11c89ce68cdd
2017-03-28 18:04:27-04:00
h264: revert 1189af429211ac650aac730368a6cf5b23756605. The patch introduces race conditions.
8c2aa45d4a99dc0d9990dfb56782487006f718c3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8c2aa45d4a99dc0d9990dfb56782487006f718c3
2017-03-28 18:04:27-04:00
avcodec/mpegaudiodec_template: Fix 2 runtime error: signed integer overflow Fixes: 873/clusterfuzz-testcase-5714546230558720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
b15818642b4e8c4ea61bf93bc6920e71a834a535
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b15818642b4e8c4ea61bf93bc6920e71a834a535
2017-03-21 20:52:08+01:00
vf_hwupload: Add missing return value check Add missing return value checks to suppress build warning and remove noop ff_formats_unref() calling. Note: most filters using ff_formats_ref() didn't have a suitable error handling, it's a potential memory leak issue. Signed-off-by: Jun Zhao <[email protected]> Signed-off-by: Mark Thompson <[email protected]>
bf238a6a3ca92de686e0e103135c1336f33f685b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/bf238a6a3ca92de686e0e103135c1336f33f685b
2017-03-12 18:12:30+00:00
avcodec/dca_xll: Fix runtime error: signed integer overflow: 1762028192 + 698372290 cannot be represented in type 'int' Fixes: 762/clusterfuzz-testcase-5927683747741696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
f4c2302ee24d8a6a31226acca48fe9caed597a8c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f4c2302ee24d8a6a31226acca48fe9caed597a8c
2017-03-12 04:38:14+01:00
avformat/oggparsedaala: Do not leave an invalid value in gpshift Fixes: undefined behavior Fixes: 702974 Found-by: Thomas Guilbert <[email protected]> Reviewed-by: Rostislav Pehlivanov <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
23ae3cc822915ede2bb4e85047ab46cc5bc71268
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/23ae3cc822915ede2bb4e85047ab46cc5bc71268
2017-04-01 22:09:23+02:00
avcodec/ituh263dec: Use 0xffff as error code in h263p_decode_umotion() This matches ff_h263_decode_motion() both functions error codes are interpreted by the same common code Fixes: 690/clusterfuzz-testcase-4744944981901312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
12c3e120fe8f8d6881001eade390d8a5c185783d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/12c3e120fe8f8d6881001eade390d8a5c185783d
2017-03-02 03:16:12+01:00
avcodec/dca_xll: Fix runtime error: signed integer overflow: -1073741824 * 32768 cannot be represented in type 'int' Fixes: 629/clusterfuzz-testcase-6697457381539840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
e8a3498f2452ba2be605b1ffb5974143095aacf1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e8a3498f2452ba2be605b1ffb5974143095aacf1
2017-02-21 00:40:20+01:00
avcodec/h264_ps: Fix runtime error: signed integer overflow: -1094995528 * 2 cannot be represented in type 'int' Fixes: 615/clusterfuzz-testcase-5488002644049920 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
59e5b05ef6f26064fc399f8e23aa05f962b8ae48
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/59e5b05ef6f26064fc399f8e23aa05f962b8ae48
2017-02-19 22:55:04+01:00
avcodec/h264_cabac: runtime error: signed integer overflow: 2147483647 + 14 cannot be represented in type 'int' Fixes: 614/clusterfuzz-testcase-4931860079575040 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
258763ad0e1efff82bbe2beb97527d3c19f40932
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/258763ad0e1efff82bbe2beb97527d3c19f40932
2017-02-19 22:41:40+01:00
avcodec/mpegaudiodec_template: Correct return code on id3 tag discarding Fixes: 665/clusterfuzz-testcase-4863789881098240 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
5d81616be332cca99304d0b747c2c8e2d719f349
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5d81616be332cca99304d0b747c2c8e2d719f349
2017-02-24 22:23:53+01:00
avfilter/af_hdcd: Fix leak of memory allocated by ff_make_format_list() Fixes CID1396265 Signed-off-by: Michael Niedermayer <[email protected]>
0a5add45c7527bbe627899be744f962588e5b2fa
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0a5add45c7527bbe627899be744f962588e5b2fa
2017-01-22 02:28:53+01:00
vaapi_h264: Scale log2_max_pic_order_cnt_lsb with max_b_frames Before this change, it was possible to overflow pic_order_cnt_lsb and generate a stream with invalid POC numbering. This makes sure that the field is large enough that a single IDR B* P sequence uses fewer than half the available POC lsb values.
89725a8512721fffd190021ded2d3f5b42e20e2a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/89725a8512721fffd190021ded2d3f5b42e20e2a
2017-01-11 23:03:58+00:00
avcodec/bsf: fix resource leak in av_bsf_list_parse_str cid: 1396268 when av_strdup(str) error, the lst need release Reviewed-by: James Almer <[email protected]> Signed-off-by: Steven Liu <[email protected]>
d9c2cfd31675a6403ae4ac7c141a8185dadceb12
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d9c2cfd31675a6403ae4ac7c141a8185dadceb12
2017-01-11 04:09:47+08:00
avcodec/pixlet: fix undefined behaviour in postprocess_chroma Signed-off-by: Paul B Mahol <[email protected]>
43cd33be16b21b9a217025e208f4ffbf0bf81da4
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/43cd33be16b21b9a217025e208f4ffbf0bf81da4
2016-12-24 10:22:39+01:00
avcodec/vp56: Check for the bitstream end, pass error codes on Fixes timeout Fixes: 446/fuzz-3-ffmpeg_VIDEO_AV_CODEC_ID_VP6_fuzzer Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
9e6a2427558a718be0c1fffacffd935f630a7a8d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9e6a2427558a718be0c1fffacffd935f630a7a8d
2017-01-24 23:01:04+01:00
lavc/videotoolboxenc: flush/free frames on close Prevents encode callback from running after codec is closed. Fixes a crash when an error is returned. Signed-off-by: Rick Kern <[email protected]>
aa413b810a7f94d8317635160a1de1b573b138ee
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/aa413b810a7f94d8317635160a1de1b573b138ee
2016-10-17 08:58:17-04:00
rtmpproto: Check the return from ff_amf_read_string If this failed, we used to continue with an uninitialized filename buffer. CC: [email protected] Signed-off-by: Martin Storsjö <[email protected]>
7395784ba72742b6daa62d35db4028e09f3fdf06
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7395784ba72742b6daa62d35db4028e09f3fdf06
2016-10-14 23:11:08+03:00
avcodec/h264_refs: Change default case to av_assert0() to suppress warning Should fix "libavcodec/h264_refs.c:372:13: warning: variable 'i' is used uninitialized whenever switch default is taken" Found-by: durandal_17 Suggested-by: jkqxz Signed-off-by: Michael Niedermayer <[email protected]>
5bbffe3412c1c34873d83d3fb80b379bb6e53d3f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5bbffe3412c1c34873d83d3fb80b379bb6e53d3f
2016-09-12 12:33:44+02:00
avformat/swfdec: Move packet size check before side data allocation Fixes memleak Fixes: 9eb9cf5b8c26dd0fa7107ed0348dcc1f/signal_sigabrt_7ffff6ae7c37_8927_f14c2a6ae1ad0bbde2c94f1da50e7074.swf Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
2a3720bc22d92d236ce62112edf80103e33ece1b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2a3720bc22d92d236ce62112edf80103e33ece1b
2016-08-19 03:05:52+02:00
avcodec/avpacket: clear side_data_elems Fixes null pointer dereference Found-by: 连一汉 <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
5e1bf9d8c0d2cdbbf17b06a5dfdf87a635b3203b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5e1bf9d8c0d2cdbbf17b06a5dfdf87a635b3203b
2016-09-12 23:53:07+02:00
cook: use the bytestream2 API for reading extradata Fixes possible invalid reads in corrupted files. CC: [email protected] Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
409d1cd2c955485798f8b0b0147c2b899b9144ec
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/409d1cd2c955485798f8b0b0147c2b899b9144ec
2016-08-18 17:06:46+02:00
lavc: free buffer_frame/pkt on avcodec_open2() failure Fixes memory leaks in some FATE tests.
e9bfff1cc66c85b91b262c41e8aa5e8685606225
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e9bfff1cc66c85b91b262c41e8aa5e8685606225
2016-08-11 10:52:13+02:00
avfilter/vf_paletteuse: enable skip_initial_unpaired Fixes crash due to unprocessed input being passed through This fixes the last segfault caused by mixing 3.0 and 3.1 libs and applications Signed-off-by: Michael Niedermayer <[email protected]>
8baa1d2209870753602ba36e522801ca5fb533e8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8baa1d2209870753602ba36e522801ca5fb533e8
2016-06-26 01:08:28+02:00
avcodec/h264: Put context_count check back Fixes assertion failure Signed-off-by: Michael Niedermayer <[email protected]>
f883f0b0bd0dac76b58e49f5c75cf9b497eecaa0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f883f0b0bd0dac76b58e49f5c75cf9b497eecaa0
2016-06-08 15:15:00+02:00
avformat/oggparseopus: Fix Undefined behavior in oggparseopus.c and libavformat/utils.c Fixes: usan_granule_overflow constant type fix by commiter Signed-off-by: Michael Niedermayer <[email protected]>
1a82d2cf8fb6a7e854e7548dfcf73c3d046b34ac
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1a82d2cf8fb6a7e854e7548dfcf73c3d046b34ac
2016-05-29 00:58:15+02:00
lossless audio dsp: unroll The loops are guaranteed to be at least multiples of 8, so this unrolling is safe but allows exploiting execution ports. For int32 version: 68 -> 58c. Signed-off-by: Michael Niedermayer <[email protected]>
9ca16bdd3f0461b40d369080647747ae70715daf
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9ca16bdd3f0461b40d369080647747ae70715daf
2016-05-11 21:03:07+02:00
avcodec/rscc: check input buffer size for deflate mode Fixes overreads. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: James Almer <[email protected]>
b2244fa0a624f7e38893d58265e9c039bed2e4de
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b2244fa0a624f7e38893d58265e9c039bed2e4de
2016-05-10 22:07:19-03:00
ffplay: fix silence insertion on error or pause Insertion of silence was a bit broken since df34b700981de606ca4847e1ed0bfdf9ac3e9104 because the info whether or not the source buffer supposed to be silence must be kept between callbacks. Failing to do so causes rogue samples from the last buffer to be presented, I guess even a crash can occur under some circumstances. This patch uses a NULL audio_buf to keep the silence state across audio callbacks. Reviewed-by: Lukasz Marek <lukasz.m.luki2 at gmail.com> Signed-off-by: Marton Balint <[email protected]>
a07934d51b40b0f48be531a359d39c091c414643
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a07934d51b40b0f48be531a359d39c091c414643
2016-04-04 23:24:58+02:00
mov: Check the entries value when parsing dref boxes And properly reset the entries count when resetting the entries. CC: [email protected] Bug-Id: 929 Bug-Id: CVE-2016-3062
7e01d48cfd168c3dfc663f03a3b6a98e0ecba328
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7e01d48cfd168c3dfc663f03a3b6a98e0ecba328
2016-03-11 14:29:13+01:00
swscale/swscale-test: Check av_image_fill_linesizes() for failure Signed-off-by: Michael Niedermayer <[email protected]>
61ea7f15094de9f44423017152b76c644b6ba89c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/61ea7f15094de9f44423017152b76c644b6ba89c
2016-02-04 01:49:38+01:00
avformat: Remove support for libquvi libquvi has not been updated since 2013. It also has a number of security issues.
2d40a09b6e73230b160a505f01ed1acf169e1d9f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2d40a09b6e73230b160a505f01ed1acf169e1d9f
2016-01-24 16:01:04+00:00
asfdec_o: prevent overflow causing seekback This fixes infinite loops. Reviewed-by: Alexandra Hájková <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
74474750f1ac522730dae271a5ea5003caa8b73c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/74474750f1ac522730dae271a5ea5003caa8b73c
2016-01-15 00:38:50+01:00
avpacket: fix size check in packet_alloc The previous check only caught sizes from -AV_INPUT_BUFFER_PADDING_SIZE to -1. This fixes ubsan runtime error: signed integer overflow: 2147483647 + 32 cannot be represented in type 'int' Signed-off-by: Andreas Cadhalpun <[email protected]> Signed-off-by: Anton Khirnov <[email protected]>
fa463aa83a4920b0eed47ad1f79775dfc53d21ec
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fa463aa83a4920b0eed47ad1f79775dfc53d21ec
2016-01-07 08:20:21+01:00
avutil/mathematics: return INT64_MIN (=AV_NOPTS_VALUE) from av_rescale_rnd() for overflows Fixes integer overflow Fixes: mozilla bug 1229167 Found-by: Tyson Smith Signed-off-by: Michael Niedermayer <[email protected]>
f03c2ceec174877e03bb302f5971fbe9ffbe4856
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f03c2ceec174877e03bb302f5971fbe9ffbe4856
2015-12-02 21:38:11+01:00
avformat/mxfenc: Do not crash if there is no packet in the first stream Fixes: Ticket4914 Signed-off-by: Michael Niedermayer <[email protected]>
b51e7554e74cbf007a1cab83c7bed3ad9fa2793a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b51e7554e74cbf007a1cab83c7bed3ad9fa2793a
2015-12-13 16:42:48+01:00
aacsbr: ensure strictly monotone time borders This fixes a division by zero in the aac_fixed decoder. Signed-off-by: Andreas Cadhalpun <[email protected]>
ff8816f7172b94028131ee2426ba35e875d973ae
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ff8816f7172b94028131ee2426ba35e875d973ae
2015-12-11 00:04:04+01:00
lavfi/show_palette: fix memory leak Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning up usage of the formats API, and in particular fixed possible NULL pointer dereferences. This commit addresses the issue of possible resource leaks when some intermediate call fails. Unfortunately, even leaving aside this subtle intermediate failure aspect, commit 8087632027d755cd32ccc9e91ea025e276197055 was only partially successful in addressing memleaks. Hopefully, this commit fixes the issue completely. Tested with valgrind --leak-check=full --show-leak-kinds=all, and manual simulation of malloc/realloc failures. Fixes: CID 1270818. Reviewed-by: Clément Bœsch <[email protected]> Signed-off-by: Ganesh Ajjanagadde <[email protected]>
00c322014904c2d5be92cc292b162d31f18a7058
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/00c322014904c2d5be92cc292b162d31f18a7058
2015-12-09 07:57:37-05:00
avutil/threadmessage: split the pthread condition in two Fix a dead lock under certain conditions. Let's assume we have a queue of 1 message max, 2 senders, and 1 receiver. Scenario (real record obtained with debug added): [...] SENDER #0: acquired lock SENDER #0: queue is full, wait SENDER #1: acquired lock SENDER #1: queue is full, wait RECEIVER: acquired lock RECEIVER: reading a msg from the queue RECEIVER: signal the cond RECEIVER: acquired lock RECEIVER: queue is empty, wait SENDER #0: writing a msg the queue SENDER #0: signal the cond SENDER #0: acquired lock SENDER #0: queue is full, wait SENDER #1: queue is full, wait Translated: - initially the queue contains 1/1 message with 2 senders blocking on it, waiting to push another message. - Meanwhile the receiver is obtaining the lock, read the message, signal & release the lock. For some reason it is able to acquire the lock again before the signal wakes up one of the sender. Since it just emptied the queue, the reader waits for the queue to fill up again. - The signal finally reaches one of the sender, which writes a message and then signal the condition. Unfortunately, instead of waking up the reader, it actually wakes up the other worker (signal = notify the condition just for 1 waiter), who can't push another message in the queue because it's full. - Meanwhile, the receiver is still waiting. Deadlock. This scenario can be triggered with for example: tests/api/api-threadmessage-test 1 2 100 100 1 1000 1000 One working solution is to make av_thread_message_queue_{send,recv}() call pthread_cond_broadcast() instead of pthread_cond_signal() so both senders and receivers are unlocked when work is done (be it reading or writing). This second solution replaces the condition with two: one to notify the senders, and one to notify the receivers. This prevents senders from notifying other senders instead of a reader, and the other way around. It also avoid broadcasting to everyone like the first solution, and is, as a result in theory more optimized.
bd5c860fdbc33d19d2ff0f6d1f06de07c17560dd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/bd5c860fdbc33d19d2ff0f6d1f06de07c17560dd
2015-12-07 11:39:28+01:00
lavc/cbrt_tablegen: speed up tablegen This exploits an approach based on the sieve of Eratosthenes, a popular method for generating prime numbers. Tables are identical to previous ones. Tested with FATE with/without --enable-hardcoded-tables. Sample benchmark (Haswell, GNU/Linux+gcc): prev: 7860100 decicycles in cbrt_tableinit, 1 runs, 0 skips 7777490 decicycles in cbrt_tableinit, 2 runs, 0 skips [...] 7582339 decicycles in cbrt_tableinit, 256 runs, 0 skips 7563556 decicycles in cbrt_tableinit, 512 runs, 0 skips new: 2099480 decicycles in cbrt_tableinit, 1 runs, 0 skips 2044470 decicycles in cbrt_tableinit, 2 runs, 0 skips [...] 1796544 decicycles in cbrt_tableinit, 256 runs, 0 skips 1791631 decicycles in cbrt_tableinit, 512 runs, 0 skips Both small and large run count given as this is called once so small run count may give a better picture, small numbers are fairly consistent, and there is a consistent downward trend from small to large runs, at which point it stabilizes to a new value. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Ganesh Ajjanagadde <[email protected]>
07a11ebcab9b31e9fc784029e5d24e6fbf486ff3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/07a11ebcab9b31e9fc784029e5d24e6fbf486ff3
2016-01-11 17:20:38-05:00
aaccoder: prevent crash of anmr coder If minq is negative, the range of sf_idx can be larger than SCALE_MAX_DIFF allows, causing assertion failures later in encode_scale_factors. Reviewed-by: Claudio Freire <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
7a4652dd5da0502ff21c183b5ca7d76b1cfd6c51
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7a4652dd5da0502ff21c183b5ca7d76b1cfd6c51
2015-12-05 01:50:08+01:00
avfilter/vf_shuffleframes: Assert that the case of an uninitialized ret does not occur Fixes CID1258479 Reviewed-by: Paul B Mahol <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
736e2e2c30088d0c2a428a51372c78a0bfb7f356
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/736e2e2c30088d0c2a428a51372c78a0bfb7f356
2015-12-01 22:00:25+01:00
avcodec/webvttdec: Fix uninitialized use of variable "again" Fixes CID1338336 Signed-off-by: Michael Niedermayer <[email protected]>
4819446eae451a6e58d6ae41faefb5529af4e783
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4819446eae451a6e58d6ae41faefb5529af4e783
2015-11-11 00:40:37+01:00
avutil/softfloat: Fix overflows in shifts in av_cmp_sf() and av_gt_sf() Signed-off-by: Michael Niedermayer <[email protected]>
cee3c9d29aceec8cddd829acd6dfb56dc5f60322
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cee3c9d29aceec8cddd829acd6dfb56dc5f60322
2015-11-08 14:54:51+01:00
avutil/softfloat: Fix exponent underflow in av_mul_sf() Signed-off-by: Michael Niedermayer <[email protected]>
a1e3303fc01b95623d7a6963686c81b076690efd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a1e3303fc01b95623d7a6963686c81b076690efd
2015-11-08 14:23:38+01:00
avcodec/mpeg12dec: Do not call show_bits() with invalid bits Fixes assertion failure Fixes: 63e50545709a6440d3d59f6426d58db9/signal_sigabrt_7ffff6ae7cc9_8189_3272a3010fd98ddf947c662bbde1ac13.ts Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
973c3dba27d0b1a88c70f6661b6a90d2f2e50665
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/973c3dba27d0b1a88c70f6661b6a90d2f2e50665
2015-11-06 00:56:52+01:00
dca_parser: don't overwrite the sample rate, it may not be correct The parser only reads the dca core sample rate, which is limited to a maximum of 48000 Hz, while X96 and HD extensions can increase the sample rate up to 192000 Hz. This change prevents the parser and decoder fighting over the sample rate, potentially confusing user applications. This also fixes sample rate display of >48000Hz files with ffmpeg/ffprobe when using libdcadec. Fixes ticket #4397
00ae5b401b24592a9f7019baada5b349152ee2fc
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/00ae5b401b24592a9f7019baada5b349152ee2fc
2015-10-20 13:02:18+02:00
avformat/mov: fix integer overflow Partially fixes Ticket 4727. -duration is not a safe expression, since duration can be INT_MIN. One might ask how it can become INT_MIN. Although it is true that line 2574 is no longer reached with INT_MIN due to commit 053e80f6eaf8d87521fe58ea96886b6ee0bbe59d (which fixed another integer overflow issue), mov_update_dts_shift is called on line 3549 as well, right after a read of untrusted data. One can do the fix locally there, but that function is already a huge mess. Changing mov_update_dts_shift is likely better. This changes duration to INT_MIN + 1 in such cases. This should not make any practical difference since such streams are anyway fuzzer files. Tested with FATE. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Ganesh Ajjanagadde <[email protected]>
d59bfcd11229300182c672ca734568919a85f773
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d59bfcd11229300182c672ca734568919a85f773
2015-10-13 19:41:07-04:00
fate: increase fuzz on AAC LTP encoding test Fails on some newer systems (archlinux with a modern GCC version).
6eff30b0bcf9b9bee573de632c8093ad3a996921
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6eff30b0bcf9b9bee573de632c8093ad3a996921
2015-10-17 11:23:22+01:00
avformat/iff: check for possible overflow in 2nd argument of av_new_packet Signed-off-by: Paul B Mahol <[email protected]>
aff3acc54c079c2e5720dae150b0d963fd8a9ab0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/aff3acc54c079c2e5720dae150b0d963fd8a9ab0
2015-09-25 21:25:08+02:00
avcodec/mpeg12dec: Fix integer overflow Fixes: signal_sigabrt_7ffff6ac8cc9_686_cov_1897408623_microsoft_new_way_to_shove_mpeg2_in_asf.dvr_ms Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
863522431fb2fc7d35fce582fcaacdcf37fc3c44
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/863522431fb2fc7d35fce582fcaacdcf37fc3c44
2015-09-02 21:11:07+02:00
xavs: Do not try to set the bitrate tolerance without a bitrate Avoid a division by zero. Bug-Id: CID 1257655
167ea1fbf15ecefa30729f9b8d091ed431bf43bd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/167ea1fbf15ecefa30729f9b8d091ed431bf43bd
2015-08-23 21:44:38+02:00
asfdec: prevent memory leaks found with Coverity Scan Signed-off-by: Anton Khirnov <[email protected]>
c571424c7f6276a6374e1784ce2a33d4b6a4292d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c571424c7f6276a6374e1784ce2a33d4b6a4292d
2015-07-13 20:27:34+02:00
avutil/mem: Fix potential overflow in overallocation code Signed-off-by: Michael Niedermayer <[email protected]>
b3415e4c5f9205820fd6c9211ad50a4df2692a36
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b3415e4c5f9205820fd6c9211ad50a4df2692a36
2015-07-11 22:47:09+02:00
libavcodec/qsvenc.c: fix incorrect loop condition. For example, the encoder may return MFX_WRN_INCOMPATIBLE_VIDEO_PARAM warning i.e. ret==5 old loop implementation will repeat several times until output buffer overflow. New implementation explicitly uses loop only for device busy case. Signed-off-by: Michael Niedermayer <[email protected]>
b409748bc4412fa2d8e642585c4e5ab8a4d136cb
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b409748bc4412fa2d8e642585c4e5ab8a4d136cb
2015-07-09 02:25:39+02:00
h264: make sure the current picture is not made a long ref multiple times Fixes possible invalid reads, once one of those refs is freed, but the others remain. CC: [email protected]
6d4d3fee63c46d921c4870feab79269af94e84e1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6d4d3fee63c46d921c4870feab79269af94e84e1
2015-06-27 16:46:01+02:00
hevc: handle a NULL sps in set_sps() properly This can happen in update_thread_context(), when the previous frame was corrupted.
077b55943330150db0eafd36bbee614697cabd98
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/077b55943330150db0eafd36bbee614697cabd98
2015-07-12 18:57:10+02:00
aac_parser: add required padding for GetBitContext buffer Fixes stack buffer overflow errors detected by address sanitizer in various fate tests. CC: [email protected]
fb1473080223a634b8ac2cca48a632d037a0a69d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fb1473080223a634b8ac2cca48a632d037a0a69d
2015-06-09 10:05:54+02:00