commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
sanity checks Originally committed as revision 3202 to svn://svn.ffmpeg.org/ffmpeg/trunk
23854cadeceb28053643cbc707e75feebbd94b61
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/23854cadeceb28053643cbc707e75feebbd94b61
2004-06-06 19:44:05+00:00
10000l : fix a crash on x86 due to an horrible mistake in my x86_64 patch Originally committed as revision 13734 to svn://svn.mplayerhq.hu/mplayer/trunk/postproc
a7b42d28da8b680c75db2ecf129e5f438e35797b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a7b42d28da8b680c75db2ecf129e5f438e35797b
2004-10-22 00:21:57+00:00
-map and sanity checking patch by (Brian Foley <bfoley at compsoc dot nuigalway dot ie>) Originally committed as revision 1835 to svn://svn.ffmpeg.org/ffmpeg/trunk
bd0739804640939fea4fb6f1f625b82432d46947
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/bd0739804640939fea4fb6f1f625b82432d46947
2003-05-05 20:39:24+00:00
Applied Roumen Petrov patch to fix crash/memory leak Originally committed as revision 1758 to svn://svn.ffmpeg.org/ffmpeg/trunk
f0ef62405770cfa52124f4569a3deda206cccda9
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f0ef62405770cfa52124f4569a3deda206cccda9
2003-04-12 02:27:54+00:00
fixing mem corruption Originally committed as revision 1729 to svn://svn.ffmpeg.org/ffmpeg/trunk
5064357588a187672ca64c169dc6e6e406777629
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5064357588a187672ca64c169dc6e6e406777629
2003-04-04 13:36:07+00:00
MacOS X stack overflow? patch by (Sylvain Corré <sylvain dot corre at wanadoo.fr>) Originally committed as revision 1694 to svn://svn.ffmpeg.org/ffmpeg/trunk
d66c7abc937069d57fb156bcecec16e406b88c7b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d66c7abc937069d57fb156bcecec16e406b88c7b
2003-03-20 01:32:17+00:00
Fix a crash in ffserver when streaming to WMP from a file. However, it still doesn't seem to work for me anyway. Originally committed as revision 1391 to svn://svn.ffmpeg.org/ffmpeg/trunk
001bcd29556b32c1afd686c03f6bdd65dd0e9a36
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/001bcd29556b32c1afd686c03f6bdd65dd0e9a36
2003-01-03 20:00:49+00:00
* If a stream gets stuck in WAIT_FEED, then disconnecting the other end will clear out the stream. I think that this is really a linux bug in the handling of poll, but I did a workaround anyway. * Improve the statistics output and prevent a buffer overrun when lots of clients are connected. * Process ffm input when it is received and don't always be one ffm packet behind. * Try to avoid going through the poll loop when not required. Originally committed as revision 514 to svn://svn.ffmpeg.org/ffmpeg/trunk
a6e14edde01bafbbe54f6f451efa718a48975b47
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a6e14edde01bafbbe54f6f451efa718a48975b47
2002-05-18 21:33:05+00:00
negative black bugfix Originally committed as revision 2395 to svn://svn.mplayerhq.hu/mplayer/trunk/postproc
57d04d3f11290d1848efa3b47031762f936d4cb3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/57d04d3f11290d1848efa3b47031762f936d4cb3
2001-10-23 00:03:19+00:00
avfilter/vf_framerate: change blend factor precision This is done mainly in preparation for the SIMD patches. - for the 8-bit input, decrease the blend factor precision to 7-bit. - for the 16-bit input, increase the blend factor precision to 15-bit. - make sure the blend functions are not called with 0 or maximum blending factors, because we don't want the signed factor integers to overflow. Fate test changes are due to different rounding. Signed-off-by: Marton Balint <[email protected]>
2cbe6bac0337939f023bd1c37a9c455e6d535f3a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2cbe6bac0337939f023bd1c37a9c455e6d535f3a
2018-01-28 18:50:50+01:00
avcodec/dirac_dwt: Fix integer overflows in COMPOSE_DAUB97* Fixes: 4478/clusterfuzz-testcase-minimized-4752113767809024 Fixes: runtime error: signed integer overflow: -2147483626 + -319489 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
5e9a13a5a33bf7566591216e335f2529612100bb
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5e9a13a5a33bf7566591216e335f2529612100bb
2017-12-06 22:09:25+01:00
avformat/http: fix memory leak in parse_cookie. Signed-off-by: Michael Niedermayer <[email protected]>
9147c0975533c83564b1ba47f22952b291b80282
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9147c0975533c83564b1ba47f22952b291b80282
2018-01-12 12:31:55+01:00
dcaenc: cleanup on init failure and add a threadsafe init codec cap The encoder didn't clean up if a malloc failed during init. It also doesn't need any external tables to be initialized on init. Finally, it didn't need to check for whether avctx->priv_data exists during uninit. Signed-off-by: Rostislav Pehlivanov <[email protected]>
56e11ebf55a5e51a8a7131d382c2020e35d34f42
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/56e11ebf55a5e51a8a7131d382c2020e35d34f42
2018-01-13 18:06:59+00:00
patch by Alex Beregszaszi <[email protected]> - AVID (AVRn) support (workaround) - print error instead of failing for unsupported SOF - fixed the 0<code<FF range checking Originally committed as revision 435 to svn://svn.ffmpeg.org/ffmpeg/trunk
af289048d8f720743ed82a4e674cff01ab02a836
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/af289048d8f720743ed82a4e674cff01ab02a836
2002-05-03 16:34:40+00:00
working around undefined behavior of get-vlc if the vlc s invalid more debug output by default for errors (so we can see immedeatly whats wrong on bugreports) guess long_vectors mode Originally committed as revision 874 to svn://svn.ffmpeg.org/ffmpeg/trunk
68bd11f5de271a1a674f196a9e8ca2e7fe40ab6e
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/68bd11f5de271a1a674f196a9e8ca2e7fe40ab6e
2002-08-28 12:23:12+00:00
avcodec/exr: Check buf_size more completely Fixes: Out of heap array read Fixes: 4683/clusterfuzz-testcase-minimized-6152313673613312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
903be5e4f66268273dc6e3c42a7fdeaab32066ef
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/903be5e4f66268273dc6e3c42a7fdeaab32066ef
2017-12-30 21:02:49+01:00
avfilter/vf_framerate: fix scene score with negative linesize Also, do not overread input if linesize > width, or linesize is not divisible by 8, and use the proper rounded width/height for MAFD calculation. Signed-off-by: Marton Balint <[email protected]>
e403e4bdbea08af0c4a068eb560b577d1b64cf7a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e403e4bdbea08af0c4a068eb560b577d1b64cf7a
2017-12-21 23:03:10+01:00
avformat/hlsenc: Fix a memory leak when http_persistent is 1 Reviewed-by: Steven Liu <[email protected]>
3ac76d890d91905925a4d7f66a43e0023e13e149
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/3ac76d890d91905925a4d7f66a43e0023e13e149
2017-12-21 11:39:24+08:00
lavc: remove complex debug code around avcodec init locking This is just a lot of complicated and confusing code that had no purpose anymore. Also, the functions return values were checked only sometimes. Locking shouldn't fail anyway, so remove the return values. Barely any other pthread lock calls check the return value (including more important code that is more likely to fail horribly if locking fails). It could be argued that it might be helpful in some debugging situations, or when the user built FFmpeg without thread support against all good advice. But there are dummy atomics too, so the atomic check won't help with ensuring correctness absolutely. You gain very little. Also, for debugging, you can just raise the ASSERT_LEVEL, and then libavutil/thread.h will redefine the locking functions to explicitly check the return values.
4ed66517c62c599701b3793fa2843d5a8530a4f4
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4ed66517c62c599701b3793fa2843d5a8530a4f4
2017-12-26 02:50:00+01:00
avcodec/jpeg2000: Only allocate Jpeg2000Pass for the encoder Reduces memory needed. Fixes: OOM Fixes: 4427/clusterfuzz-testcase-minimized-5106919271301120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
b5587fd2c6ce39bad7a5e7ebb3bd86b6469648de
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b5587fd2c6ce39bad7a5e7ebb3bd86b6469648de
2017-12-01 23:12:07+01:00
cbs_h2645: Fix memory leak on when reading SEI fails
22aed77687f86b6b9efb9b0fdf4b26130a858c6d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/22aed77687f86b6b9efb9b0fdf4b26130a858c6d
2017-11-12 16:00:41+00:00
avcodec/mpeg4videodec: Use 64 bit intermediates for sprite delta Fixes: runtime error: signed integer overflow: -104713 * 65536 cannot be represented in type 'int' Fixes: 3453/clusterfuzz-testcase-minimized-5555554657239040 Fixes: 3528/clusterfuzz-testcase-minimized-6283628420005888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
e38f280fece38e270a6462a02cc034f4116a7912
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e38f280fece38e270a6462a02cc034f4116a7912
2017-10-10 23:58:40+02:00
avcodec/avpacket: deprecate av_copy_packet_side_data() It leaks memory and destroys the dst packet in case of failure, and it ultimately duplicates functionality already existing in the saner av_packet_copy_props(). Reviewed-by: wm4 Signed-off-by: James Almer <[email protected]>
cf3d2d52b59ddfc2a7c65a8e66f7698c4b837e51
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cf3d2d52b59ddfc2a7c65a8e66f7698c4b837e51
2017-10-01 19:19:22-03:00
avcodec/dirac_dwt: Fix integer overflow in COMPOSE_FIDELITYi*() Fixes: runtime error: signed integer overflow: 161 * 13872281 cannot be represented in type 'int' Fixes: 3295/clusterfuzz-testcase-minimized-4738998142500864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
67da2685e03805230207daab83ab43a390fbb887
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/67da2685e03805230207daab83ab43a390fbb887
2017-09-22 12:19:07+02:00
avcodec/svq3: Fix overflow in svq3_add_idct_c() Fixes: runtime error: signed integer overflow: 2147392585 + 524288 cannot be represented in type 'int' Fixes: 3348/clusterfuzz-testcase-minimized-4809500517203968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
2c933c51687db958d8045d25ed87848342e869f6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2c933c51687db958d8045d25ed87848342e869f6
2017-09-22 12:19:07+02:00
avfilter/avf_concat: check ff_insert_pad() for failure Signed-off-by: Paul B Mahol <[email protected]>
1a58da434ad0e8ba0167c4066e3dc7980c7b2804
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1a58da434ad0e8ba0167c4066e3dc7980c7b2804
2017-08-25 10:16:46+02:00
avformat/aviobuf: Fix signed integer overflow in avio_seek() Signed integer overflow is undefined behavior. Detected with clang and -fsanitize=signed-integer-overflow Signed-off-by: Vitaly Buka <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
eca2a49716ae1f42804dd3545da2f740edf03250
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/eca2a49716ae1f42804dd3545da2f740edf03250
2017-08-23 03:17:11+02:00
avcodec/dirac_dwt_template: Fix integer overflow in vertical_compose53iL0() Fixes: runtime error: signed integer overflow: 2147483646 + 2 cannot be represented in type 'int' Fixes: 3013/clusterfuzz-testcase-minimized-4644084197097472 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
a165b53daa8a3a526d2328ca72c4aa9e7f163045
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a165b53daa8a3a526d2328ca72c4aa9e7f163045
2017-08-20 21:14:47+02:00
webmdashenc: Fix memory leak Signed-off-by: Derek Buitenhuis <[email protected]>
a27c412795c2147e71c5b10782c97a15bf9dc81f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a27c412795c2147e71c5b10782c97a15bf9dc81f
2017-07-16 16:09:17+01:00
avcodec/hevc_cabac: Check for ff_init_cabac_decoder() failure in cabac_reinit() Fixes: runtime error: left shift of negative value -967831544 Fixes: 2815/clusterfuzz-testcase-minimized-6062914471460864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
4ff94558f23a5de43aed4ca3429963dd1d995250
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4ff94558f23a5de43aed4ca3429963dd1d995250
2017-08-03 15:42:52+02:00
avcodec/h264_slice: Fix signed integer overflow Fixes: runtime error: signed integer overflow: 26 + 2147483644 cannot be represented in type 'int' Fixes: 2456/clusterfuzz-testcase-minimized-4822695051001856 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
7592d97f10134422d4509ab1287796af70e003ba
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7592d97f10134422d4509ab1287796af70e003ba
2017-07-05 03:19:27+02:00
avcodec/cfhd: Check bpc before setting bpc in context Fixes: runtime error: shift exponent 32 is too large for 32-bit type 'int' Fixes: 2306/clusterfuzz-testcase-minimized-5002997392211968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
6f1d2355a7e4d681bea82b4cf4280272d9fe8af3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6f1d2355a7e4d681bea82b4cf4280272d9fe8af3
2017-06-22 01:54:40+02:00
avcodec/mpeg4videodec: Check sprite delta upshift against overflowing. Fixes: runtime error: signed integer overflow: -268386304 * 16 cannot be represented in type 'int' Fixes: 2204/clusterfuzz-testcase-minimized-5616756909408256 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
12245ab1f677074b8ff83e87f76a41aba692ccd6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/12245ab1f677074b8ff83e87f76a41aba692ccd6
2017-06-15 00:16:20+02:00
avcodec/flicvideo: Fix runtime error: signed integer overflow: 4864 * 459296 cannot be represented in type 'int' Fixes: 2174/clusterfuzz-testcase-minimized-5739234533048320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
90e8317b3b33dcb54ae01e419d85cbbfbd874963
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/90e8317b3b33dcb54ae01e419d85cbbfbd874963
2017-06-10 19:46:04+02:00
avcodec/scpr: optimize shift loop. Speeds code up from 50sec to 15sec Fixes Timeout Fixes: 3242/clusterfuzz-testcase-5811951672229888 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Reviewed-by: James Almer <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
981f04b2ae2d6e0355386aaff39840eb5d390a36
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/981f04b2ae2d6e0355386aaff39840eb5d390a36
2017-09-10 19:08:23+02:00
avcodec/mlpdec: Do not leave invalid values in matrix_out_ch[] on error Fixes: runtime error: index 12 out of bounds for type 'uint8_t [8]' Fixes: 1832/clusterfuzz-testcase-minimized-6574546079449088 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
ac8dfcbd89a818b786d05ebc1af70f7bf6aeb86e
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ac8dfcbd89a818b786d05ebc1af70f7bf6aeb86e
2017-05-27 14:37:42+02:00
avcodec/libfdk-aacdec: Correct buffer_size parameter the timeDataSize argument to aacDecoder_DecodeFrame() seems undocumented and until 2016 04 (203e3f28fbebec7011342017fafc2a0bda0ce530) unused. after that commit libfdk-aacdec interprets it as size in sample units and memsets that on error. FFmpeg as well as others (like GStreamer) did interpret it as size in bytes Fixes: 1442/clusterfuzz-testcase-minimized-4540199973421056 (This requires recent libfdk to reproduce) Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
ca6776a993903dbcfef5ae8a18556c40ecf83e1c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ca6776a993903dbcfef5ae8a18556c40ecf83e1c
2017-05-28 03:08:33+02:00
avcodec/wavpack: Fix runtime error: left shift of negative value -1 Fixes: 1807/clusterfuzz-testcase-minimized-6258676199325696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
bce362d36ccfe8f778662bcfd956187c958a39b5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/bce362d36ccfe8f778662bcfd956187c958a39b5
2017-05-24 20:03:06+02:00
avcodec/ivi_dsp: Fix multiple runtime error: left shift of negative value -71 Fixes: 1734/clusterfuzz-testcase-minimized-5385630815092736 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
8fb00b3e858b7a5aeccfe6bdfc10290c2121c3ec
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8fb00b3e858b7a5aeccfe6bdfc10290c2121c3ec
2017-05-22 02:16:39+02:00
avcodec/pixlet: Fixes: runtime error: signed integer overflow: 9203954323419769657 + 29897660706736950 cannot be represented in type 'long' Fixes: 1569/clusterfuzz-testcase-minimized-6328690508038144 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
a453f5549a8c3f8307200b32d3b342f0b4af3153
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a453f5549a8c3f8307200b32d3b342f0b4af3153
2017-05-14 17:03:30+02:00
avcodec/golomb: Fix runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Fixes: 1481/clusterfuzz-testcase-minimized-5264379509473280 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
2752410c47889a94778a541c09ed29ccce8a8de9
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2752410c47889a94778a541c09ed29ccce8a8de9
2017-05-11 23:55:49+02:00
avcodec/shorten: Check k in get_uint() Fixes: undefined shift Fixes: 1371/clusterfuzz-testcase-minimized-5770822591447040 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
7b6a51f59c467ab9f4b73122dc269206fb517425
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7b6a51f59c467ab9f4b73122dc269206fb517425
2017-05-06 18:28:57+02:00
tools/target_dec_fuzzer: Use decoder and not codec_id as argument This allows fuzzing decoders with the same codec_id We also avoid register all to allow the linker to prune unused sections and symbols Signed-off-by: Michael Niedermayer <[email protected]>
dec2fa8cc7089605d1d934d65dd2709cfe8aece2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/dec2fa8cc7089605d1d934d65dd2709cfe8aece2
2017-05-03 17:22:13+02:00
avcodec/vp3: Check remaining bits in unpack_dct_coeffs() Decreases the time spend decoding junk. May fix: 1283/clusterfuzz-testcase-minimized-6221126759874560 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
2f00300b779e7b247c85db0d7daef448225105ff
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2f00300b779e7b247c85db0d7daef448225105ff
2017-05-01 18:48:39+02:00
h264: don't re-call ff_h264_direct_ref_list_init() w/ frame-mt. I'm hoping that this will address the remaining tsan fate-h264 issues: WARNING: ThreadSanitizer: data race (pid=24478) Read of size 8 at 0x7dbc0001c828 by main thread (mutexes: write M3243): #0 ff_h264_ref_picture src/libavcodec/h264_picture.c:107 (ffmpeg+0x0000013b78d8) [..] Previous write of size 1 at 0x7dbc0001c82e by thread T2 (mutexes: write M3245): #0 ff_h264_direct_ref_list_init src/libavcodec/h264_direct.c:137 (ffmpeg+0x000001382c93) But I'm not sure because I haven't been able to reproduce locally.
7f05c5cea04112471d8147487aa3b44141922d09
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7f05c5cea04112471d8147487aa3b44141922d09
2017-04-07 13:29:45-04:00
codec_desc: mark some lossless audio codecs as intraonly. Fixes tsan warnings in several audio codecs (flac, alac, wavpack, tta and tak) that look like this: WARNING: ThreadSanitizer: data race (pid=14340) Read of size 4 at 0x7d64000169d8 by main thread (mutexes: write M1335): #0 update_context_from_thread src/libavcodec/pthread_frame.c:284 (ffmpeg+0x000000dc795f) [..] Previous write of size 4 at 0x7d64000169d8 by thread T1 (mutexes: write M1333): #0 wavpack_decode_block src/libavcodec/wavpack.c:1012 (ffmpeg+0x00000112b175)
467a0538100b193d205a922737358dcc8e957e94
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/467a0538100b193d205a922737358dcc8e957e94
2017-04-03 09:36:32-04:00
vf_drawtext: Fix memory leak
4cca2f74f25331067cfb234328411bd114664871
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4cca2f74f25331067cfb234328411bd114664871
2017-03-21 12:15:50+00:00
pthread_frame: Unreference hw_frames_ctx on per-thread codec contexts When decoding with threads enabled, the get_format callback will be called with one of the per-thread codec contexts rather than with the outer context. If a hwaccel is in use too, this will add a reference to the hardware frames context on that codec context, which will then propagate to all of the other per-thread contexts for decoding. Once the decoder finishes, however, the per-thread contexts are not freed normally, so these references leak. Merges Libav commit fd0fae60. Signed-off-by: wm4 <[email protected]>
fb69a8e1f124ee89e924344bfb7934937abed642
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fb69a8e1f124ee89e924344bfb7934937abed642
2017-03-21 06:16:49+01:00
avcodec/h264idct_template: Fix several runtime error: signed integer overflow Fixes: 652/clusterfuzz-testcase-6174944410992640 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
ec849f637e8548ec6c9b6329334944c7c81df443
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ec849f637e8548ec6c9b6329334944c7c81df443
2017-02-22 22:29:03+01:00
avcodec/rv34: Fix runtime error: signed integer overflow: 36880 * 66288 cannot be represented in type 'int' Fixes: 768/clusterfuzz-testcase-4807444305805312 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
a66c6e28b543804f50df1c6083a204219b6b1daa
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a66c6e28b543804f50df1c6083a204219b6b1daa
2017-03-13 04:48:43+01:00
avcodec/vp56: Clear dimensions in case of failure in the middle of a resolution change Similar code is used elsewhere in vp56 to force a more complete reinit in the future. Fixes null pointer dereference Fixes: 707/clusterfuzz-testcase-4717453097566208 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
4bed06637729ab000b79250c67d53078300e37c4
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4bed06637729ab000b79250c67d53078300e37c4
2017-03-02 03:16:18+01:00
avcodec/vp8: Check for bitsteam end in decode_mb_row_no_filter() Fixes timeout with 686/clusterfuzz-testcase-5853946876788736 this shortcuts (i.e. speeds up) the error and return-to-user when decoding a truncated frame Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Previous version reviewed by: "Ronald S. Bultje" <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
7b5ff7d57355dc608f0fd86e3ab32a2fda65e752
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7b5ff7d57355dc608f0fd86e3ab32a2fda65e752
2017-03-01 14:07:33+01:00
ffmpeg: make sure packets put into the muxing FIFO are refcounted Some callers (like do_subtitle_out()) call this with an AVPacket that is not refcounted. This can cause undefined behavior. Calling av_packet_move_ref() does not make a packet refcounted if it isn't yet. (And it can't be made to, because it always succeeds, and can't return ENOMEM.) Call av_packet_ref() instead to make sure it's refcounted. I couldn't find a case that is fixed by this with the current code. But it will fix the fate-pva-demux test with the later patches applied. Signed-off-by: wm4 <[email protected]>
33580a8625c77591919b6155a48da04dccc8d398
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/33580a8625c77591919b6155a48da04dccc8d398
2017-03-03 08:45:43+01:00
avcodec/vp3dsp: Fix multiple signed integer overflow: 46341 * 47523 cannot be represented in type 'int' Fixes: 664/clusterfuzz-testcase-4917047475568640 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
2b8b7921c55a93049a86cfeb2fda9423d16f8ebe
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2b8b7921c55a93049a86cfeb2fda9423d16f8ebe
2017-02-24 14:12:13+01:00
avcodec/qdrw: don't overwrite bpp when checking its value Finishes fixing ticket #6171
d04e0a6bcffed7b4a0a90ae25fb21466561762df
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d04e0a6bcffed7b4a0a90ae25fb21466561762df
2017-02-21 20:21:52-03:00
asfdec: Use the ASF stream count when iterating The AVFormat stream count can be larger due external factors, such as an id3 tag appended. Avoid an out of bound read. Signed-off-by: Luca Barbato <[email protected]>
8e67039c6312ba520945f2c01b7b14df056d5ed1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8e67039c6312ba520945f2c01b7b14df056d5ed1
2017-02-04 15:21:12+01:00
configure: Place all temporary files in one separate directory Place all temporary files within a single, quasi-atomically created temporary directory rather than relying on unsafe 'mktemp -u'. This prevents possible race conditions in case two parallel 'mktemp -u' calls returned the same path. Additionally, it reduces TMPDIR pollution by keeping all test files in a single subdirectory. Signed-off-by: Diego Biurrun <[email protected]>
78489822074096e3ae0f3c3b70accace955086f6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/78489822074096e3ae0f3c3b70accace955086f6
2017-01-29 20:17:46+01:00
avcodec/ylc: do not leak memory at uninit Signed-off-by: Paul B Mahol <[email protected]>
341d3ee441474167ac784bb39f2c31f211451707
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/341d3ee441474167ac784bb39f2c31f211451707
2016-12-26 20:18:00+01:00
mov: fix a possible invalid read in mov_read_mac_string() When the input string is too large, so the second condition in if () fails, the code will erroneously execute the else branch, indexing the mac_to_unicode table with a negative index. CC: [email protected] Bug-Id: 1000 Found-By: Kamil Frankowicz
46191a2da16f751e53d93646ae1388d421d12bee
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/46191a2da16f751e53d93646ae1388d421d12bee
2016-12-19 08:14:59+01:00
avpacket: fix leak on realloc in av_packet_add_side_data() If realloc fails, the pointer is overwritten and the previously allocated buffer is leaked, which goes against the expected functionality of keeping the packet unchanged in case of error. Signed-off-by: James Almer <[email protected]> Signed-off-by: Anton Khirnov <[email protected]>
aa498c3183236a93206b4a0e8225b9db0660b50d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/aa498c3183236a93206b4a0e8225b9db0660b50d
2016-11-23 13:17:52+01:00
avcodec/ituh263dec: Fix runtime error: left shift of 1342177279 by 1 places cannot be represented in type 'int' Fixes: 659/clusterfuzz-testcase-5866673603084288 Huge DMV could be created by an encoder ignoring the spec Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
0d85c7bb5a4c398863848ecdf44a0c9f1778da06
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0d85c7bb5a4c398863848ecdf44a0c9f1778da06
2017-02-24 00:38:45+01:00
mlz: limit next_code to data buffer size This fixes a heap-buffer-overflow detected by AddressSanitizer. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
1abcd972c4c0e16f1e83be2fd32a251f51b2946d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1abcd972c4c0e16f1e83be2fd32a251f51b2946d
2016-11-15 22:01:08+01:00
astdec: fix division by zero Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
9959a52b14bcfa3e5baeb3fc8a86c04bbc0d3d5d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9959a52b14bcfa3e5baeb3fc8a86c04bbc0d3d5d
2016-10-17 20:41:26+02:00
libopenjpegenc: fix out-of-bounds reads when filling the edges The calculation of width/height should round up, not round down to prevent setting width or height to 0. Also image->comps[compno].w is unsigned (at least in openjpeg2), so the calculation could silently wrap around without the explicit cast to int. Reviewed-by: Michael Bradshaw <[email protected]> Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
56706ac0d5723cb549fec2602e798ab1bf6004cd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/56706ac0d5723cb549fec2602e798ab1bf6004cd
2016-10-14 16:56:14+02:00
d3d11va: Use the proper decoding slice index The decoding buffer index expected by D3D11VA is the one from the ID3D11Texture2D not the one from the ID3D11VideoDecoderOutputView array in AVD3D11VAContext. Otherwise, when providing decoder slices that do not start from 0, pictures appear in bogus order. For an invalid index crashes and image corruption can occur. Signed-off-by: Diego Biurrun <[email protected]>
be630b1e08ebe8f766b1798accd6b8e5e096f5aa
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/be630b1e08ebe8f766b1798accd6b8e5e096f5aa
2016-10-05 18:37:27+02:00
matroskadec: fix NULL pointer dereference The problem was introduced in commit 1273bc6. Reviewed-by: James Almer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
eb751f06db9f627c8b5c63d08836a39f7572bf56
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/eb751f06db9f627c8b5c63d08836a39f7572bf56
2016-10-17 15:50:26+02:00
avconv: only retry decoding on actual decoding errors Errors during decoding are currently considered non-fatal and do not terminate transcoding, so even if parts of the data are corrupted, the rest may be decodable. However, that should apply only to the actual decoding calls, not to the failures elsewhere (e.g. configuring filters).
27085d1b47c3741cc0fac284c916127c4066d049
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/27085d1b47c3741cc0fac284c916127c4066d049
2016-10-02 11:41:45+02:00
mpegvideo_motion: Handle edge emulation even without unrestricted_mv Fix out of bounds read. Bug-Id: 962 Found by: F4B3CD@STARLAB and Agostino Sarubbo Signed-off-by: Vittorio Giovara <[email protected]>
136f55207521f0b03194ef5b55ba70f1635d6aee
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/136f55207521f0b03194ef5b55ba70f1635d6aee
2016-09-16 16:28:07+02:00
pcx: properly pad the scanline It is passed to the get_bits API, which requires buffers to be padded. Fixes possible invalid reads. CC: [email protected] Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
15ee419b7abaf17f8c662c145fe93d3dbf43282b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/15ee419b7abaf17f8c662c145fe93d3dbf43282b
2016-08-18 17:06:46+02:00
avcodec/cuvid: Always check for internal errors during parsing The cuvid parser is basically undocumented, and although you'd think that a failed callback would result in the overall parse call returning an error, that is not true. So, we end up silently trying to keep going as if nothing is wrong, which doesn't achieve anything. Solution: check the internal error flag every time. Signed-off-by: Philip Langdale <[email protected]> Signed-off-by: Timo Rothenpieler <[email protected]>
4029f05c8b0943a5446f254142d5e2bfedb50a0d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4029f05c8b0943a5446f254142d5e2bfedb50a0d
2016-09-10 22:27:24+02:00
mmaldec: limit internal buffering This uses a new MMAL feature, which limits the number of extra frames that can be buffered within the decoder. VIDEO_MAX_NUM_CALLBACKS can be defined as positive or negative number. Positive numbers are absolute, and can lead to deadlocks if the user underestimates the number of required buffers. Negative numbers specify the number of extra buffers, e.g. -1 means no extra buffer, (-1-N) means N extra buffers. Set a gratuitous default of -11 (N=10). This is much lower than the firmware default, which appears to be 96. This is backwards compatible, but needs a symbol only present in newer firmware headers. (It's an enum item, so it requires a check in configure.) Signed-off-by: Anton Khirnov <[email protected]>
74beead9bd596180bcac6108548fc0a86d8eb4ae
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/74beead9bd596180bcac6108548fc0a86d8eb4ae
2016-04-30 08:31:08+02:00
AAC encoder: fix filling of wi.clipping array Fill all windows in all window groups instead of only the first window of each group. Also avoid uninitialized access of window_type.
7d49abdf4750d63cd9bf71235d6f064152310fff
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7d49abdf4750d63cd9bf71235d6f064152310fff
2016-04-05 04:03:05-03:00
avcodec/h264_slice: Check PPS more extensively when its not copied Fixes Ticket5371 Fixes null pointer dereference Signed-off-by: Michael Niedermayer <[email protected]>
c50be7a52bc1e8e18a0059e489743ec12a43f257
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c50be7a52bc1e8e18a0059e489743ec12a43f257
2016-03-27 05:03:44+02:00
vc2enc: fix segfault Fixes trac bug #5353 Uninitialized memory for the initial quantization index Signed-off-by: Rostislav Pehlivanov <[email protected]>
500dc20deede02f25c395351743aeb69f618fd46
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/500dc20deede02f25c395351743aeb69f618fd46
2016-03-21 11:01:01+00:00
vc2enc: do not allocate packet until exact frame size is known This commit solves most of the crashes and issues with the encoder and the bitrate setting. Now the encoder will always allocate the absolute lowest amount of memory regardless of what the bitrate has been set to. Therefore if a user inputs a very low bitrate the encoder will use the maximum possible quantization (basically zero out all coefficients), allocate a packet and encode it. There is no coupling between the bitrate and the allocation size and so no crashes because the buffer isn't large enough. The maximum quantizer was raised to the size of the table now to both keep the overshoot at ridiculous bitrates low and to improve quality with higher bit depths (since the coefficients grow larger per transform quantizing them to the same relative level requires larger quantization indices). Since the quantization index start follows the previous quantization index for that slice, the quantization step was reduced to a static 1 to improve performance. Previously with quant/5 the step was usually set to 0 upon start (and was later clipped to 1), that isn't a big change. As the step size increases so does the amount of bits leftover and so the redistribution algorithm has to iterate more and thus waste more time. Signed-off-by: Rostislav Pehlivanov <[email protected]>
b88be742fac7a77a8095e8155ba8790db4b77568
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b88be742fac7a77a8095e8155ba8790db4b77568
2016-03-04 22:40:58+00:00
mmaldec: limit internal buffering This uses a new MMAL feature, which limits the number of extra frames that can be buffered within the decoder. VIDEO_MAX_NUM_CALLBACKS can be defined as positive or negative number. Positive numbers are absolute, and can lead to deadlocks if the user underestimates the number of required buffers. Negative numbers specify the number of extra buffers, e.g. -1 means no extra buffer, (-1-N) means N extra buffers. Set a gratuitous default of -11 (N=10). This is much lower than the firmware default, which appears to be 96. This is backwards compatible, but needs a symbol only present in newer firmware headers. (It's an enum item, so it requires a check in configure.)
14a90c9ef09a4b046500dceab5ca1875e330a376
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/14a90c9ef09a4b046500dceab5ca1875e330a376
2016-01-28 17:24:53+01:00
libavcodec/util: Fix timebase overflow check It could accidentally divide by zero if num was zero. Signed-off-by: Derek Buitenhuis <[email protected]>
265ed6732fbde8a4082b2ba71fe3cd623f649bab
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/265ed6732fbde8a4082b2ba71fe3cd623f649bab
2016-01-27 21:12:04+00:00
avcodec/mjpegdec: Check for end for both bytes in unescaping Fixes assertion failure Fixes: c40c779601b77dc6e19aaea0b04b9751/signal_sigabrt_7ffff6ae7cb7_5769_b94f6ec70caecb2d3d76b4771b109ac1.avi Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
509c9e74e548139285f30ed8dcc9baf1d64359fa
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/509c9e74e548139285f30ed8dcc9baf1d64359fa
2016-01-21 23:47:29+01:00
diracdec: add support for 12 bit videos The DSP lacked a function needed to convert signed to unsigned. This was ignored when originally adding support and templating for bit depths greater than 8. The 10 bit function was used for 12 bit pictures and resulted in an improper conversion. Signed-off-by: Rostislav Pehlivanov <[email protected]>
8248b51e0b94f0151b6a2057ee639d6e0db29f5f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8248b51e0b94f0151b6a2057ee639d6e0db29f5f
2016-01-21 14:48:32+00:00
avcodec/wmaenc: Check ff_wma_init() for failure Fixes null pointer dereference Fixes: c4faf8280ba366bf00a79d425f2910a8/signal_sigsegv_1f96477_5177_1448ba7e4125faceb966f44ceb69abfa.qcp Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
19e456d48c90a1e3ceeb9e6241383384cc73dfdf
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/19e456d48c90a1e3ceeb9e6241383384cc73dfdf
2016-01-21 02:39:09+01:00
ffmdec: change type of len to ptrdiff_t It is used to store the difference between pointers, so ptrdiff_t is the correct type. This prevents potential overflows. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
f6e1c96730ebbcebbd0341329d51d3d3a36b4fa1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f6e1c96730ebbcebbd0341329d51d3d3a36b4fa1
2016-01-11 23:14:52+01:00
parser: add av_assert1 to make sure the codec matches Otherwise this can have some surprising effects (crashes), so let's better not allow it. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
fa74cdc60d19798c951dcc242ca7273e6483f2b3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fa74cdc60d19798c951dcc242ca7273e6483f2b3
2016-01-05 22:30:32+01:00
avfilter/avf_showfreqs: fix possible null pointer dereference Signed-off-by: Paul B Mahol <[email protected]>
b7b4d99a1837775afd43bef18954680ecfa683a4
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b7b4d99a1837775afd43bef18954680ecfa683a4
2016-01-08 14:58:43+01:00
x86: use emms after ff_int32_to_float_fmul_scalar_sse Intel's Instruction Set Reference (as of September 2015) clearly states that cvtpi2ps switches to MMX state. Actual CPUs do not switch if the source is a memory location. The Instruction Set Reference from 1999 (Order Number 243191) describes this behaviour but all later versions I've seen have make no distinction whether MMX registers or memory is used as source. The documentation for the matching SSE2 instruction to convert to double (cvtpi2pd) was fixed (see the valgrind bug https://bugs.kde.org/show_bug.cgi?id=210264). It will take time to get a clarification and fixes in place. In the meantime it makes sense to change ff_int32_to_float_fmul_scalar_sse to be correct according to the documentation. The vast majority of users will have SSE2 so a change to the SSE version has little effect. Fixes fate-checkasm on x86 valgrind targets. Valgrind 'bug' reported as https://bugs.kde.org/show_bug.cgi?id=357059
8563f9887194b07c972c3475d6b51592d77f73f7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8563f9887194b07c972c3475d6b51592d77f73f7
2015-12-30 13:37:57+01:00
golomb: always check for invalid UE golomb codes in get_ue_golomb Also correct the check to reject log < 7, because UPDATE_CACHE only guarantees 25 meaningful bits. This fixes undefined behavior: runtime error: shift exponent is negative Testing with START/STOP timers in get_ue_golomb, one for the first branch (A) and one for the second (B), shows that there is practically no slowdown, e.g. for the cavs decoder: With the check in the B branch: 629 decicycles in get_ue_golomb B, 4194260 runs, 44 skips 433 decicycles in get_ue_golomb A,268434102 runs, 1354 skips Without the check: 624 decicycles in get_ue_golomb B, 4194273 runs, 31 skips 433 decicycles in get_ue_golomb A,268434203 runs, 1253 skips Since the B branch is executed far less often than the A branch, this change is negligible, even more so for the h264 decoder, where the ratio B/A is a lot smaller. Fixes: mozilla bug 1230239 Fixes: fbeb8b2c7c996e9b91c6b1af319d7ebc/asan_heap-oob_195450f_2743_e8856ece4579ea486670be2b236099a0.bit Found-by: Tyson Smith Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
22e960ad478e568f4094971a58c6ad8f549c0180
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/22e960ad478e568f4094971a58c6ad8f549c0180
2015-12-14 20:51:39+01:00
r3d: fix an invalid read introduced in 6bf4c1d
5bc223b15d064e328ff90b0241fa1191f1d2786d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5bc223b15d064e328ff90b0241fa1191f1d2786d
2015-12-14 12:12:42+01:00
dds: disable palette flag for compressed dds Having both is not valid and can cause a NULL pointer dereference of frame->data[1] later. Reviewed-by: Vittorio Giovara <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
603ebab8d7b789cd3cb6c7ca645a7badb5b950b4
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/603ebab8d7b789cd3cb6c7ca645a7badb5b950b4
2015-11-14 21:52:11+01:00
vp9: initial attempt at a idct_idct_4x4 12bpp x86 simd (sse2) impl. The trouble with this function is that intermediates overflow 31+sign bits, so I've added some helpers (that will also be used in 10/12bpp 8x8, 16x16 and 32x32) to make that easier, basically emulating a half- assed pmaddqd using 2xpmaddwd. It's currently sse2-only, if anyone sees potential in adding ssse3, I'd love to hear it.
235e76aeb877bd1b23c12e74588e86752e3dfbe7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/235e76aeb877bd1b23c12e74588e86752e3dfbe7
2015-10-13 11:05:58-04:00
x86: simple_idct10_template: fix overflow in pass When the input of a pass has 15 or 16 bits of precision (in particular the column pass), the addition of a bias to W4 may lead to overflows in the input to pmaddwd. This requires postponing the adding of the bias to after the first butterfly. To do so, the fact that m15, unused although zeroed, is exploited. In case the pass is safe, an address can be directly used, and the number of xmm regs can be decreased. Otherwise, the 32bits bias is loaded into it. Signed-off-by: Michael Niedermayer <[email protected]>
e652f69b354bc6b5819012979985794cfd2805c9
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e652f69b354bc6b5819012979985794cfd2805c9
2015-10-13 12:51:10+02:00
avutil/mathematics: make av_gcd more robust This ensures that no undefined behavior is invoked, while retaining identical return values in all cases and at no loss of performance (identical asm on clang and gcc). Essentially, this patch exchanges undefined behavior with implementation defined behavior, a strict improvement. Rationale: 1. The ideal solution is to have the return type a uint64_t. This unfortunately requires an API change. 2. The only pathological behavior happens if both arguments are INT64_MIN, to the best of my knowledge. In such a case, the implementation defined behavior is invoked in the sense that UINT64_MAX is interpreted as INT64_MIN, which any reasonable implementation will do. In any case, any usage where both arguments are INT64_MIN is a fuzzer anyway. 3. Alternatives of checking, etc require branching and lose performance for no concrete gain - no client cares about av_gcd's actual value when both args are INT64_MIN. Even if it did, on sane platforms (e.g all the ones FFmpeg cares about), it produces a correct gcd, namely INT64_MIN. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Ganesh Ajjanagadde <[email protected]>
b7fb7c4542af63fea433a5417e4efe2d8c4422f6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b7fb7c4542af63fea433a5417e4efe2d8c4422f6
2015-10-29 19:13:55-04:00
h263: Drop uninitialized variable use from log message
4628443ca3534060888dd0015b229337eac13fd2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4628443ca3534060888dd0015b229337eac13fd2
2015-10-04 13:07:12+02:00
avcodec/vp8: Do not use num_coeff_partitions in thread/buffer setup The variable is not a constant and can lead to race conditions Fixes: repro.webm (not reproducable with FFmpeg alone) Found-by: Dale Curtis <[email protected]> Tested-by: Dale Curtis <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
dabea74d0e82ea80cd344f630497cafcb3ef872c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/dabea74d0e82ea80cd344f630497cafcb3ef872c
2015-10-01 00:58:46+02:00
mmaldec: refactor to have more context per MMAL input buffer The next commit needs 1 bit of additional information per MMAL buffer sent to the MMAL input port. This information will be needed when the buffer is recycled (i.e. returned by the input port's callback). Normally, we could use MMAL_BUFFER_HEADER_FLAG_USER0, but that is unexpectedly not preserved. Do this by storing a pointer to FFBufferEntry in the MMAL buffer's user data, instead of an AVBufferRef. This also changes the lifetime of FFBufferEntry. Signed-off-by: Luca Barbato <[email protected]>
65db4899fa8790049bec3af16ecdb75dd81051fd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/65db4899fa8790049bec3af16ecdb75dd81051fd
2015-10-04 19:34:04+02:00
qsvenc: mark the encoders as INIT_CLEANUP Should fix some leaks on init failure.
5d2daebf3cc8de4cee1973db6a2229beaad3b7cd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5d2daebf3cc8de4cee1973db6a2229beaad3b7cd
2015-09-28 15:43:04+02:00
AAC encoder: fix OOB access in search_for_pns Fix out of bounds access caused by wrongful usage of swb_offset constants when computing scalefactor positions.
0f98fd30e2d3c7254a1c56ce42a9a8bf0f6dc0eb
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0f98fd30e2d3c7254a1c56ce42a9a8bf0f6dc0eb
2015-09-26 04:49:16-03:00
avfilter/avf_showfreqs: Fix "may be used uninitialized in this function" warning Signed-off-by: Michael Niedermayer <[email protected]>
0ada8ec1a50c0ec157988f0a166adf977b482d37
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0ada8ec1a50c0ec157988f0a166adf977b482d37
2015-09-05 15:34:35+02:00
fate: adjust AAC encoder TNS test fuzziness Tests fails on some ARM builds but it's close enough so it's okay. NEON, half-precision floats, rounding errors, who knows. Signed-off-by: Rostislav Pehlivanov <[email protected]>
8323d9b8afbc0755120cbded0e0259b2ba23977c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8323d9b8afbc0755120cbded0e0259b2ba23977c
2015-08-29 09:26:05+01:00
avfilter/vsrc_testsrc: smpte(hd)bars: fix uninitialized last rows and columns of chroma planes For cases width and/or height is not multiple of chroma subsamplings.
7a7ca3cc2f43e7a7b61fdad8200b365ff0977bd2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7a7ca3cc2f43e7a7b61fdad8200b365ff0977bd2
2015-08-10 11:29:39+02:00
ffmpeg: Check av_parser_change() for failure No testcase known Signed-off-by: Michael Niedermayer <[email protected]>
ac0ba6f233698f02ebb75b03242e94333dbe13d4
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ac0ba6f233698f02ebb75b03242e94333dbe13d4
2015-08-21 03:37:32+02:00
avcodec/pthread_slice: Check for malloc failure Found-by: CSA Signed-off-by: Michael Niedermayer <[email protected]>
72555f4a382744dd7f02edcb7fe6f8ed91f4dc3c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/72555f4a382744dd7f02edcb7fe6f8ed91f4dc3c
2014-07-31 12:56:21+02:00