commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
avcodec/lpc: signed integer overflow in compute_lpc_coefs() (aacdec_fixed) Fixes: runtime error: signed integer overflow: -1575818955 + -915383657 cannot be represented in type 'int' Fixes: 2224/clusterfuzz-testcase-minimized-6208559949807616 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
e95fcfe8fb28fdfdaecec465c60aad79bc340a3d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e95fcfe8fb28fdfdaecec465c60aad79bc340a3d
2017-06-21 02:25:23+02:00
avcodec/iff: Cleanup on init failure Fixes: memleak Fixes: 2272/clusterfuzz-testcase-minimized-5059103858622464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
9a6503f496ae496dd6b1f54fd5752d48435361b0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9a6503f496ae496dd6b1f54fd5752d48435361b0
2017-06-18 14:05:57+02:00
avcodec/hevcdec: Fix signed integer overflow in decode_lt_rps() Fixes: runtime error: signed integer overflow: 2147483647 + 6 cannot be represented in type 'int' Fixes: 2263/clusterfuzz-testcase-minimized-4800359627227136 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
1edbf5e20c75f06d6987bc823e63aa4e649ccddd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1edbf5e20c75f06d6987bc823e63aa4e649ccddd
2017-06-17 00:34:48+02:00
avfilter/af_headphone: fix possible memory leaks on failure Signed-off-by: Paul B Mahol <[email protected]>
9b667f609c509e84ae6ef496edcfb6c8b83c4a38
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9b667f609c509e84ae6ef496edcfb6c8b83c4a38
2017-06-15 11:19:12+02:00
avcodec/tiff: Avoid loosing allocated geotag values Fixes memleak Fixes: 2076/clusterfuzz-testcase-minimized-6542640243802112 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
d7cbeab4c1381f95ed0ebf85d7950bee96f66164
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d7cbeab4c1381f95ed0ebf85d7950bee96f66164
2017-06-05 22:43:23+02:00
avformat/hls: Check local file extensions This reduces the attack surface of local file-system information leaking. It prevents the existing exploit leading to an information leak. As well as similar hypothetical attacks. Leaks of information from files and symlinks ending in common multimedia extensions are still possible. But files with sensitive information like private keys and passwords generally do not use common multimedia filename extensions. It does not stop leaks via remote addresses in the LAN. The existing exploit depends on a specific decoder as well. It does appear though that the exploit should be possible with any decoder. The problem is that as long as sensitive information gets into the decoder, the output of the decoder becomes sensitive as well. The only obvious solution is to prevent access to sensitive information. Or to disable hls or possibly some of its feature. More complex solutions like checking the path to limit access to only subdirectories of the hls path may work as an alternative. But such solutions are fragile and tricky to implement portably and would not stop every possible attack nor would they work with all valid hls files. Developers have expressed their dislike / objected to disabling hls by default as well as disabling hls with local files. There also where objections against restricting remote url file extensions. This here is a less robust but also lower inconvenience solution. It can be applied stand alone or together with other solutions. limiting the check to local files was suggested by nevcairiel Found-by: Emil Lerner and Pavel Cheremushkin Reported-by: Thierry Foucu <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
caf7d6178a4d5f24c915da48410a9790b21703aa
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/caf7d6178a4d5f24c915da48410a9790b21703aa
2017-06-05 03:03:11+02:00
checkasm: add a checkasm_checked_call function that doesn't issue emms Meant for DSP functions returning a float or double, as they'd fail if emms is called after every run on x86_32. Signed-off-by: James Almer <[email protected]>
37388b119cf814c2af349e7acba32e33ea30c343
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/37388b119cf814c2af349e7acba32e33ea30c343
2017-06-14 19:18:56-03:00
avcodec/gdv: Fix undefined shift Fixes: runtime error: left shift of 255 by 24 places cannot be represented in type 'int' Fixes: 2249/clusterfuzz-testcase-minimized-5388542379294720 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
9b65dbf7349aace16f7ca65f7cef1a368e2d83d9
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9b65dbf7349aace16f7ca65f7cef1a368e2d83d9
2017-06-16 23:32:28+02:00
avcodec/sbrdsp_fixed: Fix assertion failure in sbr_sum_square_c() This also increases the range of input values supported as well as decreasing the operation dependencies in the main loop, improving speed on modern CPUs. Fixes part of: 2045/clusterfuzz-testcase-minimized-6751255865065472 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
b315a3cf42a15358ab38279723f3c93406a66f6a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b315a3cf42a15358ab38279723f3c93406a66f6a
2017-06-04 23:41:35+02:00
avcodec/mlpdec: Check quant_step_size against huff_lsbs This reorders the operations so as to avoid computations with the above arguments before they have been initialized. Fixes part of 1708/clusterfuzz-testcase-minimized-5035111957397504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
361e0310d95bf2a0377f168518d1135ae15ca3f8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/361e0310d95bf2a0377f168518d1135ae15ca3f8
2017-06-03 23:30:31+02:00
avcodec/wnv1: More strict buffer size check This requires at least 25% of a picture to allocate and decode it Fixes: Timeout Fixes: 1845/clusterfuzz-testcase-minimized-5075974343360512 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
7f50c25124a015a539823077bb302ff0c7ce8963
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7f50c25124a015a539823077bb302ff0c7ce8963
2017-05-28 03:20:09+02:00
avcodec/rv34: Fix runtime error: signed integer overflow: 768 * 4126720 cannot be represented in type 'int' Fixes: 1655/clusterfuzz-testcase-minimized-5587079276789760 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
4bd869eb7c8416942f12b61db6439d2bfc474456
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4bd869eb7c8416942f12b61db6439d2bfc474456
2017-05-17 16:33:52+02:00
avcodec/flicvideo: Check frame_size before decrementing Fixes: runtime error: signed integer overflow: -2147483627 - 22 cannot be represented in type 'int' Fixes: 1637/clusterfuzz-testcase-minimized-5376582493405184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
355e27e24dc88d6ba8f27501a34925d9d937a399
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/355e27e24dc88d6ba8f27501a34925d9d937a399
2017-05-17 01:13:46+02:00
lavc/ffjni: fix local reference leak Reviewed-by: Clément Bœsch <[email protected]>
2f43897f657974d8f94d0d075eb67dac1147ddde
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2f43897f657974d8f94d0d075eb67dac1147ddde
2017-05-11 16:28:59+02:00
avcodec/pixlet: Fix runtime error: signed integer overflow: 436207616 * -5160230545260541 cannot be represented in type 'long' Fixes: 1462/clusterfuzz-testcase-minimized-6558894463647744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
60765cc42e3eb4a1193ef352a89946113a6e5802
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/60765cc42e3eb4a1193ef352a89946113a6e5802
2017-05-11 00:02:41+02:00
avcodec/diracdec: Fix off by 1 error in quant check Fixes: out of array read Fixes: 1781/clusterfuzz-testcase-minimized-4617176877105152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
b946bd8ef2c7aeee09469a4901182a44f9b67189
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b946bd8ef2c7aeee09469a4901182a44f9b67189
2017-05-25 19:32:39+02:00
avcodec/flacdec: Return error code instead of 0 for failures Fixes: infinite loop Fixes: 1418/clusterfuzz-testcase-minimized-5934472438480896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
3f5a68533decdfb4757207e8d7b5af06e1dcd197
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/3f5a68533decdfb4757207e8d7b5af06e1dcd197
2017-05-09 16:50:18+02:00
avcodec/cavsdec: Fix undefined behavior from integer overflow Fixes: 1335/clusterfuzz-testcase-minimized-5566961566089216 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
a0e5f7f363555d2befafb1c9e1579dbe0a2fbca7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a0e5f7f363555d2befafb1c9e1579dbe0a2fbca7
2017-05-05 04:25:07+02:00
lavc/jpeg2000dec: Fix jp2 inner atom size used for overread checks.
a75ef1506a62ff21f3e282d76978b28ffc305c64
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a75ef1506a62ff21f3e282d76978b28ffc305c64
2017-05-03 03:45:33+02:00
utvideodec: Prevent possible signed overflow Doing slice_end - slice_start is unsafe and can lead to undefined behavior until slice_end has been properly sanitized. Reviewed-by: Ronald S. Bultje <[email protected]> Signed-off-by: Ganesh Ajjanagadde <[email protected]> Signed-off-by: Luca Barbato <[email protected]>
1fe858136b315796dd5349f3b4448a29d1bd6fa1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1fe858136b315796dd5349f3b4448a29d1bd6fa1
2017-04-13 13:37:10+02:00
avformat/oggparseogm: Check ff_alloc_extradata() for failure Signed-off-by: Michael Niedermayer <[email protected]>
9eff4b0d2b5013e1ede86cf1a152dce164217d52
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9eff4b0d2b5013e1ede86cf1a152dce164217d52
2017-04-11 21:28:26+02:00
pthread_frame: fix uninitialized variable read Could lead to random behavior. This possibly happened due to commit 32a5b631267. This should/could probably be simplified, but for no apply a minimal fix to quell the errors. Tested-by: Michael Niedermayer <[email protected]> Reviewed-by: Michael Niedermayer <[email protected]>
d7896e9b4228e5b7ffc7ef0d0f1cf145f518c819
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d7896e9b4228e5b7ffc7ef0d0f1cf145f518c819
2017-03-27 13:21:20+02:00
lavc/xface: Reorder conditions to silence a gcc warning. libavcodec/xface.c:318:27: warning: assuming signed overflow does not occur when assuming that (X - c) > X is always false [-Wstrict-overflow]
66c1c9b2774968dc26017269ac175b356592f878
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/66c1c9b2774968dc26017269ac175b356592f878
2017-03-24 19:51:36+01:00
avcodec/h264idct_template: fix multiple runtime error: signed integer overflow Fixes: 857/clusterfuzz-testcase-5319093760557056 Benchmark changes from 335->333 (so if its not a random fluctuation then it would be faster) Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
2898bc522da6adebda5cbbd9036defe22e3b9bcf
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2898bc522da6adebda5cbbd9036defe22e3b9bcf
2017-03-16 16:16:05+01:00
avcodec/xpmdec: there are XPM files with dos line endings Signed-off-by: Paul B Mahol <[email protected]>
fbfbd97be25c4da0562ef61e2f27192d1ec4d276
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fbfbd97be25c4da0562ef61e2f27192d1ec4d276
2017-03-13 20:40:41+01:00
lavc: remove libschroedinger encoding and decoding wrappers The library has stopped being developed and Debian has removed it from its repositories citing security issues. The native Dirac decoder supports everything the library has and basic encoding support is still provided via the native vc2 (Dirac Pro, intra only version of Dirac) encoder. Hence, there's no reason to still support linking to the library and potentially leading users into security issues.
220b24c7c97dc033ceab1510549f66d0e7b52ef1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/220b24c7c97dc033ceab1510549f66d0e7b52ef1
2017-05-29 20:15:58+01:00
avcodec/g726: Fix runtime error: left shift of negative value -2 Fixes: 1393/clusterfuzz-testcase-minimized-5948366791901184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
c04aa148824f4fb7f4b70830ad3ca7a6cba8ab79
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c04aa148824f4fb7f4b70830ad3ca7a6cba8ab79
2017-05-07 19:32:33+02:00
avcodec/h264_mvpred: Fix runtime error: left shift of negative value -1 Fixes: 734/clusterfuzz-testcase-4821293192970240 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
222c9f031de3315af62be6d7a99c71105e516088
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/222c9f031de3315af62be6d7a99c71105e516088
2017-03-09 23:28:10+01:00
avcodec/wavpack: Fix runtime error: left shift of negative value -2 Fixes: 723/clusterfuzz-testcase-6471394663596032 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
ba150051322c02e24c004bd5309468886e1e5ab6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ba150051322c02e24c004bd5309468886e1e5ab6
2017-03-05 12:03:15+01:00
avcodec/dcadsp: Fix runtime error: signed integer overflow: 394625024 * 8 cannot be represented in type 'int' Fixes: 643/clusterfuzz-testcase-5209078743695360 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
92188c8f57bf02a564c17f7994c8434a2f3893fe
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/92188c8f57bf02a564c17f7994c8434a2f3893fe
2017-02-22 02:42:48+01:00
opus_pvq: fix uninitialized variable usage Fixes CID1400586 Signed-off-by: Rostislav Pehlivanov <[email protected]>
1b90e2414df070d4ea7d12f300c4a950d3ecc975
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1b90e2414df070d4ea7d12f300c4a950d3ecc975
2017-02-15 21:11:41+00:00
avfilter/vf_palettegen: Fix leak and simplify code Fixes CID1270818 Signed-off-by: Michael Niedermayer <[email protected]>
e740e9c79807b9d0174c037a6b3062b7057d436b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e740e9c79807b9d0174c037a6b3062b7057d436b
2017-01-21 22:40:14+01:00
h264dec: be more explicit in handling container cropping The current condition can trigger in cases where it shouldn't, with unexpected results. Make sure that: - container cropping is really based on the original dimensions from the caller - those dimenions are discarded on size change The code is still quite hacky and eventually should be deprecated and removed, with the decision about which cropping is used delegated to the caller.
4fded0480f20f4d7ca5e776a85574de34dfead14
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4fded0480f20f4d7ca5e776a85574de34dfead14
2017-01-12 16:28:05+01:00
avformat/hlsenc: fix Explicit null dereferenced in hlsenc CID: 1398228 Passing null pointer dirname to strlen, which dereferences it. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Steven Liu <[email protected]>
57ae94a3c0fced20464d9ae351efc977d964be38
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/57ae94a3c0fced20464d9ae351efc977d964be38
2017-01-06 06:29:12+08:00
avcodec/mjpegdec: Check for rgb before flipping Fixes assertion failure due to unsupported case Fixes: 356/fuzz-1-ffmpeg_VIDEO_AV_CODEC_ID_MJPEG_fuzzer Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
25d9643f1172ae6a210c671195ba3135895abaf3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/25d9643f1172ae6a210c671195ba3135895abaf3
2016-12-31 03:21:05+01:00
rtmpproto: Lengthen the filename buffer when receiving streams Some applications such as Adobe FME append lots of parameters here, making it easily overflow the current limit. Signed-off-by: Martin Storsjö <[email protected]>
d6ded94036e43a04889f4ff2813a7f7dd60b82fe
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d6ded94036e43a04889f4ff2813a7f7dd60b82fe
2016-10-14 23:11:12+03:00
wmavoice: move overflow handling to common code.
7b27dd5c16de785297ce4de4b88afa0b6685f61d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7b27dd5c16de785297ce4de4b88afa0b6685f61d
2016-12-27 10:02:34-05:00
ffmpeg: Check avcodec_parameters_to_context() for failure Fixes CID1396241 Signed-off-by: Michael Niedermayer <[email protected]>
11103a493de5f07a61c6f4f1c37a290fdc8942cb
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/11103a493de5f07a61c6f4f1c37a290fdc8942cb
2016-12-26 20:45:23+01:00
mpeg12dec: avoid signed overflow in bitrate calculation CC: [email protected] Bug-Id: 981 Found-By: Agostino Sarubbo
e807491fc6a336e4becc0cbc981274a8fde18aba
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e807491fc6a336e4becc0cbc981274a8fde18aba
2016-12-19 08:15:42+01:00
tiff: fix overflows when calling av_reduce The arguments of av_reduce are signed, so the cast to uint64_t is misleading. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
ed412d285078c167a3a5326bcb16b2169b488943
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ed412d285078c167a3a5326bcb16b2169b488943
2016-12-15 01:30:57+01:00
cafdec: prevent overflow during bit rate calculation Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
baba9c6aef88727bb0182631dc67744d36cadea4
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/baba9c6aef88727bb0182631dc67744d36cadea4
2016-12-15 01:25:43+01:00
avformat/matroskaenc: Regression fix for invalid MKV headers The following three commits created a regression by writing initially invalid mkv headers: 650e17d88b63b5aca6e0a43483e89e64b0f7d2dd avformat/matroskaenc: write a CRC32 element on Tags 3bcadf822711720ff0f8d14db71ae47cdf97e652 avformat/matroskaenc: write a CRC32 element on Info ee888cfbe777cd2916a3548c750e433ab8f8e6a5 avformat/matroskaenc: postpone writing the Tracks master Symptoms: - You can no longer playback a file that is still processed by ffmpeg, e.g. VLC fails playback - You can no longer stream a file to a client while if is still being processed - Various diagnosing tools show header errors or incomplete headers (e.g. ffprobe, mediainfo, mkvalidator) Note: The symptoms do not apply to completed files or ffmpeg runs that were interrupted with 'q' Cause: The mentioned commits made changes in a way that some header elements are only partially written in mkv_write_header, leaving the header in an invalid state. Only in mkv_write_trailer, these elements are finished correctly, but that does only occur at the end of the process. Regression: Before these commits were applied, mkv headers have always been valid, even before completion of ffmpeg. This has worked reliably over many versions of ffmpeg, to it was an obvious regression. Bugtracker: This issue has been recorded as #5977 which is resolved by this patch Patch: The patch adds a new function 'end_ebml_master_crc32_preliminary' that preliminarily finishes the ebml element without destroying the buffer. The buffer can be used to update the ebml element later during mkv_write_trailer. But most important: mkv_write_header finishes with a valid mkv header again. Signed-off-by: James Almer <[email protected]>
20e8be0c20c7b51964fa4d317073bd36b983eb55
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/20e8be0c20c7b51964fa4d317073bd36b983eb55
2017-01-07 11:20:36-03:00
swscale: save ebx register when it is not available Configure checks if the ebx register can be used for asm and it has to be saved if and only if this is not the case. Without this the build fails when configuring with --toolchain=hardened --disable-pic on i386 using gcc 4.8: error: PIC register clobbered by '%ebx' in 'asm' In that case gcc 4.8 reserves the ebx register for the GOT needed for PIE, so it can't be used in asm directly. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
319438e2f206036ee0cddf401dd50f3b2a3ae117
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/319438e2f206036ee0cddf401dd50f3b2a3ae117
2016-12-21 01:26:10+01:00
avformat/utils: check for overflow before reallocating side data This makes av_stream_add_side_data() consistent with av_packet_add_side_data(). Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: James Almer <[email protected]>
0ffea3565700c9b3093ead285f729bb319a2163e
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0ffea3565700c9b3093ead285f729bb319a2163e
2016-11-19 20:11:50-03:00
mpegts: prevent division by zero Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
1bbb18fe82fc77a10d45fa53bd2738d2c54de6c6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1bbb18fe82fc77a10d45fa53bd2738d2c54de6c6
2016-11-08 22:27:11+01:00
arm: vp9: Add NEON optimizations of VP9 MC functions This work is sponsored by, and copyright, Google. The filter coefficients are signed values, where the product of the multiplication with one individual filter coefficient doesn't overflow a 16 bit signed value (the largest filter coefficient is 127). But when the products are accumulated, the resulting sum can overflow the 16 bit signed range. Instead of accumulating in 32 bit, we accumulate the largest product (either index 3 or 4) last with a saturated addition. (The VP8 MC asm does something similar, but slightly simpler, by accumulating each half of the filter separately. In the VP9 MC filters, each half of the filter can also overflow though, so the largest component has to be handled individually.) Examples of relative speedup compared to the C version, from checkasm: Cortex A7 A8 A9 A53 vp9_avg4_neon: 1.71 1.15 1.42 1.49 vp9_avg8_neon: 2.51 3.63 3.14 2.58 vp9_avg16_neon: 2.95 6.76 3.01 2.84 vp9_avg32_neon: 3.29 6.64 2.85 3.00 vp9_avg64_neon: 3.47 6.67 3.14 2.80 vp9_avg_8tap_smooth_4h_neon: 3.22 4.73 2.76 4.67 vp9_avg_8tap_smooth_4hv_neon: 3.67 4.76 3.28 4.71 vp9_avg_8tap_smooth_4v_neon: 5.52 7.60 4.60 6.31 vp9_avg_8tap_smooth_8h_neon: 6.22 9.04 5.12 9.32 vp9_avg_8tap_smooth_8hv_neon: 6.38 8.21 5.72 8.17 vp9_avg_8tap_smooth_8v_neon: 9.22 12.66 8.15 11.10 vp9_avg_8tap_smooth_64h_neon: 7.02 10.23 5.54 11.58 vp9_avg_8tap_smooth_64hv_neon: 6.76 9.46 5.93 9.40 vp9_avg_8tap_smooth_64v_neon: 10.76 14.13 9.46 13.37 vp9_put4_neon: 1.11 1.47 1.00 1.21 vp9_put8_neon: 1.23 2.17 1.94 1.48 vp9_put16_neon: 1.63 4.02 1.73 1.97 vp9_put32_neon: 1.56 4.92 2.00 1.96 vp9_put64_neon: 2.10 5.28 2.03 2.35 vp9_put_8tap_smooth_4h_neon: 3.11 4.35 2.63 4.35 vp9_put_8tap_smooth_4hv_neon: 3.67 4.69 3.25 4.71 vp9_put_8tap_smooth_4v_neon: 5.45 7.27 4.49 6.52 vp9_put_8tap_smooth_8h_neon: 5.97 8.18 4.81 8.56 vp9_put_8tap_smooth_8hv_neon: 6.39 7.90 5.64 8.15 vp9_put_8tap_smooth_8v_neon: 9.03 11.84 8.07 11.51 vp9_put_8tap_smooth_64h_neon: 6.78 9.48 4.88 10.89 vp9_put_8tap_smooth_64hv_neon: 6.99 8.87 5.94 9.56 vp9_put_8tap_smooth_64v_neon: 10.69 13.30 9.43 14.34 For the larger 8tap filters, the speedup vs C code is around 5-14x. This is significantly faster than libvpx's implementation of the same functions, at least when comparing the put_8tap_smooth_64 functions (compared to vpx_convolve8_horiz_neon and vpx_convolve8_vert_neon from libvpx). Absolute runtimes from checkasm: Cortex A7 A8 A9 A53 vp9_put_8tap_smooth_64h_neon: 20150.3 14489.4 19733.6 10863.7 libvpx vpx_convolve8_horiz_neon: 52623.3 19736.4 21907.7 25027.7 vp9_put_8tap_smooth_64v_neon: 14455.0 12303.9 13746.4 9628.9 libvpx vpx_convolve8_vert_neon: 42090.0 17706.2 17659.9 16941.2 Thus, on the A9, the horizontal filter is only marginally faster than libvpx, while our version is significantly faster on the other cores, and the vertical filter is significantly faster on all cores. The difference is especially large on the A7. The libvpx implementation does the accumulation in 32 bit, which probably explains most of the differences. Signed-off-by: Martin Storsjö <[email protected]>
ffbd1d2b0002576ef0d976a41ff959c635373fdc
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ffbd1d2b0002576ef0d976a41ff959c635373fdc
2016-11-03 09:35:38+02:00
vc1: check that slices have a positive height Fixes possible invalid reads. CC: [email protected] Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
33f10546ec012ad4e1054b57317885cded7e953e
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/33f10546ec012ad4e1054b57317885cded7e953e
2016-08-18 17:06:46+02:00
pcx: use the bytestream2 API for reading from input Fixes possible invalid reads. CC: [email protected] Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
09b23786b3986502ee88d4907356979127169bdd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/09b23786b3986502ee88d4907356979127169bdd
2016-08-18 17:06:46+02:00
avformat/oggdec: Fix integer overflow with invalid pts If negative pts are possible for some codecs in ogg then the code needs to be changed to use signed values. Found-by: Thomas Guilbert <[email protected]> Fixes: clusterfuzz_usan-2016-08-02 Signed-off-by: Michael Niedermayer <[email protected]>
c5cc3b08e56fc95665977544486bd9f06e4b7a72
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c5cc3b08e56fc95665977544486bd9f06e4b7a72
2016-08-03 16:09:03+02:00
vp9mc/x86: sse2 MC assembly. Also a slight change to the ssse3 code, which prevents a theoretical overflow in the sharp filter. Signed-off-by: Anton Khirnov <[email protected]>
9790b44a89d191a07a9d8b361fb4d18ea15f51a1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9790b44a89d191a07a9d8b361fb4d18ea15f51a1
2016-08-03 11:04:51+02:00
libavformat/matroskadec: fix unsigned overflow to improve seeking When seeking a file where codec delay is greater than 0, the timecode can become negative after offsetting by the codec delay. Failing to cast to a signed int64 will cause the check against skip_to_timecode to evaluate true for these negative values. This breaks the "skip_to" seek mechanism. Signed-off-by: Michael Niedermayer <[email protected]>
d59820f6fec3fd112436fb7712e4f9d6d768b664
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d59820f6fec3fd112436fb7712e4f9d6d768b664
2016-07-23 10:32:28+02:00
diracdec: rewrite HQ slice decoding Now coefficients are written to a buffer and are then dequantized by the new SIMD dequantization functions. For the lower bands without enough coefficients to fill a register (and hence they overwrite) the C version of the dequantization function is used. The buffer is per-thread and will be realloc'd if anything changes. This prevents regressions and having to limit slice size. Signed-off-by: Rostislav Pehlivanov <[email protected]>
c43485f70765cb488bfdf95dc783bb9b14eb1179
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c43485f70765cb488bfdf95dc783bb9b14eb1179
2016-07-11 23:38:45+01:00
Revert "configure: Enable GCC vectorization on ≥4.9 on x86" This reverts commit cb8646af24bd8e9627cc5e1c62b049a00fe0b07b. This change has brough more issues than benefits, between compilation time failures depending on flags used and code miscompilation causing runtime crashes. See the "[PATCH 2/2] configure: Enable GCC vectorization on ≥4.9" thread in the ffmpeg-devel mailing list for the relevant discussion.
fd6dbc53855fbfc9a782095d0ffe11dd3a98905f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fd6dbc53855fbfc9a782095d0ffe11dd3a98905f
2016-07-09 16:00:06-03:00
tests/api/api-codec-param-test: Do not directly access caps_internal The caps_internal field has moved without major bump and direct access causes crashes, found when testing 3.1 Signed-off-by: Michael Niedermayer <[email protected]>
dfbb5de172b3a0373cbead8a966c41f5ba1ae08b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/dfbb5de172b3a0373cbead8a966c41f5ba1ae08b
2016-06-20 00:08:45+02:00
d3d11va: don't keep the context lock while waiting for a frame also fixes a deadlock found by Денис Кулаков <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
193a42199487b075bb452453ee034a1190a648b1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/193a42199487b075bb452453ee034a1190a648b1
2016-06-17 08:39:41+02:00
avformat/movenc: Fix potential track width/height overflows Signed-off-by: Michael Niedermayer <[email protected]>
dac030d3aa1bdf73267dbf374d5d9387dad740bb
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/dac030d3aa1bdf73267dbf374d5d9387dad740bb
2016-05-29 04:42:04+02:00
avformat/rtpdec_jpeg: fix low contrast image on low quality setting Original mail and my own followup on ffmpeg-user earlier today: I have a device sending out a MJPEG/RTP stream on a low quality setting. Decoding and displaying the video with libavformat results in a washed out, low contrast, greyish image. Playing the same stream with VLC results in proper color representation. Screenshots for comparison: http://zevv.nl/div/libav/shot-ffplay.jpg http://zevv.nl/div/libav/shot-vlc.jpg A pcap capture of a few seconds of video and SDP file for playing the stream are available at http://zevv.nl/div/libav/mjpeg.pcap http://zevv.nl/div/libav/mjpeg.sdp I believe the problem might be in the calculation of the quantization tables in the function create_default_qtables(), the attached patch solves the issue for me. The problem is that the argument 'q' is of the type uint8_t. According to the JPEG standard, if 1 <= q <= 50, the scale factor 'S' should be 5000 / Q. Because the create_default_qtables() reuses the variable 'q' to store the result of this calculation, for small values of q < 19, q wil subsequently overflow and give wrong results in the calculated quantization tables. The patch below uses a new variable 'S' (same name as in RFC2435) with the proper range to store the result of the division. Signed-off-by: Michael Niedermayer <[email protected]>
e3e6a2cff4af9542455d416faec4584d5e823d5d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e3e6a2cff4af9542455d416faec4584d5e823d5d
2016-03-24 15:40:10+01:00
fate: Ignore errors from concatenating report files Some files may be missing for valid reasons, e.g. on compile failure.
cd846b47977485bd4063e77a3324e6b7840567a2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cd846b47977485bd4063e77a3324e6b7840567a2
2016-02-23 11:45:37+01:00
avcodec/mpegvideo_enc: Check for integer overflow in ff_mpv_reallocate_putbitbuffer() Fixes assertion failure Fixes: 6568d187979ce17878b6fe5fbbb89142/signal_sigabrt_7ffff6ae7cb7_7176_564bbc6741bdcf907f5c4e685c9a77a2.mpg Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
b65efbc0f4195421c15d2a6c228d331eec5b31c3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b65efbc0f4195421c15d2a6c228d331eec5b31c3
2016-01-21 15:56:11+01:00
aacenc: mark LTP mode as experimental Too many crashes observed. Can't be helped until the autocorrelation function is massively checked for sanity. Signed-off-by: Rostislav Pehlivanov <[email protected]>
a72b1ea8261f093f0cdeebee9638f3d1b6367f37
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a72b1ea8261f093f0cdeebee9638f3d1b6367f37
2016-01-20 16:49:55+00:00
avcodec/aacenc: Check both channels for finiteness Fixes null pointer dereference Fixes: 10412fc52ecc6eab40ed67f82ca7b372/signal_sigsegv_2618c99_2129_f808373959e46afb165593332799ffbc.aif Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
057549a9ccc9fd32df71678e6abe69e10668186a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/057549a9ccc9fd32df71678e6abe69e10668186a
2016-01-16 18:33:12+01:00
avfilter/af_dynaudnorm: fix possible null pointer dereference Signed-off-by: Paul B Mahol <[email protected]>
70df51112ccc8d281cdb96141f20b3fd8a5b11f8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/70df51112ccc8d281cdb96141f20b3fd8a5b11f8
2016-01-14 14:30:36+01:00
avcodec/ass: check for av_mallocz() failure Signed-off-by: Michael Niedermayer <[email protected]>
05af8608c2dc8ed95e3afa3840308212f3df589e
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/05af8608c2dc8ed95e3afa3840308212f3df589e
2015-12-22 14:41:27+01:00
nutdec: reject negative value_len in read_sm_data If it is negative, it can cause the byte position to move backwards in avio_skip, which in turn makes sm_size negative and thus size larger than the size of the packet buffer, causing invalid writes in avio_read. Also fix potential overflow of avio_tell(bc) + value_len. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
ce10f572c12b0d172c72d31d8c979afce602bf0c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ce10f572c12b0d172c72d31d8c979afce602bf0c
2015-12-19 17:57:56+01:00
sonic: make sure num_taps * channels is not larger than frame_size If that is the case, the loop setting predictor_state in sonic_decode_frame causes out of bounds reads of int_samples, which has only frame_size number of elements. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
9637c2531f7eb040ad1c3cb46cb40a63dfc77b80
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9637c2531f7eb040ad1c3cb46cb40a63dfc77b80
2015-12-17 19:55:09+01:00
avformat/segment: Fix memory leak of cur_entry.filename Solution suggested-by: Hendrik Leppkes <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
93d336fb076a8abe33e37251af5475673e716f6d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/93d336fb076a8abe33e37251af5475673e716f6d
2015-12-12 23:19:22+01:00
lavfi/af_amix: fix memory leak Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning up usage of the formats API, and in particular fixed possible NULL pointer dereferences. This commit addresses the issue of possible resource leaks when some intermediate call fails. Tested with valgrind --leak-check=full --show-leak-kinds=all, and manual simulation of malloc/realloc failures. Fixes: CID 1250334. Signed-off-by: Ganesh Ajjanagadde <[email protected]>
89bbf01978194ee1354bb3feef139a648bc1903b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/89bbf01978194ee1354bb3feef139a648bc1903b
2015-12-09 07:58:19-05:00
avformat/mov: fix memory leak Fixes: CID 1338328. Reviewed-by: Paul B Mahol <[email protected]> Signed-off-by: Ganesh Ajjanagadde <[email protected]>
f0197e1637bbe9d508f54dabb58a9081e8f36ef3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f0197e1637bbe9d508f54dabb58a9081e8f36ef3
2015-11-16 07:41:33-05:00
avcodec/wmaprodec: Check for overread in decode_packet() Fixes assertion failure Fixes: 0256e92df2df7e933b43a2c70e4c8040/signal_sigabrt_7ffff6ae7cc9_1358_999ac18684788221490757582ce9af84.wma Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
7ad698e24e6b9dde57c4e01c145bcddfe9d6e4a3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7ad698e24e6b9dde57c4e01c145bcddfe9d6e4a3
2015-11-15 18:32:22+01:00
avcodec/dnxhddec: Make mb_scan_index a fixed length array Fixes null pointer dereference Fixes: 5c9d1a6f74a12763fc7c9dd7834022b9/signal_sigsegv_11f78d9_1461_ecee3c5e7205457498e79b3ffaf21d0c.mxf Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
cea9eb9520fab9e5ec79d3a2d4dbd03eb71b7fa3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cea9eb9520fab9e5ec79d3a2d4dbd03eb71b7fa3
2015-11-06 00:15:21+01:00
AAC encoder tests: increase fuzz for pred test MIPS needs more fuzz
79f2014f1264aeb9dae3134d3649aba6ca0d4d13
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/79f2014f1264aeb9dae3134d3649aba6ca0d4d13
2015-10-11 18:46:27-03:00
avconv: Do not try to configure filter outputs without streams Prevent a NULL-dereference. CC: [email protected]
8b830ee9a26d47b138f12a82085cdb372f407f1e
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8b830ee9a26d47b138f12a82085cdb372f407f1e
2015-10-07 18:45:50+02:00
avcodec/mips/aaccoder_mips: Disable ff_aac_coder_init_mips() to prevent build failure Signed-off-by: Michael Niedermayer <[email protected]>
97437bd17a8c5d4135b2f3b1b299bd7bb72ce02c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/97437bd17a8c5d4135b2f3b1b299bd7bb72ce02c
2015-10-13 00:01:39+02:00
avfilter/vf_atadenoise: Check for ff_get_video_buffer() failure Fixes CID1322338 Signed-off-by: Michael Niedermayer <[email protected]>
d5710411c74357efce09d1b09770990d2c13ef0c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d5710411c74357efce09d1b09770990d2c13ef0c
2015-09-03 23:07:43+02:00
avfilter/avf_showwaves: Check max_samples Fixes potential division by zero Fixes: CID1292295 Reviewed-by: Ganesh Ajjanagadde <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
a212a983c7f4faf06e600f32a165592dc5b6ae76
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a212a983c7f4faf06e600f32a165592dc5b6ae76
2015-09-03 19:27:20+02:00
avfilter/vf_histogram: fix bug in checking pixel format flags Signed-off-by: Paul B Mahol <[email protected]>
a16251a6d0401c772bd985f4c611caf97ca5e537
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a16251a6d0401c772bd985f4c611caf97ca5e537
2015-08-26 11:11:26+00:00
libfdk-aacdec: Clean up properly if the init fails Previously most of the error paths leaked. Also add FF_CODEC_CAP_INIT_THREADSAFE while adding caps_internal; this decoder wrapper doesn't have any static data that is initialized. Signed-off-by: Martin Storsjö <[email protected]>
f34b152eb7b7e8d2aee57c710a072cf74173fbe1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f34b152eb7b7e8d2aee57c710a072cf74173fbe1
2015-08-16 00:18:00+03:00
avcodec/svq1enc: Check dimensions Fixes assertion failure Signed-off-by: Michael Niedermayer <[email protected]>
88fe45e0fe379d7ea86c8ac1e1e8cf2c3f62389f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/88fe45e0fe379d7ea86c8ac1e1e8cf2c3f62389f
2015-08-15 15:06:01+02:00
elsdec: Replace EOVERFLOW with INVALIDDATA EOVERFLOW is not available on all platforms. Signed-off-by: Michael Niedermayer <[email protected]>
4e0819310e2d2eff60be2d6df28335f0739712b9
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4e0819310e2d2eff60be2d6df28335f0739712b9
2015-07-01 16:26:42+01:00
h264: do not update the context fields copied between threads after finish_setup() Should fix a large number of possible races with frame threading.
5ec0bdf2c524224f30ba4786f47324970aed4aaa
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5ec0bdf2c524224f30ba4786f47324970aed4aaa
2015-06-27 16:48:48+02:00
sonic: set avctx->channels in sonic_decode_init Otherwise it can be 0 in sonic_decode_frame, causing SIGFPE crashes. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
58995f647b5fa2e1efa33ae4f8b8a76a81ec99df
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/58995f647b5fa2e1efa33ae4f8b8a76a81ec99df
2015-06-09 23:21:51+02:00
movenc: fixes a questionable valgrind uninitialized value warning display_matrix_size is only initialized when av_stream_get_side_data() returns a side data pointer. The code is safe since the only effect this has is setting the display_matrix pointer to NULL which it was already anyway.
529c05698e88b057f0bea61e0d85f2b42925b5ea
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/529c05698e88b057f0bea61e0d85f2b42925b5ea
2015-06-10 14:32:11+02:00
avcodec/dxva2_h264: Fix "may be used uninitialized" warnings Signed-off-by: Michael Niedermayer <[email protected]>
5cddfc53570fe10fa7fe6d0f166f6f0e090466f6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5cddfc53570fe10fa7fe6d0f166f6f0e090466f6
2015-05-26 05:23:29+02:00
h264: drop the reinit parameter from init_slice_header() It is only used to decide whether to call free_tables(), but that function is safe to call on an uninitialized context as well.
8a66fd40260b7aae6226d68c4dbad43b05a8e524
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8a66fd40260b7aae6226d68c4dbad43b05a8e524
2015-04-29 05:52:58+02:00
mips/float_dsp: fix vector_fmul_window_mips on mips64 Commit dfa920807494 ("mips/float_dsp: fix a bug in vector_fmul_window_mips") fixed vector_fmul_window_mips by unrolling the loop only 4 times, but also removed the outer C loop and replaced it with assembly branches and pointer arithmetic. When submitting my 64-bit porting patch I missed this new assembly which also needed porting. This patch fixes a bus error in the fate-float-dsp test when run on 64-bit mips. Signed-off-by: James Cowgill <[email protected]> Reviewed-by: Nedeljko Babic <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
f8323744a0783d5937232a95cd1cc98f6b70a810
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f8323744a0783d5937232a95cd1cc98f6b70a810
2015-03-18 19:08:02+01:00
dca: Read params->pancABIT0[param_index] only if part0 is set Prevent a spurious read from uninitialized memory.
c9ed48e80ef807ab0c1bb946ac8db5f34d83d9c9
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c9ed48e80ef807ab0c1bb946ac8db5f34d83d9c9
2015-03-17 12:31:07+01:00
rtpdec_vp9: Drop extra sanity check for size of input packet In this case len is always at least 1, since it is checked against RTP_VP9_DESC_REQUIRED_SIZE + 1 and then it is reduced by RTP_VP9_DESC_REQUIRED_SIZE before entering the has_pic_id check. Bug-Id: CID 1270811
bacc92b59bfa5d6a1f631e63e46fc1d2fb934e51
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/bacc92b59bfa5d6a1f631e63e46fc1d2fb934e51
2015-03-11 18:01:25+00:00
webp: ensure that each transform is only used once According to the WebP Lossless Bitstream Specification "each transform is allowed to be used only once". If a transform is more than once this can lead to memory corruption. Signed-off-by: Michael Niedermayer <[email protected]>
c089e720c1b753790c746a13053636d7facf6bf0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c089e720c1b753790c746a13053636d7facf6bf0
2015-03-06 03:45:42+01:00
avfilter/hqdn3d: an invalid bit depth means a bug, not invalid read data This code looks clumsy, and an assert would probably be more welcome.
55feff57cec85cfcc972d40e02af131f0cb86a34
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/55feff57cec85cfcc972d40e02af131f0cb86a34
2015-02-08 17:16:51+01:00
avformat/omadec: only compute timestamps based on bitrate if its set Fixes division by zero Signed-off-by: Michael Niedermayer <[email protected]>
7c2fa13df9a6130b3f258c7513933cbdca2fe23b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7c2fa13df9a6130b3f258c7513933cbdca2fe23b
2015-02-07 21:12:56+01:00
avcodec/dvdsubdec: error on bitmaps with size 0 Attemtping to decode them could lead to invalid writes with some fuzzed samples. Signed-off-by: Michael Niedermayer <[email protected]>
bcaa9099b3648b47060e1724a97dc98b63c83702
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/bcaa9099b3648b47060e1724a97dc98b63c83702
2015-01-08 01:42:42+01:00
vp9: avoid infinite loop with broken files With a certain fuzzed file, the parser will always return 0 consumed bytes, which makes calling code call the parser infinitely. Return the full packet size on error instead. (Here it would be nice if parsers could return errors at all.) Additionally, _if_ there's some data left, return that too, which might help with somewhat broken but still somehow playable files. Fixes ticket #4242. Reviewed-by: "Ronald S. Bultje" <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
09b4ad15681be197fff8c57ce7c988a4718d6e03
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/09b4ad15681be197fff8c57ce7c988a4718d6e03
2015-01-10 20:12:36+01:00
mmvideo: check frame dimensions The frame size must be set by the caller and each dimension must be a multiple of 2. CC: [email protected] Bug-ID: CVE-2014-8543 Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
17ba719d9ba30c970f65747f42d5fbb1e447ca28
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/17ba719d9ba30c970f65747f42d5fbb1e447ca28
2014-12-19 08:01:46+01:00
avcodec/h264: Check *log2_weight_denom Fixes undefined behavior Fixes: signal_sigsegv_14768d2_2248_cov_3629497219_h264_h264___pi_20070614T182942.h264 Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
61296d41e2de3b41304339e4631dd44c2e15f805
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/61296d41e2de3b41304339e4631dd44c2e15f805
2014-12-18 03:45:59+01:00
avcodec/vorbis_parser: Move vp check Fixes null pointer dereference Fixes CID1251347 Signed-off-by: Michael Niedermayer <[email protected]>
374c907fb35f8236547b24d792fbb9bed201e321
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/374c907fb35f8236547b24d792fbb9bed201e321
2014-11-16 18:06:03+01:00
avresample: prevent theoretical division by zero CC: [email protected] Bug-Id: CID 1231986
088eca28164c8cd3b72b0c3d3f9e3fe5ee5cb28f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/088eca28164c8cd3b72b0c3d3f9e3fe5ee5cb28f
2014-10-18 16:15:10+01:00
avconv: fix leak in filter error CC: [email protected] Bug-Id: CID 1005311
c802a2e718fb3619291f310f851f1a1cdcf4f581
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c802a2e718fb3619291f310f851f1a1cdcf4f581
2014-10-17 09:55:46+01:00
avcodec/mpegvideo_enc: Fix leak on bitstream buffer reallocation Signed-off-by: Michael Niedermayer <[email protected]>
61c0683080176cfc6c325e556a3b7a4ca9566d5c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/61c0683080176cfc6c325e556a3b7a4ca9566d5c
2014-09-30 05:19:20+02:00
hevc_ps: check overflow and test alternate syntax Some streams were found to have what appeared to be truncated SPS. Their syntax seem to be valid at least until the end of the VUI, so try that syntax if the parsing would overflow the SPS in the conforming syntax. Fixes ticket #3872. Signed-off-by: Michael Niedermayer <[email protected]>
0625a3806628f3abcc6daa87b34ceb0d165b0160
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0625a3806628f3abcc6daa87b34ceb0d165b0160
2014-08-21 22:04:43+02:00
gdigrab: fix gdi object leak if using mouse based on patch from [email protected] Signed-off-by: rogerdpack <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
ea97859c8c218b83ab747a7eabcb88ca446f6751
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ea97859c8c218b83ab747a7eabcb88ca446f6751
2014-08-19 16:07:28+02:00