commit_msg
stringlengths 1
24.2k
| commit_hash
stringlengths 2
84
⌀ | project
stringlengths 2
40
| source
stringclasses 4
values | labels
int64 0
1
| repo_url
stringlengths 26
70
⌀ | commit_url
stringlengths 74
118
⌀ | commit_date
stringlengths 25
25
⌀ |
|---|---|---|---|---|---|---|---|
avfilter/src_movie: fix how we check for overflows with seek_point
Currently, if the movie source filter is used and a seek_point is
specified on a file that has a negative start time, ffmpeg will fail.
An easy way to reproduce this is as follows:
$ ffmpeg -vsync passthrough -filter_complex 'color=d=10,setpts=PTS-1/TB' test.mp4
$ ffmpeg -filter_complex 'movie=filename=test.mp4:seek_point=2' -f null -
The problem is caused by checking for int64_t overflow the wrong way.
In general, to check whether a + b overflows, it is not enough to do:
a > INT64_MAX - b
because b might be negative; the correct way is:
b > 0 && > a > INT64_MAX - b
Signed-off-by: Michael Niedermayer <[email protected]>
|
c1f9734f977f59bc0034096afbe8e43e40d93a5d
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/c1f9734f977f59bc0034096afbe8e43e40d93a5d
|
2016-04-03 01:50:08+02:00
|
ffserver&ffm: Fixed issues preventing ffserver write_index and files_size from being set correctly which was breaking ffserver streaming.
I discovered that ffserver streaming was broken (it seems like it has been since 20th November) and I opened a ticket for this (https://trac.ffmpeg.org/ticket/5250 <https://trac.ffmpeg.org/ticket/5250>).
I spent yesterday learning git bisect (with the kind help of cehoyos) to painstakingly track down the cause. This was made more difficult due to the presence of a segfault in ffserver during the period where the bug was introduced so I first had to identify when and how that was fixed and then retrospectively apply that fix again for each step of the second git bisect to find the actual bug.
Anyway, the fruits of my labour are the innocent looking patch below to correct a couple of typos and define a valid range for two variables.
Signed-off-by: Michael Niedermayer <[email protected]>
|
a2f8beef2dfaee573f7c4a607afaa9e83fc2c1e0
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/a2f8beef2dfaee573f7c4a607afaa9e83fc2c1e0
|
2016-02-21 12:59:07+01:00
|
ffmpeg: Check best_effort_timestamp after rescale
Fixes integer overflow
Fixes: Ticket5126
Signed-off-by: Michael Niedermayer <[email protected]>
|
5590ab45e0b1cd45e48580608f99615ad0a429b8
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/5590ab45e0b1cd45e48580608f99615ad0a429b8
|
2016-02-18 01:46:59+01:00
|
vc2enc: fix use of uninitialized variables in the rate control system
Fixes: CID1352550
Fixes: CID1352549
Signed-off-by: Rostislav Pehlivanov <[email protected]>
|
7cdea450c67d24a3503a0eb64f491f58e474973f
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/7cdea450c67d24a3503a0eb64f491f58e474973f
|
2016-02-15 12:12:16+00:00
|
tiny_psnr: Support large files
If an input file is bigger than 2GB (assume sizeof(int) == 4)),
size0/size1 will overflow, making stddev and PSNR invalid.
Signed-off-by: Luca Barbato <[email protected]>
|
7a00653be6b13131ce1b2cdeca696429f57caaf8
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/7a00653be6b13131ce1b2cdeca696429f57caaf8
|
2016-02-09 20:03:34+01:00
|
fate/cabac: replace uninitialized bytes by random bytes
Fixes valgrind warning
Signed-off-by: Michael Niedermayer <[email protected]>
|
0be4377333d8a9104eadd8b297605a6e95b22047
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/0be4377333d8a9104eadd8b297605a6e95b22047
|
2016-01-23 20:53:29+01:00
|
avcodec/aacenc: Check all coefficients for finiteness
This is needed as near infinite values on the input side result in only some
output to be non finite.
Also it may still be insufficient if subsequent computations overflow
Fixes null pointer dereference
Fixes: ae66c0f6c12ac1cd5c2c237031240f57/signal_sigsegv_2618c99_9516_6007026f2185a26d7afea895fbed6e38.ogg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Reviewed-by: Claudio Freire <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
2cb8edea7c9af336f3fa60ac8a0f9b8a17e92188
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/2cb8edea7c9af336f3fa60ac8a0f9b8a17e92188
|
2016-01-20 21:21:31+01:00
|
asfdec_o: only set asf_pkt->data_size after sanity checks
Otherwise invalid values are used unchecked in the next run.
This can cause NULL pointer dereferencing.
Reviewed-by: Alexandra Hájková <[email protected]>
Signed-off-by: Andreas Cadhalpun <[email protected]>
|
763c572801a3db1cc7a2f07a52fee9d2e35ec95a
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/763c572801a3db1cc7a2f07a52fee9d2e35ec95a
|
2016-01-15 00:36:41+01:00
|
avcodec/mpeg4video: Check time_incr
Fixes assertion failure
Fixes out of memory access
Fixes: test_casex.ivf
Found-by: Tyson Smith <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
7c97946d6131b31340954a3f603b6bf92590a9a5
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/7c97946d6131b31340954a3f603b6bf92590a9a5
|
2016-01-12 03:35:29+01:00
|
asfdec: only set asf_pkt->data_size after sanity checks
Otherwise invalid values are used unchecked in the next run.
This can cause NULL pointer dereferencing.
Signed-off-by: Andreas Cadhalpun <[email protected]>
Signed-off-by: Alexandra Hájková <[email protected]>
Signed-off-by: Anton Khirnov <[email protected]>
|
c69461d73797e02e7a3ab4316050c241fa91f53f
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/c69461d73797e02e7a3ab4316050c241fa91f53f
|
2016-01-07 08:20:21+01:00
|
exr: fix out of bounds read in get_code
This macro unconditionally used out[-1], which causes an out of bounds
read, if out is the very beginning of the buffer.
Signed-off-by: Andreas Cadhalpun <[email protected]>
|
90b99a81071d10e6b5efe86a4602d54d4f45bbcb
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/90b99a81071d10e6b5efe86a4602d54d4f45bbcb
|
2015-12-18 15:30:04+01:00
|
avformat/rmdec: Fix use of uninitialized variable
Fixes: CID1341580
Signed-off-by: Michael Niedermayer <[email protected]>
|
80ceb4696ab7b9c40a0e456a866c473a5291d2f2
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/80ceb4696ab7b9c40a0e456a866c473a5291d2f2
|
2015-12-09 18:17:47+01:00
|
lavfi/vf_alphamerge: fix memory leaks
Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and
3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning
up usage of the formats API, and in particular fixed possible NULL pointer
dereferences.
This commit addresses the issue of possible resource leaks when some intermediate
call fails.
Tested with valgrind --leak-check=full --show-leak-kinds=all, and manual simulation
of malloc/realloc failures.
Fixes: CID 1338326, 1338329.
Signed-off-by: Ganesh Ajjanagadde <[email protected]>
|
31f0d555e07797df1a0a141fa5e022648d480a49
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/31f0d555e07797df1a0a141fa5e022648d480a49
|
2015-12-09 07:58:03-05:00
|
rawdec: only exempt BIT0 with need_copy from buffer sanity check
Otherwise the too small buffer is directly used in the frame, causing
segmentation faults, when trying to use the frame.
Reviewed-by: Michael Niedermayer <[email protected]>
Signed-off-by: Andreas Cadhalpun <[email protected]>
|
699e68371ec7e381e5cc48e3d96e29c669261af7
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/699e68371ec7e381e5cc48e3d96e29c669261af7
|
2015-12-20 12:15:56+01:00
|
lavc/opusdec: Fix a memleak when reading invalid files.
Reviewed-by: James Almer
|
ced39dc5ed3ad40e7f970c95019721d58742088a
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/ced39dc5ed3ad40e7f970c95019721d58742088a
|
2015-11-22 01:49:18+01:00
|
movenc-test: Fix integer overflows
Signed-off-by: Martin Storsjö <[email protected]>
|
5b70fb8fee4af3b13f29a2dc7222fd3c9782f79b
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/5b70fb8fee4af3b13f29a2dc7222fd3c9782f79b
|
2015-11-24 20:57:11+02:00
|
brstm: reject negative sample rate
A negative sample rate causes assertion failures in av_rescale_rnd.
Reviewed-by: Paul B Mahol <[email protected]>
Signed-off-by: Andreas Cadhalpun <[email protected]>
|
7b67fe20f6c5ce21ed1cac01fdb1906e515bc87e
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/7b67fe20f6c5ce21ed1cac01fdb1906e515bc87e
|
2015-11-10 22:06:26+01:00
|
avformat: unref packet after storing it in internal packet queue
Fixes a memory leak when using genpts
|
55abb94b7d9a4dc93bece7ed7bc77daf4cc4a91d
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/55abb94b7d9a4dc93bece7ed7bc77daf4cc4a91d
|
2015-11-02 09:03:56+01:00
|
avcodec/h264, videotoolbox: do not return invalid frames on failure
If videotoolbox_common_end_frame failed, then the AVFrame was returned
to the API user with the dummy buffer (in AVFrame.buf[0]) still set, and
the decode call indicating success.
These "half-set" AVFrames with dummy buffer are a videotoolbox specific
hack, because the decoder requires an allocated AVFrame for its internal
logic. Videotoolbox on the other hand allocates its frame itself
internally, and outputs it only on end_frame. At this point, the dummy
buffer is replaced with the real frame (unless decoding fails).
|
9747219958060d8c4f697df62e7f172c2a77e6c7
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/9747219958060d8c4f697df62e7f172c2a77e6c7
|
2015-11-20 11:30:18+01:00
|
avutil/internal: add av_warn_unused_result to avpriv_open
The open syscall can obviously fail, and its return code needs to be
checked.
Reviewed-by: Michael Niedermayer <[email protected]>
Signed-off-by: Ganesh Ajjanagadde <[email protected]>
|
31ed189d5c0583cac118197689b4f3766aa146cb
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/31ed189d5c0583cac118197689b4f3766aa146cb
|
2015-10-16 17:18:21-04:00
|
fate: add 10bits YUV4:2:2 dnxhd test
It was useful to (accidentally?) spot an overflow in the column pass
of the x86 simple_idct10 implementation.
Signed-off-by: Michael Niedermayer <[email protected]>
|
f1181e466062541b6562f6c06dccc7a209ec76c5
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/f1181e466062541b6562f6c06dccc7a209ec76c5
|
2015-10-13 04:04:02+02:00
|
doc/scaler, swscale/options: use proper capitalization
Proper names should be capitalized in all user facing API as far as
possible. The option names themselves have not been changed since:
1. We consistently keep option names in lower case.
2. Changing them would break existing scripts.
The converse is also true: improper names should not be capitalized
generally.
Signed-off-by: Ganesh Ajjanagadde <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
3b2000c2bf123baef5b934e1d04cc86e5f404a87
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/3b2000c2bf123baef5b934e1d04cc86e5f404a87
|
2015-10-10 19:32:56+02:00
|
dcadec: Always initialize return variable
Silence an uninitialized warning from clang.
|
4c160fa23996c05efcd952ccfac2359311d8a1bc
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/4c160fa23996c05efcd952ccfac2359311d8a1bc
|
2015-10-04 13:06:27+02:00
|
avcodec/hevc_parser: Check init_get_bits8() for failure
Fixes: CID1322322
Signed-off-by: Michael Niedermayer <[email protected]>
|
bd6610c3b39e24ff3c3745cdfc5c69450bc7b0e5
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/bd6610c3b39e24ff3c3745cdfc5c69450bc7b0e5
|
2015-09-04 03:09:03+02:00
|
ffmpeg: avoid possible undefined behavior
On lines 1633,1634 FFABS(pts) is performed. However, if av_stream_get_end_pts
returns AV_NOPTS_VALUE always, pts remains stuck at INT64_MIN, leading
to undefined behavior on FFABS.
One could conceive of a solution using FFNABS. However, such a solution
has to deal with the implementation defined rounding of integer division
with at least one negative operand in ANSI C89. C99 forces truncation to
zero, but I am not sure that all of our platforms compile with full C99
support, and in particular whether we can safely assume a fixed
rounding behavior across all platforms.
This solution is simple, and I doubt changing INT64_MIN to INT64_MIN + 1
has any practical loss - if it is stuck at its initial value, the stream
is messed up anyway.
Signed-off-by: Ganesh Ajjanagadde <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
2f4374fae135afeee84f987c8fab8cbad1c7fcc7
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/2f4374fae135afeee84f987c8fab8cbad1c7fcc7
|
2015-10-09 21:19:39+02:00
|
tests/fate-run: make FATE non-interactive
FATE is non-interactive; it should not listen to user commands
Signed-off-by: Ganesh Ajjanagadde <[email protected]>
This should fix leaving the terminal in a messed up state with
zsh in case of crashes during fate
Signed-off-by: Michael Niedermayer <[email protected]>
|
36e17d994edcf4095f7805842d2e12228cbe784f
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/36e17d994edcf4095f7805842d2e12228cbe784f
|
2015-08-12 00:10:57+02:00
|
avcodec/texturedsp: fix undefined shift
Silences warnings when using -Wshift-overflow (GCC 6+)
Reviewed-by: Michael Niedermayer <[email protected]>
Signed-off-by: James Almer <[email protected]>
|
ec7f04c13a6e6e483cc86e576aff7700e42cd59e
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/ec7f04c13a6e6e483cc86e576aff7700e42cd59e
|
2015-07-26 00:40:17-03:00
|
avcodec/aacps_fixed_tablegen: change f_center to 64bit to avoid overflow
Signed-off-by: Michael Niedermayer <[email protected]>
|
c105e0f077fb988d5c19e1a1beadf839f01e1a3e
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/c105e0f077fb988d5c19e1a1beadf839f01e1a3e
|
2015-07-25 22:07:41+02:00
|
asfdec: increment nb_streams right after the stream allocation
to prevent possible memory leaks
Signed-off-by: Anton Khirnov <[email protected]>
|
aed7715b8fa295980c221f1cd095d42cd3bd74a6
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/aed7715b8fa295980c221f1cd095d42cd3bd74a6
|
2015-07-23 09:48:26+02:00
|
avcodec/mpegvideo: Clear pointers in ff_mpv_common_init()
This ensures that no stale pointers leak through on any path
Fixes: signal_sigsegv_c3097a_991_xtrem_e2_m64q15_a32sxx.3gp
Found-by: Samuel Groß, Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
b160fc290cf49b516c5b6ee0730fd9da7fc623b1
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/b160fc290cf49b516c5b6ee0730fd9da7fc623b1
|
2015-07-09 22:47:16+02:00
|
avio: fix potential crashes when combining ffio_ensure_seekback + crc
Calling ffio_ensure_seekback() if ffio_init_checksum() has been called
on the same context can lead to out of bounds memory accesses and
crashes. The reason is that ffio_ensure_seekback() does not update
checksum_ptr after reallocating the buffer, resulting in a dangling
pointer.
This effectively fixes potential crashes when opening mp3 files.
Signed-off-by: Michael Niedermayer <[email protected]>
|
dc87758775e2ce8be84e4fe598e12416e83d2845
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/dc87758775e2ce8be84e4fe598e12416e83d2845
|
2015-06-17 01:13:19+02:00
|
ac3_parser: add required padding for GetBitContext buffer
Fixes stack buffer overflow errors detected by address sanitizer in
various fate tests.
CC: [email protected]
|
09447f2b0fafac6d9565aab82a4c5f16fc99ee5e
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/09447f2b0fafac6d9565aab82a4c5f16fc99ee5e
|
2015-06-09 10:06:59+02:00
|
swresample/swresample: Cleanup on init failure.
This avoids leaks if the user doest call swr_close() after a failed init
Found-by: James Almer <[email protected]>
Reviewed-by: James Almer <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
c3f87f7545d42520921bc448b9fbd7324c574e49
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/c3f87f7545d42520921bc448b9fbd7324c574e49
|
2015-06-04 12:35:04+02:00
|
avcodec/libtheoraenc: Check for av_malloc failure
Fixes CID1257799
Signed-off-by: Michael Niedermayer <[email protected]>
|
c64b2d480b4a35d4face9928b4265a0fda3f3dd9
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/c64b2d480b4a35d4face9928b4265a0fda3f3dd9
|
2015-05-15 23:46:10+02:00
|
matroskadec: use uint64_t instead of int for index_scale
index_scale is set to matroska->time_scale of type uint64_t.
When index_scale is int, the assignment can overflow and e.g. result
in index_scale = 0. This causes a floating point exception due to the
division by index_scale.
Signed-off-by: Andreas Cadhalpun <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
eb9fb508b0e09d85d234fe694333b2005e1d7a7e
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/eb9fb508b0e09d85d234fe694333b2005e1d7a7e
|
2015-05-04 00:16:00+02:00
|
fate: Fix test name for pixfmts tests
The last pixel format gets leaked as `$test` further down the pipeline.
See for example https://fate.libav.org/x86_32-netbsd-clang-no-inline-asm/20150420020104
Note the odd test names like “yuvj444p.”
CC: [email protected]
Signed-off-by: Luca Barbato <[email protected]>
|
358b7ec3099eca6e999ad9dc0da0a23571a7a2f8
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/358b7ec3099eca6e999ad9dc0da0a23571a7a2f8
|
2015-04-23 12:47:00+02:00
|
avformat/libquvi: Fix whitelist handling
Fixes null pointer dereference
Signed-off-by: Michael Niedermayer <[email protected]>
|
21e034a47a2b407f0896114a995fd507f0f5230f
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/21e034a47a2b407f0896114a995fd507f0f5230f
|
2015-04-08 14:40:56+02:00
|
avcodec/h264: Fix race between slices where one overwrites data from the next
Fixes non deterministic crash in ticket4408/fuzz2.264
Likely fixes other samples as well
Signed-off-by: Michael Niedermayer <[email protected]>
|
43b434210e597d484aef57c4139c3126d22b7e2b
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/43b434210e597d484aef57c4139c3126d22b7e2b
|
2015-04-07 00:40:21+02:00
|
ac3dec_fixed: always use the USE_FIXED=1 variant of the AC3DecodeContext
The AC3DecodeContext has a float (USE_FIXED=0) and an integer
(USE_FIXED=1) variant, both of which can be present in the same binary.
This is not only very confusing, but it also breaks horribly, when one
variant is used by code expecting the other.
This currently happens, because eac3dec.c is only compiled for the float
variant, but also used from ac3dec_fixed.c, which uses the integer
variant.
The result is memory corruption, leading to crashes.
So compile eac3dec.c once for each variant and adapt it, so that it
works with the integer variant.
A loss of precission and scaling bug has been fixed by the committer
Signed-off-by: Michael Niedermayer <[email protected]>
|
7b05b5093ea67a3397b0c37cf398bab471e1ce2b
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/7b05b5093ea67a3397b0c37cf398bab471e1ce2b
|
2015-03-14 04:27:06+01:00
|
AAC: Fix M/S stereo encoding
This patch fixes a pointer arithmetic bug in adjust_frame_information that resulted in heavily corrupted audio when using M/S encoding. Also, a backup copy of untransformed coefficients has to be kept around or attempts at re-processing the frame (which happens when hevavily overspending bits during transients) will result in re-encoding of the coefficients and subsequent corruption of the resulting stream.
A/B testing shows the bug as corrected, but still cannot prove that M/S coding is a win at least in numbers. Limited listening tests do show improvement on M/S encoded samples in lower bitrates, but they're hidden among the other artifacts that remain to be corrected in the encoder.
Some of the regressions flagged in the report do show poor stereo image (but not buggy), so M/S encoding is clearly not good enough yet to be defaulted to auto.
In numbers, Patched against Unpatched, stereo_mode auto:
Files: 114
Bitrates: 6
Tests: 683
Serious Regressions: 0 (0%)
Regressions: 0 (0%)
Improvements: 227 (33%)
Big improvements: 92 (13%)
Worst regression - mybloodrusts.wv - 256k
- StdDev: 28.61 pSNR: -0.43 maxdiff: 1372.00
Best improvement - 60.wv - 384k
- StdDev: -369.57 pSNR: 45.02 maxdiff: -13322.00
Average - StdDev: -80.56 pSNR: 2.49 maxdiff: -8858.00
Patched against Unpatched stereo_mode ms_off shows no difference.
Patched stereo_mode auto vs Unpatched stereo_mode ms_off shows a small average improvement, just not too significant:
Serious Regressions: 0 (0%)
Regressions: 10 (1%)
Improvements: 45 (6%)
Big improvements: 2 (0%)
Worst regression - Illinois.wv - 256k
- StdDev: 33.20 pSNR: -2.03 maxdiff: 477.00
Best improvement - song_of_circomstances.flac - 384k
- StdDev: -3.97 pSNR: 7.61 maxdiff: -826.00
Average - StdDev: -10.25 pSNR: 0.20 maxdiff: -281.00
Signed-off-by: Michael Niedermayer <[email protected]>
|
6394acaf36da3106f4793bda32730f8ff6b0ddb1
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/6394acaf36da3106f4793bda32730f8ff6b0ddb1
|
2015-03-03 13:57:42+01:00
|
avcodec/a64multienc: don't set incorrect packet size
This fixes invalid reads of the packet buffer in av_dup_packet
Based on patch by Andreas Cadhalpun <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
d96142e9af92ded84f2580620c571ab96c4bb657
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/d96142e9af92ded84f2580620c571ab96c4bb657
|
2015-02-23 01:49:23+01:00
|
tools/graph2dot: Check for av_malloc() failure
Fixes CID1271047
Signed-off-by: Michael Niedermayer <[email protected]>
|
0a32a1b4bbcdffe5c6a61a9e8ea64a17bf31f172
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/0a32a1b4bbcdffe5c6a61a9e8ea64a17bf31f172
|
2015-02-22 22:51:13+01:00
|
postproc/postprocess: Check for av_malloc() failure
Fixes CID1271052
Signed-off-by: Michael Niedermayer <[email protected]>
|
f9d24ee1dc8e16312af059c716d489b7de689822
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/f9d24ee1dc8e16312af059c716d489b7de689822
|
2015-02-22 03:19:05+01:00
|
avcodec/libx264: Check for av_malloc() failure
Fixes CID1257813
Signed-off-by: Michael Niedermayer <[email protected]>
|
066dc0437368acd21546ee327a0a94c60c3808b2
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/066dc0437368acd21546ee327a0a94c60c3808b2
|
2015-02-22 02:55:51+01:00
|
avformat/tta: fix crash with corrupted files
av_add_index_entry() can fail, for example because the parameters are
invalid, or because memory allocation fails. Check this; it can actually
happen with corrupted files.
The second hunk is just for robustness. Just in case functions like
ff_reduce_index() remove entries. (Not sure if this can actually
happen.)
Fixes ticket #4294.
Reviewed-by: Paul B Mahol <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
6a0cd529a35190d9374b0b26504e71857cd67b83
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/6a0cd529a35190d9374b0b26504e71857cd67b83
|
2015-02-03 16:02:32+01:00
|
avformat/network: Check for av_malloc* failures in ff_tls_init()
Signed-off-by: Michael Niedermayer <[email protected]>
|
7620d48f2eab67812d8c535d12a98eaa754a1177
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/7620d48f2eab67812d8c535d12a98eaa754a1177
|
2015-02-03 02:21:55+01:00
|
avcodec/dvbsubdec: Check get_region() return value
Fixes null pointer dereference with DEBUG enabled
Signed-off-by: Michael Niedermayer <[email protected]>
|
8de0990e9f22d7f728f70d5a03f3e78fc958f658
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/8de0990e9f22d7f728f70d5a03f3e78fc958f658
|
2015-01-17 16:33:02+01:00
|
avcodec/adpcm: Check idelta
Fixes integer overflow
Fixes: signal_sigsegv_1b0a4da_1865_cov_2167818389_computer_anger.avi
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
e59c28b16660b8f86ef05c7f0db4db89e62ed55f
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/e59c28b16660b8f86ef05c7f0db4db89e62ed55f
|
2014-12-18 16:10:23+01:00
|
avformat/bit: check that pkt->size is 10 in write_packet
Ohter packet sizes are not supported by this muxer.
This avoids a null pointer dereference of pkt->data.
Signed-off-by: Andreas Cadhalpun <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
eeda2c3de8a8484d9e7d1e47ac836bec850b31fc
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/eeda2c3de8a8484d9e7d1e47ac836bec850b31fc
|
2015-02-26 23:19:31+01:00
|
avfilter/vf_uspp: fix integer overflow in intermediate
Fixes Ticket3596
Signed-off-by: Michael Niedermayer <[email protected]>
|
e07c82688e8187dbafac489b7c15427252974021
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/e07c82688e8187dbafac489b7c15427252974021
|
2014-12-12 04:28:34+01:00
|
libfdk-aacdec: Fix a boundary check
This avoids potential out of bounds writes, with potential future
versions of the library.
Bug-Id: CID 1254945
CC: [email protected]
Signed-off-by: Martin Storsjö <[email protected]>
|
c7921a480467876ece06566e0efd8f6bce9d1903
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/c7921a480467876ece06566e0efd8f6bce9d1903
|
2014-12-10 22:51:42+02:00
|
avfilter/vf_perspective: add av_assert0() to help gcc see that there are no uninitialized variables
Signed-off-by: Michael Niedermayer <[email protected]>
|
a2fa1889a69f55ad9f1971eb8ff9c638c0470ebf
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/a2fa1889a69f55ad9f1971eb8ff9c638c0470ebf
|
2014-12-10 13:40:20+01:00
|
ffserver: dont leak child arguments
Signed-off-by: Lukasz Marek <[email protected]>
|
3cb0bec6870cf0bb7879f7bfd4119ef39a02a464
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/3cb0bec6870cf0bb7879f7bfd4119ef39a02a464
|
2014-11-26 23:32:33+01:00
|
lavc/huffyuvdec: fix mem leak in case of init failure
Signed-off-by: Lukasz Marek <[email protected]>
|
c9d39fc8c68700832d5206e40d12761d65a604de
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/c9d39fc8c68700832d5206e40d12761d65a604de
|
2014-11-24 04:15:48+01:00
|
lavf: Only initialize s->offset once when using avoid_negative_ts make_zero
When given a stream starting at dts=0, it would previously consider
s->offset as uninitialized and set an offset when the second packet
was written, ending up writing two packets with dts=0. By initializing
this field to AV_NOPTS_VALUE, we make sure that we only initialize it
once, on the first packet.
Signed-off-by: Martin Storsjö <[email protected]>
|
9257692ac15eff7b07540c1f61cebde0d8823fbd
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/9257692ac15eff7b07540c1f61cebde0d8823fbd
|
2014-11-17 23:18:55+02:00
|
ffserver_config: fix possible crash
Fixes CID #1254662
Signed-off-by: Lukasz Marek <[email protected]>
|
3f07dd6e392bf35a478203dc60fcbd36dfdd42aa
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/3f07dd6e392bf35a478203dc60fcbd36dfdd42aa
|
2014-11-17 00:27:25+01:00
|
librtmp: append the correct field to the string
Also prevent a NULL pointer dereference.
CC: [email protected]
Bug-Id: CID 1250329 / CID 1250331
|
a28468d0daf4be14761c16a3ddd33266b2380123
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/a28468d0daf4be14761c16a3ddd33266b2380123
|
2014-11-18 00:38:26+01:00
|
avformat: Add and use ff_copy_whitelists()
Fixes potential security issue in case of running out of memory
Found-by: ubitux
Signed-off-by: Michael Niedermayer <[email protected]>
|
4641ae352ec587355764ffd5c43dd0d0ebd47654
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/4641ae352ec587355764ffd5c43dd0d0ebd47654
|
2014-10-24 19:23:23+02:00
|
avresample: Make sure the even check does not overflow
CC: [email protected]
Bug-Id: CID 732225
|
963f76144897d3f7684d82ec21e51dd50ea1106e
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/963f76144897d3f7684d82ec21e51dd50ea1106e
|
2014-10-18 16:15:10+01:00
|
vdpau: add AV_HWACCEL_FLAG_IGNORE_LEVEL to skip the codec level check
Decoding acceleration may work even if the codec level is higher than
the stated limit of the VDPAU driver. Or the problem may be considered
acceptable by the user. This flag allows skipping the codec level
capability checks and proceed with decoding.
Applications should obviously not set this flag by default, but only if
the user explicitly requested this behavior (and presumably knows how
to turn it back off if it fails).
Signed-off-by: Anton Khirnov <[email protected]>
|
d565fef1b83b6c5f8afb32229260b79f67c68109
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/d565fef1b83b6c5f8afb32229260b79f67c68109
|
2014-10-15 06:21:56+00:00
|
avformat/rtpdec_h261: Fix sanity checks
Fixes mbap and quant
Signed-off-by: Michael Niedermayer <[email protected]>
|
e15824e75b5549e53eb5c1ffb79766321ac8d122
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/e15824e75b5549e53eb5c1ffb79766321ac8d122
|
2014-08-26 20:37:58+02:00
|
avcodec: fix aac/ac3 parser bitstream buffer size
Buffers containing copies of the AAC and AC3 header bits were not padded
before parsing, violating init_get_bits() buffer padding requirement,
leading to potential buffer read overflows.
This change adds FF_INPUT_BUFFER_PADDING_SIZE bytes to the bit buffer
for parsing the header in each of aac_parser.c and ac3_parser.c.
Based on patch by: Matt Wolenetz <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
fccd85b9f30525f88692f53134eba41f1f2d90db
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/fccd85b9f30525f88692f53134eba41f1f2d90db
|
2014-08-22 01:24:40+02:00
|
wavpackenc: assert on too small buffer
bytestream2_* will not cause buffer overflow, but in that case, this means
the allocation would be incorrect and the encoded result invalid. Therefore,
assert no overflow occurred.
Signed-off-by: Michael Niedermayer <[email protected]>
|
4a5cc34b46a8bf8d47ec907383be83b6153b9f69
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/4a5cc34b46a8bf8d47ec907383be83b6153b9f69
|
2014-08-21 17:59:06+02:00
|
lavf/wavdec: add sanity check for AVCodecContext.channels
Fixes ticket #3862.
As a side effect, this also fixes aac_latm in wav.
Signed-off-by: James Almer <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
853c1fb66835123c87178420816cff58c18548ed
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/853c1fb66835123c87178420816cff58c18548ed
|
2014-08-18 09:29:25+02:00
|
mmvideo: check horizontal coordinate too
Fixes out of array accesses.
Bug-Id: CVE-2013-3672
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Vittorio Giovara <[email protected]>
Signed-off-by: Anton Khirnov <[email protected]>
|
70cd3b8e659c3522eea5c16a65d14b8658894a94
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/70cd3b8e659c3522eea5c16a65d14b8658894a94
|
2014-08-05 19:16:12+00:00
|
avformat/mux: keep AVPacket fields consistent in ff_write_chained()
This might have caused double frees in theory, i do not have a test case
though
Signed-off-by: Michael Niedermayer <[email protected]>
|
383a04a127734d25c1ef7839c489bba297855801
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/383a04a127734d25c1ef7839c489bba297855801
|
2014-07-24 22:33:21+02:00
|
lavfi/src_movie: remove frame from priv context
This variable is used only inside one function.
There is no need to store it in context.
This also may prevent crush by double free frame.
Signed-off-by: Lukasz Marek <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
97392553656a7f4fabde9ded4d2b7f538d98ee17
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/97392553656a7f4fabde9ded4d2b7f538d98ee17
|
2014-07-24 04:48:49+02:00
|
avcodec/hevc: clear HEVClcList[i] on allocation
Fixes fate failure with --enable-memory-poisoning && make THREAD_TYPE=slice THREADS=7 fate-hevc-conformance-ENTP_C_Qualcomm_1
Signed-off-by: Michael Niedermayer <[email protected]>
|
cf92cc8751bb27666a5b8c7c384a3c6b379823b3
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/cf92cc8751bb27666a5b8c7c384a3c6b379823b3
|
2014-07-16 01:34:57+02:00
|
hevc: Allow out of bound values for num_reorder_pics
This fixes decoding for a sample that cannot be shared
Signed-off-by: Anton Khirnov <[email protected]>
|
9b60d9197970658e91daf4b586397f450de9af69
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/9b60d9197970658e91daf4b586397f450de9af69
|
2014-06-26 07:14:57+02:00
|
swr: handle 64bit overflow check in multiple_resample().
Signed-off-by: Michael Niedermayer <[email protected]>
|
f341340552e2b70868a71aa55d3aebf3a27acc6d
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/f341340552e2b70868a71aa55d3aebf3a27acc6d
|
2014-06-09 15:24:51+02:00
|
avcodec/hevc_sei: fix invalid get_bits() in a comment
Signed-off-by: Michael Niedermayer <[email protected]>
|
5183fac92fc5c574a053dd06b84e735a1ec1cfa6
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/5183fac92fc5c574a053dd06b84e735a1ec1cfa6
|
2014-06-07 23:37:27+02:00
|
avcodec/mpegvideo: Fix psnr calculation with slice threads
This fixes a race condition and use of the wrong field, which become shared
instead of per thread during some AVFrame changes.
Signed-off-by: Michael Niedermayer <[email protected]>
|
681868cbbe8a596860c454d34f259941e0c44d73
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/681868cbbe8a596860c454d34f259941e0c44d73
|
2014-06-13 13:16:27+02:00
|
Fix nonsense non-mod16 AMV flipping code.
It is obviously nonsense since it produces wrong results
or even crashes (crashes should be encode-only though).
Fixes trac issue #1092.
Signed-off-by: Reimar Döffinger <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
6d695d7acc4cb1da84eb73710e05a4c090e5ab31
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/6d695d7acc4cb1da84eb73710e05a4c090e5ab31
|
2014-06-01 19:47:07+02:00
|
avcodec/fic: fix slice checks
fix integer overflows
Signed-off-by: Michael Niedermayer <[email protected]>
Signed-off-by: Derek Buitenhuis <[email protected]>
|
f34d3173fcfc7f3228095d509a64c4fa4b37b575
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/f34d3173fcfc7f3228095d509a64c4fa4b37b575
|
2014-04-21 14:56:17-04:00
|
tiffdec: use bytestream2 to simplify overread/overwrite protection
Based on a patch by Paul B Mahol <[email protected]>
CC:[email protected]
|
0a467a9b594dd67aa96bad687d05f8845b009f18
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/0a467a9b594dd67aa96bad687d05f8845b009f18
|
2014-04-12 14:49:08-04:00
|
lavf/utils: fix mem leak
Calling avformat_free_context() right after avformat_alloc_output_context2()
leaved option's default values not freed.
Options were freed only in av_write_trailer().
Signed-off-by: Lukasz Marek <[email protected]>
Signed-off-by: Michael Niedermayer <[email protected]>
|
e1c48e3593fb2e848fd7fb910ea3d807941f8e91
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/e1c48e3593fb2e848fd7fb910ea3d807941f8e91
|
2014-04-10 03:24:07+02:00
|
lavf/audiointerleave: check for allocation failure
Signed-off-by: Lukasz Marek <[email protected]>
|
2ed9e17ed1793b3b66ed27c0a113676a46eb9871
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/2ed9e17ed1793b3b66ed27c0a113676a46eb9871
|
2014-05-20 00:00:45+02:00
|
examples/avio_reading: fix null dereference on error
Fixed CID1197052
Signed-off-by: Michael Niedermayer <[email protected]>
|
419800acc46afc0c3b7319d6e216d0da207ebbb7
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/419800acc46afc0c3b7319d6e216d0da207ebbb7
|
2014-04-06 00:39:58+02:00
|
avcodec/ratecontrol: make (mc_)mb_var_sum(_last) 64bit
This avoids hypothetical integer overflows
|
b4356c9cc28197bb8da626ece08d4a062b62afc8
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/b4356c9cc28197bb8da626ece08d4a062b62afc8
|
2014-03-21 18:34:54+01:00
|
http: never send 'Cookie: (null)' to the server
If a domain has some cookies set, but matching the cookie fails due to
the port being different, get_cookies() succeeds, but sets cookies to
NULL. The caller of get_cookies() didn't check for the NULL value.
This also avoids passing NULL to libc string functions, which is
undefined behavior
Fixes Ticket2180
Signed-off-by: Michael Niedermayer <[email protected]>
|
76c8fbc5f22c4a93c08030b10e5dbbd4e0c4dd68
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/76c8fbc5f22c4a93c08030b10e5dbbd4e0c4dd68
|
2014-03-21 20:32:09+01:00
|
hevc: use av_mallocz() for allocating tab_ipm
Fixes use of uninitialized memory and out of stack array read.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
|
6cc94e971933cd38c452172bb048bf760e65cc3e
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/6cc94e971933cd38c452172bb048bf760e65cc3e
|
2014-03-09 17:08:11+01:00
|
avfilter/af_compand: fix invalid read
Fixes #3383.
|
9e329185d701f60412eb70c4ffbeb345bd459e82
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/9e329185d701f60412eb70c4ffbeb345bd459e82
|
2014-02-25 19:00:14+00:00
|
avcodec/lossless_videodsp: add_hfyu_left_prediction_int16_c: fix harmless integer overflow
Signed-off-by: Michael Niedermayer <[email protected]>
|
ed1a6878564a97e67e5fe3a25bc099208cfed024
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/ed1a6878564a97e67e5fe3a25bc099208cfed024
|
2014-02-15 16:51:33+01:00
|
ppc: reduce overreads when loading 8 pixels in altivec dsp functions
Altivec can only load naturally aligned vectors. To handle possibly
unaligned data a second vector is loaded from an offset of the original
location and the data is recovered through a vector permutation.
Overreads are minimal if the offset for second load points to the last
element of data. This is 7 for loading eight 8-bit pixels and overreads
are reduced from 16 bytes to 8 bytes if the pixels are 64-bit aligned.
For unaligned pixels the overread is reduced from 23 bytes to 15 bytes
in the worst case.
|
98fdfa99704f1cfef3d3a26c580b92749b6b64cb
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/98fdfa99704f1cfef3d3a26c580b92749b6b64cb
|
2014-02-14 18:34:04+01:00
|
avcodec/hevc: propagate error code from hls_coding_quadtree()
Fixes use of uninitialized memory
Fixes out of array read
Fixes: asan_static-oob_123cee5_2630_cov_1869071233_PICSIZE_A_Bossen_1.bin
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
96c4ba2392b9cd55a5e84cb28db5c0c7e53cd390
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/96c4ba2392b9cd55a5e84cb28db5c0c7e53cd390
|
2014-02-02 02:35:11+01:00
|
mpeg12: check scantable indices in all decode_block functions
Add checks to the fast functions used with CODEC_FLAGS2_FAST and move
the check for all other functions to before the invalid memory is
accessed. Fixes https://trac.videolan.org/vlc/ticket/9713 with
CODEC_FLAGS2_FAST.
CC: [email protected]
|
6d93307f8df81808f0dcdbc064b848054a6e83b3
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/6d93307f8df81808f0dcdbc064b848054a6e83b3
|
2014-01-25 21:50:20+01:00
|
avcodec/mpeg12dec: check for overread in mpeg1_fast_decode_block_inter()
No speedloss meassured
Signed-off-by: Michael Niedermayer <[email protected]>
|
0a59055167eea3087a36d9091501d3bb52ed8ebe
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/0a59055167eea3087a36d9091501d3bb52ed8ebe
|
2014-01-24 18:09:16+01:00
|
Avoid a possible overflow when reading Nikon avi files.
Suggested-by: Reimar
|
b7702fafb356b757dcd1b3d1ed4f2f32e4ebe9c1
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/b7702fafb356b757dcd1b3d1ed4f2f32e4ebe9c1
|
2014-01-20 11:40:35+01:00
|
avcodec/pgssubdec: Use av_fast_padded_malloc() for rle buffer
Fixes: use of uninitialized memeory
Fixes: msan_uninit-mem_7fa421d0e222_1765_Girl_With_The_Dragon_Tattoo_2_23_56.mkv
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
1a01dc83434fbdd1f6604c73afc022795bfb4783
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/1a01dc83434fbdd1f6604c73afc022795bfb4783
|
2014-01-15 23:09:22+01:00
|
avcodec/mpegaudiodec_template/mp3on4: check that all channels have been decoded before returnig a frame
Fixes use of uninitialized memory
Fixes: msan_uninit-mem_7f80bf9a259e_5774_id5_1.mp4
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
2545182c294ff6b91ad36a575246788159e39f28
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/2545182c294ff6b91ad36a575246788159e39f28
|
2014-01-14 20:56:08+01:00
|
h264: do not use 422 functions for monochrome
Fixes invalid memory access.
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
CC:[email protected]
|
a03a642d5ceb5f2f7c6ebbf56ff365dfbcdb65eb
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/a03a642d5ceb5f2f7c6ebbf56ff365dfbcdb65eb
|
2014-01-06 08:25:36+01:00
|
matroska: pass the lace size to the matroska_parse_rm_audio
Each lace must be independent according to the specification.
Fix heap-buffer-overflow in matroska_parse_block for
corrupted real media in mkv files.
Stricter check than fc43c19a567aa945398dccb491d972c11ec2a065
CC: [email protected]
|
25a80a931a3829f9d730971dbd269aa39cc273f6
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/25a80a931a3829f9d730971dbd269aa39cc273f6
|
2013-04-03 12:34:38+02:00
|
avformat/oggparseogm: check input size before reading t
Makes no difference in outcome, as the checks on t have no effect
when t was uninitialized
Fixes use of uninitialized memory
Fixes: msan_uninit-mem_7fa2b7b5d97c_3598_anOTHERS_DixX_in_Ogg_Sample.avi
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
0875a9e4fc4cb622758a6b59d4cb07b64f29b8b2
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/0875a9e4fc4cb622758a6b59d4cb07b64f29b8b2
|
2013-12-26 16:56:10+01:00
|
avformat/4xm: shrink packet if it was only partially initialized
Fixes use of uninitialized memory
Fixes: msan_uninit-mem_7f6c76ab7950_4920_dracula.4xm
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
9b195dd5793edb88a72d53cb080c2216e91a5849
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/9b195dd5793edb88a72d53cb080c2216e91a5849
|
2013-12-22 01:48:33+01:00
|
jvdec: Fix memory leak of jv->frames
Signed-off-by: Luca Barbato <[email protected]>
|
e518cb863edc931888ccca6cad86f73ca7430cef
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/e518cb863edc931888ccca6cad86f73ca7430cef
|
2013-12-20 17:44:20+01:00
|
avformat/sierravmd: Check avio_read return value
Fixes use of uninitialized memory
Fixes: msan_uninit-mem_7f82af392dae_1848_HR060606.VMD
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
a165964f3c4b48041b8f053813761490d57c6222
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/a165964f3c4b48041b8f053813761490d57c6222
|
2013-12-20 01:03:19+01:00
|
avcodec/mlpdec: check that streamtype matches the codec
Fixes use of uninitialized memory
Fixes msan_uninit-mem_7f126c8ed1ac_5945_issue1731_nonpublic.mpg
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
a8d702859b8bd17978fb5d8cb1d6acc363031e80
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/a8d702859b8bd17978fb5d8cb1d6acc363031e80
|
2013-12-16 15:04:49+01:00
|
avformat/thp: check fps value during probing
Fixes probetest failure
Signed-off-by: Michael Niedermayer <[email protected]>
|
52268def10f33e36ca1190906c8235f4e91fcf24
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/52268def10f33e36ca1190906c8235f4e91fcf24
|
2013-11-10 02:04:08+01:00
|
avcodec/cabac: support UNCHECKED_BITSTREAM_READER = 0
Fixes overreads in HEVC
Fixes Ticket3070
Also fixed remaining issues from Ticket3075 and Ticket3076
Some lines of code taken from 0c5f839693da2276c2da23400f67a67be4ea0af1:libavcodec/x86/cabac.h
and 0c5f839693da2276c2da23400f67a67be4ea0af1:libavcodec/cabac_functions.h
Signed-off-by: Michael Niedermayer <[email protected]>
|
fa6fa2162b730336fc1d6ee0d547dcc81f4afbad
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/fa6fa2162b730336fc1d6ee0d547dcc81f4afbad
|
2013-10-31 11:13:27+01:00
|
avcodec/sgi: Fix dereferencing uninitialized pointer
This also fixes the code so it decodes raw images correctly again
No release is affected by this
Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
Signed-off-by: Michael Niedermayer <[email protected]>
|
60ea0a5236ceac03b8d3ab3b73bda04d04c17273
|
ffmpeg
|
devign
| 1 |
https://github.com/ffmpeg/ffmpeg
|
https://github.com/ffmpeg/ffmpeg/commit/60ea0a5236ceac03b8d3ab3b73bda04d04c17273
|
2013-10-23 02:49:45+02:00
|
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.