commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
avutil: fix data race in av_get_cpu_flags() Make the one-time initialization in av_get_cpu_flags() thread-safe. The static variables |flags|, |cpuflags_mask|, and |checked| in libavutil/cpu.c are read and written using normal load and store operations. These are considered as data races. The fix is to use atomic load and store operations. Remove the |checked| variable because the invalid value of -1 for |flags| can be used to indicate the same condition. Rename |flags| to |cpu_flags| and move it to file scope. The fix can be verified by running the libavutil/tests/cpu_init.c test program under ThreadSanitizer: ./configure --toolchain=clang-tsan make libavutil/tests/cpu_init libavutil/tests/cpu_init There should be no warnings from ThreadSanitizer. Co-author: Dmitry Vyukov of Google, who suggested the data race fix. Signed-off-by: Wan-Teh Chang <[email protected]>
2170017a1cd033b6f28e16476921022712a522d8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2170017a1cd033b6f28e16476921022712a522d8
2016-12-08 15:53:58-05:00
yuv4mpegdec: fix leaking pkt in yuv4_read_packet Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
e3694478a98bc2cd702b3b3f0bfb19a100da737e
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e3694478a98bc2cd702b3b3f0bfb19a100da737e
2016-12-08 00:26:41+01:00
qsvdec: Fix memory leak Fixes CID1396851.
b6f80b16d1a82463a77352b8756e1cdcaa3a33d0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b6f80b16d1a82463a77352b8756e1cdcaa3a33d0
2016-12-06 13:21:08-08:00
avcodec/flacdec: Fix signed integer overflow in decode_subframe_fixed() Fixes undefined behavior Fixes: 640912-media Found-by: Matt Wolenetz <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
83a75bf6c31b3c0ce2ca7e1426d1f2e3df634239
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/83a75bf6c31b3c0ce2ca7e1426d1f2e3df634239
2016-12-03 17:26:39+01:00
mss2: only use error correction for matching block counts This fixes a heap-buffer-overflow in ff_er_frame_end when decoding mss2 with coded_width/coded_height larger than width/height. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
2566ad98b01538ea589e5ee07b69fc566aadc348
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2566ad98b01538ea589e5ee07b69fc566aadc348
2016-11-25 21:05:03+01:00
libopusdec: default to stereo for invalid number of channels This fixes an out-of-bounds read if avc->channels is 0. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
8c8f543b81aa2b50bb6a6cfd370a0061281492a3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8c8f543b81aa2b50bb6a6cfd370a0061281492a3
2016-11-25 00:36:36+01:00
Revert "apngdec: use side data to pass extradata to the decoder" This reverts commit e0c6b32046f4bab7d34be77dd2f03b2a80c86d39. Said commit changed the behavior of the demuxer and decoder in a non backwards compatible way. Demuxers should make extradata available at init if possible, and send new extradata as side data within a packet if needed. A better fix for the remuxing crash will follow. Signed-off-by: James Almer <[email protected]>
16c429166ddf1736972b6ccce84bd3509ec16a34
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/16c429166ddf1736972b6ccce84bd3509ec16a34
2016-11-18 12:24:28-03:00
icodec: correctly check avio_read return value It can read less than the requested amount, in which case buf contains uninitialized data, causing problems like segmentation faults later on. Also make sure that image->size is positive, so that it can't match a negative error code. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
89eb398c7fc4cb9a15e55bdf2ab6435b5332e377
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/89eb398c7fc4cb9a15e55bdf2ab6435b5332e377
2016-11-10 22:02:49+01:00
proresdec_lgpl: explicitly check coff[3] against slice_data_size The implicit checks via v_data_size and a_data_size don't work in the case '(hdr_size > 7) && !ctx->alpha_info'. This fixes segmentation faults due to invalid reads. This problem was introduced in commit 547c2f002a87f4412a83c23b0d60364be5e7ce58. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
1e33035ee7a8d9fb7a4b8b6cc54842e72b36ed70
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1e33035ee7a8d9fb7a4b8b6cc54842e72b36ed70
2016-11-10 21:00:44+01:00
avcodec/mpegvideo_enc: fix memory leak When the input frames contain side data, it will accumulate endlessly in the coded frame, as av_frame_copy_props will append any new side data. Fixes ticket #5799.
99b823f0a1be42abc0f3a6a0da946c4464db5fb6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/99b823f0a1be42abc0f3a6a0da946c4464db5fb6
2016-09-26 18:21:00+02:00
avcodec/nvenc: fix potantially uninitialized free
a19989cae581817e8857623d3afc447372b1c0e3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a19989cae581817e8857623d3afc447372b1c0e3
2016-08-28 18:58:05+02:00
avcodec/cuvid: Check for non 420 chroma formats - they aren't supported Despite the video parser seeming to correctly handle 422 and 444 chroma formats, the video decoder fails miserably to actually decode frames - even though no errors are ever returned; you just get frames showing unintialized garbage. Signed-off-by: Philip Langdale <[email protected]> Signed-off-by: Timo Rothenpieler <[email protected]>
ee88dcb2b0fefb42b0761ddb105c71daf604d791
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ee88dcb2b0fefb42b0761ddb105c71daf604d791
2016-09-17 14:08:58+02:00
pcx: check that the packet is large enough before reading the header Fixes possible invalid reads. CC: [email protected] Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
221402c1c88b9d12130c6f5834029b535ee0e0c5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/221402c1c88b9d12130c6f5834029b535ee0e0c5
2016-08-18 17:06:46+02:00
lavc/vaapi_encode_h26x: Fix a crash if "." is not the decimal separator. Fixes Debian bugs #831529, #831909, #832964. Signed-off-by: Mark Thompson <[email protected]>
82e53b3cef924f250f928fca6348204e2ace90d8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/82e53b3cef924f250f928fca6348204e2ace90d8
2016-08-05 21:24:54+01:00
avformat/mux: Restore original ts in write_packet on error Restore original timestamps in write_packet() if the actual write operation was not successfull. This allows to pass the same packet to nonblocking muxer repeatedly without corrupting the timestamps. Signed-off-by: Jan Sebechlebsky <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
2fc9a3eb7a8c606bd403dc9fbdb8463144b243cf
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2fc9a3eb7a8c606bd403dc9fbdb8463144b243cf
2016-08-22 12:59:54+02:00
ffmpeg: switch to the new BSF API This commit is initially largely based on commit 4426540 from Anton Khirnov <[email protected]> and two following fixes (80fb19b and fe7b21c) which were previously skipped respectively in 98e3153, c9ee36e, and 7fe7cdc. mpeg4-bsf-unpack-bframes FATE reference is updated because the bsf filter now actually fixes the extradata (mpeg4_unpack_bframes_init() changing one byte is now honored on the output extradata). The FATE references for remove_extra change because the packet flags were wrong and the keyframes weren't marked, causing the bsf relying on these proprieties to not actually work as intended. The following was fixed by James Almer: The filter option arguments are now also parsed correctly. A hack to propagate extradata changed by bitstream filters after the first av_bsf_receive_packet() call is added to maintain the current behavior. This was previously done by av_bitstream_filter_filter() and is needed for the aac_adtstoasc bsf. The exit_on_error was not being checked anymore, and led to an exit error in the last frame of h264_mp4toannexb test. Restoring this behaviour prevents erroring out. The test is still changed as a result due to the badly filtered frame now not being written after the failure. Signed-off-by: Clément Bœsch <[email protected]> Signed-off-by: James Almer <[email protected]>
5ef19590802f000299e418143fc2301e3f43affe
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5ef19590802f000299e418143fc2301e3f43affe
2016-09-24 14:25:53-03:00
avfilter/af_stereowiden: fix read/write past the end of buffer The stereowiden filter uses a buffer, s->buffer[], and a pointer within the buffer, s->write, to implement inter-channel delays. The loop which applies the delayed samples turns out to be faulty. 109 for (n = 0; n < in->nb_samples; n++, src += 2, dst += 2) { 110 const float left = src[0], right = src[1]; 111 float *read = s->write + 2; 112 113 if (read > s->buffer + s->length) 114 read = s->buffer; 115 116 dst[0] = drymix * left - crossfeed * right - feedback * read[1]; 117 dst[1] = drymix * right - crossfeed * left - feedback * read[0]; 118 119 s->write[0] = left; 120 s->write[1] = right; 121 122 if (s->write == s->buffer + s->length) 123 s->write = s->buffer; 124 else 125 s->write += 2; 126 } For one, the buffer gets written past its end in lines 119-120, before the bound check is done in lines 122-123. This can be easily confirmed by valgrind. ==3544== Invalid read of size 4 ==3544== at 0x593B41: filter_frame (af_stereowiden.c:116) ==3544== Address 0xb1b03c4 is 4 bytes after a block of size 7,680 alloc'd ==3544== ==3544== Invalid read of size 4 ==3544== at 0x593B66: filter_frame (af_stereowiden.c:117) ==3544== Address 0xb1b03c0 is 0 bytes after a block of size 7,680 alloc'd ==3544== ==3544== Invalid write of size 4 ==3544== at 0x593B79: filter_frame (af_stereowiden.c:119) ==3544== Address 0xb1b03c0 is 0 bytes after a block of size 7,680 alloc'd ==3544== ==3544== Invalid write of size 4 ==3544== at 0x593B7D: filter_frame (af_stereowiden.c:120) ==3544== Address 0xb1b03c4 is 4 bytes after a block of size 7,680 alloc'd Also, using two separate pointers, s->write and read = s->write + 2, does not seem to be well thought out. To apply the delay of s->buffer[], it is enough to read the delayed samples at the current position within the buffer, and then to store new samples at the same current position. Thus the application of delayed samples can probably be best described with a single pointer s->cur. I also introduce a minor change to ensure that the size of s->buffer[] is always a multiple of 2. Since the delay parameter is a float, it is otherwise possible to trick the code into allocating off-by-one buffer.
906ee4114117fd50a3c7bf4f07fa26dae5922c26
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/906ee4114117fd50a3c7bf4f07fa26dae5922c26
2016-07-30 21:53:25+02:00
libavformat/libopenmpt: Fix memory leak in error path in read_header_openmpt(). Signed-off-by: Jörn Heusipp <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
f1eb6ddcb34f4d27d52d4a0a30269728612c41b0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f1eb6ddcb34f4d27d52d4a0a30269728612c41b0
2016-07-17 16:20:46+02:00
checkasm: vp8.mc: initialize the full src buffer after ec32574209f Fixes "Use of uninitialised value" valgrind warnings in checkasm.
80fbb7becae530167373fe5178966b7d7604306e
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/80fbb7becae530167373fe5178966b7d7604306e
2016-07-13 22:18:52+02:00
mxfdec: check edit_rate also for physical_track Previously only the edit_rate of material_track was checked. If it's negative, it causes assertion failures in av_rescale_rnd. Reviewed-by: Tim Nicholson <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
047bf82c181c1220b3087b37f28445f8b87a7a23
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/047bf82c181c1220b3087b37f28445f8b87a7a23
2015-11-18 23:54:24+01:00
avformat/utils: Fix use of uninitialized variable Fixes CID1361961 Signed-off-by: Michael Niedermayer <[email protected]>
7f5c6ea5110237394a24d249e19ee3a9b829306f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7f5c6ea5110237394a24d249e19ee3a9b829306f
2016-05-26 19:04:46+02:00
avfilter/af_loudnorm: fix crash when ebur128 initialization was not successfull/complete Signed-off-by: Paul B Mahol <[email protected]>
defb960a47f6d8f801168e1c61399f6abfb79ef3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/defb960a47f6d8f801168e1c61399f6abfb79ef3
2016-05-21 19:23:04+02:00
avfilter/delogo: Check that logo area is inside the picture We can only remove the logo if it is inside the picture. We need at least one pixel around the logo area for interpolation. Fixes ticket #5527 (Delogo crash with x=0 and/or y=0). Signed-off-by: Jean Delvare <[email protected]> Reviewed-by: Paul B Mahol <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
aeefe018f847aa46c8d69d1d237a54ef89f58fee
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/aeefe018f847aa46c8d69d1d237a54ef89f58fee
2016-05-10 18:18:47+02:00
avcodec/h264: Check init_get_bits8() for failure Fixes CID1361935 Signed-off-by: Michael Niedermayer <[email protected]>
641dccc2aa5e0bf6b3c06998f9a7f24a5cf725e7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/641dccc2aa5e0bf6b3c06998f9a7f24a5cf725e7
2016-05-19 00:19:52+02:00
avcodec/shorten: if allocation fails reset max_frame_size Otherwise crash happens. Signed-off-by: Paul B Mahol <[email protected]>
ae8a13c560226f96544a07eb736014b3b5abb1d6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ae8a13c560226f96544a07eb736014b3b5abb1d6
2016-04-08 09:59:05+02:00
AAC encoder: fix signed integer overflow Clamp scalefactors by coef2minsf to avoid undefined behavior caused by signed integer overflow. It also avoids clipping of coefficients so it should avoid artifacts as well, on very rare corner cases.
c883da6bf4610ee37848687346f543dfb73de011
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c883da6bf4610ee37848687346f543dfb73de011
2016-03-30 10:05:03-03:00
Move the |die| member of FrameThreadContext to PerThreadContext. This fixes a data race warning by ThreadSanitizer. FrameThreadContext.die is read by all the worker threads but is not protected by any mutex. Move it to PerThreadContext so that each worker thread reads its own copy of |die|, which can then be protected with PerThreadContext.mutex. Signed-off-by: Wan-Teh Chang <[email protected]> Signed-off-by: Ronald S. Bultje <[email protected]>
4845f0720e38c5baab7baad52bfce1451f1c1639
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4845f0720e38c5baab7baad52bfce1451f1c1639
2016-03-01 13:53:47-05:00
avcodec/utils: split side-data in new decode API too The deprecated avcodec_decode_video2() and avcodec_decode_audio4() functions called av_packet_split_side_data() on the input packets. This is required for packets produced by libavformat with the AVFMT_FLAG_KEEP_SIDE_DATA flag unset (which is unfortunately the default). The new API didn't do this yet, although it didn't matter as no decoder supports the new API yet. The emulation layer for the old API calls the old API functions, which took care of the splitting. Add this code to the new API codec entrypoints too, because we shouldn't send essentially corrupted data to decoders.
66dd21d50be14a355e296b769d9d99090c0207f7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/66dd21d50be14a355e296b769d9d99090c0207f7
2016-04-29 10:35:00+02:00
vc1dec: Fix leak on error for array allocations The deinit function in the 'error' section will correctly free everything.
01f0e6a0c9270f1d5bef08459a6f167cf55e0596
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/01f0e6a0c9270f1d5bef08459a6f167cf55e0596
2016-02-25 15:20:53-05:00
libavformat/tcp.c : add send_buffer_size and recv_buffer_size options adds two new options that may be set via the dictionary: - send_buffer_size - recv_buffer_size When present, setsockopt() is used with SO_SNDBUF and SO_RCVBUF to set socket buffer sizes. I chose to make send and receive independent because buffering requirements are often asymmetric. Errors in setting the buffer size mean the socket will use its default, so they are ignored. There is no sanity checking on values, as the kernel/socket layers already impose reasonable limits if asked for something crazy. Rationale for enlarging receive buffers is to reduce susceptibility to intermittent network delays/congestion. I added setting the send buffer for symmetry. Signed-off-by: Michael Niedermayer <[email protected]>
84110f4f7760c4f0a9c3e394447304e7cd2384a3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/84110f4f7760c4f0a9c3e394447304e7cd2384a3
2016-01-22 15:36:30+01:00
swscale/x86/rgb2rgb_template: Do not crash on misaligend stride Fixes Ticket5013 Signed-off-by: Michael Niedermayer <[email protected]>
80bfce35ccd11458e97f68f417fc094c5347070c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/80bfce35ccd11458e97f68f417fc094c5347070c
2015-12-15 02:32:23+01:00
avformat/swfenc: Check frama rate before writing it Fixes assertion failure with ffserver Signed-off-by: Michael Niedermayer <[email protected]>
6ea7dd25c773145b50eed55c2059647bb086aaca
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6ea7dd25c773145b50eed55c2059647bb086aaca
2015-12-17 02:07:41+01:00
avcodec/utils: Fix overflow in get_bit_rates computations Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
15d14ce47cb39b93a80a2c6b8396db81c16934e6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/15d14ce47cb39b93a80a2c6b8396db81c16934e6
2015-12-05 13:20:03+01:00
avformat/smacker: fix integer overflow with pts_inc Fixes: ce19e41f0ef1e52a23edc488faecdb58/asan_heap-oob_2504e97_4202_ffa0df1baed14022b9bfd4f8ac23d0cb.smk Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
7ed47e97297fd5ef473d0cc93f0455adbadaac83
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7ed47e97297fd5ef473d0cc93f0455adbadaac83
2015-12-05 13:20:03+01:00
avutil/timecode: Fix fps check The fps variable is explicitly set to -1 in case of some errors, the check must thus be signed or the code setting it needs to use 0 as error code the type of the field could be changed as well but its in an installed header Fixes: integer overflow Fixes: 9982cc157b1ea90429435640a989122f/asan_generic_3ad004a_3799_22cf198d9cd09928e2d9ad250474fa58.mov Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
b46dcd5209a77254345ae098b83a872634c5591b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b46dcd5209a77254345ae098b83a872634c5591b
2015-12-03 04:09:48+01:00
avformat/dump: Fix integer overflow in av_dump_format() Fixes part of mozilla bug 1229167 Found-by: Tyson Smith Signed-off-by: Michael Niedermayer <[email protected]>
8e7f4520226d2d9ad6a58ad6c32d1455a8b244b2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8e7f4520226d2d9ad6a58ad6c32d1455a8b244b2
2015-12-01 13:26:03+01:00
avcodec/vp3: Clear context on reinitialization failure Fixes null pointer dereference Fixes: 1536b9b096a8f95b742bae9d3d761cc6/signal_sigsegv_294aaed_2039_8d1797aeb823ea43858d0fa45c9eb899.ogv Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
6105b7219a90438deae71b0dc5a034c71ee30fc0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6105b7219a90438deae71b0dc5a034c71ee30fc0
2015-11-28 00:25:08+01:00
ffserver: Replace one malloc(AVStream) by avformat_new_stream() This fixes a null pointer dereference from the recently introduced AVStream->internal Signed-off-by: Michael Niedermayer <[email protected]>
2ec18db75cff03a5cfa0a0f28f22da6866f720d1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2ec18db75cff03a5cfa0a0f28f22da6866f720d1
2015-11-11 21:26:50+01:00
avcodec/ffv1dec: Clear quant_table_count if its invalid Fixes deallocation of corrupted pointer Fixes: 343dfbe142a38b521ed069dc4ea7c03b/signal_sigsegv_421427_4074_ffb11959610278cd40dbc153464aa254.avi No releases affected Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
e04126072e984f8db5db9da9303c89ae01f7d6bb
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e04126072e984f8db5db9da9303c89ae01f7d6bb
2015-11-14 13:23:14+01:00
avformat/segafilm: Only add index entries when the stream exists Fixes null pointer dereference Fixes: cb02dfb163ac833c04cace3d7e35b160/signal_sigsegv_e55c49_6326_8f25619fc86a00b303c57b7778baf70a.cpk Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
183720eb6efedcabe3db8643676e55a4d9d2896d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/183720eb6efedcabe3db8643676e55a4d9d2896d
2015-11-07 14:09:17+01:00
opus: Do not call vector_fmul_scalar on zero samples The x86 variant of this function crashes in that specific case. CC: [email protected]
b8deb7c34f755d5e3eee0b5930c3a6ad2dda96bc
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b8deb7c34f755d5e3eee0b5930c3a6ad2dda96bc
2015-10-28 17:57:07+01:00
avcodec/opusdec: Fix extra samples read index Fixes crash Fixes Ticket4969 part 1 Signed-off-by: Michael Niedermayer <[email protected]>
07225fa74f2cdb29d6d85fd33675539bfdfe9ea5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/07225fa74f2cdb29d6d85fd33675539bfdfe9ea5
2015-10-27 02:37:16+01:00
vp9: fix integer overflow in 10/12bpp DC-only calculation.
342bca7f02fc7c0e9c4adf43d0ab1fab31aac85b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/342bca7f02fc7c0e9c4adf43d0ab1fab31aac85b
2015-09-05 15:50:01-04:00
avformat/hls: Check for av_opt_set_dict() failure Fixes: CID1320426 Signed-off-by: Michael Niedermayer <[email protected]>
4eca1939ef0614d0959fffb93f93d44af6740e8c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4eca1939ef0614d0959fffb93f93d44af6740e8c
2015-09-05 14:28:08+02:00
avcodec/ac3enc: fix undefined negative left shift This should fix the undefined behavior reported in: https://trac.ffmpeg.org/ticket/4727. I can reproduce this at runtime: simply stick in an abort call in asym_quant to check if c < 0 and run FATE. I don't know ac3 so I can't confirm if negative coefficients are intentional, but at the moment they clearly are according to FATE. This resolves the undefined behavior. Tested with FATE. Signed-off-by: Ganesh Ajjanagadde <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
979572365f2133f969f3f49ec6a99cc8739d2eba
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/979572365f2133f969f3f49ec6a99cc8739d2eba
2015-10-10 14:43:22+02:00
avformat/dump: Fix integer overflow in aspect ratio calculation Fixes: unknown_unknown_19e_414_cov_764838672_bellhamlam.mov Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
d1bdaf3fb2c45020f72a378bb64eab1bf136581c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d1bdaf3fb2c45020f72a378bb64eab1bf136581c
2015-09-03 02:50:41+02:00
swresample/resample: speed up Blackman Nuttall filter This may be a slightly surprising optimization, but is actually based on an understanding of how math libraries compute trigonometric functions. Explanation is given here so that future development uses libm more effectively across the codebase. All libm's essentially compute transcendental functions via some kind of polynomial approximation, be it Taylor-Maclaurin or Chebyshev. Correction terms are added via polynomial correction factors when needed to squeeze out the last bits of accuracy. Lookup tables are also inserted strategically. In the case of trigonometric functions, periodicity is exploited via first doing a range reduction to an interval around zero, and then using some polynomial approximation. This range reduction is the most natural way of doing things - else one would need polynomials for ranges in different periods which makes no sense whatsoever. To avoid the need for the range reduction, it is helpful to feed in arguments as close to the origin as possible for the trigonometric functions. In fact, this also makes sense from an accuracy point of view: IEEE floating point has far more resolution for small numbers than big ones. This patch does this for the Blackman-Nuttall filter, and yields a non-negligible speedup. Sample benchmark (x86-64, Haswell, GNU/Linux) test: fate-swr-resample-dblp-2626-44100 old: 18893514 decicycles in build_filter (loop 1000), 256 runs, 0 skips 18599863 decicycles in build_filter (loop 1000), 512 runs, 0 skips 18445574 decicycles in build_filter (loop 1000), 1000 runs, 24 skips new: 16290697 decicycles in build_filter (loop 1000), 256 runs, 0 skips 16267172 decicycles in build_filter (loop 1000), 512 runs, 0 skips 16251105 decicycles in build_filter (loop 1000), 1000 runs, 24 skips Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Ganesh Ajjanagadde <[email protected]>
cf491a925e221122f81873bd041c5c136027e385
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cf491a925e221122f81873bd041c5c136027e385
2015-11-09 18:41:32-05:00
asfdec: remove improper assignement that caused wrong timestamps and remove unneeded variable Sample-Id: https://samples.libav.org/asf-wmv/asf-code-53/movn018.asf Signed-off-by: Anton Khirnov <[email protected]>
33dc1913ab7aaefc991b3e665d1d0b5d0b088672
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/33dc1913ab7aaefc991b3e665d1d0b5d0b088672
2015-07-31 09:10:05+02:00
avformat/wavdec: Check for data_size overflow Signed-off-by: Michael Niedermayer <[email protected]>
f40ec70478648c1e6cde43b8577c3c29380372ee
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f40ec70478648c1e6cde43b8577c3c29380372ee
2015-07-29 13:47:44+02:00
avcodec: Assert on codec->encode2 in encode_audio2 Assert on `avctx->codec->encode2` to avoid a SEGFAULT on the subsequent function call. avcodec_encode_video2() uses a similar assertion. Calling the wrong function on a stream is a serious inconsistency which could at other places be potentially dangerous and exploitable, it is thus safer to stop execution and not continue with such inconsistency after returning an error. Commit-message-extended-by commiter Signed-off-by: Michael Niedermayer <[email protected]>
0c800b27611cadd64f46fd1bbd9dc8bb87fe168b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0c800b27611cadd64f46fd1bbd9dc8bb87fe168b
2015-08-27 17:26:24+02:00
g726: Do not crash on user mistake Properly report the sample rate as invalid CC: [email protected]
355864ef7a9548ee6491a25de1e0650bd983a667
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/355864ef7a9548ee6491a25de1e0650bd983a667
2015-07-11 18:45:44+02:00
hevc_ps: make sure failing to decode an SPS always returns an error Some of the goto err clauses do not set the error code. It seems better to fall back on INVALIDDATA instead of adding it everywhere explicitly.
b9f76d19d81fbc7f088536f966c2d3dc23c34ddc
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b9f76d19d81fbc7f088536f966c2d3dc23c34ddc
2015-07-13 07:49:03+02:00
asfdec: prevent possible memory leak in the asf_read_metadata_obj Signed-off-by: Luca Barbato <[email protected]>
9752d2e6cc9b9e8070ec515db8ed8374683d0856
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9752d2e6cc9b9e8070ec515db8ed8374683d0856
2015-07-03 01:50:09+02:00
swscale/output: fix null pointer dereference in yuv2ya8_2_c() Signed-off-by: Michael Niedermayer <[email protected]>
ab80d3fb3a7595db44fc143c80f8c2a3480fe28d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ab80d3fb3a7595db44fc143c80f8c2a3480fe28d
2015-07-03 23:03:25+02:00
h264: update avctx width/height/pix_fmt when returning frame Inconsistencies between the dimensions/pixel format of avctx and the frame can confuse API users. For example this can crash the demuxing_decoding example. Back up the previous values and restore them, when decoding the next frame. This is necessary, because these can be different between the returned frame and the last decoded frame. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
1189af429211ac650aac730368a6cf5b23756605
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1189af429211ac650aac730368a6cf5b23756605
2015-06-12 21:22:00+02:00
mpjpegdec: fix memory leak in probe function Signed-off-by: James Almer <[email protected]>
34d278f9838e355b3b2c7a9c0f77d7fcaf37ce49
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/34d278f9838e355b3b2c7a9c0f77d7fcaf37ce49
2015-06-08 16:03:31-03:00
avcodec/libstagefright: Check for pthread_create() failure Signed-off-by: Michael Niedermayer <[email protected]>
4c4c3d5d5abb8192b42d6d18241079929e7317e1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4c4c3d5d5abb8192b42d6d18241079929e7317e1
2015-06-07 21:20:21+02:00
lavc/qdrw: Do not fail decoding valid Quickdraw images.
209e91cbc4e1c4feaa3b7c2671b864b77874eff8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/209e91cbc4e1c4feaa3b7c2671b864b77874eff8
2015-05-21 01:05:13+02:00
avcodec/jpeglsdec: assert that overflows end at exactly x=w If that ever was untrue, there would be a bug in the code Signed-off-by: Michael Niedermayer <[email protected]>
6d3f17838db93647f026338cb63103ce57f5d0e2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6d3f17838db93647f026338cb63103ce57f5d0e2
2015-05-13 15:48:17+02:00
id3v2: catch avio_read errors in check_tag Since len is an unsigned int, the comparison is currently treated as unsigned and thus ignores all errors from avio_read. Thus cast len to int, which is unproblematic, because at that point len is between 0 and 4. This fixes 'Conditional jump or move depends on uninitialised value' valgrind warnings in is_tag. Signed-off-by: Andreas Cadhalpun <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
0382c94f13b4b20456b7259e90b170dc020419b8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0382c94f13b4b20456b7259e90b170dc020419b8
2015-05-11 20:21:48+02:00
vp9: remove another optimization branch in iadst16 which causes overflows. See sample vp90-2-14-resize-fp-tiles-16-8.webm from the vp9 test vector set to reproduce the issue.
3de13d5212b6a0ff146dc0b50e34ee7dbc822eef
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/3de13d5212b6a0ff146dc0b50e34ee7dbc822eef
2015-04-24 16:54:31+02:00
libxvid: Make codec use the init-cleanup flag and mark it as init-thread-safe This takes care of memory leaks on init error.
18db1286b04557aa2d2df7efbcb65ae825d5a469
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/18db1286b04557aa2d2df7efbcb65ae825d5a469
2015-04-24 14:55:11+01:00
avconv: Avoid theoretical NULL dereferences Bug-Id: CID 1292519 Signed-off-by: Luca Barbato <[email protected]>
aa1a1b2496cf3ca817e78e27bd0262a50adb91a1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/aa1a1b2496cf3ca817e78e27bd0262a50adb91a1
2015-04-04 19:32:10+02:00
lavc/smvjpegdec: Avoid null dereference and return meaningful error codes Signed-off-by: Michael Niedermayer <[email protected]>
5b02e84bdb15e97fda0fcbe592a98a98bbd0034a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5b02e84bdb15e97fda0fcbe592a98a98bbd0034a
2015-04-01 19:33:45+02:00
webmdashenc: Support for live stream manifests This patch adds support for creating DASH manifests for WebM Live Streams. It also updates the documentation and adds a fate test to verify the behavior of the new muxer flag. Signed-off-by: Vignesh Venkatasubramanian <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
26f2e2f3f73f0da088e6765291d0839ebb077b03
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/26f2e2f3f73f0da088e6765291d0839ebb077b03
2015-04-05 02:08:55+02:00
webp: ensure that each transform is only used once According to the WebP Lossless Bitstream Specification "each transform is allowed to be used only once". If a transform is more than once this can lead to memory corruption. Signed-off-by: Andreas Cadhalpun <[email protected]> Signed-off-by: Anton Khirnov <[email protected]>
30e6abd1a8cc4fd5daf2e23ad2e768862c39e975
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/30e6abd1a8cc4fd5daf2e23ad2e768862c39e975
2015-03-19 21:03:13+01:00
utvideodec: Handle slice_height being zero Fixes out of array accesses. CC: [email protected] Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Bug-Id: CVE-2014-9604 Signed-off-by: Vittorio Giovara <[email protected]> Signed-off-by: Luca Barbato <[email protected]>
0ce3a0f9d9523a9bcad4c6d451ca5bbd7a4f420d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0ce3a0f9d9523a9bcad4c6d451ca5bbd7a4f420d
2015-03-09 00:51:15+01:00
rtpdec_asf: Don't free the payload context in the .close function This was missed in bb4a310bb. This fixes a double free on close. Signed-off-by: Martin Storsjö <[email protected]>
1dc19729e92a96620000e09eba8e58cb458c9486
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1dc19729e92a96620000e09eba8e58cb458c9486
2015-03-04 13:12:09+02:00
avcodec/libtheoraenc: Check for av_fast_realloc() failure Fixes CID1257799 Signed-off-by: Michael Niedermayer <[email protected]>
67d4d5f5db060fece8cc8e925f18f0a1c48813c6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/67d4d5f5db060fece8cc8e925f18f0a1c48813c6
2015-02-22 02:18:35+01:00
wtvdec: fix integer overflow resulting in errors with large files This fixes a regression in 9fbc613f0df1628e7e78bca791fa8833846f8210 Signed-off-by: Michael Niedermayer <[email protected]>
62e95757d5749e578b2abd407e3009d15a85adb0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/62e95757d5749e578b2abd407e3009d15a85adb0
2015-02-20 18:38:36+01:00
avcodec/mjpegdec: Skip blocks which are outside the visible area Fixes out of array accesses Fixes: ffmpeg_mjpeg_crash.avi Found-by: Thomas Lindroth <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
08509c8f86626815a3e9e68d600d1aacbb8df4bf
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/08509c8f86626815a3e9e68d600d1aacbb8df4bf
2015-02-11 03:53:30+01:00
avcodec/vp3: pass correct context to av_log() Fixes null pointer dereference Fixes: signal_sigsegv_000_3694_cov_1050071691_theora.mkv Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
d41b66a1a216956964077b383e6e234d518f17d7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d41b66a1a216956964077b383e6e234d518f17d7
2015-02-06 00:34:09+01:00
mpegvideo_enc: Draw edges on input for non-multiple of 16 resolutions This improves motion estimation and avoids using uninitialized data for resolutions that aren't a multiple of 16. Prior to d2a25c40, the edges used to be initialized so that encoding was deterministic, but after that commit it started using uninitialized data (for non multiple of 16 resolutions). CC: [email protected] Signed-off-by: Martin Storsjö <[email protected]>
2a06c2a03e1205aaeede5af850b9271752ddd4cf
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2a06c2a03e1205aaeede5af850b9271752ddd4cf
2015-01-23 15:05:49+02:00
mov: Fix negative size calculation in mov_read_default(). The previous code assumed if an atom was marked with a 64-bit size extension, it actually had that data available. The new code verfies there's enough data in the atom for this to be done. Failure to verify causes total_size > atom.size which will result in negative size calculations later on. Found-by: Paul Mehta <[email protected]> Signed-off-by: Dale Curtis <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
3ebd76a9c57558e284e94da367dd23b435e6a6d0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/3ebd76a9c57558e284e94da367dd23b435e6a6d0
2015-01-06 05:23:45+01:00
libavformat: Check for malloc failures in avformat_new_stream CC: [email protected] Signed-off-by: Martin Storsjö <[email protected]>
9f810a9b374e0ff8e2a19fd8a7347afe2933e229
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/9f810a9b374e0ff8e2a19fd8a7347afe2933e229
2015-01-04 20:04:36+02:00
avcodec/ljpegenc: Check for av_malloc_array() failure Signed-off-by: Michael Niedermayer <[email protected]>
bd12aa2bc597f08409bede6d4c710eddf4d7c142
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/bd12aa2bc597f08409bede6d4c710eddf4d7c142
2015-01-03 21:25:26+01:00
avcodec/vp3: Fix offset handling Fixes use of uninitialized memory Signed-off-by: Michael Niedermayer <[email protected]>
c3e6a55956fd4a8b59c8c7a52a64af24dfed7a5a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c3e6a55956fd4a8b59c8c7a52a64af24dfed7a5a
2014-12-19 20:53:53+01:00
lavu/dict: check for malloc failures Signed-off-by: Michael Niedermayer <[email protected]>
a963fdb0ea3fa6772ff8464838cd217a6369abfe
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a963fdb0ea3fa6772ff8464838cd217a6369abfe
2014-12-12 23:40:50+01:00
lavc/avpacket: check for malloc failure Signed-off-by: Michael Niedermayer <[email protected]>
ce35a61399cd495fb3d0e8a2f0a18d9d729440e7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ce35a61399cd495fb3d0e8a2f0a18d9d729440e7
2014-12-12 19:31:29+01:00
avformat/rmdec: Check for overflow in ff_rm_read_mdpr_codecdata() Signed-off-by: Michael Niedermayer <[email protected]>
03abf55f252945c70f4a79eaf4d609cee4d98710
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/03abf55f252945c70f4a79eaf4d609cee4d98710
2014-12-06 00:49:23+01:00
lavc/options: don't copy priv context when it is not AVOption object This prevents potential crash when opt API is used without a class. Signed-off-by: Lukasz Marek <[email protected]>
53b2809f2c1b942adf4d876ac446ef97f812ac0c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/53b2809f2c1b942adf4d876ac446ef97f812ac0c
2014-12-06 00:05:18+01:00
avcodec/pngdec: fix mem leak in init() Signed-off-by: Michael Niedermayer <[email protected]>
6e9b060e4f0c24d2689bebd7fc03e52d75da25b2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6e9b060e4f0c24d2689bebd7fc03e52d75da25b2
2014-12-04 00:30:54+01:00
lavu: fix memory leaks by using a mutex instead of atomics The buffer pool has to atomically add and remove entries from the linked list of available buffers. This was done by removing the entire list with a CAS operation, working on it, and then setting it back again (using a retry-loop in case another thread was doing the same thing). This could effectively cause memory leaks: while a thread was working on the buffer list, other threads would allocate new buffers, increasing the pool's total size. There was no real leak, but since these extra buffers were not needed, but not free'd either (except when the buffer pool was destroyed), this had the same effects as a real leak. For some reason, growth was exponential, and could easily kill the process due to OOM in real-world uses. Fix this by using a mutex to protect the list operations. The fancy way atomics remove the whole list to work on it is not needed anymore, which also avoids the situation which was causing the leak. Signed-off-by: Anton Khirnov <[email protected]>
fbd6c97f9ca858140df16dd07200ea0d4bdc1a83
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fbd6c97f9ca858140df16dd07200ea0d4bdc1a83
2014-11-27 13:36:00+01:00
avformat/jacosubdec: Cleanup when avpriv_bprint_to_extradata() fails Fixes memleaks Fixes: asan_heap-oob_4d2250_814_cov_2745172097_JACOsub_capability_tester.jss Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
8cd80b5fcbfaefdb92faa8f3ed0b7f5651f38481
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8cd80b5fcbfaefdb92faa8f3ed0b7f5651f38481
2014-11-25 15:20:54+01:00
aacsbr: always initialize max_qmf_subbands Fixes a wordly warning from clang -Wsometimes-uninitialized.
208f3abb917757743313da0da714e525e03159d2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/208f3abb917757743313da0da714e525e03159d2
2014-11-24 01:30:15+00:00
libtwolame: prevent a NULL pointer dereference CC: [email protected] Bug-Id: CID 1250330 / CID 1250335
a42d5c861fea8d18d997c6ba3f4a1d8aa95a288b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a42d5c861fea8d18d997c6ba3f4a1d8aa95a288b
2014-11-21 12:27:07+00:00
lavfi/showspectrum: fix crash in case of negative linesize Signed-off-by: Paul B Mahol <[email protected]>
32d464121959389bd266abe232896da09bbf2bd5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/32d464121959389bd266abe232896da09bbf2bd5
2013-04-29 19:27:15+00:00
Fix initialisers in dct-test.c. Silences a warning when running fate on unusual platforms: libavcodec/dct-test.c:101:21: warning: missing braces around initializer [-Wmissing-braces] libavcodec/dct-test.c:101:21: warning: (near initialization for 'fdct_tab_arch[0]') [-Wmissing-braces] libavcodec/dct-test.c:102:21: warning: missing braces around initializer [-Wmissing-braces] libavcodec/dct-test.c:102:21: warning: (near initialization for 'idct_tab_arch[0]') [-Wmissing-braces]
392b4b663c450f5522f7c1442da91f7647db6bf0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/392b4b663c450f5522f7c1442da91f7647db6bf0
2014-10-16 12:01:26+02:00
avcodec/cinepak: fix integer underflow Fixes out of array access Fixes: asan_heap-oob_4da0ba_6_asan_heap-oob_4da0ba_241_cvid_crash.avi Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
e7e5114c506957f40aafd794e06de1a7e341e9d5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e7e5114c506957f40aafd794e06de1a7e341e9d5
2014-10-03 19:34:28+02:00
avcodec/snow: check coeffs for validity Fixes deadlock Fixes integer overflow Fixes Ticket 3892 Signed-off-by: Michael Niedermayer <[email protected]>
596636a474ab201badaae269f3a2cef4824b8c1f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/596636a474ab201badaae269f3a2cef4824b8c1f
2014-08-30 02:12:10+02:00
proresenc: Report buffer overflow If the allocated size, despite best efforts, is too small, exit with the appropriate error. CC: [email protected] Signed-off-by: Diego Biurrun <[email protected]> Signed-off-by: Luca Barbato <[email protected]>
58b68e4fdea22e22178e237bda950b09cc6f363a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/58b68e4fdea22e22178e237bda950b09cc6f363a
2014-08-18 18:51:44+02:00
Fix packet_buffer memory leak in avformat_free_context Signed-off-by: Michael Niedermayer <[email protected]>
609d5db8035c868be034892a33762779a40ab8b9
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/609d5db8035c868be034892a33762779a40ab8b9
2014-08-15 19:20:12+02:00
avcodec/lcldec: initialize encoded correctly Fixes out of array read Fixes: yuv111_no_compr_crash.avi Found-by: Piotr Bandurski <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
6c36b3afe72d1ab635efba36e78c849630ed9ec6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6c36b3afe72d1ab635efba36e78c849630ed9ec6
2014-08-14 15:19:47+02:00
avutil/pixelutils: check for malloc failure Found-by: Daemon404 Signed-off-by: Michael Niedermayer <[email protected]>
6552b0558a15b05c49976b393f2d3123c317df3a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/6552b0558a15b05c49976b393f2d3123c317df3a
2014-08-06 01:45:29+02:00
swresample: check av_opt_set for failure in swr_alloc_set_opts() Signed-off-by: Michael Niedermayer <[email protected]>
f4e814f787d050ac65f507b1304dcdc4ffa56f29
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f4e814f787d050ac65f507b1304dcdc4ffa56f29
2014-08-11 01:34:34+02:00
h264: prevent theoretical infinite loop in SEI parsing Properly address CVE-2011-3946 and parse bitstream as described in the spec. CC: [email protected] Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind
7ab551f9fd9a63586649a7df8790ddaeac55420f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/7ab551f9fd9a63586649a7df8790ddaeac55420f
2014-08-01 13:08:32+01:00
eamad: use the bytestream2 API instead of AV_RL This is safer and possibly fixes invalid reads on truncated data. CC:[email protected]
541427ab4d5b4b6f5a90a687a06decdb78e7bc3c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/541427ab4d5b4b6f5a90a687a06decdb78e7bc3c
2014-07-27 07:10:54+00:00
lavd/v4l2: do not fail when VIDIOC_ENUMSTD returns ENODATA As of September 14 2012, v4l_enumstd() will return ENODATA when a device's std field is set to 0. That is, the device does not have a standard format. In order to properly handle this case, v4l2_set_parameters should catch the ENODATA code and break instead of failing. Below is the v4l2-core commit describing this change. >>commit a5338190efc7cfa8c99a6856342a77d21c9a05cf >>Author: Hans Verkuil <[email protected]> >>Date: Fri Sep 14 06:45:43 2012 -0300 >> >> [media] v4l2-core: tvnorms may be 0 for a given input, handle that case >> >> Currently the core code looks at tvnorms to see whether ENUMSTD >> or G_PARM should be enabled. This is not a good check for drivers >> that support the STD API on one input and the DV Timings API on another. >> In that case tvnorms may be 0. >> Instead check whether s_std is present (for ENUMSTD) or whether g_std or >> current_norm is present for g_parm. >> Also, in the enumstd core function return ENODATA if tvnorms is 0, >> because in that case the current input does not support the STD API >> and ENUMSTD should return ENODATA for that. >> >> Signed-off-by: Hans Verkuil <[email protected]> >> Reviewed-by: Sakari Ailus <[email protected]> >> Signed-off-by: Mauro Carvalho Chehab <[email protected]>
44e95a017c8fa0c3d019cc91c716ba876f931fe7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/44e95a017c8fa0c3d019cc91c716ba876f931fe7
2014-08-18 09:20:00+02:00
oss_audio: use a macro to simplify ioctl() error checking Also add a note about SNDCTL_DSP_GETFMTS which may fail even if OSS is available. Signed-off-by: Timothy Gu <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
69c7aad494683953e833e8622776e3bbcc7921ed
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/69c7aad494683953e833e8622776e3bbcc7921ed
2014-07-19 03:38:31+02:00
avutil/lzo: Fix integer overflow Embargoed-till: 2014-06-27 requested by researcher, but embargo broken by libav today (git and mailing list) Fixes: LMS-2014-06-16-4 Found-by: "Don A. Bailey" <[email protected]> See: ccda51b14c0fcae2fad73a24872dce75a7964996 Signed-off-by: Michael Niedermayer <[email protected]>
d6af26c55c1ea30f85a7d9edbc373f53be1743ee
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d6af26c55c1ea30f85a7d9edbc373f53be1743ee
2014-06-23 14:18:20+02:00