commit_msg
stringlengths
1
24.2k
commit_hash
stringlengths
2
84
project
stringlengths
2
40
source
stringclasses
4 values
labels
int64
0
1
repo_url
stringlengths
26
70
commit_url
stringlengths
74
118
commit_date
stringlengths
25
25
libavformat/mov: Fix memory leak, need to free the chapter tracks array Signed-off-by: Michael Niedermayer <[email protected]>
ac24a8202a6fdfb469af1fa68d537fb2f8d1ba6a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ac24a8202a6fdfb469af1fa68d537fb2f8d1ba6a
2017-04-06 04:05:04+02:00
avcodec/dvdsubdec: Fix runtime error: left shift of 242 by 24 places cannot be represented in type 'int' Fixes: 1080/clusterfuzz-testcase-5353236754071552 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
ce7098b8f2b59c62b5abdb3d74819db75cf67698
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ce7098b8f2b59c62b5abdb3d74819db75cf67698
2017-05-05 04:25:07+02:00
tools/target_dec_fuzzer: Do not attempt to fuzz VDPAU, its not supported Fixes: 1364/clusterfuzz-testcase-minimized-6459843441328128 Fixes: 1392 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
38e79d9d9c94d27fbfa6fc810267eeb785b50b24
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/38e79d9d9c94d27fbfa6fc810267eeb785b50b24
2017-05-06 15:15:14+02:00
avcodec: fix uninitialized variable read This cna happen if the user tries to call the new decode API for subtitles. Fixes CID 1402071.
b4b8ca24f62473528949fe047085eb084364124b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b4b8ca24f62473528949fe047085eb084364124b
2017-03-17 00:29:03+01:00
avcodec/mpeg4videodec: Fix runtime error: signed integer overflow: 134527392 * 16 cannot be represented in type 'int' This checks the sprite delta intermediates for overflow Fixes: 716/clusterfuzz-testcase-4890287480504320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
fab13bbbcdf92da165f1a6be94fbb8f87fac639a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fab13bbbcdf92da165f1a6be94fbb8f87fac639a
2017-03-05 12:01:41+01:00
tools/target_dec_fuzzer: Remove FuzzerInterface.h dependancy The header is not always available in the docker build environment Suggested-by: Kostya Serebryany Signed-off-by: Michael Niedermayer <[email protected]>
550a9c547ec4139ecdfa5889916edb2732bc61c1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/550a9c547ec4139ecdfa5889916edb2732bc61c1
2017-04-25 03:13:00+02:00
avcodec/mpeg4videodec: Check the other 3 sprite points for intermediate overflows This is not necessarily specific to fuzzed files Fixes: Multiple integer overflows Fixes: 656/clusterfuzz-testcase-6463814516080640 Fixes: 658/clusterfuzz-testcase-6691260146384896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
76ba09d18245a2a41dc5f93a60fd00cdf358cb1f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/76ba09d18245a2a41dc5f93a60fd00cdf358cb1f
2017-02-24 00:38:45+01:00
avcodec/avpacket: Check metadata key in av_packet_unpack_dictionary() Fixes timeout Fixes: 501/clusterfuzz-testcase-5672752870588416 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
2c00b373024054e0779ef67fc54b763d624db3e8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2c00b373024054e0779ef67fc54b763d624db3e8
2017-03-01 14:07:33+01:00
avcodec/pngdec: Fix runtime error: left shift of 152 by 24 places cannot be represented in type 'int' Fixes: 666/clusterfuzz-testcase-6581447227867136 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
310d2af319d9113263f75e94f5a1b211c05260b5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/310d2af319d9113263f75e94f5a1b211c05260b5
2017-02-25 01:43:53+01:00
mpegaudiodec_template: fix leaking fdsp for mp3on4float Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
783b350b2e49d06030b30ee9b7e1aa5825e4a5a5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/783b350b2e49d06030b30ee9b7e1aa5825e4a5a5
2017-02-17 01:45:19+01:00
avcodec/eac3dec: Fix runtime error: left shift of negative value Fixes: 610/clusterfuzz-testcase-4831030085156864 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
067485b673f6ac4b1207d6fc975d1fd968edc68e
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/067485b673f6ac4b1207d6fc975d1fd968edc68e
2017-02-19 21:49:03+01:00
mov: Rework stsc index validation In order to avoid potential integer overflow change the comparison and make sure to use the same unsigned type for both elements.
53ea595eec984e3109310e8bb7ff4b5786d91057
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/53ea595eec984e3109310e8bb7ff4b5786d91057
2017-02-10 16:26:16-05:00
avcodec/mpeg4videodec: Fix runtime error: shift exponent -2 is negative Fixes: 612/clusterfuzz-testcase-4707817137111040 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
aa2b75263e17651187b1475551a02aa2f4ff65fe
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/aa2b75263e17651187b1475551a02aa2f4ff65fe
2017-02-19 21:49:03+01:00
omadec: fix overflows during bit rate calculation Signed-off-by: Andreas Cadhalpun <[email protected]>
d74c471a39db2919a0e1db9666df725cbcb83d86
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d74c471a39db2919a0e1db9666df725cbcb83d86
2017-01-06 19:58:42+01:00
avformat: fix overflows during bit rate calculation The bit_rate field has type int64_t since commit 7404f3bdb90e6a5dcb59bc0a091e2c5c038e557d. Reviewed-by: Paul B Mahol <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
ad5807f8aa883bee5431186dc1f24c5435d722d3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ad5807f8aa883bee5431186dc1f24c5435d722d3
2016-12-14 01:06:55+01:00
tools/target_dec_fuzzer: Only audio uses the return value to decode packets in pieces, correct the code to match that Fixes: Timeout Fixes: 483/fuzz-0-ffmpeg_VIDEO_AV_CODEC_ID_H263I_fuzzer Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
8bdba1092f50d52e0af90f425811302ec91152f8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8bdba1092f50d52e0af90f425811302ec91152f8
2017-01-31 23:43:41+01:00
avcodec/wavpack: Treat the first block coding too many channels as an error Fixes memleak Fixes: 236/8aeebc9ca49b91bf71c114dcefac56c154a3a563 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/targets/ffmpeg Signed-off-by: Michael Niedermayer <[email protected]>
c188f358aaee5800af5a5d699dd657cef3fb43a6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c188f358aaee5800af5a5d699dd657cef3fb43a6
2016-12-07 13:16:32+01:00
avidec: fix leaking extradata Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
2c908f22c2af0775a6ffe3466aad174a0ace00dd
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2c908f22c2af0775a6ffe3466aad174a0ace00dd
2016-11-30 02:22:50+01:00
mjpegdec: Check return values of functions that may fail
212c6a1d70df011b6f2a2aa02f7677503287bd00
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/212c6a1d70df011b6f2a2aa02f7677503287bd00
2016-11-29 13:13:35+01:00
avformat/utils: Check start/end before computing duration in update_stream_timings() Fixes undefined behavior Fixes: 637428.ogg Found-by: Matt Wolenetz <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
90da187f1d334422477886a19eca3c1da29c59a7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/90da187f1d334422477886a19eca3c1da29c59a7
2016-12-03 03:59:13+01:00
swresample/soxr: fix invalid use of linear_interp give very bad quality for soxr resampler. linear_interp is intended for using linear interpolation between filter bank so quality will be better. i guess this is misunderstood as 'do not use filter bank, but directly interpolate linearly between samples'. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Muhammad Faiz <[email protected]>
da34e4e13238b755bb0e6ebf549015797d9b4467
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/da34e4e13238b755bb0e6ebf549015797d9b4467
2016-11-26 05:52:24+07:00
lavf/fifo: fix undefined behaviour in deinit when destroying mutex Reviewed-by: Jan Sebechlebsky <[email protected]> Signed-off-by: Marton Balint <[email protected]>
e20e9b9033b75fac32a4a3bc2cdd3fcc3cedb33a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e20e9b9033b75fac32a4a3bc2cdd3fcc3cedb33a
2016-11-13 03:10:36+01:00
interplayacm: increase bitstream buffer size by AV_INPUT_BUFFER_PADDING_SIZE This fixes out-of-bounds reads by the bitstream reader. Reviewed-by: Paul B Mahol <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
60178e78f2fe9a7bfb9da0abc985835e2ebfd2f1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/60178e78f2fe9a7bfb9da0abc985835e2ebfd2f1
2016-11-01 00:39:06+01:00
westwood_aud: prevent division by zero Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
bc7e128a6e8e2a79d0ff7cab5e8a799b3ea042ea
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/bc7e128a6e8e2a79d0ff7cab5e8a799b3ea042ea
2016-10-17 20:42:18+02:00
avformat/avidec: Check nb_streams in read_gab2_sub() Fixes null pointer dereference Fixes: 1/null_point.avi Found-by: 连一汉 <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
2679ad4773aa356e7c3da5c68bc81f02a194617f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2679ad4773aa356e7c3da5c68bc81f02a194617f
2016-09-28 16:46:24+02:00
avcodec/mlz: Check output chars before using it Fixes hypothetical integer overflow Signed-off-by: Michael Niedermayer <[email protected]>
47ffcddaefeeb5c994af2ae2a09f34a91bc1ed28
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/47ffcddaefeeb5c994af2ae2a09f34a91bc1ed28
2016-09-21 16:28:14+02:00
avformat/avidec: Remove ancient assert This assert can with crafted files fail, a warning is already printed for this case. Fixes assertion failure Fixes:1/assert.avi Found-by: 连一汉 <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
14bac7e00d72eac687612d9b125e585011a56d4f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/14bac7e00d72eac687612d9b125e585011a56d4f
2016-09-28 16:46:24+02:00
avcodec/alsdec: Fix raw_mantissa memleak Fixes: 0cee183a09bff5aa5108429717c35a4d/asan_heap-oob_1d99eca_3702_9ef60e80de79082a778d3d9ce8ef3b64.mp4 Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
f2192e0f0399c7cbb1ac3f311726f2fa9cdf1dba
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f2192e0f0399c7cbb1ac3f311726f2fa9cdf1dba
2016-09-08 20:31:15+02:00
af_hdcd: fix possible integer overflow Signed-off-by: Burt P <[email protected]>
91be2ad756d658acc24fec5bc46c1775158d28b0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/91be2ad756d658acc24fec5bc46c1775158d28b0
2016-09-07 10:53:41-05:00
avfilter/avf_showspectrum: do not use uninitialized memory
b3c6e89d4871d4f6afada96d8695e0ef08c6f02b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b3c6e89d4871d4f6afada96d8695e0ef08c6f02b
2016-08-18 18:40:00+02:00
avcodec/diracdec: Check numx/y Fixes division by 0 Fixes: 60261c4469ba3e11059890fb2832a515/asan_generic_135e694_2790_beb94eaa0aeb7d11c0437375a8964a99.drc Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
a31e08fa1aa5c5f0518b8af850f28eb945268e66
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a31e08fa1aa5c5f0518b8af850f28eb945268e66
2016-08-20 19:36:01+02:00
lavc/avpacket: Fix undefined behaviour, do not pass a null pointer to memcpy(). Fixes ticket #5857.
c54eef46f990722ed65fd1ad1da3d0fc50806eb5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c54eef46f990722ed65fd1ad1da3d0fc50806eb5
2016-09-22 08:37:46+02:00
cuvid: Implement flush to support seeking in media players Right now, if we attempt to use cuvid in a media player and then try to seek, the decoder will happily pass out whatever frames were already in flight before the seek. There is both the output queue in our code and some number of frames within the cuvid decoder that need to be accounted for. cuvid doesn't support flush, so our only choice is to do a brute-force re-creation of the decoder, which also implies re-creating the parser, but this is fine. The only subtlty is that there is sanity check code in decoder initialisation that wants to make sure the HWContextFrame hasn't already been initialised. This is a fair check to do at the beginning but not after a flush, so it has to be made conditional. Signed-off-by: Philip Langdale <[email protected]> Signed-off-by: Timo Rothenpieler <[email protected]>
86910b15c9ee2d5c377b137ec653c044572f94ff
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/86910b15c9ee2d5c377b137ec653c044572f94ff
2016-09-06 21:52:05+02:00
avcodec/cfhd: clear idwt_buf on allocation This avoids use of uninitialized variables and might make bugs in general easier to reproduce Signed-off-by: Michael Niedermayer <[email protected]>
5fb6e39dd1c3add4dc5bd7c7f0d8100d5aadad46
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5fb6e39dd1c3add4dc5bd7c7f0d8100d5aadad46
2016-06-05 15:41:50+02:00
avfilter/vf_fieldhint: Reorder operation to prevent hypothetical integer overflow Fixes CID1355110 Signed-off-by: Michael Niedermayer <[email protected]>
be96ebdcd795c0d5acd229251eea97f3c4bf6095
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/be96ebdcd795c0d5acd229251eea97f3c4bf6095
2016-05-29 19:00:15+02:00
avformat/movenc: Avoid integer overflow Fixes: CID1361947 Signed-off-by: Michael Niedermayer <[email protected]>
17d320800b70a78f4e90cd96564154e829db8b8d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/17d320800b70a78f4e90cd96564154e829db8b8d
2016-05-29 03:56:23+02:00
avformat/utils: avoid overflow in compute_chapters_end() with huge durations Fixes: usan_granule_overflow Found-by: Thomas Guilbert <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
c1ed78a591f68f3c81eded0bfaac313937ffa3b6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c1ed78a591f68f3c81eded0bfaac313937ffa3b6
2016-05-29 00:25:21+02:00
avfilter/avf_ahistogram: raise minimum acmax to 1 If acmax can be 0 then it could result in a division by 0 Fixes CID1351345 Reviewed-by: Paul B Mahol <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
e7c5dbb4d117591f4ec19a57828155d2009f9bd6
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e7c5dbb4d117591f4ec19a57828155d2009f9bd6
2016-05-21 18:47:25+02:00
avformat/oggparseopus: Check that granule pos is within the supported range Larger values would imply file durations of astronomic proportions and cause overflows Fixes integer overflow Fixes: usan_int64_overflow Found-by: Thomas Guilbert <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
8efaee3710baa87af40556a622bf2d96a27c6425
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8efaee3710baa87af40556a622bf2d96a27c6425
2016-05-11 00:32:32+02:00
avcodec/motion_est: Attempt to fix "short data segment overflowed" on IA64 This decreases the MV related encoding table sizes This should have little effect on real world video encoding performance Signed-off-by: Michael Niedermayer <[email protected]>
d7c75a5db0cf3674e1a5c3e51ac024ef2ef6f09f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d7c75a5db0cf3674e1a5c3e51ac024ef2ef6f09f
2016-01-16 00:56:05+01:00
rtmpdh: Initialize gcrypt before using it Either disabling or init'ing secure memory is required after the use of gcry_check_version. From a look at the functions rtmpdh uses, I noticed none require the use of secure memory, so we disable it [1][2]. This resolves some errors returned by rtmpdh code with uninitialized gcrypt, especifically: Fatal: failed to create the RNG lock: Invalid argument FATAL: failed to acquire the FSM lock in libgrypt: Invalid argument Version "1.5.4" was arbitrarily chosen. An older version probably works as well, but I couldn't compile older versions to test on my machine. [1] https://gnupg.org/documentation/manuals/gcrypt/Initializing-the-library.html [2] https://www.gnupg.org/documentation/manuals/gcrypt/Controlling-the-library.html Signed-off-by: Ricardo Constantino <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
d50b5d547f4070678c88aa095b5292c872e2c1dc
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/d50b5d547f4070678c88aa095b5292c872e2c1dc
2016-01-12 00:56:02+01:00
avformat/mxfenc: Fix integer overflow in length computation Fixes: CID1341577 Signed-off-by: Michael Niedermayer <[email protected]>
537e901fe66c326f78e916ee9393830ee366131d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/537e901fe66c326f78e916ee9393830ee366131d
2015-12-13 02:11:56+01:00
avcodec/wmaprodec: Fix overflow of cutoff Fixes: 129ca3e28d73af7b1e24a9d4118e7a2d/signal_sigabrt_7ffff6ae7cc9_836_762b310fc3ef6087bd7771e5d8e90b9b.asf Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
0c56f8303e676556ea09bfac73d881c6c9057259
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0c56f8303e676556ea09bfac73d881c6c9057259
2015-12-05 13:20:03+01:00
mpegtsenc: Fix off-by-one in indexing into Opus channel mapping arrays Fixes, CID1338323, CID1338324 Signed-off-by: Michael Niedermayer <[email protected]>
eb3628d87f67b35e8dd354a466028e93bdd7f9c0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/eb3628d87f67b35e8dd354a466028e93bdd7f9c0
2015-12-04 02:35:20+01:00
avcodec/h264_direct: Check CO-POCs before use Fixes harmless integer overflow Fixes mozilla bug 1230286 Found-by: Tyson Smith Signed-off-by: Michael Niedermayer <[email protected]>
77a644e6fa4aaeb2c26cfaa0e8ec3b19829b8d88
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/77a644e6fa4aaeb2c26cfaa0e8ec3b19829b8d88
2015-12-04 01:55:11+01:00
dcadec: Do not check for overreads in auxiliary data The auxiliary data length field is not reliable, and incorrect overread errors could be returned for valid, real-world bitstreams. Signed-off-by: Luca Barbato <[email protected]>
c12c085be7e86880924249e5cb3f898e45dee134
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c12c085be7e86880924249e5cb3f898e45dee134
2015-11-23 11:32:32+01:00
opusdec: Don't run vector_fmul_scalar on zero length arrays Fixes crashes on fuzzed files Fixes Ticket4969 part2 Signed-off-by: Michael Niedermayer <[email protected]>
b3e5f15b95f04a35821f63f6fd89ddd60f666a59
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b3e5f15b95f04a35821f63f6fd89ddd60f666a59
2015-10-27 02:45:40+01:00
vf_psnr/ssim: don't crash if stats_file is NULL.
0c7b44a01c1564ef681d51a5ed37d3908558143b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0c7b44a01c1564ef681d51a5ed37d3908558143b
2015-10-23 06:38:30-04:00
rtmpproto: Write correct flv packet sizes at the end of packets In one case it was written as zero, one case left it uninitialized, missed the 11 bytes for the flv header. Signed-off-by: Luca Barbato <[email protected]>
e55376a1fd5abebbb0a082aa20739d58c2260a37
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e55376a1fd5abebbb0a082aa20739d58c2260a37
2015-10-14 14:35:33+02:00
doc/resampler, swresample/options: use proper capitalization Proper names should be capitalized in all user facing API as far as possible. The option names themselves have not been changed since: 1. We consistently keep option names in lower case. 2. Changing them would break existing scripts. 3. I suspect that we want to be similar to Sox and its relevant options. The converse is also true: improper names should not be capitalized generally. Signed-off-by: Ganesh Ajjanagadde <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
f3fc103c6a8ed8e7056052c54508470eede46566
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f3fc103c6a8ed8e7056052c54508470eede46566
2015-10-10 20:49:54+02:00
mmaldec: be more tolerant against MMAL not returning decoded output In some situations, MMAL won't return a decoded frame for certain input frames. This can happen if a frame fails to decode, or if a packet does not actually contain a complete frame. In these situations, we would deadlock (or actually timeout) waiting for an expected output frame, which is not ideal. On the other hand, there are situations where we definitely have to block to avoid deadlocks. (This mess is a consequence of trying to map MMAL's asynchronous and flexible dataflow to libavcodec, which is more static and rigid.) Solve this by doing a blocking wait only if the amount of buffered data is too big. The whole purpose of the blocking wait is to avoid excessive buffering of input data, so we can skip it if it appears to be low. The consequence is that libavcodec can gracefully return no frame to the API user. We want to track the number of full packets to make our heuristic work. But MMAL buffers are fixed-size, requiring splitting large packets. This is why the previous commit is needed. We use the ..._FRAME_END flag to remember packet boundaries, but MMAL does not preserve these buffer flags when returning buffers to the user. Signed-off-by: Luca Barbato <[email protected]>
39f01e346cab464ef6c0d4ec58cc13b7123e60d8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/39f01e346cab464ef6c0d4ec58cc13b7123e60d8
2015-10-04 19:34:04+02:00
libavformat/hlsenc: Use of uninitialized memory unlinking old files Fixes ticket#4900 Signed-off-by: DHE <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
76e3f8242d607ac0394b7894196f83f8d02ce5ca
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/76e3f8242d607ac0394b7894196f83f8d02ce5ca
2015-10-03 23:52:19+02:00
vp9: fix type of iadst4_1d intermediates. Fixes integer overflows for extreme coefficient values in 10/12bpp content.
ef8740d8e58dc45950887305307206d27ad413fb
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ef8740d8e58dc45950887305307206d27ad413fb
2015-09-05 15:50:01-04:00
avfilter/delogo: Fix show option when band is small The code assumed that the outermost interpolated pixels were always in the fuzzy area defined by the band option. However if the band value is small, there may be no fuzzy area on a given plane. In that case, option show did not work, no rectangle was drawn (or only on the luma plane, depending on the band value and chroma plane subsampling factors.) Fix the problem by not making any assumption on where the outermost interpolated pixels will be. The new code was verified to produce the same result as the original code when the band value is not small. Signed-off-by: Jean Delvare <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
3e5b02bdb8e5b35564893e6618c217e4c949c743
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/3e5b02bdb8e5b35564893e6618c217e4c949c743
2015-09-28 13:23:47+02:00
fate: increase fuzziness for the AAC encoder prediction test Fails on x86_64 using ICC 13.1. Signed-off-by: Rostislav Pehlivanov <[email protected]>
10d16647ccb5e66bf57d082c69e0dcb1b65ba746
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/10d16647ccb5e66bf57d082c69e0dcb1b65ba746
2015-09-02 08:36:53+01:00
avcodec/vp3: Check init_get_bits8() for failure Fixes CID1322316 Signed-off-by: Michael Niedermayer <[email protected]>
cbd3cd8eb2de2280d83da5ee875c35581b46a3a3
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cbd3cd8eb2de2280d83da5ee875c35581b46a3a3
2015-09-04 01:13:05+02:00
movenc: Check that frag_info entries exist in mov_write_sidx_tag This fixes crashes with pathological cases when trying to write a sidx index (via the -movflags faststart option, in combination with fragmenting options), when no fragments actually have been written. (This is possible if the empty_moov flag isn't used, so that all actual packet data is written in the moov/mdat pair, and no moof/mdat pairs have been written.) In these pathological cases, no sidx should be written at all. Signed-off-by: Martin Storsjö <[email protected]>
8e34089e265a6b01e1e3301e8864439d26793753
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/8e34089e265a6b01e1e3301e8864439d26793753
2015-08-10 09:46:03+03:00
ffmpeg: Print sub2video: rectangle coordinates in case of overflows Signed-off-by: Michael Niedermayer <[email protected]>
0ac83047f67bb56406c66d4ca664d3c0cb07c2f2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0ac83047f67bb56406c66d4ca664d3c0cb07c2f2
2015-08-15 17:41:48+02:00
movtextdec: Fix memory leaks by freeing mem allocs correctly Initialize m->count_f to 0 at the correct place to free memory allocs properly. Signed-off-by: Niklesh <[email protected]>
ecc806a224d7191f59d81ff5c4004084cf032c71
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ecc806a224d7191f59d81ff5c4004084cf032c71
2015-08-07 16:33:31-07:00
checkasm: Give macro a body to avoid potential unexpected syntax issues
cb33f8d0f48b1e9d642ca1cbea142dcbedd08a27
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cb33f8d0f48b1e9d642ca1cbea142dcbedd08a27
2015-07-18 01:06:44+02:00
lavu/libm: add erf hack and make dynaudnorm available everywhere Source code is from Boost: http://www.boost.org/doc/libs/1_46_1/boost/math/special_functions/erf.hpp with appropriate modifications for FFmpeg. Tested on interval -6 to 6 (beyond which it saturates), +/-NAN, +/-INFINITY under -fsanitize=undefined on clang to test for possible undefined behavior. This function turns out to actually be essentially as accurate and faster than the libm (GNU/BSD's/Mac OS X), and I can think of 3 reasons why upstream does not use this: 1. They are not aware of it. 2. They are concerned about licensing - this applies especially to GNU libm. 3. They do not know and/or appreciate the benefits of rational approximations over polynomial approximations. Boost uses them to great effect, see e.g swr/resample for bessel derived from them, which is also similarly superior to libm variants. First, performance. sample benchmark (clang -O3, Haswell, GNU/Linux): 3e8 values evenly spaced from 0 to 6 time (libm): ./test 13.39s user 0.00s system 100% cpu 13.376 total time (boost based): ./test 9.20s user 0.00s system 100% cpu 9.190 total Second, accuracy. 1e8 eval pts from 0 to 6 maxdiff (absolute): 2.2204460492503131e-16 occuring at point where libm erf is correctly rounded, this is not. Illustration of superior rounding of this function: arg : 0.83999999999999997 erf : 0.76514271145499457 boost : 0.76514271145499446 real : 0.76514271145499446 i.e libm is actually incorrectly rounded. Note that this is clear from: https://github.com/JuliaLang/openlibm/blob/master/src/s_erf.c (the Sun implementation used by both BSD and GNU libm's), where only 1 ulp is guaranteed. Reasons it is not easy/worthwhile to create a "correctly rounded" variant of this function (i.e 0.5ulp): 1. Upstream libm's don't do it anyway, so we can't guarantee this unless we force this implementation on all platforms. This is not easy, as the linker would complain unless measures are taken. 2. Nothing in FFmpeg cares or can care about such things, due to the above and FFmpeg's nature. 3. Creating a correctly rounded function will in practice need some use of long double/fma. long double, although C89/C90, unfortunately has problems on ppc. This needs fixing of toolchain flags/configure. In any case this will be slower for miniscule gain. Reviewed-by: James Almer <[email protected]> Signed-off-by: Ganesh Ajjanagadde <[email protected]>
dd68cde28a44bbf5307d29ee6cb8ebd14985dea5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/dd68cde28a44bbf5307d29ee6cb8ebd14985dea5
2015-12-21 09:03:11-08:00
swscale/utils: Clear pix buffers Fixes use of uninitialized memory Fixes: a96874b9466b6edc660a519c7ad47977_signal_sigsegv_7ffff713351a_744_nc_sample.avi with memlimit 2147483648 Found-by: Samuel Groß, Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
a5d44d5c220e12ca0cb7a4eceb0f74759cb13111
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a5d44d5c220e12ca0cb7a4eceb0f74759cb13111
2015-07-15 20:06:34+02:00
ffmpeg: Fix crash with ost->last_frame allocation failure Fixes: 1013dbde2c360d939cc2dfc33e4f275c_signal_sigsegv_a0500f_45_320vp3.nsv with memlimit of 536870912 Found-by: Samuel Groß, Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
fd4c87fa3becaf8a6c480db915daf51e297b76c5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/fd4c87fa3becaf8a6c480db915daf51e297b76c5
2015-07-14 13:03:35+02:00
avcodec/sanm: Reset sizes in destroy_buffers() Fixes crash in 1288a2fe8e9ae6b00ca40e089d08ca65_signal_sigsegv_7ffff71426a7_354_accident.san with allocation limit 65536 Found-by: Samuel Groß, Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
39bbdebb1ed8eb9c9b0cd6db85afde6ba89d86e4
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/39bbdebb1ed8eb9c9b0cd6db85afde6ba89d86e4
2015-07-13 16:06:37+02:00
avcodec/utils: Fix potential overflow in overallocation code Signed-off-by: Michael Niedermayer <[email protected]>
bc976e5793004c9e4bdedf160852db9bc8b2dcaf
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/bc976e5793004c9e4bdedf160852db9bc8b2dcaf
2015-07-11 22:46:44+02:00
avcodec/mss2: Fix integer overflow This also simplifies the code Fixes: signal_sigabrt_7ffff6ac8cc9_2943_cov_3588637614_mss2_speech.wmv Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
ce81e47c911fcff4f006b3b14b40a396eaa77696
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ce81e47c911fcff4f006b3b14b40a396eaa77696
2015-07-01 20:30:48+02:00
api-flac-test: Fix the bug of comparing zero bytes Add check for linesize. Signed-off-by: Michael Niedermayer <[email protected]>
86fb20324690a80f763b7de6d78749c17ad3f482
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/86fb20324690a80f763b7de6d78749c17ad3f482
2015-06-28 01:05:59+02:00
imc: add required padding for GetBitContext buffer Fixes stack buffer overflow errors detected by address sanitizer in fate-imc. CC: [email protected]
210921722bf828b3b895ebcbc34374e6c4452c6f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/210921722bf828b3b895ebcbc34374e6c4452c6f
2015-06-09 10:07:04+02:00
mpjpgdec: free AVIOContext leak on early probe fail
caf7be30b11288c498fae67be4741bfbf083d977
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/caf7be30b11288c498fae67be4741bfbf083d977
2015-06-08 13:55:26+02:00
avcodec/exr: fix crash caused by merge Various header informations need to be reset when decoding next frame. Regression since: 95582b5c Fixes ticket #4597. Signed-off-by: Paul B Mahol <[email protected]>
a03b69478b7f1c0c31e53acb0cf392917c0f967a
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a03b69478b7f1c0c31e53acb0cf392917c0f967a
2015-06-06 16:02:19+00:00
avcodec/mpegvideo: Use av_memdup() for allocating thread_context Also check for allocation failure Signed-off-by: Michael Niedermayer <[email protected]>
46428ea332d8afa3f598d6a9d660716a4f90da6d
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/46428ea332d8afa3f598d6a9d660716a4f90da6d
2015-06-06 22:47:50+02:00
libopenjpegenc: add NULL check for img before accessing it If opj_image_create fails to allocate an image it returns NULL, which causes a segmentation fault at 'img->x0 = 0'. Reviewed-by: Michael Niedermayer <[email protected]> Signed-off-by: Andreas Cadhalpun <[email protected]>
1577526b47439f33a999339efdec5d624b70e1da
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1577526b47439f33a999339efdec5d624b70e1da
2015-06-02 22:40:58+02:00
avfilter/x86/vf_fspp: Fix invalid combination of opcode and operands Signed-off-by: Michael Niedermayer <[email protected]>
5bc2c395273e020fc255a644196f0fc7c8e5ed83
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/5bc2c395273e020fc255a644196f0fc7c8e5ed83
2015-05-26 01:43:47+02:00
diracdec: prevent overflow in data_unit_size check buf_idx + data_unit_size can overflow, causing the '> buf_size' check to wrongly fail. This causes a segmentation fault. Signed-off-by: Andreas Cadhalpun <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
984f50deb2d48f6844d65e10991b996a6d29e87c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/984f50deb2d48f6844d65e10991b996a6d29e87c
2015-05-05 21:52:31+02:00
libx264: Make codec use the init-cleanup flag and mark it as init-thread-safe This takes care of memory leaks on init error.
eae7338e1592f4a398b7c3cb9d1ac854b7a44ff8
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/eae7338e1592f4a398b7c3cb9d1ac854b7a44ff8
2015-04-24 14:55:11+01:00
vp9: use aligned size to write segmentation map into cache. The unaligned size is not handled in setctx_2d(), causing edges of images to have improper segmentation prediction, which causes visual artifacts at image edges a few frames later.
ed45edb2f6fe0af577b6d09665763c6cb479a0a5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/ed45edb2f6fe0af577b6d09665763c6cb479a0a5
2015-04-24 16:54:31+02:00
bink: check vst->index_entries before using it This fixes a NULL pointer dereference if vst->duration is 0. The problem was introduced in commit 0588acaf. Signed-off-by: Andreas Cadhalpun <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
86d00ede4f9acb02690a0615490173648e1d933c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/86d00ede4f9acb02690a0615490173648e1d933c
2015-04-22 20:22:19+02:00
webmdashenc: Add better error handling Return appropriate error codes and propagate the error codes from helper functions to the outer calls. Also fix a potential leak in call to av_realloc. Signed-off-by: Vignesh Venkatasubramanian <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
1c37848f9029985d1271da9a0d161c2ebf0aca81
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1c37848f9029985d1271da9a0d161c2ebf0aca81
2015-04-17 04:48:29+02:00
avfilter/drawtext: fix frame mem leak Signed-off-by: Ivan Efimov <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
2051b401cc7e9ec9051c7f575d639944a9869b67
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/2051b401cc7e9ec9051c7f575d639944a9869b67
2015-04-14 12:04:52+02:00
avformat/rtpdec_asf: Fix potential pointer overflow Signed-off-by: Michael Niedermayer <[email protected]>
445a02b1ec5ea94d28ea2503a3ae0272fcff0e12
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/445a02b1ec5ea94d28ea2503a3ae0272fcff0e12
2015-04-12 17:41:23+02:00
libavformat: Handle error return from ff_listen_bind Handle error return from ff_listen_bind without leaking file descriptors. Signed-off-by: Anders Nystrom <[email protected]> Signed-off-by: Luca Barbato <[email protected]>
27852f2f1dec3749ea79883b70484c841169f747
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/27852f2f1dec3749ea79883b70484c841169f747
2015-04-09 14:32:37+02:00
avcodec/vc1dec: Check buf2 for malloc failure Signed-off-by: Michael Niedermayer <[email protected]>
a66dcfeedc68c080965cf78e1e0694967acef5af
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/a66dcfeedc68c080965cf78e1e0694967acef5af
2015-04-06 15:06:42+02:00
avformat/mpegts: Fix potential pointer overflows Signed-off-by: Michael Niedermayer <[email protected]>
1b3b018aa4e43d7bf87df5cdf28c69a9ad5a6cbc
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/1b3b018aa4e43d7bf87df5cdf28c69a9ad5a6cbc
2015-03-16 22:37:46+01:00
avcodec/dvbsub_parser: Fix potential pointer overflows Signed-off-by: Michael Niedermayer <[email protected]>
de41d5372faa4ad7ad439e71975fc6f4ea0c0efc
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/de41d5372faa4ad7ad439e71975fc6f4ea0c0efc
2015-03-15 20:26:08+01:00
flv: Validate and reject unsupported codecs And provide a more informative message in case of failure. CC: [email protected]
e767c9e8f2eaa116b61b8b6881b401b54bd320f5
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/e767c9e8f2eaa116b61b8b6881b401b54bd320f5
2015-03-04 18:28:40+01:00
avformat/vqf: Use 64bit for ret to avoid overflow Signed-off-by: Michael Niedermayer <[email protected]>
cb08687180683a755d0fe9d425280d0e4d1e6db2
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/cb08687180683a755d0fe9d425280d0e4d1e6db2
2015-02-20 21:00:57+01:00
avformat/dss: Check sscanf() return value in dss_read_metadata_date() Fixes writing uninitialized values into metadata without error in case parsing fails Signed-off-by: Michael Niedermayer <[email protected]>
b2bbe8298ba5416f26ffadb43f9e75997ec02f7f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/b2bbe8298ba5416f26ffadb43f9e75997ec02f7f
2015-02-19 22:10:47+01:00
avformat/rpl: check av_get_packet() for failure Also make ret signed as it should be from start. Signed-off-by: Paul B Mahol <[email protected]>
f968166439e4d4fc9f352ea20b8922d42ca5c7b1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/f968166439e4d4fc9f352ea20b8922d42ca5c7b1
2015-02-06 16:07:16+00:00
avformat/rtpdec_hevc: Fix 2 "may be used uninitialized in this function" warnings Signed-off-by: Michael Niedermayer <[email protected]>
4adf75cade6905f33baeeaca559013467dc7d1ae
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/4adf75cade6905f33baeeaca559013467dc7d1ae
2015-01-17 20:40:21+01:00
avformat/img2dec: check w/h in dpx_probe Fixes probetest failure Signed-off-by: Michael Niedermayer <[email protected]>
41ee459e88093a0b7ae13b8539ed9ccd0ebd0f0b
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/41ee459e88093a0b7ae13b8539ed9ccd0ebd0f0b
2014-12-21 23:32:57+01:00
tiff: set the correct return value when check_size() fails Only one instance affected and solved as other occurences.
10d4c5e55e5b23e165aa4c7723073ebe2c2e7da0
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/10d4c5e55e5b23e165aa4c7723073ebe2c2e7da0
2014-12-15 15:46:34+01:00
aaccoder: Implement Perceptual Noise Substitution for AAC This commit implements the perceptual noise substitution AAC extension. This is a proof of concept implementation, and as such, is not enabled by default. This is the fourth revision of this patch, made after some problems were noted out. Any changes made since the previous revisions have been indicated. In order to extend the encoder to use an additional codebook, the array holding each codebook has been modified with two additional entries - 13 for the NOISE_BT codebook and 12 which has a placeholder function. The cost system was modified to skip the 12th entry using an array to map the input and outputs it has. It also does not accept using the 13th codebook for any band which is not marked as containing noise, thereby restricting its ability to arbitrarily choose it for bands. The use of arrays allows the system to be easily extended to allow for intensity stereo encoding, which uses additional codebooks. The 12th entry in the codebook function array points to a function which stops the execution of the program by calling an assert with an always 'false' argument. It was pointed out in an email discussion with Claudio Freire that having a 'NULL' entry can result in unexpected behaviour and could be used as a security hole. There is no danger of this function being called during encoding due to the codebook maps introduced. Another change from version 1 of the patch is the addition of an argument to the encoder, '-aac_pns' to enable and disable the PNS. This currently defaults to disable the PNS, as it is experimental. The switch will be removed in the future, when the algorithm to select noise bands has been improved. The current algorithm simply compares the energy to the threshold (multiplied by a constant) to determine noise, however the FFPsyBand structure contains other useful figures to determine which bands carry noise more accurately. Some of the sample files provided triggered an assertion when the parameter to tune the threshold was set to a value of '2.2'. Claudio Freire reported the problem's source could be in the range of the scalefactor indices for noise and advised to measure the minimal index and clip anything above the maximum allowed value. This has been implemented and all the files which used to trigger the asserion now encode without error. The third revision of the problem also removes unneded variabes and comparisons. All of them were redundant and were of little use for when the PNS implementation would be extended. The fourth revision moved the clipping of the noise scalefactors outside the second loop of the two-loop algorithm in order to prevent their redundant calculations. Also, freq_mult has been changed to a float variable due to the fact that rounding errors can prove to be a problem at low frequencies. Considerations were taken whether the entire expression could be evaluated inside the expression , but in the end it was decided that it would be for the best if just the type of the variable were to change. Claudio Freire reported the two problems. There is no change of functionality (except for low sampling frequencies) so the spectral demonstrations at the end of this commit's message were not updated. Finally, the way energy values are converted to scalefactor indices has changed since the first commit, as per the suggestion of Claudio Freire. This may still have some drawbacks, but unlike the first commit it works without having redundant offsets and outputs what the decoder expects to have, in terms of the ranges of the scalefactor indices. Some spectral comparisons: https://trac.ffmpeg.org/attachment/wiki/Encode/AAC/Original.png (original), https://trac.ffmpeg.org/attachment/wiki/Encode/AAC/PNS_NO.png (encoded without PNS), https://trac.ffmpeg.org/attachment/wiki/Encode/AAC/PNS1.2.png (encoded with PNS, const = 1.2), https://trac.ffmpeg.org/attachment/wiki/Encode/AAC/Difference1.png (spectral difference). The constant is the value which multiplies the threshold when it gets compared to the energy, larger values means more noise will be substituded by PNS values. Example when const = 2.2: https://trac.ffmpeg.org/attachment/wiki/Encode/AAC/PNS_2.2.png Reviewed-by: Claudio Freire <[email protected]> Signed-off-by: Michael Niedermayer <[email protected]>
c5d4f87e81111427c0952278ec247fa8ab1e6e52
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/c5d4f87e81111427c0952278ec247fa8ab1e6e52
2015-04-15 19:59:44+02:00
lavc/options: fix leaks in avcodec_free_context Signed-off-by: Lukasz Marek <[email protected]>
345cfd04d093d9fdec81ea3531e73b1f5c1b6a6c
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/345cfd04d093d9fdec81ea3531e73b1f5c1b6a6c
2014-11-26 23:32:33+01:00
avcodec/diracdec: Use 64bit in calculation of codeblock coordinates Fixes integer overflow Fixes out of array read Fixes: asan_heap-oob_107866c_42_041.drc Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
526886e6069636a918c8c04db17e864e3d8151c1
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/526886e6069636a918c8c04db17e864e3d8151c1
2014-10-28 01:25:28+01:00
roqaudio: Always use the frame buffer on flush Prevent NULL dereference. CC: [email protected] Bug-Id: CID 703669 Signed-off-by: Vittorio Giovara <[email protected]>
55b59fab880a9fcdd30f97c5170af282087ac4f7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/55b59fab880a9fcdd30f97c5170af282087ac4f7
2014-11-24 01:30:15+00:00
flac_picture: prevent a possible out of bound write At "mimetype[len] = 0;" mimetype is a 64 element array and len might be equal to or greater than that. CC: [email protected] Bug-Id: CID 1061055
0b66fb4505e0bb43de3797f63f3290f0188d67cc
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0b66fb4505e0bb43de3797f63f3290f0188d67cc
2014-10-24 23:42:53+01:00
nutdec: Prevent a memory corruption Chapters do not have an event_flags field. Bug-Id: CID 1231990
96bfb677478514db73d1b63b4213c97ad4269e8f
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/96bfb677478514db73d1b63b4213c97ad4269e8f
2014-10-20 10:47:03+01:00
rtmp: Always call rtmp_close() on rtmp_open() failure Prevent possible memory leaks. Connect to nginx and request a non-existent resource to trigger the issue. CC: [email protected] Signed-off-by: Michael Niedermayer <[email protected]> Signed-off-by: Uwe L. Korn <[email protected]> Signed-off-by: Luca Barbato <[email protected]>
0034314a69e76a53534a74cceef865cfcb7b42cc
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/0034314a69e76a53534a74cceef865cfcb7b42cc
2014-10-18 17:37:11+02:00
avfilter: Properly check for failed format query Signed-off-by: Derek Buitenhuis <[email protected]>
23c9ebffb5e2e9a525d19a8b9c31879ec7012fc9
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/23c9ebffb5e2e9a525d19a8b9c31879ec7012fc9
2014-10-02 12:22:49+01:00
avformat/mxfdec: Fix memleak of primer_packs Fixes: asan_static-oob_87d116_10_201.mxf Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <[email protected]>
aae4f5108d04041bb264a9c547f05c4f0d18c9c7
ffmpeg
devign
1
https://github.com/ffmpeg/ffmpeg
https://github.com/ffmpeg/ffmpeg/commit/aae4f5108d04041bb264a9c547f05c4f0d18c9c7
2014-10-15 06:08:28+02:00