Datasets:

---

miesnerjacob

/

github-issues

like 0

[]

[]

[ "Requested changes made and new PR submitted here: https://github.com/huggingface/datasets/pull/1580 " ]

[]

[]

[ "Hi @lhoestq, thanks for the review. I will have a look and update it accordingly.", "Strange error message :-)\r\n\r\n```\r\n> tf_context = tf.python.context.context() # eager mode context\r\nE AttributeError: module 'tensorflow' has no attribute 'python'\r\n```\r\n" ]

[]

[]

[ "made suggested changes and a new PR created here : https://github.com/huggingface/datasets/pull/1597" ]

[]

[]

[]

[]

[]

[]

[]

[]

[ "Hi @iliemihai, it looks like this PR holds changes from your previous PR #1493 .\r\nWould you mind removing them from the branch please ?", "@SBrandeis I am sorry. Yes I will remove them. Thank you :D ", "Hi @lhoestq @SBrandeis @iliemihai\r\n\r\nIs this still in progress or can I take over this one?\r\n\r\nThanks,\r\nGunjan", "Hi,\r\nWhile trying to add this dataset, I found some potential issues. \r\nThe homepage mentioned is : https://github.com/katakonst/sentiment-analysis-tensorflow/tree/master/datasets/ro/, where the dataset is different from the URLs: https://raw.githubusercontent.com/dumitrescustefan/Romanian-Transformers/examples/examples/sentiment_analysis/ro/train.csv. It is unclear which dataset is \"correct\". I checked the total examples (train+test) in both places and they do not match.", "We should use the data from dumitrescustefan and set the homepage to his repo IMO, since he's first author of the paper of the dataset.", "Hi @lhoestq,\r\n\r\nCool, I'll get working on it.\r\n\r\nThanks", "Hi @lhoestq, \r\n\r\nThis PR can be closed.", "Closing in favor of #2011 \r\nThanks again for adding it !" ]

[]

[]

[ "Thank you :)" ]

[]

[]

[]

[]

[]

[ "merging since the CI is fixed on master" ]

[]

[]

[]

[]

[]

[]

[]

[]

[ "Thank you very much for your review @lewtun ! \r\n\r\nI've updated the script metadata, created the README and fixed the two details you commented.\r\n\r\nReady for another review! 🤗 ", "I've updated the task tag as we discussed and also added a couple of lines of code to make sure I include all the available examples.\r\n\r\nThank you again!" ]

[]

[]

[ "@SBrandeis : Thanks for the feedback! Just updated to use context manager for the `open`s and removed the placeholder text from the `README`!", "Great, thanks @ZacharySBrown !\r\nFailing tests seem to be unrelated to your changes, merging the current master branch into yours should fix them.\r\n" ]

[]

[]

[ "I had to create a new PR to fix git errors. See: https://github.com/huggingface/datasets/pull/1525\r\n\r\nI'm closing this PR. " ]

[]

[]

[ "Hi @lhoestq \r\n\r\nI have added the readme as well \r\n\r\nPlease do have a look at it when suitable ", "Chatted with @darshan-gandhi on Slack about parsing examples into a separate text and sentiment field" ]

[]

[]

[ "@yjernite Thank you for your help, generating the dummy data 🤗 Having that all the tests have passed 👍🏻", "merging since the CI is fixed on master", "Thank you :)" ]

[]

[]

[ "Hii please follow me", "thank you" ]

[]

[]

[ "Hii please follow me", "merging since the CI is fixed on master" ]

[]

[]

[ "@lhoestq thanks for the comments! Should be fixed in the latest commit, I assume the CI errors are unrelated. ", "merging since the CI is fixed on master" ]

[]

[]

[ "closing since #1379 got merged" ]

[ { "id": 1935892912, "node_id": "MDU6TGFiZWwxOTM1ODkyOTEy", "url": "https://api.github.com/repos/huggingface/datasets/labels/question", "name": "question", "color": "d876e3", "default": true, "description": "Further information is requested" } ]

[]

[ "In a dataset, labels correspond to the `ClassLabel` feature that has the `names` property that returns string represenation of the integer classes (or `num_classes` to get the number of different classes).", "I think the `features` attribute of the dataset object is what you are looking for:\r\n```\r\n>>> dataset.features\r\n{'sentence1': Value(dtype='string', id=None),\r\n 'sentence2': Value(dtype='string', id=None),\r\n 'label': ClassLabel(num_classes=2, names=['not_equivalent', 'equivalent'], names_file=None, id=None),\r\n 'idx': Value(dtype='int32', id=None)\r\n}\r\n>>> dataset.features[\"label\"].names\r\n['not_equivalent', 'equivalent']\r\n```\r\n\r\nFor reference: https://huggingface.co/docs/datasets/exploring.html" ]

[]

[]

[ "Hi @lhoestq \r\n\r\nI have added the readme file as well, please if you could check it once \r\n\r\nThank you " ]

[]

[]

[]

[]

[]

[ "merging since the CI is fixed on master" ]

[]

[]

[ "Hii please follow me", "merging since the CI is fixed on master" ]

[]

[]

[ "The only CI error comes from \r\n```\r\nFAILED tests/test_file_utils.py::TempSeedTest::test_tensorflow\r\n```\r\n\r\nwhich is not related to your PR and is fixed on master.\r\n\r\nYou can ignore it", "@lhoestq I've made the changes. Please review and merge. \r\n\r\nI have a similar PR https://github.com/huggingface/datasets/pull/1562 for another dataset. I'll incorporate your comment about sorting and reducing dummy dataset size there.", "The CI raises an error `FAILED tests/test_file_utils.py::TempSeedTest::test_tensorflow` but it's not related to this dataset.\r\nThis issue is fixed on master", "You did all the work ;) thanks\r\n\r\nmerging since the CI is fixed on master" ]

[]

[]

[ "Hii please follow me", "Thanks @mariosasko!" ]

[]

[]

[ "Hii please follow me", "The CI error `FAILED tests/test_file_utils.py::TempSeedTest::test_tensorflow` is not related with this dataset and is fixed on master. You can ignore it", "merging since the Ci is fixed on master" ]

[]

[]

[ "@SBrandeis thanks for the review, I applied your suggested changes, but CI is failing now not sure about the error.", "Many thanks @Nilanshrajput !\r\nThe failing tests on CI are not related to your changes, merging master on your branch should fix them :)\r\nIf you're interested in what causes the CI to fail, checkout [this commit](https://github.com/huggingface/datasets/commit/9a0f1e20ca1e783cb14c1ab1cc2f54b0b5b201e8)", "@SBrandeis done!\r\n", "Hello @Nilanshrajput, your PR includes changes from other branches too now (485 files changed)\r\nWould you mind creating another branch from master with your changes and opening a new PR?", "@SBrandeis sorry i messed up the git history, #1587 I opened this new pr! ", "closing in favor of #1587 " ]

[]

[]

[]

[]

[]

[ "Hi @lhoestq @yjernite, requesting you to review this for any changes needed. Thanks! :)", "Hi @lhoestq , I have updated the PR" ]

[]

[]

[ "Changed the pre-processing based on the comments raised in [PR-1482](https://github.com/huggingface/datasets/pull/1482).The below command is passing in my local environment:\r\n\r\n`python datasets-cli test datasets/covid_qa_ucsd/ --save_infos --all_configs --data_dir ~/Downloads/Medical-Dialogue-Dataset/CovidDailogue/`\r\n\r\n" ]

[]

[]

[ "Better will be if you close this PR and make a fresh PR", "Feel free to ping me if you also have questions about the dummy data", "also it looks like this PR includes changes about dummy_data.zip files in the ./datasets//un_pc folder. Can you remove them ?", "Thanks for all the advice @lhoestq. I've implemented the changes you kindly highlighted and have made sure the scripts pass all the test. I've also marked this as ready for review as I believe it's in a good place to be merged now.", "Great suggestion I fixed the dummy data and the file paths." ]

[]

[]

[ "Hi @lhoestq @yjernite, requesting you to review this for any changes needed. Thanks! :)" ]

[]

[]

[ "@lhoestq thanks for the comments! Should be fixed in the latest commit, I assume the CI errors are unrelated." ]

[]

[]

[]

[]

[]

[]

[]

[]

[ "made suggested changes and created a PR here: https://github.com/huggingface/datasets/pull/1598" ]

[]

[]

[]

[]

[]

[ "merging since the CI is fixed on master" ]

[]

[]

[ "merging since the CI is fixed on master" ]

[]

[]

[ "Thanks for the PR @iliemihai . \r\n\r\nFew comments - \r\n\r\nCan you run - \r\n`python datasets-cli dummy_data ./datasets/ronec --auto_generate` to generate dummy data.\r\n\r\nAlso, before committing files run : \r\n`make style`\r\n`flake8 datasets`\r\nthen you can add and commit files.", "> Thanks for the PR @iliemihai .\r\n> \r\n> Few comments -\r\n> \r\n> Can you run -\r\n> `python datasets-cli dummy_data ./datasets/ronec --auto_generate` to generate dummy data.\r\n> \r\n> Also, before committing files run :\r\n> `make style`\r\n> `flake8 datasets`\r\n> then you can add and commit files.\r\n\r\nSorry, forgot to generate dummy data. I will do it now :D", "Awesome, good job @iliemihai !\r\nI think the PR is ready to merge.\r\n@lhoestq would you mind double-checking this ?", "Had to regenerate the dummy data since I just found out they were empty files" ]

[]

[]

[ "merging since the CI is fixed on master" ]

[]

[]

[ "merging since the Ci is fixed on master" ]

[]

[]

[ "merging since the CI is fixed on master" ]

[]

[]

[ "Thanks for the PR @MisbahKhan789 !\r\n\r\nFew comments to help you along (I'm NOT a maintainer, just offering help to unblock the process) :-\r\n - Could you re-run `make style` and fix the errors related to code quality specific to your dataset in the `datasets/fake_news_english` folder?\r\n(These seem to show errors that need manual fixes on running `flake8 datasets/fake_news_english`)\r\n- Please run the local tests and check if they pass\r\n`RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_<your-dataset-name>`\r\n `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<your-dataset-name>`\r\n(If not, you may have to regenerate the dummy data and the `dataset_infos.json` files)\r\n\r\n", "Hii please follow me", "> Thanks for the PR @MisbahKhan789 !\r\n> \r\n> Few comments to help you along (I'm NOT a maintainer, just offering help to unblock the process) :-\r\n> \r\n> * Could you re-run `make style` and fix the errors related to code quality specific to your dataset in the `datasets/fake_news_english` folder?\r\n> (These seem to show errors that need manual fixes on running `flake8 datasets/fake_news_english`)\r\n> * Please run the local tests and check if they pass\r\n> `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_real_dataset_<your-dataset-name>`\r\n> `RUN_SLOW=1 pytest tests/test_dataset_common.py::LocalDatasetTest::test_load_dataset_all_configs_<your-dataset-name>`\r\n> (If not, you may have to regenerate the dummy data and the `dataset_infos.json` files)\r\n\r\nHey Bharat, thanks for the reply. I actually submitted a new PR with the changes that are required :)\r\n" ]

[]

[]

[ "hi @lhoestq, I wanted to push another change to this branch b/c I found a bug in the parsing. I need to swap arg1 and arg2. I tried to git push -u origin nell but it didn't work. So I tried to do git push --force -u origin nell which seems to work, but nothing is happening to this branch. I think this is because it's closed. Do I need to open another PR?\r\n\r\nThe change should be below in _generate_examples:\r\n best_arg1 = row[9]\r\n best_arg2 = row[8]\r\n", "Hi @ontocord !\r\n\r\nYup the easiest thing to do is to open a new PR with a title like \"Fix NELL dataset argument order\". If it's a simple fix we can look at it pretty fast :) " ]

[]

[]

[ "@lhoestq Thank you for suggesting changes. I fixed all the changes you suggested. Can you please review it again? ", "@lhoestq Thank you for reviewing and suggesting changes. I made the requested changes. Can you please review it again?", "Thanks @lhoestq for reviewing it again. I made the required changes. Can you please have a look ?", "merging since the CI is fixed on master" ]

[]

[]

[ "The error `tests/test_file_utils.py::TempSeedTest::test_tensorflow` just appeared because of tensorflow's update.\r\nOnce it's fixed on master we'll be free to merge this one", "It's fixed on master now :) \r\n\r\nmerging this once" ]

[]

[]

[]

[]

[]

[ "> Cool thank you !\r\n> \r\n> I left a few comments\r\n\r\nThank you @lhoestq addressed your comments. Haven't changed the code but I see that tests are failing now. Do I need to rebase or something? ", "The CI error is not related to your dataset and is fixed on master.\r\nYou can ignore it" ]

[]

[]

[ "@lhoestq @abhishekkrthakur what happened here ?\r\n", "@lhoestq everything alright here ?", "@tanmoyio please have patience. @lhoestq has to look at 150+ PRs and it may take time. The PR looks good to me but we wait for his confirmation :) 🤗 " ]

[]

[]

[ "Let me know it that helps !\r\nAlso feel free to ping me if you have other questions or if I can help you.", "Now I am getting an Assertion Error!\r\n\r\n", "All tests have passed. However, PyTest is still failing with the `AssertionError` as before. Also _datasets_info.json_ actually does not seem to provide much info. Please review and let me know what has to be improved.\r\n\r\nThanks!", "[PR-1503](https://github.com/huggingface/datasets/pull/1503) on the COVID dialog dataset from the same University has similar features. I kept it separate because it is only on COVID qa. Also consists of only single files per language. Kindly let me know if it has to be added as two more configurations to this existing dataset itself. If it has to be added, then can I still freeze the file names like in PR-1503?", "It's ok to have them separate" ]

[]

[]

[]

[]

[]

[]

[]

[]

[ "@lhoestq this is now only failing some random windows test (it appears to be somewhere in wnut_17)", "This is a connection error, you can ignore it :) \r\nThe level of activity on the lib is quite overwhelming, it stresses a bit the CI ^^" ]

[]

[]

[ "Also for the `Accuracy` metric the `accuracy_score` method should have its args in the opposite order so `accuracy_score(predictions, references,,,)`.", "Thanks for pointing this out ! 🕵🏻 \r\nPredictions and references should indeed be swapped in the docstring.\r\nHowever, the call to `accuracy_score` should not be changed, it [signature](https://scikit-learn.org/stable/modules/generated/sklearn.metrics.accuracy_score.html#sklearn.metrics.accuracy_score) being:\r\n```\r\nsklearn.metrics.accuracy_score(y_true, y_pred, *, normalize=True, sample_weight=None)\r\n```\r\n\r\nFeel free to open a PR if you want to fix this :)" ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]