Datasets:

---

lewtun

/

github-issues

like 10

[]

[]

[ "This is ok now @lhoestq\r\n\r\nI've included the tweak to `dummy_data` to only use the data transmitted to `_generate_examples` by default (it only do that if it can find at least one path to an existing file in the `gen_kwargs` and this can be unactivated with a flag).\r\n\r\nShould I extract it in another PR or is it ok like this?", "Nice !\r\nCould you add the dummy data generation trick in another PR ?\r\nI think we can also extend it to make it work not only with data files paths but also with data directories (sometimes it's one of the parent directory that is passed to gen_kwargs, not the actual path to the file).\r\nThis will help a lot to make the dummy data lighter !", "This PR can be closed due to #2053 @lhoestq\r\n\r\n" ]

[]

[]

[ "@lhoestq looks like a lot of files were updated... shall I create a new PR?", "Hi @chaitnayabasava ! you can try rebasing and see if that fixes the number of files changed, otherwise please do open a new PR with only the relevant files and close this one :) ", "Created a new PR #1230.\r\nclosing this one :)" ]

[]

[]

[ "looks like this PR includes changes about many files other than the ones related to xitsonga NER\r\n\r\ncould you create another branch and another PR please ?" ]

[]

[]

[ "the `ms_terms` formatting CI fails is fixed on master", "merging since the CI is fixed on master" ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[ "Sorry @lhoestq for the trouble, sometime I forget to change the names :/", "> Sorry @lhoestq for the trouble, sometime I forget to change the names :/\r\n\r\nhaha it's ok ;)" ]

[]

[]

[ "Thanks ! could you regenerate the dataset_infos.json file ?\r\n\r\n```\r\ndatasets-cli test ./datasets/mrqa --save_infos --all_configs --ignore_verifications\r\n```\r\n\r\nalso cc @VictorSanh ", "Oooops, good catch @jimmycode ", "> Thanks ! could you regenerate the dataset_infos.json file ?\r\n> \r\n> ```\r\n> datasets-cli test ./datasets/mrqa --save_infos --all_configs --ignore_verifications\r\n> ```\r\n> \r\n> also cc @VictorSanh\r\n\r\nUpdated the `dataset_infos.json` file." ]

[]

[]

[ "Thanks for the review. \r\nCheers!", "Hi @hfawaz, this week we are doing the 🤗 `datasets` sprint (see some details [here](https://discuss.huggingface.co/t/open-to-the-community-one-week-team-effort-to-reach-v2-0-of-hf-datasets-library/2176)).\r\n\r\nNothing more to do on your side but it means that if you register on the thread I linked above, you can have some goodies for the present dataset that you have already added (and a special goodie if you want to spend more time and add 2 other datasets as well).\r\n\r\nIf you want to join, just tell me (or post on the thread on the HuggingFace forum: https://discuss.huggingface.co/t/open-to-the-community-one-week-team-effort-to-reach-v2-0-of-hf-datasets-library/2176)", "Hello @thomwolf \r\nThanks for the feedback and for this invitation, indeed I would be glad to join you guys (you can add me). \r\nI will see if I have the time to implement a couple of datasets. \r\nCheers! ", "@hfawaz invited you to the slack with your uha email.\r\n\r\nCheck your spam folder if you can't find the invitation :)", "Oh thanks, but can you invite me on my gmail: [email protected] \r\nUHA is my old organization, I haven't had the time to update my online profiles yet.\r\nThank you " ]

[]

[]

[ "good catch !" ]

[]

[]

[]

[]

[]

[]

[]

[]

[ "too ugly, I'll make a clean one" ]

[]

[]

[]

[]

[]

[ "Thanks for reporting !\r\n\r\nIndeed this is a keyword in the library that is used to encode/decode features to a python dictionary that we can save/load to json.\r\nWe can probably change `_type` to something that is less likely to collide with user feature names.\r\nIn this case we would want something backward compatible though.\r\n\r\nFeel free to try a fix and open a PR, and to ping me if I can help :) " ]

[]

[]

[]

[]

[]

[]

[]

[]

[ "thanks ! can you also regenerate the dataset_infos.json file please ?" ]

[]

[]

[]

[]

[]

[ "looks like this PR includes changes in many files than the ones for xquad_r, could you create a new branch and a new PR ?", "Sure, I will close this then.\r\n" ]

[]

[]

[]

[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" } ]

[]

[ "Hey, I think this is great idea. Any plan to integrate kaggle private datasets loading to `datasets`?" ]

[ { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" } ]

[ { "login": "SBrandeis", "id": 33657802, "node_id": "MDQ6VXNlcjMzNjU3ODAy", "avatar_url": "https://avatars.githubusercontent.com/u/33657802?v=4", "gravatar_id": "", "url": "https://api.github.com/users/SBrandeis", "html_url": "https://github.com/SBrandeis", "followers_url": "https://api.github.com/users/SBrandeis/followers", "following_url": "https://api.github.com/users/SBrandeis/following{/other_user}", "gists_url": "https://api.github.com/users/SBrandeis/gists{/gist_id}", "starred_url": "https://api.github.com/users/SBrandeis/starred{/owner}{/repo}", "subscriptions_url": "https://api.github.com/users/SBrandeis/subscriptions", "organizations_url": "https://api.github.com/users/SBrandeis/orgs", "repos_url": "https://api.github.com/users/SBrandeis/repos", "events_url": "https://api.github.com/users/SBrandeis/events{/privacy}", "received_events_url": "https://api.github.com/users/SBrandeis/received_events", "type": "User", "site_admin": false } ]

[]

[]

[]

[ "@lhoestq done! ;)" ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[ "Errors are in the CI are not related to this PR (RemoteDatasetError)\r\nthe CI is fixed on master so it's fine ", "@lhoestq Added the dataset card. Please let me know if more information needs to be added." ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[ "hope this works.." ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[ "@lhoestq reduced the dummy data size to around 19MB in total and added the dataset card.", "@lhoestq so I ended up removing all the nested JSON objects in the gz datafile and keep only one object with minimal content: `{\"publication_number\": \"US-8230922-B2\", \"abstract\": \"dummy abstract\", \"application_number\": \"US-201113163519-A\", \"description\": \"dummy description\"}`. \r\n\r\nThey're reduced to 35KB in total (2.5KB per domain and 17.5KB for all domains), hopefully, they're small enough." ]

[]

[]

[ "> Thanks for adding this one !\r\n> \r\n> I left a few comments\r\n> \r\n> after the change you'll need to regenerate the dataset_infos.json file as well\r\n\r\ndataset_infos.json regenerated", "looks like this PR includes changes to many files other that the ones for CDT\r\ncould you create another branch and another PR please ?" ]

[]

[]

[ "Ready for review" ]

[]

[]

[]

[]

[]

[ "Will slim down the dummy files in the morning" ]

[]

[]

[ "merging since the CI is fixed on master" ]

[]

[]

[]

[]

[]

[ "Dataset card added, so ready for review!" ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[ "pan" ]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[]

[ "This one will make @thomwolf reminisce ;)", "Merging." ]

[]

[]

[]

[]

[]

[ "LGTM! ftp addition looks fine but maybe have a look @thomwolf ?", "It's not finished yet, I need to run the tests on the full dataset (it was running this weekend, there is an error somewhere deep)\r\n", "@yjernite Ready for review !\r\n@thomwolf \r\n\r\nSo I tried to follow closely the original format that means I still had to drop information (namely tags on elements are simply discarded for now but they don't seem to carry critical information).\r\nSome elements are also discarded they tend to not come up often:\r\n - The most notable is Author affiliation, which seems to be all over the place in terms of what it look meaning it's hard to actually get a consistent format.\r\n - Journal is the same, all the elements in there can be wildly different so I decided to drop it for now instead of trying to figure out a way to have a common presentation. (the DOI and medline ID are present so it can be recovered).\r\n\r\nI think this PR could go as it but we probably should add a way to get easier information to use with a config.\r\nFor instance `{\"title\": \"string\", \"abstract\": \"string\", \"authors\": List[str], \"substances\": List[str]}` maybe ? (substances for instance is a tricky one, some substances only have an international identifier, some have simply a common name, some both)\r\n\r\nIt's relatively easy to do I think it's mostly discarding other fields and renaming some deep structure into a flat one.", "Look ok to me but @lhoestq is the master on the Download Manager side" ]

[]

[]

[]

[]

[]

[ "I just saw your PR actually ^^", "> I just saw your PR actually ^^\r\n\r\nSomehow that still doesn't work, lmk if you have any ideas.", "Did you rebase from master ?" ]

[]

[]

[]

[ { "id": 1935892857, "node_id": "MDU6TGFiZWwxOTM1ODkyODU3", "url": "https://api.github.com/repos/huggingface/datasets/labels/bug", "name": "bug", "color": "d73a4a", "default": true, "description": "Something isn't working" }, { "id": 1935892871, "node_id": "MDU6TGFiZWwxOTM1ODkyODcx", "url": "https://api.github.com/repos/huggingface/datasets/labels/enhancement", "name": "enhancement", "color": "a2eeef", "default": true, "description": "New feature or request" } ]

[]

[ "Hi !\r\nThis kind of links is now supported by the library since #1316", "> Hi !\r\n> This kind of links is now supported by the library since #1316\r\n\r\nI updated links in TLC datasets to be the github links in this pull request \r\n https://github.com/huggingface/datasets/pull/1737\r\n\r\nEverything works now. Thank you." ]

[]

[]

[ "merging since the CI is fixed on master" ]

[]

[]

[ "Nice thank you !\r\nCan you regenerate the dataset_infos.json file ? Since we changed the features we must update it\r\n\r\nThen I think we'll be good to merge :)" ]

[]

[]

[]

[]